[Koha-bugs] [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #30)
> In MarkIssueReturned we crash if AnonymousPatron is not set to a valid
> borrowernumber. Here we are setting it to NULL. Both behaviours must be
> identical.

I agree with this proposal. I had doubts myself. My approach was to not change
the behavior and I was using (basically) what is done in
Koha::Patrons->anonymise_issue_history. That's where I picked the fallback to
NULL idea from.

I would keep things like this on this bug tree, so testers can verify no
behavior change takes place. And will happily file a bug for this proposed
behavior change, along with removing the (now) unused anonymise_issue_history
method.

With this fully tested and reused single place piece of code, the tweak will be
trivial to implement. Let's get this through QA.

-- 
You are receiving this mail because:
You are watching all bug changes.