From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 06:41:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 04:41:54 +0000
Subject: [Koha-bugs] [Bug 31064] Local login is difficult to style using CSS
In-Reply-To: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31064-70-D97EIKbiqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Fridolin Somers from comment #5)
> Trivial but very useful, PQA
> 
> BTW : a class on <h3>Local login</h3> would also be very useful.

I was thinking that too. Once this one is in, I could do another patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:37:30 +0000
Subject: [Koha-bugs] [Bug 31075] New: Script overdue_notices.pl should use
 GetPreparedLetter
Message-ID: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

            Bug ID: 31075
           Summary: Script overdue_notices.pl should use GetPreparedLetter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

The overdue_notices.pl script contains a lot of code for letter/notice handling
that really should not be there. Some regular notice constructs do not work
since it is doing its own thing.
Look at this example:

                    my $letter = parse_overdues_letter(
                        {   letter_code     => $overdue_rules->{"letter$i"},
                            borrowernumber  => $borrowernumber,
                            branchcode      => $branchcode,
                            items           => \@items,
                            substitute      => {    # this appears to be a hack
to overcome incomplete features in this code.
                                                bib             =>
$library->branchname, # maybe 'bib' is a typo for 'lib<rary>'?
                                                'items.content' => $titles,
                                                'count'         => $itemcount,
                                               },
                            # If there is no template defined for the requested
letter
                            # Fallback on the original type
                            message_transport_type => $letter_exists ?
$effective_mtt : $mtt,
                        }
                    );

The comment talks about a hack to overcome incomplete features.
I did mark this as major, and not enhancement for refactoring.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:37:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:37:53 +0000
Subject: [Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send
 an attachment as HTML
In-Reply-To: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29354-70-oDLjdReYkl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31075

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:37:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:37:53 +0000
Subject: [Koha-bugs] [Bug 31075] Script overdue_notices.pl should use
 GetPreparedLetter
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-zScc78JP3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29354

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:38:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:38:13 +0000
Subject: [Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send
 an attachment as HTML
In-Reply-To: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29354-70-UK5WNTSNK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I opened bug 31075 for a wider scope

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:46:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:46:28 +0000
Subject: [Koha-bugs] [Bug 31075] Script overdue_notices.pl should use
 GetPreparedLetter
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-SCbBdIVaVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
ccing Nick Tomas Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:51:09 +0000
Subject: [Koha-bugs] [Bug 31075] Script overdue_notices.pl should use
 GetPreparedLetter
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-eYvAwyVCED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Lowering severity because I just now see that  parse_overdues_letter does call
GetPreparedLetter after all.
This code really needs to be improved. Obscure stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 08:52:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 06:52:38 +0000
Subject: [Koha-bugs] [Bug 31075] Obscure notice handling in
 overdue_notices.pl needs to be improved
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-8fQPXe3hxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Script overdue_notices.pl   |Obscure notice handling in
                   |should use                  |overdue_notices.pl needs to
                   |GetPreparedLetter           |be improved

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:11:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:11:27 +0000
Subject: [Koha-bugs] [Bug 31061] OPACSuppress does not work properly with
 Elasticsearch
In-Reply-To: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31061-70-bi8ToGPG3j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ah indeed seems to be a code that convert 'perl boolean' value into true/false
:
https://git.koha-community.org/Koha-community/Koha/src/commit/6c315c164dbcf3e05fcfe4a3110b824ab3ac162c/Koha/SearchEngine/Elasticsearch.pm#L950

I need to test again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:24:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:24:36 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-yAYwr7f9nl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

--- Comment #1 from Isobel Graham <isobel.graham09 at gmail.com> ---
Created attachment 136798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136798&action=edit
Bug 30619: Add email receipt to POS

This patch adds the ability to use email receipts with the point of sale
module.

To test:
1) Configure your Koha to enable the point of sale system.
2) Add an email template to the 'Point of sale > RECEIPT' notice.
3) Add some charges on point of sale and pay for them.
3a) You should now see a new 'Email receipt' button next to the 'Print
receipt' option.
3b) Clicking the button will display a modal to enter the anonymous
users email address
3c) Enter an email address and confirm to send the email

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:26:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:26:50 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-iF6rQXmifI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:27:02 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-vrc4v6TsZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:52:11 +0000
Subject: [Koha-bugs] [Bug 31075] Obscure notice handling in
 overdue_notices.pl needs to be improved
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-qdIquT15IM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This whole stuff with loops, repeat, substitute in old and new style with or
without enclosing tag is such a mess !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 09:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 07:54:37 +0000
Subject: [Koha-bugs] [Bug 31075] Obscure notice handling in
 overdue_notices.pl needs to be improved
In-Reply-To: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31075-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31075-70-wbcAIJsJUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
A librarian changed a few notices, and I just had a 'diagonal glance' over
them. They looked good, but didnt work finally ;)

But resolving it, almost needs debugging Letters and Overdues code. No Koha
advertising..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:26:18 +0000
Subject: [Koha-bugs] [Bug 31061] OPACSuppress does not work properly with
 Elasticsearch
In-Reply-To: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31061-70-lwxFuDyVQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061

--- Comment #6 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ahhhhh now that I've retested with KTD, indeed it works.
Maybe my search was too faster after unhiding record with 942$n=0.

> But a boolean for Elasticsearch is not a perl boolean.
Ouf its is thanks to a trick in the code.

I will change patches in order to only change to : NOT(suppress:true)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:40:30 +0000
Subject: [Koha-bugs] [Bug 31061] OPACSuppress does not work properly with
 Elasticsearch
In-Reply-To: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31061-70-VFMgoIfQCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136695|0                           |1
        is obsolete|                            |
 Attachment #136696|0                           |1
        is obsolete|                            |
 Attachment #136697|0                           |1
        is obsolete|                            |

--- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 136799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136799&action=edit
Bug 31061: OPACSuppress behavior with Elasticsearch

OPACSuppress is system preference to hide records in OPAC search by adding a
limit in search query.

With Zebra, this limit is : not Suppress=1
https://git.koha-community.org/Koha-community/Koha/src/commit/244b847a08bf61a747a1e4be4eed86cc776eabd6/Koha/SearchEngine/Zebra/QueryBuilder.pm#L83
With Elasticsearch this limit is currently quite different : suppress:false
https://git.koha-community.org/Koha-community/Koha/src/commit/244b847a08bf61a747a1e4be4eed86cc776eabd6/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L286

We whould like to have several MARC fields with 'suppress' search field.
To distinguish several causes of hidden at OPAC.
Any of those fields having 1 must hide at OPAC.
Syntax 'NOT(suppress:true)' does that, like with Zebra.

Test plan :
1) Use search engine Elasticsearch
2) Disable system preference OpacSuppression
3) Search in OPAC for all records : '*:*'
     => Note how many results
4) Enable system preference OpacSuppression
5) Edit a biblio record with 942$n set to YES
6) Search in OPAC for all records : '*:*'
     => Note how many results, you should have 1 less than 3)
7) Edit a biblio record with 942$n set to NO
8) Search in OPAC for all records : '*:*'
     => Note how many results, you should have same number as 3)
9) Edit a biblio record to remove 942$n
10) Search in OPAC for all records : '*:*'
     => Note how many results, you should have same number as 3)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:41:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:41:03 +0000
Subject: [Koha-bugs] [Bug 31061] OPACSuppress behavior with Elasticsearch
In-Reply-To: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31061-70-pXvN033iQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31061

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPACSuppress does not work  |OPACSuppress behavior with
                   |properly with Elasticsearch |Elasticsearch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:50:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:50:33 +0000
Subject: [Koha-bugs] [Bug 31076] New: Bug 22605 breaks date of publication
 range search
Message-ID: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

            Bug ID: 31076
           Summary: Bug 22605 breaks date of publication range search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com

Bug 22605 changed in staff interface the date of publication limit :
       - $limit_yr = "yr,st-numeric=$params->{'limit-yr'}";
       + $limit_yr = "yr,st-numeric:$params->{'limit-yr'}";

This breaks the range search on date of publication which is a special case in
QueryBuilder :
https://git.koha-community.org/Koha-community/Koha/src/commit/6c315c164dbcf3e05fcfe4a3110b824ab3ac162c/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L1058

Maybe juste allow ":" or "=" :
  my ($date) = ( $l =~ /^yr,st-numeric[=:](.*)$/ );

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:50:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:50:39 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-TCZBw6weCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:50:54 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-fnTUPbqTll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22605


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605
[Bug 22605] Adding the option to modify/edit searches on the staff interface
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 10:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 08:50:54 +0000
Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches
 on the staff interface
In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22605-70-lw99pNpQkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31076


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076
[Bug 31076] Bug 22605 breaks date of publication range search
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:04:55 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-CXkHm6OicO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136800&action=edit
Bug 30619: Add sample email notice

This patch adds a default same email type notice for the point of sale
receipt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:06:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:06:48 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-HyaX6Z3rpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Isobel, great work.

I've added a follow-up patch to set the default email notice template for you.

Test plan wise, this can be easily tested using the sandboxes.

Follow the plan and then you can spot that the email has been sent using the
Koha Mail Log available from the sandbox management UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:07:00 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-tBO193KZXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:08:46 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-taeogfz8G3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Seeking sponsor             |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:10:51 +0000
Subject: [Koha-bugs] [Bug 29919] Elasticsearch missing alias pl for
 place-of-publication
In-Reply-To: <bug-29919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29919-70-7ihkmchjsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29919

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Ahhhh indeed.
Search field name is 'pl' in search engine config (also with Zebra) and in TT.

So we have to rename in our ES config.
I've seen 'place-of-publication' only once in code :

DBRev 18.12.00.018 :
  $dbh->do( "UPDATE `search_field` SET `name` = 'place-of-publication', `label`
= 'place-of-publication' WHERE `name` = 'place'" );

But this search field does not exist in mappings.yaml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:11:18 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-aXyKhqthh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136798|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136801&action=edit
Bug 30619: Add email receipt to POS

This patch adds the ability to use email receipts with the point of sale
module.

To test:
1) Configure your Koha to enable the point of sale system.
2) Add an email template to the 'Point of sale > RECEIPT' notice.
3) Add some charges on point of sale and pay for them.
3a) You should now see a new 'Email receipt' button next to the 'Print
receipt' option.
3b) Clicking the button will display a modal to enter the anonymous
users email address
3c) Enter an email address and confirm to send the email

Sponsored-by: Martin Renvoize <martin.renvoize at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:11:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:11:21 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-XkXqjCvhnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136800|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136802&action=edit
Bug 30619: Add sample email notice

This patch adds a default same email type notice for the point of sale
receipt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:23:46 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-JcJ3DY2Wkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
My plan was somehting like this (unfinished on itself):
Still had to set the flag when I found a https ref.
And check for commented refs.
But this is just way too much imo.


sub _convert_https {
    my ( $self, $code, $key, $params ) = @_;
    my $level = $params->{level} // 0; # to limit recursion level

    if( $level > $self->max_recursion_level ) {
        die; #FIXME Exception
    }

    # Find refs and resolve recursively
    my ( $href, $tmp_name, $new_code, $flag, @replaces, $changed );
    while( $code =~
/<(?:xsl):(?:import|include)\s*href\s*=\s*['"]([^'"]+)['"]/gcs ) {
        $href = $1;
        if( $include_cache->{$href} ) {
            $new_code = $include_cache->{$href};
            $changed = 1;
        } else {
            $new_code = $self->_get_code( $href );
            ( $new_code, $flag )  = $self->_convert_https( $new_code, $href, {
level => $level + 1 } );
            $changed = 1 if $flag;
        }
        next unless $changed;
        $tmpname = MIME::Base64::encode_base64url( $href, q{} );
        if( !$self->{_tempdir} || !-e $self->{_tempdir}. '/'. $tmpname ) {
            $self->{_tempdir} //= File::Temp->newdir;
            write_file( $self->{_tempdir}. '/'. $tmpname, { binmode => ':utf8'
}, Encode::encode_utf8($new_code) );
        }
        push @replaces, { href => $href, file => $self->{_tempdir}. '/'.
$tmpname };
    }

    # Replace refs
    foreach my $h ( @replaces ) {
        $code =~
s/(?=<(?:xsl):(?:import|include)\s*href\s*=\s*)(['"])${h->{href}}['"]/$1${h->{file}}$1/;
    }

    # Finalize
    $include_cache->{$key} = $code if !$self->disable_caching && $changed &&
$key;
    return ( $code, $changed // 0 );
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 11:25:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 09:25:39 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-lEY6LW9U1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
So let me stick to the original partial approach and only fix the https ref at
the file level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 12:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 10:28:43 +0000
Subject: [Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a
 transaction'
In-Reply-To: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29325-70-8QBJlNzPQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325

--- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136803&action=edit
Bug 29325: [21.11.x] Fix commit_file.pl

This patch fixes the broken commit_file.pl script.

It doesn't deal with commiting the import from the UI.

To test:
1. Pick a file for staging:
   $ kshell
  k$ misc/stage_file.pl --file TestDataImportKoha.mrc
=> SUCCESS: All good
2. Commit!
  k$ misc/commit_file.pl --batch-number 1
=> FAIL: You see
DBIx::Class::Storage::DBI::_exec_txn_begin(): DBI Exception: DBD::mysql::db
begin_work failed: Already in a transaction at /kohadevbox/koha/C4/Biblio.pm
line 303
3. Apply this patch
4. Repeat 2
=> SUCCESS: Commit succeeds
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 29325: (QA follow-up) Remove unexisting parameters of BatchRevertRecords

There is no interval and callback as in BatchCommitRecords.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 29325: Call progress callback one last time to confirm comppletion

Previously after finishing the loop we were still in a transaction that never
completed - we should report progress when done
one final time to commit the last records

To test:
1 - Stage a file with > 100 records
2 - Commit file
3 - Confirm batch is imported and no records left as staged

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 29325: Fix import from staff client

same test as before, but via the staff client

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Bug 29325: Handle the transaction in BatchCommitRecords

Requiring the callback to commit was breaking reversion, and likely elsewhere

Let's simplify and say that the routine iteself will handle the txn and commit

TO test:
1 - Stage a file
2 - Import a file
3 - Revert a file
4 - Test staff client and command line

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 29325: (QA follow-up) Tidy up

tools/manage-marc-import.pl: sub commit_batch does no longer need $schema
tools/manage-marc-import.pl: sub revert_batch: calling BatchRevertRecords which
has no interval and callback
misc/commit_file.pl: sub print_progress_and_commit does no longer commit,
renamed
misc/commit_file.pl: sub print_progress does no longer have a schema parameter
misc/commit_file.pl: sub revert_batch reported deleted items as added

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 12:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 10:31:44 +0000
Subject: [Koha-bugs] [Bug 30730] Holds to Pull should not list items with a
 notforloan status
In-Reply-To: <bug-30730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30730-70-YAhazMIA9X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30730

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:02:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:02:29 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-HKtg6zlTOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Nind from comment #10)
> I noted when testing that the "Place hold" button is also not displayed when
> the "If any unavailable" option is selected. I assume that this is OK - I've
> never really got my head around this setting!

It's awkward language, it boils down to "If I could walk into the library and
each of the items on this record are something I could check out right now,
don't allow holds." So if I have 10 items on a record, and all down are able to
be checked out, don't allow holds. But, if even one is checked out, allow
holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:05:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:05:36 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-0sLx3gEE0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:14:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:14:35 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-LWQ8UMuOyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:14:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:14:38 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-wQsLsTqoD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136805&action=edit
Bug 31076: Handle year limits with equal sign or colon

To test:
1 - Enable ES and index
2 - Set expandedSearchOption to 'show'
3 - Advanced search on staff and opac using Year field on staff and Publication
date range on OPAC for:
    2005
    2005-
    -2005
    <2005
    >2005
    2005-2010
4 - Confirm ranges don't work on staff side, but do on opac
5 - Apply patch
6 - Repeat searches - they work on both staff and opac
7 - prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:15:04 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-ddWIbodmCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:30:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:30:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-9ZqkDveKaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:38:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:38:59 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-JtAzZrMq5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #274 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136806&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:39:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:39:06 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-nFfbmKpq3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:39:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:39:10 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-TNt4f3WfyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135389|0                           |1
        is obsolete|                            |
 Attachment #135931|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136807&action=edit
Bug 30025: Split BiblioAddsAuthorities into two sysprefs

This patch adds two new sysprefs:
AutoLinkBiblios
AllowManualAuthorityEditing

Both inherit the setting from BiblioAddsAuhtorities which is removed

To test:
1 -Apply patches
2 - Update database
3 - Confirm old setting is transferred to new option
4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing
set to allow
5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing
set to don't allow
6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set
AllowManualAuthorityEditing to add unlinked heading)
7 - Confirm new bib notlinked when AutoLinkBiblios is disabled
8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading
doesn't match an authority and  AutoCreateAuthorities is disabled
9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but
heading doesn't match an authority and  AutoCreateAuthorities is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:39:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:39:16 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-Rzl1c1m6SJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136808&action=edit
Bug 30025: DB update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:54:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:54:33 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-mclj9QHxdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Quick and dirty perf testing, one page load per:

500 Items
Pre-patch
ISBD: 2.5
MARC: 6.21
Details: 4.51

Post-patch
ISBD: 2.84
MARC: 6.15
Details: 5.86

3000 Items
Pre-patch
ISBD: 6.28
MARC: 25.32
Details: 23.48

Post-patch
ISBD: 6.07
MARC: 25.55
Details: 23.51

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 13:56:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 11:56:24 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ERDqPlvU9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |solene.desvaux at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kRmBV1A8gI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136613|0                           |1
        is obsolete|                            |

--- Comment #275 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136809&action=edit
Bug 28854: Database update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:11 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-E4ZupxQ0ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #1 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136810&action=edit
Bug 30952: added new icons and main scss files

also touch includes files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:14 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-WOICOk7FId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136614|0                           |1
        is obsolete|                            |

--- Comment #276 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136811&action=edit
Bug 28854: DBIC Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:16 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-DMtu094POG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #2 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136812&action=edit
Bug 30952: Catalogue module restyling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:21 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vsrIqvqQd5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #3 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136813&action=edit
Bug 30952: Cataloguing Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:25 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mY74KqyENo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #4 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136815&action=edit
Bug 30952: Acquisition Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:24 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ZtLmSZlaKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136615|0                           |1
        is obsolete|                            |

--- Comment #277 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136814&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:29 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-if97fcane5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #5 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136816&action=edit
Bug 30952: Admin Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:34 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-IDM8g8TmRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #6 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136818&action=edit
Bug 30952: Auth template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-OOQKvfV74H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136616|0                           |1
        is obsolete|                            |

--- Comment #278 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136817&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:38 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-xTngalxSPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #7 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136819&action=edit
Bug 30952: Authority module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:42 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-X0IhCERbEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #8 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136820&action=edit
Bug 30952: Circulation Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:43 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dU5grsH8ty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136617|0                           |1
        is obsolete|                            |

--- Comment #279 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136821&action=edit
Bug 28854: Highlight bundle rows to clarify UI

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:49 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-aAvO6SfnZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #9 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136822&action=edit
Bug 30952: Intranet main page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:54 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ftIlxDMvKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #10 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136823&action=edit
Bug 30952: Labels Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pLvz15W8FD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136618|0                           |1
        is obsolete|                            |

--- Comment #280 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136824&action=edit
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:06:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:06:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-JxejfXMnsd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #11 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136825&action=edit
Bug 30952: Patrons Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-TTywwNDfir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #12 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136827&action=edit
Bug 30952: Plugins Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dXReSGRjVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136619|0                           |1
        is obsolete|                            |

--- Comment #281 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136826&action=edit
Bug 28854: DBIC Update ReturnClaim Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LaBdPJLnSA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #13 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136828&action=edit
Bug 30952: Suggestions Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:14 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-wenBqRIrd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #14 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136830&action=edit
Bug 30952: Tools Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:13 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-USaghtcNVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136620|0                           |1
        is obsolete|                            |

--- Comment #282 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136829&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:24 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-QqCaMf6hqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #15 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136831&action=edit
Bug 30952: Virtualshelves Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:29 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-8ZK4NdBG72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #16 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136833&action=edit
Bug 30952: Serials Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kvyYNXRTyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136621|0                           |1
        is obsolete|                            |

--- Comment #283 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136832&action=edit
Bug 28854: Simplified status handling for bundle inventory check

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-4KhIn8HBwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #17 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136834&action=edit
Bug 30952: Reports Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:37 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-f8AFCZ6bGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136622|0                           |1
        is obsolete|                            |

--- Comment #284 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136835&action=edit
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:40 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-KD6KIeiI3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #18 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136836&action=edit
Bug 30952: Search bar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:45 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-AKuachMg98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #19 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136837&action=edit
Bug 30952: add generated css files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:47 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-JYHlahUCza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136623|0                           |1
        is obsolete|                            |

--- Comment #285 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136838&action=edit
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:51 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-WHjqYgmRoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #20 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136839&action=edit
Bug 30952: update css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:56 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-NhdbOfJSO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #21 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136840&action=edit
Bug 30952: update include

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:07:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:07:56 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-QLuqFRx3dt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136624|0                           |1
        is obsolete|                            |

--- Comment #286 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136841&action=edit
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-7mms0LTGrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #22 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136842&action=edit
Bug 30952: update patron and suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:06 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-1s95MOlUlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #23 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136844&action=edit
Bug 30952: update search-engine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-TZHDu2xPVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136625|0                           |1
        is obsolete|                            |

--- Comment #287 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136843&action=edit
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:12 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-iSo6AwWWkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #24 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136845&action=edit
Bug 30952: correction includes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:16 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-zOOSvcs9I8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136626|0                           |1
        is obsolete|                            |

--- Comment #288 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136846&action=edit
Bug 28854: Highlight when a scanned item is unexpected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:17 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-U8XrixDcvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #25 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136847&action=edit
Bug 30952: update request

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-FuMLl4LSoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #26 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136848&action=edit
Bug 30952: update circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:24 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-gS5g2ofGIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136627|0                           |1
        is obsolete|                            |

--- Comment #289 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136849&action=edit
Bug 28854: Add count of scanned items to verification modal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-tychqldkJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136628|0                           |1
        is obsolete|                            |

--- Comment #290 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136850&action=edit
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:39 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7uoWtU7FMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136629|0                           |1
        is obsolete|                            |

--- Comment #291 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136851&action=edit
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-8dp5A03TNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136630|0                           |1
        is obsolete|                            |

--- Comment #292 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136852&action=edit
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:08:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7sJfY2Eqqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136631|0                           |1
        is obsolete|                            |

--- Comment #293 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136853&action=edit
Bug 28854: Make barcode comparison case insensative

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-E8zkGNsnni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136632|0                           |1
        is obsolete|                            |

--- Comment #294 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136854&action=edit
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-asYsN75xVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136633|0                           |1
        is obsolete|                            |

--- Comment #295 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136855&action=edit
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-rFJ1s0J2JH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136634|0                           |1
        is obsolete|                            |

--- Comment #296 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136856&action=edit
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Ze3JvPtQWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136635|0                           |1
        is obsolete|                            |

--- Comment #297 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136857&action=edit
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:35 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-p3VPhzY8Pc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136636|0                           |1
        is obsolete|                            |

--- Comment #298 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136858&action=edit
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:44 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-4INFqpmJgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136637|0                           |1
        is obsolete|                            |

--- Comment #299 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136859&action=edit
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:09:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:09:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-cBKi8v05T1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136638|0                           |1
        is obsolete|                            |

--- Comment #300 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136860&action=edit
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-waGeRMN663@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136639|0                           |1
        is obsolete|                            |

--- Comment #301 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136861&action=edit
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:10 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-frsxOlgEhl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136640|0                           |1
        is obsolete|                            |

--- Comment #302 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136862&action=edit
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-m8wgdx6jck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136641|0                           |1
        is obsolete|                            |

--- Comment #303 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136863&action=edit
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ldjXMUYAPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136642|0                           |1
        is obsolete|                            |

--- Comment #304 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136864&action=edit
Bug 28854: (follow-up) Improve error for item not found

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dSBN1n4ek6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136643|0                           |1
        is obsolete|                            |

--- Comment #305 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136865&action=edit
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Xh1rcQ0iyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136644|0                           |1
        is obsolete|                            |

--- Comment #306 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136866&action=edit
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:51 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-i3gfW6bVXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136645|0                           |1
        is obsolete|                            |

--- Comment #307 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136867&action=edit
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:10:58 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-9HBUazUl9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136646|0                           |1
        is obsolete|                            |

--- Comment #308 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136868&action=edit
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:08 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-K2QBoq8gNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136648|0                           |1
        is obsolete|                            |

--- Comment #309 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136869&action=edit
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:15 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-qJTsbKygml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136649|0                           |1
        is obsolete|                            |

--- Comment #310 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136870&action=edit
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-JY68wR6F5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136650|0                           |1
        is obsolete|                            |

--- Comment #311 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136871&action=edit
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:31 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wTq6AmWvwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136651|0                           |1
        is obsolete|                            |

--- Comment #312 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136872&action=edit
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:39 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nbRFoFWnTb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136652|0                           |1
        is obsolete|                            |

--- Comment #313 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136873&action=edit
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:11:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:11:51 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-fmBwyd0JNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136654|0                           |1
        is obsolete|                            |

--- Comment #314 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136874&action=edit
Bug 28854: (follow-up) Prevent stringification of null in return claims

The return claims table was stringifying 'null'. This patch updates the
code to check for definition so we don't stringify incorrectly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:12:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:12:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-r2GtFBUVpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136655|0                           |1
        is obsolete|                            |

--- Comment #315 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136875&action=edit
Bug 28854: (follow-up) Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:12:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:12:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-hRNaX76vJo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136806|0                           |1
        is obsolete|                            |

--- Comment #316 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136876&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:12:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:12:16 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ROJEoHVs9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #317 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136877&action=edit
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:12:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:12:53 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-hSBqX7J46G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136647|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:19:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:19:43 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-4OCy6XRsdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
3000 Items
Post-patch, rule = "If any unavailable"
ISBD: 27.01
MARC: 44.76
Details: 43.51

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:05 +0000
Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to
 ensure non-public notes do not leak
In-Reply-To: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30744-70-SB35fowKZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:09 +0000
Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to
 ensure non-public notes do not leak
In-Reply-To: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30744-70-65Dgay84nm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:12 +0000
Subject: [Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
In-Reply-To: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30848-70-JEiAb2Q9Zr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:15 +0000
Subject: [Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
In-Reply-To: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30848-70-yWQWzWsj4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848

--- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:18 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-gtfOec6Qll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:21 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-3NYMcNGVVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

--- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:24 +0000
Subject: [Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title
 Notes tab
In-Reply-To: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30918-70-OkYJZZAYLR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:20:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:20:26 +0000
Subject: [Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title
 Notes tab
In-Reply-To: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30918-70-Cu0B4OOlyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:22:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:22:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-xlcnKs1i8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Solene D from comment #25)
> Created attachment 136847 [details] [review]
> Bug 30952: update request

There have been incorrect merge conflict fixed in this patch.

At least:
* badBibs has been removed by bug 30742
* Removal of "PROCESS patron_search_js" looks wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:23:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:23:05 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-c2Pvy8k5zB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
It appears that this patch definitely has a noticeable effect on page loads at
scale. 

The most immediate blocker at this point is a lack of unit tests for the
changes to the Perl modules. Please provide unit tests for the changes to
CanBookBeReserved and IsAvailableForItemLevelRequest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:44:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:44:48 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-7WsmwjHfML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136810|0                           |1
        is obsolete|                            |

--- Comment #28 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136878&action=edit
Bug 30952: added new icons and main scss files

also touch includes files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:44:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:44:53 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-GiLm4sRrwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136812|0                           |1
        is obsolete|                            |

--- Comment #29 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136879&action=edit
Bug 30952: Catalogue module restyling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:44:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:44:57 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-PNujzaPiYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136813|0                           |1
        is obsolete|                            |

--- Comment #30 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136880&action=edit
Bug 30952: Cataloguing Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-qtGlrxrBdF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136815|0                           |1
        is obsolete|                            |

--- Comment #31 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136881&action=edit
Bug 30952: Acquisition Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:06 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-jECwBdwzbT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136816|0                           |1
        is obsolete|                            |

--- Comment #32 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136882&action=edit
Bug 30952: Admin Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:11 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-8Dcmgj6h0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136818|0                           |1
        is obsolete|                            |

--- Comment #33 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136883&action=edit
Bug 30952: Auth template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:15 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vwaTONJHnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136819|0                           |1
        is obsolete|                            |

--- Comment #34 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136884&action=edit
Bug 30952: Authority module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:19 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-tXxR9MbTRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136820|0                           |1
        is obsolete|                            |

--- Comment #35 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136885&action=edit
Bug 30952: Circulation Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:24 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-l0cTAkmBXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136822|0                           |1
        is obsolete|                            |

--- Comment #36 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136886&action=edit
Bug 30952: Intranet main page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:28 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-dAYy8rKzYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136823|0                           |1
        is obsolete|                            |

--- Comment #37 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136887&action=edit
Bug 30952: Labels Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:32 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-FpKUTlELuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136825|0                           |1
        is obsolete|                            |

--- Comment #38 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136888&action=edit
Bug 30952: Patrons Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:36 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vYFzFQTk2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136827|0                           |1
        is obsolete|                            |

--- Comment #39 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136889&action=edit
Bug 30952: Plugins Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:41 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-VsYFGRfRCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136828|0                           |1
        is obsolete|                            |

--- Comment #40 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136890&action=edit
Bug 30952: Suggestions Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-RFbdDfcff4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136830|0                           |1
        is obsolete|                            |

--- Comment #41 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136891&action=edit
Bug 30952: Tools Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:51 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-IGXzrzclW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136831|0                           |1
        is obsolete|                            |

--- Comment #42 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136892&action=edit
Bug 30952: Virtualshelves Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:54 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-MffMriLW3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136833|0                           |1
        is obsolete|                            |

--- Comment #43 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136893&action=edit
Bug 30952: Serials Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:45:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:45:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-t7JNJcHRSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136834|0                           |1
        is obsolete|                            |

--- Comment #44 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136894&action=edit
Bug 30952: Reports Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-hgQ9imF1D6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136836|0                           |1
        is obsolete|                            |

--- Comment #45 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136895&action=edit
Bug 30952: Search bar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:08 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LR5zjBEWEw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136840|0                           |1
        is obsolete|                            |

--- Comment #46 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136896&action=edit
Bug 30952: update include

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:13 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-eMi4ZG0LQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136842|0                           |1
        is obsolete|                            |

--- Comment #47 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136897&action=edit
Bug 30952: update patron and suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-3KNscheGO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136844|0                           |1
        is obsolete|                            |

--- Comment #48 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136898&action=edit
Bug 30952: update search-engine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-rh9YA0dAxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136845|0                           |1
        is obsolete|                            |

--- Comment #49 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136899&action=edit
Bug 30952: correction includes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:26 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-zH4ZQABaKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136847|0                           |1
        is obsolete|                            |

--- Comment #50 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136900&action=edit
Bug 30952: update request

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:30 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ZD2HhJ1Hd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136848|0                           |1
        is obsolete|                            |

--- Comment #51 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136901&action=edit
Bug 30952: update circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:46:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-oRBgzNC5ZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #52 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136902&action=edit
Bug 30952: css generation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:52:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:52:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-Ha0gxwlpmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 14:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 12:52:36 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-QdCOZ7FY2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136837|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:00:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:00:41 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-2K2tDRwfo3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #17 from Kevin Carnes <kevin.carnes at ub.lu.se> ---
(In reply to Caroline Cyr La Rose from comment #16)
> I tried to test, but I am unable to get the original "problematic" behaviour.
> 
> My rules are as follows:
> Patron category: Teacher
> Item type: Books
> Current checkouts allowed: 10
> Current on-site checkouts allowed: 10
> Loan period: 10
> Hard due date: None defined
> (I didn't fill out anything else)
> 
> Patron category: Teacher
> Item type: All
> Current checkouts allowed: 10
> Current on-site checkouts allowed: 10
> Loan period: 10
> Hard due date : Exactly on 2022-06-30
> (I didn't fill out anything else)
> 
> I also have the All/All rule that comes with a sandbox
> Patron category: All
> Item type: All
> Current checkouts allowed: 5
> Current on-site checkouts allowed: 5
> Loan period: 5
> Hard due date: None defined
> (etc.)
> 
> I checked out 39999000003857 (item-level itype = Music) to 23529000139858,
> and the due date was 2022-06-30 (today)
> I checked out 39999000010114 (item-level itype = Books) to the same patron
> and the due date was 2022-07-10 (ten days from now)
> 
> I'm not sure what I did differently than the test plan.

I tested this on the master branch and received the hard due date for both
items. Was the patch for this bug ever applied on the sandbox? If the rules
were created when the patch was applied, that would explain your results.

You can try deleting the teacher rules and adding them again. You can also try
testing it on another sandbox without any patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:06:57 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-8suLlwYkLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:07:00 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-CxQu4YxtHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136445|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136903&action=edit
Bug 31017: Add new vendor_type field to edit screen and display

This patch adds a new vendor_type field when creating/editing vendors
and displays the field on search and details for a vendor

To test:
 1 - Apply patch, update database
 2 - Edit/create a vendor in acquisitions
 3 - Note new 'Vendor type' field, free text in editor
 4 - Save a value
 5 - Confirm it displays in vendor search results and vendor main page
 6 - In Authorised values add a new value to 'VENDOR_TYPE' category
 7 - Confirm the description of VENDOR_TYPE shows and makes sense
 8 - Add/Edit a vendor, note the vendor type is now a dropdown selection
 9 - Save with a value
10 - Confirm the description shows in results and vendor page and vendor
details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:07:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:07:30 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ILDDGyG2pk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:27:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:27:35 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-maVDMrjqTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

--- Comment #43 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The error in the tests highlights an issue: existing jobs might not have
'context' set. We need to deal with those more gracefully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:32:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:32:34 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-opUQ8tD0EX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 136904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136904&action=edit
Bug 30889: (follow-up) Warn if context is not defined

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:35:59 +0000
Subject: [Koha-bugs] [Bug 31077] New: Return claims won't load on details
 tab, when ClaimReturnedLostValue is empty
Message-ID: <bug-31077-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31077

            Bug ID: 31077
           Summary: Return claims won't load on details tab, when
                    ClaimReturnedLostValue is empty
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When ClaimReturnedLostValue is empty, the tab with the number of open claims
will show both on the checkouts and the details tab of the patron account in
the staff interface, but on details, nothing will display when the tab is
opened.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:36:30 +0000
Subject: [Koha-bugs] [Bug 31077] Return claims won't load on details tab,
 when ClaimReturnedLostValue is empty
In-Reply-To: <bug-31077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31077-70-6GKR0b0PxJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28854

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:36:30 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-IQ7F1zQLva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31077

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:37:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:37:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-FEtHkMOpfH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Please see comment 27. I think some merge conflicts haven't been resolved
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:07 +0000
Subject: [Koha-bugs] [Bug 31078] New: Lost status different to 1 don't show
 with description in bundle detail view
Message-ID: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078

            Bug ID: 31078
           Summary: Lost status different to 1 don't show with description
                    in bundle detail view
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When a return claim for a bundle item is resolved into another status than "not
lost", the lost status description will only show as the number on the bundle
detail view.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:07 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kWD9vvI3EJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31078


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078
[Bug 31078] Lost status different to 1 don't show with description in bundle
detail view
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:20 +0000
Subject: [Koha-bugs] [Bug 31079] New: Entering an empty line on checking of
 an item bundle, gives "Unexpected:" error
Message-ID: <bug-31079-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079

            Bug ID: 31079
           Summary: Entering an empty line on checking of an item bundle,
                    gives "Unexpected:" error
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When returning a checked out item bundle item, if you enter an additional new
line in the field, you get an "Unexpected: " error. This could be a little
confusing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-WxLCJOACzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31079


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079
[Bug 31079] Entering an empty line on checking of an item bundle, gives
"Unexpected:" error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:24 +0000
Subject: [Koha-bugs] [Bug 31080] New: Block adding the bundle item to its
 own bundle
Message-ID: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

            Bug ID: 31080
           Summary: Block adding the bundle item to its own bundle
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

At the moment it's possible to add the bundle item barcode to the bundle. The
most prominent effect is, that the bundle can no longer be checked out, as a
bundled item is blocked from circulation. So it's not super bad for a bug, but
we should catch it with a nice error message if someone makes a copy&paste or
scan error there.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:24 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-0NcET9i6ao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080
[Bug 31080] Block adding the bundle item to its own bundle
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:32 +0000
Subject: [Koha-bugs] [Bug 31081] New: Improve display of 'Manage bundle'
 button
Message-ID: <bug-31081-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081

            Bug ID: 31081
           Summary: Improve display of 'Manage bundle' button
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When a potential bundle item (on a record with bib level = c), has no bundled
items, the button shows as:

Manage bundle (|).

It might be nicer to make this (0|0) or better not to display this part, if
there is nothing bundled yet.

It might also be nice to add a tooltip explaining about what the first and
second number mean.

First number: items lost
Second number: items total


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-cntMIH77PW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081
[Bug 31081] Improve display of 'Manage bundle' button
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:35 +0000
Subject: [Koha-bugs] [Bug 31082] New: Add tooltip to buttons when item
 bundles cannot be changed while checked out
Message-ID: <bug-31082-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082

            Bug ID: 31082
           Summary: Add tooltip to buttons when item bundles cannot be
                    changed while checked out
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When an item bundle is checked out, the composition of the bundle can not be
changed (items added or removed). The buttons are greyed out/inactive.

It would be nice to add a tooltip explaining why the bundle cannot be altered.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:44:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:44:35 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-3wQpaTsc0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31082


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082
[Bug 31082] Add tooltip to buttons when item bundles cannot be changed while
checked out
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:45:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:45:51 +0000
Subject: [Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send
 an attachment as HTML
In-Reply-To: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29354-70-W84krCbwUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #1)
> I opened bug 31075 for a wider scope

Thanks Marcel, in that case should we mark this one as a duplicate of Bug
31075?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:46:35 +0000
Subject: [Koha-bugs] [Bug 31083] New: Display subtitle,
 part name and part number in item bundle detail view
Message-ID: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

            Bug ID: 31083
           Summary: Display subtitle, part name and part number in item
                    bundle detail view
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

When displaying the contents of an item bundle, it would be nice to have more
complete item information including the subtitle, part_name and part_number
field as this helps greatly in identifying records especially for such things
as language materials.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:46:35 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KgcOiQd2fE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31083


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083
[Bug 31083] Display subtitle, part name and part number in item bundle detail
view
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:49:40 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-jvisYmUc46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:49:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:49:47 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-H0gSbW9hyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136809|0                           |1
        is obsolete|                            |

--- Comment #318 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136905&action=edit
Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:49:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:49:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pC62UzDgU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136811|0                           |1
        is obsolete|                            |

--- Comment #319 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136906&action=edit
Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:06 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-6rPqAwE0xh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136814|0                           |1
        is obsolete|                            |

--- Comment #320 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136907&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:16 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-orEqCV5y8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136817|0                           |1
        is obsolete|                            |

--- Comment #321 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136908&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-4qC9sEqG8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136821|0                           |1
        is obsolete|                            |

--- Comment #322 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136909&action=edit
Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-RxPnoc8flA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136824|0                           |1
        is obsolete|                            |

--- Comment #323 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136910&action=edit
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-1vtBjIUmWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136826|0                           |1
        is obsolete|                            |

--- Comment #324 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136911&action=edit
Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:50:51 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-X2eXTiC6DX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136829|0                           |1
        is obsolete|                            |

--- Comment #325 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136912&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pKWF2cuBZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136832|0                           |1
        is obsolete|                            |

--- Comment #326 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136913&action=edit
Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:08 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CtTQZSDvJ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136835|0                           |1
        is obsolete|                            |

--- Comment #327 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136914&action=edit
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-UISN1Xjrvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136838|0                           |1
        is obsolete|                            |

--- Comment #328 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136915&action=edit
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-V4XgtYs6gs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136841|0                           |1
        is obsolete|                            |

--- Comment #329 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136916&action=edit
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:36 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KN8PmC8V5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136843|0                           |1
        is obsolete|                            |

--- Comment #330 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136917&action=edit
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:44 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-oGdCSOJm94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136846|0                           |1
        is obsolete|                            |

--- Comment #331 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136918&action=edit
Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:51:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:51:53 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ikXxHcXIBV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136849|0                           |1
        is obsolete|                            |

--- Comment #332 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136919&action=edit
Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-xurrhtap9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136850|0                           |1
        is obsolete|                            |

--- Comment #333 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136920&action=edit
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-M5EKsszOEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136851|0                           |1
        is obsolete|                            |

--- Comment #334 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136921&action=edit
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-8Zza2knyow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136852|0                           |1
        is obsolete|                            |

--- Comment #335 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136922&action=edit
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Q6aPMEWsev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136853|0                           |1
        is obsolete|                            |

--- Comment #336 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136923&action=edit
Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:36 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-62kHE33weG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136854|0                           |1
        is obsolete|                            |

--- Comment #337 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136924&action=edit
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-FPojTstXF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136855|0                           |1
        is obsolete|                            |

--- Comment #338 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136925&action=edit
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:52:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-EYnrij4RcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136856|0                           |1
        is obsolete|                            |

--- Comment #339 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136926&action=edit
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-NlrZTsqomg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136857|0                           |1
        is obsolete|                            |

--- Comment #340 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136927&action=edit
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-AQK9ZN2vCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136858|0                           |1
        is obsolete|                            |

--- Comment #341 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136928&action=edit
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:19 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-5vDbdpNFm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136859|0                           |1
        is obsolete|                            |

--- Comment #342 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136929&action=edit
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:27 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CKvv2jn6I9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136860|0                           |1
        is obsolete|                            |

--- Comment #343 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136930&action=edit
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:36 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-14Vk1Mw1AL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136861|0                           |1
        is obsolete|                            |

--- Comment #344 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136931&action=edit
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Rw5ZaGIDfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136862|0                           |1
        is obsolete|                            |

--- Comment #345 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136932&action=edit
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:53:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:53:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-MpnNA39oke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136863|0                           |1
        is obsolete|                            |

--- Comment #346 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136933&action=edit
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nfYOgqsfAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136864|0                           |1
        is obsolete|                            |

--- Comment #347 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136934&action=edit
Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-xHGNDm0fWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136865|0                           |1
        is obsolete|                            |

--- Comment #348 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136935&action=edit
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ge5Jgd27wN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136866|0                           |1
        is obsolete|                            |

--- Comment #349 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136936&action=edit
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-1EHaVTnLEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136867|0                           |1
        is obsolete|                            |

--- Comment #350 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136937&action=edit
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:37 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-BCv9frPvpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136868|0                           |1
        is obsolete|                            |

--- Comment #351 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136938&action=edit
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:47 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-SpDcU56Xp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136869|0                           |1
        is obsolete|                            |

--- Comment #352 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136939&action=edit
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:54:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:54:57 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-O4VibtjLOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136870|0                           |1
        is obsolete|                            |

--- Comment #353 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136940&action=edit
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:55:07 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-c7tMMGh8o3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136871|0                           |1
        is obsolete|                            |

--- Comment #354 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136941&action=edit
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:55:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:55:16 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-zWU9jDMkvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136872|0                           |1
        is obsolete|                            |

--- Comment #355 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136942&action=edit
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:55:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:55:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-K5u0qNLJOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136873|0                           |1
        is obsolete|                            |

--- Comment #356 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136943&action=edit
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:55:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:55:34 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KPU60tIqow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136874|0                           |1
        is obsolete|                            |

--- Comment #357 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136944&action=edit
Bug 28854: (follow-up) Prevent stringification of null in return claims

The return claims table was stringifying 'null'. This patch updates the
code to check for definition so we don't stringify incorrectly

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:55:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:55:47 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nJoIFCYKSh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136875|0                           |1
        is obsolete|                            |

--- Comment #358 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136945&action=edit
Bug 28854: (follow-up) Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:56:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:56:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nB0GWqFwfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136876|0                           |1
        is obsolete|                            |

--- Comment #359 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136946&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:56:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:56:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ouwnkTNqt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136877|0                           |1
        is obsolete|                            |

--- Comment #360 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 136947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136947&action=edit
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 15:57:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 13:57:06 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-WfO2xGZS39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #361 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am quite happy with this now with this at 43 commits :) 

I have filed separate bugs for some of the enhancement ideas remaining that I
don't consider blocker so we can track those. No need to grow this further.
They are all bite-size things that should be easy to test later on, but no need
to grow this further.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:12:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:12:06 +0000
Subject: [Koha-bugs] [Bug 29418] Zebra clean_search_term does not clean
 search and so results in error
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-ruytnwSOWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |21.11

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:14:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:14:18 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-5bTzKliVj3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136904|0                           |1
        is obsolete|                            |

--- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 136948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136948&action=edit
Bug 30889: (follow-up) Warn if context is not defined

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:15:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:15:07 +0000
Subject: [Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should
 double quote Host-item search
In-Reply-To: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30865-70-FwlufBNXgk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:15:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:15:10 +0000
Subject: [Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should
 double quote Host-item search
In-Reply-To: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30865-70-mBrTBKy2Kb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:17:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:17:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-UShDYdXVFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #362 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136949&action=edit
Bug 28854: (follow-up) Prevent bundles from being nested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:21:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:21:40 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ldMa6N3OCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136878|0                           |1
        is obsolete|                            |

--- Comment #54 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136950&action=edit
Bug 30952: added new icons and main scss files

also touch includes files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:21:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:21:45 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uPJSPRLG0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136879|0                           |1
        is obsolete|                            |

--- Comment #55 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136951&action=edit
Bug 30952: Catalogue module restyling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:21:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-JTUs9WzYoV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136880|0                           |1
        is obsolete|                            |

--- Comment #56 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136952&action=edit
Bug 30952: Cataloguing Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:21:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:21:54 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-dnwo91jX43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136881|0                           |1
        is obsolete|                            |

--- Comment #57 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136953&action=edit
Bug 30952: Acquisition Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:21:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:21:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-NIhySBEVHY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136882|0                           |1
        is obsolete|                            |

--- Comment #58 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136954&action=edit
Bug 30952: Admin Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-dAuzcS18ie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136883|0                           |1
        is obsolete|                            |

--- Comment #59 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136955&action=edit
Bug 30952: Auth template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vneJOXemcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136884|0                           |1
        is obsolete|                            |

--- Comment #60 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136956&action=edit
Bug 30952: Authority module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:15 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-lKf3fIfQUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136885|0                           |1
        is obsolete|                            |

--- Comment #61 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136957&action=edit
Bug 30952: Circulation Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:21 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-rJP1h17jdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136886|0                           |1
        is obsolete|                            |

--- Comment #62 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136958&action=edit
Bug 30952: Intranet main page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:26 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-8rABHrDnG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136887|0                           |1
        is obsolete|                            |

--- Comment #63 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136959&action=edit
Bug 30952: Labels Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:31 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-QwW2dMm9kW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136888|0                           |1
        is obsolete|                            |

--- Comment #64 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136960&action=edit
Bug 30952: Patrons Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:36 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-aZCyYgKOtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136889|0                           |1
        is obsolete|                            |

--- Comment #65 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136961&action=edit
Bug 30952: Plugins Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:41 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ckDyRHtJI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136890|0                           |1
        is obsolete|                            |

--- Comment #66 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136962&action=edit
Bug 30952: Suggestions Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-c2csbE3nz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136891|0                           |1
        is obsolete|                            |

--- Comment #67 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136963&action=edit
Bug 30952: Tools Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:52 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-Hqy4LYrQnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136892|0                           |1
        is obsolete|                            |

--- Comment #68 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136964&action=edit
Bug 30952: Virtualshelves Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:22:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:22:56 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uDC1XeD3jF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136893|0                           |1
        is obsolete|                            |

--- Comment #69 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136965&action=edit
Bug 30952: Serials Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ee6slSuCZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136894|0                           |1
        is obsolete|                            |

--- Comment #70 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136966&action=edit
Bug 30952: Reports Module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:07 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-m0sFQnnnyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136895|0                           |1
        is obsolete|                            |

--- Comment #71 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136967&action=edit
Bug 30952: Search bar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:12 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-0trJ4XwnIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136896|0                           |1
        is obsolete|                            |

--- Comment #72 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136968&action=edit
Bug 30952: update include

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:15 +0000
Subject: [Koha-bugs] [Bug 31084] New: Display item type in bundle management
 table
Message-ID: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084

            Bug ID: 31084
           Summary: Display item type in bundle management table
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, katrin.fischer at bsz-bw.de,
                    koha-bugs at lists.koha-community.org,
                    kyle.m.hall at gmail.com,
                    testopia at bugs.koha-community.org
        Depends on: 28854

We removed the item type field from display in the bundle management table from
the original submission on bug 28854 because I felt it was not required for the
minimum viable product and that adding the code to description handling needed
testing in it's own right.

This bug serves to add that field back in.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:15 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-E1Y8sHgPE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084
[Bug 31084] Display item type in bundle management table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-OSpByH6rpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136897|0                           |1
        is obsolete|                            |

--- Comment #73 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136969&action=edit
Bug 30952: update patron and suggestion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:24 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-h6ZdzRKcyd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136898|0                           |1
        is obsolete|                            |

--- Comment #74 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136970&action=edit
Bug 30952: update search-engine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:26 +0000
Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table
In-Reply-To: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31084-70-pagxMUC0XW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |normal
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:30 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-BWEY25wOuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136899|0                           |1
        is obsolete|                            |

--- Comment #75 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136971&action=edit
Bug 30952: correction includes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:32 +0000
Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table
In-Reply-To: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31084-70-gS0XOuFI4d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-MxIX6v0SGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136900|0                           |1
        is obsolete|                            |

--- Comment #76 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136972&action=edit
Bug 30952: update request

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:38 +0000
Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table
In-Reply-To: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31084-70-NQEz5rpvJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:40 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-CvzmKrhSZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136901|0                           |1
        is obsolete|                            |

--- Comment #77 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136973&action=edit
Bug 30952: update circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:23:46 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-epEF3Uxwt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136902|0                           |1
        is obsolete|                            |

--- Comment #78 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 136974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136974&action=edit
Bug 30952: css generation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:24:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:24:01 +0000
Subject: [Koha-bugs] [Bug 31078] Lost status different to 1 don't show with
 description in bundle detail view
In-Reply-To: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31078-70-PvTWiTTrXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
            Version|20.11                       |master
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|trivial                     |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:24:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:24:29 +0000
Subject: [Koha-bugs] [Bug 31078] Lost status different to 1 don't show with
 description in bundle detail view
In-Reply-To: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31078-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31078-70-zU6LbiQVx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:27:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:27:03 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-OvnPB3eHYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136975&action=edit
Bug 31080: Prevent bundles from being nested

This is a follow-up for bug 28854 to prevent bundle type items from
being nested in to other bundles.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:28:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:28:21 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-vPqZrw9eqA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:28:31 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-2QCEBX9TGu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:34:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:34:00 +0000
Subject: [Koha-bugs] [Bug 29519] Add option to resolve a return claim at
 checkin
In-Reply-To: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29519-70-qTX7cCbPHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085
[Bug 31085] The return claims table no longer reloads on resolution
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:34:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:34:00 +0000
Subject: [Koha-bugs] [Bug 31085] New: The return claims table no longer
 reloads on resolution
Message-ID: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

            Bug ID: 31085
           Summary: The return claims table no longer reloads on
                    resolution
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 29519
            Blocks: 28854

In bug 29519 we split out the returns claim resolution modal and form so they
could be re-used on the check-in screen.

However, I missed something.  When resolving a claim from the details or
checkout screens the claims table should be refreshed.

Currently, we are calling an undefined function and this leads to noise in the
console and the table not refreshing as it should.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519
[Bug 29519] Add option to resolve a return claim at checkin
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:34:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:34:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-NabB7cWqpd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085
[Bug 31085] The return claims table no longer reloads on resolution
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:34:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:34:08 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-eREsidBR89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:34:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:34:15 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-JbmCM9bA2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:37:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:37:17 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-Ie1LDX0Qmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136976&action=edit
Bug 31085: Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

NOTE: Taken as a whole commit follow-up on bug 28854 where the issue was
initially identified

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:37:30 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-UxXOCKuJDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:37:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:37:45 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-k3RkYvyRw6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:38:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:38:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-jTPr83u6wJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|29519                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519
[Bug 29519] Add option to resolve a return claim at checkin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:38:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:38:32 +0000
Subject: [Koha-bugs] [Bug 29519] Add option to resolve a return claim at
 checkin
In-Reply-To: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29519-70-CztNbeOJDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|28854                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:38:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:38:35 +0000
Subject: [Koha-bugs] [Bug 31086] New: Do not allow hold requests with no
 branchcode
Message-ID: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

            Bug ID: 31086
           Summary: Do not allow hold requests with no branchcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Holds require a branchcode, various code expects this, however, we do not
enforce this requirement when saving holds

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:41:32 +0000
Subject: [Koha-bugs] [Bug 31087] New: Undefined notes in returns claims get
 stringified to 'null'
Message-ID: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

            Bug ID: 31087
           Summary: Undefined notes in returns claims get stringified to
                    'null'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
            Blocks: 28854

The returns claims tables available on checkout and details pages display the
null values stringified for notes.

This was found whilst testing bug 28854 and fixed inline there, but we felt it
should be split out as it's own minor bug.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:41:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:41:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-OeAOrCBfBs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31087


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087
[Bug 31087] Undefined notes in returns claims get stringified to 'null'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:45:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:45:27 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-2KaueKPurG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136977&action=edit
Bug 31087: Prevent stringification of null in return claims

The return claims table was stringifying 'null'. This patch updates the
code to check for definition so we don't stringify incorrectly

Note: This patch was split out from a follow-up on bug 28854 as we felt
it should be treated separately for backportability.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:46:18 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-JutkDfIFNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
           Severity|minor                       |normal
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:46:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:46:26 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-hKjmyAsI9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:52:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:52:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-w78jx3JTvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136905|0                           |1
        is obsolete|                            |

--- Comment #363 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136978&action=edit
Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:52:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:52:51 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-FlytaU4m1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136906|0                           |1
        is obsolete|                            |

--- Comment #364 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136979&action=edit
Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-E6YzsZPiAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136907|0                           |1
        is obsolete|                            |

--- Comment #365 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136980&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-UxeLwzANxL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136908|0                           |1
        is obsolete|                            |

--- Comment #366 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136981&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:17 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-6cL4LTkk3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:18 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-OWWqUIgedm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136909|0                           |1
        is obsolete|                            |

--- Comment #367 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136982&action=edit
Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:21 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-kcjF6KHBmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136983&action=edit
Bug 31086: DB update

This update sets branchcode as NOT NULL
default set to 0 as borrowernumber is

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:24 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-ulDuzpNztj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136984&action=edit
Bug 31086: Throw an exception when a hold is stored with no branchcode

To test:
1 - Apply first 2 patches
2 - On staff client, find a biblio, place hold, select a patron
3 - Before creating hold, right click on 'Pickup location'
4 - Inspect the element
5 - In the console find the top <li> for pickup, and right click
6 - Select 'Delete node'
7 - Save hold
8 - You get an exception/error

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:26 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-xDAEqWap65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136910|0                           |1
        is obsolete|                            |

--- Comment #368 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136985&action=edit
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:28 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-UGYtxmUKfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136986&action=edit
Bug 31086: Prevent placing hold with no pickup location

To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:31 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-1maPlCn4qV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 136987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136987&action=edit
Bug 31086: DO NOT PUSH: Schema updates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:35 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-bOGG7o0XK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136911|0                           |1
        is obsolete|                            |

--- Comment #369 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136988&action=edit
Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:40 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-17BophPX2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |21.05
            Summary|Zebra clean_search_term     |Error searching for
                   |does not clean search and   |analytics in detail view
                   |so results in error         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-4CTm05nFH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136912|0                           |1
        is obsolete|                            |

--- Comment #370 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136989&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ZCoANLaXkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136913|0                           |1
        is obsolete|                            |

--- Comment #371 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136990&action=edit
Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:53:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:53:56 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-UUD2DbvqCy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CeJBbxkbBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136914|0                           |1
        is obsolete|                            |

--- Comment #372 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136991&action=edit
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:14 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-cN7LfrluU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136915|0                           |1
        is obsolete|                            |

--- Comment #373 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136992&action=edit
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-XNERHSN8xm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136916|0                           |1
        is obsolete|                            |

--- Comment #374 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136993&action=edit
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-TMGfog9zRT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136917|0                           |1
        is obsolete|                            |

--- Comment #375 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136994&action=edit
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:43 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-WV0BWOlLmW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136918|0                           |1
        is obsolete|                            |

--- Comment #376 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136995&action=edit
Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:54:51 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-yvA7KYzx7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136919|0                           |1
        is obsolete|                            |

--- Comment #377 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136996&action=edit
Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:00 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ms9IPjPYWq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136920|0                           |1
        is obsolete|                            |

--- Comment #378 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136997&action=edit
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kAEFfpPIVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136921|0                           |1
        is obsolete|                            |

--- Comment #379 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136998&action=edit
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-pjE0kUt86S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136922|0                           |1
        is obsolete|                            |

--- Comment #380 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 136999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136999&action=edit
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7TnNgww1Xl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136923|0                           |1
        is obsolete|                            |

--- Comment #381 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137000&action=edit
Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:40 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-5eKbwNJoYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136924|0                           |1
        is obsolete|                            |

--- Comment #382 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137001&action=edit
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:50 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-do6mxi3Z9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136925|0                           |1
        is obsolete|                            |

--- Comment #383 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137002&action=edit
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:55:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:55:58 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-VaVHkUhIN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136926|0                           |1
        is obsolete|                            |

--- Comment #384 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137003&action=edit
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-gfSP2JwO64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136927|0                           |1
        is obsolete|                            |

--- Comment #385 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137004&action=edit
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-DJsUulfaHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136928|0                           |1
        is obsolete|                            |

--- Comment #386 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137005&action=edit
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-qpalJZloST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136929|0                           |1
        is obsolete|                            |

--- Comment #387 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137006&action=edit
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-QnN5WCw1OG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136930|0                           |1
        is obsolete|                            |

--- Comment #388 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137007&action=edit
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Manh6pyUOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136931|0                           |1
        is obsolete|                            |

--- Comment #389 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137008&action=edit
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:56:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:56:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-5qCtsvR0iD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136932|0                           |1
        is obsolete|                            |

--- Comment #390 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137009&action=edit
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-s7NfY4Seuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136933|0                           |1
        is obsolete|                            |

--- Comment #391 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137010&action=edit
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-twmCqw4UZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136934|0                           |1
        is obsolete|                            |

--- Comment #392 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137011&action=edit
Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-GpwDoY231G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136935|0                           |1
        is obsolete|                            |

--- Comment #393 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137012&action=edit
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:29 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-paPuaH9VCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136936|0                           |1
        is obsolete|                            |

--- Comment #394 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137013&action=edit
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:38 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-DZypXAQBcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136937|0                           |1
        is obsolete|                            |

--- Comment #395 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137014&action=edit
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:48 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-mM81nkbFXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136938|0                           |1
        is obsolete|                            |

--- Comment #396 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137015&action=edit
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:57:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:57:59 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-FALbxVOZKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136939|0                           |1
        is obsolete|                            |

--- Comment #397 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137016&action=edit
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:08 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-AoOrUgxx67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136940|0                           |1
        is obsolete|                            |

--- Comment #398 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137017&action=edit
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:18 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-r3shOp1qtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136941|0                           |1
        is obsolete|                            |

--- Comment #399 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137018&action=edit
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:27 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-8VtHWdq1pg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136942|0                           |1
        is obsolete|                            |

--- Comment #400 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137019&action=edit
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:36 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-edZFz1YQj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136943|0                           |1
        is obsolete|                            |

--- Comment #401 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137020&action=edit
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:45 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wsyjXGFQJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136946|0                           |1
        is obsolete|                            |

--- Comment #402 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137021&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:58:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-58wo5rzq2E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136947|0                           |1
        is obsolete|                            |

--- Comment #403 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137022&action=edit
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:59:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:59:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-a96m2ggB6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136944|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:59:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-rxjmd1FVN3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136945|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 16:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 14:59:57 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-A0Rv79BxEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136949|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:00:17 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-bOyQxxq5Un@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:00:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:00:20 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-NFhFkMJC4x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134865|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:00:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:00:23 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-zk78VMjHwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134866|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:00:56 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-fPR9Bk8UOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137023&action=edit
Bug 29418: Fix error searching for analytics in detail view

This patch fixes the problem of searching for analytics when the title
contains reserved characters like ?

To test:
1. Have a record with ? in the title
2. Open the detail view (staff)
=> FAIL: tells there's an error checking for analytics
3. Open the detail view (OPAC)
=> FAIL: tells there's an error checking for analytics
4. Apply this patch and restart all
5. Repeat 2 and 3
=> SUCCESS: Link shows correctly!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:01:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:01:31 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-aczkFXZKX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #404 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Final rebase done and commits we agreed to split out into their own bugs have
now been split out and added to the bugzilla tree.

All ready for a final QA run.

Thanks so much for the thorough and vigilent testing Katrin.. it's been really
helpful putting this new feature through it's paces and I think we've come out
with a much more polished piece overall.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:07:18 +0000
Subject: [Koha-bugs] [Bug 31083] Display subtitle,
 part name and part number in item bundle detail view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-cWsubGHbaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So, for me this is already working in bug 28854.. I've tested against subtitles
especially but the code is also there for part numbers/names.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:07:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:07:26 +0000
Subject: [Koha-bugs] [Bug 31083] Display subtitle,
 part name and part number in item bundle detail view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-f63VN9rEfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Version|20.11                       |master
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:18:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:18:56 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-Z3c5oYCuSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:18:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:18:59 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-0F9aRN8ChX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136976|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137024&action=edit
Bug 31085: Reload return claims table on resolve

This is another fix for a bug in return claims. We now test for the
initialised datatable and call an ajax reload directly on it if we find
one instead of calling a undefined function (the function is out of
scope here).

NOTE: Taken as a whole commit follow-up on bug 28854 where the issue was
initially identified

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:24:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:24:47 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-K8kWPGoTXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:24:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:24:51 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-goJD5pO1xz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136977|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137025&action=edit
Bug 31087: Prevent stringification of null in return claims

The return claims table was stringifying 'null'. This patch updates the
code to check for definition so we don't stringify incorrectly

Note: This patch was split out from a follow-up on bug 28854 as we felt
it should be treated separately for backportability.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:25:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:25:22 +0000
Subject: [Koha-bugs] [Bug 29959] Populate prices when creating an order with
 the API
In-Reply-To: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29959-70-dB1r1FheG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29959

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:26:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:26:02 +0000
Subject: [Koha-bugs] [Bug 29959] Populate prices when creating an order with
 the API
In-Reply-To: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29959-70-u6bS9M8BZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29959

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 17:31:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 15:31:51 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-NwN2pThPHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137026&action=edit
Bug 31086: Update existing unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:06:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:06:52 +0000
Subject: [Koha-bugs] [Bug 30438] Add select all/clear buttons to invoices.tt
 open and closed tables
In-Reply-To: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30438-70-V8DUX9tqWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30438

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Arthur,

I know this is an enhancement but it is a small one. Any chance to backport to
21.11?


Lucas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:39 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-81VK9KfjGp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133263|0                           |1
        is obsolete|                            |
 Attachment #133264|0                           |1
        is obsolete|                            |
 Attachment #133265|0                           |1
        is obsolete|                            |
 Attachment #133266|0                           |1
        is obsolete|                            |
 Attachment #133267|0                           |1
        is obsolete|                            |
 Attachment #133268|0                           |1
        is obsolete|                            |
 Attachment #133269|0                           |1
        is obsolete|                            |
 Attachment #133270|0                           |1
        is obsolete|                            |
 Attachment #133361|0                           |1
        is obsolete|                            |
 Attachment #133376|0                           |1
        is obsolete|                            |

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137027&action=edit
Bug 17170: DB Updates

This patch adds the new table, permission, and a syspref to enable the feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:44 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-YIiGEMAMmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137028&action=edit
Bug 17170: DO NOT PUSH - Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:47 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-w9CeAKu2m4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137029&action=edit
Bug 17170: Update schema for boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:51 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-ym9bwMLb10@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137030&action=edit
Bug 17170: Add API route for SearchFilters

This adds the API routes and tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:55 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-zNyt8wsPY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137031&action=edit
Bug 17170: Add search filters to staff and opac interfaces

This patch displays the filters on the results pages with the facets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:30:59 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-bkyNNfJ2Kw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137032&action=edit
Bug 17170: Handle search filters in query builders

This patch updates the query building code to expand filters when searching
and pass them back as part of the cgi and descriptive search strings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:31:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:31:03 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-gCDNF4bmwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137033&action=edit
Bug 17170: Add admin page for filters and ability to edit/save existing filters

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the resuilts page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:31:06 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-UQgtQ0Rxha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137034&action=edit
Bug 17170: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:31:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:31:10 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-MpZG3LyNuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137035&action=edit
Bug 17170: (follow-up) Display search filters admin links when apprropriate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 18:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 16:31:14 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-sP2juv37gu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137036&action=edit
Bug 17170: (follow-up) Correct handling of limits in ES

This patch alters the code in the ES QueryBuilder. Reflecting
how things are handled in build_query_compat we clean the query,
but not the limits. In Zebra we simply recursivly call buildQuery,
but the ES query structure is more complex, so we handle the pieces
individually

Additionally I add more tests to cover other cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 19:29:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 17:29:33 +0000
Subject: [Koha-bugs] [Bug 31088] New: Primary contact method enhancements
Message-ID: <bug-31088-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31088

            Bug ID: 31088
           Summary: Primary contact method enhancements
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I am loving the new primary contact method setting in the patron record.  I
have a couple enhancement requests for this:

1) Have the patronbriefinfo panel on the left just show the primary contact
info (the actual info, not the choice).  The other info would still be
available in the patron details.

2) Instead of showing the setting choice on the patron details, highlight the
preferred info.  No need to take up more screen real estate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 20:47:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 18:47:45 +0000
Subject: [Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs
In-Reply-To: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30823-70-X3bRMsWZsk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 20:47:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 18:47:49 +0000
Subject: [Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs
In-Reply-To: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30823-70-4LsFIB9aIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136212|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137037&action=edit
Bug 30823: Filling recalls uses 'FILL' action in action logs

This enhancement changes recall fulfillment actions to log with the
FILL action. It will also update existing recalls FULFILL actions in
the database to use the FILL action.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules. Confirm RecallsLog is enabled.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place a recall on that item.
5) Go back to the staff client and check the item in. Confirm the recall
as waiting for Patron A.
6) Check out the item for Patron A to fill the recall.
7) Go to Tools -> Log Viewer. Confirm there is a FULFILL action. Choose
the following search params to browse system logs:
- modules: recalls
- actions: fill
8) Submit the search and confirm the recall DOES NOT show.
9) Apply the patch, update database, restart services.
10) Refresh the log viewer and repeat step 7. Submit the search and
confirm the recall DOES show. Confirm there is no longer a FULFILL
action as both holds and recalls will use FILL.
11) Check in the item.
12) Repeat steps 2-6. We are ensuring that future recalls are logged
using the FILL action.
13) Repeat step 7. Confirm all test recalls are now showing in search
results.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:26 +0000
Subject: [Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs
In-Reply-To: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30823-70-6OyNmBJZTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:29 +0000
Subject: [Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs
In-Reply-To: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30823-70-QRkczELINS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:31 +0000
Subject: [Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from
 v1.19.1
In-Reply-To: <bug-30859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30859-70-kN4CORWJzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:33 +0000
Subject: [Koha-bugs] [Bug 30859] Upgrade jQuery Validation plugin from
 v1.19.1
In-Reply-To: <bug-30859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30859-70-XMp4vxkHiE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30859

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:35 +0000
Subject: [Koha-bugs] [Bug 31062] Change description of QOTD tool in
 tools-home
In-Reply-To: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31062-70-TYWwIxRbej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:39 +0000
Subject: [Koha-bugs] [Bug 31062] Change description of QOTD tool in
 tools-home
In-Reply-To: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31062-70-QkvFyk7qxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:41 +0000
Subject: [Koha-bugs] [Bug 31064] Local login is difficult to style using CSS
In-Reply-To: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31064-70-0uNIqlNAYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:44 +0000
Subject: [Koha-bugs] [Bug 31064] Local login is difficult to style using CSS
In-Reply-To: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31064-70-1M7cCXLNek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:46 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-EmjknOr9EY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:49 +0000
Subject: [Koha-bugs] [Bug 31085] The return claims table no longer reloads
 on resolution
In-Reply-To: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31085-70-KSnjP091Ej@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:51 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-GlzChuJyOJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:43:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:43:54 +0000
Subject: [Koha-bugs] [Bug 31087] Undefined notes in returns claims get
 stringified to 'null'
In-Reply-To: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31087-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31087-70-hLTIYmfCsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:53:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:53:24 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-YuezEPmXU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Sorry, please rebase ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:58:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:58:13 +0000
Subject: [Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work
 with limits
In-Reply-To: <bug-30152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30152-70-N2Ys4kD8Sv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:58:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:58:16 +0000
Subject: [Koha-bugs] [Bug 30152] Elasticsearch - queries with OR don't work
 with limits
In-Reply-To: <bug-30152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30152-70-MLdafQ1Soh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30152

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:58:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:58:23 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30430-70-Xl4oMz0lXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 21:58:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 19:58:26 +0000
Subject: [Koha-bugs] [Bug 30430] UNIMARC XSLT : displaying field B_214
In-Reply-To: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30430-70-rjQEK93fDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30430

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 22:09:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 20:09:23 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-RXo6UrPzKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 22:14:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 20:14:23 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-OuNEqMz4rY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #79 from Fridolin Somers <fridolin.somers at biblibre.com> ---
> Bug 30952: css generation
This looks like the compiles CSS from SCSS, you should not attach a patch for
that, it is compiled by testers :
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 22:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 20:15:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-jPMNrI27wA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #80 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Do we have a link to presentation ?
Screen shots ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  1 22:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 20:43:34 +0000
Subject: [Koha-bugs] [Bug 28976] In MARC21slimUtils.xsl param 'punctuation'
 is missing in 'chopPunctuation'
In-Reply-To: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28976-70-dcdXNGa8mY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976

--- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> ---
@Lucas, thanks for testing.
We need a MARC21 user here, could you continue on this patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 00:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 22:51:25 +0000
Subject: [Koha-bugs] [Bug 31089] New: viewlog.pl needs better reference
 point for compare
Message-ID: <bug-31089-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31089

            Bug ID: 31089
           Summary: viewlog.pl needs better reference point for compare
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Currently, viewlog.pl runs comparisons another log.  This is okay if you have a
previous entry in the log to compare it to (if your logs haven't been cleaned
up or a good log exists before the change).

It would be better, if the log had a copy of info before the change, and after.
 If that is the only log entry you select to compare, it will show you a before
and after and highlight the changes.  If you select a second log entry, then it
would show you a comparison between the two entries.

This would make the compare feature infinitely more useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 01:00:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 23:00:13 +0000
Subject: [Koha-bugs] [Bug 31090] New: Background jobs needs highlights and
 searchability
Message-ID: <bug-31090-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31090

            Bug ID: 31090
           Summary: Background jobs needs highlights and searchability
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be great if background jobs actually highlighted what was changed in
the records.

It would also be great if we could search the jobs.  Right now the search bar
only searches the list of jobs, but not the contents.  If you are searching for
a job that modified a certain record, you have to do a lot of manual scanning
for this modification, if it exists.  If the search bar searched contents, that
would be a tremendous help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 01:09:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Jul 2022 23:09:18 +0000
Subject: [Koha-bugs] [Bug 31091] New: Format grouping in record details
Message-ID: <bug-31091-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31091

            Bug ID: 31091
           Summary: Format grouping in record details
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

It would be great if details.pl had the option to organize holdings into tabs
of similar formats.

Why?

Wouldn't it be nice if you could combine your formats into one record, and get
a single result on a title rather than multiple results?

How would that help?

A patron could see all the formats available on the details page.

Then what?

Then perhaps we could develop the hold requests to limit the hold to some or
all of the available formats within that record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 03:22:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 01:22:38 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-84j0KMmNfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Great.

We should do the same with above lines :

        if ( $l =~ /^yr,st-numeric,ge=/ ) {
            my ( $start, $end ) =
              ( $l =~ /^yr,st-numeric,ge=(.*) and yr,st-numeric,le=(.*)$/ );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 15:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 13:06:00 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-8CZDjO9zLe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe check if the items had holdingbranch, homebranch and itemtype correctly
set, I believe the error could be that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 21:16:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 19:16:39 +0000
Subject: [Koha-bugs] [Bug 31092] New: Upon importing batch records, if a
 full MARC record is found, only append the items;
 do not overlay a full MARC record
Message-ID: <bug-31092-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31092

            Bug ID: 31092
           Summary: Upon importing batch records, if a full MARC record is
                    found, only append the items; do not overlay a full
                    MARC record
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: balestrieri at monterey.org
        QA Contact: testopia at bugs.koha-community.org

When receiving items from our vendors, the full MARC records are sent in
batches for import.  We would like the ability to have koha only overlay our
brief "on order" records that already exist in the system, not our full records
already in our system.  Currently, the only choice is to overlay ALL or NO
records (choices are "Replace, Add, or Ignore") and to append the items,
depending on the matching rule used (most users currently match on ISBN when
importing books, audiobooks).

Apparently, other ils systems have the ability to determine which existing
records are brief and which existing records are full, and you can choose to
only overlay the brief MARC records, leaving the full MARC records in tact,
appending only the items.

I understand the definitive markers are in the leader of the marc record.   The
leader will show the level of marc record it is.   Most loaders will have a
function to put this as one of the criteria. 

An example of an incoming Leader:

=LDR  01429pam a2200385 i 4500

Position 17 is the encoding level. The above encoding level is blank, so it is
a full level record. 

Encoding levels:

Blank  -  full level record

1               -  full level record

2               – less-than-full level record

3               – less than full level record

4               -  less than full level record

5               – less than full level record

6               -  less than full level record

7               – less than full level record

8               – less than full level (this is a prepublication record)


It would be most convenient if koha would have an internal matching rule that
allows for the user to overlay only existing records where levels 2-8 are in
position 17 on the MARCs, ignoring any records with a "blank" or "1" in
position 17 on existing MARCS, with the ability to still append all items.

Right now, many of us in aquisitions need to create separate vendor accounts to
order "added/existing" items only to avoid the constant overlaying of full MARC
records in koha.  We know any items arriving from these accounts already have
full records in our system, so the vendor does not send full MARCs for any
items ordered from these accounts.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 21:18:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 19:18:34 +0000
Subject: [Koha-bugs] [Bug 31092] Upon importing batch records, if a full
 MARC record is found, only append the items;
 do not overlay a full MARC record
In-Reply-To: <bug-31092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31092-70-yFsZiewv15@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31092

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 21:45:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 19:45:55 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-ygJZ65mrPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Display subtitle, part name |Part name (245$p) breaks
                   |and part number in item     |item bundle detail view
                   |bundle detail view          |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it was an issue with the sample data. I've checked the mappings and
updated records to make sure the fields are set in the database.

It does work, but we are missing spaces between the fields:

CSS :the definitive guide /
Should be: CSS : the definitive guide /

Also, when I add a part_name (245$p) the bundle manage view throws an error and
sends the display into eternal processing:

Uncaught ReferenceError: part_name is not defined

My catalogued 245 was:

245     1       0       _aCSS :
_bthe definitive guide /
_cEric A. Meyer.
_nnumber1
_ppart1
_nnumber2
_ppart2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:22:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:22:25 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-Q2tMbsyJgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I tried with Elasticsearch and Zebra on master, but the error was not shown, is
this specific to 21.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:33:43 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-hhmWfKX8Fi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this doesn't quite work as supposed yet.

1) Find or create a record with bib-level:c
2) Add an item
3) Copy the barcode of the item and add it to the bundle for the same item
--> It will be added without an error

Adding any other bundle item works ok (not added) and gives the message added
here.

Are we missing a unit test?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:33:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:33:56 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-a29zM9TxlE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:37:30 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-LEW2BdpyXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:37:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:37:34 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-VydxaoVH9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136795|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137038&action=edit
Bug 30785: Fixed typo in SIP2SortBinMapping

To test:
1. Go to the admin page.
2. Search for the above preference.
3. Confirm that "Will" is now spelled correctly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:38:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:38:05 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-Q1xJVHOFDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for fixing this bug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:39:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:39:32 +0000
Subject: [Koha-bugs] [Bug 31071] Bug 28321 removed date due in results page
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-F6SU4qao6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:44:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:44:27 +0000
Subject: [Koha-bugs] [Bug 27809] Make entries from 'modification log' tab in
 patron record sort by date descending as a default
In-Reply-To: <bug-27809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27809-70-u8gG7FAQED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27809

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've just tested this and it sorts the newest entries to the top for both, the
log viewer and the patron modification log.

This looks like a duplicate to bug 25968 that has been fixed in 20.11.

*** This bug has been marked as a duplicate of bug 25968 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:44:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:44:27 +0000
Subject: [Koha-bugs] [Bug 25968] Make logs sort by date descending as a
 default and add column configuration options
In-Reply-To: <bug-25968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25968-70-XKzXH1fr16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25968

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 27809 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:45:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:45:18 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-zoz9LnOz4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin Somers from comment #12)
> I do reproduce.
> 
> Searching for bööks.
> 
> Browsing from result n°18 to n°19 then n°20 does not break encoding.
> Browsing from result n°20 to n°19 breaks encoding.
> Browsing from result n°19 to n°18 does not break encoding.
> 
> o_O

Thx Frido, I have a feeling it could have to do with the "last record on a
page" somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  2 23:52:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 21:52:25 +0000
Subject: [Koha-bugs] [Bug 31093] New: Add help to
 search_for_data_inconsistencies.pl
Message-ID: <bug-31093-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31093

            Bug ID: 31093
           Summary: Add help to search_for_data_inconsistencies.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

When running ./misc/maintenance/search_for_data_inconsistencies.pl without
parameters or with -h, the script starts, instead of giving any information
about its usage.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:01:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:01:49 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-mPGYL67Zrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:01:54 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-WteQCUGllE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136750|0                           |1
        is obsolete|                            |

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137039&action=edit
Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl

Patron categories may have age limits.
Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of
patrons which age is invalid regarding there category.

Test plan :
1) Create an adult patron category limited to 18-99 years
2) Create a patron in the category
3) Edit in database its date of birth so that he is 17 years old
4) Run misc/maintenance/search_for_data_inconsistencies.pl
=> You see the patron

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:02:00 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-VNi2VPJwr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136751|0                           |1
        is obsolete|                            |

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137040&action=edit
Bug 26311: (QA follow-up) Rephrase output message

This is a suggestion for rephrasing the message slightly:

Before:
* Patron borrowernumber=15 in category 'J' has invalid age '56'

After:
* Patron borrowernumber=37 has an invalid age of 37 for their category 'K'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:02:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:02:05 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-qUBwysNSp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136752|0                           |1
        is obsolete|                            |

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137041&action=edit
Bug 26311: (follow-up) loop through the patron with date of birth and in
categories having age limits

Also added category limits in message, for example (12-18)

Check patron :
- with no date of birth
- with invalid age in category having age required
- with invalid age in category having upper age limit
- with invalid age in category having age required and upper age limit

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:02:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:02:10 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-BKExH6iF8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136753|0                           |1
        is obsolete|                            |

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137042&action=edit
Bug 26311: (follow-up) Fix undefined values in sprintf

Avoid warns 'Use of uninitialized value in sprintf' by using
'0' if lower age is undefined
'unlimited' if upper are is undefined

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:02:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:02:15 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-RvtsfV24Qa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137043&action=edit
Bug 26311: (QA follow-up) Update script documentation

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:09:20 +0000
Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be
 definable at the credit_type/debit_type level
In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26689-70-ScarZPS7sS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #20)
> Nice catch Katrin.. added a follow-up and added notes for the release notes.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:10:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:10:45 +0000
Subject: [Koha-bugs] [Bug 31066] Can't use regex in batch modification on
 fields associated with a plugin
In-Reply-To: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31066-70-46NfEzKIT3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:17:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:17:56 +0000
Subject: [Koha-bugs] [Bug 31066] Can't use regex in batch modification on
 fields associated with a plugin
In-Reply-To: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31066-70-oTAw5QxwhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:18:00 +0000
Subject: [Koha-bugs] [Bug 31066] Can't use regex in batch modification on
 fields associated with a plugin
In-Reply-To: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31066-70-ZqUZFH8zqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136749|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137044&action=edit
Bug 31066: Update javascript to use 'text_plugin' type for regex option

To test:
 1 - Confirm 952$o is not linked to a plugin in the default marc framework
 2 - Send some tiems to batch modification
 3 - Confirm you can select RegEx as an option for callnumber during
modification
 4 - Link 952$o to the cn_browser.pl plugin
 5 - Repeat batch modification
 6 - Note there is no regex option
 7 - Apply patch
 8 - Confirm there is a regex option
 9 - Unlink 952$o from plugin
10 - Confirm you still have a regex option in batch modification

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:18:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:18:25 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-tGGld4SmzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #23)
> I tried with Elasticsearch and Zebra on master, but the error was not shown,
> is this specific to 21.05?

Yes. 21.11 got the Koha::Biblio->get_marc_components method with it's own
bugfix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:22:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:22:58 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-BO6akkTrpp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #86 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> > Also, does anyone know how to have the same relative path to one file from
> > both OPAC and staff interface url? (e.g.
> > http://master/api/elasticsearch/elasticsearch.pl and
> > http://master-intranet/api/elasticsearch/elasticsearch.pl)
> > 
> > With this we would only need to create one .pl file to be used by both
> > interface instead of one for each.
> 
> Sorry, I don't.

AFAIK it's not possible to share files between OPAC and staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:34:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:34:16 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-eHsoopXuKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:34:21 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-YroXC0Qu1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136612|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137045&action=edit
Bug 29922: Make get_search_groups return results sorted by title

get_search_groups from Koha/Library/Groups.pm returns library groups sorted by
title.

Test plan:
1- Go to administration > library groups and create multiple library groups
with different names (e.g. AGroup, BGroup, ÄGroup, etc.). Make sure to tick
"Use for OPAC search groups" checkbox.
2- Go to advanced search in OPAC.
3- Under "Groups of librairies" , click the select button.
4- Notice that the library groups are not in alphabetical order.
5- Apply the patch.
6- Notice that the library groups are in alphabetical order.
7- Run `prove t/db_dependent/LibraryGroups.t` and all test should pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:34:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:34:44 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-wkxOR2XrbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The sorting is now correct in the OPAC, but still wrong in the staff interface.
We could make file a separate bug for the staff interface or we could add a
follow-up here and adjust the bug description.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:36:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:36:43 +0000
Subject: [Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on
 the bibliographic detail page
In-Reply-To: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27685-70-k4sHQyUsAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:41:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:41:58 +0000
Subject: [Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on
 the bibliographic detail page
In-Reply-To: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27685-70-yzjlGgCO7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
'In discussion' without any argument is a bit mean :)

Tested with Zebra and Elasticsearch on master: hiding the detail page works
correctly in there.

It also appears ok with Zebra in 20.11. 

I cannot check with Elastic and 20.11, but it might not make a difference. 

Lyon 3, can you add more details?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:45:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:45:21 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-rgBvIFP0gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:45:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:45:25 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-GE0P7PGV16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136533|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137046&action=edit
Bug 31039: (follow-up) Wrap jQuery in $(document).ready()

cashup_modal.js consists only of jQuery code, so the whole thing should
be contained in a $(document).ready() function. This may or may not be
contributing to the behavior this bug is trying to fix.

Please note that this patch contains whitespace changes, so diff
accordingly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:46:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:46:55 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-jEltmRwbPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I couldn't replicate the doubled up printing dialogues, but could also not find
any regression and the changes look good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:52:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:52:51 +0000
Subject: [Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree
 plugin
In-Reply-To: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31040-70-iV963ZisJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 00:52:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 22:52:55 +0000
Subject: [Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree
 plugin
In-Reply-To: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31040-70-w9F1hIHxjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136512|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137047&action=edit
Bug 31040: jsTree image being used outside of jsTree plugin

This patch corrects OPAC templates which tried to use a jsTree image
asset which is missing following the jsTree upgrade (see Bug 11873).
Templates should use /images/spinner-small.gif instead.

To test, apply the patch and enable OpenLibrarySearch and populate
OverDrive and RecordedBooks preferences with credentials (they don't
have to be valid).

Perform a catalog search in the OPAC. When the search results page first
loads you should see messages about the services being queried:

Searching OpenLibrary...
Searching RecordedBoks...
Searching OverDrive...

Each should show a working "spinner" image while the queries are being
performed. If you have valid OverDrive credentials you can try clicking
through to the OverDrive search results page to confirm that the image
is working on that page too.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:00:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:00:29 +0000
Subject: [Koha-bugs] [Bug 25525] Linking to the Schema from Staff Client
In-Reply-To: <bug-25525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25525-70-K6aU17Kcb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25525

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 28454 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:00:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:00:29 +0000
Subject: [Koha-bugs] [Bug 28454] Add Koha version number to database schema
 link in reports
In-Reply-To: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28454-70-moiAF3XvMn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 25525 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:03:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:03:13 +0000
Subject: [Koha-bugs] [Bug 26413] Allow changing privacy settings for reading
 history from the staff interface
In-Reply-To: <bug-26413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26413-70-bXOODUF4o4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26413

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.11                       |master
            Summary|Reading history management  |Allow changing privacy
                   |from staff client.          |settings for reading
                   |                            |history from the staff
                   |                            |interface

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the original intention here was to leave the choice up to the patrons
only, without having the staff interfere. But maybe this could be a preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:06:36 +0000
Subject: [Koha-bugs] [Bug 17536] Remove Duplication of receipting code in EDI
In-Reply-To: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17536-70-GvNoZJxvHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like this patch was never finished. Should we reset to NEW/unassigned?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:18:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:18:40 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-515FFMui1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement to the
      release notes|                            |command line script used
                   |                            |for searching for data
                   |                            |inconsistencies
                   |                            |(misc/maintenance/search_fo
                   |                            |r_data_inconsistencies.pl)
                   |                            |now lists patrons where
                   |                            |their age doesn't match the
                   |                            |criteria set for the patron
                   |                            |category.
                   |                            |
                   |                            |This includes
                   |                            |where there is:
                   |                            |- a minimum
                   |                            |age required
                   |                            |- an upper age
                   |                            |limit
                   |                            |- a minimum age and
                   |                            |an upper age limit
                   |                            |
                   |                            |An
                   |                            |example of the output:
                   |                            |
                   |                            |
                   |                            |Patrons with invalid age
                   |                            |for category:
                   |                            | * Patron
                   |                            |borrowernumber=49 has an
                   |                            |invalid age of 10 for their
                   |                            |category 'PT' (24-)
                   |                            | *
                   |                            |Patron borrowernumber=49
                   |                            |has an invalid age of 71
                   |                            |for their category 'PT'
                   |                            |(-50)
                   |                            | * Patron
                   |                            |borrowernumber=44 has an
                   |                            |invalid age of 70 for their
                   |                            |category 'PT' (20-60)
                   |                            |
                   |                            |Note: Where a patron's age
                   |                            |can't be calculated (for
                   |                            |example: a school or other
                   |                            |organisation, or the date
                   |                            |of birth is missing), then
                   |                            |they are not included in
                   |                            |the checks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 01:30:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Jul 2022 23:30:26 +0000
Subject: [Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree
 plugin
In-Reply-To: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31040-70-w5y76jazvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes OPAC templates
      release notes|                            |which had a missing
                   |                            |"spinner" image when
                   |                            |queries were being
                   |                            |performed (such as for
                   |                            |OpenLibrary, RecordedBooks,
                   |                            |and OverDrive). Previously,
                   |                            |they were using an image
                   |                            |from the jsTree plugin -
                   |                            |this was upgraded (see bug
                   |                            |11873), and the plugin's
                   |                            |folder structure was
                   |                            |changed. Templates now use
                   |                            |/images/spinner-small.gif
                   |                            |instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 08:23:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 06:23:34 +0000
Subject: [Koha-bugs] [Bug 17536] Remove Duplication of receipting code in EDI
In-Reply-To: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17536-70-TFo9e5T9oe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colin.campbell at ptfs-europe. |martin.renvoize at ptfs-europe
                   |com                         |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 08:23:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 06:23:58 +0000
Subject: [Koha-bugs] [Bug 17536] Remove Duplication of receipting code in EDI
In-Reply-To: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17536-70-0xDv0pMZPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17536

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'll take a look, see if I can work out what was being done here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 12:58:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 10:58:32 +0000
Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range
 search
In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31076-70-WrJ5VCj3nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 31076: Handle year limits with equal sign or colon
Using index info to reconstruct a base tree...
M       Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
M       t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
CONFLICT (content): Merge conflict in
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
Auto-merging Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 31076: Handle year limits with equal sign or colon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 18:31:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 16:31:36 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-8f86dqzL4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 18:31:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 16:31:41 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-hrVlvGHHEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137023|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137048&action=edit
Bug 29418: Fix error searching for analytics in detail view

This patch fixes the problem of searching for analytics when the title
contains reserved characters like ?

To test:
1. Have a record with ? in the title
2. Open the detail view (staff)
=> FAIL: tells there's an error checking for analytics
3. Open the detail view (OPAC)
=> FAIL: tells there's an error checking for analytics
4. Apply this patch and restart all
5. Repeat 2 and 3
=> SUCCESS: Link shows correctly!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 20:35:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 18:35:37 +0000
Subject: [Koha-bugs] [Bug 30526] The pagination in the REST API does not
 work if $c->objects->search is called multiple times.
In-Reply-To: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30526-70-8jJGr5wocr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from David Nind <david at davidnind.com> ---
Patch still applies.

Changed status to Failed QA - see comments from Tomás in comment #3

Following the test plan, I noticed no difference in either of the dropdown
lists (hold details area and place a hold on a specific item) when placing a
hold - both before and after the patch is applied. I even added some additional
libraries so that there were 22 where holds could be palced.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 20:43:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 18:43:18 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-sQa7ykBhKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |In Discussion

--- Comment #10 from David Nind <david at davidnind.com> ---
Changed status to 'In discussion', feel free to change the status back to NSO
when it is ready for testing (including a test plan).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 21:20:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 19:20:07 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-bj482oS4QP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 21:20:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 19:20:12 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-XhUeKMmeCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114829|0                           |1
        is obsolete|                            |

--- Comment #15 from David Nind <david at davidnind.com> ---
Created attachment 137049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137049&action=edit
Bug 11158: Add complete field to authority "starts with" search

This patch adds "complete field" to the authority "starts with"
search so that it uses the untokenized "p" register.

Test plan:
1. Apply the patch
2. koha-plack --restart kohadev
3. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl
4. Type in "Espen" into the search box and hit "Submit"
5. Note that there are 3 results
6. Change "contains" to "starts with" and hit "Submit"
7. Note that no results are returned
8. Change the search from "Espen" to "Sandberg" and hit "Submit"
9. Note that 3 results are returned
10. Experiment to your heart's content and rejoice at your new found power

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 21:28:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 19:28:06 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-zxfNHsgV9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #16 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. This is my first time setting up ICU - I followed the instructions at
https://wiki.koha-community.org/wiki/ICU_chains_configuration except for
enabling system preference UseICU, as it no longer exists

2. Queries about setting up ICU:
   . Are the instructions still current?
   . There is no system preference UseICU, but there is UseICUStyleQuotes
   . When editing /etc/koha/zebradb/etc/default.idx I noticed the URX (URL)
index, Numeric index, and Sort register sections reference *.chr files - do
these need changing as well?

3. I used the query in the description (Smith) as well when testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 21:39:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 19:39:24 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-Liy3d3uRFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes searching
      release notes|                            |authorities when using ICU*
                   |                            |so that 'starts with'
                   |                            |searching works correctly.
                   |                            |Before this, a 'starts
                   |                            |with' search would return
                   |                            |the same results as
                   |                            |'contains'.
                   |                            |
                   |                            |Technical
                   |                            |details: this adds the
                   |                            |"complete field" to the
                   |                            |authority "starts with"
                   |                            |search so that it uses the
                   |                            |untokenized "p" register.
                   |                            |
                   |                            |(* ICU is a feature of the
                   |                            |Zebra search engine that
                   |                            |can be configured to make
                   |                            |searching with non-latin
                   |                            |languages (such as Chinese
                   |                            |and Arabic) work
                   |                            |correctly.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 23:28:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 21:28:21 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-Hi1CufVTQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul  3 23:28:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 21:28:26 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-lQTeST8Es2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134457|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <david at davidnind.com> ---
Created attachment 137050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137050&action=edit
Bug 15187: Index 880 in Zebra the same as Elasticsearch

This patch modifies the MARC21 export to Zebra, so that 880 fields
are rewritten as their linked fields, in the same way that we
already do with Elasticsearch, so that the alternate graphic
representation of fields are indexed accordingly. (ie 880 $6245-01
Chinese titles will be indexed into the title index using the 245 rules)

Test plan:
0. Apply patch
1. Turn on ICU indexing
1b. vi /etc/koha/zebradb/etc/default.idx
1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml
1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml
1e. Restart Zebra server
1f. Re-index Zebra
2. Add record with a 880 $6 245-01 $a 教牧書信 field.
3. Search for this record using a title index with the Chinese title
4. Note that the record is correctly retrieved

(Note: This test probably works better using author or series as they
 present as links on the detail page which makes the fix more obviously
 useful.)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 00:02:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 22:02:46 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-wSUBogesyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the Zebra search
      release notes|                            |engine when using ICU* so
                   |                            |that 880 fields are
                   |                            |rewritten as their linked
                   |                            |fields and the alternate
                   |                            |graphic representation of
                   |                            |fields are indexed, in the
                   |                            |same way that it works for
                   |                            |Elasticsearch.
                   |                            |
                   |                            |Example:
                   |                            |add 245-01 to 880$6 and
                   |                            |教牧書信 to 880$a - the Chinese
                   |                            |characters are now indexed
                   |                            |into the title index using
                   |                            |the 245 rules.
                   |                            |
                   |                            |* ICU is a
                   |                            |feature of the Zebra search
                   |                            |engine that can be
                   |                            |configured to make
                   |                            |searching with non-latin
                   |                            |languages (such as Chinese
                   |                            |and Arabic) work correctly.
                 CC|                            |david at davidnind.com

--- Comment #21 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Setting up ICU: see comment 16 (notes 1 and 2) for bug 11158

2. Needed to update the bibliographic framework for books (BKS) to make 880$6
and 880$a visible in the editor.

3. Not related to this bug, but I did try to import the attached MARC records,
but it stalled on Staged MARC record management screen, and still shows as
importing (there are some other current bugs about issues with importing
records).

Error in the logs:

[2022/07/03 21:25:48] [WARN] Filehandle STDOUT reopened as $fh only for input
at /usr/share/perl5/DateTime/TimeZone/Local/Unix.    pm line 155.
  2  main::__ANON__ /kohadevbox/koha/tools/manage-marc-import.pl (331)
  3 [2022/07/03 21:25:48] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI
Exception: DBD::mysql::st execute failed: Cannot ad    d or update a child row:
a foreign key constraint fails (`koha_kohadev`.`items`, CONSTRAINT
`items_ibfk_2` FOREIGN KEY (`homebr    anch`) REFERENCES `branches`
(`branchcode`) ON UPDATE CASCADE) at /kohadevbox/koha/Koha/Object.pm line 170
  4  main::__ANON__ /kohadevbox/koha/tools/manage-marc-import.pl (331)

4. I had a go at the release notes text - feel free to edit!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 00:49:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 22:49:14 +0000
Subject: [Koha-bugs] [Bug 31094] New: day
Message-ID: <bug-31094-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31094

            Bug ID: 31094
           Summary: day
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: santrinakal757 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 137051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137051&action=edit
Anjay

anjay

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 01:55:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Jul 2022 23:55:56 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-3ClqKHQ77U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #26 from David Nind <david at davidnind.com> ---
This is now signed off by Katrin, but here are my testing notes for what they
are worth!

I'm not very familiar with analytical records, and I wasn't sure whether the ?
should be in the host record or the child/analytical record.

I tried combinations for the host record and the child/analytical record, and
for both.

I haven't changed the bug status.

(Hopefully, I recorded my observations correctly!)

Testing notes using koha-testing-docker
=======================================

Starting 21.05.x instance:
a) For Koha repository, git checkout 21.05.x
b) Edit koha-testing-docker .env file and change IMAGE=master to IMAGE=21.05

Set up an analytical record:
a) Enable the EasyAnalyticalRecords system preference
b) For any record, select Edit > Link to host record - choose any other record
(I tested with a record that had an item already attached to it)
c) For the record chosen as the host item, add a ? to the title

Used two records for testing:
- Host record: Programming Perl (biblionumber = 262)
- Child/analytical record: Perl best practices (biblionumber = 5)

Before the patch is applied
~~~~~~~~~~~~~~~~~~~~~~~~~~~

1. If only the host record has a ? in the title:
  - Viewing the host record in the staff interface - error displayed before the
title: "There was an error searching for analytic records, please see the logs
for details."
  - Viewing the host record in the OPAC - no visible error message displayed
(like in the staff interface), but there is an error message in the
/var/log/koha/kohadev/plack-opac-error.log log file:
    [2022/07/03 22:39:46] [WARN] CCL parsing error (10014) Embedded truncation
not supported ZOOM for query: Host-item=(Programming ? Perl /) at
/kohadevbox/koha/C4/Search.pm line 241.
    [2022/07/03 22:39:46] [WARN] Warning from simple_search_compat: CCL parsing
error (10014) Embedded truncation not supported ZOOM at
/kohadevbox/koha/opac/opac-detail.pl line 208.

2. If only the child/analytical record has a ? in the title:
   - Staff interface: 
     . Host record displays 'Analytics: Show analytics'
     . Clicking on 'Show analytics' link displays the child/analytical record
     . Error displayed before the title in the child/analytical record: "There
was an error searching for analytic records, please see the logs for details."
   - Viewing the host record in the OPAC
     . no error displayed
     . displays 'Analytics: Show analytics'
     . clicking on show analytics: child/analytical record displayed with no
error, but error in the logs as per 1
   - Viewing the child/analytical record in the OPAC:
     . no error displayed
     . but error in the logs as per 1

3. Both the host and child/analytical record have a ? in the title:
   . same as 1 for both the host and child/analytical record

After the patch is applied
~~~~~~~~~~~~~~~~~~~~~~~~~~

1. If only the host record has a ? in the title:
   - Staff interface:
     . Host record shows 'Analytics: Show analytics', no error messages
     . Clicking on the 'Show analytics' link: No results match your search for
'Host-item:(Programming ? Perl )'. 
     . Error in the /var/log/koha/kohadev/plack-intranet-error.log log file:
       [2022/07/03 23:40:01] [WARN] WARNING: query problem with
Host-item=(Programming ? Perl ) ZOOM error 10014 "CCL parsing error" (addinfo:
"Embedded truncation not supported") from diag-set 'ZOOM' at
/kohadevbox/koha/C4/Search.pm line 349.
   - OPAC:
     . Host record shows 'Analytics: Show analytics'
     . Error message in the /var/log/koha/kohadev/plack-opac-error.log log
file:
        [2022/07/03 23:41:25] [WARN] WARNING: query problem with
Host-item=(Programming ? Perl ) ZOOM error 10014 "CCL parsing error" (addinfo:
"Embedded truncation not supported") from diag-set 'ZOOM' at
/kohadevbox/koha/C4/Search.pm line 349.
        [2022/07/03 23:41:25] [WARN] Use of uninitialized value $times in
subtraction (-) at /kohadevbox/koha/C4/Search.pm line 1709.

2. If only the child/analytical record has a ? in the title: works as expected,
no errors in the log

3. Both the host and child/analytical record has a ?:
   - Staff interface and OPAC:
     . Host record shows 'Analytics: Show analytics'
     . Clicking on the 'Show analytics' link: No results match your search for
'Host-item:(Programming ? Perl )'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 02:08:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 00:08:44 +0000
Subject: [Koha-bugs] [Bug 13901] sort1 and sort2 not on self registration
 form
In-Reply-To: <bug-13901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13901-70-wDC5YedQCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13901

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
I might have to take another look at this...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 02:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 00:21:58 +0000
Subject: [Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on
 the bibliographic detail page
In-Reply-To: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27685-70-8pJg2w49RH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #13)
> 'In discussion' without any argument is a bit mean :)

I thought it was gentler than marking Resolved Invalid 😅

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 02:40:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 00:40:24 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-bNAecA99mT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 06:24:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 04:24:13 +0000
Subject: [Koha-bugs] [Bug 31094] SPAM
In-Reply-To: <bug-31094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31094-70-RwjiUQJ90k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31094

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|day                         |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 08:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 06:21:29 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-l44MUUYZx1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #81 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Fridolin Somers from comment #79)
> > Bug 30952: css generation
> This looks like the compiles CSS from SCSS, you should not attach a patch
> for that, it is compiled by testers :
> https://wiki.koha-community.org/wiki/
> Working_with_SCSS_in_the_OPAC_and_staff_interface

I used to attach the result of SCSS compilation as a separate patch, to ease
testing (especially on sandboxes). It's not something we do anymore ?

Anyway, we are still working on the patches (to fix bad conflict resolutions
that happened during rebase). Fixed patches should be attached later this day,
please be patient :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 08:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 06:27:00 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-gVjSeVAHSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, strange. The hos record having a ? case worked for me. Vut I had added the
? a the end of the string, maybe it could make a difference?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 08:34:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 06:34:32 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-NplMbdBkUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #28 from David Nind <david at davidnind.com> ---
(In reply to Katrin Fischer from comment #27)
> Hm, strange. The hos record having a ? case worked for me. Vut I had added
> the ? a the end of the string, maybe it could make a difference?

I had added the ? in the middle of the title.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 08:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 06:36:25 +0000
Subject: [Koha-bugs] [Bug 29354] overdue_notices.pl should be able to send
 an attachment as HTML
In-Reply-To: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29354-70-1MjQ4aVkBy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Lucas Gass from comment #2)
> (In reply to Marcel de Rooy from comment #1)
> > I opened bug 31075 for a wider scope
> 
> Thanks Marcel, in that case should we mark this one as a duplicate of Bug
> 31075?

I would wait a while :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 08:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 06:52:57 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-O4ai6i2XI9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 09:42:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 07:42:34 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-rhDRzYuG9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 10:16:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 08:16:26 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-zocJNMxkXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 10:16:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 08:16:30 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-DkATCylNZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136555|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137052&action=edit
Bug 29958: Do not set dateaccessioned on updates

This patch reomves the second occurence of setting daeaccessioned today,
outside of the 'add/update' handling in Koha::Item->store.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 10:16:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 08:16:45 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-ulabNgKoLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 10:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 08:20:05 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-lrKNibXG4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Martin: Any chance of adding a dbrev that is able to clear the date for these
records too?
For instance, we use the date to do acquisition reporting on year/month; and
these data are useless now since we have a lot of old records without the date
and checkins/checkouts now have added the date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 10:54:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 08:54:33 +0000
Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50
 filter
In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30966-70-BOOrbwXuez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

--- Comment #3 from Björn Hellberg <bjornbibblan at gmail.com> ---
We've now edited the code as suggested, but it didn't work. All fields are
protected except when replacing record via Z39.50/SRU search; if I replace the
record this way, the fields that I've listed as protected are also edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 11:02:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 09:02:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-2dBQTYtZVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
There is now a simple option to build the CSS from the sandbox manager so the
compiled CSS patch isn't required.

Personally, I was OK either way, so long as the compilation patch was distinct
(as it's almost always a rebase issue, and is easier to just skip and rebuild
when it's on it's own).

Looking forward to playing with this.. I assume, given rebases are challenging,
we're wanting to get testing done pretty quick... Adding myself to CC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 11:22:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 09:22:27 +0000
Subject: [Koha-bugs] [Bug 31095] New: Koha::Patron::Debarment should be
 updated to follow current Koha:: style
Message-ID: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

            Bug ID: 31095
           Summary: Koha::Patron::Debarment should be updated to follow
                    current Koha:: style
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The Koha::Patron::Debarment module is written in the C4 style when it should
really be a Koha::Object based class now.

We should update it to the modern practices to enable simple addition of API's
and more standard use codebase wide.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 11:22:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 09:22:41 +0000
Subject: [Koha-bugs] [Bug 31095] Koha::Patron::Debarment should be updated
 to follow current Koha:: style
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-LR7QRtWT3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
         Depends on|                            |23681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Patron restrictions should be user definable
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 11:22:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 09:22:41 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-VrlufD2ZNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31095


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095
[Bug 31095] Koha::Patron::Debarment should be updated to follow current Koha::
style
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 11:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 09:22:55 +0000
Subject: [Koha-bugs] [Bug 31095] Koha::Patron::Debarment should be updated
 to follow current Koha:: style
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-Ciba7iYpOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:00:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:00:22 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-4CPRLBfVgF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #224 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting QA here:

0) Tests pass. QA script complains a lot about "added and removed in the same
patch set", we could consider some squashing. Database update is missing
execute permission.

1) The new patron restrictions configuration page is missing from the
Administration side menu, visible when you are on any of the admin pages. It's
ok on the start page of the module.

2) The delete confirmation question is missing a question mark :) (also might
want to remove the additional spaces)
Are you sure you want to delete " Test "

I'd also make the button just "Delete" or "Yes, delete", but that's a personal
preference and I see that this was 'copied' from how deleting a patron category
looks like.

3) After installing/updating with this patch, MANUAL is marked es the default.
You cannot change it, until you have added a new restriction, which makes
sense, as the system internal ones should not be default. But: you cannot ever
change the default back to MANUAL. I think this is because system internal
values are excluded, but it might raise complaints for people experimenting
with the feature that want to restore previous behavior.

4) Just a comment: Love the new Patron restrictions sub heading in patron
preferences :)

5) When adding a manual restriction to the patron account, the default seems to
be only used when PatronRestrictionTypes is off, when it's on and the pull down
shows, the default is not preselected, but the first entry is. 

6) Something super odd: In the patron account in the staff interface, on the
checkout tab, the Restrictions shows as (0), while on the details tab the
restrictions show the correct number (2) I have added. Only the tab heading is
wrong, otherwise the restrictions show ok.

7) When editing the patron record, the pull down for restriction type is empty.

8) I notice that the type itself doesn't show up in the OPAC or the note on the
patron account in staff, just the comments do. This is the case with and
without the patches, maybe something so consider later. Or we could imagine
adding a default comment? (no blocker, just loud thinking)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:06:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:06:41 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uIvIJ7y5HW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #83 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Can we also have a list of the changes we are expecting from these patches?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:23:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:23:20 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-dSwzubL9C7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137053&action=edit
Bug 31080: Unit tests

Unit tests for add_to_bundle functionality that prevents bundle nesting.

Test plan
1) Run t/db_dependent/Koha/Item.t
2) The test should fail
3) Apply the second patch
4) Re-run the test and watch it pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:23:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:23:24 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-DPSdWKaWTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136975|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137054&action=edit
Bug 31080: Prevent bundles from being nested

This is a follow-up for bug 28854 to prevent bundle type items from
being nested in to other bundles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:23:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:23:50 +0000
Subject: [Koha-bugs] [Bug 31080] Block adding the bundle item to its own
 bundle
In-Reply-To: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31080-70-PtyVkb1CWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Unit tests added and corrections made to adjust for feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:48:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:48:29 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-ZzrDAQo4hX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I don't think we can separate the accidental updates from the intended ones -
so not sure how a database update could be written?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:51:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:51:51 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-KqFTmo8s7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137055&action=edit
Bug 31083: Fix part_name handling in js-biblio-format

This patch corrects the typo introduced in bug 28854 for part_name
handling in the js-biblio-format include.  We also introduce proper
whitespace addition when concatenating subtitle, medium and parts to the
title string.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:52:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:52:04 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-Nw7KwCkmmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 12:53:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 10:53:10 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-sFYErKS7WD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good catch.. I hadn't tested the part_name piece of this and had introduced a
typo!

I also add in some whitespace handling for the various title parts as prior to
now the title and subtitle and other fields would all be concatenated without
spaces between.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 13:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 11:07:18 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-nyCFd7c87g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #225 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #224)
> Starting QA here:
> 
> 0) Tests pass. QA script complains a lot about "added and removed in the
> same patch set", we could consider some squashing. Database update is
> missing execute permission.

I think this is a QA script mis-identification.. the file it mentions is also
mentioned in the git manip.. i.e. it no longer exists and the remaining renamed
file does have the exec bit set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 13:10:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 11:10:02 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-leB9s1kaVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #226 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #225)
> (In reply to Katrin Fischer from comment #224)
> > Starting QA here:
> > 
> > 0) Tests pass. QA script complains a lot about "added and removed in the
> > same patch set", we could consider some squashing. Database update is
> > missing execute permission.
> 
> I think this is a QA script mis-identification.. the file it mentions is
> also mentioned in the git manip.. i.e. it no longer exists and the remaining
> renamed file does have the exec bit set.

I think you are right about this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 13:57:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 11:57:55 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-XOwJoCY9ts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #16)
> I don't think we can separate the accidental updates from the intended ones
> - so not sure how a database update could be written?

I was thinking that we had a trace of eg a checkin/checkout and an item store
but unfortunately the latter is missing:

$issue->item->onloan(undef)->store({ log_action => 0, skip_record_index =>
$params->{skip_record_index} });
(from MarkIssueReturned)

If we would have had both, we could make an educated guess. But if we only have
an checkin or checkout without an item modification trace, I am afraid that it
is not possible.

Any more thoughts? Heading to the old database dumps ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:15:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:15:09 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-MkL9SCNm2e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:15:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:15:13 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-1lLSagMELz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137038|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137056&action=edit
Bug 30785: Fixed typo in SIP2SortBinMapping

To test:
1. Go to the admin page.
2. Search for the above preference.
3. Confirm that "Will" is now spelled correctly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:15:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:15:30 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-Gkkpjf15af@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
            Version|20.11                       |unspecified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:18:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:18:43 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-ZkpLT7uhta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Fridolin Somers from comment #12)
> I do reproduce.
> 
> Searching for bööks.
> 
> Browsing from result n°18 to n°19 then n°20 does not break encoding.
> Browsing from result n°20 to n°19 breaks encoding.
> Browsing from result n°19 to n°18 does not break encoding.
> 
> o_O

With or without the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:21:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:21:43 +0000
Subject: [Koha-bugs] [Bug 28151] Missing documentation on variable
 "access_dir"
In-Reply-To: <bug-28151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28151-70-qzhL6usLON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28151

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:23:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:23:25 +0000
Subject: [Koha-bugs] [Bug 30980] Make patron selection more consistent
In-Reply-To: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30980-70-uMat2T6B9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30980

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't know, I guess we should ask end users.

Adding the complete forms will add more clicks (open popup, search, select).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:25:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:25:25 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-xJmFFgW87O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137057&action=edit
Bug 15348: (follow-up) Fix TT filters from html to uri

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:45:01 +0000
Subject: [Koha-bugs] [Bug 28151] Missing documentation on variable
 "access_dir"
In-Reply-To: <bug-28151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28151-70-lTkcIyZWGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28151

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The access_dir is used as the path or paths for the "Access file" tool, there
is no other use I am aware of.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:47:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:47:37 +0000
Subject: [Koha-bugs] [Bug 30920] Add caching to
 C4::Biblio::GetAuthorisedValueDesc
In-Reply-To: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30920-70-yNzhGxjTMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am sorry but I don't manage to convince myself that we are doing it
correctly.

I think this change is coming whereas we don't use the same code to display the
descriptions, and it could lead to confusion (theoretically at least): fetch
from cache and fetch from DB.

There is at least one thing that could go wrong, itemtype's descriptions. First
we only deal with 'en', then it is actually wrong with 'en': it could be
overwritten by the "Translate into other languages" feature (yes that's a weird
use case but the UI allows it).

Also comment 6 hasn't been addressed.

Letting it for another QAer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:51:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:51:27 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-95qEWbBVbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #28)
> (In reply to Katrin Fischer from comment #27)
> > Hm, strange. The hos record having a ? case worked for me. Vut I had added
> > the ? a the end of the string, maybe it could make a difference?
> 
> I had added the ? in the middle of the title.

Hi, the internal analytics search works correctly, but a follow-up is required
for the XSLT to generate a good link. I overlooked it. Working on it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:53:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:53:44 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-Mc718ZdyrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137058&action=edit
Bug 15348: (follow-up) Fix export of dt_from_string

FAIL    acqui/addorder.pl
   FAIL   valid
          " dt_from_string " is not exported by the Koha::DateUtils module
          Can't continue after import errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:54:12 +0000
Subject: [Koha-bugs] [Bug 31062] Change description of QOTD tool in
 tools-home
In-Reply-To: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31062-70-DEdRdjgeHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062

--- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
This will need an update of the manual. I'm not sure in the new workflow when
this is supposed to be changed to "Needs documenting".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:54:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:54:34 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-ApOfUufSxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27857

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Coming from bug 27857 comment 5 (and 6).


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857
[Bug 27857] Koha::Patron->extended_attributes skips checks
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:54:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:54:34 +0000
Subject: [Koha-bugs] [Bug 27857] Koha::Patron->extended_attributes skips
 checks
In-Reply-To: <bug-27857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27857-70-xQqipCqudG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31032


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032
[Bug 31032] Patron attributes branch limitations are unclear
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 14:57:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 12:57:36 +0000
Subject: [Koha-bugs] [Bug 31062] Change description of QOTD tool in
 tools-home
In-Reply-To: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31062-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31062-70-tcX8JS56pZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31062

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Caroline Cyr La Rose from comment #9)
> This will need an update of the manual. I'm not sure in the new workflow
> when this is supposed to be changed to "Needs documenting".

The last RMaint to look at this will set 'Needs documenting'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:00:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:00:21 +0000
Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
 format show the incorrect format
In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30567-70-wpflh3LxeH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:00:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:00:26 +0000
Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
 format show the incorrect format
In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30567-70-hpujVEfwv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136335|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137059&action=edit
Bug 30567: Fix price formatting when adding a manual invoice with
CurrencyFormat FR

In input fields we always use the decimal . while the display format
uses the decimal separtor definded by CurrencyFormat. When adding a
manual invoice without this patch, the amount is shown with comma, but
it should be . in the input field.

To test:
1- Go in Administration->Debit types
2- Click on New debit type
3- Fill the form:
   Code: USEDBOOK
   Default amount: 0.50
   Description: Used book
   Can be manually invoiced: Yes
4- Save
5- Go to any patron account
6- Go to the "Accounting" tab
7- Click on "Create manual invoice"
8- Fill the form
9- Choose the created debit (Used book)
10- Verify that the format is incorrect (0,50 instead of 0.50)
11- Apply the patch
12- Verify the amount is now using the correct format

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:02:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:02:37 +0000
Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
 format show the incorrect format
In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30567-70-ll6h1u9kxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Assignee|the-minh.luong at inlibro.com  |katrin.fischer at bsz-bw.de
         QA Contact|testopia at bugs.koha-communit |jonathan.druart+koha at gmail.
                   |y.org                       |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:09:04 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-WUX7RrMmxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:09:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:09:09 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-IjHbTM5rBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136538|0                           |1
        is obsolete|                            |
 Attachment #136539|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137060&action=edit
Bug 24010: Number of issues to display to staff accepts non-integer values

This patch modifies the subscription entry form so that it will perform
a check on the staffdisplaycount and opacdisplaycount fields before
proceding to the second step. It verifies that the values are numeric.

The changes are made in the style of the existing form validation, which
should be rewritten to either use the validation plugin or to peform
checks in a way that all checks are run before warning the user.
However, this smaller change will work in the meantime.

To test, apply the patch and go to Serials -> New subscription.

- Fill out the form with at least the required fields, but put something
  other than a number if the "Number of issues to display to staff" and
  "Number of issues to display to the public" with non-numeric characters.
- When you click the "Next" button you should get an error message,
  "Number of issues to display to staff must be a number."
- Correct the issues to display to staff field and submit again.
- You should get a different error message, "Number of issues to display
  to the public must be a number."
- Correct this field and you should be able to proceed to the next step.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:09:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:09:09 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-E4qAqynpBo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137061&action=edit
Bug 15348: (QA follow-up) Fix useless use of proviate variable in void context

FAIL    acqui/moddeliverydate.pl
   FAIL   valid
          Useless use of private variable in void context

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:09:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:09:15 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-K0m7FgFU8i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137062&action=edit
Bug 24010: DB Changes

Amended-patch: adjusted to new atomic update format

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:09:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:09:35 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-R5DwZUTMnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

--- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:11:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:11:49 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-DiX7xcGir0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137061|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:16:04 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for sms transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-YN3ojD8uIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Can you add a test for this change, please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:21:55 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-OU1kiVt814@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

--- Comment #16 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137063&action=edit
Bug 29922: (follow-up) Remove extra sort

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:24:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:24:52 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-2m87kAPmyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137063|0                           |1
        is obsolete|                            |

--- Comment #17 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137064&action=edit
Bug 29922: (follow-up) Remove extra sort

Remove wrong sort in staff advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:25:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:25:49 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-cYLaWWw8da@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #18 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
It should now sort properly in the staff interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:38:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:38:09 +0000
Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details
 page
In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29393-70-cLcXzlFkUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393

Rachael <rachael.laritz at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |rachael.laritz at inlibro.com

--- Comment #17 from Rachael <rachael.laritz at inlibro.com> ---
patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:51:44 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-NYVj1kzuJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

--- Comment #24 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137065&action=edit
Bug 30556: (follow-up) Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:52:16 +0000
Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available
 items even if on shelf holds aren't allowed
In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30556-70-1D5SzgTs9y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 15:56:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 13:56:41 +0000
Subject: [Koha-bugs] [Bug 31096] New: [DOCS] Review and update acquisitions
 chapter
Message-ID: <bug-31096-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096

            Bug ID: 31096
           Summary: [DOCS] Review and update acquisitions chapter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

Review and update acquisitions chapter to bring up to date.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:20 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-ripuh4Qm8b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136716|0                           |1
        is obsolete|                            |

--- Comment #227 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137066&action=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:26 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-aeBW0jkLWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136717|0                           |1
        is obsolete|                            |

--- Comment #228 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137067&action=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:32 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-U8QAc5eMNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136718|0                           |1
        is obsolete|                            |

--- Comment #229 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137068&action=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:40 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-RzMqQEgvAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136719|0                           |1
        is obsolete|                            |

--- Comment #230 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137069&action=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:46 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-PWBV6yXwEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136720|0                           |1
        is obsolete|                            |

--- Comment #231 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137070&action=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:52 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-f8JG7IYf9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136721|0                           |1
        is obsolete|                            |

--- Comment #232 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137071&action=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:18:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:18:58 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-0V2QzQXfMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136722|0                           |1
        is obsolete|                            |

--- Comment #233 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137072&action=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:05 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-M2MwR7RiMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136723|0                           |1
        is obsolete|                            |

--- Comment #234 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137073&action=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:11 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-rz8Ypt6vn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136724|0                           |1
        is obsolete|                            |

--- Comment #235 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137074&action=edit
Bug 23681: Add unit tests

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:17 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-4D9H5o1CL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136725|0                           |1
        is obsolete|                            |

--- Comment #236 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137075&action=edit
Bug 23681: (follow-up) Fix typo

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:23 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-G3gizaZmWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136726|0                           |1
        is obsolete|                            |

--- Comment #237 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137076&action=edit
Bug 23681: (follow-up) Fix rebase issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:29 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-zPvTqV2ybJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136727|0                           |1
        is obsolete|                            |

--- Comment #238 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137077&action=edit
Bug 23681: (QA follow-up) Allow for translations

This patch allows for existing translations to follow through if
debarment type descriptions are left unaltered for the default types.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:35 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-HLuz9olYn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136728|0                           |1
        is obsolete|                            |

--- Comment #239 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137078&action=edit
Bug 23681: Updates for bug 26703

This patch fixes the title ordering and also replaces the breadcrumbs
with the modern nav block equivilent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:41 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-9n4Gg6Tc6p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136729|0                           |1
        is obsolete|                            |

--- Comment #240 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137079&action=edit
Bug 23681: (QA follow-up) Fix license, perlcritic & executable

This patch fixes the simple issues mentioned by the QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:48 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-6pexTciyl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136730|0                           |1
        is obsolete|                            |

--- Comment #241 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137080&action=edit
Bug 23681: (QA follow-up) Rename columns

Renames ronly to readonly and dflt to is_system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:19:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:19:54 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-RD6JMajn5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136731|0                           |1
        is obsolete|                            |

--- Comment #242 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137081&action=edit
Bug 23681: (QA follow-up) Fix prefs

Add the missing `.` and switch from `yes/no` to `1/0`.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:00 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-jziyhkf86r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136732|0                           |1
        is obsolete|                            |

--- Comment #243 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137082&action=edit
Bug 23681: Fix QA issues

This patch fixes following QA issues:
- convert intaller files as .yml
- change column name readonly as is_system
- change column name is_system as default_value
- add column can_be_added_manually (testplan for this below)
- move syspref "PatronRestrictionTypes" to "Accounting > Features" tab
- tweak page title
- tweak tests to apply these changes

Also atomicupdate files have been updated. Issues with delete and tests
is fixed with adding additional schema change file.

To test:
1) Add new restriction type and make it manual.
2) Navigate to patron details page.
3) Add new restriction to patron.
=> Only selectable restriction should be the one
you just created.

Also prove t/db_dependent/RestrictionTypes.t.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:09 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-jyJaR2ZJpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136733|0                           |1
        is obsolete|                            |

--- Comment #244 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137083&action=edit
Bug 23681: DO NOT PUSH! Schema changes

To be able to delete and pass tests we need to declare
koha_object[s]_class to DebarmentType.pm. Otherwise
following error is raised:

"Can't locate object method "_new_from_dbic" via package
"Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?)
at /kohadevbox/koha/Koha/Object.pm line 237"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:16 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-Ftt1gFQPtV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136734|0                           |1
        is obsolete|                            |

--- Comment #245 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137084&action=edit
Bug 23681: (QA follow-up) Move preference again

This patch removes the new PatronRestrictionTypes preference from the
accounting area in preference to creating a new group for 'Patron
restriction' related preferences in the circulation preferences tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:23 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-59OBu3zAer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136735|0                           |1
        is obsolete|                            |

--- Comment #246 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137085&action=edit
Bug 23681: (QA follow-up) Restore customisablity of description

This patch restores the customisability of description for system restriction
types. Translatability is not affected as you can translate the defaults
via template translation and assuming the end users leave their
descriptions at the default, the translations will be picked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:30 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-7PIIThsFvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136736|0                           |1
        is obsolete|                            |

--- Comment #247 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137086&action=edit
Bug 23681: (QA follow-up) Merge update files

This patch merges the three atomic update files into one and also
adds a check for foreing key existance to make the update idempotent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:36 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-2cjhrrVpt0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136737|0                           |1
        is obsolete|                            |

--- Comment #248 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137087&action=edit
Bug 23681: (QA follow-up) Proper handling of default option

This patch removes the 'can_be_added_manually' flag. Only non-system
restriction types can be added manually, so we exclude is_system instead
of having two flags. (And we set the 'Manual' that's added at install
time to default but not system).

We then add proper handling for setting the default manual restriction
type in the management page and set the dropdown list to use that value
by default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:43 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-pyGecOEEk5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136738|0                           |1
        is obsolete|                            |

--- Comment #249 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137088&action=edit
Bug 23681: DBIC Rebuild

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:49 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-iFD2wWxshd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136739|0                           |1
        is obsolete|                            |

--- Comment #250 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137089&action=edit
Bug 23681: (follow-up) Mark fields at booleans

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:20:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:20:56 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-8o0v48Lx4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #251 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137090&action=edit
Bug 23681: (QA follow-up) Add patron restrictions to admin menu

This patch adds the patron restrictions page to the admin menu that
appears to the left on all administration pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:21:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:21:02 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-OruwShTIr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #252 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137091&action=edit
Bug 23681: (QA follow-up) Remove spacing and add question mark

This patch removes the superflous whitespace around the restriction
descriptions and also adds the missing question mark into the delete
question.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:21:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:21:09 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-HLxXbkbw6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #253 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137092&action=edit
Bug 23681: (QA follow-up) Match default data to update

The default data at install time didn't match the data added at update.

This patch corrects that and by doing so it also adds back the ability
to make MANUAL restriction types the default after any other type has
been made default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:21:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:21:15 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-reonNEkeMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #254 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137093&action=edit
Bug 23681: (QA follow-up) Fix debarment count

This patch fixes the debarment count displayed on the circulation page
tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:21:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:21:22 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-ZkVygIdPJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #255 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137094&action=edit
Bug 23681: (QA follow-up) Fix memberentry page display

We were missing some changes to the restriction types dropdown handling
in the memberentry template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:26:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:26:49 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-oSpLYeGnni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #256 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #224)
> 1) The new patron restrictions configuration page is missing from the
> Administration side menu, visible when you are on any of the admin pages.
> It's ok on the start page of the module.

Fixed in follow-up

> 2) The delete confirmation question is missing a question mark :) (also
> might want to remove the additional spaces)
> Are you sure you want to delete " Test "

Fixed in follow-up

> I'd also make the button just "Delete" or "Yes, delete", but that's a
> personal preference and I see that this was 'copied' from how deleting a
> patron category looks like.

Hmm, I'd love to see us standardise on something and create a guideline about
it.. at that time I'd be keen to go through and get everything consistent.

> 3) After installing/updating with this patch, MANUAL is marked es the
> default. You cannot change it, until you have added a new restriction, which
> makes sense, as the system internal ones should not be default. But: you
> cannot ever change the default back to MANUAL. I think this is because
> system internal values are excluded, but it might raise complaints for
> people experimenting with the feature that want to restore previous behavior.

I discovered the update and the install data were out of sync.. fixed in a
follow-up. This resolves the defaulting issue.

> 4) Just a comment: Love the new Patron restrictions sub heading in patron
> preferences :)

Glad you like it :)

> 5) When adding a manual restriction to the patron account, the default seems
> to be only used when PatronRestrictionTypes is off, when it's on and the
> pull down shows, the default is not preselected, but the first entry is. 

Hmm, I couldn't replicate this.

> 6) Something super odd: In the patron account in the staff interface, on the
> checkout tab, the Restrictions shows as (0), while on the details tab the
> restrictions show the correct number (2) I have added. Only the tab heading
> is wrong, otherwise the restrictions show ok.

Unrelated to this patchset I believe.. bit it is fixed in a follow-up now.

> 7) When editing the patron record, the pull down for restriction type is
> empty.

Fixed in follow-up.

> 8) I notice that the type itself doesn't show up in the OPAC or the note on
> the patron account in staff, just the comments do. This is the case with and
> without the patches, maybe something so consider later. Or we could imagine
> adding a default comment? (no blocker, just loud thinking)

Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:28:31 +0000
Subject: [Koha-bugs] [Bug 31097] New: Patron restriction types should
 display in Staff and OPAC
Message-ID: <bug-31097-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097

            Bug ID: 31097
           Summary: Patron restriction types should display in Staff and
                    OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 23681

Where we display the patron restrictions in the OPAC and Staff client, we don't
always display the type description.. only the comment.

We should add this to the display.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Patron restrictions should be user definable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:28:31 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-njHywRi2KD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097
[Bug 31097] Patron restriction types should display in Staff and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:28:43 +0000
Subject: [Koha-bugs] [Bug 31097] Patron restriction types should display in
 Staff and OPAC
In-Reply-To: <bug-31097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31097-70-Id9Xc1crbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:30:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:30:33 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-jnVFTgvm1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #257 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #256)
> (In reply to Katrin Fischer from comment #224)
> 
> > I'd also make the button just "Delete" or "Yes, delete", but that's a
> > personal preference and I see that this was 'copied' from how deleting a
> > patron category looks like.
> 
> Hmm, I'd love to see us standardise on something and create a guideline
> about it.. at that time I'd be keen to go through and get everything
> consistent.

Agreed, I was just wondering, because in German such buttons tend to get huge.
> 
> > 3) After installing/updating with this patch, MANUAL is marked es the
> > default. You cannot change it, until you have added a new restriction, which
> > makes sense, as the system internal ones should not be default. But: you
> > cannot ever change the default back to MANUAL. I think this is because
> > system internal values are excluded, but it might raise complaints for
> > people experimenting with the feature that want to restore previous behavior.
> 
> I discovered the update and the install data were out of sync.. fixed in a
> follow-up. This resolves the defaulting issue.

Good catch! Will retest.

> > 5) When adding a manual restriction to the patron account, the default seems
> > to be only used when PatronRestrictionTypes is off, when it's on and the
> > pull down shows, the default is not preselected, but the first entry is. 
> 
> Hmm, I couldn't replicate this.

I'll retest.


> > 8) I notice that the type itself doesn't show up in the OPAC or the note on
> > the patron account in staff, just the comments do. This is the case with and
> > without the patches, maybe something so consider later. Or we could imagine
> > adding a default comment? (no blocker, just loud thinking)
> 
> Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one?

Yes, loud thinking definitely warrants a separate bug. I'd also not noticed
that before, but it's unchanged by this patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:37:42 +0000
Subject: [Koha-bugs] [Bug 30526] The pagination in the REST API does not
 work if $c->objects->search is called multiple times.
In-Reply-To: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30526-70-s9dzRThLuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526

--- Comment #5 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
It seems that the issue at hand have been accidentally fixed.

Let me propose a simpler test plan:

* Open up Koha/REST/Plugin/Query.pm and look at the subroutine _build_link
* Observe that the subroutine overwrites $args->{params}->{_page} and
$args->{params}->{_per_page}
* Ponder for a second over how one can reasonable expect that these parameters
remain unchanged for the duration of the request.
* Ponder for a second over how this unexpected modification of the parameters
might have caused the issue at hand, how it might be causing other undiscovered
issues and how it may cause issues with code yet to be written.
* Ponder for a second over how no sane programmer could have written any code
which, outside of the subroutine _build_link, relies on this unexpected update
of the parameters.
* Ponder for a second over how the proposed patch unburdens you from these
concerns.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:44:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:44:11 +0000
Subject: [Koha-bugs] [Bug 31096] [DOCS] Review and update acquisitions
 chapter
In-Reply-To: <bug-31096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31096-70-nvW8y5PEAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual-updated
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
           Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr
                   |ity.org                     |o.com
         Depends on|                            |28082

--- Comment #1 from David Nind <david at davidnind.com> ---
Complete review and update of the acquisitions chapter by Caroline Cyr La Rose,
now updated to current master (22.06) and merged into the manual.

This includes:
- image updates
- related changes to the administration chapter
- fixes to formatting in the administration chapter (warnings and notes)
- acquisition permissions in the patrons chapter
- various doc build errors
- stage and import MARC records in the tools chapter
- Bug 28082: Add acquisitions toolbar to vendors on vendor search page


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082
[Bug 28082] Add acquisitions toolbar to vendors on vendor search page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:44:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:44:11 +0000
Subject: [Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on
 vendor search page
In-Reply-To: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28082-70-Pptfmi32d0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31096


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31096
[Bug 31096] [DOCS] Review and update acquisitions chapter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 16:55:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 14:55:09 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-kky9tT5wb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:13:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:13:10 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-qyLqjYzfwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137095&action=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:17:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:17:13 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-NyIKTsYzjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136582|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137096&action=edit
Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup

This patch adds more information about the patron's account on the
curbside pickup list view.
"Patron's account is restricted" if the patron is restricted
"Patron has items overdue" if the patron has overdues

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:21:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:21:21 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-tMY7ehcgfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136583|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137097&action=edit
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:27:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:27:51 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-Q8okviu4qt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137098&action=edit
Bug 15348: (follow-up) Fix imports in moddeliverydate.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:36:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:36:24 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-GpcK51GJaC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137099&action=edit
Bug 15348: (follow-up) Update calendar widget to flatpickr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:39:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:39:41 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-9v7rp2456M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137095|0                           |1
        is obsolete|                            |

--- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137100&action=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:42:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:42:20 +0000
Subject: [Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on
 the bibliographic detail page
In-Reply-To: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27685-70-ISfQtENOR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

--- Comment #15 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
I confirm that the problem seems to be solved (for both Zebra and Elastic
Search).

In prod (indexed with Zebra) :
example with biblionumber 3652 wich has the Suppress field enabled (099$0 = 1).
Searching with the terms "Einstein 1905" does not get this title in the
results.
Searching for detailed page
"https://catalogue.univ-lyon3.fr/cgi-bin/koha/opac-detail.pl?biblionumber=3652"
get 404 error.

Same searches on our preprod instance (with Elastic search in test) : same
results.

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:45:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:45:42 +0000
Subject: [Koha-bugs] [Bug 28639] Embed see-from headings (from authorities)
 into bibliographic records at OAI repository level
In-Reply-To: <bug-28639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28639-70-kCQnCepNWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28639

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 17:51:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 15:51:28 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-vuNKmybvXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 

1) there were several complaints by the QA tools that I have fixed 2 in
separate follow-up patches. Could you please fix the third one? I have not been
able to figure this one out:

 FAIL   acqui/moddeliverydate.pl
   FAIL   valid
                Useless use of private variable in void context

2) This bit here is not translatable:

var modalTitle = $(this).attr("title") + " (order number " + ordernumber + ")";

3) When adding a new order, there is no calendar widget for the estimated
delivery date column. I have tried to do an update to flatpickr in a follow-up,
but I think it's not complete yet. 

I believe these type of lines need to be removed from the files as well:
$("#estimated_delivery_date").datepicker();

4) Looking for 'datepicker' in the code, I saw that there is code for a modal
in lateorders.tt, but it doesn't appear to be used, it looks like
moddeliverdatey.tt is used instead. A modal like the edit notes one on the same
page would really nice and more consistent:

            <div class="modal-content">
                <div class="modal-header">
                    <button type="button" class="closebtn" data-dismiss="modal"
aria-label="Close"><span aria-hidden="true">&times;</span></button>
                    <h4 class="modal-title" id="dateEditorLabel">Estimated
delivery date</h4>
                </div>
                <div class="modal-body">
                <input type="text" id="estimated_delivery_date" size="10"
name="estimated_delivery_date" class="datepicker" value="[%
estimated_delivery_date | html %]"/>
                <div class="hint">[% INCLUDE 'date-format.inc' %]</div>
                <input type="hidden" id="date_ordernumber" name="ordernumber"
value="" />
                <input type="hidden" name="op" value="save" />
            </div>

5) It's not possible to edit the estimated delivery date from a closed basket.
If you reopen and close the basket, the close date will be updated, that is
also used as the order date. So we need to be able to update this without
reopening.

6) When editing the delivery date from the late orders page, things would
explode. I fixed the import statements in a follow-up. Hope I caught them all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:11:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:11:28 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-EJebdYjCdi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #258 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

0) QA script + unit tests
RESOLVED

1) Side menu 
RESOLVED

2) Delete confirmation
RESOLVED

3) Default behavior / MANUAL
RESOLVED

4) :)

5) Pre-selection in pull down
Retested and RESOLVED. 

6) Number in restrictions tab
RESOLVED

7) When editing the patron record, the pull down for restriction type is empty.
RESOLVED

8) Show restriction type in places
MOVE to separate bug later :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:12:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:12:58 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-DSDLYIQaBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:13:00 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-59oeIWHnSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137101&action=edit
Bug 31068: Context for translation: Print (verb) vs. Print (noun)

This patch adds context to the term Print in the context of message transport
types (as opposed to printing something/print button), for translation
purposes.

To test:
0- Apply patch

Check the terms to be changed
1- Go to Tools > Notifications & slips
2- Edit a notification
** 3- In the tabs for different transport types, check the 'Print' term
(letter.tt)
4- Go to Tools > Overdue notice/status triggers
** 5- In the transport types, check the 'Print' column heading
(overduerules.tt)

Add a new language (fr-CA in the example, change for whatever language code you
want)
6- In a terminal, run
gulp po:create --lang fr-CA
7- Then, run
gulp po:update --lang fr-CA
8- In system preferences, enable the new language in language and OpacLanguages
9- Switch the language in staff interface and OPAC

Change the translations
10- In your favourite text editor, open fr-CA-messages.po
11- Find the string msgctxt "Message transport type"
12- Enter a word in msgstr
13- Save the file
14- In a terminal, go to misc/translator
15- Run
./translate install fr-CA

Check the translations
16- Redo the steps to check the terms (steps 1-5) and make sure the terms in
steps 3 and 5 are changed for the word you put in step 12.

17- Optionally, check the other pages where the term is supposed to be
unchanged and make sure it is unchanged

Check the terms to leave unchanged (optional)
18- Enable the HoldsAutoFill and UseCashRegisters system preferences
19- Go to Administration > Cash registers and create a cash register
20- Go to a patron's account
** 21- Check the 'Print' button in the menu bar or the patron's account
(members-toolbar.inc)
22- Go to the 'Accounting' tab
23- Create a manual invoice
** 24- In the 'Transactions' tab, check the 'Print' button in the fee line
(boraccount.tt)
25- Pay the fee (make sure to use the cash register)
** 26- In the 'Transactions' tab, check the 'Print' button in the payment line
(boraccount.tt)
27- At the top of the transactions table, click the 'Export' option
** 28- Check the 'Print' option (columns_settings.inc)
29- Go to the 'Check out' tab and check out an item
30- Go to the item's bibliographic record
** 31- Check the 'Print' button in the menu bar of the detailed record
(cat-toolbar.inc)
32- Add the record to the cart and open the cart
** 33- Check the 'Print' button in the cart (basket.tt)
34- Place a hold on the item
35- In the search bar at the top, click the 'Check in' tab and check in the
item
** 36- Check the 'Print' button in the 'Hold filled for' message (returns.tt)
37- Go to Tools > Cash summary for Branch
38- Click 'record cashup' and confirm
39- Click the 'Summary' link in the 'Last cashup' column
** 40- Check the 'Print' button in the cashup summary modal
(cashup_summary.inc)
41- Go to Serials
42- Create a subscription (if there aren't any)
43- Receive an issue
44- From the subscription detail page, go to Create routing list
45- Add a recipient to the list
46- Save the routing list
47- Click 'Save and preview routing slip'
** 48- Check the 'Print' button in the routing list preview
(routing_preview_slip.tt)

Note: I can't find where the 'Print' from tinymce_i18n.inc is displayed in the
staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:14:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:14:29 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-mTZQxiVV7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:14:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:14:36 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-2wS8TuQzuX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137066|0                           |1
        is obsolete|                            |

--- Comment #259 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137102&action=edit
Bug 23681: Add PatronRestrictionTypes syspref

This patch adds the new syspref "PatronRestrictionTypes"

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:14:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:14:44 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-8qB9x4cX3d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137067|0                           |1
        is obsolete|                            |

--- Comment #260 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137103&action=edit
Bug 23681: Add debarment_types

This patch adds the table debarment_types and changes
borrower_debarments.type to be a foreign key to it

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:14:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:14:52 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-5RZKxAg3qe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137068|0                           |1
        is obsolete|                            |

--- Comment #261 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137104&action=edit
Bug 23681: Add modify_patron_restrictions perm

This patch adds a new "modify_patron_restrictions" permission

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:14:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:14:59 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-B7ee4Aeszp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137069|0                           |1
        is obsolete|                            |

--- Comment #262 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137105&action=edit
Bug 23681: Add Koha::RestrictionType(s)

This patch adds the following objects:

Koha::RestrictionType
Koha::RestrictionTypes

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:07 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-bFX3auD1DC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137070|0                           |1
        is obsolete|                            |

--- Comment #263 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137106&action=edit
Bug 23681: Add management UI

This patch adds UI to allow CRUD operations on restriction types

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:13 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-9wrHK8h313@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137071|0                           |1
        is obsolete|                            |

--- Comment #264 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137107&action=edit
Bug 23681: Allow for changes to debarments

The structure of debarments has changes slightly in that the displayed
text is now a product of a call to Koha::RestrictionTypes rather than
just the debarment's code. This patch allows for that

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:20 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-Q3iGKy3xYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137072|0                           |1
        is obsolete|                            |

--- Comment #265 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137108&action=edit
Bug 23681: Allow for selection of restriction type

This patch displays a restriction type select box (when appropriate)
when adding manual patron restrictions

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:26 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-8tgjWpmaqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137073|0                           |1
        is obsolete|                            |

--- Comment #266 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137109&action=edit
Bug 23681: Clean up on delete

When a patron restriction type is deleted, any debarments that use that
type need to revert to the default type, this patch implements this
behaviour

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:32 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-fGajo4eyad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137074|0                           |1
        is obsolete|                            |

--- Comment #267 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137110&action=edit
Bug 23681: Add unit tests

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:38 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-JfkuTIucsk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137075|0                           |1
        is obsolete|                            |

--- Comment #268 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137111&action=edit
Bug 23681: (follow-up) Fix typo

Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk>
Sponsored-by: Loughborough University

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:45 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-q6JPnV40FW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137076|0                           |1
        is obsolete|                            |

--- Comment #269 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137112&action=edit
Bug 23681: (follow-up) Fix rebase issues

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:51 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-aolqczSL7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137077|0                           |1
        is obsolete|                            |

--- Comment #270 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137113&action=edit
Bug 23681: (QA follow-up) Allow for translations

This patch allows for existing translations to follow through if
debarment type descriptions are left unaltered for the default types.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:15:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:15:57 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-8MP7sQDmhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137078|0                           |1
        is obsolete|                            |

--- Comment #271 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137114&action=edit
Bug 23681: Updates for bug 26703

This patch fixes the title ordering and also replaces the breadcrumbs
with the modern nav block equivilent

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:04 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-Y7NZj9HZLQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137079|0                           |1
        is obsolete|                            |

--- Comment #272 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137115&action=edit
Bug 23681: (QA follow-up) Fix license, perlcritic & executable

This patch fixes the simple issues mentioned by the QA script.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:10 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-JSeSlwhnAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137080|0                           |1
        is obsolete|                            |

--- Comment #273 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137116&action=edit
Bug 23681: (QA follow-up) Rename columns

Renames ronly to readonly and dflt to is_system.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:17 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-Lsnxil2xaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137081|0                           |1
        is obsolete|                            |

--- Comment #274 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137117&action=edit
Bug 23681: (QA follow-up) Fix prefs

Add the missing `.` and switch from `yes/no` to `1/0`.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:23 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-29gA3hS5IS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137082|0                           |1
        is obsolete|                            |

--- Comment #275 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137118&action=edit
Bug 23681: Fix QA issues

This patch fixes following QA issues:
- convert intaller files as .yml
- change column name readonly as is_system
- change column name is_system as default_value
- add column can_be_added_manually (testplan for this below)
- move syspref "PatronRestrictionTypes" to "Accounting > Features" tab
- tweak page title
- tweak tests to apply these changes

Also atomicupdate files have been updated. Issues with delete and tests
is fixed with adding additional schema change file.

To test:
1) Add new restriction type and make it manual.
2) Navigate to patron details page.
3) Add new restriction to patron.
=> Only selectable restriction should be the one
you just created.

Also prove t/db_dependent/RestrictionTypes.t.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:30 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-J1Kw34kloF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137083|0                           |1
        is obsolete|                            |

--- Comment #276 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137119&action=edit
Bug 23681: DO NOT PUSH! Schema changes

To be able to delete and pass tests we need to declare
koha_object[s]_class to DebarmentType.pm. Otherwise
following error is raised:

"Can't locate object method "_new_from_dbic" via package
"Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?)
at /kohadevbox/koha/Koha/Object.pm line 237"

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:36 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-capDL1eYLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137084|0                           |1
        is obsolete|                            |

--- Comment #277 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137120&action=edit
Bug 23681: (QA follow-up) Move preference again

This patch removes the new PatronRestrictionTypes preference from the
accounting area in preference to creating a new group for 'Patron
restriction' related preferences in the circulation preferences tab.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:42 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-V9bxexF2Pr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137085|0                           |1
        is obsolete|                            |

--- Comment #278 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137121&action=edit
Bug 23681: (QA follow-up) Restore customisablity of description

This patch restores the customisability of description for system restriction
types. Translatability is not affected as you can translate the defaults
via template translation and assuming the end users leave their
descriptions at the default, the translations will be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:48 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-ztKL3TU4Xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137086|0                           |1
        is obsolete|                            |

--- Comment #279 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137122&action=edit
Bug 23681: (QA follow-up) Merge update files

This patch merges the three atomic update files into one and also
adds a check for foreing key existance to make the update idempotent.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:16:55 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-IARSJy6nlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137087|0                           |1
        is obsolete|                            |

--- Comment #280 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137123&action=edit
Bug 23681: (QA follow-up) Proper handling of default option

This patch removes the 'can_be_added_manually' flag. Only non-system
restriction types can be added manually, so we exclude is_system instead
of having two flags. (And we set the 'Manual' that's added at install
time to default but not system).

We then add proper handling for setting the default manual restriction
type in the management page and set the dropdown list to use that value
by default.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:02 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-BuBohvz9MQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137088|0                           |1
        is obsolete|                            |

--- Comment #281 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137124&action=edit
Bug 23681: DBIC Rebuild

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:08 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-AMRB0VuNrh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137089|0                           |1
        is obsolete|                            |

--- Comment #282 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137125&action=edit
Bug 23681: (follow-up) Mark fields at booleans

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:15 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-tojINhHPBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137090|0                           |1
        is obsolete|                            |

--- Comment #283 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137126&action=edit
Bug 23681: (QA follow-up) Add patron restrictions to admin menu

This patch adds the patron restrictions page to the admin menu that
appears to the left on all administration pages.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:21 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-90RPoEGqVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137091|0                           |1
        is obsolete|                            |

--- Comment #284 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137127&action=edit
Bug 23681: (QA follow-up) Remove spacing and add question mark

This patch removes the superflous whitespace around the restriction
descriptions and also adds the missing question mark into the delete
question.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:27 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-V8Jfi6IdpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137092|0                           |1
        is obsolete|                            |

--- Comment #285 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137128&action=edit
Bug 23681: (QA follow-up) Match default data to update

The default data at install time didn't match the data added at update.

This patch corrects that and by doing so it also adds back the ability
to make MANUAL restriction types the default after any other type has
been made default.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:33 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-BJ0W7vqyJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137093|0                           |1
        is obsolete|                            |

--- Comment #286 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137129&action=edit
Bug 23681: (QA follow-up) Fix debarment count

This patch fixes the debarment count displayed on the circulation page
tabs

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:17:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:17:40 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-dxf5o6Et2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137094|0                           |1
        is obsolete|                            |

--- Comment #287 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137130&action=edit
Bug 23681: (QA follow-up) Fix memberentry page display

We were missing some changes to the restriction types dropdown handling
in the memberentry template.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:49:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:49:54 +0000
Subject: [Koha-bugs] [Bug 31098] New: The option tohe option of "export
 database" and "export settings" are not available.
Message-ID: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

            Bug ID: 31098
           Summary: The option tohe option of "export database" and
                    "export settings" are not available.
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: bugs.koha-community.org
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: vbovictor at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I enabled in instance-conf.xml

<backup_db_via_tools>1</backup_db_via_tools>
<backup_conf_via_tools>1</backup_conf_via_tools>

In Tools --> Export Data
The option tohe option of "export database" and "export settings" are not
available.

Here's the information that appears:
"Note: This generated file will be very large, and will be generated daily."
"Unfortunately, there are no backups available."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:55:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:55:21 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-X3DLxrd4wR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136801|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137131&action=edit
Bug 30619: Add email receipt to POS

This patch adds the ability to use email receipts with the point of sale
module.

To test:
1) Configure your Koha to enable the point of sale system.
2) Add an email template to the 'Point of sale > RECEIPT' notice.
3) Add some charges on point of sale and pay for them.
3a) You should now see a new 'Email receipt' button next to the 'Print
receipt' option.
3b) Clicking the button will display a modal to enter the anonymous
users email address
3c) Enter an email address and confirm to send the email

Sponsored-by: Martin Renvoize <martin.renvoize at gmail.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:55:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:55:24 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-Jfp129UA0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136802|0                           |1
        is obsolete|                            |

--- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137132&action=edit
Bug 30619: Add sample email notice

This patch adds a default same email type notice for the point of sale
receipt.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 18:56:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 16:56:11 +0000
Subject: [Koha-bugs] [Bug 30619] Add the option to email receipts as an
 alternative to printing
In-Reply-To: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30619-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30619-70-zeOGwR0IQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30619

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 19:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 17:13:07 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wjUhy8KxVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 19:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 17:54:18 +0000
Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines
In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11844-70-cg6tL7nlkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 20:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 18:32:17 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-2f0ubf84OW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129810|0                           |1
        is obsolete|                            |

--- Comment #6 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137133&action=edit
Bug 28975: Holds queue lists can show holds from all libraries even with
IndependentBranches

When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds from all libraries.

To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Notice you see the hold of the patron from another branch under Patron
column: "A patron from library <library name>"
11) Apply the patch.
12) Notice that the "All" option is no longer available for the limited patron.
Limited patrons can't see holds from other libraries anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 20:36:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 18:36:27 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-KWOdMSMuKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |shi-yao.wang at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:16:13 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-R4bWRnUgKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136903|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137134&action=edit
Bug 31017: Add new vendor_type field to edit screen and display

This patch adds a new vendor_type field when creating/editing vendors
and displays the field on search and details for a vendor

To test:
 1 - Apply patch, update database
 2 - Edit/create a vendor in acquisitions
 3 - Note new 'Vendor type' field, free text in editor
 4 - Save a value
 5 - Confirm it displays in vendor search results and vendor main page
 6 - In Authorised values add a new value to 'VENDOR_TYPE' category
 7 - Confirm the description of VENDOR_TYPE shows and makes sense
 8 - Add/Edit a vendor, note the vendor type is now a dropdown selection
 9 - Save with a value
10 - Confirm the description shows in results and vendor page and vendor
details

Signed-off-by: Caroline <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:16:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:16:33 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-srtkhyjY38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:24:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:24:15 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-lVBF2iP2TH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:24:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:24:19 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-1LROoQ9kFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137048|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:25:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:25:30 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-a9zQ7xNAcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #30 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137135&action=edit
Bug 29418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:25:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:25:35 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-a9jNDhrCh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137136&action=edit
Bug 29418: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 22:25:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 20:25:40 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-4BwGorYxxL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #32 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137137&action=edit
Bug 29418: Make detail rendering use the cleaned-up title for searching

This patch makes both staff and OPAC detail pages generate a valid
search link so you can trace related records in the Show analytics
link.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 23:42:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 21:42:49 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-1WI0eLhsva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|The option tohe option of   |The options to "export
                   |"export database" and       |database" and "export
                   |"export settings" are not   |settings" are not available
                   |available.                  |
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 23:53:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 21:53:50 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-SLGYg38P9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 23:53:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 21:53:54 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-dmqQ9flX7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137135|0                           |1
        is obsolete|                            |

--- Comment #33 from David Nind <david at davidnind.com> ---
Created attachment 137138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137138&action=edit
Bug 29418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 23:53:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 21:53:59 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-qYOJdNk44s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137136|0                           |1
        is obsolete|                            |

--- Comment #34 from David Nind <david at davidnind.com> ---
Created attachment 137139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137139&action=edit
Bug 29418: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul  4 23:54:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 21:54:04 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-pPqs2IQkTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137137|0                           |1
        is obsolete|                            |

--- Comment #35 from David Nind <david at davidnind.com> ---
Created attachment 137140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137140&action=edit
Bug 29418: Make detail rendering use the cleaned-up title for searching

This patch makes both staff and OPAC detail pages generate a valid
search link so you can trace related records in the Show analytics
link.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:14:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:14:20 +0000
Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to
 slips and notices
In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19966-70-xcHf4s9wQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:16:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:16:35 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-4wqWr5mdIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I suspect that this will be a setup problem rather than a bug.

I'd suggest you look at https://koha-community.org/support/ for some options on
getting support with your issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:21:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:21:10 +0000
Subject: [Koha-bugs] [Bug 31095] Koha::Patron::Debarment should be updated
 to follow current Koha:: style
In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31095-70-dQTDwTmTvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:28:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:28:00 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-fk6JNWoMpf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:28:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:28:04 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-Uz491D1CcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137101|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137141&action=edit
Bug 31068: Context for translation: Print (verb) vs. Print (noun)

This patch adds context to the term Print in the context of message transport
types (as opposed to printing something/print button), for translation
purposes.

To test:
0- Apply patch

Check the terms to be changed
1- Go to Tools > Notifications & slips
2- Edit a notification
** 3- In the tabs for different transport types, check the 'Print' term
(letter.tt)
4- Go to Tools > Overdue notice/status triggers
** 5- In the transport types, check the 'Print' column heading
(overduerules.tt)

Add a new language (fr-CA in the example, change for whatever language code you
want)
6- In a terminal, run
gulp po:create --lang fr-CA
7- Then, run
gulp po:update --lang fr-CA
8- In system preferences, enable the new language in language and OpacLanguages
9- Switch the language in staff interface and OPAC

Change the translations
10- In your favourite text editor, open fr-CA-messages.po
11- Find the string msgctxt "Message transport type"
12- Enter a word in msgstr
13- Save the file
14- In a terminal, go to misc/translator
15- Run
./translate install fr-CA

Check the translations
16- Redo the steps to check the terms (steps 1-5) and make sure the terms in
steps 3 and 5 are changed for the word you put in step 12.

17- Optionally, check the other pages where the term is supposed to be
unchanged and make sure it is unchanged

Check the terms to leave unchanged (optional)
18- Enable the HoldsAutoFill and UseCashRegisters system preferences
19- Go to Administration > Cash registers and create a cash register
20- Go to a patron's account
** 21- Check the 'Print' button in the menu bar or the patron's account
(members-toolbar.inc)
22- Go to the 'Accounting' tab
23- Create a manual invoice
** 24- In the 'Transactions' tab, check the 'Print' button in the fee line
(boraccount.tt)
25- Pay the fee (make sure to use the cash register)
** 26- In the 'Transactions' tab, check the 'Print' button in the payment line
(boraccount.tt)
27- At the top of the transactions table, click the 'Export' option
** 28- Check the 'Print' option (columns_settings.inc)
29- Go to the 'Check out' tab and check out an item
30- Go to the item's bibliographic record
** 31- Check the 'Print' button in the menu bar of the detailed record
(cat-toolbar.inc)
32- Add the record to the cart and open the cart
** 33- Check the 'Print' button in the cart (basket.tt)
34- Place a hold on the item
35- In the search bar at the top, click the 'Check in' tab and check in the
item
** 36- Check the 'Print' button in the 'Hold filled for' message (returns.tt)
37- Go to Tools > Cash summary for Branch
38- Click 'record cashup' and confirm
39- Click the 'Summary' link in the 'Last cashup' column
** 40- Check the 'Print' button in the cashup summary modal
(cashup_summary.inc)
41- Go to Serials
42- Create a subscription (if there aren't any)
43- Receive an issue
44- From the subscription detail page, go to Create routing list
45- Add a recipient to the list
46- Save the routing list
47- Click 'Save and preview routing slip'
** 48- Check the 'Print' button in the routing list preview
(routing_preview_slip.tt)

Note: I can't find where the 'Print' from tinymce_i18n.inc is displayed in the
staff interface

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 01:31:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Jul 2022 23:31:43 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-59qv1Dxqtv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. I had to do steps 8 and 9 (enable the new language) after step 15 (install
the language).

2. It was an interesting exercise navigating around the staff interface in
another language - I didn't have to switch back to English very often.

3. All the optional steps (18-48) were all fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:06:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:06:49 +0000
Subject: [Koha-bugs] [Bug 31099] New: [DOCS] Export data tool - setup so
 database and configuration data can be downloaded
Message-ID: <bug-31099-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

            Bug ID: 31099
           Summary: [DOCS] Export data tool - setup so database and
                    configuration data can be downloaded
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

Add information to the manual on how to set up Tools > Export data so that the
database and configuration backups are enabled and shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:08:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:08:52 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-aL8eHJlYct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #2 from David Nind <david at davidnind.com> ---
Hi victor.

You've set things up to enable backups, but the actual backups need creating
using koha-run-backups

Example: koha-run-backups --days 2 --output /var/spool/koha

Then the database and configuration backups will appear on the tabs to export
the database and configuration.

I'd imagine this could be setup as a cronjob.

This is not documented in the manual, so I've added a documentation bug to do
this: bug 31099

See also bug 14564 - there was some discussion there about allowing it or not,
or removing the option.

I'm not sure whether there needs to be a note or information on how to set this
up, either:
- in the koha-conf.xml file, or
- on the export database and export configuration page.

It definitely should be covered in the manual to help avoid confusion!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:14:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:14:38 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-PW5PCu6nBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137142&action=edit
Bug 29418: (follow-up) Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to host records using 773$t and 773$a.

To test:
1. Repeat the test plan from the other patches
2. When sitting on the detail view of the host record, click on the link
   to open the child.
=> SUCCESS: The link works, because of the previous patches
3. Click on the 'In:' link so the search takes you to the host record
=> FAIL: The link leads no results
4. Apply this patch
5. Restart all
6. Reload the child record page and click on the link
=> SUCCESS: Voila! The host record is retrieved!
7. Bonus points: Retry the full test plan, but add a " or ? to the
   author in both host and child records
=> SUCCESS: Things don't work before this patch, and work afterwards.
8. Sign off :-D

Sponsored-by: Theke Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:31:14 +0000
Subject: [Koha-bugs] [Bug 31099] [DOCS] Export data tool - setup so database
 and configuration data can be downloaded
In-Reply-To: <bug-31099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31099-70-kgFIxs2kqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31098,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14564

--- Comment #1 from David Nind <david at davidnind.com> ---
This is set up by:

1. Enabling the export of the database and configuration in the Koha instance
koha-conf.xml file:
   . backup directory: <backupdir>/var/spool/koha/kohadev</backupdir>
   . enable database and configuration dumps (change 0 to 1):
     <!-- Enable the two following to allow superlibrarians to download
          database and configuration dumps (respectively) from the Export
          tool -->
     <backup_db_via_tools>1</backup_db_via_tools>
     <backup_conf_via_tools>1</backup_conf_via_tools>

2. Running koha-run-backups so that the downloadable backups are created and
available. Example: koha-run-backups --days 2 --output /var/spool/koha

3. This can be done either as a one-off, or as a setup as a cronjob so that it
runs regularly.

Areas in the manual to update or cross-reference:
- tools.rst:
https://koha-community.org/manual/22.05/en/html/tools.html#export-data
- cron_jobs.rst:
https://koha-community.org/manual/22.05/en/html/cron_jobs.html#backup - this
covers a different option that is a separate script to run a database backup
and set it up as a cron job, once the relative merits of the different
approaches are worked out add across-reference to how to do backups with
koha-run-backups 

Ideas for improvement:
- Look at adding something/section/guide about system administration activities
and tasks (as opposed to these are the cron jobs available, and the Koha
package commands).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:31:14 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-nJ6p5McBUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31099

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 02:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 00:31:14 +0000
Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download
 of configuration backups
In-Reply-To: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14564-70-FJnkllxJy4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31099

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 03:27:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 01:27:04 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-EeYq1dA1vE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

victor <vbovictor at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vbovictor at gmail.com

--- Comment #22 from victor <vbovictor at gmail.com> ---
Will the next updates fix this bug?
Or do you need to do the correction manually?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 03:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 01:49:25 +0000
Subject: [Koha-bugs] [Bug 31099] [DOCS] Export data tool - setup so database
 and configuration data can be downloaded
In-Reply-To: <bug-31099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31099-70-hIw6wiWTqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31099

victor <vbovictor at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vbovictor at gmail.com

--- Comment #2 from victor <vbovictor at gmail.com> ---
No, because the backup is not finalizing.

$koha-dump instance
Dumping Koha site instace:

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 04:04:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 02:04:30 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-IsNWcOGrnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #23 from victor <vbovictor at gmail.com> ---
Complementing the information.
I saw this error when updating to version 22.05.02.000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 04:50:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 02:50:12 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-NAWERsLDOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 06:11:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 04:11:05 +0000
Subject: [Koha-bugs] [Bug 31100] New: Notice editor should only show
 relevant options
Message-ID: <bug-31100-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31100

            Bug ID: 31100
           Summary: Notice editor should only show relevant options
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

At the moment, when editing a notice, you can select from a long list of fields
to insert into a notice template.

However, in many cases (e.g. PREDUEDGST), only a sub-selection of these will
ever actually work. 

We should control the list so that it only shows what you can use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 09:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 07:29:45 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-zDAXCe06br@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |23659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659
[Bug 23659] Allow hold pickup location to default to item home branch for
item-level holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 09:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 07:29:45 +0000
Subject: [Koha-bugs] [Bug 23659] Allow hold pickup location to default to
 item home branch for item-level holds
In-Reply-To: <bug-23659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23659-70-z0ZnSHtE5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23659

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990
[Bug 30990] Terminology: DefaultHoldPickupLocation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 09:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 07:30:21 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-nKrmwhZLtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 09:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 07:30:25 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-ZDYQj7seiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136309|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137143&action=edit
Bug 30990: Fix DefaultHoldPickupLocation system preference description

Changes:
* branch to library
* staff client to staff interface
* adds an ending .

To test:
- Compare system preference descrpition before and after the
  patch was applied.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 09:31:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 07:31:28 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-6VhuKeHcrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Should we add a QA check to catch "staff client", "home branch" and "holding
branch"? If so please open an issue on the qa-test-tools project.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:29:05 +0000
Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
 to include auto-renew
In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30597-70-vYPkbKNRCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Martin Renvoize
            contact|                            |
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/567
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:29:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:29:33 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10517-70-uZiYKjVKPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:30:56 +0000
Subject: [Koha-bugs] [Bug 30663] POST /api/v1/suggestions won't honor
 suggestions limits
In-Reply-To: <bug-30663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30663-70-SnduPHTfyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30663

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:31:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:31:47 +0000
Subject: [Koha-bugs] [Bug 30354] AUTO_RENEWALS_DGST notices are not
 generated if patron set to receive notice via SMS and no SMS notice defined
In-Reply-To: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30354-70-ZmVZOMVgtT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:34:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:34:53 +0000
Subject: [Koha-bugs] [Bug 29617] BorrowerUnwantedField should exclude the
 ability to hide categorycode
In-Reply-To: <bug-29617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29617-70-YHqUwI1uqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29617

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:40:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:40:22 +0000
Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
In-Reply-To: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30204-70-c3uEyixqXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:40:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:40:23 +0000
Subject: [Koha-bugs] [Bug 30302] Include subtitle in fields searched by
 Title in serials
In-Reply-To: <bug-30302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30302-70-YeMd8p0a4a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30302
Bug 30302 depends on bug 30204, which changed state.

Bug 30204 Summary: Add subtitle to serial subscription search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:40:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:40:23 +0000
Subject: [Koha-bugs] [Bug 30466] Convert serials pages tabs to Bootstrap
In-Reply-To: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30466-70-iHHbADTsUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30466
Bug 30466 depends on bug 30204, which changed state.

Bug 30204 Summary: Add subtitle to serial subscription search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:40:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:40:48 +0000
Subject: [Koha-bugs] [Bug 29828] If no content is added to default,
 but a translation, news/additional content entries don't show in list
In-Reply-To: <bug-29828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29828-70-19680bAK4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:41:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:41:20 +0000
Subject: [Koha-bugs] [Bug 29883] Uninitialized value warning when
 GetAuthorisedValues gets called with no parameters
In-Reply-To: <bug-29883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29883-70-OWx4FKMhXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:41:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:41:21 +0000
Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25790-70-MIxPeZoI0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Bug 25790 depends on bug 29883, which changed state.

Bug 29883 Summary: Uninitialized value warning when GetAuthorisedValues gets called with no parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:41:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:41:21 +0000
Subject: [Koha-bugs] [Bug 30870] Don't skip tests if Test::Deep is not
 installed
In-Reply-To: <bug-30870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30870-70-ptcu61fQ9X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30870
Bug 30870 depends on bug 29883, which changed state.

Bug 29883 Summary: Uninitialized value warning when GetAuthorisedValues gets called with no parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29883

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:41:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:41:34 +0000
Subject: [Koha-bugs] [Bug 30528] Limits are not correctly parsed when query
 contains CCL
In-Reply-To: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30528-70-aESWMo33ZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30528

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:45:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:45:33 +0000
Subject: [Koha-bugs] [Bug 30742] Confusion when placing hold on record with
 no items available because of not for loan
In-Reply-To: <bug-30742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30742-70-VRChC3MZJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:45:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:45:33 +0000
Subject: [Koha-bugs] [Bug 30892] Holds not getting placed
In-Reply-To: <bug-30892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30892-70-c7GAWRi2K1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892
Bug 30892 depends on bug 30742, which changed state.

Bug 30742 Summary: Confusion when placing hold on record with no items available because of not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 11:46:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 09:46:10 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-fQzmBRrVOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:41:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:41:35 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-sU2VdmuNkg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
On one hand it would be nice, but we can only catch the versions we know should
not be used and would have to limit it translatable strings (we have plenty of
branch, reserve etc. in source code). Not sure if that's doable/worth the
hassle?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:45:47 +0000
Subject: [Koha-bugs] [Bug 28955] Add option to set default branch from Apache
In-Reply-To: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28955-70-lNeXGoZA2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28955

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/568
         Resolution|---                         |FIXED
      Documentation|                            |Martin Renvoize
            contact|                            |
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:46:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:46:17 +0000
Subject: [Koha-bugs] [Bug 30731] Noise from about script coming from
 Test::MockTime (or other CPAN modules)
In-Reply-To: <bug-30731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30731-70-s1qAdXzR0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:46:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:46:17 +0000
Subject: [Koha-bugs] [Bug 25515] [OMNIBUS] Remove warnings and errors from
 tests output
In-Reply-To: <bug-25515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25515-70-AwUhPuL2O3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515
Bug 25515 depends on bug 30731, which changed state.

Bug 30731 Summary: Noise from about script coming from Test::MockTime (or other CPAN modules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:46:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:46:44 +0000
Subject: [Koha-bugs] [Bug 29961] Horizontal scroll bar in acquisition z39.50
 search should always show
In-Reply-To: <bug-29961-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29961-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29961-70-OkaGwoslnv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29961

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:47:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:47:11 +0000
Subject: [Koha-bugs] [Bug 30840] Add support for barcode filters to course
 reserves
In-Reply-To: <bug-30840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30840-70-C94KkdbnOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30840

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:47:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:47:27 +0000
Subject: [Koha-bugs] [Bug 28152] Hidden error when importing an item with an
 existing itemnumber
In-Reply-To: <bug-28152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28152-70-iu0BzkvgOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:47:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:47:28 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-wGTlHMyE0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Bug 17258 depends on bug 28152, which changed state.

Bug 28152 Summary: Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:47:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:47:29 +0000
Subject: [Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
In-Reply-To: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30831-70-IdGKkfPiAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831
Bug 30831 depends on bug 28152, which changed state.

Bug 28152 Summary: Hidden error when importing an item with an existing itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28152

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:47:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:47:46 +0000
Subject: [Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
In-Reply-To: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30831-70-CjAcfY6bug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Needs documenting           |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:48:02 +0000
Subject: [Koha-bugs] [Bug 30830] Add Koha Objects  for Koha Import Items
In-Reply-To: <bug-30830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30830-70-ZDcaWVe9Tb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30830

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 12:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 10:48:02 +0000
Subject: [Koha-bugs] [Bug 30831] Add unit test for BatchCommitItems
In-Reply-To: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30831-70-ZTsCccn1it@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30831
Bug 30831 depends on bug 30830, which changed state.

Bug 30830 Summary: Add Koha Objects  for Koha Import Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30830

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 13:40:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 11:40:46 +0000
Subject: [Koha-bugs] [Bug 25622] Change way MySQL password is generated by
 koha-create
In-Reply-To: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25622-70-8u2tKgMWjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25622

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Koha security               |Koha
           Severity|major                       |normal
              Group|Koha security               |
          Component|Koha                        |Installation and upgrade
                   |                            |(command-line installer)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 13:41:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 11:41:05 +0000
Subject: [Koha-bugs] [Bug 25622] Change way MySQL password is generated by
 koha-create
In-Reply-To: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25622-70-Qn8qCjrbZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25622

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:01:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:01:44 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-Dn7GavVyZ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:14:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:14:21 +0000
Subject: [Koha-bugs] [Bug 31101] New: Allow other separation options for
 digesting circulation alerts (checkin, checkout, renewal)
Message-ID: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31101

            Bug ID: 31101
           Summary: Allow other separation options for digesting
                    circulation alerts (checkin, checkout, renewal)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

In Circulation::SendCirculationAlert we find the only use of the C4::Message
module and one of the last TRUNCATE calls btw in the same context:

        my $message = C4::Message->find_last_message($borrower, $type, $mtt);
        unless ( $message ) {
            C4::Context->dbh->do(q|UNLOCK TABLES|) unless $do_not_lock;
            C4::Message->enqueue($letter, $borrower, $mtt);
        } else {
            $message->append($letter);
            $message->update;

The append method digests multiple notices by looking for a ---- separator:
    if ($letter->{content} =~ /----/) {
        my ($header, $body, $footer) = split(/----\r?\n?/, $letter->{content});

In the first place I would not mind sending these notices separately. But
anyway.
If we do combine them (within the timeframe of the message queue processing
interval), it would be convenient to allow separating too on an html tag like
<item> as used elsewhere in notices.

I looked a bit at the notice digesting and actually only find this feature
working for advance notices. The overdue digest flag is a bit weird: the job
already digests by default?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:15:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:15:58 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-EraeoMw1R3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137052|0                           |1
        is obsolete|                            |

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137144&action=edit
Bug 29958: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:16:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:16:03 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-XD7fIg8frt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137145&action=edit
Bug 29958: Do not set dateaccessioned on updates

This patch reomves the second occurence of setting daeaccessioned today,
outside of the 'add/update' handling in Koha::Item->store.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:16:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:16:49 +0000
Subject: [Koha-bugs] [Bug 24580] Allow patron_emailer or parallel structure
 to generate custom print notices from report output
In-Reply-To: <bug-24580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24580-70-ZU4pK9jym1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24580

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:18:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:18:14 +0000
Subject: [Koha-bugs] [Bug 15647] Allow selection of destination email
 address for print overdue notices
In-Reply-To: <bug-15647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15647-70-RvFUXWz7HC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15647

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Patch doesn't apply         |RESOLVED

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this has been resolved by the AddressForFailedOverdueNotices system
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:20:30 +0000
Subject: [Koha-bugs] [Bug 26488] Overdue report download not respecting
 custom patron attribute filter
In-Reply-To: <bug-26488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26488-70-aJCu1CYIjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26488

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe I have seen a fix for this one - needs some more digging/retesting
maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:22:26 +0000
Subject: [Koha-bugs] [Bug 29898] Overdues.pm line 663,
 Use of uninitialized value in string eq
In-Reply-To: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29898-70-N0TjeGTL5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:12 +0000
Subject: [Koha-bugs] [Bug 25622] Change way MySQL password is generated by
 koha-create
In-Reply-To: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25622-70-IrlYDaxwgk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25622

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:15 +0000
Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently
In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22375-70-kAQxtgGoks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Due dates should be         |Due dates should be
                   |formatted consistantly      |formatted consistently

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:17 +0000
Subject: [Koha-bugs] [Bug 25622] Change way MySQL password is generated by
 koha-create
In-Reply-To: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25622-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25622-70-tDhbQzSNbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25622

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:20 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-vDMd6tpFBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:23 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-r1r6smawJg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:26 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-RuBBe7Xy9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:29 +0000
Subject: [Koha-bugs] [Bug 29958] Missing dateaccessioned is set to today
 when storing an item
In-Reply-To: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29958-70-Kn4SnsJYFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29958

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:32 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-irgfaR7Itu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:35 +0000
Subject: [Koha-bugs] [Bug 30785] Typo in SIP2SortBinMapping
In-Reply-To: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30785-70-cKcnObyfsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30785

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:38 +0000
Subject: [Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree
 plugin
In-Reply-To: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31040-70-rhwFzOegG4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:40 +0000
Subject: [Koha-bugs] [Bug 31040] jsTree image being used outside of jsTree
 plugin
In-Reply-To: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31040-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31040-70-mWGDl0yk0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31040

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:43 +0000
Subject: [Koha-bugs] [Bug 31066] Can't use regex in batch modification on
 fields associated with a plugin
In-Reply-To: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31066-70-Hw5QWXxVTq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:23:46 +0000
Subject: [Koha-bugs] [Bug 31066] Can't use regex in batch modification on
 fields associated with a plugin
In-Reply-To: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31066-70-GGTP5SPOuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31066

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:24:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:24:42 +0000
Subject: [Koha-bugs] [Bug 17649] Create only one message per borrower and
 overdue level
In-Reply-To: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17649-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17649-70-I96L1akaFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17649

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:25:11 +0000
Subject: [Koha-bugs] [Bug 31102] New: Add granularity to serials to include
 permissions and visibility to subscriptions by branch
Message-ID: <bug-31102-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31102

            Bug ID: 31102
           Summary: Add granularity to serials to include permissions and
                    visibility to subscriptions by branch
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would be nice for larger consortiums to only see and use their own serials
in the Serials Module. The ability for granularity with serial permissions to
accommodate consortium, including the ability for each branch/library to limit
visibility to own serials data would be nice. 
In Acquisitions, there is a way to limit the funds/budgets to a specific
branch, it would be nice to do the same here in the Serials Module.  In
addition, add permissions to include only editing/checking in your own
library's serials.  Currently, the permission lives in Serials for when a
library uses Independent Branches.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:25:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:25:45 +0000
Subject: [Koha-bugs] [Bug 31102] Add granularity to serials to include
 permissions and visibility to subscriptions by branch
In-Reply-To: <bug-31102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31102-70-wk7opJCpkP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31102

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:25 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-v5dhNvf84e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135123|0                           |1
        is obsolete|                            |

--- Comment #195 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137146&action=edit
Bug 30275: Add checkout_renewals table

This patch adds the new checkout_renewals table using an atomicupdate

Sponsored-by: Loughborough University
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:30 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-DBVlvBOFv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135124|0                           |1
        is obsolete|                            |

--- Comment #196 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137147&action=edit
Bug 30275: Generated kohastructure.sql

This kohastructure update was generated using `koha-dump --schema-only`
in koha-testing-docker once the atomicupdate had been run against the
previous atomicupdate patch.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:36 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-JPYl60MOkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135125|0                           |1
        is obsolete|                            |

--- Comment #197 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137148&action=edit
Bug 30275: DBIC Schema Changes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:41 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-WdtRgNVNYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135126|0                           |1
        is obsolete|                            |

--- Comment #198 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137149&action=edit
Bug 30275: Record renewals

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:46 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-EfLddKeB8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135127|0                           |1
        is obsolete|                            |

--- Comment #199 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137150&action=edit
Bug 30275: DBIC Schema Additions

Add checkout and old_checkout relations to CheckoutRenewal schema and
mark 'seen' as a boolean.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:52 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-3XW3ZLpqXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135128|0                           |1
        is obsolete|                            |

--- Comment #200 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137151&action=edit
Bug 30275: Add Koha::Objects for Renewals

Add Koha::Checkouts::Renewals|Renewal classes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:36:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:36:58 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-3sFtJcOR0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135129|0                           |1
        is obsolete|                            |

--- Comment #201 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137152&action=edit
Bug 30275: Rename issues.renewals to issues.renewals_count

Rename the issues.renewals field to renewals_count to prevent a method
name collision with the new relation accessor introduced by this
patchset.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:03 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-DbjsRXG3Oy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135130|0                           |1
        is obsolete|                            |

--- Comment #202 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137153&action=edit
Bug 30275: renewals_count DBIC Update

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:09 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-QScK0wat3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135131|0                           |1
        is obsolete|                            |

--- Comment #203 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137154&action=edit
Bug 30275: Add 'renewals' relation to Issue Schema

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:14 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-WAkF5xkhKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135132|0                           |1
        is obsolete|                            |

--- Comment #204 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137155&action=edit
Bug 30275: Add renewals relation to Koha::Checkout

Add the new 'renewals' relation to Koha::Checkout to return a list of
Koha::Checkouts::Renewal objects.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:19 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-vw48ERq14w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135133|0                           |1
        is obsolete|                            |

--- Comment #205 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137156&action=edit
Bug 30275: Add `/api/v1/checkouts/{checkout_id}/renewals`

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:25 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-n4VzE8KG9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135134|0                           |1
        is obsolete|                            |

--- Comment #206 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137157&action=edit
Bug 30275: Add alias to create renewal in api routes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:30 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-oJOqm9LHNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135135|0                           |1
        is obsolete|                            |

--- Comment #207 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137158&action=edit
Bug 30275: Fix checkouts.t unit test

We no longer require a mocked userenv for these tests to pass, we're
setting the userenv in api auth now. The mock just serves to break tests
for the renew method now that AddRenewal required a correctly set
userenv for 'number'.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:35 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-pyVV2YXj8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135136|0                           |1
        is obsolete|                            |

--- Comment #208 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137159&action=edit
Bug 30275: Add basic unit test for fetching renewals

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:41 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-B1WbFZ0RwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135137|0                           |1
        is obsolete|                            |

--- Comment #209 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137160&action=edit
Bug 30275: (follow-up) Rebase fixes

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:47 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-k7U49TO9en@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135138|0                           |1
        is obsolete|                            |

--- Comment #210 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137161&action=edit
Bug 30275: Add renewals relation to Koha::Old::Checkout

Add the new 'renewals' relation to Koha::Old::Checkout to return a
list of Koha::Checkouts::Renewal objects.

We also add the same relation to the OldIssue schema inline.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:52 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-fzwZx3jlRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135139|0                           |1
        is obsolete|                            |

--- Comment #211 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137162&action=edit
Bug 30275: (QA follow-up) Rename columns to match API

This patch performs the following column renames:

* id => renewal_id
* issue_id => checkout_id

The idea is that no translation is needed for the API, and also, being a
new table, we can educate the users into the 'to be' terminology we are
leaning towards, instead of having them learn one naming to create
reports and then need to translate them once we normalize things in a
future.

That said, this is simple to review.

Apply this patch and repeat the test plan.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:37:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:37:57 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-r0fDv4yA5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135140|0                           |1
        is obsolete|                            |

--- Comment #212 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137163&action=edit
Bug 30275: (follow-up) Drop renewer_id constraint

This patch fixes some unit tests by ensureing we set a valid userid for
mock userenv setting so that the foreign key constraint doesn't fail and
it also removes the exception class and check for renewer_id from the
store method as, for example with autorenewals, the renewal may not have
been triggered by a actual user.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:38:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:38:04 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-pE2R0rDfr6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135141|0                           |1
        is obsolete|                            |

--- Comment #213 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137164&action=edit
Bug 30275: Add unit tests for AddRenewal addition

This patch adds a test for the AddRenewal addition that creates Renewal
lines.

Test plan
1) Run the unit tests and confirm it passes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:38:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:38:10 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-p9STYCSIQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135142|0                           |1
        is obsolete|                            |

--- Comment #214 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137165&action=edit
Bug 30275: Add Unit test for renewals relation

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:38:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:38:15 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-vdzgwXMQT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135143|0                           |1
        is obsolete|                            |

--- Comment #215 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137166&action=edit
Bug 30275: Unit Tests for Checkouts::Renewal

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:10 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-0sO5i7Pz1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:12 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-ewqMmA2D0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #216 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:15 +0000
Subject: [Koha-bugs] [Bug 30566] Incorporate link handling in OPAC's
 biblio-title include
In-Reply-To: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30566-70-qMBw1WB2B7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:18 +0000
Subject: [Koha-bugs] [Bug 30566] Incorporate link handling in OPAC's
 biblio-title include
In-Reply-To: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30566-70-UIpWN2ViKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30566

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:20 +0000
Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
 format show the incorrect format
In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30567-70-4qRGhemuF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:24 +0000
Subject: [Koha-bugs] [Bug 30567] Create manual invoice with FR currency
 format show the incorrect format
In-Reply-To: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30567-70-ZnQ1LaRzhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30567

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:27 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-LNJ5gtOnQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 14:59:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 12:59:30 +0000
Subject: [Koha-bugs] [Bug 30990] Terminology: DefaultHoldPickupLocation
In-Reply-To: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30990-70-De6PNHWP5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30990

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:08:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:08:50 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-ilU4PS8psE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134890|0                           |1
        is obsolete|                            |

--- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137167&action=edit
Bug 23838: Add renewals modal

This patch adds the display of the renewals modal when appropriate. A
"View" link is displayed next to renewals count where appropriate.
Clicking the link opens the modal that displays the logged renewals.

Sponsored-by: Loughborough University
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

I rescued this patchset by squashing previous work and updating it to
utilise the new renewals API routes introduced in bug 30275.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:08:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:08:55 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-hpMqE9nRZh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134891|0                           |1
        is obsolete|                            |

--- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137168&action=edit
Bug 23838: Use $datetime formater

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:09:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:09:00 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-PnJ7vAr5Cy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134892|0                           |1
        is obsolete|                            |

--- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137169&action=edit
Bug 23838: (follow-up) Add missing template filter

Quieting an issue highlighted by the QA tool.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:12:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:12:33 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-IQRY8SkyGN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased now that the dependency bug has been pushed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:35:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:35:55 +0000
Subject: [Koha-bugs] [Bug 28975] Holds queue lists can show holds from all
 libraries even with IndependentBranches
In-Reply-To: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28975-70-aMFuNysFv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28975

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137133|0                           |1
        is obsolete|                            |

--- Comment #7 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137170&action=edit
Bug 28975: Holds queue lists can show holds from all libraries even with
IndependentBranches

When using IndependentBranches, usually all branches are removed from the
drop-down menus. But in the Holds Queue page, there is the possibility to
choose "All branches". From there, you can see holds from all libraries.

To recreate :
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including holds permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
    - delete_borrowers
    - edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (we'll
call them patron X)
4) Place a hold for patron X on an available item from their own library
5) Run misc/cronjobs/holds/build_holds_queue.pl
6) Go to Circulation > Holds queue and make sure you can see the hold
7) Log in as your limited staff patron
8) Go to Circulation > Holds queue
9) In the drop-down menu, choose "All" and click Submit
-- Notice you see the hold of the patron from another branch under Patron
column: "A patron from library <library name>"
11) Apply the patch.
12) Notice that the "All" option is no longer available for the limited patron.
Limited patrons can't see holds from other libraries anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:50:48 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-I87FKyXLgi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137138|0                           |1
        is obsolete|                            |

--- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137171&action=edit
Bug 29418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:50:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:50:53 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-2tjVy27zdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137139|0                           |1
        is obsolete|                            |

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137172&action=edit
Bug 29418: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:50:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:50:58 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-mVf3glzmyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137140|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137173&action=edit
Bug 29418: Make detail rendering use the cleaned-up title for searching

This patch makes both staff and OPAC detail pages generate a valid
search link so you can trace related records in the Show analytics
link.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:51:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:51:03 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-3SoYOnCdyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137142|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137174&action=edit
Bug 29418: (follow-up) Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to host records using 773$t and 773$a.

To test:
1. Repeat the test plan from the other patches
2. When sitting on the detail view of the host record, click on the link
   to open the child.
=> SUCCESS: The link works, because of the previous patches
3. Click on the 'In:' link so the search takes you to the host record
=> FAIL: The link leads no results
4. Apply this patch
5. Restart all
6. Reload the child record page and click on the link
=> SUCCESS: Voila! The host record is retrieved!
7. Bonus points: Retry the full test plan, but add a " or ? to the
   author in both host and child records
=> SUCCESS: Things don't work before this patch, and work afterwards.
8. Sign off :-D

Sponsored-by: Theke Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 15:53:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 13:53:45 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-Ofegy8jWbM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work Tomas, this is a great solution for the 21.05 series.

I think we need the follow-up in 21.11+ too however.. and the approach of
passing through the analytics_query as a variable (although actually all we
pass here is the escaped title) make sense to me for a master additional too..
DRY our code out by passing the constructed and escaped analytics query from
our biblio method rather than re-constructing a version in the xslts.

All in all.. PQA for this branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:09:30 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-fxnDvYY4zs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137175&action=edit
Bug 24010: (QA follow-up) Correct COMMENT syntax

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:24:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:24:26 +0000
Subject: [Koha-bugs] [Bug 31103] New: 'interface' is stored inconsistently
 throughout the database
Message-ID: <bug-31103-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31103

            Bug ID: 31103
           Summary: 'interface' is stored inconsistently throughout the
                    database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We have many cases where we store the interface an action took place on in an
'interface' field in relevant tables.

This 'interface' field however takes many forms, we could really be consistent
and use an enum or linked table everywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:24:31 +0000
Subject: [Koha-bugs] [Bug 31103] 'interface' is stored inconsistently
 throughout the database
In-Reply-To: <bug-31103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31103-70-qgiHtP6xNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31103

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:29:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:29:49 +0000
Subject: [Koha-bugs] [Bug 31104] New: Pagination generates HTTP "Link:"
 header which is over 8291 bytes apache's limit
Message-ID: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

            Bug ID: 31104
           Summary: Pagination generates HTTP "Link:" header which is over
                    8291 bytes apache's limit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: REST API
          Assignee: tomascohen at gmail.com
          Reporter: nugged at gmail.com
                CC: tomascohen at gmail.com

to repeat:

1. Go to /cgi-bin/koha/members/member.pl

2. put this test into the "Search for patron" "Search:" field:
   "some long test to search in patron fields"

3. Observe "nothing found" but in the server log, it will say

(28)No space left on device: [client 127.0.0.1:60330] AH10124: header size is
over the limit allowed by ResponseFieldSize (8192 bytes). Bad response header:
'Link: <https://...

this of course happens when you searching for something long but seems we came
to so long URL which fails to fit into the "forward" (Link: ... header) field, 

if to debug, it creates a "search" API request URL that is already 5219 bytes
long, then this URL is re-encoded and put two times inside the "Link:" header,
so it quickly jumps over the 8192 bytes header limit.

Note: as we found together that solution in Koha/REST/Plugin/Pagination.pm to
split @links in separate "Link:" headers.

SIDENOTE: considering that we already have URL 5129 long in this example, we
might anyway even without header doubling bump into the 8192 limits (!). We
might need re-think later how in general this formed up. Not related to the
current shorter fix though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:30:21 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-jcSD19GqGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Pagination generates HTTP   |Pagination generates HTTP
                   |"Link:" header which is     |"Link:" header which is
                   |over 8291 bytes apache's    |over 8192 bytes apache's
                   |limit                       |limit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:35:42 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-b4jKjSELxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:35:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:35:44 +0000
Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff
 accepts non-integer values
In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24010-70-oJGkRNCgiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:35:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:35:47 +0000
Subject: [Koha-bugs] [Bug 30716] Add Collection column to cn_browser results
 table
In-Reply-To: <bug-30716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30716-70-DE5woHqQjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:35:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:35:50 +0000
Subject: [Koha-bugs] [Bug 30716] Add Collection column to cn_browser results
 table
In-Reply-To: <bug-30716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30716-70-IrxoN5atmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30716

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:41:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:41:39 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-5O4B0QxceU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #66 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 135839
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135839
Bug 22456: Add waiting_hold_cancellation circulation rule

Review of attachment 135839:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22456&attachment=135839)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ +836,4 @@
>      </div>
>      [% END %]
>  
> +    <div id="waiting-hold-cancel-category" class="container">

I'm curious why this configuration was added in its own section if it contains
the same three base parameters branchcode, patron category and itemtype as the
default circulation rules table? Not that anyone likes worsening the horizontal
scrolling but perhaps you had another reason in mind.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:41:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:41:43 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-Gw2eBvfqGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #67 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 135841
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135841
Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es)

Review of attachment 135841:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22456&attachment=135841)
-----------------------------------------------------------------

::: Koha/Hold/CancellationRequest.pm
@@ +40,5 @@
> +sub store {
> +    my ($self) = @_;
> +
> +    if ( !$self->in_storage ) { # new request
> +        $self->creation_date( \'NOW()' )

Why do we do store() overloading instead of defining "NOT NULL DEFAULT
CURRENT_TIMESTAMP" at table creation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:41:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:41:48 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-ao8CnHEYfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #68 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 135845
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135845
Bug 22456: Staff interface handling

Review of attachment 135845:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22456&attachment=135845)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
@@ +50,5 @@
>          </h2>
> +    [% IF reject_result_error %]
> +        <div class="error message">
> +        [% IF reject_result_error.invalid_status %]
> +            <p>There was a problem rejecting the cancellation request. Cannot reject an already completed cancellation request.</p>

Looks like comment #35 decided to remove this functionality, and this seems now
dead code.

Test plan should also be adjusted (it still mentions rejecting/accepting the
request).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:47:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:47:07 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-R6pBq8pZVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #69 from Lari Taskula <lari.taskula at hypernova.fi> ---
I think it would be user friendly to let patron uncancel the cancellation
request in OPAC, just because even with the confirmation dialog box someone may
accidentally cancel a wrong hold or start regretting their action later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:52:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:52:12 +0000
Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21903-70-7Uo3FWRuN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:52:15 +0000
Subject: [Koha-bugs] [Bug 21903] koha-dump be able to include koha-upload
In-Reply-To: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21903-70-CsPRBoLmFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21903

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:52:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:52:19 +0000
Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description
In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24865-70-h63cVTJjKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 16:52:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 14:52:22 +0000
Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description
In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24865-70-z63HAVXzhK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:03:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:03:51 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-iHBhZa3vRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136702|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137176&action=edit
Bug 30903: Fix POST /quote

quote_id should not be required

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:03:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:03:55 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-WWlvHj9Yo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136703|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137177&action=edit
Bug 30903: Fix UI glitch on the quotes upload view

Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:03:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:03:59 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-qvzpwvZFGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136704|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137178&action=edit
Bug 30903: (follow-up) Fix error message class

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:04:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:04:27 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-f0RtaX0lkz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fixes the issue at hand, QA scripts are happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:13:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:13:03 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-4cv4M9lcHL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #70 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lari Taskula from comment #66)
> Comment on attachment 135839 [details] [review]
> Bug 22456: Add waiting_hold_cancellation circulation rule
> 
> Review of attachment 135839 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
> @@ +836,4 @@
> >      </div>
> >      [% END %]
> >  
> > +    <div id="waiting-hold-cancel-category" class="container">
> 
> I'm curious why this configuration was added in its own section if it
> contains the same three base parameters branchcode, patron category and
> itemtype as the default circulation rules table? Not that anyone likes
> worsening the horizontal scrolling but perhaps you had another reason in
> mind.

I hate the big table, and of course hate worsening it. I feel like this
deserves its own section, and we could eventually group holds related policy in
a single place as well, but out of the scope.

So, this is just personal preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:14:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:14:32 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-YzgmxAUKzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #71 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lari Taskula from comment #67)
> Comment on attachment 135841 [details] [review]
> Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es)
> 
> Review of attachment 135841 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Hold/CancellationRequest.pm
> @@ +40,5 @@
> > +sub store {
> > +    my ($self) = @_;
> > +
> > +    if ( !$self->in_storage ) { # new request
> > +        $self->creation_date( \'NOW()' )
> 
> Why do we do store() overloading instead of defining "NOT NULL DEFAULT
> CURRENT_TIMESTAMP" at table creation?

Good catch! This was carried from the first iteration of this dev, in which I
added a cancellation request approval workflow, which included an 'updated_on'
column which had the trigger set, and as you cannot set it for two columns...

Will clean this in a follow-up patch later today!

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:15:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:15:17 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-I7QKPKOkUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #72 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Thanks for your review, Lari. Will address those shortly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:24:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:24:33 +0000
Subject: [Koha-bugs] [Bug 31105] New: Holds to pull counts items from other
 branches when independentbranches is active
Message-ID: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

            Bug ID: 31105
           Summary: Holds to pull counts items from other branches when
                    independentbranches is active
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: shi-yao.wang at inLibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Holds to pull should not take into account items from other branches that
shares a record.

To recreate:
1- Have IndependentBranches set to Yes
2- Have a record with 2 items from different branches (set both current/home
library)
3- Have a patron from one of the 2 branches in the previous step place a record
level hold on that record
4- Go to circulation > holds to pull
5- Notice under "Libraries" it displays 2 branches, the current branch where
the patron is from and another one. Also, it shows 2 under "Items available"
6- Checkout the item from the current branch to another patron
7- Go back to circulation > holds to pull
8- Notice under "Libraries" it displays the other branch that is not the
current one

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:25:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:25:09 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-ZykkBVEUEB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com
                   |                            |, shi-yao.wang at inLibro.com
           Assignee|koha-bugs at lists.koha-commun |shi-yao.wang at inLibro.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:30:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:30:33 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-C11nMVdHTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 17:42:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 15:42:28 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for sms transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-Ab3y8lIbdM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The more I read this code, the more funky I find it..

I feel like we could actually get rid of C4::Message entirely.. it's only used
in one place and that use feels a bit strange already.

Anyways.. I'm working on a unit test here for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 18:38:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 16:38:57 +0000
Subject: [Koha-bugs] [Bug 24091] Add biblionumber and itemnumber in Item
 lost reports
In-Reply-To: <bug-24091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24091-70-YtT8ey2QaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24091

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:06:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:06:50 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-sAKpgk2AKy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

--- Comment #1 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137179&action=edit
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:08:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:08:18 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-7ExpGFFv8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |michalurban177 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:42:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:42:47 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-JerCRXhkTm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:42:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:42:50 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-RFv4ODnUkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137179|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137180&action=edit
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to
    bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:46:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:46:57 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-rKnpLxBMRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

--- Comment #1 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137181&action=edit
Bug 31105: Holds to pull counts items from other branches when
independentbranches is active

Holds to pull should not show items from other branches that shares a
record when IndependentBranches is active. Except for superlibrarians.

Test plan:
1- Have IndependentBranches set to Yes
2- Have a record with an item from the current branch and another item from a
different branch. We will call them branch A and branch B respectively
3- Have a patron from branch A place a hold on that record
4- Have a staff account on branch A and B with the following permissions:
    - circulate (all)
    - catalogue
5- Go to circulation > holds to pull
6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under
"Items available"
7- Checkout the item from branch A to another patron
8- Go back to circulation > holds to pull
9- Notice under "Libraries" it displays branch B even though we are in branch A
10- Apply the patch
11- Return the checked out item from step 7
12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed
13- Redo step 11-12 but using accounts from step 4 and notice Holds to
pull only shows information relevant to their branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 19:48:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 17:48:10 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-EH5ccN0tQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:25:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:25:25 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-ukrePuPFFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #41)
> Nice work Tomas, this is a great solution for the 21.05 series.
> 
> I think we need the follow-up in 21.11+ too however.. and the approach of
> passing through the analytics_query as a variable (although actually all we
> pass here is the escaped title) make sense to me for a master additional
> too.. DRY our code out by passing the constructed and escaped analytics
> query from our biblio method rather than re-constructing a version in the
> xslts.

This problem is present in (at least) master, and it doesn't need just the
follow-up. I'll file a bug for master to avoid mixing things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:28:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:28:21 +0000
Subject: [Koha-bugs] [Bug 31106] New: Error searching for analytics in
 detail view
Message-ID: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

            Bug ID: 31106
           Summary: Error searching for analytics in detail view
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Zebra
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

Bug 30865 fixed part of the problem. We need to implement the fix in bug 29418
for master and 21.11+.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:28:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:28:42 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-H6DzE2ADXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136754|0                           |1
        is obsolete|                            |

--- Comment #6 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137182&action=edit
Bug 29632: Don't sort cn-sort numerically

When defining our sort fields in we defined all as 'numeric'

For other string containing numbers this is likely correct, however,
for callnumbers it is not. e.g. E45 should sort before E7

This patch adds a new 'callnumber' type and deifnes this for cn-sort and
adds to the field maping a sort without numeric set

To test:
0 - Be using ES with Koha
1 - On records with single item, add callnumbers:
    VA65 E7 R63 1984
    VA65 E7 T35 1990
    VA65 E45 R67 1985
2 - Add public note 'shrimp' or something to make them easily searchable as a
group
3 - Search for 'shrimp', sort by callnumber
4 - Note E45 comes last, it should come first
5 - Apply patch
6 - Reset ES mappings
7 - Reindex ES
8 - Repeat search
9 - Sorting should be correct when set to callnumber

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:28:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:28:45 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-BSoL5PCqxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |30865
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865
[Bug 30865] Koha::Biblio->get_components_query should double quote Host-item
search
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:28:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:28:45 +0000
Subject: [Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should
 double quote Host-item search
In-Reply-To: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30865-70-ATloa5nUKQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31106


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106
[Bug 31106] Error searching for analytics in detail view
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:28:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:28:45 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-Ocbk67SIqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31106

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 20:47:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 18:47:03 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-2zKLJnIwNE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #87 from Fridolin Somers <fridolin.somers at biblibre.com> ---
You can with REST API.
Public routes are same file between OPAC and staff :
https://wiki.koha-community.org/wiki/REST_api_RFCs#Unprivileged_.28public.29_routes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:01:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:01:47 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-iVdwZ1W5KT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com,
                   |                            |dcook at prosentient.com.au,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:02:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:02:10 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-UVyFLhqo0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:02:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:02:14 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-5PKAVNNTTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137183&action=edit
Bug 31106: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:02:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:02:18 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-bMq40Aq1m4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137184&action=edit
Bug 31106: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:02:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:02:22 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-GejRepLsS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137185&action=edit
Bug 31106: Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to and from host records using 773$t and 773$a.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Go to the child record, and notice the link back to the parent works
   :-D
10. Sign off :-D

Sponsored-by: Theke Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:06:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:06:38 +0000
Subject: [Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should
 double quote Host-item search
In-Reply-To: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30865-70-GKSRnzxOlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
> Thanks for working on this David, my apologies for not getting to testing it
> as quickly as I should.
> 
> This works great, a much cleaner solution too.
> 
> Tested with Zebra and Elastic and as the docs say it works well for both.
> 
> In the end, this is a trivial patch so I'm going straight for QA.
> 
> QA script happy, Unit tests passing, No regressions and bug is fixed.
> 
> Passing QA

Please look at bug 31106 ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 21:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 19:16:00 +0000
Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To Date'
In-Reply-To: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31057-70-A4M7cJLBKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057

Eric Rector <erector at ferrum.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erector at ferrum.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:09:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:09:53 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-v9pmEfcqS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137027|0                           |1
        is obsolete|                            |

--- Comment #23 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137186&action=edit
Bug 17170: DB Updates

This patch adds the new table, permission, and a syspref to enable the feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:09:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:09:57 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-veBb94fyOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137028|0                           |1
        is obsolete|                            |

--- Comment #24 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137187&action=edit
Bug 17170: DO NOT PUSH - Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:00 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-OZq2swYSaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137029|0                           |1
        is obsolete|                            |

--- Comment #25 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137188&action=edit
Bug 17170: Update schema for boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:05 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-7TNLhKblug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137030|0                           |1
        is obsolete|                            |

--- Comment #26 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137189&action=edit
Bug 17170: Add API route for SearchFilters

This adds the API routes and tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:10 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-Ncg6Sn4mpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137031|0                           |1
        is obsolete|                            |

--- Comment #27 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137190&action=edit
Bug 17170: Add search filters to staff and opac interfaces

This patch displays the filters on the results pages with the facets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:14 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-5m5Gnm27Tq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137032|0                           |1
        is obsolete|                            |

--- Comment #28 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137191&action=edit
Bug 17170: Handle search filters in query builders

This patch updates the query building code to expand filters when searching
and pass them back as part of the cgi and descriptive search strings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:18 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-xGZzylFiNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137033|0                           |1
        is obsolete|                            |

--- Comment #29 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137192&action=edit
Bug 17170: Add admin page for filters and ability to edit/save existing filters

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the resuilts page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:23 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-CpqWDmCiDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137034|0                           |1
        is obsolete|                            |

--- Comment #30 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137193&action=edit
Bug 17170: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:26 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-JVUu3ykWMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137035|0                           |1
        is obsolete|                            |

--- Comment #31 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137194&action=edit
Bug 17170: (follow-up) Display search filters admin links when apprropriate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:10:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:10:30 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-9tpmS10l9H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #32 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137195&action=edit
Bug 17170: Add the ability to create 'saved searches' for use as filters when
searching the catalog

This patch alters the code in the ES QueryBuilder. Reflecting
how things are handled in build_query_compat we clean the query,
but not the limits. In Zebra we simply recursivly call buildQuery,
but the ES query structure

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the results page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 22:11:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 20:11:30 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-4KrJIX2qjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michalurban177 at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 23:55:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 21:55:26 +0000
Subject: [Koha-bugs] [Bug 30597] Update wording of RestrictionBlockRenewing
 to include auto-renew
In-Reply-To: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30597-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30597-70-qxUJYt5Yvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30597

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28746
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul  5 23:55:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 21:55:26 +0000
Subject: [Koha-bugs] [Bug 28746] Add OPAC equivalent for
 RestrictionBlockRenewing system preference
In-Reply-To: <bug-28746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28746-70-VpkLjkJvl9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28746

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30597

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 01:01:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Jul 2022 23:01:43 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
 list displays and e-mails
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-K3ozQnVxfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This patch adds a new       |This patch adds a new
      release notes|subroutine                  |subroutine get_marc_host in
                   |get_host_item_entries in    |the
                   |the
                        |Koha::Biblio module
                   |Koha::Biblio module         |which retrieves any 773
                   |which retrieves any 773     |fields from the biblio
                   |fields from the biblio      |record. The subroutine is
                   |record. The subroutine is   |used to show a host item
                   |used to show a host item    |entry and a link to the
                   |entry and a link to the     |record in the following
                   |record in the following     |places:
                   |places:
                    |- staff client list
                   |- staff client list         |- staff client cart
                   |- staff client cart
        |- staff
                   |- staff                     |client send list email
                   |client send list email
     |-
                   |-                           |staff client send cart
                   |staff client send cart      |email
                   |email
                      |- staff client search
                   |- opac list
                |results
                   |- opac                      |- staff client
                   |cart
                       |detail page
                   |- opac send list email      |- opac list
                   |email
                      |-
                   |- opac send cart            |opac cart
                   |email                       |- opac send list
                   |                            |email email
                   |                            |- opac send
                   |                            |cart email
                   |                            |- opac search
                   |                            |results
                   |                            |- opac detail page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 03:11:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 01:11:13 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-4nVBXP5zUE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #24 from victor <vbovictor at gmail.com> ---
In ubuntu 20.05 and Koha 22.05.02.000
$ koha-upgrade-schema faes
Upgrading database schema for faes
DEV atomic update
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/atomicupdate/bug_30899.pl
 [22:09:37]: Bug 30899 - Check borrower_attribute_types FK constraint (30449
follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 03:52:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 01:52:08 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-auxwXc3BP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Cheers, Fridolin. Just bumped into this one myself, so your fix was very
helpful!

I was tempted to close the issue but really this is something that Bug 29605
should've watched out for I suppose...

I'm not sure what the answer is for fixing an old database migration... I
suppose we would need to fix
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/211102003.pl
since ordering is critical...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 03:54:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 01:54:13 +0000
Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with
 kohastructure.sql
In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29605-70-0e7WBVKIZ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

--- Comment #56 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #55)
> We discussed that already.
> The problem is that most of the time the error is coming from the atomic
> update, the kohastructure is correct...

Yeah it's easy to test a new kohastructure.sql or an atomic update against the
last kohastructure.sql, but systems in the wild don't always play nice with
atomic updates.

Bug 30951 also shows a problem with
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/211102003.pl
where it doesn't take into account existing duplicate keys before adding a
primary key. 

I suppose Bug 30951 might need to update that database migration so that it
does some kind of deduping... or to throw a fatal error that includes a line
number to make it easier to troubleshoot...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 05:33:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 03:33:00 +0000
Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
 EDI LSQ segments map to 'location' or 'collection'
In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30135-70-jDsFpvjseC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135

wainuiwitikapark at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

--- Comment #22 from wainuiwitikapark at catalyst.net.nz ---
This patch might have introduced a flaw in the tests - when we run
t/ediorder.t, it fails with this output:

vagrant at kohadevbox:kohaclone((v22.05.02))$ sudo koha-shell kohadev
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/Ediorder.t
t/Ediorder.t .. 1/13 Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
t/Ediorder.t .. 11/13 
#   Failed test 'Single Gir field OK'
#   at t/Ediorder.t line 104.
#          got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM'
#     expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
$VAR1 = 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT';
$VAR2 = 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT';
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 119.

#   Failed test 'First part of split Gir field OK'
#   at t/Ediorder.t line 119.
#          got: undef
#     expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 125.

#   Failed test 'Second part of split GIR field OK'
#   at t/Ediorder.t line 125.
#          got: undef
#     expected: 'GIR+002+S_I:LVT'
# Looks like you failed 3 tests of 13.
t/Ediorder.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/13 subtests 

Test Summary Report
-------------------
t/Ediorder.t (Wstat: 768 Tests: 13 Failed: 3)
  Failed tests:  11-13
  Non-zero exit status: 3
Files=1, Tests=13,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.40 cusr  0.10
csys =  1.52 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 06:29:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 04:29:17 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
 list displays and e-mails
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-fdFa0x0iDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 06:29:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 04:29:22 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
 list displays and e-mails
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-ykOJFGiwh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135416|0                           |1
        is obsolete|                            |

--- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137196&action=edit
Bug 16522: Adding 773 to cart and list displays and emails

This patch adds a new subroutine get_marc_host in the
Koha::Biblio module which retrieves any 773 fields from the biblio
record. The subroutine is used to show a host item entry and a link to
the record in the following places:
- staff client list
- staff client cart
- staff client send list email
- staff client send cart email
- staff client search results
- staff client detail page
- opac list
- opac cart
- opac send list email email
- opac send cart email
- opac search results
- opac detail page

To test:

1. apply patch, restart services
2. log into the staff client and enable the syspref EasyAnalyticalRecords
3. find a record with an item. take note of the barcode.
4. go to another record (biblio 2). click Edit -> Link to host record
5. enter the barcode in the input and submit.
6. click the MARC tab and confirm the host record has been linked under
MARC field 773.
7. add biblio 2 to your cart, and to a list.
8. go to your cart. confirm you see the 'host item entry' link.
9. click on 'more details' and confirm you see the 'host item entries'
link.
10. click 'send' to email the cart. confirm the email contains the host
item entry and the link sends you to the catalogue page for the record
in the OPAC.
11. go to the list you added the record to. confirm you see the 'source'
link for the host item entry.
12. click 'send list' to email the list. confirm the email contains the
host item entry and the link sends you to the catalogue page for the
record in the OPAC.
13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they
all pass as expected.
14. Confirm host item info also shows correctly on the
OPAC and staff client search results, and the OPAC and staff client
detail pages (where XSLT is used)
15. Delete the 773$w and confirm host item info still shows correctly
but no longer links to biblio
16. confirm tests pass t/db_dependent/Koha/Biblio/host_record.t

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 06:29:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 04:29:27 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
 list displays and e-mails
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-naegtsLBWN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

--- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137197&action=edit
Bug 16522: (follow-up) MARC display templates and get_marc_host fixes

Also:
- Show related parts 773$g
- Normalise using 'Host item entry' as title
- Remove 'foreach' because non-xslt views only return first
- If no $w, use $atg, and related tests in
t/db_dependent/Koha/Biblio/host_record.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 07:25:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 05:25:29 +0000
Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary
 phone is updated
In-Reply-To: <bug-14872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14872-70-OWFCG5yGTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Owen Leonard from comment #6)
> I wonder if a better long-term solution wouldn't be to have the SMS number
> field be an option to select one of the existing phone number fields: A
> dropdown menu where you choose to link SMS messages to primary phone,
> secondary phone, or other phone. It seems odd to me that we even have a
> separate field for SMS number.

Right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 07:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 05:31:44 +0000
Subject: [Koha-bugs] [Bug 31107] New: smsalertnumber missing from OPAC
 self-registration
Message-ID: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31107

            Bug ID: 31107
           Summary: smsalertnumber missing from OPAC self-registration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Currently, you can't provide smsalertnumber via the OPAC self-registration.
This means it's impossible to get SMSes unless a librarian has added it for
you, or you have gong through OPAC > your messaging, which I'm sure most users
never ever look at.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 07:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 05:32:17 +0000
Subject: [Koha-bugs] [Bug 14872] Reminder to update SMSnumber when primary
 phone is updated
In-Reply-To: <bug-14872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14872-70-RDJYBioSHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14872

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31107

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 07:32:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 05:32:17 +0000
Subject: [Koha-bugs] [Bug 31107] smsalertnumber missing from OPAC
 self-registration
In-Reply-To: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31107-70-MaQSjIIPFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31107

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14872

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:17:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:17:29 +0000
Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a
 later version
In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23073-70-gwAzUoVCvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #27 from Thomas Dukleth <td-koha-bugs at agogme.com> ---
The intent of adding an automatic exclusion for obsolete pages from the simple
search box with -"[[Category:Obsolete]]" is for the simplest searches to
exclude old obsolete pages so as not to confuse users or be found
inappropriately in the most basic search result set.  Old obsolete content
pages can still be found using the advanced search including found explicitly
by searching for "[[Category:Obsolete]]" without the exclusion operator prefix
and thus acts as an archive for such content.

Old obsolete pages are noted with a prominent notice via a template if they are
encountered.  Such pages should be updated if they can be, but are otherwise
available to consult most importantly for valuable information they often
contain which is not yet present in current pages.

There should be a more elegant method to address the issue but migrating the
database and upgrading has priority.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:22:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:22:24 +0000
Subject: [Koha-bugs] [Bug 29605] DB structure may not be synced with
 kohastructure.sql
In-Reply-To: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29605-70-OATOY5tiOq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
For the adding a new constraint or key case we should probably be catching that
at QA stage.. we're only human, and I'm likely a culprit for missing exactly
that sort of issue. 😬

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:39:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:39:14 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-HmMOG12BX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30570                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
[Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:39:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:39:14 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-ZHVGFcbrnW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|30650                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:43:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:43:42 +0000
Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a
 later version
In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23073-70-6V4oAglfpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #28 from Thomas Dukleth <td-koha-bugs at agogme.com> ---
I am investigating why the full view of at least some image files in the form
of /wiki/File:some_file are not displaying for even the direct restore of the
Koha MediaWiki Postgres instance.  The images are actually all present.  There
maybe a missing dependency or permission problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:48:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:48:46 +0000
Subject: [Koha-bugs] [Bug 31108] New: add missing shebang line to
 ./t/00-check-atomic-updates.pl
Message-ID: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

            Bug ID: 31108
           Summary: add missing shebang line to
                    ./t/00-check-atomic-updates.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

small patch to add missing shebang line to ./t/00-check-atomic-updates.pl

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch 


3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:51:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:51:32 +0000
Subject: [Koha-bugs] [Bug 31108] add missing shebang line to
 ./t/00-check-atomic-updates.pl
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-dAPPlNKCoc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:51:36 +0000
Subject: [Koha-bugs] [Bug 31108] add missing shebang line to
 ./t/00-check-atomic-updates.pl
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-OTCOOBDuGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
Created attachment 137198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137198&action=edit
Bug 31108: add missing shebang line to ./t/00-check-atomic-updates.pl

small patch to add missing shebang line to ./t/00-check-atomic-updates.pl

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:52:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:52:45 +0000
Subject: [Koha-bugs] [Bug 31108] add missing shebang line to
 ./t/00-check-atomic-updates.pl
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-0xgCPrDIhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |mtj at kohaaloha.com
         Depends on|                            |19169
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169
[Bug 19169] Add a test to detect unneeded 'atomicupdate' files
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:52:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:52:45 +0000
Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded
 'atomicupdate' files
In-Reply-To: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19169-70-0ZU6XLjDKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31108
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31108


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108
[Bug 31108] add missing shebang line to ./t/00-check-atomic-updates.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 09:57:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 07:57:26 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LoperxnzDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137199&action=edit
Bug 30650: Don't display slots that have are before now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 10:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 08:09:50 +0000
Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a
 later version
In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23073-70-PX8v1iF4AQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #29 from Thomas Dukleth <td-koha-bugs at agogme.com> ---
Preserving version control changes after changing to the convention for hyphens
or dashes instead of underscores in program directories and filenames has
required replacing the Git archive with filenames in the history adjusted for
dashes.  Otherwise, moving files loses version control.

Code and configuration files to test migrating the MediaWiki database and
upgrading the wiki are currently available at the same location which was
originally created with hyphens but previously contained directories and
filenames with underscores,
git://test01.agogme.com/koha-migrate-mwiki-db-and-upgrade-test.git .  Files
excluded as inappropriate for version control are currently available with
hyphens having replaced underscores at
https://test01.agogme.com/koha-migrate-mwiki-db-and-upgrade-test.tgz .

Anyone interested in testing the code would need to separately obtain a full
dump of the Koha Wiki to avoid publicly compromising Koha Wiki usernames and
passwords which are not contained in the published archive.  The issue of
resetting wgSecretKey in LocalSettings.php could be avoided by obtaining a copy
of the Koha Wiki LocalSettings.php .  I have prepared a special nonpublic tar
archive for Koha developers interested in testing. 

Test instances were down for some extended periods in the past few days while I
was fixing bugs and regenerating the test instances.  Please note as before
that newly reinstalled MediaWiki instances take time for indexing etc. to catch
up over multiple days and indexing requires actual use to weight the result set
properly.
.  They may frequently go down or become slow when: regenerated for code
testing; or excess RAM or CPU use running some memory intensive processes
unrelated to Koha on the VPS.  Non-Koha use of the VPS starting too many
processes still occasionally leads the OOM killer to stop mysqld for which I
should add a monitoring and restart service for when I forget to check after
such excess RAM usage.

Reinstalled test instance of the Koha Wiki using Postgres at
https://koha-mw-pg-test01.agogme.com/ .

Koha test wiki migrated to MySQL at https://koha-mw-my-test01.agogme.com/ .

Koha MySQL test wiki upgraded to MediaWiki 1.35 LTS at
https://koha-mw-my-test01-upgr.agogme.com/ .

Please note that some adjustment of the upgraded wiki, such as the superseded
language change template at the bottom of the home page, may be outside the
ordinary scope of an automated upgrade process and require manual correction. 
The job queue may be full for an extended period after reinstalling or
upgrading a test wiki instance because reindexing is necessary.  Ordering of
search query result set improves with actual use but appears to be ordered by
page creation initially after reindexing rather than page modification or other
potentially more useful relevancy ranking which develops over time as the wiki
instance is used.

>From the current changelog.

In README.txt
-------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Clarified language and instruction variously.

In koha_migrate_mwiki_db_and_upgrade.ini
---------------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Corrected location of debugging output logs for
koha-mediawiki-pgsqltomysql.py .

Added operating system version configuration for improving installation.

In koha-migrate-mwiki-db-and-upgrade-startup.sh
-----------------------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Decreased verbosity of bash startup script when calling without
arguments for which koha-migrate-mwiki-db-and-upgrade.pl responds with a
usage reminder leaving response from the bash startup script unnecessary.

In koha-migrate-mwiki-db-and-upgrade.pl
---------------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Corrected for temporary file inadvertantly created when creating download
directory for upgraded MediaWiki installation archive.

Corrected for setting permissions of pgpass file too early for newly
created pgpass file which led to failure of pg_restore.

Added removeal of pgpass file after use by pg_restore.

Corrected typo for binary in mysql command option
--default-character-set .

Corrections for excessive copying of files from the production archive to
the MediaWiki upgrade test instance when scope of binary files and other
files not suitable for version control had been moved to a separate
archive from version control files.

Added additional section heading comments for demarcating more code
sections for better readability of code and logs.

Added operating system version configuration for improving installation.

Removed redundant code section previously included with the intention
of chaning the section for additional MediaWiki testing instances.

In koha-mediawiki-pgsqltomysql.py
---------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Corrected location of debugging logs.

In koha-mwiki-instances-postinstall.sh
--------------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Added calls to runJobs.php.

Clarified section heading comments demarcating code
sections for better readability of code and logs.

In koha-migrate-mwiki-db_and-upgrade-forexport.sh
-------------------------------------------------

Substituted lowercase in filename for compliance with common
conventions.

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

In get-mwiki-mbox-templates.sh
------------------------------

Changed use of underscores to hyphens for file and directory names
for compliance with common conventions.

Added explanatory header.

------------------------------------------

Pending Bug Fixes.

Full View of Saved Files Not Displaying.

I am investigating why the full view of at least some image files in the form
of /wiki/File:some_file are not displaying for even the direct restore of the
Koha MediaWiki Postgres instance.

PHP LTS on sury.org Only Supports Debian Stable and Old Stable.

Debian PHP maintainer, Ondřej Surý, has been continually supplying PHP LTS
updates for PHP 5.6 and PHP 7.4 as well as other versions of PHP with ongoing
patches which have been helpful when testing database migration and upgrades
using Debian 9.  Sometime in the past two weeks, Debian 9 support was dropped
on sury.org .  The sury.org packages for Debian 9 are still available at
archive.org and other possible archives and continue to run on my Debian 9 test
server.  The sury.org packages for Debian 11 stable and 10 old stable continue
to be available.  Debian 9 had been especially good for testing because it was
much less likely to have too many changes in database versions or other
dependencies which might break an old version of MediaWiki which we have stuck
in Postgres which first needs conversion to MySQL. 

As with any project, MediaWiki uses stable dependencies and takes time to adopt
new versions of dependencies which may introduce breaking changes.  The current
Koha Wiki using MediaWiki 1.16 mistakenly using Postgres was designed for PHP
5.3 but seems to be managing fine with PHP 5.6.  MediaWiki 1.35 LTS uses PHP
7.3 or 7.4.  No versions of MediaWiki yet use PHP 8.  The main issue is the
utility of having PHP 5.6 on a system where to help verify the correctness of
database migration before upgrading MediaWiki.

There are several workarounds.  Please keep in mind that moving the Koha wiki
to Debian 10 or 11 at least after upgrading to MediaWiki 1.35 LTS is presumed
in any case.

The installations of PHP 5.6 and PHP 7.4 continue to work on my test instance
of Debian 9 but cannot be as easily replicated on another instance of Debian 9.
 An alternative archive might be used in the place of sury.org .  Nevertheless,
my test instance of Debian 9 could be used for both MediaWiki database
migration from Postgres to MySQL and MediaWiki upgrade to 1.35 LTS if really
necessary. 

The best option is probably the following:  Debian 8 with PHP 5.6 will work for
MediaWiki 1.16 database migration from Postgres to MySQL and may even be better
than Debian 9 for database migration.  Debian 10 or 11 might be used for
upgrade to MediaWiki 1.35 LTS from a a migrated MySQL database dump and
associated files from the Koha MediaWiki instance.  Ondřej Surý continues to
provide PHP LTS support for the current Debian stable 11 and Debian old stable
10.  The scripts which currently run database migration and upgrade
sequentially would need at least functional division to support upgrading on a
different server from the database migration.  In the past few days, I have
improved section headings for easier log reading and to help more easily
identify code sections which would need at least a functional distinction
between migration and upgrade tasks if running distinctly on different virtual
servers with different Debian versions.  

An easier option might still work with migration and upgrade.  Running PHP 5.6
and 7.4 for everything starting on Debian 10 might work but the risk increases
for Postgres or MySQL versions in Debian 10 being too far out of sink with
MediaWiki 1.16 for database migration to work correctly especially considering
post-database migration MediaWiki maintenance scripts required to have a
working instances of MediaWiki even if merely used to assure working MediaWiki
instances before upgrading to MediaWiki 1.35 LTS.

Ondřej Surý provides commercial support with Freexian for PHP LTS releases for
Debian 8 and 9 but that is probably not a proper option for Koha.  See
https://php.freexian.com/ .

We could always compile PHP versions from source as needed.

pg_restore ftell Warning.

I had not remembered well my previous investigation into the ftell warning when
running pg_restore.  The database restore completes and appears to be correct.

PGPASSFILE=$pgpass_file_path pg_restore -h localhost -p 5432 -U postgres -w -d
database_name < $pgdump_file_path

"pg_restore: [custom archiver] WARNING: ftell mismatch with expected position
--ftell used"

The pg_restore command ftell warning may be an incorrect presumption of data
and dump size when the dump file is piped.  The warning may be likely to be a
false alarm.

The workaround of specifying the dump file for pg_restore with the -f argument
gives an error when also specifying the database to which to restore
everything.  The database restore fails.

PGPASSFILE=$pgpass_file_path pg_restore -h localhost -p 5432 -U postgres -w -d
database_name -f $pgdump_file_path

"pg_restore: options -d/--dbname and -f/--file cannot be used together"

Not specifying the restore database has complicated restore in long past
testing partly because we had made a mistake initially of not following the
database convention of specifying the database and the database user as the
same name and even changed the database user to be distinct from the database
name which can lead to tricky issues in restore where the database has two
users with imperfectly overlapping permissions which need to be specified with
excess care.

There may not be a completely satisfactory workaround for the warning which may
merely be a false alarm.  Some test might be devised to verify that the issue
is a false alarm.

Maintenance Job Control.

I added some support for running MediaWiki maintenance/runJobs.php to the post
install shell script for MediaWiki test instances but I need to add control for
maintenance/runJobs.php as an additional separate recurring process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 10:44:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 08:44:27 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-y3eqOA3ZIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to victor from comment #24)
> In ubuntu 20.05 and Koha 22.05.02.000
> $ koha-upgrade-schema faes
> Upgrading database schema for faes
> DEV atomic update
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/atomicupdate/bug_30899.
> pl  [22:09:37]: Bug 30899 - Check borrower_attribute_types FK constraint
> (30449 follow-up)

Nothing wrong here. Your DB schema is up-to-date.

Lucas forgot to move a file from the atomicupdate directory to db_revs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:02:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:02:15 +0000
Subject: [Koha-bugs] [Bug 31067] Sub-tools permission not applying on
 intranet-main.tt
In-Reply-To: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31067-70-6UTEY1jp1Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:02:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:02:23 +0000
Subject: [Koha-bugs] [Bug 31067] Sub-tools permission not applying on
 intranet-main.tt
In-Reply-To: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31067-70-mcW6rcZRw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136745|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137200&action=edit
Bug 31067: Fixing missing permission check

This patch just fixes a missing permission on the intranet main page.
Currently, the Additional Content modules allows people to edit, modify or
create new additional content just by checking if they have any tool permission
at all, and not the right one.

To test:
1 - From the staff client, create a news article for the intranet.
2 - Create (or use) an additional staff patron, giving them the necessary
permissions to access the intranet, but no tool permission.
3 - Using another browser (or incognito mode), log on the intranet page with
your new staff account, you should be able to see the news content, but not
edit or delete it. That's the expected behavior.
4 - From your main admin account, give your test account the
edit_additional_contents permission.
5 - Your test account should now be able to edit/delete the news content. This
is also expected behavior.
6 - Using the main account again, remove this time the edit_additional_contents
but add any other subtool permission (edit_calendar is a good one for instance)
7 - Repeat step 5 and confirm that your test account can still edit or delete
the news content. This shouldn't happen.
8 - Apply patch
9 - Repeat steps 4-6, and confirm that your test account can now only edit or
delete news content if they have the edit_additional_contents permission
enabled.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:05:35 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-KJ550fot82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #68 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Did we lose the tests?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:07:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:07:52 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-kN7C8jNXtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
         Depends on|                            |29660

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Michal, did you write this patch? Why is the author Nick?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660
[Bug 29660] reserve/request.pl should not deal with biblioitem
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:07:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:07:52 +0000
Subject: [Koha-bugs] [Bug 29660] reserve/request.pl should not deal with
 biblioitem
In-Reply-To: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29660-70-TPjii33qqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29660

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30769


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769
[Bug 30769] Typo: Item typeX:
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:13:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:13:22 +0000
Subject: [Koha-bugs] [Bug 31024] Switch to the REST Datatables for
 Suggestion Management
In-Reply-To: <bug-31024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31024-70-u1hTsLFRot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31024

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
It can be tricky to keep the same behaviour we have now. The "Organize by"
views.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:16:04 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-MfviWodjtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

--- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Fridolin Somers from comment #12)
> > I do reproduce.
> > 
> > Searching for bööks.
> > 
> > Browsing from result n°18 to n°19 then n°20 does not break encoding.
> > Browsing from result n°20 to n°19 breaks encoding.
> > Browsing from result n°19 to n°18 does not break encoding.
> > 
> > o_O
> 
> With or without the patch?

Without patch.

Feels strange to remove URI escape, we should try with URI chars like & ? =

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:22:26 +0000
Subject: [Koha-bugs] [Bug 31108] add missing shebang line to
 ./t/00-check-atomic-updates.pl
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-LxhAqz6UuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Why do we need it?
It's missing in some other files.
Why this path?

% git grep '/usr/bin/perl' t|wc -l
486

% git grep '/usr/bin/env perl' t|wc -l
43

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:31:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:31:32 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-n0bL2gJihY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137201&action=edit
Bug 23991: Don't display empty div if no suggestions exist

If no suggestions exist we should not display an empty tab div

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:31:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:31:45 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-AD3P5ajxEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:48:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:48:26 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-NRT5f2QdQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #13)
> Created attachment 136715 [details] [review]
> Bug 30982: Make code more re-usable

Shouldn't you call search_limited instead of search then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 11:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 09:58:38 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-Zh1AUmrqr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 137185
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137185
Bug 31106: Fix links generated in XSLTs

Review of attachment 137185:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31106&attachment=137185)
-----------------------------------------------------------------

Bit of a deeper review this time for master...

::: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
@@ +578,4 @@
>          </xsl:if>
>      </xsl:template>
>  
> +    <xsl:template name="fix_query_term">

Maybe we could call this 'quote_term' or something.. 'fix' feels a bit
unspecific?

We're doing two things here actually.. we're escaping quotes and URI escaping..
then we leave the overall quoting of the whole string to the caller..

Maybe 'escape_phrase' or 'escape_term' then?

@@ +586,5 @@
> +                    <xsl:value-of select="$term"/>
> +                </xsl:with-param>
> +            </xsl:call-template>
> +        </xsl:variable>
> +        <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/>

I'm a bit confused by the translate.. we're translating '()' here, but we were
translating '/' in some places instead before this patch.. can you explain your
choice?

@@ +589,5 @@
> +        </xsl:variable>
> +        <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/>
> +    </xsl:template>
> +
> +    <xsl:template name="escape_quotes">

Excellent, you renamed it here to 'escape_quotes' as opposed to 'remove_quotes'
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:05:11 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-I2H879yz3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Martin Renvoize from comment #13)
> > Created attachment 136715 [details] [review] [review]
> > Bug 30982: Make code more re-usable
> 
> Shouldn't you call search_limited instead of search then?

We do so internally:
https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/REST/Plugin/Objects.pm#L189-L191

So $c->objects->search is calling a mojolicious helper method above.. as you
can see it looks for the presence of a search_limited in the plural object and
calls it in place of search if one is found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:06:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:06:16 +0000
Subject: [Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall
 on various pages do not work
In-Reply-To: <bug-30944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30944-70-CAczcaKUZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:09:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:09:23 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-1qjTJdQyWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:19:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:19:07 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-9t39sDRo4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Remote branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:56:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:56:00 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extention to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-lgNC5XMObf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|add missing shebang line to |rename
                   |./t/00-check-atomic-updates |./t/00-check-atomic-updates
                   |.pl                         |.pl extention to *.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:56:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:56:01 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for sms transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-N0ZkT4UlGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137202&action=edit
Bug 30838: (QA follow-up) Add unit tests

Two tests added, one in t/db_dependent/Circulation.t to catch the
initial setting of to_address at enqueue time and a second in
t/db_dependent/Letters.t to catch the correcting at send time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:57:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:57:22 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extention to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-IbEA2l67K0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137198|0                           |1
        is obsolete|                            |

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
Created attachment 137203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137203&action=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extention to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 12:57:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 10:57:55 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extention to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-5YMhlrFxZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #2)
> Why do we need it?

ah, my mistake - the solution was to rename the file :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:04:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:04:36 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-sMJCT06BSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks like we're missing a unit test here for the
Koha/SearchEngine/Elasticsearch.pm change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:04:42 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-1BcBqnyzA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:05:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:05:01 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-hD88T8MegG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:07:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:07:05 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-6hBW5qzjhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|rename                      |rename
                   |./t/00-check-atomic-updates |./t/00-check-atomic-updates
                   |.pl extention to *.t        |.pl extension to *.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:09:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:09:21 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-C5SL7MOlfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:15:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:15:24 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-6YBQ9zTUpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137203|0                           |1
        is obsolete|                            |

--- Comment #5 from Mason James <mtj at kohaaloha.com> ---
Created attachment 137204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137204&action=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:22:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:22:54 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-7ahheeOFC7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is really nice and elegant David!  QAing now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:41:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:41:18 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-iCri2qYEWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:41:24 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-PwMt9wyI9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135754|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137205&action=edit
Bug 30570: Replace the use of jQueryUI tabs in OPAC templates

This patch switches to Bootstrap tabs anywhere in the OPAC where
jQueryUI tabs were used.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Test the item type/collection/shelvinglocation tabs on the advanced
  search page. Test that it works correctly with different variations of
  the OpacAdvancedSearchTypes system preference.
- Search for an authority record and view the details. The "Notes"
  tab should be styled correctly.
- Locate a bibliographic record and view the detail page. Verify
  that tabs are working, including all the options:
- Holdings
- Other holdings ( If OpacSeparateHoldings is enabled)
- Descriptions ( MARC notes )
- Subscriptions
- Serial collection (UNIMARC, untested)
- Components ( If ShowComponentRecords is enabled. Link to sample
  record:
  https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 )
- Comments
- Editions (OPACFRBRizeEditions)
- Html5media ( If HTML5MediaEnabled is on. Link to sample records:
  (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685)
- Images ( If OPACLocalCoverImages is enabled )

Bonus points for testing these tabs for which I don't have
credentials:
- Syndetics TOC
- Syndetics Excerpt
- Syndetics Reviews
- Syndetics AuthorNotes
- LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView
  set to "in tabs."
- NovelistSelect

- Check tabs on these patron-related pages:
  - Checkout history
  - Search history
  - Patron summary. The following tabs are
    ✓ Checkouts
    ✓ Relatives' checkouts
    ✓ Overdues
    ✓ Fines
    ✓ Relatives' fines
    ✓ Holds
    ✓ Recalls
    ✓ Article requests
    ✓ Overdrive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:54:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:54:17 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-Y0gouj3cMd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:54:20 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-653BF6zvfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137204|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 137206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137206&action=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:54:44 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-sJVj7d5s1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137050|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137207&action=edit
Bug 15187: Index 880 in Zebra the same as Elasticsearch

This patch modifies the MARC21 export to Zebra, so that 880 fields
are rewritten as their linked fields, in the same way that we
already do with Elasticsearch, so that the alternate graphic
representation of fields are indexed accordingly. (ie 880 $6245-01
Chinese titles will be indexed into the title index using the 245 rules)

Test plan:
0. Apply patch
1. Turn on ICU indexing
1b. vi /etc/koha/zebradb/etc/default.idx
1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml
1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml
1e. Restart Zebra server
1f. Re-index Zebra
2. Add record with a 880 $6 245-01 $a 教牧書信 field.
3. Search for this record using a title index with the Chinese title
4. Note that the record is correctly retrieved

(Note: This test probably works better using author or series as they
 present as links on the detail page which makes the fix more obviously
 useful.)

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:54:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:54:50 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-Umdth4MXPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137208&action=edit
Bug 15187: (QA follow-up) Add unit test

This patch adds a unit test for the newly introduced filter.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:55:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:55:13 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-4lBTipP0no@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
This is what I get after running step 1:

prove ./t | grep 00-check-atomic-updates.pl | wc -l
Use of uninitialized value $_ in pattern match (m//) at
/usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117.
skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line
53.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $cn_item in sprintf at
/kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48.

    #   Failed test 'Logger did not init correctly without permission'
    #   at t/Logger.t line 52.
    # Looks like you failed 1 test of 10.

#   Failed test 'Test01 -- Simple tests for Koha::Logger'
#   at t/Logger.t line 74.
# Looks like you failed 1 test of 1.
0

This is what I get after running step 3:

prove ./t | grep 00-check-atomic-updates.pl | wc -l
Use of uninitialized value $_ in pattern match (m//) at
/usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117.
skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line
53.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line
315.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line
315.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $cn_item in sprintf at
/kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48.

    #   Failed test 'Logger did not init correctly without permission'
    #   at t/Logger.t line 52.
    # Looks like you failed 1 test of 10.

#   Failed test 'Test01 -- Simple tests for Koha::Logger'
#   at t/Logger.t line 74.
# Looks like you failed 1 test of 1.
0

Signing off as file is renamed and tests pass for prove
t/00-check-atomic-updates.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 13:57:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 11:57:38 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-4EJ0oamxif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I added a unit test for you to get this through QA.. Tomas may want to rename
the filter at push.. I couldn't come up with a nicer name.. but I don't really
like they we call out it's a Zebra thing... 

What I've not managed to test.. does this cause any issues with non-icu indexed
Koha's.. I imagine not as you are unlikely to have such a field in your
database in the first place without having enabled ICU (all our customers are
ICU by default in case).

Passing QA.. scripts are happy, we're now covered by tests and it's a great
improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 14:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 12:18:39 +0000
Subject: [Koha-bugs] [Bug 18147] Show cover images in public lists in the
 staff client
In-Reply-To: <bug-18147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18147-70-in6j8EByfG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18147

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

--- Comment #3 from Holly <hc at interleaf.ie> ---
This is still an issue on the 21.11.05 release. It would be great if this
feature could be added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 14:34:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 12:34:36 +0000
Subject: [Koha-bugs] [Bug 31008] Long Term Support (LTS) version of Koha
In-Reply-To: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31008-70-S8pR1p4EDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008

--- Comment #3 from David Nind <david at davidnind.com> ---
Discussed at the 22 June 2022 meeting:
https://meetings.koha-community.org/2022/development_irc_meeting_22_june_2022.2022-06-22-14.02.log.html#l-203

Comment received on mailing list from Paul Poulain about ecosystem around Koha
such as the LTS versions of Ubuntu, Debian, database versions, and other
dependencies such as specific perl modules:
https://lists.koha-community.org/pipermail/koha-devel/2022-June/047145.html

> my main question is about the ecosystem around 
> Koha. For example, how to manage Koha LTS regarding 
> Debian/Ubuntu/Elastic Search/MariaDB... upgrades ? How can we be sure 
> that, in 2 years, Koha LTS will become "unmaintainable" because it 
> requires a Perl library that can't be upgraded and the underlying tool 
> (OS, search engine...) isn't maintained anymore in the compatible version ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 14:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 12:52:56 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-xuMRx3juXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #4)
> Comment on attachment 137185 [details] [review]
> Bug 31106: Fix links generated in XSLTs
> 
> Review of attachment 137185 [details] [review]:
> -----------------------------------------------------------------
> 
> Bit of a deeper review this time for master...
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl
> @@ +578,4 @@
> >          </xsl:if>
> >      </xsl:template>
> >  
> > +    <xsl:template name="fix_query_term">
> 
> Maybe we could call this 'quote_term' or something.. 'fix' feels a bit
> unspecific?

We are basically preparing a string so it can be used within bigger query
strings. I feel like 'prepare_query_term' is a better name. It is too
unespecific still...

> @@ +586,5 @@
> > +                    <xsl:value-of select="$term"/>
> > +                </xsl:with-param>
> > +            </xsl:call-template>
> > +        </xsl:variable>
> > +        <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/>
> 
> I'm a bit confused by the translate.. we're translating '()' here, but we
> were translating '/' in some places instead before this patch.. can you
> explain your choice?

That translate method is being used to remove (, ) and / alternatively in some
places. When you look at how Zebra searches work, you notice that those
characters are removed or translated into spaces for the query:

Z> f @attr 1=1033 "Uncond\"itional¿? ="
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 1, setno 1
SearchResult-1: term=Uncond cnt=1, term=itional cnt=1
records returned: 0
Elapsed: 0.011988
Z> f @attr 1=1033 "Uncond\"itional¿? )="
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 1, setno 2
SearchResult-1: term=Uncond cnt=1, term=itional cnt=1
records returned: 0
Elapsed: 0.002718
Z> f @attr 1=1033 "Uncond\"itional¿? ()="
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 1, setno 3
SearchResult-1: term=Uncond cnt=1, term=itional cnt=1
records returned: 0
Elapsed: 0.002441
Z> f @attr 1=1033 "Uncond\"itional¿?/ ()="
Sent searchRequest.
Received SearchResponse.
Search was a success.
Number of hits: 1, setno 4
SearchResult-1: term=Uncond cnt=1, term=itional cnt=1
records returned: 0
Elapsed: 0.003235

I think those translations were added because we just didn't quote the string
as this patch is doing. in fact, such 'fixes' should be engine-specific and
dealt with in the Koha::SearchEngine::{engine}::QueryBuilder module instead. I
would like to hear from David and Nick before moving on with just removing the
translates, but the feeling is... we were doing things wrong (not quoting) and
working around things...

> @@ +589,5 @@
> > +        </xsl:variable>
> > +        <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/>
> > +    </xsl:template>
> > +
> > +    <xsl:template name="escape_quotes">
> 
> Excellent, you renamed it here to 'escape_quotes' as opposed to
> 'remove_quotes' :)

Well, the 21.05 version of this patches actually remove the double quotes. I
might revisit that as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 15:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 13:32:10 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-IccFx6SJXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135252|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137209&action=edit
Bug 29333: Fix encoding of imported UNIMARC authorities

MARC::Record and MARC::File::* modules sometimes use the position 09 of
the leader to detect encoding. A blank character means 'MARC-8' while an
'a' means 'UTF-8'.

In a UNIMARC authority this position is used to store the authority type
(see
https://www.transition-bibliographique.fr/wp-content/uploads/2021/02/AIntroLabel-2004.pdf
[FR]).
In this case, 'a' means 'Personal Name'.

The result is that the import will succeed for a Personal Name
authority, but it will fail for all other authority types.

Steps to reproduce:
0. Be sure to have a Koha UNIMARC instance.
1. Download the MARCXML for "Honoré de Balzac"
   curl -o balzac.marcxml https://www.idref.fr/02670305X.xml
2. Verify that it's encoded in UTF-8
   file balzac.marcxml
   (should output "balzac.marcxml: XML 1.0 document, UTF-8 Unicode
   text")
3. Go to Tools » Stage MARC for import and import balzac.marcxml with
   the following settings:
   Record type: Authority
   Character encoding: UTF-8
   Format: MARCXML
   Do not touch the other settings
4. Once imported, go to the staged MARC management tool and find your
   batch. Click on the authority title "Balzac Honoré de 1799-1850" to
   show the MARC inside a modal window. There should be no encoding
   issue.
5. Write down the imported record id (the number in column '#') and go
   to the MARC authority editor. Replace all URL parameters by
   'breedingid=THE_ID_YOU_WROTE_DOWN'
   The URL should look like this:
   /cgi-bin/koha/authorities/authorities.pl?breedingid=198
   You should see no encoding issues. Do not save the record.
6. Import the batch into the catalog. Verify that the authority record
   has no encoding issue.
7. Now download the MARCXML for "Athènes (Grèce)"
   curl -o athènes.marcxml https://www.idref.fr/027290530.xml
8. Repeat steps 2 to 6 using athènes.marcxml file. At steps 4 and 5 you
   should see encoding issues and that the position 9 of the leader was
   rewritten from 'c' to 'a'. Strangely, importing this batch fix the
   encoding issue, but we still lose the information in position 09 of
   the leader

This patch makes use of the MARCXML representation of the record instead
of the ISO2709 representation, because, unlike
MARC::Record::new_from_usmarc, MARC::Record::new_from_xml allows us to
pass directly the encoding and the format, which prevents data to be
double encoded when position 09 of the leader is different that 'a'

Test plan:
- Follow the "steps to reproduce" above and verify that you have no
  encoding issues.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 15:32:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 13:32:24 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-8eCvO9LkoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 15:32:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 13:32:59 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-Nw2QXg0XZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice bit of cleaning up along with the fix.. works well and I'm not seeing any
regressions.. 

Unit tests included and passing, QA scripts happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 15:37:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 13:37:29 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-xNumpSGzdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136161|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137210&action=edit
Bug 30976: Display biblio's cover images first

If one add cover images at item's level, then biblio level, the cover images
of the items are displayed first on the main "cover slider" at the top of the
page.
We should displayed biblio cover images first, then the ones for the items.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 15:38:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 13:38:35 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-laelKYKLgc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
No regressions found, works as expected.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:04:55 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-iYlxxFoZqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #6 from David Nind <david at davidnind.com> ---
Everything works as per the test plan -  can sign off, or will do so if no
additional changes area required.

For the test plan it stelfm, the 'Show Analytics' link is visible before the
patch (steps 4 and 5) - for both manually added and using the EasyAnaltics
EasyAnaltics system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:06:30 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-wob3JIS4gj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:10:12 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-FAbQi7bgu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137211&action=edit
Bug 30650: Add dayjs customParseFormat plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:10:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:10:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Pv6u3qPeQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137212&action=edit
Bug 30650: Take dateformat into account

dayjs init was not passing the dateformat.
We really need to clean the date handling with the following two bugs:
  Bug 30310 - Replace Moment.js with Day.js
and
  Bug 30718 - Use flatpickr's altInput option everywhere

But it's outside the scope of this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:16:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:16:33 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-T3C3DaDqPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Do I need to review this 200kb patch again? :-/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:18:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:18:04 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-fUobPtvnHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #6)
> Everything works as per the test plan -  can sign off, or will do so if no
> additional changes area required.
> 
> For the test plan it stelfm, the 'Show Analytics' link is visible before the
> patch (steps 4 and 5) - for both manually added and using the EasyAnaltics
> EasyAnaltics system preference.

I'm redoing it as per a conversation with Martin. Leaving as ASSIGNED until I
resubmit. No behavior changes, just putting things in the right places to aid
maintainability.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:18:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:18:14 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-Pe44WR4oKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:18:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:18:18 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-R05J2fGXj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137206|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137213&action=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:20:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:20:02 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-8skcAl0efV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #73 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Lari Taskula from comment #69)
> I think it would be user friendly to let patron uncancel the cancellation
> request in OPAC, just because even with the confirmation dialog box someone
> may accidentally cancel a wrong hold or start regretting their action later.

Is that even possible if holds are automatically triggered for the next hold
after cancellation? (maybe I'm not completely understanding the process).

Anyway, IMO, I think it is overkill to have a backup for a backup.  The
confirmation should be the end-all.  An undo seems like it is out of the scope
of this project anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:21:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:21:05 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-bNP51VQRZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137205|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137214&action=edit
Bug 30570: Replace the use of jQueryUI tabs in OPAC templates

This patch switches to Bootstrap tabs anywhere in the OPAC where
jQueryUI tabs were used.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

- Test the item type/collection/shelvinglocation tabs on the advanced
  search page. Test that it works correctly with different variations of
  the OpacAdvancedSearchTypes system preference.
- Search for an authority record and view the details. The "Notes"
  tab should be styled correctly.
- Locate a bibliographic record and view the detail page. Verify
  that tabs are working, including all the options:
- Holdings
- Other holdings ( If OpacSeparateHoldings is enabled)
- Descriptions ( MARC notes )
- Subscriptions
- Serial collection (UNIMARC, untested)
- Components ( If ShowComponentRecords is enabled. Link to sample
  record:
  https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78023 )
- Comments
- Editions (OPACFRBRizeEditions)
- Html5media ( If HTML5MediaEnabled is on. Link to sample records:
  (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10685)
- Images ( If OPACLocalCoverImages is enabled )

Bonus points for testing these tabs for which I don't have
credentials:
- Syndetics TOC
- Syndetics Excerpt
- Syndetics Reviews
- Syndetics AuthorNotes
- LibraryThing for Libraries (with LibraryThingForLibrariesTabbedView
  set to "in tabs."
- NovelistSelect

- Check tabs on these patron-related pages:
  - Checkout history
  - Search history
  - Patron summary. The following tabs are
    ✓ Checkouts
    ✓ Relatives' checkouts
    ✓ Overdues
    ✓ Fines
    ✓ Relatives' fines
    ✓ Holds
    ✓ Recalls
    ✓ Article requests
    ✓ Overdrive

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

Bug 30570: (follow-up) Correct rebase errors

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:21:24 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-uz1beU62n6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
           Keywords|additional_work_needed      |

--- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed to master. Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:21:24 +0000
Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha
 namespace
In-Reply-To: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23990-70-exWHffl2Xy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Bug 23990 depends on bug 23991, which changed state.

Bug 23991 Summary: Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:21:24 +0000
Subject: [Koha-bugs] [Bug 31024] Switch to the REST Datatables for
 Suggestion Management
In-Reply-To: <bug-31024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31024-70-or2QgMMWoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31024
Bug 31024 depends on bug 23991, which changed state.

Bug 23991 Summary: Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:22:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:22:16 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-E2IKJRJ4X1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Carolyn Hughesman <chughesman at cclsny.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chughesman at cclsny.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:23:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:23:35 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-UdmPfM1PO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #15 from Owen Leonard <oleonard at myacpl.org> ---
I don't know if it's what you were complaining about Jonathan but I re-uploaded
the patch with the signoffs on it. It was my carelessness that omitted them
from the previous rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:25:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:25:01 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-lRMWSgbqcz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:25:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:25:06 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-Tk7OesER9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137215&action=edit
Bug 29951: Fix EXPORT for C4::ClassS*Routine modules

Can't locate object method "subclasses" via package "C4::ClassSplitRoutine" at
/kohadevbox/koha/C4/ClassSplitRoutine.pm line 53

Certainly from bug 17600.

Test plan:
Home -> Administration -> Classification sources -> New splitting rule

And create classification sources and filing rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:25:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:25:18 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-N4PRpjG4dr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17600
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
[Bug 17600] Standardize the EXPORT
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:25:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:25:18 +0000
Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT
In-Reply-To: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17600-70-ZO1GELoYbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29951


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951
[Bug 29951] Cannot add splitting rule to classification sources
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:25:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:25:34 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-0tSoVjCt9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Sorry, I was not aware of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:26:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:26:08 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-NApGxBzkMS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:33:47 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-kjtsNyz9Qa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Owen Leonard from comment #15)
> I don't know if it's what you were complaining about Jonathan but I
> re-uploaded the patch with the signoffs on it. It was my carelessness that
> omitted them from the previous rebased patch.

I hadn't noticed that! :D
Now that you set the status back to PQA I am happy :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:36:59 +0000
Subject: [Koha-bugs] [Bug 31109] New: Add ability to lock bibliographic
 record or alert staff when another user is in the same bibliographic record
Message-ID: <bug-31109-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109

            Bug ID: 31109
           Summary: Add ability to lock bibliographic record or alert
                    staff when another user is in the same bibliographic
                    record
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When a cataloger is in bibliographic record-making changes, it would be nice to
alert other staff (if they happen to be in the same bibliographic record) with
a message box to indicate another staff member is also making changes. 
Additionally, allow staff to view the bibliographic record but not make changes
if another staff member is also in the bibliographic record. This is a concern
for larger consortiums that share records to have some sort of fail-safe method
of making sure edits by any staff are saved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:38:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:38:03 +0000
Subject: [Koha-bugs] [Bug 31109] Add ability to lock bibliographic record or
 alert staff when another user is in the same bibliographic record
In-Reply-To: <bug-31109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31109-70-ZuwpefoNdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:40:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:40:14 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-Wz5y0BRiVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I think I found a bug, it's not working if you modify dateformat. See also
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137212

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:50:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:50:15 +0000
Subject: [Koha-bugs] [Bug 31109] Add ability to lock bibliographic record or
 alert staff when another user is in the same bibliographic record
In-Reply-To: <bug-31109-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31109-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31109-70-UinorMchvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
How do you remove the lock or whatever mechanism implemented when the record is
opened and never saved (browser crashed etc.) ? To prevent keeping it locked
for no reason..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:56:21 +0000
Subject: [Koha-bugs] [Bug 31110] New: Use `_should_be_fk` for ReturnClaim in
 TestBuilder
Message-ID: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

            Bug ID: 31110
           Summary: Use `_should_be_fk` for ReturnClaim in TestBuilder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 29495

In bug 29495 we added a follow-up to fix the TestBuilder test.  However, we
added the change to the wrong place; Instead of forcing undefined in the test
data and not creating a link, we should add the field lacking a proper foreign
key to the list in _should_be_fk

These are deliberately not foreign keys because they link to one of two
tables.. the original and old_ version tables.. but we do add dbix::class
relations for the link.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495
[Bug 29495] Issue link is lost in return claims when using
'MarkLostItemsAsReturned'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 16:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 14:56:21 +0000
Subject: [Koha-bugs] [Bug 29495] Issue link is lost in return claims when
 using 'MarkLostItemsAsReturned'
In-Reply-To: <bug-29495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29495-70-G43Gg9AYyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31110


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110
[Bug 31110] Use `_should_be_fk` for ReturnClaim in TestBuilder
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:02:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:02:03 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-tPgp4jucE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137216&action=edit
Bug 31110: Move 'ReturnClaim.issue_id' to _should_be_fk

This patch moves the issue_id field definition for ReturnClaim in
TestBuilder to the list of 'fake' keys in _should_be_fk.

Test plan
1) Run t/db_dependent/TestBuilder.t before applying the patch
2) Run t/db_dependent/TestBuilder.t after applying the patch
3) Signoff if the test passes both times.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:04:46 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-DPbuAhgZB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #3)
> Sorry, I was not aware of this bug.

It fell off my radar too. Thx for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:04:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:04:56 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-8jM6kwLBJR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #217 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137217&action=edit
Bug 30275: (QA follow-up) Fix TestBuilder.t

This patch adds 'CheckoutRenewal.checkout_id' to the list of non-foreign
key relations found in _should_be_fk.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:05:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:05:46 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-81pda2p3cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:07:00 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-iFVK5sK3Nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

--- Comment #2 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137218&action=edit
Bug 30922: Make the "Relative's checkouts" table configurable by the table
settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are
hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:07:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:07:43 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-pDifiJM6V7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |shi-yao.wang at inLibro.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
                 CC|                            |philippe.blouin at inlibro.com
                   |                            |, shi-yao.wang at inLibro.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:14:51 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-qU8ltUCpyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Failing QA for comment 18. Marcel I waiting for an answer from you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:19:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:19:34 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-cC3Kiw6FKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed

--- Comment #218 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-up pushed to master. Thanks Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:20:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:20:54 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-lfdIfkygvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
           Assignee|chris at bigballofwax.co.nz    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:23:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:23:09 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-R0OB5LCqCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133596|0                           |1
        is obsolete|                            |

--- Comment #285 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137219&action=edit
Bug 17015: Performance comparison (images)

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:23:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:23:19 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-98a1Jo3m0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133597|0                           |1
        is obsolete|                            |

--- Comment #286 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137220&action=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:23:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:23:29 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-ejuiSA1duX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133598|0                           |1
        is obsolete|                            |

--- Comment #287 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137221&action=edit
Bug 17015: Install scripts for DiscreteCalendar

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:23:40 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-68SihP68Zq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133599|0                           |1
        is obsolete|                            |

--- Comment #288 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137222&action=edit
Bug 17015: Schema file for new discrete_calendar table

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:23:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:23:52 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-qkaXeRLOqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133600|0                           |1
        is obsolete|                            |

--- Comment #289 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137223&action=edit
Bug 17015: Tests for DiscreteCalendar

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:03 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-STalZUSfoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133601|0                           |1
        is obsolete|                            |

--- Comment #290 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137224&action=edit
Bug 17015: When using book drop mode, set check in time as closing hours

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:14 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-6tYoogM6S6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133602|0                           |1
        is obsolete|                            |

--- Comment #291 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137225&action=edit
Bug 17015: Automatically update calendar when creating or deleting a branch

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:24 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-PP0gHNXUOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133603|0                           |1
        is obsolete|                            |

--- Comment #292 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137226&action=edit
Bug 17015: Rebase and tests for discrete calendar

This patch is a rebase of all the previous patches in order to show the
discrete calendar.

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:35 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-xGBn1bizEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133604|0                           |1
        is obsolete|                            |

--- Comment #293 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137227&action=edit
Bug 17015: DiscreteCalendar->new() method is now in a HASH

This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
 ~ The error "Can't use string ("branchcode") as a HASH ref while
   "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar

USING THE DISCRETE CALENDAR:
1- New UI
  a) Calendar on the left
  b) Holidays list on the right
2- New color system for holiday types:
  a) Working day : white
  b) Unique holiday: red
  c) Holiday repeating weekly: yellow
  d) Holiday repeating yearly: orange
  e) Floating holiday: green
  f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:44 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-LWJaxWN25V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133605|0                           |1
        is obsolete|                            |

--- Comment #294 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137228&action=edit
Bug 17015: Fixing QA tools failures

This patch fixes tests that fails with the QA tool.

To test, run the QA tool
All tests should say OK except 2 that fails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:51 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-6zeoH2VzsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|tomascohen at gmail.com        |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:24:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:24:55 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-hRtqIcZ1jf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133678|0                           |1
        is obsolete|                            |

--- Comment #295 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137229&action=edit
Bug 17015: Check out with the useDaysMode preference

When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.

To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:31:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:31:01 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-WQ3I226ST3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It doesn't apply on master, and when fixing it I get the error for
CheckoutRenewal back!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:41:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:41:10 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-T01bFprjYW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136467|0                           |1
        is obsolete|                            |

--- Comment #37 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137230&action=edit
Bug 30988: Add generic OpenIDConnect client implementation

A generic OpenID Connect implementation.

Test plan:
1- Set up an OAuth2 provider that has a discovery doc (e.g. for google it's
https://accounts.google.com/.well-known/openid-configuration) and note down the
client id and client secret.
Docs to help setup:
google: https://developers.google.com/identity/protocols/oauth2/openid-connect
       
https://koha-community.org/manual/20.11/en/html/administrationpreferences.html
gitlab: https://docs.gitlab.com/ee/integration/oauth_provider.html
2- Apply the patch
3- Run atomicupdate to update database
4- Configure system preferences:
    a- Set OIDC to Yes
    b- Enter the url to the discovery doc of your OAuth2 provider
    c- Fill OIDCOAuth2ClientID with noted client id
    d- Fill OIDCOAuth2ClientSecret with noted client secret
    e- Change OIDCProviderName to change the text displayed on OIDC login
buttons

    f- Configure the other related system preferences as you wish. They
shoud work the same way as the similar googleopenidconnect system
preferences.
5- If OIDCAutoRegister is set to Don't allow, have a koha
account with the same email as the one used by your OAuth2 provider.
6- In OPAC, sign in using OpenID Connect.
7- You may have to log into your OpenID provider account and accept conditions.
It should finally log you into the koha account.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:41:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:41:13 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-K4qYkaLCBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136468|0                           |1
        is obsolete|                            |

--- Comment #38 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137231&action=edit
Bug 30988: Moving id token validation code into a module

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:41:17 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-3VlqjlYuNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136469|0                           |1
        is obsolete|                            |

--- Comment #39 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137232&action=edit
Bug 30988: Fix minor formatting issues

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:41:38 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-MEE6zLpTnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #40 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 17:53:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 15:53:14 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-H1Q6rAecNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I agree with Marcel that the endpoint route doesn't feel correct. In our API we
stick to using nouns instead of verbs (more RPC-ish).

So I'd suggest

POST /api/v1/auth/otp/token_delivery

I haven't read the patches yet, but I'd like to mention that, to me, OTP should
be generated in very specific cases and so our handling in V1/Auth.pm needs to
be very careful. Somehow, we need to identify a session that is in an
intermediate state: it already identified correctly but still needs a specific
action. So not any active session should be able to request a OTP.

As I said, I haven't reviewed this completely, so take it with a grain of salt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 18:37:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 16:37:15 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-F05oSOUIZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #3 from victor <vbovictor at gmail.com> ---
is already defined in 

nano etc/cron.daily/koha-common 

koha-run-backups --days 2 --output /var/spool/koha

however it is not generating backup

koha-dump instance

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 18:48:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 16:48:01 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-Ch0O25kfUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #4 from victor <vbovictor at gmail.com> ---
Would I need to set permission for /var/spool/koha ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:08:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:08:17 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-GQsr8OTrsc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137207|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137233&action=edit
Bug 15187: Index 880 in Zebra the same as Elasticsearch

This patch modifies the MARC21 export to Zebra, so that 880 fields
are rewritten as their linked fields, in the same way that we
already do with Elasticsearch, so that the alternate graphic
representation of fields are indexed accordingly. (ie 880 $6245-01
Chinese titles will be indexed into the title index using the 245 rules)

Test plan:
0. Apply patch
1. Turn on ICU indexing
1b. vi /etc/koha/zebradb/etc/default.idx
1c. Replace charmap word-phrase-utf.chr with icuchain words-icu.xml
1d. Replace charmap word-phrase-utf.chr with icuchain phrases-icu.xml
1e. Restart Zebra server
1f. Re-index Zebra
2. Add record with a 880 $6 245-01 $a 教牧書信 field.
3. Search for this record using a title index with the Chinese title
4. Note that the record is correctly retrieved

(Note: This test probably works better using author or series as they
 present as links on the detail page which makes the fix more obviously
 useful.)

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:08:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:08:21 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-eD0YeAK4Xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137208|0                           |1
        is obsolete|                            |

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137234&action=edit
Bug 15187: (QA follow-up) Add unit test

This patch adds a unit test for the newly introduced filter.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:27:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:27:10 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-BrMuwTpTG4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Weird.. it passed before we made the same change for CheckoutRenewals.. seems
we can't add the same thing twice.

We can certainly leave this one as is for now..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:32:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:32:33 +0000
Subject: [Koha-bugs] [Bug 31110] Use `_should_be_fk` for ReturnClaim in
 TestBuilder
In-Reply-To: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31110-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31110-70-StCeoXrAkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31110

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Needs Signoff               |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:53:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:53:30 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-WaOrothesp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:53:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:53:33 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-bOzHMkkt7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136807|0                           |1
        is obsolete|                            |

--- Comment #8 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137235&action=edit
Bug 30025: Split BiblioAddsAuthorities into two sysprefs

This patch adds two new sysprefs:
AutoLinkBiblios
AllowManualAuthorityEditing

Both inherit the setting from BiblioAddsAuhtorities which is removed

To test:
1 -Apply patches
2 - Update database
3 - Confirm old setting is transferred to new option
4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing
set to allow
5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing
set to don't allow
6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set
AllowManualAuthorityEditing to add unlinked heading)
7 - Confirm new bib notlinked when AutoLinkBiblios is disabled
8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading
doesn't match an authority and  AutoCreateAuthorities is disabled
9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but
heading doesn't match an authority and  AutoCreateAuthorities is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:53:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:53:37 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-EGzf9HceAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

--- Comment #9 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137236&action=edit
Bug 30025: Split BiblioAddsAuthorities into two sysprefs

Followed Nick's testing procedure, works good

This patch adds two new sysprefs:
AutoLinkBiblios
AllowManualAuthorityEditing

Both inherit the setting from BiblioAddsAuhtorities which is removed

To test:
1 -Apply patches
2 - Update database
3 - Confirm old setting is transferred to new option
4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing
set to allow
5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing
set to don't allow
6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set
AllowManualAuthorityEditing to add unlinked heading)
7 - Confirm new bib notlinked when AutoLinkBiblios is disabled
8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading
doesn't match an authority and  AutoCreateAuthorities is disabled
9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but
heading doesn't match an authority and  AutoCreateAuthorities is enabled

Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 19:57:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 17:57:14 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-ikDP7U0Mtw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

--- Comment #4 from Michal Urban <michalurban177 at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> Michal, did you write this patch? Why is the author Nick?

I'm not sure, I did write the patch. Maybe I messed something up when doing git
bz attach, I sign off on a lot of Nick's patches so it's possible that
information from one of his patches was attached to my patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:49:46 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-y2a6X8bWS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:49:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:49:52 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-ff5Irjvg7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137184|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:50:05 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-vDKxvjQbxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137185|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:50:13 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-kXoAFQr0D0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137183|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:51:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:51:41 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-TTwVC0GQh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137237&action=edit
Bug 31106: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:52:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:52:02 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-DelFG08lbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137238&action=edit
Bug 31106: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:52:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:52:28 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-4aJqrm2g94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137239&action=edit
Bug 31106: Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to and from host records using 773$t and 773$a.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Go to the child record, and notice the link back to the parent works
   :-D
10. Sign off :-D

Sponsored-by: Theke Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 20:54:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 18:54:02 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-dVsiiZJOWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:19:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:19:52 +0000
Subject: [Koha-bugs] [Bug 31111] New: Syndetic Unbound Cover Images would be
 nice to be visible on the Staff Client
Message-ID: <bug-31111-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31111

            Bug ID: 31111
           Summary: Syndetic Unbound Cover Images would be nice to be
                    visible on the Staff Client
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently, Syndetic images are visible to patrons on the OPAC, but it would be
extremely helpful to the staff to have these images on the Staff Interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:21:55 +0000
Subject: [Koha-bugs] [Bug 31111] Syndetic Unbound Cover Images would be nice
 to be visible on the Staff Client
In-Reply-To: <bug-31111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31111-70-8Mqp4nGTUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31111

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:26:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:26:51 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-xx6CxGSEAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:37:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:37:35 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-AL58rbiwqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137240&action=edit
Bug 31104: Put each link on a separate header

This patch makes the Pagination helper put each Link entry on the
response headers on a separate header. In practice, this leads to
shorter headers and will avoid apache default/reasonable limits.

To test:
1. Open the patron search page
2. Open the koha logs:
   $ tail -f /var/log/koha/kohadev/*.log
3. On the 'Search for patron' input, use a really long string, like
   'superlongstringthatistoolongforapacheyeahsuperlong'
=> SUCCESS: There's no user with an attribute with that content :-D
=> FAIL: You get an error like (28)No space left on device: [client
127.0.0.1:60330] AH10124: header size is over the limit allowed by
ResponseFieldSize (8192 bytes). Bad response header: 'Link:...'
4. Apply this patch
5. Restart all:
   $ restart_all
6. Repeat 2 and 3
=> SUCCESS: No results
=> SUCCESS: No error in the logs
7. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Pagination.t \
           t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!

Note 1: The Link header is expected to be in CSV format, which is
usually the way libraries treat repeated headers anyway.

Note 2: Apache is not rejecting the response, just stripping out the
'bad header'. So this is not a critical issue.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:38:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:38:28 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-p8XUP8OP3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |lari.taskula at hypernova.fi,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:31 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-IoxC4vklRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:34 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-FAENqgRFMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136420|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 137241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137241&action=edit
Bug 30933: Database revision (new pref)

Adds pref ListOwnerDesignated.
Generalize description of ListOwnershipUponPatronDeletion a bit.

Test plan:
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:39 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-2N4GcduyqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136421|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 137242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137242&action=edit
Bug 30933: Change for patron->delete

Test plan:
Run t/db_dependent/Koha/Patrons.t
Set pref ListOwnershipUponPatronDeletion to transfer.
Set pref ListOwnerDesignated to some valid borrowernumber.
Pick a user with public or shared list, delete from interface.
Pick a user with public or shared list, delete by script. (*)
Verify in both cases that new list owner is the designated one.

(*) Tip: Create another branch. Move the patron to be deleted to that
branch. And delete by script with:
    misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:43 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-i2FelXZ4r6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136422|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 137243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137243&action=edit
Bug 30933: Adjust pref description, include ListOwnerDesignated

Test plan:
View the pref on the System preferences, Patrons tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:48 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-B3ju32jPR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136423|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 137244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137244&action=edit
Bug 30933: (follow-up) Consolidate transfer checks

Adding shelf->cannot_be_transferred with unit tests.

Note: This follow-up actually refers to comment42 on the
preceding report 25498.
Furthermore, we could still improve later on using error code
more effectively (adding codes). Here we concentrate on moving
the checks to module level.

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:52 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-BCxYUZ5bKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136424|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 137245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137245&action=edit
Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts

Test plan:
Verify if transfer shared list on OPAC still works as expected.
Same for intranet counterpart for public lists.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:42:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:42:57 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-25wK38OKFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:43:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:43:00 +0000
Subject: [Koha-bugs] [Bug 30903] CSV import of quotes broken
In-Reply-To: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30903-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30903-70-vTGTHbIcqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:43:04 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-S4QzbQJRD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:43:07 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-xmT73xDqCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:49:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:49:35 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-nCFwx9wrpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 21:49:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 19:49:39 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-kuKpTl7GU7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:05:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:05:59 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-Lldpurossx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
  Text to go in the|This report adds pref       |This enhancement enables
      release notes|ListOwnerDesignated. It     |the transfer of public list
                   |serves as the new owner of  |ownership when a patron is
                   |public or shared lists when |deleted (from both the
                   |a patron is deleted as long |staff interface, and
                   |as                          |scripts or cron jobs such
                   |ListOwnershipUponPatronDele |as
                   |tion has been set to        |misc/cronjobs/delete_patons
                   |transfer.
                  |.pl). A new system
                   |
                           |preference
                   |Another                     |ListOwnershipUponPatronDele
                   |advantage is that deleting  |tion sets the action to
                   |patrons in scripts or cron  |take when a patron with
                   |jobs now allows you to      |public lists is deleted
                   |preserve their public or    |(options: delete the lists
                   |shared lists.               |or change owner of these
                   |                            |lists). If set to change
                   |                            |the owner, then the lists
                   |                            |are transferred to the
                   |                            |borrower number set in the
                   |                            |new ListOwnerDesignated
                   |                            |system preference.

--- Comment #12 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Test plan correction for patch Bug 30933: Change for patron->delete, the
script name at the end to delete patrons is not spelt correctly - this should
be ..patrons.pl.. not patons.pl: 

   misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE

2. Testing that lists continue to work after transfer from the staff interface:
   . Can delete public lists as the super librarian (koha)
   . Can transfer
   . Can edit
   . Can't add or remove items if 'Allow changes to contents from:' is set to
'Owner only', but can change this then add or remove items

2. Testing that lists continue to work as expected after transfer from the
OPAC:
   . If changes can only be made by the owner, another OPAC user can't make any
changes (as expected)
   . If changes can be made by anyone seeing the list, another OPAC user can
add and remove items from the list (as expected), can't delete or edit the list
(as expected)
   . If changes can be made by staff only, then they can only delete, edit,
etc., if they have the correct permissions (as expected)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:12:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:12:56 +0000
Subject: [Koha-bugs] [Bug 31022] 400/404 actually returns 500
In-Reply-To: <bug-31022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31022-70-9GWjkpKVzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31022

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #3)
> I do however find it really weird still that you can define more than one
> definition for the same response status on the endpoint...
> 
> i.e. the internal 400 definitions for the validator software and then our
> own one for our own errors.
> 
> I would have expected our definition to take precedence over the internal
> one and thus need it to be a superset of the built-in one.
> 
> Interesting.

Doesn't our definition just overload the default/internal one? It used to
return a 500 because it wasn't considered a valid response in the spec, which I
find correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:26:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:26:48 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-jurKu2YbOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:26:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:26:49 +0000
Subject: [Koha-bugs] [Bug 31022] 400/404 actually returns 500
In-Reply-To: <bug-31022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31022-70-bdVmNAi5Lf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31022

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, tested myself, this is some Mojolicious::Plugin::OpenAPI bug.

Reported it: https://github.com/jhthorsen/mojolicious-plugin-openapi/issues/237

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:26:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:26:52 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-sYFZynsemO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137237|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 137246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137246&action=edit
Bug 31106: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:26:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:26:57 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-zvI9wfn9CQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137238|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 137247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137247&action=edit
Bug 31106: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:27:02 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-agK6QYBsus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137239|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 137248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137248&action=edit
Bug 31106: Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to and from host records using 773$t and 773$a.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Go to the child record, and notice the link back to the parent works
   :-D
10. Sign off :-D

Sponsored-by: Theke Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:28:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:28:47 +0000
Subject: [Koha-bugs] [Bug 31112] New: Able to renew checkout when the number
 of holds exceeds available number of items
Message-ID: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

            Bug ID: 31112
           Summary: Able to renew checkout when the number of holds
                    exceeds available number of items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If AllowRenewalIfOtherItemsAvailable is set to Allow we are incorrectly
(against the syspref description) allowing to renew some checkouts when the
holds are coming from a single patron. When there is only 1 available item for
checkout in the biblio and a single patron has made 2 biblio level holds we
allow the patron who has a single item on loan to renew their item and
disregard the fact the we are leaving one hold unfilled. According to the
AllowRenewalIfOtherItemsAvailable syspref the renewal should only be possible
when other items can fill all the unfilled holds.

I have made a patch for this and will submit it shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:36:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:36:27 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-jUaOTQMu2C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #5 from David Nind <david at davidnind.com> ---
(In reply to victor from comment #4)
> Would I need to set permission for /var/spool/koha ?

I think you are correct.

>From bug 14564 comment 16 , then it set the permissions as root:kohadev-koha
ownership and 640 permission.

This is so that the files can be read by the webserver for your Koha instance -
kohadev-koha should be changed to whatever your instance name/file ownership
persmissions should be - check the files under the koha to see what that should
be.

Not sure whether this is a regression, or it is something that needs to be set
manually).

I'm not the greatest at linux file permissions, so I might be worng!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:39:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:39:24 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-9gTZypsKlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14564

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:39:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:39:24 +0000
Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download
 of configuration backups
In-Reply-To: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14564-70-PDNbuYQZuM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31098

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:45:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:45:17 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-43z8yjWOyQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #6 from David Nind <david at davidnind.com> ---
A way to test could be to either:

1. run the command in the cron job manually to generate the backups and see if
the files appear in the directory, or

2. create a file in the backup directory and see if you can see it in the staff
interface, or

If the files are in the directory, but you can't see them in the staff
interface then it will be a permission problem.

If the command doesn't generate the files, then check the logs for any errors
(I'm not sure which logs to check..).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 22:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 20:49:25 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-VYTHTGr2HG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at iki.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:16:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:16:51 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-209ueqzjiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #74 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Christopher Brannon from comment #73)
> Is that even possible if holds are automatically triggered for the next hold
> after cancellation? (maybe I'm not completely understanding the process).

While the hold is in pending cancellation request status (not yet processed),
it should be possible. The cancellation request entry would simply be deleted
from the newly introduced "hold_cancellation_requests" table and the hold would
continue to exist normally.

> An undo seems like it is out of the scope of this project anyway.

Perhaps. But I don't like a disabled button in OPAC saying "Cancellation
requested" and the fact that if a patron wanted to revert the action there is
nothing they can do other than giving the library a phone call and cause a lot
of annoying manual work for the librarians, or an angry patron if nothing could
be done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:30:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:30:31 +0000
Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning
 in basket.pl flooding error log
In-Reply-To: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31001-70-uACr2JIgM2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:30:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:30:35 +0000
Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning
 in basket.pl flooding error log
In-Reply-To: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31001-70-pbqSqpx6wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136558|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137249&action=edit
Bug 31001: Fix "CGI::param called in list context" warning in basket.pl

CGI param basketno should be explicitly scalar,
or else error log gets flooded with this warning:

AH01215: CGI::param called in list context from
/home/vagrant/kohaclone/acqui/basket.pl line 175, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a
single named parameter" at /usr/share/perl5/CGI.pm line 412.

This patch fixes it by working with it in a scalar context.
The functionality still remains the same but warning doesn't flood
error log.

To reproduce:
1. Head over to the acquisitions page.
2. Pick existing vendor with email contact info or create a new one.
3. Create a new basket or use existing one, and if it doesn't have
any orders, add a new order to it.
4. Use the "E-mail order" button to send order.
5. Check the error log and find the upper mentioned warning.
(Note: if you're going to test this more than once, you might need
to restart your Plack in order for this warning to get added to your
log file again, reasons of that is that the authors of CGI.pm decided
to "warn only once")
6. Apply the patch.
7. Use the "E-mail order" button again, ensure that the same warning
doesn't get added to the log file again.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:31:31 +0000
Subject: [Koha-bugs] [Bug 23869] Add regex test to marc mod template setup
In-Reply-To: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23869-70-S3eh5AxsaB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23869

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:32:06 +0000
Subject: [Koha-bugs] [Bug 26716] Allow specifying where to insert new fields
 in MARC Modification Templates
In-Reply-To: <bug-26716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26716-70-44fo0GZBcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26716

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> ---
This would be handy!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:32:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:32:15 +0000
Subject: [Koha-bugs] [Bug 26717] Allow specifying where to insert new
 subfields in MARC Modification Templates
In-Reply-To: <bug-26717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26717-70-6ai1y0ux3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26717

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:32:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:32:59 +0000
Subject: [Koha-bugs] [Bug 23869] Add regex test to marc mod template setup
In-Reply-To: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23869-70-qInWV5rOzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23869

--- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> ---
This would be very handy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:33:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:33:30 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-en2Pncl06Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:33:35 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-XUoZnyWj4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137180|0                           |1
        is obsolete|                            |

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137250&action=edit
Bug 30769: Typo fix in request.tt

This patch fixes a small typo at
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:574

To test:
1 - Set item-level_itypes in administrative preferences to
    bibliographic record
2 - Navigate to /reserve/request.pl in admin interface
3 - Notice that the typo is there in hold details
4 - Apply Patch
5 - Typo is fixed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:34:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:34:57 +0000
Subject: [Koha-bugs] [Bug 28915] MARC Modification Templates should allow
 specification of a position or range within a control field
In-Reply-To: <bug-28915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28915-70-VaGLeyinGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28915

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> ---
This would be useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:22 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-qzeEkiTNTE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:25 +0000
Subject: [Koha-bugs] [Bug 30769] Typo: Item typeX:
In-Reply-To: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30769-70-45pUCN2meb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30769

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:27 +0000
Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning
 in basket.pl flooding error log
In-Reply-To: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31001-70-kooOItEJqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:30 +0000
Subject: [Koha-bugs] [Bug 31001] "CGI::param called in list context" warning
 in basket.pl flooding error log
In-Reply-To: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31001-70-VzUwzn007e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31001

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:33 +0000
Subject: [Koha-bugs] [Bug 31067] Sub-tools permission not applying on
 intranet-main.tt
In-Reply-To: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31067-70-Ktsr89oBxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:37:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:37:35 +0000
Subject: [Koha-bugs] [Bug 31067] Sub-tools permission not applying on
 intranet-main.tt
In-Reply-To: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31067-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31067-70-mLF0JKdMY5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:41:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:41:52 +0000
Subject: [Koha-bugs] [Bug 31113] New: Permission change to so user can use
 marc modification template only when adding or editing single record
Message-ID: <bug-31113-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31113

            Bug ID: 31113
           Summary: Permission change to so user can use marc modification
                    template only when adding or editing single record
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aspencatteam at clicweb.org
        QA Contact: testopia at bugs.koha-community.org

Would like to see a permission to allow the application of marc modification
template to single record, without having the permission to do batch record
modification.  This would allow admin to create marc modification template that
a novice cataloger could use to supply certain fields they probably would not
know to change.  (Like in leader, 008, 007).  We would not want them to be able
to do batch record modification - just use template on single record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:21 +0000
Subject: [Koha-bugs] [Bug 25219] Include note in fines-related system
 preferences which can be disabled by leaving them blank
In-Reply-To: <bug-25219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25219-70-EH0oyNgRfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25219

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:22 +0000
Subject: [Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description
 to explain consequences of setting in Koha
In-Reply-To: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27448-70-asnJQ7ttDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:22 +0000
Subject: [Koha-bugs] [Bug 25098] automatic item modification needs report
 function
In-Reply-To: <bug-25098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25098-70-3m3Q1tCmxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25098

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:23 +0000
Subject: [Koha-bugs] [Bug 26035] AutoMemberNum fails on very large
 cardnumbers
In-Reply-To: <bug-26035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26035-70-mTr4Ty7vvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26035

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:23 +0000
Subject: [Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date
 filter
In-Reply-To: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27442-70-mOK7WyTjnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:23 +0000
Subject: [Koha-bugs] [Bug 25220] maxoutstanding syspref should be disabled
 by a null value
In-Reply-To: <bug-25220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25220-70-3HhcVC190V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25220

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:47:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:47:24 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-Loet3RYAaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|andrewfh at dubcolib.org       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul  6 23:50:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 21:50:27 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-5llAa6CzPz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #75 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Lari Taskula from comment #74)
> (In reply to Christopher Brannon from comment #73)
> > Is that even possible if holds are automatically triggered for the next hold
> > after cancellation? (maybe I'm not completely understanding the process).
> 
> While the hold is in pending cancellation request status (not yet
> processed), it should be possible. The cancellation request entry would
> simply be deleted from the newly introduced "hold_cancellation_requests"
> table and the hold would continue to exist normally.
> 
> > An undo seems like it is out of the scope of this project anyway.
> 
> Perhaps. But I don't like a disabled button in OPAC saying "Cancellation
> requested" and the fact that if a patron wanted to revert the action there
> is nothing they can do other than giving the library a phone call and cause
> a lot of annoying manual work for the librarians, or an angry patron if
> nothing could be done.

There's no cancellation acceptance workflow (there was, originally, and I
stripped it out). The main intention here is to let the staff know that hold
has been cancelled even if waiting. I guess we could just remove it from the
OPAC view. As it is really cancelled. Just having this intermediate status to
be able to alert staff in different places.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 00:15:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 22:15:42 +0000
Subject: [Koha-bugs] [Bug 31114] New: OpacHiddenItems is not respected in
 search results when an OPAC search is filtered by branch
Message-ID: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

            Bug ID: 31114
           Summary: OpacHiddenItems is not respected in search results
                    when an OPAC search is filtered by branch
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucy.vaux-harvey at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When filtering OPAC searches by library (OpacAddMastheadLibraryPulldown
enabled) the search results will include title records where all items for that
library are hidden from the OPAC due to the values in OpacHiddenItems.  When
clicking through to the detailed view of an affected record the copies are
correctly hidden in the holdings table but it is confusing for the library
customer to find the 
title in the search results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 00:16:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 22:16:20 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-lEE8sKSWgR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #76 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I think removing the button is a better option.

Even if an undo was an option, it would have been for a limited time.  Yes,
maybe we would have averted a phone call or annoying work, or an angry patron,
but we get those anyway, and if they wait long enough, they will miss that
window and still call.  I'm not saying I'm 100% against it, but a confirmation
is their 2nd chance to fix a mistake.  We don't really offer undo's anywhere
else.  Why should this be the exception?

I do like the process Tomás has laid out in the patch, regardless of what he
does with the button.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 01:20:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Jul 2022 23:20:57 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-ak3khtah6B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #77 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Christopher Brannon from comment #76)
> Even if an undo was an option, it would have been for a limited time.  Yes,
> maybe we would have averted a phone call or annoying work, or an angry
> patron, but we get those anyway, and if they wait long enough, they will
> miss that window and still call.  I'm not saying I'm 100% against it, but a
> confirmation is their 2nd chance to fix a mistake.  We don't really offer
> undo's anywhere else.  Why should this be the exception?

I think anything that reduces manual work from librarians is worth considering.

> I think removing the button is a better option.

I'm fine with having the button stay as it is or get removed, or moving this
into a new Bug. As you said it seems out of scope. I appreciate that and it's
okay.

My intention was to share a possible scenario and an idea for enhancement but
not stop the Bug from moving forward because of it. It's not that huge deal for
me. Tomás has done great work with this Bug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 03:09:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 01:09:52 +0000
Subject: [Koha-bugs] [Bug 30801] OPAC and staff interface show 856 as link
 even if there is no $u (MARC21)
In-Reply-To: <bug-30801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30801-70-tCGuOIIOsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30801

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 03:14:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 01:14:57 +0000
Subject: [Koha-bugs] [Bug 31107] smsalertnumber missing from OPAC
 self-registration
In-Reply-To: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31107-70-KRF6S1H6eU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31107

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 07:58:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 05:58:18 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-oLc4bW1IGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #10 from Mason James <mtj at kohaaloha.com> ---
(In reply to Tomás Cohen Arazi from comment #9)
> Pushed to master for 22.11.
> 
> Nice work everyone, thanks!

thanks, can we push thru to o-o-stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 08:06:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 06:06:55 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-AieINmz63L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Nind from comment #11)
> Signed-off-by: David Nind <david at davidnind.com>

Thx David.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 08:35:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 06:35:09 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-OZHN6yeQNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #18)
> (In reply to Marcel de Rooy from comment #16)
> > [2] Code segment from Koha/REST/V1/Auth.pm
> >     if ( !$authorization and
> >          ( $params->{is_public} and
> >           ( C4::Context->preference('RESTPublicAnonymousRequests') or
> >             $user) or $params->{is_plugin} )
> >         or $pending_auth
> > This does not look good to me. Do we need pending_auth here ? If so, at
> > least we need parentheses etc. My follow-up removes the line now.
> 
> 
> Why? Can you explain? If the user is not fully authenticated they shouldn't
> be allowed to access REST API route.
> With your follow-up patch the tests are failing now.

With a bit of delay.. Thx for your patience :)

First, the !A and (B and (C or D)) or E expression seems to be wrong. If D
should be true now, we are putting the door open! So the first impression is:
we need some brackets here, but looking further we dont need this stage here.

If the cookie tells us additional-auth-needed, we should only allow the
otp_token path and set the user. Another path should be revoked (follow-up). If
you set the user, and this statement is therefore fine for API, there is no
need for pending auth. You can just run this call. The current checks for user
are enough.

Note the relation with x-koha-authorization too. The follow-up adds this line.
We should jump to the else branch and check for $user now.

If you read this code carefully, I think you should understand the point?

About the test, I will submit another comment or fix it. Please wait.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 08:35:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 06:35:29 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-srWo9qNUeo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement enables    |This enhancement enables
      release notes|the transfer of public list |the transfer of public list
                   |ownership when a patron is  |ownership when a patron is
                   |deleted (from both the      |deleted (from the staff
                   |staff interface, and        |interface, and scripts or
                   |scripts or cron jobs such   |cron jobs such as
                   |as                          |misc/cronjobs/delete_patron
                   |misc/cronjobs/delete_patons |s.pl). A new system
                   |.pl). A new system          |preference
                   |preference                  |ListOwnershipUponPatronDele
                   |ListOwnershipUponPatronDele |tion sets the action to
                   |tion sets the action to     |take when a patron with
                   |take when a patron with     |public lists is deleted
                   |public lists is deleted     |(options: delete the lists
                   |(options: delete the lists  |or change owner of these
                   |or change owner of these    |lists). If set to change
                   |lists). If set to change    |the owner, the lists are
                   |the owner, then the lists   |transferred to the borrower
                   |are transferred to the      |number set in the new
                   |borrower number set in the  |ListOwnerDesignated system
                   |new ListOwnerDesignated     |preference.
                   |system preference.          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 08:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 06:51:29 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-SHuvUFVIL5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137251&action=edit
Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t

Changing flags to 20 to include the required Staff access for
intranet login.
This changes the http status. The API raises an exception now.

Test plan:
Run t/db_dependent/api/v1/two_factor_auth.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 08:53:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 06:53:51 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-3A5qC2C4NS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
There is also t/db_dependent/selenium/authentication_2fa.t
I am not sure if it fails now. Cant run it.
But as you can see in the last patch, it should be a trivial fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 09:05:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 07:05:21 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-NaDuRLkmCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #21)
> I haven't read the patches yet, but I'd like to mention that, to me, OTP
> should be generated in very specific cases and so our handling in V1/Auth.pm
> needs to be very careful. Somehow, we need to identify a session that is in
> an intermediate state: it already identified correctly but still needs a
> specific action. So not any active session should be able to request a OTP.

Currently, we do allow it. I am not sure if we should need to revoke it when
the session allows it.
We could easily revoke for status==ok, but the code wont improve imo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 09:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 07:13:14 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-ZlgMZrFXEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #22)
> First, the !A and (B and (C or D)) or E expression seems to be wrong. If D
> should be true now, we are putting the door open! 

I shuffled my letters here. Last line should if E is true..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 09:18:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 07:18:16 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-yUPfwgw55c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Selenium tests are passing. I do agree with your patch after a second look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 09:26:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 07:26:32 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-pDKXGles9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #27)
> Selenium tests are passing. I do agree with your patch after a second look.

Well, this change looks wrong, we should keep 403 IMO.

     # Patron is not authenticated yet
-    $t->request_ok($tx)->status_is(403);
+    $t->request_ok($tx)->status_is(500); # FIXME Check the exception instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 09:48:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 07:48:35 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-RxDOYEKEUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > Selenium tests are passing. I do agree with your patch after a second look.
> 
> Well, this change looks wrong, we should keep 403 IMO.
> 
>      # Patron is not authenticated yet
> -    $t->request_ok($tx)->status_is(403);
> +    $t->request_ok($tx)->status_is(500); # FIXME Check the exception
> instead?

Yes, I agree with that. But cause lies in current code. We could solve it on a
new report too. No big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 10:02:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 08:02:27 +0000
Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to
 search_for_data_inconsistencies.pl
In-Reply-To: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26311-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26311-70-BrFJZFJfrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement to the     |This enhancement to the
      release notes|command line script used    |command line script used
                   |for searching for data      |for searching for data
                   |inconsistencies             |inconsistencies
                   |(misc/maintenance/search_fo |(misc/maintenance/search_fo
                   |r_data_inconsistencies.pl)  |r_data_inconsistencies.pl)
                   |now lists patrons where     |now lists patrons where
                   |their age doesn't match the |their age doesn't match the
                   |criteria set for the patron |criteria set for the patron
                   |category. 
                 |category.
                   |
                           |
                   |This includes               |This includes
                   |where there is:
            |where there is:
                   |- a minimum                 |- a minimum
                   |age required
               |age required
                   |- an upper age              |- an upper age
                   |limit
                      |limit
                   |- a minimum age and         |- a minimum age and
                   |an upper age limit
         |an upper age limit
                   |
                           |
                   |An                          |An
                   |example of the output:
     |example of the output:
                   |
                           |
                   |                            |
                   |Patrons with invalid age    |Patrons with invalid age
                   |for category:
              |for category:
                   | * Patron                   | * Patron
                   |borrowernumber=49 has an    |borrowernumber=49 has an
                   |invalid age of 10 for their |invalid age of 10 for their
                   |category 'PT' (24-)
        |category 'PT' (24 to
                   | *                          |unlimited)
                   |Patron borrowernumber=49    | * Patron
                   |has an invalid age of 71    |borrowernumber=49 has an
                   |for their category 'PT'     |invalid age of 71 for their
                   |(-50)
                      |category 'PT' (0 to 50)
                   | * Patron                   | *
                   |borrowernumber=44 has an    |Patron borrowernumber=44
                   |invalid age of 70 for their |has an invalid age of 70
                   |category 'PT' (20-60)
      |for their category 'PT' (20
                   |                            |to 60)
                   |Note: Where a patron's age  |
                   |can't be calculated (for    |Note: Where a
                   |example: a school or other  |patron's age can't be
                   |organisation, or the date   |calculated (for example: a
                   |of birth is missing), then  |school or other
                   |they are not included in    |organisation, or the date
                   |the checks.                 |of birth is missing), then
                   |                            |they are not included in
                   |                            |the checks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:16:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:16:12 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-VaPsF1T5rB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
I'm not seeing the error described in step 3.

Are there some other settings required to generate the error?

Testing on master with koha-testing-docker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:28:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:28:04 +0000
Subject: [Koha-bugs] [Bug 31115] New: Additional fields for invoices
Message-ID: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115

            Bug ID: 31115
           Summary: Additional fields for invoices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: michaela.sieber at kit.edu
        QA Contact: testopia at bugs.koha-community.org

This new feature adds the ability to define additional fields to store
information about vendor invoices in the acquisition module.

For further information see attached documentation.

Test plan:

  1. Create a Vendor (under Acquisition -> New Vendor).
  2. Create a Basket 
  3. Apply patch.
  4. Visit Additional fields under administration, and verify that
     the option for invoices exists
  5. Create at least four fields for aqinvoice for each combination of
     searchable/not-searchable and with/without an authorized value.
  6. Create a Vendor invoice (-> Receive shipment) , and verify that all fields
are visible and
     correctly save.
  7. Edit the invoice, verifying that changes to these additional fields
     are saved.
  8. Search the invoice by using an additional field (Acquisitions > Invoices)
  9. Verify that only the searchable fields show in the form, and that
     their contents may be searched.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:35:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:35:12 +0000
Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices
In-Reply-To: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31115-70-stbsQJDj8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

--- Comment #1 from MichaelaSieber <michaela.sieber at kit.edu> ---
Created attachment 137252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137252&action=edit
Documentation Bug31115 Additional fields for invoices

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:36:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:36:11 +0000
Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices
In-Reply-To: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31115-70-EK2LwhhZGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15774
  Change sponsored?|---                         |Seeking developer

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:36:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:36:11 +0000
Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets
In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15774-70-XxsUt5yg62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31115

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:36:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:36:46 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-v6eWbRCdGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr
             Status|Needs Signoff               |Signed Off

--- Comment #42 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
I've tested on a sandbox and everything is as excepted.
- the two circulation permissions are OK
- Curbside pickup is possible only for branches where it has been defined
- If you choose to "Enable for waiting holds only", you can't choose a slot for
a pickup if the patron doesn't have available hold. But it's possible if you
don't check this in the setting
- If you choose "Enable patrons to schedule their own curbside" on some
branches, they are displayed in the OPAC in the user account. If the patron
didn't have any available holds and that it is asked for one branches, this one
is displayed and disabled. If no branch is set for enable patrons to schedule
pickup, the tab doesn't appear in the user account
- The slot for the days, the hours and the intevals are well displayed
- The checking of the number of patrons alowed for the same slot is ok
- the change of status are ok and you can rollback is wanted
- the item is correctly checked out when it is marked as delivered
- A notice is send to the patron is he has a primary mail defined and if the
choice "email" is checked for hold filled in the Patron messaging preferences
- the curbisde pickup are displayed on the checjout page for the patron
- If a patron click on "Alert staff of your arrival", the curbside pickup
switch on the "patron is arrived" tab in the intranet after 1 or 2 mn

Thanks joubu :)

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:44:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:44:15 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-FLAZDC5jjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #3 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
tested on a sandbox on the top of BZ30650 and it works as expected.
If a patron has an overdue or if he has restrictions, it appears in the
curbside pickup table, under his name, on each tab of the table.

Thanks :)
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:45:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:45:12 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-vfg7BuV3wf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
A couple of comments from testing:

1. This works for the relatives' checkouts tab on the check out and details
sections of the patron's page.

2. Normally, when the table settings are configurable, there is a 'Columns'
button above the actual table that lets you toggle the columns on and off. I'm
not seeing it for this table. For an example, check out something to the
guarantor and you should see what I mean.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:48:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:48:33 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-FohXReJGzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha at univ-lyon3.fr

--- Comment #4 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Hi,
tested on a sandbox on the top of BZ30650 and it works as expected.
On the "schedule pickup" tab of the curbside pickups table, you can search the
patron with his name and you tye 3 letters, you have an autocompletion.

Thanks
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:52:54 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-WESJxp26ku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:52:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:52:58 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-lOAwzCl0fN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137215|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137253&action=edit
Bug 29951: Fix EXPORT for C4::ClassS*Routine modules

Can't locate object method "subclasses" via package "C4::ClassSplitRoutine" at
/kohadevbox/koha/C4/ClassSplitRoutine.pm line 53

Certainly from bug 17600.

Test plan:
Home -> Administration -> Classification sources -> New splitting rule

And create classification sources and filing rules.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 11:56:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 09:56:43 +0000
Subject: [Koha-bugs] [Bug 31115] Additional fields for invoices
In-Reply-To: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31115-70-eKlT4iH0Ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31115

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new feature adds the
      release notes|                            |ability to define
                   |                            |additional fields to store
                   |                            |information about vendor
                   |                            |invoices.
                   |                            |There is a new
                   |                            |'Manage invoice fields'
                   |                            |page in the acquisitions
                   |                            |administration to configure
                   |                            |the fields.
                   |                            |Users can name
                   |                            |additional fields, tie them
                   |                            |to authorised values, and
                   |                            |specify whether the fields
                   |                            |can be searched in the
                   |                            |acquisitions module.
                   |                            |This
                   |                            |also adds a new entry to
                   |                            |the admin page for
                   |                            |additional fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:00:03 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-VAhA6wkNIG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
  Text to go in the|                            |This fixes an error* that
      release notes|                            |was displayed when adding a
                   |                            |splitting rule to
                   |                            |classifications sources
                   |                            |(Administration > Catalog >
                   |                            |Classification
                   |                            |configuration).
                   |                            |
                   |                            |*
                   |                            |Clicking 'Add a splitting
                   |                            |rule' generates an error
                   |                            |page starting "Can't locate
                   |                            |object method "subclasses"
                   |                            |via package
                   |                            |"C4::ClassSplitRoutine" at
                   |                            |/kohadevbox/koha/C4/ClassSp
                   |                            |litRoutine.pm line 53".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:29 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-nxoP97TS2N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:33 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-hZwcmd2xO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136983|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 137254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137254&action=edit
Bug 31086: DB update

This update sets branchcode as NOT NULL
default set to 0 as borrowernumber is

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:38 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-VO74wlpZzo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136984|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 137255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137255&action=edit
Bug 31086: Throw an exception when a hold is stored with no branchcode

To test:
1 - Apply first 2 patches
2 - On staff client, find a biblio, place hold, select a patron
3 - Before creating hold, right click on 'Pickup location'
4 - Inspect the element
5 - In the console find the top <li> for pickup, and right click
6 - Select 'Delete node'
7 - Save hold
8 - You get an exception/error

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:42 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-iiigpWciQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136986|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 137256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137256&action=edit
Bug 31086: Prevent placing hold with no pickup location

To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:48 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-Te45bT1lVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136987|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 137257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137257&action=edit
Bug 31086: DO NOT PUSH: Schema updates

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 12:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 10:36:52 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-z5Ckr8lxQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137026|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 137258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137258&action=edit
Bug 31086: Update existing unit tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:04:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:04:27 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-THnfNzMRqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135614|0                           |1
        is obsolete|                            |
 Attachment #135615|0                           |1
        is obsolete|                            |
 Attachment #135616|0                           |1
        is obsolete|                            |
 Attachment #135617|0                           |1
        is obsolete|                            |
 Attachment #135624|0                           |1
        is obsolete|                            |
 Attachment #135625|0                           |1
        is obsolete|                            |
 Attachment #135626|0                           |1
        is obsolete|                            |
 Attachment #135627|0                           |1
        is obsolete|                            |
 Attachment #135628|0                           |1
        is obsolete|                            |
 Attachment #135629|0                           |1
        is obsolete|                            |

--- Comment #519 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137259&action=edit
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:04:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:04:47 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-AEjh74zdDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #520 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137260&action=edit
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:04:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:04:56 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ir6cakGmJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #521 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137261&action=edit
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-T8m6dtXP28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #522 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137262&action=edit
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:13 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Ew8OXnF4sA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #523 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137263&action=edit
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-1mxhppxGmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #524 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137264&action=edit
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or
create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:32 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-s4M86L12lz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #525 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137265&action=edit
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-YujnQ6znS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #526 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137266&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:49 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-uYtIFBPAf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #527 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137267&action=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:05:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:05:57 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-SiiggyOu8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #528 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137268&action=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:16:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:16:22 +0000
Subject: [Koha-bugs] [Bug 31116] New: Article requests doesn't respect the
 'CircSidebar' preference
Message-ID: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

            Bug ID: 31116
           Summary: Article requests doesn't respect the 'CircSidebar'
                    preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The article requests management page doesn't ever display the circulation side
menu.. it should when CircSidebar is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:41:36 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-DnzS2PPfjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137269&action=edit
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:41:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:41:50 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-xTSaQSATsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:41:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:41:55 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-RkgoNSylbe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:42:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:42:00 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-HI4ejb9UqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:42:39 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-Jgfiv5OgrQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 13:47:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 11:47:48 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-2pHg1YJS7p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jeremy.breuillard at biblibre.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:21:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:21:23 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-tb5ioDgNfZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

--- Comment #2 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
Created attachment 137270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137270&action=edit
Bug 16786: Cannot add multiple emails adresses in an email field

The primary email field can allow more than one email adresses if those are
separated by comma (,;)

Test plan:
1) Home > Patrons
2) Create a new patron / Edit an existing patron
3) Part:'Contact information' > Field:'Primary email' : write at least 2 email
adresses separated by comma
4) Try to save it... impossible
5) Apply patch and repeat 1) to 3) then save again
6) Now this field allows more than one email adress as long as there is comma
separation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:21:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:21:49 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-h1iz0aWlCt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:28:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:28:04 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-MYVBFwZsub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:31:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:31:10 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-PEBitXVTbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:31:14 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-EoHCmMQhrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136780|0                           |1
        is obsolete|                            |
 Attachment #136782|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137271&action=edit
Bug 29051: Enable seen renewal in the staff client

This patch updates the javascript for the checkouts table to add the
checkbox back in for the case where too_unseen is the error returned by
CanBookBeRenewed, allowing such issues to be renewed.

Signed-off-by: Caroline <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:33:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:33:23 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-KaASOHfzrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137272&action=edit
Bug 29051: Update svc api to allow seen renewals

This patch updates the svc/renew api endpoint to allow seen renewals
when appropriate

Signed-off-by: Caroline <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:42:26 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-SsOGvb14w0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:42:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:42:31 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-oujkrKlmMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136434|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 137273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137273&action=edit
Bug 19704: Make OPAC "Most popular" respect hidden record sysprefs

At the moment, OpacSuppression and OpacHiddenItems don't affect the output
of the OPAC's "Most popular" page.

This patch adds support for the OpacSuppression and OpacHiddenItems system
preferences, so
that items are excluded from the "Most popular" calculation based on the hidden
rules.

Test plan:
0a. Apply patches
0b. koha-plack --restart kohadev
0c. Log into Koha as "koha" user
1. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacTopissue
2. Enable "OpacTopissue"
3. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51
4. Checkout 39999000001310
5. Checkout 39999000005578
6. Checkout 39999000004571
7. Checkout 39999000005592
8. Go to
http://localhost:8080/cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
9. See 3 titles
10. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItems
11. Change "OpacHiddenItems" to the following (within the single quotes):
barcode: [39999000001310,39999000005578]
location: ['RANDOM','THAT','THIS']
12. Go to
http://localhost:8080/cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
13. See 2 titles ("Gairm" is hidden, as is one of the items for "Continuous
delivery /")
14. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacHiddenItemsExceptions
15. Update the syspref to 'S'
16. Go to
http://localhost:8080/cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
17. See 3 titles again

18. Go to
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OpacSuppression
19. Change syspref to "Hide"
20. Go to
http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=114
21. Change 942$n to "Yes" and save record
22. Go to
http://localhost:8080/cgi-bin/koha/opac-topissues.pl?limit=10&branch=&itemtype=&timeLimit=999&do_it=1
23. See 2 titles ("Clean code : a handbook of agile software craftsmanship /
Robert C. Martin ... [et al.]" is suppressed)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:44:06 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-j6AjoQkDGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137270|0                           |1
        is obsolete|                            |

--- Comment #3 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
Created attachment 137274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137274&action=edit
Bug 16786: Cannot add multiple emails adresses in an email field

The primary email field can allow more than one email adresses if those are
separated by comma (,;)

Test plan:
1) Home > Patrons
2) Create a new patron / Edit an existing patron
3) Part:'Contact information' > Field:'Primary email' : write at least 2 email
adresses separated by comma
4) Try to save it... impossible
5) Apply patch and repeat 1) to 3) then save again
6) Now this field allows more than one email adress as long as there is comma
separation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:48:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:48:04 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-bFWPsQDhWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:48:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:48:08 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-zHJfjNtUBa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137274|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137275&action=edit
Bug 16786: Cannot add multiple emails adresses in an email field

The primary email field can allow more than one email adresses if those are
separated by comma (,;)

Test plan:
1) Home > Patrons
2) Create a new patron / Edit an existing patron
3) Part:'Contact information' > Field:'Primary email' : write at least 2 email
adresses separated by comma
4) Try to save it... impossible
5) Apply patch and repeat 1) to 3) then save again
6) Now this field allows more than one email adress as long as there is comma
separation

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:48:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:48:53 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-GNJ3FJVw8D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm pretty sure the change to validator-strings.inc isn't necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:49:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:49:54 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-gHMmt9NaEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Kyle M Hall from comment #5)
> I'm pretty sure the change to validator-strings.inc isn't necessary.

You beat me to it! Will re-sign the new patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:50:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:50:37 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-BXiEzPUluS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137275|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137276&action=edit
Bug 16786: Cannot add multiple emails adresses in an email field

The primary email field can allow more than one email adresses if those are
separated by comma (,;)

Test plan:
1) Home > Patrons
2) Create a new patron / Edit an existing patron
3) Part:'Contact information' > Field:'Primary email' : write at least 2 email
adresses separated by comma
4) Try to save it... impossible
5) Apply patch and repeat 1) to 3) then save again
6) Now this field allows more than one email adress as long as there is comma
separation

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:51:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:51:42 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-rqKBUgNyLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jeremy.breuillard at biblibre.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:54:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:54:10 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-V0mIxaXhoz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the "Most
      release notes|                            |popular" list in the OPAC
                   |                            |(enabled using the
                   |                            |OpacTopissue system
                   |                            |preference) so that items
                   |                            |are correctly excluded when
                   |                            |the OpacSuppression and
                   |                            |OpacHiddenItems system
                   |                            |preferences are configured.
                   |                            |Before this, settings for
                   |                            |these two system
                   |                            |preferences had no effect
                   |                            |on the "Most popular" page.
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:55:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:55:36 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-b2KxsQ5mw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 14:56:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 12:56:33 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-KGO23Bm6KG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

--- Comment #8 from Jérémy Breuillard <jeremy.breuillard at biblibre.com> ---
(In reply to Kyle M Hall from comment #6)
> (In reply to Kyle M Hall from comment #5)
> > I'm pretty sure the change to validator-strings.inc isn't necessary.
> 
> You beat me to it! Will re-sign the new patch!

=D !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:00:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:00:42 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-aBlpvXkdAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136584|0                           |1
        is obsolete|                            |
 Attachment #136585|0                           |1
        is obsolete|                            |
 Attachment #136586|0                           |1
        is obsolete|                            |
 Attachment #136587|0                           |1
        is obsolete|                            |
 Attachment #136588|0                           |1
        is obsolete|                            |
 Attachment #136589|0                           |1
        is obsolete|                            |
 Attachment #136590|0                           |1
        is obsolete|                            |
 Attachment #136591|0                           |1
        is obsolete|                            |
 Attachment #136592|0                           |1
        is obsolete|                            |
 Attachment #136593|0                           |1
        is obsolete|                            |
 Attachment #136594|0                           |1
        is obsolete|                            |
 Attachment #136595|0                           |1
        is obsolete|                            |
 Attachment #136596|0                           |1
        is obsolete|                            |
 Attachment #136597|0                           |1
        is obsolete|                            |
 Attachment #136598|0                           |1
        is obsolete|                            |
 Attachment #136599|0                           |1
        is obsolete|                            |
 Attachment #136600|0                           |1
        is obsolete|                            |
 Attachment #136601|0                           |1
        is obsolete|                            |
 Attachment #136602|0                           |1
        is obsolete|                            |
 Attachment #136603|0                           |1
        is obsolete|                            |
 Attachment #136604|0                           |1
        is obsolete|                            |
 Attachment #136605|0                           |1
        is obsolete|                            |
 Attachment #136606|0                           |1
        is obsolete|                            |
 Attachment #136607|0                           |1
        is obsolete|                            |
 Attachment #136608|0                           |1
        is obsolete|                            |
 Attachment #136609|0                           |1
        is obsolete|                            |
 Attachment #136610|0                           |1
        is obsolete|                            |
 Attachment #137100|0                           |1
        is obsolete|                            |
 Attachment #137199|0                           |1
        is obsolete|                            |
 Attachment #137211|0                           |1
        is obsolete|                            |
 Attachment #137212|0                           |1
        is obsolete|                            |

--- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137277&action=edit
Bug 30650: DB changes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:00:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:00:49 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-DEN2WFPMQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137278&action=edit
Bug 30650: Koha classes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:00:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:00:55 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Ru0vQnwa0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137279&action=edit
Bug 30650: Add the CurbsidePickup syspref

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:01 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-NlnE9SEpVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137280&action=edit
Bug 30650: Add new permission manage_curbside_pickups

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:06 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-rBFREe4Mz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #47 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137281&action=edit
Bug 30650: Add link from the admin home page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:12 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-KVAbYIdnQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137282&action=edit
Bug 30650: Admin page

This patch adds a new page in the administration area to manage curbside
pickups.

Test plan:
1. Enable the new CurbsidePickup syspref
2. Go to Administration > Curbside pickups
=> If the logged-in user has the manage_curbside_pickups permission you
should see the administration view
3. Enable the feature for some libraries and configure it.
 a. You must define a "pickup interval" and a "maximum patrons per interval"
values.
 b. If "Patron-scheduled pickup" is enabled, patrons will be able to
schedule curbside pickups from the OPAC
 c. If "Enable for waiting holds only" is enabled, only patron with waiting
holds will be allowed to schedule curbside pickups
 d. In the bottom part of the form you can define the slots available for
curbside pickups.
 e. Save

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:18 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LtB0Sdeumi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137283&action=edit
Bug 30650: Adjust atomic update

Take into account existing installs using the plugins

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:24 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-p05utcKWNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137284&action=edit
Bug 30650: Be more flexible with opening slots

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:30 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-KdukbyQQ1i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137285&action=edit
Bug 30650: Add some useful modules and tests

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:37 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Cudt2sUgc3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137286&action=edit
Bug 30650: Add circulation page view

This is the main commit message.

A plugin already exists to manage curbside pickups. This new
enhancehemnt is suggesting an implementation that is ready to be integrated
into Koha core in order to provide the feature out-of-the-box.

What has been done in this patch set:
- Deal with installations using the existing plugin (upgrade the DB schema and
migrate their data)
- Add a new syspref (CurbsidePickup) and two new permissions:
  * parameters.manage_curbside_pickups
  * circulate.manage_curbside_pickups
- Add an administration page to setup the configuration:
admin/curbside_pickup.pl
- Add a circulation page to manage the existing pickups, and create new one
- Add a new OPAC view "your curbside pickups" to let patron manage their
pickups, and create new ones
- Add link from the "member" toolbar

Improvements compared to the plugin:
- Ability to create several pickup windows per day
- Better display of the pickup times (not in a dropdown list)
- Ability to disable pickups for patrons without waiting holds
- Display pickups on the patron circulation page
- Display pickups of the library on the homepage
- Prevent pickup to be created on a holiday
- Better error handling (exceptions)
- Unit tests

More improvements are already planned, see related bug reports.

Test plan:
After you setup the feature correctly from the administration view, you
will be able to use the schedule curbside pickups from the staff
interface, and from the OPAC interface if you selected "patron-scheduled
pickup"
A. Staff interface
1. Go to Circulation > Curbside pickups
=> If the logged-in user has the circulate.manage_curbside_pickups
permission you will be able to create and manage curbside pickups
2. Go to a patron detail page and click the "Schedule pickup" button in
the toolbar
3. If the patron has waiting holds and you selected "Enable for waiting holds
only",
of if you didn't select the option, you will be able to select a pickup
date and slots to create a pickup.
4. Confirm that you cannot create more pickups per slot than what you
defined in the curbside pickup configuration for this library
5. Confirm that you cannot create a pickup if the feature is disabled
for the library
6. Notice that you can mark the pickup as "stage and ready", then
"patron is outside" and finally "delivered today". You can also rollback
the change
7. Notice that once the pickup has been marked as delivered, the
item has been checked out and that a new notice has been generated (if
the patron has "Hold_Filled" in their messaging preferences
8. Confirm that the information about current pickups is displayed on
the circulation page of the patron

B. OPAC interface
1. Create a new curbside pickup from the OPAC
2. Confirm that the same limitations as from the staff interface are in
effect (waiting holds, number of patron per slots, etc.)
3. Confirm that you can cancel a pickup and alert staff of you arrival
4. Confirm that you cannot cancel a pickup that has been delivered
already

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:43 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-bCs32b4W8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137287&action=edit
Bug 30650: Add dayjs and isSameOfAfter plugin

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:50 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-l0VIT4GsEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137288&action=edit
Bug 30650: Add dayjs to opac

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:01:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:01:56 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-C9hVgDO47Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137289&action=edit
Bug 30650: OPAC view

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:02 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-90YgIl97ol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137290&action=edit
Bug 30650: Add link from the member toolbar

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:07 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-aJmSfkLSFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137291&action=edit
Bug 30650: Notify the patron when a new curbside pickup is created

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:13 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-1RM2vsxkbn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137292&action=edit
Bug 30650: DB - Add policy.enable_waiting_holds_only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:19 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-AAJRq2ov4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137293&action=edit
Bug 30650: Allow to restrict curbside pickup for waiting holds only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:25 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-l31nMKJaOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137294&action=edit
Bug 30650: Add link from the mainpage

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:30 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-tfXMHj6wYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137295&action=edit
Bug 30650: Add link from the circ patron page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:36 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-65WlTOcbIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #62 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137296&action=edit
Bug 30650: Add filter_by_scheduled_today

A bit of cleaning

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:42 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-wtHKsQxd5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #63 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137297&action=edit
Bug 30650: Prevent pickup to be created on holiday

We could improve this more and add disable the holiday from the date
picker widget, but it's out of the scope here.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:47 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-wVq3Smz0aj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137298&action=edit
Bug 30650: Split the permission

We actually want one permission to manage the administration page, and
one for the circulation module.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:53 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-mgXN6Yyw9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #65 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137299&action=edit
Bug 30650: Select 'schedule a pickup' if no pickups yet

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:02:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:02:58 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-dRaIa8v69G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #66 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137300&action=edit
Bug 30650: Prevent browser crash if no pickup interval set

Don't get stuck in an infinite loop

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:05 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-wpB3QPVzbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #67 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137301&action=edit
Bug 30650: Compiled CSS

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:11 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-RUCiJU4x4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #68 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137302&action=edit
Bug 30650: DBIC

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-sVnrx7PUut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #69 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137303&action=edit
Bug 30650: DBIC specific

Note for QA - a false positive is raised by the QA tools:

"""
The new column curbside_pickup_opening_slots.day is using TINYINT(1) as
type but is not defined as boolean in the schema file
(Koha/Schema/Result/CurbsidePickupOpeningSlot.pm)
"""

=> It's not a boolean!

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:23 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-RIMY7qKTit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #70 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137304&action=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:28 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PnvWh3WMN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #71 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137305&action=edit
Bug 30650: Don't display slots that have are before now

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:34 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-OgTgR5Hpv8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #72 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137306&action=edit
Bug 30650: Add dayjs customParseFormat plugin

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:03:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:03:40 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LAKR1eObyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #73 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137307&action=edit
Bug 30650: Take dateformat into account

dayjs init was not passing the dateformat.
We really need to clean the date handling with the following two bugs:
  Bug 30310 - Replace Moment.js with Day.js
and
  Bug 30718 - Use flatpickr's altInput option everywhere

But it's outside the scope of this bug report.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:05:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:05:08 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-g8yrE7Sb40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137096|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137308&action=edit
Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup

This patch adds more information about the patron's account on the
curbside pickup list view.
"Patron's account is restricted" if the patron is restricted
"Patron has items overdue" if the patron has overdues

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:06:36 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-jpZEn86rNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137097|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137309&action=edit
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:12:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:12:58 +0000
Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines
In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11844-70-fLD9jCp4ZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian, we would be interested in this feature and judging from the CC list,
others as well. :) Are there any plans to pick this up again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:13:14 +0000
Subject: [Koha-bugs] [Bug 28219] Additional fields for orders/order lines
In-Reply-To: <bug-28219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28219-70-SRjtfzttqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28219

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 11844 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:13:14 +0000
Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines
In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11844-70-WcxY61cX78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 28219 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:19:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:19:00 +0000
Subject: [Koha-bugs] [Bug 31098] The options to "export database" and
 "export settings" are not available
In-Reply-To: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31098-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31098-70-rD13CbbTff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31098

--- Comment #7 from victor <vbovictor at gmail.com> ---
Not generating backup with $koha-dump

I remember that I performed the update from version 21.11 to 22.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:31:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:31:13 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-Ed2R06dZy4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Jérémy Breuillard <jeremy.breuillard at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:54:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:54:20 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-bBU51hrzaN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 15:54:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 13:54:26 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-fqwPXv84ST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136767|0                           |1
        is obsolete|                            |

--- Comment #41 from David Nind <david at davidnind.com> ---
Created attachment 137310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137310&action=edit
Bug 26247: [ALTERNATE] Adding 2 Sysprefs for Search Terms

This patch adds two system preferences options : 'RetainCatalogSearchTerms' and
'RetainPatronsSearchTerms'. If enabled, search terms will be retained between
searches made from, respectively, the Search Catalog header and the Checkout or
Search Patrons headers. If disabled, the searchbars will clear out between page
loads.

Attention, this is an alternate solution from the previous patches, ONLY apply
this patch when testing and not the previous ones.Changed the syspref wording
as well.

To test:
1 - From the staff client, search some terms using the Check out header search
bar.
2 - Confirm search terms are retained.
3 - Do Step 1-2 twice again, this time using the Search patrons and Search the
catalog.
4 - Apply patch (again, only this one), update database.
5 - In the system preferences, look for RetainCatalogSearchTerms and set it to
'don't retain'.
6 - Use the checkout head search bar again, confirm that search terms aren't
retained after page load.
7 - Do Step 5-6 once again, this time with the RetainPatronsSearchTerms and the
Search Patrons and Search the catalog headers.
8 - Search boxes should be cleared.

Thanks-to: Fridolin Somers and Nick Clemens for the bases I built on.
Signed-off-by: Florian Bontemps <florian.bontemps at biblibre.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:04:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:04:26 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-RD6A8WsJ76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #529 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137311&action=edit
Bug 24857: Fix rebase problems

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:05:18 +0000
Subject: [Koha-bugs] [Bug 31060] Fine duplicates when returning item with
 accountline status marked as lost
In-Reply-To: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31060-70-qerm0WTLxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31060

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136694|0                           |1
        is obsolete|                            |

--- Comment #3 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137312&action=edit
Bug 31060: Fine duplicates when returning item with accountline status marked
as lost

Make unpaid accountline switch from 'LOST' to 'UNRETURNED' when unsetting lost
status from an item.

To test:
1- System preferences:
    finesMode:                    Calculate and charge
    CalculateFinesOnReturn:       Do
    WhenLostChargeReplacementFee: Don't charge
    MarkLostItemsAsReturned:      uncheck from the items tab of the catalog
module
2- Have a circulation rule with defined non-zero Fine amount and Fine charging
interval. (Will have to use the patron category and item type associated to
this circulation rule to test)
3- Checkout a document from the patron with backdated due date (backdated
enough depending on the Fine charging interval set)
4- Run ./misc/cronjobs/fines.pl
5- There should be a Fine(Accruing) in accounting tab of the patron
6- Go to the checked out item detail and set Lost status: Long overdue (Lost)
and click Set status
7- Now, Fine(Accruing) changed to Fine(Lost) in the accounting tab of the
patron
8- In item detail, set Lost status: Choose and click Set status
9- Notice Fine(Lost) did not switch back to Fine(Accruing) in the accounting
tab
10- Check in the item
11- Notice there is a duplicate fee Fine(Returned) and Fine(Lost) is still
there
12- Apply the patch
13- Write off all fines of the patron
14- Repeat step 3 to 10 and notice step 9 is not true anymore
15- Notice there is only Fine(Returned) and no duplicate

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:05:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:05:50 +0000
Subject: [Koha-bugs] [Bug 31060] Fine duplicates when returning item with
 accountline status marked as lost
In-Reply-To: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31060-70-ktk4BZGkSS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31060

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:10:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:10:24 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-Cn3eWNZP9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate,
                   |                            |rel_22_05_candidate,
                   |                            |rel_22_11_candidate
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:11:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:11:10 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-OhhhdFPZI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Raised severity, because this is basically breaking analytics linking for many
users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:11:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:11:37 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-0lQTjweBff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:12:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:12:37 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-GVO1r86oWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This fixes usability and    |This fixes usability and
      release notes|consistency issues with the |consistency issues with the
                   |staff interface search      |staff interface search
                   |header. Retaining or        |header. Retaining or
                   |clearing search terms       |clearing search terms
                   |between searches is now     |between searches is now
                   |configurable using two new  |configurable using two new
                   |system preferences -        |system preferences -
                   |RetainCatalogSearchTerms    |RetainCatalogSearchTerms
                   |(for searching the catalog) |(for searching the catalog)
                   |and                         |and
                   |RetainPatronsSearchTerms    |RetainPatronsSearchTerms
                   |(for check out and          |(for check out and
                   |searching patrons).         |searching patrons).
                   |Previously, search terms    |Previously, search terms
                   |from searching the catalog  |were retained when 1)
                   |were retained. They were    |searching the catalog and
                   |also retained when          |then switching to check
                   |switching to check out,     |out, check in, or renew 2)
                   |check in, and search        |searching  from the check
                   |patrons from the search     |out or search patrons and
                   |results page - which then   |then switching to check in,
                   |required manually clearing  |renew and search catalog.
                   |the input field.
           |This then required manually
                   |
                           |clearing the input field.
                   |It also                     |
                   |cleans up the various       |
                   |search bar templates to use |
                   |a single template for the   |
                   |"Search the catalog" input  |
                   |in the search header.       |

--- Comment #42 from David Nind <david at davidnind.com> ---
(In reply to Florian from comment #40)
> Also rephrased the system preferences texts according to David's suggestion.

Thanks!

I have retested as per the test plan and updated the text for the release notes
(as the 'Consolidate search box code' is not included.

I would like to see 'Consolidate the search code' patch picked up as it seemed
like an nice tidy up - maybe a separate bug? I'll leave that for the QA team to
decide or comment on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:27:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:27:41 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-qVZI5UFmCf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:27:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:27:46 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-g5glDTE5MY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137269|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137313&action=edit
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:48:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:48:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-iSECnVRSIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137259|0                           |1
        is obsolete|                            |
 Attachment #137260|0                           |1
        is obsolete|                            |
 Attachment #137261|0                           |1
        is obsolete|                            |
 Attachment #137262|0                           |1
        is obsolete|                            |
 Attachment #137263|0                           |1
        is obsolete|                            |
 Attachment #137264|0                           |1
        is obsolete|                            |
 Attachment #137265|0                           |1
        is obsolete|                            |
 Attachment #137266|0                           |1
        is obsolete|                            |
 Attachment #137267|0                           |1
        is obsolete|                            |
 Attachment #137268|0                           |1
        is obsolete|                            |
 Attachment #137311|0                           |1
        is obsolete|                            |

--- Comment #530 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137314&action=edit
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:06 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-6EUIobBQL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #531 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137315&action=edit
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:14 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-gLZCNsmNUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #532 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137316&action=edit
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:22 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-J4P8IOGvbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #533 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137317&action=edit
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-Uo4e5DNbEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #534 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137318&action=edit
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:38 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-69G8STJocv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #535 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137319&action=edit
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or
create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:46 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-kOf3juABhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #536 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137320&action=edit
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:49:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:49:55 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-fqWbciW6Ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #537 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137321&action=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:50:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:50:00 +0000
Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-zblDSwm08e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:50:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:50:04 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-hYVHm94Xxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #538 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137322&action=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:50:14 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-VzgnCnlutZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #539 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137323&action=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:57:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:57:50 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-vZbi4Q3UZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 16:57:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 14:57:55 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-ieqbidKVRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135563|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137324&action=edit
Bug 30880: Add 'branchonly' to OPACResultsUnavailableGroupingBy

This patch adds a third option 'branch only' to the
OPACResultsUnavailableGroupBy system preference. This option will group
unavailable items by branch in the OPAC search results and NOT show
individual callnumbers or substatuses.

Note: This assumes OPACXSLTResultsDisplay is set to default.

To test:
1. Create a biblio record with 3 items with the following home branches:
Item A: Branch A
Item B: Branch A
Item C: Branch B
2. Check out Item A to yourself
3. Edit Item B to have a lost status
4. Go to Administration -> global system preferences. Search for
OPACResultsUnavailableGroupingBy.
5. By default, this preference will be set to 'branch'.
6. Open the OPAC in another tab, and search for your record.
7. Confirm the search results shows an Availability line with "Not
available: Branch A: Checked out (1). Branch A: Lost (1)." i.e. showing
both branch and substatus.
8. In your staff client tab, set OPACResultsUnavailableGroupingBy to
'substatus'.
9. Go back to your OPAC tab and search for your record. Confirm the
search results shows an Availability line with "Not available: Checked
out (1). Lost (1)." i.e. showing substatus only.
10. Apply patch, update database, restart services.
11. In your staff client tab, refresh the page. Confirm the options for
OPACResultsUnavailableGroupingBy have now changed to:
- branch and substatus
- substatus only
- branch only
12. Set OPACResultsUnavailableGroupingBy to 'branch only'.
13. Go back to your OPAC tab and search for your record. Confirm the
search results shows an Availability line with "Not available: Branch A
(2)." i.e. showing branch only.
14. Confirm the other two options still work as expected.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:00:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:00:43 +0000
Subject: [Koha-bugs] [Bug 29238] Cataloging cron jobs are not logged
In-Reply-To: <bug-29238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29238-70-KahD7kIZvG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29238

Sarah Cornell <sbcornell at cityofportsmouth.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbcornell at cityofportsmouth.
                   |                            |com

--- Comment #3 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
We'd appreciate this tiny enhancement.  I thought our linker cron wasn't
running today because it wasn't in the log.  Can we bump this up?  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:17:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:17:37 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-vbTQMdUAXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Sarah Cornell <sbcornell at cityofportsmouth.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbcornell at cityofportsmouth.
                   |                            |com

--- Comment #14 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
We are using multiple thesauruses as well and would like the linker to be able
to distinguish between them too.  Here is a typical example:

600 1 0 ‡aGammage, Jeff.‡0n 2007005947‡9104714
650 _ 0 ‡aAdoptive parents‡vBiography.‡0sh 92003241 
650 _ 0 ‡aIntercountry adoption‡zChina.‡0sh 85067220 
650 _ 0 ‡aIntercountry adoption‡zUnited States.‡0sh2008104783‡9227784
650 _ 7 ‡aAdoptive parents.‡2homoit‡0homoit0000010‡9218151

We would like the linker to consider the 6XX$0 field and the 6XX$2 field when
it selects the authority record for the 6XX$9 link.  The 6XX0 field matches
with either the 010 (LC headings) or the 024 (other thesauruses).  Using the
6XX$0 to match would also make it possible for the linker to find the match for
compound headings, which you can see it doesn't find for two of the 6XXs in my
example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:19:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:19:14 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-uKVhKIT0gs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:19:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:19:19 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-qlsCPLWCb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137045|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 137325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137325&action=edit
Bug 29922: Make get_search_groups return results sorted by title

get_search_groups from Koha/Library/Groups.pm returns library groups sorted by
title.

Test plan:
1- Go to administration > library groups and create multiple library groups
with different names (e.g. AGroup, BGroup, ÄGroup, etc.). Make sure to tick
"Use for OPAC search groups" checkbox.
2- Go to advanced search in OPAC.
3- Under "Groups of librairies" , click the select button.
4- Notice that the library groups are not in alphabetical order.
5- Apply the patch.
6- Notice that the library groups are in alphabetical order.
7- Run `prove t/db_dependent/LibraryGroups.t` and all test should pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:19:24 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-MDqjIvte25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137064|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <david at davidnind.com> ---
Created attachment 137326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137326&action=edit
Bug 29922: (follow-up) Remove extra sort

Remove wrong sort in staff advanced search page

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:22:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:22:28 +0000
Subject: [Koha-bugs] [Bug 31117] New: Cloning standard circulation rules for
 all libraries show up as from '*'
Message-ID: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

            Bug ID: 31117
           Summary: Cloning standard circulation rules for all libraries
                    show up as from '*'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: florian.bontemps at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 137327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137327&action=edit
Picture for exemple

When cloning circulation and fine rules using the "Standard rules for all
libraries" default option to another library, the confirmation title after
wards shows up as :

Cloning circulation and fine rules from "" to "Centerville"

Because the default option has no real label, it doesn't show up. This doesn't
affect the cloning feature, this is purely an text issue. You can see an
exemple on the attached picture.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:25:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:25:16 +0000
Subject: [Koha-bugs] [Bug 30024] link_bibs_to_authorities.pl relies on
 CatalogModuleRelink
In-Reply-To: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30024-70-ddt2L91Mzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30024

Sarah Cornell <sbcornell at cityofportsmouth.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sbcornell at cityofportsmouth.
                   |                            |com

--- Comment #1 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
I guess today's the day I bump a bunch of the authority linker bugs. 

This user expects "CatalogingModuleRelink = Do" to update links when I hit
"Link Authorities automatically" in the cataloging module.  

And I expect "LinkerRelink = Do" to update links when the cron job runs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:27:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:27:36 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-vxHqhTfnuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
  Text to go in the|                            |This fixes the display of
      release notes|                            |library groups in the
                   |                            |advanced search (Groups of
                   |                            |libraries) for the OPAC and
                   |                            |staff interface so that
                   |                            |they correctly sort in
                   |                            |alphabetical order. Before
                   |                            |this:
                   |                            |- OPAC: were sorted
                   |                            |in the order library groups
                   |                            |were added, group names
                   |                            |with diacritics and umlauts
                   |                            |(such as Ä or À) came last
                   |                            |(after something starting
                   |                            |with Z)
                   |                            |- Staff interface:
                   |                            |were sorted correctly, but
                   |                            |had the same issue as the
                   |                            |OPAC for group names with
                   |                            |diacritics and umlauts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:35:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:35:39 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-Ut1P5lptUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

--- Comment #1 from Florian <florian.bontemps at biblibre.com> ---
Created attachment 137328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137328&action=edit
Bug 31117: New message for cloning standard rules

This commit adds a different message when cloning circulation and fine rules if
you use the Standard rules for all libraries option.

Test plan :
1. Go to the Circulation and fine rules page in the Admin tab.
2. Check that the 'Select a library' menu is on 'Standard rules for all
libraries'.
3. Check that you also have some random rules to clone, or create some.
4. Clone these rules to the library of your choice.
5. Confirm that the message 'Clone circulation and fine rules from "" to
(library of your choice)' appears.
6. Now clone rules from a specific library to another one, and repeat steps
3-4.
7. Confirm that this time, the message will displays both libraries properly.
8. Apply patch.
9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the
first case will be 'Cloning circulation and fine rules to "(library of your
choice)"'.
10. Kindly sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 17:52:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 15:52:04 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-DYaT1plESU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:11:18 +0000
Subject: [Koha-bugs] [Bug 31073] ThingISBN API causes slowness when there
 are many editions
In-Reply-To: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31073-70-wdcgy6opmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31073

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ThingISBN API being         |ThingISBN API causes
                   |unavailable blocks loading  |slowness when there are
                   |of opac-detail when API     |many editions
                   |can't be found              |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:12:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:12:27 +0000
Subject: [Koha-bugs] [Bug 31073] ThingISBN API causes slowness when there
 are many editions
In-Reply-To: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31073-70-4n5mOJDzOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31073

--- Comment #2 from Liz Rea <wizzyrea at gmail.com> ---
Upon further review, it appears that the slowness is caused by books that have
many editions (think Hamlet).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:18:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:18:31 +0000
Subject: [Koha-bugs] [Bug 31073] ThingISBN API causes slowness when there
 are many editions
In-Reply-To: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31073-70-oXSQR41SJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31073

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
The problem code is in C4::XISBN:

    # loop through each ISBN and scope to the local collection
    for my $response_data( @{ $response->{ isbn } } ) {
        next if $unique_xisbns->{ $response_data->{content} };
        $unique_xisbns->{ $response_data->{content} }++;
        my $xbiblio= _get_biblio_from_xisbn($response_data->{content});
        next unless $xbiblio;
        push @xisbns, $xbiblio if $xbiblio && $xbiblio->{biblionumber} ne
$biblionumber;
    }

Basically, we run a search for each returned isbn to see if it's in our
catalog. Some of these titles have hundreds of ISBNs, especially for the
classics. For example, the brothers karamazov has nearly 500 isbns in
ThingISBN.

The solution could be
A) convert these hundereds of small queries into one or more big queries
and/or
B) move the this to the front end where we get the ThingISBN data via
javascript then search our own catalog via the rest api

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:22:55 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-6u2mfMlsbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137328|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137329&action=edit
Bug 31117: New message for cloning standard rules

This commit adds a different message when cloning circulation and fine rules if
you use the Standard rules for all libraries option.

Test plan :
1. Go to the Circulation and fine rules page in the Admin tab.
2. Check that the 'Select a library' menu is on 'Standard rules for all
libraries'.
3. Check that you also have some random rules to clone, or create some.
4. Clone these rules to the library of your choice.
5. Confirm that the message 'Clone circulation and fine rules from "" to
(library of your choice)' appears.
6. Now clone rules from a specific library to another one, and repeat steps
3-4.
7. Confirm that this time, the message will displays both libraries properly.
8. Apply patch.
9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the
first case will be 'Cloning circulation and fine rules to "(library of your
choice)"'.
10. Kindly sign off.

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:26:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:26:31 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-dvKD0REwTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

--- Comment #3 from Emmanuel Bétemps <e.betemps at gmail.com> ---
Actually, the message for the 1st case AFTER applying the patch is : Cloning
circulation and fine rules from standard rules to "(library of your choice)"

Your testplan says : Cloning circulation and fine rules to "(library of your
choice)"

But I think the typo is in the test plan because the sentence displayed (when
patch applies) really fits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 18:26:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 16:26:50 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-nSH098fccL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:25:23 +0000
Subject: [Koha-bugs] [Bug 31118] New: Allow to send the TOTP token when
 enabling 2FA
Message-ID: <bug-31118-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31118

            Bug ID: 31118
           Summary: Allow to send the TOTP token when enabling 2FA
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org
        Depends on: 28787

Bug 28787 adds the ability to send the token by email on login, but it would be
great to have it available when we enable 2FA as well.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
[Bug 28787] Send a notice with the TOTP token
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:25:23 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-0lzgC9vqOw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31118


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31118
[Bug 31118] Allow to send the TOTP token when enabling 2FA
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:27:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:27:57 +0000
Subject: [Koha-bugs] [Bug 31119] New: Cannot enable 2FA without scanning the
 QR code
Message-ID: <bug-31119-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31119

            Bug ID: 31119
           Summary: Cannot enable 2FA without scanning the QR code
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org
        Depends on: 28786

When enabling 2FA there are some info to setup the key on an app, but it's
missing the secret!

(from bug 28787 comment 16)
> Enable 2FA: Form text: Can't scan the code?  To add the entry manually,
> provide the following details to the application on your phone.  Account:
> BRANCH Key: BRANCH_EMAIL Time based: Yes
> But the form does not show the Secret. So telling the user to enter the
> details on their phone is useless?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
[Bug 28786] Two-factor authentication for staff client - TOTP
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:27:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:27:57 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-WMQLyqtK5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31119


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31119
[Bug 31119] Cannot enable 2FA without scanning the QR code
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:27:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:27:57 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-a7yOXG9xnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31119

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:28:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:28:31 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-xRiwFVacU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> Generally, I have some doubts about the API path api/v1/auth/send_otp_token.
> Sending a token is not a normally expected API action; it sounds like a
> 'misused verb'. You could think of creating a OTP code as an API action,
> although we do not really add it as entity.
> Apart from that it works. See some details hereunder.

Done, renamed with Tomas's suggestion: /auth/otp/token_delivery

> [1] Your TODO - I am not sure about the following line, so I commented it
> but 
> let it in the patch
> +            #|| $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token'
> ) {
> The otp path should go thru the chain. So this line should not be here
> although commented. Removed it.

Yes. Thanks!

> [2] Code segment from Koha/REST/V1/Auth.pm
>     if ( !$authorization and
>          ( $params->{is_public} and
>           ( C4::Context->preference('RESTPublicAnonymousRequests') or
>             $user) or $params->{is_plugin} )
>         or $pending_auth
> This does not look good to me. Do we need pending_auth here ? If so, at
> least we need parentheses etc. My follow-up removes the line now.

Agreed.

> [3] This segment is incomplete:
>         elsif ($status eq "additional-auth-needed") {
>             if ( $c->req->url->to_abs->path eq '/api/v1/auth/send_otp_token'
> ) {
>                 $user = Koha::Patrons->find( $session->param('number') );
>                 $cookie_auth = 1;
>                 $pending_auth = 1;
>             }
> I think we should raise an exception if we have this status and the api path
> does not match (so add an else). Removed pending_auth. Added a simple
> exception in my follow-up.

I reworked this part to take into account Tomas's remark. Requesting the token
should only be done when a full authentication is pending.

> [4] When I tested this API path via API keys, I got no authorization. I
> added a permission catalogue (staff access) to get around that. If you dont
> have that permission, we should not even send a code.

You did it in your follow-up patch.

> [5] Letters:
> +    if ( $content =~ m|\[% otp_token %\]| ) {
> +        my $patron = Koha::Patrons->find(C4::Context->userenv->{number});
> +        $tt_params->{otp_token} = Koha::Auth::TwoFactorAuth->new({patron =>
> $patron})->code;
> +    }
> This seems quite hacky. Why not pass it to Letters from the api module?
> Moved it now.
> This still needs updating the notice stuff.

The idea was to make it available from other templates, but that indeed seems
useless.

> [6] QA question: Is 400 the correct error code to tell the email has not
> been sent?
> I guess it is not. The client did nothing wrong. Maybe just plain 500? But
> having some doubts about that too.
> Or always 200/201 and refer for details to JSON body?

It can be a configuration error: the SMTP error is not setup correctly, or the
patron does not have an email address. I guess we should improve the UX.

> [7] TODO Hardcoded phrase: It is valid one minute.

Well, it's hardcoded but it's true so far. It will need to be modified after
bug 30843.

> [8] Functional question:
> When you want to enable 2FA without a mobile phone, what should you do?
> There is no link to send the code on that form.

Yes, that is a good idea to add it there as well. I am going to open a separate
bug report (bug 31118).

> [9] Current code:
> C4::Context->config('encryption_key')
> <encryption_key>__ENCRYPTION_KEY__</encryption_key>
> Do we still need to replace it in koha-create by the actual key ?

Are you asking if we should setup a key for new installs?

> Enable 2FA: Form text: Can't scan the code?  To add the entry manually,
> provide the following details to the application on your phone.  Account:
> BRANCH Key: BRANCH_EMAIL Time based: Yes
> But the form does not show the Secret. So telling the user to enter the
> details on their phone is useless?

Yes, we should show the secret. Opening a new bug report (bug 31119).

> Let me know if you agree with the follow-up.

Almost, follow-up coming ;)

Still TODO (will have a look tomorrow):
* Make the tests pass if the SMTP server is not set (hum are we doing that
already somewhere in other tests?)
* Improve user feedback messages if the email has not been sent

TODO on another bug report as well: Force 2FA for the REST API routes when not
using Basic auth (this needs bug 29836).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:30:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:30:36 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-26zExZukyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137330&action=edit
Bug 28787: Rename the REST API route to /auth/otp/token_delivery

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:30:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:30:41 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-4Bf8ACpSdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137331&action=edit
Bug 28787: Don't send the notice if we are not waiting for 2FA

If we are fully logged-in or haven't pass the password phase, don't send
the notice!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:56:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:56:56 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-KRVntJyFC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137218|0                           |1
        is obsolete|                            |

--- Comment #4 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137332&action=edit
Bug 30922: Make the "Relative's checkouts" table configurable by the table
settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are
hidden
6- Also notice the "Columns" and "Export" buttons that should work as
intended

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 19:57:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 17:57:27 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-H2SLBItKxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 20:17:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 18:17:30 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-lbg2W9j1cs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to David Nind from comment #2)
> I'm not seeing the error described in step 3.

I had to put a longer and longer string to reach the limit. Just add some
random chars.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 20:59:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 18:59:11 +0000
Subject: [Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds
 Awaiting Pickup page
In-Reply-To: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29154-70-b6knKsywRG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154

--- Comment #2 from Paul Navarrete <pnavarrete at cca.edu> ---
I like the pop up modal for this screen.
(sorry to leave this hanging)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 21:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 19:14:43 +0000
Subject: [Koha-bugs] [Bug 31120] New: Items will renew for zero ( 0 ) days
 if renewalperiod is blank/empty value
Message-ID: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

            Bug ID: 31120
           Summary: Items will renew for zero ( 0 ) days if renewalperiod
                    is blank/empty value
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 21:14:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 19:14:48 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-hM8DyerxnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 21:16:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 19:16:49 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-gxy7Nw9WzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 21:16:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 19:16:53 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-WNfYgvpEQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137333&action=edit
Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is
blank/empty value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 21:19:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 19:19:35 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-nSk0AtUoBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 22:19:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 20:19:39 +0000
Subject: [Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in
 transit should still appear as 'in transit' until they are received
In-Reply-To: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28527-70-bXn65JDi7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha-training at catalyst.net.
                   |                            |nz

--- Comment #6 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Can you please provide a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 22:37:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 20:37:46 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-6Gmbis5tDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 22:37:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 20:37:50 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-VFjslQhBFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137332|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137334&action=edit
Bug 30922: Make the "Relative's checkouts" table configurable by the table
settings

Adds "relatives-issues-table" in table settings.

Test plan:
1- Apply the patch
2- Check out an item to a patron with a guarantor
3- Go to the guarantor's "details" and "check out" page > relatives'
checkouts and look at the different columns (you should see collection
and location)
4- Go to
    admin > table settings > patron > moremember > relatives-issues-table
 or
    admin > table settings > circulation > circulation >
relatives-issues-table
to hide some columns (e.g. collection and location) and click save
5- Do step 3 again and notice some columns (e.g. collection and location) are
hidden
6- Also notice the "Columns" and "Export" buttons that should work as
intended

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul  7 22:41:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 20:41:07 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-nIXwkvC2Nb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes holds placed
      release notes|                            |using SIP2 to check that
                   |                            |the patron can actually
                   |                            |place a hold for the item.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 00:22:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 22:22:10 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-XxYHa2CPJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 00:22:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 22:22:14 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-SQLVTdY3UE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

--- Comment #2 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137335&action=edit
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 00:46:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 22:46:53 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-qI01pFat2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137335|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137336&action=edit
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Tested and it works, still needs an independent sign off though

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 00:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 22:58:43 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-XSpaqzb6TA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 00:58:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 22:58:48 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-WsWMcRZbIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137337&action=edit
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this
preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date
to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:00:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:00:23 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_30766=5D_Typo=3A_Cannot_cancel_rece?=
 =?utf-8?q?ipt=2E_Possible_reasons=E2=90=A0=3A?=
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-5lKlkgvRVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

--- Comment #1 from Danyon Sewell <danyonsewell at catalyst.net.nz> ---
Created attachment 137338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137338&action=edit
Bug 30766: extra space in Cannot cancel receipt string.

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:00:56 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_30766=5D_Typo=3A_Cannot_cancel_rece?=
 =?utf-8?q?ipt=2E_Possible_reasons=E2=90=A0=3A?=
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-6HF2q0BMPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Danyon Sewell <danyonsewell at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danyonsewell at catalyst.net.n
                   |                            |z
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:01:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:01:04 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-fDuXEwLjkc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:01:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:01:09 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-GLkjH2XVRA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137339&action=edit
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice
that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled
hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:09:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:09:33 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-TizmYxNTc4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137337|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137340&action=edit
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this
preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date
to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Works as advertised, still needs independent signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:14:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:14:12 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-JcEvoW8ObW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:14:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:14:16 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-Am4YW0bTaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

--- Comment #2 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137341&action=edit
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:16:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:16:08 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-wpcnMyOJoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137342&action=edit
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Sponsored by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:17:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:17:31 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-RzXrKJBDw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:17:34 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-5WGrJNAyLG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137342|0                           |1
        is obsolete|                            |

--- Comment #2 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137343&action=edit
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:20:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:20:14 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_30766=5D_Typo=3A_Cannot_cancel_rece?=
 =?utf-8?q?ipt=2E_Possible_reasons=E2=90=A0=3A?=
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-lI3SCAYUyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137338|0                           |1
        is obsolete|                            |
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137344&action=edit
Tested patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:23:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:23:09 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-L7gEf8l0NT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137339|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137345&action=edit
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice
that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled
hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Works as expected, needs inpdependent signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:26:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:26:55 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-nM8V7Opwxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137341|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137346&action=edit
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Works as expected, needs indpendent signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:32:44 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-UBW9g6ThmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137343|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137347&action=edit
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Patch looks fine, needs independent signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:33:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:33:21 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-0Qm3yNBjP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:33:25 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-46lPrH11dX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137348&action=edit
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:34:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:34:13 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-tlU84BP6H7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Danyon Sewell <danyonsewell at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:34:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:34:17 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-3PB1UXDA0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

--- Comment #3 from Danyon Sewell <danyonsewell at catalyst.net.nz> ---
Created attachment 137349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137349&action=edit
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:41:27 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-1tWYvuCJWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137348|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137350&action=edit
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Does what it says it does, still needs independent sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:48:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:48:20 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-U0cRXRYwf6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137349|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137351&action=edit
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Works as expected, needs indpendent sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:49:25 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-UZoTeQvLc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:49:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:49:29 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-2b13UBAuks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137352&action=edit
Bug: 27996: Updates the Circulation report overdues page to display date in
red.

Test:
1. Login to the staff interface
2. First you need to create an overdue item.
  a. Find the barcode for an item
  b. Goto My checkouts from the drop down by your login
  c. Enter the barcode and use checkout settings to select a date in the
  past.
2. Go to Tools
3. Go to Circulation
4. Go to Go to Overdues
5. In the table the due date is in black
6. Apply the patch
7. Refresh the page and the due date should be in red.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:56:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:56:29 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-fTnO0i6mwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137352|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137353&action=edit
Bug: 27996: Updates the Circulation report overdues page to display date in
red.

Test:
1. Login to the staff interface
2. First you need to create an overdue item.
  a. Find the barcode for an item
  b. Goto My checkouts from the drop down by your login
  c. Enter the barcode and use checkout settings to select a date in the
  past.
2. Go to Tools
3. Go to Circulation
4. Go to Go to Overdues
5. In the table the due date is in black
6. Apply the patch
7. Refresh the page and the due date should be in red.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Works well, needs independent sign off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:56:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:56:34 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-dN3krUf6MU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:56:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:56:38 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-UNRp6bp2FA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

--- Comment #1 from Koha Training Catalyst <koha-training at catalyst.net.nz> ---
Created attachment 137354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137354&action=edit
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 01:58:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Jul 2022 23:58:36 +0000
Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing
In-Reply-To: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23415-70-kFeVr7Zf4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415

Danyon Sewell <danyonsewell at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danyonsewell at catalyst.net.n
                   |                            |z
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #40 from Danyon Sewell <danyonsewell at catalyst.net.nz> ---
Patch doesn't apply. Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 02:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 00:05:51 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-6RS6pHnft2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137354|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 137355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137355&action=edit
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Works as expected, needs independent sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 06:32:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 04:32:00 +0000
Subject: [Koha-bugs] [Bug 30468] koha-mysql does not honor Koha's timezone
 setting
In-Reply-To: <bug-30468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30468-70-gA7xLnm6nX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30468

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 06:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 04:54:18 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-BZQSyGxbqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 06:54:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 04:54:22 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-T3ZZjKlzD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137355|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 137356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137356&action=edit
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:02:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:02:43 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-IIfS998RR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This standardizes the
      release notes|                            |spelling used for i-tiva in
                   |                            |the staff interface. When
                   |                            |modifying notices (Tools >
                   |                            |Notices & slips > [select
                   |                            |any notice]) the section is
                   |                            |now labelled 'Phone (
                   |                            |i-tiva )' - this is now
                   |                            |consistent with the table
                   |                            |heading used for Tools >
                   |                            |Overdue notice/status
                   |                            |triggers.
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Different spelling is used for i-tiva (after enabling
TalkingTechItivaPhoneNotification):
   - Tools > Notices & slips > [modify any notice]: spelling is 'Phone ( Itiva
)' for the expandable section)
   - Tools > Overdue notice/status triggers: column heading is Phone (i-tiva)

2. Standardised on i-tiva, so, after the patch is applied, for any notice the
expandable section is now labelled as 'Phone (i-tiva)'.

3. I think the spaces after and before the brackets could be removed, and it
would be even more consistent. I'm not sure if this makes any difference for
translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:14:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:14:30 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-j5YBBiWz9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:14:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:14:34 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-dwJO6EpbZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137353|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 137357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137357&action=edit
Bug: 27996: Updates the Circulation report overdues page to display date in
red.

Test:
1. Login to the staff interface
2. First you need to create an overdue item.
  a. Find the barcode for an item
  b. Goto My checkouts from the drop down by your login
  c. Enter the barcode and use checkout settings to select a date in the
  past.
2. Go to Tools
3. Go to Circulation
4. Go to Go to Overdues
5. In the table the due date is in black
6. Apply the patch
7. Refresh the page and the due date should be in red.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:14:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:14:59 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-9WKI30h596@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This highlights the due
      release notes|                            |date for an overdue item in
                   |                            |red on the Circulation >
                   |                            |Overdues page. (This is
                   |                            |consistent with how an
                   |                            |overdue date is displayed
                   |                            |in other areas of the staff
                   |                            |interface, such as on a
                   |                            |patron's list of
                   |                            |checkouts.)
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:39:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:39:52 +0000
Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a
 register
In-Reply-To: <bug-29987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29987-70-SQpWAxvIAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:41:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:41:35 +0000
Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file,
 mandatory item subfields that are empty do not block form submission
In-Reply-To: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30268-70-X62JvzHaP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:43:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:43:39 +0000
Subject: [Koha-bugs] [Bug 30580] GetItemsAvailableToFillHoldRequestsForBib
 should get transfers during initial query
In-Reply-To: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30580-70-ZlPf8OHTR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30580

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:44:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:44:12 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-Uezw6lCswk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:45:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:45:43 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-6MEgR4nWKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:46:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:46:14 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-RwuPEfQymc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:49:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:49:30 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-hM5sAgTzvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:49:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:49:57 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-hRJ0n80J80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 07:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 05:51:12 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-uFVuQsNPqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:03:19 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-ZjD9r8nSlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:03:24 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-tzcMDcqhks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137351|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137358&action=edit
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:03:31 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-xCDy0oVIkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 137359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137359&action=edit
Bug 30784: (follow-up) Addiional rephrasing

Add additional clarifcation, format NOTE: similar to most other
notes in system preferences (bold, start on a new line), and link
to other system preferences mentioned.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:06:30 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-Fm2pF8OBa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 137360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137360&action=edit
Bug 30784: (follow-up) Additional rephrasing

Add additional clarifcation, format NOTE: similar to most other
notes in system preferences (bold, start on a new line), and link
to other system preferences mentioned.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:06:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:06:39 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-oZzYiskXai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:07:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:07:41 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-6jgY2WaKFF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
 Attachment #137359|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Comment on attachment 137359
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137359
Bug 30784: (follow-up) Addiional rephrasing

Fixed spelling error in bug title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:07:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:07:55 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-dlE2g0JPzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:08:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:08:56 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-q4pTnANPIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:20 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-vZsqJ3xlVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:24 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-ojSzH144LU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137313|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137361&action=edit
Bug 31116: Add circulation sidebar to article requests

This patch adds the circulation sidebar menu to the article requests
page to make it consistent with other circulation module pages.

Test plan
1) Prior to applying the patch confirm that there is no sidebar on the
   article requests management page, regardless of the CircSidebar
   perference.
2) Apply the patch
3) Confirm there is still no sidebar when CircSidebar is disabled
4) Confirm there is now a sidebar present when CircSidebar is enabled
5) Confirm the current page is highlighted correctly in the sidebar when
   on the article requests page.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:24 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-cB3IAulq31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:28 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-WE792SOLPc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137362&action=edit
Bug 31116: (QA follow-up) Remove duplicate line

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:44 +0000
Subject: [Koha-bugs] [Bug 30880] Expand OPACResultsUnavailableGroupingBy to
 have a 'branch only' option
In-Reply-To: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30880-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30880-70-fNcEEaB5c2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30880

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:09:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:09:47 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-EXEZtORW5J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:10:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:10:06 +0000
Subject: [Koha-bugs] [Bug 30922] Make the "Relative's checkouts" table
 configurable by the table settings
In-Reply-To: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30922-70-TGFjD4HSrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:10:55 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-qBL3hehUwT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:11:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:11:12 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-6i40CRtGcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
My only comment would be: Article requests is considered as Circulation, so it
would be fine for me if it would have been listed under Circulation. Patron
request is added now. All circulation stuff is based on 'patron requests' ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:11:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:11:30 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-6foScR3RyA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:12:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:12:04 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-RFSZ6zvc8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:12:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:12:22 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-YDDUlYbiT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Needs Signoff               |RESOLVED

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
It seems that no one is interested in this change.
I will no longer spend time on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:15:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:15:04 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-AEh6gzq3bA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This updates the text for
      release notes|                            |the OPACMandatoryHoldDates
                   |                            |system preference. It
                   |                            |replaces the URL for the
                   |                            |form (opac-reserve) with a
                   |                            |description, formats the
                   |                            |note similar to other
                   |                            |notes, and links to other
                   |                            |system preferences
                   |                            |mentioned in the
                   |                            |description.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:17:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:17:59 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-oU2ntRHKBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl
           Assignee|oleonard at myacpl.org         |danyonsewell at catalyst.net.n
                   |                            |z
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:18:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:18:44 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-1IlJkrHvDS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:18:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:18:48 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-pKuxIO2eI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137358|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137363&action=edit
Bug: 30784: Rephrasing OPACMandatoryHoldDates pref slightly

TEST PLAN:

1. On the Admin page, navigate to Koha Administration > Global System
Preferences

2. Search for OPACMandatoryHoldDates

3. In the Value field, check that it now says On the "Placing a hold"
form, instead of opac-reserve form.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:18:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:18:52 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-19R34fywmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137360|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137364&action=edit
Bug 30784: (follow-up) Additional rephrasing

Add additional clarifcation, format NOTE: similar to most other
notes in system preferences (bold, start on a new line), and link
to other system preferences mentioned.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:19:24 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-Pg3Huyrn9F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Welcome Danyon Sewell. Please change Assignee when you submit patches. Thx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:21:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:21:02 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-hEz4aJoWnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137365&action=edit
Bug 30773: (follow-up) Remove spaces between brackets

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:22:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:22:15 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-kBABQW6d3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

--- Comment #6 from David Nind <david at davidnind.com> ---
(In reply to David Nind from comment #4)
> 3. I think the spaces after and before the brackets could be removed, and it
> would be even more consistent. I'm not sure if this makes any difference for
> translation.

I've added a follow-up patch to remove the spaces between the brackets, will
leave up to the QA Team to decide!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:23:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:23:27 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-nyPESr18t7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:23:32 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-fuZlkMC13W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137253|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137366&action=edit
Bug 29951: Fix EXPORT for C4::ClassS*Routine modules

Can't locate object method "subclasses" via package "C4::ClassSplitRoutine" at
/kohadevbox/koha/C4/ClassSplitRoutine.pm line 53

Certainly from bug 17600.

Test plan:
Home -> Administration -> Classification sources -> New splitting rule

And create classification sources and filing rules.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:25:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:25:46 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-pDj7YuQX0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|martin.renvoize at ptfs-europe |m.de.rooy at rijksmuseum.nl
                   |.com                        |
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:35:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:35:09 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-rCrE9e5L5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please provide feedback for this change:

-                        <xsl:attribute
name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:(<xsl:value-of
select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:subfield[@code='a'],
'/', ''), true())"/>)</xsl:attribute>

+                        <xsl:attribute
name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of
select="str:encode-uri($title_query, true())"/></xsl:attribute>

You remove translate ?

Similar example:
-                                <xsl:attribute
name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of
select="str:encode-uri(translate(marc:subfield[@code='t'], '()', ''),
true())"/><xsl:if test="marc:subfield[@code='a']">+AND+au:<xsl:value-of
select="str:encode-uri(translate(marc:subfield[@code='a'], '()', ''),
true())"/></xsl:if></xsl:attribute>

+                                    <xsl:with-param name="term"><xsl:value-of
select="marc:subfield[@code='t']"/></xsl:with-param>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 08:59:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 06:59:50 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-kl7VdPAjDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
86.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
86.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
87.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
87.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
88.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
158.
Argument "" isn't numeric in multiplication (*) at
/usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
288.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:04:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:04:09 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-9YplWWSjFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:04:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:04:14 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-4Bjc08UPhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136532|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137367&action=edit
Bug 31039: Remove duplicate modal printing JS

This patch removes the erroneos duplication of the modal printing js.

Test plan
1) Create some transactions and perform a cashup.
2) Open the cashup summary modal
3) Click 'Print'
4) Cancel the print dialogue
5) Note that the dialogue re-appears
6) Apply the patch
7) Repeat and note the dialogue closes first time now.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:04:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:04:18 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-kCzqrncncz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137046|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137368&action=edit
Bug 31039: (follow-up) Wrap jQuery in $(document).ready()

cashup_modal.js consists only of jQuery code, so the whole thing should
be contained in a $(document).ready() function. This may or may not be
contributing to the behavior this bug is trying to fix.

Please note that this patch contains whitespace changes, so diff
accordingly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:04:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:04:30 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-MotajIRoeQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:05:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:05:59 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-qFz6f4mE6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
 Attachment #137235|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 137235
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137235
Bug 30025: Split BiblioAddsAuthorities into two sysprefs

Same patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:07:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:07:09 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-YEnCcazyGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |BLOCKED

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:10:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:10:10 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-60lZ7M3nGr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:10:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:10:16 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-t298yRWPLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137369&action=edit
Bug 28787: Mock send_or_die

To make the tests pass even if no SMTP server is defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:10:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:10:21 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-EWP9cb2zoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137370&action=edit
Bug 28787: Comment selenium test that will fail if no SMTP server is defined

This is a deadlock I think. Any ideas how we could continue to test that
in any conditions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:11:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:11:56 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-QU1QlYsAbu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137331|0                           |1
        is obsolete|                            |

--- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137371&action=edit
Bug 28787: Don't send the notice if we are not waiting for 2FA

If we are fully logged-in or haven't pass the password phase, don't send
the notice!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:12:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:12:12 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-SFZYtWU4Z1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #30)
> Still TODO (will have a look tomorrow):
> * Make the tests pass if the SMTP server is not set (hum are we doing that
> already somewhere in other tests?)

Done, but I had to remove a selenium test. I don't think we can find a solution
to make it pass without SMTP server.

> * Improve user feedback messages if the email has not been sent

Done. Not how I imagined it yesterday, but I think it's simpler and efficient
enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:15:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:15:06 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-FqosBJc1kC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #42)
> (In reply to Jonathan Druart from comment #32)
> > Ha, and question, see catalogue/detail.pl
> > We are using an order_by that was initially used in GetItemsInfo. Should it
> > be the default order by for all item searches?
> > I am also stuck trying to replicate the previous order_by behaviour for
> > serials (see the FIXME there)
> 
> I wonder if we should add ordering into the Koha::Biblio->items method?
> 
> I'm not sure how it would/could affect
> embedding/prefetching/joining/caching...
> 
> But it would be nice to consistently order.. binding on whether the bib is a
> serial or otherwise to get the 'right' ordering?

Maybe we should have an explicit "search ordered" method?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:54:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:54:59 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-jmVpBwnm3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Reading this description:
When editing records, ALLOW catalogers to manually create new headings if
needed, rather than having to reference existing authorities. 

It is not completely clear to me.
When I enable this pref, I am able to change e.g. 100$a name of author while
linked to a PERSO_NAME authority.
If you are using authorities, do you really want that?

But when I disable again, I can still create a new authority from the biblio
form. But I am no longer able to change the 100$a.

It seems that the pref description does not really tell the story.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 09:57:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 07:57:10 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-stKbvSbAnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Applying: Bug 28787: Mock send_or_die
error: sha1 information is lacking or useless
(t/db_dependent/api/v1/two_factor_auth.t).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:00:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:00:04 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-FBAIMOaoKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Fixed it manually. Dont worry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:03:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:03:45 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-Lug8b7qIIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:03:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:03:50 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-8Phic3gqHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137336|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137372&action=edit
Bug 30763: fixes spelling of 'proceeds'

Test plan:
1. Login to the staff interface
2. go to tools
3. go to label creator
4. Click New -> Layout
5. Click the 'Choose layout type' dropdown
6. Notice the 'barcode proceeds biblio data' and 'biblio data proceeds
barcode'.  These are typos
7. Apply the patch and refresh the page
8 repeat step 5. Confirm 'proceeds' now correctly says 'precedes'

Sponsored by: Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:04:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:04:01 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-6H895osh7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
time prove t/db_dependent/api/v1/two_factor_auth.t
t/db_dependent/api/v1/two_factor_auth.t .. ok
All tests successful.
Files=1, Tests=1,  6 wallclock secs ( 0.04 usr  0.00 sys +  5.22 cusr  0.38
csys =  5.64 CPU)
Result: PASS

real    0m5.824s
user    0m5.334s
sys     0m0.393s

Why is it so slow ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:05:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:05:14 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-aX4YsH2vat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
            Version|unspecified                 |master
           Assignee|oleonard at myacpl.org         |evan at catalyst.net.nz

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the patch! As the fix is small I am going to move this straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:08:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:08:12 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-o44eGwrwCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:08:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:08:17 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-ZS2ergEuE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137340|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137373&action=edit
Bug 30762: Terminology: Go to Staff client

Test plan
Login to staff interface
Go to Administration. Search EnableExpiredPasswordReset. Enable this
preference. Save.
Find your patron record and go to details.
In the ‘OPAC/Staff interface login’ section, set the Password expiration date
to  the previous day. Save.
Open the OPAC in a new window.
Login to your account. It will fail. Click Reset your password.
Follow the process to add a new password.  Click update password.
See that it says ‘Go to staff interface’

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:12:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:12:39 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-eNaBXmY3MC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
             Status|Signed Off                  |Passed QA
           Assignee|oleonard at myacpl.org         |kriswehipeihana at catalyst.ne
                   |                            |t.nz

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for the patch, going straight to PQA!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:13:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:13:58 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-xoM7NKg0LU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Typo: Cannot cancel         |Typo: Cannot cancel
                   |receipt. Possible reasons␠: |receipt. Possible reasons :

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:14:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:14:50 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-sm4GHhSIeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:14:55 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-OsE5jO3MFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137344|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137374&action=edit
Bug 30766: extra space in Cannot cancel receipt string

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:16:04 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-NfLeyRXesJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
            Version|unspecified                 |master
           Assignee|oleonard at myacpl.org         |danyonsewell at catalyst.net.n
                   |                            |z

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Danyon! Going straight to PQA here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:19:30 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-6ybIYuq4xu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:19:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:19:33 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-ZoYuMJNGj2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137345|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137375&action=edit
Bug 30764: replace "Cancelled reserve" with "Cancelled hold"

Test plan:
1. Inspect `koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt`, notice
that on line 136 it says "Cancelled reserve"
2. Apply patch
3. Inspect the same line again and notice it now correctly says "Cancelled
hold"
4. ???
5. Profit!

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:20:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:20:51 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-w7Pq2fXNDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for your patch, Filip! Passing QA!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:22:55 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-dhCadCYrjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30764
            Version|unspecified                 |master
           Assignee|oleonard at myacpl.org         |toscawaerea at catalyst.net.nz


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764
[Bug 30764] Terminology: Cancelled reserve
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:22:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:22:55 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-uXUCGA1nZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30770


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770
[Bug 30770] Terminology: Lost reserve
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:24:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:24:55 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-OTfOdBZmh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:24:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:24:59 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-6sa6Xr8Fat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137347|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137376&action=edit
Bug 30770: Fixed terminology 'reserve' -> 'hold'

Test plan:
1. Look at koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
2. Note that it says 'Lost reserve'
3. Apply patch
4. Note that it says 'Lost hold'

Note:
I was not able to trigger the behaviour to see the text in question

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:25:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:25:35 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-Gsww59WWkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for your patch, Tosca! Going straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:28:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:28:03 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-jaOdtDD73S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:28:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:28:09 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-nRnkETFlNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137346|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137377&action=edit
Bug 30767: Changes word "issue" to "item"

Please test and confirm terminology is now correct.
Was unable to test without steps to reproduce.

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:30:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:30:01 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-hwYg2fKNk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
             Status|Signed Off                  |Passed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for your patch! Always happy to see these things fixed, passing QA too.

Missing test plan, because these were found during the translation process,
sorry for that!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:32:39 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-YRDSDPKWdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137378&action=edit
Bug 30770: (QA follow-up) Fixing the last occurrence of reserve in returns.tt

Reserve -> Hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:34:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:34:16 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-8ZW4nlmbG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137379&action=edit
Bug 28787: Don't request a token if no email address defined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:34:21 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-yGXBNgDf9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137369|0                           |1
        is obsolete|                            |

--- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137380&action=edit
Bug 28787: Mock send_or_die

To make the tests pass even if no SMTP server is defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:34:26 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-8kHtUsRhUw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137370|0                           |1
        is obsolete|                            |

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137381&action=edit
Bug 28787: Comment selenium test that will fail if no SMTP server is defined

This is a deadlock I think. Any ideas how we could continue to test that
in any conditions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:35:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:35:12 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-F5BEdHdSIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:35:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:35:59 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-X5ZobY1aUb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:36:04 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-dpMPnTv35X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137356|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137382&action=edit
Bug 30773: Standardize spelling i-tive / Itiva

In the Koha staff interface go to administration.
Go to TalkingTechItivaPhoneNotification. Enable this preference. Save.
Go to Tools > Overdue notice/status triggers
Check that ‘Phone (i-tiva)’ is an option for notice types.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:36:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:36:08 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-PEYsK4Mw7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137365|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137383&action=edit
Bug 30773: (follow-up) Remove spaces between brackets

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:36:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:36:43 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-gbbdIA3aui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |kriswehipeihana at catalyst.ne
                   |                            |t.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:37:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:37:38 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-426q4VSYEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:40:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:40:40 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-1ekeTddbLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:40:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:40:44 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-QuOiUUji6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137357|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137384&action=edit
Bug: 27996: Updates the Circulation report overdues page to display date in
red.

Test:
1. Login to the staff interface
2. First you need to create an overdue item.
  a. Find the barcode for an item
  b. Goto My checkouts from the drop down by your login
  c. Enter the barcode and use checkout settings to select a date in the
  past.
2. Go to Tools
3. Go to Circulation
4. Go to Go to Overdues
5. In the table the due date is in black
6. Apply the patch
7. Refresh the page and the due date should be in red.

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:41:19 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-vLRb1hQbRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you for the patch, Karen!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:47:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:47:35 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-Me0fZElZcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:58:43 +0000
Subject: [Koha-bugs] [Bug 31118] Allow to send the TOTP token when enabling
 2FA
In-Reply-To: <bug-31118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31118-70-X979j2CmxS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31118

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 10:59:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 08:59:20 +0000
Subject: [Koha-bugs] [Bug 31119] Cannot enable 2FA without scanning the QR
 code
In-Reply-To: <bug-31119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31119-70-tBaH7Syu1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31119

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:14:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:14:50 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-ijWfdu8LaU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Quite keen to see this one fixed, but we have 2 complaints in the QA test
tools. Can you please fix?

 FAIL   C4/Circulation.pm
   FAIL   critic
                # Variables::ProhibitConditionalDeclarations: Got 2
violation(s).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:19:51 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-qSx8HqTxQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:22:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:22:24 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-AH7EvNAx2p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:22:29 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-XQAlbjdcC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137350|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137385&action=edit
Bug 29050: Added a punctuation between renewal messages

Test plan:

1. First step is to go to administration > then system preferences
2. Set unseenrenewal to "allow"
3. Go to administatrion > circulation and fines rule
4. Set unseenrenewals count to any number
5. Check out an item to a patron and go to the checkouts tab
6. Renew the item
7. Notice that the renewal messages have no seperation
8. Apply the patch
9. Notice there is now a "&" in the spacing between renewal messages

Sponsored-by: Catalyst IT
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:23:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:23:10 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-YLu3tHyW3f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you for your patch, Nisha! Going straight to PQA for this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:27:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:27:31 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-HD7B8LSlfe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:31 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-iy2N8GjtFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:35 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-CRnLUGQHPT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136491|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137386&action=edit
Bug 27779: Group payouts by type of debit they're applied against

This patch adds additional grouping to the cashup summary output such
that payouts are additionally grouped by the types of debit they're
applied against.  The cashup sumary modal is adapted to expose the
descriptions at the grouping level too.

Test plan
1/ Add a various transactions using a cash register (Using Point of
Sale, Patron Accounts with payments etc).
2/ Refund some of the debts and pick the 'cash' option for payout.
(ensure you pick a variety of debit types)
3/ Add some credit to a patron account, (either refund a debt as
'credit' or add a 'manual credit')
4/ Payout the credit as 'cash' on the patron account
5/ Cashup the register
6/ Inspect the cashup summary for your cashup.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:39 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-Iiq4x58NpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136492|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137387&action=edit
Bug 27779: Update 'REFUND' description in the database

This patch simplified the REFUND description from 'Refund applied
to a patrons fine' to simply 'Refund'.. this allows the description to
be combined with debit type descriptions simply to denote what it was
applied against instead of using the generic 'applied to a patrons fine'

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:43 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-I326rZUFB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136493|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137388&action=edit
Bug 27779: New atomic update syntax

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:47 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-egZ3qNwDl8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136494|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137389&action=edit
Bug 27779: (QA follow-up) Fix translation issue with 'against'

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:40:51 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-PUgSjbxWfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136495|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137390&action=edit
Bug 27779: (QA follow-up) Fix database update

Don't overwrite peoples translations if they've already changed the
description.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:41:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:41:57 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-niA6ilClq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:43:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:43:54 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-hAd7ZQTdjw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:00 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-kWsnzBD8FO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136571|0                           |1
        is obsolete|                            |

--- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137391&action=edit
Bug 28787: Send a notice with the TOTP token

Bug 28786 let librarians enable a Two-factor authentication but force them to
use
an application to generate the TOTP token.

This new enhancement add the ability to send an email containing the token to
the
patron once it's authenticaed

The new notice template has the code '2FA_OTP_TOKEN'

Test plan:
- Setup the two-factor authentication (you need the config entry and the
syspref ON)
- Enable it for your logged in patron
- Logout
- Login and notice the new link "Send the code by email"
- Click on it and confirm that you received an email with the code
- Use the code to be fully logged in

QA question: Is 400 the correct error code to tell the email has not
been sent?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:06 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-9f8Jo1gcm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136572|0                           |1
        is obsolete|                            |

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137392&action=edit
Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:10 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-q0aBGRVXUU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136573|0                           |1
        is obsolete|                            |

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137393&action=edit
Bug 28787: Typo authenticaction

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:15 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-KCCddaPAVY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137251|0                           |1
        is obsolete|                            |

--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137394&action=edit
Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t

Changing flags to 20 to include the required Staff access for
intranet login.
This changes the http status. The API raises an exception now.

Test plan:
Run t/db_dependent/api/v1/two_factor_auth.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:20 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-nAACF0e5ND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137330|0                           |1
        is obsolete|                            |

--- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137395&action=edit
Bug 28787: Rename the REST API route to /auth/otp/token_delivery

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:25 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-gnbDFgrqBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137371|0                           |1
        is obsolete|                            |

--- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137396&action=edit
Bug 28787: Don't send the notice if we are not waiting for 2FA

If we are fully logged-in or haven't pass the password phase, don't send
the notice!

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:29 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-IJ3J0d8guw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137379|0                           |1
        is obsolete|                            |

--- Comment #49 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137397&action=edit
Bug 28787: Don't request a token if no email address defined

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:36 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-NElxkK9o08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137380|0                           |1
        is obsolete|                            |

--- Comment #50 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137398&action=edit
Bug 28787: Mock send_or_die

To make the tests pass even if no SMTP server is defined.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:42 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-MYiYS9fP5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137381|0                           |1
        is obsolete|                            |

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137399&action=edit
Bug 28787: Comment selenium test that will fail if no SMTP server is defined

This is a deadlock I think. Any ideas how we could continue to test that
in any conditions?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:44:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:44:47 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-EcXjvas9yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137400&action=edit
Bug 28787: (follow-up) Typo and additional test

Adding a test for a 403 status when lowering authorization.
The Auth mock for check_cookie_auth is not needed here.
Reading back the session after flush either.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:49:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:49:43 +0000
Subject: [Koha-bugs] [Bug 31121] New: Format date range on top of cashup
 summary page
Message-ID: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

            Bug ID: 31121
           Summary: Format date range on top of cashup summary page
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When you look at the cashup summary, the dates are formatted in database
format:

Period: 2022-07-08 09:42:24 to 2022-07-08 09:44:35

These should be formatted nicely according to the DateFormat system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:49:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:49:43 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-p2DfebCjxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31121

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:50:14 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-CofOpB2TDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:50:18 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-WAxhT8JWQe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136490|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137401&action=edit
Bug 31038: Fix price formating in cashup summary

This patch uses the existing format_price JS include to format prices in
the cashup summary modal

Test plan
1) Create some transactions and a cashup
2) View the cashup summary modal and confirm amounts are not nicely
   formatted
3) Apply patch
4) Confirm amounts in cashup summary modals are now nicely formatted

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 11:53:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 09:53:19 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-qqLL5yw36q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 12:00:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 10:00:24 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-FmTWScRWOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Few small notes for QA:

+            elsif ($status eq "additional-auth-needed") {
+            }
=> Should we add an exception here?

            elsif ( $status eq 'ok' ) {
                Koha::Exceptions::Authentication->throw(
                    error => 'Cannot request a new token.' );
=> This is theoretical. But in this case you are authorized, but we (..) do no
longer want to send another token, so it is actually a bad request. So 400 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 12:12:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 10:12:06 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-lSRxmGyIUm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 12:12:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 10:12:10 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-56BbkQ34nL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137055|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137402&action=edit
Bug 31083: Fix part_name handling in js-biblio-format

This patch corrects the typo introduced in bug 28854 for part_name
handling in the js-biblio-format include.  We also introduce proper
whitespace addition when concatenating subtitle, medium and parts to the
title string.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 12:30:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 10:30:40 +0000
Subject: [Koha-bugs] [Bug 13956] Add budget information to funds pull down
 on creating an order
In-Reply-To: <bug-13956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13956-70-BZWWCalEzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:12:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:12:15 +0000
Subject: [Koha-bugs] [Bug 29154] Add hold cancellation reason to Holds
 Awaiting Pickup page
In-Reply-To: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29154-70-nOKlxzjV8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29154

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
                 OS|Mac OS                      |All
           Hardware|Macintosh                   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:13:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:13:49 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-aP4fnO4HXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137403&action=edit
Bug 29050: (follow-up) Replace & with and

See the terminology list https://wiki.koha-community.org/wiki/Terminology

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:19:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:19:01 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-n7cGlEmuhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmanuel, I think you are right, the sentence fits, we don't need to have
the exact same wording.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:19:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:19:53 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-DZqfShaXuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:19:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:19:57 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-qDmW3fOy3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137329|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137404&action=edit
Bug 31117: New message for cloning standard rules

This commit adds a different message when cloning circulation and fine rules if
you use the Standard rules for all libraries option.

Test plan :
1. Go to the Circulation and fine rules page in the Admin tab.
2. Check that the 'Select a library' menu is on 'Standard rules for all
libraries'.
3. Check that you also have some random rules to clone, or create some.
4. Clone these rules to the library of your choice.
5. Confirm that the message 'Clone circulation and fine rules from "" to
(library of your choice)' appears.
6. Now clone rules from a specific library to another one, and repeat steps
3-4.
7. Confirm that this time, the message will displays both libraries properly.
8. Apply patch.
9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the
first case will be 'Cloning circulation and fine rules to "(library of your
choice)"'.
10. Kindly sign off.

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:20:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:20:46 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-QwLGHghK7G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:23:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:23:43 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-1WlBI343TF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:23:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:23:48 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-aRwiX7Fqxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137325|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137405&action=edit
Bug 29922: Make get_search_groups return results sorted by title

get_search_groups from Koha/Library/Groups.pm returns library groups sorted by
title.

Test plan:
1- Go to administration > library groups and create multiple library groups
with different names (e.g. AGroup, BGroup, ÄGroup, etc.). Make sure to tick
"Use for OPAC search groups" checkbox.
2- Go to advanced search in OPAC.
3- Under "Groups of librairies" , click the select button.
4- Notice that the library groups are not in alphabetical order.
5- Apply the patch.
6- Notice that the library groups are in alphabetical order.
7- Run `prove t/db_dependent/LibraryGroups.t` and all test should pass.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:23:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:23:58 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-Wli8GwmStD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137326|0                           |1
        is obsolete|                            |

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137406&action=edit
Bug 29922: (follow-up) Remove extra sort

Remove wrong sort in staff advanced search page

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:24:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:24:25 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-B562r3CObu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Happy to see this one finished, thanks your for your perseverance!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:27:58 +0000
Subject: [Koha-bugs] [Bug 31107] smsalertnumber missing from OPAC
 self-registration
In-Reply-To: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31107-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31107-70-sf2J2G3c6G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31107

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is a partial duplicate to bug 20859.

*** This bug has been marked as a duplicate of bug 20859 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:27:58 +0000
Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences
 during self registration
In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20859-70-t7SMSXR9Fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31107 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:34:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:34:43 +0000
Subject: [Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search
 results when an OPAC search is filtered by branch
In-Reply-To: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31114-70-2n4ZGGTtak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can't replicate this problem on master. 

I tested with the sample data on ktd:

* Activate OpacHiddenItems with: itype: [BK]
* Search for Perl in the OPAC: 1 result
* Search for Perl in the staff interface: 11 results
* Activate OpacAddMastheadLibraryPulldown
* Search for Perl with "All libraries" - 1 result
* Search for Perl with "Fairview" and several other libraries: no result

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:38:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:38:32 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-GkpScztDJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What text should we use? Maybe:

(See also.... and ...)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:40:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:40:04 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-9JiHmTa6gI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #1)
> What text should we use? Maybe:
> 
> (See also.... and ...)

Can we just put them in there own sub-group, or maybe as their own
"multi-syspref" on a single line?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:40:59 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-JI5EILJiPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Both could be options, I'd be willing to do it, just not sure yet what would
work best. (and also no idea on how to name the sub-heading)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:42:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:42:19 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-fmWdIob3Pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #3)
> Both could be options, I'd be willing to do it, just not sure yet what would
> work best. (and also no idea on how to name the sub-heading)

How about "Circulation Control Branch Selectors" or something along those
lines?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:43:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:43:42 +0000
Subject: [Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date
 filter
In-Reply-To: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27442-70-tGs34HD0II@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> 
> Kelly, Andrew, can you give us more info please?

Ping!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:47:17 +0000
Subject: [Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description
 to explain consequences of setting in Koha
In-Reply-To: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27448-70-rndK75L1J6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|27070                       |27252
                 CC|                            |nick at bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070
[Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all
terms are in the same field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252
[Bug 27252] ES5 no longer supported (since 20.11.00)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:47:17 +0000
Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6
 searches failing unless all terms are in the same field
In-Reply-To: <bug-27070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27070-70-E7nCl6jBgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|27448                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448
[Bug 27448] Update ElasticsearchCrossFields description to explain consequences
of setting in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:47:17 +0000
Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
In-Reply-To: <bug-27252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27252-70-mkxMVlT9Qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448
[Bug 27448] Update ElasticsearchCrossFields description to explain consequences
of setting in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:59:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:59:10 +0000
Subject: [Koha-bugs] [Bug 31122] New: Terminology: Replace & with and for
 Notices & slips
Message-ID: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

            Bug ID: 31122
           Summary: Terminology: Replace & with and for Notices & slips
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org

>From the terminology list, "Only use "&" when part of a proper noun or a common
abbreviation, such as Baker & Taylor or R&D. Otherwise use "and". "

Update needed for the page titles, description and breadcrumbs for Tools >
Patrons and circulation > Notices & slips.

To find occurrences: 
- git grep 'Notices &amp; slips' -- :^misc/translator/po
- git grep 'Notices & slips'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:59:38 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-SH9JeVm9Fo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david at davidnind.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 13:59:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 11:59:54 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-qQgrhM0mfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:29:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:29:59 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-EyfVm6601C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:30:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:30:02 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-vcgJiT4tsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

--- Comment #1 from David Nind <david at davidnind.com> ---
Created attachment 137407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137407&action=edit
Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices
and slips'

Replace occurences of 'Notices & slips' with 'Notices and slips'
(replacing '&' and '&amp' with 'and'), as per the terminology
guidelines.

See the terminology list:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. Find occurrences of 'Notices & slips':
   - git grep 'Notices &amp; slips' -- :^misc/translator/po
   - git grep 'Notices & slips'
2. Review places in the staff interface where 'Messages & slips' is
   displayed:
   - Tools home page
   - Tools > Notices & slips: page title and breadcrumb
   - Other breadcrumbs:
     . Tools > Notices & slips > New notice > [select any module]
     . Tools > Notices & slips > [select Edit for any notice]
     . Tools > Notices & slips > [select Delete for any notice]
3. Review other occurences:
   . The cron job description for misc/cronjobs/holds/holds_reminder.pl:
     misc/cronjobs/holds/holds_reminder.pl -man (scroll down to the
     description)
   . The TalkingTech README file:
     vi misc/cronjobs/thirdparty/TalkingTech.README
4. Apply the patch.
5. Re-run the grep queries from step 1 - no occurences are now found.
6. Review places where 'Notices & slips' was found in steps 2 and 3 -
   these should all be replaced with 'Notices and slips' and should
   read correctly.
7. Sign off!

Alernative: review the diff for the patch and check that occurences of
'&amp' and '&' are replaced with 'and' and the updated text reads
correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:31:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:31:13 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-4Xq0YM6AhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This updates occurrences of
      release notes|                            |'Notices & slips' with
                   |                            |'Notices and slips', as per
                   |                            |the terminology guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:38:17 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-xXDZcj3rkg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:38:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:38:49 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-BeYBD990oG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #84 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137408&action=edit
screenshot of the new interface : the main menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:40:16 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-D02PoKVYFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #85 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137409&action=edit
screenshot of the new interface : return page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:40:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:40:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-UY4i3j4qpf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #86 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137410&action=edit
screenshot of the new interface : patron details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:42:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:42:10 +0000
Subject: [Koha-bugs] [Bug 17650] Create the option to save the cover with
 the uploaded files.
In-Reply-To: <bug-17650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17650-70-2MIFBVPAVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com

--- Comment #16 from Blou <philippe.blouin at inlibro.com> ---
This functionality would interest us.  We're trying to reduce the imprint of
biblioimages on our database size.

Is there a reason the QA could already forewarn us about that this idea (moving
biblioimages outside the DB) would gain no traction?

Not sure if the current implementation is the right way, but we'd add a script
to move the current biblioimages out, as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:48:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:48:19 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-3NptWpby9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137410|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:53:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:53:23 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-ss3cUPyOeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 14:57:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 12:57:37 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-O9iXcm1mco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #87 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137411&action=edit
screenshot of the new interface : patron details

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:06:01 +0000
Subject: [Koha-bugs] [Bug 17897] Koha::SearchMappingManager - Simplify
 search mapping modifications
In-Reply-To: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17897-70-ZOkqm0KQRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #11 from David Nind <david at davidnind.com> ---
Patch still applies, but tests fail:

 prove -vvv t/db_dependent/Koha/SearchEngine/ElasticSearch.t
t/db_dependent/Koha/SearchEngine/ElasticSearch.t .. 
# Subtest: Reset Elasticsearch mappings
    ok 1 - Scenario: Reset Elasticsearch mappings to an empty database
    ok 2 - Given empty search mapping tables
    ok 3 - When reset_elasticsearch_mappings() has been ran
    ok 4 - Then search mapping tables have been populated
    ok 5 - Scenario: Reset Elasticsearch mappings when custom mappings already
exist
    1..5
ok 1 - Reset Elasticsearch mappings
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Data truncated for column 'type' at row 1 at
/kohadevbox/koha/Koha/Objects.pm line 114
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 11 just after 1.
Dubious, test returned 11 (wstat 2816, 0xb00)
All 1 subtests passed 

Test Summary Report
-------------------
t/db_dependent/Koha/SearchEngine/ElasticSearch.t (Wstat: 2816 Tests: 1 Failed:
0)
  Non-zero exit status: 11
  Parse errors: No plan found in TAP output
Files=1, Tests=1,  4 wallclock secs ( 0.03 usr  0.00 sys +  3.53 cusr  0.19
csys =  3.75 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:15:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:15:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-3piC0923hY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #88 from Solene D <solene.desvaux at biblibre.com> ---
This new interface includes  modifications of the main colors, the buttons, the
menus, the searchbar... (cf screenshots)

Any feedback will be helpfull. :)

We decided to remove the css from the patch, you'll have to generate it to test
the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:23:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:23:31 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-H0meDqQV5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> Please provide feedback for this change:
> 
> -                        <xsl:attribute
> name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:(<xsl:value-of
> select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:
> subfield[@code='a'], '/', ''), true())"/>)</xsl:attribute>
> 
> +                        <xsl:attribute
> name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of
> select="str:encode-uri($title_query, true())"/></xsl:attribute>
> 
> You remove translate ?

What I said:

> I think those translations were added because we just didn't quote the string as this patch is doing. in fact, such 'fixes' should be engine-specific and dealt with in the Koha::SearchEngine::{engine}::QueryBuilder module instead. I would > like to hear from David and Nick before moving on with just removing the translates, but the feeling is... we were doing things wrong (not quoting) and working around things...

We can bring them back. But the fact that some places remove parenthesis, and
others the slash smells... a lot. My testing showed that they are not taken
into account in Zebra, and being quoted makes the query not break, which is why
those got removed. See comment 5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:26:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:26:38 +0000
Subject: [Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify
 catalogue problems
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-cDlJK0gAlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137412&action=edit
Specification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:26:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:26:46 +0000
Subject: [Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify
 catalogue problems
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-FJk7ZAiegB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:26:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:26:53 +0000
Subject: [Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify
 catalogue problems
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-QDLKoIIAj0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:27:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:27:02 +0000
Subject: [Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify
 catalogue problems
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-iMuKkdgAnq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:27:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:27:31 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-SqaCvGfQWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:27:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:27:35 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-l6xonQnQ1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137413&action=edit
Bug 30911: Datatables error on course-details.pl after adding a bib-level
course reserve

This patch removes the colspan from biblio-level course reserves rows in
favor of adding a style to the message's container allowing it to
overflow across table cells.

To test, apply the patch and go to course reserves.

1. If necessary, add a new course.
2. View the details of the course and add a reserve using the
   biblionumber option to add the reserve at the bibliographic level.
3. Add a notes if you want, then click "Save."
4. Return to the course detail view.
5. In the table of reserves your biblio-level reserve should have a
   message starting in the "Barcode" column and overflowing across other
   item information columns, "Item information is not available for
   record-level course reserve."
6. Try adding multiple item-level and biblio-level reserves to the same
   course to confirm that the information displays well in those cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:28:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:28:57 +0000
Subject: [Koha-bugs] [Bug 31028] Enhance 'Report a problem' to specify
 catalogue problems
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-pghAFCKFUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've opted to specify this as an independence feature.. it more closely
resembled checkout notes from a workflow perspective than it does the opac
problem reports system and the sponsor wanted to be able to enabled/disable the
features separately.

I can see a route to merging the checkout notes feature into this piece as part
of a modernisation effort at a later date too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:32:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:32:41 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-B6rNGG68sH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I totally agree actually.. I just followed what the circulation-home page does
in terms of splitting them.

I'd be happy to remove the 'Patron requests' section from both and move
'Article requests' under circulation for consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:26 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-HdnkwojR1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #89 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137414&action=edit
Bug 30952: Staff interface redesign

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:28 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-UplBw7E0ts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Enhance 'Report a problem'  |Add 'Report a concern'
                   |to specify catalogue        |feature for patrons to
                   |problems                    |report concerns about
                   |                            |catalogue records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:38 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-ZzjvILv7tN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|4461                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
[Bug 4461] Add a context-sensitive report a problem process
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:38 +0000
Subject: [Koha-bugs] [Bug 4461] Add a context-sensitive report a problem
 process
In-Reply-To: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4461-70-hsR71Y7dEe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31028                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028
[Bug 31028] Add 'Report a concern' feature for patrons to report concerns about
catalogue records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:40 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-K4nWScI70H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #90 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137415&action=edit
Bug 30952: script searchbar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-CWxN1KOUp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #91 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137416&action=edit
Bug 30952: update aside menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:34:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:34:53 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-OBscN10P0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #92 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137417&action=edit
Bug 30952: update buttons toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:35:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:35:02 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-4uI4s5O5xL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #93 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137418&action=edit
Bug 30952: update filter search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:35:10 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-wBcgG9mhQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #94 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137419&action=edit
Bug 30952: renaming classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:35:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:35:16 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-i7JolbyY51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #95 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137420&action=edit
Bug 30952: update main menu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:36:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:36:37 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-cFSRRUXmul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:40:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:40:52 +0000
Subject: [Koha-bugs] [Bug 29986] Descriptions of system internal debit types
 and credit types should be editable
In-Reply-To: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29986-70-zOBYBTSHJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29986

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pretty sure those were done this way at the time as a requirement.. if we allow
them to be edited then the translations break from memory.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:43:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:43:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-gZM3Quc6Xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136974|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:45:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:45:55 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-TJqro5uOZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136973|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:46:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:46:23 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-H65uwGiH1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136972|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:48:36 +0000
Subject: [Koha-bugs] [Bug 31123] New: Add a simple way to add 'Harmful
 content warnings' to catalogue records
Message-ID: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

            Bug ID: 31123
           Summary: Add a simple way to add 'Harmful content warnings' to
                    catalogue records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I propose adding a new 'quick add' button into the biblio toolbar that would
trigger a modal where staff can enter a short content warning note to be added
to a designated 59X field (MARC21).

I would then modify the default XSLTs to display the note highlighted to draw
the users attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:49:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:49:01 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-CQ8i5mhqe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:49:11 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-njOgn61qZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:50:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:50:58 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-N9QS5Iz6Xl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |https://bugs.koha-community
                   |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi
                   |?id=25466                   |?id=31123

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:50:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:50:58 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-imGs1unExk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31028

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:50:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:50:58 +0000
Subject: [Koha-bugs] [Bug 25466] Review 'problem_reports' column names and
 types
In-Reply-To: <bug-25466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25466-70-nkpsq7Rog6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25466

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=31028                   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:53:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:53:15 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-9fOCwhnYXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136951|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:54:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:54:10 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-qxFjGUPxHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136951|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:54:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:54:51 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-7GuMBc0V7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136968|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 15:56:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 13:56:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ntHX7TN00j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136969|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:05:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:05:37 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-8k9i1jVMNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137241|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137421&action=edit
Bug 30933: Database revision (new pref)

Adds pref ListOwnerDesignated.
Generalize description of ListOwnershipUponPatronDeletion a bit.

Test plan:
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:05:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:05:41 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-vzUe8pcwwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137242|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137422&action=edit
Bug 30933: Change for patron->delete

Test plan:
Run t/db_dependent/Koha/Patrons.t
Set pref ListOwnershipUponPatronDeletion to transfer.
Set pref ListOwnerDesignated to some valid borrowernumber.
Pick a user with public or shared list, delete from interface.
Pick a user with public or shared list, delete by script. (*)
Verify in both cases that new list owner is the designated one.

(*) Tip: Create another branch. Move the patron to be deleted to that
branch. And delete by script with:
    misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:05:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:05:45 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-9ecyIkXkTY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137243|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137423&action=edit
Bug 30933: Adjust pref description, include ListOwnerDesignated

Test plan:
View the pref on the System preferences, Patrons tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:05:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:05:49 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-po03X83zxI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137244|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137424&action=edit
Bug 30933: (follow-up) Consolidate transfer checks

Adding shelf->cannot_be_transferred with unit tests.

Note: This follow-up actually refers to comment42 on the
preceding report 25498.
Furthermore, we could still improve later on using error code
more effectively (adding codes). Here we concentrate on moving
the checks to module level.

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:05:54 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-eau7mjuncQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137245|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137425&action=edit
Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts

Test plan:
Verify if transfer shared list on OPAC still works as expected.
Same for intranet counterpart for public lists.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:06:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:06:52 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-5TR8hH9NcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I did wonder if we could save ourselves a syspref and just use the anonymous
user.. but I decided the clarity here was probably better.

All works as expected, QA scripts are happy and tests are passing

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:07:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:07:32 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-B7qQAnE9xo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:17:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:17:20 +0000
Subject: [Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl)
 never uses default letter template
In-Reply-To: <bug-30667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30667-70-peaOhbvl6Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667

evelyn <evelyn at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |evelyn at bywatersolutions.com

--- Comment #6 from evelyn <evelyn at bywatersolutions.com> ---
Could this be backported to 21.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:17:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:17:25 +0000
Subject: [Koha-bugs] [Bug 30025] BiblioAddsAuthorities is poorly named
In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30025-70-P359N69YME@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025

--- Comment #13 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
> It is not completely clear to me.
> When I enable this pref, I am able to change e.g. 100$a name of author while
> linked to a PERSO_NAME authority.
> If you are using authorities, do you really want that?

In many cases, yes, this is exactly what libraries want. For a cataloger who
knows their authorities well and can reliably type them into bibs by hand, it's
cumbersome to use the authority picker interface. Instead, they want to just
type in an author name or subject heading and let the linker take care of
finding the related authority.

That said, you're right the name AllowManualAuthorityEditing gives slightly the
wrong impression. This is not a question of whether or not one is manually
editing authority records, but rather a question of whether or not one is
manually editing authority-controlled fields in bibs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:25:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:25:47 +0000
Subject: [Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date
 filter
In-Reply-To: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27442-70-uaL2IWEnkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442

--- Comment #12 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
In all honesty, at this point I remember that we filed this because we ran into
a Koha system that had due dates with 23:59:59 due dates, but I can no longer
recall what that system was or how those checkouts were created. It's possible
they were migrated in that way and it's not actually possible to set a due date
with seconds on a checkout performed in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:33:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:33:22 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-pcx4AcnEN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:33:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:33:26 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-BdSrwTFbwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137413|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137426&action=edit
Bug 30911: Datatables error on course-details.pl after adding a bib-level
course reserve

This patch removes the colspan from biblio-level course reserves rows in
favor of adding a style to the message's container allowing it to
overflow across table cells.

To test, apply the patch and go to course reserves.

1. If necessary, add a new course.
2. View the details of the course and add a reserve using the
   biblionumber option to add the reserve at the bibliographic level.
3. Add a notes if you want, then click "Save."
4. Return to the course detail view.
5. In the table of reserves your biblio-level reserve should have a
   message starting in the "Barcode" column and overflowing across other
   item information columns, "Item information is not available for
   record-level course reserve."
6. Try adding multiple item-level and biblio-level reserves to the same
   course to confirm that the information displays well in those cases.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:34:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:34:20 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-XOLHUtARLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks a lot, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:36:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:36:47 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-jLBhZeDtAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137426|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137427&action=edit
Bug 30911: Datatables error on course-details.pl after adding a bib-level
course reserve

This patch removes the colspan from biblio-level course reserves rows in
favor of adding a style to the message's container allowing it to
overflow across table cells.

To test, apply the patch and go to course reserves.

1. If necessary, add a new course.
2. View the details of the course and add a reserve using the
   biblionumber option to add the reserve at the bibliographic level.
3. Add a notes if you want, then click "Save."
4. Return to the course detail view.
5. In the table of reserves your biblio-level reserve should have a
   message starting in the "Barcode" column and overflowing across other
   item information columns, "Item information is not available for
   record-level course reserve."
6. Try adding multiple item-level and biblio-level reserves to the same
   course to confirm that the information displays well in those cases.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:38:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:38:27 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-AahULv48b6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Working as expected.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:46:35 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-lvKrmjG4hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137428&action=edit
Bug 31121: Fix date formatting in cashup summary modal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:46:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:46:51 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-sCICZwO7oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:46:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:46:59 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-Jtez2Jsele@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:47:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:47:26 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-YQQ2DKiMVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:47:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:47:26 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-46y2cGiR2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31121


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121
[Bug 31121] Format date range on top of cashup summary page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:48:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:48:16 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-jWIKarE8gB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the formatting
      release notes|                            |of dates on the cashup
                   |                            |summary modal (it uses the
                   |                            |existing $datetime JS
                   |                            |include).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:49:11 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-j7EO7cNkUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136950|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:49:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:49:20 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-uiJGPQjEje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136951|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:49:36 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-U0sdK2ifAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136952|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:49:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-koQOMEQU1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136953|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-TujOn59oQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136954|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:14 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-A6alr17Xug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136955|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:26 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-G1JDUEG7F0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136956|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:39 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-hBCdIe2Wid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136957|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:54 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-jyFmUAy8U9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #15 from Frank Hansen <frank.hansen at ub.lu.se> ---
Hi, (In reply to Sarah Cornell from comment #14)
> We are using multiple thesauruses as well and would like the linker to be
> able to distinguish between them too.  Here is a typical example:
> 
> 600 1 0 ‡aGammage, Jeff.‡0n 2007005947‡9104714
> 650 _ 0 ‡aAdoptive parents‡vBiography.‡0sh 92003241 
> 650 _ 0 ‡aIntercountry adoption‡zChina.‡0sh 85067220 
> 650 _ 0 ‡aIntercountry adoption‡zUnited States.‡0sh2008104783‡9227784
> 650 _ 7 ‡aAdoptive parents.‡2homoit‡0homoit0000010‡9218151
> 
> We would like the linker to consider the 6XX$0 field and the 6XX$2 field
> when it selects the authority record for the 6XX$9 link.  The 6XX0 field
> matches with either the 010 (LC headings) or the 024 (other thesauruses). 
> Using the 6XX$0 to match would also make it possible for the linker to find
> the match for compound headings, which you can see it doesn't find for two
> of the 6XXs in my example.

I understand your point. In Bug 17511 there is a discussion whether to move the
AuthId link field from $9 to $0 or not. But there is a comment that $0 is a
complex field. And the discussion seems to have died after that.

$0 is complex because it is repeatable and its content may have different
meanings. It may even contain URI:s. We have such situation in our catalog as
well. Here is an example:

=650  \7$aFeminism$0https://id.kb.se/term/sao/Feminism$2sao$0144892$94353
=650  \7$afeminism$2bnb$0144892$9216319
=650  \0$aFeminism$9216318

The first heading referring to the sao thesaurus. There are two occurences of
the $0 subfield. The first one consist of a URI and the the second one is the
ID of the authority record in the Royal Library catalog.

The second heading referring to the BNB thesaurus with one occurence of the $0
subfield which, i guess is the ID of the authority record in the BNB thesaurus
system.

The last heading is our LC authority record.

When I viewed the code I couldn't see I understand your point. In Bug 17511
there is a discussion whether to move the AuthId link field from $9 to $0 or
not. But there is a comment that $0 is complex. The discussion almost died
after this comment. It is complex partly because subfield $0 is a repeatable
field and may contain other ID:s with a different meaning and partly because it
also may contain URI:s. We have such situation in our catalog as well. Here is
an example taken from our catalog:

=650  \7$aFeminism$0https://id.kb.se/term/sao/Feminism$2sao$0144892$94353
=650  \7$afeminism$2bnb$0144892$9216319
=650  \0$aFeminism$9216318

The first heading referring to the sao thesaurus. There are two occurences of
the $0 subfield. The first one consist of a URI and the the second one is the
ID to the actual authority record at the Royal library.

The second heading referring to the BNB thesaurus with one occurence of the $0
subfield which probably is a ID from the BNB thesaurus system.

The last heading is our LC authority record.

I know that the LC field 010$az is an indexed field and can certainly be used
to duplication control. But i'm not sure if it is doable to distinguish between
LC records based on the 6XX$0 field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:50:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:50:55 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-PGjuphXphP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136958|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:51:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-XkxS0x8Zml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136959|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:51:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:51:23 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-GWSOSM5Ms9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136960|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:51:36 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-f02oeQndeS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136961|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:51:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:51:56 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mlaloyEbja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136962|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:52:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:52:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LX4RUorNjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136963|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:52:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:52:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-hsRNAU3WH3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136964|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:52:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vGc3PwxcoL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136965|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:53:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LXWpm08N25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136966|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:53:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:53:13 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-Qfyp7Z2Ycd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136967|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:53:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:53:35 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-l6RwR17at1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136970|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:53:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:53:52 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-rSEvsiZbyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136971|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:57:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:57:10 +0000
Subject: [Koha-bugs] [Bug 31124] New: koha-remove fails to remove long_tasks
 queue daemon, so koha-create for same <instance> user fails
Message-ID: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

            Bug ID: 31124
           Summary: koha-remove fails to remove long_tasks queue daemon,
                    so koha-create for same <instance> user fails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: rel_22_05_candidate
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matted-34813 at mypacks.net
        QA Contact: testopia at bugs.koha-community.org

>From the command line as a koha shell user:
1)
koha-remove <instance>
fails to remove the backgroundjobs / long_tasks(queue) daemon. (ps -aef | grep
long_tasks)
So when it tries to "deluser" the <instance>-koha user from /etc/passwd
that errors because a process is still running for that user's PID.
2)
koha-create <instance>   fails for that same instance name from that point
onward.

3)
koha-worker --help    doesn't show any --queue option

Cursory investigation shows:
--queue support was added in version 22.05 to koha-worker.

koha-worker --stop --queue long-tasks <instancename>
works to shut down that specified queue.
--status and --start are also supported.

Suggested Fix:
1)
koha-remove needs to have an entry added:
koha-worker --stop --queue long_tasks <instancename>
added accordingly to get that process to stop
so the latter deluser will succeed.

2)
koha-worker needs:
the --queue option should be added to the --help / POD

Also, koha-worker --help should at least show:
Usage:
koha-worker [--start|--stop|--restart] [--quiet|-q] [--queue <queuename>]
instancename1 [instancename2...]
and also:
    --queue <queuename>     Specify a queue name

One should be able to be able(test plan):
test 1)
koha-remove kohadev
koha-create --create-db kohadev
koha-remove kohadev
without problems in the ktd or other test environment to be fixed.
test 2)
Also, koha-worker --help should at least show:
Usage:
koha-worker [--start|--stop|--restart] [--quiet|-q] [--queue <queuename>]
instancename1 [instancename2...]
and also:
    --queue <queuename>     Specify a queue name

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:57:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:57:10 +0000
Subject: [Koha-bugs] [Bug 27783] Introduce background job queues
In-Reply-To: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27783-70-PC2Krogpry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31124

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 16:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 14:59:12 +0000
Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks
 queue daemon, so koha-create for same <instance> user fails
In-Reply-To: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31124-70-QUk0Vaowyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:00:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:00:53 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-8NyLsvRmEx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:16:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:16:59 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-c3ZpOJeTJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but the information doesn't show at all for me now :(

Period: to

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:18:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:18:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ySBffyXMZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #96 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
1. Lot of French in the patches:
* "onclick="clique(this)""
* <p class="plusdessous" id="filters"> 
Plus dessous?!
* <ul id="taille">
* id="lientype", french, "link type"

2. Not descriptive:
* id="button_1", button_2, button_3, button_4

3. Lot of commented code.

4. This seems wrong:
+    function toggle(elem){style="width: calc(301px);"

5. identical JS code copy/pasted all around:
functions focusInput, toggle, clique, fold, taille, etc.

6. There is a lot of unnecessary indentation changes, that will lead to
unnecessary conflicts...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:19:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:19:15 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-IDiJBzDvAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137428|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137429&action=edit
Bug 31121: Fix date formatting in cashup summary modal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:19:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:19:49 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-6iihzuYjWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Kyle M Hall from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Both could be options, I'd be willing to do it, just not sure yet what would
> > work best. (and also no idea on how to name the sub-heading)
> 
> How about "Circulation Control Branch Selectors" or something along those
> lines?

I have several issues with that :D

* capitalization
* branch should be library
* ... and it might just be a little long and wrap on the side navigation in
system preferences. 

Hmmm.

Circulation control libraries

?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:23:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:23:02 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-X33DkBTOFg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:23:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:23:06 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-6RnnOC7Jty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137407|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137430&action=edit
Bug 31122: Terminology - Replace occurences of 'Notices & slips' with 'Notices
and slips'

Replace occurences of 'Notices & slips' with 'Notices and slips'
(replacing '&' and '&amp' with 'and'), as per the terminology
guidelines.

See the terminology list:
https://wiki.koha-community.org/wiki/Terminology

Test plan:
1. Find occurrences of 'Notices & slips':
   - git grep 'Notices &amp; slips' -- :^misc/translator/po
   - git grep 'Notices & slips'
2. Review places in the staff interface where 'Messages & slips' is
   displayed:
   - Tools home page
   - Tools > Notices & slips: page title and breadcrumb
   - Other breadcrumbs:
     . Tools > Notices & slips > New notice > [select any module]
     . Tools > Notices & slips > [select Edit for any notice]
     . Tools > Notices & slips > [select Delete for any notice]
3. Review other occurences:
   . The cron job description for misc/cronjobs/holds/holds_reminder.pl:
     misc/cronjobs/holds/holds_reminder.pl -man (scroll down to the
     description)
   . The TalkingTech README file:
     vi misc/cronjobs/thirdparty/TalkingTech.README
4. Apply the patch.
5. Re-run the grep queries from step 1 - no occurences are now found.
6. Review places where 'Notices & slips' was found in steps 2 and 3 -
   these should all be replaced with 'Notices and slips' and should
   read correctly.
7. Sign off!

Alernative: review the diff for the patch and check that occurences of
'&amp' and '&' are replaced with 'and' and the updated text reads
correctly.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:23:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:23:49 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-pdgE4zDL5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks David :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:29:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:29:51 +0000
Subject: [Koha-bugs] [Bug 29986] Descriptions of system internal debit types
 and credit types should be editable
In-Reply-To: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29986-70-13q7DxHPbB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29986

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we use the codes for the translation in the templates, so this should
be ok. There is an additional description that is English by default and can be
translated via the installer files. But when we add new system internal debit
types/credit types that are added via the database updates, the library has no
means to translate them as well and they will be a mix of languages.

I think the description might be used in reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:30:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:30:11 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-THfT3PYEGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136477|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137431&action=edit
Bug 31036: Treat SIP00 that same as CASH

SIP00 is the code for CASH transactions that have taken place on a SIP
client.  Cash management treats CASH type transactions as a special case
for banking and register requirements. This patch brings SIP00 in line
with the CASH handling code of cash management.

Test plan
1) Enable cash management with 'EnablePointOfSale'
2) Enable cash registers with 'UseCashRegisters'
3) Add a cash register via 'Administration > Cash registers'
4) Make some payments against the ash register in the staff client
5) Attempt to make a payment via a SIP client without having associated
   a cash register to the SIP account config
5a) This should now fail
6) Attach the cash register to the SIP account used above
6a) Payment should now work again on SIP transactions
7) Look at the cash register details page for the cash register
7a) 'Bankale' should now include cash from both SIP and Staff client
sales

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:30:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:30:24 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-0aMyLXUKo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:31:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:31:32 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-8BRgCvqe0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This has been deployed for a while now.. signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:31:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:31:48 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-OALhC7VLeO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:32:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:32:52 +0000
Subject: [Koha-bugs] [Bug 30667] Holds reminder cronjob (holds_reminder.pl)
 never uses default letter template
In-Reply-To: <bug-30667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30667-70-v6punf1Gud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to evelyn from comment #6)
> Could this be backported to 21.11?

I've added the RMaint to CC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:40:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:40:05 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mWP0SuRYx6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #97 from George Williams (NEKLS) <george at nekls.org> ---
On the home page, HTML from the IntranetmainUserblock system preference gets
pushed under the news area (id="area-news") in the new interface.  It should be
under the menu items.

"Patrons requesting updates" used to be in a div called id="area-pending" and
it used to fall under the menu items.  Now it's under the news area in an
id="area-news" div.

This same problem applies to Suggestions pending and Quote of the day.  They
should all be under the menu items.  

My library make extensive use of the news area to share links to outside
resources and putting these things underneath the news area makes the alerts,
quote of the day and IntranetmainUserblock means that users may have to scroll
40 feet down the page in order to access relevant information and alerts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:44:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:44:06 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-c5omTmP5Vj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #98 from George Williams (NEKLS) <george at nekls.org> ---
Code mirror text in system preferences like IntranetUserJS is centered?

That's just crazy.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:57:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:57:03 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-BwmLzrRRCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #99 from George Williams (NEKLS) <george at nekls.org> ---
The "area-news" id is repeated several times on the home page for news, quote
of the day, and alerts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 17:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 15:58:20 +0000
Subject: [Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date
 filter
In-Reply-To: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27442-70-kxPb1uYuv8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am trying to see how we could resolve it - would closing it and fixing the
data if you run into it again be an option?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:01:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:01:44 +0000
Subject: [Koha-bugs] [Bug 27442] Overdues report uses 23:59:00 on To date
 filter
In-Reply-To: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27442-70-ZTObriqH3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27442

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|In Discussion               |RESOLVED

--- Comment #14 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Works for me!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:05:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:05:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-0zuABPG6jJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #100 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to George Williams (NEKLS) from comment #98)
> Code mirror text in system preferences like IntranetUserJS is centered?
> 
> That's just crazy.

Agreed. I feel the same way about centered text in the search results. It makes
it harder to distinguish items and visually track certain characteristics that
would always be in the same place in left justified text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:06:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:06:13 +0000
Subject: [Koha-bugs] [Bug 31125] New: Fix warnings from register.tt
Message-ID: <bug-31125-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31125

            Bug ID: 31125
           Summary: Fix warnings from register.tt
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, martin.renvoize at ptfs-europe.com
            Blocks: 25790

When running the QA tools on register.tt (tt?) there are some warnings we
should fix:

Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
86.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
86.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
87.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
87.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
88.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
158.
Argument "" isn't numeric in multiplication (*) at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
288.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
[Bug 25790] [OMNIBUS] warnings removal
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:06:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:06:13 +0000
Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25790-70-G0cvumteu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31125


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31125
[Bug 31125] Fix warnings from register.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:09:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:09:00 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-aJsLqxYVjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:09:04 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-J3QUQJoOav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137429|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137432&action=edit
Bug 31121: Fix date formatting in cashup summary modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:31:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:31:04 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-5duMoFjLHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 18:31:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 16:31:08 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-3v4Hsrbtob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137240|0                           |1
        is obsolete|                            |

--- Comment #4 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137433&action=edit
Bug 31104: Put each link on a separate header

This patch makes the Pagination helper put each Link entry on the
response headers on a separate header. In practice, this leads to
shorter headers and will avoid apache default/reasonable limits.

To test:
1. Open the patron search page
2. Open the koha logs:
   $ tail -f /var/log/koha/kohadev/*.log
3. On the 'Search for patron' input, use a really long string, like
   'superlongstringthatistoolongforapacheyeahsuperlong'
=> SUCCESS: There's no user with an attribute with that content :-D
=> FAIL: You get an error like (28)No space left on device: [client
127.0.0.1:60330] AH10124: header size is over the limit allowed by
ResponseFieldSize (8192 bytes). Bad response header: 'Link:...'
4. Apply this patch
5. Restart all:
   $ restart_all
6. Repeat 2 and 3
=> SUCCESS: No results
=> SUCCESS: No error in the logs
7. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Pagination.t \
           t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!

Note 1: The Link header is expected to be in CSV format, which is
usually the way libraries treat repeated headers anyway.

Note 2: Apache is not rejecting the response, just stripping out the
'bad header'. So this is not a critical issue.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:04:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:04:33 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-1sB1E2iGFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> Please provide feedback for this change:
> 
> -                        <xsl:attribute
> name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:(<xsl:value-of
> select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:
> subfield[@code='a'], '/', ''), true())"/>)</xsl:attribute>
> 
> +                        <xsl:attribute
> name="href">/cgi-bin/koha/catalogue/search.pl?q=<xsl:value-of
> select="str:encode-uri($title_query, true())"/></xsl:attribute>
> 
> You remove translate ?
> 
> Similar example:
> -                                <xsl:attribute
> name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of
> select="str:encode-uri(translate(marc:subfield[@code='t'], '()', ''),
> true())"/><xsl:if test="marc:subfield[@code='a']">+AND+au:<xsl:value-of
> select="str:encode-uri(translate(marc:subfield[@code='a'], '()', ''),
> true())"/></xsl:if></xsl:attribute>

I traced the introduction of this translate to Katrina, bug 5959 [1] and bug
4506 [2] repectively. I'm pretty sure what I did correct. If you look at the
history of the MARC21slim2intranetDetail.xsl file, you will notice we slowly
removed (, ) and / as things exploded in different scenarios and last thing we
did was wrapping in parenthesis. Quoting the string and escaping double quotes
in it is the sensible next step :-D

[1] c0ca9f3413d4c069565595919eced6ddf02e8f96
[2] d3605d9ae8d31953df1aed6c04631a578b690fcd

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:15 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-29tWuAKbOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:18 +0000
Subject: [Koha-bugs] [Bug 29050] Add punctuation in Unseen Renewals message
In-Reply-To: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29050-70-C05mFA9Y5U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:21 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-naX2FS5QX6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:23 +0000
Subject: [Koha-bugs] [Bug 30764] Terminology: Cancelled reserve
In-Reply-To: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30764-70-IXnffaziKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30764

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:26 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-2zI96Ru25r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:28 +0000
Subject: [Koha-bugs] [Bug 30770] Terminology: Lost reserve
In-Reply-To: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30770-70-PpYATEULOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30770

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:30 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-SMGBUweocU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:33 +0000
Subject: [Koha-bugs] [Bug 30773] Standardize spelling i-tive / Itiva
In-Reply-To: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30773-70-rhcVupP7pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30773

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:35 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-dKvvwfbfql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:37 +0000
Subject: [Koha-bugs] [Bug 31038] Amounts in cashup summary modal no longer
 properly formatted
In-Reply-To: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31038-70-ssHnq9WTw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:40 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-Qcu6soxpzX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:15:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:15:42 +0000
Subject: [Koha-bugs] [Bug 31122] Terminology: Replace & with and for Notices
 & slips
In-Reply-To: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31122-70-VYRL45uRwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31122

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:18 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-uDfinMSwCb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:20 +0000
Subject: [Koha-bugs] [Bug 30762] Terminology: Go to Staff client
In-Reply-To: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30762-70-1VxWRvyxY5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30762

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:22 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-XPevndxw18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:25 +0000
Subject: [Koha-bugs] [Bug 30763] Typo: Barcode proceeds bibliographic data
In-Reply-To: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30763-70-IOWAY09d8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30763

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:27 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-bTvBRSH9rm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:29 +0000
Subject: [Koha-bugs] [Bug 30766] Typo: Cannot cancel receipt. Possible
 reasons :
In-Reply-To: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30766-70-TUnPy27rV1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30766

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:32 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-v2N6zvygUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:34 +0000
Subject: [Koha-bugs] [Bug 30767] Terminology: Do not forget that the issue
 has not been checked in yet.
In-Reply-To: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30767-70-mCKJX3svKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30767

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:36 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-eSJ7vbQ7Q5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:39 +0000
Subject: [Koha-bugs] [Bug 30784] Rephrase OPACMandatoryHoldDates slightly
In-Reply-To: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30784-70-cokWVngNlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30784

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:41 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-RORLeWOHun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:44 +0000
Subject: [Koha-bugs] [Bug 31117] Cloning standard circulation rules for all
 libraries show up as from '*'
In-Reply-To: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31117-70-I8geCvN13h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31117

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:26:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:26:56 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-fm12FbiY8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com
                   |                            |, shi-yao.wang at inLibro.com

--- Comment #46 from Blou <philippe.blouin at inlibro.com> ---
Any followup on this ?

Our master doesn't work, we can't rebuild the mappings anymore.

We get an exception (and the printing of the message fails as well, since args 
   is empty.  A dumping gets us the variable 'text' at least, that states

Unknown param (include_type_name) in (put_mapping) request.

This is on Ubuntu 20.04, but it would happen everywhere (we use Debian 10 just
about everywhere in production).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:11 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-vj78WcW1OB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Pushed to master

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:36 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-eieWsqXWQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:38 +0000
Subject: [Koha-bugs] [Bug 29051] Seen renewal methods incorrectly blocked
In-Reply-To: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29051-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29051-70-GN6jsRermK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:41 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-T4MQelDYz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:44 +0000
Subject: [Koha-bugs] [Bug 29951] Cannot add splitting rule to classification
 sources
In-Reply-To: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29951-70-4ljTAU03ET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29951

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:46 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-Zw5pE7IWk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:35:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:35:49 +0000
Subject: [Koha-bugs] [Bug 30911] Datatables error on course-details.pl after
 adding a bib-level course reserve
In-Reply-To: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30911-70-5YKMzmI136@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:42:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:42:18 +0000
Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to
 slips and notices
In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19966-70-m7U6x1ZozS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:42:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:42:56 +0000
Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to
 slips and notices
In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19966-70-V95Tgeialj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:42:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:42:59 +0000
Subject: [Koha-bugs] [Bug 19966] Add ability to pass objects directly to
 slips and notices
In-Reply-To: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19966-70-vHuJwR0Vw2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:50:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:50:11 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-Jo0aFqzXPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:50:14 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-Jkr59eoCBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:52:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:52:05 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-n4OGTuxJIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Sorry, please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:53:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:53:08 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-WOViqVC0iX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:53:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:53:12 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-gkhZwY6zFk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130516|0                           |1
        is obsolete|                            |
 Attachment #132949|0                           |1
        is obsolete|                            |

--- Comment #30 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137434&action=edit
Bug 12029: Patrons should be able to delete their patron messages

This patch adds an option for patrons to dismiss OPAC messages sent to
them by the staff. The messages remain visible in the staff interface
with an indication that the message has been read.

To test, apply the patch and run the database update.

- View a patron record in the staff interface.
- Click "Add message" and select "OPAC" from the "Add a message for..."
  dropdown.
- Add a message.

- Log in to the OPAC as that patron.
- On the "Your summary" page you should see the message along with a
  "Dismiss" link."
- Clicking the "Dismiss" link should make the message disappear.
- Go to the OPAC home page. The "User summary" box in the right sidebar
  should have the correct count of messages.

- View the patron record in the staff interface again.
- The list of patron messages should still include the message which was
  dismissed via the OPAC, but there should be indication that the
  message was read, e.g. "read 11-2-2022"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:53:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:53:16 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-OgdDGciCp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #31 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137435&action=edit
Bug 12029: (follow-up) Adhering to coding guidelines

This is a follow-up patch which (based on comment #19) does
the following:

1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:56:21 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-ItztoNrTo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ivan.marquez at autoparallel.c |oleonard at myacpl.org
                   |om                          |

--- Comment #32 from Owen Leonard <oleonard at myacpl.org> ---
FYI I've changed the assignment to myself because Autoparallel had no interest
in participating in the Bugzilla process. I've attached the last version of
their patch and what I think is a mangled version of Hayley's followup.
Everything seems to work correctly but I'm going to be cautious by asking for
new signoffs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 20:58:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 18:58:50 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-qOLiJ2lTHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Marcel de Rooy from comment #9)
> Argument "" isn't numeric in multiplication (*) at
> /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line
> 86.
...

What is the purpose of this comment?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 21:32:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 19:32:41 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-ELyJRo6OTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 21:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 19:32:44 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-9oDoer7drP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #540 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 22:25:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 20:25:24 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-MATL18dymg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #33 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Tested on sandbox - Failed when creating a message: 

Error trace
Template process failed: undef error - The method
Koha::Patron::Message->patron_read_date is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Patron::Message=HASH(0x55c6e0dc8e60)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 223
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 223
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 243
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
line 18
Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x55c6e0c5ada0)',
'Template::Context=HASH(0x55c6ddb6d958)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)',
'patron_messages.inc', undef, 'localize me!') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 409
Template::Context::include('Template::Context=HASH(0x55c6ddb6d958)',
'patron_messages.inc') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 810
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
line 18
Template::Provider::__ANON__('Template::Context=HASH(0x55c6ddb6d958)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x55c6e1361ad0)',
'Template::Context=HASH(0x55c6ddb6d958)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x55c6ddb6d958)',
'Template::Document=HASH(0x55c6e1361ad0)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 91
Template::Service::process('Template::Service=HASH(0x55c6e0c4a660)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt',
'HASH(0x55c6e0d30130)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.32/Template.pm line 66
Template::process('Template=HASH(0x55c6dd8a77f8)',
'/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt',
'HASH(0x55c6e0d30130)', 'SCALAR(0x55c6da300c50)') called at
/kohadevbox/koha/C4/Templates.pm line 127
C4::Templates::output('C4::Templates=HASH(0x55c6e0d89578)') called at
/kohadevbox/koha/circ/circulation.pl line 636
eval {...} at /kohadevbox/koha/circ/circulation.pl line 2
CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::__ANON__('CGI::Compile=HASH(0x55c6ddb71328)',
'', '/kohadevbox/koha/circ/circulation.pl', '/kohadevbox/koha/circ',
'ARRAY(0x55c6e0e46b48)') called at /usr/share/perl5/CGI/Compile.pm line 151
CGI::Compile::ROOT::kohadevbox_koha_circ_circulation_2epl::circulation_2epl at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 30
CGI::Emulate::PSGI::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/App/WrapCGI.pm line 95
Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55c6e0db51f0)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/App/CGIBin.pm line 50
Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55c6d6269cf8)',
'HASH(0x55c6dd8d05a8)', '/kohadevbox/koha/circ/circulation.pl') called at
/usr/share/perl5/Plack/App/File.pm line 34
Plack::App::File::call('Plack::App::CGIBin=HASH(0x55c6d6269cf8)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/LogWarn.pm line 22
Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55c6dd8f9030)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/Log4perl.pm line 30
Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55c6dd8f92d0)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20
Plack::Middleware::HTTPExceptions::try {...}  at /usr/share/perl5/Try/Tiny.pm
line 100
eval {...} at /usr/share/perl5/Try/Tiny.pm line 93
Try::Tiny::try('CODE(0x55c6e0e89608)', 'Try::Tiny::Catch=REF(0x55c6dd95a858)')
called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23
Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x55c6dd8f9438)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15
Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x55c6dd8c9830)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/usr/share/perl5/Plack/App/URLMap.pm line 71
Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x55c6dd933228)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/kohadevbox/koha/Koha/Middleware/RealIP.pm line 64
Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x55c6dd8f8d78)',
'HASH(0x55c6dd8d05a8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8d05a8)') called at
/kohadevbox/koha/Koha/Middleware/SetEnv.pm line 105
Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x55c6dd8e4920)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Middleware/Static.pm line 18
Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x55c6dd8c9938)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68
Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x55c6dd590130)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Middleware/Lint.pm line 24
Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x55c6d6269c20)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Middleware/StackTrace.pm line 38
Plack::Middleware::StackTrace::try {...}  at /usr/share/perl5/Try/Tiny.pm line
100
eval {...} at /usr/share/perl5/Try/Tiny.pm line 93
Try::Tiny::try('CODE(0x55c6e09635e0)', 'Try::Tiny::Catch=REF(0x55c6e14df6d0)')
called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42
Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x55c6dc7962a0)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Middleware/AccessLog.pm line 27
Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x55c6dc795580)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Plack/Component.pm line 50
Plack::Component::__ANON__('HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Plack/Util.pm line 145
eval {...} at /usr/share/perl5/Plack/Util.pm line 145
Plack::Util::run_app('CODE(0x55c6dc795460)', 'HASH(0x55c6dd8ed0e8)') called at
/usr/share/perl5/Starman/Server.pm line 195
Starman::Server::dispatch_request('Starman::Server=HASH(0x55c6d5c86e50)',
'HASH(0x55c6dd8ed0e8)') called at /usr/share/perl5/Starman/Server.pm line 298
Starman::Server::process_request('Starman::Server=HASH(0x55c6d5c86e50)',
'Net::Server::Proto::UNIX=GLOB(0x55c6dda3e8a0)') called at
/usr/share/perl5/Net/Server.pm line 72
Net::Server::run_client_connection('Starman::Server=HASH(0x55c6d5c86e50)')
called at /usr/share/perl5/Net/Server/PreFork.pm line 225
eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225
Net::Server::PreFork::run_child('Starman::Server=HASH(0x55c6d5c86e50)') called
at /usr/share/perl5/Net/Server/PreFork.pm line 183
Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x55c6d5c86e50)', 2)
called at /usr/share/perl5/Net/Server/PreFork.pm line 107
Net::Server::PreFork::loop('Starman::Server=HASH(0x55c6d5c86e50)') called at
/usr/share/perl5/Net/Server.pm line 58
Net::Server::run('Starman::Server=HASH(0x55c6d5c86e50)', 'port',
'ARRAY(0x55c6d62147c0)', 'host', '*', 'proto', 'tcp', 'serialize', 'none',
'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1,
'max_servers', 2, 'max_requests', 50, 'user', 'bug12029-koha', 'group',
'bug12029-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1,
'setsid', 1, 'log_file', '/var/log/koha/bug12029/plack-error.log',
'background', 1, 'pid_file', '/var/run/koha/bug12029/plack.pid') called at
/usr/share/perl5/Starman/Server.pm line 106
Starman::Server::run('Starman::Server=HASH(0x55c6d5c86e50)',
'CODE(0x55c6d5c86d00)', 'HASH(0x55c6d5c86aa8)') called at
/usr/share/perl5/Plack/Handler/Starman.pm line 25
Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x55c6d5c86d18)',
'CODE(0x55c6d5c86d00)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line
20
Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x55c6d59d8428)',
'Plack::Handler::Starman=HASH(0x55c6d5c86d18)') called at
/usr/share/perl5/Plack/Runner.pm line 279
Plack::Runner::run('Plack::Runner=HASH(0x55c6d5971760)') called at
/usr/bin/starman line 38
 at /kohadevbox/koha/C4/Templates.pm line 127

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 22:36:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 20:36:14 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-YZSSQvKwoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |frank.hansen at ub.lu.se
                   |ity.org                     |
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 22:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 20:41:15 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-TGehBpnGKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |matted-34813 at mypacks.net

--- Comment #19 from wajasu <matted-34813 at mypacks.net> ---
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135584
This patch remove the popup that has the "Are you sure you want to delete this
message? This cannot be undone." english text. But I think they wanted it
translated to french.
Adding it to: fr-CA-messages-js.po
Some message id coded to use some method/tool(template tooklit?) to help lookup
the translation when french is selected.

DavidNind mentioned in IRC:
translations are done at translate.koha-community.org, and will picked up at
release time
16:11 < davidnind[m]>
https://wiki.koha-community.org/wiki/Release_maintenance#Push_updated_translation_files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:05:18 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-Astaz4Ux8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136657|0                           |1
        is obsolete|                            |

--- Comment #88 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137436&action=edit
Bug 27113: ElasticSearch: Autocomplete in input search

Usually the user knows only part of the title of the book or only the name of
the author, etc. When he start search something Koha (ElasticSearch) predicts
the rest of a word or expression which user is typing.  Autocomplete predicts
that thanks to index of ElasticSearch.

TEST PLAN
Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
must have all information in his index.
1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
!! APPLY PATCH !!
2. Mapping is good (Intranet -> Catalog -> Search engine configuration
(Elasticsearch) ).
!Recommended 'Reset Mapping'  -> 'Yes'
3. In your koha-conf.xml file you must have good <index_name> for
<elasticsearch> and version ES
4. Update Preference:
./installer/data/mysql/updatedatabase.pl
If that passe good you can look the lines:
 - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
 - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
elasticsearch
5. After that we can look two options in the preferences:
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
4. For add information in the index we must run script for reindexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d
5. Waiting for the end of indexing
6. Go on Preference and find :
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
Value "Show" turn on autocomplete.
7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
also).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:05:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:05:28 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-xMcvp2sd1M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136658|0                           |1
        is obsolete|                            |

--- Comment #89 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137437&action=edit
Bug 27113: (follow-up) Move new CSS to main SCSS files

This patch removes the separate CSS files added for the autocomplete
feature and puts them into the "main" SCSS files. I think a separate
file isn't necessary because the amount of CSS it adds is so small.

I've also tweaked the style of the autocomplete menu shown when you use
the arrow keys to navigate through the autocomplete choices. I think the
previous white-on-light-green didn't have enough contrast.

To test you must rebuild the OPAC and staff client CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Follow the previous test plan, being careful to observe how it
works when the autocomplete menu has been triggered and you use the
arrow keys to navigate through the results.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:05:35 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-0SjaZV1bpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136659|0                           |1
        is obsolete|                            |

--- Comment #90 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137438&action=edit
Bug 27113: (follow-up) Update descriptions for system preferences

Update the descriptions for the new system preferences -
IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch.

Test plan:
1. Review the descriptions for the IntranetAutocompleteElasticSearch
   and OPACAutocompleteElasticSearch system preferences.
2. Make sure they are readable and make sense.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:05:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:05:40 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-JvscgsMqnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136660|0                           |1
        is obsolete|                            |

--- Comment #91 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137439&action=edit
Bug 27113: (follow-up) fix adv. searches - more options display issue

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:10:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:10:17 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-zNiNStGUwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #92 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Fixed an encoding/display problem when using "é", "ù", etc.

(In reply to Fridolin Somers from comment #87)
> You can with REST API.
> Public routes are same file between OPAC and staff :
> https://wiki.koha-community.org/wiki/REST_api_RFCs#Unprivileged_.28public.
> 29_routes

I don't know how to do it, but I think it would be a good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:30:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:30:14 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-h5G9fm46zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

--- Comment #20 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
(In reply to wajasu from comment #19)
> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135584
> This patch remove the popup that has the "Are you sure you want to delete
> this message? This cannot be undone." english text. But I think they wanted
> it translated to french.
> Adding it to: fr-CA-messages-js.po
> Some message id coded to use some method/tool(template tooklit?) to help
> lookup the translation when french is selected.
> 
> DavidNind mentioned in IRC:
> translations are done at translate.koha-community.org, and will picked up at
> release time
> 16:11 < davidnind[m]>
> https://wiki.koha-community.org/wiki/
> Release_maintenance#Push_updated_translation_files

This patch does not remove the popup, it moves it from
koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc to
koha-tmpl/intranet-tmpl/prog/js/members-menu.js so it can be translated using
translations written in misc/translator/po/fr-CA-messages-js.po

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:33:35 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-G22gZTchnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:35:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:35:04 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-24PyT1BZWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:52:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:52:44 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-oWPVjjxSVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #16 from David Nind <david at davidnind.com> ---
Hi Frank.

I am getting an error message when resetting the mappings after the patch is
applied (step 5 of the test plan) - this worked without error before the patch
was applied:

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Data truncated for column 'marc_type' at row 1 at
/kohadevbox/koha/Koha/Objects.pm line 114
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77

       74:     my $self = { msg => $msg };
       75:     bless $self => $class;
       76: 
       77:     die $self;
       78: }
       79: 
       80: =head2 rethrow

   .....

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul  8 23:56:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 21:56:04 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-wwlZC20zAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #17 from David Nind <david at davidnind.com> ---
Created attachment 137440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137440&action=edit
Screenshot - Example record before patch applied (subject terms have links)

Testing notes so far (using koha-testing-docker):

1. Enable Elasticsearch as the search engine and reindex (koha-elasticsearch
--rebuild -d -b -a kohadev)

2. For step 1: misc/migration_tools/bulkmarcimport.pl -v -a -file
authorities.mrc -insert -c=MARC21

3. For step 2: misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc
-insert -c=MARC21

4. For step 4, subject terms have search links (see attached screenshot) -
search query example for one of the links
http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:%22Feminism%22

5. For step 5, I get the error message in comment #16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 00:10:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 22:10:23 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-VgKi59Vy4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #541 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137441&action=edit
Bug 24857: (QA follow-up) Make update idempotent

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 00:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 22:11:58 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-icRSQJB5vb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #542 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137442&action=edit
Bug 24857: Fix missing additionalProperties in spec

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 00:55:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 22:55:49 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-Qg10erkPLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

--- Comment #21 from David Nind <david at davidnind.com> ---
With the latest patch: when you go to delete the message, the popup doesn't
appear (no message and buttons) and the message is deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 01:07:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 23:07:07 +0000
Subject: [Koha-bugs] [Bug 31126] New: Add ability to transfer multiple order
 lines
Message-ID: <bug-31126-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31126

            Bug ID: 31126
           Summary: Add ability to transfer multiple order lines
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be helpful to have the ability to transfer multiple items from one
basket to another in Acquisitions.  

For instance, if I need to move several items to another vendor, or to another
basket, the process currently has to be done line by line.  It would be useful
to have check boxes to select several items at once and transfer them to
another vendor/basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 01:27:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 23:27:51 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-ZH3mzpg5VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'll rebase on Monday, and take a look at the highlighted warnings at the same
time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 01:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 23:29:50 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-REJWvf82oO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #543 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137443&action=edit
Bug 24857: Remove incorrect object_class method

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 01:42:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Jul 2022 23:42:43 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-odtc6pvThO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #101 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Let's keep the comments constructive please.

I'm sure there will be lots of follow-ups and fixes but let's remember lots of
work has already happened and is good.  Now it's time for us to all help polish
and fix inevitable issues that may have crept in. 🙂

On that front, I wonder if it might be helpful to have a shared branch to work
on together for the final submission?  Perhaps a merge-request flow for fixes
managed by Solene (with a little help from Julian or someone else)

There are coders here happy to help guide this through.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 05:42:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 03:42:49 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-CQ2z2Q6bRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #3 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137444&action=edit
Bug 31069: fix <span> in OPAC search suggestions (Did you mean)

== test plan ==
1. Enable "Did you mean?":
   . go to Administration > Additional parameters > Did you mean?
   . put a tick in each plugin and save the configuration
2. In the OPAC, search for 'open source'
3. Without the patch you see escaped <span> after "Did you mean:"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 05:43:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 03:43:35 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-LKJeWnKOTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30629

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Same fix as bug 30629

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 05:43:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 03:43:35 +0000
Subject: [Koha-bugs] [Bug 30629] <span> in title of patron card creator
 template needs to be removed
In-Reply-To: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30629-70-q1iq98NL1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30629

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31069

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 07:09:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 05:09:01 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-RL6TR0NMOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135751|0                           |1
        is obsolete|                            |

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137445&action=edit
Bug 30882: Add max_result_window to index config

Elasticsearch number of results is by default limited by setting
"index.max-result-window", default value is 10000.
https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules.html#index-max-result-window

We use this setting:
https://git.koha-community.org/Koha-community/Koha/src/commit/44d6528b566e5c16eba9b15f8aa24667293766c3/Koha/SearchEngine/Elasticsearch/Search.pm#L411

I propose we add this setting in index config.

Test plan:
1) Use Elasticsearch
2) Apply patch and flush memcached
3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -b -d
4) Check the settings of index (when using koha-testing-docker*):
   curl
'es:9200/koha_kohadev_biblios/_settings?pretty&filter_path=**.max_result_window'
5) You should see:
   "max_result_window" : "1000000"

* You also need to add this setting to the es section in koha-testing-docker's
docker-compose.yml (after the networks configuration):
     ports:
         - "9200:9300"

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 07:12:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 05:12:14 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-hpJadYuLol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |victor at tuxayo.net
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Passed QA

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I don't know what value should we have so I'm following Fridolin and Marcel ^^
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:19:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:19:17 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-M83xMKqaZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:46:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:46:06 +0000
Subject: [Koha-bugs] [Bug 31127] New: By default sort suggestions from
 latest to oldest
Message-ID: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

            Bug ID: 31127
           Summary: By default sort suggestions from latest to oldest
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Currently suggestions table is sorted from oldest to latest.

>From suggestion.tt :
  KohaTable("table_[% loop.count| html %]", {
      "sorting": [[ 3, "asc" ]],

Since the default tab is pending suggestions, it would be better to have the
reverse order.
Some old suggestions may stay in pending for a while and librarian must be
aware of new suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:46:18 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-eXpWhoYLus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:47:23 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-ASqOJd1P1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27813

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:47:23 +0000
Subject: [Koha-bugs] [Bug 27813] Purchase suggestions should sort by
 suggesteddate rather than title
In-Reply-To: <bug-27813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27813-70-S0m6kVolEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27813

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31127

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 09:47:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 07:47:41 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-108NzenYKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
If OK I'll provide a patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 11:24:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 09:24:44 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-IZcjW2nBRN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 11:24:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 09:24:48 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-QOVZjiNdau@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137444|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137446&action=edit
Bug 31069: fix <span> in OPAC search suggestions (Did you mean)

== test plan ==
1. Enable "Did you mean?":
   . go to Administration > Additional parameters > Did you mean?
   . put a tick in each plugin and save the configuration
2. In the OPAC, search for 'open source'
3. Without the patch you see escaped <span> after "Did you mean:"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 11:32:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 09:32:53 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-VCebeXPZRN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This removes <span> tags
      release notes|                            |incorrectly appearing
                   |                            |around the options
                   |                            |available when 'Did you
                   |                            |mean?' is enabled (for
                   |                            |example, 'Search also for
                   |                            |related subjects').

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 11:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 09:42:39 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-r8T9FzTQfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This removes <span> tags    |This removes <span> tags
      release notes|incorrectly appearing       |incorrectly displayed
                   |around the options          |around the links for
                   |available when 'Did you     |options available when 'Did
                   |mean?' is enabled (for      |you mean?' is enabled (for
                   |example, 'Search also for   |example, 'Search also for
                   |related subjects').         |related subjects').

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 17:30:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 15:30:23 +0000
Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks
 queue daemon, so koha-create for same <instance> user fails
In-Reply-To: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31124-70-gdisKzcp7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 17:33:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 15:33:27 +0000
Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks
 queue daemon, so koha-create for same <instance> user fails
In-Reply-To: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31124-70-H3hc3MGVcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

wajasu <matted-34813 at mypacks.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |matted-34813 at mypacks.net
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 21:49:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 19:49:21 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-F5jamolp3o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 21:49:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 19:49:24 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-UumncpmVtv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127839|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 137447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137447&action=edit
Bug 27683: Unit test for GetAnalyticsCount

Run prove t/db_dependent/Items/GetAnalyticsCount.t

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 21:49:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 19:49:28 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-Ktlb0HUl5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127840|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 137448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137448&action=edit
Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref

C4::Items::GetAnalyticsCount is part of the easy analytics feature.
Like Bug 20702 make early return when the system preference
EasyAnalyticalRecords is disabled.
Actually it may block an item deletion for wrong reason.

Test plan :
1) Dont apply patch
2) Build an item and a linked analytical record with 773$0 and $9
3) Enable EasyAnalyticalRecords
4) Try to delete the item
5) You have an alert because linked to analytics
6) Disable EasyAnalyticalRecords
7) Try to delete the item
8) You have an alert because linked to analytics
9) Apply patch
10) Try to delete the item
11) No alert, it works :D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 21:49:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 19:49:32 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-UymmXiKxjw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127841|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 137449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137449&action=edit
Bug 27683: Impact on catalogue/detail.pl

Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove
test in catalogue/detail.pl.

Test plan :
1) Build an item and a linked analytical record with 773$0 and $9
2) Go to record detail page
3) Enable EasyAnalyticalRecords
4) You see analytics tab and analytical count on item
5) Disable EasyAnalyticalRecords
6) You dont see analytics tab

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 23:39:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 21:39:47 +0000
Subject: [Koha-bugs] [Bug 29606] Include items from host record in XML for
 XSLT processing
In-Reply-To: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29606-70-qg5ZZOb9IK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 23:39:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 21:39:52 +0000
Subject: [Koha-bugs] [Bug 29606] Include items from host record in XML for
 XSLT processing
In-Reply-To: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29606-70-GuUgKfU7ZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128118|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137450&action=edit
Bug 29606: Include items from host record in XML for XSLT processing

If EasyAnalyticalRecords is enabled, items from host records should be
included in the XML. Otherwise, OPAC search results show no items.

Test plan:
0. Do not apply the patch yet
1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay
   to 'default'
2. Create a biblio record with title "parent" and create an item with a
   barcode for this biblio
3. Create a biblio record with title "child" with no items. On the
   biblio detail page, in the toolbar, click "Edit -> Link to host
   record" and enter the barcode for the item you created at step 2
4. Duplicate this biblio record, to be sure you will have at least two
   results with the search "child" (and not be redirected to the detail
   page)
5. Make sure your search index (zebra or elasticsearch) is up to date
6. Go to OPAC and search "child".
   You should see two results, no items.
   Click on one of them. On the detail page you should see one item (the
   one from the host record)
7. Apply the patch
8. Go to OPAC and search "child".
   You should now see one item (the same item) for each result.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul  9 23:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 21:49:17 +0000
Subject: [Koha-bugs] [Bug 30016] Remove GetOpenIssue subroutine
In-Reply-To: <bug-30016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30016-70-3e0sLjls0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30016

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #6 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Applying: Bug 30016: Remove GetOpenIssue subroutine
Using index info to reconstruct a base tree...
M       C4/Circulation.pm
M       offline_circ/process_koc.pl
M       t/db_dependent/Circulation/issue.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Circulation/issue.t
CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t
Auto-merging offline_circ/process_koc.pl
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 30016: Remove GetOpenIssue subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:05:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:05:00 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-Xq5PrfBMtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #8 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29102: Unit tests
Using index info to reconstruct a base tree...
M       t/db_dependent/DecreaseLoanHighHolds.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/DecreaseLoanHighHolds.t
Applying: Bug 29102: Do not count patron's own hold against limits
Using index info to reconstruct a base tree...
M       C4/Circulation.pm
M       t/db_dependent/DecreaseLoanHighHolds.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/DecreaseLoanHighHolds.t
CONFLICT (content): Merge conflict in t/db_dependent/DecreaseLoanHighHolds.t
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29102: Do not count patron's own hold against limits

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:05:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:05:17 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-ujUZuDabMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:08 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-y2ZMOTIFNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:13 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-eRaTwQaJyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132275|0                           |1
        is obsolete|                            |

--- Comment #17 from David Nind <david at davidnind.com> ---
Created attachment 137451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137451&action=edit
Bug 30358: Strip leading/trailing whitespace characters from input fields when
cataloguing

This enhancement adds a system preference StripWhitespaceChars which,
when enabled, will strip leading and trailing whitespace characters from
all fields when cataloguing both bibliographic records and authority
records. Whitespace characters that will be stripped are:
- spaces
- newlines
- carriage returns
- tabs

To test:
1. Apply patch and install database updates
2. Go to Administration, system preferences, find the new
StripWhitespaceChars preference. It should be "Don't strip" by default.
Change it to "Strip".
3. Search for a biblio record and edit it. Put some leading or trailing
whitespace characters in input fields and textarea fields and save.
4. Confirm these characters are removed when you save the record.
5. Repeat steps 3 and 4 for authority records.
6. Confirm tests pass t/db_dependent/Biblio/ModBiblioMarc.t

Sponsored-by: Educational Services Australia SCIS

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:18 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-mlHMq4bMUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132919|0                           |1
        is obsolete|                            |

--- Comment #18 from David Nind <david at davidnind.com> ---
Created attachment 137452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137452&action=edit
Bug 30358: (follow-up) Also strip inner newlines

This patch amends the StripWhitespaceChars system preference to also
strip inner newlines (line breaks and carriage returns) when enabled.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:23 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-2p6pwZhELE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133055|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 137453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137453&action=edit
Bug 30358: (follow-up) Inner newlines should be replaced with a space

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:27 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-lieCaUXPu2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133224|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <david at davidnind.com> ---
Created attachment 137454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137454&action=edit
Bug 30358: (follow-up) Fixing tests and including for inner newlines

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:31 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-TaHhLai5fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133225|0                           |1
        is obsolete|                            |

--- Comment #21 from David Nind <david at davidnind.com> ---
Created attachment 137455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137455&action=edit
Bug 30358: (follow-up) Clarify syspref wording about fields affected

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:36 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-wo13yqCDhT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134195|0                           |1
        is obsolete|                            |

--- Comment #22 from David Nind <david at davidnind.com> ---
Created attachment 137456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137456&action=edit
Bug 30358: (follow-up) Consider field has multiple subfields of same key

To test:

1) Click the clone subfield button to make multiple subfields with the
same key, i.e. 500$a$a$a
2) Save the record and confirm that the fields contain the correct data
after whitespaces are stripped.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:29:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:29:40 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-UVmHFM805a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134453|0                           |1
        is obsolete|                            |

--- Comment #23 from David Nind <david at davidnind.com> ---
Created attachment 137457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137457&action=edit
Bug 30358: (follow-up) Put multiple subfields fix on auth side

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 00:36:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 22:36:10 +0000
Subject: [Koha-bugs] [Bug 30930] Ability to change authority type while
 editing record
In-Reply-To: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30930-70-YizC6uNduJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from David Nind <david at davidnind.com> ---
Patch no longer applies 8-(..

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 30930: Ability to change auth type while editing record
Using index info to reconstruct a base tree...
M       authorities/authorities.pl
Falling back to patching base and 3-way merge...
Auto-merging authorities/authorities.pl
CONFLICT (content): Merge conflict in authorities/authorities.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 30930: Ability to change auth type while editing
record

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 01:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 23:19:30 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-mJHxfcV5ca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |victor at tuxayo.net
                 CC|                            |victor at tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> [% index.missing_count | html %] record(s) missing on a total of [% index.index_count | html %] in indice [% index.index_name | html %].

Any reason to use indice instead of index? IIUC, only the plural form is used,
for the singular, it's index.

Otherwise, all looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 01:19:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Jul 2022 23:19:55 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-1u083EzI4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136565|0                           |1
        is obsolete|                            |

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137458&action=edit
Bug 27667: Display a warning for records missing in Elasticsearch

On "About Koha" page are displayed the numbers of indexed biblios and
authorities with ES.
It could be great if we could have comparison with the number of records in the
database to display the number of missing records.
In the "System information" tab with the other "Data problems".

If Searchengine has any issue (index count will be -1), we do not
display missing records.

Test plan :
1) Use Elasticsearch searchengine
2) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
3) Go to "About Koha" page and look at System information tab
=> you see no warning
4) On a biblio record delete the MARCXML in biblio_metadata.metadata
5) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
6) Go to "About Koha" page and look at System information tab
=> you see warning : 1 record(s) missing on a total of 435 in indice
koha_kohadev_biblios.
7) On a authority record delete the MARCXML in auth_header.marcxml
8) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
9) Go to "About Koha" page and look at System information tab
=> you see warning : 1 record(s) missing on a total of 1705 in indice
koha_kohadev_authorities.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 03:14:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 01:14:45 +0000
Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a
 later version
In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23073-70-hWMYZYNKV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #30 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Thomas Dukleth from comment #27)
> The intent of adding an automatic exclusion for obsolete pages from the
> simple search box with -"[[Category:Obsolete]]" is for the simplest searches
> to exclude old obsolete pages so as not to confuse users or be found
> inappropriately in the most basic search result set.  Old obsolete content
> pages can still be found using the advanced search including found
> explicitly by searching for "[[Category:Obsolete]]" without the exclusion
> operator prefix and thus acts as an archive for such content.
> 
> Old obsolete pages are noted with a prominent notice via a template if they
> are encountered.  Such pages should be updated if they can be, but are
> otherwise available to consult most importantly for valuable information
> they often contain which is not yet present in current pages.

Ok it's just a bonus feature set up on the same occasion as the upgrade, not
related to it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 04:30:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 02:30:52 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-sGRkFlaMyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 04:32:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 02:32:08 +0000
Subject: [Koha-bugs] [Bug 30358] Strip leading/trailing whitespace
 characters from input fields when cataloguing
In-Reply-To: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30358-70-0CujIpUPnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30358

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 04:33:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 02:33:03 +0000
Subject: [Koha-bugs] [Bug 29606] Include items from host record in XML for
 XSLT processing
In-Reply-To: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29606-70-SjrEYEy4Ff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 21:41:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 19:41:45 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-5dFYFdHiEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 23:10:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 21:10:23 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-OGvOhYcLBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #14)
> I'll rebase on Monday, and take a look at the highlighted warnings at the
> same time.

I filed the warnings already when looking at one of the other cash register
patches: 
Bug 31125 - Fix warnings from register.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 23:30:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 21:30:33 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-crQNRnVR50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137459&action=edit
Bug 31000: Warn removal: param record_type can be undef

Uninitialized value warning on /tools/export.pl when $record_type is undef

Use of uninitialized value $record_type in string eq
at /home/vagrant/kohaclone/tools/export.pl line 43.

This warning in koha-testing-docker appears in:
/var/log/koha/kohadev/intranet-error.log

This patch fixes it by working when $record_type is Undef.
The functionality still remains the same but warning doesn't flood
error log.
To reproduce:
1. Go to export data tool page (/tools/export.pl).
2. Check the error log and find the upper mentioned warning,
check the timestamp to ensure that it was added when you loaded the page.
3. Apply the patch.
4. Load the page again, ensure that the same warning doesn't get added
to the log file again.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 23:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 21:32:25 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-LrjlTG83GJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
 Attachment #136568|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 10 23:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Jul 2022 21:35:51 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-8vdVzdnOoY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         Version(s)|                            |This fixes the cause of an
        released in|                            |error message that appears
                   |                            |in the system logs every
                   |                            |time that Tools > Catalog >
                   |                            |Export data
                   |                            |(/cgi-bin/koha/tools/export
                   |                            |.pl) is accessed. The error
                   |                            |message was "AH01215: Use
                   |                            |of uninitialized value
                   |                            |$record_type in string eq
                   |                            |at /koh
                   |                            |adevbox/koha/tools/export.p
                   |                            |l line 43.:
                   |                            |/kohadevbox/koha/tools/expo
                   |                            |rt.pl,...".
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Removed "HOTFIX" from commit message.

qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 02:51:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 00:51:14 +0000
Subject: [Koha-bugs] [Bug 31124] koha-remove fails to remove long_tasks
 queue daemon, so koha-create for same <instance> user fails
In-Reply-To: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31124-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31124-70-tqjDzM0WWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 02:57:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 00:57:46 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-wMApYgX1q4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 03:02:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 01:02:08 +0000
Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences
 during self registration
In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20859-70-ktRHZQEGbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I do like the sound of that. I might be adding a patch for providing the SMS
alert number. Will see...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 03:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 01:06:30 +0000
Subject: [Koha-bugs] [Bug 16786] Cannot add multiple emails addresses in an
 email field
In-Reply-To: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16786-70-hZrgUqKrO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16786

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
It's an interesting idea, although it could cause SSO problems, if the email
field is a match point. 

Trying to think of other functionality that expects there to be a single value
that can be checked using SQL operations without application-specific logic (ie
breaking apart of the email addresses)...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 05:56:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 03:56:05 +0000
Subject: [Koha-bugs] [Bug 11879] Add a new field to patron record: main
 contact method
In-Reply-To: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11879-70-G3teiJJp26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #210 from David Cook <dcook at prosentient.com.au> ---
It looks like there's no way to set a default for this field...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 08:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 06:32:35 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-n0wCi2Pt9u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137460&action=edit
Bug 31054: Manual importing for EDIFACT invoices fails with a 500 error page

Error in plack log is: Can't locate object method "new" via package
"Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin" (perhaps you
forgot to load "Koha::Plugin::Com::ByWaterSolutions::MyEdifactPlugin"?)
at /usr/share/koha/lib/Koha/EDI.pm line 219.

Test Plan:
1) Set EdifactInvoiceImport to "Don't"
2) Configure an EDI vendor to use an EDIFACT plugin
3) Attempt to import an invoice file
4) You will be shown an error page
5) Apply this patch
6) Restart all the things!
7) Attempt to import another invoice file
8) It works!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 08:32:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 06:32:52 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-qNr65H6E0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136574|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 08:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 06:33:25 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-957rlxSqZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial fix, works as expected with no regressions found..

Going straight for QA.. Passed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 08:33:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 06:33:32 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-2zbCTl6tY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-bxy9AU32Yo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136978|0                           |1
        is obsolete|                            |

--- Comment #405 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137461&action=edit
Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-bFbQXIib8D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136979|0                           |1
        is obsolete|                            |

--- Comment #406 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137462&action=edit
Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:38 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-EqobmThrIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136980|0                           |1
        is obsolete|                            |

--- Comment #407 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137463&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:46 +0000
Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned
 fields/subfields
In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30975-70-xEOA4Wedkv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
> Do we have to modify the framework in order to test this?

Yes, but I'd say it's no big deal if you cannot do these tests on a plugin if
that plugin is always used in a non-repeatable field/subfield.
Testing that the plugin still works in its single field should be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:48 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-YzLD44AYK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136981|0                           |1
        is obsolete|                            |

--- Comment #408 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137464&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:00:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:00:59 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-LbrUQGeIRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136982|0                           |1
        is obsolete|                            |

--- Comment #409 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137465&action=edit
Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:10 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nedP2GgGK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136985|0                           |1
        is obsolete|                            |

--- Comment #410 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137466&action=edit
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:20 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-fFAykHV0dm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136988|0                           |1
        is obsolete|                            |

--- Comment #411 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137467&action=edit
Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:29 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CzJVcs4TyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136989|0                           |1
        is obsolete|                            |

--- Comment #412 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137468&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:38 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-y90FAQ0kjC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136990|0                           |1
        is obsolete|                            |

--- Comment #413 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137469&action=edit
Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:49 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-XN3QCviBNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136991|0                           |1
        is obsolete|                            |

--- Comment #414 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137470&action=edit
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:01:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:01:58 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7H7rDpUarB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136992|0                           |1
        is obsolete|                            |

--- Comment #415 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137471&action=edit
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:08 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-FXtISCTup3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136993|0                           |1
        is obsolete|                            |

--- Comment #416 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137472&action=edit
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-qbhq9PoQVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136994|0                           |1
        is obsolete|                            |

--- Comment #417 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137473&action=edit
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:26 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-E3oFzQ1nt8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136995|0                           |1
        is obsolete|                            |

--- Comment #418 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137474&action=edit
Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:36 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-NrYGRQvSMY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136996|0                           |1
        is obsolete|                            |

--- Comment #419 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137475&action=edit
Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:45 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-4Iy6u6mwrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136997|0                           |1
        is obsolete|                            |

--- Comment #420 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137476&action=edit
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:02:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:02:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kM7bYdBSBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136998|0                           |1
        is obsolete|                            |

--- Comment #421 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137477&action=edit
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:06 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-YgLLs8geys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136999|0                           |1
        is obsolete|                            |

--- Comment #422 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137478&action=edit
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:15 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-cjZvUfIZGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137000|0                           |1
        is obsolete|                            |

--- Comment #423 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137479&action=edit
Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:24 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-x2PcBsX1K2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137001|0                           |1
        is obsolete|                            |

--- Comment #424 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137480&action=edit
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-u46EBchrQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137002|0                           |1
        is obsolete|                            |

--- Comment #425 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137481&action=edit
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:44 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-DWD9vIvXEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137003|0                           |1
        is obsolete|                            |

--- Comment #426 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137482&action=edit
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:03:53 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CnIIiFtrSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137004|0                           |1
        is obsolete|                            |

--- Comment #427 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137483&action=edit
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Bnty30iwO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137005|0                           |1
        is obsolete|                            |

--- Comment #428 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137484&action=edit
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:14 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-AN4sVHzvIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137006|0                           |1
        is obsolete|                            |

--- Comment #429 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137485&action=edit
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-3Hgj8S0Ggy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137007|0                           |1
        is obsolete|                            |

--- Comment #430 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137486&action=edit
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:32 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-uMZvlJpzjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137008|0                           |1
        is obsolete|                            |

--- Comment #431 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137487&action=edit
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:41 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-DHWsxCX8Ch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137009|0                           |1
        is obsolete|                            |

--- Comment #432 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137488&action=edit
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:04:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:04:52 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-jr6WqYGDCt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137010|0                           |1
        is obsolete|                            |

--- Comment #433 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137489&action=edit
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:01 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-YURqvnDYjE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137011|0                           |1
        is obsolete|                            |

--- Comment #434 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137490&action=edit
Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:11 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-oTivycPdGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137012|0                           |1
        is obsolete|                            |

--- Comment #435 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137491&action=edit
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:21 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-scPngNI2rl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137013|0                           |1
        is obsolete|                            |

--- Comment #436 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137492&action=edit
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:31 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-BEtdfxwfOs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137014|0                           |1
        is obsolete|                            |

--- Comment #437 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137493&action=edit
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:40 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-XDLXjgoMKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137015|0                           |1
        is obsolete|                            |

--- Comment #438 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137494&action=edit
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:05:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:05:50 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CCRFu5QvDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137016|0                           |1
        is obsolete|                            |

--- Comment #439 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137495&action=edit
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-yje18F89pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137017|0                           |1
        is obsolete|                            |

--- Comment #440 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137496&action=edit
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:13 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KwuhmSbrVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137018|0                           |1
        is obsolete|                            |

--- Comment #441 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137497&action=edit
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:21 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-LpHup4IdE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137019|0                           |1
        is obsolete|                            |

--- Comment #442 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137498&action=edit
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:30 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-uwdKECgtL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137020|0                           |1
        is obsolete|                            |

--- Comment #443 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137499&action=edit
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:39 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-9UNgyHLeLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137021|0                           |1
        is obsolete|                            |

--- Comment #444 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137500&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:06:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:06:49 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-PrfZBGyB3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137022|0                           |1
        is obsolete|                            |

--- Comment #445 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137501&action=edit
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:08:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:08:03 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-Sf8Eat1n1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

Axelle Aix-Marseille Université <axelle.clarisse at univ-amu.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axelle.clarisse at univ-amu.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:08:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:08:10 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-jHjPrX97OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #446 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Another rebase, now that itemgroups is in.. I was worried these features might
clash more, but the rebase was fairly trivial and they seem to compliment each
other nicely in the UI so far in my testing.

Ready for QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:17:22 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-sB92p0aGCw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to create       |Add ability to create
                   |bundles of items            |bundles of items for
                   |                            |circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:18:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:18:36 +0000
Subject: [Koha-bugs] [Bug 26275] Deleting item should not automatically
 delete group
In-Reply-To: <bug-26275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26275-70-Tyle0dBZwp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
            Summary|Deleting item should not    |Deleting item should not
                   |automatically delete volume |automatically delete group

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:18:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:18:46 +0000
Subject: [Koha-bugs] [Bug 26276] When merging biblios with volumes,
 preserve all groups
In-Reply-To: <bug-26276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26276-70-je2gSU5QiH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26276

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When merging biblios with   |When merging biblios with
                   |volumes, preserve all       |volumes, preserve all
                   |volumes                     |groups
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:19:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:19:01 +0000
Subject: [Koha-bugs] [Bug 26931] Groups tab should show all groups
In-Reply-To: <bug-26931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26931-70-c1d4OvD29h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26931

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
            Summary|Volumes tab should show all |Groups tab should show all
                   |volumes                     |groups

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 09:27:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 07:27:46 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-vZYgAEvMbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #120 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry Kyle.. I'm not seeing tests added or adopted for the C4 module changes..
could you add these please?

Failing QA for now... but this is close :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 10:52:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 08:52:52 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-rjdNw94Jq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Peter Vashchuk <stalkernoid at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stalkernoid at gmail.com
           Assignee|jonathan.druart+koha at gmail. |stalkernoid at gmail.com
                   |com                         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 11:23:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 09:23:06 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-fpdCU0EaFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #121 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've been playing with this a little whilst continuing QA.  Should there be a
way from the OPAC to see what items are in a group when placing a group hold. 
I suppose, the main thoughts behind this is 'the patron doesn't need to know'
and that the group name should be descriptive enough for them to make an
informed choice at hold time?.. or maybe I've missed a bug where exposing the
groups more on the OPAC is done?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 11:54:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 09:54:11 +0000
Subject: [Koha-bugs] [Bug 27870] Add holds table at
 /opac-user.pl#opac-user-holds to Table Settings
In-Reply-To: <bug-27870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27870-70-84qaxLUwty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27870

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 12:00:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 10:00:20 +0000
Subject: [Koha-bugs] [Bug 31102] Add granularity to serials to include
 permissions and visibility to subscriptions by branch
In-Reply-To: <bug-31102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31102-70-4dJV7XZRYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31102

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 12:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 10:09:29 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-Iisfb67Yrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

--- Comment #4 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 137502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137502&action=edit
Bug 30308 - Fix bulkmarcimport.pl broken by
OAI-PMH:AutoUpdateSets(EmbedItemData)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 12:11:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 10:11:09 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-SxBZX2gGZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #5 from Frédéric Demians <frederic at tamil.fr> ---
(In reply to Fridolin Somers from comment #3)
> We should clone MARC::Record in UpdateOAISetsBiblio ?

Yes! It solves the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 13:13:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 11:13:48 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-N6Quj937Va@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 13:17:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 11:17:30 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-I7bkOYXIwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #447 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503&action=edit
Bug 28854: Squashed Patch Set for Reading

Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 13:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 11:18:41 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-mbFATKLj0I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 13:44:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 11:44:45 +0000
Subject: [Koha-bugs] [Bug 27870] Add holds table at
 /opac-user.pl#opac-user-holds to Table Settings
In-Reply-To: <bug-27870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27870-70-0xNBj9VB73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27870

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:05:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:05:47 +0000
Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content
 warnings' to catalogue records
In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31123-70-y8pZvKo7u0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:05:51 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-SdrJuCoxnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:11:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:11:14 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-HvIbQ2umJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125251|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137504&action=edit
Bug 29105: Unit test

This patch adds a unit test for the addition of effective_item_type_id
to the items responses.

Test plan
1) Run the unit test prior to applying the second patch and confirm it
   fails
2) Apply the second patch and confirm the unit test now passes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:11:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:11:19 +0000
Subject: [Koha-bugs] [Bug 29105] items responses do not respect
 effective_itemtype
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-yVj9rHvnhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125252|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137505&action=edit
Bug 29105: Add effective_itemtype handling to items api

This patch adds effective_item_type_id to the items api.

We overload the to_api method to append the effective_item_type_id field
with that of the effective itemtype code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:11:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:11:49 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-BJR9OYskOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
            Summary|items responses do not      |Add effective_item_type_id
                   |respect effective_itemtype  |to the api items responses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:12:40 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-qRJdEfmuVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Patches updated as requested and not handling notforloan status as I'll submit
that as another bug

We now return both item_type_id and the new effective_item_type_id field in the
same response.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:15:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:15:36 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-lC35wj5la6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm still somewhat torn here.. it feels wrong somehow to require intimate
knowledge of how Koha works with regards to overloading features to be able to
use this API route..  an average consumer won't necessarily understand the
difference between these fields.

I wondered about taking an alternate approach of requiring a header to revert
from automatically replacing item_type_id with the effective equivalent instead
to allow for Koha staff client use on the editing of item pages.

Difficult!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:17:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:17:11 +0000
Subject: [Koha-bugs] [Bug 31128] New: REST API item not_for_loan_status
 doesn't respect biblio level fallbacks
Message-ID: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

            Bug ID: 31128
           Summary: REST API item not_for_loan_status doesn't respect
                    biblio level fallbacks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
                CC: tomascohen at gmail.com

Outside of the UI, the not for loan status is coded to fallback to biblio level
not for loan settings if the item is found to be loanable at the item level.

We should respect that in the API too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:18:12 +0000
Subject: [Koha-bugs] [Bug 18147] Show cover images in public lists in the
 staff client
In-Reply-To: <bug-18147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18147-70-5JGDnb7p5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18147

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:18:29 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-V4Tw0V3mSB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
As discussed on bug 29105 I opted instead to always add an
effective_not_for_loan_status field rather than outright replace it...

But, I'm really not sure about this approach.. it feels like we're seeking
internal processes a lot here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:18:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:18:47 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-yeURfvcxX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29105
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105
[Bug 29105] Add effective_item_type_id to the api items responses
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:18:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:18:47 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-lBGKZxLRw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31128


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128
[Bug 31128] REST API item not_for_loan_status doesn't respect biblio level
fallbacks
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:29:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:29:14 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-R2v6qGeNAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #448 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 137503
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503
Bug 28854: Squashed Patch Set for Reading

Review of attachment 137503:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28854&attachment=137503)
-----------------------------------------------------------------

::: C4/Accounts.pm
@@ +70,5 @@
>  sub chargelostitem {
>      my $dbh = C4::Context->dbh();
>      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> +    my $item  = Koha::Items->find($itemnumber);
> +    my $itype = $item->itemtype;

Why the switch from effective_itemtype() to itemtype()?

::: Koha/Item.pm
@@ +1611,5 @@
> +            }
> +            elsif ( $_->{msg} =~
> +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> +              )
> +            {    # The optional \W in the regex might be a quote or backtick

There is no \W in the regex. Wish it changed, or maybe the W should be lower
case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:31:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:31:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-2R98a9FPyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #449 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137506&action=edit
Bug 28854: (QA follow-up)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:35:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:35:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-24eUedq6x1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #102 from Julian Maurice <julian.maurice at biblibre.com> ---
Thanks for the feedback!

Obviously the centered text in system preferences is a mistake and will be
fixed ;)

Issues raised by comment 97 will be fixed too

Jonathan, we are aware of the problems you mention. Solène is working on it
(note that (5) is already fixed by attachment 137415)

Martin, I think a shared branch is an interesting idea, but maybe for later
when things are more stable (lots of rewrites/indentation fixes/... at the
moment)

Also, we'll probably set up a public instance so that people can test it
easily.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:47:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:47:58 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-etMPRdwqI7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137507&action=edit
Bug 31128: Unit tests

This patch adds unit tests for the new effective_not_for_loan_status
which I add to the items api responses in this patchset.

Test plan
1) Run the unit test without applying the next commit, it should fail
2) RUn the test again after applying the next commit, it should pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:48:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:48:04 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-6FdSTAv5GN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137508&action=edit
Bug 31128: Add effective_not_for_loan_status into items response

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:48:37 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-a8DeH5xjOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:48:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:48:51 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-XHLvfrvkcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:51:09 +0000
Subject: [Koha-bugs] [Bug 31129] New: Number of restrictions is always "0"
 on the "Check out" table
Message-ID: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

            Bug ID: 31129
           Summary: Number of restrictions is always "0" on the "Check
                    out" table
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

circ/circulation.tt vs members/moremember.tt:


circ/circulation.tt:                            <a id="debarments-tab-link"
href="#reldebarments">Restrictions ([% debarments.count || 0 | html %])</a>

members/moremember.tt:                                <a
id="debarments-tab-link" href="#reldebarments">Restrictions ([% debarments.size
|| 0 | html %])</a>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 14:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 12:51:15 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-qQcFYaPEVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Number of restrictions is   |Number of restrictions is
                   |always "0" on the "Check    |always "0" on the "Check
                   |out" table                  |out" tab

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:12:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:12:17 +0000
Subject: [Koha-bugs] [Bug 31084] Display item type in bundle management table
In-Reply-To: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31084-70-2nKSY9nx1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29105


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105
[Bug 29105] Add effective_item_type_id to the api items responses
-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:12:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:12:17 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-kHAktZOSVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084
[Bug 31084] Display item type in bundle management table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:14:55 +0000
Subject: [Koha-bugs] [Bug 31130] New: Display collection code in bundle
 management table
Message-ID: <bug-31130-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130

            Bug ID: 31130
           Summary: Display collection code in bundle management table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 28854

We removed the collection code field from display in the bundle management
table from the original submission on bug 28854 because I felt it was not
required for the minimum viable product and that adding the code to description
handling needed testing in its own right.

This bug serves to add that field back in.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:14:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ivwCmFzukq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31130


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130
[Bug 31130] Display collection code in bundle management table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:15:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:15:26 +0000
Subject: [Koha-bugs] [Bug 31130] Display collection code in bundle
 management table
In-Reply-To: <bug-31130-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31130-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31130-70-DSGdEKdI6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:17:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:17:17 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-Wz2qafEJtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:28:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:28:12 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-3VgutbJPKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

--- Comment #22 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
It still works well for me...

Not sure where the problem comes from. I tested with chrome and firefox.
I tried blocking prompts on firefox and the popup does not appear, but the
message is not deleted.

Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:30:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:30:41 +0000
Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding
 items to bundles
In-Reply-To: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29560-70-tmkCGHOIXz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135090|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137509&action=edit
Bug 29560: Add link_marc_host to Koha::Biblio

This patch adds the new `link_marc_host` method to Koha::Biblio to
facilitate adding a host link to the marc record of this biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:30:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:30:48 +0000
Subject: [Koha-bugs] [Bug 29560] Add option to create MARC links when adding
 items to bundles
In-Reply-To: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29560-70-aX8Q1dVfqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135091|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137510&action=edit
Bug 29560: Add option to create MARC Links when bundling items

This patch add a checkbox to the 'Add to bundle' modal allowing the user
to optionally add MARC links between the new child record and the
current biblio. For MARC21 this will result in a 773 pointing to the
host from the item record and for UNIMARC a 461 field will be added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:34:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:34:44 +0000
Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice
In-Reply-To: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29566-70-lodo5GbKHV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135038|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137511&action=edit
Bug 29566: Add API route for fetching item slip content

This patch adds an API endpoint to allow the generation and fetching of
an item print slip.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:34:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:34:50 +0000
Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice
In-Reply-To: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29566-70-ELs247r4JY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135039|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137512&action=edit
Bug 29566: Update modal to use slip api

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:34:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:34:58 +0000
Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice
In-Reply-To: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29566-70-KuKU5RMabd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135040|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137513&action=edit
Bug 29566: Add sample notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 15:56:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 13:56:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-aBEcmJ0XtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #450 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t
In addition, can you address the two small things from my splinter review?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:05:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:05:24 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-vP6G70FAP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137367|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137514&action=edit
Bug 31039: Remove duplicate modal printing JS

This patch removes the erroneos duplication of the modal printing js.

Test plan
1) Create some transactions and perform a cashup.
2) Open the cashup summary modal
3) Click 'Print'
4) Cancel the print dialogue
5) Note that the dialogue re-appears
6) Apply the patch
7) Repeat and note the dialogue closes first time now.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:05:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:05:37 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-I9UBjpnutm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137368|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137515&action=edit
Bug 31039: (follow-up) Wrap jQuery in $(document).ready()

cashup_modal.js consists only of jQuery code, so the whole thing should
be contained in a $(document).ready() function. This may or may not be
contributing to the behavior this bug is trying to fix.

Please note that this patch contains whitespace changes, so diff
accordingly.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:05:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:05:58 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-SY2mXi8lzg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:08:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:08:05 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-S8cOAZW0It@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Shouldn't this be Needs Signoff, Frederic?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:18:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:18:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-2kU7h0Gl9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #451 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Kyle M Hall from comment #448)
> Comment on attachment 137503 [details] [review]
> Bug 28854: Squashed Patch Set for Reading
> 
> Review of attachment 137503 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Accounts.pm
> @@ +70,5 @@
> >  sub chargelostitem {
> >      my $dbh = C4::Context->dbh();
> >      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> > +    my $item  = Koha::Items->find($itemnumber);
> > +    my $itype = $item->itemtype;
> 
> Why the switch from effective_itemtype() to itemtype()?

So.. the change here is actually so we can have access to the Item object lower
down in the function.. the switch from finding the itemtype object directly to
using the Koha::Item level accessor method means we get back the
effective_itemtype object directly via the accessor.  See Koha::Item->itemtype
;P

> 
> ::: Koha/Item.pm
> @@ +1611,5 @@
> > +            }
> > +            elsif ( $_->{msg} =~
> > +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> > +              )
> > +            {    # The optional \W in the regex might be a quote or backtick
> 
> There is no \W in the regex. Wish it changed, or maybe the W should be lower
> case?

Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it
into DBIC at some point, but didn't feel it was appropriate here).. the `\W?`
is there.. just after `for column` in the regex.. not sure I follow your
question here I'm afraid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:18:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:18:48 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-Kpxre0OmjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23681
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is a fix for this in the patch set for user defined restristions: bug
23681

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:18:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:18:48 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-piGXix3M81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31129

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:20:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:20:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-JT8qslfY9o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:20:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:20:51 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-8WWwaZsHXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135487|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137516&action=edit
Bug 30718: Use flatpickr's altInput

The idea rely on the KohaDates TT plugin for the date formatting. We
should not have any output_pref calls in pl or pm (there are some
exceptions, for ILSDI for instance).

Also flatpickr will deal with the places where dates are inputed. We
will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and
the controller will receive the same value, no need to additional
conversion.
Note that DBIC has the capability to auto-deflate DateTime objects,
which makes things way easier. We can either pass the value we receive
from the controller, or pass a DT object to our methods.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:21:18 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-YFmGpHeX4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #452 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Kyle M Hall from comment #450)
> I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t
> In addition, can you address the two small things from my splinter review?

Hmm.. I can't seem to get the test to fail.. did you run the DB update/get any
errors when you ran the DB update?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:24:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:24:23 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-o3DFQawFU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I think this patch is ready for testing, but it's hard to tell what need to be
tested!
Basically it's *any* date manipulation all over Koha that needs to be tested,
so... lot of testing!

This patch is great has it is removing 400 lines of ugly and unnecessary date
manipulation.
114 files changed, 302 insertions(+), 706 deletions(-)
It makes the code so cleaner!

I won't benchmark but I am expecting (non-significant) perf improvements here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:25:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:25:32 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-qQ8Tn1dQHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Ha, and, this patch has bugs, for sure! Please help me find them!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:26:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:26:13 +0000
Subject: [Koha-bugs] [Bug 31125] Fix warnings from register.tt
In-Reply-To: <bug-31125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31125-70-rDRRcuiRgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31125

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. I have no idea how to fix this.. there's already handling in the relevant
Object methods to return numeric 0 if there's no lines to total up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:31:37 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-w0DAINyNZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137433|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137517&action=edit
Bug 31104: Put each link on a separate header

This patch makes the Pagination helper put each Link entry on the
response headers on a separate header. In practice, this leads to
shorter headers and will avoid apache default/reasonable limits.

To test:
1. Open the patron search page
2. Open the koha logs:
   $ tail -f /var/log/koha/kohadev/*.log
3. On the 'Search for patron' input, use a really long string, like
   'superlongstringthatistoolongforapacheyeahsuperlong'
=> SUCCESS: There's no user with an attribute with that content :-D
=> FAIL: You get an error like (28)No space left on device: [client
127.0.0.1:60330] AH10124: header size is over the limit allowed by
ResponseFieldSize (8192 bytes). Bad response header: 'Link:...'
4. Apply this patch
5. Restart all:
   $ restart_all
6. Repeat 2 and 3
=> SUCCESS: No results
=> SUCCESS: No error in the logs
7. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Pagination.t \
           t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!

Note 1: The Link header is expected to be in CSV format, which is
usually the way libraries treat repeated headers anyway.

Note 2: Apache is not rejecting the response, just stripping out the
'bad header'. So this is not a critical issue.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Michal Urban <michalurban177 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:35:11 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-tDe93Krtnw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice clear fix Tomas, thanks.

All works as expected.. perhaps it might have been nice to see a unit test for
it, but otherwise, I'm happy here.

Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:35:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:35:58 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-3IJ1pev60D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #453 from Kyle M Hall <kyle at bywatersolutions.com> ---
> > Why the switch from effective_itemtype() to itemtype()?
> 
> So.. the change here is actually so we can have access to the Item object
> lower down in the function.. the switch from finding the itemtype object
> directly to using the Koha::Item level accessor method means we get back the
> effective_itemtype object directly via the accessor.  See
> Koha::Item->itemtype ;P

Thanks! I see now! I missed that subroutine when I was looking for it!


> Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move
> it into DBIC at some point, but didn't feel it was appropriate here).. the
> `\W?` is there.. just after `for column` in the regex.. not sure I follow
> your question here I'm afraid.

I missed where the \W was by focusing only on the patch and not the surrounding
code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:36:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:36:09 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-cdJeO5L2tk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:37:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:37:40 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-zCzeio5mXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm in agreement with Tomas here.. took a while to work through how it all fits
together but his history sluething helped a lot.. the tl;dr is "we've been
doing some funky escaping for years when in reality we should have been quoting
instead."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:48:23 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-GzASoswwQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137434|0                           |1
        is obsolete|                            |

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137518&action=edit
Bug 12029: Patrons should be able to delete their patron messages

This patch adds an option for patrons to dismiss OPAC messages sent to
them by the staff. The messages remain visible in the staff interface
with an indication that the message has been read.

To test, apply the patch and run the database update.

- View a patron record in the staff interface.
- Click "Add message" and select "OPAC" from the "Add a message for..."
  dropdown.
- Add a message.

- Log in to the OPAC as that patron.
- On the "Your summary" page you should see the message along with a
  "Dismiss" link."
- Clicking the "Dismiss" link should make the message disappear.
- Go to the OPAC home page. The "User summary" box in the right sidebar
  should have the correct count of messages.

- View the patron record in the staff interface again.
- The list of patron messages should still include the message which was
  dismissed via the OPAC, but there should be indication that the
  message was read, e.g. "read 11-2-2022"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:48:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:48:32 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-xL9j27mqc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137435|0                           |1
        is obsolete|                            |

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137519&action=edit
Bug 12029: (follow-up) Adhering to coding guidelines

This is a follow-up patch which (based on comment #19) does
the following:

1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:48:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:48:38 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-bkHpctsyAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137520&action=edit
Bug 12029: DBIC Schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:49:50 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-xi2Sd8msfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've added the Schema patch here to make this easier to test on sandboxes...


However.. please note when you see an error like this you can actually build
the schema's yourself from the sandbox action menu 'Refresh schema'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:58:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:58:10 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-v4BT2qGZVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137518|0                           |1
        is obsolete|                            |

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137521&action=edit
Bug 12029: Patrons should be able to delete their patron messages

This patch adds an option for patrons to dismiss OPAC messages sent to
them by the staff. The messages remain visible in the staff interface
with an indication that the message has been read.

To test, apply the patch and run the database update.

- View a patron record in the staff interface.
- Click "Add message" and select "OPAC" from the "Add a message for..."
  dropdown.
- Add a message.

- Log in to the OPAC as that patron.
- On the "Your summary" page you should see the message along with a
  "Dismiss" link."
- Clicking the "Dismiss" link should make the message disappear.
- Go to the OPAC home page. The "User summary" box in the right sidebar
  should have the correct count of messages.

- View the patron record in the staff interface again.
- The list of patron messages should still include the message which was
  dismissed via the OPAC, but there should be indication that the
  message was read, e.g. "read 11-2-2022"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:58:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:58:15 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-mVWlTjV4OB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137519|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137522&action=edit
Bug 12029: (follow-up) Adhering to coding guidelines

This is a follow-up patch which (based on comment #19) does
the following:

1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)

Sponsored-by: Horowhenua Library Trust
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:58:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:58:23 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-oAZLXwPqdV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137520|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137523&action=edit
Bug 12029: DBIC Schema

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:59:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:59:04 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-ASKeda3pcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All appears to work as designed.. signing off, ready for QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:59:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:59:43 +0000
Subject: [Koha-bugs] [Bug 31111] Syndetic Unbound Cover Images would be nice
 to be visible on the Staff Client
In-Reply-To: <bug-31111-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31111-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31111-70-ChPNpBYjeq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31111

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 21225 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 16:59:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 14:59:43 +0000
Subject: [Koha-bugs] [Bug 21225] Add Syndetics cover images to staff client
In-Reply-To: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21225-70-zrbJHFzNAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> ---
*** Bug 31111 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:09:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:09:26 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-3cVaKpuqRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #454 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137524&action=edit
Bug 28854: (QA follow-up) Remove duplicate key test

We now allow duplication of issue_id accross the return claims table (to
allow for the case where a bundle item has been loaned and thus multiple
claims can result from the same checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:19:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:19:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Q5QsJihvdm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #455 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137525&action=edit
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10

The authorised_value field is a varchar and so 'MAX' will sort '9' above
'10' and cause issues if you have more than 9 AV values already for LOST
or NOT_LOAN.

This patch adds a 'CAST' to the field so we can use MAX correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:28:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:28:30 +0000
Subject: [Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts
In-Reply-To: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27976-70-1QSpkJdkjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976

Katie Bliss <kebliss at dmpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kebliss at dmpl.org

--- Comment #2 from Katie Bliss <kebliss at dmpl.org> ---
We'd also love to be able to limit the verification to just checkin, as opposed
to both checkin and checkout. We work on the assumption that if an item's been
checked in, then it's been checked for all its parts and so we don't need to do
that again when checking the item out. It also prevents items with multiple
parts from being checked out by patrons at the self-checks, which can be
irritating for them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:41:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:41:03 +0000
Subject: [Koha-bugs] [Bug 31034] Bib image hidden after changes in bib detail
In-Reply-To: <bug-31034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31034-70-BCEKTgVHLM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034

grharry <dhd.koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dhd.koha at gmail.com

--- Comment #5 from grharry <dhd.koha at gmail.com> ---
I don't know if this applies to this bug. 

I have the same problem on all browsers except vivaldi, from version 21.11+ !

It seems like a timeout+synchronization problem. 

Thus 

for opac edit _language_code_/modules/opac_detail.tt  near line 1589 

increase the 100 timeout value to your needs, 

window.setTimeout(function(){wait_for_images(cb);}, 100);

replace 100 by a value that works for your needs 500 - 1000 or more! 

So far cannot locate the particular code for staff interface. 

Staff interface does not show the coce cover on any browser except vivaldi! 

Regards, 
Harry.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:46:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:46:57 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-koll2SFHuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #42 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Martin Renvoize from comment #37)
> I've added the Schema patch here to make this easier to test on sandboxes...
> 
> 
> However.. please note when you see an error like this you can actually build
> the schema's yourself from the sandbox action menu 'Refresh schema'

I had no idea that I needed to do that.  How can I tell?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:51:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:51:49 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-pGb1afVAxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137333|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137526&action=edit
Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is
blank/empty value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:52:15 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-xLS0zZmztF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:54:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:54:55 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-kOzmXnRfrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:55:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:55:05 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-veDj7HJ0LS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137461|0                           |1
        is obsolete|                            |
 Attachment #137462|0                           |1
        is obsolete|                            |
 Attachment #137463|0                           |1
        is obsolete|                            |
 Attachment #137464|0                           |1
        is obsolete|                            |
 Attachment #137465|0                           |1
        is obsolete|                            |
 Attachment #137466|0                           |1
        is obsolete|                            |
 Attachment #137467|0                           |1
        is obsolete|                            |
 Attachment #137468|0                           |1
        is obsolete|                            |
 Attachment #137469|0                           |1
        is obsolete|                            |
 Attachment #137470|0                           |1
        is obsolete|                            |
 Attachment #137471|0                           |1
        is obsolete|                            |
 Attachment #137472|0                           |1
        is obsolete|                            |
 Attachment #137473|0                           |1
        is obsolete|                            |
 Attachment #137474|0                           |1
        is obsolete|                            |
 Attachment #137475|0                           |1
        is obsolete|                            |
 Attachment #137476|0                           |1
        is obsolete|                            |
 Attachment #137477|0                           |1
        is obsolete|                            |
 Attachment #137478|0                           |1
        is obsolete|                            |
 Attachment #137479|0                           |1
        is obsolete|                            |
 Attachment #137480|0                           |1
        is obsolete|                            |
 Attachment #137481|0                           |1
        is obsolete|                            |
 Attachment #137482|0                           |1
        is obsolete|                            |
 Attachment #137483|0                           |1
        is obsolete|                            |
 Attachment #137484|0                           |1
        is obsolete|                            |
 Attachment #137485|0                           |1
        is obsolete|                            |
 Attachment #137486|0                           |1
        is obsolete|                            |
 Attachment #137487|0                           |1
        is obsolete|                            |
 Attachment #137488|0                           |1
        is obsolete|                            |
 Attachment #137489|0                           |1
        is obsolete|                            |
 Attachment #137490|0                           |1
        is obsolete|                            |
 Attachment #137491|0                           |1
        is obsolete|                            |
 Attachment #137492|0                           |1
        is obsolete|                            |
 Attachment #137493|0                           |1
        is obsolete|                            |
 Attachment #137494|0                           |1
        is obsolete|                            |
 Attachment #137495|0                           |1
        is obsolete|                            |
 Attachment #137496|0                           |1
        is obsolete|                            |
 Attachment #137497|0                           |1
        is obsolete|                            |
 Attachment #137498|0                           |1
        is obsolete|                            |
 Attachment #137499|0                           |1
        is obsolete|                            |
 Attachment #137500|0                           |1
        is obsolete|                            |
 Attachment #137501|0                           |1
        is obsolete|                            |
 Attachment #137506|0                           |1
        is obsolete|                            |
 Attachment #137524|0                           |1
        is obsolete|                            |
 Attachment #137525|0                           |1
        is obsolete|                            |

--- Comment #456 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137527&action=edit
Bug 28854: Database update

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:55:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:55:30 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-V4AfhAvm73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #457 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137528&action=edit
Bug 28854: DBIC Schema Updates

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:55:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:55:39 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-IGC9Kqd1XM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #458 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137529&action=edit
Bug 28854: Expose functionality to attach items to bundles

This patch adds methods the the Koha::Item object for managing item
bundling operations and then exposes those methods via the REST API.

We include the new `BundleNotLoanValue` preference for setting not
for loan values when an item is added to a bundle.

Finally, we expose bundle management via the catalogue details page.

Test plan:
0) Apply patches up to this point and run the database update
1) Configuration: `BundleNotLoanValue` should have been set by the
   database update and point to a newly added AV value.
2) Creating a new bundle
   * Add a new bib record
   * Mark the bib record as a 'collection' type by setting leader
     position 7 to 'c'
   * Add a new item to this bib record
   * You should see a new 'Manage bundle' button available in the
     'Actions' column of the Holdings table.
   * Clicking 'Manage bundle' should expand the table to include a new
     row directly beneath this one.
   * Use the new 'Add to bundle' button that appears in this row to
     trigger a modal that allows entering the barcode of items you wish
     to add to the bundle
   * Upon closing the modal, the bundle content table should reload and
     contain your newly associated items.
   * You can subsequently remove an item from a bundle using the new
     'Remove' button.
3) Not for loan
   * Items that have been added into a bundle should now appear as 'Not
     for loan' from their original biblio record and note which bundle
     they belong to.
4) Error cases
   * Try adding an item that already belongs to a bundle to another
     bundle: Note an error is displayed in the modal form.
5) The bundles feature can be disabled by unsetting the
   `BundleNotLoanValue` system preference.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:55:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:55:48 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-xiMAptsQsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #459 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137530&action=edit
Bug 28854: Update circulation functionality for bundles

This patch updates the circulation system to account for bundle
checkins. We add a content verification step to ensure bundle content is
all present at checkin and we use this comparison to mark missing items
as lost.

Test plan
0) Apply patches up to this point
1) Checkin an item that belongs to a bundle
   * An alert should be triggered noting that the item belongs to a
     bundle
   * The option to remove the item from the bundle should be clear
   * Click remove should result in the alert dissapearing and the item
     having been removed from the bundle.
2) Checkin an item bundle
   * A modal confirmation dialog should appear requesting each item
     barcode be scanned
   * As items are scanned they should be highlighted in yellow in the
     bundle content table
   * Upon submission;
     * The user will be alerted to any unexpected items that were
       scanned and told to put them to one side.
     * The user will be alerted that any missing items in the validation
       will have been marked as lost.
     * The bundle item will be marked as checked in.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-XsRroB7k0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #460 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137531&action=edit
Bug 28854: Highlight bundle rows to clarify UI

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:12 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-SacCwrU3vi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #461 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137532&action=edit
Bug 28854: Drop unique index on issue_id in return claims

With the introduction of circulating items within a bundle set, we can
now loose multiple items from the bundle from the same issue.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:21 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-aF32BhViCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #462 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137533&action=edit
Bug 28854: DBIC Update ReturnClaim Schema

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-EW24AOmcw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #463 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137534&action=edit
Bug 28854: Record and display who lost the item

This patch records the bundle issue from which an item is marked as lost
so that we may use that to infer who lost the item (for later charges
and display).

Test plan
0) Apply all patches up to this point
1) Checkout a bundle to a user
2) Checkin the bundle and do not scan one of the barcodes at
   confirmation
   * Note that the item not scanned is marked as lost
3) Navigate to the biblio for the lost item and note that it is marked
   as lost.
4) Navigate to the biblio for the collection and expand the collection
   item that contains the lost item. Note the item is marked as lost and
   checkout details are listed.
5) Checkin the lost item
   * The item should be marked as found and the return_claims line should
   be marked as resolved.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:42 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ecAGnTbIGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #464 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137535&action=edit
Bug 28854: Simplified status handling for bundle inventory check

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:56:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:56:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-fhbD9XSRaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #465 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137536&action=edit
Bug 28854: Add option to print content list after verification

We already allowed the user to view and print an updated content list
after a varification showed that items were missing from the bundle.
This patch adds the option to view and print the list even if the
content has been varified to have not changed.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:57:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:57:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-oPoXzfuFod@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #466 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137537&action=edit
Bug 28854: Add ordering to checkin validation modal

This enhancement adds simple dataTable ordering to the verification
modal table at bundle checkin time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:57:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:57:30 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-z0RFUMcvm1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:57:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:57:34 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-us8TdIFmiO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #467 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137538&action=edit
Bug 28854: Improve lost details display for bundle items

This patch adds the return claim details to the bundle item status
display on the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:57:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:57:35 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-wvyECJJ2JS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137539&action=edit
Bug 29632: Unit tests

This patch adds unit tests, as well as changing existing test to use a mock
and read the data as passed in tests, rather than relying on what exists in
the DB

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:57:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:57:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-20J3UF7ZzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #468 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137540&action=edit
Bug 28854: Enable claims return view when BundleLostValue is set

This patch adds the alternation of BundleLostValue to enable the return
claims functionality when Bundles are enbled.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:58:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:58:04 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dkR0iXNUF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #469 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137541&action=edit
Bug 28854: Highlight when a scanned item is unexpected

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:58:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:58:25 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-8eWqNlpgkC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #470 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137542&action=edit
Bug 28854: Add count of scanned items to verification modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:58:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:58:34 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-GhI9H08hgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #471 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137543&action=edit
Bug 28854: Add 'Remove from bundle' dialogue to details display

This patch adds the counterpart of the 'Add to bundle' modal prompt for
adding items to bundles from the catalogue details display.  It allows
for scanning barcodes to remove them from a bundle.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:58:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:58:44 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-SYSf31JtS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #472 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137544&action=edit
Bug 28854: Add modal after checkin to print missing items list

This patch adds a further modal to the post checkin alert to allow the
user to print a view and print a list of items that went missing at this
checkin to allow for replacements to be picked.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:58:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-PH6kTn8d8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #473 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137545&action=edit
Bug 28854: (follow-up) Only count rows in the body

This patch fixes the count to only include table rows in the body, i.e.
skip the header row.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-O16csNY3pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #474 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137546&action=edit
Bug 28854: Make barcode comparison case insensative

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:12 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wTrqWb9xAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #475 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137547&action=edit
Bug 28854: (QA follow-up) Fix QA tool complaints

* Typo in code comment
* Permissions on atomicupdate
* Missing TT filter in template
* Spelling in template

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:21 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-ivj6A8bPN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #476 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137548&action=edit
Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:29 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-hND3IE8OMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #477 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137549&action=edit
Bug 28854: Unit test for Koha::Item additions

This patch adds unit tests for the new methods added to Koha::Item
including:

* return_claim
* return_claims
* is_bundle
* in_bundle
* bundle_host
* bundle_items
* add_to_bundle
* remove_from_bundle

Test plan
1) Run t/db_dependent/Koha/Item.t

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:38 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-dmUxEdk33c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #478 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137550&action=edit
Bug 28854: Unit test for AddReturn addition

This patch adds tests for the AddReturn change that adds an 'InBundle' message
to the return.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:49 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-0858p9DKVk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #479 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137551&action=edit
Bug 28854: Unit tests - chargelostitem

This patch adds unit tests for the changes to chargelositem to ensure
bundle charging works as expected setting the correct issue_id.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 17:59:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 15:59:58 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-l33K64QsEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #480 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137552&action=edit
Bug 28854: Add default AV and Syspref values

This patch adds the new AV and System Preferences to the installer.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:00:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:00:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-Hkif43Pjm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #481 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137553&action=edit
Bug 28854: (follow-up) Translations fixes

This patch wraps and unwraps strings appropriately for trasnlation.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:00:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:00:22 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-htewcm3Ds9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #482 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137554&action=edit
Bug 28854: (follow-up) Rename column configuration to barcode

This patch updates the column configuration from 'external_id' to
'barcode'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:00:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:00:33 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-B0c4UVWtOG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #483 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137555&action=edit
Bug 28854: (follow-up) Move preferences to "Item bundles"

Move the preferences into a section under 'Circulation' called 'Item
bundles'

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:00:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:00:44 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-67S04FmrCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #484 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137556&action=edit
Bug 28854: (follow-up) Fix typo in templates and test plan

* aready > already
* 61 > 62

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:00:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:00:57 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-s8X81Ro1yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #485 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137557&action=edit
Bug 28854: (follow-up) Improve error for item not found

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:08 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-bbKKsuaR6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #486 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137558&action=edit
Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items

This removes any leading or trailing whitespace from the external id
passed

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:17 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-H4E7QvJQJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #487 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137559&action=edit
Bug 28854: (follow-up) Disable bundle editing for checked out

This patch disables the add and remove options under bundle management
when the bundled item in question is checked out.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:28 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-sXejH32eWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #488 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137560&action=edit
Bug 28854: (follow-up) Link bundle items to thier biblios

This patch splits out the title formatting from the bundle item title
display into it's own new js-biblio-format include file and adds biblio
linking options.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:37 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-bHWF83AwiT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #489 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137561&action=edit
Bug 28854: (follow-up) Restore last seen date formatting

We lost the date formatting somewhere along the line with rebases, this
patch restores the call to $date for last seen date.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:45 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-thSHvmuIm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #490 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137562&action=edit
Bug 28854: (follow-up) Add bundle item status to manage button

This patch adds the item counts (Present|Lost) to the 'Manage bundle'
button in the catalogue details page.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:01:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:01:54 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-5gnsHFV5An@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #491 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137563&action=edit
Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle'

This patch adds and removes the 'active' class to the 'Manage bundle'
button such that it correctly reflects whether the manage area is
expanded or not for the bundle item.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:04 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-wFRhR5SxvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #492 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137564&action=edit
Bug 28854: (follow-up) Restore block styling on bundled span

This patch restores a css rule that we lost during rebases that makes
the 'bundled' span that appears for bundled items on their respective
details pages so that the 'In bundle: ' text in the status field of the
table appears beneath the 'Not for loan (Added to bundle)' text.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:13 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-VBJtEzcx36@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #493 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137565&action=edit
Bug 28854: (follow-up) Link to 'In bundle' on OPAC

This patch adds the 'In bundle: Link' to the OPAC to mirror what we have
on the staff client.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:23 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-snZAJaOjvp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #494 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137566&action=edit
Bug 28854: (follow-up) Add handling for part_numbers/names

This patch adds part number/name handling to the new biblio-format js
include. This will add such details to bundle management tables.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:35 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-k8UgsS8kfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #495 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137567&action=edit
Bug 28854: (QA follow-up) Add missing TT filters

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:46 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-d3m2iT2XKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #496 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137568&action=edit
Bug 28854: (follow-up) Remove fields from from bundle items

This patch removes the itemtype and collection code fields from the
bundle items table.

We will add the itemtype back in at a later date with a new bug as the
display code needs some careful consideration and we felt that doing
that work inline here would be an unrequired blocker.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:02:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:02:59 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-7UrlLJoZBS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #497 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137569&action=edit
Bug 28854: (QA follow-up)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:03:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:03:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-iCg8RDVWKB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #498 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137570&action=edit
Bug 28854: (QA follow-up) Remove duplicate key test

We now allow duplication of issue_id accross the return claims table (to
allow for the case where a bundle item has been loaned and thus multiple
claims can result from the same checkout.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:03:19 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-CbvmWG5bfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #499 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137571&action=edit
Bug 28854: (QA follow-up) Fix DB revision for AV's above 10

The authorised_value field is a varchar and so 'MAX' will sort '9' above
'10' and cause issues if you have more than 9 AV values already for LOST
or NOT_LOAN.

This patch adds a 'CAST' to the field so we can use MAX correctly.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:09:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:09:10 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-KKdyk2I5Dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:09:14 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-mjKvaVbp21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137504|0                           |1
        is obsolete|                            |

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137572&action=edit
Bug 29105: Unit test

This patch adds a unit test for the addition of effective_item_type_id
to the items responses.

Test plan
1) Run the unit test prior to applying the second patch and confirm it
   fails
2) Apply the second patch and confirm the unit test now passes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:09:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:09:18 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-PuCOADW8Ea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137505|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137573&action=edit
Bug 29105: Add effective_itemtype handling to items api

This patch adds effective_item_type_id to the items api.

We overload the to_api method to append the effective_item_type_id field
with that of the effective itemtype code.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:16:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:16:11 +0000
Subject: [Koha-bugs] [Bug 31131] New: MARC21: XSLT links for 776 do not
 honor UseControlNumber when set to Don't use
Message-ID: <bug-31131-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31131

            Bug ID: 31131
           Summary: MARC21: XSLT links for 776 do not honor
                    UseControlNumber when set to Don't use
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

If a record has a value in 776$w, this is used for linking even if
UseControlNumber is set to Don't use.

To test:
1) Make sure UseControlNumber is set to Don't use
2) In Administration > MARC bibliographic frameworks, add field 776 to the
editor
   2.1) Go to Administration > MARC bibliographic frameworks
   2.2) Next to the Default framework, click Actions > MARC structure
   2.3) Search for 776
   2.4) Next to field 776, click Actions > Edit subfields
   2.5) Go to tab t, check the Editor box
   2.6) Go to tab w, check the Editor box
   2.7) Click Save changes
3) Go to Cataloging and add a new record
4) Fill in the required fields
5) Enter values in 776$t and 776$w
6) Save the record (no need to add items)
7) Go to normal view in staff interface
8) Hover mouse cursor over the link generated for Additional physical formats
--> The link uses the control number
9) Open the record in the OPAC
10) Hover mouse cursor over the link generated for Additional physical formats
--> The link uses the control number

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:18:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:18:15 +0000
Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on
 catalog search results in the OPAC
In-Reply-To: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26933-70-s9MI5VPL7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OPAC - Multiple cover image |Improve handling of
                   |show in results and details |multiple covers on catalog
                   |pages                       |search results in the OPAC
             Status|NEW                         |ASSIGNED
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=25846

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Since the OPAC detail page has already been upgraded to handle multiple covers
like the staff interface has, I'm re-titling this bug to cover only OPAC search
results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:18:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:18:15 +0000
Subject: [Koha-bugs] [Bug 25846] Improve handling of multiple covers on
 catalog search results in the staff client
In-Reply-To: <bug-25846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25846-70-CMdEokOurO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25846

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26933

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:19:05 +0000
Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on
 catalog search results in the OPAC
In-Reply-To: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26933-70-XRnE9L12Qc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28180

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:19:05 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-2oegbTOmJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26933

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:20:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:20:42 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-UPXQFDGro4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
I think this is fine, as long as this feature (item-level_itpyes set to
'biblio') exists - libraries using biblio itemtypes seem to be in the minority
according to:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106

If we remove the feature later, we remove the extra field

small patch, straight to PQA to let RM weigh in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:37:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:37:01 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-8KXfVeOqA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:37:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:37:09 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-9GrcSUpIs2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137507|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137574&action=edit
Bug 31128: Unit tests

This patch adds unit tests for the new effective_not_for_loan_status
which I add to the items api responses in this patchset.

Test plan
1) Run the unit test without applying the next commit, it should fail
2) RUn the test again after applying the next commit, it should pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:37:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:37:14 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-KRo33fvI8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137508|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137575&action=edit
Bug 31128: Add effective_not_for_loan_status into items response

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:39:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:39:31 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-Gm7Tlzaxw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137574|0                           |1
        is obsolete|                            |
 Attachment #137575|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137576&action=edit
Bug 31128: Unit tests

This patch adds unit tests for the new effective_not_for_loan_status
which I add to the items api responses in this patchset.

Test plan
1) Run the unit test without applying the next commit, it should fail
2) RUn the test again after applying the next commit, it should pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:39:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:39:34 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-kACBuZxLZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137577&action=edit
Bug 31128: Add effective_not_for_loan_status into items response

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 18:58:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 16:58:16 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-uljgc0VcV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37446|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137578&action=edit
Bug 12225: Fix SIP message templates

If a renewal via SIP would produce an error due to being on reserve, or
exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the
item even if the "no block" flag is set to Y.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 19:15:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 17:15:11 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-Qx1i5N2JV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 19:21:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 17:21:57 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-uaXi4xW2uY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:03:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:03:36 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-o4CWn2DNXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:03:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:03:39 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-2YR46djltO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137579&action=edit
Bug 20439: Sort SMS providers in alphabetical order

To test:
1/ Add 'Email' to the 'SMSSendDriver' system preference.
2/ Make sure 'EnhancedMessagingPreferencesOPAC' and
'EnhancedMessagingPreferences' are turned on.
3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different
names.
4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by
when they were added, not alphabetically.
5/ Apply patch and restart services.
6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS
providers now sort alphabetically.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:04:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:04:04 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-FB4s47GM7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:38:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:38:40 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-hwW7cDjI8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:38:45 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-JVL5J8eo60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135840|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:38:50 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-9c267FXJTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:38:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:38:55 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-0GSsnbJMRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:00 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-0aUfU0rlAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135843|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:06 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-npuzPH6kax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135844|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:11 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-SuoOaUaP9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135845|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:16 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-MVRtfmn8N1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135846|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:21 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-uKdJVMUnyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135838|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:39:26 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-jbhGLOPu2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:00 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-ny7a7eDaLs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #78 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137580&action=edit
Bug 22456: Add cancellation request table

This patch adds a new table, for storing holds cancellation requests,
and managing them afterwards.

The *hold_id* attribute is not made a FK on the reserves table because
of the old_reserves thing we still do (see bug 25260 for a discussion
about it).

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:10 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-bF2dqkuxRk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #79 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137581&action=edit
Bug 22456: Add waiting_hold_cancellation circulation rule

This patch adds handling for the waiting_hold_cancellation circulation
rule. It is set no 'No' by default in the atomic update, if not
previously set.

Handling in the rules editor is added, in its own section.

To test:
1. Apply this patch
2. Run:
   $ updatedatabase
=> SUCCESS: All good
3. Verify that the syspref is set:
   $ koha-mysql kohadev
   > SELECT * FROM circulation_rules WHERE
rule_name='waiting_hold_cancellation';
=> SUCCESS: Set to 0
4. Play with the rules editor, changing things back and forth, things
   should work, including library-specific and global/defualt settings.
=> SUCCESS: It works
=> SUCCESS: Texts are idiomatic
5. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:17 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-6WwXREvwLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #80 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137582&action=edit
[DO NOT PUSH] Bug 22456: DBIC update

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:24 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-byzun9Q7kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #81 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137583&action=edit
Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es)

This patch adds the Koha::Object-derived classes for cancellation
requests.

Tests are added for the overloaded ->store method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:32 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-XPtiPlJxc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #82 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137584&action=edit
Bug 22456: Add cancellation request methods to Koha::Hold

This patch adds the following helper methods for dealing with hold
cancellation requests to the Koha::Hold class:

 * cancellation_requests
 * add_cancellation_request
 * cancellation_requestable_from_opac
 * cancellation_requested_by_owner

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:41 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-tsrZiBs2dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #83 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137585&action=edit
Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests

This patch adds that method. Which is covered by new tests.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:48 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-KbbZkwvSha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #84 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137586&action=edit
Bug 22456: Allow requesting cancellation from the OPAC

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:40:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:40:56 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-HN4qFbEs4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #85 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137587&action=edit
Bug 22456: Staff interface handling

This patch introduces a new tab to the 'Holds awaiting pickup' screen
for holds that have cancellation requests. This can be accepted (by
cancelling the hold) or rejected.

To test:
1. Set circulation rules for cancellation requests, allowing them for
   certain item type.
2. Have some waiting holds for a patron on an item type that allows
   requesting cancellation.
3. Visit 'Holds awaiting pickup'
=> SUCCESS: No holds have cancellation requests
4. In the OPAC, on the user details, notice some holds have the ability
   to be requested cancellation.
5. Choose to request cancellation
=> SUCCESS: Request is placed, the button is disabled
6. In 'Holds awaiting pickup' you can see them
7. Play with rejecting/accepting
=> SUCCESS: It works!
8. Things are reflected in the OPAC side

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:41:04 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-wWgoPpZekT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #86 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137588&action=edit
Bug 22456: (follow-up) Cancel holds at checkin

This patch makes checkin process the cancellation requested holds
actually cancel them before moving forward.

To test:
1. Have a waiting hold with a patron generated cancellation request
2. At circulation, check the item in
=> SUCCESS: The workflow follows as if the cancellation requested hold
was already cancelled
=> SUCCESS: The hold is actually cancelled
=> SUCCESS: Not shown in the OPAC anymore

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:41:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:41:12 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-eAXIq13vq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #87 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137589&action=edit
Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC

This patch adds a helper method for filtering out cancellation
requested-holds from resultsets, and makes use of it in the OPAC to
filter out those in the current holds tab. Holds history now shows
'Waiting (cancellation requested)' on those.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:41:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:41:31 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-wxi9XZ7MQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137579|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137590&action=edit
Bug 20439: Sort SMS providers in alphabetical order

To test:
1/ Add 'Email' to the 'SMSSendDriver' system preference.
2/ Make sure 'EnhancedMessagingPreferencesOPAC' and
'EnhancedMessagingPreferences' are turned on.
3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different
names.
4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by
when they were added, not alphabetically.
5/ Apply patch and restart services.
6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS
providers now sort alphabetically.

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:42:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:42:19 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-LHrWx0yQ57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:43:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:43:58 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-2RZ3Td1rct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #88 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi everyone, I addressed Lari's concerns about leftovers (hopefully I didn't
miss things!).

I also decided to consider this holds cancelled. This means:
- They are not displayed anymore in the current holds
- They show as cancelled in the holds history for OPAC users.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 22:44:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 20:44:49 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-fF8Q5fMa8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137589|0                           |1
        is obsolete|                            |

--- Comment #89 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137591&action=edit
Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC

This patch adds a helper method for filtering out cancellation
requested-holds from resultsets, and makes use of it in the OPAC to
filter out those in the current holds tab. Holds history now shows
'Waiting (cancellation requested)' on those.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:19:51 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-ovFDTtn7MD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         Version(s)|This fixes the cause of an  |
        released in|error message that appears  |
                   |in the system logs every    |
                   |time that Tools > Catalog > |
                   |Export data                 |
                   |(/cgi-bin/koha/tools/export |
                   |.pl) is accessed. The error |
                   |message was "AH01215: Use   |
                   |of uninitialized value      |
                   |$record_type in string eq   |
                   |at /koh                     |
                   |adevbox/koha/tools/export.p |
                   |l line 43.:                 |
                   |/kohadevbox/koha/tools/expo |
                   |rt.pl,...".                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:21:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:21:54 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-yU2ayzNLfC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

--- Comment #11 from Slava Shishkin <slavashishkin at gmail.com> ---
Thanks, Victor! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:23:46 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-A1vfmpehWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:23:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:23:50 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-QEljpS7gad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:23:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:23:52 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-0JCmxaNK3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:23:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:23:55 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-rXofKvGXOI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:23:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:23:58 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-GaeT1YcdZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:24:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:24:00 +0000
Subject: [Koha-bugs] [Bug 31054] Manual importing for EDIFACT invoices fails
 with a 500 error page
In-Reply-To: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31054-70-eCK9zahcmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31054

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:24:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:24:03 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-O4qqnltwJr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:24:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:24:05 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-qzvwoQbOud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:24:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:24:08 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-smrgrSQquu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:24:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:24:12 +0000
Subject: [Koha-bugs] [Bug 31116] Article requests doesn't respect the
 'CircSidebar' preference
In-Reply-To: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31116-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31116-70-IGG1lywnTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31116

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:32:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:32:19 +0000
Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue
 should be removed when the offending item is returned
In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16882-70-hROUE3vkli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882

--- Comment #7 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Another +1 on here now that I'm working in a library that would like for
overdues restrictions to clear based on *triggering* overdues rather than all
overdues.

(In reply to Andrew Fuerste-Henry from comment #6)
> +1 here, I've spoken to many libraries that would prefer the restriction be
> specific to the item(s) that triggered the notice. This could be a new
> syspref tied to AutoRemoveOverduesRestrictions so it asks: "(Do / Do not)
> allow OVERDUES restrictions triggered by sent notices to be cleared
> automatically when (all / triggering) overdue items are returned by a
> patron."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:41:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:41:41 +0000
Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results
 pages
In-Reply-To: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31020-70-1fFP1AGuPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136436|0                           |1
        is obsolete|                            |

--- Comment #3 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137592&action=edit
Bug 31020: Fix PassItemMarcToXSLT in system preferences description

Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT
system preferences.
But it only applies on results pages.
The only use in perl code is in C4::Search :
 > $marcrecord->delete_fields( @fields ) unless
C4::Context->preference('PassItemMarcToXSLT');

I've tested by adding in all XSLT files :
  <strong>ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/>
</strong>
Number of items only appears in OPAC and staff interface results pages.

In fact only search pages get MARC record from search engine, in which items
datas have been embedded for indexing.
In other pages MARC record does not embed items datas.

This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about
MARC datas not item tags build in XML recieved by XSLT.

Test plan :
1) Apply patch
2) Search for PassItemMarcToXSLT in system preferencies
3) Look at description of PassItemMarcToXSLT
4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and
XSLTResultsDisplay

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:47:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:47:03 +0000
Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results
 pages
In-Reply-To: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31020-70-FAfegAMLuk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:50:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:50:02 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-pWtJ0Ewk6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 11 23:51:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 21:51:43 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-LM6S4TLuMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:13:07 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-df1I1Qi4AC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
   Patch complexity|---                         |Small patch

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> ->status_is( 200, 'SWAGGER3.2.2' )

How can we have Swagger version hardcoded in tests and it still works?
Searching for "SWAGGER" shows multiple versions allover the tests and yet it
still work :o

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:50:18 +0000
Subject: [Koha-bugs] [Bug 31132] New: Add button to clear the cataloguing
 authority plugin form
Message-ID: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

            Bug ID: 31132
           Summary: Add button to clear the cataloguing authority plugin
                    form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: koha-training at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Add a button that will empty all of the search fields in the authority finder
plugin when cataloguing biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:50:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:50:25 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-TjrVOTRKHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Koha Training Catalyst <koha-training at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |koha-training at catalyst.net.
                   |ity.org                     |nz
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:51:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:51:06 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-Ce3xChTe4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-training at catalyst.net. |aleisha at catalyst.net.nz
                   |nz                          |
                 CC|                            |aleisha at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:59:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:59:08 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-HRs5OvIBFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137576|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 137593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137593&action=edit
Bug 31128: Unit tests

This patch adds unit tests for the new effective_not_for_loan_status
which I add to the items api responses in this patchset.

Test plan
1) Run the unit test without applying the next commit, it should fail
2) RUn the test again after applying the next commit, it should pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 00:59:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 22:59:12 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-REi23n6kam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137577|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 137594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137594&action=edit
Bug 31128: Add effective_not_for_loan_status into items response

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:10:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:10:03 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-j10mhCeTGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:10:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:10:07 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-4WsnRDsW0G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137595&action=edit
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:16:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:16:13 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-cQmbMCetHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |'Clear form' link to empty
                   |                            |all of the input fields on
                   |                            |the authority finder plugin
                   |                            |form when cataloguing
                   |                            |bibliographic records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:19:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:19:54 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-hTzzEfDH0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #7 from David Nind <david at davidnind.com> ---
Could we get a test plan for this?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:29:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:29:33 +0000
Subject: [Koha-bugs] [Bug 31133] New: TestBuilder fragile on virtual fks
Message-ID: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

            Bug ID: 31133
           Summary: TestBuilder fragile on virtual fks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

As exposed with the introduction of Koha::Checkouts::Renewal(s), which has two
relationships (checkout and old_checkout) defined at the DBIC level (and not at
DB level) that point the same column name, to the same fk name, TestBuilder
fails in some situations.

Looking at the code I found there's some code for detecting duplicate fk
introduced by bug 16155, but it doesn't seem to be effective: it fails randomly
depending on the key that is picked.

I will submit my attempt to make things work, but more eyes are needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:32:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:32:40 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-36o371VxIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:32:44 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-rEAWxmOe5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137595|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137596&action=edit
Bug 31132: Add button to clear the cataloguing auth finder form

This enhancement adds a 'Clear form' link to empty all of the input
fields on the authority finder plugin form when cataloguing
bibliographic records.

To test:
1) Search for a bibliographic record in the staff interface
2) Edit a record
3) Go to tabs 1, 6 or 7 to find a tag linked to the authority finder
plugin
4) Launch the authority finder plugin by clicking the Tag editor icon at
the end of the field
5) If the fields are empty, add some text in the text fields
6) Click the 'Clear form' link at the bottom of the form
7) Confirm the text is cleared from the input fields and the form is
empty

Sponsored-by: Education Services Australia SCIS

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:33:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:33:30 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-eoooAWPP3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:35:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:35:10 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-WwSk8leTTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |nugged at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:35:36 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-j9nkcS7pbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16155

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:35:36 +0000
Subject: [Koha-bugs] [Bug 16155] Composite keys in TestBuilder and more
In-Reply-To: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16155-70-uF0Hy4we7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16155

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31133

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:42:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:42:08 +0000
Subject: [Koha-bugs] [Bug 31039] Rebase issues lead to duplicate JS for cash
 summary modal printing
In-Reply-To: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31039-70-nEeu5tkqAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes a duplicate
      release notes|                            |print dialogue box
                   |                            |appearing when printing the
                   |                            |cashup summary for cash
                   |                            |registers - ins some
                   |                            |circumstances when
                   |                            |cancelling the print
                   |                            |dialogue, it reappeared
                   |                            |instead of closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 01:57:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Jul 2022 23:57:49 +0000
Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences
 during self registration
In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20859-70-SW3ACPEn0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:03:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:03:35 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-VLYqcqbWDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes two issues that
      release notes|                            |affect searching and links
                   |                            |for analytics on the detail
                   |                            |view pages for records in
                   |                            |the staff interface and
                   |                            |OPAC:
                   |                            |
                   |                            |1. Several
                   |                            |characters will break Zebra
                   |                            |search engine queries, so
                   |                            |search terms need to be
                   |                            |quoted by the query builder
                   |                            |for things to work. Double
                   |                            |quotes in titles and used
                   |                            |in search terms were not
                   |                            |escaped, cuasing issues
                   |                            |with results.
                   |                            |
                   |                            |2. This
                   |                            |caused links to and from
                   |                            |host records using 773$t
                   |                            |and 773$a to fail (not find
                   |                            |or display the expected
                   |                            |results).
                   |                            |
                   |                            |Example: Before
                   |                            |this was fixed, for a host
                   |                            |record with the title
                   |                            |'Uncond"itional?¿' and
                   |                            |child records linked using
                   |                            |773$t and 773$a:
                   |                            |- the
                   |                            |'Show analytics' link was
                   |                            |not displayed in the staff
                   |                            |interface and OPAC for the
                   |                            |host record
                   |                            |- the link from
                   |                            |the child record back to
                   |                            |the host record ('In' Title
                   |                            |of host record (linked))
                   |                            |didn't work.

--- Comment #20 from David Nind <david at davidnind.com> ---
I've added some text for the release notes, but not sure if I've described this
correctly. Corrections and updates to the release notes text welcome!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:35:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:35:30 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-NmSgqYtdvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #23 from David Nind <david at davidnind.com> ---
(In reply to Shi Yao Wang from comment #22)
> It still works well for me...
> 
> Not sure where the problem comes from. I tested with chrome and firefox.
> I tried blocking prompts on firefox and the popup does not appear, but the
> message is not deleted.
> 
> Any ideas?

I retested, and it all works now... not sure what I did to make it not work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:40:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:40:04 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-iPDu3bTps9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Hi :)

If I understand correctly there will be a change for existing notices.
items.content now is the 1st title instead of the concatenation of all of them.
Is that correct?
I don't know what is the template variable where it end but it's content will
change then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:41:09 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-uzBadQZfE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:41:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:41:12 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-egBcRsoEbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135584|0                           |1
        is obsolete|                            |

--- Comment #24 from David Nind <david at davidnind.com> ---
Created attachment 137597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137597&action=edit
Bug 30028: Fix patron message delete confirmation to be translatable

Make the message deletion confirmation popup translatable. Test plan
uses fr-CA translations.

Test plan:
1) Switch language to french (fr-CA)
If you do not have the translations, go to
  misc/translator
then do
  ./translate install fr-CA
After it is done, go to administration > global system preference >
l18N/L10N then select Français (fr-CA) under language preference.
Refresh then you should be able to switch languages.
2) Add a message to a patron account from your own branch (or make sure
AllowAllMessageDeletion is on)
3) Click "Delete" next to the message
--> a confirmation message appears "Are you sure you want to delete this
message? This cannot be undone." with options "Cancel" and "OK".
4) Apply the patch
5) Write a translation in misc/translator/po/fr-CA-messages-js.po :
msgid "Are you sure you want to delete this message? This cannot be undone."
msgstr "Êtes-vous sûr de vouloir supprimer ce message? Cette opération est
irréversible."
6) Refresh the translations by going to misc/translator and execute ./translate
install fr-CA
7) Refresh and click "Delete" again
--> now the confirmation message is "Êtes-vous sûr de vouloir supprimer ce
message? Cette opération est irréversible." with options "Cancel" and "OK"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 02:43:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 00:43:19 +0000
Subject: [Koha-bugs] [Bug 30028] Patron message delete confirmation
 untranslatable
In-Reply-To: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30028-70-D6RGRJQ8ys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30028

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the patron
      release notes|                            |delete messages dialogue
                   |                            |box to make the message
                   |                            |shown translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:09:30 +0000
Subject: [Koha-bugs] [Bug 31134] New: t/Ediorder.t tests failing on 22.05.02
Message-ID: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

            Bug ID: 31134
           Summary: t/Ediorder.t tests failing on 22.05.02
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Bug 30135 might have introduced a flaw in the tests - when we try to install
Koha 22.05.02 and run t/ediorder.t, it fails with this output:

vagrant at kohadevbox:kohaclone((v22.05.02))$ sudo koha-shell kohadev
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/Ediorder.t
t/Ediorder.t .. 1/13 Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
t/Ediorder.t .. 11/13 
#   Failed test 'Single Gir field OK'
#   at t/Ediorder.t line 104.
#          got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM'
#     expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
$VAR1 = 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT';
$VAR2 = 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM+S_I:LVT';
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 119.

#   Failed test 'First part of split Gir field OK'
#   at t/Ediorder.t line 119.
#          got: undef
#     expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 125.

#   Failed test 'Second part of split GIR field OK'
#   at t/Ediorder.t line 125.
#          got: undef
#     expected: 'GIR+002+S_I:LVT'
# Looks like you failed 3 tests of 13.
t/Ediorder.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/13 subtests 

Test Summary Report
-------------------
t/Ediorder.t (Wstat: 768 Tests: 13 Failed: 3)
  Failed tests:  11-13
  Non-zero exit status: 3
Files=1, Tests=13,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.40 cusr  0.10
csys =  1.52 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:09:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:09:47 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-ffSXdDLhVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wainuiwitikapark at catalyst.n
                   |                            |et.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:37:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:37:21 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-Q7Hu87DL2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

--- Comment #219 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137598&action=edit
Bug 30275: (QA follow-up) Trivial fix to schema file

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:37:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:37:32 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-OTp8kVDMNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30275


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275
[Bug 30275] Checkout renewals should be stored in their own table
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:37:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:37:32 +0000
Subject: [Koha-bugs] [Bug 30275] Checkout renewals should be stored in their
 own table
In-Reply-To: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30275-70-I7mLVNQgRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133
[Bug 31133] TestBuilder fragile on virtual fks
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:37:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:37:39 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-RoKXsJkMuX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:39:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:39:33 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-NkFOMsuOQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 04:39:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 02:39:33 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-V4QbyZq2kQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31133


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133
[Bug 31133] TestBuilder fragile on virtual fks
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:05:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:05:49 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-OM025wX8gB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:05:54 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-3RpH4nrRWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137599&action=edit
Bug 31133: Regression tests (1)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:06:00 +0000
Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on
 catalog search results in the OPAC
In-Reply-To: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26933-70-dK51hyvkBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:06:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:06:01 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-MRf9gbbjt3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137600&action=edit
Bug 31133: Add a way to handle multiple relationships on same column

This patch introduces a syntax for TestBuilder so we can specify which
is the preferred relationship in situations like
Koha::Checkouts::Renewals that have more than one virtual FK [1] for the
same column. In this case, there are the following relationships:

* checkouts
* old_checkouts

both of which link the *checkout_id* column to the *issue_id* column of
the **issues** and **old_issues** tables respectively.

It does so by defining a mapping between the (concatenated, maybe
multiple) related source column and foreign counterpart. The mapping
structure is explained in the POD.

To test:
1. Apply the regression tests
2. Run the tests a couple times:
   $ kshell
  k$ prove t/db_dependent/TestBuilder_multi_vfk.t
=> FAIL: Tests fail often, randomly!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! No random failures!
5. Bonus, run:
   $ kshell
  k$ prove t/db_dependent/TestBuilder.t
=> FAIL: It fails consistently about Koha::Biblio::ItemGroup

[1] i.e. defined at DBIC level but not present on the DB structure.

DISCLAIMER: This is not a complete solution as it still requires a way
to override the hardcoded default. This would require a special syntax
for build() and build_object() which I prefer to delay until we really
need it.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:07:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:07:13 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-umbmb7XVXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, this should cover one part of the problem. There's still
Koha::Biblio::ItemGroup which is failing, ran out of fuel today/yesterday, late
already :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:19:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:19:23 +0000
Subject: [Koha-bugs] [Bug 19556] Added Content ISBN Does Not Match MARC 020
In-Reply-To: <bug-19556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19556-70-bpEyzz99xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19556

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Koha converts ISBN-13 into ISBN-10 for looking up a lot of enhanced content. 

I think that Amazon can only use ISBN-10 so that might be the origin for this
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 05:20:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 03:20:25 +0000
Subject: [Koha-bugs] [Bug 22313] Show cover image on any matching ISBN found
 in a record
In-Reply-To: <bug-22313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22313-70-QzUvKWV1qW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22313

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I think this is a flaw in Koha as well but it is complicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 06:50:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 04:50:44 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-IZwxAS683y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 06:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 04:50:48 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-XYCwhfVNdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137601&action=edit
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 07:37:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 05:37:50 +0000
Subject: [Koha-bugs] [Bug 31135] New: Circulation guided report missing
 biblio table
Message-ID: <bug-31135-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31135

            Bug ID: 31135
           Summary: Circulation guided report missing biblio table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

The circulation guided report uses the 'borrowers', 'statistics', 'items',
'biblioitems' tables but not the 'biblio' table. This seems strange.

Personally, I find the guided report generates very bad reports, but it's a
clear oversight.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 08:51:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 06:51:13 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-uNS3Ro9wAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The last two follow-ups on the above bug fix bugs in restrictions.. happy to
split them out into this bug and another if we want to have them easily
backportable.  I think they can retain PQA though.. they're small and self
contained and well tested as part of the above bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 08:59:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 06:59:56 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-A2VHV3Wo1i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137602&action=edit
Bug 31129: Fix debarment count on circulation page

This patch was split from bug 23681 where QA identified the issue.

This patch fixes the debarment count displayed on the circulation page
tabs

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:00:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:00:33 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-hrAoLWavbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Did you notice that "Bug 30275: (QA follow-up) Trivial fix to schema file"
fixes this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:01:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:01:00 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-ck8jpohzsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:01:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:01:06 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-IC9Qmvcudo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:01:12 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-GSmCMDzkZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:01:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:01:48 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-GheuMzIVN3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Patch split from bug 23681 as promised above.. QA pulled through.  This should
make it very trivial to backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:02:00 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-fB7ecaOvYJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Patron restrictions should be user definable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:02:00 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-VWhh7UxRfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31129


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129
[Bug 31129] Number of restrictions is always "0" on the "Check out" tab
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:03:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:03:37 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-TyUUSNL77G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> Did you notice that "Bug 30275: (QA follow-up) Trivial fix to schema file"
> fixes this problem?

Hum no, it did not!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:06:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:06:54 +0000
Subject: [Koha-bugs] [Bug 31136] New: Restrictions types select fails on
 memberentry page
Message-ID: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

            Bug ID: 31136
           Summary: Restrictions types select fails on memberentry page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

During QA of bug 23681 we spotted some issues with the existing restrictions
code on the member entry page.

This bug serves to split the follow-up I posted there into it's own bug to aid
backports.

(In reply to Katrin Fischer from bug #23681 comment #224)

> 7) When editing the patron record, the pull down for restriction type is
> empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:07:03 +0000
Subject: [Koha-bugs] [Bug 31136] Restrictions types select fails on
 memberentry page
In-Reply-To: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31136-70-NZjNtCI1fD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23681


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
[Bug 23681] Patron restrictions should be user definable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:07:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:07:03 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-TAfkZZdcQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31136


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136
[Bug 31136] Restrictions types select fails on memberentry page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:07:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:07:11 +0000
Subject: [Koha-bugs] [Bug 31136] Restrictions types select fails on
 memberentry page
In-Reply-To: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31136-70-3qG2Re02Xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:07:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:07:24 +0000
Subject: [Koha-bugs] [Bug 31136] Restrictions types select fails on
 memberentry page
In-Reply-To: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31136-70-hX1hjXdxA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:07:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:07:35 +0000
Subject: [Koha-bugs] [Bug 31136] Restrictions types select fails on
 memberentry page
In-Reply-To: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31136-70-9qJWXoFW7R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:09:30 +0000
Subject: [Koha-bugs] [Bug 31136] Restrictions types select fails on
 memberentry page
In-Reply-To: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31136-70-ZzV7jeeVpY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oop.. this one was an actual genuine follow-up the the aforementioned bug.. my
bad.. closing.. this doesn't need backporting at all..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:09:30 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-o52hjEVKb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Bug 23681 depends on bug 31136, which changed state.

Bug 31136 Summary: Restrictions types select fails on memberentry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:11:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:11:53 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-futGG6zkbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137603&action=edit
[ALTERNATIVE-PATCH] Bug 31133: Don't generate values for more than one FK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:13:07 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-5M1eWgRw5y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What about this alternative, Tomas? At least we won't have more code to add for
other specific cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:15:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:15:35 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-IcRleUsxv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
That's pretty elegant and simple.. I like

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:17:34 +0000
Subject: [Koha-bugs] [Bug 31137] New: Error editing label template
Message-ID: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

            Bug ID: 31137
           Summary: Error editing label template
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: adolfo.rodriguez at xercode.es
        QA Contact: testopia at bugs.koha-community.org

While editing a label template, you may choose a Printer Profile for
Patroncards resulting in an error 500 when saving the changes.

Can't bless non-reference value at
/home/adolfo/workspace/koha-master/C4/Creators/Profile.pm line 88

It's the same error described on bug 24001, but in Labels instead of Patron
cards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:18:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:18:43 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-JZYjVaWapn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Christopher Brannon from comment #42)
> I had no idea that I needed to do that.  How can I tell?

It's not entirely trivial to tell.. it's either a good habit to get into to
just run the schema rebuild after applying patches (this is something I've
considered doing by default on the sandboxes, but never had a moment to
implement).. or if you look at the logs you posted the `The method
Some::Koha::Object->some_method_name is not covered by tests!` line is an
indication that it's probably schema build related.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:20:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:20:47 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-UsubPfteiy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The bit you highlight Victor is actually just a comment rather than test
condition.  If I'm honest I'm not sure why that was used as the comment in the
first place, I just used the president set in the rest of the test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:25:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:25:55 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-Tkwjx7ScxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Do you understand the patch here Kyle.. must admit it's way over my head ;-|

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:26:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:26:22 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-xtFmZ3tyDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137603|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137604&action=edit
[ALTERNATIVE-PATCH] Bug 31133: Don't generate values for more than one FK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:27:06 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-fCIRMoBkQf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
It was not working, randomly failing!
The second patch should be correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:28:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:28:05 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-2OfgBeMDhM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Note that I don't get any other failures, t/db_dependent/TestBuilder.t is
passing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:28:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:28:37 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-YA3DWPrm4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137182|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137605&action=edit
Bug 29632: Don't sort cn-sort numerically

When defining our sort fields in we defined all as 'numeric'

For other string containing numbers this is likely correct, however,
for callnumbers it is not. e.g. E45 should sort before E7

This patch adds a new 'callnumber' type and deifnes this for cn-sort and
adds to the field maping a sort without numeric set

To test:
0 - Be using ES with Koha
1 - On records with single item, add callnumbers:
    VA65 E7 R63 1984
    VA65 E7 T35 1990
    VA65 E45 R67 1985
2 - Add public note 'shrimp' or something to make them easily searchable as a
group
3 - Search for 'shrimp', sort by callnumber
4 - Note E45 comes last, it should come first
5 - Apply patch
6 - Reset ES mappings
7 - Reindex ES
8 - Repeat search
9 - Sorting should be correct when set to callnumber

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Michal Urban <michalurban177 at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:28:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:28:41 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-G3RPpEHkPx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137539|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137606&action=edit
Bug 29632: Unit tests

This patch adds unit tests, as well as changing existing test to use a mock
and read the data as passed in tests, rather than relying on what exists in
the DB

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:29:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:29:00 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-NtAe5s0aMb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Nick, Passing QA now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:30:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:30:43 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-TnU9oO8Vfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Note that I don't get any other failures, t/db_dependent/TestBuilder.t is
passing.(In reply to Jonathan Druart from comment #11)
> Note that I don't get any other failures, t/db_dependent/TestBuilder.t is
> passing.

Wrong! Hard morning...

Can't use string ("Koha::Biblio::ItemGroup") as a HASH ref while "strict refs"
in use at /kohadevbox/koha/Koha/Object.pm line 830.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:31:53 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-7lPRHPDgis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Adolfo <adolfo.rodriguez at xercode.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|cnighswonger at foundations.ed |adolfo.rodriguez at xercode.es
                   |u                           |

--- Comment #1 from Adolfo <adolfo.rodriguez at xercode.es> ---
Created attachment 137607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137607&action=edit
Fix Bug 31137 - Error editing label template

This patch filters the printer profiles in the label edition template so you
may only choose Printer Profiles created for Labels.

To test
1 Create a new Printer Profile in Patron Cards
2 Edit a Label template, pick the Printer Profile you just created.
3 Save the Label Template. You get an error 500
4 apply patch, restart services
5 Edit a Label template and check that you can't pick the Printer Profile you
created in Patron Cards

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:35:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:35:27 +0000
Subject: [Koha-bugs] [Bug 30920] Add caching to
 C4::Biblio::GetAuthorisedValueDesc
In-Reply-To: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30920-70-l4Pta2119O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I missed comment 6 entirely.. I'll take a look at your suggestions now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:38:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:38:30 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-YM6dkg50Oi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:39:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:39:36 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-RTP4mm1xeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #544 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137608&action=edit
Bug 24857: Remove object_class from singular classes

Fixes
Can't use string ("Koha::Biblio::ItemGroup") as a HASH ref while "strict refs"
in use at /kohadevbox/koha/Koha/Object.pm line 830.
Can't use string ("Koha::Biblio::ItemGroup::Item") as a HASH ref while "strict
refs" in use at /kohadevbox/koha/Koha/Object.pm line 830.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 09:40:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 07:40:07 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-8jQ3GQGMia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #3)
> Ok, this should cover one part of the problem. There's still
> Koha::Biblio::ItemGroup which is failing, ran out of fuel today/yesterday,
> late already :-D

I've attached a patch on bug 24857 for that: "Bug 24857: Remove object_class
from singular classes".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:08:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:08:13 +0000
Subject: [Koha-bugs] [Bug 31138] New: DataTables is not raising error to the
 end user
Message-ID: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

            Bug ID: 31138
           Summary: DataTables is not raising error to the end user
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Staff Client
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

DataTables is not raising error to the end user, it's only displaying a generic
message in the console.
This leads to lot of questions on IRC or the mailing list ("the table is
empty").
We can do better and display what went wrong.

We could also imagine add a link to the wiki for the more common problems
(won't be implemented here however).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:08:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:08:28 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-y3BAxLLnz5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:12:03 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-YwsyVOtWoq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:12:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:12:07 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-p2Z9p8nyhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137609&action=edit
Bug 31138: Don't ignore DataTables errors and raise them to the end-user

DataTables is not raising error to the end user, it's only displaying a generic
message in the console.
This leads to lot of questions on IRC or the mailing list ("the table is
empty").
We can do better and display what went wrong.

We could also imagine add a link to the wiki for the more common problems
(won't be implemented here however).

Test plan:
Revert "Bug 31104: Put each link on a separate header" and search for a
patron using a very long string
You should get an alert with the reponse of the server.
In my case:
"""
Something went wrong when loading the table.
414: Request-URI Too Long
"""

You can also make the REST API returns a 500 (bad specs or simply with a
die statement).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:25:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:25:47 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-WeTXZ7HK6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137610&action=edit
Bug 31104: Add a selenium test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:26:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:26:07 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-lc1hYIqiRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Will still pass after bug 31138.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:33:08 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-UP1KpDQDhB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #121 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Did you notice that t/db_dependent/selenium/patrons_search.t was failing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:41:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:41:57 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-mhHnpcO1aY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136741|0                           |1
        is obsolete|                            |

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137611&action=edit
Bug 30935: Holds to pull shows wrong first patron

When different patrons have item level holds on the same item, Holds to
pull shows wrong first patron.

Test plan:
1) Place a record-level hold on a biblio with an available item
2) Check the Holds to pull page (circ/pendingreserves.pl)
--> The biblio should appear in the list and the patron should appear in the
'First patron' column
3) Place a second record-level hold on the same biblio
4) Go back to the Holds to pull page
--> The biblio is still there, but the patron in the 'First patron' column is
the second patron
5) Place a third record-level hold on the same biblio
6) Go back to the Holds to pull page
--> The biblio is still there, but the patron in the 'First patron' column is
the third patron
7) Apply the patch
8) Go back to the Holds to pull page
--> The biblio is still there and the patron in the 'First patron' column is
the first patron

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:42:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:42:55 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-cXMyhE68ft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described; thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:43:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:43:05 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-r6ddU7r4Fu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #122 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137612&action=edit
Bug 21978: Fix Selenium tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:43:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:43:42 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-BfydHu5lK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #123 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Is watching the CI after pushing still a thing or...? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:43:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:43:50 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-C9ID6DuZ8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 10:44:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 08:44:55 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-7ZqC3qlriv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #124 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #122)
> Created attachment 137612 [details] [review]
> Bug 21978: Fix Selenium tests

This patch is messy but makes the tests pass. I think the behaviours are
correct (tested using the UI).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:16:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:16:18 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-XUSZ9edrGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #125 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I only see TestBuilder failures on Jenkins at the moment.. so hadn't spotted
this no... thanks for the patch.. I'll take a look to confirm it makes sense
now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:18:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:18:40 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-tiW2eLYZTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #126 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Patch makes sense.. why is this only failing on D11 though and not any of the
other runs?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:32:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:32:38 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-wBPaJUczF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137613&action=edit
Bug 30717: Fix selenium tests

Error while executing command: element not interactable: Element <input
id="tag_952_subfield_w_810691" class="input_marceditor
items.replacementpricedate noEnterSubmit flatpickr-input"
name="items.replacementpricedate" type="hidden"> is not reachable by keyboard
at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:33:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:33:14 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-lhAZSotldq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_21_11_candidate         |additional_work_needed

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
No idea why this is not failing on 21.11 but git bisect led me to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:34:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:34:30 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-InyQqn3QTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hum, we released 22.05 since this. Moving to its own bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:34:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:34:37 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-IlSu89waiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137613|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:34:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:34:48 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-9jqe9nqa2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:35:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:35:48 +0000
Subject: [Koha-bugs] [Bug 31139] New: basic_workflow.t is failing
Message-ID: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

            Bug ID: 31139
           Summary: basic_workflow.t is failing
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Error while executing command: element not interactable: Element <input
id="tag_952_subfield_w_810691" class="input_marceditor
items.replacementpricedate noEnterSubmit flatpickr-input"
name="items.replacementpricedate" type="hidden"> is not reachable by keyboard
at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:36:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:36:51 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-zLQM5ZwZjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Not sure if it's coming from bug 30717 or not. git bisect told me it was the
culprit but we released 22.05 and it seems that we got basic_workflow.t green
since then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:37:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:37:33 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-AisvNFgo5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Selenium fix moved to bug 31139.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:37:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:37:36 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-pYxHv0OHmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:37:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:37:39 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-XhoevvXOfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137614&action=edit
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input
id="tag_952_subfield_w_810691" class="input_marceditor
items.replacementpricedate noEnterSubmit flatpickr-input"
name="items.replacementpricedate" type="hidden"> is not reachable by keyboard
at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the
culprit but we released 22.05 and it seems that we got basic_workflow.t green
since then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:45:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:45:36 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-PdkbQdAoOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137609|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137615&action=edit
Bug 31138: Don't ignore DataTables errors and raise them to the end-user

DataTables is not raising error to the end user, it's only displaying a generic
message in the console.
This leads to lot of questions on IRC or the mailing list ("the table is
empty").
We can do better and display what went wrong.

We could also imagine add a link to the wiki for the more common problems
(won't be implemented here however).

Test plan:
Revert "Bug 31104: Put each link on a separate header" and search for a
patron using a very long string
You should get an alert with the reponse of the server.
In my case:
"""
Something went wrong when loading the table.
414: Request-URI Too Long
"""

You can also make the REST API returns a 500 (bad specs or simply with a
die statement).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:47:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:47:28 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-EjBhR2UFu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as designed.. signing off.

We could go a little further and grab our API error messages from
'responseJSON'.. but I'm not sure if would yield any better results in terms of
people coming and asking for help.. we're still likely to need to ask for more
details to really investigate any problems and as such direct them at the
console and networking log to get those details anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:50:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:50:36 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-BQWHfivF3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #127 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #126)
> Patch makes sense.. why is this only failing on D11 though and not any of
> the other runs?

D11 is the only job that has LIGHT_RUN=0 and run the selenium tests (including
drop+create of the DB and run webinstaller).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:51:36 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-SNndVYF1Hz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:51:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:51:47 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-Tq3n8rvnfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30717

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:51:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:51:47 +0000
Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing
 items
In-Reply-To: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30717-70-Rg0OocPs8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31139

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 11:56:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 09:56:08 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-8KZigHbLf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

--- Comment #128 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Aha, I see.. I'm a little out of date then.. I tended to track D10 as I thought
it was still the most complete run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:10:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:10:48 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-53zhy3T7ZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the sorting of
      release notes|                            |call numbers when using
                   |                            |Elasticsearch. Sorting will
                   |                            |now work correctly for
                   |                            |non-numeric call numbers,
                   |                            |for example, E45 will now
                   |                            |sort before E7.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:10:55 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-NanjmPpc9a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
% git checkout v22.05.02)
% reset_all
% prove t/Ediorder.t

All tests successful.

Works for me. And Jenkins is happy as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:11:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:11:57 +0000
Subject: [Koha-bugs] [Bug 31140] New: TestBuilder.t is failing on item
 groups modules
Message-ID: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

            Bug ID: 31140
           Summary: TestBuilder.t is failing on item groups modules
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:12:03 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-GwcTaUT2vf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857
[Bug 24857] Add ability to group items for records
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:12:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:12:03 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-gl1SSF18g8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31140


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140
[Bug 31140] TestBuilder.t is failing on item groups modules
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:14:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:14:32 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-rgT10tAEwo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
My first implementation was similar to Jonathan's. The 'problem' was that it
randomly generated old_issues and it felt like a very rare use case. It felt
like it was better to just have a default resolution path. I'm fine with
either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:14:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:14:58 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-WuinzfpUDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:15:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:15:02 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-0HSJRlAx1t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137616&action=edit
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:20:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:20:55 +0000
Subject: [Koha-bugs] [Bug 31071] Bug 28321 removed date due in results page
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-gBEhA93TkX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
This one is for you Owen, the line Fridolin pointed in comment 0 has been
removed from master by your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:21:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:21:17 +0000
Subject: [Koha-bugs] [Bug 31141] New: We can remove 'select_column' from
 waiting_holds.inc
Message-ID: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

            Bug ID: 31141
           Summary: We can remove 'select_column' from waiting_holds.inc
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We only call waiting_holds.inc from one template and in both cases we have hard
coded the select_column variable to be passed as true.

As such, we can simplify and just remove the condition entirely.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:24:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:24:14 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-J0PbXrugbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137617&action=edit
Bug 31141: Template simplification

In the only place we use the waiting_holds include, we were hard coded
to always pass the 'select_column' variable as true.

We can simply and clarify the logic by just removing this superflous
variable.

Test plan
1. Confirm that the waiting holds tables continue to display as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:26:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:26:13 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-pTRfklZF1d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:26:18 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-V2Iy7j523U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:26:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:26:39 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-NDHKjxMrWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:27:24 +0000
Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds
 Awaiting Pickup report
In-Reply-To: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27868-70-qE00PsIsGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The checkbox column addition here needs backporting to 21.11 series.. it's a
bug that was introduced by bug 23678

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:29:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:29:32 +0000
Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue
 should be removed when the offending item is returned
In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16882-70-XOpArcKdfB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:34:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:34:12 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-DnUkWRhqAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137618&action=edit
Bug 30970: Add checkbox column to holdst and holdso

This patch adds the missing checkbox column to the columns_settings
configuration file.

The field was added unconditionally to the tables in bug 23678 and then
consequently fixed in master as part of bug 27868 which being an
ehancement wont be backported.  This patch simply lifts the relevant
part of the fix from bug 27868 to apply just to the 21.11.x branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:34:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:34:28 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-4xX6niI5Zf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:34:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:34:34 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-Ha2j7Ynh53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:34:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:34:52 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-GanUbFkxbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23678


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678
[Bug 23678] Cancel holds in bulk
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:34:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:34:52 +0000
Subject: [Koha-bugs] [Bug 23678] Cancel holds in bulk
In-Reply-To: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23678-70-OLq5B73S1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30970


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970
[Bug 30970] holdst columns don't match actual columns in 'Holds waiting'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:35:11 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-J4Kj74MP5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27868

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:35:11 +0000
Subject: [Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds
 Awaiting Pickup report
In-Reply-To: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27868-70-3KFe2lXlNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30970

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 12:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 10:41:09 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-6kpuF5L5IW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:19:59 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and
 list displays and e-mails
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-jAGE3SbYhz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #19 from David Nind <david at davidnind.com> ---
1. Sending email
~~~~~~~~~~~~~~~

Sending email from staff interface - for both the cart and the list I get this
error trace (note: can send email from OPAC for both the cart and list):

Template process failed: file error - biblio_a_href: not found at
/kohadevbox/koha/C4/Templates.pm line 127

    in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127

      124: 
      125:     my $data;
      126:     binmode( STDOUT, ":encoding(UTF-8)" );
      127:     $template->process( $self->filename, $vars, \$data )
      128:       || die "Template process failed: ", $template->error();
      129:     return $data;
      130: }

    Show function arguments
    in (eval) at /kohadevbox/koha/virtualshelves/sendshelf.pl line 111

      108:     );
      109: 
      110:     # Getting template result
      111:     my $template_res = $template2->output();
      112:     my $body;
      113: 
      114:     my $subject;

    in
CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_sendshelf_2epl::__ANON__ at
/kohadevbox/koha/virtualshelves/sendshelf.pl line 2

....

Setup to test email: see comment #15 (note: yourpassword = an app password, not
the normal Gmail password)

2. OPAC - link for host item entry is wrong
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The link in OPAC record detail page to the host item entry is using the staff
interface URL.

Link in OPAC detail view: 
http://127.0.0.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=262

Should be:
http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262

3. Step 15
~~~~~~~~~~

I deleted the 773$w, but the staff interface and OPAC are still showing the
link to the host record.

4. Text 'Host item entry' vs 'In'
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have you seen bug 31106 - text in child record to host item is 'In'.

See also Katrin's comment about the 'label' for 773 in comment #16

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:25:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:25:35 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-5kUOYpG4tf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:25:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:25:39 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-NmejfwNlIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137614|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 137619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137619&action=edit
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input
id="tag_952_subfield_w_810691" class="input_marceditor
items.replacementpricedate noEnterSubmit flatpickr-input"
name="items.replacementpricedate" type="hidden"> is not reachable by keyboard
at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the
culprit but we released 22.05 and it seems that we got basic_workflow.t green
since then.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:26:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:26:06 +0000
Subject: [Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search
 results when an OPAC search is filtered by branch
In-Reply-To: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31114-70-3RjTJ4AG53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

--- Comment #2 from Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> ---
Hi Katrin, thanks for testing this.

I agree this works as expected if all the items attached to a particular record
should be hidden.  In that case I see the same results as you do.

We are seeing the error when a record has multiple items.  We are hiding items
based on their Withdrawn status - withdrawn: [1]

For example:
https://elms.koha-ptfs.co.uk/cgi-bin/koha/opac-search.pl?idx=ti&q=medical+interviews+comprehensive&limit=branch%3ABHL&weight_search=1 

 - The search is filtered to Basildon Healthcare Library (ABH) using
OpacAddMastheadLibraryPulldown.  
 - The search returns 2 results.  
 - The second result has available items at other libraries but the only item
at Basildon is withdrawn.
 - The withdrawn item is not displayed (correctly) but library users find it
confusing that the record is returned at all.  It is felt that having a library
filter on the search should prevent that record being displayed as no items are
available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:27:01 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-9nl4P18bMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Tests fail before applying the patch: prove
t/db_dependent/selenium/basic_workflow.t

2. Tests now pass after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:36:07 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-W9DcnJv40d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:36:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:36:11 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-piV9j0VAX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137616|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 137620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137620&action=edit
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:38:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:38:27 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-BeQVgNuEDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:38:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:38:31 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-H7j2CZQ96k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137617|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137621&action=edit
Bug 31141: Template simplification

In the only place we use the waiting_holds include, we were hard coded
to always pass the 'select_column' variable as true.

We can simply and clarify the logic by just removing this superflous
variable.

Test plan
1. Confirm that the waiting holds tables continue to display as expected

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:38:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:38:56 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-SSz4q0PQ8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I would suggest to improve the commit title to make it more explicit. Maybe
"Remove 'select_column' from waiting_holds.inc"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:48:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:48:18 +0000
Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items
In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26802-70-86soooA4pd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
(In reply to Fridolin Somers from comment #4)
> > - Add pagination to the items table (like is done with other Koha tables) and JS load.
> I suggest this bug focus on this point

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:51:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:51:32 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-vpYzICdTGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:51:37 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-Nggk5hqWOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137622&action=edit
Bug 12225: Re-implement no block flag for checkouts

Test Plan ( assuming Koha Testing Docker or kohadevbox ):
1) Check out master
2) Start the SIP server ( edit the SIP config koha instutution to be
   "CPL" instead of "kohalibrary" )
3) Telnet to 6001
4) Send 9300CNkoha|COkoha|CPCPL|
5) Send 11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN|
6) Note the due date for the checkout in Koha is not in the year 2025:
   Henry Acevedo (23529000035676) checked out Philippics. by Cicero, Marcus
Tullius. 39999000001396
7) Apply this patch set
8) Restart all the things!
9) Check in the checkout
10) Repeat steps 3 through 5
11) Note the due date is now in 2025!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 13:52:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 11:52:21 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-xNJM9Twcpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colin.campbell at ptfs-europe. |kyle at bywatersolutions.com
                   |com                         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:13:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:13:52 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-0YOw38I4cP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137621|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 137623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137623&action=edit
Bug 31141: Template simplification

In the only place we use the waiting_holds include, we were hard coded
to always pass the 'select_column' variable as true.

We can simply and clarify the logic by just removing this superflous
variable.

Test plan
1. Confirm that the waiting holds tables continue to display as expected

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:22:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:22:20 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-ClGoYRwRKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Place some holds for several items.
2. Check items in and confirm holds.
3. Check the list of holds awaiting pickup (Circulation > Holds > Holds
awaiting pickup)
4. After applying the patch, there should be no change to the table and things
should work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:22:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:22:52 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-pJg9cyuFMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Lucy Harrison <l.m.harrison at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |l.m.harrison at lboro.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:41:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:41:28 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-Pg0YfFXB6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137624&action=edit
Bug 31141: Remove 'select_column' from waiting_holds.inc

In the only place we use the waiting_holds include, we were hard coded
to always pass the 'select_column' variable as true.

We can simply and clarify the logic by just removing this superflous
variable.

Test plan
1. Confirm that the waiting holds tables continue to display as expected

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:41:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:41:45 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-e0wSYqQW4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137623|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:42:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:42:01 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-kIxCgzMmD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good call on the commit title, updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:44:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:44:45 +0000
Subject: [Koha-bugs] [Bug 23541] Duplicate Hold Notifications
In-Reply-To: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23541-70-fM6ePU3mNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23541

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shi-yao.wang at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:49:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:49:38 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-qUXZHBSshp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137618|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137625&action=edit
Bug 30970: Add checkbox column to holdst and holdso

This patch adds the missing checkbox column to the columns_settings
configuration file.

The field was added unconditionally to the tables in bug 23678 and then
consequently fixed in master as part of bug 27868 which being an
ehancement wont be backported.  This patch simply lifts the relevant
part of the fix from bug 27868 to apply just to the 21.11.x branch.

Signed-off-by: Lucy Harrison <l.m.harrison at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 14:50:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 12:50:19 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-xZNpw85gQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thankyou for the quick signoff Lucy, I've added your signature to the patch
itself now too for our history.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:04:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:04:27 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-eHBHJ1SgqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137625|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 137626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137626&action=edit
Bug 30970: Add checkbox column to holdst and holdso

This patch adds the missing checkbox column to the columns_settings
configuration file.

The field was added unconditionally to the tables in bug 23678 and then
consequently fixed in master as part of bug 27868 which being an
ehancement wont be backported.  This patch simply lifts the relevant
part of the fix from bug 27868 to apply just to the 21.11.x branch.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:06:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:06:22 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-dS6XVC8uiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:14:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:14:12 +0000
Subject: [Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search
 results when an OPAC search is filtered by branch
In-Reply-To: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31114-70-bBG0T4Y7SZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |trivial
            Version|21.11                       |master

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lucy,

ah! I understand why that would be confusing, but I am not sure how hard it
would be to make it work like this. At the moment the filtering is happening
independent of the search criteria. It could probably also qualify for an
enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:27:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:27:14 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-YJCaXrl8tr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |
                 CC|                            |tomascohen at gmail.com

--- Comment #129 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Thanks for the follow-up, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:30:21 +0000
Subject: [Koha-bugs] [Bug 24857] Add ability to group items for records
In-Reply-To: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24857-70-fn6srzh3XY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed,     |
                   |rel_22_11_candidate         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:31:17 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-eaCARqoTaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |unspecified
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:32:11 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-h2DTgYxn8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:32:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:32:15 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-WmeZYDF6xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137620|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137627&action=edit
Bug 31140: TestBuilder.t is failing on item groups modules

Test Plan:
1) prove t/db_dependent/TestBuilder.t
2) Note failures
3) Apply this patch
4) prove t/db_dependent/TestBuilder.t
5) Note all tests pass!

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:34:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:34:05 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-F8V6oV9wJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:34:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:34:07 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-7M8k0RBjbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:36:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:36:42 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-98BqVz3xQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137610|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137628&action=edit
Bug 31104: Add a selenium test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:45:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:45:22 +0000
Subject: [Koha-bugs] [Bug 31140] TestBuilder.t is failing on item groups
 modules
In-Reply-To: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31140-70-PuvIVYc56L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31140

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137629&action=edit
Bug 31140: (QA follow-up) Remove leftover POD

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:47:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:47:25 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-nlNKJvWgtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137502|0                           |1
        is obsolete|                            |

--- Comment #8 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 137630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137630&action=edit
Bug 30308 - Fix bulkmarcimport.pl broken by
OAI-PMH:AutoUpdateSets(EmbedItemData)

Test plan:

(A) Reproduce the bug:

A1 In Administration > System preferences > Web services:
   - Enable OAI-PMH
   - Enable OAI-PMH:AutoUpdateSets
   - Enable OAI-PMH:AutoUpdateSetsEmbedItemData

A2 In Tools > Export data > Export bibliographic records, export 1 (one)
   biblio record. Be sure that this biblio record has at least one item.
   Don't tick "Don't export items".

A3 Delete the exported biblio record, and its items.

A4 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

A5 Retrieve the biblio record in Koha. Note the absence of the item(s). This is
   the bug.

(B) Apply the patch

B1 Delete the record (without item) loaded at A4.

B2 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

B2 Retrieve the biblio record in Koha. Note the presence of the item(s).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:48:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:48:24 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-eg7wTsrGXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:48:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:48:27 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-7CQ21oC5s3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137631&action=edit
Bug 31023: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:48:31 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-qsSomAcBGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137632&action=edit
Bug 31023: Quote authtypecode in FindDuplicateAuthorities

To test:
0 - Have Koha using Elasticsearch
1 - Set  QueryRegexEscapeOptions to 'unescape escaped'
2 - Attempt to add a new 'GENRE/FORM' authority record
3 - On save you get a 500 error
Unable to understand your search query, please rephrase and try again.
 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 102
4 - Apply patch, restart all
5 - Attempt to add a new 'GENRE/FORM' authority record
6 - Success!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:54:18 +0000
Subject: [Koha-bugs] [Bug 31142] New: Don't generate object for depth > 1
Message-ID: <bug-31142-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31142

            Bug ID: 31142
           Summary: Don't generate object for depth > 1
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We shouldn't need to generate objects the is more than one level deep in the
structure.
For instance if we generate a patron, then the library, we certainly don't need
to generate the SMTP server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:56:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:56:10 +0000
Subject: [Koha-bugs] [Bug 31142] Don't generate object for depth > 1
In-Reply-To: <bug-31142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31142-70-fQ7Db69fPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31142

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137633&action=edit
Bug 31142: Don't generate objects if more than 1 level deep

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 15:57:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 13:57:58 +0000
Subject: [Koha-bugs] [Bug 31142] Don't generate object for depth > 1
In-Reply-To: <bug-31142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31142-70-Me14hdFD75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31142

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Spoiler: this does not work.

For the example in comment 0: SMTP servers are not generate anyway (not a 1-n
relationship but n-n and so it's not generated by TestBuilder).

For t/db_dependent/Circulation.t we are passing from 502 objects to 504, no
gain expected.

The change in the DB structure looks correct however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:03:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:03:11 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-8Q8RCnbPZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bug 28321 removed date due  |Regression: date due
                   |in results page             |removed from staff search
                   |                            |results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:08:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:08:08 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-BgGfTdEMyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:08:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:08:13 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-gP0rnYJ00R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137599|0                           |1
        is obsolete|                            |
 Attachment #137600|0                           |1
        is obsolete|                            |
 Attachment #137604|0                           |1
        is obsolete|                            |

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137634&action=edit
Bug 31133: Don't generate values for more than one FK

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:09:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:09:06 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-86Ic6RCyQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:09:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:09:14 +0000
Subject: [Koha-bugs] [Bug 29662] PrefillItem should apply to all subfields
 when SubfieldsToUseWhenPrefill is null
In-Reply-To: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29662-70-j7E99OF9OV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:09:31 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-eEN6InJlwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:09:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:09:34 +0000
Subject: [Koha-bugs] [Bug 31133] TestBuilder fragile on virtual fks
In-Reply-To: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31133-70-kuqdqeraNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31133

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:15:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:15:09 +0000
Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where
 clause' 500 error in API /api/v1/acquisitions/orders
In-Reply-To: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30677-70-AjlEUrvQVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate,
                   |                            |rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 16:32:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 14:32:08 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-4mPCT4x7Y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 137254
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137254
Bug 31086: DB update

Review of attachment 137254:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31086&attachment=137254)
-----------------------------------------------------------------

::: installer/data/mysql/kohastructure.sql
@@ +4408,4 @@
>    `borrowernumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the borrowers table defining which patron this hold is for',
>    `reservedate` date DEFAULT NULL COMMENT 'the date the hold was placed',
>    `biblionumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the biblio table defining which bib record this hold is on',
> +  `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 0 COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at',

Why DEFAULT 0?  We're throwing an exception if we don't pass a branchcode in
the app... why default to a probably incorrect branch id in SQL.. to me I'd
just drop the DEFAULT entirely and force anyone writing SQL to get thrown an
error when they don't include it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:24:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:24:42 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-r6FMgPcuiG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137254|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137635&action=edit
Bug 31086: DB update

This update sets branchcode as NOT NULL
default set to 0 as borrowernumber is

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:24:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:24:46 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-lYOyxpKEhQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137255|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137636&action=edit
Bug 31086: Throw an exception when a hold is stored with no branchcode

To test:
1 - Apply first 2 patches
2 - On staff client, find a biblio, place hold, select a patron
3 - Before creating hold, right click on 'Pickup location'
4 - Inspect the element
5 - In the console find the top <li> for pickup, and right click
6 - Select 'Delete node'
7 - Save hold
8 - You get an exception/error

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:24:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:24:52 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-2cq2tqBEgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137256|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137637&action=edit
Bug 31086: Prevent placing hold with no pickup location

To test:
1 - Apply patch
2 - Repeat test on previous patch
3 - You should get a warning popup when attempting to save hold
4 - Reload page
5 - Inspect the HTML and manualy set #pickup value of selected option to ""
6 - Attempt to save hold
7 - You get the popup
8 - Place a hold normally (with location) and verify it works

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:24:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:24:56 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-CMkFfJKkYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137257|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137638&action=edit
Bug 31086: DO NOT PUSH: Schema updates

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:25:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:25:00 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-ZXAoep9iZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137258|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137639&action=edit
Bug 31086: Update existing unit tests

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:25:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:25:06 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-tZy6ohIQOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137640&action=edit
Bug 31086: (QA follow-up) Remove DEFAULT from column

There's no need to have a default here, and in fact it doesn't make
sense.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:25:11 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-WkCiykSElF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137641&action=edit
Bug 31086: (QA follow-up) Fix failing tests

This test was missed first time around, branchcode needed adding to all
the calls to AddReserve.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:25:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:25:18 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-MEsic1NsY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137642&action=edit
Bug 31086: (QA follow-up) Add unit tests

This patch adds the unit tests for the change to Koha::Hold::store.

We test for and catch the exception introduced for both the create and
update cases.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:26:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:26:02 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-h2mTCUDb4C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:26:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:26:19 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-GSmllKJYsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All good now with the minor follow-ups.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:30:59 +0000
Subject: [Koha-bugs] [Bug 30778] ModBiblioInBatch is not used and can be
 removed
In-Reply-To: <bug-30778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30778-70-qhXhqUP4cZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30778

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:34:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:34:45 +0000
Subject: [Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Author
 (meeting/conference) when upgrading an authority through Z3950
In-Reply-To: <bug-29260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29260-70-AHF1XvUKlq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:37:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:37:45 +0000
Subject: [Koha-bugs] [Bug 30864] Patron category form - no validation for
 password expiration field
In-Reply-To: <bug-30864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30864-70-JlLo03xjQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:39:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:39:46 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-PfQnzrJmae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134625|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137643&action=edit
Bug 30687: Override hold policy when no valid pickup location

This patch allows hold policy to be overridden when there is no valid
pickup location and AllowHoldPolicyOverride is enabled. This is
re-implementing old behaviour that has been lost.

To test:

1. Go to Administration -> Circulation and fines rules. Ensure there is
a default circulation rule and default reserves policy.
2. Change the library using the dropdown and scroll to the bottom of the
page to set a reserves policy by item type for Library A, which the
following settings:
- Item type: BK
- Reserve policy: From home library
- Reserve pickup library match: any library
- Return policy: Item returns home
3. Go to Administration -> system preferences. Set the
AllowHoldPolicyOverride setting to Allow.
4. Create a biblio with an item where the item's home library is Library
A and the itemtype is BK.
5. Log in to the staff client as a Patron that belongs to Library B.
6. Search for the biblio you just created and try to request a hold for
yourself. Notice there is a blocking notice "Cannot place reserve", the
"Place reserve" button is disabled, and the item has a "No valid pickup
location" error.
7. Apply the patch and refresh the page or re-request the hold.
8. Confirm you can now place the hold, acknowledging that you must
override hold policy to do so (note the exclamation point icon).
9. Set the AllowHoldPolicyOverride system preference to "Don't allow".
10. Repeat Step 6. Confirm you are blocked again from requesting the
hold and cannot override it.

Sponsored-by: Chartered Accountants Australia and New Zealand

Signed-off-by: Daniel <daniel.jones at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:41:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:41:46 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-o80kCdfF61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.jones at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> ---
Signing off as test plan works as described.

One thing I noticed was that I couldn't complete the hold by checking in the
item. Is this expected behaviour?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:43:09 +0000
Subject: [Koha-bugs] [Bug 30713] Patron entry should limit date of birth
 selection to dates in the past
In-Reply-To: <bug-30713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30713-70-ziJUmodI2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:48:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:48:12 +0000
Subject: [Koha-bugs] [Bug 30026] International phone number not supported
 for sending SMS
In-Reply-To: <bug-30026-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30026-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30026-70-ysH4C1tUme@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:51:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:51:20 +0000
Subject: [Koha-bugs] [Bug 30384] Reindent template for ordering from a MARC
 file
In-Reply-To: <bug-30384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30384-70-yQwt1IudV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30384

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Patchset does not apply cleanly to 22.05.x, no backport. 

If needed please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:52:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:52:50 +0000
Subject: [Koha-bugs] [Bug 30388] Fix some errors in the template for
 ordering from a MARC file
In-Reply-To: <bug-30388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30388-70-NFQPT1b2pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30388

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Missing dependencies for 22.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:55:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:55:03 +0000
Subject: [Koha-bugs] [Bug 30849] Make pending patron modification notices on
 staff main page number of modifications at logged in branch
In-Reply-To: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30849-70-j4Il7LRbus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135823|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137644&action=edit
Bug 30849: show pending modifications by branch

To test:
1. Add some borrower modifications from the OPAC from patrons that belong to
some different libraries.
2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons
requesting modifications:' but no way of knowing if they are patrons from your
logged in branch or not
3. Apply patch, restart_all
4. Try step 2 again and now you should see something like 'Patrons requesting
modifications: Centerville: 1 / All libraries: 2';
5. Trying and and fulfilling some modifcations and make sure the numbers on
mainpage.pl are always correct.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:56:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:56:44 +0000
Subject: [Koha-bugs] [Bug 30849] Make pending patron modification notices on
 staff main page number of modifications at logged in branch
In-Reply-To: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30849-70-H4LnuspH9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.jones at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> ---
Works as described, great idea for a feature.

I noticed this creates two links that both lead to the same location. At first
glance it looks like the first link will only take you to patrons of that
library who require approval.

Maybe if it was all one link it would be clearer that the destination is the
same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 17:58:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 15:58:05 +0000
Subject: [Koha-bugs] [Bug 29871] Remove marcflavour param in
 Koha::Biblio->get_marc_notes
In-Reply-To: <bug-29871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29871-70-YYG8C37xNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29871

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:02:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:02:09 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-Yt5WsYjo9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #18 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to David Nind from comment #16)
> Hi Frank.
> 
> I am getting an error message when resetting the mappings after the patch is
> applied (step 5 of the test plan) - this worked without error before the
> patch was applied:
> 
> DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
> execute failed: Data truncated for column 'marc_type' at row 1 at
> /kohadevbox/koha/Koha/Objects.pm line 114
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
>     in DBIx::Class::Exception::throw at
> /usr/share/perl5/DBIx/Class/Exception.pm line 77
> 
>        74:     my $self = { msg => $msg };
>        75:     bless $self => $class;
>        76: 
>        77:     die $self;
>        78: }
>        79: 
>        80: =head2 rethrow
> 
>    .....
> 
> David

Hi David,

I don't get this error. I don't using docker myself but a kohadevbox. I using
the latest debian 11 box to create the koha enviroment with ElasticSearch 6. I
did the following:

1. Creating the koha database instance by using the webinstaller.
2. Loaded demo records into the database (i using kshell when I work with the
records)
perl ../misc4dev/insert_data.pl
rebuild_elasticsearch.pl -d -v
3. Enabling Elasticsearch as search engine in intranet
4. Loading the sample records with bulkmarkimport.pl:
./bulkmarcimport.pl -v -a -file /var/tmp/authorities.mrc -insert -c=MARC21
./bulkmarcimport.pl -v -b -file /var/tmp/biblios.mrc -insert -c=MARC21
5. I verified if the sample records were loaded properly. I experienced that
the authority record was loaded and indexed ok. But the biblio record weren't
indexed for some reason. They seems to have been loaded into the database but
somehow Koha didn't indexed the record. This command worked for me before. I
had to reindex the biblio records again before I applied the patch:
/home/vagrant/kohaclone/misc/search_tools/rebuild_elasticsearch.pl -d -v
6. The sample biblio have topic terms but they are not linked to any authority
records.
7. Applying the patch.
8. Resetting the mappings which work for me without any any errors as described
above.
9. Rebuilding the authority index.
/home/vagrant/kohaclone/misc/search_tools/rebuild_elasticsearch.pl -a -d -v
10. Link bibliographic records to authority records
/home/vagrant/kohaclone/misc/link_bibs_to_authorities.pl -v -l
11. When I search the record, the topic_terms is linked.

Is there some differences between docker and kohadevbox when it comes to
mappings?

Regards,
Frank

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:04:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:04:09 +0000
Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when
 importing an order from a file is invalid
In-Reply-To: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29607-70-eXg7JSVB9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:05:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:05:40 +0000
Subject: [Koha-bugs] [Bug 31143] New: We should attempt to fix/identify all
 cases where '0000-00-00' may still remain in the database
Message-ID: <bug-31143-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143

            Bug ID: 31143
           Summary: We should attempt to fix/identify all cases where
                    '0000-00-00' may still remain in the database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

With the move to more and more of Koha using the REST API's and our rest API's
being suitably strict about date formats, we need to retrospectively correct
occurrences of 0000-00-00 dates appear in database fields system wide.

I've had enough occurrences of bad data still in the database after a number of
upgrade and it biting me in the UI that I think we should now look at
introducing a script to either bulk fix these or at the least identify them and
warn they will cause serious issues going forward.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:11:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:11:00 +0000
Subject: [Koha-bugs] [Bug 30891] SMS provider shows on staff side even if
 SMS::Send driver is not set to "Email"
In-Reply-To: <bug-30891-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30891-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30891-70-gGigAFUY1D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:18:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:18:42 +0000
Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own
 file
In-Reply-To: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30057-70-tQ3joTiThk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:21:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:21:41 +0000
Subject: [Koha-bugs] [Bug 29994] Single label pdf export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-d0ibFKXva0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
The problem occurs when clicking the "Export" button in the table of items,
Actions column. 

To test:
1) If you do not already have label templates and layouts, add some (can use
the settings in comment 2, but any will do)
2) Go to Tools > Label creator > New > Label batch
3) Add one barcode in the box
4) Click Add items
5) Click the 'Export full batch' button
6) Choose the label template and layout
7) Click Export
8) Click Download as PDF
--> PDF is generated
9) In the label batch, select the item (the checkbox on the right)
10) Click 'Export selected items'
11) Repeat steps 6-8
--> PDF is generated
12) In the label batch, click the 'Export' button in the Actions column
13) Repeat steps 6-8
--> No PDF is generated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:23:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:23:11 +0000
Subject: [Koha-bugs] [Bug 30539] Koha upgrade error "Column 'claimed_on'
 cannot be null"
In-Reply-To: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30539-70-HsJ3qyJQP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30539

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:28:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:28:08 +0000
Subject: [Koha-bugs] [Bug 30877] use List::MoreUtils::uniq from
 recalls_to_pull.pl
In-Reply-To: <bug-30877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30877-70-NB4ltNZUP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:32:02 +0000
Subject: [Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
In-Reply-To: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13614-70-y6b8X4BfEj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Doesn't apply clean to 22.05.x, no backport.

If needed please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:39:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:39:01 +0000
Subject: [Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental
In-Reply-To: <bug-30923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30923-70-DgHgOHhCqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:50:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:50:04 +0000
Subject: [Koha-bugs] [Bug 30850] Add default mapping for biblio.author to
 110$a (MARC21)
In-Reply-To: <bug-30850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30850-70-WunbPMcGin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05, if needed please ask!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 18:58:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 16:58:04 +0000
Subject: [Koha-bugs] [Bug 30789] Improve performance of AddBiblio when
 importing records with many items
In-Reply-To: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30789-70-kDzhCyvSMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:14:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:14:56 +0000
Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where
 clause' 500 error in API /api/v1/acquisitions/orders
In-Reply-To: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30677-70-5VwpSHzS8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.x
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #24 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:25:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:25:38 +0000
Subject: [Koha-bugs] [Bug 30789] Improve performance of AddBiblio when
 importing records with many items
In-Reply-To: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30789-70-D7hrToZU01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Performance bugs should be considered bug, not enhancement, remarking.

Please consider for backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:26:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:26:57 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-j9HnQyaBpU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:27:01 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-aGr2pJYsSn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137645&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:36:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:36:40 +0000
Subject: [Koha-bugs] [Bug 30789] Improve performance of AddBiblio when
 importing records with many items
In-Reply-To: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30789-70-xRacWtdA53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:40:16 +0000
Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha
In-Reply-To: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14239-70-s0hkvrxsx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 19:42:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 17:42:57 +0000
Subject: [Koha-bugs] [Bug 25603] Add 001 and 003 to biblio table
In-Reply-To: <bug-25603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25603-70-p0jXn9YR8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25603

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:18:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:18:20 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-SmRCR6xgKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137521|0                           |1
        is obsolete|                            |

--- Comment #44 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137646&action=edit
Bug 12029: Patrons should be able to delete their patron messages

This patch adds an option for patrons to dismiss OPAC messages sent to
them by the staff. The messages remain visible in the staff interface
with an indication that the message has been read.

To test, apply the patch and run the database update.

- View a patron record in the staff interface.
- Click "Add message" and select "OPAC" from the "Add a message for..."
  dropdown.
- Add a message.

- Log in to the OPAC as that patron.
- On the "Your summary" page you should see the message along with a
  "Dismiss" link."
- Clicking the "Dismiss" link should make the message disappear.
- Go to the OPAC home page. The "User summary" box in the right sidebar
  should have the correct count of messages.

- View the patron record in the staff interface again.
- The list of patron messages should still include the message which was
  dismissed via the OPAC, but there should be indication that the
  message was read, e.g. "read 11-2-2022"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:18:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:18:24 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-3IoSqGEtp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137522|0                           |1
        is obsolete|                            |

--- Comment #45 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137647&action=edit
Bug 12029: (follow-up) Adhering to coding guidelines

This is a follow-up patch which (based on comment #19) does
the following:

1) Removes newline from top of Koha/Patron/Messages.pm
2) Changes method Koha::Patron::Messages->unread to ->filter_by_unread
3) Removes method Koha::Patron::Messages->unread_count
4) (Will address tests in separate patch)
5) Removes changes to Koha/Schema/Result/Message.pm
6) Changes atomicupdate from qq{} to q{}
7) (Left for RM)
8) Removes extra copyright statement in opac/dismiss_message.pl
9) Removes extra comments from opac/dismiss_message.pl
10) (Left for now)
11) (Left for now)

Sponsored-by: Horowhenua Library Trust
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:18:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:18:28 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-HQG4IDnN2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137523|0                           |1
        is obsolete|                            |

--- Comment #46 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137648&action=edit
Bug 12029: DBIC Schema

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:15 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-33QUHdn0J0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:18 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-BZSpvH3gC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41551|0                           |1
        is obsolete|                            |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137649&action=edit
Bug 14680: Always subtract discoutn form price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on
the order form
we add the discount to the price, and when it comes form the vendor we subtract
the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:31 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-67JBRzaYLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:40 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-xcmQ6xEvXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #47 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Looks good to me as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:47 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-0ELRYwFzKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29607

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:19:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:19:47 +0000
Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when
 importing an order from a file is invalid
In-Reply-To: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29607-70-O671CSpZqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14680

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:38:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:38:59 +0000
Subject: [Koha-bugs] [Bug 31144] New: When modifying an order we should not
 load the vendor default discount
Message-ID: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

            Bug ID: 31144
           Summary: When modifying an order we should not load the vendor
                    default discount
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:39:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:39:28 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-eXBwtS90Mz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137649|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137650&action=edit
Bug 14680: Always subtract discoutn form price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on
the order form
we add the discount to the price, and when it comes form the vendor we subtract
the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:40:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:40:15 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-EgDkDoBKoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:40:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:40:19 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-uEoQwoJfTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137651&action=edit
Bug 31144: When modifying an order we should not load the vendor default
discount

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:40:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:40:20 +0000
Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file,
 MarcFieldsToOrder-syspref discounts are instead added.
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-4gbTtiipVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:41:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:41:26 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-Ejhsc3rH9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:52:14 +0000
Subject: [Koha-bugs] [Bug 31145] New: Add some defaults for acquisitions in
 TestBuilder
Message-ID: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

            Bug ID: 31145
           Summary: Add some defaults for acquisitions in TestBuilder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:53:21 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-OdFfhXhJVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137651|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137652&action=edit
Bug 31144: When modifying an order we should not load the vendor default
discount

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:53:36 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-x5hT5IUjl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:54:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:54:15 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-ESHkPHrPgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:54:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:54:18 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-WqWM231DgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137653&action=edit
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as
text input fields

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:54:37 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-lsZxCj7NHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
'reset_all' that is

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:54:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:54:54 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-k4yGllbQzw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 20:59:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 18:59:49 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-K86vO1QUoi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Shouldn't we add the index to the configuration on the update?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:04:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:04:09 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-8OUCyG4bSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:04:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:04:14 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-WrfDfSwXS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137653|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137654&action=edit
Bug 31145: Supply defaults for vendors and funds

This is a convenience bug - when koha testing docker creates sample vendors and
budgets there are small issues:

1 - The vendor website gets a random string - you can't edit the vendor without
removing this
2 - The funds have random values for statistical categories, and you get empty
dropdowns when choosing a fund in ordering

To test:
1 - Apply patch
2 - Restart all
3 - Edit 'My vendor'
4 - note webstie is empty and you can save without changing anythign
5 - Add order to basket for my vendor
6 - Confirm that when selecting a fund statistic 1 and statistic 2 remain as
text input fields

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:04:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:04:49 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-U9dRyPsq2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
QA script happy. Simple change. Straight QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:12:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:12:15 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-TGThQdAUUv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:12:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:12:19 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-FqkRIc8y6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137578|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 137655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137655&action=edit
Bug 12225: Fix SIP message templates

If a renewal via SIP would produce an error due to being on reserve, or
exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the
item even if the "no block" flag is set to Y.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:12:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:12:24 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-t6bdcfwwK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137622|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 137656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137656&action=edit
Bug 12225: Re-implement no block flag for checkouts

Test Plan ( assuming Koha Testing Docker or kohadevbox ):
1) Check out master
2) Start the SIP server ( edit the SIP config koha instutution to be
   "CPL" instead of "kohalibrary" )
3) Telnet to 6001
4) Send 9300CNkoha|COkoha|CPCPL|
5) Send 11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN|
6) Note the due date for the checkout in Koha is not in the year 2025:
   Henry Acevedo (23529000035676) checked out Philippics. by Cicero, Marcus
Tullius. 39999000001396
7) Apply this patch set
8) Restart all the things!
9) Check in the checkout
10) Repeat steps 3 through 5
11) Note the due date is now in 2025!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:14:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:14:22 +0000
Subject: [Koha-bugs] [Bug 30806] Use patron-title.inc in member-flags
 template
In-Reply-To: <bug-30806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30806-70-t9lmxl4c7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30806

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:17:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:17:01 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-SXoMmayuCT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #14 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker)

1. To install telnet: apt-get install telnet

2. Restart the SIP server: koha-sip --restart kohadev

3. To access SIP server using telnet: telnet 127.0.0.1 6001

4. To exit telnet: CTRL+] and then quit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:18:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:18:41 +0000
Subject: [Koha-bugs] [Bug 30807] Use patron-title.inc in patron payments
 pages
In-Reply-To: <bug-30807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30807-70-AFu6RfjdgA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30807

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:21:42 +0000
Subject: [Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't
 display in system preferences
In-Reply-To: <bug-27519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27519-70-cqGdrcSTDc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:24:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:24:44 +0000
Subject: [Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961
 (300 shown) .
In-Reply-To: <bug-29312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29312-70-51nXGk6MXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:34:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:34:57 +0000
Subject: [Koha-bugs] [Bug 30768] Typo: pin should be PIN
In-Reply-To: <bug-30768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30768-70-4W4wDp4LLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:37:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:37:03 +0000
Subject: [Koha-bugs] [Bug 30585] Table settings for course_reserves_table
 are wrong due to lack of "Holding library" option
In-Reply-To: <bug-30585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30585-70-Xi0moltGxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:38:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:38:41 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-lIXHvH6ERw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #4 from David Nind <david at davidnind.com> ---
For me, the clear form works initially:
1. Authority finder launched for a tag
2. Clear form is styled as a text link
3. Click 'Clear form' ==> text form fields are cleared
4. For the 'Search main heading ($a only)' change to 'starts with' and enter
perl as the term (don't press the search button)
5. Click 'Clear form' ==> form reset, including options and text entered

However, for step 4, if you click search, and search results are displayed:
1. The 'Clear form' button is now styled as a button, rather than a link
2. Clicking 'Clear form' now only clears the text but not the options
3. The results from the previous search are still displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:43:04 +0000
Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds
 causes all other holds to be prioritized as well!
In-Reply-To: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12630-70-0LIAXT7Sa3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #27 from Lucas Gass <lucas at bywatersolutions.com> ---
Missing dependencies for 22.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:48:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:48:44 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-nrYjXt34JM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:48:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:48:48 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-fu1cVZbiz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137645|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 137657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137657&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:49:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:49:34 +0000
Subject: [Koha-bugs] [Bug 31146] New: Minor UI problem in recalls history in
 OPAC
Message-ID: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

            Bug ID: 31146
           Summary: Minor UI problem in recalls history in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

This is very minor, but I figured it might make an easy fix for someone...

When recalls are turned on, the patron has access to their recalls history in
their online account. If the OPAC is multilingual, the language switcher is
right under the recalls history table, rather than being at the bottom of the
page where it normally is.

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:50:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:50:39 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-7Z9GiiEy0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137658&action=edit
Recalls history page wth language switch in wrong place

This is a screenshot of the recalls history page in the patron's online
account. Note that the language switch is right under the table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:50:51 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-TxC5xDiOsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136055|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:51:31 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-5jjoICHfHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137659&action=edit
Holds history page for comparison

This is a screenshot of the holds history page in the patron's online account.
Note that the language switch is at the bottom left.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:54:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:54:48 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-Op4eji3RJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136055|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:57:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:57:02 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-THwJY2z6fw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 137660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137660&action=edit
Screenshot - due date in search results before and after patch applied

I have signed off, but note that the display seems slightly "off" - see the
screenshots.

Not sure if there is a better way to format this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 21:58:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 19:58:49 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-100wtlJZSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137660|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:00:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:00:27 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-f3wodKTzOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 137661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137661&action=edit
Screenshot - due date in search results before and after patch applied

I have signed off, but note that the display seems slightly "off" - see the
screenshots.

Not sure if there is a better way to format this.

(Have re-added as a PDF)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:15:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:15:54 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-ne2YOX7uGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

--- Comment #6 from AspenCat Team <aspencatteam at clicweb.org> ---
Lucas demonstrated the test plan and I'm signing off on the work - Bob Bennhoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:27:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:27:29 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-MbJ7PuM2wY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:27:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:27:41 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-eUPBoaIWXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137631|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 137662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137662&action=edit
Bug 31023: Unit tests

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:27:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:27:48 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-zPx4gR5RTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137632|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 137663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137663&action=edit
Bug 31023: Quote authtypecode in FindDuplicateAuthorities

To test:
0 - Have Koha using Elasticsearch
1 - Set  QueryRegexEscapeOptions to 'unescape escaped'
2 - Attempt to add a new 'GENRE/FORM' authority record
3 - On save you get a 500 error
Unable to understand your search query, please rephrase and try again.
 at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Search.pm line 102
4 - Apply patch, restart all
5 - Attempt to add a new 'GENRE/FORM' authority record
6 - Success!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 22:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 20:42:38 +0000
Subject: [Koha-bugs] [Bug 31147] New: Recalls due date to the minute rather
 than 23:59
Message-ID: <bug-31147-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147

            Bug ID: 31147
           Summary: Recalls due date to the minute rather than 23:59
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I don't know if this is intended behaviour or a bug.

When placing a recall, the new due date is exactly now + recall due date
interval.

Let's say my recall due date interval is 7 and an item is due 2022-08-31
23:59:00. If I place my recall today (2022-07-12) at 16:31:14, the new due date
will be 2022-07-19 16:31:14.

Like I said, I'm not sure if this is the intended behaviour, but in my very
unknowledgable opinion, I find it a bit extreme to ask someone out of the blue
to return an item by a certain time (to the second).

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) Find a record with a checked out item; check the due date for that checked
out item, e.g.

SELECT date_due FROM issues WHERE itemnumber = XXXX;

--> It should be YYYY-MM-DD 23:59:00

3) In the OPAC, log in as a patron
4) Find the same record and place a recall
5) Check the new due date
--> It should be today + the number of days you put in recall due date interval
in step 1.2 at the exact time you placed the recall

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 12 23:46:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Jul 2022 21:46:16 +0000
Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table
In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30928-70-f7nOD1GlwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

James Donaldson <james.donaldson at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |james.donaldson at montgomeryc
                   |                            |ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 02:40:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 00:40:25 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-3T36SPowZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Ok If I checkout the branch it fails

   Failed test 'Single Gir field OK'
#   at t/Ediorder.t line 104.
#          got: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+CALL:LSM'
#     expected: 'GIR+001+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $lsq_field in hash element at
/home/vagrant/kohaclone/Koha/Edifact/Order.pm line 563.
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 117.

#   Failed test 'First part of split Gir field OK'
#   at t/Ediorder.t line 117.
#          got: undef
#     expected: 'GIR+002+BUDGET:LFN+BRANCH:LLO+TYPE:LST+LOCATION:LSQ+CALL:LSM'
Use of uninitialized value $got in string eq at (eval in cmp_ok) t/Ediorder.t
line 123.

#   Failed test 'Second part of split GIR field OK'
#   at t/Ediorder.t line 123.
#          got: undef
#     expected: 'GIR+002+S_I:LVT'
# Looks like you failed 3 tests of 13.

This is because this test is now db_dependent 
Koha/Edifact/Order.pm:    my $lsq_field =
C4::Context->preference('EdifactLSQ');


So it needs to probably be moved out of t, or that syspref needs to be mocked.
The reason it works is if that syspref is set location. 

If I set the syspref to collection, the tests fail, if i set it location the
tests pass.  
The problem is then when you are building a package you dont have a database,
the t/ tests should all pass without relying on a syspref fetched from a db.

Chris

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 06:23:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 04:23:09 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-eTRkEHZ5xR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Daniel Jones from comment #3)
> Signing off as test plan works as described.
> 
> One thing I noticed was that I couldn't complete the hold by checking in the
> item. Is this expected behaviour?

Do you mean you couldn't set the hold as waiting? Or fill the hold?

What do you mean by complete the hold?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:02:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:02:31 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-9aevDzoMZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137664&action=edit
Bug 30992: Improve translatability for Waiting at|On hold

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:02:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:02:35 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-4ANnvfzziw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137665&action=edit
Bug 30992: Improve translatability for 'for'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:19:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:19:47 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-wqsV8uOSDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137664|0                           |1
        is obsolete|                            |
 Attachment #137665|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137666&action=edit
Bug 30992: Improve translatability for Waiting at|On hold

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:19:51 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-EY6tlmmU4h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137667&action=edit
Bug 30992: Improve translatability for 'for'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:20:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:20:22 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-OJGEhT0XGU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I think those patches are working as you expect.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:30:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:30:53 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-EZqfCCfZyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Remote branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:37:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:37:25 +0000
Subject: [Koha-bugs] [Bug 31148] New: Add link to MARC import tools from
 Cataloging
Message-ID: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

            Bug ID: 31148
           Summary: Add link to MARC import tools from Cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

While the MARC import tools are in the "Tools" module, they're strongly related
to the Cataloging module.

I think it would be good to have links from the Cataloging module page to the
MARC import tools.

We can wrap them in the same permissions that are used on tools-home.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:40:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:40:54 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-XmvUClD0lK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135340|0                           |1
        is obsolete|                            |
 Attachment #135341|0                           |1
        is obsolete|                            |
 Attachment #135342|0                           |1
        is obsolete|                            |
 Attachment #135343|0                           |1
        is obsolete|                            |
 Attachment #135344|0                           |1
        is obsolete|                            |
 Attachment #135345|0                           |1
        is obsolete|                            |
 Attachment #135346|0                           |1
        is obsolete|                            |
 Attachment #135347|0                           |1
        is obsolete|                            |
 Attachment #135348|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137668&action=edit
Bug 30847: Cleanup calculation of holds and rank

Currently we loop over all the holds on the record to get a count of the
reserves not
waiting and a rank for the upcoming hold

We can simply count the number of nont waiting holds and add 1

Note: Before this patch the count of holds included the new hold we were going
to place
which meant rank and count were the same. I believe countaing existing holds
and our
upcoming rank is the correct behavior

To test:
 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their
priorty level'
 2 - Place a few holds on a bib on the staff side
 3 - Mark 1 waiting
 4 - Attempt to place hold on the bib on the opac
 5 - Note 'Your priority' and 'Number of holds' are the same number
 6 - Place another hold, confirm both increase
 7 - Set another hold waiting, confirm both decrease
 8 - Apply patch
 9 - Confirm 'Your priority' is now 1 greater than Number of holds
10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:40:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:40:59 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-alFYe4sS2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137669&action=edit
Bug 30847: Remove unused noreserve parameter

This is defined but never used

To test:
1 - git grep noreserve
2 - only one ocurrence
3 - Apply patch
4 - repeat, no ocurrence
5 - Note the plural has a few uses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:03 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-FB18zM61w8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137670&action=edit
Bug 30847: Remove unused OPACShowHoldQueueDetails

Search for the variables, they aren't used!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:07 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-4yXSaP0BOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137671&action=edit
Bug 30847: Don't fetch patron twice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:11 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-UivuBQtY7G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137672&action=edit
Bug 30847: Avoid fetching biblio object

Here the items biblionumber is either equal to the biblionumber passed in
or it is not and should be - we can just assign directly from the item in all
cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:16 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-wqMt6jLA62@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137673&action=edit
Bug 30847: Don't declrae undef variable for assignment

New holds have found set to undef - we can do this directly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:20 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-ebJWXpe0cM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137674&action=edit
Bug 30847: Don't get biblio/item info when placing holds

The only bit we get form the hash is the rank and title
We can si9mply fetch the biblio once to calculate
no need to fetch all the info as we don't display or use it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:41:24 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-XV2rx62opH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137675&action=edit
Bug 30847: Consolidate code to check if patron can place holds and exit if they
cannot

This wil save us fetching more info if we are denying the holds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:42:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:42:04 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-PipMNE1JuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27272

--- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hi Nick, I have rebased your patches on top of bug 27272, hope you don't mind!
I can also mark myself as assignee of the patches and continue their
integration if you like.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
[Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:42:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:42:04 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-4wKaZVQNHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30847


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847
[Bug 30847] Cleanup opac-reserve.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:54:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:54:14 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
 hold state at branch A kill Koha
In-Reply-To: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28259-70-worpNPNDRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

Anneli Österman <anneli.osterman at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anneli.osterman at koha-suomi.
                   |                            |fi

--- Comment #7 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
We really could need this fix. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:57:25 +0000
Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news
 on homepage
In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29691-70-Gh0nLJrE80@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Do you intend to revisit this Nick?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:58:14 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-U6175CfeeF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #6 from Emmanuel Bétemps <e.betemps at gmail.com> ---
Due date is displayed but instead of this display :

Centerville
Audio Visual
 • 1 Due: 07/19/2022 Music


Could we rather get something like :


Centerville
Audio Visual
 • 1 Music
Due: 07/19/2022

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:58:54 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-4wb8o1aeRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718
[Bug 30718] Use flatpickr's altInput option everywhere
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:58:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:58:54 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-PZ0KKIdjgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30310


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310
[Bug 30310] Replace Moment.js with Day.js
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:59:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:59:35 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-SBp2xr2IWg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:59:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:59:39 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-qzhihAdAQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136507|0                           |1
        is obsolete|                            |
 Attachment #136508|0                           |1
        is obsolete|                            |
 Attachment #136509|0                           |1
        is obsolete|                            |
 Attachment #136510|0                           |1
        is obsolete|                            |
 Attachment #136511|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137676&action=edit
Bug 30310: Add dayjs timezone plugin

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:59:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:59:44 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-CQEoiHVgXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137677&action=edit
Bug 30310: Adjust js-date-format

Test plan:
Confirm that the test plan from bug 24455 is still passing

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:59:48 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-7f0HjWVg0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137678&action=edit
Bug 30310: Remove momentjs

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 08:59:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 06:59:53 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-z1waGYfdVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137679&action=edit
Bug 30310: Adjust about page

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:01:18 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-Nq5DyEN9nK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135495|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:02:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:02:17 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-MQwcIvUURs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:04:42 +0000
Subject: [Koha-bugs] [Bug 30310] Replace Moment.js with Day.js
In-Reply-To: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30310-70-ascRX6zg4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31149


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149
[Bug 31149] Use dayjs to parse dates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:04:42 +0000
Subject: [Koha-bugs] [Bug 31149] New: Use dayjs to parse dates
Message-ID: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149

            Bug ID: 31149
           Summary: Use dayjs to parse dates
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 30310

We don't need our own JS functions to parse date, we can rely on dayjs for
that.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310
[Bug 30310] Replace Moment.js with Day.js
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:05:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:05:12 +0000
Subject: [Koha-bugs] [Bug 30673] Improve is_valid_date function for
 validating date strings
In-Reply-To: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30673-70-EeI1Vr1guI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30673

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31149

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Jonathan Druart from comment #5)
> > Created attachment 134735 [details] [review] [review]
> > Bug 30673: Use moment.js to improve our date parsing
> 
> That's not working well enough but I think we should go into this direction.

Moved to bug 31149.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:05:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:05:12 +0000
Subject: [Koha-bugs] [Bug 31149] Use dayjs to parse dates
In-Reply-To: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31149-70-IcbHUonYcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30673

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:05:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:05:27 +0000
Subject: [Koha-bugs] [Bug 30673] Improve is_valid_date function for
 validating date strings
In-Reply-To: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30673-70-fHo6GYyO1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30673

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134735|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:06:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:06:22 +0000
Subject: [Koha-bugs] [Bug 30673] Improve is_valid_date function for
 validating date strings
In-Reply-To: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30673-70-DmO6gx9XTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30673

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
IMO we should go with bug 31149, not this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:08:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:08:15 +0000
Subject: [Koha-bugs] [Bug 31149] Use dayjs to parse dates
In-Reply-To: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31149-70-l0ordkCjGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:08:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:08:18 +0000
Subject: [Koha-bugs] [Bug 31149] Use dayjs to parse dates
In-Reply-To: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31149-70-GmMWsyuv57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137680&action=edit
Bug 31149: Use dayjs to parse dates

We can use the isValid's dayjs function instead of our own parsing
functions.

Test plan:
Confirm that you cannot enter an invalid date when using a date picker widget.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:08:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:08:44 +0000
Subject: [Koha-bugs] [Bug 31149] Use dayjs to parse dates
In-Reply-To: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31149-70-Tvp1iUmzHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31149

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, oleonard at myacpl.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:25:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:25:19 +0000
Subject: [Koha-bugs] [Bug 31150] New: _on or _date for DB date columns?
Message-ID: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

            Bug ID: 31150
           Summary: _on or _date for DB date columns?
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: martin.renvoize at ptfs-europe.com,
                    nick at bywatersolutions.com, tomascohen at gmail.com

We need to decide a naming for the dates column.
We have _on and _date:

% git grep -c '_date`' installer/data/mysql/kohastructure.sql
installer/data/mysql/kohastructure.sql:14

% git grep -c '_on`' installer/data/mysql/kohastructure.sql 
installer/data/mysql/kohastructure.sql:31

I've tried to find previous discussion but haven't found much.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:25:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:25:43 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-KnIEFvjJZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
DB naming (suffix _date), see bug 31150.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:25:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:25:49 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-Q0OFNx67mO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:27:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:27:14 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-Fp2LJR0TgO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
IRC log, 20200723

<ashimema> remind me of our policy on db column name consistency
<Joubu> There_isNoCon_sistency!
<caroline> lol!
<caroline> maybe this?
https://wiki.koha-community.org/wiki/DBIC_naming_conventions
<Joubu> for a date, should end with _on 
<Joubu> or _date, apparently
<caroline> if above link is not good, let me know and I'll add a warning saying
this is not accurate
<caroline> I don't know for you, but I feel like no column should ever be
called just "id", but somethingid, so that it's the same in all tables
<ashimema> I wrote that guideline I think.
<ashimema> oh.. maybe not.. maybe I wrote the corresponding api one 
<ashimema> I prefer _on.. but don't really like inconsistency within a table
<ashimema> but I also don't want to update other fields in the table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:34:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:34:03 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-mR9KibE8gO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Interesting.. I think we've since settled on _date to stay in line with the
also recent discussions around api field names as described here:
https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4:_mapping

We should update the db fields page you linked to link between the two
definitions and make sure they're consistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:35:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:35:11 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-845TzxyOfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
At 20200129 dev meeting we discussed about _date for the REST API (does it
cover timestamp and datetime as well, etc.)

https://meetings.koha-community.org/2020/development_irc_meeting_29_january_2020.2020-01-29-14.00.log.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:36:45 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-OsFVQCR0OJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
As for existing inconsistencies.. I'd love to fix those but I always get met
with the "This will break reports" argument so in general I've ended up leaving
the DB inconsistent and kept the old field names.

I did have some partners complaining only a day ago that it's really annoying
that our API field names dont match our database field names.. but I do think
the API is much more consistent and better named in general...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:37:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:37:03 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-XfauqMahRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #2)
> Interesting.. I think we've since settled on _date to stay in line with the
> also recent discussions around api field names as described here:
> https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER1.3.4:
> _mapping
> 
> We should update the db fields page you linked to link between the two
> definitions and make sure they're consistent.

We never decided either. Hence this bug report.
See previous comment. If we move to "*_date", does it include datetime and
timestamp, etc. It's not that trivial. And in my mind we decided on "_on", or
at least I picked that because it had the more occurrences in the codebase.

There is no record of a community decision (at least I didn't find one).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:49:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:49:00 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-JhM48rUBBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
There is NO authentication check, everybody (no need to be loggedin) can delete
a message. This is a hard fail.

Really, it would have been better (and easier for everybody) to follow the
usual pattern we have in our scripts, than decide on something that is not
Koha-styled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 09:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 07:51:25 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-AulfIPyqev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
+    my $borrowernumber = $cgi->param('borrowernumber') || undef;

$borrowernumber MUST be retrieved from get_template_and_user (or another
C4::Auth method), not from the query parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 10:22:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 08:22:31 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-ccwKogBdCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

--- Comment #5 from Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> ---
(In reply to Aleisha Amohia from comment #4)
> (In reply to Daniel Jones from comment #3)
> > Signing off as test plan works as described.
> > 
> > One thing I noticed was that I couldn't complete the hold by checking in the
> > item. Is this expected behaviour?
> 
> Do you mean you couldn't set the hold as waiting? Or fill the hold?
> 
> What do you mean by complete the hold?

The hold cannot be filled. Once it is checked in, the book just asks to be
returned to its home library, and not sent to the patron's library.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 10:43:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 08:43:07 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-IY8oILyQTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Must admit, I didn't do a code review here.. just confirmed the feature worked
as described.

As you've adopted this one Owen, feel free to ask for help to update it to more
usual practices.. I'm happy to help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 10:59:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 08:59:23 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-91Du8eFA7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, we dropped the 'DRAFT' part from the API Guidelines wiki page in the
evening of 5th Februrary 2020, and I presume I only did that after we voted and
agreed to it in a meeting.. I'll go hunting.

https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines_-_API&action=historysubmit&diff=24914&oldid=24910

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 11:01:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 09:01:08 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-kyOtzYyArl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Found it.. we voted
https://meetings.koha-community.org/2020/development_irc_meeting_5_february_2020.2020-02-05-20.00.log.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 12:06:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 10:06:10 +0000
Subject: [Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search
 results when an OPAC search is filtered by branch
In-Reply-To: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31114-70-qRB3818pLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 12:09:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 10:09:46 +0000
Subject: [Koha-bugs] [Bug 31114] OpacHiddenItems is not respected in search
 results when an OPAC search is filtered by branch
In-Reply-To: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31114-70-HwULLWBKC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114

--- Comment #4 from Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> ---
Thanks Katrin.  I have marked this as an enhancement.  The libraries in our
larger Koha systems use the library filtering quite a bit so it would be good
if opachiddenitems could be taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 12:10:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 10:10:06 +0000
Subject: [Koha-bugs] [Bug 31150] _on or _date for DB date columns?
In-Reply-To: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31150-70-UPdbfq2xYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Yes, that's for the API, not the DB :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 13:23:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 11:23:44 +0000
Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on
 uncertain prices page
In-Reply-To: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10086-70-RlVX5g1cZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 13:23:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 11:23:48 +0000
Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on
 uncertain prices page
In-Reply-To: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10086-70-GQANfmWJIj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136505|0                           |1
        is obsolete|                            |
 Attachment #136506|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137681&action=edit
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:05:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:05:46 +0000
Subject: [Koha-bugs] [Bug 31151] New: On mobile,
 the sticky menu when viewing a list is very big
Message-ID: <bug-31151-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151

            Bug ID: 31151
           Summary: On mobile, the sticky menu when viewing a list is very
                    big
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

When a patron views their list on mobile, the sticky menu can take up to half
the screen depending on the device.

To test:
1) Using a smartphone or your browser's mobile view tool, go to the OPAC
2) Log in as a patron
3) Create a list
4) Add items to the list (at least 2 or 3)
5) View the list, scroll down
The sticky menu has lots of options New list, download, send list, etc. and it
takes up a lot of space.

I think the sticky menu is fun, but on mobile, it should maybe be a couple of
option plus a burger menu (three lines)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:08:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:08:38 +0000
Subject: [Koha-bugs] [Bug 31151] On mobile,
 the sticky menu when viewing a list is very big
In-Reply-To: <bug-31151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31151-70-aX6LSvsLAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137682&action=edit
List view on 21.05 on iPhone8

This is a screenshot of my phone, an iPhone8, with Safari, viewing a 21.05
OPAC. The sticky menu takes up almost half the screen space.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:18:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:18:08 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-4rcbWSHwZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #69 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
The current patch is quite different than the previous one so I marked the
previous tests as obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:31:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:31:24 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-tE17mruyLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137683&action=edit
Bug 12225: Use ProcessOfflineIssue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:33:08 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-QpAl21A3rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
David, can you test again with the latest patch? It switches to using the
offline circ checkout code. The idea behind "no block" is the patron already
has it. It's basically SIP offline circ ( aka store and forward ) where the
patron already has it so we'd better check it out to them! It makes sense to
use the same code for both.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:39:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:39:09 +0000
Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync
 with upgraded databases
In-Reply-To: <bug-30836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30836-70-Xv37KBID25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi,
                   |                            |nugged at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:45:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:45:13 +0000
Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to
 BackgroundJob
In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27421-70-cSvKBejFGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 16:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 14:50:54 +0000
Subject: [Koha-bugs] [Bug 31151] On mobile,
 the sticky menu when viewing a list is very big
In-Reply-To: <bug-31151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31151-70-Nup8rUR1Fu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31151

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:22:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:22:59 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-SQnFJ0QFcC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:23:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:23:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-UWJbIM25nI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #500 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:23:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:23:06 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-8o9RRdfV6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:23:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:23:09 +0000
Subject: [Koha-bugs] [Bug 31141] We can remove 'select_column' from
 waiting_holds.inc
In-Reply-To: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31141-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31141-70-6GbxfdPB7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31141

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:23:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:23:11 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-sqBMjoDO7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:23:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:23:14 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-RqeOIITBQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:27:53 +0000
Subject: [Koha-bugs] [Bug 31058] Bad import in auto_unsuspend_holds
In-Reply-To: <bug-31058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31058-70-tssPPoHpvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31058

evelyn <evelyn at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |evelyn at bywatersolutions.com

--- Comment #5 from evelyn <evelyn at bywatersolutions.com> ---
Can this be backported to 21.11?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:38:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:38:46 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-742H6REcIF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Not a big deal but this one seems weird to me. Why don't you pass the data you
need instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 17:50:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 15:50:33 +0000
Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-YhVZgx4R29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #45 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
We'd really love to see this feature in Koha.  We don't use pseudonymization as
there are statistics that we pull together where we reference date of birth.

Pseudonymization definitely has a place, but we've developed policies to ensure
that we're processing our collected data in line with GDPR and with consent
granted by our patrons.

The statistics table is the heart of our performance statistics, and having a
permanent record of which category a patron was in would be a major step
forward for us.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 18:20:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 16:20:46 +0000
Subject: [Koha-bugs] [Bug 31145] Add some defaults for acquisitions in
 TestBuilder
In-Reply-To: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31145-70-zZmbWa5GbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31145

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #6)
> Not a big deal but this one seems weird to me. Why don't you pass the data
> you need instead?

TestBuilder is never going to put useful info here, seemed reasonable to
default to NULL

I don't need anything in these, but it did sometime interfere with testing or
demo when fields had to be corrected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 18:22:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 16:22:20 +0000
Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-mOxdjLkSKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 18:24:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 16:24:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-D7Iim54kih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

koha-US bug tracker <bugzilla at koha-us.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 18:48:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 16:48:16 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-f3o4twoEFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Emmanuel Bétemps from comment #6)
> Could we rather get something like

This patch fixes a regression, so it doesn't make changes to the order of the
elements. A separate bug could be filed to talk about improvements to the
display.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 19:17:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 17:17:03 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-nG0cMWG40U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #501 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137684&action=edit
Bug 28854: (follow-up) Replace unique constraint in return claims

This patch fixes the failing test for the return claims api.  We add a
new unique constraint to replace the one we removed earlier in the
patchset. One should not be able to create a duplicate return claim for
the same issue of an item.

Test plan
1) Run the database update
2) Confirm that t/db_dependent/api/v1/return_claims.t now passes
3) Confirm that t/db_dependent/api/v1/items.t continues to pass
4) Bonus points, confirm that bundle checkin still works when items are
   missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 19:19:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 17:19:13 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-4wYhZtSDlq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #502 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Follow-up attached to fix the failing introduced here on master.

Not sure why I didn't think about this constraint replacement in the first
place, it's a nice improvement over the simple removal I did before and
shouldn't have any negative side effects on the feature introduced here.

The follow-up includes an atomic update and the kohaschema change but does not
include the dbic schema build ;P

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 19:24:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 17:24:27 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-DgtsuFZ4z2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137684|0                           |1
        is obsolete|                            |

--- Comment #503 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137685&action=edit
Bug 28854: (follow-up) Replace unique constraint in return claims

This patch fixes the failing test for the return claims api.  We add a
new unique constraint to replace the one we removed earlier in the
patchset. One should not be able to create a duplicate return claim for
the same issue of an item.

Test plan
1) Run the database update
2) Confirm that t/db_dependent/api/v1/return_claims.t now passes
3) Confirm that t/db_dependent/api/v1/items.t continues to pass
4) Bonus points, confirm that bundle checkin still works when items are
   missing

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 19:29:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 17:29:02 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-QeQgmGxWZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 20:25:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 18:25:44 +0000
Subject: [Koha-bugs] [Bug 26170] Create "system" patrons that cannot be
 (easily) deleted via the web UI
In-Reply-To: <bug-26170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26170-70-lMFsVYcKvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #7 from Liz Rea <wizzyrea at gmail.com> ---
Maybe a default attribute of "undeletable," just to be general

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:09:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:09:38 +0000
Subject: [Koha-bugs] [Bug 30399] Patron.t fails when there is a patron
 attribute that is mandatory
In-Reply-To: <bug-30399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30399-70-mrPTTnRN4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:13:07 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-w3Zoftp68A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137657|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137686&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:24:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:24:56 +0000
Subject: [Koha-bugs] [Bug 30924] Fix recalls-related errors in transfers and
 cancelling actions
In-Reply-To: <bug-30924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30924-70-4T1BqjkQBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:28:52 +0000
Subject: [Koha-bugs] [Bug 30914] cleanup_database.pl --transfers
 --old-reserves --confirm does not work
In-Reply-To: <bug-30914-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30914-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30914-70-sKAc8Mw26n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:34:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:34:44 +0000
Subject: [Koha-bugs] [Bug 30798] Columns Home library and Checked out from
 in wrong order on table settings for account_fines table
In-Reply-To: <bug-30798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30798-70-YRIanuwWBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:38:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:38:02 +0000
Subject: [Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in
 news (additional contents) causes inconsistencies
In-Reply-To: <bug-30904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30904-70-PqL1GTcHGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:42:38 +0000
Subject: [Koha-bugs] [Bug 30780] Librarians with only "place_holds"
 permissions can not update holds data via REST API
In-Reply-To: <bug-30780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30780-70-L3wFQbEmhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:53:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:53:07 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30409-70-p4VcFDv02Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #26 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:55:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:55:38 +0000
Subject: [Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs
In-Reply-To: <bug-30917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30917-70-O4auYEMLEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to the 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:56:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:56:39 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29623-70-NAzUgSgQ4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Needs documenting

--- Comment #40 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 21:57:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 19:57:30 +0000
Subject: [Koha-bugs] [Bug 30420] Rename Koha::Patron->get_overdues with
 ->overdues
In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30420-70-OSELF8AAaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Needs documenting

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:01:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:01:39 +0000
Subject: [Koha-bugs] [Bug 30974] Job size not correct for indexing jobs
In-Reply-To: <bug-30974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30974-70-pfGTUgJC59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30974

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:04:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:04:44 +0000
Subject: [Koha-bugs] [Bug 30973] Serials search wrong body id
In-Reply-To: <bug-30973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30973-70-7YoRl6cGd3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30973

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:10:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:10:35 +0000
Subject: [Koha-bugs] [Bug 30954]
 includes/background_jobs_update_elastic_index.inc must be removed
In-Reply-To: <bug-30954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30954-70-kJOobIUDU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30954

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:30:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:30:09 +0000
Subject: [Koha-bugs] [Bug 30938] Fix column configuration to the
 acquisitions home page
In-Reply-To: <bug-30938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30938-70-R1upWT2Z8T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:32:39 +0000
Subject: [Koha-bugs] [Bug 29963] Date accessioned plugin should not
 automatically fill today's date on cataloguing screens
In-Reply-To: <bug-29963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29963-70-wFUVOiCqV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #38 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:34:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:34:32 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-0DFAYlZmio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:39:26 +0000
Subject: [Koha-bugs] [Bug 30925] Creating public list by adding items to new
 list creates a private list
In-Reply-To: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30925-70-xUeE4wCUba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30925

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:43:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:43:12 +0000
Subject: [Koha-bugs] [Bug 30989] Tags with some special characters are not
 encoded right
In-Reply-To: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30989-70-zfclG4lfD1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:54:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:54:19 +0000
Subject: [Koha-bugs] [Bug 31152] New: EasyAnalyticalRecord - trim leading
 whitespace from barcode when linking to host record
Message-ID: <bug-31152-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152

            Bug ID: 31152
           Summary: EasyAnalyticalRecord - trim leading whitespace from
                    barcode when linking to host record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david at davidnind.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When adding analytical record relationships the easy way with the
EasyAnalyticalRecords system preference enabled, any leading whitespace in the
barcode is not trimmed.

To reproduce:
1. Enable the EasyAnalyticalRecord system preference - change to 'Show'.
2. Copy a barcode from any item, for example: 39999000000498
3. For any record with item, select Edit > Link to host record.
4. Enter item barcode:
   - paste the barcode into the input field
   - put spaces before the barcode
   - press 'Select'.
5. Note error message: "ERROR: Unable to get the item number from this
barcode.".

Notes:
- Only leading whitespace causes the error, trailing whitespace does not cause
the error.
- Recent bug 30409 did some work on consolidating barcode checking.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:54:40 +0000
Subject: [Koha-bugs] [Bug 31152] EasyAnalyticalRecord - trim leading
 whitespace from barcode when linking to host record
In-Reply-To: <bug-31152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31152-70-4DmeNrg2mu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30409

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:54:40 +0000
Subject: [Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode
In-Reply-To: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30409-70-hujNz5dCjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31152

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 22:55:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 20:55:29 +0000
Subject: [Koha-bugs] [Bug 31152] EasyAnalyticalRecords - trim leading
 whitespace from barcode when linking to host record
In-Reply-To: <bug-31152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31152-70-lzCZc40RDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31152

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|EasyAnalyticalRecord - trim |EasyAnalyticalRecords -
                   |leading whitespace from     |trim leading whitespace
                   |barcode when linking to     |from barcode when linking
                   |host record                 |to host record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:05:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:05:53 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-OBBamusmah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Emily W <emily.warwas at cedarparktexas.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emily.warwas at cedarparktexas
                   |                            |.gov

--- Comment #4 from Emily W <emily.warwas at cedarparktexas.gov> ---
Recently began having this issue. Digests will be checked when creating the
guarantee but will uncheck once saved. Takes up staff time adding an additional
step to sign up process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:22:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:22:44 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-Ghqp7XRKpS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from David Nind <david at davidnind.com> ---
(In reply to Kyle M Hall from comment #16)
> David, can you test again with the latest patch? It switches to using the
> offline circ checkout code. The idea behind "no block" is the patron already
> has it. It's basically SIP offline circ ( aka store and forward ) where the
> patron already has it so we'd better check it out to them! It makes sense to
> use the same code for both.

Hi Kyle.

I have retested

When I post the command in step 5 with the patches applied and after restarting
everything:
- Telnet exits saying: Connection closed by foreign host.
- The item is not checked out.

Commands entered after applying patches, flush_memcached, restart_all, and
koha-sip --restart kohadev:

telnet 127.0.0.1 6001
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
9300CNkoha|COkoha|CPCPL|
941
11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN|
Connection closed by foreign host.

>From the sip.log:

 87 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 88 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying *:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 89 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 127.0.0.1:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 90 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]: raw_transport:
timeout is 60 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 91 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: read_request trimmed
1 character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 92 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: INPUT MSG:
'9300CNkoha|COkoha|CPCPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
 93 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 94 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPCPL', 'A1A1', '2', ...)
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 95 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: Successful login/auth
for 'koha' of 'CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 96 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: login_core: $VAR1 =
'ILS';
 97  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 98 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: new ILS 'CPL'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 99 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: OUTPUT MSG: '941'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
100 [2022/07/13 21:16:43] [4660] [DEBUG] koha at 127.0.0.1: raw_transport:
uname/inst: 'koha/CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
101 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: read_request trimmed 2
character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
102 [2022/07/13 21:16:56] [4660] [INFO] koha at 127.0.0.1: INPUT MSG:
'11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
103 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '11YY202207...', '11'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
104 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::_initialize('Checkout', 'YY20220711    16350220250711   
163502AOCPL|AA2    3529000035676|AB39999000001396|ACkoha|BON|BIN',
'A1A1A18A18', '38', ...) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
105 [2022/07/13 21:16:56] [4660] [WARN] koha at 127.0.0.1: received no-block
checkout from terminal 'koha' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
106 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: new
ILS::Patron(23529000035676): found patron '23529000035676' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
107 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: new
ILS::Item('39999000001396'): found with title 'Philippics.'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
108 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
ILS::Transaction::Checkout performing checkout... C4::SIP::Sip::siplog
/kohadevbox/koh a/C4/SIP/Sip.pm (220)
109 [2022/07/13 21:16:56] [4660] [INFO] koha at 127.0.0.1: raw_transport: shutting
down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)

I'm assuming all three patches should be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:42:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:42:04 +0000
Subject: [Koha-bugs] [Bug 30836] Elasticsearch mappings.yaml is out of sync
 with upgraded databases
In-Reply-To: <bug-30836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30836-70-IAXMthOHGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30836

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
We ceratinly need to define a good way to patch things in production for the
regular user, leaving room so we don't break more advanced users setups.

If this is not doable, then we need to document better how to reset the
indexes, or provide a tool to let them know they are out of sync.

This is a blocker for several enhancements.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:47:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:47:42 +0000
Subject: [Koha-bugs] [Bug 31153] New: Search bar not visible on recalls
 history page
Message-ID: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

            Bug ID: 31153
           Summary: Search bar not visible on recalls history page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When accessing the 'Recalls history' tab in a patron's file in the staff
interface, the section where the Koha logo and search bar are disappears.

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between
the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:48:40 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-dWU05MgRez@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:48:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:48:45 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-tBjKo8Dx09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127098|0                           |1
        is obsolete|                            |

--- Comment #23 from David Nind <david at davidnind.com> ---
Created attachment 137687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137687&action=edit
Bug 29114: Trim whitespace before the barcode

The solution was to add regexp that trims all whitespaces.

How to test:
1. Go to the koha/virtualshelves/shelves.pl;
2. Add new list or edit existing one;
3. Start adding new items;
4. In the "Barcode" field add barcode(s) with whitespaces before them;
5. Observe that it wasn't added as the barcode isn't recognized because of
whitespaces;
6. Apply the patch;
7. Repeat step 4;
8. Observe that the item was successfully added;

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:49:36 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-i8JFD6gvle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137688&action=edit
Holds history page for comparison

This is the holds history page, for comparison. Note that the logo and search
bar are visible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:50:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:50:31 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-A10jvRR0lD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137689&action=edit
Recalls history page

The is the Recalls history page. Note that the logo and search bar are not
visible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:51:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:51:26 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-mEoTemUfmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

--- Comment #24 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

- Patch still applies.

- Things work as per the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 13 23:56:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 21:56:44 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-GCnxJpUc0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 00:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 22:05:54 +0000
Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
In-Reply-To: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30035-70-U4Al8AhG90@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Reverted from 21.05.x to fix Ubuntu 16.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 00:38:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 22:38:48 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-gCV1QcwR40@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #19 from David Nind <david at davidnind.com> ---
Hi Frank.

I think I'm getting the error because of lines 750-754 from the
admin/searchengine/elasticsearch/mappings.yaml patch.

If I remove those lines, then I can reset the mappings without an error.

NORMARC was removed from Koha from 21.11 - see bug 187984

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 00:47:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 22:47:37 +0000
Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an
 object
In-Reply-To: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28610-70-A4RYfPmV8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #25 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document (not yet full support for ES 7), marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 00:47:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 22:47:38 +0000
Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 -
 ES7
In-Reply-To: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25439-70-STFvGPAAgw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439
Bug 25439 depends on bug 28610, which changed state.

Bug 28610 Summary: Elasticsearch 7 - hits.total is now an object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 00:47:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 22:47:53 +0000
Subject: [Koha-bugs] [Bug 28610] Elasticsearch 7 - hits.total is now an
 object
In-Reply-To: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28610-70-4jk7loAOQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28610

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.05.00,21.11.05           |22.05.00,21.11.05,21.05.17
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 01:02:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 23:02:37 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-HdqzpoyXCc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Passed QA                   |Pushed to oldoldstable
         Version(s)|                            |21.05.17
        released in|                            |

--- Comment #43 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 01:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 23:07:18 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan_status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-j9W9f0S33v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> The bit you highlight Victor is actually just a comment rather than test condition.

Ah, it's just string that pops when the test fails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 01:16:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 23:16:08 +0000
Subject: [Koha-bugs] [Bug 29418] Error searching for analytics in detail view
In-Reply-To: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29418-70-3yDGDO2CdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29418

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Victor Grousset/tuxayo from comment #43)
> Backported: Pushed to 21.05.x branch for 21.05.17

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 01:16:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 23:16:15 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-SeJim2hfaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #70 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> The current patch is quite different than the previous one so I marked the previous tests as obsolete.

Makes sense.
Tests on the new changes are still needed for this to be ready for QA. These
are not trivial changes and AddReturn() in Circulation.pm is like super
critical code ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 01:41:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Jul 2022 23:41:06 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-QzvcF4dQZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #20 from David Nind <david at davidnind.com> ---
I tested (after making the change in comment #19) using koha-testing-docker.

Test plan:

1. Enable Elasticsearch as the search engine (SearchEngine system preference =
Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev).

2. Load sample authority records attached to the bug (in this case the file was
saved in the koha directory - adjust file location as appropriate):[1]
   misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21

3. Load the sample bibliographic record attached to the bug:
   misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert
-c=MARC21

4. Search for ISBN 0704328623 and verify that the subject terms are not linked
to any authority records (if you hover over the link terms, all links should
look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should
have any ?q=an:XXX (where XXX = authority record ids) in the link).

5. Apply the patches.[2]

6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch)).

7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

8. Link bibliographic records to authority records:
misc/link_bibs_to_authorities.pl -v -l

9. Repeat the search in step 4 (or refresh the record details page) and verify
that all the Feminism headings are linked to an authority record (should have
?q=an:XXX (where XXX = different authority record ids for the various feminism
authority records)).[3]

[1] After importing the authorities, I got an error and had to reindex:

    misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21
    Characteristic MARC flavour: MARC21
    .One or more ElasticSearch errors occurred when indexing documents at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.
    .One or more ElasticSearch errors occurred when indexing documents at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.
    .One or more ElasticSearch errors occurred when indexing documents at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.

[2] After applying the patch I edited mappings.yaml to remove the nomarc entry
that was added so the resetting the mappings worked
    vi admin/searchengine/elasticsearch/mappings.yaml -  remove lines 750-754
added by the mapping patch

[3] Not all links to feminism are linked to authority records. Links for
subject terms for step 9 in order are:

    Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria |
Litteratur

    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"

    MARC info:

    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
      0 Authority record control number or standard number
https://id.kb.se/term/sao/Feminism
      2 Source of heading or term sao
    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element feminism
      2 Source of heading or term bnb
    650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Idéhistoria
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Litteratur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 02:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 00:30:44 +0000
Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
 when paying fees in two different libraries
In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30551-70-PA1G8MtQRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Note: was backported to 21.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 02:30:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 00:30:52 +0000
Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
 when paying fees in two different libraries
In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30551-70-s4XXboVNpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 02:48:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 00:48:00 +0000
Subject: [Koha-bugs] [Bug 30551] Cash register report shows wrong library
 when paying fees in two different libraries
In-Reply-To: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30551-70-fd6l7tqRzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
         Version(s)|22.05.00                    |22.05.00,21.05.17
        released in|                            |

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 03:02:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 01:02:18 +0000
Subject: [Koha-bugs] [Bug 31005] Cannot edit patrons in other categories if
 an extended attribute is mandatory and limited to a category
In-Reply-To: <bug-31005-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31005-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31005-70-WTVcxSjj8W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
         Version(s)|22.11.00, 22.05.01,         |22.11.00, 22.05.01,
        released in|21.11.10                    |21.11.10, 21.05.17

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:20 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-JcAxHl5v6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:27 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-iz1938GBSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134304|0                           |1
        is obsolete|                            |

--- Comment #93 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137690&action=edit
Bug 3150: Move emails for sending cart and list contents to notices

This patch creates notices using Template Toolkit syntax for sending
emails containing cart and list contents.

To test:
1. Apply Bug 27266
2. Run update database and restart services
3. In the staff client, add multiple items to your cart and to a list
4. Go to your cart and click Send to email the contents
5. Add an email and a comment and click Send
6. Confirm the information shown in the success message is correct
7. In your terminal, log into the database. View the message queue ( i.e.
select * from message_queue; ). Confirm that your email has been queued and the
content is all correct. Confirm the cart contents has been included as an
attachment.
8. Go to your list and click Send list to email the contents
9. Repeat steps 5-7
10. Log into the OPAC
11. Add multiple items to your cart and to a list
12. Repeat steps 4-9
13. By the end, you should have four emails in your message queue. All
of the data about the items should be correct, they should all have
attachments, and be addressed to the correct email address.

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:33 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-Aa2cehTMi7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134305|0                           |1
        is obsolete|                            |

--- Comment #94 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137691&action=edit
Bug 3150: (follow-up) HTML filtering TT notices and removing old files

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:40 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-g2DYbL3ahe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134306|0                           |1
        is obsolete|                            |

--- Comment #95 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137692&action=edit
Bug 3150: (follow-up) Reformat notices, don't send if no sender email

This patch reformats the notices so that the is_html flag is disabled
and the notices display better

It also throws an error if trying to send an email but the logged in
borrower has no valid email address.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:46 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-9s2cXzoD9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134307|0                           |1
        is obsolete|                            |

--- Comment #96 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137693&action=edit
Bug 3150: (follow-up) Add missing bracket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 07:16:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 05:16:52 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-h1JLEQCZSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134477|0                           |1
        is obsolete|                            |

--- Comment #97 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137694&action=edit
Bug 3150: (follow-up) Fixing errors and notices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 08:23:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 06:23:17 +0000
Subject: [Koha-bugs] [Bug 31154] New: Batch item modification fails when
 "Use default values" is checked
Message-ID: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

            Bug ID: 31154
           Summary: Batch item modification fails when "Use default
                    values" is checked
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

When one tries to batch mod items and has "Use default values" checkbox checked
on, Koha dies on error 500. In logs it reads:

Can't call method "field" on an undefined value at
.../Koha/Koha/UI/Form/Builder/Item.pm line 164.

To test:
1. Find item(s) to modify 
2. Provide barcodes of item(s) to modify and check checkbox "Use default
values"
3. Hit "Continue"
=> error 500 is raised

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:14:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:14:53 +0000
Subject: [Koha-bugs] [Bug 29302] The dataTables Koha RESTful API wrapper
 should allow picking match type at the column level
In-Reply-To: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29302-70-PegfWoeTje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29302

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127358|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137695&action=edit
Bug 29302: Allow passing of 'criteria' at the column level

This patch adds the option to pass 'criteria' at the 'column' definition
level which means you can set 'contains', 'starts_with', 'ends_with' and
'exact' match types for each different column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:19:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:19:02 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-nqUpchiHtp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137686|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137696&action=edit
Bug 31071: Regression: date due removed from staff search results

This patch corrects a regression caused by Bug 28321, which
inadvertently removed the date due from output of item information in
each search result.

To test, apply the patch and perform a catalog search which will return
some results which are checked out and some which aren't. Confirm that
the checked out items show the date due correctly.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:19:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:19:33 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-fTXUWycO5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fixes the regression, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:19:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:19:39 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-QyrxPr4v4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:22:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:22:38 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-wrSMQQaAuZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137526|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137697&action=edit
Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is
blank/empty value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:23:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:23:00 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-8NEG479wQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any chance of a unit test for this Kyle?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:23:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:23:05 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-tzt18y7KWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:25:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:25:59 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-ux0ULrkDDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137446|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137698&action=edit
Bug 31069: fix <span> in OPAC search suggestions (Did you mean)

== test plan ==
1. Enable "Did you mean?":
   . go to Administration > Additional parameters > Did you mean?
   . put a tick in each plugin and save the configuration
2. In the OPAC, search for 'open source'
3. Without the patch you see escaped <span> after "Did you mean:"

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:26:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:26:30 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-TD3r1rSFo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works, PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:27:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:27:14 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-PBy1DHfT4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:31:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:31:08 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-GJfJ9G2bqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137049|0                           |1
        is obsolete|                            |

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137699&action=edit
Bug 11158: Add complete field to authority "starts with" search

This patch adds "complete field" to the authority "starts with"
search so that it uses the untokenized "p" register.

Test plan:
1. Apply the patch
2. koha-plack --restart kohadev
3. Go to http://localhost:8081/cgi-bin/koha/authorities/authorities-home.pl
4. Type in "Espen" into the search box and hit "Submit"
5. Note that there are 3 results
6. Change "contains" to "starts with" and hit "Submit"
7. Note that no results are returned
8. Change the search from "Espen" to "Sandberg" and hit "Submit"
9. Note that 3 results are returned
10. Experiment to your heart's content and rejoice at your new found power

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:31:53 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-mZ0HI37eI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice one David and David!..

It's great to see Zebra having a little love still..

All works as described, so great.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:32:23 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-8Mbp8BLpOd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:36:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:36:42 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-lOKqYkFOWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137447|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137700&action=edit
Bug 27683: Unit test for GetAnalyticsCount

Run prove t/db_dependent/Items/GetAnalyticsCount.t

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:36:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:36:46 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-U0YmJPsRaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137448|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137701&action=edit
Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref

C4::Items::GetAnalyticsCount is part of the easy analytics feature.
Like Bug 20702 make early return when the system preference
EasyAnalyticalRecords is disabled.
Actually it may block an item deletion for wrong reason.

Test plan :
1) Dont apply patch
2) Build an item and a linked analytical record with 773$0 and $9
3) Enable EasyAnalyticalRecords
4) Try to delete the item
5) You have an alert because linked to analytics
6) Disable EasyAnalyticalRecords
7) Try to delete the item
8) You have an alert because linked to analytics
9) Apply patch
10) Try to delete the item
11) No alert, it works :D

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:36:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:36:49 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-RyiYeeqqDH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137449|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137702&action=edit
Bug 27683: Impact on catalogue/detail.pl

Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove
test in catalogue/detail.pl.

Test plan :
1) Build an item and a linked analytical record with 773$0 and $9
2) Go to record detail page
3) Enable EasyAnalyticalRecords
4) You see analytics tab and analytical count on item
5) Disable EasyAnalyticalRecords
6) You dont see analytics tab

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:37:42 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-FL3knv1f2D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great to see these old routines getting a little love and cleanup, thanks
Fridolin..

Tests added, tidy up works as expected.. history confirmed.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:39:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:39:26 +0000
Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file,
 mandatory item subfields that are empty do not block form submission
In-Reply-To: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30268-70-cQCO6w0H6V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136771|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137703&action=edit
Bug 30268: Check mandatory fields in addorderiso2709.pl

Test plan:
1. Make sure you have mandatory item subfields in the MARC bibliographic
   framework used in acquisitions ("ACQ" if it exists, the default framework
   otherwise).
2. Use the "Stage MARC records for import" tool to upload a file. Do not import
   the bibliographic records.
3. Create a new acquisition basket ("Create items when:" must be set to
   "placing an order") and add a new order from a staged file
4. Select the file you just uploaded
5. In the "Items information" tab, make sure at least one mandatory subfield is
   empty
6. Try to submit the form. If there are errors about other mandatory fields
   (like the fund for instance), fix those errors and resubmit. There should be
   an error message about mandatory item subfields.
7. Enter a value for the mandatory item subfields and resubmit the form. Verify
   that the order and the item have been correctly created.

Signed-off-by: Thibault Kero <thibault.keromnes at univ-paris8.fr>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:39:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:39:53 +0000
Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file,
 mandatory item subfields that are empty do not block form submission
In-Reply-To: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30268-70-oErg3cCkVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice improvement, works as described.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:48:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:48:06 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-oaWytJt2bi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Anneli Österman <anneli.osterman at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anneli.osterman at koha-suomi.
                   |                            |fi

--- Comment #1 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
I strongly support the idea to add deleted_on column!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:49:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:49:07 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-tbnhrmUrYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

paxed <pasi.kallinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pasi.kallinen at koha-suomi.fi

--- Comment #2 from paxed <pasi.kallinen at koha-suomi.fi> ---
Deletion time information is very important for statistics reason, AND SHOULD
NOT CHANGE. This ON UPDATE is messing up weeding stats for the libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:50:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:50:51 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-nv4epUiaom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136200|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137704&action=edit
Bug 30447: Check if transfers arrived or cancelled

TO test:
 1 - Find a bib with a single item
 2 - Browse to Circulation->Transfer
 3 - Transfer the item to another branch
 4 - Check the item in at current branch and cancel the transfer on the dialog
 5 - Place a hold on the biblio for a patron at current branch
 6 - Browse to Circulation->Holds to pull
 7 - Item does not show
 8 - Apply patch, restart all
 9 - Browse to Circulation->Holds to pull
10 - Item shows

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:50:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:50:55 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-hvh0ReOHjQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136201|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137705&action=edit
Bug 30447: Unit tests

Added tests to ensure that Koha::Holds->get_items_that_can_fill returns items
with datecancelled and datearrived
Added test for correct number of items for each call of "get_items_that_fill"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:52:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:52:13 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-GgksxWvLvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good catch.

I've still got a second phase of transfers cleanup I'll get back to some time
soon and will make sure we add filter methods there so I don't think we need to
hold back this simple to backport version.

Works as expected and has tests.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:52:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:52:21 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-URG5ciw1Y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:55:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:55:08 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-UE7Fyaj6Nj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136611|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137706&action=edit
Bug 29094: Adding hold via SIP should check if patron can hold item first

When placing holds via SIP2, there is no holdability check. This seems very
incorrect.

Test Plan:
1) Apply this patch
2) prove -r t/db_dependent/SIP

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:55:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:55:44 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-FriGlfAmoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Kyle,

Works as described, contains unit tests and QA scripts are all happy.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 11:55:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 09:55:50 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-hMJVdn8c9f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:33:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:33:52 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-lZah58MPRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137516|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137707&action=edit
Bug 30718: Use flatpickr's altInput

The idea rely on the KohaDates TT plugin for the date formatting. We
should not have any output_pref calls in pl or pm (there are some
exceptions, for ILSDI for instance).

Also flatpickr will deal with the places where dates are inputed. We
will pass the raw SQL value (what we call 'iso' in Koha::DateUtils), and
the controller will receive the same value, no need to additional
conversion.
Note that DBIC has the capability to auto-deflate DateTime objects,
which makes things way easier. We can either pass the value we receive
from the controller, or pass a DT object to our methods.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:39:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:39:18 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-XQvHiYjF5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137708&action=edit
Bug 31120: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:42:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:42:35 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-sVJQN1IiJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137708|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137709&action=edit
Bug 31120: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:50:48 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29623-70-yayzGBtqHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Jonathan, would you say this is eligible for backport? More performance than
enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:52:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:52:09 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-EdTD38XRtK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Some places to test:

1. KohaDates is used instead of html, as we moved the formatting to the
template (and remove the output_pref(dt_from_string)) call from the pl/pm)
2. Places where we retrieve from flatpickr and resent to the template (sticky
due date in circ for instance)
3. REST API - I think I made some changes there as well (but maybe it is on a
follow-up bug, cannot remember)
4. Flatpickr needs to be tested
5. there is as well the cataloguing plugin that is using altInput already
6. Lot of changes in the reports area (I haven't tested at all this module)
7. There is a block commented in Koha::Report that certainly needs attention

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:54:21 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29623-70-UaUDlEDl9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

--- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #41)
> Jonathan, would you say this is eligible for backport? More performance than
> enhancement

We could backport, but I would wait a couple of months to let us time to catch
potential problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:56:53 +0000
Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
 EDI LSQ segments map to 'location' or 'collection'
In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30135-70-2XMT0kgTIR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31134


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134
[Bug 31134] t/Ediorder.t tests failing on 22.05.02
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 12:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 10:56:53 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-cl9mBsBBEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30135
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Martin, can you have a look at this?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135
[Bug 30135] We should allow configuration of whether EDI LSQ segments map to
'location' or 'collection'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:06:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:06:34 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-6wtRUarsch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137710&action=edit
Bug 31134: Mock EdifactLSQ for t/Edifact.t

This patch adds a mock for the EdifactLSQ preference so we can
consistently pass when a database is not available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:06:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:06:48 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-S09fnEtnEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:07:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:07:39 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-8lmT5NBA0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for drawing my attention to this one.. should work with the patch
attached :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:11:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:11:19 +0000
Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
 EDI LSQ segments map to 'location' or 'collection'
In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30135-70-fASX1OBGDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to wainuiwitikapark from comment #22)
> This patch might have introduced a flaw in the tests - when we run

The unit tests are passing for me. I'm wondering how this is even possible as
this test isn't db dependent!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:12:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:12:23 +0000
Subject: [Koha-bugs] [Bug 30135] We should allow configuration of whether
 EDI LSQ segments map to 'location' or 'collection'
In-Reply-To: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30135-70-4RFReLgK5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Kyle M Hall from comment #23)
> (In reply to wainuiwitikapark from comment #22)
> > This patch might have introduced a flaw in the tests - when we run
> 
> The unit tests are passing for me. I'm wondering how this is even possible
> as this test isn't db dependent!

Ah, I was testing on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:14:51 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-ghFaIHPbm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:14:55 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-p9W5r1DxWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137710|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137711&action=edit
Bug 31134: Mock EdifactLSQ for t/Edifact.t

This patch adds a mock for the EdifactLSQ preference so we can
consistently pass when a database is not available.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:18:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:18:50 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-NPc3LIalHl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #22)
> Hi Nick, I have rebased your patches on top of bug 27272, hope you don't
> mind!
> I can also mark myself as assignee of the patches and continue their
> integration if you like.

Thanks! I do not mind at all ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:47:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:47:07 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-hdEyaBjbsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:47:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:47:11 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-tuGjMF11gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137683|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137712&action=edit
Bug 12225: Use ProcessOfflineIssue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 13:48:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 11:48:30 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-fohg4Wbv0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Nind from comment #17)
> I have retested
> When I post the command in step 5 with the patches applied and after
> restarting everything:
> - Telnet exits saying: Connection closed by foreign host.
> - The item is not checked out.

This new version of the patch should fix that! Would you mind giving it another
test David?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:12:35 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-luOviAkZWm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:12:40 +0000
Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag
In-Reply-To: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12225-70-w1X2AEZz4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137712|0                           |1
        is obsolete|                            |

--- Comment #20 from David Nind <david at davidnind.com> ---
Created attachment 137713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137713&action=edit
Bug 12225: Use ProcessOfflineIssue

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:14:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:14:25 +0000
Subject: [Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
In-Reply-To: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30847-70-YQfaLQQpmE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:17:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:17:56 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-o8UEYtlWa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28356

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Nind from comment #42)
> I would like to see 'Consolidate the search code' patch picked up as it
> seemed like an nice tidy up - maybe a separate bug? 

Bug 28356

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:17:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:17:56 +0000
Subject: [Koha-bugs] [Bug 28356] Consolidate header catalogue search box code
In-Reply-To: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28356-70-oLyeqXJJpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28356

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26247

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:18:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:18:14 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-PApu1qm8zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:18:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:18:18 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-I7o9wJD9aR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137711|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137714&action=edit
Bug 31134: Mock EdifactLSQ for t/Edifact.t

This patch adds a mock for the EdifactLSQ preference so we can
consistently pass when a database is not available.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:19:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:19:34 +0000
Subject: [Koha-bugs] [Bug 31079] Entering an empty line on checking of an
 item bundle, gives "Unexpected:" error
In-Reply-To: <bug-31079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31079-70-c0A7QMxg5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Keywords|                            |rel_22_11_candidate
            Version|20.11                       |unspecified
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 14:54:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 12:54:09 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-WifcAdHuEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
I've gone through Acquisitions pages and found only one issue:

- lateorders.pl:
   Can't locate object method "ymd" via package "2010-07-02" (perhaps you
forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line
100

In that error "2020-07-02" is the "Estimated delivery date from:" value I was
trying to filter on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:24:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:24:39 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-w8jYe9EJFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137715&action=edit
Bug 30718: Pass DT to filter_by_lates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:24:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:24:57 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-D67gh0wDRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Owen Leonard from comment #11)
> - lateorders.pl:
>    Can't locate object method "ymd" via package "2010-07-02" (perhaps you
> forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm
> line 100

Fixed, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:43:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:43:32 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-ZdrRjIiYgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:43:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:43:37 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-2p7hTY7FE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137690|0                           |1
        is obsolete|                            |

--- Comment #98 from David Nind <david at davidnind.com> ---
Created attachment 137716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137716&action=edit
Bug 3150: Move emails for sending cart and list contents to notices

This patch creates notices using Template Toolkit syntax for sending
emails containing cart and list contents.

To test:
1. Apply Bug 27266
2. Run update database and restart services
3. In the staff client, add multiple items to your cart and to a list
4. Go to your cart and click Send to email the contents
5. Add an email and a comment and click Send
6. Confirm the information shown in the success message is correct
7. In your terminal, log into the database. View the message queue ( i.e.
select * from message_queue; ). Confirm that your email has been queued and the
content is all correct. Confirm the cart contents has been included as an
attachment.
8. Go to your list and click Send list to email the contents
9. Repeat steps 5-7
10. Log into the OPAC
11. Add multiple items to your cart and to a list
12. Repeat steps 4-9
13. By the end, you should have four emails in your message queue. All
of the data about the items should be correct, they should all have
attachments, and be addressed to the correct email address.

Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:43:44 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-9aJIARZX2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137691|0                           |1
        is obsolete|                            |

--- Comment #99 from David Nind <david at davidnind.com> ---
Created attachment 137717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137717&action=edit
Bug 3150: (follow-up) HTML filtering TT notices and removing old files

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:43:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:43:50 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-86HJcqkbn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137692|0                           |1
        is obsolete|                            |

--- Comment #100 from David Nind <david at davidnind.com> ---
Created attachment 137718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137718&action=edit
Bug 3150: (follow-up) Reformat notices, don't send if no sender email

This patch reformats the notices so that the is_html flag is disabled
and the notices display better

It also throws an error if trying to send an email but the logged in
borrower has no valid email address.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:43:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:43:56 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-c4x1Oucvwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137693|0                           |1
        is obsolete|                            |

--- Comment #101 from David Nind <david at davidnind.com> ---
Created attachment 137719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137719&action=edit
Bug 3150: (follow-up) Add missing bracket

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:44:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:44:03 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-9UNxQGSwDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137694|0                           |1
        is obsolete|                            |

--- Comment #102 from David Nind <david at davidnind.com> ---
Created attachment 137720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137720&action=edit
Bug 3150: (follow-up) Fixing errors and notices

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:58:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:58:42 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29623-70-0sU75b1OCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Martin Renvoize
            contact|                            |
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Internal improvements, no documentation change required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 15:59:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 13:59:10 +0000
Subject: [Koha-bugs] [Bug 30420] Rename Koha::Patron->get_overdues with
 ->overdues
In-Reply-To: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30420-70-WuMsJvrKz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30420

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Martin Renvoize
            contact|                            |
             Status|Needs documenting           |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:02:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:02:40 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-TZt8tUE3tU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #103 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. I ran through the test plan both before and after applying the patches.

2. After the patches are applied, remember to update the database! Otherwise,
the new notices are not added, and you get a warning in the log files:
 [2022/07/14 13:01:00] [WARN] No catalogue LIST letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 583.
  [2022/07/14 13:07:33] [WARN] No catalogue CART letter transported by email at
/kohadevbox/koha/C4/Letters.pm line 583.

3. Enable basic email sending by adding this to the instance koha-conf.xml
(user_name = gmail address, password = app password set up for your account,
not your normal password):

<smtp_server>
    <host>smtp.gmail.com</host>
    <port>587</port>
    <timeout>5</timeout>
    <ssl_mode>STARTTLS</ssl_mode>
    <user_name>youraddress at gmail.com</user_name>
    <password>yourapppassword</password>
    <debug>1</debug>
 </smtp_server>

4. Added an email address to koha user, added email addresses for
KohaAdminEmailAddress and ReplytoDefault (not sure if this was required).

5. Before the patch was applied, steps 3 and 4 were sufficient for the lists
and cart contents to be sent to the email address.

6. After the patches are applied, the messages are now put in the message queue
(koha-mysql kohadev, then select * from message_queue;).

7. To send the messages so you can review them in your email client, run
misc/cronjobs/process_message_queue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:03:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:03:35 +0000
Subject: [Koha-bugs] [Bug 31155] New: Document --since option in help of
 borrowers-force-messaging-defaults.pl
Message-ID: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

            Bug ID: 31155
           Summary: Document --since option in help of
                    borrowers-force-messaging-defaults.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The --since option is not documented at all in the script
borrowers-force-messaging-defaults.pl.

--since

Will only update borrowers enrolled since the specified date.

Examples:

--since "2022-07-13"
--since `date -d "1 day ago" '+%Y-%m-%d'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:05:15 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-Fsm4Y9RYpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

--- Comment #44 from David Nind <david at davidnind.com> ---
(In reply to Nick Clemens from comment #43)
> (In reply to David Nind from comment #42)
> > I would like to see 'Consolidate the search code' patch picked up as it
> > seemed like an nice tidy up - maybe a separate bug? 
> 
> Bug 28356

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:07:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:07:01 +0000
Subject: [Koha-bugs] [Bug 31156] New: Document
 borrowers-force-messaging-defaults.pl in cronjobs chapter
Message-ID: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31156

            Bug ID: 31156
           Summary: Document borrowers-force-messaging-defaults.pl in
                    cronjobs chapter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

I don't know if it can be considered a cronjob, it's mostly a command-line
utility used once, afaik, but I've had to use it as a cronjob for a client who
regularly imports borrowers.

It is not in the manual at all, and I had trouble finding information on all
the options.

=head1 SYNOPSIS

  borrowers-force-messaging-defaults.pl
  borrowers-force-messaging-defaults.pl --help
  borrowers-force-messaging-defaults.pl --doit
  borrowers-force-messaging-defaults.pl --doit --not-expired
  borrowers-force-messaging-defaults.pl --doit --category PT

=head1 DESCRIPTION

If the EnhancedMessagingPreferences syspref is enabled after borrowers have
been created in the DB, those borrowers won't have messaging transport
preferences default values as defined for their borrower category. So you would
have to modify each borrower one by one if you would like to send them 'Hold
Filled' notice for example.

This script creates/overwrites messaging preferences for all borrowers and sets
them to default values defined for the category they belong to (unless you
use the options -not-expired or -no-overwrite to update a subset).

=over 8

=item B<--help>

Prints this help

=item B<--doit>

Actually update the borrowers.

=item B<--not-expired>

Will only update active borrowers (borrowers who didn't pass their expiration
date).

=item B<--no-overwrite>

Will only update patrons without messaging preferences and skip patrons that
already set their preferences.

=item B<--category>

Will only update patrons in the category specified.

See also Bug 31155 for --since option

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:07:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:07:11 +0000
Subject: [Koha-bugs] [Bug 31156] Document
 borrowers-force-messaging-defaults.pl in cronjobs chapter
In-Reply-To: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31156-70-mJyLodHRko@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31156

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr
                   |ity.org                     |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:08:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:08:44 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-1SHw5uktue@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:23:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:23:33 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-SclGDBsMcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:23:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:23:37 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-NpHk5QtGlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137630|0                           |1
        is obsolete|                            |

--- Comment #9 from David Nind <david at davidnind.com> ---
Created attachment 137721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137721&action=edit
Bug 30308 - Fix bulkmarcimport.pl broken by
OAI-PMH:AutoUpdateSets(EmbedItemData)

Test plan:

(A) Reproduce the bug:

A1 In Administration > System preferences > Web services:
   - Enable OAI-PMH
   - Enable OAI-PMH:AutoUpdateSets
   - Enable OAI-PMH:AutoUpdateSetsEmbedItemData

A2 In Tools > Export data > Export bibliographic records, export 1 (one)
   biblio record. Be sure that this biblio record has at least one item.
   Don't tick "Don't export items".

A3 Delete the exported biblio record, and its items.

A4 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

A5 Retrieve the biblio record in Koha. Note the absence of the item(s). This is
   the bug.

(B) Apply the patch

B1 Delete the record (without item) loaded at A4.

B2 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

B2 Retrieve the biblio record in Koha. Note the presence of the item(s).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:26:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:26:03 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-bBnPSTmiyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

--- Comment #10 from David Nind <david at davidnind.com> ---
Thanks Frédéric for the test plan!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:26:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:26:40 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-BX2pv1K38o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:26:44 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-S2pwMyn4To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128901|0                           |1
        is obsolete|                            |
 Attachment #128902|0                           |1
        is obsolete|                            |
 Attachment #128903|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137722&action=edit
Bug 29102: Do not count patron's own hold against limits

This patch makes two changes:
1 - The borrower's own holds are not counted towards HighHolds limit
2 - We exclude all hold counts from CanItemBeReserved

Previously a patron's hold could put the count over the threshhold, and
if the patron is only allowed 1 hold per record, and the hold wasn't found
before
the checkout, it would make all items unholdable, thus lowering the theshhold
for
dynamic HighHolds

To test:
1 - Set sysaprefs:
     decreaseLoanHighHolds  - enable
     decreaseLoanHighHoldsDuration - 1
     decreaseLoanHighHoldsValue - 1
     decreaseLoanHighHoldsControl - dynamic
     decreaseLoanHighHoldsIgnoreStatuses - blank
2 - Set circ rules to allow 1 hold per record and loan period of 5
3 - Find/create a record with 3 items
4 - Place a title level hold for a patron
5 - Attempt to checkout item - note warning about high holds
6 - Cancel checkout
7 - Set decreaseLoanHighHoldsControl - static
8 - Attempt checkout - note warning about high holds
9 - Apply patrch
10 - Checkout item - no warning
11 - checkin item, replace hold
12 - Set decreaseLoanHighHoldsControl - dynamic
13 - Checkout item - no warning
14 - prove t/db_dependent/DecreaseLoanHighHolds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:26:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:26:47 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-KCgdgtjEzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137723&action=edit
Bug 29102: Remove ignore_found_holds

If not counting patrons holds, found or unfound, we no longer need this option
introduced by bug 28078

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:30:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:30:22 +0000
Subject: [Koha-bugs] [Bug 31155] Document --since option in help of
 borrowers-force-messaging-defaults.pl
In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31155-70-rhBW5AvYcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:30:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:30:25 +0000
Subject: [Koha-bugs] [Bug 31155] Document --since option in help of
 borrowers-force-messaging-defaults.pl
In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31155-70-l5JcTKOjKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137724&action=edit
Bug 31155: Document --since option in help of
borrowers-force-messaging-defaults.pl

This patch adds a section about the --since option in the help section
of borrowers-force-messaging-defaults.pl

To test:
0) Apply patch
1) run the script with the --help option, e.g.
./misc/maintenance/borrowers-force-messaging-defaults.pl --help
--> There should be an explanation of the --since option with examples
    for specific and relative dates
2) Optionally, run the script with different options
--> The behaviour shouldn't have changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:34:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:34:16 +0000
Subject: [Koha-bugs] [Bug 30269] Use objects directly to display holds on
 request.pl
In-Reply-To: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30269-70-OsQhsrwLRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:34:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:34:20 +0000
Subject: [Koha-bugs] [Bug 30269] Use objects directly to display holds on
 request.pl
In-Reply-To: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30269-70-gQocstxO5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134548|0                           |1
        is obsolete|                            |
 Attachment #134552|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137725&action=edit
Bug 30269: Use objects directly on request.pl

This patch removes our loop over the hold objects, and simply passes them
directly to the template

Template is adjusted to use ojbects and accessor method
Related objects are prefetched to avoid more DB calls when display
Use of 'iswaiting' and related methods are removed - it is faster to use the
accessor and test

To test:
1 - Place many holds on a record
2 - Set soem waiting, some in transit
3 - View the holds page and note loading time
4 - Apply patch
5 - Reload
6 - Page appears the same
7 - Load time is faster (more with more holds)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:34:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:34:23 +0000
Subject: [Koha-bugs] [Bug 30269] Use objects directly to display holds on
 request.pl
In-Reply-To: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30269-70-UOgPCWaWvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137726&action=edit
Bug 30269: (follow-up) Remove object references as using directly now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:35:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:35:44 +0000
Subject: [Koha-bugs] [Bug 31155] Document --since option in help of
 borrowers-force-messaging-defaults.pl
In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31155-70-TbW7fB3Lp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I copied the syntax from the other options, I hope it's ok. I've never edited
.pl before...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:36:04 +0000
Subject: [Koha-bugs] [Bug 31155] Document --since option in help of
 borrowers-force-messaging-defaults.pl
In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31155-70-CUDqaRyxOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31156

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:36:04 +0000
Subject: [Koha-bugs] [Bug 31156] Document
 borrowers-force-messaging-defaults.pl in cronjobs chapter
In-Reply-To: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31156-70-fppKdcoOrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31156

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31155

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:37:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:37:12 +0000
Subject: [Koha-bugs] [Bug 31155] Document --since option in help of
 borrowers-force-messaging-defaults.pl
In-Reply-To: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31155-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31155-70-X6CqwiMCJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31155

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |brief explanation of the
                   |                            |--since option for
                   |                            |borrowers-force-messaging-d
                   |                            |efaults.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:48:21 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-RgE8Y85dGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136327|0                           |1
        is obsolete|                            |

--- Comment #71 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727&action=edit
Bug 14784: Fix checkin message for restricted patrons

Test plan:
Before

1) Select a user with active indefinite or definite restrictions (manual
restriction works)
2) Make sure finedays=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at checkout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

[1] The "finedays" setting is called "Suspension in days" in the web interface,
if you're searching for it like I did...

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:48:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:48:27 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-y0Q949VUIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #72 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137728&action=edit
Bug 14784: (follow-up) Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:51:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:51:20 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-yl6Pt7DJEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #73 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Added tests and fixed some typos in main patch commit message.

Putting back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 16:58:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 14:58:41 +0000
Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that
 should not be allowed
In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29523-70-n5B2luU74n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:12:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:12:20 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-65a47oDZsP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:12:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:12:23 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-MwUXYXpCwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137729&action=edit
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between
the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:12:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:12:43 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-Fh163Pu3RZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Severity|enhancement                 |minor
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:21:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:21:14 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-DIaFGECoTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137729|0                           |1
        is obsolete|                            |

--- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137730&action=edit
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between
the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:23:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:23:32 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-PcGsbpRCuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:24:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:24:38 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-u1E6Qy0hjC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Thanks Lucas!

I still had my Recalls history page open from yesterday, so I only had to apply
the patch and refresh the page :) It works perfectly!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:29:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:29:29 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-TnsSUADdNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
There is a small mistake in the markup, an unclosed table element.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:31:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:31:41 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-eGbZlTTt9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:31:44 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-rg057X3rfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137731&action=edit
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the
page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:33:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:33:00 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-qeliKK4XXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137731|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:33:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:33:24 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-KlhHPI14ns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:33:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:33:58 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-oJ8Gn34OAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:34:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:34:00 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-DDf1VDkWqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137732&action=edit
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the
page.

https://bugs.koha-community.org/show_bug.cgi?id=31153

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:34:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:34:25 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-IWN4F7y79r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Assignee|oleonard at myacpl.org         |lucas at bywatersolutions.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:36:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:36:05 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-ChfZwulTAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Sorry, attached a patch to the wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:36:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:36:15 +0000
Subject: [Koha-bugs] [Bug 31157] New: overdue_notices.pl --frombranch option
 should be available as a system preference
Message-ID: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

            Bug ID: 31157
           Summary: overdue_notices.pl --frombranch option should be
                    available as a system preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

On a multi-tenant system it is understandable for one client to want one
options for the --frombranch and another to want another.  However, as the
overdue job is run under cron.daily it's not trivial to change it on a per
instance basis.. We should expose this option at the UI level.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:36:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:36:21 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-UYuI5Hcnoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:38:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:38:51 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-LQpFd22d8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I have been wondering if Cataloging should have something similar to
CircSideBar in Ciruclation but with useful links for cataloging, controlled by
a system pref like CatalogingSideBar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:42:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:42:21 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-F0WD4EO8IA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

--- Comment #103 from Heather <heather_hernandez at nps.gov> ---
Hi!  Is https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137408 the
latest update of the Main Menu?  It seems odd that "Lists" is now on a line
with "Advanced Search" and "Item Search," since Lists is very much tied to
one's login--it takes one to one's own lists & the lists one has access to.

I like Reports being moved to a column with Tools and Administration.  But the
"About Koha" logo seems out of place here--should it be next to the Koha logo
at the center bottom of the screen?

I know this is probably only a dream at this point, but it would be great for
the user to be able to click/tap-and-drag these buttons to a custom layout
based on their login, and to hide less often used ones.  I'd have my top
buttons be Cataloging, Authorities, Advanced Search, and Item Search, with my
second row of buttons being Serials, Reports, Tools, Administration, and I'd
hide the Acquisitions button (and access the module via the pull-down menus at
the top).

There's a lovely typo in the pull-down menus at the top, "Catalogage." 
Although I do adore the idea that this makes cataloging seem more en-gaging, it
should probably match the button that says "Cataloging."  And while I'm at it,
can we please standardize Catalog vs. Catalogue, and Cataloging vs.
Cataloguing?  Can we just put the "u" in or leave it out everywhere?  I'd say
put it in, and drag we USians into the spelling of the international community!
 (Next let's work on making us metric.:) )

"Selections pending approval" at the bottom of the left column would be ignored
at my library, and would get pushed down by staff client news.  It's something
that needs paying attention to--it's a, "Hey!  You!  You need to take care of
this!" item, so although I like it over in the column, I'd put it at the top in
an alert color, or prefaced with the login name to catch the eye of the user,
e.g., for me, "Hello, Heather!  Suggestions pending approval..."

I don't have any comments yet on other areas--I don't really use the Basic Bib
Editor, but am eager to see what the Advanced Editor and/or Authorities might
look like.

Lovely work!!  So exciting!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 17:58:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 15:58:44 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-iKyGD1apnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137733&action=edit
Bug 30624: DB Update to add permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:09:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:09:37 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-zeveUeANKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
More notes after having gone through almost everything and tested the basics:

- lateorders.pl:
   Can't locate object method "ymd" via package "2010-07-02" (perhaps you
forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm line
100

- circulation.pl
  Template process failed: undef error - The given date (01.06.2022 11:59 PM)
does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line
205.
 at /kohadevbox/koha/C4/Templates.pm line 127

The above error occurred when checking out and specifying a date in the past.

- overdues.pl The date in the heading is formatted incorrectly: "1 Item overdue
as of 2022-07-14T13:53:00"

- serials/claims.pl: "Template process failed: undef error - : filter not found
at /kohadevbox/koha/C4/Templates.pm line 127"

- tools/holidays.pl "Template process failed: undef error - : filter not found
at /kohadevbox/koha/C4/Templates.pm line 127"

I noticed this in the log for export.pl after testing a date-limited export.
The export completed fine as far as I can tell.

[Thu Jul 14 15:46:05.900437 2022] [cgi:error] [pid 83824] [client
172.18.0.1:62854] AH01215: DBIx::Class::Storage::DBI::_gen_sql_bind(): DateTime
objects passed to search() are not supported properly (InflateColumn::DateTime
formats and settings are not respected.) See ".. format a DateTime object for
searching?" in DBIx::Class::Manual::FAQ. To disable this warning for good set
$ENV{DBIC_DT_SEARCH_OK} to true at /kohadevbox/koha/Koha/Objects.pm line 312:
/kohadevbox/koha/tools/export.pl, referer:
http://127.0.0.1:8081/cgi-bin/koha/tools/export.pl

- Tasks scheduler: "Failed to add Tasks"

I didn't see anything in the error log that appeared to be related to this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:14:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:14:05 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-zwQP6vRA6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137734&action=edit
Bug 31157: Allow selection for overdue from address in the UI

This patch adds a new system preference to allow systems librarians the
option to pick wich address to use for overdues notices.

We default to 'cron' to allow existing uses of '--frombranch' on the
command line to continue to function but now allow end users to override
this option via the new OverdueNoticeFrom preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:14:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:14:19 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-m3W7WExCcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:20:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:20:41 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-KVEaScakWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jake.deery at ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:21:24 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-3PMCvrnGIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com,
                   |                            |kyle.m.hall at gmail.com
          Component|Command-line Utilities      |Circulation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:21:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:21:39 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-ZjEX7lFwes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:26:44 +0000
Subject: [Koha-bugs] [Bug 31156] Document
 borrowers-force-messaging-defaults.pl in cronjobs chapter
In-Reply-To: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31156-70-cH17iUsuYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31156

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/572
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |
             Status|NEW                         |ASSIGNED

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created merge request
https://gitlab.com/koha-community/koha-manual/-/merge_requests/572

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 18:58:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 16:58:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-gaHW5Xe8pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #104 from George Williams (NEKLS) <george at nekls.org> ---
As far as accessibility goes, I don't like putting the search input
(#header_search) in the header and I don't like removing the text labels for
the different types searches and replacing them only with icons.

I have staff that are older and their vision isn't great and relying solely on
icons to select the function of the search input is going to be difficult for
them.

I'd either like to see a return to the text tabs underneath the search input
or, at the very least, making the hint text that appears when you hover over
the icons much, much larger.

The bottom line is that I have staff with vision issues that are going to need
a bigger search input.  The one in the current iteration of this interface is
too small and difficult to read.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 19:09:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 17:09:00 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-EPtiHKjMXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137732|0                           |1
        is obsolete|                            |

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137735&action=edit
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the
page.

https://bugs.koha-community.org/show_bug.cgi?id=31153
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 19:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 17:09:31 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-PusPRmKnrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Thanks for this Lucas! It works perfectly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 19:31:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 17:31:04 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-2wUBAJOMFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #105 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
I agree with George in comment 94.  I am a visually impaired person who finds
this search input display very difficult to read. The input box is not big
enough for me to comfortably use it and the icons are too small to distinguish
from each other without zooming in.

I prefer the text labels underneath the input (maybe because that is what I'm
used to) If the icons could be made much larger and include plenty of space
between them that would help a great deal.

Including the input box in the #header_search makes it less prominent to me. I
would prefer it to have its own dedicated area of the screen.  Additionally,
our library uses the extra white space in the #header_search to add additional
links which have streamlined our operations.  Placing the input box here would
make us lose that ability.

We have an extremely busy Information Desk at out library so staff being able
to clearly see the screen and quickly navigate around while a lot of patrons
are waiting for assistance is of prime importance to us.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 19:58:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 17:58:40 +0000
Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table
In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30928-70-rJy4mhMutY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

raymond.bryson at montgomerycountymd.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |raymond.bryson at montgomeryco
                   |                            |untymd.gov

--- Comment #1 from raymond.bryson at montgomerycountymd.gov ---
It would be incredibly useful to have the interface added to the statistics
table. Our use case is this - 

We need to calculate self-checkout percentage, by library location. 

At the system-wide level (all branches), we can do this using the action_logs
table. However, if we need granularity at the library branch level, we
currently cannot provide accurate data for reporting/comparisons.  

For our use case, we would use the interface to compare Intranet (staff) vs SIP
(self-checkouts), at the branch level.

There are other use cases where the interface (context) at the branch level
might be useful too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:03:31 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-It4O5YbBvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
To test:
1) Apply patch
2) Put different email addresses in branch A and branch B (doesn't have to be
real email addresses, I used centerville at centerville.com and midway at midway.com)
   2.1) Go to Administration > Libraries
   2.2) Edit branch A (e.g. Centerville)
   2.3) Enter an email address in 'Email'
   2.4) Save
   2.5) Repeat steps 2.1 to 2.4 for branch B (e.g. Midway), making sure it is a
different email address
3) Set up overdue notice triggers
   3.1) Go to Tools > Overdue notice/status triggers
   3.2) Enter a number of days for a patron category (e.g. Patron)
   3.3) Choose a letter to be sent (e.g. Overdue notice)
   3.4) Check the 'Email' box
   3.5) Save
4) Checkout an item from branch A to a patron while logged in at branch B
   4.1) In the top right corner, make sure you are connected at branch B (if
not, click the branch name and choose set library)
   4.1) Go to Patrons
   4.2) Search for or add a patron in the patron category from 3.2
   4.3) Go to 'Check out'
   4.4) Click 'Checkout settings' and select a due date in the past, equal or
greater than the number of days from 3.2
   4.5) Enter a barcode from an item from branch A and check out
5) Generate overdue notice
   5.1) In a terminal, run overdue_notices.pl (without any options)
   5.2) Search the database for the from_address of the overdue notice
        SELECT from_address FROM message_queue WHERE borrowernumber = XX;
   --> It should be branch B (script defaults to item-issuebranch)
6) Change OverdueNoticeFrom system preference to item home library
   6.1) Go to Administration > Global system preferences
   6.2) Search for OverdueNoticeFrom
   6.3) Choose the 'item home library' option
   6.4) Save
7) Delete notice and repeat
   7.1) Delete the notice from the database 
        DELETE FROM message_queue WHERE borrowernumber = XX;
   7.2) Repeat step 5
   --> The from_address should be branch A
8) Change OverdueNoticeFrom system preference to 'checkout library'
9) Delete notice and repeat
   --> The from_address should be branch B


I tried the following combinations
Item home library A, Checkout library B, syspref = system default,    cron = no
option                     --> from_address is branch B (script defaults to
item-issuebranch)
Item home library A, Checkout library B, syspref = item home library, cron = no
option                     --> from_address is branch A (item home library
according to syspref)
Item home library A, Checkout library B, syspref = checkout library,  cron = no
option                     --> from_address is branch B (checkout library
according to syspref)
Item home library A, Checkout library B, syspref = system default,    cron =
--frombranch item-homebranch  --> from_address is branch A (item home library
according to cron)
Item home library A, Checkout library B, syspref = system default,    cron =
--frombranch item-issuebranch --> from_address is branch B (checkout library
according to cron)
Item home library A, Checkout library B, syspref = item home library, cron =
--frombranch item-issuebranch --> from_address is branch A (syspref overrides
cron)
Item home library A, Checkout library B, syspref = checkout library,  cron =
--frombranch item-homebranch  --> from_address is branch B (syspref overrides
cron)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:04:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:04:30 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-8rE7RyRO4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:04:34 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-CoYUygebmB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137734|0                           |1
        is obsolete|                            |

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137736&action=edit
Bug 31157: Allow selection for overdue from address in the UI

This patch adds a new system preference to allow systems librarians the
option to pick wich address to use for overdues notices.

We default to 'cron' to allow existing uses of '--frombranch' on the
command line to continue to function but now allow end users to override
this option via the new OverdueNoticeFrom preference.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:46:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:46:59 +0000
Subject: [Koha-bugs] [Bug 30673] Improve is_valid_date function for
 validating date strings
In-Reply-To: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30673-70-Y3hWmxnv5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30673

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we mark this WONTFIX then or would this still be good for
backports/older versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:58:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:58:13 +0000
Subject: [Koha-bugs] [Bug 31158] New: Can't filter suggestions by suggestion
 date range
Message-ID: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158

            Bug ID: 31158
           Summary: Can't filter suggestions by suggestion date range
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

On the suggestions home page I expanded the "Suggestions information" sidebar
filter, then entered dates in the "Suggested date from:" and "To:" fields.

When I submit I get an error:

DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st
execute failed: Unknown column 'suggesteddate_from' in 'where clause' at
/kohadevbox/koha/Koha/Objects.pm line 394
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 20:59:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 18:59:37 +0000
Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets
In-Reply-To: <bug-23524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23524-70-OEuYeL9H18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |kelly at bywatersolutions.com

--- Comment #2 from Donna <bwsdonna at gmail.com> ---
To me, lock means nothing changes.  So no changing of fund amounts, no
adding/removing funds, and no ordering/receiving.  

Active/inactive makes sense for whether or not I can use the money in the
budget, where lock means it has been finalized/closed out and nothing should
change in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:08:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:08:30 +0000
Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on
 uncertain prices page
In-Reply-To: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10086-70-NkuaSAxxjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:08:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:08:34 +0000
Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on
 uncertain prices page
In-Reply-To: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10086-70-x1GnTNFanD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137681|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 137737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137737&action=edit
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:18:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:18:02 +0000
Subject: [Koha-bugs] [Bug 10086] No way to go back to the basket on
 uncertain prices page
In-Reply-To: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10086-70-DqzRsIi3sX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10086

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This updates the display of
      release notes|                            |the uncertain prices page
                   |                            |(Acquisitions > Uncertain
                   |                            |prices):
                   |                            |1. The basket name
                   |                            |is now linked to the basket
                   |                            |in the list of orders with
                   |                            |uncertain prices, making it
                   |                            |easier to quickly view the
                   |                            |basket.
                   |                            |2. The edit link is
                   |                            |now formatted as a button
                   |                            |and moved into a column
                   |                            |(similar to other areas),
                   |                            |instead of being a text
                   |                            |link in the order column.
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:22:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:22:32 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-HjmOb0hfvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #1)
> I have been wondering if Cataloging should have something similar to
> CircSideBar in Ciruclation but with useful links for cataloging, controlled
> by a system pref like CatalogingSideBar.

Martin and I just discussed this - adding him CC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:26:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:26:40 +0000
Subject: [Koha-bugs] [Bug 31147] Recalls due date to the minute rather than
 23:59
In-Reply-To: <bug-31147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31147-70-xo47PyWVq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Blocks|                            |29734

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this qualifies as a bug, because it could cause issues (see bug 27442).
It will also create a display issue with the time showing.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:26:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:26:40 +0000
Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29734-70-no72oseKtQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31147


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147
[Bug 31147] Recalls due date to the minute rather than 23:59
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:26:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:26:54 +0000
Subject: [Koha-bugs] [Bug 30883] Authorities merge is limited to 100 biblio
 with Elasticsearch
In-Reply-To: <bug-30883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30883-70-WWtCwjNQ1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30883

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
         Version(s)|22.11.00, 22.05.01,         |22.11.00, 22.05.01,
        released in|21.11.10                    |21.11.10, 21.05.17

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Can't reproduce on 21.05.x

7) Perform a search 'an:111'
   without patch you get 100 results
   with patch you get no results
8) Perform a search 'an:222'
   without patch you get 102 results
   with patch you get 202 results


With and without the patch, I always get the original number of results. Even
if the 1st auth doesn't exist anymore.
Note: I used preexisting authorities on sample data. respectively 1 (used in
152 records) and 101 (used in 4 records)
Any idea? Does this show merge is completely broken in 21.05.x ? Maybe I used
it badly.

Anyway, the code very simple and safe so I don't think it's related:
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:34:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:34:36 +0000
Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29734-70-wxU5amYpuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31153


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153
[Bug 31153] Search bar not visible on recalls history page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:34:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:34:36 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-HhtwSTHx6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:35:51 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-8fPThFK1c1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:36:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:36:25 +0000
Subject: [Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha
In-Reply-To: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29734-70-IOql4mJubw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/573

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:39:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:39:11 +0000
Subject: [Koha-bugs] [Bug 30234] Serial local covers don't appear in the
 staff interface for other libraries with SeparateHoldings
In-Reply-To: <bug-30234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30234-70-E727Esf4L6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Version(s)|22.11.00, 22.05.01,         |22.11.00, 22.05.01,
        released in|21.11.10                    |21.11.10, 21.05.17
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #28 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:39:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:39:12 +0000
Subject: [Koha-bugs] [Bug 30972] "Replace existing covers" checkbox replaces
 ALL local covers for a biblio, not only the specific item's covers
In-Reply-To: <bug-30972-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30972-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30972-70-haGuZPzaQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30972
Bug 30972 depends on bug 30234, which changed state.

Bug 30234 Summary: Serial local covers don't appear in the staff interface for other libraries with SeparateHoldings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 21:39:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 19:39:12 +0000
Subject: [Koha-bugs] [Bug 30976] Cover images for biblio should be displayed
 first
In-Reply-To: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30976-70-lOjNTVxXeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30976
Bug 30976 depends on bug 30234, which changed state.

Bug 30234 Summary: Serial local covers don't appear in the staff interface for other libraries with SeparateHoldings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:21:24 +0000
Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even
 when not running
In-Reply-To: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30684-70-RSsEDR5iRp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:22:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:22:19 +0000
Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even
 when not running
In-Reply-To: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30684-70-6rh11OFs8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135747|0                           |1
        is obsolete|                            |

--- Comment #19 from David Nind <david at davidnind.com> ---
Created attachment 137738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137738&action=edit
Bug 30684: When a service isn't running koha-* scripts --restart should start
it

Test plan:
1. Stop plack, indexer, sip, worker, z3950 and zebra.

Note: To test Z39.50 restarting you will need to setup the server:
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server#Setting_up_the_Z39.50_and_SRU_Server

2. Run restart command for each service:
- [Plack] sudo koha-plack --restart {instance}
- [Indexer] sudo koha-indexer --restart {instance}
- [SIP] sudo koha-sip --restart {instance}
- [Worker] sudo koha-worker --restart {instance}
- [z3950] sudo koha-z3950-responder --restart {instance}
- [Zebra] sudo koha-zebra --restart {instance}

3. Observe the services do not get restarted.
Instead you get an error saying the service is not running

4. Apply patch

5. If you are using kohadevbox you must copy koha-* scripts to /usr/sbin/:
sudo cp debian/scripts/koha-plack /usr/sbin/koha-plack
sudo cp debian/scripts/koha-indexer /usr/sbin/koha-indexer
sudo cp debian/scripts/koha-sip /usr/sbin/koha-sip
sudo cp debian/scripts/koha-worker /usr/sbin/koha-worker
sudo cp debian/scripts/koha-z3950-responder /usr/sbin/koha-z3950-responder
sudo cp debian/scripts/koha-zebra /usr/sbin/koha-zebra

6. Repeat step 2

7. This time confirm that each service is restarted

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:29:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:29:01 +0000
Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even
 when not running
In-Reply-To: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30684-70-95nnPWiouK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #20 from David Nind <david at davidnind.com> ---
Testing notes (using koha-testing-docker):

1. Not related to this bug, but for koha-sip and koha-zebra there is no error
message before and after the patch is applied. (All the other scripts say
"Error: X not running for {instancename}: failed!".)

2. For koha-testing-docker, need to copy scripts as per step 5.

3. Format of the message after the patch is applied, examples:
   - Plack not running for kohadev.:Starting Plack daemon for kohadev:.
   - Worker not running for kohadev (default).:Starting Koha worker daemon for
kohadev (default):.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:41:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:41:02 +0000
Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-OvorDQJG5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sally from comment #45)
> We'd really love to see this feature in Koha.  We don't use pseudonymization
> as there are statistics that we pull together where we reference date of
> birth.
> 
> Pseudonymization definitely has a place, but we've developed policies to
> ensure that we're processing our collected data in line with GDPR and with
> consent granted by our patrons.
> 
> The statistics table is the heart of our performance statistics, and having
> a permanent record of which category a patron was in would be a major step
> forward for us.

+1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:41:04 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-D0JEJMoC4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Haha, funny how things come around.

Yes, I would love to see cataloguing have more of a 'home page' than it does
now, more akin to the  Circulation and Tools modules.. it would improve
consistency and help us to better organise Koha as a more coherent whole.

As for the sidebar, I was surprised the other day to find such an include did
in fact already exist but wasn't being used anywhere.. I reinstated it I
think.. lete dig out the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:43:09 +0000
Subject: [Koha-bugs] [Bug 30684] koha-* scripts --restart should start even
 when not running
In-Reply-To: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30684-70-JkuxK9FeTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement restarts
      release notes|                            |services if they are not
                   |                            |running when using the
                   |                            |--restart option for
                   |                            |koha-plack, koha-indexer,
                   |                            |koha-sip, koha-worker,
                   |                            |koha-z3950-responder, and
                   |                            |koha-zebra . Before this,
                   |                            |if a service was not
                   |                            |running an error message
                   |                            |was generated (Error:
                   |                            |{servicename} not running
                   |                            |for ${instancename}") and a
                   |                            |start command for the
                   |                            |service was required.
                   |                            |
                   |                            |Example of message if plack
                   |                            |is not running and the
                   |                            |service is restarted:
                   |                            |
                   |                            |koha-plack --restart
                   |                            |kohadev
                   |                            |  Plack not running
                   |                            |for kohadev.:Starting Plack
                   |                            |daemon for kohadev:.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 22:54:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 20:54:36 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-rMnbdcbDhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Changed status to Failed QA - see comment #3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 23:05:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 21:05:31 +0000
Subject: [Koha-bugs] [Bug 26757] SMS Test Button
In-Reply-To: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26757-70-Xy4dr8znJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26757

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
+1, this would be quite useful. As would a test email, for that matter.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 23:08:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 21:08:18 +0000
Subject: [Koha-bugs] [Bug 26757] SMS Test Button
In-Reply-To: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26757-70-4r6J8ZW9lX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26757

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
+1, would be handy :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 14 23:14:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 21:14:03 +0000
Subject: [Koha-bugs] [Bug 26757] SMS Test Button
In-Reply-To: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26757-70-etztKayU9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26757

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I would add, that if a test were made for either/both, it would be beneficial
for Koha to send it out right away rather than wait for the usual cron.  Since
this is a test, and it is like a patron is standing around waiting for a
confirmation.

It might also be useful for there to be some kind of indicator in Koha that the
message was verified by a link in the test.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 00:06:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 22:06:32 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-Tbb4JdcFZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 00:18:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 22:18:39 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-KHGYQMQJyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137619|0                           |1
        is obsolete|                            |

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137739&action=edit
Bug 31139: Fix basic_workflow.t

Error while executing command: element not interactable: Element <input
id="tag_952_subfield_w_810691" class="input_marceditor
items.replacementpricedate noEnterSubmit flatpickr-input"
name="items.replacementpricedate" type="hidden"> is not reachable by keyboard
at /usr/share/perl5/Selenium/Remote/Driver.pm line 411.

Not sure if it's coming from bug 30717 or not. git bisect told me it was the
culprit but we released 22.05 and it seems that we got basic_workflow.t green
since then.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 00:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Jul 2022 22:21:24 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-QCBXwvCx1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Passed QA

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 04:13:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 02:13:53 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-tXBQtUB0Ih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 04:13:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 02:13:58 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-qOp2MsaHNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #44 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137740&action=edit
Bug 15348: (follow-up) Fix calendar widget, translateability, etc

Also add functionality to edit the estimated delivery date from a closed
basket.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 04:14:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 02:14:03 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-hWtatARDBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #45 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137741&action=edit
Bug 15348: DBIC changes DO NOT PUSH

For testing purposes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 04:20:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 02:20:10 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-DjPyiI0ny3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137740|0                           |1
        is obsolete|                            |

--- Comment #46 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137742&action=edit
Bug 15348: (follow-up) Fix calendar widget, translateability, etc

Also add functionality to edit the estimated delivery date from a closed
basket.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 04:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 02:20:15 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-ABoc9Cockn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137741|0                           |1
        is obsolete|                            |

--- Comment #47 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 137743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137743&action=edit
Bug 15348: DBIC changes DO NOT PUSH

For testing purposes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 08:56:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 06:56:46 +0000
Subject: [Koha-bugs] [Bug 31159] New: Can we drop the 'CircSideBar'
 preference and convert the sidebar to being collapsible?
Message-ID: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

            Bug ID: 31159
           Summary: Can we drop the 'CircSideBar' preference and convert
                    the sidebar to being collapsible?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I find it confusing that the CircSidebar is disabled by default.  I propose we
enable it and remove the preference replacing it with a collapsible navigation
that gives us the best of both worlds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 08:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 06:57:18 +0000
Subject: [Koha-bugs] [Bug 31159] Can we drop the 'CircSideBar' preference
 and convert the sidebar to being collapsible?
In-Reply-To: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31159-70-mvBeJ8ALrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |lucas at bywatersolutions.com,
                   |                            |oleonard at myacpl.org,
                   |                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 09:05:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 07:05:26 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-VB647gH4oC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #106 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Think this needs another rebase.. I had a go but there are a lot of template
changes going on here so it's non-trivial to get right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 09:09:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 07:09:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-cXMQs0SRJq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #107 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Martin Renvoize from comment #106)
> Think this needs another rebase.. I had a go but there are a lot of template
> changes going on here so it's non-trivial to get right.

It's coming soon. Solène has been working on fixes and also on reducing the
number of template changes to ease rebase. We'll try to submit an up-to-date
patch today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:21:19 +0000
Subject: [Koha-bugs] [Bug 31159] Can we drop the 'CircSideBar' preference
 and convert the sidebar to being collapsible?
In-Reply-To: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31159-70-MkJcLhcN5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 

I know some software that does this and it's helpful to be able to collapse and
uncollapse. We'd solve the space problem and we could probably also 'remember'
the setting for a session?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:23:46 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-T41rBsBYSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |blocker
            Version|master                      |22.05
           Priority|P5 - low                    |P1 - high

--- Comment #11 from Mason James <mtj at kohaaloha.com> ---
bumping to blocker for 22.05.03 release

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:25:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:25:29 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-5CRheUvSbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:27:18 +0000
Subject: [Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl
 extension to *.t
In-Reply-To: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31108-70-Y8e5EaZtKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30899

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:27:18 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-F7ZyOP9PFM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31108

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:41:04 +0000
Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table
In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30928-70-6dj8ce2vGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:54:23 +0000
Subject: [Koha-bugs] [Bug 7021] Add patron category to the statistics table
In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7021-70-0QoZCz84QU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30928

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:54:23 +0000
Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table
In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30928-70-YNArYsg6aE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7021

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:56:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:56:11 +0000
Subject: [Koha-bugs] [Bug 31160] New: Required fields in the Patrons API are
 a bit random
Message-ID: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

            Bug ID: 31160
           Summary: Required fields in the Patrons API are a bit random
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
                CC: tomascohen at gmail.com

Currently, the required fields in the patron API do not match the required
fields in the CSV imports.. and they don't entirely make sense.. city and
address are required for example.. is there some reasoning behind those
choices?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:58:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:58:46 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-zC4jUVGmj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:58:55 +0000
Subject: [Koha-bugs] [Bug 31160] Required fields in the Patrons API are a
 bit random
In-Reply-To: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31160-70-0RYk6avsfv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 10:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 08:59:42 +0000
Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets
In-Reply-To: <bug-23524-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23524-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23524-70-LNJkc5Mbfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is an old bug now... feature in the GUI that never did anything. Maybe we
should fix it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:12:35 +0000
Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges
In-Reply-To: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31158-70-khXf8lZhuZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Can't filter suggestions by |Can't filter suggestions by
                   |suggestion date range       |date ranges
         Depends on|                            |29229

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed!

It cannot work, the column in the database is suggesteddate. But this problem
exists for all the data range searches in the form.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229
[Bug 29229] Use Flatpickr in suggestion search sidebar filter
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:12:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:12:35 +0000
Subject: [Koha-bugs] [Bug 29229] Use Flatpickr in suggestion search sidebar
 filter
In-Reply-To: <bug-29229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29229-70-EWxuF4a9nT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31158


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158
[Bug 31158] Can't filter suggestions by date ranges
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:12:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:12:42 +0000
Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges
In-Reply-To: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31158-70-QlwKUGfGUX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|29229                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229
[Bug 29229] Use Flatpickr in suggestion search sidebar filter
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:12:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:12:42 +0000
Subject: [Koha-bugs] [Bug 29229] Use Flatpickr in suggestion search sidebar
 filter
In-Reply-To: <bug-29229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29229-70-0UgpF2xuwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31158                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158
[Bug 31158] Can't filter suggestions by date ranges
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:16:31 +0000
Subject: [Koha-bugs] [Bug 31158] Can't filter suggestions by date ranges
In-Reply-To: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31158-70-zJ0UIgjw8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23991


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991
[Bug 23991] Move SearchSuggestion to Koha::Suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:16:31 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-oNMA2ahL4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31158


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158
[Bug 31158] Can't filter suggestions by date ranges
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:21:07 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-WcJbi7EUIV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can't confirm on master. Which version did you test with Emmi?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:21:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:21:40 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-OeI2BnzXTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Oh, and maybe check the logs - there could be a more meaningful error there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:24:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:24:42 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-u9j2hP4Tps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Emily W from comment #4)
> Recently began having this issue. Digests will be checked when creating the
> guarantee but will uncheck once saved. Takes up staff time adding an
> additional step to sign up process.

Hi Emily, I think this is a slightly different bug 30175 that was fixed in
22.05. I have also asked the RMaint to check for backporting. Which version did
you test with?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:24:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:24:54 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-Hr6KLiYqCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30175

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:24:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:24:54 +0000
Subject: [Koha-bugs] [Bug 30175] Digest options not enabled when populating
 messaging preferences for a selected category during patron entry
In-Reply-To: <bug-30175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30175-70-SD9WsXMjcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30175

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7660

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:30:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:30:43 +0000
Subject: [Koha-bugs] [Bug 31161] New: OAI-PMH - Add ability to exclude
 suppressed records in output
Message-ID: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

            Bug ID: 31161
           Summary: OAI-PMH - Add ability to exclude suppressed records in
                    output
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.field at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

At the moment, if a record is suppressed in Koha it will still appear in the
results set of an OAI-PMH query. It would be great to have an option to exclude
a record if 942$n is set to suppress. That way OPAC suppression would be
reflected in the OAI output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:31:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:31:15 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-karUvF0wRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

Jonathan Field <jonathan.field at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:35:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:35:58 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-id7JrmdreZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:36:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:36:04 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-Y35ILKLRqC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:37:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:37:57 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-c5UCzYrE5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #1 from Jonathan Field <jonathan.field at ptfs-europe.com> ---
Just to add some extra context to this, one of the methods that EBSCO use to
harvest data into EDS is OAI-PMH from Koha and some libraries don't want
suppressed records going into EDS in the same way they don't want them in the
OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:40:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:40:43 +0000
Subject: [Koha-bugs] [Bug 30945] Branch specific self checkout login
In-Reply-To: <bug-30945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30945-70-VEGXtt3LMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30945

Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

--- Comment #3 from Lucy Vaux-Harvey <lucy.vaux-harvey at ptfs-europe.com> ---
1++  Being able to specify a branch code in the URL would be really useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:41:24 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
 hold state at branch A kill Koha
In-Reply-To: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28259-70-bCPDZDoSYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can no longer reproduce this issue with the test plan in master. Could there
have been a fix for this as a side effect of another patch?

Anneli, which version are you seeing the problem with?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:42:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:42:59 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
 hold state at branch A kill Koha
In-Reply-To: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28259-70-GKdQ4SSTFA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

--- Comment #9 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
Katrin, we are using version 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:49:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:49:08 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-HMGdgCbaPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can this be updated from New to Needs Signoff? :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:52:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:52:12 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-oFS6vM6nr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 11:56:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 09:56:53 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
 hold state at branch A kill Koha
In-Reply-To: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28259-70-hyHC0Wmlvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

--- Comment #10 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
I tested this now in Bywater's Sandbox and had the same results as Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:00:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:00:41 +0000
Subject: [Koha-bugs] [Bug 31159] Can we drop the 'CircSideBar' preference
 and convert the sidebar to being collapsible?
In-Reply-To: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31159-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31159-70-bz3cLo9Pdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31159

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:05:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:05:12 +0000
Subject: [Koha-bugs] [Bug 31162] New: Add a clear cataloguing module home
 page
Message-ID: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

            Bug ID: 31162
           Summary: Add a clear cataloguing module home page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The cataloguing module doesn't really have a 'home page' like circulation does.
We have a number of tools under the cataloguing banner, we could have a clear
jump-in point on the module home page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:05:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:05:23 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-EUy5ksu4sf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:05:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:05:43 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-eKEiK6AHSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31148

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:05:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:05:43 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-L98AFaAxXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31162

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:06:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:06:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-m8vpJ3YvfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137414|0                           |1
        is obsolete|                            |

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137420|0                           |1
        is obsolete|                            |

--- Comment #108 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137744&action=edit
Bug 30952: Staff interface redesign

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:06:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:06:50 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-CV6KG8HSB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Solene D <solene.desvaux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137414|0                           |1
        is obsolete|                            |

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137420|0                           |1
        is obsolete|                            |

--- Comment #108 from Solene D <solene.desvaux at biblibre.com> ---
Created attachment 137744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137744&action=edit
Bug 30952: Staff interface redesign

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:07:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:07:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-E0IDmGsweO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137419|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:07:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:07:20 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-1mOdMrVVgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137418|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:07:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:07:27 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-13AhGzGeHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137417|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:07:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:07:39 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ZqZp6E7WBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137416|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:07:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:07:47 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-A0PUM802kc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137415|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:13:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:13:34 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-LTY1WUQees@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:58:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:58:15 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-WcbBNpYoqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, could you please look into Daniel's comment? If the hold cannot be
filled at the pickup-location this might not work as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:58:38 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-sff8totMKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137722|0                           |1
        is obsolete|                            |
 Attachment #137723|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137745&action=edit
Bug 29102: Do not count patron's own hold against limits

This patch makes three changes:
1 - The borrower's own holds are not counted towards HighHolds limit
2 - We exclude all hold counts from CanItemBeReserved
3 - Static mode should only decrease hold when over the
decreaseLoanHighHoldsValue, not when equal

Previously a patron's hold could put the count over the threshhold, and
if the patron is only allowed 1 hold per record, and the hold wasn't found
before
the checkout, it would make all items unholdable, thus lowering the theshhold
for
dynamic HighHolds

To test:
 1 - Set sysaprefs:
     decreaseLoanHighHolds  - enable
     decreaseLoanHighHoldsDuration - 1
     decreaseLoanHighHoldsValue - 1
     decreaseLoanHighHoldsControl - "over the number of holdable items on the
record" / dynamic
     decreaseLoanHighHoldsIgnoreStatuses - blank
 2 - Set circ rules to allow 1 hold per record and loan period of 5
 3 - Find/create a record with 3 items
 4 - Place a title level hold for two different patrons
 5 - Attempt to checkout item - note warning about high holds
 6 - Cancel checkout
 7 - Set decreaseLoanHighHoldsControl - "on the record" / static
 8 - Attempt checkout - note warning about high holds
 9 - Apply patch
10 - Checkout item - no warning
11 - checkin item, replace hold
12 - Set decreaseLoanHighHoldsControl - "over the number of holdable items on
the record" / dynamic
13 - Checkout item - no warning
14 - prove t/db_dependent/DecreaseLoanHighHolds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 12:58:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 10:58:42 +0000
Subject: [Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan
 period if borrower has an 'unfound' hold
In-Reply-To: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29102-70-C1OySaj0VA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137746&action=edit
Bug 29102: Remove ignore_found_holds

If not counting patrons holds, found or unfound, we no longer need this option
introduced by bug 28078

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:06:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:06:49 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-ExiAvKDZlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
One thing to note here, if the messaging preferences are left blank, then they
are filled from the category on save

To test:
1 - In KTD set 'Juvenile' category to have some messaging preferences
2 - Find a patron, say Edna Acosta, and 'Add guarantee'
3 - In new form preferences are blank - fill out other fields and save
4 - Save patron
5 - Note messaging preferences match category defaults

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:16:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:16:05 +0000
Subject: [Koha-bugs] [Bug 28259] Checking at branch B an item in waiting
 hold state at branch A kill Koha
In-Reply-To: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28259-70-rFcT6RHQAM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28259

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |21.11

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am updating the version here to 21.11 for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:20:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:20:41 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file,
 MarcFieldsToOrder syspref defined discounts are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-mHMED91XJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|when doing acquisitions     |When creating orders from a
                   |from a staged file,         |staged file,
                   |MarcFieldsToOrder-syspref   |MarcFieldsToOrder syspref
                   |discounts are instead       |defined discounts are added
                   |added.                      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:24:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:24:47 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file,
 MarcFieldsToOrder syspref defined discounts are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-j4gDTQeptN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

the original bug description and the patch test plan don't match up.

The original bug is about when the discount is pulled from the record, not the
vendor. 

Should the patch be moved or the bug description be adjusted?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:28:52 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-bPYxs4bRx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24001

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:28:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:28:52 +0000
Subject: [Koha-bugs] [Bug 24001] Cannot edit card template
In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24001-70-imTz0plJxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31137

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:39:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:39:05 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-2kwXx8vj5t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137747&action=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:39:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:39:39 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-JH67y9dKk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:42:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:42:02 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-OFt3TydpWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This submission serves as a starting point for making the cataloguing processes
into a more coherent module.

I think we can certainly work on improving the look and feel of the page and
eventually migrate many of the 'tools' here out of 'tools' and into
'cataloging' as a distinct part of the breadcrumb.

I also intend to re-instate the cat-menu.inc sidebar option and have it reflect
the options available from this new home page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:42:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:42:23 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-GPCx2UcIyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:48:21 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-zjBuwPFC4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 13:48:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 11:48:25 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-NrvMdJkqg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #114119|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137748&action=edit
Bug 27136 - Add languages and avoid displaying nothing in facet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:11:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:11:20 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-Cnm84vrTCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:11:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:11:23 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-tFrG3wNMv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137749&action=edit
Fix - Bug 31137 - Error editing label template

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:11:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:11:27 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-CfTYcU8JY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137750&action=edit
Bug 31137: (QA follow-up) Also fix new template page

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:13:20 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-36XW53f2pb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137607|0                           |1
        is obsolete|                            |
 Attachment #137749|0                           |1
        is obsolete|                            |
 Attachment #137750|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137751&action=edit
Bug 31137: Only display label printer profiles when editing labels

This patch filters the printer profiles in the label edition template so you
may only choose Printer Profiles created for Labels.

To test
1 Create a new Printer Profile in Patron Cards
2 Edit a Label template, pick the Printer Profile you just created.
3 Save the Label Template. You get an error 500
4 apply patch, restart services
5 Edit a Label template and check that you can't pick the Printer Profile you
created in Patron Cards

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:13:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:13:23 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-rZ2EW5hqKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137752&action=edit
Bug 31137: (QA follow-up) Also fix new template page

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:13:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:13:45 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-z363Rqnfgg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Straightforward - PQA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:15:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:15:50 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file,
 MarcFieldsToOrder syspref defined discounts are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-mtA91QdkRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #9)
> Hi Nick,
> 
> the original bug description and the patch test plan don't match up.
> 
> The original bug is about when the discount is pulled from the record, not
> the vendor. 
> 
> Should the patch be moved or the bug description be adjusted?

It's the same - when discount populated from file or entered manually it gets
subtracted, will adjust title

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:16:31 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 defined discounts are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-MlmwLDf3KN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When creating orders from a |When creating orders from a
                   |staged file,                |staged file defined
                   |MarcFieldsToOrder syspref   |discounts are added
                   |defined discounts are added |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:16:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:16:49 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-DktXuxzFfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When creating orders from a |When creating orders from a
                   |staged file defined         |staged file discounts
                   |discounts are added         |supplied in the form are
                   |                            |added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:31:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:31:15 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-GSnDDxRSMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #47 from Mason James <mtj at kohaaloha.com> ---
(In reply to Blou from comment #46)
> Any followup on this ?
> 
> Our master doesn't work, we can't rebuild the mappings anymore.

hi Blou,
try using the staging repo, it has updated packages

$ cat /etc/apt/sources.list.d/koha.list
deb http://debian.koha-community.org/koha-staging unstable  main

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:35:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:35:58 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-4s65IEl1sp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Nice one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:42:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:42:58 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-SejoJ4hrkn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Anneli Österman <anneli.osterman at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anneli.osterman at koha-suomi.
                   |                            |fi

--- Comment #3 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
Looks good! Maybe you could also make "New record" heading and add those
"Advanced editor" (if activated), "New record" and "New from 39.50/SRU" buttons
underneath it? :)

Btw, if you click More -> Cataloging you end up to the "old" empty page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:49:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:49:28 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-nTJrd8LAMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 14:55:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 12:55:07 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-m9epodIXK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Awesome feedback, thanks.

I did wonder about the toolbar with 'advanced editor' and 'new from X'
buttons.. initially I didn't have that on the page at all but I haven't yet
worked out a nicer way to do it.. I'll have a go at dropping the toolbar and
moving them as per your suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:00:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:00:09 +0000
Subject: [Koha-bugs] [Bug 30849] Make pending patron modification notices on
 staff main page number of modifications at logged in branch
In-Reply-To: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30849-70-nzf7hSGbAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

1) I am not sure if we don't give off the wrong impression here. The link for
"my library" and "all libraries" is the same, because the patron modification
page doesn't filter. But I think having 2 links would give off the impression
that they behave differently. Would it be possible to create a link that
filters? Or maybe we keep the link on the Patrons requesting... and not on the
numbers.

2) We don't take  IndependentBranchesPatronModifications into account. I
believe if that is 'on' we should only show the library count and could hide
the all libraries one.

3) When there are no modification requests for the current library, it reads:
Patrons requesting modifications: Centerville: / All libraries: 1

For suggestions we show 0 here, which is a little nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:01:38 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-CQLL5Ab3Kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:04:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:04:10 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-gaAsdHIJbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd like to add that $c is really not a nice name for a variable, but that was
there 'before patch':

my $c = $c_discount ? $c_discount : $bookseller->discount;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:05:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:05:29 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-iG2JSOPi3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:05:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:05:33 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-gsoMkkXU04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137753&action=edit
Bug 14680: Always subtract discount from price to calculate estimated cost

This patch simply removes a discrepancty where when a discount is provided on
the order form
we add the discount to the price, and when it comes form the vendor we subtract
the discount.

Discounts should always descrease the estimated cost

To test:
 0 - Have a vendor with a discount of 10% specified
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $10 RRP and $9 actual/budgeted cost
 6 - Repeat 2&3
 7 - Select the tile, set price $10 and discount 50%
 8 - Add the order - note $20 RRP and $10 actual/budgeted cost! FAIL
 9 - Apply patch, restart all
10 - Repeat 2-7
11 - Add the order, note $10 RRP and $5 actual.budgeted cost

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:07:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:07:21 +0000
Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to
 oldest
In-Reply-To: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31127-70-S5ChektWpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could we make the sort configurable using the new Datatables options? I believe
some libraries might want the one or the other (LIFO or FIFO...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:07:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:07:55 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-TKoRAOwnmT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137650|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:09:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:09:40 +0000
Subject: [Koha-bugs] [Bug 31034] Cover images hidden in some browsers
In-Reply-To: <bug-31034-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31034-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31034-70-KADEGNZ64j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31034

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bib image hidden after      |Cover images hidden in some
                   |changes in bib detail       |browsers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:12:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:12:53 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-IrGVo1tbKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137747|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137754&action=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:14:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:14:30 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-HAZ2V5Z8Xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Just a minor iteration there.. fixes the top bar link and moves the advanced
editor button into a 'New' section underneath.. 

I'm not sure how to try and handle the other toolbar buttons.. the Framework
selection lends itself to a button.. I was considering a fieldset with buttons
but that also feels a bit weird.

Contemplating.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:18:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:18:00 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-VAEm1BAJSM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I followed the test plan, but the system information note doesn't show up for
me. I deleted the MARCXML as follows:

update biblio_metadata set metadata = "" where biblionumber = 2;

Reindexing then gives an error:

No record passed at /kohadevbox/koha/Koha/MetadataIterator.pm line 71.
Something went wrong reading record for biblio
Koha::Schema::Result::Biblio=HASH(0x557fea5e8d78)->biblionumber: Can't bless
non-reference value at /kohadevbox/koha/Koha/BiblioUtils.pm line 69.

Cannot determine authority type for record: 1 at
/kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 564.


BUT: The system information tab remains empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:19:24 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-MF4Y6dUhHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, good test: you also need to set the SearchEngine to Elasticsearch :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:25:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:25:02 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-N9R18LrxDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:25:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:25:06 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-OwPorkiqU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137458|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137755&action=edit
Bug 27667: Display a warning for records missing in Elasticsearch

On "About Koha" page are displayed the numbers of indexed biblios and
authorities with ES.
It could be great if we could have comparison with the number of records in the
database to display the number of missing records.
In the "System information" tab with the other "Data problems".

If Searchengine has any issue (index count will be -1), we do not
display missing records.

Test plan :
1) Use Elasticsearch searchengine
2) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
3) Go to "About Koha" page and look at System information tab
=> you see no warning
4) On a biblio record delete the MARCXML in biblio_metadata.metadata
5) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
6) Go to "About Koha" page and look at System information tab
=> you see warning : 1 record(s) missing on a total of 435 in indice
koha_kohadev_biblios.
7) On a authority record delete the MARCXML in auth_header.marcxml
8) Rebuild all records : koha-elasticsearch --rebuild -d kohadev
9) Go to "About Koha" page and look at System information tab
=> you see warning : 1 record(s) missing on a total of 1705 in indice
koha_kohadev_authorities.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:25:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:25:11 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-nQQCXoYawR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137756&action=edit
Bug 27667: (QA follow-up) Fix singular index and rephrase heading

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:31:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:31:08 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-hvI4xZR0Mh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:35:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:35:20 +0000
Subject: [Koha-bugs] [Bug 31163] New: Sort cashup history so that newest
 entries are first
Message-ID: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

            Bug ID: 31163
           Summary: Sort cashup history so that newest entries are first
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: martin.renvoize at ptfs-europe.com

When looking at the cashup history table, it would be helpful if the newest
entries showed up first. Currently it sorts the oldest entries first.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:37:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:37:44 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-JRzFL8ZXd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:37:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:37:48 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-EIWLS9kOXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137431|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137757&action=edit
Bug 31036: Treat SIP00 that same as CASH

SIP00 is the code for CASH transactions that have taken place on a SIP
client.  Cash management treats CASH type transactions as a special case
for banking and register requirements. This patch brings SIP00 in line
with the CASH handling code of cash management.

Test plan
1) Enable cash management with 'EnablePointOfSale'
2) Enable cash registers with 'UseCashRegisters'
3) Add a cash register via 'Administration > Cash registers'
4) Make some payments against the ash register in the staff client
5) Attempt to make a payment via a SIP client without having associated
   a cash register to the SIP account config
5a) This should now fail
6) Attach the cash register to the SIP account used above
6a) Payment should now work again on SIP transactions
7) Look at the cash register details page for the cash register
7a) 'Bankale' should now include cash from both SIP and Staff client
sales

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:39:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:39:10 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-2X7sG2dbMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137754|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137758&action=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:39:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:39:22 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-1YeTLnEs8k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 5) Attempt to make a payment via a SIP client without having associated
> a cash register to the SIP account config
> 5a) This should now fail

I think this would warrant a 'bold' note in the release notes as it has the
potential to break self checks unexpectedly. 

Could it be an option to make it fail gracefully/with a good error message?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:41:09 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-ewzzLo4pO9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
See bug 31162 for an initial attempt at adding a cataloguing homepage :).

I decided to do it on its own bug so we can track the idea of a cataloguing
sidebar and cataloguing homepage as distinct features.. and as my homepage
design adds more than just the marc import tools.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:47:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:47:56 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-IwLG4Hor8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30871

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:47:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:47:56 +0000
Subject: [Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is
 controlled by Leader 6th position in MARC21
In-Reply-To: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30871-70-C2r88AaOzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19419

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:48:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:48:58 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-RohagFYKAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It's a fair point.. I struggled to come up with a solution.. either a big bold
warning next to the system preference that enables cash registers.. or perhaps
a soft fallback to the first register we find on the system in SIP if there
isn't one in the sip config..

Or.. both..  I feel like the soft fallback could lead to unexpected results at
cashup too.

Any preference?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:51:12 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-a6hSsIDwgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:51:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:51:14 +0000
Subject: [Koha-bugs] [Bug 31139] basic_workflow.t is failing
In-Reply-To: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31139-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31139-70-Ze9jovfQIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31139

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:51:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:51:26 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-8ZWgyi4JB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the soft fallback is potentially more dangerous, so the note would be
better. And I think this should probably not be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:56:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:56:08 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-8OH4sw94au@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Ha.. I spotted this the other day and totally forgot to report it.. thanks
Katrin :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:59:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:59:36 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-cSIcTjjXyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137759&action=edit
Bug 31163: Sort cashups newest to oldest

The cashup history table was sorting from oldest to newest.. it's
perferable to show the most recent at the top by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 15:59:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 13:59:55 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-Dp4OmBD7ok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:00:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:00:02 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-8eWenMwDOq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:07:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:07:34 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
 types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-tYHwaiN1Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:07:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:07:38 +0000
Subject: [Koha-bugs] [Bug 7960] choice to not show the text labels for item
 types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-LES2Wv3b6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98778|0                           |1
        is obsolete|                            |

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137760&action=edit
Bug 7960: Add class to item type descriptions so they can be hidden with CSS

This patch adds the class "itypetext" around item type descriptions so
they can easily be hidden with CSS.

To test:
1. Navigate to the pages listed below to confirm that the text
descriptions do show.
2. Add
.itypetext { display:none; }
to IntranetUserCSS and OPACUserCSS system preferences and save.
3. Go back to the pages listed below and confirm that the text
descriptions DO NOT show.

= STAFF CLIENT =
 - catalogue/advsearch.tt
 - catalogue/detail.tt
 - catalogue/results.tt
 - reserve/request.tt
 - virtualshelves/shelves.tt
= OPAC =
 - opac-advsearch.tt
 - opac-detail.tt
 - opac-readingrecord.tt
 - opac-reserve.tt
 - opac-results-grouped.tt
 - opac-shelves.tt
 - opac-user.tt

Sponsored-by: Catalyst IT

Signed-off-by: Charles Farmer <charles.farmer at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:13:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:13:03 +0000
Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item
 types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-xDsqjAiPy0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|choice to not show the text |Choice to not show the text
                   |labels for item types       |labels for item types

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:14:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:14:17 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-GTp7UV4WEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fix adds the last
      release notes|                            |missing piece for cash
                   |                            |management when involving
                   |                            |transactions via a SIP
                   |                            |client.
                   |                            |
                   |                            |We now understand
                   |                            |that a SIP00 coded
                   |                            |transaction is equal to
                   |                            |'CASH' in other register
                   |                            |environments. This means we
                   |                            |treat it as such in the
                   |                            |cashup system and also that
                   |                            |we now require a register
                   |                            |for cash transactions.
                   |                            |
                   |                            |WARNING: This makes
                   |                            |register a required
                   |                            |configuration field for SIP
                   |                            |devices when cash registers
                   |                            |are enabled on the system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:21:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:21:06 +0000
Subject: [Koha-bugs] [Bug 31063] [OMNIBUS] QOTD tool
In-Reply-To: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31063-70-N8DXrdGGrf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137761&action=edit
Bug 31036: (QA follow-up) Add a warning to the system preference

As suggested by Katrin, adding a warning to the system preference that
this has an effect on SIP configurations that needs to be understood.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:22:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:22:13 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-6THAxJbbUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137762&action=edit
Bug 31036: (QA follow-up) Add a warning to the system preference

As suggested by Katrin, adding a warning to the system preference that
this has an effect on SIP configurations that needs to be understood.

https://bugs.koha-community.org/show_bug.cgi?id=31063

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:22:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:22:32 +0000
Subject: [Koha-bugs] [Bug 31063] [OMNIBUS] QOTD tool
In-Reply-To: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31063-70-X38BpQynDu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
 Attachment #137761|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:22:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:22:48 +0000
Subject: [Koha-bugs] [Bug 31063] [OMNIBUS] QOTD tool
In-Reply-To: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31063-70-eG4ih0e8xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31063

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Doh, wrong bug.. sorry for the noise

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:23:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:23:36 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-71GaWY80zN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137762|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137763&action=edit
Bug 31036: (QA follow-up) Add a warning to the system preference

As suggested by Katrin, adding a warning to the system preference that
this has an effect on SIP configurations that needs to be understood.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:24:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:24:06 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?=
 =?utf-8?q?n=E2=80=99_button_to_reports?=
In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23824-70-6R2JzSILeK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michalurban177 at gmail.com
           Assignee|koha-bugs at lists.koha-commun |michalurban177 at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #4 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137764&action=edit
Bug 23824:  Add a Save and Run button to reports

Added a setting within the Guided SQL Reports create and edit report
interfaces.

This allows admins to bypass the need to go to the Edit SQL page to run reports
and run a report after saving.

To test:
1. Navigate to the reports screen in Koha admin, and create a SQL report
2. Create a report with "Run report after saving" switched to "Yes", save the
report
(Easy query for testing: "SELECT NOW();")
3. Notice that the report runs after saving
4. Navigate to the edit page for the report, edit the query, set "Run report
after saving" to yes and update SQL
5. Notice that the report runs after updating in the Edit SQL page
6. Create a new report with "Run report after saving" set to "No", and save
7. Notice that you are redirected to the Edit SQL page
8. Edit the query with "Run report after saving" set to "No" and update SQL
9. Notice that the SQL updates and does not run

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:24:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:24:33 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?=
 =?utf-8?q?n=E2=80=99_button_to_reports?=
In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23824-70-UpLv8QOvSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:24:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:24:39 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-vInPWahjIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Added text for release notes and added a warning to the system preference in a
QA follow-up as discussed :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:34:41 +0000
Subject: [Koha-bugs] [Bug 26593] Rental discounts are applied in wrong
 precedence order
In-Reply-To: <bug-26593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26593-70-RAJ8cgAOav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at hypernova.fi

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 25115 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:34:41 +0000
Subject: [Koha-bugs] [Bug 25115] Use get_effective_rule for getting rental
 discount
In-Reply-To: <bug-25115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25115-70-4eFu2N1o5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 26593 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:38:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:38:25 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-kQvOW9i1GA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137730|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137765&action=edit
Bug 31153: Correct include for patron-search-header

To test:
1) Turn on recalls
   1.1) In Administration > Global system preferences, enable UseRecalls
   1.2) Add recalls permissions in your circulation rules
2) In the OPAC, log in as a patron
3) Find a record with checked out items and place a recall
4) In the staff interface, go to the patron's account
5) Click on any tab on the left in the patron's account (e.g. Holds history)
--> Note that the Koha logo and search bar is at the top of the page between
the module menu and the breadcrumbs
6) Click on the 'Recalls history' tab
--> Note that the Koha logo and search bar disappear
7) Apply patch
8) Conform search bar is there

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:38:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:38:46 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-YVDxdf1zgn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial code change, solid fix.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:41:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:41:35 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-HucPauZA4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137735|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137766&action=edit
Bug 31146: Fix unclosed table element

To test:
1) Install another language and enable it in the OPACLanguages system
preference
2) Also make sure opaclanguagesdisplay is set to Allow
3) Make sure OpacLangSelectorMode is set to display the switch in the footer
(either top and bottom or footer only)
4) Turn on recalls
   4.1) In Administration > Global system preferences, enable UseRecalls
   4.2) Add recalls permissions in your circulation rules
5) In the OPAC, log in as a patron
6) Find a record with checked out items and place a recall
7) Go to your account
--> Note that the language switch is at the bottom left of the screen
8) Click on any tab in the patron's account
--> Note that the language switch is at the bottom left of the screen
9) Click on 'Your recalls history'
--> Note that the language switch is right under the recalls history table
10) Apply patch
11) The changelanguage div should now be properly placed at the bottom of the
page.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:41:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:41:40 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-AcuQQSvMWj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #93 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
First of all: I quite like the functionality and how this looks. It also
appears to be pretty fast and accurate as far as I can tell. I especially like
that it's not only available for the keyword index, but also on other search
options like author search and limits the results down accordingly.

That said: There are a couple things here that would require fixing and a big
question we need to resolve for moving this forward.


The small stuff:
1) In the database update, there should still be a description for the system
preference.
2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the
prefs into the correct places.
3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2 in
coding guidelines)
4) In the database update elasticsearch should be Elasticsearch.


Somewhat bigger:

5) I have problems making this work with the "library catalog" and "title"
search options in simple search in OPAC. title doesn't give me any results and
library catalog looks like author (but it's a keyword search). Something might
not be 'wired' correctly there.
6) Updating installations: I believe you also need to reset mappings to make
this work? How can we ensure this works out of the box for people updating
without them having to "redo" their index configuration? (database update?)
7) sub filterAutocomplete looks complex and I wonder if it should be in the .pl
and not in a module where it can be tested. 942 is hardcoded as field for
OpacSuppression, which is a little risky. I wonder if it could be more elegant
to filter this at search time instead of after?


The last big question, I'll refer to the RM:

This adds to /svc which is the outdated way of doing things as others have
pointed out before. I think in order to move on here and before more time is
spend, we should come to a decision of what is required for this patch to make
it in and if it needs to be rewritten to use REST API or if this could be an
exception.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:42:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:42:06 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-YpMS6qz66e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice quick fixing there..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:50:05 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-ceiBDdKcj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 137727
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727
Bug 14784: Fix checkin message for restricted patrons

Review of attachment 137727:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14784&attachment=137727)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +2296,4 @@
>          if ( $issue and $issue->is_overdue($return_date) ) {
>          # fix fine days
>              my ($debardate,$reminder) = _debar_user_on_return( $patron_unblessed, $item->unblessed, dt_from_string($issue->date_due), $return_date );
> +            if ($debardate and $debardate ne "9999-12-31") {

There really shouldn't be any 9999-12-31 dates left for debardate.. we tried to
clean them all up back with the 3.15.00.029 database update.

@@ +2302,5 @@
> +                } else {
> +                    $messages->{'Debarred'} = $debardate;
> +                }
> +            } elsif ($patron->debarred) {
> +                if ( $patron->debarred eq "9999-12-31") {

As above

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:51:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:51:24 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-X7OFaM9twN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:56:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:56:13 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-eFxKOXuctg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not sure about the date, actually:

If you create an unrestricted debarment you get:

borrowers_debarments.expiration = NULL
borrowers.debarred = 9999-12-31

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:57:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:57:17 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-F58wriMWqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #109 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137767&action=edit
Bug 30952: (follow-up) Fix linting errors in SCSS

This patch makes some corrections to the style of modified SCSS:

- Space before "{"
- No leading zeroes in number values
- Upper case hex codes
- Multi-line comment style
- Use "border: 0" instead of "border: none"
- Remove vendor prefixes
- Remove commented-out declarations
- Put each selector on a separate line

The patch should have no visible effects on the style of the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:57:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:57:22 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-GW4e1mbnXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #110 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137768&action=edit
Bug 30952: (follow-up) Correct whitespace errors

Tab characters are forbidden, as is space at the end of lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 16:58:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 14:58:19 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-1DxX4qpjy4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #111 from Owen Leonard <oleonard at myacpl.org> ---
There are a few other errors highlighted by the QA tool, so please run that
provide a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:00:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:00:34 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-g0sFUWVhBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 136693
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136693
Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to
block

Review of attachment 136693:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22042&attachment=136693)
-----------------------------------------------------------------

Sorry Nick.. this doesn't look quite right yet..

::: C4/Circulation.pm
@@ +2096,5 @@
>  
> +    if ( $item->withdrawn ) { # book has been cancelled
> +        $messages->{'withdrawn'} = 1;
> +        $doreturn = 0 if C4::Context->preference("BlockReturnOfWithdrawnItems");
> +        return ( $doreturn, $messages, $issue, ( $patron ? $patron->unblessed : {} ));

This doesn't look quite right to me.. we're returning early now regardless of
the BlockReturnOfWithdrawnItems preference?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:00:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:00:41 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-oCog0WgLwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:02:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:02:27 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-jaDxJgbPqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137709|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137769&action=edit
Bug 31120: Add unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:03:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:03:02 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-7qyJr9TFGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Cheers Kyle, Passing now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:06:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:06:00 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?=
 =?utf-8?q?n=E2=80=99_button_to_reports?=
In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23824-70-0vQ0bNPlV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like this might be overthinking the issue a bit. 

The new field on top reqires you to set it every time you open and edit a
report, which means extra clicks. 

It also looks like a field that would be stored in the database - but it isn't.
So we might create a wrong impression there.

What if we added another button next to 'Update SQL' that is 'Update SQL and
run'? Or we could turn the button into a split button with the current
behaviour pre-selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:06:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:06:37 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-Tn86pOYmYz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137652|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137770&action=edit
Bug 31144: When modifying an order we should not load the vendor default
discount

After placing an order in a basket with a discount of "0" if you attempt to
modify we will load the vendor default discount, this can lead to accidentally
applying a discount when modifying other order parts

To test:
0 - Have a vendor with a discount set
1 - Add an order to a basket
2 - While adding, set discount to 0
3 - Add order - prices are calculated ocrrectly
4 - Modify order
5 - Note discount is populated with vendor discount
6 - Cancel
7 - Apply patch
8 - Modify order
9 - Discount remains at 0
10 - Repeat with a vendor with no discount set
11 - Placing order not specifiying discount it remains blank
12 - Modifying order discount remains blank
13 - Modify order and set discount
14 - Confirm it is retained on modifcation

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:06:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:06:55 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-tbSKPi8gdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial fix, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:07:00 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-3JxABOxdQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:09:20 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-MsDT5xt9WE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:09:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:09:23 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-mFE7aWMtsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137759|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137771&action=edit
Bug 31163: Sort cashups newest to oldest

The cashup history table was sorting from oldest to newest.. it's
perferable to show the most recent at the top by default.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:09:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:09:58 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-3pUiWTxIM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137141|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137772&action=edit
Bug 31068: Context for translation: Print (verb) vs. Print (noun)

This patch adds context to the term Print in the context of message transport
types (as opposed to printing something/print button), for translation
purposes.

To test:
0- Apply patch

Check the terms to be changed
1- Go to Tools > Notifications & slips
2- Edit a notification
** 3- In the tabs for different transport types, check the 'Print' term
(letter.tt)
4- Go to Tools > Overdue notice/status triggers
** 5- In the transport types, check the 'Print' column heading
(overduerules.tt)

Add a new language (fr-CA in the example, change for whatever language code you
want)
6- In a terminal, run
gulp po:create --lang fr-CA
7- Then, run
gulp po:update --lang fr-CA
8- In system preferences, enable the new language in language and OpacLanguages
9- Switch the language in staff interface and OPAC

Change the translations
10- In your favourite text editor, open fr-CA-messages.po
11- Find the string msgctxt "Message transport type"
12- Enter a word in msgstr
13- Save the file
14- In a terminal, go to misc/translator
15- Run
./translate install fr-CA

Check the translations
16- Redo the steps to check the terms (steps 1-5) and make sure the terms in
steps 3 and 5 are changed for the word you put in step 12.

17- Optionally, check the other pages where the term is supposed to be
unchanged and make sure it is unchanged

Check the terms to leave unchanged (optional)
18- Enable the HoldsAutoFill and UseCashRegisters system preferences
19- Go to Administration > Cash registers and create a cash register
20- Go to a patron's account
** 21- Check the 'Print' button in the menu bar or the patron's account
(members-toolbar.inc)
22- Go to the 'Accounting' tab
23- Create a manual invoice
** 24- In the 'Transactions' tab, check the 'Print' button in the fee line
(boraccount.tt)
25- Pay the fee (make sure to use the cash register)
** 26- In the 'Transactions' tab, check the 'Print' button in the payment line
(boraccount.tt)
27- At the top of the transactions table, click the 'Export' option
** 28- Check the 'Print' option (columns_settings.inc)
29- Go to the 'Check out' tab and check out an item
30- Go to the item's bibliographic record
** 31- Check the 'Print' button in the menu bar of the detailed record
(cat-toolbar.inc)
32- Add the record to the cart and open the cart
** 33- Check the 'Print' button in the cart (basket.tt)
34- Place a hold on the item
35- In the search bar at the top, click the 'Check in' tab and check in the
item
** 36- Check the 'Print' button in the 'Hold filled for' message (returns.tt)
37- Go to Tools > Cash summary for Branch
38- Click 'record cashup' and confirm
39- Click the 'Summary' link in the 'Last cashup' column
** 40- Check the 'Print' button in the cashup summary modal
(cashup_summary.inc)
41- Go to Serials
42- Create a subscription (if there aren't any)
43- Receive an issue
44- From the subscription detail page, go to Create routing list
45- Add a recipient to the list
46- Save the routing list
47- Click 'Save and preview routing slip'
** 48- Check the 'Print' button in the routing list preview
(routing_preview_slip.tt)

Note: I can't find where the 'Print' from tinymce_i18n.inc is displayed in the
staff interface

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:10:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:10:13 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-nNuxmwH0qZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is an obvious and tiny patch, going straight to PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:10:12 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-lRigma7G03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:13:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:13:13 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-haQOGyL3sI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137687|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137773&action=edit
Bug 29114: Trim whitespace before the barcode

The solution was to add regexp that trims all whitespaces.

How to test:
1. Go to the koha/virtualshelves/shelves.pl;
2. Add new list or edit existing one;
3. Start adding new items;
4. In the "Barcode" field add barcode(s) with whitespaces before them;
5. Observe that it wasn't added as the barcode isn't recognized because of
whitespaces;
6. Apply the patch;
7. Repeat step 4;
8. Observe that the item was successfully added;

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:13:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:13:42 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-KBXTZO4GUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great work, thanks Andrii..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:13:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:13:48 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-C9s7wL36Iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|m.de.rooy at rijksmuseum.nl    |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:16:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:16:00 +0000
Subject: [Koha-bugs] [Bug 24867] Keep CircControl / ReservesControlBranch /
 HomeOrHolding together in sysprefs
In-Reply-To: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24867-70-qNi29TmMaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24867

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
'Circulation control libraries' works for me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:22:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:22:46 +0000
Subject: [Koha-bugs] [Bug 17650] Create the option to save local cover
 images outside the database
In-Reply-To: <bug-17650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17650-70-rzfqjB6YXF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Create the option to save   |Create the option to save
                   |the cover with the uploaded |local cover images outside
                   |files.                      |the database
            Version|16.05                       |master
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> Is there a reason the QA could already forewarn us about that this idea
> (moving biblioimages outside the DB) would gain no traction?

I think it would make sense to have this at least as an option. Not sure if or
how existing installations could be switched over. 

Adding some more CC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:25:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:25:19 +0000
Subject: [Koha-bugs] [Bug 27448] Update ElasticsearchCrossFields description
 to explain consequences of setting in Koha
In-Reply-To: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27448-70-WYZxBTixdN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27448

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It has a link to documentation that's not a link too :)

https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-multi-match-query.html#type-cross-fields

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:35:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:35:32 +0000
Subject: [Koha-bugs] [Bug 31060] Fine duplicates when returning item with
 accountline status marked as lost
In-Reply-To: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31060-70-TIBRKFXD8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31060

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm pretty sure this is by design actually.

It's not a duplicate fine.. it's a new fine... there are more preferences and
circulation rules that play into this.

I would take a look at the 'Lost item fee refund on return policy' section of
the circulation rules.  We describe what to do with these fines and lost fees
there.. i.e should we restore them, or charge a new fee.. perhaps there needs
to be further options there?

I don't think we should just undo the LOST status of the fine however.. that
could trigger refunds should the user have already paid for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:37:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:37:21 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-yH3QQD3Olc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Shouldn't this be sorted by DB field in the query Lucas, rather than after the
fact in perl?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:37:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:37:52 +0000
Subject: [Koha-bugs] [Bug 23869] Add regex test to marc mod template setup
In-Reply-To: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23869-70-f7JBfee2Ek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23869

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:40:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:40:53 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-R2m02CrV0P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:48:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:48:07 +0000
Subject: [Koha-bugs] [Bug 31164] New: When staging records,
 'ignore items' resets to 'import all items'
Message-ID: <bug-31164-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31164

            Bug ID: 31164
           Summary: When staging records, 'ignore items' resets to 'import
                    all items'
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When staging a record for import and you chose 'ignore items' from the last
pull down, it will still parse for items. And once you get to 'manage staged
records' the option will have reset to 'add all items'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:52:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:52:30 +0000
Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML
 UTF-8 breaks the encoding
In-Reply-To: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29333-70-IgIiYXQrrh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Julian Maurice from comment #13)
> (In reply to Katrin Fischer from comment #12)
> > Of course I did... :( It's 17754 that we just ran into on 20.11.
> Indeed they look very similar. Will you try to apply this patch to see if it
> fixes 17754 too ?

I finally got to test with this patch and it didn't fix it. But I found another
clue: the encoding in the MARC record was not set (for MARC21 LDR. pos. 9 = a).
Setting it manually and then reimporting fixed my issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:55:14 +0000
Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken
 (encoding) if LDR pos. 9 is missing
In-Reply-To: <bug-17754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17754-70-6JBZc0smGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|MARCXML upload in Intranet  |MARCXML upload in Intranet
                   |is broken (encoding)        |is broken (encoding) if LDR
                   |                            |pos. 9 is missing

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think I solved the riddle: The problem appears, if LDR pos. 9 = a (encoding)
is missing. 

The attached MARCXML record here is missing the leader and this position was
unset in the records I had issues with. Once I fixed the records, the import
worked as expected.

I wonder if we could automatically assume UTF-8 encoding, if the encoding is
not set?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:59:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:59:03 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-hnukvQeAe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137767|0                           |1
        is obsolete|                            |
 Attachment #137768|0                           |1
        is obsolete|                            |

--- Comment #112 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137775&action=edit
Bug 30952: (follow-up) Fix linting errors in SCSS

This patch makes some corrections to the style of modified SCSS:

- Space before "{"
- No leading zeroes in number values
- Upper case hex codes
- Multi-line comment style
- Use "border: 0" instead of "border: none"
- Remove vendor prefixes
- Remove commented-out declarations
- Put each selector on a separate line

The patch should have no visible effects on the style of the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 17:59:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 15:59:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-nVzvypzGUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #113 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137776&action=edit
Bug 30952: (follow-up) Correct whitespace errors

Tab characters are forbidden, as is space at the end of lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:11:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:11:40 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-TK3tOJxLiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136796|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137777&action=edit
Bug 30335: Add classes to invoice/credit tabs on patron accouting pages

To test:
1. Apply patch and go to the patron accounting page.
2. Notice the class names for each list element on the page.
3. You can use the following CSS to try hiding each of the tabs:

.transactions { display: none; }
.makepayment { display: none; }
.manualinvoice { display: none; }
.manualcredit { display: none; }

Signed-off-by: Rachael Laritz <rachael at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:11:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:11:43 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-8KXMRb2lWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137778&action=edit
Bug 30335: (follow-up) Add permissions for manual accounts options

This patch adds two new sub-permissions, `manual_credit` and
`manual_invoice` to allow/prevent staff the ability to add manual
invoices and credits to a patrons account.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:11:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:11:46 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-cwTAUcPJYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137779&action=edit
Bug 30335: (follow-up) Bind new permissions to pages and tabs

This patch binds the new permissions added in the previous patch to the
tab display on the borrower account page.

Test plan
1) Apply the previous patch and run the database update
2) Configure a user without the new permissions
3) Confirm the 'Create manual invoice' and 'Create manual credit' tabs
   no longer appear under the 'Accounting' area when logged in as the
   above user.
4) Confirm that you cannot manually navigate to /members/mancredit.pl or
   /members/maninvoice.pl when logged in as the above user.
5) Confirm that users with the above permissions are still able to see
   the tabs and take actions on them.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:12:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:12:34 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-0xj2PFE8RV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Couldn't help myself.. there was a suggestion here to use system preferences..
I felt user permissions made even more sense..

Follow-ups added to enhance this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:13:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:13:06 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-kpqF8PQPNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:13:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:13:14 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-Ss5jMJsAjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:13:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:13:44 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-AhXN8HEPgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Setting back to NSO to get an independent eye on my follow-ups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:15:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:15:18 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-8niTx9WpXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137436|0                           |1
        is obsolete|                            |

--- Comment #94 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137780&action=edit
Bug 27113: ElasticSearch: Autocomplete in input search

Usually the user knows only part of the title of the book or only the name of
the author, etc. When he start search something Koha (ElasticSearch) predicts
the rest of a word or expression which user is typing.  Autocomplete predicts
that thanks to index of ElasticSearch.

TEST PLAN
Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
must have all information in his index.
1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
!! APPLY PATCH !!
2. Mapping is good (Intranet -> Catalog -> Search engine configuration
(Elasticsearch) ).
!Recommended 'Reset Mapping'  -> 'Yes'
3. In your koha-conf.xml file you must have good <index_name> for
<elasticsearch> and version ES
4. Update Preference:
./installer/data/mysql/updatedatabase.pl
If that passe good you can look the lines:
 - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
 - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
elasticsearch
5. After that we can look two options in the preferences:
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
4. For add information in the index we must run script for reindexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d
5. Waiting for the end of indexing
6. Go on Preference and find :
-  IntranetAutocompleteElasticSearch;
-  OPACAutocompleteElasticSearch;
Value "Show" turn on autocomplete.
7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
also).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:15:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:15:23 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-kg9a6sKXEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137437|0                           |1
        is obsolete|                            |

--- Comment #95 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137781&action=edit
Bug 27113: (follow-up) Move new CSS to main SCSS files

This patch removes the separate CSS files added for the autocomplete
feature and puts them into the "main" SCSS files. I think a separate
file isn't necessary because the amount of CSS it adds is so small.

I've also tweaked the style of the autocomplete menu shown when you use
the arrow keys to navigate through the autocomplete choices. I think the
previous white-on-light-green didn't have enough contrast.

To test you must rebuild the OPAC and staff client CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Follow the previous test plan, being careful to observe how it
works when the autocomplete menu has been triggered and you use the
arrow keys to navigate through the results.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:15:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:15:28 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-LoqiML9Jtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137438|0                           |1
        is obsolete|                            |

--- Comment #96 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137782&action=edit
Bug 27113: (follow-up) Update descriptions for system preferences

Update the descriptions for the new system preferences -
IntranetAutocompleteElasticSearch and OPACAutocompleteElasticSearch.

Test plan:
1. Review the descriptions for the IntranetAutocompleteElasticSearch
   and OPACAutocompleteElasticSearch system preferences.
2. Make sure they are readable and make sense.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:15:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:15:32 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-96VPypSW2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137439|0                           |1
        is obsolete|                            |

--- Comment #97 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 137783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137783&action=edit
Bug 27113: (follow-up) fix adv. searches - more options display issue

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:22:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:22:51 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-KphPGXo6xu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137784&action=edit
Bug 30335: (follow-up) Ensure existing users remain permitted

This patch updates the database update to ensure users with the
'remaining_permissions' subpermission of 'updatecharges' continue to be
able to manually invoice and manually credit borrower accounts after the
patch is applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:28:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:28:02 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-YePZjdnNag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:32:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:32:29 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-K31ea2EqF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:33:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:33:02 +0000
Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be
 cataloged in the cataloguing home page
In-Reply-To: <bug-5523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5523-70-22c59yoJaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31162


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162
[Bug 31162] Add a clear cataloguing module home page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:33:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:33:02 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-BtF3SMpXPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |5523


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523
[Bug 5523] Display list of items which are to be cataloged in the cataloguing
home page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:34:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:34:01 +0000
Subject: [Koha-bugs] [Bug 5523] Display list of items which are to be
 cataloged in the cataloguing home page
In-Reply-To: <bug-5523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5523-70-sAzGI1Yxsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5523

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I reckon we could rethink this after bug 31162 now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:42:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:42:27 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-wHnlKa7qCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Alexis Ripetti <alexis.ripetti at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:42:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:42:31 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-feghUd2luw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Alexis Ripetti <alexis.ripetti at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137748|0                           |1
        is obsolete|                            |

--- Comment #6 from Alexis Ripetti <alexis.ripetti at inLibro.com> ---
Created attachment 137785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137785&action=edit
Bug 27136 - Add languages and avoid displaying nothing in facet

Signed-off-by: Alexis Ripetti <alexis.ripetti at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:46:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:46:44 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27113-70-s9467HaerB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #98 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
(In reply to Katrin Fischer from comment #93)
> First of all: I quite like the functionality and how this looks. It also
> appears to be pretty fast and accurate as far as I can tell. I especially
> like that it's not only available for the keyword index, but also on other
> search options like author search and limits the results down accordingly.
> 
> That said: There are a couple things here that would require fixing and a
> big question we need to resolve for moving this forward.
> 
> 
> The small stuff:
> 1) In the database update, there should still be a description for the
> system preference.
> 2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the
> prefs into the correct places.
> 3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2
> in coding guidelines)
> 4) In the database update elasticsearch should be Elasticsearch.
> 
> 
> Somewhat bigger:
> 
> 5) I have problems making this work with the "library catalog" and "title"
> search options in simple search in OPAC. title doesn't give me any results
> and library catalog looks like author (but it's a keyword search). Something
> might not be 'wired' correctly there.
> 6) Updating installations: I believe you also need to reset mappings to make
> this work? How can we ensure this works out of the box for people updating
> without them having to "redo" their index configuration? (database update?)
> 7) sub filterAutocomplete looks complex and I wonder if it should be in the
> .pl and not in a module where it can be tested. 942 is hardcoded as field
> for OpacSuppression, which is a little risky. I wonder if it could be more
> elegant to filter this at search time instead of after?

Small stuff fixed.

5) Searching with "title" works for me. Maybe an index issue? or is it just me?

   "library catalog" search displays suggestions for each search options in
this order: title-cover, author, subject, title-series, publisher. What I think
probably happened is, since "title" search doesn't work for you, it showed
"author" suggestions where you had more match than the maximum number of rows
displayed.

6) I don't know :/

7) I can move it to a module, but which one? Maybe in a new module? if so,
where?
   I reused the code in opac/opac-detail.pl where 942 is hardcoded too.
   I do think it would be better to filter at search time but I don't know
how...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:56:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:56:58 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-QnjBfO8p49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 18:57:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 16:57:01 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-SCo6tGh82F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137590|0                           |1
        is obsolete|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137786&action=edit
Bug 20439: Sort SMS providers in alphabetical order by DB field

To test:
1/ Add 'Email' to the 'SMSSendDriver' system preference.
2/ Make sure 'EnhancedMessagingPreferencesOPAC' and
'EnhancedMessagingPreferences' are turned on.
3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different
names.
4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by
when they were added, not alphabetically.
5/ Apply patch and restart services.
6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS
providers now sort alphabetically.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:03:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:03:19 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-XcmLypUfVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108633|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137787&action=edit
Bug 6419: Add custom HTML areas to intranet home pages

This patch adds customisable HTML text areas to acqui/acqui-home.pl,
authorities/authorities-home.pl, cataloguing/addbooks.pl,
virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and
serials/serials-home.pl pages

To test:

1) Apply patch
2) Run updatedatabase.pl
3) Add some html to the new prefs IntranetAcquisitionsHomeHTML,
   IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML,
   IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML
   and IntranetSerialsHomeHTML
4) View the Acquisition, Authorities, Cataloging, Lists, Patrons,
   Point of Sale, and Serials homepages and confirm that your changes
   show. Note that this should display in exactly the same way as it
   does in the already extant IntranetCirculationHomeHTML and
   IntranetReportsHomeHTML system preferences.

Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:03:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:03:33 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-azlFXbC9nh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:04:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:04:43 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-qqm32hVqPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased and fixed QA issues.

Probably worth a retest as the templates have changed significantly since this
was first written.

I still think it's a worthwhile little enhancement though :)

Regarding it still using system preferences, I felt that was the simplest route
to goal for now.. we can always move them later I feel.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:10:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:10:56 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-yFe1HijIwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31162

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:10:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:10:56 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-W5KG5puMQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6419

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:40:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:40:11 +0000
Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds
 causes all other holds to be prioritized as well!
In-Reply-To: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12630-70-ERkrsL7eBA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |

--- Comment #28 from Lucas Gass <lucas at bywatersolutions.com> ---
Backing porting upon request to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:49:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:49:12 +0000
Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout
 permission (checkouts tab)
In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29504-70-PnWCRlMm3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #26 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:51:25 +0000
Subject: [Koha-bugs] [Bug 30997] "CGI::param called in list context" warning
 in detail.pl flooding error log
In-Reply-To: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30997-70-QWSmXKZBU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30997

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:53:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:53:58 +0000
Subject: [Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken
 for translations
In-Reply-To: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30958-70-Iz246u1Z4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 19:57:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 17:57:25 +0000
Subject: [Koha-bugs] [Bug 28355] Add warning note about Email SMS driver
 option for SMSSendDriver
In-Reply-To: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28355-70-37yikOsF3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28355

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:10:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:10:13 +0000
Subject: [Koha-bugs] [Bug 31166] New: Digest option is not selectable for
 phone when PhoneNotification is enabled
Message-ID: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

            Bug ID: 31166
           Summary: Digest option is not selectable for phone when
                    PhoneNotification is enabled
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Digests are not available via Talking Tech, but the artificial limit should not
be in place for the non-TT phone notices. If only phone is selected, digest
remains disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:10:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:10:23 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-2f88z4fZTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:12:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:12:57 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-xs9uVHvlNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:13:00 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-XMSbNFcCQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137788&action=edit
Bug 31166: Digest option is not selectable for phone when PhoneNotification is
enabled

Digests are not available via Talking Tech, but the artificial limit should not
be in place for the non-TT phone notices. If only phone is selected, digest
remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:43:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:43:15 +0000
Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50
 filter
In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30966-70-VxD5rQbNjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
         Depends on|                            |14957


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
[Bug 14957] Write protecting MARC fields based on source of import
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:43:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:43:15 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-FT6o1ouQDZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966
[Bug 30966] Record Overlay Rules - can't use Z39.50 filter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:47:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:47:48 +0000
Subject: [Koha-bugs] [Bug 30980] Make patron selection more consistent
In-Reply-To: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30980-70-PyG70ACE6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30980

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the idea of auto-complete in combination with opening a full search if
needed. But we might need to try it out to see if that works. I know that there
have been complaints about auto-complete from very big library systems with a
lot of similar user  names as the pull downs usually limit to x visible
entries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:49:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:49:35 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-L5lgjG3jUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, can you explain a bit more about the issue here? I am not sure what
the expected behavior would be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:52:57 +0000
Subject: [Koha-bugs] [Bug 27685] Syspref OpacSuppression has no effect on
 the bibliographic detail page
In-Reply-To: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27685-70-CqatfRpf49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27685

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I suspect that my records were not properly indexed, can't replicate either.
Closing WORKSFORME. Please reopen if necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:57:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:57:33 +0000
Subject: [Koha-bugs] [Bug 31101] Allow other separation options for
 digesting circulation alerts (checkin, checkout, renewal)
In-Reply-To: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31101-70-jEhfCjp0tY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31101

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
What do you mean by ovedue digest flag?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 20:59:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 18:59:18 +0000
Subject: [Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does
 not work in overdues report
In-Reply-To: <bug-30735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30735-70-Gm08eRjCDI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Arthur, could you check this one for backporting please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:07:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:07:36 +0000
Subject: [Koha-bugs] [Bug 27996] Format of "Due date" on Circulation >
 Overdues page
In-Reply-To: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27996-70-X5lxWoAVuZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31167
[Bug 31167] Only mark due dates in the past red on overdues report
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:07:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:07:36 +0000
Subject: [Koha-bugs] [Bug 31167] New: Only mark due dates in the past red on
 overdues report
Message-ID: <bug-31167-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31167

            Bug ID: 31167
           Summary: Only mark due dates in the past red on overdues report
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 27996

Bug 27996 added formatting to the due dates on the overdues report, but we
forgt that it doesn't only show due dates in the past. If you check the
checkbox on top, also current checkouts with due dates in the future will
display. They area also formatted in red now.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27996
[Bug 27996] Format of "Due date" on Circulation > Overdues page
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:11:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:11:05 +0000
Subject: [Koha-bugs] [Bug 26488] Overdue report download not respecting
 custom patron attribute filter
In-Reply-To: <bug-26488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26488-70-b1wl30TTAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26488

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is still valid on current master. To test:

* Create a new patron attribute TEST as a free text field
* Make sure at least 2 patrons in your installation have checked out items
* Edit one of those patrons and fill the TEST attribute with test
* Go to Circulation > Overdues
* Check the checkbox on top to show all checkouts
* Verfiy both your patrons show up
* Limit search by searching for test in your TEST attribute
* Verify the correct patrons show in the search result list
* BUT: download the list: it will show all patrons with checkouts again

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:19:30 +0000
Subject: [Koha-bugs] [Bug 31000] Use of uninitialized value $record_type in
 string eq
In-Reply-To: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31000-70-5gRF2pDi4k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31000

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This fixes the cause of an  |This fixes the cause of an
      release notes|error message that appears  |error message that appears
                   |in the system logs every    |in the system logs every
                   |time that Tools > Catalog > |time that Tools > Catalog >
                   |Export data                 |Export data
                   |(/cgi-bin/koha/tools/export |(/cgi-bin/koha/tools/export
                   |.pl) is accessed. The error |.pl) is accessed. The error
                   |message was "AH01215: Use   |message was "AH01215: Use
                   |of uninitialized value      |of uninitialized value
                   |$record_type in string eq   |$record_type in string eq
                   |at /koh                     |at
                   |adevbox/koha/tools/export.p |/kohadevbox/koha/tools/expo
                   |l line 43.:                 |rt.pl line 43.:
                   |/kohadevbox/koha/tools/expo |/kohadevbox/koha/tools/expo
                   |rt.pl,...".                 |rt.pl,...".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:30:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:30:24 +0000
Subject: [Koha-bugs] [Bug 31167] Only mark due dates in the past red on
 overdues report
In-Reply-To: <bug-31167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31167-70-lpWSpjbRwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31167

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:41:15 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-LQItTe8Qwr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, this sounds really ineresting! Could you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17170: (follow-up) Correct handling of limits in ES
error: sha1 information is lacking or useless (C4/Search.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 17170: (follow-up) Correct handling of limits in ES
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-17170-follow-up-Correct-handling-of-limits-in--3qL2M9.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 21:49:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 19:49:36 +0000
Subject: [Koha-bugs] [Bug 30176] Koha Manual Link for latest manual
In-Reply-To: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30176-70-GrvnpauOal@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30176

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Kelly McElligott from comment #0)
> Up until recently, the link:
> https://koha-community.org/manual/latest/en/html would bring the user to the
> most recent version of Koha manual, which should be 21.11, however, at this
> time, the 'latest' link is still referring to the 20.11 version. 

I am not sure who maintains the forwarding for this link, but it looks like it
should be part of the post-release tasks list to update?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:04:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:04:14 +0000
Subject: [Koha-bugs] [Bug 30980] Make patron selection more consistent
In-Reply-To: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30980-70-0YUwASNQ01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30980

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Limiting pull downs would be a thing of the past if we use infinite scrolling
in select2 which I've trialed in a few places.

It's the filtering down further after doing an initial search which isn't so
well handled.  Must admit, I've never seen the need in real life myself, but
Jonathan assures me theres a real need for these advanced secondary filters.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:25:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:25:24 +0000
Subject: [Koha-bugs] [Bug 30176] Koha Manual Link for latest manual
In-Reply-To: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30176-70-LBpK7ynOYR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30176

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It's Liz, she's that only one with that level of access to the server the docs
are hosted on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:26:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:26:37 +0000
Subject: [Koha-bugs] [Bug 30176] Koha Manual Link for latest manual
In-Reply-To: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30176-70-dLmSWDvTpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30176

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The development version of the manual also isn't yet available and we need to
mark the 22.05 manual as current too.. we need to branch the repo soon

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:27:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:27:42 +0000
Subject: [Koha-bugs] [Bug 30176] Koha Manual Link for latest manual
In-Reply-To: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30176-70-nSvRH9ixIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30176

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:38:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:38:13 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-YqhVYzF14d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 22:50:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 20:50:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-48ps5r0ffP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #114 from Cab Vinton <bibliwho at gmail.com> ---
Agreeing with the comments of George & Barbara on accessibility & design of the
header (comments 104, 105).

Search bar, icon sizes, et al. as presently configured would present *many*
issues to staff.

A couple other notes on issues in the current sandbox that are no doubt being
worked on:

Patrons page (members-home.pl): layout issues

Lists page (shelves.pl): Template process failed: file error - parse error

Cab Vinton/ Plaistow PL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 23:00:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 21:00:02 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-IsTBnsrNkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137788|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137789&action=edit
Bug 31166: Digest option is not selectable for phone when PhoneNotification is
enabled

Digests are not available via Talking Tech, but the artificial limit should not
be in place for the non-TT phone notices. If only phone is selected, digest
remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected

Signed-off-by: Evelyn Hartline <evelyn at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 23:01:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 21:01:34 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-VyygD2By5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

evelyn <evelyn at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |evelyn at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 15 23:41:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Jul 2022 21:41:31 +0000
Subject: [Koha-bugs] [Bug 31168] New: Temporary Item Locations
Message-ID: <bug-31168-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31168

            Bug ID: 31168
           Summary: Temporary Item Locations
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

There is a needed item field when it comes to locations.  Right now, if you put
in a permanent location, if an item is returned, the location is temporarily
changed to the cart location, and then back.

However, there are other scenarios that are getting overlooked.

Sometimes an item lives on a new books shelving location.  Sometimes it lives
on a display.

These locations are temporary, and these items eventually have to make their
way back to their permanent shelving location.

There is no field for a temporary location, so we end up using the permanent
location.  And because we do this, we are unable to automate the process of
setting it back to its regular shelving location when it is time, because there
is nothing for the automatic item modifications by age tool to look at to
determine what the permanent shelving location needs to be changed too.

I propose that a temporary shelving location field be added, where we can
select from the shelving locations the place that it will live for a little
while, and the permanent shelving location can be set where it will usually
live.  We can then use the automatic item modifications by age tool to set this
back after a set time.

Ideally, it would be better if we could automate this from the record itself,
perhaps setting a temporarily shelving location cutoff date.  Otherwise, the
temporary shelving location is only good as long as a rule exists for it in the
tool.  Having the cutoff date in the item record would make this extremely easy
to use.  Maybe fore a little extra, we could have a couple buttons next to the
field with pre-defined (in preferences) lengths of time.  For example, one
button for New Books, and another for Displays.  Click whichever button, and it
would set the date x days from today based on the pref.  Or you could manually
pick a date from a date picker as to when it would revert back.

Once that date comes around, that temporarily location can either be cleared or
remain, but the permanent shelving location is displayed past the date.

If a date is not entered, the temporary location is used indefinitely.  And of
course, if there is no temporary shelving location, the permanent location is
used.

Some of this could be done in stages, if not all at once, but this would be a
fantastic step forward for libraries that utilize temporary placement and
shelving.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 03:37:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 01:37:42 +0000
Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item
 types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-Cseaj2MS1k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

--- Comment #23 from David Nind <david at davidnind.com> ---
I've tested, but haven't signed off.

Notes from testing (using koha-testing-docker):

1. Some icons only display for some pages if the item-level_itypes system
preference is set to bibliographic record.

2. May also need to set the noItemTypeImages (for staff interface) or
OpacNoItemTypeImages system preferences to 'Show'.

3. For the staff interface and with the CSS to hide the text description:
   . catalogue/detail.tt: see note for staff interface and catalogue/detail.tt
- can't hide text description for 'Itemtype' shown on the details page before
the holdings tab

4. For the OPAC, I'm not sure how to test opac-results-grouped.tt: there is no
opac-results-grouped.tt file, item type icon and text show for normal OPAC
search results when OPACnoItemTypeImages system preference is set to 'Show',
with OPAC CSS to hide no text description is shown in search results (but icon
is).

5. How to access pages to test, along with some notes: 

= STAFF INTERFACE =
 - catalogue/advsearch.tt (Home page > Advanced search)
 - catalogue/detail.tt (view the details page for a record with items - note: 
   . if item-level_itypes = specific item and noItemTypeImages set to 'Don't
show' ==> text only descriptions shown for both
   . if item-level_itypes = specific item and noItemTypeImages set to 'Show'
==> icons and text description shown for both
   . if item-level_itypes = bibliographic record and noItemTypeImages set to
'Show' ==> icons and text description only shown for the record, the Item types
column under the holdings tab is not shown
    . if item-level_itypes = bibliographic record and noItemTypeImages set to
'Don't show' ==> text description only for the record,  the Item types column
under the holdings tab is not shown
 - catalogue/results.tt (set noItemTypeImages system preference to 'Show',
search in the staff interface)
 - reserve/request.tt (place a hold for a record, select a patron, item type
column displayed for specific items) 
 - virtualshelves/shelves.tt (set noItemTypeImages to 'Show', set
item-level_itypes to bibliographic record: create and add items to a public
list, Lists > select the list)

= OPAC =
 - opac-advsearch.tt (advanced search page)
 - opac-detail.tt (view the details page for a record with items)
 - opac-readingrecord.tt (check out some items for a patron, go to Your account
> your checkout history for that patron)
 - opac-reserve.tt (place a hold for a record, select 'a specific item', table
lists the item type)
 - opac-results-grouped.tt (not sure how to test this on, no longer an
opac-results-grouped.tt file; item type icon and text show on normal OPAC
search results when OPACnoItemTypeImages system preference set to 'Show')
 - opac-shelves.tt (set OPACnoItemTypeImages to 'Show', set item-level_itypes
to bibliographic record: add items to a list, view list More > Lists > select
the list)
 - opac-user.tt (set OPACnoItemTypeImages to 'Show', set item-level_itypes to
bibliographic record: check some items to a patron, go to Your account >
summary for the patron)

6. Personally, I think enhancing the existing system preferences
item-level_itypes, noItemTypeImages and OpacNoItemTypeImages would be a better
way to go. But having some way to do it is better than no way...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 09:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 07:49:53 +0000
Subject: [Koha-bugs] [Bug 26183] UpdateItemWhenLostFromHoldList should be
 limited in scope
In-Reply-To: <bug-26183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26183-70-qsw3aAdR6d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26183

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jamespfk at gmail.com          |koha-bugs at lists.koha-commun
                   |                            |ity.org

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure if this has not turned out as a non-issue over time by now with
people not breaking things badly, although they could. They also might be using
more than notforloan and itemlost... I think it could be nice to add an
internal note too.

I believe we cannot always prevent people from doing bad things. 

I feel like we might want to close WONTFIX.

But if people disagree: instead of limiting the pref, could we use an
allowlist/denylist of fields that will be updated in the background instead? 

I agree with Andrew's list in general, but would allow changing itype.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 09:58:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 07:58:01 +0000
Subject: [Koha-bugs] [Bug 23832] 001 control number auto complete or copy
 from 999c
In-Reply-To: <bug-23832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23832-70-cqiV8yaF31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23832

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
            Summary|001 control number auto     |001 control number auto
                   |complet or copy from 999c   |complete or copy from 999c
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, I believe this is now a duplicate to bug 27981 that will allow to auto-add
the biblionumber to 001.

There also has been a plugin for generating a number in 001 for a while now
with the advanced editor.

*** This bug has been marked as a duplicate of bug 27981 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 09:58:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 07:58:01 +0000
Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001
 control number to the biblionumber
In-Reply-To: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27981-70-DNv7fswhhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #68 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 23832 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 10:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 08:10:50 +0000
Subject: [Koha-bugs] [Bug 31019] UNIMARC field help link when cataloguing -
 default location needs updating
In-Reply-To: <bug-31019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31019-70-bUl9rYgTPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31019

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like the Italian version would work fine with MarcFieldDocURL, but
most links, including to the English version are broken:

https://www.ifla.org/publications/unimarc-formats-and-related-documentation/

Then there is https://www.ifla.org/g/unimarc-rg/unimarc-updates/, but it looks
like the full documentation is not (or no longer?) available online.

Maybe we should just remove the default URL for UNIMARC?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 10:14:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 08:14:16 +0000
Subject: [Koha-bugs] [Bug 9799] Prompt for due date for specific item types
In-Reply-To: <bug-9799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9799-70-XjXqY9OSf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9799

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24239

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We now have the option to add the due_date in the ILL backend and use it in
circulation, not quite the same, but maybe still helpful to some:
Bug 24239 - Let the ILL module set ad hoc hard due dates

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 10:14:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 08:14:16 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24239-70-TDdJWWRoKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9799

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 10:15:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 08:15:10 +0000
Subject: [Koha-bugs] [Bug 28685] Should AutoControlNumber also overwrite 003
 field ?
In-Reply-To: <bug-28685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28685-70-QcMSHWn0Er@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28685

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27981


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981
[Bug 27981] Add option to automatically set the 001 control number to the
biblionumber
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 10:15:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 08:15:10 +0000
Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001
 control number to the biblionumber
In-Reply-To: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27981-70-wLwIHpDC0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |28685


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28685
[Bug 28685] Should AutoControlNumber also overwrite 003 field ?
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 11:21:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 09:21:23 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-FcUfdaU6e8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Awesome, thanks Lucas. I'll take a look at straight QAing this on Monday..
unless someone gets a signoff in in the mean time :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 12:30:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 10:30:17 +0000
Subject: [Koha-bugs] [Bug 28651] Automatic renewal don't send out notice if
 status "On hold"
In-Reply-To: <bug-28651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28651-70-yb4DypkcBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28651

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Like Nick, I cannot replicate the problem. I ran through the test plan and the
notice was generated as expected using Koha's sample notice:

Dear ...,

The following item, Effective Perl programming , has not been renewed because:

This item is on hold for another patron.


I am closing this WORKSFORME, pleas reopen if you still see the issue, but
please note that 20.11 is no longer supported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 12:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 10:33:08 +0000
Subject: [Koha-bugs] [Bug 28987] Record search by date broken in label
 management
In-Reply-To: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28987-70-SgRF5Qhqlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 30745 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 12:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 10:33:08 +0000
Subject: [Koha-bugs] [Bug 30745] ES : Search never return result using
 after-date and/or before-date in labels/label-item-search.pl
In-Reply-To: <bug-30745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30745-70-nuRQ5LMrm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 28987 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 12:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 10:40:51 +0000
Subject: [Koha-bugs] [Bug 26841] No warning if a hold on an available item
 is placed in staff with AllowHoldPolicyOverride
In-Reply-To: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26841-70-TRhgGUBy92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.05                       |master
            Summary|Koha staff interface - all  |No warning if a hold on an
                   |items reservable (against   |available item is placed in
                   |the rule: If all            |staff with
                   |unavailable)                |AllowHoldPolicyOverride

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tested this on master and this is still valid:

With AllowHoldPolicyOverride off, I get the following warning and cannot place
a hold:

No items are available to be placed on hold

With AllowHoldPolicyOverride set to Allow, I see no warning and can place the
holds. It's not visible in any way, that we are dealing with an override.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:15:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:15:59 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-LF5yw7Ow6W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113890|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137790&action=edit
Bug 27045: Fix items lost report export if delimiter is tab

When choosing tabulation as the delimiter for a CSV profile
for the lost item report, the tabs appear in the file as \t
instead of as proper tabs.

title\tauthor\tstocknumber\tcallnumber
"E Street shuffle :"\"Heylin, Clinton."\\

To test:
* Upate the existing sample lost item CSV profile to use tabs as
  separator
* Make sure you have some lost items in your database or create some
* Go to Reports > Lost items
* Run the report
* Check all or some of the checkboxes in the result list
* Export using the link on top and the CSV profile
* Verify the tabs are not exported correctly
* Apply patch
* Verify tabs now are proper tabs instead of \t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:16:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:16:07 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-LMJJocMYOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137791&action=edit
Bug 27045: Fix other exports using CSV profiles

This patch corrects the export of the 2 other reports
using CSV profiles:

* Late issues (serials)
* Basket (acquisitions)

To test:
1) Late issues
* Update the late issues sample report to use tab as separator
* Create a subscription
* Go to serial collection and 'generate next' to get some late issues
* Go to Claims
* Export the late issues and verify format is correct
* Verify exported file has tabs

2) Basket summary
* Create an order with several order lines
* Create an SQL type CSV profile for basket export using tab as separator
  Example: aqorders.quantity|aqordres.listprice|Title=biblio.title
* Export the basket using your configured CSV profile
* Verify exported file has tabs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:16:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:16:35 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-VdoBA8Y5Bf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113891|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:18:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:18:28 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-Tk2GGrPtN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joubu,

I've rebased the patch set, cleaned up the descriptions and added test plans.
There is only one problem: this works almost perfectly, but the header rows for
the basket and late serial issues still show the \t, while the data has the
proper tabs.

Example:

aqorders.quantity\taqordres.listprice\tTitle
1       12.000000       "Perl best practices /"

Could you help?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:18:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:18:34 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-ji0YiTO2y3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:18:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:18:52 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-g4EzSuVw9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:25:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:25:10 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-8C0ETDYVyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:25:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:25:14 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-DfW1GTRn4N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137790|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137792&action=edit
Bug 27045: Fix items lost report export if delimiter is tab

When choosing tabulation as the delimiter for a CSV profile
for the lost item report, the tabs appear in the file as \t
instead of as proper tabs.

title\tauthor\tstocknumber\tcallnumber
"E Street shuffle :"\"Heylin, Clinton."\\

To test:
* Upate the existing sample lost item CSV profile to use tabs as
  separator
* Make sure you have some lost items in your database or create some
* Go to Reports > Lost items
* Run the report
* Check all or some of the checkboxes in the result list
* Export using the link on top and the CSV profile
* Verify the tabs are not exported correctly
* Apply patch
* Verify tabs now are proper tabs instead of \t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:25:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:25:19 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-za1CxcfnTB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137791|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137793&action=edit
Bug 27045: Fix other exports using CSV profiles

This patch corrects the export of the 2 other reports
using CSV profiles:

* Late issues (serials)
* Basket (acquisitions)

To test:
1) Late issues
* Update the late issues sample report to use tab as separator
* Create a subscription
* Go to serial collection and 'generate next' to get some late issues
* Go to Claims
* Export the late issues and verify format is correct
* Verify exported file has tabs

2) Basket summary
* Create an order with several order lines
* Create an SQL type CSV profile for basket export using tab as separator
  Example: aqorders.quantity|aqordres.listprice|Title=biblio.title
* Export the basket using your configured CSV profile
* Verify exported file has tabs

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:25:23 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-C8ZmLnixv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137794&action=edit
Bug 27045: (follow-up) Fix delimiter in header rows

The header rows still showed \t because the newly defined
variable wasn't used there.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:26:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:26:19 +0000
Subject: [Koha-bugs] [Bug 27045] Tabulation in CSV profile for lost items
 doesn't export correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-oX8NIwbE6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #11)
> Hi Joubu,
> 
> I've rebased the patch set, cleaned up the descriptions and added test
> plans. There is only one problem: this works almost perfectly, but the
> header rows for the basket and late serial issues still show the \t, while
> the data has the proper tabs.
> 
> Could you help?

Never mind - found the fix myself :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:27:53 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-VJg8UVg2xi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tabulation in CSV profile   |Exports using CSV profiles
                   |for lost items doesn't      |with tab as separator don't
                   |export correctly            |work correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:30:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:30:22 +0000
Subject: [Koha-bugs] [Bug 31169] New: [OMNIBUS] Problems with forced holds
 (AllowHoldPolicyOverride)
Message-ID: <bug-31169-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169

            Bug ID: 31169
           Summary: [OMNIBUS] Problems with forced holds
                    (AllowHoldPolicyOverride)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When holds are forced, this can create several issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:30:44 +0000
Subject: [Koha-bugs] [Bug 31169] [OMNIBUS] Problems with forced holds
 (AllowHoldPolicyOverride)
In-Reply-To: <bug-31169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31169-70-8ndCXSFJR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |26841, 28788


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26841
[Bug 26841] No warning if a hold on an available item is placed in staff with
AllowHoldPolicyOverride
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28788
[Bug 28788] Default holds policy by item type can be overridden but holds will
not capture
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:30:44 +0000
Subject: [Koha-bugs] [Bug 26841] No warning if a hold on an available item
 is placed in staff with AllowHoldPolicyOverride
In-Reply-To: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26841-70-A1qBtokiAf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26841

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:30:44 +0000
Subject: [Koha-bugs] [Bug 28788] Default holds policy by item type can be
 overridden but holds will not capture
In-Reply-To: <bug-28788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28788-70-myGNnjJUV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28788

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 17884] troubles with syspref
 AllowHoldPolicyOverride on return
In-Reply-To: <bug-17884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17884-70-82XxX8h2WQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 31169] [OMNIBUS] Problems with forced holds
 (AllowHoldPolicyOverride)
In-Reply-To: <bug-31169-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31169-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31169-70-zcRA0kGYCr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13559, 17884, 26463, 27895,
                   |                            |30687


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13559
[Bug 13559] Forced item level hold should be highlighted on return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884
[Bug 17884] troubles with syspref AllowHoldPolicyOverride on return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26463
[Bug 26463] AllowHoldPolicyOverride overrides too many holds policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895
[Bug 27895] Internal server error when trying to change pickup location for a
hold with no valid locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687
[Bug 30687] Unable to override hold policy if no pickup locations are available
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 13559] Forced item level hold should be
 highlighted on return
In-Reply-To: <bug-13559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13559-70-N6joLmbCQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13559

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup
 locations are available
In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30687-70-luQILliAZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 26463] AllowHoldPolicyOverride overrides too many
 holds policies
In-Reply-To: <bug-26463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26463-70-h2FxuKx9dC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26463

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:35:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:35:05 +0000
Subject: [Koha-bugs] [Bug 27895] Internal server error when trying to change
 pickup location for a hold with no valid locations
In-Reply-To: <bug-27895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27895-70-SVq81OH7Ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31169


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31169
[Bug 31169] [OMNIBUS] Problems with forced holds (AllowHoldPolicyOverride)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:43:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:43:25 +0000
Subject: [Koha-bugs] [Bug 26347] Wrong publication pattern locale on months
In-Reply-To: <bug-26347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26347-70-X4Xzu6DKgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 30035 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:43:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:43:25 +0000
Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
In-Reply-To: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30035-70-NX2Ctsff12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 26347 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:46:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:46:31 +0000
Subject: [Koha-bugs] [Bug 27081] Notes missing from lost items report column
 configuration when CSV export is active
In-Reply-To: <bug-27081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27081-70-h0sUBXFGo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27081

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Notes missing from lost     |Notes missing from lost
                   |items report column         |items report column
                   |configuration               |configuration when CSV
                   |                            |export is active
            Version|20.05                       |master

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid on master.

To test:
* Create a CSV profile of type SQL for exporting lost items
* Make sure you have some lost items
* Run Reports > Items lost
* Verify the list of columns ends with 'not for loan status', note is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:49:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:49:00 +0000
Subject: [Koha-bugs] [Bug 8214] Create a bound with function
In-Reply-To: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8214-70-S4EB2cdVsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > There is a difference:
> > 
> > "Bound withs" are on item level. The library might have something twice, but
> > once it's bound with something else and once it's on its own. That can
> > happen especially in libraries with old and rare books.
> > 
> > bug 11175 is talking about showing relationships between bibliographic
> > records, so it's on a different level. For example in Germany for a multi
> > volume work you'd usually have a 'set record' that represents the whole work
> > and then a record for each volume. They are tied together using 7xx and 8xx.
> > The goal of bug 11175 would then be to show the volume records on the set
> > record.
> 
> Oh, I wasn't thinking of this at the item level.. so does this really need
> the Holdings level MARC support before it can be implemented then?  i.e.
> should it depend on bug 20447

No, I think the holdings are more for grouping several items or holdings of one
record. A bound with would be items from different records, I believe this is
yet another use case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 13:58:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 11:58:55 +0000
Subject: [Koha-bugs] [Bug 28846] MarcRecordFromNewSuggestion needs mapping
 to biblioitems.itemtype
In-Reply-To: <bug-28846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28846-70-aZUvBAeJq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28846

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Libraries using item-level itypes usually still have the mapping on record
level, although they might set it to be not mandatory in cataloguing. There is
a lot of functionality tied to the record level itype, even when using item
level itypes, so both make sense to have.

biblio.author should also exist.

Is this to avoid an explosion if the mapping doesn't exist?

I tried to remove both and create a record from a suggestion:

* Administration > Kohat-to-MARC-Mapping, unmap biblio.author and
biblioitems.itemtype (not a good idea, but for testing)
* Add a new suggestion > BOOM!

Tag "" is not a valid tag. at /kohadevbox/koha/C4/Suggestions.pm line 492.

This is actually odd, because creating a suggestions doens't create a MARC
record yet.

Is this a non-fix if mappings are also required in other places or an even
bigger issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:32:06 +0000
Subject: [Koha-bugs] [Bug 8214] Create a bound with function
In-Reply-To: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8214-70-i0nRdhOCOm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So many similar but different functions.. how would this relate too the
recently pushed bundles and item groups bugs.

Almost sounds like an automatic multi-checkout? I.e if you checkout an item
that's bound with another you automatically get the other item checked out too.
Spitballing, I have no idea how this works really

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:34:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:34:29 +0000
Subject: [Koha-bugs] [Bug 8214] Create a bound with function
In-Reply-To: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8214-70-uLVfFn3o0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it would be more like EasyAnalytics (actually that could be used as a
bound with). There would only be one physical thing, so only one barcode to
check out.. and ideally you'd see it's gone on all the records/titles it
contains.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:47:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:47:18 +0000
Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields
In-Reply-To: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30218-70-21tGwhzNJk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:47:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:47:22 +0000
Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields
In-Reply-To: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30218-70-a3HoWq7bJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137795&action=edit
Bug 30218: Add subfield g to field 150 in C4::Heading::MARC21 mappings

When creating authorities via SRU or linking exising authorities
(via cgi-bin/koha/authorities/auth_finder.pl) the search results are
generated using the hardcoded mappings $bib_heading_fields /
$auth_heading_field from C4::Heading::MARC21. For TOPIC_TERM / field 150
these mappings currently include the subfield `abvxyz68`.

But: We are using the GND provided by Deutsche Nationalbibliothek.
We imported some authorities from there, for example:

http://d-nb.info/gnd/4114171-4 "Kind <0-3 Jahre>" (kid 0-3 years)
http://d-nb.info/gnd/4196417-2 "Kind <0-4 Jahre>" (kid 0-4 years)

When searching for these terms, Koha only displays "Kind", which is not
very helpful, as there are a lot of different authorities for different
age bands.

GND stores "Kind" in 150a, and "0-3 Jahre" in 150g.

But in the hardcoded mappings used by Koha, subfield g is not included.

This patch adds subfield g to these mappings, thus making it possible to
easily select the correct authority.

Test plan:
* Create an authority (or edit an existing one) and set 150g to "foo"
* Create a new biblio (or edit an existing one), go to field 650 and click
  on the search-icon on the right.
* A popup should open, where you can search for "Authority type: TOPIC_TERM",
  enter the name of the authority (150a!) in the search box
* In the resulting list, you will only see the value of 150a.
* Apply the patch
* Search again, now you should see "foo" in the result list

Sponsored-by: Steiermärkische Landesbibliothek

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:53:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:53:23 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-iVQrx5keCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can we please have a rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15048 - subject/genre (650/655) searches fail on searches with $x
'General subdivision' subfield values
Applying: Bug 15048: Index all possible searched subfields for index-term-genre
Using index info to reconstruct a base tree...
M       etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
M       etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15048: Index all possible searched subfields for
index-term-genre
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15048-Index-all-possible-searched-subfields-fo-UEZYrg.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 14:55:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 12:55:36 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-8eYi33Dvbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #8)
> Bug 28870 solves the backend email validation issues, and accepts formatted
> addresses. The remaining problems are related to the jquery library we use:
> 
> https://jqueryvalidation.org/email-method/
> 
> one path for solving it, could be trying to extract the regex from
> Email::Address and override the one in the jQuery library with it. Another
> option could be to add a route for email validation so an async check is
> done.

I missed this comment, so it looks like they should not cause issues and it's
only a matter of the validation now, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 15:45:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 13:45:41 +0000
Subject: [Koha-bugs] [Bug 26463] AllowHoldPolicyOverride overrides too many
 holds policies
In-Reply-To: <bug-26463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26463-70-BR6gsVmUBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Will take a look on Monday.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 15:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 13:47:54 +0000
Subject: [Koha-bugs] [Bug 31019] UNIMARC field help link when cataloguing -
 default location needs updating
In-Reply-To: <bug-31019-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31019-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31019-70-e2RSmTLzc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31019

--- Comment #3 from David Nind <david at davidnind.com> ---
I also found:
- https://www.ifla.org/g/unimarc-rg/unimarc-updates/
- https://www.iflastandards.info/unimarc (but it doesn't provide as good an
explanation as the narrative information)

Removing the default URL seems like a good plan!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 17:01:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 15:01:21 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-EurDhWumJ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |---
             Status|RESOLVED                    |REOPENED

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi all.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 17:01:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 15:01:44 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-gsjRbR9AQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |In Discussion

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
wajasu was asking for this. Re-opening to keep the discussion flowing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 17:01:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 15:01:56 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-n9uz5SvtCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matted-34813 at mypacks.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 18:06:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 16:06:02 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-pOgqH8lrDI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #9)
> (In reply to Tomás Cohen Arazi from comment #8)
> > Bug 28870 solves the backend email validation issues, and accepts formatted
> > addresses. The remaining problems are related to the jquery library we use:
> > 
> > https://jqueryvalidation.org/email-method/
> > 
> > one path for solving it, could be trying to extract the regex from
> > Email::Address and override the one in the jQuery library with it. Another
> > option could be to add a route for email validation so an async check is
> > done.
> 
> I missed this comment, so it looks like they should not cause issues and
> it's only a matter of the validation now, right?

You mean validating in the form. Right? I'm that case, that's what I think

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 18:53:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 16:53:08 +0000
Subject: [Koha-bugs] [Bug 31168] Temporary Item Locations
In-Reply-To: <bug-31168-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31168-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31168-70-brMLYZQt8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31168

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I like this idea! It takes a few things Koha kinda already knows how to do and
brings them together into a nice whole.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:12:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:12:39 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-7e3duVMekJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can replicate the issue, when the 'date acquired' is filled in. This gives
the error every time on adding multiple items:

Uncaught TypeError: $(...).parent(...).attr(...) is undefined

Johanna, are you still working on a fix?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:14:51 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-8ac2KAJ91v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29239


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239
[Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:14:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:14:51 +0000
Subject: [Koha-bugs] [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker
 with flatpickr
In-Reply-To: <bug-29239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29239-70-ygtVda49Mf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23202


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202
[Bug 23202] Problems when adding multiple items to an order in acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:39:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:39:15 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-1RgtIVmCci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |normal
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
            Version|21.11                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is valid in master as well:

Default checkout, hold and return policy
Max holds: 1

Default checkout, hold policy by patron category:
Staff: Max holds: Unlimited

You can't place a second hold. Only the first rule is applied, although the GUI
says that the patron category rule will be used.

This shows that the "Unlimited" rule is actually not seen/ignored.

In circulation rules we have:

| 34 | NULL  | NULL  | NULL     | patron_maxissueqty               |      |
| 35 | NULL  | NULL  | NULL     | patron_maxonsiteissueqty         |      |
| 36 | NULL  | NULL  | NULL     | max_holds                        | 1    |
| 31 | NULL  | S     | NULL     | patron_maxonsiteissueqty         | 80   |
| 33 | NULL  | S     | NULL     | patron_maxissueqty               | 80   |

The line for max_holds and Staff (S) is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:41:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:41:04 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-GvG7JTLtpg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137626|0                           |1
        is obsolete|                            |

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137796&action=edit
Bug 30970: Add checkbox column to holdst and holdso

This patch adds the missing checkbox column to the columns_settings
configuration file.

The field was added unconditionally to the tables in bug 23678 and then
consequently fixed in master as part of bug 27868 which being an
ehancement wont be backported.  This patch simply lifts the relevant
part of the fix from bug 27868 to apply just to the 21.11.x branch.

Signed-off-by: Lucy Harrison <l.m.harrison at lboro.ac.uk>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:41:15 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-AbhNMS5KWH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 29061 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:41:15 +0000
Subject: [Koha-bugs] [Bug 29061] max_holds rule not saving a value of
 Unlimited
In-Reply-To: <bug-29061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29061-70-cRdoCmEJkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29061

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 30794 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:41:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:41:42 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-V5I4d5ld9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Passed QA

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works (I'm taking the two SO to not have to get a 21.11 env), qa script happy,
code looks good, same as on master, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:43:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:43:36 +0000
Subject: [Koha-bugs] [Bug 26910] When calling the effective rule (allowed
 reserves), the undef is now set at 0 versus undef
In-Reply-To: <bug-26910-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26910-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26910-70-0epGcRq85a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26910

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30794

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:43:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:43:36 +0000
Subject: [Koha-bugs] [Bug 30794] 'Default checkout,
 hold and return policy' overrides Unlimited holds in 'Default
 checkout, hold policy by patron category'
In-Reply-To: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30794-70-qEpVn2bN0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=26910

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:47:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:47:27 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-Hu4OgTQ4Re@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:48:40 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-E3kCmaKyOn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:50:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:50:14 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-t5zbCPsYcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:51:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:51:12 +0000
Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing
 in facet
In-Reply-To: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27136-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27136-70-lKpsRsplVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:51:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:51:35 +0000
Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the
 calendar and possibility to renew on-site loans
In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24101-70-fzuM3xM5r2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
At the moment these patches don't apply:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 24101: Enable renewals for on-site checkouts
error: sha1 information is lacking or useless (C4/Circulation.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 24101: Enable renewals for on-site checkouts
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-24101-Enable-renewals-for-on-site-checkouts-OjwApl.patch

Lari, do you plan to continue here or should we switch to NEW?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:52:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:52:53 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-VpjVBIb63S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:53:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:53:40 +0000
Subject: [Koha-bugs] [Bug 31166] Digest option is not selectable for phone
 when PhoneNotification is enabled
In-Reply-To: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31166-70-xXlqg0E68u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31166

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:54:40 +0000
Subject: [Koha-bugs] [Bug 24865] Customize the accountlines description
In-Reply-To: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24865-70-RuNxUXDT90@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_22_11_candidate         |release-notes-needed
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 20:58:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 18:58:43 +0000
Subject: [Koha-bugs] [Bug 30653] "Check out" search with one result does not
 redirect to checkout
In-Reply-To: <bug-30653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30653-70-yg9PZU1D38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30653

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #1)
> Looks ok for me on master. Are you able to confirm that?

I can confirm it works ok on master, couldn't test in 21.11 yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 21:37:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 19:37:30 +0000
Subject: [Koha-bugs] [Bug 30670] [DOCS] Sentence case for headings -
 searching chapter
In-Reply-To: <bug-30670-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30670-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30670-70-9RQbfRYqUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30670

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
           Assignee|david at davidnind.com         |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created a merge request:
https://gitlab.com/koha-community/koha-manual/-/merge_requests/574

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 21:46:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 19:46:03 +0000
Subject: [Koha-bugs] [Bug 30900] "Error searching for analytic records"
In-Reply-To: <bug-30900-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30900-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30900-70-VPzibNlPxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30900

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 31106 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 21:46:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 19:46:03 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-lamDRKR4El@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 30900 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 21:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 19:48:43 +0000
Subject: [Koha-bugs] [Bug 30827] Autobarcode discards leading zero
In-Reply-To: <bug-30827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30827-70-LkNzM3L83m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30827

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 27426 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 21:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 19:48:43 +0000
Subject: [Koha-bugs] [Bug 27426] Plugin barcode must keep leading zeros
In-Reply-To: <bug-27426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27426-70-doZUCIhZZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 30827 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 22:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 20:41:19 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-ubBAPj11lA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

--- Comment #48 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> try using the staging repo, it has updated packages

Does that mean the problem is solved? Then when can backport, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 16 22:46:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 20:46:32 +0000
Subject: [Koha-bugs] [Bug 26300] Error in ISBD view in OPAC
In-Reply-To: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26300-70-StibveWvqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26300

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could you post the contents of your OpacHiddenItems system preference?
And can you please check if the error goes away if you empty it for a quick
test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 00:06:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 22:06:58 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-4240uDpRtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135436|0                           |1
        is obsolete|                            |

--- Comment #3 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137797&action=edit
Bug 29955: Move populate_order_with_prices to Koha namespace

and split the subroutine into 2 smaller subroutines (one for ordering,
the other for receiving)

Test plan:
1. Create a vendor and an acquisition basket
2. In this basket, create new orders using all the different methods
   (from an existing record, from a suggestion, from a new record, ...)
   then close the basket and receive these orders.
   Make sure it works the same with and without the patch
3. Run tests in t/Prices.t,
   t/db_dependent/Acquisition/populate_order_with_prices.t, and
   t/db_dependent/Budgets.t

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 00:07:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Jul 2022 22:07:16 +0000
Subject: [Koha-bugs] [Bug 29955] Move
 C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order
In-Reply-To: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29955-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29955-70-eLqcbvce4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 02:14:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 00:14:00 +0000
Subject: [Koha-bugs] [Bug 26300] Error in ISBD view in OPAC
In-Reply-To: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26300-70-yFUbAq4dDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26300

--- Comment #11 from Charles Kelley <cmkelleymls at gmail.com> ---
On our end the bug is exterminated.

What caused the bug in the first place was that we used the wrong header in the
OPACHiddenItems. Originally, we entered

lost: [1, 2, 3, 4, 5, 9, 21, 22, 31, 32, 98, 99]

Through other correspondence, we learned that the SQL column names were
supposed to be used instead. So we got a copy of the column names from the
Koha-community website and corrected the above bad entry to

itemlost: [1, 2, 3, 4, 5, 9, 21, 22, 31, 32, 98, 99]

The problem vanished. We got "lost" from what appears in some of the
documentation, from a bit of intuition, and a bit of illogic.

In summary, as long as the SQL column name is used, there isn't a problem. I
suggest the documentation be amended to include such cautionary advice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 10:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 08:52:15 +0000
Subject: [Koha-bugs] [Bug 26300] Error in ISBD view in OPAC
In-Reply-To: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26300-70-NEB3fsnN7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26300

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|In Discussion               |RESOLVED

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Charles, thanks for sharing your solution. I believe Humberto's problem is
very similar:

The column in the items table is named itype, not itemtype.

See: https://schema.koha-community.org/master/tables/items.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 11:04:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 09:04:34 +0000
Subject: [Koha-bugs] [Bug 31170] New: Capitalization: Overdue Item Fine
 Description
Message-ID: <bug-31170-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31170

            Bug ID: 31170
           Summary: Capitalization: Overdue Item Fine Description
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: trivial
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Overdue Item Fine Description

The string is in the sample notices:
installer/data/mysql/en/mandatory/sample_notices.yml:letter:1:row:64

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 11:08:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 09:08:06 +0000
Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
In-Reply-To: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28707-70-xiMbgUKav6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 11:08:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 09:08:10 +0000
Subject: [Koha-bugs] [Bug 28707] Translate RECEIPT notice (fr-CA)
In-Reply-To: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28707-70-j8eYrPl7kH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28707

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134768|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137798&action=edit
Bug 28707: Translate RECEIPT notice

There is a badly crafted regex used when extracting
strings in multiline fields in yaml files
The regex is my own, introduced in Bug 24262, sorry.

This patch correct it a little. Better eyes are welcome.

To test:
1) go to misc translator, update some language
    ./translate update fr-CA

2) check missing strings

    egrep "Total out|Operator ID|August 31" po/fr-CA-installer.po

   first two are from sample notices, third from sample creator data

3) apply the patch, repeat 1)

4) repeat 2), verify the strings are present in the translation file

5) translate some of the new strings, install the language,
   verify strings are present in the translated files
    ./translate install fr-CA
   check fr-CA/optional/sample_creator_data.yml and
   fr-CA/mandatory/sample_notices.yml

There are some 60+ new strings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:21:50 +0000
Subject: [Koha-bugs] [Bug 28712] Printed slips for fees come up empty if no
 notice is defined for the user's preferred language
In-Reply-To: <bug-28712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28712-70-buXE3ksiCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28712

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|Failed QA                   |RESOLVED

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can confirm this if fixed in master. Joubu pointed out that bug 26734 fixed
it in 21.05. As 20.11 is no longer maintained, this is a WONTFIX now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:26:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:26:55 +0000
Subject: [Koha-bugs] [Bug 28329] The items callnumber will reappear when
 editing the item if originally blanked out
In-Reply-To: <bug-28329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28329-70-roG6Y8TNGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28329

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Version|20.11                       |master

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Confirmed this on current master.

I think this could not only come as a surprise, but lead to unwanted changes in
people's data. So moving from enh to a bug.

But as always... maybe someone is relying on just this behavior? Would be good
to get some more opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:29:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:29:46 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-LIE0Q9sjP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add sort1 and sort2 to      |Add sort1 and sort2 to
                   |Patron Card Creator -       |patron card creator patron
                   |Patron Search               |search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:32:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:32:22 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-qZMTTBsoql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Michaeal, could you please rebase against the master branch?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 28726: Add sort1 and sort2 to patron card creator - patron
search.
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc).
error: could not build fake ancestor
Patch failed at 0001 Bug 28726: Add sort1 and sort2 to patron card creator -
patron search.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-28726---Add-sort1-and-sort2-to-patron-card-cre-61BF84.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:33:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:33:21 +0000
Subject: [Koha-bugs] [Bug 28795] Ability to add metadata to lists
In-Reply-To: <bug-28795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28795-70-QdU68wQxKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ability to add metadata to  |Ability to add metadata to
                   |lists                       |lists

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:35:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:35:41 +0000
Subject: [Koha-bugs] [Bug 30357] Better display of 'Edit this search'
In-Reply-To: <bug-30357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30357-70-MvLUvctuCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30357

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #4)
> Created attachment 132220 [details]
> Mockup of edit link in facets sidebar
> 
> What about this for a page with search results?

+1 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:38:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:38:04 +0000
Subject: [Koha-bugs] [Bug 30365] Use the frameworks to determine if a field
 in cataloguing shows as textarea independent of content length
In-Reply-To: <bug-30365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30365-70-fH1Sr7IvCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30365

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
            Summary|editing existing records    |Use the frameworks to
                   |that are greater than 100   |determine if a field in
                   |characters long brings up   |cataloguing shows as
                   |the textarea method of      |textarea independent of
                   |input                       |content length

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:44:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:44:00 +0000
Subject: [Koha-bugs] [Bug 29045] Public lists do not sort alphabetically as
 expected
In-Reply-To: <bug-29045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29045-70-frjaWKZZZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29045

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
            Summary|Public Lists do not sort    |Public lists do not sort
                   |alphabetically as expected  |alphabetically as expected
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tested the sorting on current master and it appears to have been fixed. I
think it was fixed by 28069!

*** This bug has been marked as a duplicate of bug 28069 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:44:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:44:00 +0000
Subject: [Koha-bugs] [Bug 28069] Can't sort lists on staff client
In-Reply-To: <bug-28069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28069-70-YGDL1XfL6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28069

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |estherm at sodaspringsid.com

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 29045 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:48:40 +0000
Subject: [Koha-bugs] [Bug 29167] Patron search exports only visible rows
In-Reply-To: <bug-29167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29167-70-y3rIai7pvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29167

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
            Summary|Patron Search - Data Export |Patron search exports only
                   |                            |visible rows

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am also not sure that this is a regression as the Export button works like
this on all tables and I don't remember another export option offered
previously.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:54:21 +0000
Subject: [Koha-bugs] [Bug 29451] Merging records and authorities - log
 details for the delete action so it could be recreated
In-Reply-To: <bug-29451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29451-70-EF75jmtJJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29451

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:54:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:54:21 +0000
Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22794-70-cBp06NK2qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29451


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29451
[Bug 29451] Merging records and authorities - log details for the delete action
so it could be recreated
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:55:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:55:48 +0000
Subject: [Koha-bugs] [Bug 29450] Allow flatPickr to instantiate in any order
In-Reply-To: <bug-29450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29450-70-bos5XZ2apT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29450

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Martin, could you please add a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 12:59:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 10:59:13 +0000
Subject: [Koha-bugs] [Bug 21572] Allow checkout an item with pending hold
 that is not yet in waiting state
In-Reply-To: <bug-21572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21572-70-uzcxNxR0Jf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21572

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow checkout an item with |Allow checkout an item with
                   |reserve that is not yet in  |pending hold that is not
                   |waiting state               |yet in waiting state

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:03:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:03:13 +0000
Subject: [Koha-bugs] [Bug 28925] OPAC checkout history is not accessing the
 set language
In-Reply-To: <bug-28925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28925-70-hS3b6KcX0a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28925

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could it be clashing with the user's language preference? We had that happen in
other spots too as the field in the patron table is also called lang.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:16:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:16:39 +0000
Subject: [Koha-bugs] [Bug 29423] Link of opac-detail.pl use biblioitemnumber
In-Reply-To: <bug-29423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29423-70-i8dO5FVZQq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29423

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|link of opac-detail.pl use  |Link of opac-detail.pl use
                   |biblioitemnumber            |biblioitemnumber
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's not easy to check if this has since been fixed, as there is not much
information about the broken links. I couldn't find any references to
biblioitemnumber in neither opac-detail.pl or opac-detail.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:23:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:23:23 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-1kQvN4dNeW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7882
           Severity|minor                       |normal

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can replicate the issue. 

To test:
- Edit subfields of any field
- Mark the last subfield in the row as mandatory
- Save
- Edit again and verify the field shows as mandatory
- Move the field to the first position and save
- Verify the original field is no longer mandatory, but the last subfield is
now

Updating severity as this is a data issue.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882
[Bug 7882] Add ability to move and reorder fields and subfields in MARC editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:23:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:23:23 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields and
 subfields in MARC editor
In-Reply-To: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-adK1u3jecP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001
[Bug 29001] Subfields attributes are not preserved when order is changed in
framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:25:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:25:46 +0000
Subject: [Koha-bugs] [Bug 29044] Check for untriggered holds when checking
 out
In-Reply-To: <bug-29044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29044-70-pz1OkcBVXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Check holds when checking   |Check for untriggered holds
                   |out                         |when checking out
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:28:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:28:12 +0000
Subject: [Koha-bugs] [Bug 31015] Remove option to clear pickup location
 selects on multi-holds page
In-Reply-To: <bug-31015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31015-70-RBCndSJaXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31015

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The x is part of the select2 pull downs, not sure if it can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:30:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:30:43 +0000
Subject: [Koha-bugs] [Bug 31011] Make hold reminders respect patron's
 language
In-Reply-To: <bug-31011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31011-70-ZtzLdsOHCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:34:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:34:27 +0000
Subject: [Koha-bugs] [Bug 31011] Make hold reminders respect patron's
 language
In-Reply-To: <bug-31011-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31011-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31011-70-SSWDJcbT03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31011

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15986
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28797

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid. There is also another bug that could possibly be fixed at the same
time: 

Bug 28797 - Hold reminder email should use All Libraries notice


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
[Bug 15986] Add a script for sending hold waiting reminder notices
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:34:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:34:27 +0000
Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting
 reminder notices
In-Reply-To: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15986-70-nt1Iz8lWYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31011


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31011
[Bug 31011] Make hold reminders respect patron's language
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:34:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:34:27 +0000
Subject: [Koha-bugs] [Bug 28797] Hold reminder email should use All
 Libraries notice
In-Reply-To: <bug-28797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28797-70-c7qWKnux87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31011

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:38:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:38:42 +0000
Subject: [Koha-bugs] [Bug 29190] Allow access to cached news pages by code
 and lang from OPAC start page
In-Reply-To: <bug-29190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29190-70-HWWsIjUYZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow cached news pages by  |Allow access to cached news
                   |code from opac-main         |pages by code and lang from
                   |                            |OPAC start page

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:43:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:43:41 +0000
Subject: [Koha-bugs] [Bug 29085] Add an alert when deleting a vendor linked
 to a subscription
In-Reply-To: <bug-29085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29085-70-k5Zoo5II93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29085

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.05                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is still valid on master. 

I think we should have a warning/confirmation message at least.

If the vendor is deleted, the aqbooksellerid column in subscription should be
set to NULL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 13:46:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 11:46:49 +0000
Subject: [Koha-bugs] [Bug 29090] Patron card creator has a bug when
 generating batches
In-Reply-To: <bug-29090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29090-70-krKtQhBIwN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29090

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is not enough information here to reproduce the bug and it was reported
against a rather old version. I am closing invalid for now, please reopen with
more information if you still experience this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 14:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 12:04:55 +0000
Subject: [Koha-bugs] [Bug 29655] Email sender name setting
In-Reply-To: <bug-29655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29655-70-BCK3wFYGqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29655

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 15349 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 14:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 12:04:55 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-B7JNbRCA6b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |resetka.bedi at gmail.com

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 29655 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 14:06:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 12:06:45 +0000
Subject: [Koha-bugs] [Bug 30787] Holds to pull list does not show available
 item when item has had wrong transfer
In-Reply-To: <bug-30787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30787-70-Xq7knX5hIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Holds to pull -list does    |Holds to pull list does not
                   |not show available item     |show available item when
                   |when item has had Wrong     |item has had wrong transfer
                   |transfer                    |

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Minna, could you add a test plan on how to reproduce this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 18:06:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 16:06:19 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-mYTNTBT4fR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #7 from Emily W <emily.warwas at cedarparktexas.gov> ---
(In reply to Katrin Fischer from comment #5)
> (In reply to Emily W from comment #4)
> > Recently began having this issue. Digests will be checked when creating the
> > guarantee but will uncheck once saved. Takes up staff time adding an
> > additional step to sign up process.
> 
> Hi Emily, I think this is a slightly different bug 30175 that was fixed in
> 22.05. I have also asked the RMaint to check for backporting. Which version
> did you test with?

We currently have 21.05 but will be updating to 21.11 on 7/27/22. Do you think
the fix will come with that upgrade?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 18:07:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 16:07:33 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-P2JsXv7jGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #8 from Emily W <emily.warwas at cedarparktexas.gov> ---
(In reply to Nick Clemens from comment #6)
> One thing to note here, if the messaging preferences are left blank, then
> they are filled from the category on save
> 
> To test:
> 1 - In KTD set 'Juvenile' category to have some messaging preferences
> 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
> 3 - In new form preferences are blank - fill out other fields and save
> 4 - Save patron
> 5 - Note messaging preferences match category defaults

We've noticed that, but most of the juvenile cards we make we need to change
the patron category, which auto fills everything in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 23:42:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 21:42:36 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-HvdzdKPpke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134928|0                           |1
        is obsolete|                            |

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 137799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137799&action=edit
Bug 30039: Add published on column to claims.pl

To test:
1. Have a vendor setup
2. Go to serials and add a new serial w/ that vendor.
3. When creating a serial make this first issues sometime in the past.
4. Go to Claims, choose your vendor and load the table.
5. No published on column.
6. Apply patch
7. Try step 4 again and now you should see a published on column.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 23:43:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 21:43:04 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-ge6txsBLnL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 17 23:47:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 21:47:29 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-UnwaWIpHgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
How does on populate the "published on" column? To check that it's indeed
displayed and that search works.

Otherwise it looks good for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 00:06:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 22:06:42 +0000
Subject: [Koha-bugs] [Bug 31171] New: Remember user-selected sort in a given
 session for Purchase Suggestions
Message-ID: <bug-31171-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31171

            Bug ID: 31171
           Summary: Remember user-selected sort in a given session for
                    Purchase Suggestions
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: margaret at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Would it be possible to filter by manager or collection or any other sort
column, and have Koha remember the settings between actions? It's annoying and
slows down work to have to re-sort the list after each action to try to find
next title in your list after you do something.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 01:35:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 23:35:37 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-k3x4HlQBAi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
I was just thinking about the native input type "email" but it looks like it
doesn't accept "Library X <library at ...>" either. 

Would we really want to support "Library X <library at ...>" in all contexts or
just system preferences and branch emails?

If we supported it for users, it could stop SSO from working.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 01:55:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 23:55:11 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-0ae4wuTbOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
I suppose it depends on how pedantic we want to be. 

But I think Marcel has a good point. It probably makes more sense to use
"/usr/sbin" than "/usr/share/koha/bin" since that's where the other koha-*
shell code is. 

Even if someone did run "koha-functions.sh" via $PATH, it wouldn't actually do
anything. 

(Alternatively, we could always have a "/usr/share/koha/bin/scripts" and
symlink the /usr/sbin/koha-* stuff to the code in that location. Plus
potentially update koha-gitify to symlink /usr/sbin/koha-* stuff as well - at
least on Debian/Ubuntu. )

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 01:58:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 23:58:30 +0000
Subject: [Koha-bugs] [Bug 31148] Add link to MARC import tools from
 Cataloging
In-Reply-To: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31148-70-bliamkljPD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31148

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #4)
> See bug 31162 for an initial attempt at adding a cataloguing homepage :).
> 
> I decided to do it on its own bug so we can track the idea of a cataloguing
> sidebar and cataloguing homepage as distinct features.. and as my homepage
> design adds more than just the marc import tools.

\0/

Sounds great to me

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 01:59:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Jul 2022 23:59:14 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-C6ViTUOEGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 02:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 00:09:28 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-Sp8JbUetQO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
This has been on my mind for a while. 

I think that we need a database column to store the 942$n data to make it easy
to query via SQL.

OpacHiddenItems will still be an issue but that can be a separate issue...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 02:18:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 00:18:03 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-EF1AOCGalc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #18)
> Nice one David and David!..
> 
> It's great to see Zebra having a little love still..

I'll keep showing it the love until all my libraries jump ship to
Elasticsearch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 08:54:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 06:54:29 +0000
Subject: [Koha-bugs] [Bug 31101] Allow other separation options for
 digesting circulation alerts (checkin, checkout, renewal)
In-Reply-To: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31101-70-Y8KHfLVL7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31101

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #1)
> What do you mean by ovedue digest flag?

The digests only box on Messaging preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 09:02:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 07:02:46 +0000
Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
 modules for Koha
In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30444-70-LKahoyp1oj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
This is interesting. I'll need to review the shibboleth code here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 09:10:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 07:10:13 +0000
Subject: [Koha-bugs] [Bug 28746] Add OPAC equivalent for
 RestrictionBlockRenewing system preference
In-Reply-To: <bug-28746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28746-70-HDXzy0xlAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28746

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 09:30:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 07:30:17 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-yJ1cmHexNN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 09:32:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 07:32:28 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-34lQMEcygv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add the option to require   |Add the option to require
                   |2FA setup on first login    |2FA setup on first staff
                   |                            |login

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:04:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:04:19 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-t7aKe1355O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137786|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137800&action=edit
Bug 20439: Sort SMS providers in alphabetical order by DB field

To test:
1/ Add 'Email' to the 'SMSSendDriver' system preference.
2/ Make sure 'EnhancedMessagingPreferencesOPAC' and
'EnhancedMessagingPreferences' are turned on.
3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different
names.
4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by
when they were added, not alphabetically.
5/ Apply patch and restart services.
6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS
providers now sort alphabetically.

Signed-off-by: George Williams <george at nekls.org
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:04:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:04:42 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-CCBhYf6tdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great work, works as expected

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:04:48 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-937QesDISs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:04:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:04:53 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-TyfLBev0LZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:49:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:49:56 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-FFeOjlJQvF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We only had the request for library email addresses so far, I think that's the
main use case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 11:53:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 09:53:26 +0000
Subject: [Koha-bugs] [Bug 31101] Allow other separation options for
 digesting circulation alerts (checkin, checkout, renewal)
In-Reply-To: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31101-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31101-70-fnh6evAvjw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31101

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the 'overdue' confused me, as we don't have the overdues in messaging
preferences. Overdues are digested by branch/overdue level or you can include
all overdue items with a flag.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 12:08:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 10:08:26 +0000
Subject: [Koha-bugs] [Bug 26533] Searching authorities using 'is exactly'
 doesn't work as expected
In-Reply-To: <bug-26533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26533-70-BCICiZjYsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Victor Grousset/tuxayo from comment #19)
> Hi, I just tried the test plan to see if bug 28475 broke this.
> 
> I'm failing step 4) even though I'm on master :o
> 
> On sample data I'm searching "AGENTES INTERESADOS" with "is exactly" in the
> main heading and I get two results.
> When I'm searching "INTERESADOS" which "is exactly" in the main heading and
> I don't get a result.
> (main heading: default)
> 
> Is there something missing?

You should not get a result with INTERESADOS, as that's not the full heading.
Exact means full heading, no more words before or after. (exact field content)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 12:55:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 10:55:14 +0000
Subject: [Koha-bugs] [Bug 31172] New: Shouldn't issues.issuedate have a
 DEFAULT NOW() and be NOT NULL?
Message-ID: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31172

            Bug ID: 31172
           Summary: Shouldn't issues.issuedate have a DEFAULT NOW() and be
                    NOT NULL?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We are currently defaulting to dt_from_string in code, we could just set `NOT
NULL DEFAULT NOW()` to get a more consistent behaviour couldn't we?

I see this as a good starting place for moving C4::Circulation::AddIssue to
Koha::Checkouts->store() eventually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 12:55:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 10:55:40 +0000
Subject: [Koha-bugs] [Bug 31172] Shouldn't issues.issuedate have a DEFAULT
 NOW() and be NOT NULL?
In-Reply-To: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31172-70-Bwt12mqGPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31172

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 13:34:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 11:34:10 +0000
Subject: [Koha-bugs] [Bug 31173] New: display copy number in checkout list
Message-ID: <bug-31173-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31173

            Bug ID: 31173
           Summary: display copy number in checkout list
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The checkout list in OPAC (opac-user.pl) should display the value of
item.copynumber, in the Title column (like the value of item.enumchron) or in a
specific column.

Maybe this information is not useful for some libraries, but I suppose it is
for most.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 13:54:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 11:54:09 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-kVL2raOpK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 13:54:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 11:54:13 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-xMU2fMuyxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137801&action=edit
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 13:54:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 11:54:55 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-GVSlQnptIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:11:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:11:00 +0000
Subject: [Koha-bugs] [Bug 31174] New: Display fund on acquisition details
 tab in catalogue/detail.pl
Message-ID: <bug-31174-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31174

            Bug ID: 31174
           Summary: Display fund on acquisition details tab in
                    catalogue/detail.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In detail.pl the "Acquisition details"  tab under the record don't display the
fund. It could be useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:45:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:45:10 +0000
Subject: [Koha-bugs] [Bug 7960] Choice to not show the text labels for item
 types
In-Reply-To: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7960-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7960-70-KNqLIFSQr0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:46:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:46:39 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-J3PK1XPF9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:46:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:46:42 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-d5zonP4fhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117744|0                           |1
        is obsolete|                            |

--- Comment #3 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Created attachment 137802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137802&action=edit
Bug 27849: Koha::Token may access undefined C4::Context->userenv

The _add_default_csrf_params internal function accesses
C4::Context->userenv without checking that it has been defined. I think
not all of the potential callers of it declare that they require a
defined userenv, so we should test and provide defaults for required
values if it is not defined, to avoid some "Can't use an undefined value
as a HASH reference" HTTP 500 Internal Server Errors.

To test:

Do anything that requires a form with CSRF token, such as editing your
details. Behaviour should be unchanged. To test the failure case, you
would need some customised code that indirectly generates a CSRF token
before setting the userenv up and I am not sure there is any in released
Koha yet.

Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de>

Looks good to me. Working as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:48:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:48:39 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-i48iWfdlkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #21 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to David Nind from comment #20)
> I tested (after making the change in comment #19) using koha-testing-docker.
> 
I finally manage to set up a koha-testing-docker myself. 

> Test plan:

> 
> [1] After importing the authorities, I got an error and had to reindex:
>     
>     misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc
> -insert -c=MARC21
>     Characteristic MARC flavour: MARC21
>     .One or more ElasticSearch errors occurred when indexing documents at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.
>     .One or more ElasticSearch errors occurred when indexing documents at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.
>     .One or more ElasticSearch errors occurred when indexing documents at
> /kohadevbox/koha/Koha/SearchEngine/Elasticsearch/Indexer.pm line 148.
I didn't got this error. Loading of authority record and bibliographic record
worked fine for me.

> 
> [2] After applying the patch I edited mappings.yaml to remove the nomarc
> entry that was added so the resetting the mappings worked
>     vi admin/searchengine/elasticsearch/mappings.yaml -  remove lines
> 750-754 added by the mapping patch
Yes, normarc should be removed. 

> 
> [3] Not all links to feminism are linked to authority records. Links for
> subject terms for step 9 in order are:
> 
>     Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria |
> Litteratur
> 
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"
>     http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"
> 
>     MARC info:
> 
>     650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element Feminism
>       0 Authority record control number or standard number
> https://id.kb.se/term/sao/Feminism
>       2 Source of heading or term sao
>     650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element feminism
>       2 Source of heading or term bnb
>     650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element Feminism
>     650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element Feminism
>     650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element Idéhistoria
>     650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
>       a Topical term or geographic name entry element Litteratur

This is actually correct, because the fourth Feminism term has second indicator
4 which means "Source not specified". So this term is only a local term and
does not belonging to any specific thesaurus and thus not linked. To specify a
source of a term, second indicator must be 7. The source of heading is then
specified in subfield 2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 14:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 12:54:44 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-mn5mPfyYfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #6)
> Can this be updated from New to Needs Signoff? :)

I haven't tested them, but feel free to do so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:00:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-SQH2CBSYh6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #115 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
How hard would it be to implement a expand/collapse feature to display a
minimal/full header? I think it would fit everybody's needs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:06:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:06:47 +0000
Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in
 preference to using the REST API's
In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30578-70-FVdpraJzqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |25498


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
[Bug 25498] Allow to change owner of public or shared list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:06:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:06:47 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-Qladhdqmnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30578


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
[Bug 30578] We should drop circ/ysearch.pl in preference to using the REST
API's
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:21:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:21:59 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-t62EnBqA39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #10 from Emily W <emily.warwas at cedarparktexas.gov> ---
(In reply to Nick Clemens from comment #9)
> Created attachment 137801 [details] [review]
> Bug 7660: Use first available categorycode when none passed in
> 
> The code that populates the patron messaging preferences on initial form load
> expects to have a category selected. Currently we only have one if one was
> passed to the form. When creating an account from a parent, we don't have a
> category explicitly selected - so we can just select the first of the
> possible
> categories
> 
> To test:
>  1 - In KTD set 'Juvenile' category to have some messaging preferences
>  2 - Find a patron, say Edna Acosta, and 'Add guarantee'
>  3 - In new form preferences are blank, cancel
>  4 - Apply patch, restart all
>  5 - Go to Edna, click 'Add guarantee'
>  6 - Preferences are populated!
>  7 - Cancel
>  8 - Go to 'Patrons' module
>  9 - Click "+ New patron"
> 10 - Confirm messaging preferences load correctly when not adding child

Yes, everything works fine when we aren't creating using "add guarantee." All
the categories have their default notification preferences correct in our
settings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:13 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-SPK9BGcgvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:17 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-jZVXMYFyG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137803&action=edit
Bug 30718: Fix today's date on overdue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:21 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-WYtvXM8E4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137804&action=edit
Bug 30718: Fix serials/showpredictionpattern.pl

Can't locate object method "ymd" via package "2022-02-01" (perhaps you forgot
to load "2022-02-01"?) at /kohadevbox/koha/serials/showpredictionpattern.pl
line 100
eval {...} at /kohadevbox/koha/serials/showpredictionpattern.pl line 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:26 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-pAA8ackDY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137805&action=edit
Bug 30718: Add missing USE KohaDates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:30 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-RvHHr6UGZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137806&action=edit
Bug 30718: Fix holidays

Template process failed: undef error - The given date (07/18/2022) does not
match the date format (iso)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:28:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:28:34 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-nlIVOKVPPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137807&action=edit
Bug 30718: Fix scheduler

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:30:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:30:31 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-h9WvtmYHRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Owen Leonard from comment #14)

Thanks a lot, Owen, you are awesome! :)

> More notes after having gone through almost everything and tested the basics:
> 
> - lateorders.pl:
>    Can't locate object method "ymd" via package "2010-07-02" (perhaps you
> forgot to load "2010-07-02"?) at /usr/share/perl5/DateTime/Format/MySQL.pm
> line 100
> 
> - circulation.pl
>   Template process failed: undef error - The given date (01.06.2022 11:59
> PM) does not match the date format (iso) at
> /kohadevbox/koha/Koha/DateUtils.pm line 205.
>  at /kohadevbox/koha/C4/Templates.pm line 127
> 
> The above error occurred when checking out and specifying a date in the past.
> 
> - overdues.pl The date in the heading is formatted incorrectly: "1 Item
> overdue as of 2022-07-14T13:53:00"
> 
> - serials/claims.pl: "Template process failed: undef error - : filter not
> found at /kohadevbox/koha/C4/Templates.pm line 127"
> 
> - tools/holidays.pl "Template process failed: undef error - : filter not
> found at /kohadevbox/koha/C4/Templates.pm line 127"

All fixed!

> I noticed this in the log for export.pl after testing a date-limited export.
> The export completed fine as far as I can tell.
> 
> [Thu Jul 14 15:46:05.900437 2022] [cgi:error] [pid 83824] [client
> 172.18.0.1:62854] AH01215: DBIx::Class::Storage::DBI::_gen_sql_bind():
> DateTime objects passed to search() are not supported properly
> (InflateColumn::DateTime formats and settings are not respected.) See "..
> format a DateTime object for searching?" in DBIx::Class::Manual::FAQ. To
> disable this warning for good set $ENV{DBIC_DT_SEARCH_OK} to true at
> /kohadevbox/koha/Koha/Objects.pm line 312: /kohadevbox/koha/tools/export.pl,
> referer: http://127.0.0.1:8081/cgi-bin/koha/tools/export.pl

Also in master, should be fixed (but reported separately).

> - Tasks scheduler: "Failed to add Tasks"
> 
> I didn't see anything in the error log that appeared to be related to this.

Fixed (note that time part is mandatory but the UI does not ask for it).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:07 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-wvirfljjXh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:10 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-e8uAPlMPIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:14 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-oDIWH8EZeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:17 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-YUfGOc30xA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:20 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-RHUf7hRAlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:23 +0000
Subject: [Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a
 patron can hold the given item
In-Reply-To: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29094-70-uBgUJAFGst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:25 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-0GTd0KxsoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:28 +0000
Subject: [Koha-bugs] [Bug 31036] Cash management doesn't take SIP00 (Cash
 via SIP2) transactions into account
In-Reply-To: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31036-70-yUPFvsmPQd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31036

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:30 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-pcNm8vFtxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:33 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-DZU5F4dIEH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:35 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-j8gcWLaade@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:39 +0000
Subject: [Koha-bugs] [Bug 31129] Number of restrictions is always "0" on the
 "Check out" tab
In-Reply-To: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31129-70-a4bdKstc0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:41 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-qsUhTYi0IV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:44 +0000
Subject: [Koha-bugs] [Bug 31134] t/Ediorder.t tests failing on 22.05.02
In-Reply-To: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31134-70-sG2pcocA0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31134

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:47 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-BUq5EGo0Kk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:49 +0000
Subject: [Koha-bugs] [Bug 31137] Error editing label template
In-Reply-To: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31137-70-TOzdYNW4uF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31137

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:52 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-TQmK3bCX5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:56 +0000
Subject: [Koha-bugs] [Bug 31146] Minor UI problem in recalls history in OPAC
In-Reply-To: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31146-70-t3yMFwe1I0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31146

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:31:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:31:57 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-V5oaiQAsGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:02 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-1l1PVTI83u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137036|0                           |1
        is obsolete|                            |
 Attachment #137186|0                           |1
        is obsolete|                            |
 Attachment #137187|0                           |1
        is obsolete|                            |
 Attachment #137188|0                           |1
        is obsolete|                            |
 Attachment #137189|0                           |1
        is obsolete|                            |
 Attachment #137190|0                           |1
        is obsolete|                            |
 Attachment #137191|0                           |1
        is obsolete|                            |
 Attachment #137192|0                           |1
        is obsolete|                            |
 Attachment #137193|0                           |1
        is obsolete|                            |
 Attachment #137194|0                           |1
        is obsolete|                            |
 Attachment #137195|0                           |1
        is obsolete|                            |

--- Comment #34 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137808&action=edit
Bug 17170: DB Updates

This patch adds the new table, permission, and a syspref to enable the feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:06 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-eRbaWRDORa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #35 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137809&action=edit
Bug 17170: DO NOT PUSH - Schema Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:10 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-UDli6lDB0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #36 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137810&action=edit
Bug 17170: Update schema for boolean

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:14 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-J4qfStBE3s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #37 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137811&action=edit
Bug 17170: Add API route for SearchFilters

This adds the API routes and tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:18 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-99nzIMSMdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137812&action=edit
Bug 17170: Add search filters to staff and opac interfaces

This patch displays the filters on the results pages with the facets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:22 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-UlF76noT7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137813&action=edit
Bug 17170: Handle search filters in query builders

This patch updates the query building code to expand filters when searching
and pass them back as part of the cgi and descriptive search strings

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:27 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-0Y6VavcvSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137814&action=edit
Bug 17170: Add admin page for filters and ability to edit/save existing filters

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the resuilts page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:31 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-0M0qslfEHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137815&action=edit
Bug 17170: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:35 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-AN1Kpfj5WQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137816&action=edit
Bug 17170: (follow-up) Display search filters admin links when apprropriate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:32:39 +0000
Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches'
 for use as filters when searching the catalog
In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17170-70-rgFEvM8c5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137817&action=edit
Bug 17170: Add the ability to create 'saved searches' for use as filters when
searching the catalog

This patch alters the code in the ES QueryBuilder. Reflecting
how things are handled in build_query_compat we clean the query,
but not the limits. In Zebra we simply recursivly call buildQuery,
but the ES query structure

This patchset adds a new ability to save searches on the staff client, and
display them in the results
page on staff or opac as a new filter.

New filters can be added from the results page after a search, and there is an
admin page for updating
deleting and renaming filters

There is a new permission to control management of these filters

New filters can be added that are not displayed along with facets, this allows
for building custom links
using these filters to keep URLs shorter

Due to bug 30528 testing in ES is recommended

To test:
 1 - Apply patches and update database and restart all
 2 - Enable new system preference 'SavedSearchFilters'
 3 - As superlibrarian perform a search in staff client, something broad like
'a'
 4 - Note new 'Save search as filter' link on results page
 5 - Click it, save search as new filter, check 'Staff client' visibility
 6 - Perform another search
 7 - Note the filter now appears above facets
 8 - Click to it filter results
 9 - Note results are limited by the new filter, and it is checked in the
facets
10 - Confirm click the [x] removes the filter
11 - Go to administration->search filters
12 - Confirm the filter appears
13 - Edit and mark as OPAC visible
14 - Test OPAC to ensure it shows and can be applied/removed
15 - Copy URL with filter applied
16 - In adminsitration mark filter as not visible on staff or opac
17 - Confirm link above still works
18 - Create a new staff with catalogue and search filters permission
19 - Ensure they can access/save filters
20 - Remove filter permission and ensure they cannot
21 - Disable system preference
22 - Confirm links to search filters page are removed from admin home and admin
sidebar
23 - Confirm filters do not appear on results and cannot be created
24 - Enable pref
25 - Create a filter
26 - From search filters page, click 'Edit search'
27 - Confirm you are taken to advanced search page letting you know which
filter you are editing
28 - Confirm you can change searhc options and save
29 - Confirm you can perform the search from this page

Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:36:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:36:09 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-3NfNGwSvBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Hi Emily,

That attachment was a patch to attempt to fix the problem and a supplied test
plan. Did you apply the patch, or were just confirming current state of the
bug?

-Nick

(In reply to Emily W from comment #10)
> (In reply to Nick Clemens from comment #9)
> > Created attachment 137801 [details] [review] [review]
> > Bug 7660: Use first available categorycode when none passed in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:36:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:36:43 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-hRNw6iiTCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Follow-ups can be squashed of course

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:38:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:38:36 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-DfFMsbkl5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #12 from Emily W <emily.warwas at cedarparktexas.gov> ---
(In reply to Nick Clemens from comment #11)
> Hi Emily,
> 
> That attachment was a patch to attempt to fix the problem and a supplied
> test plan. Did you apply the patch, or were just confirming current state of
> the bug?
> 
> -Nick
> 
> (In reply to Emily W from comment #10)
> > (In reply to Nick Clemens from comment #9)
> > > Created attachment 137801 [details] [review] [review] [review]
> > > Bug 7660: Use first available categorycode when none passed in

Confirming the state, I will try the patch later today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:39:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:39:17 +0000
Subject: [Koha-bugs] [Bug 31175] New: OPAC Logout should return you to where
 you were (unless that's a restricted page)
Message-ID: <bug-31175-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31175

            Bug ID: 31175
           Summary: OPAC Logout should return you to where you were
                    (unless that's a restricted page)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The OPAC logout appears to always take you back to opac-main.

To test
1) Perform a search
2) Go to the details of a search results
3) Logout
4) Note, you are no longer on the defail page for the record you had searched
for.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:39:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:39:25 +0000
Subject: [Koha-bugs] [Bug 31175] OPAC Logout should return you to where you
 were (unless that's a restricted page)
In-Reply-To: <bug-31175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31175-70-XpWzdjvtoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31175

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:55:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:55:48 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-lxC2RjF2zK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
I am not sure either, that's why I filed this :-)

I guess my question is:
Does limiting an attribute to a branch(es) imply that only patrons from that
branch should have the attribute?
or 
Does limiting an attribute to a branch(es) imply that only librarians from that
branch can see that attribute?

i.e. What is the purpose of the limit?

Once we have that, then we can verify it works correctly

Additionally - they can't be required for any patrons, or at least we don't
enforce it as we do others (delete the whole attribute node from the form and
submit - not blocked)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 15:59:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 13:59:56 +0000
Subject: [Koha-bugs] [Bug 31176] New: Move holds logic to Koha::
Message-ID: <bug-31176-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31176

            Bug ID: 31176
           Summary: Move holds logic to Koha::
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We currently use use C4::Reserves::CanBookBeReserved and
C4::Reserves::AddReserve heavily.. we should start migrating to Koha object
methods in a similar fashion to how request_transfer was implemented and added
to Koha::Item along with Koha::Item::Transfer(s) classes being added.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:00:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:00:07 +0000
Subject: [Koha-bugs] [Bug 31176] Move holds logic to Koha::
In-Reply-To: <bug-31176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31176-70-rh80024DCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31176

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:05:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:05:50 +0000
Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons
 to report concerns about catalogue records
In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31028-70-IESJcaSUSc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/mrenvoiz
                   |                            |e/Koha/-/tree/bug_31028

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:19:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:19:54 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-EVmGkFVhff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131772|0                           |1
        is obsolete|                            |

--- Comment #22 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137818&action=edit
Bug 30280: Add a new mapping authority marc field 040\$f

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:19:59 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-nVgaV39QJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131773|0                           |1
        is obsolete|                            |

--- Comment #23 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137819&action=edit
Bug 30280: Handle subject headings from differens thesaurus

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:20:05 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-Mb6gV8UPDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131774|0                           |1
        is obsolete|                            |

--- Comment #24 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137820&action=edit
Bug 30280: Removing tab character in Heading.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:26:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:26:30 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-Hic8gFob5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #25 from Frank Hansen <frank.hansen at ub.lu.se> ---
I fixed the mapping issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:47:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:47:31 +0000
Subject: [Koha-bugs] [Bug 31172] Shouldn't issues.issuedate have a DEFAULT
 NOW() and be NOT NULL?
In-Reply-To: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31172-70-uUsvH7N45H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31172

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
That seems totally reasonable to me now that we can set the database timezone
to the Koha timezone!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:52:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:52:19 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-NT7tpkAnAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Keywords|                            |additional_work_needed
             Status|Pushed to master            |ASSIGNED

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This broke tests:

t/db_dependent/SuggestionEngine_ExplodedTerms.t

Please fix ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:26 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-uEb6bG9aD3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:28 +0000
Subject: [Koha-bugs] [Bug 14680] When creating orders from a staged file
 discounts supplied in the form are added
In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14680-70-IBwqjDaqDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:31 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-z9h3uUBgHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:34 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-lQweltD7NG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:37 +0000
Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in
 preference to using the REST API's
In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30578-70-q5oFNcoQN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:39 +0000
Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in
 preference to using the REST API's
In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30578-70-YsghZ1ArV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578

--- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:42 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-KarBBIbhV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:44 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-ADUEFFIGs9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:47 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-WvxhngOAC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:50 +0000
Subject: [Koha-bugs] [Bug 31083] Part name (245$p) breaks item bundle detail
 view
In-Reply-To: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31083-70-rI80TJWrD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:53 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-f8KsVbQaGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:53:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:53:55 +0000
Subject: [Koha-bugs] [Bug 31153] Search bar not visible on recalls history
 page
In-Reply-To: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31153-70-x31X3zL2dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31153

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:58:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:58:46 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-OqDqpHfafX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137801|0                           |1
        is obsolete|                            |

--- Comment #13 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137821&action=edit
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:59:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:59:28 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-EzdrfF5V50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #14 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, signing off.

Thanks, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 16:59:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 14:59:32 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-I24H4g0EKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137787|0                           |1
        is obsolete|                            |

--- Comment #9 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137822&action=edit
Bug 6419: Add custom HTML areas to intranet home pages

This patch adds customisable HTML text areas to acqui/acqui-home.pl,
authorities/authorities-home.pl, cataloguing/addbooks.pl,
virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and
serials/serials-home.pl pages

To test:

1) Apply patch
2) Run updatedatabase.pl
3) Add some html to the new prefs IntranetAcquisitionsHomeHTML,
   IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML,
   IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML
   and IntranetSerialsHomeHTML
4) View the Acquisition, Authorities, Cataloging, Lists, Patrons,
   Point of Sale, and Serials homepages and confirm that your changes
   show. Note that this should display in exactly the same way as it
   does in the already extant IntranetCirculationHomeHTML and
   IntranetReportsHomeHTML system preferences.

Signed-off-by: Brandon J <brandon.jimenez at inLibro.com>

Signed-off-by: Daniel <daniel.jones at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:01:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:01:16 +0000
Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6419-70-yEBiAEOHpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419

Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.jones at cheshireshared
                   |                            |services.gov.uk

--- Comment #10 from Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> ---
Works as described- good enhancement.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:05:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:05:49 +0000
Subject: [Koha-bugs] [Bug 25966] Renewal of lost item generates overdue fine
In-Reply-To: <bug-25966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25966-70-puuqj8N9z1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25966

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:06:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:06:23 +0000
Subject: [Koha-bugs] [Bug 15455] Long Overdue charged item then renewed
In-Reply-To: <bug-15455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15455-70-ohf1zzIQbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15455

Chris Slone <cslone at camdencountylibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cslone at camdencountylibrary.
                   |                            |org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:10:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:10:03 +0000
Subject: [Koha-bugs] [Bug 29632] Callnumber sorting is incorrect in
 Elasticsearch
In-Reply-To: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29632-70-R1Xn7Sq8wq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29632

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137823&action=edit
Bug 29632: (QA follow-up) Add ENUM value to kohastructure.sql :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:39:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:39:02 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-GdDdNBo1ak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137824&action=edit
Bug 31069: Remove ExplodedTerms dependency on templates

This patch removes the use of templates and CGI in ExplodedTerms by using the
Koha::I18N library.

The functionality on the package is too simple, and messing with the
template paths complexity on the tests was too much, given we have a
nice way to have translatable strings at the package level.

This patch does that, and cleans up the test file as well, that required
complex template and CGI mocking to run properly.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/SuggestionEngine_ExplodedTerms.t
=> FAIL: It fails in master
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass
4. Follow the original test plan
=> SUCCESS: Things work
5. Enjoy the rest of the day and forget this ever happened

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:41:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:41:44 +0000
Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to
 linking to orders
In-Reply-To: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19358-70-SnivYCJjQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:43:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:43:01 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-hlhECvGtoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |
             Status|ASSIGNED                    |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:43:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:43:08 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-2NZC0SOMM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:43:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:43:46 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-hR8GNVM1wj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #116 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
(In reply to Jonathan Druart from comment #115)
> How hard would it be to implement a expand/collapse feature to display a
> minimal/full header? I think it would fit everybody's needs.

If the logic of not having text labels on the buttons is to make the interface
responsive, perhaps the labels could appear on desktops but switch to icons
only on smaller screen sizes?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:46:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:46:05 +0000
Subject: [Koha-bugs] [Bug 31177] New: Misplaced import in C4::ILSDI::Services
Message-ID: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177

            Bug ID: 31177
           Summary: Misplaced import in C4::ILSDI::Services
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Koha::I18N is not added where it should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:46:18 +0000
Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
In-Reply-To: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31177-70-bxdUXTJIpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |22347


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347
[Bug 22347] Translatability of ILSDI results for getavaibility
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:46:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:46:18 +0000
Subject: [Koha-bugs] [Bug 22347] Translatability of ILSDI results for
 getavaibility
In-Reply-To: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22347-70-fHrgzdzecv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22347

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31177


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177
[Bug 31177] Misplaced import in C4::ILSDI::Services
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:48:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:48:36 +0000
Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
In-Reply-To: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31177-70-s60T75uWKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:48:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:48:51 +0000
Subject: [Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
In-Reply-To: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31177-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31177-70-6aOYo271LD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137825&action=edit
Bug 31177: Fix misplaced import in C4::ILSDI::Services

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:51:15 +0000
Subject: [Koha-bugs] [Bug 31178] New: ExplodedTerms produces unquoted
 searches
Message-ID: <bug-31178-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31178

            Bug ID: 31178
           Summary: ExplodedTerms produces unquoted searches
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:51:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:51:23 +0000
Subject: [Koha-bugs] [Bug 31178] ExplodedTerms produces unquoted searches
In-Reply-To: <bug-31178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31178-70-c3Lvt5rAGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31178

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31106

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:51:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:51:23 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-5XU4g3YNSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31178

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:56:06 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-WfznrehWSr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28553

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 17:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 15:56:06 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-zqXgmbAHqR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30355

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:03:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:03:17 +0000
Subject: [Koha-bugs] [Bug 31178] ExplodedTerms produces unquoted searches
In-Reply-To: <bug-31178-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31178-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31178-70-tNat4YEVMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31178

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The built query comes from the templates/XSLT, so the assertion is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:09:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:09:25 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-hiOw0XKOOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
> > - circulation.pl
> >   Template process failed: undef error - The given date (01.06.2022 11:59
> > PM) does not match the date format (iso) at
> >
> > The above error occurred when checking out and specifying a date in the past.

I'm still getting this error when manually selecting a due date in the past.

I now notice that the time portion of the datetime is not appearing in the
input field. The same is true on the checkin and offline circulation page.

> > - tools/holidays.pl

There's now a little calendar icon showing above the calendar on this page.

> > - Tasks scheduler: "Failed to add Tasks"
> Fixed (note that time part is mandatory but the UI does not ask for it).

Would it make sense to update the form in this patch set to use a single field
with the Flatpickr timepicker enabled?

I notice also that paired date fields (start date & end date) now show an extra
"X" icon after the second field, e.g. serial claims or catalog statistics.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:11:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:11:03 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
 permission can no longer update hold pickup locations
In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30207-70-VacjKDBndH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #18 from Liz Rea <wizzyrea at gmail.com> ---
Hi, 

Possible to backport this one into 21.11?

Thanks!

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:27:18 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-TtxuMeDPti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Blocks|                            |30355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355
[Bug 30355] SMS auto renew digest notices are only generated if patron is also
set to receive email
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:27:18 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-oGOzbwfDIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28553


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553
[Bug 28553] Patrons can be set to receive auto_renew notices as SMS, but Koha
does not generate them
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:27:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:27:23 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-pjPgFJT9S4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:38:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:38:50 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-UN3ppqfEKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:38:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:38:54 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-0gO93CbdgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137826&action=edit
Bug 31112: Remove unnecessary if-clause

To test:
 1) Please check manually that the logic stays the same, use git's -w command
line parameter to
    ignore whitespace changes in the diff output.
 2) prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:38:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:38:58 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-ZMiOKITzNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137827&action=edit
Bug 31112: Remove unit test that forces specific internal implementation

To test:
 1) Make sure tests still pass:
    $ prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:39:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:39:02 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-XoGU526SXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137828&action=edit
Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to
a biblio

If a single patron had more than 1 hold to a biblio and there was only one
available item we allowed incorrectly renewing the checkout when
AllowRenewalIfOtherItemsAvailable was set to "Allow". This
changes CanBookBeRenewed so that it makes sure all the holds are
filled and not just one per patron.

To test:
 1) prove t/db_dependent/Circulation.t
 2) (Optional, as unit test is provided)
    - Set AllowRenewalIfOtherItemsAvailable = Allow
    - Create biblio with three items
    - Checkout one item to patron A
    - Add two biblio-level holds for patron B
    - Try to renew patron A's checkout with and without this patch.
    - Notice that without this patch the renewal succeeds even though we
      one unfilled hold left. After applying the patch the renewal should
      fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:40:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:40:22 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-79MVk2h221@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137829&action=edit
Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha
does not generate them

Following bug 18532, one can set a patron's messaging prefs to deliver an
auto-renew notice via SMS.
However, the auto_renewals cron only knows how to generate email notices. We
should not allow the selection of non-functional transport types.

Test Plan:
1) Set a patron to recieve auto-renewals via SMS, leave digest mode
   disabled. Ensure no other transports are enabled either.
2) Auto-renew some items
3) Note the SMS auto-renewal notice was generated!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:41:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:41:23 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-w62gC8QUG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
  Text to go in the|                            |When
      release notes|                            |AllowRenewalIfOtherItemsAva
                   |                            |ilable is set to Allow it
                   |                            |now correctly takes into
                   |                            |account all the holds
                   |                            |instead of just one per
                   |                            |patron.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:44:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:44:49 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-ip41vLGLK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:46:08 +0000
Subject: [Koha-bugs] [Bug 30355] SMS auto renew digest notices are only
 generated if patron is also set to receive email
In-Reply-To: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30355-70-e1QgCDPKYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137829|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:46:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:46:23 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-J3PeasL5Fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:46:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:46:26 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-5epCVso4XU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137830&action=edit
Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha
does not generate them

Following bug 18532, one can set a patron's messaging prefs to deliver an
auto-renew notice via SMS.
However, the auto_renewals cron only knows how to generate email notices. We
should not allow the selection of non-functional transport types.

Test Plan:
1) Set a patron to recieve auto-renewals via SMS, leave digest mode
   disabled. Ensure no other transports are enabled either.
2) Auto-renew some items
3) Note the SMS auto-renewal notice was generated!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:55:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:55:44 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-Fvqy5VuViM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137246|0                           |1
        is obsolete|                            |

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137831&action=edit
Bug 31106: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:55:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:55:48 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-2L3LjrCxIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137247|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137832&action=edit
Bug 31106: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:55:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:55:53 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-5abLsMChCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137248|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137833&action=edit
Bug 31106: Fix links generated in XSLTs

This patch addresses the case of links that are generated on the XSLT
side, those linking to and from host records using 773$t and 773$a.

To test:
1. Pick a bibliographic record (I chose 'Unconditional' from the sample
   data
2. Add " and ? to the title statement. I changed it to
   'Uncond"itional?¿'
3. Add a child record to it
4. Open the detail page for the host record
=> FAIL: It doesn't show the 'Show analytics' link
5. Repeat 4 for the same record, in the OPAC
=> FAIL: It doesn't show the 'Show analytics' link
6. Apply this patch
7. Repeat 4 and 5.
=> SUCCESS: Links are shown!
8. Follow the links
=> SUCCESS: The links take you to the right resultset!
9. Go to the child record, and notice the link back to the parent works
   :-D
10. Sign off :-D

Sponsored-by: Theke Solutions
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 18:56:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 16:56:40 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-3T7imXbwub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great to see the work followed through here.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:01:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:01:05 +0000
Subject: [Koha-bugs] [Bug 31179] New: Duplicate item is duplicating internal
 item fields
Message-ID: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

            Bug ID: 31179
           Summary: Duplicate item is duplicating internal item fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however, currently it is duplicating the complete internal record of the
item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have been copied to new item

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:01:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:01:19 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-DkuzDNn8E6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:18:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:18:01 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-f3BGOqnMtG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #91 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Doesn't apply anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:22:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:22:25 +0000
Subject: [Koha-bugs] [Bug 31174] Display fund on acquisition details tab in
 catalogue/detail.pl
In-Reply-To: <bug-31174-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31174-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31174-70-YgBJOjDj0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31174

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe budget would be useful too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:27:06 +0000
Subject: [Koha-bugs] [Bug 31172] Shouldn't issues.issuedate have a DEFAULT
 NOW() and be NOT NULL?
In-Reply-To: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31172-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31172-70-RKV2EdW8Pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31172

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I like the idea, but we need to think of bad data and the upgrade process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:37:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:37:11 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-qOXL0L8rZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137834&action=edit
Bug 30882: (QA follow-up) Fix tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:28 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-vyySpmn2I1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:31 +0000
Subject: [Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items
 responses
In-Reply-To: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29105-70-2xsIVR95XK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:34 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-ffH4f9pVcn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:36 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-3CGQ7fYYKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:39 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-GQCi23aCZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:42:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:42:42 +0000
Subject: [Koha-bugs] [Bug 31106] Error searching for analytics in detail view
In-Reply-To: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31106-70-FN2COO2HKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:47:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:47:17 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-SdQtxfe96G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Benjamin Daeuber from comment #116)
> (In reply to Jonathan Druart from comment #115)
> > How hard would it be to implement a expand/collapse feature to display a
> > minimal/full header? I think it would fit everybody's needs.
> 
> If the logic of not having text labels on the buttons is to make the
> interface responsive, perhaps the labels could appear on desktops but switch
> to icons only on smaller screen sizes?

I like both ideas. 

Maybe it would work better if the select options would be below or above the
search form again. 

Another thought here: there is not much room currently for additional links
added by IntranetNav. A longer register name or library name would also take up
more space - if we leave a bit more space, we could fit these better too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:14 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-w5OOHtvY73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135797|0                           |1
        is obsolete|                            |
 Attachment #135978|0                           |1
        is obsolete|                            |
 Attachment #135979|0                           |1
        is obsolete|                            |
 Attachment #135980|0                           |1
        is obsolete|                            |
 Attachment #135981|0                           |1
        is obsolete|                            |
 Attachment #135982|0                           |1
        is obsolete|                            |

--- Comment #92 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137835&action=edit
Bug 29697: Special case - opac not needed

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:19 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-hPnuUrH1X8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #93 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137836&action=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

JD Amended patch:
-# FIXME Special case here

-    print "Biblio not found\n,";
+    print "Biblio not found\n";

- my $biblio = Koha::Biblio->find($hostbiblionumber);
+ my $biblio = Koha::Biblios->find($hostbiblionumber);

Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:24 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-BXsoNsNq7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #94 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137837&action=edit
Bug 29697: Remove GetHiddenItemnumbers

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

JD amended patch:
-    my @items        = $biblio->items->filter_by_visible_in_opac({ patron =>
$logged_in_user })->unblessed;
-    foreach my $item (@items) {
+    my $items        = $biblio->items->filter_by_visible_in_opac({ patron =>
$logged_in_user })->unblessed;
+    foreach my $item (@$items) {

-    for my $itm (@items) {
+    for my $itm (@$items) {

-    $dat->{ITEM_RESULTS}   = \@items;
+    $dat->{ITEM_RESULTS}   = $items;

-        @items_to_show = Koha::Items->search( { itemnumbers => [ map {
$_->{itemnumber} } @all_items ] } )
-                                    ->filter_by_visible_in_opac( { patron =>
$patron } );
+        @items_to_show = Koha::Items->search( { itemnumber => [ map {
$_->{itemnumber} } @all_items ] } )
+                                    ->filter_by_visible_in_opac( { patron =>
$patron } )->as_list;

-            my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1,
patron => $patron });
+            my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1,
patron => $patron })->as_list;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:29 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-TJIyrV8wZz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #95 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137838&action=edit
Bug 29697: Use flag embed_items

Includes:
    Bug 29697: (follow-up) Use flag embed_items

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:34 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-mp9UVaijUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #96 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137839&action=edit
Bug 29697: Fix tests

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:52:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:52:39 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-IemRlL0o1y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #97 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137840&action=edit
Bug 29697: Deal with the degraded view in detail.pl

In detail.pl we must provide a degraded view with an error message about
invalid MARC::Record.
We are then forced to reproduce the GetMarcBiblio behaviour and call
StripNonXmlChars on the MARC::XML

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:53:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:53:10 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-gbfwvKIzEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #98 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:35 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-MGKIdqNAnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:38 +0000
Subject: [Koha-bugs] [Bug 20439] SMS provider sorting
In-Reply-To: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20439-70-VHJrbMYnGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20439

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:41 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-3vWV16iTGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:44 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-yRQFIrp4HT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:47 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-2D54FT7fES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:49 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-2t6Zp07oJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:52 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-TB8o8wZViu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:55:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:55:55 +0000
Subject: [Koha-bugs] [Bug 31144] When modifying an order we should not load
 the vendor default discount
In-Reply-To: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31144-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31144-70-yLX0dv9fxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31144

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 19:59:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 17:59:21 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-6CAHZ0bsO8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #46 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Doesn't apply anymore against latest master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:00:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:00:08 +0000
Subject: [Koha-bugs] [Bug 31175] OPAC Logout should return you to where you
 were (unless that's a restricted page)
In-Reply-To: <bug-31175-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31175-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31175-70-afhNbXIQKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31175

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tbh it feels right to me that a logout 'resets' for the next user. I think
usually you'd only log out when you intend to leave. For the patron account
pages, we'd also need to redirect to the login page probably.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:23 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-DbTJ0N60VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:26 +0000
Subject: [Koha-bugs] [Bug 29114] Can not add barcodes with whitespaces at
 the beginning to the list
In-Reply-To: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29114-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29114-70-dxcuJ5egsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:29 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-eRKaKWX0lY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:31 +0000
Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in
 alphabetical order
In-Reply-To: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29922-70-Fvwo1cTR9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:34 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-Yt8j118Mxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:16:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:16:37 +0000
Subject: [Koha-bugs] [Bug 31163] Sort cashup history so that newest entries
 are first
In-Reply-To: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31163-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31163-70-lxvG5f1iuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31163

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 20:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 18:32:07 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-6iVa6OUeM7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, we never used that feature, but there have been bugs reported about it that
might give some insight - or at least lead to libraries using it?

I feel like maybe 'visible for the library's staff users' might be the answer:

Bug 7919 - Display of values depending on the connexion library (authorised
values, patron categories, extended attributes)

Bug 15163 - Patron attributes with branch limiits are not saved when invisible

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:17:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:17:50 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-rabh3Kjgcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:20:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:20:02 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-5UQhbC7nPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48887|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:20:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:20:28 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-gHt7ATgJ5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:21:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:21:01 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-zoqCLqfjFR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #19)
> Can we please have a rebase?
> 

I just forgot to obsolete the older patch, should work now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:21:55 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-WEfaE28Msc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:22:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:22:01 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-Idbn3vmUNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137821|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137841&action=edit
Bug 7660: Use first available categorycode when none passed in

The code that populates the patron messaging preferences on initial form load
expects to have a category selected. Currently we only have one if one was
passed to the form. When creating an account from a parent, we don't have a
category explicitly selected - so we can just select the first of the possible
categories

To test:
 1 - In KTD set 'Juvenile' category to have some messaging preferences
 2 - Find a patron, say Edna Acosta, and 'Add guarantee'
 3 - In new form preferences are blank, cancel
 4 - Apply patch, restart all
 5 - Go to Edna, click 'Add guarantee'
 6 - Preferences are populated!
 7 - Cancel
 8 - Go to 'Patrons' module
 9 - Click "+ New patron"
10 - Confirm messaging preferences load correctly when not adding child

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:22:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:22:28 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-bQRyG3gRMW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Don't get to pass QA on 4 digit bugs often anymore :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:35:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:35:00 +0000
Subject: [Koha-bugs] [Bug 29994] Single label pdf export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-IVv3FBCN9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Manos PETRIDIS <egpetridis at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egpetridis at yahoo.com

--- Comment #4 from Manos PETRIDIS <egpetridis at yahoo.com> ---
Could this be related to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:41:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:41:58 +0000
Subject: [Koha-bugs] [Bug 29994] Single label pdf export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-mfLkn0bnzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #5 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Caroline Cyr La Rose from comment #3)
> The problem occurs when clicking the "Export" button in the table of items,
> Actions column. 
> 
> To test:
> 1) If you do not already have label templates and layouts, add some (can use
> the settings in comment 2, but any will do)
> 2) Go to Tools > Label creator > New > Label batch
> 3) Add one barcode in the box
> 4) Click Add items
> 5) Click the 'Export full batch' button
> 6) Choose the label template and layout
> 7) Click Export
> 8) Click Download as PDF
> --> PDF is generated
> 9) In the label batch, select the item (the checkbox on the right)
> 10) Click 'Export selected items'
> 11) Repeat steps 6-8
> --> PDF is generated
> 12) In the label batch, click the 'Export' button in the Actions column
> 13) Repeat steps 6-8
> --> No PDF is generated

Thank you. Yes, this way it works, at least it does now that I upgraded to
version 22.05. I remember that the single export button in the table used to
work in Koha 21.05 and previous versions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:43:44 +0000
Subject: [Koha-bugs] [Bug 29994] Single label pdf export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-z99g1uVpTC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #6 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Manos PETRIDIS from comment #4)
> Could this be related to
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 ?

Thank you. No, in my case all printed characters are Latin characters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:44:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:44:35 +0000
Subject: [Koha-bugs] [Bug 31180] New: Provide a koha-conf.xml (etc.) checker.
Message-ID: <bug-31180-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31180

            Bug ID: 31180
           Summary: Provide a koha-conf.xml (etc.) checker.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: egpetridis at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I feel that a checker should be provided that checks the various configuration
files -koha-conf.xml is a prime suspect- and notify the library admin of
missing stanzas or invalid values. For example, missing information on fonts to
be used, or reference to non-existent (or non-accessible) files and/or folders.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:46:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:46:58 +0000
Subject: [Koha-bugs] [Bug 31180] Provide a koha-conf.xml (etc.) checker.
In-Reply-To: <bug-31180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31180-70-3ndLHntCLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31180

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We already have some checks in place and the results show on the system
information tab on the About Koha page.

The fonts section missing could be another to add. Maybe we could change this
bug report to cover that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:54:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:54:49 +0000
Subject: [Koha-bugs] [Bug 31181] New: Merge function does not include local
 copy images
Message-ID: <bug-31181-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31181

            Bug ID: 31181
           Summary: Merge function does not include local copy images
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: egpetridis at yahoo.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It seems that merge-from item local cover images are not merged to the merge-to
entry. 
Is thie intentional or is it a bug? If intentinal there should be a warning to
the user before the merge is performed, so that they may save the current
images and re-locad them once the merging is complete.
Are the images left in limbo, or are they deleted from the db once the merge is
complete?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:55:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:55:36 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-WhUPv6J5hj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:55:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:55:41 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-3PZImQxz9z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136449|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137842&action=edit
Bug 15048: Index all possible searched subfields for index-term-genre

Currently we only index a - but we can setup the system such that avxyz are
searched

To test:
 1 - define both a 655$a *and* 655$x value in a bib, save, reindex
 2 - Set system preferences:
      TraceSubjectSubdivisions: Include
      TraceCompleteSubfields: Force
 3 - View the record edited above in the opac
 4 - Click on the subject heading
 5 - No results found
 6 - Copy zebra files:
  sudo cp ./etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \
  /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
  sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \
  /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
 7 - restart all and reindex
 8 - Click on the subject heading in OPAC
 9 - Sucess!
10 - Repeat with other fields (vyz)
11 - Repeat under ES, reindexing and resetting mappings

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:58:14 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-8gW4zFZ4Vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel like we can't expect people to constantly reset their Elasticsearch
mappings and redo their own. As this fixed a bug, could we update mappings with
a database update?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 21:58:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 19:58:30 +0000
Subject: [Koha-bugs] [Bug 5158] Koha needs its own cookie, ice cream,
 and fudge flavors
In-Reply-To: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5158-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5158-70-CaQ8VPm4n5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5158

Margaret Hade <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:00:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:00:05 +0000
Subject: [Koha-bugs] [Bug 31181] Merge function does not include local copy
 images
In-Reply-To: <bug-31181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31181-70-ZAtkdpSSln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31181

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe we could count this as a bug. I think the covers should be merged in,
maybe with a warning only if  AllowMultipleCovers is off?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:00:18 +0000
Subject: [Koha-bugs] [Bug 31181] Merge function does not include local cover
 images
In-Reply-To: <bug-31181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31181-70-twPeU4k5J4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31181

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Merge function does not     |Merge function does not
                   |include local copy images   |include local cover images

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:07:00 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-TYU8DYKGQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The second patch doesn't quite work:

-                                        <span>for</span>
-                                            [% IF (
subscription_LOO.numberlength ) %][% subscription_LOO.numberlength | html %]
<span>issues</span>[% END %]
-                                            [% IF (
subscription_LOO.weeklength ) %][% subscription_LOO.weeklength | html %]
<span>weeks</span>[% END %]
-                                            [% IF (
subscription_LOO.monthlength ) %][% subscription_LOO.monthlength | html %]
<span>months</span>[% END %]
+                                            [% IF (
subscription_LOO.numberlength ) %][% subscription_LOO.numberlength | html %]
<span>for issues</span>[% END %]

Before:

for x months

Now: 

4 for months

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:15:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:15:58 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-RIwRnwhxf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Victor Grousset/tuxayo from comment #7)
> How does on populate the "published on" column? To check that it's indeed
> displayed and that search works.
> 
> Otherwise it looks good for QA

"Published on" is the date the claimed issue was supposed to be published. I am
adding a follow-up to rename the column to 'Publication date' - I think as we
are claiming something that has not arrived that might work a little better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:21:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:21:47 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-E0yiV3WVg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:21:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:21:51 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-8s4OccW7KH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137799|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137843&action=edit
Bug 30039: Add published on column to claims.pl

To test:
1. Have a vendor setup
2. Go to serials and add a new serial w/ that vendor.
3. When creating a serial make this first issues sometime in the past.
4. Go to Claims, choose your vendor and load the table.
5. No published on column.
6. Apply patch
7. Try step 4 again and now you should see a published on column.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:21:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:21:56 +0000
Subject: [Koha-bugs] [Bug 30039] Add published_on column to missing issues
 table on claims.tt
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-8gIX0NzqAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137844&action=edit
Bug 30039: (QA follow-up) Change published on to publication date

As the issue might not have been published yet, but should have
been that seemed a better fit.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:22:29 +0000
Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial
 claims table
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-Z0tmWcvwz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add published_on column to  |Add publication date column
                   |missing issues table on     |to serial claims table
                   |claims.tt                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:32:11 +0000
Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record
In-Reply-To: <bug-24589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24589-70-XdLbUvgvYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:35:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:35:36 +0000
Subject: [Koha-bugs] [Bug 28173] Add plugin hooks object_store_pre and
 object_store_post
In-Reply-To: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28173-70-jOEiM74Tmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28173

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:38:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:38:33 +0000
Subject: [Koha-bugs] [Bug 29994] Single label pdf export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-onULObonGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #7 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Isabel Pineda from comment #6)
> (In reply to Manos PETRIDIS from comment #4)
> > Could this be related to
> > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 ?
> 
> Thank you. No, in my case all printed characters are Latin characters.

We are using Koha in Spanish, though. Maybe this has something to do with the
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:41:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:41:06 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-Wry1EMKeHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:41:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:41:11 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-nMRVbxhxf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137777|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137845&action=edit
Bug 30335: Add classes to invoice/credit tabs on patron accouting pages

To test:
1. Apply patch and go to the patron accounting page.
2. Notice the class names for each list element on the page.
3. You can use the following CSS to try hiding each of the tabs:

.transactions { display: none; }
.makepayment { display: none; }
.manualinvoice { display: none; }
.manualcredit { display: none; }

Signed-off-by: Rachael Laritz <rachael at inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:41:15 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-3O0eOtXV32@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137778|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137846&action=edit
Bug 30335: (follow-up) Add permissions for manual accounts options

This patch adds two new sub-permissions, `manual_credit` and
`manual_invoice` to allow/prevent staff the ability to add manual
invoices and credits to a patrons account.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:41:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:41:20 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-xswFW9vTzG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137779|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137847&action=edit
Bug 30335: (follow-up) Bind new permissions to pages and tabs

This patch binds the new permissions added in the previous patch to the
tab display on the borrower account page.

Test plan
1) Apply the previous patch and run the database update
2) Configure a user without the new permissions
3) Confirm the 'Create manual invoice' and 'Create manual credit' tabs
   no longer appear under the 'Accounting' area when logged in as the
   above user.
4) Confirm that you cannot manually navigate to /members/mancredit.pl or
   /members/maninvoice.pl when logged in as the above user.
5) Confirm that users with the above permissions are still able to see
   the tabs and take actions on them.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:41:24 +0000
Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices
 and manual credits in patron accounts
In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30335-70-qRcY2nmk8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137784|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137848&action=edit
Bug 30335: (follow-up) Ensure existing users remain permitted

This patch updates the database update to ensure users with the
'remaining_permissions' subpermission of 'updatecharges' continue to be
able to manually invoice and manually credit borrower accounts after the
patch is applied.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:54:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:54:48 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-bWkNPHpsh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:54:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:54:52 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-SkCdyIfxs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135393|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137849&action=edit
Bug 30858: Add serial enumeration/chronology to item search

To test:
1. Apply patch
2. Go to  Catalog > Item search and do a search for items that you know contain
a items.enumchron
3. The result set should now show the items.enumchron
4. Make sure you can properly "Export results to.."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:54:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:54:57 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-1fYaoPdSnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137850&action=edit
Bug 30589: (follow-up) Add enumchron to CSV export and fix CSS class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:55:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:55:30 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-9e0ZBRDPLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I borrowed your bug, Lucas and hopefully fixed the issues David noted for good
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 22:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 20:57:20 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-rf7Kzj8coi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah, and there is already a bug for adding the column configuration:
Bug 23565 - Add columns configuration and export options to item search results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:09:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:09:57 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-MI6VePtAO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have tried to test this, but I can't replicate the problem, could this have
been fixed otherwise?

To recreate:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor

I used 952k, tab 10, visibile in editor, AV = LOC.
Updated Koha-to-MARC-mappings to map to permanent_location.

3 - Change the location of the item and retain the permanent location on saving

My item had no locations set. I set permanent location and locatoon to
different values and saved.

4 - note that permanent location has changed anyway

The fields kept the values I set, nothing was changed unexectedly.

Maybe I am missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:10:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:10:36 +0000
Subject: [Koha-bugs] [Bug 31182] New: Result search number missing in OPAC
Message-ID: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182

            Bug ID: 31182
           Summary: Result search number missing in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Bug 27493 changed in OPAC the result search number to hidden when
OPACHiddenItems is used.
But looks like it is always hidden.
Looking at HTML code, the data is also missing (in
/cgi-bin/koha/opac-search.pl) :
  <td class="numcol hidden">
  </td>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:10:58 +0000
Subject: [Koha-bugs] [Bug 31182] Result search number missing in OPAC
In-Reply-To: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31182-70-MXe8Vk5hxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493
[Bug 27493] Improve structure and style of checkbox columns in tables
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:10:58 +0000
Subject: [Koha-bugs] [Bug 27493] Improve structure and style of checkbox
 columns in tables
In-Reply-To: <bug-27493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27493-70-KPYbiZvOPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27493

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31182


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182
[Bug 31182] Result search number missing in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:11:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:11:14 +0000
Subject: [Koha-bugs] [Bug 31182] Result search number missing in OPAC
In-Reply-To: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31182-70-JXTdudl1MX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:26:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:26:22 +0000
Subject: [Koha-bugs] [Bug 30318] Cannot override default patron messaging
 preferences when creating a patron in staff client
In-Reply-To: <bug-30318-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30318-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30318-70-U9Ooa595Dn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid, but you have to remove all settings, if you only remove some, the
settings are saved correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:28:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:28:06 +0000
Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check
 if the zebraqueue has uncommitted records
In-Reply-To: <bug-30260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30260-70-wA33Z8GWAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tomas or Martin, can you help with pushing to
https://git.koha-community.org/Koha-community/global/?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:28:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:28:50 +0000
Subject: [Koha-bugs] [Bug 30218] Add subfield g to 150 heading_fields
In-Reply-To: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30218-70-KQ4zXJF85L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131328|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:32:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:32:00 +0000
Subject: [Koha-bugs] [Bug 30216] Additional identification field for patron
 for SIP2
In-Reply-To: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30216-70-aHeg3dFhQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Additional identification   |Additional identification
                   |filed for patron for sip2   |field for patron for SIP2

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just a suggestion: we usually use one identifier that the patron uses for login
in the OPAC and another, that is used at the self check/circulation desk. 
If you can, you could move one of your IDs to a unique patron attribute. They
can be used for patron import, if that is an issue. Maybe the Internal Student
ID could be moved?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:32:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:32:27 +0000
Subject: [Koha-bugs] [Bug 31183] New: Add
 Koha::Item::Transfers->filter_by_current
Message-ID: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

            Bug ID: 31183
           Summary: Add Koha::Item::Transfers->filter_by_current
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:32:44 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-NHJMApGeAb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30447
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447
[Bug 30447] pendingreserves.pl is checking too many transfers
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:32:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:32:44 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-fKjhufN2M8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31183


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183
[Bug 31183] Add Koha::Item::Transfers->filter_by_current
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:48:21 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-vM4mAa7JxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:48:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:48:26 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-abpZ6ZYAel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137851&action=edit
Bug 31183: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:48:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:48:30 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-94PlwhnYiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137852&action=edit
Bug 31183: Add Koha::Item::Transfers->filter_by_current

This patch introduces the aforementioned method.

To test:
1. Apply this unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item/Transfers.t
=> FaIL: method not defined?
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:48:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:48:34 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-fxR4GqShtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137853&action=edit
Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill

This patch makes the method use the new
Koha::Item::Transfers->filter_by_current one.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:54:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:54:09 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-rNawgtr2Cl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:54:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:54:11 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-bf9zabRHbs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:54:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:54:14 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-r6XpI6p7ul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:54:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:54:16 +0000
Subject: [Koha-bugs] [Bug 30447] pendingreserves.pl is checking too many
 transfers
In-Reply-To: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30447-70-kVOZ5bexLR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30447

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 18 23:55:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 21:55:03 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-flFmFLRXdn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 00:08:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 22:08:13 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-khKS0E3mqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
- It feels weird that we add a DB-level constraint on the column, but we
manually check it in ->store to raise the exception. I see how we got there by
the bug history. Thoughts? Shouldn't we catch the DB-level exception and throw
our own? Not a blocker, though.
- In cases like this, if the atomicupdate fails, it would be nice to tell how
to fix things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 00:27:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 22:27:52 +0000
Subject: [Koha-bugs] [Bug 30260] Script which checks index should also check
 if the zebraqueue has uncommitted records
In-Reply-To: <bug-30260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30260-70-z0Ps1Em3Le@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I had no idea that repo existed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 00:56:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Jul 2022 22:56:49 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-wGI5oYox75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134003|0                           |1
        is obsolete|                            |

--- Comment #7 from Michael Hafen <michael.hafen at washk12.org> ---
Created attachment 137854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137854&action=edit
Bug 28726: Add sort1 and sort2 to patron card creator -  patron search.

[ Rebased 2022-07-18 ]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 04:38:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 02:38:00 +0000
Subject: [Koha-bugs] [Bug 29497] Add ability to link authorities
 automatically in the advanced editor
In-Reply-To: <bug-29497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29497-70-cPSsgUxY39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29497

Carlos Lopez <clopez at dml.vic.edu.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at dml.vic.edu.au

--- Comment #1 from Carlos Lopez <clopez at dml.vic.edu.au> ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 05:59:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 03:59:36 +0000
Subject: [Koha-bugs] [Bug 31184] New: Add default permissions by patron
 category
Message-ID: <bug-31184-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184

            Bug ID: 31184
           Summary: Add default permissions by patron category
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It could be useful to assign default permissions by patron category. (This was
pointed out to me by a librarian who had similar functionality in a previous
system.)

Alternatively, I suppose we could create "permission profiles" and assign those
at patron creation time I suppose.

The idea being that you set up permissions for certain staff categories (like
cataloguing or circulation) and then the staff automatically have their
permissions set up and don't require you to manually check all the right
checkboxes on a per-user basis. 

(I suppose role/group-based authorization would cut down even further on having
to manually manage so many permissions...although this probably more of a
problem for large libraries than small libraries...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 07:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 05:31:06 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-v8JQ4UFbTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 07:38:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 05:38:29 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-iTQS3tem5a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good points raised there Tomas.. I was perhaps a little hasty in PQA.  We could
do better; as you highlighted we could be catching the constraint failure
rather than testing before hitting the database.. never sure which approach is
actually cleaner/better for performance.. it would be interesting to benchmark
that.

However, the DB update side is something I think we probably should try to
improve by making it a little more resilient.. we could look for nulls prior to
adding the constraint and arbitrarily pick the first branchcode in the branches
table to fix the data should we find any nulls?

Our database updates are better now in terms of not silently ignoring issues,
but I do think we as Devs aught to try and cater for more of these cases to
keep the upgrades fairly smooth.

I'm happy to add that proposed follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 07:54:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 05:54:15 +0000
Subject: [Koha-bugs] [Bug 30216] Additional identification field for patron
 for SIP2
In-Reply-To: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30216-70-79IduxhxGe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216

--- Comment #4 from Mohsin <mohsin.riaz1 at gmail.com> ---
Fischer, YEs. thats what i did. I use one attribute " initial" and used it as
secondary id but you know its bit confusing or may raise a issue if later
library wants to use this. So thats hwy i need to know how i can add a new
unique attribute filed in borrowers.(In reply to Katrin Fischer from comment
#3)
> Just a suggestion: we usually use one identifier that the patron uses for
> login in the OPAC and another, that is used at the self check/circulation
> desk. 
> If you can, you could move one of your IDs to a unique patron attribute.
> They can be used for patron import, if that is an issue. Maybe the Internal
> Student ID could be moved?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 09:00:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 07:00:08 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-T1LTKr0wHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #47 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Remote branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 09:15:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 07:15:25 +0000
Subject: [Koha-bugs] [Bug 30216] Additional identification field for patron
 for SIP2
In-Reply-To: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30216-70-AvgfNETJWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You can add patron attributes from Administration after activating the
ExtendedPatronAttributes system preference. If you choose for it to be
'unique', it will be available as a match point for patron imports.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 09:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 07:32:58 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-pg4vlU070B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #99 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Looks like ktd is failing to setup if those patches are applied and
KOHA_ELASTICSEARCH is set to 1.


koha_1       | [942] Indexing biblios
koha_1       | Invalid data, cannot decode metadata object
(biblio_metadata.id=368, biblionumber=369, format=marcxml, schema=MARC21,
decoding_error=':8: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="001">00aD000015937</controlfield>
koha_1       |                             ^
koha_1       | :9: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="004">00satmrnu0</controlfield>
koha_1       |                             ^
koha_1       | :9: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="004">00satmrnu0</controlfield>
koha_1       |                                ^
koha_1       | :9: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="004">00satmrnu0</controlfield>
koha_1       |                                   ^
koha_1       | :9: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="004">00satmrnu0</controlfield>
koha_1       |                                      ^
koha_1       | :10: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="008">00ar19881981bdkldan</controlfield>
koha_1       |                             ^
koha_1       | :10: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="008">00ar19881981bdkldan</controlfield>
koha_1       |                                        ^
koha_1       | :10: parser error : PCDATA invalid Char value 31
koha_1       |   <controlfield tag="008">00ar19881981bdkldan</controlfield>
db_1         | 2022-07-19  7:27:59 13 [Warning] Aborted connection 13 to db:
'koha_kohadev' user: 'koha_kohadev' host: '172.24.0.6' (Got an error reading
communication packets)
koha_1       |                                            ^')koha_koha_1 exited
with code 1


May need to be investigated before push.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 09:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 07:38:17 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-7KFKUt8otv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 09:38:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 07:38:21 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-HNBMG39QvQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137667|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137855&action=edit
Bug 30992: Improve translatability for 'for'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 10:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 08:52:56 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-azlMDjhVWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137826|0                           |1
        is obsolete|                            |

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137856&action=edit
Bug 31112: Remove unnecessary if-clause

To test:
 1) Please check manually that the logic stays the same, use git's -w command
line parameter to
    ignore whitespace changes in the diff output.
 2) prove t/db_dependent/Circulation.t

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 10:52:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 08:52:59 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-YjULEfKpGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137827|0                           |1
        is obsolete|                            |

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137857&action=edit
Bug 31112: Remove unit test that forces specific internal implementation

To test:
 1) Make sure tests still pass:
    $ prove t/db_dependent/Circulation.t

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 10:53:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 08:53:03 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-hR8nyQFGAy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137828|0                           |1
        is obsolete|                            |

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137858&action=edit
Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to
a biblio

If a single patron had more than 1 hold to a biblio and there was only one
available item we allowed incorrectly renewing the checkout when
AllowRenewalIfOtherItemsAvailable was set to "Allow". This
changes CanBookBeRenewed so that it makes sure all the holds are
filled and not just one per patron.

To test:
 1) prove t/db_dependent/Circulation.t
 2) (Optional, as unit test is provided)
    - Set AllowRenewalIfOtherItemsAvailable = Allow
    - Create biblio with three items
    - Checkout one item to patron A
    - Add two biblio-level holds for patron B
    - Try to renew patron A's checkout with and without this patch.
    - Notice that without this patch the renewal succeeds even though we
      one unfilled hold left. After applying the patch the renewal should
      fail.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 10:55:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 08:55:51 +0000
Subject: [Koha-bugs] [Bug 31112] Able to renew checkout when the number of
 holds exceeds available number of items
In-Reply-To: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31112-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31112-70-KTlA9KCizk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, signed off.  Thanks for this, good improvement.

There's a small typo in the test plan - either 2.2. should be:  'Create biblio
with two items' or 2.3/2.4 should be:  'Checkout out one item to patron A, one
item to patron B, and add two biblio-level holds for patron C'.  

To test:
 1) prove t/db_dependent/Circulation.t
 2) (Optional, as unit test is provided)
    - Set AllowRenewalIfOtherItemsAvailable = Allow
    - Create biblio with three items
    - Checkout one item to patron A
    - Add two biblio-level holds for patron B
    - Try to renew patron A's checkout with and without this patch.
    - Notice that without this patch the renewal succeeds even though we
      one unfilled hold left. After applying the patch the renewal should
      fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 11:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 09:45:47 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-RJvifsEwE5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137181|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137859&action=edit
Bug 31105: Holds to pull counts items from other branches when
independentbranches is active

Holds to pull should not show items from other branches that shares a
record when IndependentBranches is active. Except for superlibrarians.

Test plan:
1- Have IndependentBranches set to Yes
2- Have a record with an item from the current branch and another item from a
different branch. We will call them branch A and branch B respectively
3- Have a patron from branch A place a hold on that record
4- Have a staff account on branch A and B with the following permissions:
    - circulate (all)
    - catalogue
5- Go to circulation > holds to pull
6- Notice under "Libraries" it displays branch A and B. Also, it shows 2 under
"Items available"
7- Checkout the item from branch A to another patron
8- Go back to circulation > holds to pull
9- Notice under "Libraries" it displays branch B even though we are in branch A
10- Apply the patch
11- Return the checked out item from step 7
12- Redo step 5 to 9 with superlibrarian privileges and notice nothing changed
13- Redo step 11-12 but using accounts from step 4 and notice Holds to
pull only shows information relevant to their branch

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 11:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 09:46:08 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-vyamOQJ9U3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:03:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:03:20 +0000
Subject: [Koha-bugs] [Bug 31185] New: Link authorities automatically doesn't
 detect duplicate authorities
Message-ID: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

            Bug ID: 31185
           Summary: Link authorities automatically doesn't detect
                    duplicate authorities
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: adolfo.rodriguez at xercode.es
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When cataloging a bibliographic record, the template addbiblio.tt has a code to
show that there is more than one local match for the entry point
(MULTIPLE_MATCH) but the function LinkBibHeadingsToAuthorities never returns
that code. 

This means that when the authority you are looking for is duplicated and you
click the "Link authorities automatically", you obtain the following message
"No matching authority found." instead of "More than one local match found.
Possibly a duplicate authority!" This gives the false impression that the
authority doesn't exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:13:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:13:57 +0000
Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't
 detect duplicate authorities
In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31185-70-q88yo1JuLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

--- Comment #1 from Adolfo <adolfo.rodriguez at xercode.es> ---
Created attachment 137860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137860&action=edit
Detect duplicate authorities using Link authorities automatically

This patch fixes LinkBibHeadingsToAuthorities so it detects duplicate
authorities using "Link authorities automatically"

To test
1 Make sure the system preference AutoCreateAuthorities is turned to don't
generate
2 Create a duplicate authority and check that search in Authorities module
returns both. For example, two Personal Name (Smith, John)
3 Create a new record and fill the entry point with the same text of the
authorities you just created. For example 100$a Smith, John
4 Click "Link authorities automatically" and you will obtain the following
message "No matching authority found."
5 Apply patch, restart services
6 Click "Link authorities automatically" and you will obtain the following
message "More than one local match found. Possibly a duplicate authority!"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:24:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:24:32 +0000
Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't
 detect duplicate authorities
In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31185-70-o0W5dmRtbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

Adolfo Rodríguez Taboada <adolfo.rodriguez at xercode.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:27:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:27:43 +0000
Subject: [Koha-bugs] [Bug 31186] New: Search result numbering in OPAC got
 suppressed
Message-ID: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

            Bug ID: 31186
           Summary: Search result numbering in OPAC got suppressed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Trivial fix forthcoming

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:31:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:31:20 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-FBefmuH73G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:31:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:31:24 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-aDaCD9O26O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137861&action=edit
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 13:31:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 11:31:53 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-l6SGr4lX9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl
                 CC|                            |tomascohen at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Super trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:30 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-FgzPNoWbFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136166|0                           |1
        is obsolete|                            |

--- Comment #54 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137862&action=edit
Bug 25498: Add transfer button on intranet

Note: Adjusting shelves_results template too for not allowing delete
when you do not have delete_public_lists (or higher). If you are the
owner, you are allowed to edit or delete. But transfer specifically
needs edit_public_lists (or higher).

Note: Removed a few useless POD lines to make qa tools happy.

Test plan:
Check if you see the transfer button on public lists only when having
permission edit_public_lists (or higher). And never on private lists.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:35 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-4Yyur9suNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136167|0                           |1
        is obsolete|                            |

--- Comment #55 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137863&action=edit
Bug 25498: Add a transfer form for public lists

Test plan:
[1] Valid transfer:
    Log in with staff patron C having edit_public_lists.
    Pick a public list. Choose Transfer. Select a patron.
    Submit and check if transfer was successful.
[2] Permission problem:
    Pick a staff user D. Temporary enable edit_public_lists.
    Add another private tab. Login with D.
    Pick a public list. Transfer. Choose another patron. Wait.
    Switch tab: remove added permission from D.
    Switch tab again: Submit transfer form. Error? Close tab.
[3] Bonus test - Shelf disappeared:
    Pick a public list. Transfer. Choose another patron. Wait.
    Open another tab. Delete the selected public list.
    Close tab. Submit the transfer. Not exist error?
[4] Bonus test - Patron not found:
    Pick a public list. Transfer. Choose another patron. Wait.
    Open another tab. Delete selected patron.
    Close tab. Submit transfer. Patron not found error?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:40 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-7kYlfGAsXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136168|0                           |1
        is obsolete|                            |

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137864&action=edit
Bug 25498: Show transfer button for shared lists on OPAC

Test plan:
Pick or create a shared list.
Verify that OPAC only shows the Transfer button when you are the
owner of a shared list.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:45 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-NYHJBYAX7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136169|0                           |1
        is obsolete|                            |

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137865&action=edit
Bug 25498: Transfer ownership shared list on OPAC

Test plan:
Pick or create a shared list. Login as owner.
Transfer to one of the other members.
Verify that you do no longer have Transfer, but see Remove share.
Login as the other member. Transfer it back.

Bonus: Working with two tabs, you can open the Transfer form and
in the meantime delete the list, the patron or remove the share.
Or change permissions. Submit after that and check the error message.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:50 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-FyndanHGoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136221|0                           |1
        is obsolete|                            |

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137866&action=edit
Bug 25498: (QA follow-up) Rename virtualshelfshare->patron

This patron is a 'sharee' (not the sharer).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:21:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:21:55 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-sjlbnluYIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137867&action=edit
Bug 25498: (follow-up) Change for autocomplete change of 30578

Test plan:
Check if the patron search still works on the intranet shelves form
when transferring ownership.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:37:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:37:50 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-hvzNYsfAhC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:37:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:37:55 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-1naKr7fzBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137868&action=edit
Bug 30718: Fix time display

Especifically when timeformat=12h

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:38:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:38:00 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-nbjCdCC8xB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137869&action=edit
Bug 30718: Prevent 'reset' icon to appear twice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:39:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:39:13 +0000
Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere
In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30718-70-Fztaxp2TNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718

--- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Owen Leonard from comment #22)
> > > - circulation.pl
> > >   Template process failed: undef error - The given date (01.06.2022 11:59
> > > PM) does not match the date format (iso) at
> > >
> > > The above error occurred when checking out and specifying a date in the past.
> 
> I'm still getting this error when manually selecting a due date in the past.
> 
> I now notice that the time portion of the datetime is not appearing in the
> input field. The same is true on the checkin and offline circulation page.

This was hiding something critical, thanks for the catch.

> > > - tools/holidays.pl
> 
> There's now a little calendar icon showing above the calendar on this page.

Yes, we don't need it there, fixed.

> > > - Tasks scheduler: "Failed to add Tasks"
> > Fixed (note that time part is mandatory but the UI does not ask for it).
> 
> Would it make sense to update the form in this patch set to use a single
> field with the Flatpickr timepicker enabled?

I would consider that different from what we are doing here. Should be fixed
separately in my opinion.

> I notice also that paired date fields (start date & end date) now show an
> extra "X" icon after the second field, e.g. serial claims or catalog
> statistics.

Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:51:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:51:57 +0000
Subject: [Koha-bugs] [Bug 30905] Show waiting recalls in patron account on
 checkouts tab
In-Reply-To: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30905-70-TslDfvVUU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137870&action=edit
Bug 30905: (follow-up) Get logged in branch once

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:54:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:54:49 +0000
Subject: [Koha-bugs] [Bug 30905] Show waiting recalls in patron account on
 checkouts tab
In-Reply-To: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30905-70-kJG390vBbN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:54:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:54:52 +0000
Subject: [Koha-bugs] [Bug 30905] Show waiting recalls in patron account on
 checkouts tab
In-Reply-To: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30905-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30905-70-2GgDMEEs6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30905

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:54:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:54:55 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-2UcLzDdN57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:54:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:54:58 +0000
Subject: [Koha-bugs] [Bug 30935] Holds to pull shows wrong first patron
In-Reply-To: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30935-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30935-70-VmTlwX8ka6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30935

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 14:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 12:59:19 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-22uGBTlVZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137867|0                           |1
        is obsolete|                            |

--- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137871&action=edit
Bug 25498: (follow-up) Change for autocomplete change of 30578

Test plan:
Check if the patron search still works on the intranet shelves form
when transferring ownership.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 15:00:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 13:00:38 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-NvgmWCPR3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Just wanted to test the last patch. All good.

A quick remark when testing: I think we need the "transfer" action available
from the show list view (/virtualshelves/shelves.pl?op=view&shelfnumber=1). Not
considering blocker however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 15:15:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 13:15:00 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-P5YGWZwUID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #8)
> I have tried to test this, but I can't replicate the problem, could this
> have been fixed otherwise?
> 
> To recreate:
> 1 - Map permanent_location to a marc field
> 2 - Expose that field in the item editor
> 
> I used 952k, tab 10, visibile in editor, AV = LOC.
> Updated Koha-to-MARC-mappings to map to permanent_location.
> 
> 3 - Change the location of the item and retain the permanent location on
> saving
> 
> My item had no locations set. I set permanent location and locatoon to
> different values and saved.
> 
> 4 - note that permanent location has changed anyway
> 
> The fields kept the values I set, nothing was changed unexectedly.
> 
> Maybe I am missing something?

Create an item, set location=Audio Visual (AV), save
=> permanent location is AV
Edit again, set location=Child's area (CHILD), don't modify permanent location,
save
=> permanent location is CHILD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 15:30:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 13:30:35 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-biuy0ldbJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Nick Clemens from comment #3)
> Does limiting an attribute to a branch(es) imply that only librarians from
> that branch can see that attribute?

This.
It was the goal of bug 7919, restrict some values to a list of branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 15:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 13:51:59 +0000
Subject: [Koha-bugs] [Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
In-Reply-To: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27526-70-vyLeLEy7SL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31179


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179
[Bug 31179] Duplicate item is duplicating internal item fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 15:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 13:51:59 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-0r3PdBIXW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
         Depends on|                            |27526

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
If this is a regression it's certainly coming from bug 27526.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
[Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:10:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:10:57 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-8bTchXlRql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:11:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:11:03 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-C35tHowxxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137872&action=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:15:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:15:10 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-hPjTfQS592@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #10 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Confirming current incorrect behavior: 

1: create new subfield in DEFAULT framework, 952$k, visible in editor, managed
in tab 10, tied to LOC auth value
2: In Koha to MARC mapping, find items.permanent_location and add a mapping to
952$k
3: Find a bib and item in the default framework
4: Edit the item, see that both the 952$c and 952$k are visible in the editor
-- In my test, both fields started at a value of "General Stacks"
5: change both values and save the item, confirm both values change and save
successfully -- I set 952$c to Audio Visual and 952$k to Fiction
6: edit again, change only 952$c, save -- I changed 952$c to On Display and
left 952$k set to Fiction

THIS IS WHERE THINGS GO WRONG. After saving that change, both 952$c AND 952$k
are set to On Display, even though I only changed the 952$c.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:17:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:17:34 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-Vbuuj8KaoH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #11 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
> Notes:
> - When you add a mapping: the instructions say:
> "Adding a mapping for: items.permanent_location.
> Please enter field tag and subfield code, separated by a comma. (For control
> fields: add '@' as subfield code.)
> The change will be applied immediately."
> - However, at the top of the page it says: "If you make any change to the
> mappings, you must ask your administrator to run
> misc/batchRebuildBiblioTables.pl."
> - Not sure which is right here and hwteher this shouldbe logged as a new bug.

Agreed on all of this. The format of "952,k" is confusingly nonstandard, I'd
love to see it normalized to "952$k."

I believe those two notes about immediate changes and rebuilds are meant to
convey that any mapping change will be applied to new and edited records
immediately but that existing records will need a rebuild to reflect the
change. This could certainly be explained more clearly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:25:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:25:17 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-9gpGdumgGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135748|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 137873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137873&action=edit
Bug 30909: Retain permanent_location if mapped

If items.permanent_location is mapped to a MARC subfields we must retain
the value, not using items.location

Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Change the location of the item and retain the permanent location on saving
4 - note that permanent location has not changed

Test the different other situation, when adding and editing: Empty the field,
change only location, change only permanent_location, etc.

Signed-off-by: andrew <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:25:52 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-amOHnyRa2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regression, Permanent       |Regression, Permanent
                   |shelving location is always |shelving location is always
                   |updated when editing        |updated when editing
                   |location if both are mapped |location VIA ADDITEM.PL if
                   |to MARC fields              |both are mapped to MARC
                   |                            |fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:26:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:26:00 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-tS9zSrv7cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:27:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:27:58 +0000
Subject: [Koha-bugs] [Bug 31187] New: Regression,
 Permanent shelving location is always updated when editing location
 VIA BATCH ITEM MOD if both are mapped to MARC fields
Message-ID: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187

            Bug ID: 31187
           Summary: Regression, Permanent shelving location is always
                    updated when editing location VIA BATCH ITEM MOD if
                    both are mapped to MARC fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 30909 handled this bug in the single item editor. It also exists in batch
item mod.

Same test plan applies, but use item batch modification for all of the edits:

1: create new subfield in DEFAULT framework, 952$k, visible in editor, managed
in tab 10, tied to LOC auth value
2: In Koha to MARC mapping, find items.permanent_location and add a mapping to
952$k
3: Find a bib and item in the default framework
4: Edit the item, see that both the 952$c and 952$k are visible in the editor
-- In my test, both fields started at a value of "General Stacks"
5: change both values and save the item, confirm both values change and save
successfully -- I set 952$c to Audio Visual and 952$k to Fiction
6: edit again, change only 952$c, save -- I changed 952$c to On Display and
left 952$k set to Fiction

THIS IS WHERE THINGS GO WRONG. After saving that change, both 952$c AND 952$k
are set to On Display, even though I only changed the 952$c.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:28:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:28:08 +0000
Subject: [Koha-bugs] [Bug 31187] Regression,
 Permanent shelving location is always updated when editing location
 VIA BATCH ITEM MOD if both are mapped to MARC fields
In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31187-70-yRlyikaLsO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909
[Bug 30909] Regression, Permanent shelving location is always updated when
editing location VIA ADDITEM.PL if both are mapped to MARC fields
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:28:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:28:08 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-rk35ymndCm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31187


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187
[Bug 31187] Regression, Permanent shelving location is always updated when
editing location VIA BATCH ITEM MOD if both are mapped to MARC fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:40:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:40:51 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-UgpBp2cbo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:43:09 +0000
Subject: [Koha-bugs] [Bug 31188] New: UPC or ASIN from amazon for dvd,
 music cds image
Message-ID: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

            Bug ID: 31188
           Summary: UPC or ASIN from amazon for dvd, music cds image
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julie.emond at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

We would like, in the same way as the isbn for books, that the UPC code or the
ASIN for amazon enter automatically for the display of images for dvds and
music cds. 

In short for other documents that do not have an isbn. 

On other request we see that some have briefly talked about it but no solution
except to enter the images by hand has been submitted. A gateway between amazon
and koha for the UPC code in the same way as we have a gateway for the
simagette with an ISBN.


Thank you for your help

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 16:47:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 14:47:21 +0000
Subject: [Koha-bugs] [Bug 31055] Move koha-functions to /usr/sbin instead of
 koha/bin
In-Reply-To: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31055-70-OAINtnt4Gu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055

--- Comment #10 from wajasu <matted-34813 at mypacks.net> ---
if you colocate the koha-functions.sh next to the other scripts, you can source
them path relative. But if other scripts somewhere else them, they will use
have an absolute path.

Some lib or scripts directory is definitely desired with an absolute path.

Will they be used by maintenance scripts?  That you probably don't want in
/usr/sbin.
I didn't find any currently when grepping. Most of our scripts are perl, but
these are bash shell.

A) /usr/share/koha/lib           <-- perl code
B) /usr/share/koha/lib/scripts   <-- doesn't exist yet
C) /usr/sbin                     <-- but gets out commands available in system
dir
D) /usr/share/koha/bin           <-- This is where koha-functions.sh is now.
                                  (which not on the PATH in KTD.  by design?)

I can easily test many of the koha-functions by sourcing the file from
debian/scripts and just calling them in the shell to examine $? and such.

Then I just run the cp_debian_files.pl everytime I make change.  Because the
koha-commands are sourcing the absolute path anyway.  A pain to fix/test, but
it works.

I tried to add a PREPATH inthe files/templates/defaults.env and change it in my
.env, but alas run.sh is set in stone in the image.  Making it less easy to
change (accidentall).
I was trying to put /kohadevbox/koha/debian/scripts prepended to the PATH so I
could edit/test without cp_debian_files.pl but that would only work if run.sh
had PATH=${PREPATH}:/usr/bin/usr/sbin/${PATH}:/kohadevbox/bin  and the koha-*
scripts used source ./koha-functions.sh

Maybe making it less painful to test with koha_functions.sh in the same
directory as /usr/sbin  is less clunky to fix/test and even explain an easier
test plan (without cp_debian_files.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:01:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:01:38 +0000
Subject: [Koha-bugs] [Bug 31189] New: Use different material type icon for
 LDR Pos. 6 = t - Manuscript language material
Message-ID: <bug-31189-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31189

            Bug ID: 31189
           Summary: Use different material type icon for LDR Pos. 6 = t -
                    Manuscript language material
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

It would be nice if Koha could display a specific material type icon for
manuscripts (LDR Pos. 6 = t)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:11:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:11:49 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-CUu54aAALv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrobb at sekls.org

--- Comment #3 from Jason Robb <jrobb at sekls.org> ---
This is very much needed.

We currently don't keep logs past 6 months due to our size but need to be able
to report annually on how many items each branch has weeded. The only way to do
that at present is by counting deleted items based on timestamp, so when that
table gets updated and the timestamps change, we lose the ability to accurately
retrieve that information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:15:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:15:18 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-5u4J8vWYiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:15:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:15:22 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-HKKnr0BnzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137874&action=edit
Bug 29001: Fix framework edition when subfields are reordered

There is a flaw when subfields are ordered, the inputs are not retrieved
correctly.
We should not rely on the order but use an id instead.
Test plan:
Create, edit subfields
Modify values from the different subfields
Confirm that values are correctly saved

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:15:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:15:36 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-KI2MPQjeSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|7882                        |8976
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882
[Bug 7882] Add ability to move and reorder fields and subfields in MARC editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976
[Bug 8976] Default sequence of subfields in cataloguing and item editor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:15:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:15:36 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields and
 subfields in MARC editor
In-Reply-To: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-9pDpl5v6RO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|29001                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001
[Bug 29001] Subfields attributes are not preserved when order is changed in
framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:15:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:15:36 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
 and item editor
In-Reply-To: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8976-70-8QFpjKeocc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |29001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001
[Bug 29001] Subfields attributes are not preserved when order is changed in
framework
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:29:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:29:01 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-wRJ3hRc7rK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:30:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:30:30 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-IL56OZazoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:30:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:30:34 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-lVctcQPKv6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137872|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137875&action=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:30:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:30:37 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-3Oe8dcDGH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137876&action=edit
Bug 31179: (QA follow-up) POD fix

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:30:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:30:41 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-lnMm6MqE9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137877&action=edit
Bug 31179: (QA follow-up) Set field as hidden for tests

We want the tests to pass in the case where field is set to visibile in Koha

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:50:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:50:34 +0000
Subject: [Koha-bugs] [Bug 31190] New: Add item creation date in items table
Message-ID: <bug-31190-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31190

            Bug ID: 31190
           Summary: Add item creation date in items table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In biblio table, there is a "datecreated" field, but I believe there is nothing
similar for items.
Some other ILS have a field to store the effective creation date of an item in
the system, in a non editable way, which is not the same kind of information as
items.dateaccessioned (the date of entry of an item in library's collection).

This kind of information can be useful for system administration purposes.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:52:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:52:08 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-l2KmmwuRY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha,

thanks a lot for the follow-ups! The modals look really nice now.

Found a small glitch: you cannot empty the estimated delivery date from the
modal on the basket summary page once it has been set. When emptying the field
using the red X next to the field, the field empties, but today's date will be
saved. It's always today's date, independent of the setting for the vendor.

I have created 3 orders:
2022-07-30
2022-07-19
NULL - calculated from 10 days in vendor: 2022-07-29

When I search for:
- 2022-07-01 - 2022-07-30  - OK, all show
- 2022-07-01 - 2022-07-29  - NOT OK, still all three show, but 30 should not
- 2022-07-01 - 2022-07-27  - NOT OK, 30t and 19 show, but 29, the calculated
one does not

I've tried the dd.mm.yyyy and the yyyy-mm-dd Dateformat settings and the
behaviour is the same. Can you help?

Are moddelivery.tt/.pl fallbacks for no JavaScript?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 17:58:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 15:58:56 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-PbnjiTMKVH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

--- Comment #104 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 137878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137878&action=edit
Bug 3150: (follow-up) Fix .yml formatting

 FAIL     yaml_valid
 YAML::XS::Load Error: The problem:      did not find expected key  was found
at document: 1, line: 1748, column: 1 while parsing a block mapping at line:
23, column: 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 18:44:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 16:44:32 +0000
Subject: [Koha-bugs] [Bug 29446] Add ability to delete image from item edit
 drop down
In-Reply-To: <bug-29446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29446-70-7aVCtqgZ2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29446

--- Comment #1 from Esther Melander <estherm at sodaspringsid.com> ---
After filing this bug it appears there is a way to delete item images without
having to go through the tools/upload menu. Unfortunately it is not intuitive -
you have to know it is there. Currently, you have to click on the item image
and the delete image option is in the lower left corner. It would still be
helpful to have the option to delete the image from the edit button dropdown.
It was the first placed I looked for it and could not find it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 19:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 17:02:26 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-rZo3Q7Qeai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #100 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #99)
> May need to be investigated before push.

In comment 81 the cause was deemed to be an invalid MARC record. However, as
this breaks the development setup, and the automated test server / jenkins I
presume, then to me this is FQA. We need to provide a patch along with this
change that removes the invalid MARC record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 19:11:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 17:11:05 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-HIOXuUzNmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> ---
Marcel,

Is this ready for testing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 19:23:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 17:23:50 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-r8qCR2C2m5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #101 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Joonas Kylmälä from comment #100)
> (In reply to Jonathan Druart from comment #99)
> > May need to be investigated before push.
> 
> In comment 81 the cause was deemed to be an invalid MARC record. However, as
> this breaks the development setup, and the automated test server / jenkins I
> presume, then to me this is FQA. We need to provide a patch along with this
> change that removes the invalid MARC record.

This is actually a behavior change we need to address on this patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:02:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:02:23 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-OyfOo7jyoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137879&action=edit
Bug 30933: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:02:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:02:31 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-aeqYBrRrER@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137880&action=edit
Bug 30933: Add lists methods for disowning

This patch aims to tidy things a bit by doing the following changes:

* Koha::Virtualshelf gets the 'transfer_ownership' method
* Koha::Virtualshelves gets the 'disown_or_delete' method
* Koha::Patron->delete gets rewritten/simplified by using
  disown_or_delete

The idea is to capture the current behavior in more fine grained
methods. So current tests should be passing as they do now.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run:
  k$ prove t/db_dependent/Koha/Virtualshelf.t \
           t/db_dependent/Koha/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:03:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:03:59 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-7wex8LAtPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off
                 CC|                            |tomascohen at gmail.com

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
@Marcel and @Martin. Please review my follow-ups. I'll push the tree if we
agree with them. Would like your signature, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:05:15 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-rS3S3voEZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:07:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:07:06 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-0tQvy2P0B6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:07:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:07:13 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-YljlUwjKWk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137875|0                           |1
        is obsolete|                            |

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137881&action=edit
Bug 31179: Don't copy invisible subfields when duplicating items

Duplicate item is intended to duplicate the visible cataloging fields of an
item, however,
currently it is duplicating the complete internal record of the item

To recreate:
1 - find an item in Koha staff client, copy the barcode
2 - Issue this item to a patron
3 - Return to the record
4 - Edit items
5 - Click 'Actions->Duplicate' for the item in question
6 - Save the item
7 - Note in the items table above for that 'Total checkouts' 'Due date'
 etc. have not been copied to new item

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:07:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:07:19 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-ZTrJcpf69y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137876|0                           |1
        is obsolete|                            |

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137882&action=edit
Bug 31179: (QA follow-up) POD fix

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:07:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:07:24 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-c9gl2AfAqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137877|0                           |1
        is obsolete|                            |

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137883&action=edit
Bug 31179: (QA follow-up) Set field as hidden for tests

We want the tests to pass in the case where field is set to visibile in Koha

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:21:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:21:13 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-87lQy9e5r0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:21:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:21:18 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-hZ2iKqnkGV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137873|0                           |1
        is obsolete|                            |

--- Comment #13 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137884&action=edit
Bug 30909: Retain permanent_location if mapped

If items.permanent_location is mapped to a MARC subfields we must retain
the value, not using items.location

Test plan:
1 - Map permanent_location to a marc field
2 - Expose that field in the item editor
3 - Change the location of the item and retain the permanent location on saving
4 - note that permanent location has not changed

Test the different other situation, when adding and editing: Empty the field,
change only location, change only permanent_location, etc.

Signed-off-by: andrew <andrewfh at dubcolib.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 20:24:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 18:24:26 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-CJrQKrRHyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #14 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Fixes the issue as advertised, passing QA.

On an unrelated note whilst testing this bug I noticed that we seem to have a
cache invalidation problem with Koha to MARC mapping. After removing the 952$k
mapping to items.permanent_location I had to restart all koha services (i guess
memcached would have been plenty) for the functionality to return to original,
that is, when location is updated also permanent_location is updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:13:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:13:46 +0000
Subject: [Koha-bugs] [Bug 31191] New: Specify FacetLabelTruncationLength is
 only for Zebra
Message-ID: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

            Bug ID: 31191
           Summary: Specify FacetLabelTruncationLength is only for Zebra
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When using ElasticSearch, the FacetLabelTruncationLength system preference
doesn't apply. I don't know if it's a bug or by design. Maybe it should be
indicated in the syspref description that it only works with Zebra?

To test:
1) Change the searchengine syspref to Zebra
2) Reindex
3) Do a search
4) Check the facets
   --> The longer ones should be truncated to 20 characters
5) Change the seachengin syspref to Elasticsearch
6) Redo steps 2-4
   --> The longer facets are displayed in full

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:15:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:15:12 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-cjL6IdZmrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137885&action=edit
Screenshot of facets with Zebra

This is a screenshot of facets with Zebra. Note that the longer ones are
truncated with an ellipsis, e.g. "Association for Scot..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:16:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:16:14 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-Q16hkKSp4p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137886&action=edit
Screenshot of facets with Elasticsearch

This is a screenshot of facets with Elasticsearch. Note that the longer ones
are there in full, e.g. "Association for Scottish Literary Studies"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:18:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:18:06 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-GsyG3lnfzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
In my test, I did not change the FacetLabelTruncationLength system preference
when I changed search engines. 

I also did not specify staff interface or OPAC, but it does the same thing in
both interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:25:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:25:00 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-kIZvKr0zW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:25:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:25:03 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-jhNn67TVsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 137887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137887&action=edit
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra

This patch adds a note in the description of FacetLabelTruncationLength
that it only works with Zebra.

To test:
0) Apply patch
1) Go to Administration > Global system preference > Searching
preferences
2) Search for FacetLabelTruncationLength
3) Read the description, make sure it indicates that is requires Zebra

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:25:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:25:48 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-khJyDAJa5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I changed the .pref file, I'm not sure if that's where it's changed or if it's
the only place... Let me know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:40:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:40:01 +0000
Subject: [Koha-bugs] [Bug 31192] New: Checking in an unkown barcode causes
 error
Message-ID: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

            Bug ID: 31192
           Summary: Checking in an unkown barcode causes error
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Can't call method "is_bundle" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 413

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:40:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:40:19 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-TYqFAQK2TQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854
[Bug 28854] Add ability to create bundles of items for circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 21:40:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 19:40:19 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-KGDwsUJs1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31192


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192
[Bug 31192] Checking in an unkown barcode causes error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 22:53:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 20:53:27 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-iaPtTS9lMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 22:53:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 20:53:30 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-eQssFmNyjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137849|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 137888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137888&action=edit
Bug 30858: Add serial enumeration/chronology to item search

To test:
1. Apply patch
2. Go to  Catalog > Item search and do a search for items that you know contain
a items.enumchron
3. The result set should now show the items.enumchron
4. Make sure you can properly "Export results to.."

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 22:53:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 20:53:34 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-t84EOuRWYh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137850|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 137889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137889&action=edit
Bug 30589: (follow-up) Add enumchron to CSV export and fix CSS class

https://bugs.koha-community.org/show_bug.cgi?id=30858

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 22:57:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 20:57:35 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-WFHXPvxUIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement to the
      release notes|                            |item search in the staff
                   |                            |interface adds a serial
                   |                            |enumeration/chronology
                   |                            |(952$h) column to the
                   |                            |search results and export.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 23:10:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 21:10:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-7p3COYSGkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

knmartinez at santafenm.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |knmartinez at santafenm.gov

--- Comment #118 from knmartinez at santafenm.gov ---
Addressing accessibility concerns presented by others, I have to second this.
If categories on the home page are no longer neatly grouped, navigation and
orientation will take longer and I anticipate my staff having difficulty with
this. In present format, eyes do tend to drift across the page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 23:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 21:40:03 +0000
Subject: [Koha-bugs] [Bug 31068] Context for translation: Print (verb) vs.
 Print (noun)
In-Reply-To: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31068-70-ZilqaV9gf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31068

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds
      release notes|                            |context for translation
                   |                            |purposes to the term
                   |                            |'Print' for notices and
                   |                            |slips message transport
                   |                            |types (email, print, SMS).
                   |                            |(In English, the word
                   |                            |"print" is the same whether
                   |                            |it is a verb (to print
                   |                            |something) or a noun (a
                   |                            |print of something),
                   |                            |however, for other
                   |                            |languages different words
                   |                            |may be used. When the word
                   |                            |is in a sentence, it's not
                   |                            |too difficult to translate,
                   |                            |but in cases where the
                   |                            |string to translate is
                   |                            |simply "Print", it is often
                   |                            |used in different cases
                   |                            |(noun or verb). For
                   |                            |example: in French there
                   |                            |are two different
                   |                            |spellings, "Imprimer" or
                   |                            |"Imprimé".)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 23:43:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 21:43:54 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-z2MkpNthPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement adds       |This enhancement adds
      release notes|information about           |information about
                   |non-indexed records when    |non-indexed records when
                   |using the Elasticsearch     |using the Elasticsearch
                   |search engine on the About  |search engine on the About
                   |Koha > System information   |Koha > System information
                   |page.
                      |page.
                   |
                           |
                   |For example:
               |For example:
                   |                            |
                   |Records are missing in      |Records are not indexed in
                   |Elasticsearch search engine |Elasticsearch
                   |- Warning  1 record(s)      |- Warning 1
                   |missing on a total of 435   |record(s) missing on a
                   |in indice                   |total of 435 in index
                   |koha_kohadev_biblios.
      |koha_kohadev_biblios.record
                   |-                           |(s).
                   |Warning  1 record(s)        |- Warning 1 record(s)
                   |missing on a total of 1705  |missing on a total of 1705
                   |in indice                   |in index
                   |koha_kohadev_authorities.   |koha_kohadev_authorities.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 23:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 21:49:58 +0000
Subject: [Koha-bugs] [Bug 31071] Regression: date due removed from staff
 search results
In-Reply-To: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31071-70-o9ppJFQRtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31071

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes a regression
      release notes|                            |introduced in Koha 21.11
                   |                            |that inadvertently removed
                   |                            |the date due in the staff
                   |                            |interface search results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 19 23:55:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 21:55:06 +0000
Subject: [Koha-bugs] [Bug 30882] Add max_result_window to index config
In-Reply-To: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30882-70-yyRhgyX5Kg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This updates the number of
      release notes|                            |results set by default in
                   |                            |Elasticsearch for the
                   |                            |setting
                   |                            |"index.max-result-window"
                   |                            |from  10,000 to 1,000,000.
                   |                            |This can be useful for
                   |                            |really large catalogs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:06:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:06:21 +0000
Subject: [Koha-bugs] [Bug 31184] Add default permissions by patron category
In-Reply-To: <bug-31184-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31184-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31184-70-66Tqda5X95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31184

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:14:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:14:45 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-C0jxdC63Rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:14:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:14:50 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-dAVzodnTFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137818|0                           |1
        is obsolete|                            |

--- Comment #26 from David Nind <david at davidnind.com> ---
Created attachment 137890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137890&action=edit
Bug 30280: Add a new mapping authority marc field 040\$f

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:14:55 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-tSc1SEro7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137819|0                           |1
        is obsolete|                            |

--- Comment #27 from David Nind <david at davidnind.com> ---
Created attachment 137891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137891&action=edit
Bug 30280: Handle subject headings from differens thesaurus

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:15:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:15:01 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-ZrBZm1RrM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137820|0                           |1
        is obsolete|                            |

--- Comment #28 from David Nind <david at davidnind.com> ---
Created attachment 137892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137892&action=edit
Bug 30280: Removing tab character in Heading.pm

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 00:56:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 22:56:28 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-ltkgkM2Avw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds
      release notes|                            |support for displaying and
                   |                            |linking to subject headings
                   |                            |from different thesaurus
                   |                            |when using Elasticsearch.
                   |                            |The thesaurus used for the
                   |                            |term is added to the
                   |                            |authority record using
                   |                            |040$f. For the
                   |                            |bibliographic record, set
                   |                            |the second indicator to 7
                   |                            |for 650 and add the source
                   |                            |to 650$2. For local terms,
                   |                            |use 4 (Source not
                   |                            |specified) as the
                   |                            |indicator.
                   |                            |
                   |                            |Example for a
                   |                            |bibliographic record:
                   |                            |
                   |                            |650
                   |                            |_ 0 $a Feminism
                   |                            |650 _ 7 $a
                   |                            |Feminism $2 sao
                   |                            |650 _ 7 $a
                   |                            |Feminism $2 barn
                   |                            |
                   |                            |The first
                   |                            |example above is the LCSH
                   |                            |term. The other two terms
                   |                            |are from sao (controlled
                   |                            |Swedish subject heading
                   |                            |system) and barn (Swedish
                   |                            |children subject heading
                   |                            |system). These three are
                   |                            |using the same TOPIC_TERM
                   |                            |Feminism, but they belong
                   |                            |to different thesaurus.

--- Comment #29 from David Nind <david at davidnind.com> ---
(In reply to Frank Hansen from comment #25)
> I fixed the mapping issue

Thanks Frank!

I have re-tested and signed off.

Re replies on comment #21 - thanks for the explanations for my footnote [3]. I
also didn't get the error message mentioned in my footnote [1] this time, so
not sure what was going on whenI orginally tested this...

The QA Team may ask you to amend the patches as per the commit message
guidelines https://wiki.koha-community.org/wiki/Commit_messages

I've had a go at the text for the release note, feel free to update it as I'm
not sure I've described this correctly.

Test plan:
1. Enable Elasticsearch as the search engine (SearchEngine system preference =
Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev).
2. Load sample authority records attached to the bug (in this case the
authorities.mrc file was saved in the koha directory - adjust file location as
appropriate):
   misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21
3. Load the sample bibliographic record attached to the bug:
   misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert
-c=MARC21
4. Search for ISBN 0704328623 and verify that the subject terms are not linked
to any authority records (if you hover over the link terms, all links should
look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should
have any ?q=an:XXX (where XXX = authority record ids) in the link).
5. Apply the patches.
6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch)).
7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
8. Link bibliographic records to authority records:
misc/link_bibs_to_authorities.pl -v -l
9. Repeat the search in step 4 (or refresh the record details page) and verify
that the first three Feminism headings[1] are linked to an authority record
(should have ?q=an:XXX (where XXX = different authority record IDs for the
various feminism authority records linked to a specific thesaurus)).
10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

[1] Links for subject terms for step 9 in order are (the authority ids may be
different depending on how ou are testing):

    Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria |
Litteratur

    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"

    MARC info:

    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
      0 Authority record control number or standard number
https://id.kb.se/term/sao/Feminism
      2 Source of heading or term sao
    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element feminism
      2 Source of heading or term bnb
    650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Idéhistoria
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Litteratur

   Note: The fourth Feminism term has second indicator 4 which means "Source
not specified". So this term is only a local term and does not belong to any
specific thesaurus and thus not linked. To specify a source of a term, the
second indicator must be set as 7. The source of heading is then specified in
subfield 2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 01:36:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 23:36:02 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-Bw6VYvX2AG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Thibault Keromnès <thibault.keromnes at univ-paris8.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thibault.keromnes at univ-pari
                   |                            |s8.fr
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Thibault Keromnès <thibault.keromnes at univ-paris8.fr> ---
The patch fixes the issue but brings another one, I can't mark a subfield as
repeatable now (if i check the 3 attributes and save the subfield will be
mandatory and important but not repeatable). 
I don't have this issue with the current master.

I change the status to failed QA, not sure it's the right one, feel free to
change it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 01:53:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Jul 2022 23:53:24 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-U7GFcH8NVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
Some day, it would be nice to make about.pl use more asynchronous calls. 

I often look at about.pl when I want to double-check a Koha instance's version
and it takes so long to load these days...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 02:40:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 00:40:09 +0000
Subject: [Koha-bugs] [Bug 31188] UPC or ASIN from amazon for dvd,
 music cds image
In-Reply-To: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31188-70-ldVm6IiIJK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
The cover images code could really use some improvements more generally I think
but I think it would take a sponsored effort to do it.

With the UPC, you could use "024$a1234$2upc" from a data point of view, and
then update the code to handle that case. 

Using the ASIN would be harder... since asin/Amazon isn't a standard code for
the 024 $2 subfield (which is interesting since "spotify" is so clearly there
are some fairly recent codes in there)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 06:38:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 04:38:49 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-lSeHNpzdh7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 07:34:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 05:34:28 +0000
Subject: [Koha-bugs] [Bug 31193] New: API error when receiving orders
Message-ID: <bug-31193-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31193

            Bug ID: 31193
           Summary: API error when receiving orders
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

We've noticed that when receiving orders, we can't seem to filter the results
using the search boxes in the pending orders table.

When we type in the 'summary search' filter for example, this error shows in
the console:

GET
https://toi-ohomai-admin.test.mykoha.co.nz/api/v1/acquisitions/orders?only_active=1&_page=1&_per_page=20&_match=contains&_order_by=+basket.name
[HTTP/1.1 500 Internal Server Error 173ms]
DataTables warning: table id=pending_orders - Ajax error. For more information
about this error, please see http://datatables.net/tn/7

And the API error log shows:

[2022/07/20 16:02:28] [ERROR] GET /api/v1/acquisitions/orders: unhandled
exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute():
DBI Exception: DBD::mysql::st execute failed: Unknown column 'biblioitem.title'
in 'where clause' at /usr/share/perl5/Data/Page.pm line 50>>
Koha::REST::Plugin::Exceptions::ANON
/usr/share/koha/lib/Koha/REST/Plugin/Exceptions.pm (73)

The biblioitem.title field doesn't exist. I imagine this is something to do
with the code in Koha/REST/V1/Acquisitions/Orders.pm

Can anyone else reproduce this bug? Do we know a fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 08:33:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 06:33:00 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-2rIGNCadCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 08:33:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 06:33:04 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-bpCO6r2z7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137874|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137893&action=edit
Bug 29001: Fix framework edition when subfields are reordered

There is a flaw when subfields are ordered, the inputs are not retrieved
correctly.
We should not rely on the order but use an id instead.
Test plan:
Create, edit subfields
Modify values from the different subfields
Confirm that values are correctly saved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 08:33:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 06:33:40 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-qIc8z1fT0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Thibault Keromnès from comment #3)
> The patch fixes the issue but brings another one, I can't mark a subfield as
> repeatable now (if i check the 3 attributes and save the subfield will be
> mandatory and important but not repeatable). 
> I don't have this issue with the current master.
> 
> I change the status to failed QA, not sure it's the right one, feel free to
> change it.

Indeed, thanks! Should be fixed now.

Yes, Failed QA is the correct status when the patch does not work as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:04:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:04:15 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-Y01KRsuDzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #102 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137894&action=edit
Bug 29697: Don't crash ES reindex if a record is wrong

We don't want rebuild_elasticsearch.pl to crash if a record is wrong
(also fix ktd setup).
Note that now the script will output an error for the problematic
record, which is certainly the expected behaviour as we are doing it
already for authority records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:05:04 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-tupP9plfne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:06:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:06:02 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-q7zilP06uj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #103 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Last patch would benefit from a QA review but I don't want to set the status
back to NQA and lose it for weeks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:21:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:21:52 +0000
Subject: [Koha-bugs] [Bug 31032] Patron attributes branch limitations are
 unclear
In-Reply-To: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31032-70-PxQVixCjSg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31032

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the question was "patron's home library" or "staff user's logged in
library", but it appears that 'logged in library' is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:22:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:22:28 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-JI7kOygLjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Joonas Kylmälä from comment #14)
> Fixes the issue as advertised, passing QA.
> 
> On an unrelated note whilst testing this bug I noticed that we seem to have
> a cache invalidation problem with Koha to MARC mapping. After removing the
> 952$k mapping to items.permanent_location I had to restart all koha services
> (i guess memcached would have been plenty) for the functionality to return
> to original, that is, when location is updated also permanent_location is
> updated.

I guess it's because we are flushing the marc structure for the default
framework only in admin/koha2marclinks.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:35:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:35:50 +0000
Subject: [Koha-bugs] [Bug 31194] New: koha-marc mappings not invalidated in
 cache
Message-ID: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

            Bug ID: 31194
           Summary: koha-marc mappings not invalidated in cache
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The cache is cleared for the default framework, but the mapping can be read
from another framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:36:07 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-CxV9iALaiz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Coming from bug 30909 comment 14.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:36:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:36:14 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-oOlJPUVrfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:36:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:36:21 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-ROLZdJh1xu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31194

--- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Opened bug 31194.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:36:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:36:22 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-meLd8zXKPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30909

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:37:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:37:29 +0000
Subject: [Koha-bugs] [Bug 31195] New: "Tied interface" from Koha::Cache is
 not used
Message-ID: <bug-31195-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31195

            Bug ID: 31195
           Summary: "Tied interface" from Koha::Cache is not used
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This is an old implementation of the caching system, but we are no longer using
it. We should remove it to prevent confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:38:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:38:33 +0000
Subject: [Koha-bugs] [Bug 31196] New: Key "default_value_for_mod_marc-"
 cleared from cache but never set
Message-ID: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196

            Bug ID: 31196
           Summary: Key "default_value_for_mod_marc-" cleared from cache
                    but never set
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We are seeing the following lines several times in the codebase
  $cache->clear_from_cache("default_value_for_mod_marc-");

But values are never set for this key.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:56:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:56:23 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-EV8GXdkXgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hum, I am not sure what is the best here.

The original problem is that the koha-MARC mapping is not updated when
adding/editing items.

So this may be a regression coming from bug 27526, where we are now using the
marc subfield structure (mss) from the biblio to retrieve the mapping
(kohafield). And before we were calling C4::Biblio::GetMarcFromKohaField.

Either 1. we consider that the kohafield can be retrieved from any mss in
cache, or 2. we force the fetch to be done using GetMarcFromKohaField.

2. is easier to implement, 1. is preventing us from hitting the same problem in
the future (and certainly better for perfs but nothing bad as
GetMarcFromKohaField is cached).

What's your call?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:56:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:56:30 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-66sd5HOCvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:56:52 +0000
Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared
 from cache but never set
In-Reply-To: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31196-70-lqZlLXpBbZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31194

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:56:52 +0000
Subject: [Koha-bugs] [Bug 31195] "Tied interface" from Koha::Cache is not
 used
In-Reply-To: <bug-31195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31195-70-GaKieMqoX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31195

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31194

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:56:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:56:52 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-Oj8CuDNNUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31195,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31196

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:57:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:57:31 +0000
Subject: [Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in
 batch patron modification breaks the form sending
In-Reply-To: <bug-30884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30884-70-ZvRKb1C4A3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
This one was actually reverted on 21.11.10, I didn't reproduced the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:59:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:59:13 +0000
Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared
 from cache but never set
In-Reply-To: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31196-70-LTtUbJMGQX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 09:59:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 07:59:16 +0000
Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared
 from cache but never set
In-Reply-To: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31196-70-rOiyCtz7KG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137895&action=edit
Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls

We are seeing the following lines several times in the codebase
  $cache->clear_from_cache("default_value_for_mod_marc-");

But values are never set for this key.

Test plan:
Ask you, "Is the above correct?"
Use the correct 'git grep' and 'git log' and confirm the assertion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:00:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:00:16 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-EAESAiD5yK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
For 1. we need a separate cache for biblio frameworks that we could fully
cleared when they are modified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:31:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:31:10 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-r06C84TaOf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137896&action=edit
Bug 31192: Check for item before calling is_bundle

The code in here is weird.. we really aught to check for the item before
anything else and throw an error to screen if we don't find one... but
my patch takes the simple option, and the one taken elsewhere in the
script.. to just check for item being defined before calling a method
upon it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:31:31 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-WGd6ueB6x9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:34:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:34:39 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-WbeXJqskYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #30 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137897&action=edit
Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions
(new) authority mapping index field (MARC21)

This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions
authority index mapping.

To test:
1) Apply patch
2) Reindex using rebuild_elasticsearch.pl -r

If you don't have access to a terminal (in a sandbox for example)
2a) Go to Administration > Search engine configuration, click "Reset mappings"
and confirm
2b) Then reindex

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:34:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:34:43 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-pLygOnW0ri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #31 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137898&action=edit
30280: Add support for subject headings from different thesaurus when using
Elasticsearch

This patch allows subject headings from different thesaurus to co-exist in
Koha.

Test plan:
1. Enable Elasticsearch as the search engine (SearchEngine system preference =
Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev).
2. Load sample authority records attached to the bug (in this case the
authorities.mrc file was saved in the koha directory - adjust file location as
appropriate):
   misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21
3. Load the sample bibliographic record attached to the bug:
   misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert
-c=MARC21
4. Search for ISBN 0704328623 and verify that the subject terms are not linked
to any authority records (if you hover over the link terms, all links should
look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should
have any ?q=an:XXX (where XXX = authority record ids) in the link).
5. Apply the patches.
6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch)).
7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
8. Link bibliographic records to authority records:
misc/link_bibs_to_authorities.pl -v -l
9. Repeat the search in step 4 (or refresh the record details page) and verify
that the first three Feminism headings[1] are linked to an authority record
(should have ?q=an:XXX (where XXX = different authority record IDs for the
various feminism authority records linked to a specific thesaurus)).
10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

[1] Links for subject terms for step 9 in order are (the authority ids may be
different depending on how ou are testing):

    Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria |
Litteratur

    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"

    MARC info:

    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
      0 Authority record control number or standard number
https://id.kb.se/term/sao/Feminism
      2 Source of heading or term sao
    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element feminism
      2 Source of heading or term bnb
    650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Idéhistoria
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Litteratur

   Note: The fourth Feminism term has second indicator 4 which means "Source
not specified". So this term is only a local term and does not belong to any
specific thesaurus and thus not linked. To specify a source of a term, the
second indicator must be set as 7. The source of heading is then specified in
subfield 2.

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:34:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:34:48 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-84KB1ShsRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #32 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137899&action=edit
Bug 30280: (follow-up) Removing tab character in Heading.pm

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:36:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:36:30 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-M5p03ANEJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

Frank Hansen <frank.hansen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137890|0                           |1
        is obsolete|                            |
 Attachment #137891|0                           |1
        is obsolete|                            |
 Attachment #137892|0                           |1
        is obsolete|                            |
 Attachment #137897|0                           |1
        is obsolete|                            |
 Attachment #137898|0                           |1
        is obsolete|                            |
 Attachment #137899|0                           |1
        is obsolete|                            |

--- Comment #33 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137900&action=edit
Bug 30280: Elasticsearch - Add 040f to Subject-heading-thesaurus-conventions
(new) authority mapping index field (MARC21)

This patch adds 040 $f to a new field Subject-heading-thesaurus-conventions
authority index mapping.

To test:
1) Apply patch
2) Reindex using rebuild_elasticsearch.pl -r

If you don't have access to a terminal (in a sandbox for example)
2a) Go to Administration > Search engine configuration, click "Reset mappings"
and confirm
2b) Then reindex

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:36:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:36:35 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-wOkvTHUx5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #34 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137901&action=edit
30280: Add support for subject headings from different thesaurus when using
Elasticsearch

This patch allows subject headings from different thesaurus to co-exist in
Koha.

Test plan:
1. Enable Elasticsearch as the search engine (SearchEngine system preference =
Elasticsearch) and reindex (koha-elasticsearch --rebuild -d -b -a kohadev).
2. Load sample authority records attached to the bug (in this case the
authorities.mrc file was saved in the koha directory - adjust file location as
appropriate):
   misc/migration_tools/bulkmarcimport.pl -v -a -file authorities.mrc -insert
-c=MARC21
3. Load the sample bibliographic record attached to the bug:
   misc/migration_tools/bulkmarcimport.pl -v -b -file biblios.mrc -insert
-c=MARC21
4. Search for ISBN 0704328623 and verify that the subject terms are not linked
to any authority records (if you hover over the link terms, all links should
look like ../cgi-bin/koha/catalogue/search.pl?q=su:"subjectterm" - none should
have any ?q=an:XXX (where XXX = authority record ids) in the link).
5. Apply the patches.
6. Reset the Elasticsearch mappings (Administration > Catalog > Search engine
configuration (Elasticsearch)).
7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev
8. Link bibliographic records to authority records:
misc/link_bibs_to_authorities.pl -v -l
9. Repeat the search in step 4 (or refresh the record details page) and verify
that the first three Feminism headings[1] are linked to an authority record
(should have ?q=an:XXX (where XXX = different authority record IDs for the
various feminism authority records linked to a specific thesaurus)).
10. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev

[1] Links for subject terms for step 9 in order are (the authority ids may be
different depending on how ou are testing):

    Subject(s:) Feminism | feminism | Feminism | Feminism | Idéhistoria |
Litteratur

    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1709
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1710
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=an:1708
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Feminism"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Idéhistoria"
    http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?q=su:"Litteratur"

    MARC info:

    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
      0 Authority record control number or standard number
https://id.kb.se/term/sao/Feminism
      2 Source of heading or term sao
    650 #7 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element feminism
      2 Source of heading or term bnb
    650 #0 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Feminism
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Idéhistoria
    650 #4 - SUBJECT ADDED ENTRY--TOPICAL TERM
      a Topical term or geographic name entry element Litteratur

   Note: The fourth Feminism term has second indicator 4 which means "Source
not specified". So this term is only a local term and does not belong to any
specific thesaurus and thus not linked. To specify a source of a term, the
second indicator must be set as 7. The source of heading is then specified in
subfield 2.

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:36:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:36:39 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-A58UDVCWuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #35 from Frank Hansen <frank.hansen at ub.lu.se> ---
Created attachment 137902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137902&action=edit
Bug 30280: (follow-up) Removing tab character in Heading.pm

Sponsored-by: Lund University Library, Sweden

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:48:40 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-JCmZXE2NtW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137896|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137903&action=edit
Bug 31192: Check for item before calling is_bundle

The code in here is weird.. we really aught to check for the item before
anything else and throw an error to screen if we don't find one... but
my patch takes the simple option, and the one taken elsewhere in the
script.. to just check for item being defined before calling a method
upon it.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:50:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:50:40 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-H6LXKsxXLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
The patch fixes the reported problem, signing off.  Thanks for the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:52:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:52:00 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-ay5n2OlHhG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #36 from Frank Hansen <frank.hansen at ub.lu.se> ---
(In reply to David Nind from comment #29)
> (In reply to Frank Hansen from comment #25)

Thanks David.

> > I fixed the mapping issue
> 
> The QA Team may ask you to amend the patches as per the commit message
> guidelines https://wiki.koha-community.org/wiki/Commit_messages
I have modified the commit messages a little bit. I used your Test plan. So I
hope it looks better now. 

> 
> I've had a go at the text for the release note, feel free to update it as
> I'm not sure I've described this correctly.
I think the release notes well explain what the enhancement is about. I haven't
changed anything it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:56:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:56:49 +0000
Subject: [Koha-bugs] [Bug 30280] Koha does not currently support authority
 records with common subject headings from different thesaurus
In-Reply-To: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30280-70-ScoPOXczcF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30280

--- Comment #37 from David Nind <david at davidnind.com> ---
(In reply to Frank Hansen from comment #36)

Excellent! 

Good luck for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:56:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:56:57 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-of6LTTY7Sa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137893|0                           |1
        is obsolete|                            |

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137904&action=edit
Bug 29001: Fix framework edition when subfields are reordered

There is a flaw when subfields are ordered, the inputs are not retrieved
correctly.
We should not rely on the order but use an id instead.
Test plan:
Create, edit subfields
Modify values from the different subfields
Confirm that values are correctly saved

Signed-off-by: Thibault Kero <thibault.keromnes at univ-paris8.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 10:57:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 08:57:59 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-Sd8Mzf23Lk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Thibault Keromnès <thibault.keromnes at univ-paris8.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:21:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:21:56 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-x6hrfFsDGZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132976|0                           |1
        is obsolete|                            |

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137905&action=edit
Bug 30458:- Librarian ( manager_id ) not included in accountline when using
"Payout amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:27:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:27:30 +0000
Subject: [Koha-bugs] [Bug 15165] REST API routes to list,
 edit and pay borrower's accountlines
In-Reply-To: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15165-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15165-70-r1w6Jy9b5o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165

--- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like we now have routes for listing and creating credits (including
payment). So we might only miss creating debits?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:29:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:29:13 +0000
Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's
 account
In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21043-70-2x9F0f4h1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:29:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:29:49 +0000
Subject: [Koha-bugs] [Bug 3758] Automatic update of exchange rates
In-Reply-To: <bug-3758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3758-70-P3U0h6PruO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3758

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like this has been abandoned, any chance to pick it up again?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:32:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:32:21 +0000
Subject: [Koha-bugs] [Bug 25656] Allow entering of currency rate to use when
 receiving and ordering in acq
In-Reply-To: <bug-25656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25656-70-DDBnTXuoVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25656

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:32:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:32:45 +0000
Subject: [Koha-bugs] [Bug 25655] Additionally store actual cost in foreign
 currency, currency and currency rate used
In-Reply-To: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25655-70-1nGWIfLN6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:33:15 +0000
Subject: [Koha-bugs] [Bug 24971] Pre-select invoice currency from vendor on
 receive
In-Reply-To: <bug-24971-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24971-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24971-70-9TJh6IOMGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24971

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:33:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:33:45 +0000
Subject: [Koha-bugs] [Bug 18412] Show list price in foreign currency in
 acquisitions
In-Reply-To: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18412-70-rwqUkQnMJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:34:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:34:07 +0000
Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating
 shipping cost
In-Reply-To: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12967-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12967-70-z9ZybORrBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:34:35 +0000
Subject: [Koha-bugs] [Bug 20354] Add ability for patrons to set their
 preferred currency
In-Reply-To: <bug-20354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20354-70-nJ5lnPVl1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20354

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability for patrons to  |Add ability for patrons to
                   |set theirs preferred        |set their preferred
                   |currency                    |currency

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:37:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:37:48 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-KyKb2HcvMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I can replicate on master (the manager_id shows if 'issue payout' is used on
the individual line, but doesn't show if the 'payout amount' button at the
bottom of the lines is used).  

After replicating the bug, I've tested the patch and it works - so signing off.
 Thanks for the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:39:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:39:12 +0000
Subject: [Koha-bugs] [Bug 12146] Add new ISO code column to currency sample
 files
In-Reply-To: <bug-12146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12146-70-r364Th71He@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:40:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:40:46 +0000
Subject: [Koha-bugs] [Bug 6514] Save book price in different currencies
 (cataloging)
In-Reply-To: <bug-6514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6514-70-ZlBRAlQXrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6514

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The price field in the item record can only take amounts that are formatted
correctly, as the corresponding field in the database is decimal. I think if we
need to store the currency, we'd need a separate field for it to avoid problems
with calculations etc. in SQL reports.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:44:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:44:38 +0000
Subject: [Koha-bugs] [Bug 20118] System picks Active currency by default
 while adding suggestion to vendor
In-Reply-To: <bug-20118-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20118-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20118-70-hRaEL5Kq91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20118

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid on current master. The currency selected on the suggestion form is
not used on ordering leading to wrong price calculations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:45:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:45:48 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-WwaEOCk41K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:48:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:48:26 +0000
Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history
In-Reply-To: <bug-7571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7571-70-DK3NDSQF4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18157 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:48:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:48:26 +0000
Subject: [Koha-bugs] [Bug 18157] Forex rates for India based on GOC rates
 need support in the ACQ module
In-Reply-To: <bug-18157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18157-70-nfzHppDw0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is a partial dupclicate to each of those bugs:

* Bug 7571 - Maintain exchange rate history
* Bug 3758 - Automatic update of exchange rates

Koha doesn't care what rates you use, so using the GOC rates should be
possible, but it might need to be taken into account if updating rates is
automated as an additional option (depending on the availability of web
services)

*** This bug has been marked as a duplicate of bug 7571 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:51:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:51:04 +0000
Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's
 account
In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21043-70-VGJjg9aOeX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is certainly a need for this to be able to add charges to the patron
accounts from other library services/web applications. An example would be a
print management software where the user is charged for the number of
printouts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 11:54:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 09:54:02 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-ZyuC7rrBmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sally from comment #5)
> I can replicate on master (the manager_id shows if 'issue payout' is used on
> the individual line, but doesn't show if the 'payout amount' button at the
> bottom of the lines is used).  
> 
> After replicating the bug, I've tested the patch and it works - so signing
> off.  Thanks for the patch.

Thanks for testing, Sally! (in general, but for this one too)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 12:02:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 10:02:16 +0000
Subject: [Koha-bugs] [Bug 31189] Use different material type icon for LDR
 Pos. 6 = t - Manuscript language material
In-Reply-To: <bug-31189-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31189-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31189-70-TAlCr2DnAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31189

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We discussed this with a library and they picked the book_edit icon from the
famfamfam Silk icon set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 12:02:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 10:02:57 +0000
Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history
In-Reply-To: <bug-7571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7571-70-ev3hsg9gxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 12:06:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 10:06:52 +0000
Subject: [Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more
 than 20 items on the return screen
In-Reply-To: <bug-30802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30802-70-e9nQM1TPKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
(In reply to Caroline Cyr La Rose from comment #2)
> I tested in a sandbox in case it was my installation that was acting up, and
> the sandbox is limited to 14, completely ignoring the value in
> numReturnedItemsToShow (which was set to 20 by default). Even after I
> changed the pref to 50, the returns.pl page only shows 14.

I found the same whilst testing on a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:03:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:03:29 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-pg11torrY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Lucas Gass from comment #20)
> Marcel,
> 
> Is this ready for testing?

No, not yet. I still have a unfinished development for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:03:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:03:39 +0000
Subject: [Koha-bugs] [Bug 31197] New: Enabling Authority checks for all
 library staff but restrict the ability to edit Authority files to system
 admin
Message-ID: <bug-31197-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31197

            Bug ID: 31197
           Summary: Enabling Authority checks for all library staff but
                    restrict the ability to edit Authority files to system
                    admin
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: susan.merner at nhs.net
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The ability to check whether an Authority such as a subject heading is in the
authority file should be available to all staff BUT the option to edit
authority files should be restricted to selected staff with system admin
permissions.

The Authority files affected would be Subject Headings (650), Series (490) and
Corporate Authors. We want to ensure staff keep to the authorised lists and do
not introduce or amend entries within Authorities.

Is there a way to give cataloguers permission to have the "Link authorities
automatically" button, but not edit, create or delete the authorities? If we
could have a 'check authorities' button with no additional permissions, it
would be really helpful! Or a way to flag unauthorised headings upon saving.

We all need to be able to check if the subject headings (650 field) being
pulled through by z39.50 are included in the authority file on Koha. At
present, this is not possible, and there is no way to check z39.50 against the
authority file. This raises an issue with cataloguers adding in unauthorised
headings

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:35:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:35:58 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-aQSx9NgLMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:36:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:36:03 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-ALC2cLUZBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137879|0                           |1
        is obsolete|                            |

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137906&action=edit
Bug 30933: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:36:07 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-Oa1NNsJZ77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137880|0                           |1
        is obsolete|                            |

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137907&action=edit
Bug 30933: Add lists methods for disowning

This patch aims to tidy things a bit by doing the following changes:

* Koha::Virtualshelf gets the 'transfer_ownership' method
* Koha::Virtualshelves gets the 'disown_or_delete' method
* Koha::Patron->delete gets rewritten/simplified by using
  disown_or_delete

The idea is to capture the current behavior in more fine grained
methods. So current tests should be passing as they do now.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run:
  k$ prove t/db_dependent/Koha/Virtualshelf.t \
           t/db_dependent/Koha/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:36:59 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-llrFYFQhGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Tomás Cohen Arazi from comment #22)
> @Marcel and @Martin. Please review my follow-ups. I'll push the tree if we
> agree with them. Would like your signature, though.

They are fine with me. Please wait a bit still, looking at a small interface
issue in the middle patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:47:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:47:42 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-1eTpqrcaN5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #62 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137908&action=edit
Bug 25498: (follow-up) Show error message when no sharee has email

Test plan:
Share a list with a patron that has no email address.
Try to transfer ownership. Verify that you get the error message.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:15 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-2pxldEq656@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137421|0                           |1
        is obsolete|                            |

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137909&action=edit
Bug 30933: Database revision (new pref)

Adds pref ListOwnerDesignated.
Generalize description of ListOwnershipUponPatronDeletion a bit.

Test plan:
Run updatedatabase.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:20 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-wVckMnd4N1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137422|0                           |1
        is obsolete|                            |

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137910&action=edit
Bug 30933: Change for patron->delete

Test plan:
Run t/db_dependent/Koha/Patrons.t
Set pref ListOwnershipUponPatronDeletion to transfer.
Set pref ListOwnerDesignated to some valid borrowernumber.
Pick a user with public or shared list, delete from interface.
Pick a user with public or shared list, delete by script. (*)
Verify in both cases that new list owner is the designated one.

(*) Tip: Create another branch. Move the patron to be deleted to that
branch. And delete by script with:
    misc/cronjobs/delete_patons.pl -c -v -library YOUR_CODE

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:24 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-1IzUTBRkJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137423|0                           |1
        is obsolete|                            |

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137911&action=edit
Bug 30933: Adjust pref description, include ListOwnerDesignated

Test plan:
View the pref on the System preferences, Patrons tab.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:28 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-ZTDpL0rCCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137424|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137912&action=edit
Bug 30933: (follow-up) Consolidate transfer checks

Adding shelf->cannot_be_transferred with unit tests.

Note: This follow-up actually refers to comment42 on the
preceding report 25498.
Furthermore, we could still improve later on using error code
more effectively (adding codes). Here we concentrate on moving
the checks to module level.

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:36 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-O5ETwfVtJA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137425|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137913&action=edit
Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts

Test plan:
Verify if transfer shared list on OPAC still works as expected.
Same for intranet counterpart for public lists.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:46 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-2wn1GjFBs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137907|0                           |1
        is obsolete|                            |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137915&action=edit
Bug 30933: Add lists methods for disowning

This patch aims to tidy things a bit by doing the following changes:

* Koha::Virtualshelf gets the 'transfer_ownership' method
* Koha::Virtualshelves gets the 'disown_or_delete' method
* Koha::Patron->delete gets rewritten/simplified by using
  disown_or_delete

The idea is to capture the current behavior in more fine grained
methods. So current tests should be passing as they do now.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run:
  k$ prove t/db_dependent/Koha/Virtualshelf.t \
           t/db_dependent/Koha/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:47 +0000
Subject: [Koha-bugs] [Bug 23565] Add columns configuration and export
 options to item search results
In-Reply-To: <bug-23565-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23565-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23565-70-7dFnku5WzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23565

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:52:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:52:41 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-ZPxDcbnKnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137906|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 137914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137914&action=edit
Bug 30933: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:53:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:53:27 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-72zYiLJNc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased Bug 30933: (follow-up) Use cannot_be_transferred in shelves scripts
for change on 25498

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 13:57:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 11:57:23 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-blpR29TGIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks like a great improvement to the code readability to me..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:00:56 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-tqODDqSRN2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137914|0                           |1
        is obsolete|                            |

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137916&action=edit
Bug 30933: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:01:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:01:00 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-ZZHqJzeRZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137915|0                           |1
        is obsolete|                            |

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137917&action=edit
Bug 30933: Add lists methods for disowning

This patch aims to tidy things a bit by doing the following changes:

* Koha::Virtualshelf gets the 'transfer_ownership' method
* Koha::Virtualshelves gets the 'disown_or_delete' method
* Koha::Patron->delete gets rewritten/simplified by using
  disown_or_delete

The idea is to capture the current behavior in more fine grained
methods. So current tests should be passing as they do now.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patrons.t \
           t/db_dependent/Virtualshelves.t
=> SUCCESS: Tests pass
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Run:
  k$ prove t/db_dependent/Koha/Virtualshelf.t \
           t/db_dependent/Koha/Virtualshelves.t
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:31 +0000
Subject: [Koha-bugs] [Bug 11889] Option to keep public or shared lists when
 deleting patron
In-Reply-To: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11889-70-dUwjjMNE3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:34 +0000
Subject: [Koha-bugs] [Bug 11889] Option to keep public or shared lists when
 deleting patron
In-Reply-To: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11889-70-l87YIlKsQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889

--- Comment #101 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:37 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-TVVYTnH4lC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:42 +0000
Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared
 list
In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25498-70-eF8d6ITCj3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498

--- Comment #63 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:51 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-IxsqnS8oDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:55 +0000
Subject: [Koha-bugs] [Bug 30909] Regression,
 Permanent shelving location is always updated when editing location
 VIA ADDITEM.PL if both are mapped to MARC fields
In-Reply-To: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30909-70-7fXVXBspMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30909

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:09:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:09:57 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-lUHfrqd1MX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:10:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:10:02 +0000
Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and
 public lists at patron deletion
In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30933-70-v0VuCb72QF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933

--- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:10:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:10:08 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-jp8wMM1vev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:10:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:10:06 +0000
Subject: [Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item
 fields
In-Reply-To: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31179-70-pjWYA87ShH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:15 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-vrO3aIWwwh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137835|0                           |1
        is obsolete|                            |

--- Comment #104 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137918&action=edit
Bug 29697: Special case - opac not needed

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:23 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-EHD30i0SS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137836|0                           |1
        is obsolete|                            |

--- Comment #105 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137919&action=edit
Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

JD Amended patch:
-# FIXME Special case here

-    print "Biblio not found\n,";
+    print "Biblio not found\n";

- my $biblio = Koha::Biblio->find($hostbiblionumber);
+ my $biblio = Koha::Biblios->find($hostbiblionumber);

Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:32 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-Lsr0DtHCbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137837|0                           |1
        is obsolete|                            |

--- Comment #106 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137920&action=edit
Bug 29697: Remove GetHiddenItemnumbers

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

JD amended patch:
-    my @items        = $biblio->items->filter_by_visible_in_opac({ patron =>
$logged_in_user })->unblessed;
-    foreach my $item (@items) {
+    my $items        = $biblio->items->filter_by_visible_in_opac({ patron =>
$logged_in_user })->unblessed;
+    foreach my $item (@$items) {

-    for my $itm (@items) {
+    for my $itm (@$items) {

-    $dat->{ITEM_RESULTS}   = \@items;
+    $dat->{ITEM_RESULTS}   = $items;

-        @items_to_show = Koha::Items->search( { itemnumbers => [ map {
$_->{itemnumber} } @all_items ] } )
-                                    ->filter_by_visible_in_opac( { patron =>
$patron } );
+        @items_to_show = Koha::Items->search( { itemnumber => [ map {
$_->{itemnumber} } @all_items ] } )
+                                    ->filter_by_visible_in_opac( { patron =>
$patron } )->as_list;

-            my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1,
patron => $patron });
+            my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1,
patron => $patron })->as_list;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:38 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-9q72uM2xPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137838|0                           |1
        is obsolete|                            |

--- Comment #107 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137921&action=edit
Bug 29697: Use flag embed_items

Includes:
    Bug 29697: (follow-up) Use flag embed_items

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:43 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-WEdHyAHgtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137839|0                           |1
        is obsolete|                            |

--- Comment #108 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137922&action=edit
Bug 29697: Fix tests

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:50 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-FN1vfbK8vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137840|0                           |1
        is obsolete|                            |

--- Comment #109 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137923&action=edit
Bug 29697: Deal with the degraded view in detail.pl

In detail.pl we must provide a degraded view with an error message about
invalid MARC::Record.
We are then forced to reproduce the GetMarcBiblio behaviour and call
StripNonXmlChars on the MARC::XML

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Rebased-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:29:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:29:55 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-ec3mgepicE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137894|0                           |1
        is obsolete|                            |

--- Comment #110 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137924&action=edit
Bug 29697: Don't crash ES reindex if a record is wrong

We don't want rebuild_elasticsearch.pl to crash if a record is wrong
(also fix ktd setup).
Note that now the script will output an error for the problematic
record, which is certainly the expected behaviour as we are doing it
already for authority records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:30:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:30:21 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-3aQx2HKhtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #111 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:03 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-ANUYbV0pOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #22)
> Our database updates are better now in terms of not silently ignoring
> issues, but I do think we as Devs aught to try and cater for more of these
> cases to keep the upgrades fairly smooth.
> 
> I'm happy to add that proposed follow-up

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:57 +0000
Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial
 claims table
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-pVl8GhtjLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:46 +0000
Subject: [Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl
 that relate to optional item records
In-Reply-To: <bug-26377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26377-70-d3WEnyFcYU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:43 +0000
Subject: [Koha-bugs] [Bug 26377] Clearly label parts of subscription-add.pl
 that relate to optional item records
In-Reply-To: <bug-26377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26377-70-aUgP4Kmxnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26377

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:51 +0000
Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
 staff client
In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27546-70-OuU5a0ucWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:49 +0000
Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the
 staff client
In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27546-70-KR1IyLaRxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 14:59:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 12:59:54 +0000
Subject: [Koha-bugs] [Bug 30039] Add publication date column to serial
 claims table
In-Reply-To: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30039-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30039-70-0kvGYHTLzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30039

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:00:03 +0000
Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results
 pages
In-Reply-To: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31020-70-13kQ8R5Vnc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:00:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:00:00 +0000
Subject: [Koha-bugs] [Bug 31020] PassItemMarcToXSLT only applies on results
 pages
In-Reply-To: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31020-70-kDBZQqnSe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31020

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:09:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:09:15 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-EjEg0aAyBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate
           Severity|enhancement                 |new feature
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:08 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-UUrDEFyJBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:12 +0000
Subject: [Koha-bugs] [Bug 7660] Enhanced messaging preferences are not set
 when creating a child patron from the adult
In-Reply-To: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7660-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7660-70-nJc4jFpQQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7660

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:20 +0000
Subject: [Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt
 summary page into menu
In-Reply-To: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30333-70-4sm9bTvqKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:17 +0000
Subject: [Koha-bugs] [Bug 30333] Move view actions on acquisitions receipt
 summary page into menu
In-Reply-To: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30333-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30333-70-BWqC5ZaSkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30333

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:22 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-H5b4StVynw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:11:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:11:25 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-VOiQ8e4EPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:12:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:12:19 +0000
Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-IdYrkf2Sjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron restrictions should  |Make patron restrictions
                   |be user definable           |user definable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:23:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:23:15 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-l1BOo2u7XU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #66 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:35:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:35:39 +0000
Subject: [Koha-bugs] [Bug 31198] New: Display results search authority
 numbers
Message-ID: <bug-31198-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31198

            Bug ID: 31198
           Summary: Display results search authority numbers
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julie.emond at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

Created attachment 137925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137925&action=edit
Authority display example

Hi, 

We would like to show the authority number in the search results. Currently you
have to click on the authorized to display the number.

It would therefore be interesting if we could choose the display options for
the authority results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:54:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:54:12 +0000
Subject: [Koha-bugs] [Bug 31188] UPC or ASIN from amazon for dvd,
 music cds image
In-Reply-To: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31188-70-0FwgmDirRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:58:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:58:07 +0000
Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count
In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16122-70-udQt6pAIlK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesse at bywatersolutions.com

--- Comment #9 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
*** Bug 18668 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 15:58:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 13:58:07 +0000
Subject: [Koha-bugs] [Bug 18668] Add the column localuse to the items table
In-Reply-To: <bug-18668-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18668-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18668-70-4BvHQ2PgBR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18668

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---


*** This bug has been marked as a duplicate of bug 16122 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:16:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:16:43 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-vE77hl6DQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137903|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137926&action=edit
Bug 31192: Check for item before calling is_bundle

The code in here is weird.. we really aught to check for the item before
anything else and throw an error to screen if we don't find one... but
my patch takes the simple option, and the one taken elsewhere in the
script.. to just check for item being defined before calling a method
upon it.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:16:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:16:39 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-g37ad0twOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:17:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:17:45 +0000
Subject: [Koha-bugs] [Bug 31008] Long Term Support (LTS) version of Koha
In-Reply-To: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31008-70-wMN4hbGwiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008

--- Comment #4 from David Nind <david at davidnind.com> ---
Discussed further at the 6 July 2022 development meeting
https://meetings.koha-community.org/2022/development_irc_meeting_6_july_2022.2022-07-06-21.00.log.html

General points discussed:

1) Which version will be LTS: discussion leant towards preferring 22.05, rather
than 21.11
2) Overlap time (half year or year): discussion leant towards a year
3) Regular maintenance time (1 year, 1.5 years...)

Diagram: https://lite.framacalc.org/29o8a7mlwc-9v57

To add questions to vote on to the next agenda. Those not able to attend next
meeting - add apologies and record votes in advance (if questions added to the
agenda).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:17:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:17:31 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-2IWbHDZJQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think I agreed to the idea of explicit search_ordered.. thus calling it
chained to get the order one wants in each case..

Can you now actually pass ordering in as attributes to the relation accessor
anyway too already?

  $biblio->items({},{ order_by => whatever });

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:19:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:19:57 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-vXAcHa440W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think this is pretty much ready to go.. just needs a QA eye.. which I can't
lend as I SO'd :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:26:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:26:35 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-0m3RLnmjsy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #72 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137932&action=edit
Bug 14364: (QA follow-up) Add email validation to ExpireReservesAutoFillEmail

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:26:18 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-lGx2KmrOvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #69 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137929&action=edit
Bug 14364: (follow-up) Cleanup duplicate code and adjust notices and prefs

This patch removes a duplicated stanza left form moving routine
Changes the routines to use inbound_library_address
Improves the display if the system preferences
Updates the update file
Moves smaple notice

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:25:52 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-JsunmxGvt7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133923|0                           |1
        is obsolete|                            |
 Attachment #133924|0                           |1
        is obsolete|                            |
 Attachment #133925|0                           |1
        is obsolete|                            |
 Attachment #133926|0                           |1
        is obsolete|                            |
 Attachment #133927|0                           |1
        is obsolete|                            |
 Attachment #133928|0                           |1
        is obsolete|                            |

--- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137927&action=edit
Bug 14364: Allow automatically canceled expired waiting holds to fill the next
hold

Right now, if a library automatically cancels expired waiting holds, a
librarian must still re-checkin an item to trap the next available hold
for that item. It would be better if the next hold was automatically
trapped and the librarians receive an email notification so they can
make any changes to the item if need be ( hold area, hold slip in item,
etc ).

Test Plan:
 1) Apply this patch
 2) Run updatedatabase.pl
 3) Create a record with one item
 4) Place two holds on that record
 5) Check in the item and set it to waiting for the first patron
 6) Set ReservesMaxPickUpDelay to 1
 7) Enable ExpireReservesMaxPickUpDelay
 8) Enable ExpireReservesAutoFill
 9) Set an email address in ExpireReservesAutoFillEmail
10) Modify the holds waitingdate to be in the past
11) Run misc/cronjobs/holds/cancel_expired_holds.pl
12) Note the hold is now waiting for the next patron
12) Note a waiting hold notification email was sent to that patron
13) Note a hold changed notification email was sent to the library

Signed-off-by: Victoria Faafia <vfaafia29 at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:27:24 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-DTFLINSfy4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:26:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:26:30 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-auiN40Cto7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #71 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137931&action=edit
Bug 14364: (QA follow-up) Fix capitalization

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:26:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:26:10 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-73JTc44fB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137928&action=edit
Bug 14364: (QA follow-up) Generate message for transfers as well

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:26:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:26:24 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-LVg28IAKrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #70 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137930&action=edit
Bug 14364: Fix spelling and tests

Moved the installer to pl file
Adjusted capitalization / reply-to
Fix tests by importing needed fuction and adjusting a wrong call

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:38:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:38:37 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-mzo2eAg0TO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137792|0                           |1
        is obsolete|                            |
 Attachment #137793|0                           |1
        is obsolete|                            |
 Attachment #137794|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137933&action=edit
Bug 27045: Fix items lost report export if delimiter is tab

When choosing tabulation as the delimiter for a CSV profile
for the lost item report, the tabs appear in the file as \t
instead of as proper tabs.

title\tauthor\tstocknumber\tcallnumber
"E Street shuffle :"\"Heylin, Clinton."\\

To test:
* Upate the existing sample lost item CSV profile to use tabs as
  separator
* Make sure you have some lost items in your database or create some
* Go to Reports > Lost items
* Run the report
* Check all or some of the checkboxes in the result list
* Export using the link on top and the CSV profile
* Verify the tabs are not exported correctly
* Apply patch
* Verify tabs now are proper tabs instead of \t

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:38:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:38:41 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-nD2gRbmLB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137934&action=edit
Bug 27045: Fix other exports using CSV profiles

This patch corrects the export of the 2 other reports
using CSV profiles:

* Late issues (serials)
* Basket (acquisitions)

To test:
1) Late issues
* Update the late issues sample report to use tab as separator
* Create a subscription
* Go to serial collection and 'generate next' to get some late issues
* Go to Claims
* Export the late issues and verify format is correct
* Verify exported file has tabs

2) Basket summary
* Create an order with several order lines
* Create an SQL type CSV profile for basket export using tab as separator
  Example: aqorders.quantity|aqordres.listprice|Title=biblio.title
* Export the basket using your configured CSV profile
* Verify exported file has tabs

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:38:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:38:05 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-8veyPmnCgW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Petro, are you working on this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:38:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:38:45 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-51qMjY1fYB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137935&action=edit
Bug 27045: (follow-up) Fix delimiter in header rows

The header rows still showed \t because the newly defined
variable wasn't used there.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:38:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:38:34 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-ftfQKGiEjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:41:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:41:51 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-rEQbKKvpzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137861|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137936&action=edit
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:41:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:41:48 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-slAt9x1wzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:44 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-Y5OegqsBDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:26 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-8HBGJbdoTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:29 +0000
Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file,
 mandatory item subfields that are empty do not block form submission
In-Reply-To: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30268-70-ngYFmX34RI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:42 +0000
Subject: [Koha-bugs] [Bug 31192] Checking in an unkown barcode causes error
In-Reply-To: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31192-70-t8nSZHxrIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:31 +0000
Subject: [Koha-bugs] [Bug 30268] When creating an order from a staged file,
 mandatory item subfields that are empty do not block form submission
In-Reply-To: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30268-70-LWjMRk5EpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30268

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:24 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-324PFAmqG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:37 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-0nqcjp1W0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:54:40 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-fJIMoJSw8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:59:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:59:06 +0000
Subject: [Koha-bugs] [Bug 31200] New: Block payment of late fees when
 document not return
Message-ID: <bug-31200-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31200

            Bug ID: 31200
           Summary: Block payment of late fees when document not return
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julie.emond at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi, 

A library would like to be able to block any payment of late fees if materials
are not returned to the library. 

As this could have undesirable effects it should be possible to make changes in
the system preference and not be blocked for everyone. 

Does anyone know a way to enforce this preference?

Another possibility would be to display a pop-up during payment so that the
person who wants to collect knows that the document has not been returned.
After the libraby chooses if it want accept of not the payment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:58:20 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-JhWKQ00l5Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31199


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199
[Bug 31199] selenium/patrons_search.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:58:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:58:27 +0000
Subject: [Koha-bugs] [Bug 31199] selenium/patrons_search.t is failing
 randomly
In-Reply-To: <bug-31199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31199-70-fJyehv2qF8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Koha_Master/2115

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 16:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 14:58:20 +0000
Subject: [Koha-bugs] [Bug 31199] New: selenium/patrons_search.t is failing
 randomly
Message-ID: <bug-31199-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31199

            Bug ID: 31199
           Summary: selenium/patrons_search.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 25551

19:38:24 koha_1       |     # Looks like you planned 24 tests but ran 16.
19:38:24 koha_1       | 
19:38:24 koha_1       | #   Failed test 'Search patrons'
19:38:24 koha_1       | #   at t/db_dependent/selenium/patrons_search.t line
287.
19:38:24 koha_1       | Cannot wait more for jQuery to be active
(wait_for_ajax) at /kohadevbox/koha/t/lib/Selenium.pm line 206.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:41:17 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-Sonmhbl54Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:46:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:46:19 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-XfhlX5K9Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137938&action=edit
Bug 31201: Prevent Pseudonymization.t to fail

It's failing if selenium/patrons_search.t failed before, they are using
the same code and the selenium tests didn't clean correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:45:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:45:14 +0000
Subject: [Koha-bugs] [Bug 31201] New: Pseudonymization.t failing if
 selenium/patrons_search.t failed before
Message-ID: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

            Bug ID: 31201
           Summary: Pseudonymization.t failing if
                    selenium/patrons_search.t failed before
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 25551

Koha_Master/2115

19:52:29 koha_1       | #   Failed test 'No tests run for subtest
"PseudonymizedBorrowerAttributes tests"'
19:52:29 koha_1       | #   at t/db_dependent/Koha/Pseudonymization.t line 211.
19:52:29 koha_1       | Duplicate ID# Looks like your test exited with 255 just
after 3.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:45:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:45:14 +0000
Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly
In-Reply-To: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25551-70-ErlXK9Fe8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31201


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201
[Bug 31201] Pseudonymization.t failing if selenium/patrons_search.t failed
before
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:46:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:46:16 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-rM6uFeMT78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:41:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:41:06 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-OQHOsoo6gC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137937&action=edit
Bug 25449: Fix basic_workflow.t

We need to create an itemtype for the biblio, then the item form will
have 942$c prefilled by default

STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch
{...}
        /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try
        (eval 1726):1 in Selenium::Remote::Driver::__ANON__
        (eval 1728):2 in Selenium::Remote::Driver::__ANON__
        /usr/share/perl5/Selenium/Remote/Driver.pm:953 in
Selenium::Remote::Driver::_execute_command
        t/db_dependent/selenium/basic_workflow.t:224 in
Selenium::Remote::Driver::get_title

Error while executing command: unexpected alert open: Dismissed user prompt
dialog: Form not submitted because of the following problem(s)
------------------------------------------------------------------------------------

- 1 mandatory fields empty (highlighted) at
/usr/share/perl5/Selenium/Remote/Driver.pm line 411.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:47:16 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-WrHXRXPSuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 17:47:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 15:47:26 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-L0LMbyFKRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:02:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:02:47 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-ObBLMqDjMv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:02:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:02:41 +0000
Subject: [Koha-bugs] [Bug 31202] New: Koha removes optional SIP fields with
 a value of "0"
Message-ID: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

            Bug ID: 31202
           Summary: Koha removes optional SIP fields with a value of "0"
 Change sponsored?: ---
           Product: Koha
           Version: 21.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Discovered this when trying to send the number of patron holds in a custom SIP
field.

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:18:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:18:51 +0000
Subject: [Koha-bugs] [Bug 28702] Improve performance of
 C4/XSLT/buildKohaItemsNamespace
In-Reply-To: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28702-70-yAkoCYhK3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122785|0                           |1
        is obsolete|                            |

--- Comment #3 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137939&action=edit
Bug 28702: Make buildKohaItemsNamespace take an array

If we fetch some of the authorised values and before hand we can reduce the
amount of work needed in this routine.
We stil require queries for pending holds and transfers, but these are lighter
than fetching the items

To test:
1 - Perform a search on the OPAC
2 - Add the results to a list
3 - Load the list several times and use developer tools (F12) to view the time
to load in the network tab
4 - Repeat a search several times and use developer tools (F12) to view the
time to load in the network tab
5 - Record the times noted above
6 - Apply patch
7 - Repeat the search and list view and compare to before the patch
8 - prove -v t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:20:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:20:04 +0000
Subject: [Koha-bugs] [Bug 28702] Improve performance of
 C4/XSLT/buildKohaItemsNamespace
In-Reply-To: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28702-70-aRxoM8JCna@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137939|0                           |1
        is obsolete|                            |

--- Comment #4 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137940&action=edit
Bug 28702: Make buildKohaItemsNamespace take an array

If we fetch some of the authorised values and before hand we can reduce the
amount of work needed in this routine.
We stil require queries for pending holds and transfers, but these are lighter
than fetching the items

To test:
1 - Perform a search on the OPAC
2 - Add the results to a list
3 - Load the list several times and use developer tools (F12) to view the time
to load in the network tab
4 - Repeat a search several times and use developer tools (F12) to view the
time to load in the network tab
5 - Record the times noted above
6 - Apply patch
7 - Repeat the search and list view and compare to before the patch
8 - prove -v t/db_dependent/XSLT.t

Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:19:59 +0000
Subject: [Koha-bugs] [Bug 28702] Improve performance of
 C4/XSLT/buildKohaItemsNamespace
In-Reply-To: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28702-70-hGAj8h6Edw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:34:35 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-BguaUZunE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:34:38 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-1jfyxOSByC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137941&action=edit
Bug 31202 - Koha removes optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:37:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:37:09 +0000
Subject: [Koha-bugs] [Bug 31203] New: Cronjobs should log completion as well
 as logging begin
Message-ID: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

            Bug ID: 31203
           Summary: Cronjobs should log completion as well as logging
                    begin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Currently our cronjobs call cronlogaction when they begin

We should add a second call:
cronlogaction({done => 1});

To indicate when a job has completed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:47:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:47:43 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-doKghHpljL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
100% yes please

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:52:11 +0000
Subject: [Koha-bugs] [Bug 31204] New: Edit dropdown on results.tt should
 indicate it is record modification
Message-ID: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

            Bug ID: 31204
           Summary: Edit dropdown on results.tt should indicate it is
                    record modification
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On results.tt there is an option to select records and then, from the toolbar,
select edit and choose either 'Batch edit' or 'Batch delete'.

Some librarians have found this confusing, thinking it would lead them to
'Batch Item Modification' when instead it leads to 'Batch record modification'.

We could make it less confusing by clearly indicating this function takes the
user to record modification, not item modification.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:52:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:52:27 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-t7Y6ydLJAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:58:00 +0000
Subject: [Koha-bugs] [Bug 31205] New: Adding Custom name to the 'From' field
 in email notices
Message-ID: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

            Bug ID: 31205
           Summary: Adding Custom name to the 'From' field in email
                    notices
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tgoatley at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 137942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137942&action=edit
Please enter valid email address

Adding Custom name to the 'From' field in email notices (i.e. Whatever you want
in front <yourAdminEmail at address.com>) hasn't been working for a few years and
recently a few libraries have requested. The wiki page for this is:
https://wiki.koha-community.org/wiki/Adding_Custom_name_to_the_%27From%27_field_in_email_notices

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:58:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:58:16 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-ADzEk1iME9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:58:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:58:19 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-EjQ5Splyrb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 137943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137943&action=edit
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 18:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 16:58:38 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-8V9FQLVcAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:00:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:00:55 +0000
Subject: [Koha-bugs] [Bug 31205] Adding Custom name to the 'From' field in
 email notices
In-Reply-To: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31205-70-F0odcieStn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Todd Goatley <tgoatley at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tgoatley at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:06:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:06:57 +0000
Subject: [Koha-bugs] [Bug 31194] koha-marc mappings not invalidated in cache
In-Reply-To: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31194-70-eLPSgTY4bE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31194

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #0)
> The cache is cleared for the default framework, but the mapping can be read
> from another framework

I'm pretty sure I used the default framework when noticing this bug for the
first time. The cache invalidation problem occurred only when I deleted a
mapping, I didn't notice it happening when changing the value of a mapping.
I'll try to circle back to this bug report later to confirm / and see if I have
any ideas on how to fix this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:07:18 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-sqiyvZ4VpV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137851|0                           |1
        is obsolete|                            |

--- Comment #4 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137944&action=edit
Bug 31183: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:07:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:07:14 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-nCRreoB0AI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:07:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:07:22 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-al8Qsj170L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137852|0                           |1
        is obsolete|                            |

--- Comment #5 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137945&action=edit
Bug 31183: Add Koha::Item::Transfers->filter_by_current

This patch introduces the aforementioned method.

To test:
1. Apply this unit tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Item/Transfers.t
=> FaIL: method not defined?
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:07:25 +0000
Subject: [Koha-bugs] [Bug 31183] Add Koha::Item::Transfers->filter_by_current
In-Reply-To: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31183-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31183-70-Lux4eNdlAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31183

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137853|0                           |1
        is obsolete|                            |

--- Comment #6 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137946&action=edit
Bug 31183: Use filter_by_current in Koha::Holds->get_items_that_can_fill

This patch makes the method use the new
Koha::Item::Transfers->filter_by_current one.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Holds.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests still pass
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:40:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:40:58 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-WyDFawDEvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137941|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 137947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137947&action=edit
Bug 31202 - Koha removes optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban <michalurban177 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:41:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:41:15 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-4iUhFZToMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michalurban177 at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:42:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:42:07 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-U0L3yiReJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137924|0                           |1
        is obsolete|                            |

--- Comment #112 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137948&action=edit
Bug 29697: Don't crash ES reindex if a record is wrong

We don't want rebuild_elasticsearch.pl to crash if a record is wrong
(also fix ktd setup).
Note that now the script will output an error for the problematic
record, which is certainly the expected behaviour as we are doing it
already for authority records.

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:44:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:44:40 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-1xf33Z5Lp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #113 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
(In reply to Jonathan Druart from comment #103)
> Last patch would benefit from a QA review but I don't want to set the status
> back to NQA and lose it for weeks.

Looks good to me, handing off to the release manager.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 19:45:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 17:45:04 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-xw4lsBq3GS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It is actually failing randomly, with this patch at least:

$ prove t/db_dependent/Koha/Pseudonymization.t
t/db_dependent/Koha/Pseudonymization.t .. 1/3 
    #   Failed test 'Attribute 1 should be retrieved correctly'
    #   at t/db_dependent/Koha/Pseudonymization.t line 201.
    #     Structures begin differing at:
    #          $got->{code} = 'sJHyWk'
    #     $expected->{code} = 'YgXf22O9Vp'

    #   Failed test 'Attribute 2 should be retrieved correctly'
    #   at t/db_dependent/Koha/Pseudonymization.t line 207.
    #     Structures begin differing at:
    #          $got->{attribute} = 'attribute for code1'
    #     $expected->{attribute} = 'attribute for code3'
    # Looks like you failed 2 tests of 3.
t/db_dependent/Koha/Pseudonymization.t .. 3/3 
#   Failed test 'PseudonymizedBorrowerAttributes tests'
#   at t/db_dependent/Koha/Pseudonymization.t line 214.
# Looks like you failed 1 test of 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 20:33:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 18:33:17 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-q8Yj2OntO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 20:33:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 18:33:21 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-jgfPfwiSJK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137905|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137949&action=edit
Bug 30458: Include librarian (manager_id) in accountline when using "Payout
amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
JK: Fix commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 20:34:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 18:34:33 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-TsXGRXTK1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Thanks, trivial fix, passing QA. Adjusted the commit title a bit as it was not
passing the qa tool and didn't describe the change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 20:35:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 18:35:29 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-fzZjrnmZP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 21:38:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 19:38:15 +0000
Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches
 with $x 'General subdivision' subfield values
In-Reply-To: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15048-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15048-70-Ab8yBnesWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #22)
> I feel like we can't expect people to constantly reset their Elasticsearch
> mappings and redo their own. As this fixed a bug, could we update mappings
> with a database update?

I don't think it is that simple. We have created the ability for librarians to
manage their own ES configuration - we cannot know what thy have done and
whether our fixes are desired

bug 30836 needs to address this as a larger issue, but I don't think this
should be held up by that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 21:41:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 19:41:24 +0000
Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
 CSV or spreadsheet
In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18392-70-Zk7y3eHA7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 23:12:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 21:12:19 +0000
Subject: [Koha-bugs] [Bug 31206] New: Highlight logged in library in green
 in Circ History
Message-ID: <bug-31206-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206

            Bug ID: 31206
           Summary: Highlight logged in library in green in Circ History
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: madamyk at ckls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This is based on the same idea that was used in Bug 10902 (pushed to 21.11;
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10902). I think it
might be helpful to have the same kind of highlighting feature in other areas
of Koha for consortiums. 

Specifically, in this case, highlighting the logged-in library when looking at
circ history. However, I'm not sure if this would be "too much of a good
thing," i.e. if we started adding highlighting all over the place, is it going
to be more of a problem than a solution? I'm open to input on this. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 23:12:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 21:12:34 +0000
Subject: [Koha-bugs] [Bug 31206] Highlight logged in library in green in
 Circ History
In-Reply-To: <bug-31206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31206-70-tHNbiQwqJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madamyk at ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 20 23:46:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jul 2022 21:46:14 +0000
Subject: [Koha-bugs] [Bug 30884] Incomplete replace of jQuery UI tabs in
 batch patron modification breaks the form sending
In-Reply-To: <bug-30884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30884-70-TNQIhapzPf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.01,         |22.11.00, 22.05.01
        released in|21.11.07                    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:22:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:22:17 +0000
Subject: [Koha-bugs] [Bug 31207] New: The OPAC Shelf browser fails to
 display local cover images
Message-ID: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

            Bug ID: 31207
           Summary: The OPAC Shelf browser fails to display local cover
                    images
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: a.roussos at dataly.gr
        QA Contact: testopia at bugs.koha-community.org

In the OPAC Details page for a biblio, opening the Shelf browser
will display adjacent items next to each other based on their call
number and also display any cover images found. It's a very useful
OPAC feature that allows librarians to have a "virtual" look at
their library shelves.

This is currently broken *when local covers are exclusively in use*,
as it fails to fetch the related local cover images from the DB.

Steps to reproduce:

TL;DR: Just visit the sandbox URL below and see for yourself ;-)
https://opac-shlfbrwsr.sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?biblionumber=344&shelfbrowse_itemnumber=1348#holdings

Go to Home > Administration > System preferences in the Staff interface:
- in section 'OPAC -> Shelf browser', make sure OPACShelfBrowser
  is enabled (i.e. set to 'Show')
- in section 'Enhanced content -> Local or remote cover images',
  make sure both LocalCoverImages and OPACLocalCoverImages
  are enabled (i.e. set to 'Display')
- make sure no other cover image provider is enabled
- make sure OpacSeparateHoldings and OpacSeparateHoldingsBranch
  are set to 'Don't separate' and 'home library', respectively

Next, in the Staff interface, find a record without any local cover
images (either at the biblio or at the item level), having at
least one item attached to it that has a Call number (the call
number value can be anything -- it's only needed to trigger the
display of the 'Browse shelf' hyperlink). Use the 'Images' tab
in the Details page of the record to upload a local cover image
at the biblio level (do *not* upload any item-level cover image).

Finally, in the OPAC, visit the Details page of the record you
just added the cover image to, and click on the 'Browse shelf'
link found in the 'Call number' column. When the Shelf browser
expands, you'll notice that there is no cover image displayed
for the item(s) that belong to your test biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:27:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:27:00 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-XwVtbVpg44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #1 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 137950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137950&action=edit
Koha 21.05.16 - OPAC Shelf browser - Local covers OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:27:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:27:28 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-6tCDaxjCym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #2 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 137951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137951&action=edit
Koha 21.11.00 - OPAC Shelf browser - Local covers Broken

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:29:05 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-fe6d3Q3Z25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31207

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:29:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:29:05 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-eCm7pmT8li@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28180

--- Comment #3 from Andreas Roussos <a.roussos at dataly.gr> ---
With regards to the display of local cover images, the OPAC Shelf
browser works correctly in Koha versions < 21.11.00. It's also worth
noting that the correct Shelf browser behaviour can be observed in
all Koha versions (including master) when other cover image providers
(Amazon, etc.) are in use (either on their own or in combination with
the local cover images system preferences).

The relevant commit that changed the Shelf browser's behaviour is
fad97080e97da5bc77724c68b9394aba15518847 (from Bug 28180), where
these lines were removed from opac-detail.tt:

[% IF OPACLocalCoverImages %]
    KOHA.LocalCover.GetCoverFromBibnumber(true);
    [% IF itemloop_has_images OR oheritemloop_has_images %]
        KOHA.LocalCover.GetCoverFromItemnumber(true);
    [% END %]
[% END %]

Adding the above code to opac-detail.tt fixes the problem in master.

However, if you look closely you'll notice the code has a small typo.
The template parameter in the second [% IF %] conditional is named:

oheritemloop_has_images

vs. the correct parameter name:

otheritemloop_has_images

Because of that, the display of local cover images in the
OPAC Shelf browser has never worked as intended when the SysPref
OpacSeparateHoldings is set to 'Separate'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 05:30:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 03:30:36 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-lskNjCmNHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |a.roussos at dataly.gr
             Status|NEW                         |ASSIGNED

--- Comment #4 from Andreas Roussos <a.roussos at dataly.gr> ---
Self-assigning this as I'm preparing a patch that fixes both issues
outlined above. I'm also going to include a Selenium unit test that
will (hopefully) make it easier to catch Shelf browser-related bugs
in the future.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 07:10:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 05:10:00 +0000
Subject: [Koha-bugs] [Bug 31208] New: "Check for embedded item record data"
 should default to "No"
Message-ID: <bug-31208-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31208

            Bug ID: 31208
           Summary: "Check for embedded item record data" should default
                    to "No"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

At the moment, "Check for embedded item record data" in stage-marc-import.pl
defaults to "Yes", but I doubt that the majority of libraries would want to
check for embedded item record data. 

(By extension, I think it would be good to default "How to process items:" to
"Ignore items" instead of "Always add items" - just to be on the safe side.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 07:14:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 05:14:06 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-HzJD80dQrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 07:18:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 05:18:25 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-Fi4cG3HuQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 07:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 05:18:29 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-ac7utXmkuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137938|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137952&action=edit
Bug 31201: Prevent Pseudonymization.t to fail

It's failing if selenium/patrons_search.t failed before, they are using
the same code and the selenium tests didn't clean correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 08:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 06:43:44 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-wHroxNMxPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31207


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207
[Bug 31207] The OPAC Shelf browser fails to display local cover images
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 08:43:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 06:43:44 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-d2xm1JEGkm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28180


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180
[Bug 28180] Use a lightbox gallery to display the images on the detail pages in
OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 08:51:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 06:51:13 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-1OkIV0HC1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137953&action=edit
Bug 25449: (QA follow-up) Fix basic_workflow.t

Now that we have made item.itype a required field, we need to ensure we
set it for the corresponding selenium test.. this wasn't entirely easy
as the html select is hidden by select2. I had to find the select2 span,
trigger a click event to open it and then find and click an option.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 08:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 06:53:21 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-oSyo69DNGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Oooh.. you beat me to it Jonathan.

I think Jonathans fix is more elegant here Tomas, so I'd grab his.. I'll leave
mine here temporarily as an example of how to mess with select2 if needed.. it
also gets the test passing but it's rather messy and likely fragile.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 09:06:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 07:06:35 +0000
Subject: [Koha-bugs] [Bug 31209] New: Add span with class info to enumchron
 data in circulation.tt, for better styling
Message-ID: <bug-31209-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209

            Bug ID: 31209
           Summary: Add span with class info to enumchron data in
                    circulation.tt, for better styling
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In the table issues-table of circulation.tt, enumchron data in added to the
title between parentheses. There is no way to style this information
differently from the title. We could add a span with a class to isolate this
information. 

Alternatively, enumchron data could be moved in a new column

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 09:12:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 07:12:00 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-Gy2KPjrjWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 137937
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137937
Bug 25449: Fix basic_workflow.t

Review of attachment 137937:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25449&attachment=137937)
-----------------------------------------------------------------

::: t/db_dependent/selenium/basic_workflow.t
@@ +206,4 @@
>                  $v = strftime("%Y-%m-%d", localtime);
>                  $effective_input = $driver->find_element('//div[@id="subfield952w"]/input[@class="input_marceditor flatpickr-input"]');
>              }
> +            elsif (

As discussed on irc.. we don't actually need this condition.. the select is
hidden by select2 so we already filter it out with the selector.. it won't
appear in this loop.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 09:16:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 07:16:04 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-1Nermkh4t6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137952|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137954&action=edit
Bug 31201: Prevent Pseudonymization.t to fail

It's failing if selenium/patrons_search.t failed before, they are using
the same code and the selenium tests didn't clean correctly

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 09:16:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 07:16:39 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-IOHY55iS86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The change makes sense to me and makes us a little more future proof by using
testbuilder.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 09:39:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 07:39:37 +0000
Subject: [Koha-bugs] [Bug 21522] Labels incorrectly inheriting some default
 Bootstrap style properties
In-Reply-To: <bug-21522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21522-70-wwi3oclp3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21522

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Still valid ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:00:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:00:25 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-YG866XQNbE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137943|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137955&action=edit
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:01:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:01:02 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-Njj0K3BKbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Nice clear change - works as described, signing off.  Thanks for the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:01:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:01:16 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-Ps5TnynYjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It would be great if we could pick this up again. We often get asked about why
the settings are not remembered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:01:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:01:29 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-WR2tmJKH2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:08:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:08:05 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-fFTiGTZtQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Bug still valid - but patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:09:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:09:41 +0000
Subject: [Koha-bugs] [Bug 29533] Add additional fields to items
In-Reply-To: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29533-70-GKZeHG7LY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|add more fields to items    |Add additional fields to
                   |sql table                   |items

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think a separate key-value style table would be the best way to improve the
situation.

If we offered a 'Koha only' storage without the need to map to map to a valid
MARC subfield identifier, as we have run out of those. 

We could, for example, use capital letters only internally and do something
like $9 + defined prefix for export/import.

It would also help with the situation where data gets indexed and searchable
that should not be (see recurring internal notes discussion).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:09:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:09:52 +0000
Subject: [Koha-bugs] [Bug 29533] Add additional fields to items
In-Reply-To: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29533-70-Xr62dM8I91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29533

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:13:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:13:33 +0000
Subject: [Koha-bugs] [Bug 22212] Improve usability of column configuration
 page
In-Reply-To: <bug-22212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22212-70-HnifFuwAcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22212

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr
          Component|System Administration       |I18N/L10N

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:18:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:18:20 +0000
Subject: [Koha-bugs] [Bug 31210] New: Add option to use different library
 name in OPAC and staff interface
Message-ID: <bug-31210-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31210

            Bug ID: 31210
           Summary: Add option to use different library name in OPAC and
                    staff interface
 Change sponsored?: ---
           Product: Koha
           Version: 20.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, michaela.sieber at kit.edu

At the moment the name of a library is used both in OPAC and staff displays. It
would be nice if we could use different descriptions in staff and OPAC as some
libraries would prefer to use an abbreviated internal version of the name in
the staff interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:24:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:24:01 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-wPaqfir8Y6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137888|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137956&action=edit
Bug 30858: Add serial enumeration/chronology to item search

To test:
1. Apply patch
2. Go to  Catalog > Item search and do a search for items that you know contain
a items.enumchron
3. The result set should now show the items.enumchron
4. Make sure you can properly "Export results to.."

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:24:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:24:06 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-VDvGUsFYtb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 137957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137957&action=edit
Bug 30858: (follow-up) Add enumchron to CSV export and fix CSS class

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:24:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:24:43 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-OiWFZmJGm2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
 Attachment #137889|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 10:25:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 08:25:22 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-HE9Y0yjGV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works well, QA scripts are happy.

I fixed the bug number in the follow-up.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 11:27:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 09:27:52 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-zHBQkzgdPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushed to 21.11.x for 21.11.11, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 11:28:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 09:28:07 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-fGRZSHD00r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |21.11.11
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 12:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 10:10:12 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-tp8IXHbqzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #50 from Peter Vashchuk <stalkernoid at gmail.com> ---
Yes, I'm on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:12:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:12:21 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-6FmXos14r0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.derscheid at lmscloud.de

--- Comment #1 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Should this be a public route?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:19:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:19:40 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-fxABd4p5Qj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:19:45 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-bXC8b6M3kB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133028|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137958&action=edit
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for
'Lost item fee refund on return policy' and note default says 'Use default
(Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore
overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost
item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:27:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:27:18 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
 permission can no longer update hold pickup locations
In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30207-70-xdZ15x5aMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.05.00                    |22.05.00, 21.11.11
        released in|                            |

--- Comment #19 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi,
Applied to 21.11.x for 21.11.11 :)
thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:28:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:28:19 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
 permission can no longer update hold pickup locations
In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30207-70-l5O47LngYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:28:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:28:20 +0000
Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user
 only has place_hold permission
In-Reply-To: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30213-70-kIvGDVOUtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213
Bug 30213 depends on bug 30207, which changed state.

Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:37:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:37:13 +0000
Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where
 clause' 500 error in API /api/v1/acquisitions/orders
In-Reply-To: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30677-70-Z6pXviE5Ku@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.x           |22.11.00, 22.05.x, 21.11.11
        released in|                            |
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #25 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushed to 21.11.x for 21.11.11, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 13:51:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 11:51:07 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-iu8EwkclEN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:04:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:04:27 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-pImUTEmBxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137958|0                           |1
        is obsolete|                            |

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137959&action=edit
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for
'Lost item fee refund on return policy' and note default says 'Use default
(Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore
overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost
item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:05:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:05:04 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-Jd157vqLjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Great, thanks Nick - works as described, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:42:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:42:29 +0000
Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's
 account
In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21043-70-Or0FYIIpVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:48:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:48:49 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-cts66m8WDe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:48:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:48:53 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-QlXidmwJ0t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137960&action=edit
Bug 31203: Alter cronlogaction to take a hash and pass PID as object for log

This patch simply changes the routine to expect a hashref, now info and pid can
be passed
through for logging

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:48:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:48:57 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-OHjFVVI2bD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137961&action=edit
Bug 31203: POC advance_notices

This patch proposes a new standard for cronlogaction

We copy @ARGV into a space separated string, then pass this and the PID to
cronlogaction

At the end of the script we add a call with info "COMPLETED"

To test:
1 - Apply patch
2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c
3 - sudo koha-mysql kohadev
4 - SELECT * FROM action_logs WHERE interface="CRON";
5 - Note start and completion logged
6 - Note command line arguments included in info

If this looks good I will copy this pattern to the other cronjobs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:49:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:49:32 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-90CWXDtN8N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:49:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:49:35 +0000
Subject: [Koha-bugs] [Bug 31201] Pseudonymization.t failing if
 selenium/patrons_search.t failed before
In-Reply-To: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31201-70-qWf6gZ56bn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31201

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:50:48 +0000
Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default
In-Reply-To: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25449-70-fMcatnbShK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed,     |
                   |rel_22_11_candidate         |

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-ups pushed to master. Thanks Jonathan and Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:51:31 +0000
Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS
In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23773-70-9zVZDRo7km@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
                 CC|                            |julian.maurice at biblibre.com

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
I'm working on that. Marking as assigned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:58:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:58:00 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-uii0qk1Nh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137960|0                           |1
        is obsolete|                            |
 Attachment #137961|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137962&action=edit
Bug 31203: Alter cronlogaction to take a hash

This patch simply changes the routine to expect a hashref for info
and to log the PID as object in action logs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 14:58:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 12:58:04 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-HIrb43TRgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137963&action=edit
Bug 31203: POC advance_notices

This patch proposes a new standard for cronlogaction

We copy @ARGV into a space separated string, then pass this to
cronlogaction

At the end of the script we add a call with info "COMPLETED"

To test:
1 - Apply patch
2 - perl misc/cronjobs/advance_notices.pl -v -m 4 -n -c
3 - sudo koha-mysql kohadev
4 - SELECT * FROM action_logs WHERE interface="CRON";
5 - Note start and completion logged
6 - Note command line arguments included in info

If this looks good I will copy this pattern to the other cronjobs

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:00:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:00:30 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-m0ixtJNtfE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #40 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Hi, tried to apply to 21.11.x but have conflicts.
Didn't manage to fix them on the main patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:13:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:13:20 +0000
Subject: [Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
In-Reply-To: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30786-70-5Ya5Z78xd1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.01          |22.11.00, 22.05.01,
        released in|                            |21.11.11
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushed to 21.11.x for 21.11.11, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:43:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:43:38 +0000
Subject: [Koha-bugs] [Bug 30938] Fix column configuration to the
 acquisitions home page
In-Reply-To: <bug-30938-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30938-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30938-70-GKXIT9Li2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Resolution|---                         |FIXED
             Status|Pushed to stable            |RESOLVED

--- Comment #7 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 27212, not relevant to 21.11.x.
Won't backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:44:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:44:42 +0000
Subject: [Koha-bugs] [Bug 29963] Date accessioned plugin should not
 automatically fill today's date on cataloguing screens
In-Reply-To: <bug-29963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29963-70-Be9aT2L3gq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #39 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
depends on 29815, won't backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:44:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:44:43 +0000
Subject: [Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the
 item editor
In-Reply-To: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30931-70-ornTZYjEb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931
Bug 30931 depends on bug 29963, which changed state.

Bug 29963 Summary: Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:46:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:46:43 +0000
Subject: [Koha-bugs] [Bug 30925] Creating public list by adding items to new
 list creates a private list
In-Reply-To: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30925-70-pB5m1i9cPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30925

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #15 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
backported to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 15:48:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 13:48:35 +0000
Subject: [Koha-bugs] [Bug 30989] Tags with some special characters are not
 encoded right
In-Reply-To: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30989-70-y06mMBwrXP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
backported to 21.11.x for 21.11.11, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:00:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:00:48 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-RHIisYIkYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137964&action=edit
[21.11.x] Bug 28529: Regression tests

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:00:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:00:56 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-Ew1zFxKa7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

--- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 137965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137965&action=edit
[21.11.x] Bug 28529: Make biblio-level hold itemtype count against max rules

The current situation is that biblio-level holds can be assigned an item
type, so they can only be fulfilled by items matching that specified
item type (be it item-level itype or the fallback to biblio-level).

But there's the situation in which max holds limits for a specific item
type can be overridden by using biblio-level holds with item type
selection (AllowHoldItemTypeSelection) enabled.

To test:
1. Have a patron of category 'Staff' (S)
2. Have 3 records with items with the 'BK' item type, and maybe others
3. Enable AllowHoldItemTypeSelection
4. Set a limit of 2 max holds for that category+item type
5. In the OPAC. Place bibio-level holds, with item type contraint to 'BK' on
those 3 records
=> FAIL: You can place the 3 holds
6. Cancel the holds
7. Apply this patch and restart all
8. Repeat 5
=> SUCCESS: You can only place 2 holds
9. Run:
   $ kshell t/db_dependent/Reserves.t
=> SUCCESS: Tests pass!
10. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:03:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:03:50 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-kHW2PUSdgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137967&action=edit
Bug 27272: Remove GetItemsInfo from basket/basket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:03:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:03:45 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-0B6EG4PWKV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137966&action=edit
Bug 27272: Remove type= from detail.pl

This is not related to anything known.. was it "itype" at some point?
`git log -p` will tell you that it's there for a looong time already

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:03:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:03:56 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-ViNVwJPp2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137968&action=edit
Bug 27272: Remove GetItemsInfo from basket/sendbasket

Why are we display with $raw?
Why are we display the location code instead of the AV's lib?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:04 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-Zzm7SDBlCQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137969&action=edit
Bug 27272: Remove GetItemsInfo from catalogue/imageviewer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:14 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-99jvYg5wR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137970&action=edit
Bug 27272: Remove GetItemsInfo labels/label-item-search

It was commented anyway

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:22 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-W9zjx83ihQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137971&action=edit
Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl

Hum... Item2Marc ok here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:33 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-Q2g498a90i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137973&action=edit
Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl

It was never set (was set before 14695)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:28 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-4cNjesagX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137972&action=edit
Bug 27272: Remove GetItemsInfo from opac-detail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:39 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-YsyTr6a5RZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137974&action=edit
Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:45 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-QNeMrt00AZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137975&action=edit
Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:50 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-SBvJIlCasy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137976&action=edit
Bug 27272: Remove GetItemsInfo from opac-sendbasket

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:04:55 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-QK1Wjw3YA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #62 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137977&action=edit
Bug 27272: Remove GetItemsInfo import from opac-tags

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:05:06 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-ERUZeft2id@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #63 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137978&action=edit
Bug 27272: Remove GetItemsInfo from serials/routing-preview

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:05:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:05:15 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-QiPqKvQIsR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137979&action=edit
Bug 27272: Remove GetItemsInfo from tags/list.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:05:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:05:21 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-KDrveYNEJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #65 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137980&action=edit
Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl

And GetItemsLocationInfo from shelves.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:05:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:05:37 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-kNcqEzQtCY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #67 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137982&action=edit
Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:05:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:05:31 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-g06cmf90R6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #66 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 137981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137981&action=edit
Bug 27272: Remove GetItemsInfo from catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:06:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:06:10 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-QbyWSyq0nf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gitlab.com/joubu/Ko |
                   |ha/-/commits/bug_27272      |

--- Comment #68 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Patches from remote branch have been attached here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:18:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:18:45 +0000
Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds
 causes all other holds to be prioritized as well!
In-Reply-To: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12630-70-ZhgVmryJrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #29 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
backporting to 21.11.x for 21.11.11.
thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:27:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:27:35 +0000
Subject: [Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken
 for translations
In-Reply-To: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30958-70-BrtyH11Jzi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
backported to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:28:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:28:10 +0000
Subject: [Koha-bugs] [Bug 30997] "CGI::param called in list context" warning
 in detail.pl flooding error log
In-Reply-To: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30997-70-gKrBjyvexg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30997

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushed to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:28:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:28:40 +0000
Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout
 permission (checkouts tab)
In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29504-70-gXvKON4qZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |arthur.suzuki at biblibre.com
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11

--- Comment #27 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushed to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:37:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:37:27 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-Kg4HE2HisO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.01          |22.11.00, 22.05.01,
        released in|                            |21.11.11
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #43 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
backported to 21.11.x for 21.11.11.
Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:40:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:40:28 +0000
Subject: [Koha-bugs] [Bug 28355] Add warning note about Email SMS driver
 option for SMSSendDriver
In-Reply-To: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28355-70-deaJAMXuEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28355

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|22.11.00, 22.05.03          |22.11.00, 22.05.03,
        released in|                            |21.11.11

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
pushing to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:54:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:54:07 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-y87iOrWzuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 16:54:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 14:54:17 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-PYLObK7enG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137983&action=edit
Bug 31203: Add End action to cronjobs and log viewer

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:06:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:06:03 +0000
Subject: [Koha-bugs] [Bug 31211] New: Check slips and notices for valid
 Template Toolkit and report errors
Message-ID: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

            Bug ID: 31211
           Summary: Check slips and notices for valid Template Toolkit and
                    report errors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would be useful for Koha to run a basic TT validation test and report back
errors. That way if somebody misses an END tag or something of that nature, it
will be easy to find and fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:06:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:06:08 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-gGfKeE4ARp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:13:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:13:33 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-wgTVIOZkZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:13:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:13:36 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-hgJI9gtP7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137984&action=edit
Bug 31211: Check slips and notices for valid Template Toolkit and report errors

It would be useful for Koha to run a basic TT validation test and report back
errors.
That way if somebody misses an END tag or something of that nature, it will be
easy to find and fix.

Test Plan:
1) Apply this patch
2) Edit a notice, change the content to simply "[% END %]"
   or some other invalid Template Toolkit
3) Choose "Save and continue editing"
4) Note the new "Template Toolkit error" field that displays the error
   message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:34:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:34:14 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-F98KERf0DC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137984|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137985&action=edit
Bug 31211: Check slips and notices for valid Template Toolkit and report errors

It would be useful for Koha to run a basic TT validation test and report back
errors.
That way if somebody misses an END tag or something of that nature, it will be
easy to find and fix.

Test Plan:
1) Apply this patch
2) Edit a notice, change the content to simply "[% END %]"
   or some other invalid Template Toolkit
3) Choose "Save and continue editing"
4) Note the new "Template Toolkit error" field that displays the error
   message

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:35:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:35:43 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-Eo8V3kcvhF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I really like this - I tested with a few different errors, including missing
and duplicated characters, and it works really well.  Thanks for the patch,
signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 17:44:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 15:44:43 +0000
Subject: [Koha-bugs] [Bug 31212] New: Datelastseen should be a datetime
Message-ID: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

            Bug ID: 31212
           Summary: Datelastseen should be a datetime
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

This field should be updated to be a datetime field and the interface adapted
to display the full date and time to help librarians track items

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:04:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:04:03 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-aGjDALrblg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:04:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:04:44 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-rSPG0MVPo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:04:48 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-OxovtGUVF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137959|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137986&action=edit
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for
'Lost item fee refund on return policy' and note default says 'Use default
(Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore
overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost
item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:11:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:11:04 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-xoZnhid9lC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:11:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:11:51 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-ZWSQySR1Re@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:11:55 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-gCK5leMxkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137955|0                           |1
        is obsolete|                            |

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137987&action=edit
Bug 31204: Clearly indicate edit buttons are for record modification

To test:
1. Apply patch
2. Do a search and select some records
3. On the toolbar (#selection_ops) open the Edit dropdown.
4. The labels should read 'Batch edit records' and 'Batch delete records'.

Note: To see both you must have batchmod and batchdelete permission.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:22:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:22:08 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-rBmXmAzrn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:22:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:22:32 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-oMCH32ofoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137947|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137988&action=edit
Bug 31202: Don't remove optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban <michalurban177 at gmail.com>
JK: Adjust commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:22:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:22:28 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-qoyeDq7JIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:23:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:23:50 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-xBG9bAGCdu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 18:56:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 16:56:57 +0000
Subject: [Koha-bugs] [Bug 26648] Prevent internal server error if item
 attached to old checkout has been removed
In-Reply-To: <bug-26648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26648-70-riImxSyq8z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26648

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:22:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:22:42 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-cGztuR7o6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|pasi.kallinen at koha-suomi.fi |kyle at bywatersolutions.com
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:23:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:23:46 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-myqG1qhBoQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:23:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:23:49 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-TGM0UyhWJZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130538|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137989&action=edit
Bug 29579: Show saved SQL report ID in database query

When trying to figure out which saved SQL report caused too much load, it's
useful to have the report id show in the mysql process list.

This patch adds the saved SQL ID number as a comment line in front
of the SQL before passing it to the database.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Create a long running query like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d
4) Connect to the database using koha-mysql
5) Execute "show processlist;"
6) Note the Info column looks something like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d
/*saved_sql.id: 1*/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:24:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:24:52 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-zcPkoInZ1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
I was working on this very same feature when I found this bug report. My
version does pass unit tests, probably due to the different commenting style I
chose. I changed up my string to more closely match what paxed did.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:26:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:26:01 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-zohf0oOGqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137989|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 137990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137990&action=edit
Bug 29579: Show saved SQL report ID in database query

When trying to figure out which saved SQL report caused too much load, it's
useful to have the report id show in the mysql process list.

This patch adds the saved SQL ID number as a comment line in front
of the SQL before passing it to the database.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Create a long running query like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d
4) Connect to the database using koha-mysql
5) Execute "show processlist;"
6) Note the Info column looks something like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d /*
saved_sql.id: 1 */

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:48:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:48:53 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-W11RbfJmLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 19:58:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 17:58:15 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-sHzJWbV5h0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:03:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:03:42 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-JVLczmxtXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:03:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:03:46 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-MqFqhwKlzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137904|0                           |1
        is obsolete|                            |

--- Comment #7 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137991&action=edit
Bug 29001: Fix framework edition when subfields are reordered

There is a flaw when subfields are ordered, the inputs are not retrieved
correctly.
We should not rely on the order but use an id instead.
Test plan:
Create, edit subfields
Modify values from the different subfields
Confirm that values are correctly saved

Signed-off-by: Thibault Kero <thibault.keromnes at univ-paris8.fr>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:03:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:03:53 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-KAw3GWDbI8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137992&action=edit
Bug 29001: (QA follow-up) Remove code duplication

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:16:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:16:12 +0000
Subject: [Koha-bugs] [Bug 31213] New: When performing a basic search with no
 results, repeat the search with term quoted
Message-ID: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

            Bug ID: 31213
           Summary: When performing a basic search with no results, repeat
                    the search with term quoted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Under elastic, when searching for some special characters a search may fail:
Ivy + Bean
The 6:20 man
etc.

These terms work when quoted:
"Ivy + Bean"

It would be nice if we just tried this automatically for the user

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:19:51 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-jjG4USGLrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:19:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:19:56 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-5HEwK7y9dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137993&action=edit
Bug 31213: Auto search simple term quoted

This patch does a second search if the first had no results and was a simple
single term search

We simply quote the term, rebuild the query, and rerun the search

This targets both Zebra and ES, but is more relevant for ES

To test:
0 - Have Koha running using ES
1 - Add titles your system "Ivy + Bean" "The 6:20 Man"
2 - Search for these titles without quotes - NO results under ES
3 - Search with quotes - you find them
4 - Apply patch, restart all
5 - Search again without quotes
6 - Success!
7 - Confirm search still works under Zebra

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:20:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:20:49 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-bLepT7DaYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org,
                   |                            |joonas.kylmala at helsinki.fi,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:21:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:21:14 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-JIL87dwEV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #119 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 137994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137994&action=edit
Bug 30952: (follow-up) Add Poppins font assets

This patch adds web font versions of Poppins, a font licensed under the
Open Font License. Providing a web version is necessary because not
everyone will have Poppins locally installed.

SCSS has been updated so that the staff interface uses this font by
default.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Visit various pages in the staff interface to confirm that the correct
font is being used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:22:04 +0000
Subject: [Koha-bugs] [Bug 31214] New: Regression: subfield code editable in
 MARC framework editor
Message-ID: <bug-31214-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214

            Bug ID: 31214
           Summary: Regression: subfield code editable in MARC framework
                    editor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at iki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 5917

The Subfield code field is incorrectly editable in the MARC framework subfield
configuration page, on e.g. on the page

http://localhost:8081/cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=003&frameworkcode= 

This is an regression from bug 5917 – When converting the old templating syntax
to Template toolkit syntax some of the code was missed and the old syntax was
left in the codebase. In marc
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt the
following line should be fixed:

> [% IF ( subfieldcode == 0 || subfieldcode ) %]

it should be 

> [% IF ( loo.subfieldcode == 0 || loo.subfieldcode ) %]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917
[Bug 5917] Switch Koha to use Template::Toolkit
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:22:04 +0000
Subject: [Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit
In-Reply-To: <bug-5917-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5917-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5917-70-xIsl4U7j08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31214


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214
[Bug 31214] Regression: subfield code editable in MARC framework editor
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:31:37 +0000
Subject: [Koha-bugs] [Bug 30546] Initial articles not ignored when sorting
 by the summary column in the pending_orders table
In-Reply-To: <bug-30546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30546-70-cIcM66tvg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30546

Abbey Holt <aholt at dubuque.lib.ia.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aholt at dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:34:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:34:21 +0000
Subject: [Koha-bugs] [Bug 31215] New: Add ability to select multiple items
 to remove from course_items
Message-ID: <bug-31215-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31215

            Bug ID: 31215
           Summary: Add ability to select multiple items to remove from
                    course_items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hebah at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Currently the only way to remove items from course reserves is to remove all
reserves or select items individually to remove. For libraries that use course
reserves with large courses, the ability to select multiple items at a time to
remove would be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:35:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:35:02 +0000
Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC
 framework editor
In-Reply-To: <bug-31214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31214-70-vVJlxK0Zgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214

--- Comment #1 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Commit causing the regression: Bug 5917 : Swapping templates over
(5884fb100071e973daf671a4ada6b32724376768)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 20:52:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 18:52:48 +0000
Subject: [Koha-bugs] [Bug 31203] Cronjobs should log completion as well as
 logging begin
In-Reply-To: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31203-70-og1O0MWVz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:04:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:04:52 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-AoPpJITOxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:04:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:04:55 +0000
Subject: [Koha-bugs] [Bug 29001] Subfields attributes are not preserved when
 order is changed in framework
In-Reply-To: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29001-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29001-70-zRh1cCr6T7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29001

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:05:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:05:03 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-aR1BC0mBO3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:04:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:04:57 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-Qz9DyiiPbJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:05:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:05:00 +0000
Subject: [Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in
 accountline when using "Payout amount" button
In-Reply-To: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30458-70-b4xuAOjCDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:05:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:05:06 +0000
Subject: [Koha-bugs] [Bug 30471] Typo in Circulation Rules - Lost item fee
 refund policy
In-Reply-To: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30471-70-BatXHS018v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30471

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:05:11 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-BoQGQjvq6F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 21:05:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 19:05:09 +0000
Subject: [Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a
 value of "0"
In-Reply-To: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31202-70-cM1HIaMfbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 22:51:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 20:51:02 +0000
Subject: [Koha-bugs] [Bug 31216] New: inventory.pl is slow when comparing
 many barcodes
Message-ID: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

            Bug ID: 31216
           Summary: inventory.pl is slow when comparing many barcodes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

According to NYTProf, most of our time is spent in fetching authorised values
and storing the items

We should improve the use of cache here and reduce store where we can

Just to note:
GetItemsForInventory translates the AVs in a single call which seems to be
quite fast

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 21 23:50:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 21:50:03 +0000
Subject: [Koha-bugs] [Bug 31217] New: Fix Coce JavaScript to hide
 single-pixel cover images in the OPAC lightbox gallery
Message-ID: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

            Bug ID: 31217
           Summary: Fix Coce JavaScript to hide single-pixel cover images
                    in the OPAC lightbox gallery
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

The shift to using a lightbox gallery to display cover images in the detail
pages of the OPAC has stopped Coce from hiding 1-pixel cover images.

This line (
https://github.com/Koha-Community/Koha/blob/0177b88eb33d398da4eb5ffb6344226930c3346b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js#L39
) should hide the coce-coverimg box from the OPAC for 1-pixel images. 

However, coce-coverimg is an id, not a class, in the OPAC detail page,
therefore, this JavaScript does not hide anything in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:02:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:02:25 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-goSfD3eA5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 137995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137995&action=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because OPAC coce.js targets coce-coverimg as a class, when it is
actually an ID.

Test plan:
1. Set:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. View the biblio in the OPAC. Observe an empty 'Coce image from
Amazon.com' box loads

4. Apply patch and restart services

5. Reload the same biblio record in the OPAC. Observe the empty 'Coce
image from Amazon.com' is not displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:03:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:03:34 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-IhF7cDFZhj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |alexbuckley at catalyst.net.nz
  Change sponsored?|---                         |Sponsored
             Status|NEW                         |Needs Signoff
         Depends on|                            |28180
   Patch complexity|---                         |Trivial patch


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180
[Bug 28180] Use a lightbox gallery to display the images on the detail pages in
OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:03:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:03:34 +0000
Subject: [Koha-bugs] [Bug 28180] Use a lightbox gallery to display the
 images on the detail pages in OPAC
In-Reply-To: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28180-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28180-70-SlwBm8JhAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28180

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31217


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217
[Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC
lightbox gallery
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:05:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:05:26 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-JO6UPcFEmf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
This is now ready for testing!

This is the coce-coverimg in opac-detail.tt (
https://github.com/Koha-Community/Koha/blob/0177b88eb33d398da4eb5ffb6344226930c3346b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L105
) as you can see it is an id, not a class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:27:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:27:37 +0000
Subject: [Koha-bugs] [Bug 31215] Add ability to select multiple items to
 remove from course_items
In-Reply-To: <bug-31215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31215-70-pZOVVkXFAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31215

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:28:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:28:54 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-OAAzGsuFb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:32:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:32:39 +0000
Subject: [Koha-bugs] [Bug 31209] Add span with class info to enumchron data
 in circulation.tt, for better styling
In-Reply-To: <bug-31209-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31209-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31209-70-hSOhA1vjwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I like the idea of it having its own column, that way you can sort issues by
enumchron if needed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:34:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:34:55 +0000
Subject: [Koha-bugs] [Bug 31210] Add option to use different library name in
 OPAC and staff interface
In-Reply-To: <bug-31210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31210-70-URYIXQ5QpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31210

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:36:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:36:32 +0000
Subject: [Koha-bugs] [Bug 31206] Highlight logged in library in green in
 Circ History
In-Reply-To: <bug-31206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31206-70-eBTWfP04lE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31206

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 00:37:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 22:37:28 +0000
Subject: [Koha-bugs] [Bug 31205] Adding Custom name to the 'From' field in
 email notices
In-Reply-To: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31205-70-QXGWfUGKm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 01:11:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 23:11:41 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-l4dGaux0Nm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134927|0                           |1
        is obsolete|                            |

--- Comment #9 from George Veranis <gveranis at dataly.gr> ---
Created attachment 137996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137996&action=edit
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

Signed-off-by: Felicity Brown <Felicity.Brown at montgomerycountymd.gov>
Signed-off-by: George Veranis <gveranis at dataly.gr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 01:14:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 23:14:45 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Mbyrb0lgOM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133103|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 01:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 23:14:55 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-uE7d88S9mH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133102|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 01:15:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 23:15:05 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-7wGe5Dl52u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133101|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 01:15:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jul 2022 23:15:29 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-pWmXbjw8sL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133050|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 03:27:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 01:27:52 +0000
Subject: [Koha-bugs] [Bug 31008] Long Term Support (LTS) version of Koha
In-Reply-To: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31008-70-pTF3FfsmBE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Discussed further at the Development IRC meeting 20 July 2022
http://irc.koha-community.org/koha/2022-07-20#i_2439428

See discussion and diagram 2 and 3 about the need to have 3.5 years of LTS
maintenance. https://lite.framacalc.org/29o8a7mlwc-9v57
tl;dr there need to be a year of overlap to allow jumping to LTS to LTS on the
any time of the year. To allow libraries to be able to pick or winter or summer
for example depending on their organization.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 03:43:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 01:43:53 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-vZsObOEkSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Why did the patch broke SuggestionEngine_ExplodedTerms.t btw? I don't get it
and might break other things if I use Koha::I18N in other places to clean up
strings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 03:59:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 01:59:31 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-x7O4iyAFoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #16 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 137997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137997&action=edit
Bug 23538: Database changes

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:00:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:00:13 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Ic5zazzJXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #17 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 137998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137998&action=edit
Bug 23538: Email library when new patron self-registers

Test plan:
1. Apply all patches
2. Update database
3. Restart services
4. Set email addresses in:
- KohaAdminEmailAddress syspref
- EmailAddressForPatronRegistrations syspref
- Email address in the library branch
5. Enable PatronSelfRegistration syspref
6. Test the following use cases:

- EmailPatronRegistrations syspref = 'none'.
Submit OPAC registration.
= OUTCOME: Confirm no OPAC_REG notice in message_queue table

---

-  EmailPatronRegistrations syspref = 'email address of branch'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling the branch address

---

- EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling EmailAddressForPatronRegistrations syspref

---

- EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling KohaAdminEmailAddress syspref

7. Enable PatronSelfRegistrationVerifyByEmail syspref
8. Repeat testing all use cases. Confirm this time the expected outcomes only
happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY
notice

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:00:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:00:49 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-LBmZJ47Y1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133102|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:00:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:00:53 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-g6OhV9OVBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133103|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:10:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:10:21 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-flCWj8ZYQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133102|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:10:33 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-ObxzJJZmup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133103|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:10:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:10:47 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-GaRVhVABOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137998|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:11:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:11:16 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Kw3eX8XcxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #18 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 137999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137999&action=edit
Bug 23538: Email library when new patron self-registers

Test plan:
1. Apply all patches
2. Update database
3. Restart services
4. Set email addresses in:
- KohaAdminEmailAddress syspref
- EmailAddressForPatronRegistrations syspref
- Email address in the library branch
5. Enable PatronSelfRegistration syspref
6. Test the following use cases:

- EmailPatronRegistrations syspref = 'none'.
Submit OPAC registration.
= OUTCOME: Confirm no OPAC_REG notice in message_queue table

---

-  EmailPatronRegistrations syspref = 'email address of branch'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling the branch address

---

- EmailPatronRegistrations syspref = 'EmailAddressForPatronRegistrations'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling EmailAddressForPatronRegistrations syspref

---

- EmailPatronRegistrations syspref = 'KohaAdminEmailAddress'.
Submit OPAC registration.
= OUTCOME: Confirm OPAC_REG notice in message_queue with to_address
equalling KohaAdminEmailAddress syspref

7. Enable PatronSelfRegistrationVerifyByEmail syspref
8. Repeat testing all use cases. Confirm this time the expected outcomes only
happen AFTER you have clicked the verification link in the OPAC_REG_VERIFY
notice

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:11:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:11:46 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-GGk5pm8Of7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #19 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138000&action=edit
Bug 23538: Unit tests

Test plan:
1. Run unit tests:
sudo koha-shell <instance>
cd t/db_dependent/Koha
prove -v Patron.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 04:12:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 02:12:19 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-fNNvfnavbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #20 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138001&action=edit
Bug 23538: (follow-up) Fix up notices

- Add toolkit template (TT) syntax to notices
- Add TT conditionals to notices
- Add translated notice

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 05:19:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 03:19:34 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-RZc1oHfNlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #21 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Lucas, 

Apologies for the delay rebasing. This is now rebased and is ready for testing
again.

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 06:32:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 04:32:25 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-PefWrQ6eRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #41 from David Cook <dcook at prosentient.com.au> ---
I've asked folk to QA this a few times and just gotten silence, so I'm thinking
we should look for someone else to sign off on this report, and then I'll join
the QA team for Koha 22.11. 

I'd been on the QA team before but hadn't contributed heaps so I let myself
slide off it, but I think maybe it would be good to get back onto it,
especially to move along important changes like this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 06:44:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 04:44:10 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
 HTML customizations
In-Reply-To: <bug-29782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29782-70-2QRRR41iUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
I'm not sure I follow 100% but I'm not sure that this should be marked as
"critical" importance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 07:59:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 05:59:14 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-U1Ft7GTcCW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hi Alex,

I didn't test the patch, bug had a look at it.

A couple of remarks:
1. if you have the id you don't need to use a parent, the line could simply be
  $("#coce-coverimg").remove();
2. I am wondering if staff-side as well:

koha-tmpl/intranet-tmpl/js/coce.js:                               
$(this).closest(".coce-coverimg").remove();

We are using an id on the detail page
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:                   
    <div class="cover-image" id="coce-coverimg">

BUT a class on the result list
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:                  
 <div id="coce-coverimg-[% SEARCH_RESULT.biblionumber | html %]"
class="cover-image coce-coverimg">

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 08:15:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 06:15:55 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-UGiVpyaKoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #29 from David Cook <dcook at prosentient.com.au> ---
This is arguably a database management problem rather than a Koha problem per
se, no?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 08:16:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 06:16:55 +0000
Subject: [Koha-bugs] [Bug 27665] Clarify usage of matching dropdown on
 addorderiso2709.pl
In-Reply-To: <bug-27665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27665-70-mIta09AK6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27665

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I think this could probably be downgraded from "critical" importance?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 08:24:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 06:24:13 +0000
Subject: [Koha-bugs] [Bug 30821] unable to install plugin. throws error 500
In-Reply-To: <bug-30821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30821-70-7siitSWmyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30821

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
           Severity|major                       |normal
                 CC|                            |dcook at prosentient.com.au
             Status|NEW                         |RESOLVED

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
That's a 4 year upgrade so some hiccups aren't surprising and there hasn't been
a response for 2 months, so I think this probably isn't an issue anymore.
Likely was just an issue with the plugins needing an upgrade.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 08:28:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 06:28:40 +0000
Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized
 PDF files.
In-Reply-To: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28806-70-n5fktxP67s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Manos PETRIDIS from comment #0)
> In my first tries to create biblio labels, I see that export to PDF creates
> zero sized PDF files, in both individual/single and batch modes.  
> 
> Coult it be due to non-latin characters (Greek) appearing in the label
> contents? 

I don't think so. If the font can't print the Greek characters, it should just
not print them, but it should still generate a PDF. (I was working out some
issues with Chinese characters not printing recently.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 08:34:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 06:34:11 +0000
Subject: [Koha-bugs] [Bug 16327] Running build_oai_sets.pl with embed items
 option should consider every item in a biblio
In-Reply-To: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16327-70-dccWkr6ebj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16327

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Did you fancy submitting that as a patch.. is this still valid in master now?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 09:20:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 07:20:07 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-uvaNzmfUTH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is looking good.. a few comments of where I'd love to see it headed and
one that is unfortunately a QA fail at the moment.

QA Fail
* We're missing Unit Tests for the new module you introduce, I'm afraid that's
a hard fail for now.  It also looks like you have a note to do validation here
which is missing... little confused as it looks like you are passing in a json
structure rather than the token string.. so I'd have expected that to already
be verified?  We could perhaps just use an existing library for this Mojo::JWT
for instance?

Future
1. I'd love to see this moved out of preferences and into it's own management
page.. I could see multiple OpenIDConnect providers being configured at the
same time and allowing the end user to 'Pick their poison' at login.
2. If we went the above route, I'd love to see the Google stuff pulled out and
the preferences it uses also migrated into the above management area.
3. The controller/svc script is pretty heavy right now.. I'd love to have seen
more of this done 'in module' and have the controller lighter and perhaps in
the REST side of things rather than a new /svc.. but I'm honestly not sure how
it would fit in REST as yet so have no issue with it in /svc for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 09:51:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 07:51:35 +0000
Subject: [Koha-bugs] [Bug 31214] Regression: subfield code editable in MARC
 framework editor
In-Reply-To: <bug-31214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31214-70-bwQpBml7jE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31214

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We noticed this too and were torn between bug or feature, but it doesn't work
right and isn't really useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:00:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:00:05 +0000
Subject: [Koha-bugs] [Bug 27665] Clarify usage of matching dropdown on
 addorderiso2709.pl
In-Reply-To: <bug-27665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27665-70-86Crea4mqY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27665

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Agree. This might be in a grey area to enh too?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:00:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:00:25 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-HFhyN0CPS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Yes and no.. the packages are generally expected to just "do the right thing"
so if there is an appraisal we can take to "fix" peoples databases, we probably
should.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:01:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:01:24 +0000
Subject: [Koha-bugs] [Bug 31218] New: Add a way to add new columns to item
 search results
Message-ID: <bug-31218-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31218

            Bug ID: 31218
           Summary: Add a way to add new columns to item search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathsabypro at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There should be a way for the admin to add any item subfield (even if not
mapped to a SQL field) to the results of item search (screen display and CSV
export)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:04:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:04:28 +0000
Subject: [Koha-bugs] [Bug 29782] Missing entries for display locations in
 HTML customizations
In-Reply-To: <bug-29782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29782-70-ziYWNfV6t8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The problem here is that we might create entries that exist in the database and
display, but can't be deleted or edited without using SQL. As this effects the
OPAC I think the importance is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:05:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:05:21 +0000
Subject: [Koha-bugs] [Bug 31218] Add a way to add new columns to item search
 results
In-Reply-To: <bug-31218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31218-70-7hGnEYoaKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31218

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it might be nice to have a "clever" solution that makes sure besides a
base set the columns with the criteria you searched for always show. But this
might be quite hard to achieve.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:06:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:06:55 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-Z5kujHYNM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #41)
> I've asked folk to QA this a few times and just gotten silence, so I'm
> thinking we should look for someone else to sign off on this report, and
> then I'll join the QA team for Koha 22.11. 
> 
> I'd been on the QA team before but hadn't contributed heaps so I let myself
> slide off it, but I think maybe it would be good to get back onto it,
> especially to move along important changes like this one.

We are happy to have you for this cycle too if you are interested. In the
summer time (Europe etc.) we are always struggling a bit more.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:08:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:08:37 +0000
Subject: [Koha-bugs] [Bug 26654] Add item number column to item search
 results
In-Reply-To: <bug-26654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26654-70-EpV0qJEsf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26654

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:08:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:08:47 +0000
Subject: [Koha-bugs] [Bug 15787] Show and export itemnumber and biblionumber
 via the item search
In-Reply-To: <bug-15787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15787-70-bMpGl9SbT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15787

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:13:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:13:58 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-RCTsLcXAvo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137993|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138002&action=edit
Bug 31213: Auto search simple term quoted

This patch does a second search if the first had no results and was a simple
single term search

We simply quote the term, rebuild the query, and rerun the search

This targets both Zebra and ES, but is more relevant for ES

To test:
0 - Have Koha running using ES
1 - Add titles your system "Ivy + Bean" "The 6:20 Man"
2 - Search for these titles without quotes - NO results under ES
3 - Search with quotes - you find them
4 - Apply patch, restart all
5 - Search again without quotes
6 - Success!
7 - Confirm search still works under Zebra

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:14:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:14:25 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-8r14VXW7SZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works great, thanks Nick - signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:23:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:23:03 +0000
Subject: [Koha-bugs] [Bug 31050] Standardize session setup
In-Reply-To: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31050-70-KlON1PVfxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136566|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138003&action=edit
Bug 31050: C4::Context->setup_session() standardizes user session setup

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Log into http://localhost:8081/cgi-bin/koha/mainpage.pl using "koha" user
2. Note the login is successful

3. koha-mysql kohadev
3a. select * from sessions;
Session in MySQL sets parameters like surname, flags, interface, ip, lasttime,
etc
3b. select * from systempreferences where variable = 'Version';
3c. update systempreferences set value = '<version which is 1 number less at
the end>' where variable = 'Version';

4. koha-plack --restart kohadev
5. echo 'flush_all' | nc -q 1 memcached 11211

6. Visit http://localhost:8081/ and do the upgrade
6b. Note that the authentication and upgrade works without a problem

7. curl http://localhost:8081/cgi-bin/koha/svc/authentication -d 'userid=<koha
user>&password=<koha password>'

8. koha-mysql kohadev
8a. select * from sessions;
Session in MySQL sets parameters like surname, flags, interface, ip, lasttime,
etc

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:24:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:24:03 +0000
Subject: [Koha-bugs] [Bug 31050] Standardize session setup
In-Reply-To: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31050-70-Lqg9sUFycA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This is a nice bit of code cleaning, thanks David.. as you suggested, it might
be nice as a next step to allow just passing a Patron object and then
constructing the various fields from that.. could have a nice reduction in line
count again.

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:27:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:27:30 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-h0u3hS61qs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great idea

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:30:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:30:10 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-1KL8mKXGf7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138002|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138004&action=edit
Bug 31213: Auto search simple term quoted

This patch does a second search if the first had no results and was a simple
single term search

We simply quote the term, rebuild the query, and rerun the search

This targets both Zebra and ES, but is more relevant for ES

To test:
0 - Have Koha running using ES
1 - Add titles your system "Ivy + Bean" "The 6:20 Man"
2 - Search for these titles without quotes - NO results under ES
3 - Search with quotes - you find them
4 - Apply patch, restart all
5 - Search again without quotes
6 - Success!
7 - Confirm search still works under Zebra

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:31:05 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-JPxCwG9NwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as described and the QA scripts are happy..

I wondered if we could possibly move it up a level into the modules but decided
that's either a silly idea, or something for a future piece..

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:31:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:31:57 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-bn8RHdCqVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 from me as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:35:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:35:12 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-SZVkb5yhHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #20 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Please have a look at Bug 28327 where I try to centralize the tabulation
special case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:36:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:36:21 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-VI8RoV0ZjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20.11                       |master
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:37:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:37:25 +0000
Subject: [Koha-bugs] [Bug 21135] Upon log in,
 user is redirected to account page instead of the page where they
 logged in from
In-Reply-To: <bug-21135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21135-70-GwxRDigm6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:38:17 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-LcSs7Lx6bt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

--- Comment #15 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Greaaaaaate thanks to all.
This was a huge performance issue for some cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:38:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:38:51 +0000
Subject: [Koha-bugs] [Bug 27683] Bind results of GetAnalyticsCount to the
 EasyAnalyticalRecords pref
In-Reply-To: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27683-70-BHTbgGexL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683

--- Comment #16 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Pleaaaaaaaaaase backport to 22.05 and 21.11.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:47:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:47:39 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-rgV7QNd6zU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:48:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:48:23 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-6TK7m9lObM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:49:17 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-YLXzpZYDeE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137432|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138005&action=edit
Bug 31121: Fix date formatting in cashup summary modal

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:49:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:49:53 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-o0mDp6aVNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin Somers from comment #20)
> Please have a look at Bug 28327 where I try to centralize the tabulation
> special case.

This doesn't depend on the pref, but is a per CSV profile setting. So my
impresison was they complement each other.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:50:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:50:06 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-nzHrXa8v0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 10:55:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 08:55:21 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-AsGXOfRU3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I just tested this a second time because I didn't remember my sign-off.
deciding to go to PQA given it's an easy patch and the number of bugs in queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:02:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:02:56 +0000
Subject: [Koha-bugs] [Bug 29987] Manual credits are not recorded for a
 register
In-Reply-To: <bug-29987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29987-70-JftzrAyurL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29987

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can confirm David's findings in comment#8. Setting to Failed QA for now as I
feel that the display on the cash register transactions and summary is not
right yet.

I do think the payment type option on the credit page is the right way to go,
but probably needs some more adjustments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:07:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:07:18 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-gXNVxMmqJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138006&action=edit
Bug 31086: (QA follow-up) Improve atomicupdate to be more resilient

We now populate the branchcode field with the first available branch on
the system if we find it to be NULL before we set the NOT NULL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:06:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:06:39 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-GLwNGQ8XMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:27:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:27:39 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-onmul9v3fB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #73 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Overall, this works really well, but I found a small display glitch:

If the user (in my case it was 42) has no first name, the display is:

22.07.2022 09:25 Renewed by null koha

Possibly the same issue arises if there is no surname.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:33:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:33:57 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-bxKwd2TkxH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 11:57:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 09:57:39 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-HuCkG9jw3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138007&action=edit
Bug 23838: Use $patron_to_html formater

This patch updates the renewals modal to correctly format the staff
member who renewed the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:00:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:00:46 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-IkNXa8IKOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:08:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:08:52 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-k9OzHIScFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #5 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Andreas Roussos from comment #3)
> Because of that, the display of local cover images in the
> OPAC Shelf browser has never worked as intended when the SysPref
> OpacSeparateHoldings is set to 'Separate'.
Apologies, I just double-checked what I wrote above and it's not 100%
valid. There is indeed a problem in master that relates to the display
of local cover images in the OPAC when OpacSeparateHoldings is set to
'Separate', but it occurs at a different level and under specific
conditions (and since it's not OPAC Shelf browser-specific, I think
it'd be better if I filed a new bug report for it).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:43:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:43:35 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-zpMwAOgYb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:43:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:43:33 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-JwOAbSjURY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:42:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:42:24 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-1gn61CCN4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I wondered if it was as simple as just running it through RecordProcessor.. but
when I started to have a quick look at the code I couldn't wrap my head around
it.. perhaps not as simple as it appears on the surface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 12:46:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 10:46:03 +0000
Subject: [Koha-bugs] [Bug 28553] Patrons can be set to receive auto_renew
 notices as SMS, but Koha does not generate them
In-Reply-To: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28553-70-0jkGy038PC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:07:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:07:16 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-DB4Xz7Hbw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Victor Grousset/tuxayo from comment #11)
> Why did the patch broke SuggestionEngine_ExplodedTerms.t btw? I don't get it
> and might break other things if I use Koha::I18N in other places to clean up
> strings.

It was probably a unique case in the codebase. A template that is used from a
.pm file that didn't use get_template_and_user that also had really complex and
fragile mocks in the tests...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:10:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:10:48 +0000
Subject: [Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many
 barcodes
In-Reply-To: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31216-70-ikAWXzvGa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 138008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138008&action=edit
Bug 31216: Make one call to fetch AVs before substituting

This patch copies logic from GetItemsForInventory as it proves
much faster at updating values

Probably this should be a subroutine? BUt we have cachign patches in the
works too (bug 30920)

Additionally - it looks like current inventory code looks for framework from
items, but I am
not sure we fetch it anywhere

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:17:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:17:48 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-NeXZzpX2wt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:30:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:30:37 +0000
Subject: [Koha-bugs] [Bug 21135] Upon log in,
 user is redirected to account page instead of the page where they
 logged in from
In-Reply-To: <bug-21135-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21135-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21135-70-3lvhVXAoH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21135

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:36:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:36:03 +0000
Subject: [Koha-bugs] [Bug 31220] New: Error when attempting to export
 selected labels as PDF
Message-ID: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

            Bug ID: 31220
           Summary: Error when attempting to export selected labels as PDF
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To recreate:
1 - Create a new label batch with some items
2 - Select 1 or more
3 - Export selected labels
4 - Download as PDF
5 - BOOM

Can't locate object method "get_attr" via package "-2" (perhaps you forgot to
load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line
126.


It looks like bug 26340 accidentally touched the selected label export and
removed batch number and label ids

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:44:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:44:40 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-egyllFYyds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
         Depends on|                            |26340


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340
[Bug 26340] When printing labels from a barcode range, keep zero padding
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:44:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:44:13 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-SDA7WKo0Gl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:44:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:44:17 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-kmlNMDsK1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 138009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138009&action=edit
BUg 31220: Pass label batch and ids to label-create-pdf

This patch fixes a malformed link to print selected labels
and fix error:
Can't locate object method "get_attr" via package "-2" (perhaps you forgot to
load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line
126.

To test:
1 - Create a new label batch with some items
2 - Select 1 or more
3 - Export selected labels
4 - Download as PDF
5 - It works!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:44:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:44:40 +0000
Subject: [Koha-bugs] [Bug 26340] When printing labels from a barcode range,
 keep zero padding
In-Reply-To: <bug-26340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26340-70-oRZO7Ud19E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26340

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31220


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220
[Bug 31220] Error when attempting to export selected labels as PDF
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:49:50 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-2KeyuChKI6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #6 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 138010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138010&action=edit
Bug 31207: Fix the display of local cover images in the OPAC Shelf browser

In the OPAC Details page for a biblio, opening the Shelf browser
results in a nice display of adjacent items next to each other
based on their call number, which also shows any cover images
found. Since 21.11.00 this has been broken when local covers are
exclusively in use, as it fails to fetch the related images that
have been uploaded *at the biblio level*.

This patch fixes that by adding back TT code that was removed
in commit fad97080e97da5bc77724c68b9394aba15518847 (Bug 28180).

Test plan:

0) Under Home > Administration > System preferences:
   - in section 'OPAC -> Shelf browser', make sure OPACShelfBrowser
     is enabled (i.e. set to 'Show')
   - in section 'Enhanced content -> Local or remote cover images',
     make sure both LocalCoverImages and OPACLocalCoverImages
     are enabled (i.e. set to 'Show')
   - make sure no other cover image provider is enabled
   - make sure OpacSeparateHoldings and OpacSeparateHoldingsBranch
     are set to 'Don't separate' and 'home library', respectively

1) In the Staff interface, create a record that has:
   - a local cover image at the biblio level (use the 'Images' tab
     in the Details page of the record to upload a test image)
   - at least one item attached to it that has a Call number (the
     call number value can be anything -- it's only needed to
     trigger the display of the 'Browse shelf' hyperlink)

2) In the OPAC, visit the Details page of the record you just added
   the cover image to, and click on the 'Browse shelf' link found
   in the 'Call number' column. When the Shelf browser expands,
   you'll notice there's no cover image displayed for the item(s)
   that belong to your test biblio.

3) Apply the patch and refresh the OPAC biblio Details page.
   This time the shelf browser should display the local cover images
   associated with your test record.

4) Make sure the relevant unit test passes:

   prove -v t/db_dependent/ShelfBrowser.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:56:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:56:37 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-9gCfe6wUWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138009|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138012&action=edit
BUg 31220: Pass label batch and ids to label-create-pdf

This patch fixes a malformed link to print selected labels
and fix error:
Can't locate object method "get_attr" via package "-2" (perhaps you forgot to
load "-2"?) at /usr/share/koha/intranet/cgi-bin/labels/label-create-pdf.pl line
126.

To test:
1 - Create a new label batch with some items
2 - Select 1 or more
3 - Export selected labels
4 - Download as PDF
5 - It works!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:49:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:49:46 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-Gc0L6GYAO7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:57:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:57:41 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-jibPC0CvxF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Nice fix - works as described, so signing off. Thanks for the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 13:49:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 11:49:54 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-XWinxlSCgr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #7 from Andreas Roussos <a.roussos at dataly.gr> ---
Created attachment 138011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138011&action=edit
Bug 31207: Add Selenium test for the OPAC Shelf browser

This adds a new Selenium test to automatically test the
functionality of the OPAC Shelf browser with regards to the
display of local cover images. This unit test has a somewhat
narrow scope at the moment (i.e. it only checks if everything
is working fine when local covers are in use), but can be
expanded in the future to include OPAC Shelf browser tests for
other cover image providers, etc.

Also added are two sample images to be used by the test when
uploading a local cover image. They come from the Unsplash
website and have this license: https://unsplash.com/license
Attribution to the image creators is given in the test code.

Test plan:

1) Apply the other patch from this bug report, then run the
   new Selenium unit test which should pass without failures:

   cd t/db_dependent/selenium/
   prove -v opacshelfbrowser.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:37:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:37:03 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-fyJ5a3TUFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I like nicks addition to my follow-up.. best of all worlds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:32:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:32:16 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-FtcGPVqDqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #25 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 138018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138018&action=edit
Bug 31086: Notify of problematic holds during upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:26:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:26:02 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-FgNDjBrLh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138014&action=edit
Bug 30471: Correct display of default rules

To test:
1 - Browse to 'Administration->Circulation and fines rules'
2 - Make sure you are editing 'Standard rules for all libraries'
3 - Set 'Lost item fee refund on return policy' to 'Refund lost item charge and
charge new overdue fine'
4 - Swtich to edit rules for a specific library, click on the dropdown for
'Lost item fee refund on return policy' and note default says 'Use default
(Refund lost item charge and restore overdue fine)'
5 - Switch default/all libraries rule to 'Refund lost item charge and restore
overdue fine'
6 - On specific branch note the default option is now 'Use default (Refund lost
item charge and charge new overdue fine)'
7 - Apply patch and repeat, note the default descriptions now display correctly

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:27:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:27:24 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-0xk2BXxGCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Sorry for the noise - I messed up on the number of patches to sign off from the
sandbox.  :(

But the patch works great - appreciate the solid test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:36:36 +0000
Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie
 Legislation via cookie consent
In-Reply-To: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27378-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27378-70-FoMCo9TFPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some stuff:

1) Old style database updates (we got 4 separate ones for the prefs). Might be
worth combining them into one atomicupdate.

2) I think the system preference descriptions are not all self explanatory. I
am struggling with a little with this one:

+         - Specify Javascript that requires user consent to run (e.g. tracking
code)
+         - pref: ConsentJS
+           type: modaljs
+           initiator: populateConsentJS
+           processor: prepareConsentJS

3) New codes cannot be saved in ConsentJs

And also getting stuck here in the test plan:

12. Enter a name and description, and check both checkboxes.
    - For "String used to identify cookie name", enter "test1", this enables us
to delete the cookie when consent is withdrawn.
    - For "Cookie domain" enter the domain of your Koha.
    - For "Cookie path" enter "/"

I have entered: 
Name: Test
Description: Testing consent
Requires consent in OPAC: checked
Requires consent in staff interface: checked
String used to identify cookie name: test1
Cookie domain: localhost
Cookie path: /

When I try to save, I get: You must complete all fields.

x) Future enhancement ideas:

* Move CookieConsentBar and CookieConsentPopup to HTML customizations, so they
can be provided in multiple languages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:25:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:25:33 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-Et7w2w92p0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138011|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138013&action=edit
Bug 31207: Add Selenium test for the OPAC Shelf browser

This adds a new Selenium test to automatically test the
functionality of the OPAC Shelf browser with regards to the
display of local cover images. This unit test has a somewhat
narrow scope at the moment (i.e. it only checks if everything
is working fine when local covers are in use), but can be
expanded in the future to include OPAC Shelf browser tests for
other cover image providers, etc.

Also added are two sample images to be used by the test when
uploading a local cover image. They come from the Unsplash
website and have this license: https://unsplash.com/license
Attribution to the image creators is given in the test code.

Test plan:

1) Apply the other patch from this bug report, then run the
   new Selenium unit test which should pass without failures:

   cd t/db_dependent/selenium/
   prove -v opacshelfbrowser.t

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:26:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:26:11 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-ZTDyvaEMW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138010|0                           |1
        is obsolete|                            |

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138016&action=edit
Bug 31207: Fix the display of local cover images in the OPAC Shelf browser

In the OPAC Details page for a biblio, opening the Shelf browser
results in a nice display of adjacent items next to each other
based on their call number, which also shows any cover images
found. Since 21.11.00 this has been broken when local covers are
exclusively in use, as it fails to fetch the related images that
have been uploaded *at the biblio level*.

This patch fixes that by adding back TT code that was removed
in commit fad97080e97da5bc77724c68b9394aba15518847 (Bug 28180).

Test plan:

0) Under Home > Administration > System preferences:
   - in section 'OPAC -> Shelf browser', make sure OPACShelfBrowser
     is enabled (i.e. set to 'Show')
   - in section 'Enhanced content -> Local or remote cover images',
     make sure both LocalCoverImages and OPACLocalCoverImages
     are enabled (i.e. set to 'Show')
   - make sure no other cover image provider is enabled
   - make sure OpacSeparateHoldings and OpacSeparateHoldingsBranch
     are set to 'Don't separate' and 'home library', respectively

1) In the Staff interface, create a record that has:
   - a local cover image at the biblio level (use the 'Images' tab
     in the Details page of the record to upload a test image)
   - at least one item attached to it that has a Call number (the
     call number value can be anything -- it's only needed to
     trigger the display of the 'Browse shelf' hyperlink)

2) In the OPAC, visit the Details page of the record you just added
   the cover image to, and click on the 'Browse shelf' link found
   in the 'Call number' column. When the Shelf browser expands,
   you'll notice there's no cover image displayed for the item(s)
   that belong to your test biblio.

3) Apply the patch and refresh the OPAC biblio Details page.
   This time the shelf browser should display the local cover images
   associated with your test record.

4) Make sure the relevant unit test passes:

   prove -v t/db_dependent/ShelfBrowser.t

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:26:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:26:14 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-h5M5AZL2B8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138013|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138017&action=edit
Bug 31207: Add Selenium test for the OPAC Shelf browser

This adds a new Selenium test to automatically test the
functionality of the OPAC Shelf browser with regards to the
display of local cover images. This unit test has a somewhat
narrow scope at the moment (i.e. it only checks if everything
is working fine when local covers are in use), but can be
expanded in the future to include OPAC Shelf browser tests for
other cover image providers, etc.

Also added are two sample images to be used by the test when
uploading a local cover image. They come from the Unsplash
website and have this license: https://unsplash.com/license
Attribution to the image creators is given in the test code.

Test plan:

1) Apply the other patch from this bug report, then run the
   new Selenium unit test which should pass without failures:

   cd t/db_dependent/selenium/
   prove -v opacshelfbrowser.t

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:26:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:26:07 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-1lddHyf8Gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138015&action=edit
Bug 30458: Include librarian (manager_id) in accountline when using "Payout
amount" button

When using the "Payout amount" button, accountlines.manager_id is not
populated. This is not the case with the "Issue payout" buttons.

Test Plan:
1) Create a manual credit
2) Issue a payout using the "Payout amount" button
3) Inspect the payout accountline, note it has no manager_id
4) Apply this patch, restart all the things!
5) Repeat steps 1 and 2
6) Note the new payout accountline has a manager_id!

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
JK: Fix commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:01:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:01:07 +0000
Subject: [Koha-bugs] [Bug 13550] Automatic processing status
In-Reply-To: <bug-13550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13550-70-joRvb84l8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13550

mathieu saby <mathsabypro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathsabypro at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 14:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 12:51:30 +0000
Subject: [Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many
 barcodes
In-Reply-To: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31216-70-UrwFlrWB25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks good to me at first glance.. just about to head off on vacation though so
will have to leave a proper review for me return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:48:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:48:34 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-0bB7hRJA50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:29:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:29:15 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-owkHNGDfnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:29:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:29:19 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-9sW0tamroS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137593|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138023&action=edit
Bug 31128: Unit tests

This patch adds unit tests for the new effective_not_for_loan_status
which I add to the items api responses in this patchset.

Test plan
1) Run the unit test without applying the next commit, it should fail
2) RUn the test again after applying the next commit, it should pass

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:48:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:48:25 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-IlnWDT5ZJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think using the smsalertnumber is the correct behaviour, but I am a little
worried about someone relying on the fallback. I think because of the behaviour
change this might not be for backporting and needs a note?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:47:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:47:03 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-IIJTVDaBOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:25:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:25:21 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-HGwTv4rpUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137168|0                           |1
        is obsolete|                            |

--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138020&action=edit
Bug 23838: Use $datetime formater

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:30:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:30:48 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-Zfbexc1QUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Version|unspecified                 |master
            Summary|to_address is misleading    |to_address is misleading
                   |for sms transports          |for SMS transports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:47:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:47:08 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-qptmfg5QRD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136674|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138025&action=edit
Bug 30838: Don't fallback through phone numbers for sms

This patch removes the fallback handling for smsalartnumber as the
to_address in notices. We ignore the to_address field in the message
queue at send time for sms anyway and use smsalertnumber exclusively so
having this field populated is just confusing to the end user

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:47:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:47:12 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-43OIu7aKt1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136675|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138026&action=edit
Bug 30838: Set to_address to smsalertnumber at send

It may be helpful to know exactly what number was used for the sms alert
that was sent. As such, we should ensure it's set at the time of
sending.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:47:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:47:16 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-iSk6IiZYZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136676|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138027&action=edit
Bug 30838: (QA Follow-up) Add missing semicolon

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:29:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:29:24 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-qImhetE3ud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137594|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138024&action=edit
Bug 31128: Add effective_not_for_loan_status into items response

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:47:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:47:20 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-KqJU1PvDPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137202|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138028&action=edit
Bug 30838: (QA follow-up) Add unit tests

Two tests added, one in t/db_dependent/Circulation.t to catch the
initial setting of to_address at enqueue time and a second in
t/db_dependent/Letters.t to catch the correcting at send time.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:25:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:25:31 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-pI018pBe6a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138007|0                           |1
        is obsolete|                            |

--- Comment #78 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138022&action=edit
Bug 23838: Use $patron_to_html formater

This patch updates the renewals modal to correctly format the staff
member who renewed the checkout.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:25:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:25:26 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-DQ7l4Ueha3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137169|0                           |1
        is obsolete|                            |

--- Comment #77 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138021&action=edit
Bug 23838: (follow-up) Add missing template filter

Quieting an issue highlighted by the QA tool.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:25:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:25:10 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-bnSNpuaGuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Medium patch                |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:27:06 +0000
Subject: [Koha-bugs] [Bug 31128] REST API item not_for_loan status doesn't
 respect biblio level fallbacks
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-iARCIsDDrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API item               |REST API item not_for_loan
                   |not_for_loan_status doesn't |status doesn't respect
                   |respect biblio level        |biblio level fallbacks
                   |fallbacks                   |
         QA Contact|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:25:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:25:15 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-wyJXPLyPNz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137167|0                           |1
        is obsolete|                            |

--- Comment #75 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138019&action=edit
Bug 23838: Add renewals modal

This patch adds the display of the renewals modal when appropriate. A
"View" link is displayed next to renewals count where appropriate.
Clicking the link opens the modal that displays the logged renewals.

Sponsored-by: Loughborough University
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>
Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

I rescued this patchset by squashing previous work and updating it to
utilise the new renewals API routes introduced in bug 30275.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:14:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:14:08 +0000
Subject: [Koha-bugs] [Bug 31221] New: Buttons overflow in opac search
 results in mobile view
Message-ID: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

            Bug ID: 31221
           Summary: Buttons overflow in opac search results in mobile view
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: shi-yao.wang at inLibro.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
1- Have at least 10 record of the same type that can be viewed from OPAC
2- Go to administration > system preferences > OPACnumSearchResults and set it
to 1
3- Go to the OPAC and search for the type from step 1
4- Notice top and bottom page selections are numbered from 1 to 10 + Next >> +
Last >>
5- Inspect the webpage and switch to mobile view
6- Reduce display width and notice the buttons (of step 4) on the right are
overflowing the screen



My fix:
Go to administration > system preferences > OPACUserCSS and write:
@media (max-width: 609px) {
    #top-pages > .pagination > .pagination,
    #bottom-pages > .pagination > .pagination {
        flex-wrap: wrap;
    }
}

#top-pages > .pagination,
#bottom-pages > .pagination{
  flex-direction: column;
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:32:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:32:04 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-clLGWky3Yc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137615|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138030&action=edit
Bug 31138: Don't ignore DataTables errors and raise them to the end-user

DataTables is not raising error to the end user, it's only displaying a generic
message in the console.
This leads to lot of questions on IRC or the mailing list ("the table is
empty").
We can do better and display what went wrong.

We could also imagine add a link to the wiki for the more common problems
(won't be implemented here however).

Test plan:
Revert "Bug 31104: Put each link on a separate header" and search for a
patron using a very long string
You should get an alert with the reponse of the server.
In my case:
"""
Something went wrong when loading the table.
414: Request-URI Too Long
"""

You can also make the REST API returns a 500 (bad specs or simply with a
die statement).

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 15:56:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 13:56:38 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-J7CVprWtvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madamyk at ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:26:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:26:57 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-R1kVmSZOXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136404|0                           |1
        is obsolete|                            |

--- Comment #44 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138029&action=edit
Bug 11300: Add a new authority linker which searches for authority links on a
Z39.50 server.

This patch adds a Z39.50 Linker which searches for authority links on a remote
server.

If a matching authority is found, it's imported in the local database for
linking with the current biblio record.

If no matching authority was found on the remote server, the Linker falls back
to a local authority search.

Configuration :
* The option "Z39.50 Server" is added to the LinkerModule preference. You must
choose this to use the new Linker.
* The preference LinkerZ3950Server is required and specifies which server to
use for linking. It must contain the "name" of the server, as defined in the
z3950servers table.
* You can set the "local_first" option in the LinkerOptions preference to force
the Linker to search for authorities in the local database first. If no local
authority match was found, the Linker falls back to a remote Z39.50 search.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:20:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:20:04 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-lQhczfr8HS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:33:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:33:26 +0000
Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API
 item objects
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-1E7mNvOBVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API item not_for_loan  |Add
                   |status doesn't respect      |effective_not_for_loan_stat
                   |biblio level fallbacks      |us to API item objects

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:14:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:14:41 +0000
Subject: [Koha-bugs] [Bug 31221] Buttons overflow in opac search results in
 mobile view
In-Reply-To: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31221-70-EcfllXDJuf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com,
                   |                            |philippe.blouin at inlibro.com
                   |                            |, shi-yao.wang at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:23:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:23:50 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-5MRa59DvAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:40 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-g7AhaoOoSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133500|0                           |1
        is obsolete|                            |

--- Comment #114 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138033&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:31:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:31:59 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-XmKMGeMUI2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:51 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-IrfDewARN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133502|0                           |1
        is obsolete|                            |

--- Comment #116 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138035&action=edit
Bug 17385: Add custum export format option when saving a record

This patch adds "XSL-Simple Export" when saving a bibliographic
record. Previous patches are combined into this one.

To test:
1) Search for a record in the intranet.
2) Click on the "Save" button and observe the dropdown menu.
3) Notice that "XSL- Simple Export" is not in the menu.
4) Apply the patch.
5) Repeat the steps 1 and 2.
6) Notice that "XSL - Simple Export" is in the menu.
7) Click on "XSL - Simple Export". A .html file should be downloaded.
8) Open the .html file. You should see the record's informations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:22:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:22:11 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-gFV4MYWZk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Note: To me it looks like there is something wrong with the returnpath/Sender
in the emails, but this is out of scope here. Reply-To is set as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:37:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:37:04 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-qEj8Dbro72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133504|0                           |1
        is obsolete|                            |

--- Comment #118 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138037&action=edit
Bug 17385: Fixing display for XSL-Simple Export in OPAC

This attachment correct the placement of XSL-Simple Export in the OPAC's page.
It is now displayed in the "Save record" dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:57 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-6Rl5iL1yFo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133503|0                           |1
        is obsolete|                            |

--- Comment #117 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138036&action=edit
Bug 17385: Correction of opac-detail-sidebar.inc

This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar
is
displayed as wanted. Tests are now passing properly.

TEST PLAN:
1- Apply the patch and search for a record in the OPAC.
2- Click on "Save record". Notice that the dropdown menu is unchanged.
3- Run t/db_dependent/XSLT.t (All tests should pass)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:45 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-5whHxv2cCI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133501|0                           |1
        is obsolete|                            |

--- Comment #115 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138034&action=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :

<pre>
$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
    #   Failed test 'This list comes from the cache and that is fine'
    #   at t/db_dependent/XSLT.t line 122.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL
</pre>

This one works fine :

<pre>
$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS
</pre>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:17:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:17:04 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-jUCXs7wW6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #80 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138040&action=edit
Bug 23838: Add 'view' link to item detail page

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:20:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:20:42 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-7iHnQrl8SY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tried to understand how the code works and I think this doesn't quite work
the option and the pref describe it:

Set the from address for the notice to one of 'item-homebranch' or
'item-issuebranch'.

1) Option influences item selection

To test: 
* In Centerville, check out:
* 1 item from Centerville
* 1 item from Fairview

Run the overdue_notices script with default/item-issuebranch setting:
* checkout library is used, 1 notice, listing both items

Run the overdue_notices script with item-homebranch setting:
* home library is used, 2 notices, each listing 1 item

Conclusion: this is not only about the from address setting, but more
importantly it influence how the overdue items are grouped/selected.

2) Email settings

item-issuebranch
CPL is used 

item-homebranch
CPL and FPL are used, as you'd expect.

I feel like this works, but the descriptions make you think it's only about a
specific email header setting, which is not true. It will use the 'email
configuration' of either the home library or checkout library and it will group
the overdue items accordingly.

I'll try to provide a follow-up with a suggestion for a slightly different
wording.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:48:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:48:34 +0000
Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
In-Reply-To: <bug-31222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31222-70-nrmmOqz0xK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 138038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138038&action=edit
Bug 31222: Reduce query size for batchMod

The object search is currently:
Koha::Items->search({ barcode => \@contentlist }

Which generate code like:
barcode = 1 OR barcode = 2 OR barcode = 3 ....

This can get quite large

We can reduce the query size by using -in:
Koha::Items->search({ barcode => { -in => \@contentlist } }

Which generates code like:
barcode in ( 1, 2, 3 )

To test:
1 - Apply patch
2 - Perform batch modifications
3 - Confirm nothing has changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:29 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-5YTWFu8haA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133498|0                           |1
        is obsolete|                            |

--- Comment #112 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138031&action=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:47:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:47:30 +0000
Subject: [Koha-bugs] [Bug 31222] New: DBIC queries for batch mod can be very
 large
Message-ID: <bug-31222-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222

            Bug ID: 31222
           Summary: DBIC queries for batch mod can be very large
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We had an issue with  mysql logging for a site doing many batch modifications.

The object search is currently:
Koha::Items->search({ barcode => \@contentlist }

Which generate code like:
barcode = 1 OR barcode = 2 OR barcode = 3 ....

This can get quite large

We can reduce the query size by using -in:
Koha::Items->search({ barcode => { -in => \@contentlist } }

Which generates code like:
barcode in ( 1, 2, 3 )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:48:31 +0000
Subject: [Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
In-Reply-To: <bug-31222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31222-70-AXIYcgRbDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 16:36:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 14:36:34 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-QgfprW6rEC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133499|0                           |1
        is obsolete|                            |

--- Comment #113 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138032&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:16:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:16:58 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-fUM88Or2qP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #79 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138039&action=edit
Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:22:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:22:07 +0000
Subject: [Koha-bugs] [Bug 31223] New: Batch edit items - not working anymore
 in 22.05
Message-ID: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

            Bug ID: 31223
           Summary: Batch edit items - not working anymore in 22.05
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: isabel.pineda at ds.edu.sv
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In a register with several items I select all (or some) items and click "edit
selected items". I make the modification (write a public note, change the
signature, change item type etc.) and click "Save", the modifications don't get
saved.
It used to work in previous versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:27:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:27:20 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-LAVOgeMAWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138040|0                           |1
        is obsolete|                            |

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138042&action=edit
Bug 23838: Add 'view' link to item detail page

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:23:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:23:05 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-EDHEmG4BBd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:37 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-dgjoDOK2sQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #83 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:58:38 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-tqhgwQnDJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:34 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-6apWsuMhok@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:40 +0000
Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API
 item objects
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-KMozTFjMxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:45 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-lgnbP4puqg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:27:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:27:14 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-1GOklcQk3F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138039|0                           |1
        is obsolete|                            |

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 138041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138041&action=edit
Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:28:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:28:24 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-10oUIkeNgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138046|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138047&action=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn

We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.

Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
    <a  href="https://worldcat.org/search?q={OCLC_NO}" target="_blank">WorldCat
(via OCLC number)</a>
Open that record on detail page. Click More searches. Follow that link.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:28:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:28:38 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-0FZAbuLy0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138049&action=edit
Bug 30678: (follow-up) Add oclc_number routine and friends

As requested by QA, we should match the orgcode.
Adding a few small routines in a Util module.

Test plan:
Run t/Koha/Util/MARC.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:29:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:29:28 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-UIQAEDkRRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #2 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
There's another thing: I think that the only Content-Type that makes sense for
the return value is 'application/marc-in-json' because we return 1..n records
instead of a single one. 

Additionally I can't imagine a use-case in which you wouldn't want JSON as a
return value for that route.

Is there any sane way to discern marc records from one another in an api
response?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:54:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:54:42 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23838-70-YgCVuvp0kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

--- Comment #84 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138043&action=edit
Bug 23838: (QA follow-up) Move include files

As talked with Martin, this patches were originally developed before we
added the modals/ and str/ dirs, but we need to align it with current
way of doing it. This patch does that.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:26:44 +0000
Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting
 pickup' should not reset the selected tab
In-Reply-To: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30878-70-q2PNZ8wRrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:00:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:00:57 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-Q9qjH5wW3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:58:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:58:42 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-I6doxFg4DI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137736|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138044&action=edit
Bug 31157: Allow selection for overdue from address in the UI

This patch adds a new system preference to allow systems librarians the
option to pick wich address to use for overdues notices.

We default to 'cron' to allow existing uses of '--frombranch' on the
command line to continue to function but now allow end users to override
this option via the new OverdueNoticeFrom preference.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:19:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:19:46 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-tbfiheeJgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #44 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
(In reply to Martin Renvoize from comment #42)
> This is looking good.. a few comments of where I'd love to see it headed and
> one that is unfortunately a QA fail at the moment.
> 
> QA Fail
> * We're missing Unit Tests for the new module you introduce, I'm afraid
> that's a hard fail for now.  It also looks like you have a note to do
> validation here which is missing... little confused as it looks like you are
> passing in a json structure rather than the token string.. so I'd have
> expected that to already be verified?  We could perhaps just use an existing
> library for this Mojo::JWT for instance?

Sorry, I am not really knowledgeable on the subject of token validation. For
the note, I put it there because I saw this note in the file
opac/svc/auth/googleopenidconnect that I copied to opac/svc/auth/openidconnect
when I started:
># Normally we'd have to validate the token - but google says not to worry here (Avoids another library!)
># See https://developers.google.com/identity/protocols/OpenIDConnect#obtainuserinfo for rationale

So I rewrote the note in the same spot just to give a heads up since I am not
sure if it is needed and I couldn't figure out how to do it if it is needed. I
looked into it a little and I think it has something to do with validating the
token signature involving kid attribute (key id) and jwks_uri of the discovery
document?

> little confused as it looks like you are
> passing in a json structure rather than the token string.. so I'd have
> expected that to already be verified?

The json passed in looks like this:
>{
>    'access_token' => '(encoded stuff)'
>    'id_token' => '(encoded stuff)'
>    'scope' => 'openid https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email'
>    'expires_in' => 3598
>    'token_type' => 'Bearer'
>}
Then 'id_token' is split (into 3 parts) by '.' and the middle part is decoded
into another json that contains the claims. Hope this helps comprehension.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:23:40 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-QmDHY7qLpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136222|0                           |1
        is obsolete|                            |
 Attachment #136223|0                           |1
        is obsolete|                            |
 Attachment #136224|0                           |1
        is obsolete|                            |
 Attachment #136225|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138046&action=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn

We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.

Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
    <a  href="https://worldcat.org/search?q={OCLC_NO}" target="_blank">WorldCat
(via OCLC number)</a>
Open that record on detail page. Click More searches. Follow that link.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:23:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:23:37 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-RrU2BFHo4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:42 +0000
Subject: [Koha-bugs] [Bug 31128] Add effective_not_for_loan_status to API
 item objects
In-Reply-To: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31128-70-yssDFN44kX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:28:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:28:34 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-uHy8zrFWr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138048&action=edit
Bug 30678: Adjust pref description

Test plan:
Look up pref OPACSearchForTitleIn.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:58:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:58:48 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-kCHTjKnq4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138045&action=edit
Bug 31157: (QA follow-up) Update descriptions and wording of configuration
options

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 18:28:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 16:28:42 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-m01yF4Jezk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138050&action=edit
Bug 30678: (follow-up) Change call in opac scripts

Test plan:
See first patch. Add orgcode OCoLC.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 17:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 15:29:48 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-O1bS7mss0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:17:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:17:45 +0000
Subject: [Koha-bugs] [Bug 31216] inventory.pl is slow when comparing many
 barcodes
In-Reply-To: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31216-70-qZ7syz3fpa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31216

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:46:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:46:43 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-xgHIgzvBGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138052&action=edit
Bug 30838: (QA follow-up) Add missing semicolon

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:17 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-xa6zHP5XpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:40:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:40:05 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-avC5AKqx4R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

--- Comment #14 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to Sally from comment #13)
> Sorry for the noise - I messed up on the number of patches to sign off from
> the sandbox.  :(
> 
> But the patch works great - appreciate the solid test plan.
No worries, I've marked the non-relevant comments as obsolete.
Many thanks for your feedback and the speedy sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:38:17 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-EJSTgx4qXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #27 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138051&action=edit
Bug 31086: (QA follow-up) Use plain SQL in db_rev

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:29 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-rAS4I4RyEt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:57 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-YbWfXvZXT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138015|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:08 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-42DOWke11h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:41 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-4DFI4Xwch1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:54 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-oNT8MhXJE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:29:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:29:42 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-goL3V8XKsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #45 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
I will wait for a reply on my previous comment before attempting to write unit
tests. Should the test be at t/db_dependent/Koha/Auth/Client/OIDC.t?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:17 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-EdnCNcsWnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:48 +0000
Subject: [Koha-bugs] [Bug 31204] Edit dropdown on results.tt should indicate
 it is record modification
In-Reply-To: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31204-70-MD1Cg80ojR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:57:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:57:29 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-q1H5OqPj3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:23 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-Rm3TFVsiU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:33 +0000
Subject: [Koha-bugs] [Bug 31121] Format date range on top of cashup summary
 page
In-Reply-To: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31121-70-JZ2fCPa6fo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:22:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:22:42 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-JljOoz7OvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Michal Urban <michalurban177 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:14 +0000
Subject: [Koha-bugs] [Bug 31207] The OPAC Shelf browser fails to display
 local cover images
In-Reply-To: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31207-70-RPhqTijE3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31207

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138014|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:03:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:03:52 +0000
Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what
 the refund was actioned against
In-Reply-To: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27779-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27779-70-KzvVGsPPMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:11 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-elRWbRmgtg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:20 +0000
Subject: [Koha-bugs] [Bug 30858] Add serial enumeration/chronology to
 itemsearch.pl
In-Reply-To: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30858-70-GBlugDhXSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30858

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:11 +0000
Subject: [Koha-bugs] [Bug 30678] Add OCLC_NO as option to
 OPACSearchForTitleIn
In-Reply-To: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30678-70-gFiO7O1Y71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:18:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:18:58 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-QEszZrq2A7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:18:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:18:55 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-vISqy1Y9bk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:05:18 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-s4Orq0NJ3O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |29697


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
[Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:13 +0000
Subject: [Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option
 should be available as a system preference
In-Reply-To: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31157-70-ucuv67iA93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:05:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:05:13 +0000
Subject: [Koha-bugs] [Bug 31224] New: Koha::Biblio::Metadata->record should
 use the EmbedItems filter
Message-ID: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

            Bug ID: 31224
           Summary: Koha::Biblio::Metadata->record should use the
                    EmbedItems filter
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Bug 29697 removed GetMarcBiblio in favor of using
Koha::Biblio::Metadata->record. YAY!

But it added a redundant Koha::Biblio::Metadata::_embed_items method. It also
adds a suspicious 'record' param. I say suspicious because it looks like a
trick to have a given MARC::Record object added the items information. Which
feels like wrong API design. Specially when we have the
Koha::Filter::MARC::EmbedItems processor filter for the task.

Now that things are 'modernized' we really need to revisit this code for a
cleanup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:22:45 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-cMeKmh223q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

--- Comment #1 from Michal Urban <michalurban177 at gmail.com> ---
Created attachment 138053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138053&action=edit
Bug 31212: Change datelastseen from date to datetime field

This patch changes the datelastseen field to a datetime field for better time
accuracy.

It also fixes the interface in order to display datelastseen as a datetime
field.

To test:
1. Apply patch
2. Search the catalogue and select a biblio with at least one item. Confirm in
the holdings table that every entry in the "Last Seen" column is in date-time
format.
3. Navigate to "Items" in for that same biblio and check the item "History"
section to have "Last Seen" in the correct format
4. Click "Edit" then "Edit Items" and confirm that the table has date-time
format for the "Date Last Seen" Column entries
5. Edit one of the items to have lost status, then navigate to the Reports
section, find "Items Lost", and search for the item with the barcode. Confirm
the proper date-time format in the result.
6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date
Last Seen" column entries are in proper format

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:26 +0000
Subject: [Koha-bugs] [Bug 31086] Do not allow hold requests with no
 branchcode
In-Reply-To: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31086-70-CqiJKJPhyD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:02 +0000
Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be
 definable at the credit_type/debit_type level
In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26689-70-WgEoeAzbSn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:55:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:55:03 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-meMBcwJmfG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #114 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138057&action=edit
Bug 29697: (follow-up) Indexing a deleted record is not expected to crash

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:14 +0000
Subject: [Koha-bugs] [Bug 30838] to_address is misleading for SMS transports
In-Reply-To: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30838-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30838-70-tvol0OLBsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30838

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:33:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:33:38 +0000
Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting
 pickup' should not reset the selected tab
In-Reply-To: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30878-70-AFVhLhrydG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:04:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:04:58 +0000
Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to
 Increase Search for ALL non-latin Scripts
In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15187-70-bA3rUo1nba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I hate the filter name. But it is accurate!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:19:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:19:05 +0000
Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be
 definable at the credit_type/debit_type level
In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26689-70-qV9Lre6sft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:50:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:50:43 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-y6Q3CuTZbl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138059&action=edit
Bug 23247: Use EmbedItems in opac-MARCdetail.pl

This patch uses the EmbedItems processor to add the items to the MARC
record.

To test:
- Find a known record, go to the OPAC MARC page of it.
- Play with several options in OpacHiddenItems, refreshing it
- Play with OpacHiddenItemsExceptions as well
=> SUCCESS: Things work as expected
- Apply this patch
- Repeate the tests above
=> SUCCESS: Things work as expected!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:57:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:57:36 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-ideFqhDt9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 19:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 17:52:36 +0000
Subject: [Koha-bugs] [Bug 31138] DataTables is not raising error to the end
 user
In-Reply-To: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31138-70-4XxunwMtrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31138

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:33:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:33:41 +0000
Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting
 pickup' should not reset the selected tab
In-Reply-To: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30878-70-AioHepl3j2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136333|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138054&action=edit
Bug 30878: Avoid resetting waiting reserves tab

When canceling holds waiting over X days in "Holds awaiting pickup"
view, form submission resets the selected tab to "Holds waiting". This
tab reset may cause confusion for the user and lead to unwanted
actions. Instead, the user should be returned to the same tab that they
began with.

To test:
1. Apply patch
2. Navigate to /cgi-bin/koha/circ/waitingreserves.pl
3. Select "Holds waiting over X days" tab
4. Refresh page
5. Observe "Holds waiting over X days" is still selected
6. Have some holds waiting over X days
7. Select one of them and press "Cancel selected (1)" and confirm
8. Observe "Holds waiting over X days" is still selected after form
   submission

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:50:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:50:18 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-IWY8DNVTuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102094|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:30:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:30:15 +0000
Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
In-Reply-To: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30085-70-lHRo7MCmR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:52:16 +0000
Subject: [Koha-bugs] [Bug 23247] Use EmbedItems in opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-eLEYYJtLe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31224
         Depends on|                            |29697
         QA Contact|m.de.rooy at rijksmuseum.nl    |testopia at bugs.koha-communit
                   |                            |y.org
            Summary|Simplify visibility logic   |Use EmbedItems in
                   |in opac-MARCdetail.pl       |opac-MARCdetail.pl

--- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, In light of bug 29697 and the design discussion on bug 31224, I decided to
rework this bug.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
[Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:50:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:50:21 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-vLrM71WLjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102095|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:52:16 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-oQNfqjzy3J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23247

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:05:18 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-PUZD9aZ5SB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31224


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224
[Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:29:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:29:41 +0000
Subject: [Koha-bugs] [Bug 30085] Improve performance of CanItemBeReserved
In-Reply-To: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30085-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30085-70-tj0g8l99iN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30085

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 138058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138058&action=edit
Bug 30085: [21.11.x] Reduce scope of holds count / today holds count

We retrieve two counts that are only needed if rules for hold limits are
defined.
The DB counts should only be fetched once the rules are confirmed to exist

Further improvement would be possiblke by allowing them to be passed in (or
cached?)
from CanBookBeReserved as they rely only on patron/biblionumber and not item
specific information

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Bug 30085: Don't fetch ReservesControlBranch twice

We essentially copy the code from GetReservesControlBranch here, because we
also calculate 'branchfield'

Setting it to "" vs undef makes no difference in this code, so lets not fetch
this
again later.

Rename the variable to make it clearer where the branchcode came from

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Bug 30085: Consolidate querycoutn code and only check if needed

Similar to first patch, move a count only conditionally used into
the conditional

This could be updated to use DBIC, but the itemtype conditionals
add complexity

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Bug 30085: Move IndependentBranches check sooner

This doesn't rely on the other statuses, and requires only cached
preference check, so lets allow the possibiliy of an early exit

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 20:57:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 18:57:38 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-tSF5dK5lVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #115 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:50:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:50:15 +0000
Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in
 opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-8O7Afk22uo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Trivial patch
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:52:16 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-hhOmasiNkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23247


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247
[Bug 23247] Use EmbedItems in opac-MARCdetail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:01:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:01:41 +0000
Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601
In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29718-70-sShxaeGwYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718

--- Comment #41 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
This causes a failure on Ubuntu 18.04: bug 30030

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:04:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:04:59 +0000
Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t
 is_going_to_expire fails on U18
In-Reply-To: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30030-70-FyfsDa5gIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
To have the CI still be meaningful for Ubuntu 18.04 (until 2023-04-26) for
22.05 and in the future 22.11, should 29718 be reverted until then? (assuming
it's possible)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:53:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:53:22 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-QTBmhoOlcp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Resubmitted as an unrelated change slipped in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:05:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:05:33 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-NDu5o9cnzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:50:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:50:39 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-GCQDUKgz8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:00:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:00:58 +0000
Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601
In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29718-70-zPvvUJm8x6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30030


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030
[Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:59:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:59:56 +0000
Subject: [Koha-bugs] [Bug 23247] Use EmbedItems in opac-MARCdetail.pl
In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23247-70-p6XzHJJdho@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247

--- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #13)
> If I have nothing in OPACHiddenItems or just itype: [CF],
> I do not see my two items on a record with itype BK or BKS.
> Just: No available items.
> 
> Without your patch, they come up again. Nice.
> 
> So there is still something wrong ;) Can you find it ?

I don't manage to reproduce this. It might have been the old YAML library we
were using?

I tried

---
itype: ['CF']

and

---
itype: [CF]

Both produced the expected result.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:06:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:06:36 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-sKzpLTzfQY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138063&action=edit
[POC] Bug 31224: Add Koha::Biblio->metadata_record

This patch introduces a higher-level method for retrieving a 'prepared'
record for using in specific contexts. In particular, I only focused on
embedding item information and OPAC view filtering. But we could add a
way to get the record through the ViewPolicy also for staff.

The virtue of this patch is that it explains better than my words why I
think having the *embed_items* and *opac* parameters in
Koha::Biblio::Metadata->record is not ideal. And makes the other
implementation feel like is done at the wrong level.

I know it's been done like that to act as a drop-in replacement fro
GetMarcBiblio,
which was a good first step. But we need to revisit how it is used, in general,
to come
up with a more refined and useful design. So we do not port the same
design problems from C4::* into Koha::*.

Try to think how it would be used in contexts like opac-MARCdetail.pl or
any other OPAC controller script.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 21:57:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 19:57:22 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-qF8XUwWm57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:14:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:14:35 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-E9vy18eky2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, I submitted to bug 23247 and implementation that doesn't rely on the new
embed_items param, so we ponder how coding with RecordProcessor looks like in
the controllers.

I will now submit a version that uses RecordProcessor in the method.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:52:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:52:32 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-LxiPDpokSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138060|0                           |1
        is obsolete|                            |

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138061&action=edit
[POC] Bug 31224: Add Koha::Biblio->metadata_record

This patch introduces a higher-level method for retrieving a 'prepared'
record for using in specific contexts. In particular, I only focused on
embedding item information and OPAC view filtering. But we could add a
way to get the record through the ViewPolicy also for staff.

The virtue of this patch is that it explains better than my words why I
think having the *embed_items* and *opac* parameters in
Koha::Biblio::Metadata->record is not ideal. And makes the other
implementation feel like is done at the wrong level.

I know it's been done like that to act as a drop-in replacement fro
GetMarcBiblio,
which was a good first step. But we need to revisit how it is used, in general,
to come
up with a more refined and useful design. So we do not port the same
design problems from C4::* into Koha::*.

Try to think how it would be used in contexts like opac-MARCdetail.pl or
any other OPAC controller script.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:05:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:05:38 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-iTMjgajLBt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138062|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:06:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:06:40 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-LxguZqp9lb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138064&action=edit
[POC] Bug 31224: Use metadata_record in opac-MARCdetail.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:59:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:59:55 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-O3nqlFlnr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138062&action=edit
[POC] Bug 31224: Use metadata_record in opac-MARCdetail.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:05:35 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-1R0KIdCEBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138061|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 22:50:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 20:50:58 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-jA7fvJWRPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138060&action=edit
[POC] Bug 31224: Add Koha::Biblio->metadata_record

This patch introduces a higher-level method for retrieving a 'prepared'
record for using in specific contexts. In particular, I only focused on
embedding item information and OPAC view filtering. But we could add a
way to get the record through the ViewPolicy also for staff.

The virtue of this patch is that it explains better than my words why I
think having the *embed_items* and *opac* parameters in
Koha::Biblio::Metadata->record is not ideal. And makes the other
implementation feel like is done at the wrong level.

I know it's been done like that to act as a drop-in replacement fro
GetMarcBiblio,
which was a good first step. But we need to revisit how it is used, in general,
to come
up with a more refined and useful design. So we do not port the same
design problems from C4::* into Koha::*.

Try to think how it would be used in contexts like opac-MARCdetail.pl or
any other OPAC controller script.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:00:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:00:58 +0000
Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t
 is_going_to_expire fails on U18
In-Reply-To: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30030-70-80eWf4usCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|29403                       |29718
                 CC|                            |victor at tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
It's not 29403, reverting doesn't fix the issue.

Bisecting shows that it's commit Bug 29718: Mock the timezone


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
[Bug 29403] dt_from_string should fail if passed more data than expected for
the format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718
[Bug 29718] DateTime - our 'iso' is not ISO 8601
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:00:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:00:58 +0000
Subject: [Koha-bugs] [Bug 29403] dt_from_string should fail if passed more
 data than expected for the format
In-Reply-To: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29403-70-zUaaPZCQKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|30030                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030
[Bug 30030] Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 22 23:08:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jul 2022 21:08:20 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-nIOFOhwywY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, I added a sample usage.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 05:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 03:49:50 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-lQxgXIhSL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
wow
thanks, no worries then ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 06:27:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 04:27:06 +0000
Subject: [Koha-bugs] [Bug 30970] holdst columns don't match actual columns
 in 'Holds waiting'
In-Reply-To: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30970-70-6hmRPr0ihC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30970

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Needs documenting

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 08:05:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 06:05:24 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-TosTS6EtYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Then, what's next? Please make sure to work on top of bug 27272 please.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 09:36:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 07:36:23 +0000
Subject: [Koha-bugs] [Bug 29829] Standardize multi-value system preferences
 to use | as separator
In-Reply-To: <bug-29829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29829-70-PlaA9B3Kzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29829

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
The Alphabet syspref uses spaces as delimiter, because I found it hard to parse
out the (non-ASCII) characters with e.g. a pipe as the delimiter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 07:26:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 05:26:18 +0000
Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances,
 the authority finder uses MARC21 relationship codes
In-Reply-To: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29434-70-ZOMnnBOZ6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

--- Comment #7 from Andreas Roussos <a.roussos at dataly.gr> ---
(In reply to David Nind from comment #6)
> Hi Andreas.
Hi David!

> I'm not familiar with UNIMARC, but I would like to test this bug.
That's great! Thank you for your interest in this bug report.

> For step 1, how do I set things up so I can "launch
> authorities/auth_finder.pl"?
> - Are there any fields that have the tag editor already enabled?
There aren't any, no. See below for instructions on how to enable.

> - Do I need to edit the authority structure (Administration > Catalog >
> Authority types)?
Yes. I'll outline the steps required below:
- Go to 'Home > Administration > Authority types' and click on
  'Actions -> MARC structure' for the 'NP' (Personal Name) auth type.
- Next, search for tag 510 and click on 'Actions -> Subfields' for
  that tag.
- Finally, click 'Edit' next to subfield 'a' (Entry element), then
  pick 'CO' from the 'Thesaurus' dropdown menu. Save your settings
  and you're good to go! From now on, when editing a Personal Name
  authority, the 'Tag editor' button next to subfield 510$a will
  launch the authority finder plugin.

> - Where does the 'Special relationship:' dropdown menu appear?
It will appear when you launch the authority finder plugin via
the 'Tag editor' button. The menu itself will be near the bottom
of the popup window, under the 'Relationship information' section.

> - I assume I need to enable the AuthDisplayHierarchy system preference.
Actually you're not required to have this system preference enabled
if you just want to link authorities with other authorities.
It certainly helps to have in enabled, though, as you'll get
the nice hierarchical view of authorities in their Details page.

> I'm using koha-testing-docker and have a UNIMARC instance with the default
> sample data. Is there an existing authority record that you know of in the
> sample data with this already setup?
I ran a SELECT query on the SQL sample data for UNIMARC (provided
by koha-misc4dev) looking for records where the `authtrees` column
would be != NULL but couldn't find such a record. So, I guess
the answer is no.

> Apologies for such a basic question!
No worries, my test plan and the Bug Description did not include
all the information so your question is absolutely valid.
I apologise myself for the very late reply!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 09:31:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 07:31:05 +0000
Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses
In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12802-70-faKMovT9Td@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

--- Comment #104 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This conflicts in resent feature C4::Letters::ResendMessage where to_address is
touched.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 17:31:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 15:31:46 +0000
Subject: [Koha-bugs] [Bug 4877] Create and update the manual pages for the
 koha-* scripts.
In-Reply-To: <bug-4877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4877-70-Jd4Dsf3cUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=27315

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 17:31:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 15:31:46 +0000
Subject: [Koha-bugs] [Bug 27315] The man pages for the command line
 utilities do not display properly
In-Reply-To: <bug-27315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27315-70-6Yzp9HUifr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=4877
           Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

--- Comment #4 from Andreas Roussos <a.roussos at dataly.gr> ---
I'm revisiting this as it's still valid in 22.05.02.

Thanks to the comments posted at the following GitHub issue
I believe I've found what's causing the broken man pages:
https://github.com/docbook/xslt10-stylesheets/issues/123

The source XML files for our man pages have the following namespace
declaration at the top: xmlns='http://docbook.org/ns/docbook'. That
means they are DocBook V5.0 documents and should be processed by
namespace-aware DocBook XSL stylesheets.

However, the Stylesheet that generates the man pages from the DocBook
XML source files is currently part of the docbook-xsl package.
I think we should be using the Stylesheet from the docbook-xsl-ns
package instead (I've actually tested this on Debian 9/10/11 and it
worked just fine -- the generated man pages did not have any issues).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 22:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 20:09:20 +0000
Subject: [Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds
 causes all other holds to be prioritized as well!
In-Reply-To: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12630-70-5g5cKHxN5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #30 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 22:09:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 20:09:21 +0000
Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron
 jump to the top of the holds list
In-Reply-To: <bug-10883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10883-70-QaWJNytKLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883
Bug 10883 depends on bug 12630, which changed state.

Bug 12630 Summary: Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 21:59:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 19:59:29 +0000
Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where
 clause' 500 error in API /api/v1/acquisitions/orders
In-Reply-To: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30677-70-RmddDwaMAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |RESOLVED

--- Comment #26 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 21:53:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 19:53:48 +0000
Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user
 only has place_hold permission
In-Reply-To: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30213-70-q7NcT8bjXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213
Bug 30213 depends on bug 30207, which changed state.

Bug 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |Needs documenting
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 21:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 19:53:39 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
 permission can no longer update hold pickup locations
In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30207-70-QSGS7eXQon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 22:07:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 20:07:50 +0000
Subject: [Koha-bugs] [Bug 30989] Tags with some special characters are not
 encoded right
In-Reply-To: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30989-70-EKgg1INXMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30989

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 00:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 22:51:25 +0000
Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances,
 the authority finder uses MARC21 relationship codes
In-Reply-To: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29434-70-fMFxCglc1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 22:03:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 20:03:38 +0000
Subject: [Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
In-Reply-To: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30786-70-xk49fXaiMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 21:53:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 19:53:47 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
 permission can no longer update hold pickup locations
In-Reply-To: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30207-70-hNYBTj5aQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 23 22:05:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 20:05:23 +0000
Subject: [Koha-bugs] [Bug 30925] Creating public list by adding items to new
 list creates a private list
In-Reply-To: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30925-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30925-70-82VW4ln1c2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30925

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Needs documenting
                 CC|                            |victor at tuxayo.net

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 01:00:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 23:00:27 +0000
Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances,
 the authority finder uses MARC21 relationship codes
In-Reply-To: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29434-70-6G2tBw0OuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This fixes the values
      release notes|                            |displayed for the
                   |                            |relationship codes in the
                   |                            |authority finder 'Special
                   |                            |relationships' drop down
                   |                            |list in UNIMARC catalogs -
                   |                            |UNIMARC values are now
                   |                            |displayed, instead of
                   |                            |MARC21 values.

--- Comment #9 from David Nind <david at davidnind.com> ---
Thanks Andreas!

Was able to test successfully, and the bug is now signed off.

David

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 05:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 03:09:29 +0000
Subject: [Koha-bugs] [Bug 30995] Bug 29504 - Confirm item parts requires
 force_checkout permission (batch checkout)
In-Reply-To: <bug-30995-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30995-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30995-70-3YW61rlBfC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30995
Bug 30995 depends on bug 29504, which changed state.

Bug 29504 Summary: Confirm item parts requires force_checkout permission (checkouts tab)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 00:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jul 2022 22:51:29 +0000
Subject: [Koha-bugs] [Bug 29434] In UNIMARC instances,
 the authority finder uses MARC21 relationship codes
In-Reply-To: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29434-70-NLcTsXDVJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29434

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #127424|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 138065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138065&action=edit
Bug 29434: add UNIMARC relationship codes for authorities

When using the authority finder plugin (authorities/auth_finder.pl),
you can pick an entry from the 'Special relationship:' dropdown menu
in order to set the relationship between authorities.

However, in UNIMARC instances the relationship codes listed are those
for MARC21. The correct codes for UNIMARC are listed in pages 93-94
of the IFLA UNIMARC Manual for Authorities.

Test plan:

1) In a UNIMARC instance, launch authorities/auth_finder.pl in the
   Staff client, by clicking on the 'Tag editor' button. Notice how
   the 'Special relationship:' dropdown menu lists the relationship
   codes for MARC21 instead of UNIMARC.
2) Apply this patch.
3) Launch the authority finder again; this time the correct values
   should be listed in the 'Special relationship:' dropdown menu.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 05:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 03:09:28 +0000
Subject: [Koha-bugs] [Bug 29504] Confirm item parts requires force_checkout
 permission (checkouts tab)
In-Reply-To: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29504-70-N0jeMxA1Xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Version(s)|22.11.00, 22.05.03,         |22.11.00, 22.05.03,
        released in|21.11.11                    |21.11.11, 21.05.17
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #28 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Backported: Pushed to 21.05.x branch for 21.05.17
Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 13:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 11:51:59 +0000
Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP
 Replication not using autoMemberNum if configured
In-Reply-To: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17215-70-O0wsFi5wHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215

Janik <janik.hilser at icloud.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 13:51:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 11:51:38 +0000
Subject: [Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to
 unwanted updates
In-Reply-To: <bug-29930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29930-70-az78sOhwIN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Janik <janik.hilser at icloud.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 22:48:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 20:48:46 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-9XLLd9njuW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Single label pdf export not |Single label PDF export not
                   |working                     |working

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:01:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:01:23 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-IyiDIdXHJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please don't forget to switch back the status when you rebase :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:08:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:08:52 +0000
Subject: [Koha-bugs] [Bug 31225] New: Spine label formatting in PDF is not
 rendering correctly
Message-ID: <bug-31225-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31225

            Bug ID: 31225
           Summary: Spine label formatting in PDF is not rendering
                    correctly
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: PC
                OS: Windows
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: stdominic.novices at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Hi, I'm using Debian subsystem for Windows 11 and whenever I export a BIB
callnumber batch of spine labels to PDF, all the data is rendering incorrectly.
The template that I set up is working fine, and ONE of the labels comes out
correctly, but all the other call numbers are running together and even going
off the template. I tried recollecting a new batch using the same books, but it
didn't change anything. Also, whenever I try exporting a selection of the batch
instead of the whole thing, I get an "error 500" message. Happy to give more
info if needed, but I'm not sure what else I can say. Couldn't find any reason
for only one book to formatted correctly and all the others come out all piled
up. Hope this all makes sense, and thanks for your time!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:13:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:13:53 +0000
Subject: [Koha-bugs] [Bug 31182] Result search number missing in OPAC
In-Reply-To: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31182-70-fzUNxiXPDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31182

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fixed by bug 31186.

*** This bug has been marked as a duplicate of bug 31186 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:13:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:13:53 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-7oKe5Qgb7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31182 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:16:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:16:25 +0000
Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't
 detect duplicate authorities
In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31185-70-vnZTywwe8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Don't forget to switch the status to "Needs Signoff", once you have a patch
attached for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:18:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:18:53 +0000
Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD
 cover images
In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23965-70-INzxW5yDKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31188

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:18:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:18:53 +0000
Subject: [Koha-bugs] [Bug 31188] UPC or ASIN from amazon for DVDs,
 music CDs cover images
In-Reply-To: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31188-70-DLTY3CuzrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UPC or ASIN from amazon for |UPC or ASIN from amazon for
                   |dvd, music cds image        |DVDs, music CDs cover
                   |                            |images
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23965

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:19:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:19:44 +0000
Subject: [Koha-bugs] [Bug 31190] Add item creation date in items table
In-Reply-To: <bug-31190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31190-70-05Zu3pSmfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31190

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30392

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:19:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:19:44 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-aHnax2Y52f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31190

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:23:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:23:03 +0000
Subject: [Koha-bugs] [Bug 31226] New: Make FacetLabelTruncationLength work
 with Elasticsearch
Message-ID: <bug-31226-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31226

            Bug ID: 31226
           Summary: Make FacetLabelTruncationLength work with
                    Elasticsearch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Bug 31191 adds a note to the FacetLabelTruncationLength system preference that
it works only with Zebra. We should make it work with Elasticsearch too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:23:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:23:03 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-HavxvC4riL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31226

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:25:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:25:41 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-Sz007fDiRu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:25:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:25:45 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-Y6I48B71Ia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137887|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138066&action=edit
Bug 31191: Specify FacetLabelTruncationLength is only for Zebra

This patch adds a note in the description of FacetLabelTruncationLength
that it only works with Zebra.

To test:
0) Apply patch
1) Go to Administration > Global system preference > Searching
preferences
2) Search for FacetLabelTruncationLength
3) Read the description, make sure it indicates that is requires Zebra

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:26:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:26:49 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-XjkaFn6ghL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
String patch - passing QA too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:28:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:28:40 +0000
Subject: [Koha-bugs] [Bug 31196] Key "default_value_for_mod_marc-" cleared
 from cache but never set
In-Reply-To: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31196-70-WjKbZfepFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31196

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The test plan is a bit too sparse for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:30:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:30:27 +0000
Subject: [Koha-bugs] [Bug 31221] Buttons overflow in OPAC search results in
 mobile view
In-Reply-To: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31221-70-4eE23tWaTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Buttons overflow in opac    |Buttons overflow in OPAC
                   |search results in mobile    |search results in mobile
                   |view                        |view

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:35:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:35:27 +0000
Subject: [Koha-bugs] [Bug 30677] Unknown column 'biblioitem.title' in 'where
 clause' 500 error in API /api/v1/acquisitions/orders
In-Reply-To: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30677-70-LE0zLYW6EZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30677

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31193 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:35:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:35:27 +0000
Subject: [Koha-bugs] [Bug 31193] API error when receiving orders
In-Reply-To: <bug-31193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31193-70-6xASSk1XMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, this looks like a duplicate of bug 30677.

*** This bug has been marked as a duplicate of bug 30677 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:40:16 +0000
Subject: [Koha-bugs] [Bug 31200] Block payment of late fees when document
 not return
In-Reply-To: <bug-31200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31200-70-BMI3rHvjm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31200

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
          Component|Circulation                 |Fines and fees
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:41:37 +0000
Subject: [Koha-bugs] [Bug 31198] Display results search authority numbers
In-Reply-To: <bug-31198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31198-70-bdnZPuZh0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
          Component|Searching                   |MARC Authority data support

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 24 23:45:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 21:45:02 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-Tnz7Nan9ei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Isabel, there could be a time delay while the job is processed by the
background jobs. If you go to Aministration > Background jobs, do you see any
finished/unfinished jobs of type "Batch item record modification" there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:01:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:01:08 +0000
Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern
In-Reply-To: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30035-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30035-70-YBdHv1i3ft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035

--- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
I didn't notice that Ubuntu 16.04 is end of life since 2021-04-30

I can reintroduce this patch it if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:01:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:01:25 +0000
Subject: [Koha-bugs] [Bug 30997] "CGI::param called in list context" warning
 in detail.pl flooding error log
In-Reply-To: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30997-70-rvnqzQ9T1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30997

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:01:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:01:26 +0000
Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal
In-Reply-To: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25790-70-LNHIbi0N4f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Bug 25790 depends on bug 30997, which changed state.

Bug 30997 Summary: "CGI::param called in list context" warning in detail.pl flooding error log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30997

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:02:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:02:52 +0000
Subject: [Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken
 for translations
In-Reply-To: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30958-70-AIIV8qYzV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |victor at tuxayo.net

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:05:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:05:10 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-sVBC1DDHdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:05:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:05:14 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-W9SfHOehWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135110|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138067&action=edit
Bug 26549: Show value of global system preferences on subscription form

This patch modifies the subscription entry form so that the values of
two system preferences are displayed as a hint to the user:

The "Number of issues to display to staff" field will show the value
of the StaffSerialIssueDisplayCount preference, and the "Number of
issues to display to the public" field will show
OPACSerialIssueDisplayCount. If the user has permission the system
preference names will link to the system preferences page.

To test, apply the patch and log into the staff interface as a user with
permission to edit system preferences.

- Go to Serials -> New subscription.
- The "Number of issues to display to staff" field should have a hint
  under it: "Default: XX (StaffSerialIssueDisplayCount system
   preference)"
- The "Number of issues to display to the public" field should have a
  hint under it: "Default: XX (OPACSerialIssueDisplayCount system
  preference)"
- Log out and log back in as a user who does not have permission to edit
  system preferences. Return to the form and confirm that the hints do
  not link to system preferences.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:05:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:05:51 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-rcgo6J1fwm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Rebased and tested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:08:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:08:43 +0000
Subject: [Koha-bugs] [Bug 28529] Item type-constrained biblio-level holds
 should honour max_holds as item-level do
In-Reply-To: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28529-70-FexQKI2UtI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28529

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to oldstable         |RESOLVED
                 CC|                            |victor at tuxayo.net

--- Comment #44 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:08:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:08:51 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-LfsphMzEYd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can you please update the patches with some descriptions and a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:11:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:11:10 +0000
Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to
 home library or library group
In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20256-70-yudMSwEYIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #351 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 6423 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:11:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:11:10 +0000
Subject: [Koha-bugs] [Bug 6423] Add permission for editing other library's
 items
In-Reply-To: <bug-6423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6423-70-EThD61MSxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6423

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 20256 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:14:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:14:25 +0000
Subject: [Koha-bugs] [Bug 30030] Test t/db_dependent/Koha/Patrons.t
 is_going_to_expire fails on U18
In-Reply-To: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30030-70-aL8tcmWSlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30030

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:15:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:15:32 +0000
Subject: [Koha-bugs] [Bug 29718] DateTime - our 'iso' is not ISO 8601
In-Reply-To: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29718-70-P8mWOAFcnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:19:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:19:29 +0000
Subject: [Koha-bugs] [Bug 28355] Add warning note about Email SMS driver
 option for SMSSendDriver
In-Reply-To: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28355-70-7W14eWaank@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28355

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Pushed to oldstable         |Needs documenting

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

The warning might need to be documented in the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:42:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:42:45 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-LgHA1zsXs1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 00:57:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 22:57:13 +0000
Subject: [Koha-bugs] [Bug 31105] Holds to pull counts items from other
 branches when independentbranches is active
In-Reply-To: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31105-70-BQbSzFaheq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31105

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:14:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:14:39 +0000
Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD
 cover images
In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23965-70-nfT9sXB7eT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:24:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:24:32 +0000
Subject: [Koha-bugs] [Bug 31227] New: Provide option to protect user
 permissions on patron import
Message-ID: <bug-31227-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31227

            Bug ID: 31227
           Summary: Provide option to protect user permissions on patron
                    import
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

When importing patrons, you can match on cardnumber or username, then
preserve/protect selected fields if there's a match.

However it doesn't appear that user permissions are protected if there is a
match - these get reset/wiped.

There should be an option to protect user permissions if a match is found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:29:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:29:30 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-M00HgVEjki@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #4)
> I wondered if it was as simple as just running it through RecordProcessor..
> but when I started to have a quick look at the code I couldn't wrap my head
> around it.. perhaps not as simple as it appears on the surface.

I'd have to do a thorough double-check but I think we need to do the check at
the SQL level.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:31:17 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-FlVHy9wBQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #13)
> Quite keen to see this one fixed, but we have 2 complaints in the QA test
> tools. Can you please fix?
> 
>  FAIL	C4/Circulation.pm
>    FAIL	  critic
> 		# Variables::ProhibitConditionalDeclarations: Got 2 violation(s).

I saw your message, and it's on my TODO list. I'll be coming back to this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:34:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:34:23 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-pVbST6Ompv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #3)
> I think that we need a database column to store the 942$n data to make it
> easy to query via SQL.

I still think that this is the solution for this particular issue. 

> OpacHiddenItems will still be an issue but that can be a separate issue...

I actually just remembered that I actually have a solution for this! 

Check out the patch on bug 19704. I use SQL::Abstract to generate SQL based on
OpacHiddenItems! 

(Note that the 942$n issue on that report is managed using ExtractValue() but
it's not as efficient as just having a "biblio" or "biblioitems" column of
"suppressed".)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 01:34:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jul 2022 23:34:56 +0000
Subject: [Koha-bugs] [Bug 31161] OAI-PMH - Add ability to exclude suppressed
 records in output
In-Reply-To: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31161-70-etbilABkln@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #6)
> Check out the patch on bug 19704. I use SQL::Abstract to generate SQL based
> on OpacHiddenItems! 

Note that SQL::Abstract is a dependency of DBIx::Class, so it's pretty safe to
rely on it. We could always add it to the cpanfile if folk thought it was
necessary too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 02:03:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 00:03:20 +0000
Subject: [Koha-bugs] [Bug 28267] Koha-common package upgrade problem from
 20.05.xx to 20.11.04-1
In-Reply-To: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28267-70-o0JbZqPq9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #30)
> Yes and no.. the packages are generally expected to just "do the right
> thing" so if there is an appraisal we can take to "fix" peoples databases,
> we probably should.

I suppose it's a fine line. Maybe it does make sense to change all Koha tables
over to DYNAMIC if they're not already. As I noted above, it looks like if you
in-place upgrade your database, it'll retain COMPACT and not automatically
update, so I suppose that does leave the responsibility to Koha...

(As a side note, I looked at
https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
and https://wiki.debian.org/LTS, and it looks like Debian 9 reached it's EOL
LTS a month ago. We might want to stop supporting it too. I'll send out an
email about that. Debian 10 will be regular EOL in the next month or two it
seems.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 02:46:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 00:46:51 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-DjQxY42KK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #119 from David Nind <david at davidnind.com> ---
Apologies, I was too slow to retest - the patches no longer apply 8-(..

Applying: Bug 17385: Add custom export XSLT
.git/rebase-apply/patch:163: trailing whitespace.
} else { 
.git/rebase-apply/patch:166: trailing whitespace.
    $template->param(bib_list => $bib_list); 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M       basket/basket.pl
M       basket/downloadcart.pl
M       catalogue/detail.pl
M       catalogue/export.pl
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
M       opac/opac-detail.pl
M       opac/opac-downloadcart.pl
M       opac/opac-downloadshelf.pl
M       opac/opac-export.pl
M       virtualshelves/downloadshelf.pl
M       virtualshelves/shelves.pl
.git/rebase-apply/patch:163: trailing whitespace.
} else { 
.git/rebase-apply/patch:166: trailing whitespace.
    $template->param(bib_list => $bib_list); 
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging virtualshelves/shelves.pl
Auto-merging virtualshelves/downloadshelf.pl
Auto-merging opac/opac-export.pl
CONFLICT (content): Merge conflict in opac/opac-export.pl
Auto-merging opac/opac-downloadshelf.pl
CONFLICT (content): Merge conflict in opac/opac-downloadshelf.pl
Auto-merging opac/opac-downloadcart.pl
CONFLICT (content): Merge conflict in opac/opac-downloadcart.pl
Auto-merging opac/opac-detail.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging catalogue/export.pl
Auto-merging catalogue/detail.pl
Auto-merging basket/downloadcart.pl
Auto-merging basket/basket.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 17385: Add custom export XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:04:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:04:06 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-heSyWNag6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #46 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #42)
> QA Fail
> * We're missing Unit Tests for the new module you introduce, I'm afraid
> that's a hard fail for now. 

I thought since the foundation Google OpenID Connect code (bug 10988) made it
through without unit tests, this one would be able to as well, since it's just
a slight modification on existing code in Koha.

> It also looks like you have a note to do
> validation here which is missing... little confused as it looks like you are
> passing in a json structure rather than the token string.. so I'd have
> expected that to already be verified?  We could perhaps just use an existing
> library for this Mojo::JWT for instance?

I think that the code comments are misleading. The Koha code does validate the
"iss", "aud", and "exp" claims in the ID token. The only thing it doesn't check
is the JWT signature. (See
https://developers.google.com/identity/protocols/oauth2/openid-connect#validatinganidtoken). 

Mojo::JWT is probably the way to go, but I wonder if it's scope creep though,
since the Google OpenID Connect code doesn't do it currently. 

> Future
> 1. I'd love to see this moved out of preferences and into it's own
> management page.. I could see multiple OpenIDConnect providers being
> configured at the same time and allowing the end user to 'Pick their poison'
> at login.
> 2. If we went the above route, I'd love to see the Google stuff pulled out
> and the preferences it uses also migrated into the above management area.

That's a goal of mine for sure. 

Locally, I have an endpoint called
/cgi-bin/koha/svc/login_openidc/<provider_id>. The controller is located at
"login_openidc" and it parses the remaining URL string to get the ID, and then
looks up the provider in its configuration. It would be very easy to do. 

> 3. The controller/svc script is pretty heavy right now.. I'd love to have
> seen more of this done 'in module' and have the controller lighter and
> perhaps in the REST side of things rather than a new /svc.. but I'm honestly
> not sure how it would fit in REST as yet so have no issue with it in /svc
> for now.

This code is pretty much a copy/paste of bug 10988 so it inherits its problems. 

One could argue that it shouldn't be in /svc or the REST API, because it's not
really an API. It's just an authentication endpoint. In terms of the
controller, it's really just redirecting a browser (and doing some backend work
which should be in a module for sure).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:04:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:04:46 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-817gyhCICW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #47 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #43)
> We are happy to have you for this cycle too if you are interested. In the
> summer time (Europe etc.) we are always struggling a bit more.

Sounds good to me. Do we need to do anything for me to re-gain my QA genie
powers?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:06:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:06:32 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-8oQjlt8HVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #48 from David Cook <dcook at prosentient.com.au> ---
(As a side note, Tomas has mentioned by email that he has an alternative
implementation he's been working on. I recall that he and I talked about it a
long time ago, and it sounded like a superior implementation. I'm going to ask
him more about it by email.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:15:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:15:49 +0000
Subject: [Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken
 for translations
In-Reply-To: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30958-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30958-70-m4fuzGnZH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958

--- Comment #10 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Victor Grousset/tuxayo from comment #9)
> Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
> 
> Nothing to document, marking resolved.

Hi Victor, 

We have a client (Melbourne Athenaeum Library - who sponsored this fix) running
21.05.x who would love to have this fix before their next Koha upgrade.

Would it be possible for you to backport this fix to 21.05.x please?

Many thanks!
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:19:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:19:45 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-pNxS22bo5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
I was able to successfully test this in an "Ingognito" window using Google
Chrome:
- without the patch, it displays a spinner and 'Coce image from Amazon'
- after the patch (and clearing the cached and restarting), no image was
displayed

For whatever reason (probably privacy and other settings) I didn't observe the
same in Firefox - no image or placeholder was displayed in the OAPC details
page.

Happy to sign off once Jonathan's question(s) are resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:23:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:23:04 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-6Yx614BFH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #49 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #42)
> 3. The controller/svc script is pretty heavy right now.. I'd love to have
> seen more of this done 'in module' and have the controller lighter and
> perhaps in the REST side of things rather than a new /svc.. but I'm honestly
> not sure how it would fit in REST as yet so have no issue with it in /svc
> for now.

(In reply to David Cook from comment #46)
> One could argue that it shouldn't be in /svc or the REST API, because it's
> not really an API. It's just an authentication endpoint. In terms of the
> controller, it's really just redirecting a browser (and doing some backend
> work which should be in a module for sure).

Since the only Mojolicious implementation is the REST API, that means that the
controller really should stay in our bespoke Koha Plack/CGI scripts. 

With Bug 28325, I started working on a Mojolicious web UI base, but there was
just too much work to do solo, and I ran out of steam.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:30:44 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-uPxcNNw6NC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 03:30:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 01:30:48 +0000
Subject: [Koha-bugs] [Bug 29579] Show saved SQL report ID in database query
In-Reply-To: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29579-70-qe7AQQQZzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29579

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137990|0                           |1
        is obsolete|                            |

--- Comment #15 from David Nind <david at davidnind.com> ---
Created attachment 138068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138068&action=edit
Bug 29579: Show saved SQL report ID in database query

When trying to figure out which saved SQL report caused too much load, it's
useful to have the report id show in the mysql process list.

This patch adds the saved SQL ID number as a comment line in front
of the SQL before passing it to the database.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Create a long running query like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d
4) Connect to the database using koha-mysql
5) Execute "show processlist;"
6) Note the Info column looks something like:
   SELECT * FROM borrowers a, borrowers b, borrowers c, borrowers d /*
saved_sql.id: 1 */

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:43:28 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-hul2VyOMGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137601|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 138069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138069&action=edit
Bug 31132: (follow-up) Reset dropdown values and style button

This follow-up patch resets the dropdown values of the form alongside
the text inputs. It styles the button to look like a link so it doesn't
distract the user and get 'accidentally' clicked when attempting to
submit.

Test that the button looks and behaves as expected after submitting a
search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:43:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:43:24 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-STudrYE4qe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:51:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:51:20 +0000
Subject: [Koha-bugs] [Bug 31228] New: Fix Coce JavaScript to hide
 single-pixel cover images in both the staff client detail and results pages
Message-ID: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

            Bug ID: 31228
           Summary: Fix Coce JavaScript to hide single-pixel cover images
                    in both the staff client detail and results pages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

As reported by Jonathan in bug 31217 koha-tmpl/intranet-tmpl/js/coce.js hides
the coce-coverimg class.

- In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt coce-coverimg
is a class.

- In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt coce-coverimg
is an ID, not a class. 

As ID's are more specific, coce-coverimg should be changed to an ID in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt

And koha-tmpl/intranet-tmpl/js/coce.js should be changed to:
$("#coce-coverimg").remove();

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:56:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:56:22 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-ABO4eu9Rb9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137995|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:56:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:56:45 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-zEY6Equ9n7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138070&action=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because OPAC coce.js targets coce-coverimg as a class, when it is
actually an ID.

Test plan:
1. Set:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio record in the OPAC. Observe no image is
displayed.

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 05:59:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 03:59:42 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-VulqRkw8IV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan and David, 

Thank you both very much for your input. 

I have done the following:

- Changed my patch to '$("#coce-coverimg").remove();'

- Created a new bug report for making a similar change on the staff-side (bug
31228)

- Amended my commit test plan based on your notes David. 

Ready to test again!

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 06:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 04:00:17 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-Afd7a3HBBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31217

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 06:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 04:00:17 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-IOLanxy93M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31228

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 07:52:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 05:52:01 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-kYfoSf09q3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

--- Comment #6 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
(In reply to Katrin Fischer from comment #5)
> I can replicate the issue, when the 'date acquired' is filled in. This gives
> the error every time on adding multiple items:
> 
> Uncaught TypeError: $(...).parent(...).attr(...) is undefined
> 
> Johanna, are you still working on a fix?

I'm on to it. Just came from summer vacation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:53:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:53:49 +0000
Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the
 /patrons REST API route
In-Reply-To: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30063-70-Uhl71x9VpK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31229


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229
[Bug 31229] column visibility broken on patron search view
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:53:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:53:49 +0000
Subject: [Koha-bugs] [Bug 31229] New: column visibility broken on patron
 search view
Message-ID: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

            Bug ID: 31229
           Summary: column visibility broken on patron search view
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30063


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063
[Bug 30063] Make the main patron search use the /patrons REST API route
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:55:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:55:27 +0000
Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
 modules for Koha
In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30444-70-DJ3IwmWNmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
I haven't tested this yet, but after reviewing the code... I can't wrap my head
around how this is supposed to work.

Typically, when you visit http://localhost:8080/cgi-bin/koha/sco/sco-main.pl,
the AutoSelfCheckAllowed will create an authenticated user session using
AutoSelfCheckID and AutoSelfCheckPass. Then, you either provide a cardnumber or
a username/password to move on to the actual self-checkout, but that cardnumber
or username/password doesn't create a "session".

Looking at these patches, why would an external Shibboleth login be triggered? 

I see at
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=30444&attachment=133615
that it says "Do Shibboleth login" but it doesn't do a Shibboleth login.
Rather, it just gets the Shibboleth details out of the environmental variables.
That assumes that you've already been redirected to a SAML IdP and been
returned back to Koha. 

The only way it could work is if you logged into Koha using a SAML IdP and then
visited the self-checkout, which would bypass the AutoSelfCheckAllowed handling
because Koha privileges an existing session (supplied by CGISESSID cookie)
above all else. 

But maybe I'm missing something. Could you detail the exact workflow here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:56:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:56:21 +0000
Subject: [Koha-bugs] [Bug 31229] column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-jYHtxkrjGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:56:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:56:25 +0000
Subject: [Koha-bugs] [Bug 31229] column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-zMIWpjfrgY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138071&action=edit
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 08:59:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 06:59:05 +0000
Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
 modules for Koha
In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30444-70-XlLrLrN8Pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
Also, what happens when you click "Finish"? The external IdP session will still
be valid, so whatever triggers the Shibboleth login will automatically log you
back in again next time, since there's no logout handling here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:00:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:00:59 +0000
Subject: [Koha-bugs] [Bug 31229] column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-GOmwOM1eat@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:01:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:01:50 +0000
Subject: [Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck
 modules for Koha
In-Reply-To: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30444-70-RquVx4eCdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
I'm interested in getting this working, but the only way I can think of it
working would be to have a "Shibboleth" login button that you press in the
Self-Checkout, get redirected to SAML IdP, log in, get redirected back to the
self-checkout which can use the HTTP_ environmental variables to get the SSO
details. 

Then either on timeout or on "Finish" click, there would need to be a logout
call back to the SAML IdP. At least this would be necessary on a public
terminal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:05:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:05:22 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-g4W1oXQqLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
results will have several nodes, you cannot use an id there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:12:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:12:18 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-3IJictPQJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Oh course, thanks Jonathan.

So we should aim to make coce-coverimg a class in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt, correct?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:14:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:14:19 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-48TB1FWyR6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Katrin Fischer from comment #1)
> I can't confirm on master. Which version did you test with Emmi?

I tested on both master and 21.11 which we use. 

It seems this happens because in batchMod.pl line 269 we don't pass
biblionumber as parameter to Koha::UI::Form::Builder::Item->new and thus Koha
fails to fetch biblios marc record. 

However when I tested this on "clean" master database where default framework
has no values in it error wasn't raised.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:18:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:18:05 +0000
Subject: [Koha-bugs] [Bug 31230] New: Add more fields to subscription batch
 edit form
Message-ID: <bug-31230-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31230

            Bug ID: 31230
           Summary: Add more fields to subscription batch edit form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

It would be nice if more fields could be added to the subscription batch edit
form. 

* Patron notification
* Grace period
* Frequency
* Subscription length
* Numbering pattern
* Numbering table

Some fields are quite specific for a serial, but when libraries have multiple
subscriptions for one serial, they would still be a very useful in saving time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:29:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:29:04 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-s6NhyeM0SM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Those patches are simply using a new REST API routes to search and display the
jobs. It make use of the DT wrapper to let the user search and filter the
table, like we do in other places.

There is nothing much I could add.

Test plan:
Add new jobs and filter the table (?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:30:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:30:37 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-uMowQtlEZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Johanna Räisä from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > I can replicate the issue, when the 'date acquired' is filled in. This gives
> > the error every time on adding multiple items:
> > 
> > Uncaught TypeError: $(...).parent(...).attr(...) is undefined
> > 
> > Johanna, are you still working on a fix?
> 
> I'm on to it. Just came from summer vacation.

Thx! Will try to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:36:57 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-m2cTKXuH0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #47)
> (In reply to Katrin Fischer from comment #43)
> > We are happy to have you for this cycle too if you are interested. In the
> > summer time (Europe etc.) we are always struggling a bit more.
> 
> Sounds good to me. Do we need to do anything for me to re-gain my QA genie
> powers?

I think adding yourself to the roles page will suffice ;)
https://wiki.koha-community.org/wiki/Roles_for_22.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 09:54:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 07:54:07 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-1s5glCTCHj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
That's certainly the best we can do, yes.
We could also search for the ID and fallback to class if it does not exist.

The main challenge in my opinion is to keep both opac and staff code as similar
as possible (ie. switch to class for the OPAC if we decide so for staff)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:07:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:07:09 +0000
Subject: [Koha-bugs] [Bug 28854] Add ability to create bundles of items for
 circulation
In-Reply-To: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28854-70-RsP8LxcYd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #504 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
New error/warning in test output

t/db_dependent/Koha/Item.t .. 5/25 DBIx::Class::Storage::DBI::_dbh_execute():
DBI Exception: DBD::mysql::st execute failed: Duplicate entry '987-988' for key
'PRIMARY' at /kohadevbox/koha/Koha/Item.pm line 1601

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:09:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:09:46 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-PJVilbLqSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:09:50 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-ejz25YcqTp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138073&action=edit
Bug 30392: Set deleted_on when an item is (marked as) deleted

We could like to track down when an item has been moved to the
deleteditems table.

Test plan:
Created a new item, delete it
Not that the deleteditems.deleted_on value is set correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:10:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:10:49 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-oZSRq7GIZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What about existing deleteditems rows? Setting deleted_on=timestamp (but might
be wrong), or NULL?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:10:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:10:56 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-4XYqNyDMpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:24:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:24:18 +0000
Subject: [Koha-bugs] [Bug 31229] column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-eNK1GJb77K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138071|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138074&action=edit
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:24:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:24:47 +0000
Subject: [Koha-bugs] [Bug 31229] column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-7njSk5qczz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, signing off.  Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:26:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:26:19 +0000
Subject: [Koha-bugs] [Bug 31231] New: Link authorities automatically does
 not always work
Message-ID: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

            Bug ID: 31231
           Summary: Link authorities automatically does not always work
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hc at interleaf.ie
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 11299 introduced the "Link authorities automatically" function. When the
button is used for fields with only the main heading or the main heading and
one subheading, it works. However, I've noticed a few instances of it not
picking up already existing authority records. When this happens, it generates
a new authority record. Then, if the same authority is used in a new
bibliographic record the "Link authorities automatically" button will link to
the newly created, duplicate authority. 

Example:

In a new bibliographic record, the 650 fields are filled out as follows:

650$a - Biology

650$x - Research

650$y - 1960

There is already an authority record with this content in the 150 field:

150$a - Biology

150$x - Research

150$y - 1960

When the "Link authorities automatically" is clicked, the original authority is
not picked up, but a duplicate authority is created. 

On a new bibliographic record, the same information is added to the 650 fields
and the "Link authorities automatically" is clicked and the duplicate authority
is linked, not the original one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:37:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:37:05 +0000
Subject: [Koha-bugs] [Bug 31232] New: Add note that finescalendar is also
 used when calculation suspension days
Message-ID: <bug-31232-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31232

            Bug ID: 31232
           Summary: Add note that finescalendar is also used when
                    calculation suspension days
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

_get_chargeable_units uses finescalendar to decide if the closing days will be
substracted from the days overdue.

As _get_chargeable_units is also used by _debar_user_on_return, the description
should be amended to include suspensions.

Currently the description reads:

[Use the calendar|Ignore the calendar] when calculating the period for fines.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 10:59:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 08:59:28 +0000
Subject: [Koha-bugs] [Bug 31233] New: Grace period is used for determining
 when a suspension will be placed
Message-ID: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

            Bug ID: 31233
           Summary: Grace period is used for determining when a suspension
                    will be placed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The grace period is labelled "Fine grace period" in the circulation rules, but
will also be used when working with suspension days.

If the chargeable units (days overdue with or without closing days) is smaller
than the grace period, the suspension will not be placed. So we should change
the description in circulation rules probably.


sub _calculate_new_debar_dt {
  [...]
    if ( $deltadays->subtract($grace)->is_positive() ) {
      ... place suspension restriction

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:08:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:08:20 +0000
Subject: [Koha-bugs] [Bug 31234] New: SubfieldsToAllowForRestrictedEditing :
 data from drop-down menu not stored
Message-ID: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

            Bug ID: 31234
           Summary: SubfieldsToAllowForRestrictedEditing : data from
                    drop-down menu not stored
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pierre.genty at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

1. A librarian with edit_items_restricted permission set
2. Item subfield not authorized for editing
(SubfieldsToAllowForRestrictedEditing). In Marc framework, this subfield is
linked to an authorized value (= drop-down menu)
3. When adding/editing item, this subfield has a default value from drop-down
menu and is not editable (OK). 
4. Once item is saved, the subfield is empty : it should have the default value
from drop-down menu.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:22:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:22:13 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-gXAs81m6fD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Failing this one because although it does change the field from date to
datetime, the time is not accurately recorded.

In all of the tests I ran, it records datelastseen as always being at midnight
- e.g. 07/25/2022 00:00

Examples of tests:

- Check an item in
- Manually edit the datelastseen in items editor
- Initiate a manual transfer of the item to another library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:45:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:45:25 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-AU6BCSCffa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
         Resolution|---                         |WORKSFORME

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I think this has since been fixed; I can't replicate the reported issue on the
current branch or on 20.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:50:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:50:45 +0000
Subject: [Koha-bugs] [Bug 31235] New: UseDaysMode is used for calculating
 the expiration date for waiting holds
Message-ID: <bug-31235-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235

            Bug ID: 31235
           Summary: UseDaysMode is used for calculating the expiration
                    date for waiting holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This is also a confusing one: The UseDaysMode system preference, that can also
be set in the circulation rules is described as:

... when calculating the date due. 

BUT: In set_waiting it's also used to calculate the expiration date for holds:

    my $max_pickup_delay = C4::Context->preference("ReservesMaxPickUpDelay");
    my $cancel_on_holidays =
C4::Context->preference('ExpireReservesOnHolidays');

    my $expirationdate = $today->clone;
    $expirationdate->add(days => $max_pickup_delay);

    if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) {
        my $itemtype = $self->item ? $self->item->effective_itemtype :
$self->biblio->itemtype;
        my $daysmode = Koha::CirculationRules->get_effective_daysmode(
            {
                categorycode => $self->borrower->categorycode,
                itemtype     => $itemtype,
                branchcode   => $self->branchcode,
            }
        );
        my $calendar = Koha::Calendar->new( branchcode => $self->branchcode,
days_mode => $daysmode );

        $expirationdate = $calendar->days_forward( dt_from_string(),
$max_pickup_delay );
    }

I feel like this is quite odd as you can set ExcludeHolidaysFromMaxPickUpDelay
to ignore the calendar (and then it will be ignored). 

But if you set it to use the calendar, it can still be ignored when the
UseDaysMode setting is set to ignore calendar. So it should probably be:

Ignore the calendar | Use UseDaysMode setting ...

If asked previously, I'd have said don't make this rely on UseDaysMode and just
use calendar or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:54:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:54:03 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-cHFDUI8bX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, signing off.  Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:54:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:54:47 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-HQyh3fGVUr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128026|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138075&action=edit
Bug 21982: Circulation statistics wizard does not count deleted items

By default statistic assistant filter is set on the
existing items and doesn't mind about deleted items.
The patch corrects this. Items belong to the same library.

Test plan:
1)Make sure to have at least 1 or more item(s) in deleteditems database table
2)Home > Reports > Circulation statistics
3)Fill up 'Issuing library', 'Home library' and 'Holding library'
4)Submit
5)Notice that only statistics for active items are shown
6)Apply patch and repeat from 2) to 5)
7)Now active items and deleted items are shown

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 11:55:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 09:55:51 +0000
Subject: [Koha-bugs] [Bug 31235] UseDaysMode is used for calculating the
 expiration date for waiting holds
In-Reply-To: <bug-31235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31235-70-5VHVhXRbTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31235

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
... and the UseDaysMode description should be amended to include the hold
expiration date and a link to ExcludeHolidaysFromMaxPickupDelay.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 12:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 10:28:43 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-K1LLDGQ3dU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe NULL is better, we messed with the date in a recent update, so they are
most likely wrong. We can still use COALESCE in reports if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 12:46:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 10:46:42 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-DVowbmIsoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:12:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:12:41 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-qo2PuwPSvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Paul Derscheid from comment #2)
> There's another thing: I think that the only Content-Type that makes sense
> for the return value is 'application/marc-in-json' because we return 1..n
> records instead of a single one. 
> 
> Additionally I can't imagine a use-case in which you wouldn't want JSON as a
> return value for that route.
> 
> Is there any sane way to discern marc records from one another in an api
> response?

All of the accepted formats in GET /biblio/{biblio_id} have their plural
representations [1]

BUT I think we could start with 'application/marc-in-json'. and add things
'as-needed'. So if you want to work on this, it'd be ok to just implement
marc-in-json for now.

[1] "application/json" => this is the biblio + biblioitem table, plural is an
arrary,
    "application/marcxml+xml" => there's '<collection>' for multiple records,
    "application/marc-in-json" => as you said, an array,
    "application/marc" => concatenated usmarc records would work,
    "text/plain" => double new line separator would work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:15:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:15:29 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-oRbrTtQsfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
> Then, what's next? Please make sure to work on top of bug 27272 please.

If you all agree with this proposed implementation, once we fix breakages
caused by bug 29697, and bug 27272 pushed, I will implement this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:25:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:25:13 +0000
Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting
 pickup' should not reset the selected tab
In-Reply-To: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30878-70-4sLik8iukr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:25:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:25:16 +0000
Subject: [Koha-bugs] [Bug 30878] Canceling holds from 'Holds awaiting
 pickup' should not reset the selected tab
In-Reply-To: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30878-70-aa3ZXdD7r1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30878

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:36:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:36:59 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-OZmgw3uPrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #6)
> Maybe NULL is better, we messed with the date in a recent update, so they
> are most likely wrong. We can still use COALESCE in reports if needed.

What does the patch then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 13:57:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 11:57:01 +0000
Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header
 which is over 8192 bytes apache's limit
In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31104-70-Bq3epadRzm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
No sure what's going on here, but the selenium tests are failing on jenkins.

They are passing with and without commit "Bug 31104: Put each link on a
separate header"

They are failing after bug 31138.

And actually this patch does not fix the problem, I am still getting "414
Request-URI Too Long".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:11:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:11:18 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-l1H9LcJDS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #116 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138076&action=edit
Bug 29697: Replace some missing occurrences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:11:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:11:33 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-pit8jULsDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:14:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:14:19 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-0rfrTVgmPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138076|0                           |1
        is obsolete|                            |

--- Comment #117 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138077&action=edit
Bug 29697: Replace some missing occurrences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:26:44 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-8qXbi5Wr74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Maybe NULL is better, we messed with the date in a recent update, so they
> > are most likely wrong. We can still use COALESCE in reports if needed.
> 
> What does the patch then.

Not sure I understand. The idea is to give a reliable date, that is not
accidentally overwritten by changes to deleteditems (as we did in the last
update, which triggered the timestamp).

And we start with NULL for the old entries (would be my suggestion)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:27:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:27:25 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-nzBbpstmLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #118 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138078&action=edit
Bug 29697: Fix t/db_dependent/Exporter/Record.t

Not sure about the warn, we shouldn't need it as we are raising an
exception. But better (for now) than introducing regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:29:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:29:31 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-nq8jcvfDuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #119 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138079&action=edit
Bug 29697: Reintroduce wrongly removed import

#   Failed test 'No tests run for subtest "CancelHold"'
 #   at t/db_dependent/ILSDI_Services.t line 806.
 Undefined subroutine &C4::ILSDI::Services::CanReserveBeCanceledFromOpac called
at /kohadevbox/koha/C4/ILSDI/Services.pm line 941.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:31:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:31:08 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-5GvRWPhxx4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #120 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138080&action=edit
Bug 29697: Fix t/Search.t

#   Failed test 'No tests run for subtest "searchResults PassItemMarcToXSLT
test"'
 #   at t/Search.t line 208.
 Undefined subroutine &C4::Biblio::EmbedItemsInMarcBiblio called at t/Search.t
line 194.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:49:58 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-gKM6b3vUXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #121 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138081&action=edit
Bug 29697: Fix t/db_dependent/Search.t

FIXME This does not seem correct.
I bet it was coming from a problem in our test data but apparently all
the items in
t/db_dependent/data/marc21/zebraexport/biblio/exported_records have a
952$9

I don't fully understand why we reach this code without itemnumber.

Not sure this is the correct fix

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:54:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:54:32 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-bJgw2EkgqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
So yes, it's what the patch does :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:57:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:57:30 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-GJ5J0By2vV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138031|0                           |1
        is obsolete|                            |

--- Comment #120 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138082&action=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:57:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:57:36 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-b9eOpIouh3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138032|0                           |1
        is obsolete|                            |

--- Comment #121 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138083&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:57:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:57:43 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-8xgxQYsfGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138033|0                           |1
        is obsolete|                            |

--- Comment #122 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138084&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:57:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:57:53 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-n4FgUigq9J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138034|0                           |1
        is obsolete|                            |

--- Comment #123 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138085&action=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :

<pre>
$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
    #   Failed test 'This list comes from the cache and that is fine'
    #   at t/db_dependent/XSLT.t line 122.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL
</pre>

This one works fine :

<pre>
$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS
</pre>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:58:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:58:03 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-kLnDMjVnuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138035|0                           |1
        is obsolete|                            |

--- Comment #124 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138086&action=edit
Bug 17385: Add custum export format option when saving a record

This patch adds "XSL-Simple Export" when saving a bibliographic
record. Previous patches are combined into this one.

To test:
1) Search for a record in the intranet.
2) Click on the "Save" button and observe the dropdown menu.
3) Notice that "XSL- Simple Export" is not in the menu.
4) Apply the patch.
5) Repeat the steps 1 and 2.
6) Notice that "XSL - Simple Export" is in the menu.
7) Click on "XSL - Simple Export". A .html file should be downloaded.
8) Open the .html file. You should see the record's informations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:58:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:58:14 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-N7lobmppRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138036|0                           |1
        is obsolete|                            |

--- Comment #125 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138087&action=edit
Bug 17385: Correction of opac-detail-sidebar.inc

This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar
is
displayed as wanted. Tests are now passing properly.

TEST PLAN:
1- Apply the patch and search for a record in the OPAC.
2- Click on "Save record". Notice that the dropdown menu is unchanged.
3- Run t/db_dependent/XSLT.t (All tests should pass)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:58:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:58:20 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-jJuejWojXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138037|0                           |1
        is obsolete|                            |

--- Comment #126 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138088&action=edit
Bug 17385: Fixing display for XSL-Simple Export in OPAC

This attachment correct the placement of XSL-Simple Export in the OPAC's page.
It is now displayed in the "Save record" dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 14:59:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 12:59:52 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-BF4igI47y1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
                 CC|                            |shi-yao.wang at inLibro.com

--- Comment #127 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:10:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:10:14 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-yrKcp31reF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #122 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138089&action=edit
Bug 29697: tracklinks should not explode on invalid marc record

Caught by t/db_dependent/www/regressions.t

    #   Failed test '404 for itemnumber containing different URI'
    #   at t/db_dependent/www/regressions.t line 124.
    #          got: '500'
    #     expected: '404'

    #   Failed test '302 for itemnumber with matching URI'
    #   at t/db_dependent/www/regressions.t line 126.
    #          got: '500'
    #     expected: '302'

    #   Failed test '404 for itemnumber containing different URI'
    #   at t/db_dependent/www/regressions.t line 139.
    #          got: '500'
    #     expected: '404'

    #   Failed test '302 for itemnumber with matching URI'
    #   at t/db_dependent/www/regressions.t line 141.
    #          got: '500'
    #     expected: '302'
    # Looks like you failed 4 tests of 36.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:17:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:17:22 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-W1j8wpiyZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138081|0                           |1
        is obsolete|                            |

--- Comment #123 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138090&action=edit
Bug 29697: Fix t/db_dependent/Search.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:19:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:19:12 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-O4RSqUpL94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #2 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Katrin Fischer from comment #1)
> Hi Isabel, there could be a time delay while the job is processed by the
> background jobs. If you go to Aministration > Background jobs, do you see
> any finished/unfinished jobs of type "Batch item record modification" there?

Hi Katrin.

I have just tried: When I click on the link to view the details of the queued
job, I get a 500 error.
The intranet-error logfile gives this output:

AH01215: CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/share/perl5/CGI.pm line 415.:
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl

AH01215: Use of uninitialized value $mode in string ne at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 886.:
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=18080

AH01215: CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/share/perl5/CGI.pm line 415.:
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=18080

AH01215: Can't use an undefined value as an ARRAY reference at
/usr/share/koha/lib/Koha/BackgroundJob/BatchUpdateItem.pm line 175.:
/usr/share/koha/intranet/cgi-bin/admin/background_jobs.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl
End of script output before headers: background_jobs.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:20:16 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-679N5jF10y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #124 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #123)
> Created attachment 138090 [details] [review]
> Bug 29697: Fix t/db_dependent/Search.t
> 
> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

I have looked at the wrong data apparently, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:21:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:21:15 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-OCtGfLdUol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:21:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:21:06 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-AK9Zk7VnJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #125 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:26:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:26:06 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-iNLwvNYwZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Identify the id of the job in the URL and request the DB

select * from background_jobs where id=X

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:28:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:28:03 +0000
Subject: [Koha-bugs] [Bug 15913] It should be possible to restrict a problem
 patron from editing their record or adding comments / tags to records
In-Reply-To: <bug-15913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15913-70-MTCSUChXx9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15913

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:35:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:35:33 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-Qq8drAXYTe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #4 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Jonathan Druart from comment #3)
> Identify the id of the job in the URL and request the DB
> 
> select * from background_jobs where id=X

Ok. This is the content that I get in the fields:
id: 357
status: new
size: 2
borrowernumber: 2
type: batch_item_record_modification    
queue: default
data:
{"exclude_from_local_holds_priority":null,"regex_mod":null,"record_ids":["38409","42755"],"new_values":{"itemnotes":"test","dateaccessioned":"2022-07-25"}}

The other fields are empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:38:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:38:02 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-5UbCs5VkLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #5 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Jonathan Druart from comment #3)
> Identify the id of the job in the URL and request the DB
> 
> select * from background_jobs where id=X

Sorry, I forgot one field:

id: 357
status: new
size: 2
borrowernumber: 2
type: batch_item_record_modification    
queue: default
data:
{"exclude_from_local_holds_priority":null,"regex_mod":null,"record_ids":["38409","42755"],"new_values":{"itemnotes":"test","dateaccessioned":"2022-07-25"}}
enqueued_on: 2022-07-25 07:14:34

The other fields are empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:41:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:41:37 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-EvTj7YJRaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Do you see the two koha-worker processes?

  ps aux | grep koha-worker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:41:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:41:39 +0000
Subject: [Koha-bugs] [Bug 4134] add bibliographic tagging to staff interface
In-Reply-To: <bug-4134-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4134-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4134-70-uB1AtmwefS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4134

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

--- Comment #1 from Holly <hc at interleaf.ie> ---
I'm currently working on 21.11.09 and I think this would be a useful feature to
have.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:42:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:42:39 +0000
Subject: [Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with
 $biblio->metadata->record
In-Reply-To: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29697-70-nLijCMUv6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #126 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #125)
> Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!

I broke, I fix ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 15:50:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 13:50:28 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-3Knigm8oSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #7 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Jonathan Druart from comment #6)
> Do you see the two koha-worker processes?
> 
>   ps aux | grep koha-worker

I get this output:
bibliot+   21230  0.0  0.0   8468   156 ?        S    Jul04   0:00 daemon
--name=biblioteca-koha-worker
--errlog=/var/log/koha/biblioteca/worker-error.log
--stdout=/var/log/koha/biblioteca/worker.log
--output=/var/log/koha/biblioteca/worker-output.log
--pidfiles=/var/run/koha/biblioteca/ --verbose=1 --respawn --delay=30
--user=biblioteca-koha.biblioteca-koha --
/usr/share/koha/bin/background_jobs_worker.pl --queue default
biblio   4191795  0.0  0.0   9208  2216 pts/0    S+   07:46   0:00 grep
--color=auto koha-worker


I have just looked into the worker-error logfile, but it is empty. The
worker-output logfile gives this output:
Can't call method "GetPlugins" on an undefined value at
/usr/share/koha/lib/Koha/BackgroundJob.pm line 402.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:00:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:00:37 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-9ml3BKNRq1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:21:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:21:09 +0000
Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use
 the EmbedItems filter
In-Reply-To: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31224-70-Q0UvUJMjtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:21:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:21:28 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-MlNcQWur4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nick at bywatersolutions.com   |paul.derscheid at lmscloud.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:31:17 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-oiKkBWdlE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Passed QA                   |Patch doesn't apply

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:33:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:33:31 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-rYjHrGH7lG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:33:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:33:34 +0000
Subject: [Koha-bugs] [Bug 26549] Show value of global system preferences on
 subscription form
In-Reply-To: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26549-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26549-70-gLKBpisID3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:33:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:33:36 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-uI0lsylM4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:33:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:33:39 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-aTHKhhScm3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:47:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:47:54 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-QJ3MxYCkEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137744|0                           |1
        is obsolete|                            |
 Attachment #137775|0                           |1
        is obsolete|                            |
 Attachment #137776|0                           |1
        is obsolete|                            |
 Attachment #137994|0                           |1
        is obsolete|                            |

--- Comment #120 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138091&action=edit
Bug 30952: Staff interface redesign (header)

What this patch does:
- change the navigation bar style
- change the breadcrumbs style
- change the "last borrower" link style
- move the search bar inside the navigation bar
- move the help link to the same row as the breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:03 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-AkTTJeum3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #121 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138092&action=edit
Bug 30952: Add Poppins font assets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:10 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-w52uiPPeZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #122 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138093&action=edit
Bug 30952: Move "Go to advanced/item search" link to toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:18 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-AMENkkcBTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #123 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138094&action=edit
Bug 30952: Staff interface redesign (toolbar)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:31 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-J0PatiPl2L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #125 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138096&action=edit
Bug 30952: Staff interface redesign (main page)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:24 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-ehDMx9EX4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #124 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138095&action=edit
Bug 30952: Change checkout, checkin and renew forms

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:37 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-VPUFHgvQeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #126 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138097&action=edit
Bug 30952: Small adjustments in search results page

- Move Z39.50 search button to a toolbar
- Use btn and btn-link classes for "Select all" and "Clear all" buttons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:45 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-bID4OyOq8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #127 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138098&action=edit
Bug 30952: Change MARC tags toolbar style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-6o28VjKkNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #129 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138100&action=edit
Bug 30952: Change sysprefs nav menu style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:48:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:48:52 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-xLAVBap30l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #128 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138099&action=edit
Bug 30952: Change login page style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:49:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:49:05 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-DmGKn7f7i9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #130 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138101&action=edit
Bug 30952: Change default button style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:49:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:49:11 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-EX0kSS6uzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #131 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138102&action=edit
Bug 30952: Change tables style

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:49:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:49:19 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-NTWD9r5eTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #132 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138103&action=edit
Bug 30952: The rest of CSS changes

There is still work to do to split this patch correctly into several
more logical patches. Consider this patch a WIP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:55:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:55:56 +0000
Subject: [Koha-bugs] [Bug 31236] New: Add ability to send custom item fields
 via SIP using Template Toolkit
Message-ID: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

            Bug ID: 31236
           Summary: Add ability to send custom item fields via SIP using
                    Template Toolkit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Koha has been able to send arbitrary item fields via the "item_field" parameter
in the config. We have partners that need the ability to created custom item
fields from templates, as the item_fields feature cannot accomplish what they
need. We need to add a templated custom field feature for items, similar to
what we have for patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:58:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:58:35 +0000
Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via
 SIP using Template Toolkit
In-Reply-To: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31236-70-3qfWUfvThx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 16:58:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 14:58:38 +0000
Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via
 SIP using Template Toolkit
In-Reply-To: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31236-70-JPhUm2EFkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138104&action=edit
Bug 31236: Add ability to send custom item fields via SIP using Template
Toolkit

Koha has been able to send arbitrary item fields via the "item_field" parameter
in the config. We have partners that need the ability to created custom item
fields from templates, as the item_fields feature cannot accomplish what they
need. We need to add a templated custom field feature for items, similar to
what we have for patrons.

Test Plan:
1) Apply this patch
2) Choose a SIP login to use, edit that account and add the following
   *inside* the login section:
   <custom_item_field field="IN" template="[% item.itemnumber %]" />
3) Restart SIP
4) Run an item information query
5) Note the itemnumber is sent in the IN field!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 17:00:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 15:00:43 +0000
Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via
 SIP using Template Toolkit
In-Reply-To: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31236-70-LMMk4X7P84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 17:17:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 15:17:19 +0000
Subject: [Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only
 for Zebra
In-Reply-To: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31191-70-wHq6Q8YZeX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/576
  Text to go in the|                            |This enhancement adds a
      release notes|                            |note to the
                   |                            |FacetLabelTruncationLength
                   |                            |system preference
                   |                            |description that it only
                   |                            |works with Zebra. When
                   |                            |using ElasticSearch, facets
                   |                            |are displayed in full.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 17:35:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 15:35:31 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-2a6qMrfWip@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|solene.desvaux at biblibre.com |julian.maurice at biblibre.com
             Status|Failed QA                   |ASSIGNED

--- Comment #133 from Julian Maurice <julian.maurice at biblibre.com> ---
I have done a bit of cleanup in the patch and split it in more logical patches.
I tried to remove all template changes that were not necessary. Hopefully it
will be easier to review.

There are some changes too (non-exhaustive list):
- The search bar in the header has been "fixed". It's still the same with the
same accessibility issues mentioned earlier, but at least it should be
displayed correctly on all pages, even when the search form have more than one
input. There was some JS code used to fix sizes and positioning, it's gone. All
positioning is done in CSS only now
- The main page regained its old appearance (only colors are different).
- The circulation home page went back to old boring links (still WIP)
- There was some "UIKit" icons added in the previous patch, but only two of
those were used, and those two have an equivalent icon in FontAwesome
(arrow-right and sliders). I decided to remove all UIKit icons from the patch
and use FontAwesome instead.
- QA tests are green :)

There is still work to do, but you can already have a look at it on the
sandbox: https://staff-bug30952.sandboxes.biblibre.eu (user/password as usual)

I also set up a github repository here:
https://github.com/jajm/koha-staff-interface-redesign
I think it can be useful to organize feedbacks/decisions:
  - If you see something that need to be fixed you can open an issue
https://github.com/jajm/koha-staff-interface-redesign/issues/new
  - If you want to discuss something, you can create a new discussion
https://github.com/jajm/koha-staff-interface-redesign/discussions/new

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 17:48:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 15:48:06 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-mk9blRBj77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #134 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
The search bar is always returning to "Check Out". If I do a catalog search,
the bar will return to "Check out" and I need to manually return it to "Search
Catalog" each time. Also, I think the entry in that bar should persist even as
you switch contexts (so if I type something in and realize it's on Check out, I
should be able to switch to Search and not retype).

The floating search header bar has a transparent background, meaning that as
items scroll underneath it, you can no longer read the bar properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 17:55:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 15:55:55 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-JNBDACbhAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #135 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
Moved my comments to the github issues board.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 19:54:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 17:54:17 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-kr6ioanOGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I tried to test this on a sandbox, but even if I "Refresh Schema", there is no
deleted_on column in deleteditems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 21:11:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 19:11:55 +0000
Subject: [Koha-bugs] [Bug 31237] New: Automatic item modifications by age
 needs a run button
Message-ID: <bug-31237-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31237

            Bug ID: 31237
           Summary: Automatic item modifications by age needs a run button
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

There needs to be a way to test an Automatic item modifications by age rule. 
Currently, you have to wait for the conditions to occur naturally and via cron.
 It would be great if there were a way to test a rule against a record, and
also a way to see a preview of results if you don't want the rules to apply
immediately.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 21:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 19:13:07 +0000
Subject: [Koha-bugs] [Bug 31237] Automatic item modifications by age needs a
 way to test rules from the front end
In-Reply-To: <bug-31237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31237-70-HW0CFeq2CL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31237

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Automatic item              |Automatic item
                   |modifications by age needs  |modifications by age needs
                   |a run button                |a way to test rules from
                   |                            |the front end
                 CC|                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:05:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:05:45 +0000
Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)
In-Reply-To: <bug-27252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27252-70-hhcHrEAQXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/575
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:26:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:26:45 +0000
Subject: [Koha-bugs] [Bug 19693] update of an authority record creates
 inconsistency when the heading tag is changed
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-ik7VFAWjHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|authtypefrom incorrectly    |update of an authority
                   |set when updating auth recs |record creates
                   |from file                   |inconsistency when the
                   |                            |heading tag is changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:39:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:39:53 +0000
Subject: [Koha-bugs] [Bug 30214] Send WELCOME notice for new patrons added
 via self registration
In-Reply-To: <bug-30214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30214-70-BcOZ2MUH77@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:47:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:47:32 +0000
Subject: [Koha-bugs] [Bug 31227] Provide option to protect user permissions
 on patron import
In-Reply-To: <bug-31227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31227-70-gEaG9EGUuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31227

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, 

I am not sure which version it was added in, but there is now a feature to
preserve values on import that includes "System permissions" (flags). You can
find it on the patron import page collapsed as "Preserve existing values".

I think this should work or would be a bug otherwise - do you agree?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:49:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:49:13 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-tYoOneA1nf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You are right, Caroline, the patch is missing the database update bits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 22:55:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 20:55:43 +0000
Subject: [Koha-bugs] [Bug 31227] Provide option to protect user permissions
 on patron import
In-Reply-To: <bug-31227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31227-70-CxjGvjgROW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31227

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Yes that sounds good! Will close this

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:15:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:15:22 +0000
Subject: [Koha-bugs] [Bug 31132] Add button to clear the cataloguing
 authority plugin form
In-Reply-To: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31132-70-zHekDVZp63@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The feature itself works nicely, but I am not sure about the placement of the
link as it 'breaks the rule' of the Cancel link always being next to the submit
button.

Looking at the Z39.50 search pop-up, the clear form links is placed inside the
form. Maybe we should do the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:26:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:26:28 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-uoHtdEixnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmi,
yes, that's it:

* Update default framework 952 and add a default value
  Example: Add REF as default for 952$8 with standard sample data
* Collect some barcodes
* Go to Tools > Batch item modification
* Enter barcodes and check checkbox for using default values
* Submit form and boom!

Can't call method "field" on an undefined value at
/kohadevbox/koha/Koha/UI/Form/Builder/Item.pm line 165

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:31:31 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-sfAOrKWIcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can I please have a test plan for this one? I don't know much about the
background jobs yet, so I wonder what the best way would be to ensure I have a
completed and a queued job?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:36:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:36:56 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-S8QEsdeVNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Applied the patches, restart_all:

* The page loads ok, table is empty in my installation
* I check the "Only include jobs started in the last hour" checkbox:
  Error: Something went wrong when loading the table.
  500: Internal Server Error

In my background_jobs table I have several entries, one for
batch_item_record_modification and several update_elastic_index. All are
finished.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:37:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:37:34 +0000
Subject: [Koha-bugs] [Bug 31229] Column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-Dz34uWDNkO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
            Summary|column visibility broken on |Column visibility broken on
                   |patron search view          |patron search view
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:40:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:40:16 +0000
Subject: [Koha-bugs] [Bug 31229] Column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-YveTRCdHP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jul 25 23:40:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 21:40:20 +0000
Subject: [Koha-bugs] [Bug 31229] Column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-qbNHybYJuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138074|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138105&action=edit
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:03:31 +0000
Subject: [Koha-bugs] [Bug 11083] Authority search result display in staff
 interface should be XSLT driven
In-Reply-To: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11083-70-0rZWmyQgLK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/575

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:09:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:09:23 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-P2Hj61aRpM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:09:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:09:28 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-pa7LmiMfR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138075|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138106&action=edit
Bug 21982: Circulation statistics wizard does not count deleted items

By default statistic assistant filter is set on the
existing items and doesn't mind about deleted items.
The patch corrects this. Items belong to the same library.

Test plan:
1)Make sure to have at least 1 or more item(s) in deleteditems database table
2)Home > Reports > Circulation statistics
3)Fill up 'Issuing library', 'Home library' and 'Holding library'
4)Submit
5)Notice that only statistics for active items are shown
6)Apply patch and repeat from 2) to 5)
7)Now active items and deleted items are shown

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:10:12 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-fblX9O9Vap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:10:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:10:29 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-wo2UM5A2Jm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:11:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:11:24 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-deBG4mtoAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #128 from David Nind <david at davidnind.com> ---
Thanks Shi Yao, the patches now apply!

However, I've changed the status to Failed QA as there are:

1. Error traces after the patches are applied:

   a. See error traces for the staff interface - see [1], [2], and [3] (occurs
if the 'XSL - Simple Export' option for OpacExportOptions is either selected or
not selected).

   b. See error traces for the OPAC - see [4].

2. If the 'XSL - Simple Export' option for OpacExportOptions is not selected,
it still appears in the staff interface record details page as a save option.

3. The t/XSLT.t tests fail - see [5].

There is no option in the OPAC cart and lists to download as 'XSL - Simple
Export' - I'm not sure whether there should be or not...

Consolidated test plan so far:
1. Before applying the patches run the tests - these should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t
2. Check current download and save options:
   a. OpacExportOptions system preference: all options selected, note that
there is no 'XSL - Simple Export' option.
   b. for both the OPAC and the staff interface:
      (i) search and add some selected items to the cart: check the download
options - there is no 'XSL - Simple Export' option
      (ii) search and add some items to a new list: check the download lists
options - there is no 'XSL - Simple Export' option
      (iii) from the details page for a record in the OPAC: check the save
record options in the right sidebar, there is no 'XSL - Simple Export' option
      (iv) from the details page for a record in the staff interface: check the
save record options from the menu bar, there is no 'XSL - Simple Export' option
4. Apply the patches and reload everything (flush_memcached, restart_all, clear
your browser cache (or use an incognito/private window)).
5. For the OpacExportOptions system preference, select the new option 'XSL -
Simple Export'.
6. Repeat step 2 - there should now be an 'XSL - Simple Export' option
available for download or saving.
7. Select the 'XSL - Simple Export' in all the paces it appears in the OPAC and
 staff interface - an HTML file should be downloaded.
8. Open the HTML file - you should see the record's information.
9. Run the tests - they should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t

[1] Error trace after clicking on the cart in the staff interface: 

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_basket_basket_2epl::CustomXSLTExportList
called at /kohadevbox/koha/basket/basket.pl line 120
    ....

[2] Error trace when accessing the lists from the staff interface:

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_shelves_2epl::CustomXSLTExportList
called at /kohadevbox/koha/virtualshelves/shelves.pl line 381
    ....

[3] Error trace when selecting Save > XSL - Simple Export from a record's
details page in the staff interface:

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_catalogue_export_2epl::GetMarcBiblio
called at /kohadevbox/koha/catalogue/export.pl line 95
    ....

[4] Error trace when selecting Save record > XSL - Simple Export from a
record's details page in the OPAC:

    Undefined subroutine &C4::Biblio::GetMarcBiblio called at
/kohadevbox/koha/opac/opac-export.pl line 145
    ....

[5] Failed tests for t/XSLT.t

prove -l t/XSLT.t
t/XSLT.t .. 2/12 
#   Failed test 'CustomXSLTExportList finds custom XSLTs'
#   at t/XSLT.t line 107.

#   Failed test 'Title is specified in root node'
#   at t/XSLT.t line 108.
Use of uninitialized value in string eq at t/XSLT.t line 109.

#   Failed test 'Title is filename if not specified'
#   at t/XSLT.t line 109.
# Looks like you failed 3 tests of 12.
t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/12 subtests 

Test Summary Report
-------------------
t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3)
  Failed tests:  10-12
  Non-zero exit status: 3
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.01 sys +  3.46 cusr  0.19
csys =  3.68 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:12:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:12:06 +0000
Subject: [Koha-bugs] [Bug 31205] Adding Custom name to the 'From' field in
 email notices
In-Reply-To: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31205-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31205-70-SQlkdJM864@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this is a dupliate (not the first) to bug 15349.

*** This bug has been marked as a duplicate of bug 15349 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:12:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:12:06 +0000
Subject: [Koha-bugs] [Bug 15349] Problem with email pattern check on forms
In-Reply-To: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15349-70-DA6rRTKOge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tgoatley at gmail.com

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 31205 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:16:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:16:50 +0000
Subject: [Koha-bugs] [Bug 31185] Link authorities automatically doesn't
 detect duplicate authorities
In-Reply-To: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31185-70-aFGt3Zn7DI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31231

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:16:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:16:50 +0000
Subject: [Koha-bugs] [Bug 31231] Link authorities automatically does not
 always work
In-Reply-To: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31231-70-Va8ns18dN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31185

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Holly, I believe this sounds very similar to bug 31185 that has a patch now.
Could you have a look and verify?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:19:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:19:18 +0000
Subject: [Koha-bugs] [Bug 31225] Spine label formatting in PDF is not
 rendering correctly
In-Reply-To: <bug-31225-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31225-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31225-70-PuhmP8HB6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31225

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The callnumbers running into each other could be an issue with your template
settings. There are also currently some other open bugs about label printing,
like bug 29994. Maybe you could check if it relates to your issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:28:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:28:22 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-vKuQ809U19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As I was recently suffering a lot from "Internal server error" on testing
notices, I really like the idea of this.

Of course, the errors are English only and quite technical. And maybe the error
could stand out a bit more. 

I have added a CSS class to the new list element in a follow-up, so libraries
will be able to do additional styling or even hide it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:28:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:28:43 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-WNTp41M1lL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:29:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:29:30 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-l0nVVESI1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137985|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138107&action=edit
Bug 31211: Check slips and notices for valid Template Toolkit and report errors

It would be useful for Koha to run a basic TT validation test and report back
errors.
That way if somebody misses an END tag or something of that nature, it will be
easy to find and fix.

Test Plan:
1) Apply this patch
2) Edit a notice, change the content to simply "[% END %]"
   or some other invalid Template Toolkit
3) Choose "Save and continue editing"
4) Note the new "Template Toolkit error" field that displays the error
   message

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:29:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:29:26 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-aESybOdioB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 00:29:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 22:29:34 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-7WOkaTcjuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138108&action=edit
Bug 31211: (QA follow-up) Add class to new list element for error

To allow additional styling the class template_toolkit_error was
added to the list element.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 01:31:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 23:31:14 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-rCoZLDxNZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #3)
> That's certainly the best we can do, yes.
> We could also search for the ID and fallback to class if it does not exist.
> 
> The main challenge in my opinion is to keep both opac and staff code as
> similar as possible (ie. switch to class for the OPAC if we decide so for
> staff)

Ahh yep, thanks for that Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 01:45:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 23:45:50 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-LclHFbUST6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #69 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 138109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138109&action=edit
Bug 27272: Add search_ordered sub to order items with extra conditions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 01:56:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 23:56:15 +0000
Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx
 fields)
In-Reply-To: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23412-70-qfNDiBx84l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to Lucas Gass from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > I am still not sure we should bend the standard like that... especially as
> > it will break things like the sample below with the <> as part of the text.
> 
> I think you are correct and we should not bend the standard like this,
> marking this as wont fix.

I'm not sure I follow. Which standard would be bent by allowing HTML?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 01:59:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jul 2022 23:59:37 +0000
Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx
 fields)
In-Reply-To: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23412-70-COu0GjC4BT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
On the topic of standards, I think that this is my favourite MARC field:

887 - Non-MARC Information Field (R)
https://www.loc.gov/marc/bibliographic/bd887.html

I think it was probably intended for XML data outside the MARC schema, but I've
seen some wild things in there before...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 02:00:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 00:00:39 +0000
Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx
 fields)
In-Reply-To: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23412-70-RX9All6m9M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #10)
> On the topic of standards, I think that this is my favourite MARC field:
> 
> 887 - Non-MARC Information Field (R)
> https://www.loc.gov/marc/bibliographic/bd887.html
> 
> I think it was probably intended for XML data outside the MARC schema, but
> I've seen some wild things in there before...

Technically, I would say that XHTML is allowed in the 887 at least.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 02:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 00:02:19 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-TFRJOaSxQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #51 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #50)
> (In reply to David Cook from comment #47)
> > (In reply to Katrin Fischer from comment #43)
> > > We are happy to have you for this cycle too if you are interested. In the
> > > summer time (Europe etc.) we are always struggling a bit more.
> > 
> > Sounds good to me. Do we need to do anything for me to re-gain my QA genie
> > powers?
> 
> I think adding yourself to the roles page will suffice ;)
> https://wiki.koha-community.org/wiki/Roles_for_22.11

Ah right. I think I meant to add myself for 23.05 but accidentally added myself
to 22.11 previously. Happy accident!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 04:36:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 02:36:06 +0000
Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime
In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31212-70-HMX2KkGQ2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Andreas Roussos <a.roussos at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.roussos at dataly.gr

--- Comment #3 from Andreas Roussos <a.roussos at dataly.gr> ---
Hi Michal,

I concur with Sally; your patch, as it stands, does not work 100%.
However, fear not! The Community is here to help! ;-)

Since you're changing a column definition in the DB, you may want
to have a look at these guidelines:
https://wiki.koha-community.org/wiki/Database_updates

The gist of it is that when you alter the database schema, you need
to accommodate for both
a) new installations (which you did by modifying the installer's DB
   structure in installer/data/mysql/kohastructure.sql), *and*
b) existing installations by means of creating an atomicupdate file.

Also, since the DATETIME column will now be able to store the exact
time the item was last seen down to the second, you'll have to ensure
the timestamp is stored with the correct accuracy in the DB.

Finally, don't forget the unit tests whenever you want to submit a
patch, as they can help you find oversights in your submitted code.
As usual, the details are in the Wiki:
https://wiki.koha-community.org/wiki/Unit_Tests#Good_practices_for_running_tests

I hope this helps!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 07:09:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 05:09:20 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-yFacIShHSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 138110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138110&action=edit
Bug 15348: (follow-up) Fix modal to edit delivery date

This allows you to empty the delivery date and ensures the current date
shows

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 07:10:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 05:10:55 +0000
Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per
 order line
In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15348-70-SMMxMjnwwv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #50 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #48)

> I have created 3 orders:
> 2022-07-30
> 2022-07-19
> NULL - calculated from 10 days in vendor: 2022-07-29
> 
> When I search for:
> - 2022-07-01 - 2022-07-30  - OK, all show
> - 2022-07-01 - 2022-07-29  - NOT OK, still all three show, but 30 should not
> - 2022-07-01 - 2022-07-27  - NOT OK, 30t and 19 show, but 29, the calculated
> one does not
> 
> I've tried the dd.mm.yyyy and the yyyy-mm-dd Dateformat settings and the
> behaviour is the same. Can you help?
> 

Still working on this

> Are moddelivery.tt/.pl fallbacks for no JavaScript?

Yes, it matches the behaviour of the internal and vendor notes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 07:41:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 05:41:50 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-9VGXX5K3ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138070|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 07:42:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 05:42:31 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-M8eLqKE6Lp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138111&action=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because opac-detail.tt has coce-coverimg as an ID, but OPAC
coce.js targets coce-coverimg as a class.

opac-detail.tt should be changed to have coce-coverimg as a class.

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the OPAC. Observe no image is
displayed.

8. View another OPAC biblio detail page that does have a successfully
loading coce image and confirm the source of that image is listed: For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 07:59:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 05:59:53 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-aBSg3pY6Yw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138112&action=edit
Bug 31228: Intraneyt coce.js is not hiding the coce-coverimg div for
single-pixel images

This is because the intranet detail.tt has coce-coverimg as an ID. Intranet
results.tt has coce-coverimg as a class. Intranet coce.js targets coce-coverimg
as a class.

Intranet detail.tt should be changed to have coce-coverimg as a class.
This is inline with the change made to the OPAC in bug 31217

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- IntranetCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the intranet. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the intranet. Observe no image is
displayed.

8. Do an intranet search to get the biblio returned in search results
page. Confirm no cover image box is displayed

9. View the intranet search result and detail pages for a different
biblio that you know Coce should be displaying the cover image of and
confirm that it is correctly displayed with the source of that image listed:
For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:00:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:00:15 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-7Fkg77OzD7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138112|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:01:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:01:02 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-FuUs5MSNRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #6 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 138113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138113&action=edit
Bug 31228: Intranet coce.js is not hiding the coce-coverimg div for
single-pixel images

This is because the intranet detail.tt has coce-coverimg as an ID. Intranet
results.tt has coce-coverimg as a class. Intranet coce.js targets coce-coverimg
as a class.

Intranet detail.tt should be changed to have coce-coverimg as a class.
This is inline with the change made to the OPAC in bug 31217

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- IntranetCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the intranet. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the intranet. Observe no image is
displayed.

8. Do an intranet search to get the biblio returned in search results
page. Confirm no cover image box is displayed

9. View the intranet search result and detail pages for a different
biblio that you know Coce should be displaying the cover image of and
confirm that it is correctly displayed with the source of that image listed:
For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:02:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:02:07 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-p1fdfoRl6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |alexbuckley at catalyst.net.nz
             Status|NEW                         |Needs Signoff
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:10:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:10:06 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-bCJExq5NNl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #8 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
I've gone ahead and added patches on this bug report and 31228 to switch to
using coce-coverimg as a class consistently in the OPAC and staff client. 

I have found that browser caching can make this a tricky thing to test.

Ready for testing again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:27:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:27:19 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-TYrRxexXre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:45:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:45:02 +0000
Subject: [Koha-bugs] [Bug 30982] Use the REST API for background job list
 view
In-Reply-To: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30982-70-YgqCLlRe7I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138114&action=edit
Bug 30982: Add 'context' to the REST API specs

context has been added by bug 30889

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:54:44 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-mJVxp1PAlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138115&action=edit
bug 30392: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:55:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:55:00 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-qqEki5sVvk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Oops, sorry, I forgot to attach one patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 08:54:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 06:54:40 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-GC9msVOF3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:01:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:01:37 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-kCp6nwNQLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137134|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138118&action=edit
Bug 31017: Add new vendor_type field to edit screen and display

This patch adds a new vendor_type field when creating/editing vendors
and displays the field on search and details for a vendor

To test:
 1 - Apply patch, update database
 2 - Edit/create a vendor in acquisitions
 3 - Note new 'Vendor type' field, free text in editor
 4 - Save a value
 5 - Confirm it displays in vendor search results and vendor main page
 6 - In Authorised values add a new value to 'VENDOR_TYPE' category
 7 - Confirm the description of VENDOR_TYPE shows and makes sense
 8 - Add/Edit a vendor, note the vendor type is now a dropdown selection
 9 - Save with a value
10 - Confirm the description shows in results and vendor page and vendor
details

Signed-off-by: Caroline <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: KIT Library Germany <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:01:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:01:30 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-lh2CWp9xr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136443|0                           |1
        is obsolete|                            |

--- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138116&action=edit
Bug 31017: DB Updates

Signed-off-by: KIT Library Germany <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:01:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:01:33 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-Gxf0a84L6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138117&action=edit
Bug 31017: DO NOT PUSH - Schema updates

Signed-off-by: KIT Library Germany <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:11:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:11:56 +0000
Subject: [Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx
 fields)
In-Reply-To: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23412-70-G5HKhhRWmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the problem is not the HTML so much as the expectation that it should
render... and then it will be used for formatting, which is not a good mix
usually - formatting and data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:17:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:17:59 +0000
Subject: [Koha-bugs] [Bug 31231] Link authorities automatically does not
 always work
In-Reply-To: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31231-70-W2brvhja3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

--- Comment #2 from Holly <hc at interleaf.ie> ---
I'm not sure it is. Bug 31185 seems to be about when duplicate authorities
already exist and you try to use the "Link authorities automatically" button. 

What I am seeing is in situations where there is only one authority, but it has
content in multiple subfields, the "Link authorities automatically" button
can't pick up the one authority and duplicates it. So, "Link authorities
automatically" is wrongly creating new authorities.

Please let me know if I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:19:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:19:51 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-xIhy7cYCYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136444|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:27:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:27:34 +0000
Subject: [Koha-bugs] [Bug 31231] Link authorities automatically does not
 always work
In-Reply-To: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31231-70-U3aBtQ1dML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was not sure if they were the same, so that's perfectly fine. Thx for taking
a look!  I'll keep them linked with see also, because they touch the same area
at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:33:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:33:35 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-1EiegREKcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #14 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
I tested in Bywater's sandbox.

If I deleted item via batch item delete (backgroun jobs), it is deleted but
deleted_on is empty in deleteditems table.

If I delete the item from "additem.pl?op=edititem&biblionumber=" page (Actions
-> Delete) I get this error message:

DBIx::Class::Row::store_column(): No such column 'deleted_on' on
Koha::Schema::Result::Deleteditem at /kohadevbox/koha/Koha/Item.pm line 341
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

There is deleted_on column on items and deleteditems table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:34:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:34:28 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items - not working anymore in
 22.05
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-YIdfpkRsan@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gveranis at dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 09:46:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 07:46:22 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-qOtJjtPBHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Anneli, are you testing using the sandboxes or ktd?

If ktd, run: dbic
If sandboxes, got to Actions > Refresh schema

This should hopefully make the error go away.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 10:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 08:49:17 +0000
Subject: [Koha-bugs] [Bug 31238] New: Unable to save authorised value to
 frameworks subfields
Message-ID: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

            Bug ID: 31238
           Summary: Unable to save authorised value to frameworks
                    subfields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emmi.takkinen at koha-suomi.fi
        QA Contact: testopia at bugs.koha-community.org

While working on bug 31154 I stumbled on problem described above. As it states
I'm unable to save authorised value to frameworks subfields and was wondering
is anyone able to repeat this.   

I suspect that this is caused by changes made in bug 29001, before it variable
$authorised_value in marc_subfields_structure.pl is succesfully filled with
value indented to be saved. After applying bug again $authorised_value is
undef.

To test:
1. Edit e.g. default frameworks subfield 952$8
2. Add or change fields authorised value
3. Save your changes
=> note that on subfield listing there is no mention that 952$8 is linked to
any authorised value
=> if you edit 952$8 authorised value input is empty

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 10:57:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 08:57:14 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-fkfuQiwrlu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
There seems to be a minor typo on marc_subfields_structure.pl, 

>$input->param("authorised_values_$id") 
should be 

>$input->param("authorised_value_$id")

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 10:57:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 08:57:26 +0000
Subject: [Koha-bugs] [Bug 31239] New: search_for_data_inconsistencies.pl
 fails for Koha to MARC mapping using biblio table
Message-ID: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239

            Bug ID: 31239
           Summary: search_for_data_inconsistencies.pl fails for Koha to
                    MARC mapping using biblio table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The script misc/maintenance/search_for_data_inconsistencies.pl search for
invalid values using Koha to MARC mapping fields.
The tables items and biblioitems are OK but mappings can be on biblio table :
  my $value = $table eq 'items' ? $i->$column : $i->biblioitem->$column;

For example in UNIMARC if fails with error :

The method Koha::Biblioitem->medium is not covered by tests!
Trace begun at /home/koha/src/Koha/Object.pm line 880
Koha::Object::AUTOLOAD('Koha::Biblioitem=HASH(0x55c9a1905a40)') called at
/home/koha/src/misc/maintenance/search_for_data_inconsistencies.pl line 196

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:05:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:05:54 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-HY1TcRIxzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 138119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138119&action=edit
Bug 31238: Fix typo in marc_subfields_structure.pl

After bug 29001 one is unable to save authorised value to frameworks
subfields. This is caused by minor typo in marc_subfields_structure.pl.

To test:
1. Edit e.g. default frameworks subfield 952$8
2. Add or change fields authorised value
3. Save your changes
=> note that on subfield listing there is no mention that 952$8 is linked to
any authorised value
=> if you edit 952$8 authorised value input is empty
4. Apply this patch.
5. Repeat steps 1.-3.
=> authorised value should now be saved

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:14:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:14:35 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-PUHB1ni4SL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

--- Comment #8 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
Created attachment 138120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138120&action=edit
Bug 23202: Problems when adding multiple items to an order in acquisitions

This patch fixes adding multiple items on order acquisitions

1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field.
2) Create basket to a vendor and add order from a new empty record.
3) Add date acquired value from calendar.
4) Add multiple items and see that the view freezes.
5) Apply the patch
6) Reload the page and repeat the steps 3 and 4.
7) See that the items are added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:26:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:26:11 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-IFmVEou6ur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:31:37 +0000
Subject: [Koha-bugs] [Bug 19693] update of an authority record creates
 inconsistency when the heading tag is changed
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-tEvhIeCw9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69350|0                           |1
        is obsolete|                            |

--- Comment #6 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 138121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138121&action=edit
Bug 19693: update of an authority record creates inconsistency when the heading
tag is changed

Since after a few years the problem is still unresolved here comes a new
attempt to address it:

In those rare cases when authorities are updated by an external agency (or
even internally, by reviewing and correcting an exported authority file)
when the heading tag will be changed (seems odd but happens:

111 Congress ==> 110 Corporate body.Congress ;
100 Person ==> 110 Corporate body (a company named with person's name ;
151 City--object ==> 150 Object (city) etc.)

and then the authority record in Koha database will be updated with
bulkmarcimport or by calling directly ModAuthority from a custom script,
the merge function "doesn't know" that the change to the authority type
has been made and, consequently, doesn't adequately change the tag in
related fields in biblio records (as it would if two different records
with different authtypecode were merged with Koha interface).

This is because at the moment when merge function is being called
by ModAuthority:
Koha::Authority::Types->find($autfrom->authtypecode)
Koha::Authority::Types->find($authto->authtypecode)
both have the same value (because $mergefrom == $mergeto).

Therefore in case when $mergefrom == $mergeto and the heading tag changes,
$authtypefrom and $authfrom calculated in merge in the ordinar way are
misleading and should not be taken unto consideration.

Test plan:
==========

1. run t/db_dependent/Authority/Merge.t
2. you should see problems in "Test update A with modified heading tag
   (changing authtype)"
3. apply the patch
4. run t/db_dependent/Authority/Merge.t again
5. the test should pass

Alternatively:

1. have an authority record used in biblio;
   export it to file;
   change 1XX heading tag to a different (but reasonable) value
   and possibly change also the content of the heading
   (one can delete also 942 but it doesn't matter);
   make bulkmarcimport.pl -a -update -file <modified_auth_file> and
   see that the tag in biblio record has not been changed (whereas
   the type of authority record did change);

2. make orders in database (so that the authority type and the tag of
   the field in biblio record correspond); apply the patch;

3. repeat the test from 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:33:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:33:13 +0000
Subject: [Koha-bugs] [Bug 19693] update of an authority record creates
 inconsistency when the heading tag is changed
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-P20QgTave6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek <januszop at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
           Priority|P5 - low                    |P3
           Severity|minor                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:32:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:32:30 +0000
Subject: [Koha-bugs] [Bug 19693] update of an authority record creates
 inconsistency when the heading tag is changed
In-Reply-To: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19693-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19693-70-qLiwj0zYtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

--- Comment #7 from Janusz Kaczmarek <januszop at gmail.com> ---
Created attachment 138122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138122&action=edit
Bug 19693: Add test sub to Merge.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:43:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:43:34 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-R4VnrOH3XZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #5 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
The other issue is that this route can be abused for DOS-attacks which must be
handled somehow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:38:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:38:04 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-BgHQ7Vi9SR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #4 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Created attachment 138123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123&action=edit
Bug 25870 - Add a q_ccl query parameter to /biblios

This patch adds new functionality to the existing /public/biblios route.
Instead of specifying a biblio by a biblionumber as a path parameter, you can
use the new q_ccl query parameter to run a query on the endpoint.

To test:
1) Apply the patch
2) Pick an endpoint tester of your choice, e.g. Insomnia or the ThunderClient
if you use VSCode or derivatives.
3) Run a query while using Zebra.
4) Observe the marc-in-json response and check for validity.
5) Run a query while using Elasticsearch.
6) Again, observe the marc-in-json response and check for validity.
7) I'd love to say: 'Sign-Off' but the unit tests need work and I need help
with that, so.. an attachment or guidance would be great.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 11:55:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 09:55:20 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-dqWK2oz6bn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Anneli Österman <anneli.osterman at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #16 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
Katrin, thanks, refreshing the schema helped! :)

There is a deleted_on column on both items and deleteditems table and it is
updated when item is deleted (regardless of the method used, batch delete or
actions/delete in modify page.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 12:34:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 10:34:26 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-EJScaD0PX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #5 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 138124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138124&action=edit
Bug 31154: Pass biblionumber to Koha::UI::Form::Builder::Item->new from
batchMod.pl to prevent error 500

When one tries to batch mod items and has "Use default values"
checkbox checked on and their default framework contains
default values, Koha dies on error 500. In logs it reads:

Can't call method "field" on an undefined value at
.../Koha/Koha/UI/Form/Builder/Item.pm line 164.

This happens because in batchMod.pl line 269 we don't pass
biblionumber as parameter to Koha::UI::Form::Builder::Item->new
and thus Koha fails to fetch biblios marc record.

To test:
1. Update default framework 952 and add a default value
* Example: Add REF as default for 952$8 with standard sample data
2. Find some item(s) to modify
3. Provide barcodes of those item(s) and check checkbox "Use default values"
4. Hit "Continue"
=> error 500 is raised
5. Apply patch.
6. Repeat steps 3. and 4.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 12:49:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 10:49:20 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-lQZ7YoYqPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #7 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
That's right but at LMSCloud we need this as a public route and tcohen also
wants this to be public, so the simple approach doesn't fly. 

Thanks for the pointers, I'll have a look in a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 12:46:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 10:46:26 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-1RFky1WGTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Paul Derscheid from comment #5)
> The other issue is that this route can be abused for DOS-attacks which must
> be handled somehow.

Wouldn't the simplest solution be to make it *not* public, and just require the
catalogue permission?

Another option would be to bake in a rate limiting middleware such as
https://metacpan.org/pod/Plack::Middleware::Throttle or
https://metacpan.org/pod/Plack::Middleware::Throttle::Lite

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 12:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 10:50:05 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-NKZF9bii6x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Also https://metacpan.org/pod/Plack::Middleware::Cerberus

We need something that throttles by the minute or even second if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 12:53:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 10:53:36 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-DaksAEaF5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #6)
> Created attachment 138108 [details] [review]
> Bug 31211: (QA follow-up) Add class to new list element for error
> 
> To allow additional styling the class template_toolkit_error was
> added to the list element.
> 
> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Good idea! Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:31:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:31:39 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-ifJqdUzlVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Paul Derscheid from comment #5)
> The other issue is that this route can be abused for DOS-attacks which must
> be handled somehow.

Isn't that already the case for bots hitting opac-search.pl?

I think we need to introduce some tool for throttling, but not necessarily as
part of this dev, as it is really tricky (e.g. it will be common for campus
sites to be queried many times from a transparent proxy on the LAN so we will
also need to be able to configure exceptions...).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:36:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:36:36 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-q6IaeSnMeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #13)
> That is a good point. Now, we just need to add throttling to this api, then
> use that api in opac-search.... ;)
>
> Tomas, at this time I think you have the ultimate authority to declare
> throttling "out of scope" and move it to a new bug report.

I think we should file a separate bug, yes. And I wouldn't make this one
dependent on the new one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:35:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:35:31 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-NspUWeqC6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Paul Derscheid from comment #7)
> That's right but at LMSCloud we need this as a public route and tcohen also
> wants this to be public, so the simple approach doesn't fly. 

We can have both, really. And when we say 'public' we mean 'unprivileged
access' which could or not imply authentication.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:14:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:14:05 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-k894YFWVBs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #9 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Another question is what a sane 'number of requests/interval' would look like.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:34:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:34:19 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-7BKIbx6IFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Paul Derscheid from comment #5)
> > The other issue is that this route can be abused for DOS-attacks which must
> > be handled somehow.
> 
> Isn't that already the case for bots hitting opac-search.pl?
> 
> I think we need to introduce some tool for throttling, but not necessarily
> as part of this dev, as it is really tricky (e.g. it will be common for
> campus sites to be queried many times from a transparent proxy on the LAN so
> we will also need to be able to configure exceptions...).

That is a good point. Now, we just need to add throttling to this api, then use
that api in opac-search.... ;)

Tomas, at this time I think you have the ultimate authority to declare
throttling "out of scope" and move it to a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:27:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:27:59 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-wnS3SPtAv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Paul Derscheid from comment #9)
> Another question is what a sane 'number of requests/interval' would look
> like.

I think that depends on the power of the server, and your use case. What will
you be using this API for?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:38:17 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-M6ujtpcgvy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'd really like to see us get away from Apache based solutions, but at the same
time it's a very practical way to handle it that works for 99.9% of Koha users.
If there exists middleware that would work for Koha, that would be a better
solution IMO, especially because we can bake the throttling settings directly
into Koha.

Now, I think we've done enough bike-shedding. We should move this discussion to
a throttling specific bug report!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:45:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:45:38 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-yR8hhElTZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 138123
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123
Bug 25870 - Add a q_ccl query parameter to /biblios

Review of attachment 138123:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25870&attachment=138123)
-----------------------------------------------------------------

::: Koha/REST/V1/Biblios.pm
@@ +160,5 @@
> +    my $record_processor = Koha::RecordProcessor->new(
> +        {
> +            filters => 'ViewPolicy',
> +            options => {
> +                interface => 'opac',

I think you could implement only a list() method, and rely on
$c->stash('is_public') to choose staff vs. public. And later check the
OpacHiddenItems stuff accordingly.

@@ +177,5 @@
> +            }
> +        );
> +    }
> +
> +    sub format_record_by_content_type {

This inline subs look really untidy.

@@ +243,5 @@
> +        }
> +
> +        my $response =
> +          format_record_by_content_type(
> +            { content_type => $requested_content_type, records => \@records } );

It feels like this method call should be placed in the data => portion of the
respond_to, with the right parameters for each case instead of 'detecting it'
inside format_record_... But as I said, I'm still not convinced by those subs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 13:33:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 11:33:13 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-BgwRhjeByu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Paul Derscheid from comment #5)
> > The other issue is that this route can be abused for DOS-attacks which must
> > be handled somehow.
> 
> Isn't that already the case for bots hitting opac-search.pl?

What I meant to say is that introducing this route just adds another place we
need to take care of. But the solution is needed in general. Maybe at Apache
level.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:00:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:00:41 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-PHoCVcje2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:23:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:23:43 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-HRW2u4f5ti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:00:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:00:52 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-I79PCeJgHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138127&action=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:15:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:15:00 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-NEaY5TnDkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138119|0                           |1
        is obsolete|                            |

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 138125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138125&action=edit
Bug 31238: Fix typo in marc_subfields_structure.pl

After bug 29001 one is unable to save authorised value to frameworks
subfields. This is caused by minor typo in marc_subfields_structure.pl.

To test:
1. Edit e.g. default frameworks subfield 952$8
2. Add or change fields authorised value
3. Save your changes
=> note that on subfield listing there is no mention that 952$8 is linked to
any authorised value
=> if you edit 952$8 authorised value input is empty
4. Apply this patch.
5. Repeat steps 1.-3.
=> authorised value should now be saved

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:00:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:00:47 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-ujKNuxgjZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138126&action=edit
Bug 31223: Regression tests

This patch adds tests so we are sure things don't explode with/without
plugins enabled.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:30:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:30:23 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-ZywyfUFX8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:00:18 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-DcIyBCmKRN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:38 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-N23m1eSeH3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:06:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:06:34 +0000
Subject: [Koha-bugs] [Bug 31017] Add type field for vendors
In-Reply-To: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31017-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31017-70-eL8QJQKILu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31017

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a new
      release notes|                            |field to record the vendor
                   |                            |type when creating or
                   |                            |editing vendors. This field
                   |                            |can be used as a free text
                   |                            |field, or a drop-down menu
                   |                            |if there are authorized
                   |                            |values in the VENDOR_TYPE
                   |                            |authorized value category.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:40 +0000
Subject: [Koha-bugs] [Bug 31229] Column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-qAJ7lD6WnP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:24:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:24:50 +0000
Subject: [Koha-bugs] [Bug 30700] Patrons who can log into staff client
 should be able to change their own password
In-Reply-To: <bug-30700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30700-70-viOcLTB7VI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:30 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-SDTaE1TQA1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:35 +0000
Subject: [Koha-bugs] [Bug 31211] Check slips and notices for valid Template
 Toolkit and report errors
In-Reply-To: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31211-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31211-70-iIyMXKHnM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:33 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-HRuxpe59uW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:28:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:28:05 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-snqI2hUoJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:51:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:51:55 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-IZzKrUUp4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138131&action=edit
Bug 31223: Do not try to report results if task not started

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:57:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:57:18 +0000
Subject: [Koha-bugs] [Bug 21982] Circulation statistics wizard does not
 count deleted items
In-Reply-To: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21982-70-0mJK5yC00V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
  Text to go in the|                            |This patch corrects a bug
      release notes|                            |in the Circulation
                   |                            |statistics wizard.
                   |                            |Previously, the wizard only
                   |                            |looked at existing items to
                   |                            |calculate statistics. It
                   |                            |now includes transactions
                   |                            |made on items that are now
                   |                            |deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:50:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:50:06 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-z8zQhd5QB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138127|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:08:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:08:10 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-DxMyTdzu2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I cannot reproduce the problematic behaviour either in a sandbox nor on my
local dev install with the steps from comment 4. In all cases, I am brought to
the batch item modification page without problem and am able to launch the
batch modification.

I do get a 500 error when I click on the "View detail of the enqueued job" link
to see the background job.

I tried with and without the patch and get the same behaviour...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:34:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:34:43 +0000
Subject: [Koha-bugs] [Bug 31229] Column visibility broken on patron search
 view
In-Reply-To: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31229-70-62IDid0F7s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:50:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:50:37 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-ym4soCxePK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:51:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:51:46 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-RGaCqGHKbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138129&action=edit
Bug 31223: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:54:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:54:19 +0000
Subject: [Koha-bugs] [Bug 31236] Add ability to send custom item fields via
 SIP using Template Toolkit
In-Reply-To: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31236-70-UHfPyuOIMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:49:59 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-BtdwqRgnG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138128|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:35:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:35:06 +0000
Subject: [Koha-bugs] [Bug 30837] Fix table width on 'Print summary'
In-Reply-To: <bug-30837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30837-70-XJsDTNSHky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30837

pierre.genty at biblibre.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pierre.genty at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 14:48:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 12:48:06 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-cwqp0bEcAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
           Keywords|                            |rel_22_05_candidate
             Status|NEW                         |ASSIGNED
            Version|22.05                       |master
            Summary|Batch edit items - not      |Batch edit items explodes
                   |working anymore in 22.05    |if plugins disabled

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:13:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:13:45 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-EM4sbN0kSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138136&action=edit
Bug 30077: (follow-up) Set max width for library drapdown

If you have a library with a very long name the dropdown will expand to
accommodate it. I think this is awkward-looking, so I propose to set a
max width on <select> elements in the header search region.

The patch requires a rebuild of the staff interface CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:59:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:59:15 +0000
Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
 CSV or spreadsheet
In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18392-70-ZF5e4OfjQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
           Keywords|release-notes-needed        |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:21:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:21:27 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-AUwv3k3FW7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang <shi-yao.wang at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #130 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
(In reply to David Nind from comment #128)
> Thanks Shi Yao, the patches now apply!
> 
> However, I've changed the status to Failed QA as there are:
> 
> 1. Error traces after the patches are applied:
> 
>    a. See error traces for the staff interface - see [1], [2], and [3]
> (occurs if the 'XSL - Simple Export' option for OpacExportOptions is either
> selected or not selected).
> 
>    b. See error traces for the OPAC - see [4].
> 
> 2. If the 'XSL - Simple Export' option for OpacExportOptions is not
> selected, it still appears in the staff interface record details page as a
> save option.
> 
> 3. The t/XSLT.t tests fail - see [5].

1. There shouldn't be any errors now

2. The system preference has the word "Opac" in it so I assume it only affects
OPAC interface and not the staff interface

3. Couldn't run the test on my machine because I have trouble installing
Test::DBIx::Class. Hope it works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:42:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:42:42 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-8DVm3rUXQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:14:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:14:30 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17385-70-jkN0OoIBWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #129 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
Created attachment 138132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138132&action=edit
Bug 17385: Add missing imports and equivalent code for GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:12:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:12:44 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-UP1UKlQOYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138128&action=edit
Bug 31223: Do not try to report results if task not started

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:27:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:27:45 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-BY0lw3BdT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #20 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
It worked on my local installation :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:32:58 +0000
Subject: [Koha-bugs] [Bug 26689] Monetary accounts notices should be
 definable at the credit_type/debit_type level
In-Reply-To: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26689-70-kiRfSOp4nt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:50:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:50:03 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-apqzW7zRWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138126|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:09:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:09:13 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-bzQnSzeY1T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:40:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:40:12 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-dBInLXooHt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16882 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:37:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:37:01 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-vvvY818CQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=30654

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:49:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:49:56 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-7i5WF7ufxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:40:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:40:12 +0000
Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue
 should be removed when the offending item is returned
In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16882-70-vmCtoobOcE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think 29145 would work here, but is currently failed QA.

*** This bug has been marked as a duplicate of bug 29145 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:09:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:09:17 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-Ds3bJ6mhNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132821|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138133&action=edit
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC
file

This patch updates addorderiso2709.tt so that it uses Bootstrap tabs
intead of jQuery.

The patch contains indentation changes, so diff accordingly.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that the tabs work correctly.

Signed-off-by: Séverine Queune <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:52:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:52:03 +0000
Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that
 would not result in debarment when removing overdue debarments
In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29145-70-G1EZxQnIRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David and Stefan,

looking into this and trying to rephrase what I think this does:

If an item is returned, we check if the patron is still restricted by an
OVERDUES restriction. If that's the case, we check if they have any remaining
checkouts that have triggered an OVERDUES restriction (are overdue long
enough). If there are no such remaining checkouts, we undebar.

Is that about right?

1) Could you please add a test plan and some description to the commit message?

2) You are missing the sysprefs.sql change for adding a new system preference
in your patch. And in the pref file, don't use yes/no, but 0/1.

3) The new pref is named: ODueDebarmentRemovalAllowUnrestricted

I wonder if instead of using a new pref, it might be nicer to change the
existing pref AutoRemoveOverduesRestrictions to have 3 options:

* Don't lift restriction
* Lift restriction if no more overdues
* Lift restriction if remaining overdues didn't trigger a restriction

(some native speaker might be able to help with a more elegant phrasing)

If we go with 2 separate preferences, they should be linked to each other in
the .pref (there are a lot of examples for this in the files). Also a bit
different name might be nice... but I have to admit, I don't have a good idea
right now. I think I'd really prefer not to have them separate.

4) Missing unit tests for the changes in Circulation.pm and Patron.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:13:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:13:37 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-RXjGJTzm14@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135530|0                           |1
        is obsolete|                            |
 Attachment #135531|0                           |1
        is obsolete|                            |
 Attachment #135532|0                           |1
        is obsolete|                            |

--- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138134&action=edit
Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search
   the catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
   correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It
   should correcrly limit to that branch BUT it should also default back
   to 'All libraries' for the next search.
9. Try selecting 'All libraries' from the top of the dropdown and make
   sure it is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make
    sure it looks nice with both of those dropdowns and functions when
    you use limiters from both dropdowns.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:22:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:22:07 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-klXNflAZc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Need to re-do the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:13:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:13:41 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-0LngZVRpEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138135&action=edit
Bug 30077: (follow-up) retain branch selection

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search
   the catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
   correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It
   should correcrly limit to that branch and retain that branch in the
   dropdown, just like the OPAC.
9. Try selecting 'All libraries' from the top of the dropdown and make
   sure it is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make
    sure it looks nice with both of those dropdowns and functions when
    you use limiters from both dropdowns.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 15:51:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 13:51:50 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-zWgXdBmXx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138130&action=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:54:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:54:33 +0000
Subject: [Koha-bugs] [Bug 30786] Capitalization in (Opac)AdvancedSearchTypes
In-Reply-To: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30786-70-yOREaamVEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30786

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
           Keywords|Academy, Manual             |
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/575

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:26:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:26:11 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-p5VMPTY1XI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133274|0                           |1
        is obsolete|                            |
 Attachment #133275|0                           |1
        is obsolete|                            |
 Attachment #133276|0                           |1
        is obsolete|                            |

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138137&action=edit
Bug 28307: Make BakerTaylorEnabled preference separate for staff and OPAC

This patch updates the system preferences controlling Baker & Taylor
content so that there are separate preferences for the OPAC and the
staff interface. The patch also adds Baker & Taylor cover images to the
staff client.

To test, apply the patch and run the database update.

- Go to Admnistration -> System preferences -> Enhanced content
- You should see a BakerTaylorEnabled and a OPACBakerTaylorEnabled
  preference. The OPACBakerTaylorEnabled should have the same setting
  you previously had for BakerTaylorEnabled. The BakerTaylorEnabled
  preference should be turned off.
  - Note that the description of the preferences have been updated to
    include links to the Baker & Taylor username and password
    preferences.
- Enable both and make sure you have a valid Baker & Taylor username
  and password entered.
- Perform a search in both the OPAC and staff interface. A Baker &
  Taylor cover image should appear on the bibliographic detail page in
  the OPAC, and on the search results and bibliographic detail page in
  the staff interface.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:27:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:27:05 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-Z1zwgeqUW6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135194|0                           |1
        is obsolete|                            |

--- Comment #19 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 138140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138140&action=edit
Bug 29012: Add default values for blank circulation rules that weren't saved to
the database

There are 5 fields that are not set if no value is provided when saving/editing
a rule in Administration->Circulation and fines rules
- issuelength
- hardduedate
- unseenrenewalsallowed
- rentaldiscount
- decreaseloanholds

This is problematic because it gives the impression these rules are set as
blank, but in reality they don't exist and the rule will fal back to the higher
level

To test:
1 - Set a rule for
    Patron category: Teacher
    Itemtype: All
    Hard due date: (Today)
    Lona period: 10
2 - Set a rule for
    Patron category: Teacher
    Itemtype: Books
    Hard due date: (leave blank)
    Loan period: 10
3 - Expected behaviour is Book item will checkout to teacher for 10 days, all
other types will be due yesterday at 25:59:00
4 - Checkout an non-book item type to teacher
5 - Hard due date applies
6 - Checkout a 'book' item type to teacher
7 - Hard due date applies - FAIL

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:26:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:26:20 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-7YbQeDyK5e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

--- Comment #23 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138139&action=edit
Bug 28307: (follow-up) Correct OPAC references to OPACBakerTaylorEnabled

This patch adds the new OPACBakerTaylorEnabled preferences to OPAC
templates and scripts which were missed in the first patch. The patch
also adds OPACBakerTaylorEnabled to UsageStats.pm and sysprefs.sql.

Check these pages in the OPAC:

 - Catalog -> Search results
   - And search results -> RSS
 - Catalog -> Bibliographic details page -> Shelf browser
 - Catalog -> Lists -> List contents
 - Catalog -> Recent comments
   - And recent comments -> RSS
 - Your summary -> Checkouts and Overdues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:53:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:53:41 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-xaKqMTkDRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Send message to a durable RabbitMQ queue(In reply to David Cook from comment
#10)
> 4. Send message to a durable RabbitMQ queue

What is the 'durable RabbitMQ queue' in this context?

In order for using RabbitMQ makes sense, I feel like we need:

- A Task queue manager (we have the table, just missing a process that polls it
and sends 'the message'
- A way to dispatch the message to notify workers about it (Yay, RabbitMQ)
- A worker that reads the message and acts accordingly

Questions:

- how does a worker report back if it failed? Probably directly to the DB? This
is a case for a task queue manager, which would read and make the decision it
is time to retry.
- if we had 2 workers waiting for 'index' jobs through the mq, how do we pick
which process takes the job? how does the system know it is being processed by
who? what if the process dies and we need to assign a new worker? That's where
I was going with the PID thing. BEcause I was thinking about things locally
(wrong) but the case still stands with this question. Who is running what?

I personally don't see a case in which RabbitMQ is being useful right now. At
least when we still haven't implemented a way to avoid tasks that failed to get
notified through the mq to be retried, scheduled, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:29:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:29:19 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-WgAAEQAg9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #16 from Isabel Pineda <isabel.pineda at ds.edu.sv> ---
(In reply to Tomás Cohen Arazi from comment #15)
> (In reply to Isabel Pineda from comment #0)
> > In a register with several items I select all (or some) items and click
> > "edit selected items". I make the modification (write a public note, change
> > the signature, change item type etc.) and click "Save", the modifications
> > don't get saved.
> > It used to work in previous versions.
> 
> In the meantime, you should enable plugins in koha-conf.xml until this is
> pushed.
> 
> Also, I noticed that the task will stay as 'new' because it is not being
> picked by the message queue. So I suggest you:
> 
> - systemctl stop rabbitmq
> - koha-worker --restart --queue default <instance>
> 
> so it is picked again.

Thank you.
The plugins were enabled, actually I am using the coverflow plugin on the OPAC.
But for some reason the koha-worker wasn't working. So the line
- koha-worker --restart --queue default <instance>
solved the problem for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:45:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:45:55 +0000
Subject: [Koha-bugs] [Bug 31213] When performing a basic search with no
 results, repeat the search with term quoted
In-Reply-To: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31213-70-eFdwhLBerU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31213

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |second, automatic, search
                   |                            |with the search terms
                   |                            |between quotation marks
                   |                            |when a search returns no
                   |                            |results.
                   |                            |
                   |                            |For example,
                   |                            |searches with special
                   |                            |characters don't work with
                   |                            |Elasticsearch.
                   |                            |A search for
                   |                            |Ivy + Bean will return no
                   |                            |results. But a search for
                   |                            |"Ivy + Bean" will return
                   |                            |results.
                   |                            |
                   |                            |With this
                   |                            |enhancement, if a user
                   |                            |searches for Ivy + Bean
                   |                            |without quotation marks and
                   |                            |gets no results, Koha will
                   |                            |automatically search for
                   |                            |"Ivy + Bean" and return
                   |                            |those results.
                   |                            |
                   |                            |This
                   |                            |targets both Zebra and
                   |                            |Elasticsearch, but is more
                   |                            |relevant for Elasticsearch.
           Keywords|release-notes-needed        |
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:04:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:04:40 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-NTjB3A7A4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Sigh. I was able to reproduce the original behaviour in a fresh sandbox, but
even after applying the patch in the sandbox, the behaviour stayed the same...
I will try on my dev install

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:21:19 +0000
Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once
In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8179-70-Q38uXL9DBh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Amanda Campbell <acampbell at hmcpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acampbell at hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:16:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:16:58 +0000
Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their
 patron messages
In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12029-70-IWnyulxCRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:15:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:15:35 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-jIJtGAluLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Isabel Pineda from comment #0)
> In a register with several items I select all (or some) items and click
> "edit selected items". I make the modification (write a public note, change
> the signature, change item type etc.) and click "Save", the modifications
> don't get saved.
> It used to work in previous versions.

In the meantime, you should enable plugins in koha-conf.xml until this is
pushed.

Also, I noticed that the task will stay as 'new' because it is not being picked
by the message queue. So I suggest you:

- systemctl stop rabbitmq
- koha-worker --restart --queue default <instance>

so it is picked again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:26:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:26:15 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-KBKMFafiE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138138&action=edit
Bug 28307: (follow-up) Add proper check for BakerTaylorEnabled

This patch adds a missing check for the BakerTaylorEnabled system
preference in staff interface search results.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:51:36 +0000
Subject: [Koha-bugs] [Bug 18392] Allow exporting circulation conditions as
 CSV or spreadsheet
In-Reply-To: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18392-70-lX6qpOgKxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/577
           Keywords|Manual                      |
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:04:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:04:48 +0000
Subject: [Koha-bugs] [Bug 30879] Add option to sort components by
 biblionumber
In-Reply-To: <bug-30879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30879-70-MeJE0cIZS1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
No reply from Nick yet, I think we still need the release notes note, but
dropping the other requirement from my side. I believe this is worth having.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 19:40:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 17:40:58 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-6ZQRkXmgxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138129|0                           |1
        is obsolete|                            |
 Attachment #138130|0                           |1
        is obsolete|                            |
 Attachment #138131|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138142&action=edit
Bug 31223: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:37:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:37:01 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-UmUHK7dc69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31223

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Let's kill the rabbit ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 17:27:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 15:27:01 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-iUIUQtred0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 16:38:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 14:38:37 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-bowwto17zH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 19:40:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 17:40:54 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-Q0lld3r7KV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 21:43:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 19:43:20 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-vdUWsOjIkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com
      Documentation|                            |Caroline Cyr La Rose
            contact|                            |
      Documentation|                            |https://gitlab.com/koha-com
         submission|                            |munity/koha-manual/-/merge_
                   |                            |requests/578

--- Comment #168 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I added a section in the manual. This type of more technical thing is a bit
outside my expertise and I'm not 100% sure I have the right vocabulary. So
please let me know of any corrections I need to make. 

https://gitlab.com/koha-community/koha-manual/-/merge_requests/578

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:27:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:27:47 +0000
Subject: [Koha-bugs] [Bug 28445] Use the task queue for the batch delete and
 update items tool
In-Reply-To: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28445-70-b1Gh46R56G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234
[Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not
stored
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:27:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:27:47 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-NzrJlEbc84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Depends on|                            |28445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445
[Bug 28445] Use the task queue for the batch delete and update items tool
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:56:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:56:27 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-Cq5dC462pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #4 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Important /!\ :

There are other places with JS calling 'field_value', we should check if there
are other bugs :

 > git grep 'name..field_value'
 > git grep 'name..field_value' -- koha-tmpl/
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:              
                                                         <select
name="field_value" class="input_marceditor">
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt:            
           <input type="hidden" name="field_value" value="[% authid | html %]"
/>
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt:            
           <input type="hidden" name="field_value" value="[% authtypecode |
html %]" />
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:    if(!
$(subfield_div).children("input[type='text'][name='field_value']").val() ){
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:       
$(subfield_div).children("input[type='text'][name='field_value']").val($("#serialseq"
+ serialId).val());
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:               
  <select name="field_value" class="select2 input_marceditor">
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:        <input
type="hidden" name="field_value" value="[% item.itemnumber | html %]" />
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:               
  <select name="field_value">
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:        <input
type="hidden" name="field_value" value="[% newserialloo.itemnumber | html %]"
/>
koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt:       
<select name="field_value" class="input_marceditor">
koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt:  
                                 with value <input type="text"
name="field_value" id="field_value" />
koha-tmpl/intranet-tmpl/prog/js/additem.js:           
.prevAll("[name='field_value']")[0];
koha-tmpl/intranet-tmpl/prog/js/additem.js:           
$(original).find("input[name='field_value']").each(function(){
koha-tmpl/intranet-tmpl/prog/js/additem.js:                   
$(clone).find("div[id^='"+id+"'] input[name='field_value']").val(value);
koha-tmpl/intranet-tmpl/prog/js/additem.js:           
$(original).find("select[name='field_value']").each(function(){
koha-tmpl/intranet-tmpl/prog/js/additem.js:                   
$(clone).find("div[id^='"+id+"'] select[name='field_value']").val(value);
koha-tmpl/intranet-tmpl/prog/js/additem.js:            var input =
$(this).prevAll("input[name='field_value']")[0];

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 01:43:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 23:43:29 +0000
Subject: [Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.
In-Reply-To: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31241-70-M2TcZEBo7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 02:00:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 00:00:03 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-aqVP5RVtsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |unspecified
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 19:41:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 17:41:34 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-0UDPnOn3b5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138144&action=edit
Bug 31223: Do not try to report results if task not started

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 19:15:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 17:15:41 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-IjT0SG6QHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137758|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138141&action=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

Signed-off-by: KIT <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 02:03:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 00:03:14 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-ghxV1ukIsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
I am able to recreate this in current master. 

1. Make a label batch. 
2. Go to 'label-edit-batch.pl' and select at least one item in the table. (
#batcht )
3. Use the 'Export' button to export at one item. 
4. Choose template/layout etc.
5. Download as PDF

This is the error I see:
Can't locate object method "get_attr" via package "-2" (perhaps you forgot to
load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:34:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:34:23 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-xMFE3z98Ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> ---
This comes from a change by Bug 28445 in items edition form :
  <select name="field_value"
change to :
  <select name="[% kohafield | html %]" 

This breaks the special JS code :
https://git.koha-community.org/Koha-community/Koha/src/commit/fc919fc796df42c29e73cd527d3c425377fcc27a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js#L112

I propose we use "select.input_marceditor".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:45:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:45:53 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-vtwxS1en3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #2 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Item restricted edition dates back to Bug 7673

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 03:09:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 01:09:12 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-OMoYzIVLhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #11 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Chris Nighswonger from comment #9)
> (In reply to Lucas Gass from comment #8)
> 
> > This is the error I see:
> > Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> > to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127
> 
> See the comment here:
> 
> https://github.com/Koha-Community/Koha/blob/master/C4/Creators/Batch.pm#L156
> 
> What is being passed in as the batch id?

The URL to create the PDF should similar to this:

https://jl-staff.campus.foundations.edu/cgi-bin/koha/labels/label-create-pdf.pl?batch_id=858&template_id=1&layout_id=5&start_label=1&amp;label_id=25498

If batch_id is non-existent or an invalid value, C4::Creators::Batch->retrieve
will return -2.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:51:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:51:05 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-IVFYZwqdNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 03:20:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 01:20:58 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-5Dywz6k7vG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #12 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Lucas Gass from comment #8)
> I am able to recreate this in current master. 
> 
> 1. Make a label batch. 
> 2. Go to 'label-edit-batch.pl' and select at least one item in the table. (
> #batcht )

batch_id originates from element_id passed in to label-edit-batch.pl. ie.

https://jl-staff.campus.foundations.edu/cgi-bin/koha/labels/label-edit-batch.pl?op=edit&element_id=858

> 3. Use the 'Export' button to export at one item. 
> 4. Choose template/layout etc.

The fact that you are able to get this far would seem to indicate that a valid
batch_id is being passed in to this point.

> 5. Download as PDF
> 
> This is the error I see:
> Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127

It appears that by the time you get to this point, the batch_id has become
corrupted somehow.

Please post both the label-edit-batch.pl URL and the label-create-pdf-pl URL
for your failure case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 02:38:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 00:38:39 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-zm4EwvfDWd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #9 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Lucas Gass from comment #8)

> This is the error I see:
> Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127

See the comment here:

https://github.com/Koha-Community/Koha/blob/master/C4/Creators/Batch.pm#L156

What is being passed in as the batch id?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 23:05:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 21:05:01 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-CGP6IXp1M4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> ---
BTW : 
The system preference 'SubfieldsToAllowForRestrictedEditing' edition is quite
strange, why enter itemsfield 952/995 when it is obvious.
Could be simply subfields separated with a comma : a,b,c

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 21:51:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 19:51:59 +0000
Subject: [Koha-bugs] [Bug 31240] New: Search bar disappears on
 tow_factor_auth page
Message-ID: <bug-31240-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240

            Bug ID: 31240
           Summary: Search bar disappears on tow_factor_auth page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The search bar that is always at the top of the page in the staff interface
disappears when we access the 'Manage two-factor authentication' page in our
account.

To test:
1- Enable the TwoFactorAuthentication syspref
2- Go to your account (click username at the top right and choose 'My account')
3- Go to More > Manage two-factor authentication
   --> Search bar is not visible anymore

Similar to bug 31153? In that case the include file was not the right one...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 19:41:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 17:41:30 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-MLdOucUtVD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138143&action=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:28:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:28:14 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-j1WY7LgzB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
           Severity|enhancement                 |major
             Status|NEW                         |ASSIGNED
            Version|21.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 21:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 19:52:46 +0000
Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
 client - omnibus
In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20476-70-QjmMGwPYB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31240


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240
[Bug 31240] Search bar disappears on tow_factor_auth page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 08:02:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 06:02:43 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-TIGcDVypWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
On Bug 25870, Tomas suggested Apache for rate-limiting, while Kyle suggested
Plack middleware to keep the rate-limiting in the Koha app.

I'll throw some API Gateway options into the mix:
https://konghq.com/
https://www.krakend.io/

(I use Kong for managing complex security requirements around APIs on other
projects. I've been wanting to try out KrakenD for a while as it apparently is
faster and lighter weight overall.)

--

Overall, I'd say that Apache - in its role as reverse proxy to Starman - is the
place to do rate limiting. It's almost certainly going to be more efficient
than Starman, and there's no point letting in traffic to Starman if we're just
going to block it.

That said, a quick Google doesn't really show any good Apache options. I think
mod_security might be one way which is available but it has a questionable past
and future I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:39 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-7Bk9f2SZIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138165&action=edit
Bug 30588: Add selenium tests

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 21:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 19:52:46 +0000
Subject: [Koha-bugs] [Bug 31240] Search bar disappears on tow_factor_auth
 page
In-Reply-To: <bug-31240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31240-70-5CTRqHEa5I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20476


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
[Bug 20476] Two factor authentication for the staff client - omnibus
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jul 26 22:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 20:51:09 +0000
Subject: [Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data
 from drop-down menu not stored
In-Reply-To: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31234-70-lwD2S5UBTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #3 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Created attachment 138145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138145&action=edit
Bug 31234: SubfieldsToAllowForRestrictedEditing - data from drop-down menu not
stored

Problem with items restricted edition, restriced fields with a drop-down
menu are not stored, since 21.11.

This comes from a change by Bug 28445 in items edition form :
  <select name="field_value"
change to :
  <select name="[% kohafield | html %]"

This breaks the special JS code :
https://git.koha-community.org/Koha-community/Koha/src/commit/fc919fc796df42c29e73cd527d3c425377fcc27a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js#L112

I propose we use "select.input_marceditor".

Test plan :
1. A librarian with 'edit_items_restricted' permission set
2. Item subfield not authorized for editing
(SubfieldsToAllowForRestrictedEditing). In Marc framework, this subfield is
linked to an authorized value (= drop-down menu). For exemple homebranch.
3. When adding/editing item, this subfield has a default value from drop-down
menu and is not editable (OK).
4. Save item
=> Without patch : the subfield is empty, it should have the value from
drop-down menu.
=> With patch : the subfield is saved with the value from drop-down menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:31 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-PQ2UfHf8To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138163&action=edit
Bug 30588: Adjust existing selenium tests

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:08:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:08:24 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-Uzk5x9TWYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 08:10:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 06:10:41 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-hoySnaKEZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Maybe it does make sense to put the rate limiting in Starman just to keep
things as simple as possible. 

We could just put it in the builder for "/api/v1/app.pl", so it wouldn't affect
the performance of the /opac and /intranet apps. 

The middlewares Kyle linked do look ancient though.

https://www.krakend.io/docs/endpoints/rate-limit/ poses some interesting points
about rate limiting methods, especially whether to rate limit by endpoint or
rate limit by endpoint * client IP address. 

One way or another, it would be good to have rate limiting I reckon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 11:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 09:48:02 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-nYh2MUWXfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described, signing off.  Thanks for the patch!

The display of the not for loan status for the staff on check in will be
particularly useful when we get a publisher recall.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:24:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:24:02 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-sSytizBgv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138147|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138148&action=edit
Bug 31244: Fix 500 if logout and not logged in

Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm
line 985
        C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0,
'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at
/kohadevbox/koha/C4/Auth.pm line 186
        C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at
/kohadevbox/koha/mainpage.pl line 40

Test plan:
Open a private window
Hit /cgi-bin/koha/mainpage.pl?logout.x=1

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:17:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:17:40 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-68KkGMSWgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

--- Comment #9 from Emmanuel Bétemps <e.betemps at gmail.com> ---
Nice cataloging page !

Note that if  EnableAdvancedCatalogingEditor is set on "Don't enable", the
title of the "New" section is displayed although this section is empty.

Perhaps the "New record" and "New from Z39.50..." buttons could be in this
section rather than above, in their own menu.

Is this what you mean with :
> I'm not sure how to try and handle the other toolbar buttons.. the Framework
> selection lends itself to a button.. I was considering a fieldset with
> buttons but that also feels a bit weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:35 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-KfeFSvUs8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138164&action=edit
Bug 30588: Add tests for the REST API routes

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:39:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:39:43 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-TBLYIlQ3zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
(In reply to Paul Derscheid from comment #7)
> That's right but at LMSCloud we need this as a public route and tcohen also
> wants this to be public, so the simple approach doesn't fly. 
> 
> Thanks for the pointers, I'll have a look in a bit.

I'd like this as a public route as well, as I'd like to point a third-party at
it, so that they can search Koha in an event-driven way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:44 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-P6wx799JK0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138154&action=edit
Bug 28787: Don't send the notice if we are not waiting for 2FA

If we are fully logged-in or haven't pass the password phase, don't send
the notice!

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:22:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:22:05 +0000
Subject: [Koha-bugs] [Bug 31242] New: Add rate-limiting to the REST API
Message-ID: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

            Bug ID: 31242
           Summary: Add rate-limiting to the REST API
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
                CC: tomascohen at gmail.com

As has been noted on bug 25870, there are times where we want to rate limit the
REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:57:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:57:43 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-0sA0s7ywlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133717|0                           |1
        is obsolete|                            |
 Attachment #133718|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138172&action=edit
Bug 22276: Add client storage of user-selected DataTables configuration

This patch enables use of DataTables' built-in session storage of table
configurations. DataTables by default uses the browser's localstorage
feature to store the state of each DataTable, including which columns
have been hidden by the user.

Our table settings system has always overridden this saved state. This
patch adds a check for a saved configuration state and if present loads
the saved state instead of the default state.

The system is enabled in this patch on the libraries administration
page. To test, apply the patch and open go to Administration ->
Libraries.

- Use the "Columns" button to change the visibility setting of multiple
  columns.
- Navigate away from the page and then back to test that the visibility
  settings have been kept.
- Go to Administration -> Table settings -> Administration and change
  the visibility settings for the "libraries" table in a way that it
  differs from the visibility settings you set manually.
- Return to the libraries administration page and confirm that your
  manual settings are still being loaded instead of the defaults from
  table settings.

Signed-off-by: Solène Desvaux <solene.desvaux at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:08:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:08:24 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-aVtaf50UGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:18 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-1fIiBygREV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138160&action=edit
Bug 30588: Add 'enforced' option to TwoFactorAuthentication

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:57:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:57:38 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-2RLNl13AXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:07:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:07:57 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-qWCldLkL9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138147&action=edit
Bug 31244: Fix 500 if logout and not logged in

Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm
line 985
        C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0,
'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at
/kohadevbox/koha/C4/Auth.pm line 186
        C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at
/kohadevbox/koha/mainpage.pl line 40

Test plan:
Open a private window
Hit /cgi-bin/koha/mainpage.pl?logout.x=1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:31 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-5hlslkEdlx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138151&action=edit
Bug 28787: Typo authenticaction

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 16:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 14:32:23 +0000
Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff
 client - omnibus
In-Reply-To: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20476-70-bBGX5Pj1dx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31247


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247
[Bug 31247] Staff interface 2FA blocks logging into the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:04:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:04:04 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-piUVrGFaXS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #64 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138158&action=edit
Bug 28787: (follow-up) Typo and additional test

Adding a test for a 403 status when lowering authorization.
The Auth mock for check_cookie_auth is not needed here.
Reading back the session after flush either.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:54 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-rOWxpbkVSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #62 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138156&action=edit
Bug 28787: Mock send_or_die

To make the tests pass even if no SMTP server is defined.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:18:12 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-RV8D1VIxTg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138176|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 138179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138179&action=edit
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
  
http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 01:41:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jul 2022 23:41:41 +0000
Subject: [Koha-bugs] [Bug 31241] New: PDF export of ANY label is NOT
 functioning.
Message-ID: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

            Bug ID: 31241
           Summary: PDF export of ANY label is NOT functioning.
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: stdominic.novices at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I've been experimenting and no label type of any kind works when exported as a
pdf. Either it is completely jumbled or massive amounts of the data are
missing. I've tried batch and selected exporting, redoing the layouts and
templates. This is for Patron, barcode, and spine label. I have a similar bug
concerning the spine label, but this seems to be a more widespread problem than
I first thought. If I try to export a singly selected or any other number that
is not the full batch I get an Error 500 message, and if it's the full bath the
label is garbled. Thanks for your time looking into this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:22 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-VPkJLE5JgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137391|0                           |1
        is obsolete|                            |
 Attachment #137392|0                           |1
        is obsolete|                            |
 Attachment #137393|0                           |1
        is obsolete|                            |
 Attachment #137394|0                           |1
        is obsolete|                            |
 Attachment #137395|0                           |1
        is obsolete|                            |
 Attachment #137396|0                           |1
        is obsolete|                            |
 Attachment #137397|0                           |1
        is obsolete|                            |
 Attachment #137398|0                           |1
        is obsolete|                            |
 Attachment #137399|0                           |1
        is obsolete|                            |
 Attachment #137400|0                           |1
        is obsolete|                            |
 Attachment #138146|0                           |1
        is obsolete|                            |

--- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138149&action=edit
Bug 28787: Send a notice with the TOTP token

Bug 28786 let librarians enable a Two-factor authentication but force them to
use
an application to generate the TOTP token.

This new enhancement add the ability to send an email containing the token to
the
patron once it's authenticaed

The new notice template has the code '2FA_OTP_TOKEN'

Test plan:
- Setup the two-factor authentication (you need the config entry and the
syspref ON)
- Enable it for your logged in patron
- Logout
- Login and notice the new link "Send the code by email"
- Click on it and confirm that you received an email with the code
- Use the code to be fully logged in

QA question: Is 400 the correct error code to tell the email has not
been sent?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:47:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:47:40 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-1IbIaHVWuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

--- Comment #15 from Emmanuel Bétemps <e.betemps at gmail.com> ---
Created attachment 138174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138174&action=edit
before & after applying the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:07:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:07:00 +0000
Subject: [Koha-bugs] [Bug 31244] New: Logout when not logged in raise a 500
Message-ID: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

            Bug ID: 31244
           Summary: Logout when not logged in raise a 500
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If /cgi-bin/koha/mainpage.pl?logout.x=1 is hit when the user is not logged in,
a 500 is displayed.

    Can't use an undefined value as a HASH reference at
/kohadevbox/koha/C4/Auth.pm line 985
            C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0,
'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at
/kohadevbox/koha/C4/Auth.pm line 186
            C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at
/kohadevbox/koha/mainpage.pl line 40

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:49 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-QOaGivMQgf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138155&action=edit
Bug 28787: Don't request a token if no email address defined

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 02:59:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 00:59:22 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-zNpVYr7aZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #10 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to Chris Nighswonger from comment #9)
> (In reply to Lucas Gass from comment #8)
> 
> > This is the error I see:
> > Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> > to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127
> 
> See the comment here:
> 
> https://github.com/Koha-Community/Koha/blob/master/C4/Creators/Batch.pm#L156
> 
> What is being passed in as the batch id?

At a minimum this error should be trapped here:

https://github.com/Koha-Community/Koha/blob/master/labels/label-create-pdf.pl#L59

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:33:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:33:22 +0000
Subject: [Koha-bugs] [Bug 31245] New: Job detail view for batch mod explode
 if job not started
Message-ID: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

            Bug ID: 31245
           Summary: Job detail view for batch mod explode if job not
                    started
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If the job has failed to start (status=new), the job detail view is exploding
with 

Can't use an undefined value as an ARRAY reference at
/kohadevbox/koha/Koha/BackgroundJob/BatchUpdateItem.pm line 175                 
       
Koha::BackgroundJob::BatchUpdateItem::additional_report('Koha::BackgroundJob::BatchUpdateItem=HASH(0x5592c6c6ced8)')
called at /kohadevbox/koha/Koha/BackgroundJob.pm line 339                      
               
Koha::BackgroundJob::additional_report('Koha::BackgroundJob=HASH(0x5592c6df3268)')
called at /kohadevbox/koha/admin/background_jobs.pl line 55

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:07:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:07:59 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-Gh1hdIEkqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:24:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:24:10 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-NkTFMNuioG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #4 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Sally from comment #2)
> I like this idea - but the patch doesn't currently apply.
> 
> CONFLICT (content): Merge conflict in C4/Circulation.pm
> error: Failed to merge in the changes.

Patch rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:50:05 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-r3FxWgYm0J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134428|0                           |1
        is obsolete|                            |

--- Comment #17 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138186&action=edit
Bug 28269: Add tests for Acquisitions Orders search by ISSN

also with SearchWithISSNVariations on and off

Signed-off-by: KIT Library Germany <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:49:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:49:58 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-10PJ8j1uAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134427|0                           |1
        is obsolete|                            |

--- Comment #16 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138185&action=edit
Bug 28269: Add feature to search Acquisitions Orders by ISSN

- add search form field for ISSN number
- add search logic including ISSN variations search
  if SearchWithISSNVariations preference is set

Signed-off-by: KIT Library Germany <michaela.sieber at kit.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:53:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:53:29 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-X4gLe0yNdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 16:50:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 14:50:28 +0000
Subject: [Koha-bugs] [Bug 31248] New: Make checkout history table responsive
 for mobile
Message-ID: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

            Bug ID: 31248
           Summary: Make checkout history table responsive for mobile
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 138180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138180&action=edit
Screenshot of checkout history in mobile view on Firefox

The checkout history table on mobile is large and there doesn't seem to be a
way to scroll right. When on mobile, the current checkouts are not in a table,
maybe the same could be done with the checkout history?

To test:
1) Make sure you have checkouts in your account
2) Log into the OPAC
--> In 'Your summary' current checkouts are in a table
3) Go to 'You checkout history'
--> Current and previous checkouts are in a table
4) Switch to mobile view (in Firefox, Ctrl + Shift + M)
--> Checkout history is still in a table and the last column is not entirely
visible (depending on the content of the columns, I suppose)
5) Go to 'Your summary'
--> Current checkouts are presented in list form instead of a table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:29:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:29:43 +0000
Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29658-70-lsTQJiGb3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #7 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
I’m not sure I understand what ‘cancelling a cancelled order’ actually means
here. We are having a fiscal period close clean-up, and I too receive an
internal server error when I try to delete a basket when all the orders on it
have been cancelled and one or more (or all) of the biblios in the orders have
been deleted. Is this the same thing as is being reported here, or should I
raise a separate bug report? The error I see in our production Koha is simply
‘Internal server error’ but in our test Koha I see: ‘Cannot insert order:
Mandatory parameter biblionumber is missing at
/home/koha/kohaclone/acqui/basket.pl line 141’.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:49:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:49:05 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-UCY68OXdKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138181&action=edit
Bug 31247: Fix OPAC authentication when 2FA is enabled

Silly mistake from bug 28786, the $type should be compared to "opac"
instead of "OPAC", erk!

Test plan:
Turn 2FA on
Set it up for an user
Login at the OPAC
=> Without this patch you keep being redirected to the auth form screen
=> With this patch applied you are able to successfully login

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:38:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:38:20 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-RVfplwAiQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #19 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #14)
> (In reply to Paul Derscheid from comment #7)
> > That's right but at LMSCloud we need this as a public route and tcohen also
> > wants this to be public, so the simple approach doesn't fly. 
> 
> We can have both, really. And when we say 'public' we mean 'unprivileged
> access' which could or not imply authentication.

I know I struggle to wrap my head around how the API is organised as well... 

If I recall correctly, I think the majority of API endpoints are for
admin/staff users and the "public" APIs are for public/OPAC users. 

Public users don't have authorizations (hence "unprivileged access"). 

Some public APIs require authentication and some don't.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:30:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:30:39 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-7he7TxjUXP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I felt like doing it your way, Jonathan, would place unnecessary constraints on
what we want to display. Specially for plugins. We could want to display
something on other background jobs in the 'new' status.

But I think either solution is fine. If required we can step back later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:37:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:37:57 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-NYZPyCDoVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|ASSIGNED                    |In Discussion

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
What about this alternative patch, Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:18:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:18:51 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-l9y6utzqnT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138141|0                           |1
        is obsolete|                            |

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 138167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138167&action=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

Signed-off-by: KIT <michaela.sieber at kit.edu>

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:58:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:58:16 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-56ojDEDNjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #169 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Caroline Cyr La Rose from comment #168)
> I added a section in the manual. This type of more technical thing is a bit
> outside my expertise and I'm not 100% sure I have the right vocabulary. So
> please let me know of any corrections I need to make. 
> 
> https://gitlab.com/koha-community/koha-manual/-/merge_requests/578

Read good, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 11:42:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 09:42:02 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-KJPNKBTFBv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138168|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138171&action=edit
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:43:09 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-8S0uYL6bxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |28786
           Severity|major                       |critical
             Status|NEW                         |In Discussion
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786
[Bug 28786] Two-factor authentication for staff client - TOTP
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:03:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:03:58 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-gBFImYqDco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:02:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:02:56 +0000
Subject: [Koha-bugs] [Bug 31243] Misleading tests in api/v1/two_factor_auth.t
In-Reply-To: <bug-31243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31243-70-osZWwHl1F6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31243

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Well, bug 28787 is not pushed yet. Adding the patch there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:52:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:52:32 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-Dr7LCRVeEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138113|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138187&action=edit
Bug 31228: Intranet coce.js is not hiding the coce-coverimg div for
single-pixel images

This is because the intranet detail.tt has coce-coverimg as an ID.
Intranet results.tt has coce-coverimg as a class. Intranet coce.js
targets coce-coverimg as a class.

Intranet detail.tt should be changed to have coce-coverimg as a class.
This is inline with the change made to the OPAC in bug 31217

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- IntranetCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the intranet. Observe a 'Coce image
from Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the intranet. Observe no image
is displayed.

8. Do an intranet search to get the biblio returned in search results
page. Confirm no cover image box is displayed

9. View the intranet search result and detail pages for a different
biblio that you know Coce should be displaying the cover image of and
confirm that it is correctly displayed with the source of that image
listed: For example 'Coce image from Amazon.com' is displayed

Sponsored-by: Catalyst IT, New Zealand

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:25 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-jOB4Cb5PLm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
I like this idea - but the patch doesn't currently apply.

CONFLICT (content): Merge conflict in C4/Circulation.pm
error: Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:52:56 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-ttZpNijAqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138182&action=edit
Bug 31247: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:26 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-xfKUv4lYp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138150&action=edit
Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 11:36:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 09:36:52 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-aUj0XyISve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

--- Comment #11 from Anneli Österman <anneli.osterman at koha-suomi.fi> ---
(In reply to Emmanuel Bétemps from comment #9)
> Nice cataloging page !
> 
> Note that if  EnableAdvancedCatalogingEditor is set on "Don't enable", the
> title of the "New" section is displayed although this section is empty.
> 
> Perhaps the "New record" and "New from Z39.50..." buttons could be in this
> section rather than above, in their own menu.
> 
Yes, this could be better place for them! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 11:12:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 09:12:49 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-U22Yt1GBqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00, 22.05.x           |22.11.00,22.05.01
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:23:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:23:54 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-vSNEtYiQsA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132554|0                           |1
        is obsolete|                            |

--- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 138168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138168&action=edit
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 06:02:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 04:02:41 +0000
Subject: [Koha-bugs] [Bug 28498] Add CLI counterpart for plugin actions
In-Reply-To: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28498-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28498-70-pYjoPsBtKC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28498

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to Nick Clemens from comment #0)
> We need a CLI counterpart for plugin actions:
>  - Install (from a URL, from a .kpz)
>  - Upgrade (from a URL, from a .kpz)
>  - Uninstall
>  - Configure based on some file format

I'm still keen on this one.

I would love to turn on plugins for all my Koha instances while disabling the
Plugin web upload. This feature would be a bit more convenient than using
install_plugins.pl.

Actually I was most of the way with Bug 25671, although that code didn't take
into account that you could have multiple "plugin_dir" entries. That's a gotcha
with this CLI feature. I suppose you could always assume a default path and
override or fail as necessary. (Using a "default" attribute on the main
plugin_dir path would be handy...)

I don't know. I keep wanting to use plugins more, but it's just not been quite
convenient enough. 

I'm still thinking a bit about my "Plugin Manager" Koha plugin which would
provide a list of curated plugins that would let library staff install plugins
with a click of a button. 

And then deploy that "Plugin Manager" Koha plugin using a centralized "plugin
dir" and just run 'koha-foreach perl
/usr/share/koha/bin/devel/install_plugins.pl' for install/upgrade of those
centralized plugins that I want to enforce on all instances...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:33:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:33:37 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-XFBuJJC30N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138144|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Comment on attachment 138144
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138144
Bug 31223: Do not try to report results if task not started

Moved to bug 31245.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:04:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:04:05 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-1hPDTY0Mzb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138182|0                           |1
        is obsolete|                            |

--- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 138184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138184&action=edit
Bug 31247: Add tests

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:14:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:14:55 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-2DpnfUxbg6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #3)
> (In reply to David Cook from comment #2)
> > Maybe it does make sense to put the rate limiting in Starman just to keep
> > things as simple as possible. 
> 
> Yes, that was the idea. If it's baked in, it's less onerous for libraries. 

While technically it might not be ideal, I think it would be practical for a
FOSS project like Koha for sure. Having something out of the box makes sense. 

I often think about how X, Y, Z technologies would be great for Koha, but how
they're not practical because they are too complex for non-technical Koha
adopters...

I answered a query about horizontally scaling Koha, and I suppose if you were
to horizontally scale Koha, you'd want your rate limiting to be done by your
load balancer. But we can cross that bridge when we come to it too.

> > We could just put it in the builder for "/api/v1/app.pl", so it wouldn't
> > affect the performance of the /opac and /intranet apps. 
> 
> Is there a benefit to rate limiting everything? It hasn't been an issue
> lately but back in the day I know we had an issue with "thrashing" where
> some partner's browsers would DOS a server with requests for reasons we
> never understood.

If we rate limited everything (without IP checking), I think they'd still DOS
Koha just by hitting the global rate limit. 

We still occasionally have issues where out of control bots (usually benign
crawlers) will DOS a Koha instance (not the whole server fortunately) by
keeping Starman busy, but we have additional software that finds and blocks
those. 

In theory, we could install fail2ban alongside Koha and point it at Plack
logs... (I suppose that is a different kind of rate limiting)

> > The middlewares Kyle linked do look ancient though.
> 
> True, but if it works, it doesn't need updated!

Haha. That's what I was thinking as well. 

> > https://www.krakend.io/docs/endpoints/rate-limit/ poses some interesting
> > points about rate limiting methods, especially whether to rate limit by
> > endpoint or rate limit by endpoint * client IP address. 
> 
> That *is* interesting! I seems more "fair" to do it by endpoint+ip, but
> really, a system can only handle some much traffic no matter how fair it is.
> Now I'm going to say it would be nice to have both of those, and for them to
> each be configurable ;)

I don't know if you followed the link, but that's what they recommend! "Both
and" rather than "Either or". You determine how many simultaneous clients you
expect to handle, give each client up to X requests per Y and then have a Z
global limit that should be the sum of X for all clients. Probably would need
to tweak it a bit from there but not a bad guideline.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:42:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:42:15 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-0KUXqmr1Ed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #21 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #20)
> (In reply to Paul Derscheid from comment #7)
> > That's right but at LMSCloud we need this as a public route and tcohen also
> > wants this to be public, so the simple approach doesn't fly. 
> > 
> > Thanks for the pointers, I'll have a look in a bit.
> 
> I'd like this as a public route as well, as I'd like to point a third-party
> at it, so that they can search Koha in an event-driven way.

Although for my use case I could go with a non-public route and just give them
a "catalogue" authorized user like Kyle suggested. 

But that wouldn't work if we wanted opac-search.pl to use it.

But... we could start with non-public and then add public later if we're
concerned. They could probably share the controller even.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:14 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-nRzMXZuVUC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:45:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:45:52 +0000
Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records
In-Reply-To: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27667-70-P1X5fmUnpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667

--- Comment #13 from Fridolin Somers <fridolin.somers at biblibre.com> ---
That is why I proposed Bug 27497 :)

We at Biblibre have patch to add a toolip on Koha logo showing version,
marcflavour and searchengine.
Those info are super useful when managing hundreds of sites.
One can have them even without login into staff interface, via logo in auth
page.

There is also this plugin, we use it for demo and dev envs :
https://github.com/biblibre/koha-plugin-intranet-version-in-header

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:07:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:07:54 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-lP665TBPZ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:43:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:43:09 +0000
Subject: [Koha-bugs] [Bug 28786] Two-factor authentication for staff client
 - TOTP
In-Reply-To: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28786-70-q7MkAs7WPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31247


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247
[Bug 31247] Staff interface 2FA blocks logging into the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:20:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:20:43 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-LxrNzPihQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:43:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:43:56 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-QVVLwsLxlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:21:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:21:56 +0000
Subject: [Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable
In-Reply-To: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18148-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18148-70-z0tFiBEBT9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148

--- Comment #11 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
We're still interested in this development.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:55:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:55:32 +0000
Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not
 require edit_borrowers permission
In-Reply-To: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30230-70-MdR60LgjXB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 04:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 02:05:35 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-vSOkiN2m6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #16 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #13)
> Send message to a durable RabbitMQ queue(In reply to David Cook from comment
> #10)
> > 4. Send message to a durable RabbitMQ queue
> 
> What is the 'durable RabbitMQ queue' in this context?

"Durable (the queue will survive a broker restart)"
(https://www.rabbitmq.com/queues.html)

> In order for using RabbitMQ makes sense, I feel like we need:
> 
> - A Task queue manager (we have the table, just missing a process that polls
> it and sends 'the message'
> - A way to dispatch the message to notify workers about it (Yay, RabbitMQ)
> - A worker that reads the message and acts accordingly
> 
> Questions:
> 
> - how does a worker report back if it failed? Probably directly to the DB?
> This is a case for a task queue manager, which would read and make the
> decision it is time to retry.
> - if we had 2 workers waiting for 'index' jobs through the mq, how do we
> pick which process takes the job? how does the system know it is being
> processed by who? what if the process dies and we need to assign a new
> worker? That's where I was going with the PID thing. BEcause I was thinking
> about things locally (wrong) but the case still stands with this question.
> Who is running what?

- If a worker fails, it needs to record that in the "result store" (which in
this case is the database). 
- Why do you need to know which worker processes which message? It shouldn't
matter. If the worker dies, the MQ broker would detect the broken connection,
and give that message to the next worker that connects asking for a message. 

> I personally don't see a case in which RabbitMQ is being useful right now.
> At least when we still haven't implemented a way to avoid tasks that failed
> to get notified through the mq to be retried, scheduled, etc.

It's not the job of the message broker to handle scheduling. There needs to be
a separate scheduler. That can be a cronjob, it can be a daemon. It's whatever
we want it to be. (The advantage of the minion daemon is that it already exists
and we wouldn't need to write it.)

Are you having problems with retries? RabbitMQ should automatically retry. Or
are you referring to this scenario:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654#c0

RabbitMQ is useful right now because it provides a standard interface for
passing message between separate processes. It's the only reason we're able to
process asynchronous jobs in a reasonable way. (Forking CGI processes for the
old school background jobs has a major barrier to using Plack 100%.)

(In reply to Martin Renvoize from comment #0)
> Our worker currently starts up and immediately tries to listen for jobs
> being passed via STOMP.  However, if rabbitMQ wasn't running when the tasks
> were enqueue, then the worker will never know about them.

Why wouldn't RabbitMQ be running? I'd argue that we shouldn't be saving jobs in
the database if the message broker (which is a component of the overall Koha
system) is unavailable. 

To me, it sounds like a Koha design problem rather than a RabbitMQ problem. If
the database weren't available, we wouldn't try saving a change to the file
system on our own. We'd throw an exception saying that we can't save the
record. 

I'm in the process of implementing a background job system using RabbitMQ on
another Perl app and that's the process I'll be following. First I'll check my
RabbitMQ connection, if good, then I'll insert the job into the DB, commit into
the DB, which is necessary to avoid a race condition, send the message to
RabbitMQ. If the message sends, then there's nothing more to do but tell the
user that their job is in progress. If it doesn't send, I update the job in the
database as failed (or you could delete the job), and tell the user that there
was an error. 

I'm not saying that's necessarily the only right way to do it. Or that we have
to keep RabbitMQ, but that's my interpretation of the situation. 

Totally not opposed to yanking out RabbitMQ and replacing with Minion. I think
that we'd gain a lot of functionality for free by doing that, but I suppose I
want to make sure we're not unfairly condemning RabbitMQ either when I think
we're the reason RabbitMQ might not be working the way we want it to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 16:30:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 14:30:52 +0000
Subject: [Koha-bugs] [Bug 31247] New: Staff interface 2FA blocks logging
 into the OPAC
Message-ID: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

            Bug ID: 31247
           Summary: Staff interface 2FA blocks logging into the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

I noticed when I turned on the 2FA for my staff account, I'm no longer able to
log into the OPAC with that same account. I usually use the same account for
both, so I find this a major drawback in using 2FA.

To test:
1) With 2FA turned off, log into the staff interface with your staff account
--> login is normal
2) With 2FA turned off, log into the OPAC with the same account
--> login is normal
3) Turn on 2FA
3.1) In System preferences, enable TwoFactorAuthentication
3.2) Go to 'My account' (click your username in the top right and choose 'My
account)
3.3) Click More > Manage two-factor authentication
3.4) Click Enable two-factor authentication
3.5) With an authenticator app (I used FreeOTP) scan the QR code
3.6) Enter the PIN provided by the app in the PIN code field
3.7) Click Register with two-factor app
4) Log out of the staff interface
5) Log into the staff interface
--> Username, password and two-factor code is needed
6) Log out of the OPAC
7) Log into the OPAC (I used the login box on the right)
--> It cycles back to the login page, you can never log in
8) In the staff interface, disable 2FA
8.1) In 'My account', click More > Manage two-factor authentication
8.2) Click Disable two-factor authentication
9) Log into the OPAC
--> login is normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:24:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:24:41 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-xN8sLjV9lC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
Works as described - signing off.  Thanks for the patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 08:56:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 06:56:47 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-2XdDznhYdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31243
[Bug 31243] Misleading tests in api/v1/two_factor_auth.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:08:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:08:02 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-gBtgo5y9JA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:24:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:24:57 +0000
Subject: [Koha-bugs] [Bug 31240] Search bar disappears on two_factor_auth
 page
In-Reply-To: <bug-31240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31240-70-49PD84IPca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au
            Summary|Search bar disappears on    |Search bar disappears on
                   |tow_factor_auth page        |two_factor_auth page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:22 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-SCXOjJYTB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138161&action=edit
Bug 30588: Adjust existing occurrences of TwoFactorAuthentication

We need to replace 0 with 'disabled', and 1 with 'enabled'

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:27 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-5boLJ5nQiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138162&action=edit
Bug 30588: Add the option to require 2FA setup on first staff login

Bug 28786 added the ability to turn on a two-factor authentication,
using a One Time Password (OTP).
Once enabled on the system, librarian had the choice to enable or
disable it for themselves.
For security reason an administrator could decide to force the
librarians to use this second authentication step.

This patch adds a third option to the existing syspref, 'Enforced', for
that purpose.

QA notes: the code we had in the members/two_factor_auth.pl controller
has been moved to REST API controller methods (with their tests and
swagger specs), for reusability reason. Code from template has been
moved to an include file for the same reason.

Test plan:
A. Regression tests
As we modified the code we need first to confirm the existing features
are still working as expected.
1. Turn off TwoFactorAuthentication (disabled) and confirm that you are not
able to
enable and access the second authentication step
2. Turn it on (enabled) and confirm that you are able to enable it in your
account
3. Logout and confirm then that you are able to login into Koha

B. The new option
1. Set the pref to "enforced"
2. You are not logged out, logged in users stay logged in
3. Pick a user that does not have 2FA setup, login
4. Notice the new screen (UI is a bit ugly, suggestions welcomed)
5. Try to access Koha without enabling 2FA, you shouldn't be able to
access any pages
6. Setup 2FA and confirm that you are redirected to the login screen
7. Login, send the correct pin code
=> You are fully logged in!

Note that at 6 we could redirect to the mainpage, without the need to
login again, but I think it's preferable to reduce the change to
C4::Auth. If it's considered mandatory by QA I could have a look on
another bug report.

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 16:32:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 14:32:23 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-vUoEmTMtnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20476


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476
[Bug 20476] Two factor authentication for the staff client - omnibus
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:48:21 +0000
Subject: [Koha-bugs] [Bug 27045] Exports using CSV profiles with tab as
 separator don't work correctly
In-Reply-To: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27045-70-EQRsG8rakm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27045

--- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #21)
> (In reply to Fridolin Somers from comment #20)
> > Please have a look at Bug 28327 where I try to centralize the tabulation
> > special case.
> 
> This doesn't depend on the pref, but is a per CSV profile setting. So my
> impresison was they complement each other.

In Bug 28327 I add a method csv_delimiter() that take a value to convert and
fallsback to syspref if no value.
So it may be used for CSV profiles.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:04:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:04:25 +0000
Subject: [Koha-bugs] [Bug 22861] Add ability to turn on/off the display of a
 public list
In-Reply-To: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22861-70-BCR84l5kxm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22861

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk
            Version|18.11                       |master

--- Comment #1 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
+1 

This would be incredibly useful.  I don't want to stop the staff from making
lists, but I don't necessarily want them all published to the OPAC at the same
time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:52:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:52:28 +0000
Subject: [Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel
 cover images in both the staff client detail and results pages
In-Reply-To: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31228-70-sYyb6nEu3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:37:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:37:46 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-mcNK3FbNVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Tomás Cohen Arazi from comment #5)
> I felt like doing it your way, Jonathan, would place unnecessary constraints
> on what we want to display. Specially for plugins. We could want to display
> something on other background jobs in the 'new' status.


^ This is a good point I hadn't thought of

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:40 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-gG8q9nFaX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138153&action=edit
Bug 28787: Rename the REST API route to /auth/otp/token_delivery

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:26:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:26:23 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-sBxsO62XZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #12)
> Let's kill the rabbit ;-)

I won't oppose it. Minion might make more sense after all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:05:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:05:11 +0000
Subject: [Koha-bugs] [Bug 30418] Add permission and setting for public lists
 to allow staff with permission to edit contents
In-Reply-To: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30418-70-F0OcJhWDIC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
+1 

Really interested in this development.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:09:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:09:34 +0000
Subject: [Koha-bugs] [Bug 25796] Allow REST API to use external OAuth2
 authorization server
In-Reply-To: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25796-70-UIlmMDRqui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25796

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Unless the Keycloak uses Koha as its backend user storage, I suppose that could
circumvent a number of Koha business rules though. That would need to be
checked.

Hmm this is interesting:
https://developers.google.com/identity/sign-in/web/backend-auth

In that example, you get the id_token from your SSO IdP, and then you send it
to your other backend server (eg. Koha), and then Koha can verify the token (at
this point it can create a new user if one is missing, or it can validate an
existing user).

Then Koha could return whatever.

Hmm needs more thought.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:53:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:53:49 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-2nOoYJ04jb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate
                 CC|                            |lucas at bywatersolutions.com,
                   |                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 02:56:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 00:56:02 +0000
Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface
 home page
In-Reply-To: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27497-70-LR5xVXGmQ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497

--- Comment #55 from David Cook <dcook at prosentient.com.au> ---
Actually, it looks like we have it in a meta tag (at least in 21.11) so maybe
it's not that necessary after all...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:57:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:57:28 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-Snnzi2q0S1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:35 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-eua3eZPNch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138152&action=edit
Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t

Changing flags to 20 to include the required Staff access for
intranet login.
This changes the http status. The API raises an exception now.

Test plan:
Run t/db_dependent/api/v1/two_factor_auth.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 02:54:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 00:54:48 +0000
Subject: [Koha-bugs] [Bug 27497] Display Koha version in staff interface
 home page
In-Reply-To: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27497-70-wHAxyLfIWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497

--- Comment #54 from David Cook <dcook at prosentient.com.au> ---
Frido, I like what you said about adding the version as a tooltip over the Koha
logo at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667#c13

That would be very usable but it wouldn't be ugly or disruptive to staff users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:33:42 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-YVyk8D767C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31245

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:22:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:22:22 +0000
Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios
In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25870-70-jQAbkAZWRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #16)
> I'd really like to see us get away from Apache based solutions, but at the
> same time it's a very practical way to handle it that works for 99.9% of
> Koha users. If there exists middleware that would work for Koha, that would
> be a better solution IMO, especially because we can bake the throttling
> settings directly into Koha.

I've just raised bug 31242

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:04:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:04:10 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-U1PKHWArVt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #65 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138159&action=edit
Bug 28787: Fix misleading tests in two_factor_auth.t

We were having a "Patron is not authenticated yet" comment, but it was not
correct,
we set 'number' and 'id' in session, and waiting-for-2FA was not set => the
patron is fully authenticated.
The test returned 401 because we fully authenticated user cannot request
an otp token when not waiting for the second auth step.

This situation is already covered (last test of the subtest).

Test plan:
  prove t/db_dependent/api/v1/two_factor_auth.t
must return green

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:57:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:57:47 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-2QEo0129LJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138173&action=edit
Bug 22276: (QA follow-up) Add missing USE

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:43:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:43:59 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-9pNhaNdTMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:33:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:33:43 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-fFsqKXOE8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31223

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:04:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:04:22 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-rGNBF8S2Tn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138146&action=edit
Bug 28787: Fix misleading tests in two_factor_auth.t

We were having a "Patron is not authenticated yet" comment, but it was not
correct,
we set 'number' and 'id' in session, and waiting-for-2FA was not set => the
patron is fully authenticated.
The test returned 401 because we fully authenticated user cannot request
an otp token when not waiting for the second auth step.

This situation is already covered (last test of the subtest).

Test plan:
  prove t/db_dependent/api/v1/two_factor_auth.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:05:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:05:43 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-tQYL0mIjOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138166&action=edit
Bug 30588: Add tests for C4::checkauth

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 07:33:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 05:33:51 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-yurvUtHd1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #8 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Caroline Cyr La Rose from comment #7)
> I cannot reproduce the problematic behaviour either in a sandbox nor on my
> local dev install with the steps from comment 4. In all cases, I am brought
> to the batch item modification page without problem and am able to launch
> the batch modification.
> 
> I do get a 500 error when I click on the "View detail of the enqueued job"
> link to see the background job.
> 
> I tried with and without the patch and get the same behaviour...

Hmm, it could also be that error is actually raised when subfield has
authorised value linked to it? However at least for me saving authorised value
to subfield is currently broken on master (see bug 31238) so it might be little
tricky to reproduce.

I'm unable to reproduce 500 error by clicking "View detail of the enqueued
job". Do you know what logs say when this happens?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:04:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:04:01 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-P2c5DIlXHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138181|0                           |1
        is obsolete|                            |

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 138183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138183&action=edit
Bug 31247: Fix OPAC authentication when 2FA is enabled

Silly mistake from bug 28786, the $type should be compared to "opac"
instead of "OPAC", erk!

Test plan:
Turn 2FA on
Set it up for an user
Login at the OPAC
=> Without this patch you keep being redirected to the auth form screen
=> With this patch applied you are able to successfully login

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:58:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:58:03 +0000
Subject: [Koha-bugs] [Bug 30407] Add ability to syspref
 UpdateNotForLoanStatusOnCheckin to show only the notforloan values
 description
In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30407-70-Tk4TQgqLoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 08:34:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 06:34:09 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-pAMtVFsd8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I don't understand your use case. "new": the job hasn't started yet. report:
what happened, the job has started (still running or failed or succeeded).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 08:52:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 06:52:17 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-oOtWKCOC5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
You let the session in an unexpected state and change the code? Yes of course
it is failing.
If you want your steps to work you must truncate the sessions table after you
applied the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:37:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:37:27 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-yVUS2sqVth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138170&action=edit
[ALTERNATIVE-PATCH] Bug 31245: Do not call report for job detail view if job
not started

We should not generate the report if the job hasn't started yet

Test plan:
Stop the koha-worker processes, modify a new item using the batch mod
tool, then see the detail page of the job

Without this patch an error is generated:
Can't use an undefined value as an ARRAY reference at
/kohadevbox/koha/Koha/BackgroundJob/BatchUpdateItem.pm line 175

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:51:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:51:50 +0000
Subject: [Koha-bugs] [Bug 31186] Search result numbering in OPAC got
 suppressed
In-Reply-To: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31186-70-gTbaEP7ibP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31186

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 09:08:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 07:08:24 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-7HwDgZ1hbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |31244, 28787


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
[Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244
[Bug 31244] Logout when not logged in raise a 500
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 09:58:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 07:58:33 +0000
Subject: [Koha-bugs] [Bug 28307] Enable BakerTaylorEnabled content in the
 staff interface with separate system preference
In-Reply-To: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28307-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28307-70-HnI1MAVzFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |paul.derscheid at lmscloud.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:49:17 +0000
Subject: [Koha-bugs] [Bug 30733] Simplify translatable strings
In-Reply-To: <bug-30733-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30733-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30733-70-wVMOH20UEW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31246


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246
[Bug 31246] <span> displayed in 'Additional fields' section
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 22:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 20:51:31 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-KMFoZp1Py8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Liz Rea from comment #1)
> On bug 22957 there was a comment: 
> 
> "I'd love to see a 'Private computer' checkbox on login screens next and
> have a list of cookies to keep should that checkbox be ticked at login vs a
> completely public computer where I still think we should remove all by
> default." 
> 
> I think this is not the worst ever solution for this. It happens to be how
> the bank, for example, often does it.

This does seem like the best solution for this, IMHO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:48:02 +0000
Subject: [Koha-bugs] [Bug 31069] Did you mean? in the OPAC - links have
 <span> tags
In-Reply-To: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31069-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31069-70-pnPuvXHSOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31069

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:36:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:36:53 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-IRDxanaOq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to David Cook from comment #2)
> Maybe it does make sense to put the rate limiting in Starman just to keep
> things as simple as possible. 

Yes, that was the idea. If it's baked in, it's less onerous for libraries. 

> We could just put it in the builder for "/api/v1/app.pl", so it wouldn't
> affect the performance of the /opac and /intranet apps. 

Is there a benefit to rate limiting everything? It hasn't been an issue lately
but back in the day I know we had an issue with "thrashing" where some
partner's browsers would DOS a server with requests for reasons we never
understood.

> 
> The middlewares Kyle linked do look ancient though.

True, but if it works, it doesn't need updated!

> https://www.krakend.io/docs/endpoints/rate-limit/ poses some interesting
> points about rate limiting methods, especially whether to rate limit by
> endpoint or rate limit by endpoint * client IP address. 

That *is* interesting! I seems more "fair" to do it by endpoint+ip, but really,
a system can only handle some much traffic no matter how fair it is. Now I'm
going to say it would be nice to have both of those, and for them to each be
configurable ;)

> One way or another, it would be good to have rate limiting I reckon.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:13:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:13:44 +0000
Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50
 filter
In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30966-70-S6ZtsPaozh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johanna.raisa at koha-suomi.fi

--- Comment #4 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
We found out that the protection applies only after you have saved the imported
record, which is kind of confusing when looking the record on the editor. 

Fixing the z3950 syntax works but I think that there should be done something
so the protected fields appear to the editor. If you have required fields then
those have to be filled before save and the new values don't even apply because
of the protection.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:57:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:57:32 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-5pbFiiLaak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138176&action=edit
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
  
http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:35:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:35:01 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-I7OMYuroVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138169&action=edit
Bug 31245: Do not try to report results if task not started

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 08:56:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 06:56:47 +0000
Subject: [Koha-bugs] [Bug 31243] New: Misleading tests in
 api/v1/two_factor_auth.t
Message-ID: <bug-31243-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31243

            Bug ID: 31243
           Summary: Misleading tests in api/v1/two_factor_auth.t
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart+koha at gmail.com
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 28787

Somewhere in the script: # Patron is not authenticated yet

But it's not correct, we set 'number' and 'id' in session, the patron has
filled in their credentials, they are correct, but the second authentication
step is not passed yet.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
[Bug 28787] Send a notice with the TOTP token
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:24:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:24:14 +0000
Subject: [Koha-bugs] [Bug 24260] REST Self Registration
In-Reply-To: <bug-24260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24260-70-Nz92VP6C8I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24260

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
This sounds like doing :
<pre>
curl -X POST https://demo.biblibre.com//api/v1/patrons \
    -H 'Authorization: Basic [your-token]' \
    -d '{
    "address":"anywhere",
    "city":"nowhere",
    "firstname":"asu",
    "surname":"zuki",
    "library_id":"SITE",
    "category_id":"ADULT"
}'
</pre>

to me the only bug we have here is, the post patron api doesn't use the
self-registration prefs like PatronSelfRegistrationDefaultCategory.
It means the category is mandatory, where it is not when using the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:32:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:32:47 +0000
Subject: [Koha-bugs] [Bug 31252] New: Advanced search in staff interface
 should call barcodedecode if the search index is a barcode
Message-ID: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

            Bug ID: 31252
           Summary: Advanced search in staff interface should call
                    barcodedecode if the search index is a barcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We should run any inputted barcode through barcodedecode before passing it to
any subroutines. This was missed during the initial development of bug 26351.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:15 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-kw7B88smo2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 12:35:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 10:35:16 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-gKY3JU2FwW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> Comment on attachment 138144 [details] [review]
> Bug 31223: Do not try to report results if task not started
> 
> Moved to bug 31245.

Ok!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:32:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:32:08 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-8Bt8LjlXFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmi.takkinen at koha-suomi.fi

--- Comment #1 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
We are facing this same problem. I guess one possible solution could be move to
"Modify notice" page instead "Add notice" if notice already exists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:04:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:04:29 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-fxLgG2RWbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 11:16:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 09:16:39 +0000
Subject: [Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to
 21.11.05.004"
In-Reply-To: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30899-70-0jhUhnVQn8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #26 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Fixed in 22.05.03 by :
e40fa1af65 Remove atomicupdate file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 06:45:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 04:45:11 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-tPC87rdOEA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:55:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:55:19 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-MA9BfyEX3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |victor at tuxayo.net

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:18:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:18:50 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-jHOHP6fIuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138111|0                           |1
        is obsolete|                            |

--- Comment #9 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Created attachment 138192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138192&action=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because opac-detail.tt has coce-coverimg as an ID, but OPAC
coce.js targets coce-coverimg as a class.

opac-detail.tt should be changed to have coce-coverimg as a class.

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the OPAC. Observe no image is
displayed.

8. View another OPAC biblio detail page that does have a successfully
loading coce image and confirm the source of that image is listed: For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:14:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:14:02 +0000
Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not
 log to action_logs
In-Reply-To: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31249-70-u2nVnuxSuz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:27:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:27:45 +0000
Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines
In-Reply-To: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31254-70-jbIP53j1ID@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:07:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:07:56 +0000
Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected
 DataTables configuration
In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22276-70-iCcdcQlPGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:51:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:51:51 +0000
Subject: [Koha-bugs] [Bug 25796] Allow REST API to use external OAuth2
 authorization server
In-Reply-To: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25796-70-RpUUvqG5mC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25796

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
But then if you read this:
https://auth0.com/blog/id-token-access-token-what-is-the-difference/

In theory, the access token should be for the "Resource server" (ie the Koha
API). I suppose that the access token can then be used to do a UserInfo lookup
in order to get the user info (I did that in my early 2014 OpenID Connect
work).

I suppose the Koha API would check the "iss" and "aud" claims. The "iss" would
let it know what IdP to talk to (and whether or not it trusts it). I think the
"aud" would need to be the whole Koha API and then further authorization would
be handled by Koha at a more granular level...

Looking at Koha::OAuth, it would be fairly trivial to add support. We'd just
need a table really to store providers. If the "iss" provider isn't found in
the table, then we default to a Koha supplied access token.

We need a table to store providers anyway for improving Koha's SSO options so
this dovetail with that.

If we wanted to handle this with plugins, we could do that instead so long as
we put a plugin hook in "Koha::OAuth::_verify_access_token_cb". 

It does look like we'd need to alter Koha::Rest::V1::Auth a little bit as it
tries to lookup the patron using the "client_id" in the access token. 

Anyway, lots of possibilities there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:28:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:28:35 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-DkI5VNTssI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #3)
> What about this alternative patch, Tomas?

Why not both?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:06:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:06:10 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-pWfRbizd8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:58:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:58:29 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-9C2iWbm7fB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #10 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to Emmanuel Bétemps from comment #9)
> I got this message after applying the patch (which is not displayed in the
> KohaGitLog)
> (I test using a sandbox)
> 
> -------------------------------------------
> Bug 28726 - Add sort1 and sort2 to patron card creator patron search
> 
> 137854 - Bug 28726: Add sort1 and sort2 to patron card creator -  patron
> search.
> 
> Apply? [(y)es, (n)o, (i)nteractive] Traceback (most recent call last):
>   File "/usr/bin/git-bz", line 2716, in <module>
>     applied = do_apply(bug_ref)
>   File "/usr/bin/git-bz", line 1827, in do_apply
>     users = bug.server.get_xmlrpc_proxy().User.get({ 'names':
> [patch.attacher] })['users']
>   File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
>     return self.__send(self.__name, args)
>   File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
>     verbose=self.__verbose
>   File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
>     return self.single_request(host, handler, request_body, verbose)
>   File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
>     response.msg,
> xmlrpclib.ProtocolError: <ProtocolError for
> bugs.koha-community.org/xmlrpc.cgi: 404 Not Found>

To be that looks like a problem with the koha-community.org git server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 10:03:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 08:03:59 +0000
Subject: [Koha-bugs] [Bug 28787] Send a notice with the TOTP token
In-Reply-To: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28787-70-iLFtj6Pd71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #63 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138157&action=edit
Bug 28787: Comment selenium test that will fail if no SMTP server is defined

This is a deadlock I think. Any ideas how we could continue to test that
in any conditions?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:06:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:06:44 +0000
Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29658-70-BRHNfgCfWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 08:58:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 06:58:31 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-LAnOJ9MrQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Biblioteca de Asociación Médica from comment #45)
> Greetings to all Koha´s community.
> 
> We wish to inform you the great contributions you have made to the ABC
> Hospital Medical Association Library. Since Koha´s implementation we have
> received a lot of congratulations and approval from our users and superiors.
> 
> We are motivated to continue the development of our services. One of them
> consist into add the ORCID and the links to doctors' social media profiles.
> 
> We would like to ask the status of this Koha´s new modality.
> 
> Thanks in advance for your reply.

Hola,
This development is waiting for a review from one member of the QA team.
You can show your interest in this development and explain how useful it will
be for you, by letting a comment (as you did!) and/or vote for it (see above of
the page, there is a "vote" link).
Then you can cross fingers and hope it will be part of the next major version,
22.11.

Thank you for showing us your interest here!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:09:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:09:03 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-dK98c9YOnU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138178&action=edit
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty
value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:24:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:24:41 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-noIzJtyMA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31241
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:08:46 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-O5SExKyr5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138201&action=edit
Bug 12758: Add new module call in Koha::XSLT::Base

Reviving a report back from 2014. The workaround is now moved to a
separate helper module from another patch.

Test plan:
Test OPACXSLTDetailsDisplay with an https reference.
You may try:
https://library.rijksmuseum.nl/opac-tmpl/bootstrap/en/xslt/zztest.xsl

If you flush and restart, the opac detail pages will contain the
text 'This is my MARC record.'.

NOTE: If you point to an xslt file over https that contains includes or
imports, you will still get the error: Failed to load external entity.
To address that, we need to extend the _resolve_includes sub.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:54:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:54:44 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-2fqSpzLxcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138204&action=edit
Bug 31250: Add catalogue_editor_ cookie to koha-conf deny list

Test plan:
Add this change to your koha-conf.xml.
Flush, restart.
Test if the cookie is kept now in the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:48:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:48:21 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-Bm5hqzl0Cc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119868|0                           |1
        is obsolete|                            |

--- Comment #16 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 138175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138175&action=edit
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

For staff add descriptions.

1)  Go to lists in Opac interface
2)  Choose a list and send it at one of your emails
3)  In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed
7)  Do the same with staff interface

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 08:55:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 06:55:27 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-qh3AjxJ2pc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to David Cook from comment #14)
> > (In reply to Tomás Cohen Arazi from comment #12)
> > > Let's kill the rabbit ;-)
> > 
> > I won't oppose it. Minion might make more sense after all.
> 
> Or, as time is limited for everybody, we take advantage of having something
> that is working (and has been waiting for years), a task queue (whatever is
> its implementation), and fix the different scripts that are still running
> under cgi?
> 
> We have been waiting for it to adjust the scripts. Now we have it we would
> like to rethink/rewrite everything? What's the point for the end-users
> exactly? Bug 27421 is one step forward, and does not get attention.
> 
> Could we show durability in our tech choices?
> 
> I've already answered several about why rabbitmq.
> 
> I am out of the recurring discussion anyway, just wanted to say that.

That makes sense to me too. I'm happy to support whomever has the time to do
the work one way or another. 

(I've already given feedback on Bug 27421 but I'm happy to look at it again if
it's ready to be QAed.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 09:24:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 07:24:50 +0000
Subject: [Koha-bugs] [Bug 31251] New: "Clear" patron attribute link does not
 work
Message-ID: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

            Bug ID: 31251
           Summary: "Clear" patron attribute link does not work
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

On the patron edit view there is a "Clear" link to reset the value of an
attribute.
It does no longer work, nothing happens and no error in the console.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 01:48:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 23:48:16 +0000
Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not
 log to action_logs
In-Reply-To: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31249-70-YWoz5kkrjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138189&action=edit
Bug 31249: Use cronlogaction on update_patrons_category.pl

This patch does what the title says.

To test:
1. Run the script
2. Check the action logs
=> FAIL: Boo, no record of the running cronjob
3. Apply this patch
4. Repeat 1-2
=> SUCCESS: Yay!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:49:17 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-WeStY2Cckc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_05_candidate
         Depends on|                            |30733
           Assignee|oleonard at myacpl.org         |tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733
[Bug 30733] Simplify translatable strings
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:24:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:24:04 +0000
Subject: [Koha-bugs] [Bug 22861] Add ability to turn on/off the display of a
 public list
In-Reply-To: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22861-70-awB7XRkkcj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22861

--- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
(In reply to Marcel de Rooy from comment #2)
> Hmm. Isnt this just a matter of switching category back and forth?
> Note that a few recently pushed reports allow staff to transfer ownership
> too which enables them to edit the category.

You're right, there are recent changes which make this easier than before. 
It's more the scale that's the problem - if you have twenty lists, it's ok, if
you have two hundred, it'll take a fair amount of time.

It also requires the manage_patron_lists permission to transfer - and either
that means involving a superlibrarian, or giving staff the ability to
edit/delete all lists.

Ideally, I'd like to give a group of staff the task of curating which lists can
be seen on the OPAC at one time:  

- A toggle for 'display on OPAC / hide from OPAC' to show in the Public Lists
table
- The toggle is tied to a permission in a staff member's account (e.g. Lists >
Control display of Public Lists on OPAC)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:42:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:42:20 +0000
Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't
 set for the opac, try to guess it by checking branchip
In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28658-70-sh9gcZ3KGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:42:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:42:47 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-JUxj73VGaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138192|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 138198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138198&action=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because opac-detail.tt has coce-coverimg as an ID, but OPAC
coce.js targets coce-coverimg as a class.

opac-detail.tt should be changed to have coce-coverimg as a class.

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the OPAC. Observe no image is
displayed.

8. View another OPAC biblio detail page that does have a successfully
loading coce image and confirm the source of that image is listed: For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand
Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 16:57:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 14:57:50 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-D3DdPpBqSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Biblioteca de Asociación Médica <asistenteasocmed at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asistenteasocmed at gmail.com

--- Comment #45 from Biblioteca de Asociación Médica <asistenteasocmed at gmail.com> ---
Greetings to all Koha´s community.

We wish to inform you the great contributions you have made to the ABC Hospital
Medical Association Library. Since Koha´s implementation we have received a lot
of congratulations and approval from our users and superiors.

We are motivated to continue the development of our services. One of them
consist into add the ORCID and the links to doctors' social media profiles.

We would like to ask the status of this Koha´s new modality.

Thanks in advance for your reply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:40 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-2prNLArDWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #98 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138217&action=edit
Bug 22456: (follow-up) Cancel holds at checkin

This patch makes checkin process the cancellation requested holds
actually cancel them before moving forward.

To test:
1. Have a waiting hold with a patron generated cancellation request
2. At circulation, check the item in
=> SUCCESS: The workflow follows as if the cancellation requested hold
was already cancelled
=> SUCCESS: The hold is actually cancelled
=> SUCCESS: Not shown in the OPAC anymore

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:56:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:56:51 +0000
Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
In-Reply-To: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31162-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31162-70-EIi2PNCA4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:32:07 +0000
Subject: [Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
In-Reply-To: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29658-70-3PfH5icNdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Ray Delahunty from comment #7)
> I’m not sure I understand what ‘cancelling a cancelled order’ actually means
> here. We are having a fiscal period close clean-up, and I too receive an
> internal server error when I try to delete a basket when all the orders on
> it have been cancelled and one or more (or all) of the biblios in the orders
> have been deleted. Is this the same thing as is being reported here, or
> should I raise a separate bug report? The error I see in our production Koha
> is simply ‘Internal server error’ but in our test Koha I see: ‘Cannot insert
> order: Mandatory parameter biblionumber is missing at
> /home/koha/kohaclone/acqui/basket.pl line 141’.

I should still have a closer look to get this going again but at first sight I
believe that we are talking about the same bug here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:23:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:23:43 +0000
Subject: [Koha-bugs] [Bug 31256] New: Circ rules batch modification
Message-ID: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

            Bug ID: 31256
           Summary: Circ rules batch modification
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Wouldn't it be nice if you could batch modify rules?  Like, I have to set a
hard due date for schools each year.  Instead of modify each rule individually,
it would be great if I could specify all libraries, or specific ones, all rules
under that or specific ones, and what I would change.

There are times when we have to change the fines to everything, or change the
holds to many rules, etc.  This would make this job so much easier.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:47:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:47:12 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-txrYh0gAiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138203&action=edit
Bug 31250: Deny clearing cookies with numeric suffix

This change allows us to add catalogue_editor_ to the deny list
in koha-conf.xml and keep cookies like catalogue_editor_123.

Test plan:
Run t/CookieManager.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 06:47:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 04:47:13 +0000
Subject: [Koha-bugs] [Bug 25796] Allow REST API to use external OAuth2
 authorization server
In-Reply-To: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25796-70-8PfMojYxrR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25796

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Here's another thought:

If Koha and other applications used Keycloak for SSO, the id_token and refresh
token could be saved, and used beyond the initial login.

For instance, a user logs into MyApp, which redirects them to Keycloak and back
to MyApp. They click "Place a Hold" on an item in MyApp, which then sends an
API request with id_token to Koha. 

Koha takes the id_token and validates it against Keycloak. If it's valid, API
request proceeds. If it's invalid, it spits out a 401. 

MyApp could verify the id_token ahead of time or re-try after using the refresh
token to get a new id_token. That's irrelevant right now.

--

The only difficulty I have in mind at the moment is... how does Koha know which
IdP to query with the id_token? It's easy if your Koha is only set up with one
IdP. With more than one, it would be more complicated...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:15 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-j5fX34dlDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #93 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138212&action=edit
Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es)

This patch adds the Koha::Object-derived classes for cancellation
requests.

Tests are added for the overloaded ->store method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:52:16 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-SWjHjX9ODo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

--- Comment #17 from Emmanuel Bétemps <e.betemps at gmail.com> ---
(In reply to Kelly McElligott from comment #14)
> Hi, Do you have a good way of testing this without having to set up email
> generation on a test server?

Hi,

I use sandboxes  : they display "Koha Mail Logs" in the Log menu
It's the way I used to read the sent mails

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:10:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:10:35 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-7cxWb1xiP0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136713|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:19:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:19:41 +0000
Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer
In-Reply-To: <bug-12450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12450-70-CaF6Qmhvo9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450

--- Comment #13 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I think ideally this should be set through the calendar.  If you block a time
that a library is closed, when you specify that it is closed, it presents you
with the previous checklist and you fill out what you need.

Thoughts?  Ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:12:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:12:33 +0000
Subject: [Koha-bugs] [Bug 31253] New: Item search in staff interface should
 call barcodedecode if the search index is a barcode
Message-ID: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

            Bug ID: 31253
           Summary: Item search in staff interface should call
                    barcodedecode if the search index is a barcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We should run any inputted barcode through barcodedecode before passing it to
any subroutines. This was missed during the initial development of bug 26351.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:08:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:08:05 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-3jGKnQQ5HR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:18:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:18:45 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-rYlqwD5PD1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:08:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:08:57 +0000
Subject: [Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if
 renewalperiod is blank/empty value
In-Reply-To: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31120-70-kNXblfSmRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137697|0                           |1
        is obsolete|                            |
 Attachment #137769|0                           |1
        is obsolete|                            |

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138177&action=edit
Bug 31120: Add unit tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 02:02:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 00:02:00 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-dL1n6eSRTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138179|0                           |1
        is obsolete|                            |

--- Comment #3 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138190&action=edit
Bug 31246: <span> displayed in 'Additional fields' section

This patch avoids escaping HMTL data in the additional fields section.

To test:
1. Open the additional fields section
  
http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/admin/additional-fields.pl
=> FAIL: there are some nasty <span> </span> texts in there
2. Apply this patch
3. Reload
=> SUCCESS: Things display nicely again!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:54:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:54:59 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-e3pgitVHot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138148|0                           |1
        is obsolete|                            |

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138188&action=edit
Bug 31244: Fix 500 if logout and not logged in

Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm
line 985
        C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0,
'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at
/kohadevbox/koha/C4/Auth.pm line 186
        C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at
/kohadevbox/koha/mainpage.pl line 40

Test plan:
Open a private window
Hit /cgi-bin/koha/mainpage.pl?logout.x=1

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:05:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:05:20 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-FNP2jhz7Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138191&action=edit
Bug 30588: Add missing atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:45 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-WWvpo6gDi5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #99 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138218&action=edit
Bug 22456: (QA follow-up) Consider cancellation requested as cancelled in OPAC

This patch adds a helper method for filtering out cancellation
requested-holds from resultsets, and makes use of it in the OPAC to
filter out those in the current holds tab. Holds history now shows
'Waiting (cancellation requested)' on those.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:11:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:11:40 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-YHwxXaUFvC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138125|0                           |1
        is obsolete|                            |

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138231&action=edit
Bug 31238: Fix typo in marc_subfields_structure.pl

After bug 29001 one is unable to save authorised value to frameworks
subfields. This is caused by minor typo in marc_subfields_structure.pl.

To test:
1. Edit e.g. default frameworks subfield 952$8
2. Add or change fields authorised value
3. Save your changes
=> note that on subfield listing there is no mention that 952$8 is linked to
any authorised value
=> if you edit 952$8 authorised value input is empty
4. Apply this patch.
5. Repeat steps 1.-3.
=> authorised value should now be saved

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Emmanuel Bétemps <e.betemps at gmail.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:24:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:24:31 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-lbVA1S9OeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138073|0                           |1
        is obsolete|                            |

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138232&action=edit
Bug 30392: Set deleted_on when an item is (marked as) deleted

We could like to track down when an item has been moved to the
deleteditems table.

Test plan:
Created a new item, delete it
Not that the deleteditems.deleted_on value is set correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 18:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 16:51:30 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-k2aehhSG0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

MichaelaSieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:16:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:16:06 +0000
Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values
 with a code of '0'
In-Reply-To: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27684-70-CjC509im2U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:36:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:36:57 +0000
Subject: [Koha-bugs] [Bug 31050] Standardize session setup
In-Reply-To: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31050-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31050-70-Utw2h2wE1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:13:00 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-LvJ6r4Jvxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31252

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:58:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:58:13 +0000
Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not
 require edit_borrowers permission
In-Reply-To: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30230-70-L0BkvLOG7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

--- Comment #1 from George Williams (NEKLS) <george at nekls.org> ---
This is a problem for our system also.  We have libraries with volunteer staff
who do not have "edit_borrowers" permission who can no longer search for
borrowers by name.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 14:48:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 12:48:59 +0000
Subject: [Koha-bugs] [Bug 31246] New: <span> displayed in 'Additional
 fields' section
Message-ID: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

            Bug ID: 31246
           Summary: <span> displayed in 'Additional fields' section
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Introduced by bug 30733.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:44:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:44:45 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-0qSg6h9SHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:51 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-EH5VNdHSF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #130 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138230&action=edit
Bug 24860: Update existing Schema files [DO NOT PUSH]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:11:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:11:34 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-oG0PdtKpsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 22:48:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 20:48:03 +0000
Subject: [Koha-bugs] [Bug 31250] New: Don't remove advanced/basic cataloging
 editor cookie on logout
Message-ID: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

            Bug ID: 31250
           Summary: Don't remove advanced/basic cataloging editor cookie
                    on logout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 29957 removed cookies upon logout and I think this is impacting catalogers
choice of advanced vs basic cataloging editor.

Before Bug 29957 a cataloger could set the editor to basic or advanced and that
choice would be remembered after logout. Now catalogers who logout and log back
in will always be defaulted to the basic editor.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:03:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:03:04 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-vPLDRrnCvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #17 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Email sent to Sally to ask if their testing matches the new test plan. To know
if the signoff is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:41:17 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-geKHPQ9KHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 17:48:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 15:48:59 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-fWiJHAJVT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 08:46:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 06:46:43 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-5JXORkMtYE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to David Cook from comment #14)
> (In reply to Tomás Cohen Arazi from comment #12)
> > Let's kill the rabbit ;-)
> 
> I won't oppose it. Minion might make more sense after all.

Or, as time is limited for everybody, we take advantage of having something
that is working (and has been waiting for years), a task queue (whatever is its
implementation), and fix the different scripts that are still running under
cgi?

We have been waiting for it to adjust the scripts. Now we have it we would like
to rethink/rewrite everything? What's the point for the end-users exactly? Bug
27421 is one step forward, and does not get attention.

Could we show durability in our tech choices?

I've already answered several about why rabbitmq.

I am out of the recurring discussion anyway, just wanted to say that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 13:35:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 11:35:03 +0000
Subject: [Koha-bugs] [Bug 22861] Add ability to turn on/off the display of a
 public list
In-Reply-To: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22861-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22861-70-rkPO9vTfo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22861

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hmm. Isnt this just a matter of switching category back and forth?
Note that a few recently pushed reports allow staff to transfer ownership too
which enables them to edit the category.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:52:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:52:58 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-vrUzrHBMlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138184|0                           |1
        is obsolete|                            |

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138219&action=edit
Bug 31247: Add tests

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:30 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-eKkaCycbyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #96 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138215&action=edit
Bug 22456: Allow requesting cancellation from the OPAC

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 20:00:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 18:00:18 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-P7FrQemtQC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |---

--- Comment #7 from Michael Hafen <michael.hafen at washk12.org> ---
My test plan missed hitting the 'add patrons' button the second time.  The
patron table in the search window that open the first time you hit the 'add
patrons' button is fine, it honors the PatronsPerPage setting.  After adding
the patrons to the batch though, the patron table that appears on the main
windows does not honor the setting.
I just loaded the patron card creator on my workstation, which is running
22.05.3-1, and checked.  My PatronsPerPage setting is 50.  I created a batch
with more than 50 patrons.  In the patrons table in the card batch after adding
patrons to the batch, the default per page selected is 20, not 50 as it should
be.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:09:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:09:56 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-PV0nJXZGkT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Lucas Gass from comment #20)
> Marcel,
> 
> Is this ready for testing?

Lukas, the current patches can be tested. They will only resolve pure https
references without includes or imports.
That would need further work and could be done on a new report?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 09:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 07:21:24 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-N7KpolF8kW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.derscheid at lmscloud.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 15:20:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 13:20:47 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-phCA8Z7LB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:47:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:47:08 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-PZvVh4n3dN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:46:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:46:09 +0000
Subject: [Koha-bugs] [Bug 31255] Patron card number prefilled with "1" when
 adding a new patron
In-Reply-To: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31255-70-TDNlxjx0Km@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31255

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Hi Micheal,

I think your problems is related to the koha-plugin-barcode-prefixer plugin,
and not a problem in Koha.


Kyle has provided a fix for the plugin:


https://github.com/bywatersolutions/koha-plugin-barcode-prefixer/commit/9b27bbb57b3e513d368babcda9dc77b2b03ce2b2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 22:50:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 20:50:34 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-jh5PkTiBGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #1 from Liz Rea <wizzyrea at gmail.com> ---
On bug 22957 there was a comment: 

"I'd love to see a 'Private computer' checkbox on login screens next and have a
list of cookies to keep should that checkbox be ticked at login vs a completely
public computer where I still think we should remove all by default." 

I think this is not the worst ever solution for this. It happens to be how the
bank, for example, often does it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 06:45:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 04:45:01 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-sUwSjPOiNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Failed QA

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Found issue

1. don't apply patch
2. setup 2FA
3. logout staff
4. login and use 2FA
5. go to OPAC
6. logout OPAC (in my setup, on localhost but on a different port, OPAC and
staff share session)
7. try to log in the OPAC
8. it fails
9. apply patch and restart services
10. try to log in the OPAC
11. it still fails (nothing in the logs), this is not expected
12. go to staff
13. you are prompted for 2FA
14. cancel (I guess putting the code would also unblock the situation)
15. go to opac and retry logging
16. it works!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:17:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:17:00 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-ySQyhfb9VE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134004|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:24:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:24:37 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-7gAxfANr6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138233&action=edit
Bug 30392: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:41:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:41:40 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-QCOWHwVg2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138194|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138195&action=edit
Bug 28864: Have patron search use PatronsPerPage better.

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1. Set the PatronsPerPage system preference to any integer other than 20.

2. Go to the Patrons page and search for patrons.
3. Observe that the per page drop down defaults to 20.

4. Go to Tools -> Patron card creator.
5. Start a new Card Batch.
6. Click the 'Add patron(s)' button to open the patron search window.
7. Do a search.
8. Observe that the per page drop down defaults to 20.
8b.  If the PatronsPerPage was set to a value other than 10, 20, 50, or 100
      observe that that value is not in the per page drop down.
9. Close patron search window.

10. Apply patch.
11. Click the 'Add patron(s)' button again to open the patron search window.
12. Do a search.
13. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

14. Go back to the Patrons page and search for patrons.
15. Observe that the per page drop down defaults to the value of the
     PatronsPerPage system preference.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:32:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:32:53 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-CKc2LOLNv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 04:18:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 02:18:49 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-EoZVfD4LFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:23:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:23:26 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-N0GpsCS54H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
Ohh I'm curious about this one. 

I wonder if "Bug 28980 - Add temporary passwords which must be reset after
first login" would be able to make use of any hooks from this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:42:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:42:26 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-e332dOSFeB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138195|0                           |1
        is obsolete|                            |

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138197&action=edit
Bug 28864: Have patron search use PatronsPerPage better.

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1. Set the PatronsPerPage system preference to any integer other than 20.

2. Go to the Patrons page and search for patrons.
3. Observe that the per page drop down defaults to 20.

4. Go to Tools -> Patron card creator.
5. Start a new Card Batch.
6. Click the 'Add patron(s)' button to open the patron search window.
7. Do a search.
8. Observe that the per page drop down defaults to 20.
8b.  If the PatronsPerPage was set to a value other than 10, 20, 50, or 100
      observe that that value is not in the per page drop down.
9. Close patron search window.

10. Apply patch.
11. Click the 'Add patron(s)' button again to open the patron search window.
12. Do a search.
13. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

14. Go back to the Patrons page and search for patrons.
15. Observe that the per page drop down defaults to the value of the
     PatronsPerPage system preference.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:23:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:23:24 +0000
Subject: [Koha-bugs] [Bug 31248] Fix responsive table style in the OPAC
 after switch to Bootstrap tabs
In-Reply-To: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31248-70-CpBSqnzxeN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make checkout history table |Fix responsive table style
                   |responsive for mobile       |in the OPAC after switch to
                   |                            |Bootstrap tabs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:40:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:40:52 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-DXaa1zJ8Ck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #15 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to Katrin Fischer from comment #14)
> I have tested without applying the patch and this works nicely on master. I
> believe this might be because of the standardizing of patron search that has
> taken place since this patch was written.

The test plan, since the standardizing of the patron search, is wrong.  This is
still an issue on the edit-batch page.  The contents of the patch reflect this
though I neglected to update the test plan.

Here is the new test plan:

Test plan:
1.  Set the PatronsPerPage system preference to any integer other than 20.

2.  Go to Tools -> Patron card creator.
3.  Start a new Card Batch.
4.  Click the 'Add patron(s)' button to open the patron search window.
5.  Do a search.
6.  Add more than 20 patrons to the batch.
7.  Close patron search window.
8.  Click the 'Add patron(s)' button to add the selected patrons to the batch.
9.  Observe that the table of patrons is has 20 as the default per page
setting.

10. Apply patch.
11. Reload the batch.
12. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:28:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:28:46 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-qc0iG120i6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christian.stelzenmueller at bs
                   |                            |z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 18:52:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 16:52:33 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-DAfdyZ2EMD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

tmcmahon at wlpl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmcmahon at wlpl.org
           Assignee|koha-bugs at lists.koha-commun |tmcmahon at wlpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

--- Comment #1 from tmcmahon at wlpl.org ---
Created attachment 138208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138208&action=edit
Move the include for catalogue-search-box.inc in circ-search.inc to correct
keyboard shortcuts

Bug 30499: Keyboard shortcuts broken on several pages

Keyboard shortcuts for catalog search, check in and renew should be following: 
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:22:26 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
 templates
In-Reply-To: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30570-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30570-70-nObQPOvWBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248
[Bug 31248] Make checkout history table responsive for mobile
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 23:40:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 21:40:27 +0000
Subject: [Koha-bugs] [Bug 28702] Improve performance of
 C4/XSLT/buildKohaItemsNamespace
In-Reply-To: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28702-70-c2UfQ47LYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28702

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:41:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:41:55 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-xfcr8xMria@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 02:25:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 00:25:28 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-zHKp0JZ793@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138223|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 138241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138241&action=edit
Bug 31251: Use jQuery val() to clear_entry

1. Add some patron attributes that are textarea and some that have an AV
category so they are select dropdowns
2. Go to the patron form and add some values to the patron attributes
3. Use the "Clear" button to try and clear the values, doesnt work.
4. Apply patch
5. Try clearing values from patron attributes that are both select dropdowns
and textarea. The "Clear" button should work.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:17 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-VBH0IYcBLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:46:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:46:15 +0000
Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on
 serial-level
In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18745-70-XO8H9QLWnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18783
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:26:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:26:44 +0000
Subject: [Koha-bugs] [Bug 31254] New: Add additional fields for accountlines
Message-ID: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

            Bug ID: 31254
           Summary: Add additional fields for accountlines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 02:22:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 00:22:19 +0000
Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to
 ensure non-public notes do not leak
In-Reply-To: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30744-70-xBfsorxJUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
@RMAints please backport this bugs. If they don't apply we'll provide
version-specific patches. But please try ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:09:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:09:30 +0000
Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN
 too
In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28269-70-W1wYODPAaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:47:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:47:39 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Ck0YlljXEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137999|0                           |1
        is obsolete|                            |

--- Comment #23 from David Nind <david at davidnind.com> ---
Created attachment 138238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138238&action=edit
Bug 23538: Email library when new patron self-registers

Test plan:
1. Apply all patches
2. Update database
3. Restart services
4. Set email addresses in:
- KohaAdminEmailAddress syspref
- EmailAddressForPatronRegistrations syspref
- Email address in the library branch
5. Enable PatronSelfRegistration syspref
6. Test the following use cases:

- EmailPatronRegistrations syspref = 'none'.
Submit OPAC registration.
= OUTCOME: Confirm no OPAC_REG notice in message_queue table

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 01:47:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 23:47:45 +0000
Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not
 log to action_logs
In-Reply-To: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31249-70-VRbqxf1Kkz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:46:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:46:32 +0000
Subject: [Koha-bugs] [Bug 31255] Patron card number prefilled with "1" when
 adding a new patron
In-Reply-To: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31255-70-wI3GzqIttd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31255

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:13:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:13:22 +0000
Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a
 basket as PDF
In-Reply-To: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31257-70-xTxP3AJhl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:59:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:59:19 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-kDJtxXZA7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
   Patch complexity|---                         |Small patch

--- Comment #16 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
The commits
Bug 28864: Have patron card creator use PatronsPerPage 
Bug 28864: Have patron search use PatronsPerPage better.
are duplicate, which the is the right one?

Thanks Michael for the correct test plan. Which patch name? With this, we will
be able to cleanup this.

The name and test plan was changed on the 1st signoff via a sandbox. I don't
know how is that possible to change a commit message via a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:12:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:12:51 +0000
Subject: [Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not
 log to action_logs
In-Reply-To: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31249-70-07TZ9Vsg3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138189|0                           |1
        is obsolete|                            |

--- Comment #2 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 138206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138206&action=edit
Bug 31249: Use cronlogaction on update_patrons_category.pl

This patch does what the title says.

To test:
1. Run the script
2. Check the action logs
=> FAIL: Boo, no record of the running cronjob
3. Apply this patch
4. Repeat 1-2
=> SUCCESS: Yay!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Liz Rea <liz at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:13:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:13:00 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-0Xg2TSWKVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31253

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:12:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:12:45 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-lfrg2Jg4Bu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:58:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:58:29 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-Ga6H5Xq9h3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #9 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
Ahh, forgot to change the status. Here you go!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:50 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-idyon2pnY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:32:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:32:51 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-oWo9oK2snR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have tested without applying the patch and this works nicely on master. I
believe this might be because of the standardizing of patron search that has
taken place since this patch was written.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:47:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:47:34 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-VYsypcAooM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137997|0                           |1
        is obsolete|                            |

--- Comment #22 from David Nind <david at davidnind.com> ---
Created attachment 138237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138237&action=edit
Bug 23538: Database changes

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:17:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:17:04 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-y7eb203wIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I think it is because we should use .val('') instead of .attr('value' , '').

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:43:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:43:43 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-B3ajoWVk9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:46:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:46:15 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-Ru4pKH0lC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18745

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:41:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:41:16 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-TvOyj1hcSO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:42:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:42:23 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-EwHNgDL4rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138196&action=edit
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty
value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:58 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-1aPfsXYbwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:46:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:46:35 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-hvg2Im4gSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The referenced bug allows you to specify cookies not to be removed:

See koha-conf.xml

 <!-- Uncomment lines like hereunder to not clear cookies at logout:
      The cookie name is case sensitive.
     <do_not_remove_cookie>KohaOpacLanguage</do_not_remove_cookie>
 -->

The problem is that it sets a cookie for each user:
Cookies.set( 'catalogue_editor_[% logged_in_user.borrowernumber | html %]',
'advanced', { expires: 365, path: '/', sameSite: 'Lax'  } );

Adding a fix for that

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:29:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:29:33 +0000
Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold
In-Reply-To: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26440-70-4PXo84QLPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:40 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-CZvFuBGKOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #88 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138275&action=edit
Bug 30650: Add link from the member toolbar

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:22:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:22:15 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-21Mkp9KOnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 04:19:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 02:19:18 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-EDHdc7S0DV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 02:02:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 00:02:23 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-Wj3e2nX3sS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Signed Off                  |Passed QA

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:48 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-dtH3cVmoqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #100 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138287&action=edit
Bug 30650: DBIC specific

Note for QA - a false positive is raised by the QA tools:

"""
The new column curbside_pickup_opening_slots.day is using TINYINT(1) as
type but is not defined as boolean in the schema file
(Koha/Schema/Result/CurbsidePickupOpeningSlot.pm)
"""

=> It's not a boolean!

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:07:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:07:31 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-ondHxd2fWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #72 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138297&action=edit
Bug 27272: Add tests for search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:51:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:51:09 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-liV8bsJcwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136288|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:37 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-xU0iIqd6Zx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #98 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138285&action=edit
Bug 30650: Prevent browser crash if no pickup interval set

Don't get stuck in an infinite loop

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:24:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:24:41 +0000
Subject: [Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.
In-Reply-To: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31241-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31241-70-yz2qYlrSKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29994

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:06:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:06:04 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-ZKxegmVfBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Will finish this Monday.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 18:54:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 16:54:58 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-UlJJKVWk1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

tmcmahon at wlpl.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|enhancement                 |trivial
             Status|ASSIGNED                    |Needs Signoff
            Version|unspecified                 |21.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:37 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PuzQGiWVbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #77 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138264&action=edit
Bug 30650: Add the CurbsidePickup syspref

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:31 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-IldBsTkQhD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #97 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138284&action=edit
Bug 30650: Select 'schedule a pickup' if no pickups yet

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 01:41:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 23:41:59 +0000
Subject: [Koha-bugs] [Bug 25796] Allow REST API to use external OAuth2
 authorization server
In-Reply-To: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25796-70-c3eWh8i04d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25796

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
I might actually end up doing this work locally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:53:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:53:07 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-vSEjn3K1Gn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138183|0                           |1
        is obsolete|                            |

--- Comment #9 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138220&action=edit
Bug 31247: Fix OPAC authentication when 2FA is enabled

Silly mistake from bug 28786, the $type should be compared to "opac"
instead of "OPAC", erk!

Test plan:
Turn 2FA on
Set it up for an user
Login at the OPAC
=> Without this patch you keep being redirected to the auth form screen
=> With this patch applied you are able to successfully login

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:03:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:03:51 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-p3wO8kW0oQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
BTW, step 8 on my test plan, going to the staff interface and hitting cancel to
the 2FA doesn't make the OPAC logging work. So the patch is indeed needed.

Also, on step 8 if one does the 2FA and retries the OPAC it works. So it seems
to show that it's linked to this ticket and that it's incomplete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:42 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-LKVcSyNwVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138254&action=edit
Bug 29897: Don't use $6 for linkage but build the link instead

See comment 26:
$6 is a very specialized field that will never contain a URL. Linkage here
means 'linking MARC fields within the record'. For example it is used to link
an original script tag with the corresponding tag in transliteration. See:
https://www.loc.gov/marc/authority/ecadcntf.html

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:20 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-eghC6qAWDj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #94 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138213&action=edit
Bug 22456: Add cancellation request methods to Koha::Hold

This patch adds the following helper methods for dealing with hold
cancellation requests to the Koha::Hold class:

 * cancellation_requests
 * add_cancellation_request
 * cancellation_requestable_from_opac
 * cancellation_requested_by_owner

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 07:04:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 05:04:22 +0000
Subject: [Koha-bugs] [Bug 31244] Logout when not logged in raise a 500
In-Reply-To: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31244-70-mJTjOCiCid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:22:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:22:02 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-uGwCuhxvR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #74 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138261&action=edit
Bug 30650: Display the link in the admin even if the pref is off

The link in the sidebar was displayed already. The idea is to let admins
configure the module before enabling it for users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jul 27 21:47:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 19:47:09 +0000
Subject: [Koha-bugs] [Bug 31249] New: update_patrons_category.pl cron does
 not log to action_logs
Message-ID: <bug-31249-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249

            Bug ID: 31249
           Summary: update_patrons_category.pl cron does not log to
                    action_logs
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: wizzyrea at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The cron job update_patrons_category.pl does not log anything to the
action_logs via cronlogaction. It would be awesome if it did, so that curious
users can know a job ran from within Koha's web interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:11:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:11:39 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-7ntTNbJ42E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137580|0                           |1
        is obsolete|                            |
 Attachment #137581|0                           |1
        is obsolete|                            |
 Attachment #137582|0                           |1
        is obsolete|                            |
 Attachment #137583|0                           |1
        is obsolete|                            |
 Attachment #137584|0                           |1
        is obsolete|                            |
 Attachment #137585|0                           |1
        is obsolete|                            |
 Attachment #137586|0                           |1
        is obsolete|                            |
 Attachment #137587|0                           |1
        is obsolete|                            |
 Attachment #137588|0                           |1
        is obsolete|                            |
 Attachment #137591|0                           |1
        is obsolete|                            |

--- Comment #90 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138209&action=edit
Bug 22456: Add cancellation request table

This patch adds a new table, for storing holds cancellation requests,
and managing them afterwards.

The *hold_id* attribute is not made a FK on the reserves table because
of the old_reserves thing we still do (see bug 25260 for a discussion
about it).

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:25 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-z8qtqfjG12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #95 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138214&action=edit
Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests

This patch adds that method. Which is covered by new tests.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Holds.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:52:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:52:08 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-B92PAcxQ64@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:33:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:33:20 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-zSWznk1d01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could you please rebase? :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:10:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:10:30 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-bEAyirIQng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 11:53:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 09:53:23 +0000
Subject: [Koha-bugs] [Bug 31233] Fine grace period in circulation conditions
 is misnamed
In-Reply-To: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31233-70-obzBLR1Uza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31233

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Grace period is used for    |Fine grace period in
                   |determining when a          |circulation conditions is
                   |suspension will be placed   |misnamed

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After some debugging I realized that the grace period is also substracted from
the overdue days before the restriction is calculated:

    if ( $deltadays->subtract($grace)->is_positive() ) {

So we should really kill the "Fine" from "Fine grace period".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 01:40:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 23:40:24 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-IZSd4b5BFi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Kyle M Hall from comment #5)
> Yep, and nothing would prevent you from doing so! Just as any power use
> could replace apache with nginx or some other frontend. Any rate limiting
> feature could be turned off or set to an impossibly high threshold.

Yeah I was thinking the same thing. So long as we make things
optional/configurable, it's all good.  

> > We still occasionally have issues where out of control bots (usually benign
> > crawlers) will DOS a Koha instance (not the whole server fortunately) by
> > keeping Starman busy, but we have additional software that finds and blocks
> > those. 
> 
> Ooh, what are you using?

A combo of fail2ban and custom scripts. It can always use tweaking!

> > In theory, we could install fail2ban alongside Koha and point it at Plack
> > logs... (I suppose that is a different kind of rate limiting)
> 
> That's an interesting idea!

Right? I feel like it would be tough to get it right though. 

--

In any case, one of those Plack middlewares for the "api" app in plack.psgi is
probably a good place to start? I mean it is better than the current situation
at the very least.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:56 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-xCmyKkWaXG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #80 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138267&action=edit
Bug 30650: Admin page

This patch adds a new page in the administration area to manage curbside
pickups.

Test plan:
1. Enable the new CurbsidePickup syspref
2. Go to Administration > Curbside pickups
=> If the logged-in user has the manage_curbside_pickups permission you
should see the administration view
3. Enable the feature for some libraries and configure it.
 a. You must define a "pickup interval" and a "maximum patrons per interval"
values.
 b. If "Patron-scheduled pickup" is enabled, patrons will be able to
schedule curbside pickups from the OPAC
 c. If "Enable for waiting holds only" is enabled, only patron with waiting
holds will be allowed to schedule curbside pickups
 d. In the bottom part of the form you can define the slots available for
curbside pickups.
 e. Save

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:13:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:13:07 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-zR0zIGr492@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
           Severity|enhancement                 |major
             Status|Signed Off                  |Passed QA

--- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Works, QA script happy, code looks good, passing QA :)

Severity upped to major. Feel free to change if that's too much. Surely that's
at least normal severity.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:47 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-8KYuavrqNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138314&action=edit
Bug 23919: Items search by ISBN variations and ISSN variations

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:41:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:41:56 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-sLRVx7VVtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137721|0                           |1
        is obsolete|                            |

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138301&action=edit
Bug 30308: Fix bulkmarcimport.pl broken by
OAI-PMH:AutoUpdateSets(EmbedItemData)

Test plan:

(A) Reproduce the bug:

A1 In Administration > System preferences > Web services:
   - Enable OAI-PMH
   - Enable OAI-PMH:AutoUpdateSets
   - Enable OAI-PMH:AutoUpdateSetsEmbedItemData

A2 In Tools > Export data > Export bibliographic records, export 1 (one)
   biblio record. Be sure that this biblio record has at least one item.
   Don't tick "Don't export items".

A3 Delete the exported biblio record, and its items.

A4 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

A5 Retrieve the biblio record in Koha. Note the absence of the item(s). This is
   the bug.

(B) Apply the patch

B1 Delete the record (without item) loaded at A4.

B2 In command line, on the server load the exported file:
   ./bulkmarcimport.pl -b -v -file /path/to/koha.mrc

B2 Retrieve the biblio record in Koha. Note the presence of the item(s).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:14:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:14:54 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-idf2wtcSz9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.05                       |master
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:11:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:11:42 +0000
Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online
 purchase suggestion
In-Reply-To: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9290-70-a1ipachsL9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290

--- Comment #24 from Vinod <mishravk79 at gmail.com> ---
(In reply to Pablo López Liotti from comment #23)
> hi, there are any news on this topic?
> In the university libraries is wanted to filter students suggestions.
> I hope I can do by jquery while.

(In reply to Vinod from comment #4)
> @Indranil, I will be the part of co-sponsor, trying to get some more very
> soon.

Hello,

Is there any update on this as it is already delayed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 01:34:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 23:34:41 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-ra6PwcCXQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #27 from David Nind <david at davidnind.com> ---
Minor suggested changes to the new EmailPatronRegistrations system preference
wording:

- Revised wording for the first sentence: Choose the email address that new
patron self-registration notifications are sent to: [options].

- Option - 'email address of branch': I think the terminology guidelines are to
use library instead of branch. 

- Remove the : at the end of the last sentence and replace with a full stop.
I've also suggested some revised wording.

==> Choose the email address that new patron self-registration notifications
are sent to: [options]. A valid email address is required for
EmailAddressForPatronRegistrations if that option is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:49:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-2vPnGmAemx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #136 from Owen Leonard <oleonard at myacpl.org> ---
I've taken a different approach regarding the next step with this work. I think
we should be working with a set of templates with as few changes as possible as
we adjust the CSS. I think reducing template changes is going to make testing
easier. Some template change reversions can be replaced with CSS changes.
Others can wait until we have more consensus about the design in general.

https://gitlab.com/koha-dev/koha-dev/-/commits/wip-bug-30952-staff-redesign

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:42:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:42:09 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-EA3lNixUB2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #138 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138246&action=edit
Bug 30952: Undo change to Home breadcrumb for remaining templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:37 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-WtA2gGsCWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138253&action=edit
Bug 29897: Fix linkage

Signed-off-by: Orex Digital <info at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:05 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-z4hroF2149@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135922|0                           |1
        is obsolete|                            |
 Attachment #135923|0                           |1
        is obsolete|                            |
 Attachment #135924|0                           |1
        is obsolete|                            |
 Attachment #135925|0                           |1
        is obsolete|                            |
 Attachment #135926|0                           |1
        is obsolete|                            |
 Attachment #135927|0                           |1
        is obsolete|                            |
 Attachment #135928|0                           |1
        is obsolete|                            |
 Attachment #135929|0                           |1
        is obsolete|                            |
 Attachment #135930|0                           |1
        is obsolete|                            |

--- Comment #122 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138221&action=edit
Bug 24860: Add reserves.item_group_it

This feature builds upon bug 24857 and allows placing holds that target a
specific item group of a record. It is patterned after the feature that allows
limiting hold selection by itemtype ( AllowHoldItemTypeSelection ).

Test Plan:
1) Apply bug 24857 and this bug's patches
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the sysprefs EnableVolumes and EnableVolumeHolds
5) Create a record, items and item groups, with each item being assigned to
an item group
6) Place a hold for a patron
7) Note the new selector to choose an item group in addition to record and item
level holds
8) Place an item group level hold
9) Check in an item from the record that is not part of that item group
10) Note the hold is not trapped for that item
11) Check in an item from the record that *is* part of that item group
12) Note the hold is trapped for that item
13) Place an item group level hold for another item
14) Run the holds queue builder
15) Note the holds queue targets only items from that item group
16) Check out all the items of that item group to other patrosn
17) Re-run the holds queue builder
18) Note the holds queue no longer has a line for that hold,
    as all items that could fill that hold are now unavailable

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:24 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-y4awJ6AsKB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #124 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138224&action=edit
Bug 24860: Implement reserves.item_group_id

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:27 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-fESfNe6yDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138251&action=edit
Bug 29897: Add new pref OPACAuthorIdentifiers

Sponsored-by: Orex Digital

Signed-off-by: Orex Digital <info at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 00:40:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 22:40:15 +0000
Subject: [Koha-bugs] [Bug 31220] Error when attempting to export selected
 labels as PDF
In-Reply-To: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31220-70-jnep2EITnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31220

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
   Patch complexity|---                         |Small patch

--- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Are the warn Data::Dumper::Dumper forgotten there or are there logging
improvements?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:44:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:44:12 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-gP4YEpxBNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just mentioning here that mediumtext is not really needed for the script name;
tinytext would suffice (256).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:03:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:03:27 +0000
Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values
 with a code of '0'
In-Reply-To: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27684-70-HkNDjxRFUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684

--- Comment #8 from Didier Gautheron <didier.gautheron at biblibre.com> ---
(In reply to Jonathan Druart from comment #6)
> You need a test and certainly to modify this other place:
> 
> Koha/UI/Form/Builder/Item.pm
> 122         $value = $subfield->{defaultvalue};

No, in my understanding it's already done there :

 if ( $prefill_with_default_values && ( !defined($value) || $value eq '' ) ) {
        $value = $subfield->{defaultvalue} if !$item->{itemnumber}; # apply
defaultvalue only to new items


it's only set $value if it's undefined or an empty string.

Unlike 0 empty string for a VA code is an issue in a lot of place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:46:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:46:56 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-J2YjeSwJHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #140 from Julian Maurice <julian.maurice at biblibre.com> ---
Owen, I took one of your patches for removing for undoing changes to the
breadcrumb, but I didn't take the last patch like I said I would do. I believe
it tries to fix things that are already fixed, and for the home icon I changed
the CSS to use the FontAwesome icon instead (looks better than the inline SVG
IMO)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:46 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-dhbOxNIDGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #89 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138276&action=edit
Bug 30650: Notify the patron when a new curbside pickup is created

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:45:47 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-j4o06ArQX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #12 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
(In reply to Michael Hafen from comment #7)
> My test plan missed hitting the 'add patrons' button the second time.  

Great, thank you.

Patch works as described with the updated test plan - so I've signed off.

Unfortunately, the sandbox is playing havoc at the moment and won't sign off
both of the patches.  After signing one off twice, it has now added a patch
from a different bug - rather than signing off the two patches Michael added. 
Nightmare.  :(

But the two patches from Michael both work here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:11:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:11:41 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-l9bipti8SQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Michael, please check the attache file, this doesn't appear to be a correct
patch file, but only the commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:31 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-zE55cXgYHB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #76 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138263&action=edit
Bug 30650: Koha classes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:37:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:37:17 +0000
Subject: [Koha-bugs] [Bug 31257] Add a new English 1 page layout to export a
 basket as PDF
In-Reply-To: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31257-70-TIvczZQjfk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 138236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138236&action=edit
Bug 31257: WIP

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:14:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:14:05 +0000
Subject: [Koha-bugs] [Bug 31260] New: From cash app support know How To
 Borrow Money From Cash App
Message-ID: <bug-31260-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31260

            Bug ID: 31260
           Summary: From cash app support know How To Borrow Money From
                    Cash App
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: finnfoster.foster at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Are you struggling with enabling the cash app borrow feature? If you haven't
been able to enable this feature then seek help from the cash app technicians
via helpline number. For this answer, connect with a team of technical
professionals. While talking to the experts, you can ask How to Borrow Money
>From Cash App? Techies will answer the query with ease so that you can easily
solve them. For eliminating these kinds of problems, just get in touch with the
cash app technical experts via helpline number.
https://www.digihubexpert.com/cash-app/how-to-borrow-money-from-cash-app/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:53:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:53:07 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-RPi9oWfKAr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138259&action=edit
Bug 29897: Don't display identifier if not in the list

Requested by QA, see comment 26.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:57:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:57:12 +0000
Subject: [Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce
 DB calls
In-Reply-To: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29454-70-f9WB0V7N2c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:33:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:33:47 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-wuoSK8d47h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmanuel, what kind of environment are you using for testing?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 01:54:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jul 2022 23:54:03 +0000
Subject: [Koha-bugs] [Bug 22352] Items location not shown correctly in email
 sent lists
In-Reply-To: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22352-70-7OkoPX0zBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22352

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:08:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:08:33 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-DC5Ib4b82i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:53:02 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-8GQpKXvSST@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138258&action=edit
Bug 29897: Move the identifier list to an include file

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:01:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:01:18 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-E9QUL1YCyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:53 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-YVWY6OmKuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138205&action=edit
Bug 31253 - Item search in staff interface should call barcodedecode if the
search index is a barcode

We should run any inputted barcode through barcodedecode before passing it to
any subroutines.
This was missed during the initial development of bug 26351.

Test Plan:
1) Set itemBarcodeInputFilter to "Remove spaces from"
2) Create an item with the barcode "MYTEST"
3) Browse to the staff side advanced search
4) Run a barcode search for "MY TEST"
5) Note no results are round
6) Apply this patch
7) Restart all the things!
8) Repeat your search
9) Note the item was found!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 03:38:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 01:38:29 +0000
Subject: [Koha-bugs] [Bug 30654] Even with RabbitMQ enabled,
 we should poll the database for jobs at worker startup
In-Reply-To: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30654-70-eKu7PCH2Oi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30654

--- Comment #15 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #14)
> (In reply to Tomás Cohen Arazi from comment #12)
> > Let's kill the rabbit ;-)
> 
> I won't oppose it. Minion might make more sense after all.

That said, I am a little suspicious that Sebastian Riedel is going to abandon
Mojolicious/Minion (ie Perl) in favour of mojo.js/minion.js (ie
Node.js/Typescript). 

He keeps saying that he's not going to abandon them but... there's no
guarantees in life. 

Of course, that's why I keep thinking having a robust model is important, so
that porting to a different controller framework isn't prohibitive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:25:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:25:04 +0000
Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values
 with a code of '0'
In-Reply-To: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27684-70-EBNwi6wF6B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684

--- Comment #9 from David Nind <david at davidnind.com> ---
I'm not that familiar with serials, so could you clarify steps 1-6 in a bit
more detail?

I've:
1. Added an authorized value for NOT_LOAN:
   . Authorized value = 0
   . Description = Available
   . Library limitations = All libraries
2. Created a serial, set so that it creates an item record when received.
3. Received an edition: 952$7 has no value selected by default and I set it to
Available (using the authorized value setup in step 1).
4. After applying the patch and receiving another edition, the default still
has no value selected by default.

Am I supposed to manually create an item when I first set up the serial? (Do
subsequent editions received inherit the values set up for this first item?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:32:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:32:07 +0000
Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on
 first staff login
In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30588-70-HhyMVe2FZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138193&action=edit
Bug 30588: Add missing include file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:09 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-dEAurmaPSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #92 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138211&action=edit
Bug 22456: DBIC update

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:18:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:18:20 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Mb8mBagDb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #270 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I see this bug stalled back in 2020.  I LOVE the concept of it, and hope it can
pick up momentum again.  I think leaving deleted things in their original
tables with a date to flag deletion is a positively brilliant idea.  It would
leave links in tact where needed, and make it so easy to implement an undo
feature of deletion down the road.

If this project is too big, maybe it can be done in phases?  Just a shame it
hasn't move in a couple of years.  This would be a HUGE step forward for Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:11:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:11:11 +0000
Subject: [Koha-bugs] [Bug 29055] Focus on keyword field when subscription
 biblio search window opens
In-Reply-To: <bug-29055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29055-70-uYQrdRr22U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29055

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:38:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:38:53 +0000
Subject: [Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
In-Reply-To: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29057-70-oHf6Te2yS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

--- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be bacckported to 22.05.x unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:42:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:42:17 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-jQjMsCmDuE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #139 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138247&action=edit
Bug 30952: Replace "Home" by icon in breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:10:58 +0000
Subject: [Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation
 correctly
In-Reply-To: <bug-30822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30822-70-B78XJASZq2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #23 from Lucas Gass <lucas at bywatersolutions.com> ---
Does not apply cleanly to 22.05.x, no backport. Please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:33 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PA5BWRVbex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138291|0                           |1
        is obsolete|                            |

--- Comment #148 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138359&action=edit
Bug 30650: Take dateformat into account

dayjs init was not passing the dateformat.
We really need to clean the date handling with the following two bugs:
  Bug 30310 - Replace Moment.js with Day.js
and
  Bug 30718 - Use flatpickr's altInput option everywhere

But it's outside the scope of this bug report.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:48:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:48:04 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-2thbRMBPDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #108 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>From testing in the GUI:

3) Curbside pickup configuration

The trashcan icon behind the times is missing a space before it. It also
doesn't have an alt text/tool tip when hovering.

4) Circulation start page

a) With CircSidebar enabled, the curbside pickup entry is missing from the
sidebar.
b) Also the curbside configuration page doesn't show the sidebar.
c) Capitalization: Curbside Pickup = Curbside pickup

5) Schedule pickup

a) When scheduling a pickup the calendar widget shows future days greyed out
and allows to select dates in the past. (blocker)
b) The button remains greyed out until you pick a date with pickup times
available. I think a tool tip would be very helpful here. (not blocker)

5) New notice NEW_CURBSIDE_PICKUP

a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname %]
=> ... scheduled (normal)
b) Can we break the content text into 3 entries in the .yml file for new
installations (one per sentence) to ease translation a bit? (normal)

6) Koha start page

a) The start page for new pickups reads: New curbside pickups 1. We should add
a : here: 
New curbside pickups: 1 
This makes it also more consistent with the other entries (looked at
suggestions and patron modifications). (trivial)


7) OPAC view

As this is the patron side of things, I worry more about that than about other
stuff. I have some issues here:

a) The alert link will only be functional, when the pickup has been "staged &
ready". But there is no clue in the GUI about this and the patron might be in
front of the library without being able to see what's going on. 
b) Once the pickup has been "marked as delivered" it still remains in the list
with no clue that it has been picked up already. It would be nicer to display,
that it's already been delivered. Note: only today's and future pickups will
show in the list.

Maybe this could be a separate bug as well to get some feedback, but it feels
like we should give the patrons more information there.

X) Possible enhancements

These are supposed to go into new wish list bugs. But maybe you could look
through them quickly to check if I have missed/misunderstood something?

a) Curbside pickup configuration page: The weekday pull down and display should
follow the CalendarFirstDayofWeek system preference.

b) Show a note on top of the Curbside pickup configuration page, if the
Curbside pickup module is not enabled (similar to what we do for the Transport
cost matrix administration page)

c) Improve GUI for pickup up pickup times in staff interface: The times are a
little hard to select/hard to read. I think it would be nice to make this look
more like in the OPAC. 

d) Scheduling a pickup from the curbside pickups page only will only work with
the cardnumber. It would be nicer to use the standard patron search for this.

e) Add logging for curbside pickup location actions

f) Have different permission descriptions (might require to change the
permission code) to make it clearer what the difference between each of the
permissions is.

h) Make curbside pickup confirmation its own messaging preference or adapt
messaging preference description to include curbside pickups when the pref is
enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:49 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-1CVnQgzZra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #79 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138266&action=edit
Bug 30650: Add link from the admin home page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:14:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:14:58 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-Zdyr4YE2Oi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Added a dependency on 12446, which just made it possible to have guarantors for
adults. This patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 09:36:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 07:36:31 +0000
Subject: [Koha-bugs] [Bug 31248] Make checkout history table responsive for
 mobile
In-Reply-To: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31248-70-1bgK7pN8JP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.derscheid at lmscloud.de

--- Comment #1 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
I cannot reproduce this issue. Following your steps I'm able to scroll sideway
with a trackpad (as this is a mobile view, scrolling with a touchscreen is
possible). 

However I noticed that in the checkout history as well as in the summary the UI
uses a table to display the data. So there's no list view for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:24:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:24:27 +0000
Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems
In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30392-70-MEf3koI650@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:20 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-Erod7eEevd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:37 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-e2s4gbOnWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #127 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138227&action=edit
Bug 24860: Skip non-matching item group holds in CheckReserves

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:59 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Rqg3aiSu8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #102 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138289&action=edit
Bug 30650: Don't display slots that have are before now

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:10:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:10:05 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-vG4lxrDihN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #112 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138322&action=edit
Bug 30650: Add link to the circ nav bar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:31:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:31:25 +0000
Subject: [Koha-bugs] [Bug 30947] Simplify date handling in CanbookBeIssued
In-Reply-To: <bug-30947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30947-70-doOCIzdOfY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30947

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Not going to backport this enhancement to 22.05.x unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 17:33:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 15:33:55 +0000
Subject: [Koha-bugs] [Bug 30068] Wrong reference to table_borrowers in
 circulation.tt
In-Reply-To: <bug-30068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30068-70-BOxRvm9zdQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068

--- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Oh I think I found where table_borrowers is used: when searching for a patron
to place a hold. 
So ignore my previous comment!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:09:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:09:58 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-4BhV626PZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #111 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138321&action=edit
Bug 30650: Add info to the trash icon

And add a missing space between the time and icon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:30:56 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-gOMbTrOODx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Have to conclude that this is not ready for passing QA yet.

Just removing the encoding/escaping does not look good.
We meet the issue here too of the encoding of CGI::Session. If we store unicode
stuff (in the URL) within param busc, how does it get stored and how should we
retrieve?
It feels like we should do conversion as early as we retrieve and as late as we
store it again. And such that it survives pure ASCII, Latin and 'real' Unicode.

-    use URI::Escape qw( uri_escape_utf8 uri_unescape );
+    use C4::Search;
This does not look good either. Probably we need to move URI::Escape to the
top.

The whole logic for Back and Next in this feature looks buggy. But that is
outside the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:08:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:08:37 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-GmIZgv1RW1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136711|0                           |1
        is obsolete|                            |

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138199&action=edit
Bug 12758: Make LWP::Protocol::https required module

Moving from recommends to required in cpanfile.

Reference info: Debian package liblwp-protocol-https-perl is
available for Buster (6.07-2) and Bullseye (6.10-1).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:36:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:36:19 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-V1ImtdJlUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This is very weird code. Apart from the encoding, the paging seems to be buggy
too.

Can reproduce the issue Frido mentioned:

Back to results (pos 9 with 5 results per page WHEN coming back from pos 10)
/cgi-bin/koha/opac-search.pl?idx=kw&sort_by=relevance_dsc&q=b%C3%83%C2%B6%C3%83%C2%B6k
=> böök

The previous and next links are good, but the Back to results becomes even more
bad when paging back and forth..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:35:51 +0000
Subject: [Koha-bugs] [Bug 30344] Changing a patron from a category that
 allows guarantees to one that doesn't should remove that link
In-Reply-To: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30344-70-Dud7Dzczzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
         Depends on|                            |12446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:38 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-rqTwFC0lzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138292|0                           |1
        is obsolete|                            |

--- Comment #149 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138360&action=edit
Bug 30650: Display the link in the admin even if the pref is off

The link in the sidebar was displayed already. The idea is to let admins
configure the module before enabling it for users.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:35:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:35:43 +0000
Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
In-Reply-To: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26351-70-qoxoESWhyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252
[Bug 31252] Advanced search in staff interface should call barcodedecode if the
search index is a barcode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:46:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:46:13 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-DNKcCUa4xf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138133|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138235&action=edit
Bug 30389: Switch to Bootstrap tabs on the page for adding orders from MARC
file

This patch updates addorderiso2709.tt so that it uses Bootstrap tabs
intead of jQuery.

The patch contains indentation changes, so diff accordingly.

To test apply the patch and go to Acquisitions -> Vendor -> Basket ->
Add to basket -> From a staged file.

- Click "Add orders" next to the staged file you want to use.
- On the "Add orders" page, test that the tabs work correctly.

Signed-off-by: Séverine Queune <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:42:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:42:03 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-p8JfAChNuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138244&action=edit
Bug 30984: (QA follow-up) Ternary formatting style

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:05:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:05:09 +0000
Subject: [Koha-bugs] [Bug 30871] Make it clear that 008 Type of Material is
 controlled by Leader 6th position in MARC21
In-Reply-To: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30871-70-tr8EoRFfc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30871

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04. 


Added a tiny follow-up to fix a forbidden character FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:49 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-ZGscgqUZmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138320|0                           |1
        is obsolete|                            |

--- Comment #151 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138362&action=edit
Bug 30650: Add dayjs license to the about page

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:00:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:00:39 +0000
Subject: [Koha-bugs] [Bug 30939] remove_unused_authorities.pl is broken
In-Reply-To: <bug-30939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30939-70-PrT960Sziz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30939

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 09:07:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 07:07:39 +0000
Subject: [Koha-bugs] [Bug 30462] Should the background job list view hide
 index tasks by default?
In-Reply-To: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30462-70-cbvS6Xi2eJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #27)
> Can I please have a test plan for this one? I don't know much about the
> background jobs yet, so I wonder what the best way would be to ensure I have
> a completed and a queued job?

You can use one of these methods:
1. batch mod a long list of items
2. add a sleep in the ->process method of one of the Koha::BackgroundJob
modules
3. modify in DB directly to simulate a running job: set status="new",
ended_on=null

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:47:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:47:25 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-PfJlAnCK97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:26:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:26:05 +0000
Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines
In-Reply-To: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31254-70-5S4DBIIcWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

--- Comment #2 from Emmanuel Bétemps <e.betemps at gmail.com> ---
Created attachment 138370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138370&action=edit
Make a payment

Steps 1 to 5 are ok (I see the credits / debits fileds I created)

At step 6, I don't see any Credit fields as I saw them at steps 4-5
Maybe I don't look at the right place ? (screenshot taken)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:04 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-kJPqOWSolF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #91 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138210&action=edit
Bug 22456: Add waiting_hold_cancellation circulation rule

This patch adds handling for the waiting_hold_cancellation circulation
rule. It is set no 'No' by default in the atomic update, if not
previously set.

Handling in the rules editor is added, in its own section.

To test:
1. Apply this patch
2. Run:
   $ updatedatabase
=> SUCCESS: All good
3. Verify that the syspref is set:
   $ koha-mysql kohadev
   > SELECT * FROM circulation_rules WHERE
rule_name='waiting_hold_cancellation';
=> SUCCESS: Set to 0
4. Play with the rules editor, changing things back and forth, things
   should work, including library-specific and global/defualt settings.
=> SUCCESS: It works
=> SUCCESS: Texts are idiomatic
5. Sign off :-D

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:58 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-RQ87klvfLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #91 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138278&action=edit
Bug 30650: Allow to restrict curbside pickup for waiting holds only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:28:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:28:45 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-4ntsEzwlIk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #132 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #120)
> Sorry Kyle.. I'm not seeing tests added or adopted for the C4 module
> changes.. could you add these please?
> 
> Failing QA for now... but this is close :)

I've not seeing what module is missing tests. I've added tests for AddReserve
already! Is there one I missed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:10:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:10:33 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-UCt4ysFPbW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136712|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:29 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-RzU6pkFLap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #125 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138225&action=edit
Bug 24860: Add ability to select an item group when placing a hold

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:18:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:18:23 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-d3KyeCgS9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138310&action=edit
Bug 29012 (QA follow-up) Use q{} instead of '' in smart-rules.pl

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:21:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:21:52 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-t1n6p1DPeS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org
                   |ity.org                     |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Michael, please don't forget to assign yourself!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:20:15 +0000
Subject: [Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel
 cover images in the OPAC lightbox gallery
In-Reply-To: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31217-70-z7l8sJSAtJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Paul Derscheid <paul.derscheid at lmscloud.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.derscheid at lmscloud.de

--- Comment #10 from Paul Derscheid <paul.derscheid at lmscloud.de> ---
Didn't write it in the sign-off because I'm scared of the python timeouts but
everything works as expected. Great work. 👍

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:09:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:09:25 +0000
Subject: [Koha-bugs] [Bug 31259] New: Downloading patron card PDF hangs the
 server
Message-ID: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259

            Bug ID: 31259
           Summary: Downloading patron card PDF hangs the server
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Label/patron card printing
          Assignee: cnighswonger at foundations.edu
          Reporter: jake.deery at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Hi,

One of our customers is having an issue with their patron card creator, that we
have been able to replicate on our support server. Both installations are
Debian package installations, and both installations run atop Debian 10.

When one goes to create a 'patron card' using the build-in patron card creator
found under Tools > Patron card creator, the download process loops endlessly
and eventually returns a Proxy Timeout (we have tried without Plack).

Steps to reproduce:
1.    Create printer profile with:
      *    0mm x 0mm offset
      *    0mm x 0mm creep
2.    Create card template with:
      *    297mm x 210mm page
      *    99.1mm x 38.1 card
      *    15mm top page margin
      *    5mm left page margin
      *    2 columns
      *    7 rows
      *    3mm gap between columns
      *    0mm gap between rows
3.    Create layout with:
      *    Guide box on
      *    Guide grid off
      *    Field 1 text to 'Name: <firstname> <surname>'
      *    Font to 'Courier'
      *    Font size to 14pt
      *    Text alignment to left
      *    Lower left X co-ord to 20mm
      *    Lower left Y co-ord to 25mm
      *    Print card number as barcode: yes
      *    Lower left X co-ord: 30
      *    Lower left Y co-ord: 10
      *    Barcode type: CODE39
      *    Print card number as text under barcode: yes
4.    Add two patrons to a new card batch, and use the previously created
printer profile, card template, and layout.
5.    Export the entire batch as a PDF.
6.    The software will hang, and a 'create-ptf.pl' process will run
indefinitely
koha at demo1:~$ sudo ps aux | grep perl
support+ 30344 93.1  5.2 287880 210820 ?       R    10:06   0:05 /usr/bin/perl
/usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl

The create-ptf.pl script eats the CPU, and also appears to leak memory
indefinitely, until the OOM killer is forced to step in. I have tried changing
a few different values, including the font (as I thought maybe it was Courier
being missing in Linux), all to no avail.

If anyone has the time to take a look at this, or has a vague idea of what
lines to look at so I can see if I can fix it myself, that would be hugely
appreciated.

Many thanks,
Jake

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:09:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:09:29 +0000
Subject: [Koha-bugs] [Bug 31250] Don't remove advanced/basic cataloging
 editor cookie on logout
In-Reply-To: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31250-70-MWYpcMDbti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31250

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Lucas, I could imagine that we call this a bug for backporting. Especially the
first patch. Note that we do not touch koha-conf at upgrades, so it still needs
koha-conf editing. Which might make backporting a bit less interesting..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 10:40:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 08:40:39 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-fEFOxYXUAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138194&action=edit
Bug 28864: Have patron search use PatronsPerPage better.

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1. Set the PatronsPerPage system preference to any integer other than 20.

2. Go to the Patrons page and search for patrons.
3. Observe that the per page drop down defaults to 20.

4. Go to Tools -> Patron card creator.
5. Start a new Card Batch.
6. Click the 'Add patron(s)' button to open the patron search window.
7. Do a search.
8. Observe that the per page drop down defaults to 20.
8b.  If the PatronsPerPage was set to a value other than 10, 20, 50, or 100
      observe that that value is not in the per page drop down.
9. Close patron search window.

10. Apply patch.
11. Click the 'Add patron(s)' button again to open the patron search window.
12. Do a search.
13. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

14. Go back to the Patrons page and search for patrons.
15. Observe that the per page drop down defaults to the value of the
     PatronsPerPage system preference.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:41:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:41:53 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-NaAEye210D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:12:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:12:51 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-M3MhWDPrp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |26351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351
[Bug 26351] Add plugin hooks to transform item barcodes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:41:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:41:36 +0000
Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't
 set for the opac, try to guess it by checking branchip
In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28658-70-JeW4MyWcJg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:13 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-hyNAsUR6Rg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138266|0                           |1
        is obsolete|                            |

--- Comment #123 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138334&action=edit
Bug 30650: Add link from the admin home page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:50:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:50:13 +0000
Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned
 fields/subfields
In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30975-70-tuY1LZTPv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136135|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138318&action=edit
Bug 30975: Fix framework plugins not working on cloned fields/subfields

Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do
not work on a cloned field/subfield.
That is because we rely on jQuery's `.data('events')` to clone event
handlers to the cloned elements, and that was removed in jQuery 1.8.0
(I did not confirm but it's possible it continued to work after that
thanks to jQuery Migrate)

It is apparently still possible to access these event handlers by using
`jQuery._data(element, "events")` but here's what jQuery 1.8.0 release
notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

Instead, what this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) Only 'click', 'focus' and 'blur' events are listened to now. They are
   the only ones we use, and the only ones we actually need.
   Events removed: change, mouseover, mouseout, mousedown, mouseup,
   mousemove, keydown, keypress, keyup.
   If you ever need one of those, you can still add event listeners in
   the 'focus' event handler, and remove them in the 'blur' event
   handler
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated. All framework plugins
   have been updated
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:51:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:51:14 +0000
Subject: [Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices
 script ( advance_notices.pl )
In-Reply-To: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29100-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29100-70-YdFUJDCle0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

--- Comment #10 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
This will be a great enhancement, thank you, Kyle :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:01 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-tsOCXfmS9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138322|0                           |1
        is obsolete|                            |

--- Comment #153 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138364&action=edit
Bug 30650: Add link to the circ nav bar

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:35 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-MVDzPW17KG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #87 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138274&action=edit
Bug 30650: OPAC view

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:53 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-xQmn35XXG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #101 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138288&action=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:31:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:31:59 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-KxCNrTiABw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #142 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138299&action=edit
Bug 30952: Fix position shift when hovering .linktools links

Issue #6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:15:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:15:23 +0000
Subject: [Koha-bugs] [Bug 31246] <span> displayed in 'Additional fields'
 section
In-Reply-To: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31246-70-Qi6BPaNEaz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31246

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:33:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:33:08 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-xvuj12Tigv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:47:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:47:18 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-GrJe5YEwVj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
           Assignee|oleonard at myacpl.org         |jonathan.druart+koha at gmail.
                   |                            |com
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:44 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-vKxnDc4YDB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138319|0                           |1
        is obsolete|                            |

--- Comment #150 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138361&action=edit
Bug 30650: Fix some typos

* Curbside pickups are not enabled for your location. = library
* Pickup Date/Time = capitalization
* ... it is an holiday = it is a holiday. (multiple)
* Deliver Date/Time = capitalization
* There is no waiting holds for this patron at this location. = There are no...
at this library
* No pickup time define for this day. = defined (multiple)
* You don't have waiting holds at this location = library

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:12 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-4rnDmkG6pw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138324|0                           |1
        is obsolete|                            |

--- Comment #155 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138366&action=edit
Bug 30650: Split yml on several lines to help translation

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:43 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-WrA5dFSqjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #78 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138265&action=edit
Bug 30650: Add new permission manage_curbside_pickups

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:51:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:51:45 +0000
Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50
 filter
In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30966-70-P9op3O2G5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:09:44 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-HyrpFI2NmS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #109 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138319&action=edit
Bug 30650: Fix some typos

* Curbside pickups are not enabled for your location. = library
* Pickup Date/Time = capitalization
* ... it is an holiday = it is a holiday. (multiple)
* Deliver Date/Time = capitalization
* There is no waiting holds for this patron at this location. = There are no...
at this library
* No pickup time define for this day. = defined (multiple)
* You don't have waiting holds at this location = library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:18:12 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-U4YX22p7E6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138140|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138309&action=edit
Bug 29012: Add default values for blank circulation rules that weren't saved to
the database

There are 5 fields that are not set if no value is provided when saving/editing
a rule in Administration->Circulation and fines rules
- issuelength
- hardduedate
- unseenrenewalsallowed
- rentaldiscount
- decreaseloanholds

This is problematic because it gives the impression these rules are set as
blank, but in reality they don't exist and the rule will fal back to the higher
level

To test:
1 - Set a rule for
    Patron category: Teacher
    Itemtype: All
    Hard due date: (Today)
    Lona period: 10
2 - Set a rule for
    Patron category: Teacher
    Itemtype: Books
    Hard due date: (leave blank)
    Loan period: 10
3 - Expected behaviour is Book item will checkout to teacher for 10 days, all
other types will be due yesterday at 25:59:00
4 - Checkout an non-book item type to teacher
5 - Hard due date applies
6 - Checkout a 'book' item type to teacher
7 - Hard due date applies - FAIL

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:46 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-hVHAWTT2Bs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138255&action=edit
Bug 29897: Add and fix POD

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:23 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-lCKvE3SiOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #157 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138368&action=edit
Bug 30650: Add missing name to notice added by database update

The notice was missing the name, which gives you an error when
you try to save changes in Koha.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:34:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:34:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-8UqsX85cJe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #105 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138292&action=edit
Bug 30650: Display the link in the admin even if the pref is off

The link in the sidebar was displayed already. The idea is to let admins
configure the module before enabling it for users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:08:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:08:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-n6W3Nt9Mpt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Michael Adamyk <madamyk at ckls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madamyk at ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 12:50:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 10:50:52 +0000
Subject: [Koha-bugs] [Bug 31242] Add rate-limiting to the REST API
In-Reply-To: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31242-70-8FTIhjA2Wc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
> I answered a query about horizontally scaling Koha, and I suppose if you
> were to horizontally scale Koha, you'd want your rate limiting to be done by
> your load balancer. But we can cross that bridge when we come to it too.

Yep, and nothing would prevent you from doing so! Just as any power use could
replace apache with nginx or some other frontend. Any rate limiting feature
could be turned off or set to an impossibly high threshold.

> If we rate limited everything (without IP checking), I think they'd still
> DOS Koha just by hitting the global rate limit. 

Indeed. It's a nontrivial problem, especially when the DOSing pc is inside a
library or campus!

> We still occasionally have issues where out of control bots (usually benign
> crawlers) will DOS a Koha instance (not the whole server fortunately) by
> keeping Starman busy, but we have additional software that finds and blocks
> those. 

Ooh, what are you using?

> In theory, we could install fail2ban alongside Koha and point it at Plack
> logs... (I suppose that is a different kind of rate limiting)

That's an interesting idea!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:44 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-pcH9hWFcKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138313&action=edit
Bug 23919: Add tests for biblioItems search by ISBN and ISSN with

variations (sysprefs SearchWithISBNVariations/SearchWithISSNVariations)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:57:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:57:53 +0000
Subject: [Koha-bugs] [Bug 21978] Add middle name field
In-Reply-To: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21978-70-YvXgt9OLDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Needs documenting

--- Comment #130 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 01:20:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 23:20:39 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-VvP0EMweWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows
      release notes|                            |libraries to receive
                   |                            |notifications when patrons
                   |                            |self-register.
                   |                            |
                   |                            |This is
                   |                            |enabled using the new
                   |                            |system preference
                   |                            |EmailPatronRegistrations
                   |                            |(options are: none, email
                   |                            |address of branch,
                   |                            |EmailAddressForPatronRegist
                   |                            |rations, and
                   |                            |KohaAdminEmailAddress) and
                   |                            |a new notice (OPAC_REG).
                   |                            |
                   |                            |To use a specific email
                   |                            |address for notifications,
                   |                            |use the new system
                   |                            |preference
                   |                            |EmailAddressForPatronRegist
                   |                            |rations.
                   |                            |
                   |                            |If verification
                   |                            |is required for
                   |                            |self-registrations (when
                   |                            |PatronSelfRegistrationVerif
                   |                            |yByEmail is enabled), then
                   |                            |notifications are only sent
                   |                            |to the library once the
                   |                            |registration is confirmed.
                 CC|                            |david at davidnind.com

--- Comment #26 from David Nind <david at davidnind.com> ---
Not sure what happened to the test plan for the 'Email library when new patron
self-registers' patch after I signed it off - step 6 and onwards are cut off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:47:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:47:15 +0000
Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search
 creates UX inconsistency
In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26247-70-mBZy3gLnha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:16 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-kFbWTzuAnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:10:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:10:19 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-whP31OouxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #114 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138324&action=edit
Bug 30650: Split yml on several lines to help translation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:51:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:51:15 +0000
Subject: [Koha-bugs] [Bug 31260] SPAM
In-Reply-To: <bug-31260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31260-70-1S4LYwqpEr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|From cash app support know  |SPAM
                   |How To Borrow Money From    |
                   |Cash App                    |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:46:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:46:32 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-VPpOdPnQ5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|String patch                |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:31:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-nHyNRbsgam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31261


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261
[Bug 31261] Curbside pickups - remove dates in the past
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:28 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-cCCVZMtvf1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #158 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138369&action=edit
Bug 30650: (QA follow-up) Terminology: location - library

Updates one remaining occurrence of "at this location" meaning
"at this library".

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:30:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:30:50 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-vbOsDftHzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

--- Comment #3 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 138373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138373&action=edit
Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts

Keyboard shortcuts for catalog search, check in and renew should be following:
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:12:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:12:51 +0000
Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes
In-Reply-To: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26351-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26351-70-Pr3saQfJVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31253


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253
[Bug 31253] Item search in staff interface should call barcodedecode if the
search index is a barcode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:41:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:41:19 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-QRQJtKOCqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138202&action=edit
Bug 31252: Advanced search in staff interface should call barcodedecode if the
search index is a barcode

We should run any inputted barcode through barcodedecode before passing it to
any subroutines.
This was missed during the initial development of bug 26351.

Test Plan:
1) Set itemBarcodeInputFilter to "Remove spaces from"
2) Browse to the staff side advanced search
3) Run a barcode search for "MY TEST"
4) Note the message returned is:
   No results match your search for 'bc,wrdl: "MY TEST"'.
5) Apply this patch
6) Restart all the things!
7) Repeat your search
8) Note the message returned is:
   No results match your search for 'bc,wrdl: "MYTEST"'.
9) Note the lack of the space between MY and TEST!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:32:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:32:37 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
 memberentry
In-Reply-To: <bug-30874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30874-70-VBcKe1CVzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
Bug 30874 depends on bug 12446, which changed state.

Bug 12446 Summary: Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:29 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-vkVj5L7CYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135288|0                           |1
        is obsolete|                            |
 Attachment #135289|0                           |1
        is obsolete|                            |
 Attachment #135290|0                           |1
        is obsolete|                            |
 Attachment #135291|0                           |1
        is obsolete|                            |
 Attachment #135292|0                           |1
        is obsolete|                            |

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138311&action=edit
Bug 23919: Add new system preference SearchWithISSNVariations

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:47:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:47:44 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-OJiCf1NH5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138000|0                           |1
        is obsolete|                            |

--- Comment #24 from David Nind <david at davidnind.com> ---
Created attachment 138239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138239&action=edit
Bug 23538: Unit tests

Test plan:
1. Run unit tests:
sudo koha-shell <instance>
cd t/db_dependent/Koha
prove -v Patron.t

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:04 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-EZLClwb0uG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #92 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138279&action=edit
Bug 30650: Add link from the mainpage

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:43:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:43:28 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-o1ZeVKR4wT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #19 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
(In reply to Victor Grousset/tuxayo from comment #17)
> Email sent to Sally to ask if their testing matches the new test plan. To
> know if the signoff is still valid.

Yes, it's valid. 

I used the new test plan and checked the bug was valid on master.

Then I used the new test plan against the patch, and it worked perfectly - so
that's why I added the sign off.  I'll change the status back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:57 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-7LjDgvYTKD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138274|0                           |1
        is obsolete|                            |

--- Comment #131 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138342&action=edit
Bug 30650: OPAC view

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 02:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 00:25:23 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-4jhmwrYxsB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:48:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:48:13 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-V1VuaNfgXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #62 from Lucas Gass <lucas at bywatersolutions.com> ---
Doesn't apply cleanly to 22.05.x, if needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:53:39 +0000
Subject: [Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to
 search results
In-Reply-To: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22070-70-wbAWj5s8Tz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |oleonard at myacpl.org
                   |com                         |

--- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I won't have time to dedicate to this in the near future.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:09:50 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-VHGaiwAX3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #110 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138320&action=edit
Bug 30650: Add dayjs license to the about page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 03:22:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 01:22:31 +0000
Subject: [Koha-bugs] [Bug 30962] REST API: Add endpoint
 /patrons/:patron_id/check_password
In-Reply-To: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30962-70-eJ5fVB3KkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30962

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Regarding security, I've been thinking more about this, and in theory you could
lock down all non-public API routes by IP address, if your organisation has
static IP addresses and requires VPNs for working from home (WFH).

We do this on other systems that have admin APIs. 

It's possible that you might need to provide a third-party access to an admin
API (like this one in bug 30962), but then you can add their IP address to the
allow list. 

It just adds another layer of security over top of the existing security
measures. 

We could promote the idea by adding some configuration directives to Apache
that allow all IP addresses for both public and non-public API routes and
include some comments about how they can lock down the non-public API routes by
doing X, Y, and Z.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 13:08:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 11:08:42 +0000
Subject: [Koha-bugs] [Bug 12758] Failure when loading or parsing XSLT
 stylesheets over HTTPS
In-Reply-To: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12758-70-R96Q12drhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758

--- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138200&action=edit
Bug 12758: Introduce Koha::XSLT::HTTPS

This module now fetches a https stylesheet and returns it as a
string to Base. (As a workaround waiting for a real solution
in the underlying libraries.)

The module can be extended to resolve includes but this requires
parsing the xslt code.

Test plan:
[1] Run t/Koha_XSLT_HTTPS.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:27:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:27:22 +0000
Subject: [Koha-bugs] [Bug 30068] Wrong reference to table_borrowers in
 circulation.tt
In-Reply-To: <bug-30068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30068-70-PTmiXCGFoV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30068

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
I'm not sure if this is the bug I'm looking for, but I think table_borrowers
doesn't refer to any table anymore? It used to be the patron search when
searching for a patron for a checkout, but now this search simply falls back to
the regular patron search (table is memberresultst).

Just to make sure we're talking about the same thing:
1) In the main page of the staff interface, in the search bar at the top, with
the tab 'Check out' selected, search for part of a name (e.g. "mar" should give
several results with the sample patrons)
--> This table used to be table_borrowers, in the past, we could configure it
under Administration > Table settings > Circulation
--> Note that the tab selected in the search bar at the top is now 'Search
patrons'
2) In the main staff interface, in the search bar at the top, with the tab
'Search patrons' selected, search for part of a name
--> This table is memberresultst, we can configure it under Administration >
Table settings > Patrons

Something was consolidated under 'Search patrons', which is fine, but I think
the reference to that table under Administration > Table settings > Circulation
was forgotten.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:34:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:34:30 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-SmdT9xcxZF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 25698 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:08:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:08:00 +0000
Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new
 patron" form
In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19249-70-pfc55A9LCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249

Agnes Rivers-Moore <arm at hanover.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arm at hanover.ca

--- Comment #7 from Agnes Rivers-Moore <arm at hanover.ca> ---
In our system we do not have Date of Birth as mandatory. We actually have
DateOfBirth in BorrowerUnwantedField so it does not appear in either the long
or quick patron form. I wanted to comment that we are unable to get the
registration date and expiry date fields to appear in the Quick Add form. They
are listed as in the Preference PatronQuickAddFields, but are absent from the
staff interface. Not sure if this is related to the broken picker issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:17:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:17:19 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-dHRtOju8v4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Summary|The patron search results   |The patron search results
                   |in the Patron card creator  |in the patron card creator
                   |doesn't seem to use         |doesn't seem to use
                   |PatronsPerPage syspref      |PatronsPerPage syspref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:46 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-V686sofGfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #129 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138229&action=edit
Bug 24860: Add hold's item group to holds table on circulation.pl and
moremember.pl

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:45 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-lj2Drg0qOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138272|0                           |1
        is obsolete|                            |

--- Comment #129 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138340&action=edit
Bug 30650: Add dayjs and isSameOfAfter plugin

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:08:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:08:30 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-Kq1Hcy0FYD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #145 from Julian Maurice <julian.maurice at biblibre.com> ---
Sandbox recreated will all patches:
https://staff-bug30952.sandboxes.biblibre.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:08:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:08:27 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-UpuwxlKaKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Signed Off

--- Comment #74 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Back to NQA.

Thanks, Petro!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:02:19 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-tbRMWSc4rk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31265


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265
[Bug 31265] Curbside pickups - improve slots selection
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:07:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:07:11 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-x5DInuG6Oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138260&action=edit
Bug 29897: Fix tab display

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:14:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:14:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Z2i9B1m89T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #118 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> > 0) Tests are failing, but possibly just a typo/later change causing it:

Tests pass now.

> > 1) Tiny typos

Fixed another "location" to library in a follow-up.

> > 2) New JS libraries
> Yes, done in "Add dayjs license to the about page"

Ok!


> > 3) Curbside pickup configuration
> > 
> > The trashcan icon behind the times is missing a space before it. It also
> > doesn't have an alt text/tool tip when hovering.
> 
> Done in "Add info to the trash icon"

Much better, thanks!


> > 4) Circulation start page
> > 
> > a) With CircSidebar enabled, the curbside pickup entry is missing from the
> > sidebar.
> Done in "Add link to the circ nav bar"

OK!

> > b) Also the curbside configuration page doesn't show the sidebar.
> 
> "Add the sidebar to the circ view"

OK!

> > c) Capitalization: Curbside Pickup = Curbside pickup

OK!

> > 5) Schedule pickup
> > 
> > a) When scheduling a pickup the calendar widget shows future days greyed out
> > and allows to select dates in the past. (blocker)
> 
> I don't recreate that. All dates can be selected using the widget, but dates
> in the past won't display slots.
> This is the correct behaviour. We could improve and "disable" dates in the
> past or even dates without slots, but that's for another bug report.
> 
> Opened bug 31261 and bug 31262.

Talked about it on IRC and agreeing with the approach.

> > b) The button remains greyed out until you pick a date with pickup times
> > available. I think a tool tip would be very helpful here. (not blocker)
> 
> I think I understand what you mean: you have to remove the focus from the
> widget to be able to select a slot.
> I've tried to fix it already but didn't manage to find a correct solution.

Not blocker for me.

> > 5) New notice NEW_CURBSIDE_PICKUP
> > 
> > a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname
> > %] => ... scheduled (normal)
> 
> Fixed earlier.

OK! Fixed another small glitch: letter.name is set in .yml but not in the
update. See follow-up.

> > b) Can we break the content text into 3 entries in the .yml file for new
> > installations (one per sentence) to ease translation a bit? (normal)
> 
> "Split yml on several lines to help translation"

OK, thanks!

> 
> > 6) Koha start page
> > 
> > a) The start page for new pickups reads: New curbside pickups 1. We should
> > add a : here: 

OK!

> > 7) OPAC view
> > 
> > As this is the patron side of things, I worry more about that than about
> > other stuff. I have some issues here:
> > 
> > a) The alert link will only be functional, when the pickup has been "staged
> > & ready". But there is no clue in the GUI about this and the patron might be
> > in front of the library without being able to see what's going on.
> 
> I would like this to be discussed on a separate bug report, it was the
> previous (plugin) behaviour.
> See bug 31263.

Suggested the same a bit further below, fine by me!


> > b) Once the pickup has been "marked as delivered" it still remains in the
> > list with no clue that it has been picked up already. It would be nicer to
> > display, that it's already been delivered. Note: only today's and future
> > pickups will show in the list.
> > 
> > Maybe this could be a separate bug as well to get some feedback, but it
> > feels like we should give the patrons more information there.
> 
> What do you suggest? Do you want a separate column to display the status?

I think a status column would be nice, but happy to move to a separate bug.

> > X) Possible enhancements
> > 
> > These are supposed to go into new wish list bugs. But maybe you could look
> > through them quickly to check if I have missed/misunderstood something?
> > 
> > a) Curbside pickup configuration page: The weekday pull down and display
> > should follow the CalendarFirstDayofWeek system preference.
> 
> Why do we accept all the day of the week in this syspref?!
> It should, indeed, but not trivial. Opening a separate bug and not sure it
> will be fixed. That seems a lot of work for not much to gain. Maybe first
> keeping only Monday, Saturday and Sunday...
> 
> ...ha ... bug 12137 comment 16...
> 
> Opened bug 31264!

Thx for opening the bugs already :) I agree with your past comment, just
wishing we could have Monday first to match with the calendars.


> > b) Show a note on top of the Curbside pickup configuration page, if the
> > Curbside pickup module is not enabled (similar to what we do for the
> > Transport cost matrix administration page)
> 
> Done in "Add message on the admin page if the pref is off"

OK! Already off the wish list then :)

> > c) Improve GUI for pickup up pickup times in staff interface: The times are
> > a little hard to select/hard to read. I think it would be nice to make this
> > look more like in the OPAC. 
> 
> Opened a separate bug, I would like to ask Owen his opinion what's best
> here. We could improve both I think.
> The plugin was displaying the list in a dropdown list, so it's already a
> nice improvement how it is now ;)
> Opened bug 31265 for discussion.

Thx for the bug!


> > d) Scheduling a pickup from the curbside pickups page only will only work
> > with the cardnumber. It would be nicer to use the standard patron search for
> > this.

> Bug 30965 is waiting for you PQA stamp :)

I'll look at the other related bugs, once we are done here. Would be nice if it
was already pushed as this makes testing a little easier.


> > e) Add logging for curbside pickup location actions
> 
> Can you open a bug report with the detail of what you have in mind exactly?

I'll think about it a bit more. Maybe it's not an issue, but it seemed like a
little missing piece.

> > f) Have different permission descriptions (might require to change the
> > permission code) to make it clearer what the difference between each of the
> > permissions is.
> 
> Is that blocker? :D
> If not done here it won't be done. On the other hand I don't see how it
> could be a problem (the module code is different).

Maybe a non-issue, we can wait and see with this one.

> > h) Make curbside pickup confirmation its own messaging preference or adapt
> > messaging preference description to include curbside pickups when the pref
> > is enabled.
> 
> Yes, that is definitely something we should do. I've copied the plugin's
> behaviour but it's not obvious.
> Opened bug 31266.

Thx!

> I will pick the related bugs with the highest number of votes.

Go and vote people! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:52 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-C6qPMLuxSv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138298|0                           |1
        is obsolete|                            |

--- Comment #80 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138308&action=edit
Bug 27272: Call search_ordered when GetItemsInfo was called before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:52:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:52:00 +0000
Subject: [Koha-bugs] [Bug 20395] Use Price formatter in more templates
 (paycollect, request, parcel, smart-rules)
In-Reply-To: <bug-20395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20395-70-HOo0hRELtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:18 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-iAFicGOsBn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138267|0                           |1
        is obsolete|                            |

--- Comment #124 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138335&action=edit
Bug 30650: Admin page

This patch adds a new page in the administration area to manage curbside
pickups.

Test plan:
1. Enable the new CurbsidePickup syspref
2. Go to Administration > Curbside pickups
=> If the logged-in user has the manage_curbside_pickups permission you
should see the administration view
3. Enable the feature for some libraries and configure it.
 a. You must define a "pickup interval" and a "maximum patrons per interval"
values.
 b. If "Patron-scheduled pickup" is enabled, patrons will be able to
schedule curbside pickups from the OPAC
 c. If "Enable for waiting holds only" is enabled, only patron with waiting
holds will be allowed to schedule curbside pickups
 d. In the bottom part of the form you can define the slots available for
curbside pickups.
 e. Save

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:05:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:05:35 +0000
Subject: [Koha-bugs] [Bug 30988] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30988-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30988-70-aqGP67p2iL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

Michaela Sieber <michaela.sieber at kit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:11:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:11:59 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the Patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-Kzbi3M0xux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138196|0                           |1
        is obsolete|                            |

--- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Comment on attachment 138196
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138196
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty
value

A patch for Bug 31120 was attached by mistake here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:51:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:51:36 +0000
Subject: [Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50
 filter
In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30966-70-bmLZyk3ErF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Johanna Räisä <johanna.raisa at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #5 from Johanna Räisä <johanna.raisa at koha-suomi.fi> ---
Created attachment 138248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138248&action=edit
Bug 30966: Record Overlay Rules - can't use Z39.50 filter

This patch fixes overlay rules on z39.50 import

Test plan:
1) Create protection overlay rule to some fields for z39.50.
2) Import a record via z39.50.
3) See that the protected fields are replaced on the editor.
4) Apply the patch.
5) Import a record again.
6) See that the protected fields are in place on the editor.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:14 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-HFw4aupOzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135983|0                           |1
        is obsolete|                            |
 Attachment #135984|0                           |1
        is obsolete|                            |
 Attachment #135985|0                           |1
        is obsolete|                            |
 Attachment #135986|0                           |1
        is obsolete|                            |
 Attachment #135987|0                           |1
        is obsolete|                            |
 Attachment #135988|0                           |1
        is obsolete|                            |
 Attachment #135989|0                           |1
        is obsolete|                            |
 Attachment #135990|0                           |1
        is obsolete|                            |
 Attachment #135991|0                           |1
        is obsolete|                            |
 Attachment #135992|0                           |1
        is obsolete|                            |
 Attachment #135993|0                           |1
        is obsolete|                            |

--- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138249&action=edit
Bug 29897: Rename get_marc_authors with get_marc_contributors

get_marc_authors actually return authors from 700..712, not the first
author from 200

Sponsored-by: Orex Digital

Signed-off-by: Orex Digital <info at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 17:54:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 15:54:24 +0000
Subject: [Koha-bugs] [Bug 31255] Patron card number prefilled with "1" when
 adding a new patron
In-Reply-To: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31255-70-4L7yHmywRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31255

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:17:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:17:47 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-B6mBSRRWva@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

--- Comment #9 from Emmanuel Bétemps <e.betemps at gmail.com> ---
I got this message after applying the patch (which is not displayed in the
KohaGitLog)
(I test using a sandbox)

-------------------------------------------
Bug 28726 - Add sort1 and sort2 to patron card creator patron search

137854 - Bug 28726: Add sort1 and sort2 to patron card creator -  patron
search.

Apply? [(y)es, (n)o, (i)nteractive] Traceback (most recent call last):
  File "/usr/bin/git-bz", line 2716, in <module>
    applied = do_apply(bug_ref)
  File "/usr/bin/git-bz", line 1827, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
  File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
    response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi:
404 Not Found>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:51:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:51:05 +0000
Subject: [Koha-bugs] [Bug 31264] New: CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
Message-ID: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

            Bug ID: 31264
           Summary: CalendarFirstDayOfWeek not taken into account when
                    configuring curbside pickups
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 30650


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:51:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:51:32 +0000
Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned
 fields/subfields
In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30975-70-qhIzOxYsxL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:30:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:30:28 +0000
Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying
 types in put mapping requests is deprecated (incompatible with 7)
In-Reply-To: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25669-70-HgEzc99DuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #49 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:03 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-wVurcegYsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138275|0                           |1
        is obsolete|                            |

--- Comment #132 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138343&action=edit
Bug 30650: Add link from the member toolbar

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:20:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:20:50 +0000
Subject: [Koha-bugs] [Bug 31023] Cannot create new GENRE/FORM authorities
 when QueryRegexEscapeOptions set to 'Unescape escaped'
In-Reply-To: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31023-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31023-70-2En4gQdpZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31023

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nick, please don't forget to assign yourself!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:41 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-f0Q2sr3IBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138282|0                           |1
        is obsolete|                            |

--- Comment #139 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138350&action=edit
Bug 30650: Prevent pickup to be created on holiday

We could improve this more and add disable the holiday from the date
picker widget, but it's out of the scope here.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:20:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:20:06 +0000
Subject: [Koha-bugs] [Bug 31245] Job detail view for batch mod explode if
 job not started
In-Reply-To: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31245-70-Be6QHbrPc1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #7)
> I don't understand your use case. "new": the job hasn't started yet. report:
> what happened, the job has started (still running or failed or succeeded).

Ok, let's go ahead with your alternative patch. We can enhance it later if
needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:38:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:38:04 +0000
Subject: [Koha-bugs] [Bug 31269] New: DataTables error when managing staged
 MARC records
Message-ID: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

            Bug ID: 31269
           Summary: DataTables error when managing staged MARC records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic record staging/import
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 31138 made some DataTable errors much more visible, which is good. One that
was noticed was when managing staged MARC files.

To recreate:

1. Stage a MARC record for import
2. Once you have one click on 'Manage staged records'
3. You will see an alert that says "Something went wrong when loading the
table."
4. If you dismiss that you should see the following error:

DataTables warning: table id=records-table - Requested unknown parameter '' for
row 0, column 4. For more information about this error, please see
http://datatables.net/tn/4

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:36:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:36:07 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-Qd1Acut9U4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #18 from Michael Hafen <michael.hafen at washk12.org> ---
(In reply to Victor Grousset/tuxayo from comment #16)
> The commits
> Bug 28864: Have patron card creator use PatronsPerPage 
> Bug 28864: Have patron search use PatronsPerPage better.
> are duplicate, which the is the right one?
> 
> Thanks Michael for the correct test plan. Which patch name? With this, we
> will be able to cleanup this.
> 
> The name and test plan was changed on the 1st signoff via a sandbox. I don't
> know how is that possible to change a commit message via a sandbox.

The line numbers are the only difference.  It seems that the commit "Bug 28864:
Have patron search use PatronsPerPage better." is the more correct, looking at
the line numbers (this is the only attachment that isn't marked obsolete);
though I like the commit message of the other commit better, but if you can't
change the commit message, then that's ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 14:35:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 12:35:43 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-Boi96yCGkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |26351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351
[Bug 26351] Add plugin hooks to transform item barcodes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 16:27:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 14:27:34 +0000
Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines
In-Reply-To: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31254-70-Tk3Ta6tEK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138207&action=edit
Bug 31254: Add additional fields for accountlines

Test plan:
1. Go to Admin » Additional fields
   There are two new categories: "Account lines (credit)" and
   "Account lines (debit)"
2. Create fields for both categories, with and without an authorized
   value category
3. Go to a user's accounting page
4. Create a manual invoice. Verify that all "debit" fields are there,
   put a value in them and save
5. Create a manual credit. Verify that all "credit" fields are there,
   put a value in them and save
6. Make a payment. Verify that all "credit" fields are there, put a
   value in them and save
7. Go to the transactions tab, click on the "Details" button for the
   lines you just created and verify that the additional fields are
   there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:21 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-nXGonbKvSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138250&action=edit
Bug 29897: Move code to private method for reusability

Sponsored-by: Orex Digital

Signed-off-by: Orex Digital <info at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:31:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:31:27 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-xeIdPOuTTw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Don't forget to sign, Kyle :) Thx for QA!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:19 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-iDZrtuXSef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 138223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138223&action=edit
Bug 31251: Use jQuery val() to clear_entry

1. Add some patron attributes that are textarea and some that have an AV
category so they are select dropdowns
2. Go to the patron form and add some values to the patron attributes
3. Use the "Clear" button to try and clear the values, doesnt work.
4. Apply patch
5. Try clearing values from patron attributes that are both select dropdowns
and textarea. The "Clear" button should work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:41:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:41:27 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-Vju7fdWkHg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Michael Hafen <michael.hafen at washk12.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |---
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:47:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:47:49 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-KrcrW8w2pG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138001|0                           |1
        is obsolete|                            |

--- Comment #25 from David Nind <david at davidnind.com> ---
Created attachment 138240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138240&action=edit
Bug 23538: (follow-up) Fix up notices

- Add toolkit template (TT) syntax to notices
- Add TT conditionals to notices
- Add translated notice

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 15:12:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 13:12:26 +0000
Subject: [Koha-bugs] [Bug 31248] Make checkout history table responsive for
 mobile
In-Reply-To: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31248-70-rw1Zht2anX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

--- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
You're right, I think I was testing on 22.05 (I'm documenting 22.05 and I can
get a bit confused when I have 20 million tabs open and all the OPACs look the
same, lol)

In my current master (22.06.00.021), the checkouts table is a table and I can
scroll sideways, and the checkout history is the same.

In 22.05 (I'm at 22.05.02.001), the checkouts are in a list and the checkout
history is in a table and I am unable to scroll.

So we seem to have lost the checkouts in a list since 22.05, but we gained the
scrolling. I'm not sure if it was intentional? 

Personally, I like the list form better on mobile. Opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:21:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:21:31 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-VC6xqygFwk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:35:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:35:51 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-im0XackrFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |30344


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30344
[Bug 30344] Changing a patron from a category that allows guarantees to one
that doesn't should remove that link
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:14 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Ah2IVjkEvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #83 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138270&action=edit
Bug 30650: Add some useful modules and tests

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:34:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:34:30 +0000
Subject: [Koha-bugs] [Bug 25698] Curbside Pickup
In-Reply-To: <bug-25698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25698-70-z7evv9QaOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #17)
> Hi, I have been sponsored to integrate this plugin to Koha core, see bug
> 30650.

I think we can mark it a duplicate by now!

*** This bug has been marked as a duplicate of bug 30650 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 17:42:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 15:42:48 +0000
Subject: [Koha-bugs] [Bug 31255] New: Patron card number prefilled with "1"
 when adding a new patron
Message-ID: <bug-31255-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31255

            Bug ID: 31255
           Summary: Patron card number prefilled with "1" when adding a
                    new patron
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: madamyk at ckls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

After the upgrade to Koha 21.11, the "Add Patron" page has the card number
field prefilled with the numeral one "1".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:43:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:43:54 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-r09AcSTIJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:27:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:27:56 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-NsydTQMe9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #131 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #121)
> I've been playing with this a little whilst continuing QA.  Should there be
> a way from the OPAC to see what items are in a group when placing a group
> hold.  I suppose, the main thoughts behind this is 'the patron doesn't need
> to know' and that the group name should be descriptive enough for them to
> make an informed choice at hold time?.. or maybe I've missed a bug where
> exposing the groups more on the OPAC is done?

You've got it. This is being used in production by one of our partners, and
everything is centered around the item group description. Since items in a
group are supposed to be identical, knowing which items are in a group does not
provide any benefit outside the group name itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:29:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:29:40 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-Mo43wFijZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> ---
It works, but I don't think this is a complete solution.  It needs to warn you
that you are overwriting an existing notice or slip and give you the option to
proceed or cancel.  This is too dangerous as is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:15:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:15:06 +0000
Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
 circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29129-70-rIvFPWnlEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

--- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:32:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:32:11 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-9MdbPoNM8E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:25:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:25:51 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-geRqKjM3Sj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|stalkernoid at gmail.com       |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #70 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am writing tests for the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:55:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:55:32 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-0TdMMqWHhk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> You let the session in an unexpected state and change the code?

Ah ok the bad state comes from before the patch is applied! Thanks for clearing
that up.

Works, qa script happy, code looks good, passing QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:07:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:07:25 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-3ko2mKeyAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #71 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138296&action=edit
Bug 27272: Allow to pass params and attributes to search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:09:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:09:04 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-V6c8YgJpsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

--- Comment #3 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Emmi Takkinen from comment #1)
> We are facing this same problem. I guess one possible solution could be move
> to "Modify notice" page instead "Add notice" if notice already exists.

This wasn't the solution, but I still think we should move to "Modify notice"
page in these cases. However I was unsure if this is in scope of this bug or
should I open a separete bug report for this (if it doesn't already exists).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:19 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-eCriSzWhgC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #123 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138222&action=edit
Bug 24860: Add new syspref EnableItemGroupHolds

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:47:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:47:13 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-zGDj6jXZLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #144 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138302&action=edit
Bug 30952: Show the search catalog form by default in cat-search.inc

Issue #1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:17:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:17:52 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-H89ArO6nq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138262|0                           |1
        is obsolete|                            |

--- Comment #119 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138330&action=edit
Bug 30650: DB changes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:30 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-TCvt1qebVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138280|0                           |1
        is obsolete|                            |

--- Comment #137 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138348&action=edit
Bug 30650: Add link from the circ patron page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:15 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-NxokKyxRiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 22:12:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 20:12:20 +0000
Subject: [Koha-bugs] [Bug 28433] Improve links to EDI accounts using the
 label
In-Reply-To: <bug-28433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28433-70-O7gsPHcZxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28433

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This appears to be fixed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 23:46:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 21:46:06 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-Azz143JdrQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:08:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:08:31 +0000
Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to
 news and HTML customizations
In-Reply-To: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22659-70-WQ5xoOlRzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:30 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-CelSMsiAZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #86 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138273&action=edit
Bug 30650: Add dayjs to opac

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:56 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-Tit8txyMjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138257&action=edit
Bug 29897: Add VIAF

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:19 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-FbEczce3iY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #84 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138271&action=edit
Bug 30650: Add circulation page view

This is the main commit message.

A plugin already exists to manage curbside pickups. This new
enhancehemnt is suggesting an implementation that is ready to be integrated
into Koha core in order to provide the feature out-of-the-box.

What has been done in this patch set:
- Deal with installations using the existing plugin (upgrade the DB schema and
migrate their data)
- Add a new syspref (CurbsidePickup) and two new permissions:
  * parameters.manage_curbside_pickups
  * circulate.manage_curbside_pickups
- Add an administration page to setup the configuration:
admin/curbside_pickup.pl
- Add a circulation page to manage the existing pickups, and create new one
- Add a new OPAC view "your curbside pickups" to let patron manage their
pickups, and create new ones
- Add link from the "member" toolbar

Improvements compared to the plugin:
- Ability to create several pickup windows per day
- Better display of the pickup times (not in a dropdown list)
- Ability to disable pickups for patrons without waiting holds
- Display pickups on the patron circulation page
- Display pickups of the library on the homepage
- Prevent pickup to be created on a holiday
- Better error handling (exceptions)
- Unit tests

More improvements are already planned, see related bug reports.

Test plan:
After you setup the feature correctly from the administration view, you
will be able to use the schedule curbside pickups from the staff
interface, and from the OPAC interface if you selected "patron-scheduled
pickup"
A. Staff interface
1. Go to Circulation > Curbside pickups
=> If the logged-in user has the circulate.manage_curbside_pickups
permission you will be able to create and manage curbside pickups
2. Go to a patron detail page and click the "Schedule pickup" button in
the toolbar
3. If the patron has waiting holds and you selected "Enable for waiting holds
only",
of if you didn't select the option, you will be able to select a pickup
date and slots to create a pickup.
4. Confirm that you cannot create more pickups per slot than what you
defined in the curbside pickup configuration for this library
5. Confirm that you cannot create a pickup if the feature is disabled
for the library
6. Notice that you can mark the pickup as "stage and ready", then
"patron is outside" and finally "delivered today". You can also rollback
the change
7. Notice that once the pickup has been marked as delivered, the
item has been checked out and that a new notice has been generated (if
the patron has "Hold_Filled" in their messaging preferences
8. Confirm that the information about current pickups is displayed on
the circulation page of the patron

B. OPAC interface
1. Create a new curbside pickup from the OPAC
2. Confirm that the same limitations as from the staff interface are in
effect (waiting holds, number of patron per slots, etc.)
3. Confirm that you can cancel a pickup and alert staff of you arrival
4. Confirm that you cannot cancel a pickup that has been delivered
already

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:29:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:29:10 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-casVXOZIHi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:10:12 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-kP2MR3oCF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #113 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138323&action=edit
Bug 30650: Add the sidebar to the circ view

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:17:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:17:10 +0000
Subject: [Koha-bugs] [Bug 29129] The clear screen and print icons in
 circulation should be configuarable to print either ISSUESLIP or ISSUEQSLIP
In-Reply-To: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29129-70-Mq56Ly6B6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement expands
      release notes|                            |upon the
                   |                            |'DisplayClearScreenButton'
                   |                            |allowing the choice of
                   |                            |printing either the
                   |                            |ISSUESLIP or the ISSUEQSLIP
                   |                            |when using the
                   |                            |printclearscreen icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:34 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-gaSATbs3SF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:13:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:13:12 +0000
Subject: [Koha-bugs] [Bug 31257] New: Add a new English 1 page layout to
 export a basket as PDF
Message-ID: <bug-31257-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257

            Bug ID: 31257
           Summary: Add a new English 1 page layout to export a basket as
                    PDF
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

We would like a new layout that puts library, vendor and order information on
one page, that reads more like an invoice with a letter head.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:40 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-qZ8UFB5XRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:53:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:53:32 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-Pmh9GtiM8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138294&action=edit
Bug 30984: (QA follow-up) Switch from mediumtext to tinytext

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:32:31 +0000
Subject: [Koha-bugs] [Bug 31262] New: Curbside pickups - disable dates
 without slots
Message-ID: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

            Bug ID: 31262
           Summary: Curbside pickups - disable dates without slots
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650

We could remove from the date picker widget the dates that do not have
available slots.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:12:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:12:36 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-ZNtRoOlXjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #97 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138216&action=edit
Bug 22456: Staff interface handling

This patch introduces a new tab to the 'Holds awaiting pickup' screen
for holds that have cancellation requests. This can be accepted (by
cancelling the hold) or rejected.

To test:
1. Set circulation rules for cancellation requests, allowing them for
   certain item type.
2. Have some waiting holds for a patron on an item type that allows
   requesting cancellation.
3. Visit 'Holds awaiting pickup'
=> SUCCESS: No holds have cancellation requests
4. In the OPAC, on the user details, notice some holds have the ability
   to be requested cancellation.
5. Choose to request cancellation
=> SUCCESS: Request is placed, the button is disabled
6. In 'Holds awaiting pickup' you can see them
7. Play with rejecting/accepting
=> SUCCESS: It works!
8. Things are reflected in the OPAC side

Sponsored-by: Montgomery County Public Libraries

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:49:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:49:01 +0000
Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a
 new 'holds' table
In-Reply-To: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25260-70-HsbMxCBqRx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:25 +0000
Subject: [Koha-bugs] [Bug 30195] Suggestion form in OPAC should use ISBN to
 FindDuplicate
In-Reply-To: <bug-30195-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30195-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30195-70-4Bum3Y5QBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30195

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to the 22.05.x series unless requested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:10 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-dMhd2zSVrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #100 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:10:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:10:12 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-wfM1cwmSEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #12)
> Ok, I have the same error. Chris said it could be related to git-bz not
> working with ipv6.

Ok, we did some more testing and git-bz works on other bugs. I am not sure
what's causing the problem here, but it appears to be bug specific and so
probably not network related.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:25:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:25:20 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-aEC9ZTojIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
 Attachment #138208|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:25 +0000
Subject: [Koha-bugs] [Bug 30650] Add a Curbside Pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-hK1ypWuZw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:02:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:02:45 +0000
Subject: [Koha-bugs] [Bug 31058] Bad import in auto_unsuspend_holds
In-Reply-To: <bug-31058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31058-70-i2wn00HBri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31058

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11., 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:24 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-fwPjFJ50rx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #85 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138272&action=edit
Bug 30650: Add dayjs and isSameOfAfter plugin

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:22:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:22:23 +0000
Subject: [Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to
 ensure non-public notes do not leak
In-Reply-To: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30744-70-Cad4xMUUZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #27 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:02 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-qHnYLNwPaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #81 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138268&action=edit
Bug 30650: Adjust atomic update

Take into account existing installs using the plugins

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:18:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:18:15 +0000
Subject: [Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields
In-Reply-To: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30848-70-v3D9PBL2h4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #54 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:34:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:34:11 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-u8SWw2n1Te@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #104 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138291&action=edit
Bug 30650: Take dateformat into account

dayjs init was not passing the dateformat.
We really need to clean the date handling with the following two bugs:
  Bug 30310 - Replace Moment.js with Day.js
and
  Bug 30718 - Use flatpickr's altInput option everywhere

But it's outside the scope of this bug report.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:35 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-vPjv0WNbWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138270|0                           |1
        is obsolete|                            |

--- Comment #127 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138338&action=edit
Bug 30650: Add some useful modules and tests

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:27 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-NeB0s4jVKp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137982|0                           |1
        is obsolete|                            |

--- Comment #76 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138304&action=edit
Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:14:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:14:47 +0000
Subject: [Koha-bugs] [Bug 30978] Potential data loss when using Quick add
 new patron
In-Reply-To: <bug-30978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30978-70-wR5dK6nFKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30978

Agnes Rivers-Moore <arm at hanover.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arm at hanover.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:54:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:54:56 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-iaTHMv3qVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:17:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:17:55 +0000
Subject: [Koha-bugs] [Bug 31258] New: Accessing patron lists from patron
 accounts
Message-ID: <bug-31258-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31258

            Bug ID: 31258
           Summary: Accessing patron lists from patron accounts
 Change sponsored?: ---
           Product: Koha
           Version: 21.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Love the patron lists tool.  What would make it better???

* Being able to add a patron to multiple lists at once
* Adding patrons to list from the patron account - maybe have a modal come up
with a list of patron lists they can be added to
* Time stamping when the patron is added to the list
* If we are going to link to the lists from the patron account, maybe have a
setting in the list to set whether or not the list can be shown in the patron
account
* If the patron list can be added to from the patron account, it should not
rely on the permission that gives you access to the tool.  If we are setting
within the account that this list is visible from within the patron account,
that should be enough permission to add or remove the patron from the list, but
not give staff the ability to edit the entire list from the tool or do anything
else with it.
* The patron account modal, in showing the lists to choose from should be a
check box next to each list name, and should allow you to uncheck the list,
removing them from the list

Maybe this is a multi-phase wish list rather than a single enhancement request,
but I think this would be a good next step for this feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:13 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-uunapXRbG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138277|0                           |1
        is obsolete|                            |

--- Comment #134 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138345&action=edit
Bug 30650: DB - Add policy.enable_waiting_holds_only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:29:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:29:36 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-JmMOSLpb2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joubu,

I can't get the information to show in the OPAC :(

* Applied patch, updatatabase, restart_all*
* Activated OPACAuthorIdentifiers
* Updated authority record with 024 as such: 
  #148 Foy, Brian D. 
  $2 orcid
  $a 0000-...
  Also tried an author that is in 100 - no effect.

But I don't see the information neither in the OPAC detail view nor the OPAC
authority detail view.

Maybe I am doing it wrong? Help! :)

Some other things I noticed:

1) get_identifiers

The routine is still using $6, maybe we should remove this to avoid confusion
about its purpose.

2) Update commit message

The test plan also still mentions $6, we should probably update for
documentation writers.

3) System preference

The system preference mentions 024, but I think it would be useful to add the
valid $2 source codes, so it's easier to use.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:33 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-LAzBXaQFXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #126 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138226&action=edit
Bug 24860: Add ability to select an item group when placing a hold - OPAC

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:26 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PRvAaVBLKK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #96 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138283&action=edit
Bug 30650: Split the permission

We actually want one permission to manage the administration page, and
one for the circulation module.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 19:22:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 17:22:26 +0000
Subject: [Koha-bugs] [Bug 31248] Make checkout history table responsive for
 mobile
In-Reply-To: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31248-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31248-70-v3fz7aM8Ek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31248

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         Depends on|                            |30570
             Status|NEW                         |ASSIGNED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Caused by Bug 30570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
[Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:22:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:22:29 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-QXUnkcwViP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 23:58:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 21:58:22 +0000
Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor)
 for authority records
In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22232-70-iTkuhT8XQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

--- Comment #5 from Heather <heather_hernandez at nps.gov> ---
There is another reason this would be fantastic to have: sometimes authorities
are entered with the wrong 1XX field.  For example, the correct subject heading
is:

650 _ 0 $aAubrey, Jack (Fictitious character)

But a cataloger could think, "Hmmm...it's a name...I'll enter it:"
600 10 $aAubrey, Jack $c(Fictitious character)

And maybe even create an authority record for it off of that bib resulting in
an authority record with this:
100 10 $aAubrey, Jack $c(Fictitious character)

If you're an OCLC library, it's an easy fix--put this field into the OCLC
record:
010 _ _ $ash 92000670 
Overlay the correct authority record over the wrong local record, and, voila! 
The linked bib's 600 is corrected.

But what about ALL the non-OCLC libraries?  What about those who don't have
easy access to aut records to import?  Wouldn't it be wonderful to be able to
simple go into the aut record in an advanced editor and type over the incorrect
100 with the correct:
150 _ 0 $aAubrey, Jack (Fictitious character)

I know the priority is low.  It's a feature that appeals to a small portion of
users.  But I bet if you measured the work hours saved, it would be HUGE.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:22 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-uNMIk3dh2J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jul 28 20:21:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 18:21:42 +0000
Subject: [Koha-bugs] [Bug 24860] Add ability to place item group level holds
In-Reply-To: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24860-70-oHIcHJU0Jh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #128 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138228&action=edit
Bug 24860: Skip non-matching item group holds in HoldsQueue

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Rebecca Coert <rcoert at arlingtonva.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:08 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-8ROPZriRld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138265|0                           |1
        is obsolete|                            |

--- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138333&action=edit
Bug 30650: Add new permission manage_curbside_pickups

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 00:47:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jul 2022 22:47:30 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-XCmkqLN7T8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:21 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-AfqNCWnXVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137981|0                           |1
        is obsolete|                            |

--- Comment #75 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138303&action=edit
Bug 27272: Remove GetItemsInfo from catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:20 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-D6HHmpeNNR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #95 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138282&action=edit
Bug 30650: Prevent pickup to be created on holiday

We could improve this more and add disable the holiday from the date
picker widget, but it's out of the scope here.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 05:44:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 03:44:31 +0000
Subject: [Koha-bugs] [Bug 25560] Exclude itemtypes from
 UpdateNotForLoanStatusOnCheckin
In-Reply-To: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25560-70-NJszX0cYXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

--- Comment #61 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Just to note I have a working patchset that can use YAML defined in the
UpdateNotForLoanStatusOnCheckin syspref like so:

BK:
 -1: 0

CR: 
 -2: 0

I am currently working on how to handle existing values in the syspref so they
still apply for all itemtypes for upgrading libraries.
Any suggestions would be much appreciated on this point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:25 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-T3E2aKfbch@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:58:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:58:02 +0000
Subject: [Koha-bugs] [Bug 31268] New: Clearly indicate reason for failed
 item creation when receiving expired subscription
Message-ID: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31268

            Bug ID: 31268
           Summary: Clearly indicate reason for failed item creation when
                    receiving expired subscription
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrewfh at dubcolib.org
        QA Contact: testopia at bugs.koha-community.org

Bug 29188 points out that while the manual says one cannot receive issues in an
expired subscription, Koha is currently allowing one to do so.

However, Koha *is* refusing to create an item when receiving an issue on an
expired subscription. 

To recreate:
1 - create a subscription set to *not* create items, subscription end date in
the past
2 - save subscription, confirm it shows as expired, confirm you can receive an
issue anyway
3 - create a subscription set *to* create items, subscription end date in the
past
4- save subscription, confirm it shows as expired, confirm you can get to the
receiving page but setting the dropdown for the expected issue to "Arrived"
does not cause an item edit box to appear
5- create a subscription set *to* create items, subscription end date in the
future, number of issues set to 1
6- save subscription, receive 1 issue, confirm it works as intended
7- confirm subscription now shows a confusing "Subscription will expire on
[subscription end date]" message even though the date isn't the problem
8- Attempt to receive another issue, confirm that now the item edit box won't
pop up, as in step 4

In steps 4 and 8, the item edit box will appear if one attempts to receive a
supplemental issue, but the item will refuse to save, giving an erroneous
"missing required field" message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:11:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:11:33 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-7YcLe6uOvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #14 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Hi,

This change looks like outside of scope :

@@ -502,7 +507,8 @@ sub SendAlerts {
         }

         my $success = try {
-            $mail->send_or_die({ transport => $library->smtp_server->transport
});
+            my $smtp_server = $library ? $library->smtp_server :
Koha::SMTP::Servers->get_default;
+            $mail->send_or_die({ transport => $smtp_server->transport });
         }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:11 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-wWYzliCOIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138287|0                           |1
        is obsolete|                            |

--- Comment #144 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138355&action=edit
Bug 30650: DBIC specific

Note for QA - a false positive is raised by the QA tools:

"""
The new column curbside_pickup_opening_slots.day is using TINYINT(1) as
type but is not defined as boolean in the schema file
(Koha/Schema/Result/CurbsidePickupOpeningSlot.pm)
"""

=> It's not a boolean!

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:33 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-trPX9h7c5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138109|0                           |1
        is obsolete|                            |

--- Comment #77 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138305&action=edit
Bug 27272: Add search_ordered sub to order items with extra conditions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:40 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-etIwsBH8yV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138271|0                           |1
        is obsolete|                            |

--- Comment #128 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138339&action=edit
Bug 30650: Add circulation page view

This is the main commit message.

A plugin already exists to manage curbside pickups. This new
enhancehemnt is suggesting an implementation that is ready to be integrated
into Koha core in order to provide the feature out-of-the-box.

What has been done in this patch set:
- Deal with installations using the existing plugin (upgrade the DB schema and
migrate their data)
- Add a new syspref (CurbsidePickup) and two new permissions:
  * parameters.manage_curbside_pickups
  * circulate.manage_curbside_pickups
- Add an administration page to setup the configuration:
admin/curbside_pickup.pl
- Add a circulation page to manage the existing pickups, and create new one
- Add a new OPAC view "your curbside pickups" to let patron manage their
pickups, and create new ones
- Add link from the "member" toolbar

Improvements compared to the plugin:
- Ability to create several pickup windows per day
- Better display of the pickup times (not in a dropdown list)
- Ability to disable pickups for patrons without waiting holds
- Display pickups on the patron circulation page
- Display pickups of the library on the homepage
- Prevent pickup to be created on a holiday
- Better error handling (exceptions)
- Unit tests

More improvements are already planned, see related bug reports.

Test plan:
After you setup the feature correctly from the administration view, you
will be able to use the schedule curbside pickups from the staff
interface, and from the OPAC interface if you selected "patron-scheduled
pickup"
A. Staff interface
1. Go to Circulation > Curbside pickups
=> If the logged-in user has the circulate.manage_curbside_pickups
permission you will be able to create and manage curbside pickups
2. Go to a patron detail page and click the "Schedule pickup" button in
the toolbar
3. If the patron has waiting holds and you selected "Enable for waiting holds
only",
of if you didn't select the option, you will be able to select a pickup
date and slots to create a pickup.
4. Confirm that you cannot create more pickups per slot than what you
defined in the curbside pickup configuration for this library
5. Confirm that you cannot create a pickup if the feature is disabled
for the library
6. Notice that you can mark the pickup as "stage and ready", then
"patron is outside" and finally "delivered today". You can also rollback
the change
7. Notice that once the pickup has been marked as delivered, the
item has been checked out and that a new notice has been generated (if
the patron has "Hold_Filled" in their messaging preferences
8. Confirm that the information about current pickups is displayed on
the circulation page of the patron

B. OPAC interface
1. Create a new curbside pickup from the OPAC
2. Confirm that the same limitations as from the staff interface are in
effect (waiting holds, number of patron per slots, etc.)
3. Confirm that you can cancel a pickup and alert staff of you arrival
4. Confirm that you cannot cancel a pickup that has been delivered
already

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:48:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:48:28 +0000
Subject: [Koha-bugs] [Bug 29188] Expired serial subscriptions can still
 receive issues
In-Reply-To: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29188-70-fRkbPgmjvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
However, it appears expired subscriptions cannot create items (and don't give
any clear explanation of why the idea will not be created).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:21:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:21:22 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-v1FTJd52YO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr
                   |ity.org                     |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Frederic, please don't forget to assign yourself!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:18:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:18:12 +0000
Subject: [Koha-bugs] [Bug 31267] New: Error 500 in stage-marc-import
Message-ID: <bug-31267-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31267

            Bug ID: 31267
           Summary: Error 500 in stage-marc-import
 Change sponsored?: ---
           Product: Koha
           Version: 22.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gveranis at dataly.gr
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When trying to visit Tools-> Export data or Tools -> Stage Marc records for
import 
as superuser ( or anyother type of user ) display 500 error and on logs shows
Auth ERROR: Cannot get_session() line 1009

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:59 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PjAU991jLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138285|0                           |1
        is obsolete|                            |

--- Comment #142 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138353&action=edit
Bug 30650: Prevent browser crash if no pickup interval set

Don't get stuck in an infinite loop

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:38:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:38:07 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-Ojg2AGhwL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:59:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:59:11 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-GGVRa79Y6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:00:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:00:08 +0000
Subject: [Koha-bugs] [Bug 29188] Expired serial subscriptions can still
 receive issues
In-Reply-To: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29188-70-udD7rpsT6U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188

--- Comment #2 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Filed bug 31268 for the issue I described with item creation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:13:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:13:15 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-NCyWpPLkz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #22 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Michael Hafen from comment #18)
> though I like the commit message of the other commit better, but
> if you can't change the commit message, then that's ok.

Ok I changed to "Bug 28864: Have patron card creator use PatronsPerPage"
and added test plan from Comment 15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:56:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:56:06 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-aU2zG70J7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #101 from Christofer Zorn <christofer.zorn at ajaxlibrary.ca> ---
Thank you everyone for your hard work on this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:10:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:10:25 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LJBRlwnFgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #115 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138325&action=edit
Bug 30650: Add message on the admin page if the pref is off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:45 +0000
Subject: [Koha-bugs] [Bug 30936] Reindent authority detail template in staff
 interface
In-Reply-To: <bug-30936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30936-70-gUXtcbgL7U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30936

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:05:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:05:10 +0000
Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another branch if it
 already exists
In-Reply-To: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24616-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24616-70-hpS4nDmjdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616

Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
Created attachment 138242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138242&action=edit
Bug 24616: Allow copying notice to a branch even if it exists in that branch

If you try to copy notice or slip to a branch which already
has that notice or slip Koha won't let you save it. Instead
pop-up saying branch already has that notice is displayed.

This patch allows users to copy and override already existing
notice or slip.

To test:
1. Find notice which exists e.g. in all branches and branch A.
2. Copy that notice, add notice screen is displayed.
3. Press save.
=> Pop-up informing that notice already exists in branch A
is displayed.
4. Apply this patch.
5. Repeat steps 2. and 3.
=> Notice is saved succesfully.

Also try to save the notice you tested with as a new (same code)
to branch A. Confirm that pop-up is displayed as it should be.

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:52 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-VRFzq3pXig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #90 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138277&action=edit
Bug 30650: DB - Add policy.enable_waiting_holds_only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:27 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-08Joyekaqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138290|0                           |1
        is obsolete|                            |

--- Comment #147 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138358&action=edit
Bug 30650: Add dayjs customParseFormat plugin

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:59:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:59:30 +0000
Subject: [Koha-bugs] [Bug 31268] Clearly indicate reason for failed item
 creation when receiving expired subscription
In-Reply-To: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31268-70-UZnWpUbLAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31268

--- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
Obviously this bug will be moot if 29188 gets resolved in such a way that one
can't get this far into receipt on an expired subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:29:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:29:48 +0000
Subject: [Koha-bugs] [Bug 26440] Not renewable Supersedes On Hold
In-Reply-To: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26440-70-0T6785wx05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26440

--- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> ---
Is patch ready for signoff ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:41:09 +0000
Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders
In-Reply-To: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20119-70-2xkghBDgq8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18796

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:14:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:14:21 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-SFXIMf6t1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Agnes Rivers-Moore <arm at hanover.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arm at hanover.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:38:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:38:31 +0000
Subject: [Koha-bugs] [Bug 27849] Koha::Token may access undefined
 C4::Context->userenv
In-Reply-To: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27849-70-OtX8kTDm0y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:24 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-pMFKekfBOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138279|0                           |1
        is obsolete|                            |

--- Comment #136 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138347&action=edit
Bug 30650: Add link from the mainpage

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:08:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:08:41 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-R6kraPX3bH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

--- Comment #73 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:35 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-0pPeHDjN5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138281|0                           |1
        is obsolete|                            |

--- Comment #138 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138349&action=edit
Bug 30650: Add filter_by_scheduled_today

A bit of cleaning

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:10:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:10:51 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-rOYg9UKDtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:17:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:17:14 +0000
Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on
 serial-level
In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18745-70-mbrM2GYCUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

--- Comment #22 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #21)
> error: sha1 information is lacking or useless
> (installer/data/mysql/kohastructure.sql).
> 
> You shouldn't need to reorder kohastructure.sql

Indeed patch "kohastructure.sql: Move aqbooksellers above serial" is obsolete,
aqbooksellers is above serial because tables are alphabetical now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:41:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:41:09 +0000
Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
In-Reply-To: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18796-70-KaVU4m3q3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

Fridolin Somers <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20119

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:32 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-Et7UeLeNdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138252&action=edit
Bug 29897: Display author's identifiers

This new enhancement add the capability to list the different
identifiers of authors. It is helpful for research publications for
instance.

This patch will add a new "Author identifiers" tab on the detail page
(OPAC) of a bibliographic record, with the list of the authors and their
identifiers.
On the detail page of the authority record, the same identifier list
will be displayed.

Test plan:
Create some authority with
024
  $a source
  $2 number
  $6 link to the source
With the pref turned ON you will be able to see the new information.

Sponsored-by: Orex Digital

Signed-off-by: Orex Digital <info at orex.es>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:24:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:24:48 +0000
Subject: [Koha-bugs] [Bug 30865] Koha::Biblio->get_components_query should
 double quote Host-item search
In-Reply-To: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30865-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30865-70-aVj2e1xGUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30865

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:14:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:14:38 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-orDU1lq6Ai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - 5dd5449223

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:02 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-RXvA1jXNgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138264|0                           |1
        is obsolete|                            |

--- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138332&action=edit
Bug 30650: Add the CurbsidePickup syspref

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:32:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:32:33 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-bqZmKztsZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #217 from Lucas Gass <lucas at bywatersolutions.com> ---
Nice new feature but it will not be backported to 22.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:13:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:13:59 +0000
Subject: [Koha-bugs] [Bug 30609] Reindent serial claims template
In-Reply-To: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30609-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30609-70-mRdc5YgcxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30609

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:35:42 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-975sJKnsgE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #106 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
There was a typo 'Cubside' in the exception name, and on the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:10:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:10:48 +0000
Subject: [Koha-bugs] [Bug 30389] Switch to Bootstrap tabs on the page for
 adding orders from MARC file
In-Reply-To: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30389-70-M2EGWT1QAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30389

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:39:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:39:36 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-xh1e1oPNwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #159 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 138375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138375&action=edit
Bug 30650: (QA follow-up) Some higher-level methods usage

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:36:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:36:01 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-rfzzrzOenZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138373|0                           |1
        is obsolete|                            |

--- Comment #5 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 138374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138374&action=edit
Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts

Keyboard shortcuts for catalog search, check in and renew should be following:
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:07:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:07:41 +0000
Subject: [Koha-bugs] [Bug 30269] Use objects directly to display holds on
 request.pl
In-Reply-To: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30269-70-8U2aS031aR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30269

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org
             Status|Needs Signoff               |Failed QA

--- Comment #13 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
With this patch applied on a sandbox, I am not able to open request.pl for a
bib with holds on it. I get the following error:
"Template process failed: undef error - The method Koha::Hold->date is not
covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875"

After a bunch of error output, it goes on to say:
"in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 127"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:09 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-NrfmQUQAIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #93 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138280&action=edit
Bug 30650: Add link from the circ patron page

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:34:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:34:05 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-PaEvxhrgwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #103 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138290&action=edit
Bug 30650: Add dayjs customParseFormat plugin

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:19 +0000
Subject: [Koha-bugs] [Bug 30308] bulkmarcimport.pl broken by
 OAI-PMH:AutoUpdateSets(EmbedItemData)
In-Reply-To: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30308-70-Rl8lm624lD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30308

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:43:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:43:38 +0000
Subject: [Koha-bugs] [Bug 31053] Add Context module to Koha/Encryption
In-Reply-To: <bug-31053-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31053-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31053-70-ggGOrw45LM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31053

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:13:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:13:13 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-g0wWZ7biFw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #116 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #107)

Thanks a lot, Katrin, for you great QA session :)

> o) Tests are failing, but possibly just a typo/later change causing it:
> 
>     #   Failed test 'Notice correctly generated'
>     #   at t/db_dependent/Koha/CurbsidePickups.t line 299.
>     #          got: 'You have schedule a curbside pickup for Te9oDc'
>     #     expected: 'You have schedule a curbside pickup for Te9oDc.'
>     # Looks like you failed 1 test of 2.
> 
> 
> Other finds from code review:
> 
> 1) Tiny typos
> 
> * Curbside pickups are not enabled for your location. = library
> * Pickup Date/Time = capitalization
> * ... it is an holiday = it is a holiday. (multiple)
> * Deliver Date/Time = capitalization
> * There is no waiting holds for this patron at this location. = There are
> no... at this library
> * No pickup time define for this day. = defined (multiple)
> * You don't have waiting holds at this location = library

Done in patch "Fix some typos"

> 2) New JS libraries
> 
> There are no license statements for these, as we only add the minified
> version:
> 
> dayjs.min.js
> isSameOrAfter.js
> customParseFormat.js
> 
> Should they be listed on the about page?

Yes, done in "Add dayjs license to the about page"

(In reply to Katrin Fischer from comment #108)
> From testing in the GUI:
> 
> 3) Curbside pickup configuration
> 
> The trashcan icon behind the times is missing a space before it. It also
> doesn't have an alt text/tool tip when hovering.

Done in "Add info to the trash icon"

> 4) Circulation start page
> 
> a) With CircSidebar enabled, the curbside pickup entry is missing from the
> sidebar.

Done in "Add link to the circ nav bar"

> b) Also the curbside configuration page doesn't show the sidebar.

"Add the sidebar to the circ view"

> c) Capitalization: Curbside Pickup = Curbside pickup

Done in "Fix some typos"

> 5) Schedule pickup
> 
> a) When scheduling a pickup the calendar widget shows future days greyed out
> and allows to select dates in the past. (blocker)

I don't recreate that. All dates can be selected using the widget, but dates in
the past won't display slots.
This is the correct behaviour. We could improve and "disable" dates in the past
or even dates without slots, but that's for another bug report.

Opened bug 31261 and bug 31262.

> b) The button remains greyed out until you pick a date with pickup times
> available. I think a tool tip would be very helpful here. (not blocker)

I think I understand what you mean: you have to remove the focus from the
widget to be able to select a slot.
I've tried to fix it already but didn't manage to find a correct solution.

> 5) New notice NEW_CURBSIDE_PICKUP
> 
> a) Tiny typo: You have schedule a curbside pickup for [% branch.branchname
> %] => ... scheduled (normal)

Fixed earlier.

> b) Can we break the content text into 3 entries in the .yml file for new
> installations (one per sentence) to ease translation a bit? (normal)

"Split yml on several lines to help translation"

> 6) Koha start page
> 
> a) The start page for new pickups reads: New curbside pickups 1. We should
> add a : here: 
> New curbside pickups: 1 
> This makes it also more consistent with the other entries (looked at
> suggestions and patron modifications). (trivial)

"Fix some typos"

> 7) OPAC view
> 
> As this is the patron side of things, I worry more about that than about
> other stuff. I have some issues here:
> 
> a) The alert link will only be functional, when the pickup has been "staged
> & ready". But there is no clue in the GUI about this and the patron might be
> in front of the library without being able to see what's going on.

I would like this to be discussed on a separate bug report, it was the previous
(plugin) behaviour.
See bug 31263.

> b) Once the pickup has been "marked as delivered" it still remains in the
> list with no clue that it has been picked up already. It would be nicer to
> display, that it's already been delivered. Note: only today's and future
> pickups will show in the list.
> 
> Maybe this could be a separate bug as well to get some feedback, but it
> feels like we should give the patrons more information there.

What do you suggest? Do you want a separate column to display the status?

> X) Possible enhancements
> 
> These are supposed to go into new wish list bugs. But maybe you could look
> through them quickly to check if I have missed/misunderstood something?
> 
> a) Curbside pickup configuration page: The weekday pull down and display
> should follow the CalendarFirstDayofWeek system preference.

Why do we accept all the day of the week in this syspref?!
It should, indeed, but not trivial. Opening a separate bug and not sure it will
be fixed. That seems a lot of work for not much to gain. Maybe first keeping
only Monday, Saturday and Sunday...

...ha ... bug 12137 comment 16...

Opened bug 31264!

> b) Show a note on top of the Curbside pickup configuration page, if the
> Curbside pickup module is not enabled (similar to what we do for the
> Transport cost matrix administration page)

Done in "Add message on the admin page if the pref is off"

> c) Improve GUI for pickup up pickup times in staff interface: The times are
> a little hard to select/hard to read. I think it would be nice to make this
> look more like in the OPAC. 

Opened a separate bug, I would like to ask Owen his opinion what's best here.
We could improve both I think.
The plugin was displaying the list in a dropdown list, so it's already a nice
improvement how it is now ;)

Opened bug 31265 for discussion.

> d) Scheduling a pickup from the curbside pickups page only will only work
> with the cardnumber. It would be nicer to use the standard patron search for
> this.

Bug 30965 is waiting for you PQA stamp :)

> e) Add logging for curbside pickup location actions

Can you open a bug report with the detail of what you have in mind exactly?

> f) Have different permission descriptions (might require to change the
> permission code) to make it clearer what the difference between each of the
> permissions is.

Is that blocker? :D
If not done here it won't be done. On the other hand I don't see how it could
be a problem (the module code is different).

> h) Make curbside pickup confirmation its own messaging preference or adapt
> messaging preference description to include curbside pickups when the pref
> is enabled.

Yes, that is definitely something we should do. I've copied the plugin's
behaviour but it's not obvious.
Opened bug 31266.

We will need to prioritize what we want first :)

I will pick the related bugs with the highest number of votes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:51 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-PM5XElQKDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138256&action=edit
Bug 29897: Improve syspref's description

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:31 +0000
Subject: [Koha-bugs] [Bug 31238] Unable to save authorised value to
 frameworks subfields
In-Reply-To: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31238-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31238-70-s9UEXkjwnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31238

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 07:38:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 05:38:16 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-7a6LzlOnGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

--- Comment #2 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
I'm having trouble applying this patch. Using git bz I get:

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2716, in <module>
    applied = do_apply(bug_ref)
  File "/usr/local/bin/git-bz", line 1827, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
  File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
    response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi:
404 Not Found>

Applying manually doesn't work either:

>Patch format detection failed.

It seems patch is missing metadata header (stuff containing e.g. information
when patch was made and by whom) from the begining of it. Could you provide
patch again?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:18:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:18:45 +0000
Subject: [Koha-bugs] [Bug 31267] Error 500 in stage-marc-import
In-Reply-To: <bug-31267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31267-70-Qo2wofwqJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31267

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 09:55:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 07:55:12 +0000
Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator
 patron search
In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28726-70-OB8lEQTsFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, I have the same error. Chris said it could be related to git-bz not working
with ipv6.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:51 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-htk5WzZZtX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138315&action=edit
Bug 23919: Add tests for Items search by ISBN and ISSN with variations

(sysprefs SearchWithISBNVariations/SearchWithISSNVariations)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:39:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:39:17 +0000
Subject: [Koha-bugs] [Bug 30327] Sort component parts
In-Reply-To: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30327-70-QfR9MErsPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00. 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #43 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:25:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:25:23 +0000
Subject: [Koha-bugs] [Bug 30991] [% ELSE %]0[% END %] will break
 translations if used for assigning variables
In-Reply-To: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30991-70-aHPhqD9gVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30991

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:23:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:23:40 +0000
Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23919-70-Q2cx3QA8az@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138312&action=edit
Bug 23919: Zebra search by ISSN variations

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:42:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:42:01 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-sktOMBIq31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #137 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138245&action=edit
Bug 30952: (follow-up) Undo change to Home breadcrumb

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:27:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:27:53 +0000
Subject: [Koha-bugs] [Bug 31253] Item search in staff interface should call
 barcodedecode if the search index is a barcode
In-Reply-To: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31253-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31253-70-Qz2LWtdaXb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31253

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 08:41:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 06:41:59 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-pjRhLAegcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 138243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138243&action=edit
Bug 30984: Action logs should log the cronjob script name that generated the
given log

When something is changed by a cronjob, and that entity is logged via action
logs, we can know what changed, and that it was via a cronjob, but we cannot
necessarily know which cronjob made that change. The closest we can come is to
find the action logs for the cronjob module which ran before the change which
is by no means reliable assuming the CronLog is even enabled.

We should add a new column to action logs to store the name of the script ran
for any action logs where the interface is "cron".

Test plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable all the Log/Logging sysprefs
4) Run some cronjobs that will generate action logs
5) Note the new action_logs column "script" contains the filename of the
   cronjob that caused the change.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:37 +0000
Subject: [Koha-bugs] [Bug 31247] Staff interface 2FA blocks logging into the
 OPAC
In-Reply-To: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31247-70-9Wv9V06uBH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31247

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:07:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:07:48 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-UaLT2XqSah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31266


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266
[Bug 31266] Curbside pickups - New messaging preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:05 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-GnDaaGmVhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138286|0                           |1
        is obsolete|                            |

--- Comment #143 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138354&action=edit
Bug 30650: DBIC

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:51 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-RgXHjACbJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138273|0                           |1
        is obsolete|                            |

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138341&action=edit
Bug 30650: Add dayjs to opac

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:39:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:39:51 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-RharqVgPAZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #141 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138293&action=edit
Bug 30952: Fix "rows" forms

Issue #7

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:32:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:32:31 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-rkRhqgdwZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31262


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262
[Bug 31262] Curbside pickups - disable dates without slots
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:07:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:07:37 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-v6oBlMtFlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #73 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138298&action=edit
Bug 27272: Call search_ordered when GetItemsInfo was called before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:53 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-TSIbHtYGKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138284|0                           |1
        is obsolete|                            |

--- Comment #141 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138352&action=edit
Bug 30650: Select 'schedule a pickup' if no pickups yet

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 15:50:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 13:50:26 +0000
Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned
 fields/subfields
In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30975-70-gWIuB1mCT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:41:17 +0000
Subject: [Koha-bugs] [Bug 31263] New: Curbside pickups - Should the patron
 be able to alert even if not staged
Message-ID: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

            Bug ID: 31263
           Summary: Curbside pickups - Should the patron be able to alert
                    even if not staged
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650

The patron can alert staff of their arrival only if the pickup is "staged and
ready". Is that the expected behaviour? Do we want them to be able to alert
even if it's still not ready yet? Do we need a syspref (or per library, in the
admin) to control that?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:32:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:32:08 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-TSWZJSC7nO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #82 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138269&action=edit
Bug 30650: Be more flexible with opening slots

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:15 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-dBEijcplGy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #94 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138281&action=edit
Bug 30650: Add filter_by_scheduled_today

A bit of cleaning

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:29 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-XinWIP5eUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138269|0                           |1
        is obsolete|                            |

--- Comment #126 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138337&action=edit
Bug 30650: Be more flexible with opening slots

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-EGbhCS45Ss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138325|0                           |1
        is obsolete|                            |

--- Comment #156 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138367&action=edit
Bug 30650: Add message on the admin page if the pref is off

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:29:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:29:53 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-uFNaH2MSiG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #62 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138371&action=edit
Bug 29897: Remove 'linkage' leftover

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:08:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:08:37 +0000
Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired
 waiting holds to fill the next hold
In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14364-70-R4zMoYcEh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |22.11.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:08 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-g6BCJlClHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138276|0                           |1
        is obsolete|                            |

--- Comment #133 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138344&action=edit
Bug 30650: Notify the patron when a new curbside pickup is created

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:31:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:31:38 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-9HRaZHCVie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new enhancement add
      release notes|                            |the capability to list the
                   |                            |different identifiers of
                   |                            |authors. It is helpful for
                   |                            |research publications for
                   |                            |instance.
                   |                            |It will add a new
                   |                            |"Author identifiers" tab on
                   |                            |the detail page (OPAC) of a
                   |                            |bibliographic record, with
                   |                            |the list of the authors and
                   |                            |their identifiers.
                   |                            |On the
                   |                            |detail page of the
                   |                            |authority record, the same
                   |                            |identifier list will be
                   |                            |displayed.
                   |                            |The authority
                   |                            |must have a 024$a (source)
                   |                            |and 024$2 (number).
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:29:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:29:58 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-aaFF5PKZ2x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #63 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138372&action=edit
Bug 29897: Adjust syspref description

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:43:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:43:14 +0000
Subject: [Koha-bugs] [Bug 20630] An attempt at multitenancy with Mojolicious
In-Reply-To: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20630-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20630-70-uVtN9bMJ0i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20630

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:41:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:41:17 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-cHc7d2upsq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31263


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263
[Bug 31263] Curbside pickups - Should the patron be able to alert even if not
staged
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:32:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:32:08 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-wL4uJbR1xZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #143 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 138300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138300&action=edit
Bug 30952: Fix the 'keep_text' feature of the search bar

Text in one form should be copied in other forms when switching tab

Issue #2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 10:52:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 08:52:09 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-i9XUUxbi5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 01:44:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 23:44:13 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-KWfvDAzMgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 138380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138380&action=edit
Bug 31269: Define sDefaultContent for DataTables

1. Stage a MARC record for import
2. Once you have one click on 'Manage staged records'
3. You will see an alert that says "Something went wrong when loading the
table."
4. If you dismiss that you should see the following error:

DataTables warning: table id=records-table - Requested unknown parameter '' for
row 0, column 4. For more information about this error, please see
http://datatables.net/tn/4

5. Appy patch
6. Try ssteps 1 & 2 again
7. No DataTable errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:31:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:31:23 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-h1InZhMx2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137277|0                           |1
        is obsolete|                            |
 Attachment #137278|0                           |1
        is obsolete|                            |
 Attachment #137279|0                           |1
        is obsolete|                            |
 Attachment #137280|0                           |1
        is obsolete|                            |
 Attachment #137281|0                           |1
        is obsolete|                            |
 Attachment #137282|0                           |1
        is obsolete|                            |
 Attachment #137283|0                           |1
        is obsolete|                            |
 Attachment #137284|0                           |1
        is obsolete|                            |
 Attachment #137285|0                           |1
        is obsolete|                            |
 Attachment #137286|0                           |1
        is obsolete|                            |
 Attachment #137287|0                           |1
        is obsolete|                            |
 Attachment #137288|0                           |1
        is obsolete|                            |
 Attachment #137289|0                           |1
        is obsolete|                            |
 Attachment #137290|0                           |1
        is obsolete|                            |
 Attachment #137291|0                           |1
        is obsolete|                            |
 Attachment #137292|0                           |1
        is obsolete|                            |
 Attachment #137293|0                           |1
        is obsolete|                            |
 Attachment #137294|0                           |1
        is obsolete|                            |
 Attachment #137295|0                           |1
        is obsolete|                            |
 Attachment #137296|0                           |1
        is obsolete|                            |
 Attachment #137297|0                           |1
        is obsolete|                            |
 Attachment #137298|0                           |1
        is obsolete|                            |
 Attachment #137299|0                           |1
        is obsolete|                            |
 Attachment #137300|0                           |1
        is obsolete|                            |
 Attachment #137301|0                           |1
        is obsolete|                            |
 Attachment #137302|0                           |1
        is obsolete|                            |
 Attachment #137303|0                           |1
        is obsolete|                            |
 Attachment #137304|0                           |1
        is obsolete|                            |
 Attachment #137305|0                           |1
        is obsolete|                            |
 Attachment #137306|0                           |1
        is obsolete|                            |
 Attachment #137307|0                           |1
        is obsolete|                            |
 Attachment #138261|0                           |1
        is obsolete|                            |

--- Comment #75 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138262&action=edit
Bug 30650: DB changes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:52:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:52:09 +0000
Subject: [Koha-bugs] [Bug 26486] Group edit buttons in reports toolbar
In-Reply-To: <bug-26486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26486-70-0Bja6ciLV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26486

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:12:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:12:32 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-Sjyp5feOsW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138197|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:20:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:20:30 +0000
Subject: [Koha-bugs] [Bug 30918] Non-public note is visible in OPAC in Title
 Notes tab
In-Reply-To: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30918-70-XXxu2axYXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30918

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:14:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:14:15 +0000
Subject: [Koha-bugs] [Bug 31013] Reserved words as branchcodes cause search
 error in Elasticsearch
In-Reply-To: <bug-31013-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31013-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31013-70-r4H3iPvVCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31013

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:25:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:25:56 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-YyEqLwmm2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

--- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #60)
> Hi Joubu,
> 
> I can't get the information to show in the OPAC :(
> 
> * Applied patch, updatatabase, restart_all*
> * Activated OPACAuthorIdentifiers
> * Updated authority record with 024 as such: 
>   #148 Foy, Brian D. 
>   $2 orcid
>   $a 0000-...
>   Also tried an author that is in 100 - no effect.
> 
> But I don't see the information neither in the OPAC detail view nor the OPAC
> authority detail view.

I've tried exactly that and it's working for me.

https://snipboard.io/x8hZQ4.jpg

https://snipboard.io/iJGvN3.jpg

https://snipboard.io/hBTurb.jpg

> Maybe I am doing it wrong? Help! :)
> 
> Some other things I noticed:
> 
> 1) get_identifiers
> 
> The routine is still using $6, maybe we should remove this to avoid
> confusion about its purpose.

How do we add a link to the external resources?

> 2) Update commit message
> 
> The test plan also still mentions $6, we should probably update for
> documentation writers.

Will do.

> 3) System preference
> 
> The system preference mentions 024, but I think it would be useful to add
> the valid $2 source codes, so it's easier to use.

Will do.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:02:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:02:26 +0000
Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection
In-Reply-To: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31265-70-Z1n6wcrkgL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:39 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-Pw7FrKX9T4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138296|0                           |1
        is obsolete|                            |

--- Comment #78 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138306&action=edit
Bug 27272: Allow to pass params and attributes to search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:58:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:58:35 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-YTQphBY2no@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136076|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138377&action=edit
Bug 30624: Add select_loggedin_library permission

To test:
1. Apply patch, updatedatabase, restart_all
2. Have a user with superlibrarian privileges ( User1 )
3. Have a user who has staff access and circulate privileges but is not a super
librarian. ( User2 ) Make note of this users home library
4. Turn on the system preference 'CircSidebar'.

-MAIN log in ( auth.tt )
5. As User1, go to the main login screen and try logging in. You should be able
to log in AND you should be able to properly chnage your branch BEFORE logging
in.
6. As User2, to to the main login screnn amd try logging in. You should be able
to but if you try and switch your libraray to anything beside the user's home
branch it will not work. You will be logged in at your home branch.
7. For User2, set the new permission 'select_loggedin_library' on.
8. Now you should be able to successfully switch libraries before log in.
9. Turn the 'select_loggedin_library' back off for User2.

-AFTER log in-
10. With User1, click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
11. With User2, click on your name/branch in the top right. If you have
'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see
nothing.
12. Repeat step 7.
13. NOw if you click on your name/branch in the top right, you should see the
the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the
link will be 'Set library and desk'.
14. Repeat Step 9.

-CircSideBar-
15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds
to pull, Holds awaiting pickup) with User1. You will see the 'Set library'
link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'.
16. Try with User2 and you will not see a 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set desk' link.
17. Repeat step 7.
18. For with User2 you go to any ciculation page (Holds queue, Holds to pull,
Holds awaiting pickup). You will see the 'Set library' link. If
'UseCirculationDesks' is on you will see a 'Set library and desk'.
19. Repeat step 9.

-Set library page-
20. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will
see a dropdown for 'Set library'. Make sure you can change your library
successfully.
21. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should
NOT see see a dropdown for 'Set library'.
22. Repeat step 7.
23. Go to the set library page
(http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you
should see a dropdown for 'Set library'.

Signed-off-by: Andrew <andrewfh at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 12:00:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 10:00:48 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-KOJ5rwDpjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #107 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
o) Tests are failing, but possibly just a typo/later change causing it:

    #   Failed test 'Notice correctly generated'
    #   at t/db_dependent/Koha/CurbsidePickups.t line 299.
    #          got: 'You have schedule a curbside pickup for Te9oDc'
    #     expected: 'You have schedule a curbside pickup for Te9oDc.'
    # Looks like you failed 1 test of 2.


Other finds from code review:

1) Tiny typos

* Curbside pickups are not enabled for your location. = library
* Pickup Date/Time = capitalization
* ... it is an holiday = it is a holiday. (multiple)
* Deliver Date/Time = capitalization
* There is no waiting holds for this patron at this location. = There are no...
at this library
* No pickup time define for this day. = defined (multiple)
* You don't have waiting holds at this location = library

2) New JS libraries

There are no license statements for these, as we only add the minified version:

dayjs.min.js
isSameOrAfter.js
customParseFormat.js

Should they be listed on the about page?

Please check!

I'll keep testing on GUI side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:03:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:03:00 +0000
Subject: [Koha-bugs] [Bug 30984] Action logs should log the cronjob script
 name that generated the given log
In-Reply-To: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30984-70-drcuFz3BjL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30984

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138294|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 138295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138295&action=edit
Bug 30984: (QA follow-up) Switch from mediumtext to varchar(255)

My research indeicates that tinytext of less than 40 bytes uses
about the same storage as a varchar(255). Also, using
a TEXT field in a complex query may create a temp table.
varchar fields are also more efficient for sorting on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 11:33:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 09:33:42 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-mFS0cKVzGt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #99 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138286&action=edit
Bug 30650: DBIC

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:37:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:37:45 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24239-70-xWC6jUhc2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:31:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:31:17 +0000
Subject: [Koha-bugs] [Bug 31261] New: Curbside pickups - remove dates in the
 past
Message-ID: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

            Bug ID: 31261
           Summary: Curbside pickups - remove dates in the past
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650

We are displaying all the dates from the date picker widget, we should display
future dates only.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:21:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:21:07 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-CV1URmnkE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138323|0                           |1
        is obsolete|                            |

--- Comment #154 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138365&action=edit
Bug 30650: Add the sidebar to the circ view

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 16:51:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 14:51:05 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-4aiZ98o27P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31264


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264
[Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring
curbside pickups
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:37:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:37:41 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-ElbPSAolV4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138374|0                           |1
        is obsolete|                            |

--- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138376&action=edit
Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts

Keyboard shortcuts for catalog search, check in and renew should be following:
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

Signed-off-by: Andrew <andrewfh at dubcolib.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:27:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:27:48 +0000
Subject: [Koha-bugs] [Bug 30994] Typo: item was on loan. couldn't be
 returned.
In-Reply-To: <bug-30994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30994-70-Wm0I2ZnbkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30994

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:17:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:17:46 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-KoT5WhzZns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 14:18:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 12:18:08 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-5veWs6KrQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:55:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:55:53 +0000
Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23991-70-3SsWEfFNfQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please don't backport until the depending bug 31158 has been resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:17:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:17:57 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-AAHOonRmIz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138263|0                           |1
        is obsolete|                            |

--- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138331&action=edit
Bug 30650: Koha classes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:19 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-dEi3uFiBhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138278|0                           |1
        is obsolete|                            |

--- Comment #135 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138346&action=edit
Bug 30650: Allow to restrict curbside pickup for waiting holds only

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:13 +0000
Subject: [Koha-bugs] [Bug 29012] Some rules are not saved when left blank
 while editing a 'rule' line in smart-rules.pl
In-Reply-To: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29012-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29012-70-6HqejuFDAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:22:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:22:43 +0000
Subject: [Koha-bugs] [Bug 29282] Show items.issue and items.renewals in the
 holdings table on the detail page in the staff interface
In-Reply-To: <bug-29282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29282-70-Pzl3L2csJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

--- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancment will not be backported to 22.05.x series unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 13:53:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 11:53:45 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-16eJjDY40h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138297|0                           |1
        is obsolete|                            |

--- Comment #79 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138307&action=edit
Bug 27272: Add tests for search_ordered

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:49:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:49:17 +0000
Subject: [Koha-bugs] [Bug 30650] Add a Curbside Pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-WhIvDkSfUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual,
                   |                            |release-notes-needed
                 CC|                            |tomascohen at gmail.com
            Summary|Convert the Curbside Pickup |Add a Curbside Pickup
                   |plugin to Koha core         |module

--- Comment #160 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Great job, Jonathan.

- We could use some more unit tests
- Some of this could've been squashed, specially the typos, etc.
- ^^ I don't care much about the above, this is great

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 01:44:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 23:44:10 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-Yk5HvAS0bM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:54:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:54:05 +0000
Subject: [Koha-bugs] [Bug 30775] 952w should have datepicker plugin enabled
 for it by default
In-Reply-To: <bug-30775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30775-70-ZeE2xb7PtL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:02:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:02:19 +0000
Subject: [Koha-bugs] [Bug 31265] New: Curbside pickups - improve slots
 selection
Message-ID: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

            Bug ID: 31265
           Summary: Curbside pickups - improve slots selection
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650

We should improve the slots selection. Is what is done at the OPAC enough?

Staff: https://snipboard.io/qikxl3.jpg
OPAC : https://snipboard.io/hULe5D.jpg


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 01:18:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 23:18:43 +0000
Subject: [Koha-bugs] [Bug 22232] Use Advanced cataloguing editor (Rancor)
 for authority records
In-Reply-To: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22232-70-LorTU9fQe4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22232

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 19:12:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 17:12:59 +0000
Subject: [Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info
 in logs
In-Reply-To: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30889-70-xK2Ns324hm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |

--- Comment #46 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:19:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:19:46 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LeqQHFmPij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138283|0                           |1
        is obsolete|                            |

--- Comment #140 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138351&action=edit
Bug 30650: Split the permission

We actually want one permission to manage the administration page, and
one for the circulation module.

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:16 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-WnJwt9QeTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138288|0                           |1
        is obsolete|                            |

--- Comment #145 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138356&action=edit
Bug 30650: Display holds waiting at the logged-in library

Not those waiting at the library of the logged-in user

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:58:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:58:11 +0000
Subject: [Koha-bugs] [Bug 31268] Clearly indicate reason for failed item
 creation when receiving expired subscription
In-Reply-To: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31268-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31268-70-FotJJ7GwBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31268

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29188

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:18:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:18:23 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-zyM9JQNgBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138268|0                           |1
        is obsolete|                            |

--- Comment #125 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138336&action=edit
Bug 30650: Adjust atomic update

Take into account existing installs using the plugins

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:54:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:54:54 +0000
Subject: [Koha-bugs] [Bug 30937] Add a detail view for libraries
In-Reply-To: <bug-30937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30937-70-NtZjdxuZIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30937

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Needs documenting

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series, unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:27:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:27:41 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-jyytKlpu7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Emmanuel Bétemps <e.betemps at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |e.betemps at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:26:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:26:54 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-zSajYMEod6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

--- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> ---
I got the following error trying to apply this to a sandbox. I'm wondering if
maybe it's to do with two copies of the same patch being active here? I just
marked one obsolete to see if that helps, waiting on a new sandbox.

Bug 30499 - Keyboard shortcuts broken on several pages

138208 - Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts
138374 - Bug 30499: Move the include for catalogue-search-box.inc in
circ-search.inc to correct keyboard shortcuts

Apply? [(y)es, (n)o, (i)nteractive] Traceback (most recent call last):
  File "/usr/bin/git-bz", line 2716, in <module>
    applied = do_apply(bug_ref)
  File "/usr/bin/git-bz", line 1827, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
  File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
    response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi:
404 Not Found>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:07:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:07:48 +0000
Subject: [Koha-bugs] [Bug 31266] New: Curbside pickups - New messaging
 preference
Message-ID: <bug-31266-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266

            Bug ID: 31266
           Summary: Curbside pickups - New messaging preference
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart+koha at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 30650

Bug 30650 is adding a new notice that is sent when a new curbside pickup is
created. It's is generated when the patron has the "Hold filled" messaging
preference.

To add flexibility we could have a separate one, dedicated to curbside pickups.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650
[Bug 30650] Convert the Curbside Pickup plugin to Koha core
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:37:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:37:32 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24239-70-Rc21oHw28W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #35 from Lucas Gass <lucas at bywatersolutions.com> ---
Enhancement will not be backported to 22.05.x series unless requested

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 17:35:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 15:35:40 +0000
Subject: [Koha-bugs] [Bug 30950] timepicker.inc is no longer used and should
 be removed
In-Reply-To: <bug-30950-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30950-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30950-70-EBu29fObZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30950

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|22.11.00                    |22.11.00, 22.05.04
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
Backported to 22.05.x for 22.05.04

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:10:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:10:11 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-C6EApCn30f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #21 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138379&action=edit
Bug 28864: Have patron card creator use PatronsPerPage

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1.  Set the PatronsPerPage system preference to any integer other than 20.

2.  Go to Tools -> Patron card creator.
3.  Start a new Card Batch.
4.  Click the 'Add patron(s)' button to open the patron search window.
5.  Do a search.
6.  Add more than 20 patrons to the batch.
7.  Close patron search window.
8.  Click the 'Add patron(s)' button to add the selected patrons to the batch.
9.  Observe that the table of patrons is has 20 as the default per page
setting.

10. Apply patch.
11. Reload the batch.
12. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:55 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LXn97UqAsn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138321|0                           |1
        is obsolete|                            |

--- Comment #152 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138363&action=edit
Bug 30650: Add info to the trash icon

And add a missing space between the time and icon

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:12:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:12:44 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
 memberentry
In-Reply-To: <bug-30874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30874-70-y0kllTkoCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
ping? It would be a shame to lose this enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 18:20:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 16:20:22 +0000
Subject: [Koha-bugs] [Bug 30650] Convert the Curbside Pickup plugin to Koha
 core
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-mDpXUPHrY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138289|0                           |1
        is obsolete|                            |

--- Comment #146 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138357&action=edit
Bug 30650: Don't display slots that have are before now

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:28 +0000
Subject: [Koha-bugs] [Bug 30650] Add a Curbside Pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-SUhckGgPFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #161 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 20:51:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 18:51:06 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-K3CSx24wsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |22.11.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:14:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:14:43 +0000
Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-GRqnfogVy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 21:58:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 19:58:11 +0000
Subject: [Koha-bugs] [Bug 29188] Expired serial subscriptions can still
 receive issues
In-Reply-To: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29188-70-ztuU3pJBXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29188

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=31268

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:58:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:58:39 +0000
Subject: [Koha-bugs] [Bug 30624] Add a permission to control the ability to
 change the logged in branch
In-Reply-To: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30624-70-2CUwXQKSlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137733|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 138378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138378&action=edit
Bug 30624: DB Update to add permission

Signed-off-by: Andrew <andrewfh at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jul 29 22:38:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 20:38:46 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-pAFi5woZ1e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrewfh at dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 01:40:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 23:40:31 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-ZgfSG39d3h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Since columns 4 and 5 are later populated by jQuery 'sDefaultContent' should be
used to define the placeholder value, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:16:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:16:34 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-6idkAjOJy3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 00:44:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jul 2022 22:44:38 +0000
Subject: [Koha-bugs] [Bug 15338] Remove inconsistency in location of
 SIPServer.pm
In-Reply-To: <bug-15338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15338-70-HLfD1MmFK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15338

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
No longer applies cleanly to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 14:53:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 12:53:15 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-71RaAm2F5z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a Curbside Pickup       |Add a curbside pickup
                   |module                      |module

--- Comment #162 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like we have a failing test now?
not ok 264 - Module Koha::CurbsidePickupPolicys should be defined

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 14:50:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 12:50:47 +0000
Subject: [Koha-bugs] [Bug 30327] Sort component parts
In-Reply-To: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30327-70-BSgfS7e81D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #43)
> Backported to 22.05.x for 22.05.04

I am not sure about this one, if the sorting currently was by biblionumber that
might have been the expected sorting - and it won't work now as long as we
don't have bug 30879 in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:07:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:07:01 +0000
Subject: [Koha-bugs] [Bug 31254] Add additional fields for accountlines
In-Reply-To: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31254-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31254-70-thxLlGjc54@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michaela.sieber at kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:08:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:08:23 +0000
Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification
In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31256-70-Q4xs24w00A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, it would be nice :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:28:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:28:28 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-s8eqwKVL02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
My problem with the patron search here is that you get 'stuck' on it.

Search for a patron, pick it - names were all similar, it's not the right one!

There is no way to reset the form. You'd have to schedule a curbside pickup
(which sends an email) and remove it again to get out of it.

Can we have some kind of reset button to get back to search?

Not for this bug, but how do people feel about having a way to open an
'advanced search' (like the normal pop-up) with a button if needed? We've had
complaints form libraries with lots of patrons with very similar names in the
past and this might help them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:42:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:42:23 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-OF7RKVnfuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138382&action=edit
Bug 30964: (QA follow-up) Add classes to allow for additional styling

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:42:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:42:14 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-EgxioV24TB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:48:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:48:27 +0000
Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be
 able to alert even if not staged
In-Reply-To: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31263-70-xHapRtsa4X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's a little harsh to have them just sit in front of the library. If
we don't allow them to 'alert' we should probably at least display information
about the pickup not being ready yet?
Or a library might want to put a "rush" on it if the patron is already waiting
(and allow the alert)?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:45:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:45:08 +0000
Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection
In-Reply-To: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31265-70-9VOPybpLq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's a little tidier and that improves orientation. But I agree there
could be room for more enhancement.

In the OPAC the entries are a little wide, maybe we could center the times as
they are padded and have all the same size and decrease the width a little?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:42:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:42:18 +0000
Subject: [Koha-bugs] [Bug 30964] Add information about overdues and
 restrictions on the curbside pickup list
In-Reply-To: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30964-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30964-70-M8rzzwLxVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30964

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137308|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138381&action=edit
Bug 30964: Add 'restricted' and 'has overdues' on curbside pickup

This patch adds more information about the patron's account on the
curbside pickup list view.
"Patron's account is restricted" if the patron is restricted
"Patron has items overdue" if the patron has overdues

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:55:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:55:04 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-90xP2w7oft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Email Library when New      |Email library when new
                   |Patrons Self Register       |patrons self register
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:50:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:50:23 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-cqDBtUjCqN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
In Germany the week usually starts on Monday, so the pull down starting with
Sunday is a little irritating and it won't match the calendars and other pages
were calendar settings are used.

I think it would be really nice to fix the pull down on the curbside
configuration page and also the way the scheduled times are displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 15:52:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 13:52:35 +0000
Subject: [Koha-bugs] [Bug 31266] Curbside pickups - New messaging preference
In-Reply-To: <bug-31266-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31266-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31266-70-eJ0ppqsfz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31266

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think a separate messaging setting would be for sure the cleanest approach. 

A "cheaper" alternative could be to update the text of the messaging
preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:33:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:33:11 +0000
Subject: [Koha-bugs] [Bug 31270] Terminology: Standardize on
 self-registration or self registration
In-Reply-To: <bug-31270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31270-70-CPOsRrH2H1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe some native speaker can help?

According to coding guidelines we use AE spelling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:24:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:24:33 +0000
Subject: [Koha-bugs] [Bug 31270] New: Terminology: Standardize on
 self-registration or self registration
Message-ID: <bug-31270-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270

            Bug ID: 31270
           Summary: Terminology: Standardize on self-registration or self
                    registration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Currently we have a bit of a mix in the templates and the notices and I think
it would be nice to standardize.

I found this, but happy with either as long as we are consistent:
https://www.merriam-webster.com/dictionary/self-registering

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:00:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:00:17 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-tJTsw4bQyM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:41 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Tby4agNId9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138240|0                           |1
        is obsolete|                            |

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138386&action=edit
Bug 23538: (follow-up) Fix up notices

- Add toolkit template (TT) syntax to notices
- Add TT conditionals to notices

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:46 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-PvthOUbfeM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138387&action=edit
Bug 23538: (QA follow-up) Group system preferences into one entry

This makes the new perferences EmailPatronRegistrations and
EmailAddressForPatronRegistrations
follow a little more closely the pattern set by the very similar
EmailPurchaseSuggestions and EmailAddressforSuggestions.

* Group both preferences into one entry
* Add line break between preferences
* Switch branch for library in pull down

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:00:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:00:22 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-YfebWofzrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138379|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138388&action=edit
Bug 28864: Have patron card creator use PatronsPerPage

Add pageLength to members/member.tt
Add aLengthMenu and pageLength to
 patroncards/add_user_search (common/patron_search.tt).
Add aLengthMenu, pageLength, and iDisplayLength to patroncards/edit-batch

Test plan:
1.  Set the PatronsPerPage system preference to any integer other than 20.

2.  Go to Tools -> Patron card creator.
3.  Start a new Card Batch.
4.  Click the 'Add patron(s)' button to open the patron search window.
5.  Do a search.
6.  Add more than 20 patrons to the batch.
7.  Close patron search window.
8.  Click the 'Add patron(s)' button to add the selected patrons to the batch.
9.  Observe that the table of patrons is has 20 as the default per page
setting.

10. Apply patch.
11. Reload the batch.
12. Observe that the per page drop down includes the value of PatronsPerPage
     and that value is selected by default.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:35 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-VTOpGMcYfa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138239|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138385&action=edit
Bug 23538: Unit tests

Test plan:
1. Run unit tests:
sudo koha-shell <instance>
cd t/db_dependent/Koha
prove -v Patron.t

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:25 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-waz3HXYIEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138237|0                           |1
        is obsolete|                            |

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138383&action=edit
Bug 23538: Database changes

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:59:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:59:38 +0000
Subject: [Koha-bugs] [Bug 28864] The patron search results in the patron
 card creator doesn't seem to use PatronsPerPage syspref
In-Reply-To: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28864-70-yfsLmWB4vZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thanks for clearing that up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:52:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:52:15 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-xyKia2aG9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Very happy to see inbound_email_address and ReplyToDefault used here!

installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql is no longer
necessary. I have amended David's patch removing the file and adjusting the
commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:53:02 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-SgWhVXf32R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement allows     |This enhancement allows
      release notes|libraries to receive        |libraries to receive
                   |notifications when patrons  |notifications when patrons
                   |self-register.
             |self-register.
                   |
                           |
                   |This is                     |This is
                   |enabled using the new       |enabled using the new
                   |system preference           |system preference
                   |EmailPatronRegistrations    |EmailPatronRegistrations
                   |(options are: none, email   |(options are: none, email
                   |address of branch,          |address of library,
                   |EmailAddressForPatronRegist |EmailAddressForPatronRegist
                   |rations, and                |rations, and
                   |KohaAdminEmailAddress) and  |KohaAdminEmailAddress) and
                   |a new notice (OPAC_REG).
   |a new notice (OPAC_REG).
                   |                            |
                   |To use a specific email     |To use a specific email
                   |address for notifications,  |address for notifications,
                   |use the new system          |use the new system
                   |preference                  |preference
                   |EmailAddressForPatronRegist |EmailAddressForPatronRegist
                   |rations.
                   |rations.
                   |
                           |
                   |If verification             |If verification
                   |is required for             |is required for
                   |self-registrations (when    |self-registrations (when
                   |PatronSelfRegistrationVerif |PatronSelfRegistrationVerif
                   |yByEmail is enabled), then  |yByEmail is enabled), then
                   |notifications are only sent |notifications are only sent
                   |to the library once the     |to the library once the
                   |registration is confirmed.  |registration is confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:30 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-Fos7SzclAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138238|0                           |1
        is obsolete|                            |

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138384&action=edit
Bug 23538: Email library when new patron self-registers

Test plan:
1. Apply all patches
2. Update database
3. Restart services
4. Set email addresses in:
- KohaAdminEmailAddress syspref
- EmailAddressForPatronRegistrations syspref
- Email address in the library branch
5. Enable PatronSelfRegistration syspref
6. Test the following use cases:

- EmailPatronRegistrations syspref = 'none'.
Submit OPAC registration.
= OUTCOME: Confirm no OPAC_REG notice in message_queue table

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 16:51:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 14:51:19 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-6jdFbBIS6p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:24:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:24:09 +0000
Subject: [Koha-bugs] [Bug 31271] New: "Edit search" always resets search
 options to keyword
Message-ID: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271

            Bug ID: 31271
           Summary: "Edit search" always resets search options to keyword
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, nick at bywatersolutions.com

To test:
- Go to the advanced search in the staff interface
- Select Barcode as search option and search for a non-existing barcode
- From the search results, go back by Edit search link
- Verify the search option flipped back to Keyword :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:24:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:24:10 +0000
Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha
 namespace
In-Reply-To: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27272-70-zJIfoHxIDk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #81 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Did some testing, no code review yet but noticed the following problems:

1. Going to a serial biblio's detail page fails on opac, e.g. page
http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 on KTD.

> DBIx::Class::ResultSource::_resolve_join(): No such relationship serial on Item at /kohadevbox/koha/Koha/Objects.pm line 421

Same error on the detail.pl on the staff side.


2. Go to any biblio's OPAC detail page, checkout an item for that biblio and
notice the Status column is not updated and it still shows "Available". Before
applying these patches the status was "Checked out"

3. serials/routing-preview.pl doesn't display the branch name anymore.

Will continue testing after this, there are still some things I want to test on
the biblio detail pages that I cannot due to the internal server errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:25:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:25:08 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-kq3HikqdlC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like this, but I was a little worried it could create problems with the other
barcode filters.

So what happens if the barcode is not scanned but for example copied from a
report or from the items table (already being converted?)

Are we sure the existing filters will not "double-convert" those?

So I have tested (looking at the test for the barcode filters):

libsuite8
Unconverted: b000126 searches for:
Converted: IMS-b-126 searches for: CPL-IMS-b--126
--> unwanted conversion
This is odd, because the test covers this and they should actually be the same?
The additional space should not upset Koha, so we can probably ignore this.

Also tested CueCat, T, EAN etc. and it looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 17:31:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 15:31:06 +0000
Subject: [Koha-bugs] [Bug 31252] Advanced search in staff interface should
 call barcodedecode if the search index is a barcode
In-Reply-To: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31252-70-X73UjOkwcJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31252

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looking at this again... the libsuite8 conversion is an odd one:

IMS-b-126 searches for: CPL-IMS-b--126 => Where is the branchcode suddenly
coming from?

This should not happen, IMS-B-125 should stay identical on conversion?

t/Circulation_barcodedecode.
'libsuite8' => ['b000126', 'b12', 'B0126', 'IMS-B-126',
'ims-b-126','CD0000024','00123','11998'],
'libsuite8' => ['IMS-b-126', 'IMS-b-12', 'IMS-B-126', 'IMS-B-126',
'ims-b-126','IMS-CD-24','IMS-b-123','IMS-b-11998'],

Can you have a look please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:33:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:33:25 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-tjFewRBKHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:33:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:33:29 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-HqO23vb9bA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138376|0                           |1
        is obsolete|                            |

--- Comment #8 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 138389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138389&action=edit
Bug 30499: Move the include for catalogue-search-box.inc in circ-search.inc to
correct keyboard shortcuts

Keyboard shortcuts for catalog search, check in and renew should be following:
1) Alt-q for catalog search
2) Alt-r for check in
3) Alt-w for renew

However on some of the pages shortcuts get mixed up:

1) Alt-w for catalog search
2) Alt-q for check in
3) Alt-r for renew

Affected files are:
circ/pendingreserves.tt
circ/circulation_batch_checkouts.tt
circ/circulation-home.tt
circ/branchtransfers.tt
circ/branchoverdues.tt
circ/set-library.tt
circ/checkout-notes.tt
circ/renew.tt
circ/waitingreserves.tt
circ/transferstoreceive.tt
circ/offline.tt
circ/bookcount.tt
circ/on-site_checkouts.tt
circ/circulation.tt
circ/transfers_to_send.tt
circ/request-article.tt
circ/overdue.tt
circ/reserveratios.tt
offline_circ/list.tt
offline_circ/process_koc.tt
offline_circ/enqueue_koc.tt
plugins/plugins-upload.tt
plugins/plugins-disabled.tt
pos/registers.tt
pos/register.tt
pos/pay.tt
reports/reports-home.tt
reports/dictionary.tt
reports/guided_reports_start.tt
reserve/request.tt
tools/scheduler.tt

This is because the include statement for catalogue-search-box.inc is in the
wrong line in circ-search.inc.

To test:
1) Go to an affected page (circulation-home was the first one I noticed)
2) Try the keyboard shortcuts and notice they are incorrect
3) Apply patch and refresh the page
4) Notice that the keys work properly

Signed-off-by: Andrew <andrewfh at dubcolib.org>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:28:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:28:50 +0000
Subject: [Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
In-Reply-To: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30499-70-c2gcuMZLYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at iki.fi
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
            Version|21.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:59:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:59:44 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-dhBe2bl0bo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:59:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:59:48 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-DZmpdorqUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138142|0                           |1
        is obsolete|                            |
 Attachment #138143|0                           |1
        is obsolete|                            |

--- Comment #22 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 138390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138390&action=edit
Bug 31223: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:59:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:59:52 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-MHiLrF7FC5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #23 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 138391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138391&action=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 18:56:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 16:56:36 +0000
Subject: [Koha-bugs] [Bug 31223] Batch edit items explodes if plugins
 disabled
In-Reply-To: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31223-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31223-70-x3vtuxBSWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |joonas.kylmala at iki.fi
                   |y.org                       |
                 CC|                            |joonas.kylmala at iki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 20:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 18:32:50 +0000
Subject: [Koha-bugs] [Bug 31258] Accessing patron lists from patron accounts
In-Reply-To: <bug-31258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31258-70-nm3GJHRKqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31258

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|21.11                       |master

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Again, this would be better as an omnibus bug with the ideas listed as several
small bugs. Easier to solve and better to advertise :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 20:30:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 18:30:11 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-Nk8KuUcKAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138241|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138392&action=edit
Bug 31251: Use jQuery val() to clear_entry

1. Add some patron attributes that are textarea and some that have an AV
category so they are select dropdowns
2. Go to the patron form and add some values to the patron attributes
3. Use the "Clear" button to try and clear the values, doesnt work.
4. Apply patch
5. Try clearing values from patron attributes that are both select dropdowns
and textarea. The "Clear" button should work.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 21:50:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 19:50:55 +0000
Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because
 it's missing REGEXP_REPLACE
In-Reply-To: <bug-29805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29805-70-E5lonP66jm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805

--- Comment #10 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Katrin Fischer from comment #0)
> Are we still supporting 5.7?
> 
> If not, should we highlight that somewhere?
> 
> We currently only list MariaDB versions on the wiki linked from release
> notes:
> https://wiki.koha-community.org/wiki/System_requirements_and_recommendations
> 
> We are still listing MySQL here:
> https://koha-community.org/download-koha/

Woops I only understand now why I was CCed here.
The only CI running MySQL is for Master with MySQL 8
Since more than a year anything could break with MySQL 5.7 and we wouldn't
notice it in any release. So maybe we didn't formally decided to not support it
but the current state is not a support one.

I added the question to the next meeting:
https://wiki.koha-community.org/wiki/Development_IRC_meeting_3_August_2022

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:02:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:02:21 +0000
Subject: [Koha-bugs] [Bug 20119] Ability to print claims for late orders
In-Reply-To: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20119-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20119-70-QzqlbBtXZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20119

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Alex, could you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20119 - Ability to print claims for late orders
Applying: Bug 20119 - Add unit tests
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 20119 - Add unit tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-20119---Add-unit-tests-BTwZip.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 21:59:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 19:59:50 +0000
Subject: [Koha-bugs] [Bug 18783] Allow automatic claims for serials
In-Reply-To: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18783-70-5bttVFVobl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jessie Zairo from comment #13)
> When testing we got an error of DBIx::Class::Row::store_column(): No such
> column 'auto_claim_enabled' on Koha::Schema::Result::Subscription at
> /kohadevbox/koha/Koha/Object.pm line 79
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77

If you see an error like this, make sure that the database update has run and
if there is no Schema update patch, you need to 'refresh schema' in the sandbox
or run the dbic command.

Would love to see this back in the queues!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:44:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:44:33 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-o9qrVOSI8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|31272                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:47:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:47:48 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-9ieFiFPiMG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137666|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138393&action=edit
Bug 30992: Improve translatability for Waiting at|On hold

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:02:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:02:09 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-TgyZg2dWra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138134|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138396&action=edit
Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search
   the catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
   correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It
   should correcrly limit to that branch BUT it should also default back
   to 'All libraries' for the next search.
9. Try selecting 'All libraries' from the top of the dropdown and make
   sure it is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make
    sure it looks nice with both of those dropdowns and functions when
    you use limiters from both dropdowns.

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:36:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:36:21 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-XvVoKlYQ6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30992


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992
[Bug 30992] Hard to translate single word strings
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 21:56:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 19:56:37 +0000
Subject: [Koha-bugs] [Bug 27684] Serial add is confused by authorized values
 with a code of '0'
In-Reply-To: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-27684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-27684-70-f0NFGQ6Ywj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27684

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is about the different behaviour of the add item form
(cataloguing) vs. the add item form (serials). If I read the test plan right,
they should preselect the 0 value in both when you open the forms.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 21:34:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 19:34:34 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-WtI4NnCYZX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #417 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Hi :) I tried to rebase because why not, but hit a wall on the changes on
ModReserveFill which was moved (and changed a lot) to Hold::fill(). I don't
know where is a right place to put the new code:

    # if this hold was part of a group, cancel other holds in the group
    my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
    foreach my $h ( @holds ) {
        $h->cancel unless $h->reserve_id == $hold->reserve_id;
    }


Also, maybe these lines are also needed in Hold::cancel()
Not sure at all.

I would gladly give another try if someone know what to do about the two above
points.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:02:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:02:18 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-aZ7MRSWAAy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138136|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138398&action=edit
Bug 30077: (follow-up) Set max width for library drapdown

If you have a library with a very long name the dropdown will expand to
accommodate it. I think this is awkward-looking, so I propose to set a
max width on <select> elements in the header search region.

The patch requires a rebuild of the staff interface CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 20:30:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 18:30:07 +0000
Subject: [Koha-bugs] [Bug 31251] "Clear" patron attribute link does not work
In-Reply-To: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31251-70-MPqOU7vsCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31251

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:35:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:35:24 +0000
Subject: [Koha-bugs] [Bug 31272] New: Show library name not code when
 placing item level holds in OPAC
Message-ID: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

            Bug ID: 31272
           Summary: Show library name not code when placing item level
                    holds in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When placing an item level hold in the OPAC and there are other pending holds,
the branchcode will show instead of the branchname:

On hold for patron expected at FFL since 07/30/2022 .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:36:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:36:21 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-6gudPR6VNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:00:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:00:48 +0000
Subject: [Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
In-Reply-To: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18796-70-SzJEm3hx65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ping?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:33:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:33:13 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-ugYjK6eAkl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |31272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272
[Bug 31272] Show library name not code when placing item level holds in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:02:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:02:04 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-i4C1j9w3Yl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:32:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:32:58 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-7gRTJYOj9l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The hold that should be triggered is a "next available", but I have another 2
item level holds on this record as well. I did not try to cancel, so I wonder,
why this code would be run?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:58:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:58:40 +0000
Subject: [Koha-bugs] [Bug 30672] Special characters entered into circulation
 and fine rules causes errors
In-Reply-To: <bug-30672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30672-70-fF3fcGzF9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30672

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think what was meant here was the missing validation on the fields that is
maybe partially to blame on the switch to circulation_rules. Before, you
couldn't save an amount of 4,00€ in fine, now you can, but it will cause
problems down the road.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 00:04:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 22:04:30 +0000
Subject: [Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart
 normal and detailed views
In-Reply-To: <bug-25126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-25126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-25126-70-oguaokAU7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I retested with 650a set to hidden and this works now. Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:47:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:47:53 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-nJVMdnRCNh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137855|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138394&action=edit
Bug 30992: Improve translatability for 'for'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:39:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:39:59 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-avfHzKcXzt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:31:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:31:07 +0000
Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22456-70-Gj0M1cCb1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #102 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry, but I get this error when trying to return an item with a hold on
it:

Can't call method "id" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 351

  349:     # is there a waiting hold for the item, for which cancellation
  350:     # has been requested?
  351:     my $waiting_holds_to_be_cancelled =
  352:       Koha::Holds->waiting->search( { itemnumber => $item->id } )
  353:       ->filter_by_has_cancellation_requests;
  354:     while ( my $hold = $waiting_holds_to_be_cancelled->next ) {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:51:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:51:29 +0000
Subject: [Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails
 for Koha to MARC mapping using biblio table
In-Reply-To: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31239-70-swVzZK3dDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Which mapping caused the error?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:55:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:55:51 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-u9GThvsmWL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138120|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138395&action=edit
Bug 23202: Problems when adding multiple items to an order in acquisitions

This patch fixes adding multiple items on order acquisitions

1) Set dateaccessioned.pl plugin to ACQ framework's 952$d field.
2) Create basket to a vendor and add order from a new empty record.
3) Add date acquired value from calendar.
4) Add multiple items and see that the view freezes.
5) Apply the patch
6) Reload the page and repeat the steps 3 and 4.
7) See that the items are added.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:44:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:44:33 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-jgLuLeJnGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|30992                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992
[Bug 30992] Hard to translate single word strings
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:51:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:51:47 +0000
Subject: [Koha-bugs] [Bug 31154] Batch item modification fails when "Use
 default values" is checked
In-Reply-To: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31154-70-uCfFdIA6Hh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can no longer replicate the problem with the test plan that worked before :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:55:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:55:46 +0000
Subject: [Koha-bugs] [Bug 23202] Problems when adding multiple items to an
 order in acquisitions
In-Reply-To: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23202-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23202-70-nV12y0dcvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23202

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:33:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:33:13 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-0ndusq4c1C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |30992


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992
[Bug 30992] Hard to translate single word strings
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:40:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:40:03 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-8Vr82yFmEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138399&action=edit
Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl

Before this patch the date formatting for the due date was done
in the .pl instead of the template and the branchcode would show
instead of the library's name in the list of items when placing
an item level hold in the OPAC.

To test:
* Find or create a record with mulitple items
* Check out one of the items
* Place a record level hold
* Return an item to set to waiting
* Place an item level hold
* Go to the OPAC and start placing an item level hold
* Verify the messages in the item table show the branchcode
* Apply patch
* Only visible change should be the library name replacing the branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 22:47:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 20:47:44 +0000
Subject: [Koha-bugs] [Bug 30992] Hard to translate single word strings
In-Reply-To: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30992-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30992-70-HNuqs6KUer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:03:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:03:52 +0000
Subject: [Koha-bugs] [Bug 31272] Show library name not code when placing
 item level holds in OPAC
In-Reply-To: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31272-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31272-70-GRHhUF98o7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:55:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:55:27 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-V0Fq2gqZox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138380|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138400&action=edit
Bug 31269: Define sDefaultContent for DataTables

1. Stage a MARC record for import
2. Once you have one click on 'Manage staged records'
3. You will see an alert that says "Something went wrong when loading the
table."
4. If you dismiss that you should see the following error:

DataTables warning: table id=records-table - Requested unknown parameter '' for
row 0, column 4. For more information about this error, please see
http://datatables.net/tn/4

5. Appy patch
6. Try ssteps 1 & 2 again
7. No DataTable errors

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:02:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:02:13 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
 function for staff interface
In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30077-70-TnRaAyru2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138135|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138397&action=edit
Bug 30077: (follow-up) retain branch selection

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search
   the catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
   correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It
   should correcrly limit to that branch and retain that branch in the
   dropdown, just like the OPAC.
9. Try selecting 'All libraries' from the top of the dropdown and make
   sure it is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make
    sure it looks nice with both of those dropdowns and functions when
    you use limiters from both dropdowns.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jul 30 23:55:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 21:55:23 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-5acESa5QMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 00:23:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jul 2022 22:23:23 +0000
Subject: [Koha-bugs] [Bug 30648] Title is lost in Holds History when biblio
 is deleted
In-Reply-To: <bug-30648-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30648-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30648-70-tvF8bvIULp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30648

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have confirmed it. In old_reserves the biblionumber is set to NULL when the
bibliographic record is deleted.

I know that merging the tables is the ultimate solution, but is there another
solution we could think of? Maybe we could not cascade on delete?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:50:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:50:44 +0000
Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized
 PDF files.
In-Reply-To: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28806-70-2s0Zezxuc5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=29994

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:00:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:00:58 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Iz5Umop175@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:35:42 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-H0CHWZWlyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:15:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:15:40 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-5y8OK9yMym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Is that what you wanted?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:54:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:54:04 +0000
Subject: [Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because
 it's missing REGEXP_REPLACE
In-Reply-To: <bug-29805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29805-70-MFXi4dhllJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun
                   |com                         |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:48:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:48:43 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove dates in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-jYRCOVRGky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138406&action=edit
Bug 31261: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:28:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:28:42 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-8O9QChTsUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:50:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:50:44 +0000
Subject: [Koha-bugs] [Bug 29994] Single label PDF export not working
In-Reply-To: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29994-70-WP8kemzNVd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=28806

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:36:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:36:16 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-dFbzLqngZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:14:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:14:52 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-lfhVrSPwIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

--- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138402&action=edit
Bug 30965: Add a 'x' to go back to the patron search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:28:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:28:56 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-Ccr4sfZyCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:37:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:37:24 +0000
Subject: [Koha-bugs] [Bug 31263] Curbside pickups - Should the patron be
 able to alert even if not staged
In-Reply-To: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31263-70-oSvPIUFTTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31263

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |lisettepalouse+koha at gmail.c
                   |                            |om

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Lisette, what's your opinion on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:45:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:45:57 +0000
Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection
In-Reply-To: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31265-70-qkmQw29kQn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138405&action=edit
Bug 31265: Improve time slots selection

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 06:46:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 04:46:58 +0000
Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized
 PDF files.
In-Reply-To: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-28806-70-oVDcx8zAfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806

Dietrich <dietrich at teilgedanken.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dietrich at teilgedanken.de

--- Comment #6 from Dietrich <dietrich at teilgedanken.de> ---
I have the same problem...
What would be the next step to debug this further?
I did not find any error in the logs... but where would I look for errors?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:48:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:48:08 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-QXhaXOM8M2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:54:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:54:05 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-Dpg95LxYNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #164 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #160)
> Great job, Jonathan.
> 
> - We could use some more unit tests

Which missing tests did you identify?

> - Some of this could've been squashed, specially the typos, etc.

Yes, they should have been. I submitted to easy the QA review, but they could
have been squashed before push for sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 07:57:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 05:57:47 +0000
Subject: [Koha-bugs] [Bug 30650] Add a curbside pickup module
In-Reply-To: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30650-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30650-70-LF7vMA6scR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650

--- Comment #163 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138401&action=edit
Bug 30650: Add missing koha_object[s]_class methods

To fix TestBuilder.t
        #   at t/db_dependent/TestBuilder.t line 453.
        #          got: 'Can't locate Koha/CurbsidePickupPolicys.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:28:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:28:46 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-r577oUla8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

--- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138404&action=edit
Bug 31264: Curbside pickups - Take CalendarFirstDayOfWeek into account

We need to take the pref CalendarFirstDayOfWeek into account to display
the days on the curbside pickups admin page.

Test plan:
Turn on the CurbsidePickup pref
Set CalendarFirstDayOfWeek to Sunday
Go to the curbside pickups admin page, add new slots, and confirm that
Sunday is displayed first.
Try again with CalendarFirstDayOfWeek set to Monday and Saturday.

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:49:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:49:23 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-50jNvz6Vap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122448|0                           |1
        is obsolete|                            |

--- Comment #80 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138407&action=edit
Bug 26282: Allow staff to decide if a hold cancellation notice will be sent
when cancelling a hold

Bug 25534 adds the option to send hold cancellation notices when a
reason was given. It would be nice if you could give a reason but still
decide not to send to the patron.

Say the patron called and will not be able to pick up numerous holds for
some time. You cancel them all with "patron requested cancellation" but
don't want to send multiple notices.

I could imagine a checkbox next to the reason to activate/deactivate
sending the notice.

Test Plan:
1) Apply this patch
2) Visit each area in Koha where a hold can be canceled with a reason
3) Note the new 'Notify patron' checkbox
4) Test canceling a hold with and without this checkbox checked
5) Verify leaving it unchecked does not trigger a notice to be sent to the
patron

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:53 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-qCOR2mYq9X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122454|0                           |1
        is obsolete|                            |

--- Comment #89 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138416&action=edit
Bug 26282: (QA follow-up) Update test

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 12:42:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 10:42:22 +0000
Subject: [Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
In-Reply-To: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30951-70-rnCNrl3grm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could we fix the old database update and implement the proposed fix as a new
one to catch all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:49:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:49:39 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove dates in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-67yRNVzkKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail.
                   |ity.org                     |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:49:40 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-bU386gsjzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122449|0                           |1
        is obsolete|                            |

--- Comment #81 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138408&action=edit
Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:50:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:50:48 +0000
Subject: [Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups
 list
In-Reply-To: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30963-70-ApzNIOR2eF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Katrin, what's your opinion on this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:46:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:46:34 +0000
Subject: [Koha-bugs] [Bug 31265] Curbside pickups - improve slots selection
In-Reply-To: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31265-70-TXuJ6m5g60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
I am very bad at that. Owen, could you help me please? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:48:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:48:40 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove dates in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-dMsqDpGidA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:16 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-CeH6grzfyt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138407|0                           |1
        is obsolete|                            |

--- Comment #83 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138410&action=edit
Bug 26282: Allow staff to decide if a hold cancellation notice will be sent
when cancelling a hold

Bug 25534 adds the option to send hold cancellation notices when a
reason was given. It would be nice if you could give a reason but still
decide not to send to the patron.

Say the patron called and will not be able to pick up numerous holds for
some time. You cancel them all with "patron requested cancellation" but
don't want to send multiple notices.

I could imagine a checkbox next to the reason to activate/deactivate
sending the notice.

Test Plan:
1) Apply this patch
2) Visit each area in Koha where a hold can be canceled with a reason
3) Note the new 'Notify patron' checkbox
4) Test canceling a hold with and without this checkbox checked
5) Verify leaving it unchecked does not trigger a notice to be sent to the
patron

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 08:35:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 06:35:46 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-mvZ2vTWIve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

--- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 138403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138403&action=edit
Bug 31262: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:48:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:48:14 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-Nqx8oCUJiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 09:47:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 07:47:23 +0000
Subject: [Koha-bugs] [Bug 31262] Curbside pickups - disable dates without
 slots
In-Reply-To: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31262-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31262-70-ZKaWRZnkms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31262

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138403|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:40:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:40:30 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-hl8fcN7YcS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138404|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138422&action=edit
Bug 31264: Curbside pickups - Take CalendarFirstDayOfWeek into account

We need to take the pref CalendarFirstDayOfWeek into account to display
the days on the curbside pickups admin page.

Test plan:
Turn on the CurbsidePickup pref
Set CalendarFirstDayOfWeek to Sunday
Go to the curbside pickups admin page, add new slots, and confirm that
Sunday is displayed first.
Try again with CalendarFirstDayOfWeek set to Monday and Saturday.

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:47 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-XcBsu8acex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122453|0                           |1
        is obsolete|                            |

--- Comment #88 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138415&action=edit
Bug 26282: (QA follow-up) Unit tests

This patch adds tests for the behaviour change. It tests if letter
processing takes place when notify_patron is passed. It tests all
combinations.

Bonus: it tweaks the POD to acknowledge this new parameter.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> FAIL: Tests fail!
3. Apply the rest of the patches
4. Repeat 2
=> SUCCESS: Tests pass! No warnings!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:53:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:53:14 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-GDGNABALFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122550|0                           |1
        is obsolete|                            |

--- Comment #92 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138419&action=edit
Bug 26282: Update Holds to pull

Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:22 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-rmf1z2Y5YC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138408|0                           |1
        is obsolete|                            |

--- Comment #84 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138411&action=edit
Bug 26282: (QA follow-up) Implement for moremember.pl and circulation.pl

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:41 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-ok3HAmxGcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122452|0                           |1
        is obsolete|                            |

--- Comment #87 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138414&action=edit
Bug 26282: (QA follow-up) Update POD

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:33:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:33:27 +0000
Subject: [Koha-bugs] [Bug 29897] Display author identifiers for researchers
In-Reply-To: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-29897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-29897-70-ZFOrn20qZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Joubu, it almost works perfectly now, but:
The author identifiers don't only show on their own tab, but on all tabs on the
OPAC detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:36:09 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:36:09 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-SUE0u6xxrH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 19:11:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 17:11:58 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-blI8Y8kdvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

--- Comment #93 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Happy birthday, here is a rebase 🎁 ^o^

I compared the old and new patches to double check that I didn't change
anything unknowingly.

However failed QA because a test is failing and it's also failing when rebasing
on an old(2021-08) master. So it's not from the rebase. #notmyjoblol


root at kohadevbox:koha((e781542349...))$ prove t/db_dependent/Koha/Hold.t
t/db_dependent/Koha/Hold.t .. 3/4 
    #   Failed test 'GetPreparedLetter not called if notify_patron passed and
no cancellation_reason passed'
    #   at t/db_dependent/Koha/Hold.t line 290.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 1 test of 12.
t/db_dependent/Koha/Hold.t .. 4/4 
#   Failed test 'cancel() tests'
#   at t/db_dependent/Koha/Hold.t line 297.
# Looks like you failed 1 test of 4.
t/db_dependent/Koha/Hold.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Hold.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=1, Tests=4, 10 wallclock secs ( 0.04 usr  0.00 sys +  7.23 cusr  1.52
csys =  8.79 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 12:40:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 10:40:40 +0000
Subject: [Koha-bugs] [Bug 30952] New interface for staff client
In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30952-70-vj6cw1WoxD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #146 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Julian Maurice from comment #145)
> Sandbox recreated will all patches:
> https://staff-bug30952.sandboxes.biblibre.eu

I've posted the link into the discussion on the mailing list - thanks a lot for
setting this up!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:36:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:36:14 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-VA4ZuxuA3t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137309|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138420&action=edit
Bug 30965: Add patron autocomplete search to curbside pickups

Prior to this patch librarians had to know the cardnumber to search for
patron. Now it's possible to search using the default patron
autocomplete search (name, cardnumber, etc.)

Test plan:
Confirm that you can search for a patron without their cardnumber,
select it and create a curbside pickup

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Koha Team University Lyon 3 <koha at univ-lyon3.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:36 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-zrfkaVpFGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122451|0                           |1
        is obsolete|                            |

--- Comment #86 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138413&action=edit
Bug 26282: (QA follow-up) Allow notification via cancel_expired_holds

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:47:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:47:06 +0000
Subject: [Koha-bugs] [Bug 31261] Curbside pickups - remove dates in the past
In-Reply-To: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31261-70-4tzp3Qbo5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have configured from 1:00 to 23:55 with 10 minute slots, but I can no longer
pick pickup slots from today in the calendar. OPAC and staff show the same
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 14:26:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 12:26:41 +0000
Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server
In-Reply-To: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31259-70-HB8kcNi7UT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259

--- Comment #1 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Please post this URL from your instance:

http://staff-client.kohadev.org/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=1&layout_id=5&start_label=1

Include the parameters which cause the loop.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:50:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:50:50 +0000
Subject: [Koha-bugs] [Bug 31269] DataTables error when managing staged MARC
 records
In-Reply-To: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31269-70-RBZI6IupIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31269

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please don't forget to fill in the assignee.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:52:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:52:29 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-6nbmS1PFGs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138409|0                           |1
        is obsolete|                            |

--- Comment #85 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138412&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:49:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:49:59 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-PEiJMd363m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122450|0                           |1
        is obsolete|                            |

--- Comment #82 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138409&action=edit
Bug 26282: (QA follow-up) Always notify patron if notify checkbox is checked

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:40:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:40:26 +0000
Subject: [Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into
 account when configuring curbside pickups
In-Reply-To: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31264-70-0r91vf3ZRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:36:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:36:34 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-mnYZcDVUbw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #8)
> Is that what you wanted?

Yes, that's much better - thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:53:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:53:08 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-x7KNJ2x3SD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122456|0                           |1
        is obsolete|                            |

--- Comment #91 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138418&action=edit
Bug 26282: Show reason only if notice exists

Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:38:06 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:38:06 +0000
Subject: [Koha-bugs] [Bug 31267] Error 500 in stage-marc-import
In-Reply-To: <bug-31267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-31267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-31267-70-LsxcYKvYLA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31267

George Veranis <gveranis at dataly.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |minor
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from George Veranis <gveranis at dataly.gr> ---
finally was wrong configuration at my installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 18:53:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 16:53:01 +0000
Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold
 cancellation notice will be sent when cancelling a hold
In-Reply-To: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-26282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-26282-70-TNTsyRDtjy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122455|0                           |1
        is obsolete|                            |

--- Comment #90 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 138417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138417&action=edit
Bug 26282: (QA follow-up) Restore default notice

Rebased-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 23:29:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 21:29:08 +0000
Subject: [Koha-bugs] [Bug 23538] Email library when new patrons self register
In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23538-70-TTIboexPUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538

--- Comment #34 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Thanks very much for testing and feedback David and Katrin!

Great to see this Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jul 31 22:36:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Jul 2022 20:36:18 +0000
Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside
 pickups
In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-30965-70-pavQZNv5QH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138402|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 138421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138421&action=edit
Bug 30965: Add a 'x' to go back to the patron search

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.