[Koha-bugs] [Bug 31075] New: Script overdue_notices.pl should use GetPreparedLetter

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31075

            Bug ID: 31075
           Summary: Script overdue_notices.pl should use GetPreparedLetter
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

The overdue_notices.pl script contains a lot of code for letter/notice handling
that really should not be there. Some regular notice constructs do not work
since it is doing its own thing.
Look at this example:

                    my $letter = parse_overdues_letter(
                        {   letter_code     => $overdue_rules->{"letter$i"},
                            borrowernumber  => $borrowernumber,
                            branchcode      => $branchcode,
                            items           => \@items,
                            substitute      => {    # this appears to be a hack
to overcome incomplete features in this code.
                                                bib             =>
$library->branchname, # maybe 'bib' is a typo for 'lib<rary>'?
                                                'items.content' => $titles,
                                                'count'         => $itemcount,
                                               },
                            # If there is no template defined for the requested
letter
                            # Fallback on the original type
                            message_transport_type => $letter_exists ?
$effective_mtt : $mtt,
                        }
                    );

The comment talks about a hack to overcome incomplete features.
I did mark this as major, and not enhancement for refactoring.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.