[Koha-bugs] [Bug 30526] The pagination in the REST API does not work if $c->objects->search is called multiple times.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30526

--- Comment #5 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
It seems that the issue at hand have been accidentally fixed.

Let me propose a simpler test plan:

* Open up Koha/REST/Plugin/Query.pm and look at the subroutine _build_link
* Observe that the subroutine overwrites $args->{params}->{_page} and
$args->{params}->{_per_page}
* Ponder for a second over how one can reasonable expect that these parameters
remain unchanged for the duration of the request.
* Ponder for a second over how this unexpected modification of the parameters
might have caused the issue at hand, how it might be causing other undiscovered
issues and how it may cause issues with code yet to be written.
* Ponder for a second over how no sane programmer could have written any code
which, outside of the subroutine _build_link, relies on this unexpected update
of the parameters.
* Ponder for a second over how the proposed patch unburdens you from these
concerns.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.