[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456

--- Comment #67 from Lari Taskula <lari.taskula at hypernova.fi> ---
Comment on attachment 135841
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135841
Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es)

Review of attachment 135841:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22456&attachment=135841)
-----------------------------------------------------------------

::: Koha/Hold/CancellationRequest.pm
@@ +40,5 @@
> +sub store {
> +    my ($self) = @_;
> +
> +    if ( !$self->in_storage ) { # new request
> +        $self->creation_date( \'NOW()' )

Why do we do store() overloading instead of defining "NOT NULL DEFAULT
CURRENT_TIMESTAMP" at table creation?

-- 
You are receiving this mail because:
You are watching all bug changes.