[Koha-bugs] [Bug 31124] New: koha-remove fails to remove long_tasks queue daemon, so koha-create for same <instance> user fails

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124

            Bug ID: 31124
           Summary: koha-remove fails to remove long_tasks queue daemon,
                    so koha-create for same <instance> user fails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: rel_22_05_candidate
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matted-34813 at mypacks.net
        QA Contact: testopia at bugs.koha-community.org

>From the command line as a koha shell user:
1)
koha-remove <instance>
fails to remove the backgroundjobs / long_tasks(queue) daemon. (ps -aef | grep
long_tasks)
So when it tries to "deluser" the <instance>-koha user from /etc/passwd
that errors because a process is still running for that user's PID.
2)
koha-create <instance>   fails for that same instance name from that point
onward.

3)
koha-worker --help    doesn't show any --queue option

Cursory investigation shows:
--queue support was added in version 22.05 to koha-worker.

koha-worker --stop --queue long-tasks <instancename>
works to shut down that specified queue.
--status and --start are also supported.

Suggested Fix:
1)
koha-remove needs to have an entry added:
koha-worker --stop --queue long_tasks <instancename>
added accordingly to get that process to stop
so the latter deluser will succeed.

2)
koha-worker needs:
the --queue option should be added to the --help / POD

Also, koha-worker --help should at least show:
Usage:
koha-worker [--start|--stop|--restart] [--quiet|-q] [--queue <queuename>]
instancename1 [instancename2...]
and also:
    --queue <queuename>     Specify a queue name

One should be able to be able(test plan):
test 1)
koha-remove kohadev
koha-create --create-db kohadev
koha-remove kohadev
without problems in the ktd or other test environment to be fixed.
test 2)
Also, koha-worker --help should at least show:
Usage:
koha-worker [--start|--stop|--restart] [--quiet|-q] [--queue <queuename>]
instancename1 [instancename2...]
and also:
    --queue <queuename>     Specify a queue name

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.