[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #448 from Kyle M Hall <kyle at bywatersolutions.com> ---
Comment on attachment 137503
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503
Bug 28854: Squashed Patch Set for Reading

Review of attachment 137503:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28854&attachment=137503)
-----------------------------------------------------------------

::: C4/Accounts.pm
@@ +70,5 @@
>  sub chargelostitem {
>      my $dbh = C4::Context->dbh();
>      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> +    my $item  = Koha::Items->find($itemnumber);
> +    my $itype = $item->itemtype;

Why the switch from effective_itemtype() to itemtype()?

::: Koha/Item.pm
@@ +1611,5 @@
> +            }
> +            elsif ( $_->{msg} =~
> +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> +              )
> +            {    # The optional \W in the regex might be a quote or backtick

There is no \W in the regex. Wish it changed, or maybe the W should be lower
case?

-- 
You are receiving this mail because:
You are watching all bug changes.