[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #451 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Kyle M Hall from comment #448)
> Comment on attachment 137503 [details] [review]
> Bug 28854: Squashed Patch Set for Reading
> 
> Review of attachment 137503 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Accounts.pm
> @@ +70,5 @@
> >  sub chargelostitem {
> >      my $dbh = C4::Context->dbh();
> >      my ($borrowernumber, $itemnumber, $amount, $description) = @_;
> > +    my $item  = Koha::Items->find($itemnumber);
> > +    my $itype = $item->itemtype;
> 
> Why the switch from effective_itemtype() to itemtype()?

So.. the change here is actually so we can have access to the Item object lower
down in the function.. the switch from finding the itemtype object directly to
using the Koha::Item level accessor method means we get back the
effective_itemtype object directly via the accessor.  See Koha::Item->itemtype
;P

> 
> ::: Koha/Item.pm
> @@ +1611,5 @@
> > +            }
> > +            elsif ( $_->{msg} =~
> > +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/
> > +              )
> > +            {    # The optional \W in the regex might be a quote or backtick
> 
> There is no \W in the regex. Wish it changed, or maybe the W should be lower
> case?

Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it
into DBIC at some point, but didn't feel it was appropriate here).. the `\W?`
is there.. just after `for column` in the regex.. not sure I follow your
question here I'm afraid.

-- 
You are receiving this mail because:
You are watching all bug changes.