[Koha-bugs] [Bug 31120] Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31120

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137333|0                           |1
        is obsolete|                            |

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 137526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137526&action=edit
Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is
blank/empty value

If the rule renewalperiod is the blank empty string instead of being
null/undefined or non-existant, Koha will interpret the renewal period as being
zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days
even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.