[Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from David Nind <david at davidnind.com> ---
(In reply to Kyle M Hall from comment #16)
> David, can you test again with the latest patch? It switches to using the
> offline circ checkout code. The idea behind "no block" is the patron already
> has it. It's basically SIP offline circ ( aka store and forward ) where the
> patron already has it so we'd better check it out to them! It makes sense to
> use the same code for both.

Hi Kyle.

I have retested

When I post the command in step 5 with the patches applied and after restarting
everything:
- Telnet exits saying: Connection closed by foreign host.
- The item is not checked out.

Commands entered after applying patches, flush_memcached, restart_all, and
koha-sip --restart kohadev:

telnet 127.0.0.1 6001
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
9300CNkoha|COkoha|CPCPL|
941
11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN|
Connection closed by foreign host.

>From the sip.log:

 87 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 88 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying *:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 89 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]:
Configuration::find_service: Trying 127.0.0.1:6001/tcp C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
 90 [2022/07/13 21:16:28] [4660] [DEBUG] [undef]@[undef]: raw_transport:
timeout is 60 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 91 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: read_request trimmed
1 character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 92 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: INPUT MSG:
'9300CNkoha|COkoha|CPCPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
 93 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '9300CNkoha...', '93'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 94 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]:
Sip::MsgType::_initialize('Login', '00CNkoha|COkoha|CPCPL', 'A1A1', '2', ...)
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 95 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: Successful login/auth
for 'koha' of 'CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 96 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: login_core: $VAR1 =
'ILS';
 97  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 98 [2022/07/13 21:16:43] [4660] [DEBUG] [undef]@[undef]: new ILS 'CPL'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
 99 [2022/07/13 21:16:43] [4660] [INFO] [undef]@[undef]: OUTPUT MSG: '941'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
100 [2022/07/13 21:16:43] [4660] [DEBUG] koha at 127.0.0.1: raw_transport:
uname/inst: 'koha/CPL' C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
101 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: read_request trimmed 2
character(s)  C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
102 [2022/07/13 21:16:56] [4660] [INFO] koha at 127.0.0.1: INPUT MSG:
'11YY20220711    16350220250711   
163502AOCPL|AA23529000035676|AB39999000001396|ACkoha|BON|BIN'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
103 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::new('C4::SIP::Sip::MsgType', '11YY202207...', '11'): seq.no '0',
protocol 2 C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
104 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
Sip::MsgType::_initialize('Checkout', 'YY20220711    16350220250711   
163502AOCPL|AA2    3529000035676|AB39999000001396|ACkoha|BON|BIN',
'A1A1A18A18', '38', ...) C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm
(220)
105 [2022/07/13 21:16:56] [4660] [WARN] koha at 127.0.0.1: received no-block
checkout from terminal 'koha' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
106 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: new
ILS::Patron(23529000035676): found patron '23529000035676' C4::SIP::Sip::siplog
/kohadevbox/koha/C4/SIP/Sip.pm (220)
107 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1: new
ILS::Item('39999000001396'): found with title 'Philippics.'
C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)
108 [2022/07/13 21:16:56] [4660] [DEBUG] koha at 127.0.0.1:
ILS::Transaction::Checkout performing checkout... C4::SIP::Sip::siplog
/kohadevbox/koh a/C4/SIP/Sip.pm (220)
109 [2022/07/13 21:16:56] [4660] [INFO] koha at 127.0.0.1: raw_transport: shutting
down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (220)

I'm assuming all three patches should be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.