[Koha-bugs] [Bug 29102] DecreaseLoanHighHolds will decrease loan period if borrower has an 'unfound' hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29102

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #128901|0                           |1
        is obsolete|                            |
 Attachment #128902|0                           |1
        is obsolete|                            |
 Attachment #128903|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 137722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137722&action=edit
Bug 29102: Do not count patron's own hold against limits

This patch makes two changes:
1 - The borrower's own holds are not counted towards HighHolds limit
2 - We exclude all hold counts from CanItemBeReserved

Previously a patron's hold could put the count over the threshhold, and
if the patron is only allowed 1 hold per record, and the hold wasn't found
before
the checkout, it would make all items unholdable, thus lowering the theshhold
for
dynamic HighHolds

To test:
1 - Set sysaprefs:
     decreaseLoanHighHolds  - enable
     decreaseLoanHighHoldsDuration - 1
     decreaseLoanHighHoldsValue - 1
     decreaseLoanHighHoldsControl - dynamic
     decreaseLoanHighHoldsIgnoreStatuses - blank
2 - Set circ rules to allow 1 hold per record and loan period of 5
3 - Find/create a record with 3 items
4 - Place a title level hold for a patron
5 - Attempt to checkout item - note warning about high holds
6 - Cancel checkout
7 - Set decreaseLoanHighHoldsControl - static
8 - Attempt checkout - note warning about high holds
9 - Apply patrch
10 - Checkout item - no warning
11 - checkin item, replace hold
12 - Set decreaseLoanHighHoldsControl - dynamic
13 - Checkout item - no warning
14 - prove t/db_dependent/DecreaseLoanHighHolds.t

-- 
You are receiving this mail because:
You are watching all bug changes.