[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #93 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
First of all: I quite like the functionality and how this looks. It also
appears to be pretty fast and accurate as far as I can tell. I especially like
that it's not only available for the keyword index, but also on other search
options like author search and limits the results down accordingly.

That said: There are a couple things here that would require fixing and a big
question we need to resolve for moving this forward.


The small stuff:
1) In the database update, there should still be a description for the system
preference.
2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the
prefs into the correct places.
3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2 in
coding guidelines)
4) In the database update elasticsearch should be Elasticsearch.


Somewhat bigger:

5) I have problems making this work with the "library catalog" and "title"
search options in simple search in OPAC. title doesn't give me any results and
library catalog looks like author (but it's a keyword search). Something might
not be 'wired' correctly there.
6) Updating installations: I believe you also need to reset mappings to make
this work? How can we ensure this works out of the box for people updating
without them having to "redo" their index configuration? (database update?)
7) sub filterAutocomplete looks complex and I wonder if it should be in the .pl
and not in a module where it can be tested. 942 is hardcoded as field for
OpacSuppression, which is a little risky. I wonder if it could be more elegant
to filter this at search time instead of after?


The last big question, I'll refer to the RM:

This adds to /svc which is the outdated way of doing things as others have
pointed out before. I think in order to move on here and before more time is
spend, we should come to a decision of what is required for this patch to make
it in and if it needs to be rewritten to use REST API or if this could be an
exception.

-- 
You are receiving this mail because:
You are watching all bug changes.