[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113

--- Comment #98 from Shi Yao Wang <shi-yao.wang at inLibro.com> ---
(In reply to Katrin Fischer from comment #93)
> First of all: I quite like the functionality and how this looks. It also
> appears to be pretty fast and accurate as far as I can tell. I especially
> like that it's not only available for the keyword index, but also on other
> search options like author search and limits the results down accordingly.
> 
> That said: There are a couple things here that would require fixing and a
> big question we need to resolve for moving this forward.
> 
> 
> The small stuff:
> 1) In the database update, there should still be a description for the
> system preference.
> 2) sysprefs.sql is sorted alphabetically to avoid conflicts, please move the
> prefs into the correct places.
> 3) Instead of use strict; use warnings; we use use Modern::Perl; (see PERL2
> in coding guidelines)
> 4) In the database update elasticsearch should be Elasticsearch.
> 
> 
> Somewhat bigger:
> 
> 5) I have problems making this work with the "library catalog" and "title"
> search options in simple search in OPAC. title doesn't give me any results
> and library catalog looks like author (but it's a keyword search). Something
> might not be 'wired' correctly there.
> 6) Updating installations: I believe you also need to reset mappings to make
> this work? How can we ensure this works out of the box for people updating
> without them having to "redo" their index configuration? (database update?)
> 7) sub filterAutocomplete looks complex and I wonder if it should be in the
> .pl and not in a module where it can be tested. 942 is hardcoded as field
> for OpacSuppression, which is a little risky. I wonder if it could be more
> elegant to filter this at search time instead of after?

Small stuff fixed.

5) Searching with "title" works for me. Maybe an index issue? or is it just me?

   "library catalog" search displays suggestions for each search options in
this order: title-cover, author, subject, title-series, publisher. What I think
probably happened is, since "title" search doesn't work for you, it showed
"author" suggestions where you had more match than the maximum number of rows
displayed.

6) I don't know :/

7) I can move it to a module, but which one? Maybe in a new module? if so,
where?
   I reused the code in opac/opac-detail.pl where 942 is hardcoded too.
   I do think it would be better to filter at search time but I don't know
how...

-- 
You are receiving this mail because:
You are watching all bug changes.