[Koha-bugs] [Bug 31086] Do not allow hold requests with no branchcode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good points raised there Tomas.. I was perhaps a little hasty in PQA.  We could
do better; as you highlighted we could be catching the constraint failure
rather than testing before hitting the database.. never sure which approach is
actually cleaner/better for performance.. it would be interesting to benchmark
that.

However, the DB update side is something I think we probably should try to
improve by making it a little more resilient.. we could look for nulls prior to
adding the constraint and arbitrarily pick the first branchcode in the branches
table to fix the data should we find any nulls?

Our database updates are better now in terms of not silently ignoring issues,
but I do think we as Devs aught to try and cater for more of these cases to
keep the upgrades fairly smooth.

I'm happy to add that proposed follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.