[Koha-bugs] [Bug 31202] Koha removes optional SIP fields with a value of "0"

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 21 18:22:32 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31202

Joonas Kylmälä <joonas.kylmala at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137947|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at iki.fi> ---
Created attachment 137988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137988&action=edit
Bug 31202: Don't remove optional SIP fields with a value of "0"

If the value of a SIP field is "0", that evaluates to false, so any calls to
maybe_add with a value of "0" will not get added to the SIP response message.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/SIP/Message.t

Signed-off-by: Michal Urban <michalurban177 at gmail.com>
JK: Adjust commit title

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list