[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Hi Alex,

I didn't test the patch, bug had a look at it.

A couple of remarks:
1. if you have the id you don't need to use a parent, the line could simply be
  $("#coce-coverimg").remove();
2. I am wondering if staff-side as well:

koha-tmpl/intranet-tmpl/js/coce.js:                               
$(this).closest(".coce-coverimg").remove();

We are using an id on the detail page
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:                   
    <div class="cover-image" id="coce-coverimg">

BUT a class on the result list
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:                  
 <div id="coce-coverimg-[% SEARCH_RESULT.biblionumber | html %]"
class="cover-image coce-coverimg">

-- 
You are receiving this mail because:
You are watching all bug changes.