[Koha-bugs] [Bug 31157] overdue_notices.pl --frombranch option should be available as a system preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31157

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've tried to understand how the code works and I think this doesn't quite work
the option and the pref describe it:

Set the from address for the notice to one of 'item-homebranch' or
'item-issuebranch'.

1) Option influences item selection

To test: 
* In Centerville, check out:
* 1 item from Centerville
* 1 item from Fairview

Run the overdue_notices script with default/item-issuebranch setting:
* checkout library is used, 1 notice, listing both items

Run the overdue_notices script with item-homebranch setting:
* home library is used, 2 notices, each listing 1 item

Conclusion: this is not only about the from address setting, but more
importantly it influence how the overdue items are grouped/selected.

2) Email settings

item-issuebranch
CPL is used 

item-homebranch
CPL and FPL are used, as you'd expect.

I feel like this works, but the descriptions make you think it's only about a
specific email header setting, which is not true. It will use the 'email
configuration' of either the home library or checkout library and it will group
the overdue items accordingly.

I'll try to provide a follow-up with a suggestion for a slightly different
wording.

-- 
You are receiving this mail because:
You are watching all bug changes.