[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jul 25 03:23:04 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #49 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #42)
> 3. The controller/svc script is pretty heavy right now.. I'd love to have
> seen more of this done 'in module' and have the controller lighter and
> perhaps in the REST side of things rather than a new /svc.. but I'm honestly
> not sure how it would fit in REST as yet so have no issue with it in /svc
> for now.

(In reply to David Cook from comment #46)
> One could argue that it shouldn't be in /svc or the REST API, because it's
> not really an API. It's just an authentication endpoint. In terms of the
> controller, it's really just redirecting a browser (and doing some backend
> work which should be in a module for sure).

Since the only Mojolicious implementation is the REST API, that means that the
controller really should stay in our bespoke Koha Plack/CGI scripts. 

With Bug 28325, I started working on a Mojolicious web UI base, but there was
just too much work to do solo, and I ran out of steam.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list