[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #128 from David Nind <david at davidnind.com> ---
Thanks Shi Yao, the patches now apply!

However, I've changed the status to Failed QA as there are:

1. Error traces after the patches are applied:

   a. See error traces for the staff interface - see [1], [2], and [3] (occurs
if the 'XSL - Simple Export' option for OpacExportOptions is either selected or
not selected).

   b. See error traces for the OPAC - see [4].

2. If the 'XSL - Simple Export' option for OpacExportOptions is not selected,
it still appears in the staff interface record details page as a save option.

3. The t/XSLT.t tests fail - see [5].

There is no option in the OPAC cart and lists to download as 'XSL - Simple
Export' - I'm not sure whether there should be or not...

Consolidated test plan so far:
1. Before applying the patches run the tests - these should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t
2. Check current download and save options:
   a. OpacExportOptions system preference: all options selected, note that
there is no 'XSL - Simple Export' option.
   b. for both the OPAC and the staff interface:
      (i) search and add some selected items to the cart: check the download
options - there is no 'XSL - Simple Export' option
      (ii) search and add some items to a new list: check the download lists
options - there is no 'XSL - Simple Export' option
      (iii) from the details page for a record in the OPAC: check the save
record options in the right sidebar, there is no 'XSL - Simple Export' option
      (iv) from the details page for a record in the staff interface: check the
save record options from the menu bar, there is no 'XSL - Simple Export' option
4. Apply the patches and reload everything (flush_memcached, restart_all, clear
your browser cache (or use an incognito/private window)).
5. For the OpacExportOptions system preference, select the new option 'XSL -
Simple Export'.
6. Repeat step 2 - there should now be an 'XSL - Simple Export' option
available for download or saving.
7. Select the 'XSL - Simple Export' in all the paces it appears in the OPAC and
 staff interface - an HTML file should be downloaded.
8. Open the HTML file - you should see the record's information.
9. Run the tests - they should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t

[1] Error trace after clicking on the cart in the staff interface: 

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_basket_basket_2epl::CustomXSLTExportList
called at /kohadevbox/koha/basket/basket.pl line 120
    ....

[2] Error trace when accessing the lists from the staff interface:

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_virtualshelves_shelves_2epl::CustomXSLTExportList
called at /kohadevbox/koha/virtualshelves/shelves.pl line 381
    ....

[3] Error trace when selecting Save > XSL - Simple Export from a record's
details page in the staff interface:

    Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_catalogue_export_2epl::GetMarcBiblio
called at /kohadevbox/koha/catalogue/export.pl line 95
    ....

[4] Error trace when selecting Save record > XSL - Simple Export from a
record's details page in the OPAC:

    Undefined subroutine &C4::Biblio::GetMarcBiblio called at
/kohadevbox/koha/opac/opac-export.pl line 145
    ....

[5] Failed tests for t/XSLT.t

prove -l t/XSLT.t
t/XSLT.t .. 2/12 
#   Failed test 'CustomXSLTExportList finds custom XSLTs'
#   at t/XSLT.t line 107.

#   Failed test 'Title is specified in root node'
#   at t/XSLT.t line 108.
Use of uninitialized value in string eq at t/XSLT.t line 109.

#   Failed test 'Title is filename if not specified'
#   at t/XSLT.t line 109.
# Looks like you failed 3 tests of 12.
t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/12 subtests 

Test Summary Report
-------------------
t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3)
  Failed tests:  10-12
  Non-zero exit status: 3
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.01 sys +  3.46 cusr  0.19
csys =  3.68 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.