[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David and Stefan,

looking into this and trying to rephrase what I think this does:

If an item is returned, we check if the patron is still restricted by an
OVERDUES restriction. If that's the case, we check if they have any remaining
checkouts that have triggered an OVERDUES restriction (are overdue long
enough). If there are no such remaining checkouts, we undebar.

Is that about right?

1) Could you please add a test plan and some description to the commit message?

2) You are missing the sysprefs.sql change for adding a new system preference
in your patch. And in the pref file, don't use yes/no, but 0/1.

3) The new pref is named: ODueDebarmentRemovalAllowUnrestricted

I wonder if instead of using a new pref, it might be nicer to change the
existing pref AutoRemoveOverduesRestrictions to have 3 options:

* Don't lift restriction
* Lift restriction if no more overdues
* Lift restriction if remaining overdues didn't trigger a restriction

(some native speaker might be able to help with a more elegant phrasing)

If we go with 2 separate preferences, they should be linked to each other in
the .pref (there are a lot of examples for this in the files). Also a bit
different name might be nice... but I have to admit, I don't have a good idea
right now. I think I'd really prefer not to have them separate.

4) Missing unit tests for the changes in Circulation.pm and Patron.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.