[Koha-bugs] [Bug 22070] OpacBrowseResults has broken link back to search results

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Have to conclude that this is not ready for passing QA yet.

Just removing the encoding/escaping does not look good.
We meet the issue here too of the encoding of CGI::Session. If we store unicode
stuff (in the URL) within param busc, how does it get stored and how should we
retrieve?
It feels like we should do conversion as early as we retrieve and as late as we
store it again. And such that it survives pure ASCII, Latin and 'real' Unicode.

-    use URI::Escape qw( uri_escape_utf8 uri_unescape );
+    use C4::Search;
This does not look good either. Probably we need to move URI::Escape to the
top.

The whole logic for Back and Next in this feature looks buggy. But that is
outside the scope of this report.

-- 
You are receiving this mail because:
You are watching all bug changes.