[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

--- Comment #93 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Happy birthday, here is a rebase 🎁 ^o^

I compared the old and new patches to double check that I didn't change
anything unknowingly.

However failed QA because a test is failing and it's also failing when rebasing
on an old(2021-08) master. So it's not from the rebase. #notmyjoblol


root at kohadevbox:koha((e781542349...))$ prove t/db_dependent/Koha/Hold.t
t/db_dependent/Koha/Hold.t .. 3/4 
    #   Failed test 'GetPreparedLetter not called if notify_patron passed and
no cancellation_reason passed'
    #   at t/db_dependent/Koha/Hold.t line 290.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 1 test of 12.
t/db_dependent/Koha/Hold.t .. 4/4 
#   Failed test 'cancel() tests'
#   at t/db_dependent/Koha/Hold.t line 297.
# Looks like you failed 1 test of 4.
t/db_dependent/Koha/Hold.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/4 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Hold.t (Wstat: 256 Tests: 4 Failed: 1)
  Failed test:  4
  Non-zero exit status: 1
Files=1, Tests=4, 10 wallclock secs ( 0.04 usr  0.00 sys +  7.23 cusr  1.52
csys =  8.79 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.