From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 00:10:48 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2022 22:10:48 +0000
Subject: [Koha-bugs] [Bug 29777] Fields 580 are wrong displayed in summary
column
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #3 from David Nind ---
Just checking what is required here, as I'm not sure how it displays now f
there are 580 entries and how it should display after the patch is applied.
I'm not that familiar with authorities, so I'm not really sure how they should
be "correctly" displayed.
Screenshots of before and after would help.
For me, if I add some 580 entries:
- Displays in the summary column as "See also" and then the entries with a
space between them.
- This is the same before and after the patch is applied.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 00:34:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 31 May 2022 22:34:23 +0000
Subject: [Koha-bugs] [Bug 29554] neworderempty.pl may create records with
biblioitems.itemtype NULL
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29554
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |david at davidnind.com
--- Comment #7 from David Nind ---
The patch no longer applies 8-(...
Also, just checking my understanding what is required here for testing.
Is it that when adding to a basket "From a new (empty) record", that for the
catalog details section the item type should be shown regardless of the setting
for the item-level_itypes system preference?
This is so that the record created has an item type, and it is not empty (which
can cause issues elsewhere in Koha if it is NULL).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 02:53:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 00:53:53 +0000
Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #18 from David Cook ---
(In reply to Jonathan Druart from comment #15)
> I think this is the correct approach, what do you think?
I'm not 100% sure.
I find that the code in ./admin/smart-rules.pl and Koha/CirculationsRules.pm is
very messy.
If we clear the cache after each set_rule() call, we'll be calling the function
~38 times (so 38 loops) for each add/update/delete in ./admin/smart-rules.pl.
We should only need to call it 1 time for each CRUD operation.
In terms of core code, it looks like Koha::CirculationRules->set_rule only gets
called in Koha/CirculationRules.pm and once accidentally in
./admin/smart-rules.pl (it should use set_rules instead). We do call set_rule()
a lot in the unit tests though.
I suppose occasional inefficient cache setting/clearing in
./admin/smart-rules.pl is worth a performance speed up during frequent
transactional work.
In fact, since we're using the L1 cache and the L1 cache is flushed at the end
of every HTTP/SIP request, clearing the cache (in ./admin/smart-rules.pl) is
actually probably totally unnecessary for production purposes.
The only time caching of circulation rules would be a potential problem is in
the unit tests.
So I'd say the cache clearing is messy but it's good enough.
(Side note: the circulation_rules table has an "id" column, so we should be
using that for for distinct update_rules/delete_rules operations.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:01:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:01:02 +0000
Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #19 from David Cook ---
(In reply to Jonathan Druart from comment #15)
> I think this is the correct approach, what do you think?
Since we are clearing the cache via set_rule, there's probably no harm in using
the L2 cache via Koha::Cache.
Nick has already signed off this version though, and I think this one is good
enough for now at least.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:02:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:02:51 +0000
Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #20 from David Cook ---
One last thing... we might want to rename this issue to be "Cache effective
circulation rules" because that would be more accurate than "Cache circulation
rules".
We're not just saving a database call by caching. We're saving a database call
that has embedded logic in it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:08:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:08:46 +0000
Subject: [Koha-bugs] [Bug 30182] background_jobs.status should be an ENUM
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30182
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:09:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:09:10 +0000
Subject: [Koha-bugs] [Bug 22659] Add 'save and continue' functionality to
news and HTML customizations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22659
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:09:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:09:32 +0000
Subject: [Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:11:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:11:17 +0000
Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when
importing an order from a file is invalid
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |david at davidnind.com
--- Comment #3 from David Nind ---
I get this message when trying to apply the patch (using koha-testing-docker) -
I think that this means the patch isn't correctly formatted, but I could be
wrong:
git bz apply 29607
Bug 29607 - addorderiso2709: The stored discount when importing an order from a
file is invalid
128127 - Patch for the bug 29607
Apply? [(y)es, (n)o, (i)nteractive] y
Traceback (most recent call last):
File "/usr/bin/git-bz", line 2716, in
applied = do_apply(bug_ref)
File "/usr/bin/git-bz", line 1827, in do_apply
users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
return self.__send(self.__name, args)
File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
verbose=self.__verbose
File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
return self.single_request(host, handler, request_body, verbose)
File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
response.msg,
xmlrpclib.ProtocolError:
Testing notes
~~~~~~~~~~~~~
The QA Team will probably want the commit message formatted according to
https://wiki.koha-community.org/wiki/Commit_messages I have drafted a test
plan, based on the comments in the bug description.
Bug 29607: Store the discount amount correctly when importing and order from a
file
This bug fixes how the discount amount for an order is stored, when an order is
added to a basket using "From staged MARC records".
Test plan:
1. Export a record (without the items) (Tools > Catalog > Export data).
2. Delete the record from the catalog (including any items).
3. Stage the record for import (Tools > Catalog > Stage MARC records for
import).
4. Create a new vendor with a discount of 25%. (Or select and existing vendor
that has a discount). (Acquisitions > New vendor)
5. Create a new basket for the vendor. (Acquisitions > Manage orders > search
for vendors > New > Basket).
6. Add to the basket using "From a staged file":
. select "Add orders" next to the staged file
. select the record to add to the order
. enter a price
. leave the discount field blank
. select a fund
. select "Save"
==> The order is created!
7. Modify the order - note that the discount is showing on the form as .25%
instead of 25%, also note that the discount amount is calculated correctly.
8. Check what is recorded in the database:
. koha-mysql kohadev
. select * from aqorders;
==> discount field for the basket item shows as 0.2500
9. Change the discount to 25%. Run step 8 again - discount amount will be
correctly shown as 25.0000
10. Apply the patch.
11. Repeat steps 1-9 - discount amount is shown and calculated correctly.
12. Test modifying the discount amount - should be calculated and shown
correctly.
13. Sign off!
See additional comments in the bug description.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:24:46 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:24:46 +0000
Subject: [Koha-bugs] [Bug 30327] Sort component parts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327
Michal Urban changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |michalurban177 at gmail.com
Status|Needs Signoff |Signed Off
--- Comment #7 from Michal Urban ---
Testing procedure:
- Enabled ShowComponentRecords
- Added 3 child records to record "E Street"
- There were varying biblionumbers for the child records, in the details of "E
Street" they were not displayed in ascending biblionumber order, instead in the
order they were attached.
- Applied patch and refreshed page
- Child record components displayed by ascending biblionumber order.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:28:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:28:55 +0000
Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #2 from David Nind ---
I'm not familiar with SIP2, but I would like to test.
Are you able to provide a test plan similar to bug 26871 or bug 20517? Ideally
with the commands to give, and the responses expected.
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 03:43:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 01:43:37 +0000
Subject: [Koha-bugs] [Bug 30327] Sort component parts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #8 from David Nind ---
>From IRC - oleonard, there is a component parts sample record attached to bug
11175 http://irc.koha-community.org/koha/2022-06-01#i_2427405
If you are using koha-testing-docker to sign off, these are the steps I
normally use (once .env file for koha-testing-docker is setup with Bugzillar
information) - this is so that your sign-off is added to the patch, and appears
on the dashboard:
1. git bz apply bug-number
2. Test and make sure things work as per the test plan.
3. git so 1
4. git bz attach -e bug-number HEAD~1..
5. Remove the # in front of the signoff line (note that there is text added
after the test plan, for example: "Signed-off-by: David Nind
"), the :wq
Notes:
- If more than one patch, change:
. git so 1 to the number of patches, for example: git so 2
. HEAD~1.. to the number of patches, for example: HEAD~2..
- see my cheat sheet https://gitlab.com/-/snippets/1893788
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:30:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 02:30:44 +0000
Subject: [Koha-bugs] [Bug 30873] New: "Libraries" link on OPAC should be
hideable by system preference
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873
Bug ID: 30873
Summary: "Libraries" link on OPAC should be hideable by system
preference
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
Most of my libraries don't want to show the "Libraries" link on the OPAC.
While you can hide it using Javascript, it's not a very elegant solution. There
should be a system preference to hide it (like every other option on that nav
bar besides "Advanced search").
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 02:30:56 +0000
Subject: [Koha-bugs] [Bug 30873] "Libraries" link on OPAC should be hideable
by system preference
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13388
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
[Bug 13388] Add library pages to the OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 04:30:56 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 02:30:56 +0000
Subject: [Koha-bugs] [Bug 13388] Add library pages to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13388
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |30873
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30873
[Bug 30873] "Libraries" link on OPAC should be hideable by system preference
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:03:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 06:03:36 +0000
Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
Status|Needs Signoff |Patch doesn't apply
--- Comment #5 from David Nind ---
Patch no longer applies 8-(..
git bz apply 26368
Bug 26368 - Add support for OCLC Encoding level values
120209 - Bug 26368: Add OCLC options to marc21_leader.tt
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26368: Add OCLC options to marc21_leader.tt
Using index info to reconstruct a base tree...
M installer/data/mysql/mandatory/sysprefs.sql
M
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
M
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/mandatory/sysprefs.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26368: Add OCLC options to marc21_leader.tt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:14:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 06:14:40 +0000
Subject: [Koha-bugs] [Bug 28301] Add ability to force re-run of a particular
DB update
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david at davidnind.com
--- Comment #10 from David Nind ---
Is this bug still relevant (from the comments)?
If it is, I will have a go at testing...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:55:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 06:55:17 +0000
Subject: [Koha-bugs] [Bug 29623] Cache circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #21 from Jonathan Druart ---
(In reply to David Cook from comment #18)
> (In reply to Jonathan Druart from comment #15)
> > I think this is the correct approach, what do you think?
>
> I'm not 100% sure.
>
> I find that the code in ./admin/smart-rules.pl and Koha/CirculationsRules.pm
> is very messy.
Let's say all our code is messy and so we don't need to tell it every week,
deal?
> If we clear the cache after each set_rule() call, we'll be calling the
> function ~38 times (so 38 loops) for each add/update/delete in
> ./admin/smart-rules.pl. We should only need to call it 1 time for each CRUD
> operation.
We could add a flag to set_rule to not clear the cache, and clear it from
set_rules. Would that work for you?
> In fact, since we're using the L1 cache and the L1 cache is flushed at the
> end of every HTTP/SIP request, clearing the cache (in
> ./admin/smart-rules.pl) is actually probably totally unnecessary for
> production purposes.
Seems a good practices to invalided the cache when the value might have
changed. That will prevent bugs in the future.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:55:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 06:55:39 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Cache circulation rules |Cache effective circulation
| |rules
--- Comment #22 from Jonathan Druart ---
(In reply to David Cook from comment #20)
> One last thing... we might want to rename this issue to be "Cache effective
> circulation rules" because that would be more accurate than "Cache
> circulation rules".
Done.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 08:57:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 06:57:34 +0000
Subject: [Koha-bugs] [Bug 28301] Add ability to force re-run of a particular
DB update
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28301
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |RESOLVED
Resolution|--- |INVALID
--- Comment #11 from Jonathan Druart ---
I don't think so. Nick, please reopen if you disagree.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:01:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:01:12 +0000
Subject: [Koha-bugs] [Bug 29623] Cache effective circulation rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623
--- Comment #23 from David Cook ---
(In reply to Jonathan Druart from comment #21)
> Let's say all our code is messy and so we don't need to tell it every week,
> deal?
Hehe deal.
> We could add a flag to set_rule to not clear the cache, and clear it from
> set_rules. Would that work for you?
I thought about that but the existing patches are already signed off, so it's
probably not a necessary optimization at this point.
> > In fact, since we're using the L1 cache and the L1 cache is flushed at the
> > end of every HTTP/SIP request, clearing the cache (in
> > ./admin/smart-rules.pl) is actually probably totally unnecessary for
> > production purposes.
>
> Seems a good practices to invalided the cache when the value might have
> changed. That will prevent bugs in the future.
Agreed.
--
Overall, I don't see any blocks/fails for this one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:13:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:13:19 +0000
Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548
--- Comment #3 from Stefan Berndtsson ---
(In reply to David Nind from comment #2)
> I'm not familiar with SIP2, but I would like to test.
I don't have an instance without the patch near me at the moment that can run
SIP commands, but it should be something like (tweak credentials and such as
needed):
Barcode 123123123 is a barcode that is not in the database.
1. Have SIP-server running
2. ./sip_cli_emulator.pl -m checkin -a localhost -p 6001 -l 123 -su sipuser -sp
sippass -t CR --item 123123123
3. See that AQ is missing completely.
4. Apply patch
5. Run same command again.
6. See that AQ| is present.
That is the expected situation, but as mentioned, I haven't tested the
non-patched version.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:19:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:19:00 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #205 from Jonathan Druart ---
> Bug 12446: Schema update Category.pm
Please note that you must provide the specific change (is_boolean part) in a
separate patch.
The workflow is:
* run `dbic`
* commit with "DBIC changes" (this patch won't be pushed by the RM, they will
regenerate it themselves)
* Edit the schema files and add what you need below the "DO NOT MODIFY" line
* commit (ideally with "DBIC specific" or similar)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:21:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:21:26 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #206 from Jonathan Druart ---
(In reply to Shi Yao Wang from comment #204)
> (In reply to Jonathan Druart from comment #196)
> > Can you please review the whole patch set carefully to make it ready for QA?
> >
> > It took me 3 min to catch trivial errors:
> > * merge marker
> > +<<<<<<< HEAD
> >
> > * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql
> > has been removed, this patch set reintroduce it
> >
> > * in members/memberentry.pl there are 2 calls to search_with_library_limits
> >
> > * still memberentry.pl
> > You are adding yet another fetch of the patron category:
> > Koha::Patron::Categories->find
> > It's fetched several times already in the same script
> >
> > * t/db_dependent/Patrons.t l.206: extra spaces
>
> Fixed mentioned errors except "Koha::Patron::Categories->find". It would
> require a new variable near the beginning of the script (after "my
> $categorycode ...") that stores
> "Koha::Patron::Categories->find($categorycode)" and would also require
> changing every place where the script uses it for consistency. I don't know
> if it's a good idea to do it here. Maybe a separate bug?
Agreed, please open it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:24:43 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:24:43 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:07 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:18 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #135506|0 |1
is obsolete| |
Attachment #135507|0 |1
is obsolete| |
Attachment #135508|0 |1
is obsolete| |
Attachment #135510|0 |1
is obsolete| |
Attachment #135511|0 |1
is obsolete| |
Attachment #135512|0 |1
is obsolete| |
--- Comment #207 from Jonathan Druart ---
Created attachment 135519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135519&action=edit
Bug 12446: Ability to allow guarantor relationship for all patron category
types
This adds a new field "Can be guarantee" to patron categories so it
becomes possible for any category type to have a guarantor.
To test:
1) Have a patron category of type 'Adult' and one of type 'Child'
2) Confirm, by searching for the "Patron guarantor" fieldset in the
edit/create form, that:
=> a patron of the first category can't have a guarantor
=> a patron from the second category can
3) Apply patch and run updatedatabase.pl
4) Edit the categories and note the new "Can be guarantee" field
5) It should have been set to "yes" for the "Child" and to "no" for
the "Adult"
5) Repeat step 2. It should behave in the same way.
6) Edit the "Can be guarantee" for any of the category and check
that the fieldset only appears when "Can be guarantee" is set to "yes"
7) prove t/db_dependent/Patrons.t
=> tests should still pass
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
Signed-off-by: David Nind
Signed-off-by: Owen Leonard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:29 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #208 from Jonathan Druart ---
Created attachment 135520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135520&action=edit
Bug 12446: Schema update Category.pm
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
Signed-off-by: David Nind
Signed-off-by: Owen Leonard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:39 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #209 from Jonathan Druart ---
Created attachment 135521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135521&action=edit
Bug 12446: Limit available categories when using "Add guarantee" button
Test plan:
1) Have some patron categories that can and cannot be guarantee
2) Visit a patron's account and click the "Add guarantee" button
3) In the "category" dropdown, note that all categories are available
4) Apply this patch
5) Repeat step 2 and 3; the dropdown now only contains the categories
for which "can be guarantee" is set to "Yes".
Signed-off-by: Kyle M Hall
Signed-off-by: David Nind
Signed-off-by: Owen Leonard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:49 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #210 from Jonathan Druart ---
Created attachment 135522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135522&action=edit
Bug 12446: Fix typos
Signed-off-by: Owen Leonard
JD Amended patch: squashed and edited commit message
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:30:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:30:59 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #211 from Jonathan Druart ---
Created attachment 135523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135523&action=edit
Bug 12446: Add canbeguarantee value to patron categories sample data
This patch changes sample data so patron categories of type 'C' or
'P' can be guarantees by default.
Signed-off-by: Salman Ali
Signed-off-by: Salman Ali
Signed-off-by: David Nind
Signed-off-by: Owen Leonard
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 09:49:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 07:49:50 +0000
Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950
Ray Delahunty changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |r.delahunty at arts.ac.uk
--- Comment #10 from Ray Delahunty ---
Following a number of complaints relating to gender self-identity we have
changed our data feed from the university registry system to pull the
'Preferred name' rather than the 'Given name' from that system and use that to
populate the borrowers.firstname . When we move to using API available in 21.05
we will also be massively trimming back what is included in the borrowers table
and will be removing title and sex (for example) as they are not relevant to
the services we provide. We are being offered a 'personal pronoun' and I think
we will store this in borrowers.sort1 for now, and display it to library staff.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:08:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:08:39 +0000
Subject: [Koha-bugs] [Bug 30874] New: Simplify patron category handling in
memberentry
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
Bug ID: 30874
Summary: Simplify patron category handling in memberentry
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart+koha at gmail.com
Reporter: jonathan.druart+koha at gmail.com
QA Contact: testopia at bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:09:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:09:36 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |30874
--- Comment #212 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #206)
> (In reply to Shi Yao Wang from comment #204)
> > Fixed mentioned errors except "Koha::Patron::Categories->find". It would
> > require a new variable near the beginning of the script (after "my
> > $categorycode ...") that stores
> > "Koha::Patron::Categories->find($categorycode)" and would also require
> > changing every place where the script uses it for consistency. I don't know
> > if it's a good idea to do it here. Maybe a separate bug?
>
> Agreed, please open it.
Done, see bug 30874
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
[Bug 30874] Simplify patron category handling in memberentry
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:09:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:09:36 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |12446
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:10:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:10:50 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
--- Comment #1 from Jonathan Druart ---
Created attachment 135524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135524&action=edit
Bug 30874: Replace categoryname
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:10:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:10:54 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
--- Comment #2 from Jonathan Druart ---
Created attachment 135525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135525&action=edit
Bug 30874: Reduce number of category fetches
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:10:58 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:10:58 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
--- Comment #3 from Jonathan Druart ---
Created attachment 135526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135526&action=edit
Bug 30874: 2 more - need more investigation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:11:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:11:02 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
--- Comment #4 from Jonathan Druart ---
Created attachment 135527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135527&action=edit
Bug 30874: Simplify categories loop construction
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:12:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:12:29 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |In Discussion
--- Comment #5 from Jonathan Druart ---
Fancy a code golf?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:29:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:29:34 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #135527|0 |1
is obsolete| |
--- Comment #6 from Jonathan Druart ---
Created attachment 135528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135528&action=edit
Bug 30874: Simplify categories loop construction
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 10:29:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 08:29:39 +0000
Subject: [Koha-bugs] [Bug 30874] Simplify patron category handling in
memberentry
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874
--- Comment #7 from Jonathan Druart ---
Created attachment 135529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135529&action=edit
Bug 30874: Remove category_type
In which case do we pass category_type to this script? Am I missing
something?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:45:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 09:45:47 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
function for staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:45:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 09:45:54 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
function for staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131544|0 |1
is obsolete| |
--- Comment #17 from David Nind ---
Created attachment 135530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135530&action=edit
Bug 30077: Add system preference IntranetAddMastheadLibraryPulldown
To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search the
catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It should
correcrly limit to that branch BUT it should also default back to 'All
libraries' for the next search.
9. Try selecting 'All libraries' from the top of the dropdown and make sure it
is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it
looks nice with both of those dropdowns and functions when you use limiters
from both dropdowns.
Signed-off-by: Sally
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:46:00 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 09:46:00 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
function for staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #132982|0 |1
is obsolete| |
--- Comment #18 from David Nind ---
Created attachment 135531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135531&action=edit
Bug 30077: (follow-up) retain branch selection
To test:
1. Apply patch, updatedatabase, restart_all
2. Search for the system pref 'IntranetAddMastheadLibraryPulldown'
3. Set it to 'Show'.
4. Go to any page that contains header search box and click on 'Search the
catalog'.
5. To the left of the search bar you should see a dropdown for branches.
6. This should be defaulted to 'All libraries'.
7. In the dropdown choose any branch and do a search and make sure it is
correctly limiting to that branch.
8. Try changing to a different branch and doing another search. It should
correcrly limit to that branch and retain that branch in the dropdown, just
like the OPAC.
9. Try selecting 'All libraries' from the top of the dropdown and make sure it
is correctly searching all branches.
10. Turn on the system pref 'IntranetCatalogSearchPulldown' and make sure it
looks nice with both of those dropdowns and functions when you use limiters
from both dropdowns.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jun 1 11:46:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jun 2022 09:46:08 +0000
Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search
function for staff interface
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077
David Nind changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #133037|0 |1
is obsolete| |
--- Comment #19 from David Nind ---
Created attachment 135532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135532&action=edit
Bug 30077: (follow-up) Set max width for library drapdown
If you have a library with a very long name the dropdown will expand to
accommodate it. I think this is awkward-looking, so I propose to set a
max width on