[Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
I get this message when trying to apply the patch (using koha-testing-docker) -
I think that this means the patch isn't correctly formatted, but I could be
wrong:

git bz apply 29607

Bug 29607 - addorderiso2709: The stored discount when importing an order from a
file is invalid

128127 - Patch for the bug 29607

Apply? [(y)es, (n)o, (i)nteractive] y
Traceback (most recent call last):
  File "/usr/bin/git-bz", line 2716, in <module>
    applied = do_apply(bug_ref)
  File "/usr/bin/git-bz", line 1827, in do_apply
    users = bug.server.get_xmlrpc_proxy().User.get({ 'names': [patch.attacher]
})['users']
  File "/usr/lib/python2.7/xmlrpclib.py", line 1243, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1602, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1283, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1331, in single_request
    response.msg,
xmlrpclib.ProtocolError: <ProtocolError for bugs.koha-community.org/xmlrpc.cgi:
404 Not Found>

Testing notes
~~~~~~~~~~~~~

The QA Team will probably want the commit message formatted according to
https://wiki.koha-community.org/wiki/Commit_messages I have drafted a test
plan, based on the comments in the bug description.

Bug 29607: Store the discount amount correctly when importing and order from a
file

This bug fixes how the discount amount for an order is stored, when an order is
added to a basket using "From staged MARC records".

Test plan:
1. Export a record (without the items) (Tools > Catalog > Export data).
2. Delete the record from the catalog (including any items).
3. Stage the record for import (Tools > Catalog > Stage MARC records for
import).
4. Create a new vendor with a discount of 25%. (Or select and existing vendor
that has a discount). (Acquisitions > New vendor)
5. Create a new basket for the vendor. (Acquisitions > Manage orders > search
for vendors > New > Basket).
6. Add to the basket using "From a staged file":
   . select "Add orders" next to the staged file
   . select the record to add to the order
   . enter a price
   . leave the discount field blank
   . select a fund
   . select "Save"
   ==> The order is created!
7. Modify the order - note that the discount is showing on the form as .25%
instead of 25%, also note that the discount amount is calculated correctly.
8. Check what is recorded in the database:
   . koha-mysql kohadev
   . select * from aqorders;
   ==> discount field for the basket item shows as 0.2500
9. Change the discount to 25%. Run step 8 again - discount amount will be
correctly shown as 25.0000
10. Apply the patch.
11. Repeat steps 1-9 - discount amount is shown and calculated correctly.
12. Test modifying the discount amount - should be calculated and shown
correctly.
13. Sign off!

See additional comments in the bug description.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.