[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

--- Comment #206 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Shi Yao Wang from comment #204)
> (In reply to Jonathan Druart from comment #196)
> > Can you please review the whole patch set carefully to make it ready for QA?
> > 
> > It took me 3 min to catch trivial errors:
> > * merge marker
> > +<<<<<<< HEAD
> > 
> > * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql
> > has been removed, this patch set reintroduce it
> > 
> > * in members/memberentry.pl there are 2 calls to search_with_library_limits
> > 
> > * still memberentry.pl
> > You are adding yet another fetch of the patron category:
> > Koha::Patron::Categories->find
> > It's fetched several times already in the same script
> > 
> > * t/db_dependent/Patrons.t l.206: extra spaces
> 
> Fixed mentioned errors except "Koha::Patron::Categories->find". It would
> require a new variable near the beginning of the script (after "my
> $categorycode ...") that stores
> "Koha::Patron::Categories->find($categorycode)" and would also require
> changing every place where the script uses it for consistency. I don't know
> if it's a good idea to do it here. Maybe a separate bug?

Agreed, please open it.

-- 
You are receiving this mail because:
You are watching all bug changes.