[Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jun 1 14:16:13 CEST 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607
Jonathan Druart <jonathan.druart+koha at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128127|0 |1
is obsolete| |
--- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Created attachment 135538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135538&action=edit
Bug 29607: Store the discount amount correctly when importing and order from a
file
This bug fixes how the discount amount for an order is stored, when an order is
added to a basket using "From staged MARC records".
Test plan:
1. Export a record (without the items) (Tools > Catalog > Export data).
2. Delete the record from the catalog (including any items).
3. Stage the record for import (Tools > Catalog > Stage MARC records for
import).
4. Create a new vendor with a discount of 25%. (Or select and existing vendor
that has a discount). (Acquisitions > New vendor)
5. Create a new basket for the vendor. (Acquisitions > Manage orders > search
for vendors > New > Basket).
6. Add to the basket using "From a staged file":
. select "Add orders" next to the staged file
. select the record to add to the order
. enter a price
. leave the discount field blank
. select a fund
. select "Save"
==> The order is created!
7. Modify the order - note that the discount is showing on the form as .25%
instead of 25%, also note that the discount amount is calculated correctly.
8. Check what is recorded in the database:
. koha-mysql kohadev
. select * from aqorders;
==> discount field for the basket item shows as 0.2500
9. Change the discount to 25%. Run step 8 again - discount amount will be
correctly shown as 25.0000
10. Apply the patch.
11. Repeat steps 1-9 - discount amount is shown and calculated correctly.
12. Test modifying the discount amount - should be calculated and shown
correctly.
13. Sign off!
See additional comments in the bug description.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
More information about the Koha-bugs
mailing list