[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
> I guess you're talking about the is_enabled method (which calls
> retrieve_data) ?
> I think we should not ask the plugin itself if it's enabled because a plugin
> can override this method.
> It also produces less SQL queries that way (one query to retrieve all
> enabled plugins, instead of one query per module)

I think this is a reasonable stance to take. We control the internals so we
don't need to make is_enabled a chokepoint. A single query selecting all
plugins where plugins data __ENABLED__ is 1 seems like a good idea to me.

-- 
You are receiving this mail because:
You are watching all bug changes.