[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jun 3 11:27:40 CEST 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697
--- Comment #68 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Jonathan Druart from comment #67)
> (In reply to Marcel de Rooy from comment #60)
> > (In reply to Jonathan Druart from comment #59)
> > > (In reply to Marcel de Rooy from comment #48)
> > > > +my $invalid_marc_record = $@ || !$marc_record;
> > > > +if ($invalid_marc_record) {
> > > > + $template->param( decoding_error => $@ );
> > > >
> > > > Theoretically $@ might be empty but there is not $marc_record.
> > > > So you could provide a fallback for no error message in the last line..
> > >
> > > Indeed. No idea what's better. Do you think we need to pass another variable
> > > to the template (invalid_marc_record set to 1)?
> >
> > Or just $@ // 'some great message' to keep it simple and not touch the
> > template?
>
> An untranslatable message? :)
I would keep like that for now, and see if we need to improve later.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list