[Koha-bugs] [Bug 30409] barcodedecode() should always trim barcode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409

--- Comment #20 from David Nind <david at davidnind.com> ---
(In reply to Peter Vashchuk from comment #18)
> Rebased on current master

Thanks Peter. 

Have retested and changed to signed off. Things now seem to work as expected.

I think what I was getting confused with, was that if a barcode in the actual
item had spaces before and after, then this was not found on input forms. This
was the case both before and after the patch was applied:
1. Edit a barcode for an item so that it has spaces before and after.
2. Check input forms such as Check out - item not found.
3. After patch applied, item still not found, for example Check out input form.
4. Edit item, save - spaces before and after removed and now found on input
forms even if extra spaces added on input forms.

Other testing notes:

1. Card barcodes: worked before and after patch for Check out, Search patrons,
and Patron lists.

2. Item barcodes: worked before and after patch applied:
   . From header block: Check out, Check in, Renew
   . Add reserves
   . Search (keyword)
   . From Circulation screen: Check out, Check in, Renew, Transfers, Overdue
report
   . Batch checkout
   . Tools: Batch item deletion, Batch item modification

3. Item barcodes: didn't work before the patch, but now works after patch
applied:
   . Tools: Barcode image generator, Rotating collections, Inventory

4. Item barcodes: didn't work before the patch, and don't work after patch -
possible future enhancements:
  . Lists
  . Quick spine label creator
  . Item search - barcode is

-- 
You are receiving this mail because:
You are watching all bug changes.