[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #16 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Marcel and David,

Apologies it seems I was overly optimistic about when I could get back to this
bug report. Thank you David for replying to my request for comment email to the
community mailing list!

I have been working on this patchset this evening and I tried to add the
following line to the else block of restart_plack() in
debian/scripts/koha-plack:
stop_plack $instancename && start_plack $instancename

I found that when plack is not running if I tried koha-plack --restart I would
get the following error from that above line:
[FAIL] Error: Plack not running for kohadev: failed!

I had a discussion with Chris C about this and we concluded that you cannot
stop a service that is not running. You will only get an error that the service
is not running.

Looking at how Apache does it we thought it would be best for the restart
functions in the koha-* scripts to check if the service is running and if not
then only start the service, not try to stop then start.

Our proposed functionality is contained in the attached patchset for all the
koha-* scripts with restart functions. 

Can you please let me know your thoughts when you have a chance?

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.