[Koha-bugs] [Bug 30789] Improve performance of AddBiblio when record has items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30789

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #9)
> (In reply to Marcel de Rooy from comment #8)
> > I agree with this patch, no problem about that.
> > But the performance gain should be close to zero.
> > Running Biblio.t (calling AddBIblio) twice with and without patch:
> > RM: I would suggest to revise the title unless we have clear feedback to
> > prove the statement. Keeping the release notes a bit more realistic?
> 
> The gain is only going to come when you have records that contain items. 
> 
> Testing with NYTProf against an import with record containing items, there
> was a clear improvement
> 
> Biblio.t does not add items to most records, so the savings will be minimal
> if present

When you look at the AddBiblio code, you will be surprised to see that this
routine does not add items at all.
During import you need something as BatchCommitItems to add items.

So the title of this report still needs attention :)

-- 
You are receiving this mail because:
You are watching all bug changes.