[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 8 13:40:47 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813

--- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #41)
> (In reply to Marcel de Rooy from comment #40)
> > (In reply to Nick Clemens from comment #39)
> > > Why add the qw(); to the use statements?
> > 
> > That is essential to prevent needlessly importing all default exported
> > routines from the module. (EXPORT_OK routines)
> 
> From bug 17600 I understood that EXPORT_OK was 'on demand' i.e. only
> explicitly named subroutines are imported. Is that incorrect?

Ah. You might very well be right. EXPORT versus EXPORT_OK
So yes, might not be needed then. But explicitly stating that you dont want to
import cannot be wrong either. I would recommend keeping them.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list