[Koha-bugs] [Bug 29623] Cache effective circulation rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623

--- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Martin Renvoize from comment #24)
> I think we can probably call this one PQA now.. but I'd love to see a
> follow-up but to convert to Koha::Cache as we've pretty much done all the
> work here to make sure we're resetting the caches as required on changes and
> caching for longer makes sense.

Yes, maybe. However I am expecting several adjustments in test files as we are
deleting all the entries from circulation_rules in some tests.

> I'm also interested in David's suggestion about using ID's for the cache
> key, but I've not investigated the code to validate that myself.

I don't think it's possible, get_effective_rule_value does not have the ID.

-- 
You are receiving this mail because:
You are watching all bug changes.