[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904

--- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Janusz Kaczmarek from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > (In reply to Janusz Kaczmarek from comment #3)
> > > To sum up—I would suggest considering the patch OK, but probably data
> > > definition introduced by you with the commit
> > > 8df3116760bdf1b889dc6f78e4605e231c4d7d6d requires correction as well.  IMO,
> > > UNIQUE KEY `additional_contents_uniq` (`category`,`code`,`lang`) would be
> > > perfect. 
> > 
> > Which means you couldn't have 2 identical contents for different libraries?
> > Sounds wrong to me.
> 
> Why not?  In every case you have to create them separately, which means they
> would get a different additional_contents.code.  The presence or absence of
> branchcode in unique key does not change anything here, IMHO.

You are right. I would like to not modify the DB structure and keep the patch
as simple as possible, for backporting purposes.

When I rewrote this module I wanted to stick to the same structure as the
'letter' one. I should not have done that, and preferred a better architecture.
This table should have been split into two. Unfortunately it's now too much
work and I won't have time for that soon.

-- 
You are receiving this mail because:
You are watching all bug changes.