[Koha-bugs] [Bug 30742] Confusion when placing hold on record with no items available because of not for loan

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30742

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 135906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135906&action=edit
Bug 30742: [21.11.x] Prevent placing holds on items/records where all items
notforloan Bug 30742: Remove 'bad_bibs' and send a list of holdable bibs Bug
30892: (bug 30742 follow-up) Send single bib as a holdable bib

Rebeased/rewritten patch - includes fix from 30892

This patch does a few things:
1 - Adds itemtype not for loan status to display
2 - Adds a conditional to display notforlaon status as the reason a hold cannot
be placed
3 - Seperates the lower 'Place hold(s)' buttons for single and multi holds into
two template sections
4 - Handles the case where all bibs in a multi hold have no items available
5 - Disables the button for single hlds when all items are unavailable

To test:
 1 - Find or create a record with all items of itemtype marked 'notforloan'
 2 - Attempt to place single hold on this record from staff client
 3 - See one disab;ed button, one enabled 'Place holds' button
 4 - Click 'Place holds' - hold placed
 5 - Cancel hold
 6 - Place multiple holds with some bibs that can be held, and this one that
cannot
 7 - Notice message that 'Cannot place hold on some items'
 8 - Click 'Place holds' - hold is generated for the notforloan bib
 9 - Apply patch
10 - Place single hold
11 - Note you now see not for loan status on items
12 - Note the red x also includes message abnout not for loan status
13 - Note the 'Place hold' button is disabled
14 - Attempt multi hold
15 - Message now includes "No items available: One or more records have no
items that can be held"
16 - Click 'Place holds'
17 - Above still places the hold - this is for a followup patch

Currently place request gets a list of bad_bibs that is created via javascript
on the
template. It ignores this list

Ths patch instead doesn't add info for bad bibs, and provides a list of the
bibs that
can be held

To test:
1 - Attempt multi hold with some items that can be held, and one that cannot
due to notforloan
2 - Fill in pickup locations and place hold
3 - Note hold is place on bib with no avilable items and hsows twice in results
4 - Apply patch
5 - repeat with another patron
6 - Note no aidditonal hold on record with notforloan items
7 - Note with with not for loan items appears only once in results

Bug 30892
To test:
1. Try placing hold
2. Everything seems to work but no hold gets placed.
3. Apply patch
4. Verify holds are no placed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.