[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to Thomas Klausner from comment #9)
> I could give it another go, but I'll most likely will have to do that on my
> own time (which is fine by me regarding money etc, but it's the most limited
> time slot I have...)

I can relate to that on several projects :(

> So yes, I'd like to finish this feature, but I'm not sure I can prepare a
> patch that's nice enough for you and/or easy to test (mostly because I still
> did not get around to set up a proper Koha dev environment).

Also relatable.

Regarding a proper Koha dev environment, take a look at
https://gitlab.com/koha-community/koha-testing-docker. I think a lot of people
run it on Mac/Linux but I run it on Windows. So happy to answer any questions
you might have about it. It makes Koha dev much easier. 

> I also have some architectural concerns / ideas about how the background
> jobs are implemented (eg having to list all the background job classes in
> the source code seems a bit redundant), but I think it's better to discuss
> those in another issue (or just via mail) instead of bloating this issue.

I have voiced the same concern but I think we might be the minority there. 

I think Bug 29149 re-organized the hard-coded list into a different hard-coded
list in Koha::BackgroundJob.

However, Bug 27783 removed the hard-coded list from
misc/background_jobs_worker.pl at least. 

So halfway there. I don't understand the resistance to not having a hard-coded
allow list. I think its security value is very limited and just makes the
system much less usable...

-- 
You are receiving this mail because:
You are watching all bug changes.