[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #21)
> There is something wrong in the design here.
> I really don't think it's correct to pass the marc to
> Koha::Biblio->get_marc_notes
> 
> I feel like we need a Koha::MARC class that would have the 'get_notes'
> method.
> 
> Koha::Biblio->get_marc_notes fetches the marc and call it
> If you have a marc already you could call it directly.

We allow for optionally passing the marc (at Davids request)... but yes, I
generally agree.. there's a bug 'move get_marc_* methods to
Koha::Biblio::Metadata.. which Tomas raised and I've been trying to think of
how to achieve.. this is one of the stepping stones towards that end.

-- 
You are receiving this mail because:
You are watching all bug changes.