[Koha-bugs] [Bug 29454] Stash itemtypes in plugin objects to reduce DB calls

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jun 15 00:05:00 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454

--- Comment #10 from Fridolin Somers <fridolin.somers at biblibre.com> ---
(In reply to Fridolin Somers from comment #7)
> Maybe add an early return q{} if itemtypecode is undefined,
> to avoid warning in concatenation :
> my $cache_key    = $want_parent ?
> "Itemtype_parent_description:".$itemtypecode : "Itemtype_description:" .
> $itemtypecode;

I've added this.
And also a write of empty string in cache when item type is not found.
I signed first patch.

Added a unit test for Koha::Template::Plugin::ItemTypes.
This needs SO.

Best regards,
Run Koha, run ... ^^

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list