[Koha-bugs] [Bug 29282] Show items.issue and items.renewals in the holdings table on the detail page in the staff interface

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #11)
> (In reply to Victor Grousset/tuxayo from comment #10)
> > Is there a reason to use the classes issues_field and renewals_field for the
> > values when the other columns don't have the _field prefix? There doesn't
> > seem to be a name clash in the file with issues and renewals.
> > 
> > Otherwise everything looks good for QA.
> 
> I think those classes already has associated styles, and this was just a way
> to differentiate the view on this page

I see a .renewals rule in staff-global.scss (though I'm struggling to find
anything using the class in the templates right now) but I don't see any rules
that would catch an 'issues' class.

I think personally I'd like to see the consistency carried through and the
_field dropped from the class names.

Asking Owen for an opinion in case I've missed something obvious.

-- 
You are receiving this mail because:
You are watching all bug changes.