[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Martin Renvoize from comment #6)
> (In reply to Joonas Kylmälä from comment #5)
> > Good improvement! Just a small nit: as BatchCommitItems is a public function
> > it should take either skip_record_index as a parameter or document clearly
> > that it doesn't do indexing and it is left to the caller.
> 
> Good Catch..
> 
> I'm wondering if the third option is to rename the function to be
> 'private'.. it appears to only be called inside this module and isn't
> exported either.  Certainly some POD around it would also be sensible though.

Just a thought. Not sure if we should invest time in renaming C4 functions
private rather than getting them out of C4 ;)
There will be a bunch more. Wouldnt rename them all.
This is done, no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.