[Koha-bugs] [Bug 30822] BatchCommit does not deal with indexation correctly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 17 11:27:39 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30822

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136219|0                           |1
        is obsolete|                            |

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 136248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136248&action=edit
Bug 30822: Clarify that BatchCommitItems is a private function

BatchCommitItems is only being used within this module and isn't
mentioned in EXPORT_OK. This patch simply renames it to
_batchCommitItems to take the _ standard for private functions and also
adds a little hint to the POD of the function to clarify that the caller
must trigger a re-index.

JK: Amended patch to rename also the function in t/db_dependent/ImportBatch.t
    and fix typo "commiting" => "commiting"

Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list