[Koha-bugs] [Bug 28854] Add ability to create bundles of items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #181 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
0) Documentation

Read the documentation, really helpful! (comment :) )

1) Unit tests (question)

Unit tests pass. Changes marked with . have new unit tests added, but we might
be missing some for the changes to checkout and holds? Hope I didn't miss them:

Koha/Item 
  checkout
.  return_claims (new)
.  return_claim (new)
  holds
.  bundle_items (new)
.  is_bundle (new)
.  bundle_host (new)
.  in_bundle (new)
.  add_to_bundle (new)
.  remove_from_bundle (new)
C4/Circulation 
.  AddReturn 


2) Database update, installer

a) The new table has the columns host and item, I was wondering if they should
not have _id added to match conventions on the API etc. (question)

b) I like the 'trick' on adding the LOST and NOT_LOAN values. (comment)

c) installer/data/mysql/en/optional/auth_val.yml requires updating for the new
system preference values (blocker)

d) Changes to sysprefs.sql are missing. We can use the values from d) to
pre-set the preferences for new installations correctly. (blocker)


3) Translatability, spelling, terminology

a) detail.pl - buttons and other text in js (blocker)

bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal"
data-target="#addToBundleModal" data-item="' + itemnumber + '"><i class="fa
fa-plus"></i> Add to bundle</a>');

bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal"
data-target="#removeFromBundleModal" data-item="' + itemnumber + '"><i
class="fa fa-minus"></i> Remove from bundle</a>');

$('#addResult').replaceWith('<div id="addResult" class="alert
alert-success">Success: Added '+barcode+'</div>');

$('#addResult').replaceWith('<div id="addResult" class="alert
alert-warning">Warning: Item '+barcode+' already attached</div>');
} else {
$('#addResult').replaceWith('<div id="addResult" class="alert
alert-danger">Failure: Item '+barcode+' belongs to another bundle</div>');
}
} else {
$('#addResult').replaceWith('<div id="addResult" class="alert
alert-danger">Failure: Check the logs for details</div>');

b) detail.pl - JSON titles, this and following (blocker):
{
"data": "biblio.author",
"title": "Author",
"searchable": true,
"orderable": true,
},

c) detail.pl - Capitalization (blocker)
"title": "Item Type",

d) detail.pl - Terminology (blocker)
"title": "Collection code", should be just Collection

e) circ/returns.tt: Why the use of i18n here? (question)
<th>[% t('Title') | html %]</th> 
Isn't it the same as:
<th>Title</th> ?

Same here, .tt file with text inside a div element, should have been parsed the
same without using t().
[% t('Scan all barcodes of items found in the items bundle. If any items are
missing, they will be marked as lost') | html %]

And here:
<button type="submit" class="btn btn-default"><i class="fa fa-check"></i> [%
t('Confirm checkin and mark missing items as lost') | html %]</button>


4) GUI - Configuration

a) In table configuration, there is one option named external_id - while this
makes sense to the API, I think it's hard on users. Why not update to barcode
instead? (normal)

b) The system preferences are currently spread on 2 different tabs (circulation
and cataloguing). I think we should add a new sub heading 'Item bundles' to
group them on the circulation tab instead. It will make setup smoother and I
can imagine the section might grow in the future. (normal)


5) Permissions

a) Who should be able to create item bundles? At the moment anyone with
catalogue permission should be able to. (question)


5) GUI - Functionality

a) As barcodes are unique, how could this happen? Should the message maybe be
adjusted? (question)

$('#removeResult').replaceWith('<div id="removeResult" class="alert
alert-danger">'+_("Failed: Barcode matched more than one item
")+barcode+'</div>');

More functionality testing to come.

-- 
You are receiving this mail because:
You are watching all bug changes.