[Koha-bugs] [Bug 30988] Adding a more generic version of googleopenidconnect

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
(In reply to David Cook from comment #8)
> @@ +183,5 @@
> > +            else {
> > +                my $error_feedback =
> > +'The email address you are trying to use is not associated with a borrower at this library.';
> > +                my $auto_registration = C4::Context->preference('OpenIDConnectAutoRegister') // q{0};
> > +                my $borrower = Koha::Patrons->find( { email => $email } );
> 
> This won't work properly for pre-existing patrons that might have their
> email saved into "emailpro". It would be wise to search both email and
> emailpro for borrowers.
> 

Actually, it looks like C4::Auth::checkauth() will only look for patrons using
"email" anyway, so that shortcoming already exists in Koha.
C4::Auth::checkauth() should probably be patched too..

-- 
You are receiving this mail because:
You are watching all bug changes.