[Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #30)
> (In reply to Jonathan Druart from comment #15)
> > With those 3 patches I think most of the work is done.
> > 
> > To continue I need people to commit to an involvement on these patches.
> > To start I would like someone familiar with the import process to test the
> > workflow and see if they are happy.
> > 
> > Then we will need to add test coverage and certainly provide some bug fixes.
> > 
> > Who's onboard?
> 
> Well, I was. No problem. Seeing no test plan from the author and no unit
> tests. But a signed off status :)
> Did you find some experienced user to get user feedback btw ?

The status should stay 'in discussion', the patches are not ready for master. I
will need help for that.

(In reply to Nick Clemens from comment #31)

Thanks, Nick!

> I tried testing, if I stage with matching it seems to die every time - it is
> also a bad experience when staging fails - the job remains at 'Started' and
> the report is present but empty

Fixed.

> When I import:
>  - The job says 'Started' but also shows 'Completed import of records'

Should be fixed now.

>  - When it finishes, there is no link back to the batch

Yes, that's one problem I identified. However we don't have the batch id yet.
One solution would be to have an ajax script that would get the job's detail
and display the link when the job has started. But I would suggest to do it on
a separate bug report, if we don't have a better solution. Note that bug 30982
is adding the REST API route for GET /background_jobs and GET
/background_jobs/$id

>  - If it fails it says 'Finished' "Progress 0/0"

Progress bugs should be fixed now.

>  - From a completed import I can't get back to the background job (maybe not
> needed?)

Hum, I don't know. If we need it it will be "tricky" (we will need a separate
DB column to store that I think).

> Lack of error feedback was problematic before, and is worse here because the
> user is moved to a different section of Koha and the progress is less
> visible - before you had a stuck bar, now just a not updating screen

Yes, that's why I think we need feedback from regular users. The ajax
suggestion above could work but I will be happy if we can come up with a better
solution.

> I like this alot but do think we need to fix these other problems while we
> do this work - it can be a second bug while we address functionality here,
> but I would like to see them pushed together in that case

-- 
You are receiving this mail because:
You are watching all bug changes.