[Koha-bugs] [Bug 28854] Add ability to create bundles of items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #227 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #224)
> 1) Adding to bundle and removing from bundle
> 
> a) When adding a non-existing barcode like "eee", I get an unspecific error
> message: Failure: Check the logs for details (blocker)

Fixed in follow-up attached

> b) The contrast is not really good on those errors I feel, maybe black text
> would be better on the colored background if that is an easy option. The
> light red background + red font is a little hard to read. (Accessibility)

I stick to the bookstrap standard alerts here, I'll defer to Owen for
guidance.. it's an area I've felt we're really inconsistent all over the place
for ages and aught to improve... but I'd rather do a consistent job everywhere
in a distinct bug.

> c) If you have a leading space in front of the barcode, it won't be
> recognized. This can happen easily if you copy and paste when forming the
> bundle and we deal with it in other places - I think we should do it here
> too for consistency (see also bug 30409) (normal)

Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode
here.. we should perhaps use JS instead on input.

> d) Should we be able to change contents of a bundle while it is checked out?
> At the moment it's possible. Maybe a 'safety question'? (question/suggestion)

Really good point.. I think it probably shouldn't be possible.. I'll have a go
at that next week and then continue with your review.

-- 
You are receiving this mail because:
You are watching all bug changes.