[Koha-bugs] [Bug 30327] Sort component parts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, time to do this properly and summarize in one comment :)

1) Unit tests are failing for me, although why is not obvious to me:

    #   Failed test at t/db_dependent/Koha/Biblio.t line 547.
    # found warning: Use of uninitialized value in concatenation (.) or string
at /kohadevbox/koha/Koha/Biblio.pm line 568.
    # found warning: Use of uninitialized value in concatenation (.) or string
at /kohadevbox/koha/Koha/Biblio.pm line 568.
    # found warning: Warning from search_compat: 'Exception 'Koha::Exception'
thrown 'error searching analytics'
    # expected to find warning: (?^u:Warning from search_compat: .* 'error
searching analytics')
    ok 5
    # Looks like you failed 1 test of 5.
not ok 11 - get_marc_components() tests


2) Database update is not idempotent, missing the IGNORE (it will explode if
you run it a second time):

+            INSERT INTO systempreferences ( `variable`, `value`, `options`,
`explanation`, `type` ) VALUES


3) I feel like the sorting options in combination with the sort criterias are
not totally clear. 
Why do we need ascending, descending, A-Z and Z-A as separate options? Is there
a functional difference between those and are there any 'impossible'
combinations one should not select?


4) There is a mismatch that needs to be fixed (additional s):
.yml: ComponentSortField
syspref.sql: ComponentsSortField
update: both versions are mixed in update and description.



Please fix, this works otherwise nicely and we are very close!

-- 
You are receiving this mail because:
You are watching all bug changes.