[Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jun 27 11:01:31 CEST 2022


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #26 from David Nind <david at davidnind.com> ---
Apologies that it has taken me so long to retest.

Summary from testing: 

- test plan for first patch: worked as expected

- with no date of birth: does not appear in the list, no warnings on the patron
page in staff interface [1]

- with invalid age in category having age required: unitilized value message if
upper age limit blank [2]

- with invalid age in category having upper age limit: unitilized value message
if upper age limit blank [3]

- with invalid age in category having age required and upper age limit: works
as expected

Hopefully I haven't misinterpreted what is expected here!

[1] with no date of birth
~~~~~~~~~~~~~~~~~~~~~~~~~

1. Edited a staff patron (Henry: patron id = 19) and removed date of birth
using the staff interface (dateofbirth shows as NULL in database)
2. Changed the staff patron category (S) so age required = 18-99 years
3. Does not appear in the list after running the script

[2] with invalid age in category having age required
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1. Edited a patron (Mary Burton - borrowernumber = 49) so that age is less than
24.
2. Changed patron category (PT) so age required = 24 and no maximum age (left
blank).
3. Worked as expected except for 'Use of unitialized value...' message:
   ==> Use of uninitialized value in sprintf at
misc/maintenance/search_for_data_inconsistencies.pl line 304.
        * Patron borrowernumber=49 has an invalid age of 21 for their category
'PT' (24-)

4. If they have the correct age (changed so they were older than 24), then no
unitialized value message

[3] with invalid age in category having upper age limit
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1. Edited a patron (Mary Burton - 49) so that age is more than 50.
2. Changed patron category (PT) so that no age required and upper age limit was
50.
3. Output as expected, except for 'Use of uninitialized value in sprintf...'
message:
   ==> Use of uninitialized value in sprintf at
misc/maintenance/search_for_data_inconsistencies.pl line 304.
        * Patron borrowernumber=49 has an invalid age of 58 for their category
'PT' (-50)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list