[Koha-bugs] [Bug 28854] Add ability to create bundles of items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #269 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #224)
> Taking things for a test run now :)
> 
> c) If you have a leading space in front of the barcode, it won't be
> recognized. This can happen easily if you copy and paste when forming the
> bundle and we deal with it in other places - I think we should do it here
> too for consistency (see also bug 30409) (normal)

Decided to stick with barcodedecode as it does more than just whitespace
depending on some koha settings.

> d) Should we be able to change contents of a bundle while it is checked out?
> At the moment it's possible. Maybe a 'safety question'? (question/suggestion)

Fixed in follow-up.

> 2) Detail view of bundle 
> 
> Staff:
> 
> a) From the bundle, there is no way to access the record that holds the
> bundled item. It would be nice if the Title could be linked in the table to
> allow for that. (suggestion)

Fixed in follow-up

> b) Collection is not resolved into the description in the table. (blocker)

I'm tempted to drop this column from the display entirely.. is it useful? 
Pulling through descriptions is not yet easily supported on the API and there's
ongoing discussions around it.

> c) The item type column is empty, although the bundled item has an itemtype
> (blocker)

As above; However, I felt this one probably was a more useful field.. I started
(see WIP patch) but decided perhaps it should be done as it's own bug as it
really involves adding a whole new set of API routes and js handling.

> d) If an item is lost, the date is formatted 'database' style. DateFormat is
> not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.YYYY.
> (blocker)

Restored in a follow-up.. it got lost somewhere during rebases.

> e) As all items on collections now show the "Manage bundle" button, there is
> no way to see which item actually has bundled items. An idea here would be
> to add the number of bundled items to the button text. (strong suggestion?)
> * Empty: Manage bundle
> * 3 items bundled in: Manage bundle (3)

Fixed in follow-up. Opted to go for (X|Y) where 'X' is "Present items attached"
and Y is "Lost items attached".  Might seem Owens thoughts on how this displays
inside a button, I'm not entirely sure about the approach of using plain text.

> f) If you have 2 items on a bundle record and "Manage bundle" the first, the
> button appearance changes and looks a bit 'pushed'. 
> Now push the second "Manage bundle link". Both bundles are open now, but
> only the second button appears 'pushed'.
> Close the first bundle - the button looks pushed now... close the second,
> now you have a detail page with the second button looking pushed. 
> This seems a bit of a confusing UI message. Maybe it was supposed to close
> the first when the second was opened? (question)

Enhanced in follow-up.. I wasn't actually doing anything to the button but
perhaps your browser was.. I've not assigned an 'active' class to the button
when the management UI is expanded and then remove it again if we collapse.

> 3) Detail view of bundled items
> 
> a) Staff - bundled: I like the link from the status to the record there,
> although it makes the column quite wide for a longer one. It all has nice
> class mark-up, so would be easy to play with if needed. (comment)

Restored styling that was lost in rebases again.. we use 'block' display to
make it go directly underneath the not for loan status.

> b) OPAC - bundled: We show "Added to bundle" but there is no way for the
> OPAC user to figure out "how to get it". I'd really like to see a way to
> navigate this here. Maybe we could link the status on the detail page to the
> bundle? (normal)

This wasn't at all trivial given how our item status include is written.. I
took the simple approach in the end of embedding the data in the controller..
but this is unlikely to work everwhere the include is called.  I think we
should take this as-is now and work together with NatFi and Tomas to make
status's work via the API's.

> 4) Checkout - nothing found there :)

Awesome.

> 5) Checkin - nothing to complain about here either. I like the new modal and
> its functionality.

Awesome.

> 6) Lost/return claims
> 
> Checked in a bundle of 3 items, but one was 'lost'. 
> 
> a) Details tab: The return claim was created and in the patron account it
> shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is
> nothing below. (blocker)

I couldn't replicate this, but will have another go sometime this week with
cleared-down data.

> b) Checkouts tab: The claim shows here, but also shows a little issue: In
> the notes column, it shows the text 'null'. And when I edit the note the
> text is there as well.

Hmm, not sure where the 'null' text is coming from yet.. still working on this
one.

> c) When trying to resolve the checkout claim to "(Not lost)", I see an
> "Uncaught ReferenceError" in the console and the display of the claims table
> is not refreshed. When I reload the page, I can see that the claim was
> actually resolved. (blocker?)

Oop.. missed this one whilst working through the comments.. will have to
revisit as above.

> d) When the claim return is resolved to another lost status, like "Lost",
> the bundle view will show: Lost: 1. It should resolve to the description
> instead. (blocker)

As above.

> 7) Inventory on checkin feature - no complaints

Awesome.

> 8) Wish/suggestion list
> 
> a) Some items are really similar if you don't see the subtitle, part_name
> and part_number. The bundle display and the modals in circulation only show
> title. I think it would make a lot of sense to add the other fields here to
> display as well. The use case here would be language materials for us. They
> often match on title ($a) and the important bit is in the other fields (work
> book, DVD, etc.9. They would also lend themselves to be 'bundled up'.

We use the standard biblio-title.inc include for the check-in modal so that
should already contain all the details you mention.

I've added a follow-up to include handling for part numbers and part names in
the manage bundle UI now.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are watching all bug changes.