[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Jun 27 18:04:54 CEST 2022
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787
--- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Marcel de Rooy from comment #16)
> [2] Code segment from Koha/REST/V1/Auth.pm
> if ( !$authorization and
> ( $params->{is_public} and
> ( C4::Context->preference('RESTPublicAnonymousRequests') or
> $user) or $params->{is_plugin} )
> or $pending_auth
> This does not look good to me. Do we need pending_auth here ? If so, at
> least we need parentheses etc. My follow-up removes the line now.
Why? Can you explain? If the user is not fully authenticated they shouldn't be
allowed to access REST API route.
With your follow-up patch the tests are failing now.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list