From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:13:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 23:13:53 +0000 Subject: [Koha-bugs] [Bug 30199] New: self checkout login by cardnumber is broken if you input a non-existent cardnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Bug ID: 30199 Summary: self checkout login by cardnumber is broken if you input a non-existent cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Set SelfCheckoutByLogin to 'cardnumber'. 2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3. Enter an invalid carnumber like 'thisisabadcardnumber' 4. See the appropriate message "Sorry The userid thisisabadcardnumber was not found in the database. Please try again." 5. Try again with a different cardnumber and notice the same exact error message including the 'thisisabadcardnumber' cardnumber. 6. The only thing that solves it for me is to direct my browser to this URL: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl?op=logout That properly logs me out and allows me to input a new cardnumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:55:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Feb 2022 23:55:37 +0000 Subject: [Koha-bugs] [Bug 30200] New: Add customizable tabs to interlibrary loan requests list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Bug ID: 30200 Summary: Add customizable tabs to interlibrary loan requests list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi In staff client, all interlibrary loan requests are loaded into a table regardless of their status. Ability to sort them by status under multiple tabs would make librarians life a lot easier. This Bug adds such feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:06:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 01:06:05 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:06:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 01:06:11 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106938|0 |1 is obsolete| | Attachment #106939|0 |1 is obsolete| | Attachment #106940|0 |1 is obsolete| | --- Comment #82 from Owen Leonard --- Created attachment 131174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131174&action=edit Bug 6815: Capture member photo via webcam This patch builds on a patch by Mark Tompsett, adding the option to take a patron's picture using the computer's webcam. The photo can then be saved to the patron's account. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Administration -> System preferences and enable the 'patronimages' preference. - View a patron record. In the sidebar, hover your mouse over the blank patron image. Click the "Edit" button which appears. - A modal window should appear with two sections, "Upload patron photo" and "Take patron photo." - If your computer has a webcam, your browser should ask permission to access it. Grant access. - You should see the view of your webcam shown under the "Take photo" button. - Click the "Take photo" button. The captured photo should be shown in place of the live video from the webcam. - You should now see three buttons: "Retake photo," "Download photo," and "Upload photo." - Clicking "Retake photo" should hide those buttons and return you to a live video view. - Clicking "Download" should make your browser download the image. - Clicking "Upload" should cause the page to redirect back to the patron detail page where you should see the new patron image displayed in the sidebar. - Trigger the modal again and click the "cancel" button. The modal should disappear and camera access should stop. - If your computer has no webcam the modal should appear correctly but there should be a banner at the bottom indicating that a camera is not available. - Try the test again but this time deny your browser access to the webcam. You may need to reset the camera permissions in your browser's settings. When the modal appears you should see a message saying access to the camera is denied. - The patron image edit modal should be available on all pages which show the patron image in the sidebar: Check out, Batch check out, Details, Accounting, Routing lists, Circulation history, Holds history, Modification log, Notices, Statistics, Files, Purchase suggestions, Discharges, Housebound, and ILL requests history. - Test adding an image to a patron record using the "Upload photo" option. It should still work correctly. - If the patron has an image attached, the "Upload photo" section should have a "Delete" button. Test that it works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:12:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 07:12:42 +0000 Subject: [Koha-bugs] [Bug 30198] Add privacy elements to reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30198 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:48:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 08:48:57 +0000 Subject: [Koha-bugs] [Bug 30201] New: Hahaa Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30201 Bug ID: 30201 Summary: Hahaa Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: gggeming1234567890 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 131175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131175&action=edit Haha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:50:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 08:50:59 +0000 Subject: [Koha-bugs] [Bug 30201] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Hahaa |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:40:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 09:40:35 +0000 Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 --- Comment #13 from Fridolin Somers --- Sure, another bug report for long-term fix is good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:03:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 10:03:05 +0000 Subject: [Koha-bugs] [Bug 30202] New: Option to send the cart to the library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30202 Bug ID: 30202 Summary: Option to send the cart to the library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be good if there is an option, where the patrons are able to send the cart (OPAC) to the library, additional to the entered email-address. Maybe with a checkbox saying "Send cart to the library". This option should of course be configurable with a system preference. Some libraries are using the cart feature instead of holds to get items off the shelves for their patrons. They don't want to have these "holds" in Koha on purpose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:12:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 12:12:40 +0000 Subject: [Koha-bugs] [Bug 30150] Dutch option in language limits is garbled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150 --- Comment #7 from Marcel de Rooy --- (In reply to Eric Phetteplace from comment #2) > I just used a report `select * FROM language_descriptions` and found the > Dutch entries further down. If I run your query I get this: > > subtag type lang description id > nl language de Niederländisch 138 > nl language en Dutch 26 > nl language fr Néerlandais 27 > nl language nl nedərlɑns 25 > NL region en Netherlands 299 > NL region nl Nederland 300 > > Should we change the "nedərlɑns" description in the database to "Nederlands" > then? Yes, Nederlands is the correct spelling. Change it. The first description seems to be a fonetic one. But apart from replacing it, I would say that there is some encoding issue too. I already have this entry: | nl | language | nl | Nederlands | 25 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:31:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 12:31:47 +0000 Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 --- Comment #5 from Marcel de Rooy --- By default, you will find this entry for UNIMARC in your ControlledIndicators preference: # UNIMARC: Always copy the indicators from the authority unimarc, *, ind1:auth1, ind2:auth2 If you don't want this behaviour, a simple remedy is to comment that last line starting with unimarc. I would not recommend doing so but it is possible to just ignore standards and the like ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:32:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 12:32:03 +0000 Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 --- Comment #6 from Marcel de Rooy --- I recommend closing this report. It is no bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:48:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 12:48:02 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #845 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #844) > (In reply to Marcel de Rooy from comment #835) > > Still applied on current master (more or less: minor conflicts) > > commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103 > > > > Will be spending some time on it now and next week, and hoping that the > > other volunteers will be able to do so too.. > > Have fixed the merge conflict and the failing tests and qa tests mentioned > above. Thx for doing that quickly. Resuming here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:13:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:13:08 +0000 Subject: [Koha-bugs] [Bug 30203] New: Can we trust the clean slate in Circulation.t ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Bug ID: 30203 Summary: Can we trust the clean slate in Circulation.t ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Not sure what happened exactly. But a failing Circulation.t must have removed all users in my devbox. # Start with a clean slate $dbh->do('DELETE FROM issues'); $dbh->do('DELETE FROM borrowers'); And my borrowers: select borrowernumber,userid,lastseen from borrowers; +----------------+---------------------------------------------------------------------------+---------------------+ | borrowernumber | userid | lastseen | +----------------+---------------------------------------------------------------------------+---------------------+ | 382 | pCITR3m30mWAv4MTsEhckB0QR1JoJFgBac2mdWx | 2022-03-01 13:01:39 | | 383 | sazlgFEfa4UmwVgniArAfluzcETJXkru9ktdHKYzSqTXwYckCAXNje3ZpqfRabaz42p | 2022-03-01 13:01:39 | | 384 | VkGSPpUO7VFE2it55nZ2pflAmo75HUin4eYVKtThczB7tUF_AZFXuOcg95_Q | 2022-03-01 13:01:39 | | 385 | opoi06B6_LWhoOXQtTjYrN01Vm182og8OK6Uaezc_CfNnA6SYicmnWzb2hEeZF_ | 2022-03-01 13:01:39 | | 386 | john.renewal | NULL | | 387 | katrin.reservation | NULL | | 388 | kyle.reservation | NULL | | 389 | alice.reservation | NULL | | 390 | ca.glisse | NULL | | 391 | T5MrUI8DftRsa_nou6Q_VO76Wby4HAfcDsNP9WXk3gom8 | 2022-03-01 13:01:39 | | 392 | goV_DQYtptbpxYFdUtEcpJqz9X4fq3Zn4Arf336wEvxvc7rF8prBsQRDLq8_8FZhQypuamFi | 2022-03-01 13:01:39 | | 393 | fridolyn.somers | NULL | | 394 | kyle.hall | NULL | | 395 | kyle.hall1 | NULL | | 396 | chelsea.hall | NULL | | 397 | fn.dn | NULL | etc etc The family Hall are prominently visible now :) But Katrin and Fridolin too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:17:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:17:36 +0000 Subject: [Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:43:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:43:49 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- A very minor quibble, the current behavior is to give the due date including the time. The default notice in this patch calls the due date without the time. It should be changed to maintain current behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:49:55 +0000 Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 --- Comment #7 from Noémie Labine --- The library did clear the appropriate line in AuthorityControlledIndicators and decided to put a default value of 0 for the second indicator of their 830 field. I believe they will correct the authority records as they see them. In the end, they do know that it would be prefereable to keep every line in AuthorityControlledIndicators and correct any empty indicator they would find in Uniform title authority. I'm closing this report, thanks for taking the time. Have a nice day everyone ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:50:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:50:05 +0000 Subject: [Koha-bugs] [Bug 29907] The 'type' column in the public lists table is redundant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29907 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:50:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:50:34 +0000 Subject: [Koha-bugs] [Bug 29907] The 'type' column in the public lists table is redundant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29907 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:51:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:51:30 +0000 Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:52:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 13:52:23 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- I'm getting this error when trying to run process_message_queue with this patch: Global symbol "$letter_code" requires explicit package name (did you forget to declare "my $letter_code"?) at misc/cronjobs/process_message_queue.pl line 84. Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) at misc/cronjobs/process_message_queue.pl line 90, near "};" Type of arg 1 to Try::Tiny::try must be block or sub {} (not reference constructor) at misc/cronjobs/process_message_queue.pl line 90, near "};" Execution of misc/cronjobs/process_message_queue.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:25:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:25:20 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128890|0 |1 is obsolete| | --- Comment #31 from David Gustafsson --- Created attachment 131176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131176&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:25:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:25:24 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128891|0 |1 is obsolete| | --- Comment #32 from David Gustafsson --- Created attachment 131177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131177&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. Signed-off-by: Frank Hansen The patch works fine for me. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:31:31 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:38:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:38:17 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 --- Comment #33 from David Gustafsson --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:41:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:41:38 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 --- Comment #7 from Katrin Fischer --- If there is a feature added for this, I'd love having an option to add checkboxes instead of having to use a Yes/No pull down :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:43:18 +0000 Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:48:33 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131136|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 131178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131178&action=edit Bug 30185: Missing return in db rev 210600003.pl db rev files are constructed with a return {...}, db rev 210600003.pl is missing return word. I don't know if it can impact the db upgrade but we should fix it for consistency. To test upgrade from a version 21.05 and check db rev is applied. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:48:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:48:53 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131178|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 131179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131179&action=edit Bug 30185: Missing return in db rev 210600003.pl db rev files are constructed with a return {...}, db rev 210600003.pl is missing return word. I don't know if it can impact the db upgrade but we should fix it for consistency. To test upgrade from a version 21.05 and check db rev is applied. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:49:07 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Trivial PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:50:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:50:54 +0000 Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails validation on first submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:52:07 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131176|0 |1 is obsolete| | --- Comment #34 from David Gustafsson --- Created attachment 131180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131180&action=edit Bug 29440: Refactor and clean up bulkmarcimport.pl To test: 1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert -update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log" 2) Verify in /tmp/import.log that one biblio has been inserted 3) Import again without the "-n" option, verify that one biblio has been updated and the rest inserted 4) In the staff interface search the catalog for some string appearing in the imported biblios to verify records have been indexed 5) View/edit some of the biblios the staff interface to very have been properly imported 6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file authorities.xml -insert -update -c=MARC21 -keepids="024a" -match "heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml" 7) Go to the authorities page and find the imported authority by for example search for a 400 or 100 field value. Verify that the 001 field of the incoming record has been moved to 024a. Also check that the value of 024a appear as a key in /tmp/ids.yml. 8) Edit the authorities.xml file and change the value of field 400a 9) Import authorities again using the same options 10) Verify that the 400a field of the authority in Koha has not been updated (the import was skippped since revision did not change) 11) Edit authorities.xml, replace the value of field 005 in the file with field 005 of the authority in Koha incremented by one 12) Import again with the same options 13) Verify that the 400a field of the authority in Koha now have been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:52:11 +0000 Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131177|0 |1 is obsolete| | --- Comment #35 from David Gustafsson --- Created attachment 131181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131181&action=edit Bug 29440: Make authorities import behavior consistent with biblios The current behavior for when importing authorities, when match option is enabled, is to insert as a new authority fetching from db fails. This is both a bit confusing and not consistent with the biblio case where an error is generated. Also clean up error and log messages so both messages/errors and when messages/errors are issued are more consistent for the biblio and authority case. Signed-off-by: Frank Hansen The patch works fine for me. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:55:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:55:50 +0000 Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131137|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 131182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131182&action=edit Bug 30178: (bugs 27526 and 28445 follow-up) Every librarian can edit every item with IndependentBranches on Problem arises after applying bugfix 27526 and 28445: with IndependentBranches on, a librarian without superlibrarian privileges, can edit (and potentially delete) every item (i.e. also from a foreign branch). This is because can_be_edited calculation is buggy (in two spots). Test plan: 1. Have (at least) two branches defined. 2. Have IndependentBranches set. 3. Have a biblio record with items belonging to different branches. 4. Be a librarian without superlibrarian rights, with editcatalogue and tool permissions set. Scenario A (Edit items): 1. Go to Edit -> Edit items view (cataloguing/additems.pl). 2. You will be able to edit every item, also ones not from the branch you are from (cf. the button 'Actions'). 3. Apply the patch. 4. Repeat 1. 5. You should be able to edit only the items from your branch. Scenario B (Edit items in batch): 1. From Normal view go to Edit -> Edit items in batch. 2. You will be able to batch edit every item, also ones not from the branch you are from. 3. Apply the patch. 4. Repeat 1. 5. You should be able to edit only the items from your branch (and see 'Cannot edit' for others. Scenario C (Delete items in batch): 1. From Normal view go to Edit -> Delete items in batch. 2. You will not see the string 'Cannot delete' and only by chance will not be able to activate the checkboxes next to foreign items. 3. Apply the patch. 4. Repeat 1. 5. You should be able to delete only the items from your branch (and see 'Cannot delete' for others. Scenario D and E: Analogous steps can be executed from Tools -> Batch item modification and Tools -> Batch item deletion Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:57:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:57:20 +0000 Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Well sleuthed, this was hard to trace. I've confirmed the fix works and I can't find any regressions. Lets get this one pushed as a matter of urgency and continue tidying up in a further bug.. I'll leave Katrin and Fridolin to report that new bug. So.. Passing QA, thanks for the patch Janusz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:59:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:59:01 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130201|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 131183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131183&action=edit Bug 29826: Manage call of Template Plugin Branches GetName() with null or empty branchcode Bug 26587 added a concatenation that sends a warning if var is undef : $ prove t/db_dependent/Template/Plugin/Branches.t Use of uninitialized value $branchcode in concatenation (.) or string at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35. This patch adds an early return empty string when GetName is called with $branchcode null or empty string. Test plan : 1) Run t/db_dependent/Template/Plugin/Branches.t without patch 2) Run with the patch to see warning disappear Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:59:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 14:59:34 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Great fix, includes tests, no regressions and squelched warnings. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:01:23 +0000 Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130809|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 131184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131184&action=edit Bug 30128: Change language_subtag_registry.description to varchar(255) In database, language_descriptions.description is VARCHAR(255). language_subtag_registry.description is VARCH(25), it should have same size. You can see in https://www.loc.gov/standards/iso639-2/php/code_list.php there is for example 'South American Indian languages' Test plan : 1) Run atomic update 2) Check language_subtag_registry.description is now varchar(255) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:01:27 +0000 Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131142|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 131185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131185&action=edit Bug 30128: [DO NOT PUSH] Update DBIC Schema Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:01:50 +0000 Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too short In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Trivial fix, no mistakes found, no regerssions. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:03:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:03:29 +0000 Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131138|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 131186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131186&action=edit Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords To test: - Search for something that gives several result pages in OPAC, example: e - Switch to one of the last pages using link on top of results, example: 10 - Open any of the records listed in detail view - Verify that the error is shown - Apply patch and repeat, error is gone and browsing behaves as expected Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:03:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:03:50 +0000 Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Another trivial fix, well spotted. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:08:02 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:08:14 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131129|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 131187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131187&action=edit Bug 29771: Remove trivial cases I squashed the patches because they are too trivial to have a test plan. Or it is too much work to write the test plan for such trivial cases. I leave the original commit messages just in case. Generally, this are all cases in which CGI::param is being called in a trivially identifiable _list context_. i.e. they are assigned to a @variable. I left one case out on purpose: admin/auth_subfields_structure.pl Paul introduced this: my @kohafield = ''.$input->param('kohafield'); and then: my $kohafield = $kohafield[$i]; My intuition says it is forcing scalar context on the first assignment so the list contains a single element and then inside the loop some $kohafield assignments should lead to undef, and even warnings. I leave it for a separate patch because it is not that easy testable and is a sensible area. Bug 29771: Remove warning from acqui/finishreceive.pl This patch removes a warning that shows when receiving. To test: 1. Do the acq workflow up to the receive step. 2. Once you choose the items and click on Finish => FAIL: There's a warning in the logs 3. Revert receipt 4. Apply this patch 5. Receive => SUCCESS: No more warnings 6. Sign off :-D Bug 29771: Remove warning from svc/members/add_to_list To test: 1. Run: $ tail -f /var/log/koha/kohadev/*-error.log 2. Generate a patron list 3. Perform a patron search that gives you a few 4. Select some, and choose to add them to the list => FAIL: The logs show the infamous warn: CGI::param called in list context from /kohadevbox/koha/svc/members/add_to_list 5. Apply this patch 6. Restart plack and repeat 4 => SUCCESS: No warn! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:08:18 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131130|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 131188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131188&action=edit Bug 29771: Scalar context for split This patch tackles a very specific scenario. Calling split(..., CGI::param) makes it be called in list context. The split docs say: split /PATTERN/,EXPR,LIMIT this means the first CGI param will be used as EXPR and the second one as LIMIT, which is wrong anyway. So the fix is to just force scalar context. To test: 1. Not sure, just make sure nothing breaks when using the scripts in the browser. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:09:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:09:50 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Great call! This fixes all obvious cases and many non-obvious ones too.. No regressions found, lets get this pushed and deal with any further occurrences as we spot them. It would be nice to have a QA script test catch new introductions of such warnings.. but that can be handled outside of this bug. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:13:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:13:55 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128365|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:15:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:15:44 +0000 Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #7 from David Gustafsson --- I must have accidentally added two different iterations of the same patch, now it should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:16:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:16:02 +0000 Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:17:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:17:53 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129415|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 131189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131189&action=edit Bug 29877: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:17:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:17:57 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129416|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 131190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131190&action=edit Bug 29877: Make POST /holds handle maxreserves correctly The current implementation doesn't consider the following values for the syspref: undef and 0. The tests mistakenly didn't cover them. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests fail, obvious warnings about comparing undefined values too. 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. You can try on Postman as well => SUCCESS: Behavior is correct! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:19:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:19:08 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- I think we're all in agreement here that this bug fix restores/corrects the functionality of the API to make it consistent with existing behaviours elsewhere and that further actions should take place in their own bug. As such, and as I can't spot any real regressions resulting from this.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:22:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:22:45 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 --- Comment #4 from Martin Renvoize --- Created attachment 131191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131191&action=edit Bug 30098: Only redirect from patron search if single result is on first page This patch simply adds a check that we are oin the first page (starting at result 0) before redirecting to a isngle patron To test: 1 - Perform a patron search that returns 41 results, on Koha testing docker, 'a' works 2 - Go to second page of results, works 3 - Go to third page of results, redirected to the patron 4 - Apply patch 5 - Repeat search and paging 6 - On third page you remian in results and are not redirected to patron Signed-off-by: Emmanuel Bétemps Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:23:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:23:17 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #130626|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:24:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:24:38 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_Remove_or_clarify_checkbox?= =?utf-8?q?_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:25:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:25:52 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Hmm, just read Jonathans comment.. I think he's right, that's a slightly cleaner solution with one less test. I'll PQA as there's not real issue with this code and leave it to the RM to decide which of the two options is 'nicest'... we can always have the solution from bug 30063 once that's worked it's way through anyway. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:28:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:28:39 +0000 Subject: [Koha-bugs] [Bug 23347] Columns settings for items in OPAC should be according to the framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23347 --- Comment #2 from Marjorie Barry-Vila --- Hi Katrin, Sorry for the delay! It's more a question finally, why the Call number column is displayed when the field is empty? There are columns that are not displayed as soon as the field is empty, such as the Notes. Even if in the cataloging framework, the callnumber subfield is not checked for the visibility in opac, the column is displayed anyway. I think only filled subfields should appear in the table. And if that's not possible, then make the Opac box in the cataloging framework work for the items table. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:32:14 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:32:19 +0000 Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface -

on each page is Logo but should be page description/title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #112 from Owen Leonard --- Created attachment 131192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131192&action=edit Bug 27631: (follow-up) Various corrections This patch addresses issues found during QA: - Double headings (patron details page) - Inconsistent heading position (check out, patron accounting) - Missing headings when there is no data (Library EANs, Item search fields, MARC modification templates). - Typo: Z19.50 => Z39.50 - Reword "Classification sources" heading: "Classification configuration" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:40:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:40:39 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #846 from Marcel de Rooy --- Created attachment 131193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131193&action=edit Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences Due to the wantarray change, we should fix this call in list context. We should either use an iterator now or append as_list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:43:21 +0000 Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails validation on first submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003 --- Comment #11 from Katrin Fischer --- Hi Jake, thx for your patch and don't worry about the bugzilla noise, we all do it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:48:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:48:16 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #847 from Marcel de Rooy --- Saw this warning in QA tools: FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt FAIL valid_template Attempt to reload Koha/Template/Plugin/KohaPlugins.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206. SAME for koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt The reload aborted on Template plugins I have seen incidentally on a few other reports, where we did spend quite some time to resolve it to no avail. Eventually they were ignored. This report does not do anything with the KohaPlugins template plugin. So I think we can discard it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:49:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:49:32 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #848 from Marcel de Rooy --- >From code glancing: Unfinished business? + } elsif ( $code eq 'RecallFound' ) { + ; + } elsif ( $code eq 'RecallNeedsTransfer' ) { + ; + } elsif ( $code eq 'TransferredRecall' ) { + ; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:53:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 15:53:15 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 jmbroust changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:01:15 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131166|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize --- Created attachment 131194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131194&action=edit Bug 27812: Remove the ability to transmit a patron's plain text password over email We should not give libraries the ability to compromise patron accounts, it is considered a huge security issue and nobody in network security would never recommend allowing passwords to be transmitted in clear text over email. It should simply not be possible to send a patron's password in plain text via email. As such, we should remove this ability from Koha. Test Plan: 1) Apply this patch 2) Create a patron to generate the ACCTDETAILS email 3) Note you can no longer transmit the patron's password in the email Signed-off-by: Amit Gupta Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:01:20 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131167|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 131195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131195&action=edit Bug 27812: Email should send for all new patron as per the syspref description Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:01:24 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131168|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 131196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131196&action=edit Bug 27812: Add DBRev to warn of the change to the account details notice Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:01:28 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #29 from Martin Renvoize --- Created attachment 131197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131197&action=edit Bug 27812: (QA follow-up) Fix atomicupdate We removed a bit too much from the skeliton here ;) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:04:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:04:25 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This bugfix/enhancement release notes| |improves the default | |security of Koha by | |removing the pass of the | |plain text password to the | |ACCTDETAILS notice on | |patron creation. | | | |WARNING: | |You will need to update | |your notice template if you | |were relying on | |`<>` in | |this notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:06:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:06:31 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize --- Right, I think we've all agreed now to keep this bug to scope as a security related issue. The code works as expected and we've agreed that updating the notices isn't reliably possible and so a warning should be used instead. We now have such a warning posted during the database update and added in the 'Text to go in the release notes' field above. As such, with the QA scripts passing and no nasty regressions found I think we can safely mark this PQA.. I will now go and QA the dependant bugs and report a new bug for the 'Your password has been changed' notice I suggested was a good idea here. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:09:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:09:02 +0000 Subject: [Koha-bugs] [Bug 30204] New: Add subtitle to serial subscription search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Bug ID: 30204 Summary: Add subtitle to serial subscription search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On serials-search.pl when one does a serial search the results will display the title of the connected biblio but it will not display the biblio.subtitle, it would be handy if it did show the subtitle along with the title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:11:54 +0000 Subject: [Koha-bugs] [Bug 18543] Emails for new patron accounts with the AutoEmailOpacUser preference require to enter password manually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Martin Renvoize --- This will be resolved as part of bug 27812 so I'm marking it as a RESOLVED DUPLICATE. Further work will take place in bug 17648 to move this notice into the message queue and then allow for further trigger area's in follow-up bugs. *** This bug has been marked as a duplicate of bug 27812 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:11:54 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen at bywatersolutions.com --- Comment #31 from Martin Renvoize --- *** Bug 18543 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:14:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:14:52 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:14:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:14:54 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 --- Comment #1 from Lucas Gass --- Created attachment 131198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131198&action=edit Bug 30204: Add subtitle to serial search results To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Notice the subtitle doesn't appear. 4. Apply patch and restart_all 5. Again try step 2. 6. Notice the subtitle appears alongside the title now. 7. Make sure it still sorts that column correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:16:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:16:17 +0000 Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Text to go in the| |Adds the biblio.subtitle to release notes| |the 'Title' column on | |serial-search.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:29:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:29:08 +0000 Subject: [Koha-bugs] [Bug 30205] New: Add biblio.subtitle to the subscription-detail.pl page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Bug ID: 30205 Summary: Add biblio.subtitle to the subscription-detail.pl page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On the subscription-detail page we show the biblio.title, we should also show the biblio.subtitle, if it exists. This can be shown both in the h1 heading and on the 'Biblio:' line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:30:11 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131165|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 131199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131199&action=edit Bug 17648: ACCTDETAILS notice does not show in notices.pl The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. Test Plan: 1) Apply this patch 2) Create a new patron with an email address 3) Note the patron's ACCTDETAILS notice shows in the patron's messages Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:30:15 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #10 from Martin Renvoize --- Created attachment 131200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131200&action=edit Bug 17648: (QA follow-up) Further code cleaning We actually have a Koha::Patron method to do all the work of finding the right patron primary email address for notices.. we can use that here instead of doing it long hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:30:41 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- Great improvement, all works ass expected.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:31:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:31:27 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 [Bug 17648] ACCTDETAILS notice does not show in notices.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:31:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:31:27 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:32:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:32:50 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:32:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:32:53 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #1 from Lucas Gass --- Created attachment 131201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131201&action=edit Bug 30205: Add subtitle to subscription detail page To test: 1. Make some new serial subscriptions and connect them to biblios that contain subtitles. 2. Do a serial search that will return your newly created subscription. 3. Click on one of those subscription to be taken to the subscription detail page. 4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no subtitle in either place 5. Apply patch, restart_all, and reload the subscription detail page. 6. You should now see the subtitle on both the main heading (h1) and on the 'Biblio:' line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:33:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:33:49 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Text to go in the| |Add the biblio.subtitle to release notes| |the serial subscription | |details page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:34:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:34:45 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #10 from Martin Renvoize --- Right.. bug 27812 is now PQA and will now send a notice whenever a new patron is added via the staff client via memberentry.. and bug 17648 is signed off and moves the notice into the message queue.. Now it's time to come back to this and look at enabling the notice in some other places, like patron imports, opac registrations (maybe at the confirmation stage?) etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:38:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:38:44 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #32 from Martin Renvoize --- Bug 25936 already records my request for password change notifications :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:39:01 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:39:29 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27812 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:39:29 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:42:38 +0000 Subject: [Koha-bugs] [Bug 30206] New: Notify users if their personal details change Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30206 Bug ID: 30206 Summary: Notify users if their personal details change Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, dpavlin at rot13.org, george at nekls.org, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org We should add the option to notify users when their personal details are updated. This should allow for detailing the change that has taken place, allowing the patron to understand what details the library has on record for them. This is especially useful in the event that someone has compromised an account and changed the account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:42:38 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:49:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:49:21 +0000 Subject: [Koha-bugs] [Bug 30207] New: Librarians with only "place_holds" permission can no longer update hold pickup locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Bug ID: 30207 Summary: Librarians with only "place_holds" permission can no longer update hold pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 29540 increased the flags required to for modreserve.pl, but in doing so created a situation where a library can select a different pickup location for a hold, but upon clicking the "Update hold(s)" button, will be logged out due to having insufficient permissions for modreserve.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:49:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:49:40 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #12 from Martin Renvoize --- Created attachment 131202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131202&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:52:13 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29005 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:52:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:52:13 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9097 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:53:02 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:53:02 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:53:41 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:53:44 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 --- Comment #1 from Kyle M Hall --- Created attachment 131203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131203&action=edit Bug 30207: Librarians with only "place_holds" permission can no longer update hold pickup locations Bug 29540 increased the flags required to for modreserve.pl, but in doing so created a situation where a library can select a different pickup location for a hold, but upon clicking the "Update hold(s)" button, will be logged out due to having insufficient permissions for modreserve.pl. Test Plan: 1) Create a librarian with "place_holds" permissions, but not "modify_holds_priority". 2) Place a hold for a patron 3) Attempt to change the pickup location from request.pl 4) Note you get logged out with a permissions error 5) Apply this patch 6) Restart all the things! 7) Attempt to change the pickup location from request.pl 8) This time it should succeed! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:53:52 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:57:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 16:57:32 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:35:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:35:34 +0000 Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:35:38 +0000 Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 --- Comment #1 from Lucas Gass --- Created attachment 131204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131204&action=edit Bug 24221: Move OPACMySummaryNote to HTML customizations in additional-contents To test: 1- Before applying the patch add some content to the system preference OPACMySummaryNote 2- Apply patch 3- restart_all and updatedatabase 4. Go to additional-content.pl ( HTML customizations ) 5. You should now see your content from the system preference under OpacMySummaryNote in HTML customizations 6. Try searching for the system preference, OPACMySummaryNote. It has been removed and you should not be able to find it. 7. Try changing/removing/adding content from OpacMySummaryNote in HTML customizations 8. Make sure your edits are reflected when you look at the user summary page Note: The system preference was named OPACMySummaryNote but in to be more consitent with how we have named other additional_contents I have renamed this OpacMySummaryNote. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:36:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:36:05 +0000 Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:52:08 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131203|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 131205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131205&action=edit Bug 30207: Librarians with only "place_holds" permission can no longer update hold pickup locations Bug 29540 increased the flags required to for modreserve.pl, but in doing so created a situation where a library can select a different pickup location for a hold, but upon clicking the "Update hold(s)" button, will be logged out due to having insufficient permissions for modreserve.pl. Test Plan: 1) Create a librarian with "place_holds" permissions, but not "modify_holds_priority". 2) Place a hold for a patron 3) Attempt to change the pickup location from request.pl 4) Note you get logged out with a permissions error 5) Apply this patch 6) Restart all the things! 7) Attempt to change the pickup location from request.pl 8) This time it should succeed! Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:52:36 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 17:52:37 +0000 Subject: [Koha-bugs] [Bug 30206] Notify users if their personal details change In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30206 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:09:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:09:40 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:09:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:09:44 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130864|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 131206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131206&action=edit Bug 29713: Make item table when placing an item level hold sortable This patch modifies the holds page in the OPAC so that users selecting a specific item to place a hold on can sort the table of items. This patch also removes some obsolete JavaScript left over from before Flatpickr. To test, apply the patch and go to Administration -> Circulation and fine rules to make sure at least one item type in your system has "OPAC item level holds" set to "allow." - Log in to the OPAC as a user who can place holds. - Search the catalog for items which will accept item-level holds. - Place a hold on one of the results, and click the "Show more options" link on the holds page. - Check the "specific item" radio button. - A table of items should be displayed. Confirm that the table is sortable. - The first entry in the table should be selected. - Perform the same test when placing a hold on multiple titles. Confirm that each table of items is sortable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:07 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121555|0 |1 is obsolete| | Attachment #121556|0 |1 is obsolete| | Attachment #121557|0 |1 is obsolete| | Attachment #121558|0 |1 is obsolete| | --- Comment #51 from The Minh Luong --- Created attachment 131207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131207&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he start search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:12 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #52 from The Minh Luong --- Created attachment 131208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131208&action=edit Bug 27113: (follow-up) QA Tests Bug 27113: (follow-up) QA Tests (2) Bug 27113: (follow-up) Fixup warnings. TEST PLAN Important! In this patch we need to do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). !Recommended 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for and version ES 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 5. After that we can look two options in the preferences: - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; 4. For add information in the index we must run script for reindexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find : - IntranetAutocompleteElasticSearch; - OPACAutocompleteElasticSearch; Value "Show" turn on autocomplete. 7. Now we have Autocomplete for Intranet/OPAC search input (advanced search also). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:16 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #53 from The Minh Luong --- Created attachment 131209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131209&action=edit Bug 27113: (follow-up) Correction with Session I have changed CGI::Session->new() from CGI::Session->load() for use session. This condition - 'CGI::Session->load() or die CGI::Session->errstr();' I am not sure that was good idea to use 'die' in this condition...What do you think? Thanks! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:21 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #54 from The Minh Luong --- Created attachment 131210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131210&action=edit Bug 27113: (follow-up) Move new CSS to main SCSS files This patch removes the separate CSS files added for the autocomplete feature and puts them into the "main" SCSS files. I think a separate file isn't necessary because the amount of CSS it adds is so small. I've also tweaked the style of the autocomplete menu shown when you use the arrow keys to navigate through the autocomplete choices. I think the previous white-on-light-green didn't have enough contrast. To test you must rebuild the OPAC and staff client CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Follow the previous test plan, being careful to observe how it works when the autocomplete menu has been triggered and you use the arrow keys to navigate through the results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:25 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #55 from The Minh Luong --- Created attachment 131211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131211&action=edit Bug 27113: Rebase and correct autocomplete appearance Rebase of previous patches and correct the buggy behavior (See "GIF showing buggy behavior attachment") Test plan: 1- Search for an item. Notice that the autocomplete functionnality is not available. (See "Result" attachment) 2- Make sure that you are using Elasticsearch as your searching engine. (Preference->SearchEngine->ElasticSearch) 3- Apply the patch. 4- Run ./installer/data/mysql/updatedatabase.pl 5- Looks for the following preferences : - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 6- Set their value to show. 7- Rebuild the OPAC and staff client CSS (This step is important because the autocomplete CSS is moved to the main SCSS file): Instructions here: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 8- Search for an item and notice that the autocomplete functionnality is now available. 9- In the staff interface, go in "Search the catalog". 10- Notice that the buggy behavior is now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:49:55 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |the-minh.luong at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:51:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 19:51:11 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Michael Hafen --- (In reply to Andreas Jonsson from comment #13) > Using a table lock seems like a crude solution. > > Why not use a transaction? I agree that the table lock is pretty ugly. Honestly, I haven't tested that it solves the problem either. Think of it, it probably creates a problem where the accountlines table is locked during circulation. (I just found out that foreign key tables also get locked, which compounds this problem.) But a transaction would not prevent multiple threads from changing the same row, which is what I was trying to catch there. I'd be fine with going back to Martin's patches. (But a test would still have to be written. ;) ) Besides, I'm not even using the table locking patch in production here. I've moved on from this, so I'll have to dig in a bit to remember what all is going on, to figure out how much of a problem the 'renewed is still overdue so new fine' case is. This keys on the issue_id, but maybe that can be changed to key on the accountlines_id instead; that would be a better solution to this problem I think. I'll dig in a bit and see if I can get this to key on the accountlines_id instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:16:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 20:16:22 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 --- Comment #9 from Marjorie Barry-Vila --- (In reply to Samu Heiskanen from comment #8) > Created attachment 129236 [details] [review] > Bug 28247: (folow up) Add a MARC preview action to Authority search results > > To test: > 1) Do an authority search > 2) On Actions button click to see the available actions and click on "MARC > preview" action. > 3) A modal window open and confirm that the correct details are shown. > > Signed-off-by: Samu Heiskanen Hi, I just tested in a sandbox (21.12.00.016) (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview' appears twice in the Actions menu, is this normal? Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:17:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 20:17:39 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 --- Comment #10 from Marjorie Barry-Vila --- Created attachment 131212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131212&action=edit Marc preview -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:23:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 20:23:42 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Donna --- I'd like to see this as an option in the system preference as to which new patrons get the email - batch created, individually created, both, or neither. There are libraries that will do batch imports that do not want to send an email to the new users from the batch import, but do still want to send emails to users that are created individually. For instance, a public library will want to send emails to users they register in person, but when they do a batch upload of students to permit them access to digital resources, they don't want to send welcome emails to the students. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:54:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 20:54:23 +0000 Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data, cannot decode object" on ISBDdetail and MARCdetail pages. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 22:38:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 21:38:54 +0000 Subject: [Koha-bugs] [Bug 30208] New: Marking an item lost should revert the waiting status of any associated hold Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30208 Bug ID: 30208 Summary: Marking an item lost should revert the waiting status of any associated hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If an item is currently Waiting for pickup for a hold, editing that item to apply a lost status should revert the waiting status of the hold. To recreate: - place an item-level hold - check your item in and confirm the hold - confirm on waitingreserves.pl that Koha shows the item is waiting for pickup - confirm on the request.pl that Koha shows the item is waiting for pickup - edit your item to Lost - confirm the item now shows as both lost and waiting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 23:08:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 22:08:16 +0000 Subject: [Koha-bugs] [Bug 30186] ISBD throws error when record is suppressed, but patron category is not in OpacHiddenItemsExceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30186 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Looks like the preference OpacHiddenItems contains 'lost' instead of 'itemlost'. Fields must be the column names of items DB table. See https://wiki.koha-community.org/wiki/OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 23:55:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 22:55:31 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #849 from Aleisha Amohia --- Created attachment 131213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131213&action=edit Bug 19532: (follow-up) Removing unnecessary code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:04:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 23:04:41 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #850 from Aleisha Amohia --- Cool I will ignore that warning about KohaPlugins then. (In reply to Marcel de Rooy from comment #848) > From code glancing: > Unfinished business? > > + } elsif ( $code eq 'RecallFound' ) { > + ; > + } elsif ( $code eq 'RecallNeedsTransfer' ) { > + ; > + } elsif ( $code eq 'TransferredRecall' ) { > + ; Not unfinished business, I was just copying the similar code above, but I have removed in latest follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:13:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 23:13:44 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ACCTDETAILS notice does not |ACCTDETAILS notice doesn't |show in notices.pl |show in the notices tab in | |staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:44:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 23:44:01 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:44:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 23:44:08 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126413|0 |1 is obsolete| | --- Comment #66 from Aleisha Amohia --- Created attachment 131214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131214&action=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library & Catalyst IT Test plan: * Update the database, update the schema files, restart services * Log into Staff interface, search for a title, choose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. * Clicking a record in the history log should revert that field to the clicked value (a previous value) * Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:45:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2022 23:45:51 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126414|0 |1 is obsolete| | --- Comment #67 from Aleisha Amohia --- Created attachment 131215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131215&action=edit Bug 14367: Updated schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:07:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:07:26 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:20:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:20:15 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #15 from Michael Hafen --- I think I figured out why the code here was the way it was. It has to do with the possibility of a book being renewed and then becoming overdue again. The way the code was there would be a second overdue fine added to the account lines for this second instance of the issue becoming overdue. With the patches to dropping the status check the second overdue fine would never get entered since the previous overdue fine would be found instead. And the table locking patch doesn't lock the table soon enough to fix the duplication problem. (Which is besides the fact that locking in a long running process would totally kill the circulation desk.) Which brings me back to using accountlines_id to find the overdue fine instead of issue_id. We need to either make sure the fines cron job doesn't run during circulation hours, or find and use the accountlines_id when pulling the list of overdues. Those are the best solutions I can think of, either run the script when things aren't going to change, or make sure the script can find the right account line in case things change so we don't have a duplicate. So, I need to either patch cronjobs/fines.pl and C4/Overdues.pm to use accountlines_id, or patch the cron files to specify when the fines cron job runs (move some jobs from cron.daily to cron.d). I prefer patching fines.pl and C4/Overdues.pm, since I can't be sure how long the cron jobs would run, and some should finish before others start. Options and alternate solutions welcome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:45:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:45:49 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:47:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:47:28 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #12 from Mason James --- Created attachment 131216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131216&action=edit Bug 29881: Remove SQLite2 dependency (follow up) small follow up patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:51:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:51:44 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131216|0 |1 is obsolete| | --- Comment #13 from Mason James --- Comment on attachment 131216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131216 Bug 29881: Remove SQLite2 dependency (follow up) will move this patch to a new bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:52:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:52:10 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #14 from Mason James --- resolving again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:59:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 01:59:45 +0000 Subject: [Koha-bugs] [Bug 30209] New: Upgrade DBD::SQLite2 package to DBD::SQLite3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Bug ID: 30209 Summary: Upgrade DBD::SQLite2 package to DBD::SQLite3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com the DBD::SQLite2 package has been removed in debian-testing, therefor we should upgrade to DBD::SQLite3 package only one script uses DBD::SQLite2 (misc/cronjobs/create_koc_db.pl), see BZ-4269 'create_koc_db.pl' can use both sqlite2 and sqlite3, so we can upgrade this package without a problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:01:52 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade DBD::SQLite2 package to DBD::SQLite3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29881, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=4269 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:01:52 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:01:52 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30209 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:15:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:15:39 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade DBD::SQLite2 |Upgrade |package to DBD::SQLite3 |'libdbd-sqlite2-perl' | |package to | |'libdbd-sqlite3-perl' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:19:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:19:14 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 --- Comment #1 from Mason James --- Created attachment 131217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131217&action=edit Bug 30209: Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' to test... - apply patch, build and install new package - build and install new package - check that libdbd-sqlite3-perl package is installed note: libdbd-sqlite3-perl package installs DBD::SQLite module, which uses sqlite3 :) https://packages.debian.org/stretch/libdbd-sqlite3-perl https://metacpan.org/pod/DBD::SQLite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:20:40 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131217|0 |1 is obsolete| | --- Comment #2 from Mason James --- Created attachment 131218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131218&action=edit Bug 30209: Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' to test... - apply patch, build and install new package - build and install new package - check that libdbd-sqlite3-perl package is installed note: libdbd-sqlite3-perl package installs DBD::SQLite module, which uses sqlite3 :) https://packages.debian.org/stretch/libdbd-sqlite3-perl https://metacpan.org/pod/DBD::SQLite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:21:01 +0000 Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:21:50 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:21:57 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125380|0 |1 is obsolete| | --- Comment #135 from Aleisha Amohia --- Created attachment 131219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131219&action=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:22:04 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125381|0 |1 is obsolete| | --- Comment #136 from Aleisha Amohia --- Created attachment 131220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131220&action=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:22:10 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125382|0 |1 is obsolete| | --- Comment #137 from Aleisha Amohia --- Created attachment 131221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131221&action=edit Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:22:17 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #138 from Aleisha Amohia --- Created attachment 131222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131222&action=edit Bug 14242: (follow-up) Clear all text input fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:22:57 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #139 from Aleisha Amohia --- (In reply to Victor Grousset/tuxayo from comment #133) > I can still reproduce easily comment 128 's *f* test on Firefox and Chromium. > > I can reproduce c. using Chromium, going in the network dev tab, network > conditions (wireless icon), network throttling, adding a custom profile with > 2 seconds of latency. > > That 2 second latency allows me to reproduce d. also. Hopefully latest follow-up addresses the remaining issues! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:31:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:31:32 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 --- Comment #3 from Mason James --- > > ---- Reported by colin.campbell at ptfs-europe.com 2010-02-25 16:18:38 ---- > > The module DBD::SQLite2 is a requirement at present. CPAN testers matrix > shows it failing on most linux perls > 5.8.7 it seems to only be used in > the script > log misc/cronjobs/create_koc_db.pl which also can now support sqlite3. > Should it be removed from Makefile.PL and the script commented to that > affect for anyone wishing to use it? > this bug can be closed, due to work in bz-29881 also, DBD::SQLite2 module has been passing tests since 2018-09-29 http://matrix.cpantesters.org/?dist=+DBD%3A%3ASQLite2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:32:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:32:49 +0000 Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:57:33 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:57:40 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118479|0 |1 is obsolete| | --- Comment #112 from Aleisha Amohia --- Created attachment 131223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131223&action=edit Bug 8628: Updated schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 02:57:47 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #113 from Aleisha Amohia --- Created attachment 131224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131224&action=edit Bug 8628: (follow-up) Fix documentation, subroutine calls, filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:35:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:35:42 +0000 Subject: [Koha-bugs] [Bug 30210] New: Fix typos in cpanfile Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 Bug ID: 30210 Summary: Fix typos in cpanfile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com this patch fixes typos in cpanfile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:39:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:39:15 +0000 Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:39:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:39:18 +0000 Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 --- Comment #1 from Mason James --- Created attachment 131225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131225&action=edit Bug 30210: Fix typos in cpanfile to test... - apply patch - confirm updated versions display correctly in about.pl page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:40:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:40:15 +0000 Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:42:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:42:20 +0000 Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix ubuntu-stable (focal) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #23 from Mason James --- (In reply to Fridolin Somers from comment #22) > (In reply to Jonathan Druart from comment #21) > > (In reply to Jonathan Druart from comment #20) > > > Mason, we need a separate bug report for this last patch. The original one > > > has been backported already. > > > > This is still pending. > I've created Bug 30084 for that thanks Frido! this can be closed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:42:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:42:21 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Bug 30084 depends on bug 25920, which changed state. Bug 25920 Summary: Add liblocale-codes-perl package to fix ubuntu-stable (focal) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:43:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 04:43:16 +0000 Subject: [Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |CLOSED --- Comment #25 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #24) > Pushed in 19.11.18-2 thanks Victor, closing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:10:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:10:36 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #7 from Mason James --- Created attachment 131226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131226&action=edit Update release notes for 21.11.03 release Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:11:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:11:26 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131226|0 |1 is obsolete| | --- Comment #8 from Mason James --- Comment on attachment 131226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131226 Update release notes for 21.11.03 release oops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:27:08 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:27:12 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111675|0 |1 is obsolete| | --- Comment #9 from Mason James --- Created attachment 131227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131227&action=edit Bug 26685: Move starman out of debian/control.in and into cpanfile to test... - apply patch - build and install new package - confirm starman package displays correctly in about.pl page Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:27:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:27:52 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:32:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:32:14 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #10 from Mason James --- Created attachment 131228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131228&action=edit Bug 26685: Move Starman out of debian/control.in and into cpanfile (2) defining package as 'recommended', as suggested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:35:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:35:24 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #11 from Mason James --- Created attachment 131229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131229&action=edit pic pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:55:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:55:12 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 --- Comment #19 from Mason James --- Created attachment 131230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131230&action=edit Bug 30084 - Remove dependency of liblocale-codes-perl (follow-up) trival patch, no test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:56:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:56:39 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131230|0 |1 is obsolete| | --- Comment #20 from Mason James --- Created attachment 131231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131231&action=edit Bug 30084: Remove dependency of liblocale-codes-perl (follow-up) trival patch, no test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:57:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 05:57:47 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 07:00:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 06:00:59 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 --- Comment #21 from Mason James --- (In reply to Mason James from comment #20) > Created attachment 131231 [details] [review] > Bug 30084: Remove dependency of liblocale-codes-perl (follow-up) > > trival patch, no test plan hi Frido, Kyle, here is a small follow-up patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 07:24:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 06:24:10 +0000 Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 --- Comment #22 from Fridolin Somers --- (In reply to Mason James from comment #21) > (In reply to Mason James from comment #20) > > Created attachment 131231 [details] [review] [review] > > Bug 30084: Remove dependency of liblocale-codes-perl (follow-up) > > > > trival patch, no test plan > > hi Frido, Kyle, here is a small follow-up patch Follow-up pushed to master for 22.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 08:01:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 07:01:22 +0000 Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- Are they typos ? According to https://metacpan.org/pod/CPAN::Meta::Spec#Version-Formats they seem valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 08:06:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 07:06:09 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #41 from Fridolin Somers --- Created attachment 131232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131232&action=edit Bug 29857: (QA follow-up) Fix unit test Object.t Unit test failling with : # Failed test 'Exception message correct' # at /kohadevbox/koha/t/db_dependent/Koha/Object.t line 335. # got: 'Exception 'Koha::Exception' thrown 'Asked to embed items but its return value doesn't implement to_api' # ' # expected: 'Asked to embed items but its return value doesn't implement to_api' # Looks like you failed 1 test of 29. Fixed by using $@->message like in other places. prove t/db_dependent/Koha/Object.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 08:29:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 07:29:46 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #42 from Fridolin Somers --- There are other fails in test suite but I push master, we will fix them -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:13:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:13:31 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:20 +0000 Subject: [Koha-bugs] [Bug 20689] Improve usability of Item search fields administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:23 +0000 Subject: [Koha-bugs] [Bug 20689] Improve usability of Item search fields administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #64 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:26 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:28 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:31 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:33 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:35 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:38 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:40 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:42 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:44 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:47 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:49 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:52 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:54 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:56 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #43 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:48:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:48:59 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:01 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:03 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:06 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:08 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:10 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:12 +0000 Subject: [Koha-bugs] [Bug 30132] overdue_notices.pl POD is incorrect regarding passing options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30132 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:14 +0000 Subject: [Koha-bugs] [Bug 30132] overdue_notices.pl POD is incorrect regarding passing options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30132 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:16 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:19 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:21 +0000 Subject: [Koha-bugs] [Bug 30164] Header filter not taken into account on the cities view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:23 +0000 Subject: [Koha-bugs] [Bug 30164] Header filter not taken into account on the cities view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:25 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:27 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:49:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:49:49 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:51:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:51:28 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:51:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 08:51:56 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #26 from Fridolin Somers --- Ah wait, t/Search.t/ is failling : # Failed test '$query built correctly (no operator)' # at t/Search.t line 90. # got: 'query AND parsed_operand' # expected: 'query and parsed_operand' # Failed test '$query_cgi built correctly (no operator)' # at t/Search.t line 92. # got: 'query_cgi&op=%20AND%20&idx=index&q=original_operand' # expected: 'query_cgi&op=%20and%20&idx=index&q=original_operand' # Failed test '$query_desc build correctly (no operator)' # at t/Search.t line 94. # got: 'query_desc AND index_plus original_operand' # expected: 'query_desc and index_plus original_operand' # Looks like you failed 3 tests of 20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:11:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:11:13 +0000 Subject: [Koha-bugs] [Bug 30211] New: TN PLASTICK Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30211 Bug ID: 30211 Summary: TN PLASTICK Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: gggeming1234567890 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 131233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131233&action=edit TN PLASTICK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:12:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:12:00 +0000 Subject: [Koha-bugs] [Bug 30211] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|TN PLASTICK |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:44:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:44:34 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124979|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 131234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131234&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display Signed-ff-by: Barry Cannon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:44:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:44:38 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124980|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 131235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131235&action=edit Bug 22531: Add unit tests Add tests for new and modified methods Signed-off-by: Barry Cannon Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:44:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:44:42 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #18 from Martin Renvoize --- Created attachment 131236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131236&action=edit Bug 22531: (QA follow-up) Fix filter and tab issues Correction to template filters and replace tabs with spaces in code to pass the QA script. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:44:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:44:45 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #19 from Martin Renvoize --- Created attachment 131237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131237&action=edit Bug 22531: (QA follow-up) Fix Unit Tests This patch series adds the ability to generate a partners request multiple times from the same ILL request. It does this be adding the 'GENREQ' action to both 'prev_actions' and 'next_actions' in the 'GENREQ' status segment of the status graph. This QA followup updates the status graph tests to reflect this change. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:45:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 10:45:48 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:17:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 11:17:08 +0000 Subject: [Koha-bugs] [Bug 30212] New: Make Select2 available for ILL backend developers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Bug ID: 30212 Summary: Make Select2 available for ILL backend developers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org When you write a backend, you usually write some .inc template files that are used to render forms, views, etc. It would be great if 'select2.inc' was included on ill-requests.tt so backend authors can use it easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:17:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 11:17:30 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|oleonard at myacpl.org |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:27:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 11:27:34 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 131238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131238&action=edit Bug 30212: Make Select2 available for ILL backends This patch makes select2 available for ILL backend developers to use on their templates. To test: 1. Have a configured backed and an ILL request 2. Open the inspector and load any action on the backend (intranet) => FAIL: no select2 asset is transfered from Koha to the browser 3. Apply this patch 4. Reload => SUCCESS: There's select2 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:35:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 11:35:15 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Tomás Cohen Arazi --- This trivial patch can be cherry-picked down to 20.11 (at least). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:56:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 11:56:48 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:00:16 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:00:16 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:01:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:01:29 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #6 from Martin Renvoize --- I'm going to rework with bug in the light of bug 17648 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:05:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:05:04 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Owen Leonard --- I think this is ready for testing, but I do have concerns about whether I have the workflow correct. As it is now you have to manually clear the "remembered" selections, which could cause confusion if someone is coming back to a new patron search some time later. I'm interested in how others think that works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:19:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:19:03 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #851 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #850) > Not unfinished business, I was just copying the similar code above, but I > have removed in latest follow-up. Are you really really sure about that :) ? Look here, read the else comment too ! elsif ( $code eq 'ReturnClaims' ) { $template->param( ReturnClaims => $messages->{ReturnClaims} ); - } elsif ( $code eq 'RecallFound' ) { - ; - } elsif ( $code eq 'RecallNeedsTransfer' ) { - ; - } elsif ( $code eq 'TransferredRecall' ) { - ; } else { die "Unknown error code $code"; # note we need all the (empty) elsif's above, or we die. # This forces the issue of staying in sync w/ Circulation.pm In conclusion: We dont wanna die here, but as for ReturnClaims we could send a code to the template allowing to return something meaningful to the user? Obsoleting the last patch now. Correct me when I am wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:19:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:19:45 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:20:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:20:19 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 131239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131239&action=edit Bug 30007: (follow-up) Adjust Koha::Patrons->search_patrons_to_anonymise tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:22:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:22:43 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #14 from Tomás Cohen Arazi --- Frido, I posted a follow-up for Koha/Patrons.t tests failures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:29:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:29:01 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 131240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131240&action=edit Bug 29857: (follow-up) Fix Barcode_transform_hooks.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:30:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:30:01 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #852 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #851) > In conclusion: We dont wanna die here, but as for ReturnClaims we could send > a code to the template allowing to return something meaningful to the user? > Obsoleting the last patch now. Correct me when I am wrong. And looking in context, I indeed see stuff like: elsif ( $code eq 'WrongTransfer' ) { ; # FIXME... anything to do here? } elsif ( $code eq 'WrongTransferItem' ) { ; # FIXME... anything to do here? } So lets just leave as-is now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:33:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:33:13 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #853 from Marcel de Rooy --- FAIL C4/Circulation.pm FAIL pod coverage POD is missing for AddOfflineOperation POD is missing for CheckValidBarcode POD is missing for DeleteOfflineOperation POD is missing for GetOfflineOperation POD is missing for GetOfflineOperations POD is missing for GetRenewCount POD is missing for GetTopIssues POD is missing for ProcessOfflineIssue POD is missing for ProcessOfflineOperation POD is missing for ProcessOfflinePayment POD is missing for ProcessOfflineReturn POD is missing for ReturnLostItem POD is missing for TooMany POD is missing for checkHighHolds C4::Circulation has a Pod::Coverage rating of 0.702127659574468 The following are uncovered: AddOfflineOperation, CheckValidBarcode, DeleteOfflineOperation, GetOfflineOperation, GetOfflineOperations, GetRenewCount, GetTopIssues, ProcessOfflineIssue, ProcessOfflineOperation, ProcessOfflinePayment, ProcessOfflineReturn, ReturnLostItem, TooMany, checkHighHolds This can be safely ignored: we dont add subs here, just some changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:40:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:40:18 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #45 from Tomás Cohen Arazi --- Created attachment 131241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131241&action=edit Bug 29857: (follow-up) Fix t/Koha/Plugins/Tab.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:42:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:42:42 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #854 from Marcel de Rooy --- Same remark for: FAIL C4/Overdues.pm FAIL pod coverage POD is missing for 'GetWdayFromItemnumber' and FAIL C4/XSLT.pm FAIL pod coverage POD is missing for get_xsl_filename POD is missing for get_xslt_sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:47:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:47:22 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:49:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:49:44 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #46 from Tomás Cohen Arazi --- Created attachment 131242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131242&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Biblio.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:52:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:52:46 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #47 from Tomás Cohen Arazi --- Created attachment 131243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131243&action=edit Bug 29857: (follow-up) Fix t/Koha/Object/Message.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:55:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:55:33 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #855 from Marcel de Rooy --- I remember to have posted this before, but these lines show me that Recalls does not support itemtype notforloan: + return 0 if ( $self->notforloan != 0 ); OR + my @items = Koha::Items->search({ biblionumber => $self->biblionumber, itemlost => 0, withdrawn => 0, notforloan => 0 })->as_list; OR + [% IF ( item.notforloan ) %] The only check for notforloan in the new code is made only on the item, not on the itemtype. Dont think that we need to fix it here now. No blocker. I am wondering btw: If we can only recall something checked out, when would notforloan come into play actually? Seems to be an edge case like item was checked out, notforloan was activated after that, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:57:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 12:57:55 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #48 from Tomás Cohen Arazi --- Created attachment 131244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131244&action=edit Bug 29857: (follow-up) Fix t/Koha/Email.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:14:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:14:04 +0000 Subject: [Koha-bugs] [Bug 30158] Add a QR code for the list of results when doing a research on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30158 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:14:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:14:27 +0000 Subject: [Koha-bugs] [Bug 30157] Make hold notes visible from the holds tab in patrons account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30157 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:33:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:33:16 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131202|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 131245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131245&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:34:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:34:42 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #14 from Martin Renvoize --- OK, this all works now.. but only with my followups as they fix the imports.. I decided not to doctor Kyles original patch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:35:09 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #7 from Martin Renvoize --- Created attachment 131246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131246&action=edit Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:35:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:35:38 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:36:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:36:16 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131246|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 131247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131247&action=edit Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:42:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 13:42:10 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #9 from Martin Renvoize --- Created attachment 131248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131248&action=edit Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:20:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:20:30 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131247|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 131249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131249&action=edit Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:20:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:20:34 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131248|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 131250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131250&action=edit Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:20:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:20:38 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #12 from Martin Renvoize --- Created attachment 131251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131251&action=edit Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:10 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131249|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 131252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131252&action=edit Bug 29005: Add option to send welcome email from patron imports This patch adds the ability to send the ACCTDETAILS notice for new users added using the patron import tool. Test plan 1. Create a valid csv for patron import that includes some new users, ensuring you add a valid email address for which you have access. 2. Import the users using the patron import tool and select the new 'Send email to new patrons' checkbox. 3. Check that the notice appears in the new patrons notices 4. Check that you received a welcome email for the user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:14 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131250|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 131253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131253&action=edit Bug 29005: Add support for the command line script This patch adds welcome email for new users support to the command line patron import tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:18 +0000 Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131251|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize --- Created attachment 131254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131254&action=edit Bug 29005: Unit tests Add a unit test for the additional functionality of sending welcome emails from Koha::Patrons::Import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:31 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:34 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 --- Comment #1 from Owen Leonard --- Created attachment 131255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131255&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:24:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:24:53 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add support for |Add option to send |AutoEmailUser similar to |ACCDETAILS notice for new |AutoEmailOpacUser to patron |patrons added via patron |imports |imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:25:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:25:11 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:25:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:25:27 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:37:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:37:18 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #49 from Tomás Cohen Arazi --- Created attachment 131256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131256&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Auth.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:40:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:40:55 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:41:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:41:08 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #856 from Marcel de Rooy --- Created attachment 131257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131257&action=edit Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber The fines cron job uses Getoverdues to pass issue info to CalcFine. It took me a while to realize that the overdue hash does not contain a biblionumber. When testing CalcFine, we pass an item hash that does include one. So what happened? $item->{biblionumber} is undefined when it comes from Getoverdues and no recall overdue fine is calculated, only a regular one. Simple fix (without any impact): Add a biblionumber to Getoverdues. Signed-off-by: Marcel de Rooy Tested with fines.pl: recall fine applied now. Ran some Circulation and Overdues unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:43:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:43:06 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 131258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131258&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Patron/Modifications.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:43:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:43:25 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #11 from Martin Renvoize --- Patron imports done.. see bug 29005 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:44:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:44:00 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #51 from Tomás Cohen Arazi --- Just in case: I'm submitting the fixes one by one just in case I need to leave and cannot complete the fixes. But this could just be pushed on a single commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:45:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:45:17 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #857 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #856) > Created attachment 131257 [details] [review] > Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber > > The fines cron job uses Getoverdues to pass issue info to CalcFine. > It took me a while to realize that the overdue hash does not contain > a biblionumber. When testing CalcFine, we pass an item hash that > does include one. > > So what happened? $item->{biblionumber} is undefined when it comes from > Getoverdues and no recall overdue fine is calculated, only a regular one. > > Simple fix (without any impact): Add a biblionumber to Getoverdues. > > Signed-off-by: Marcel de Rooy > Tested with fines.pl: recall fine applied now. > Ran some Circulation and Overdues unit tests. This was a serious bug! The fines cron job would never ever calculate the correct recalls fine when you relied on Getoverdues without biblionumber.. I didnt see any reference to testing this process in the large test plan btw ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:50:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:50:16 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:50:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:50:20 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131255|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 131259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131259&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:50:46 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 --- Comment #3 from Lucas Gass --- Thanks Owen, that looks much better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:51:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:51:17 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #52 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #51) > Just in case: I'm submitting the fixes one by one just in case I need to > leave and cannot complete the fixes. But this could just be pushed on a > single commit. These one line patches read so beautifully ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:57:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:57:12 +0000 Subject: [Koha-bugs] [Bug 30213] New: Hide Delete (aka Priority) column when user only has place_hold permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Bug ID: 30213 Summary: Hide Delete (aka Priority) column when user only has place_hold permission Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With the change to holds permissions in Bug 29540, the Delete (or Priority, with full holds permissions) column isn't useful and is misleading for users with only the place_hold permission. They don't have the option to change holds' priority using the column, and if they select 'del' on a patron to delete their hold, they get locked out for having insufficient permissions when they click the Update Hold(s) button. But this is misleading because they *can* delete an individual hold using the red X. It would be clearer if that entire column were hidden for users with only the place_hold permission. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:57:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:57:12 +0000 Subject: [Koha-bugs] [Bug 29540] Accounts with just 'catalogue' permission can modify/delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29540 Sara Brown changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30213 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:58:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 14:58:43 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com | |, | |lucas at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:06:27 +0000 Subject: [Koha-bugs] [Bug 30214] New: Add option to send ACCDETAILS notice for new patrons added via self registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Bug ID: 30214 Summary: Add option to send ACCDETAILS notice for new patrons added via self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: andrew at bywatersolutions.com, bwsdonna at gmail.com, gmcharlt at gmail.com, katrin.fischer at bsz-bw.de, kris.sinnaeve at etf.edu, kyle.m.hall at gmail.com, kyle at bywatersolutions.com, mirjam.vantieghem at etf.edu, oleonard at myacpl.org, testopia at bugs.koha-community.org Depends on: 17648 Blocks: 9097 It would be helpful to add automatic email to users on patron self-registration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:06:27 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:06:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:06:27 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:19:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #858 from Marcel de Rooy --- TODO We need to add two new cronjobs to the cron files (debian side and example file somewhere in etc folder) misc/cronjobs/recalls/expire_recalls.pl misc/cronjobs/recalls/overdue_recalls.pl They both do a recalls search. If one has not activated recalls, no records are found. Early exit. All fine. Note the following: "check if item has been recalled. recall should have been marked Overdue by cronjob, so only look at overdue recalls" => So we need to run overdue_recalls BEFORE fines (CalcFine) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:30:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:30:47 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #859 from Marcel de Rooy --- Created attachment 131260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131260&action=edit Bug 19532: (QA follow-up) Move as_list to iterator based loop Adjusting both new cron jobs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:36:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:36:22 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #1 from Andrew Fuerste-Henry --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:50:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:50:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130641|0 |1 is obsolete| | --- Comment #860 from Marcel de Rooy --- Created attachment 131261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131261&action=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:51:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:51:04 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #861 from Marcel de Rooy --- Created attachment 131262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131262&action=edit Bug 19532: [DBIx] Updated schema files Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:51:24 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #862 from Marcel de Rooy --- Created attachment 131263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131263&action=edit Bug 19532: [DBIx] Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:51:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:51:37 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #863 from Marcel de Rooy --- Created attachment 131264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131264&action=edit Bug 19532: [DBIx] Schema change for Recalls Separated from the "Recalls-objects-and-tests" patch Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:51:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:51:50 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130644|0 |1 is obsolete| | --- Comment #864 from Marcel de Rooy --- Created attachment 131265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131265&action=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:52:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:52:03 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130645|0 |1 is obsolete| | --- Comment #865 from Marcel de Rooy --- Created attachment 131266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131266&action=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:52:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:52:16 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130646|0 |1 is obsolete| | --- Comment #866 from Marcel de Rooy --- Created attachment 131267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131267&action=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:52:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:52:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130647|0 |1 is obsolete| | --- Comment #867 from Marcel de Rooy --- Created attachment 131268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131268&action=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:52:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:52:43 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130648|0 |1 is obsolete| | --- Comment #868 from Marcel de Rooy --- Created attachment 131269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131269&action=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note to say that the item was recalled and the due date adjusted. 23. Log in to the OPAC as Borrower B and go to your summary tab. Notice there is a note under their checkout to say the item had been recalled. 24. Log out of the OPAC and log back in as Borrower A. 25. Go to your summary tab. Confirm there is a Recalls tab with a count of 1. 26. Cancel the recall using the button. Confirm it cancels and the Recalls tab disappears. 27. Do a catalogue search with a term that will return multiple results, including Biblio A. 28. When the results load, notice there is a 'Place recall' button next to the 'Place hold' button. Click this 'Place recall' button. 29. Notice you are redirected straight to the form to place a recall. 30. Place a biblio-level recall again, following the steps in Step 19. 31. Go to your recalls history tab. Notice your first cancelled recall shows here. 32. Cancel the recall you just created, using the button. Confirm it cancels and you are redirected to your summary tab. 33. In the staff client, enable the UseCourseReserves system preference. 34. Go to the main menu, click Course Reserves. 35. Add a new course. (You may also have to define an authorised value for DEPARTMENT.) 36. Add Item A as a reserve to this course. 37. View Course Reserves in the OPAC. Click the course you just created. 38. Notice the reserve has a Recall button underneath it's 'Checked out' status. Click this button. 39. Place a biblio-level recall again, following the steps in Step 19. 40. Click the 'Place recall' link in the breadcrumbs. 41. Notice there is a message saying that you have reached the max number of recalls on this record. This is because Recalls allowed = 1 and Recalls per record = 1. 42. Edit the circulation rules to have the following values: Recalls allowed (count) = 10 Recalls per record (count) = 5 43. Refresh the 'Place recall' page. You will now see the form to place a recall. 44. Create another test record (Biblio B) with at least one item (Item C). 45. Find this record on the OPAC and place a biblio-level recall again, following the steps in Step 19. 46. In the staff client, go to Circulation -> Old recalls. You should be able to see your two cancelled recalls. 47. Go to Circulation -> Recalls queue. Your current recalls should show here. 48. Use the 'Select all' checkbox to select all recalls. 49. Cancel the recalls using the 'Cancel selected recalls' button. 50. Go to the OPAC and place a biblio-level recall on Biblio A again, following the steps in Step 19. 51. In the staff client, check in Item A, which should still be checked out to Borrower B. 52. A box should pop-up asking you to confirm Borrower A's recall. Click ignore. 53. Click the link to go view Biblio A's details in the catalogue. 54. Click the recalls tab. Notice Borrower A's recall is displayed, and shows it is still Requested (has not been confirmed waiting). 55. Check in Item A again. This time, confirm the recall as waiting using the "Confirm recall" button. 56. Go to Borrower A's Notices tab. Confirm there is a notice "Recalled item awaiting pickup". 57. Go to Borrower A's checkouts. Notice there is a recalls tab. Confirm the recall is showing as "Ready for pickup". 58. Click the 'Actions' dropdown. Click the "Revert waiting" button. The page should show a message that the waiting status has been reverted, without reloading. 59. This time, check in Item B. The recall confirmation box should show again, because this a biblio-level recall that any recallable item under Biblio A can fill. Click the "Print slip and confirm" button. 60. Check the slip that is generated. Confirm it contains Borrower A's correct details, and the details of the recall are correct. 61. Go to Circulation -> Recalls awaiting pickup. Confirm the recall is now waiting and shows in this list. (You could also try this with Item B having a different item type to Item A, and circ rules not allowing Item B's item type to have recalls. When checking in Item A, it should not trigger the recall box). 62. Go to Borrower A's checkouts. Check out Item B. 63. Confirm the checkout is successful and the recall is removed from the Recalls tab. 64. Go to Circulation -> Old recalls. The fulfilled recall should show. 65. Check in Item B. BIBLIO-LEVEL RECALL, TRANSFER REQUIRED 66. Check out Item A to Borrower B. 67. Log in to the OPAC as Borrower A. 68. Find Biblio A and place a biblio-level recall. Pickup location: Branch B, a different branch from your logged in branch. This recall will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 69. In the staff client, check in Item A at Branch A. Notice the box that pops up shows that a transfer is required. 70. Click "confirm recall and transfer" and confirm the transfer. 71. Go to your account and click the Recalls tab. 72. Confirm the recall status now shows the item is in transit to Branch B. 73. In the drop-down top-right of your window, select 'Set library'. 74. Set your library to Branch B. 75. Go to Circulation -> Transfers to receive. Notice that the recall is showing here. 76. Click 'Cancel transfer'. 77. Go to Circulation -> Recalls queue 78. Confirm the recall status has been reverted to Requested. 79. Set your library back to Branch A. 80. Check in Item A and trigger the transfer. 81. Set your library back to Branch B. 82. Check in Item A at Branch B. 83. When the 'Recall found' box pops up, click Ignore. 84. Go to Circulation -> Recalls to pull. The recall should show here, with a button to "Cancel recall and return to: Branch A" 85. Click the button to cancel the recall. 86. Repeat Steps 66-70. 87. Check in Item A at Branch B. Confirm the recall as waiting. 88. Check out Item A to Borrower A to fulfill the recall. 89. Set your library back to Branch A and check in Item A. ITEM-LEVEL RECALL, NO TRANSFER 90. Go to Administration -> circulation rules. Set the following rules: On shelf recalls allowed ( If any unavailable / If all unavailable ) = If all unavailable 91. Check out Item A to Borrower B. 92. Log in to the OPAC as Borrower A and go to Biblio A. 93. Click the 'Place recall' button. Confirm there is a message that there are no items to recall. This is because On shelf recalls allowed = If all unavailable, and there is still one item (Item B) available. 94. In the staff client, edit Item B to have a withdrawn, item lost or not for loan status. 95. Refresh the 'Place recall' page. Confirm you can now see the form to place a recall. 96. Place an item-level recall. Pickup location: Branch A. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 97. In the staff client, edit Item B and remove the lost or missing status. 98. Check in Item B. Confirm the recall box does not pop up, because it cannot fill the item-level recall. 99. Check in Item A. Confirm the recall as waiting. 100. Go to Circulation -> Recalls awaiting pickup 101. Expire the recall. Confirm it expires as expected. ITEM-LEVEL RECALL, TRANSFER REQUIRED 102. Repeat steps 91 to 95. 103. Place an item-level recall. Pickup location: Branch B, we will require a transfer. Recall not needed after (expiration date): whatever you want Select 'recall a specific item' Item B will not be selectable, and Item A should be selected by default. Click confirm 104. In the staff client, check in Item A. Confirm the recall and trigger the transfer. 105. Set your library to Branch B and check in Item A. 106. Confirm the recall as waiting. 107. Check out Item A to Borrower A and fulfill the recall. 108. Set your library back to Branch A and check in Item A. CRONJOBS: EXPIRING RECALL 109. Check out Item A to Borrower B. 110. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 111. In your terminal, enter mysql and edit the expiration date of your recall to be before today UPDATE recalls SET expirationdate = NOW()-2 WHERE recall_id = X; 112. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 113. Go to Borrower A's account and go to the Recalls history tab 114. Confirm the recall has been expired because the current date surpassed the specified expiration date 115. Check out Item A to Borrower B. 116. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 117. In the staff client, check in Item A and confirm the recall as waiting. 118. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW() - interval 5 day WHERE recall_id = X; 119. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 120. Go to Borrower A's account and go to the Recalls history tab 121. Confirm the recall has been expired because the recall had been waiting for more days than the Recall pickup period 122. Go to Administration -> circulation rules. Set the following rules: Recall pickup period (days) = 0 123. Set the RecallsMaxPickUpDelay system preference = 1. 124. Check out Item A to Borrower B. 125. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 126. In the staff client, check in Item A and confirm the recall as waiting. 127. In your terminal, enter mysql and edit the waiting date of your recall to be before today UPDATE recalls SET waitingdate = NOW()-2 WHERE recall_id = X; 128. Run the expiry cronjob from within your shell perl misc/cronjobs/recalls/expire_recalls.pl 129. Go to Borrower A's account and go to the Recalls history tab 130. Confirm the recall has been expired because the recall had been waiting for more days than the RecallsMaxPickUpDelay syspref CRONJOBS: OVERDUE RECALL 131. Check out Item A to Borrower B 132. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 133. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 134. Run the overdue cronjob from within your shell perl misc/cronjobs/recall/overdue_recalls.pl 135. Go to Circulation -> Overdue recalls 136. Confirm your recall is showing here now as the recall has been marked Overdue CIRCULATION 137. Check in Item A. 138. When the recall box pops up, click Ignore. 139. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that another borrower has recalled the item you are trying to check out. 140. Click "No don't check out" and confirm the item isn't checked out and the recall remains. 141. Repeat Step 139. 142. Click "Yes check out" and confirm the item is checked out and the recall remains. 143. When Borrower B's checkout table loads, confirm that you cannot renew or check in the item from the Checkouts table because there is a 'Recalled' link which takes you to the recalls tab for that biblio. 144. Repeat Steps 137-139. 145. Select "Cancel recall" and click "Yes check out" and confirm the item is checked out and the recall has been cancelled. 146. Log in to the OPAC as Borrower A. Place a recall (any level) on Biblio A. 147. Check in Item A. Confirm the recall as waiting. 148. Check out Item A to Borrower B. You should see a yellow confirmation box, saying that that another borrower has recalled the item that you are trying to check out. 149. Select "Revert waiting status" and click "Yes check out" and confirm the item is checked out and the recall status has reverted to requested. OTHER 150. In your terminal, enter mysql and edit the due date of the checkout to Borrower B to be before today UPDATE issues SET date_due = NOW()-2 WHERE issue_id = X; 151. Go to Borrower A's recalls and click the Actions dropdown. 152. Click "Mark as overdue" and confirm the recall is marked as overdue manually. 153. Go to Tools -> Log Viewer. Check only the Recalls module, and leave all other parameters, and click Submit. 154. Confirm all of the recalls actions that have been made are correctly logged. Note: recalls messaging preferences are introduced in Bug 23781. The recall feature is fully documented at: https://wiki.koha-community.org/wiki/Catalyst_IT_Recalls Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:52:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:52:58 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130649|0 |1 is obsolete| | --- Comment #869 from Marcel de Rooy --- Created attachment 131270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131270&action=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:53:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:53:15 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130650|0 |1 is obsolete| | --- Comment #870 from Marcel de Rooy --- Created attachment 131271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131271&action=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:53:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:53:30 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130651|0 |1 is obsolete| | --- Comment #871 from Marcel de Rooy --- Created attachment 131272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131272&action=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:53:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:53:44 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130652|0 |1 is obsolete| | --- Comment #872 from Marcel de Rooy --- Created attachment 131273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131273&action=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:53:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:53:57 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130653|0 |1 is obsolete| | --- Comment #873 from Marcel de Rooy --- Created attachment 131274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131274&action=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:54:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:54:12 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131156|0 |1 is obsolete| | --- Comment #874 from Marcel de Rooy --- Created attachment 131275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131275&action=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:54:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:54:26 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131157|0 |1 is obsolete| | --- Comment #875 from Marcel de Rooy --- Created attachment 131276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131276&action=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:54:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:54:39 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131158|0 |1 is obsolete| | --- Comment #876 from Marcel de Rooy --- Created attachment 131277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131277&action=edit Bug 19532: (follow-up) Fixes along recall workflow Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:54:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:54:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131159|0 |1 is obsolete| | --- Comment #877 from Marcel de Rooy --- Created attachment 131278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131278&action=edit Bug 19532: (QA follow-up) Fixing unit tests (Trivial:) Number of tests in Koha/Item.t Added a $patron object to resolve warnings like: * Global symbol "$patron" requires explicit package name (did you forget to declare "my $patron"?) at t/db_dependent/Koha/Patron.t line 1064. Fixed CanItemBeReserved call in Holds.t, number of tests adjusted Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:55:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:55:07 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131160|0 |1 is obsolete| | --- Comment #878 from Marcel de Rooy --- Created attachment 131279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131279&action=edit Bug 19532: (follow-up) Fix for wantarray change and title-string Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:55:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:55:21 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131193|0 |1 is obsolete| | --- Comment #879 from Marcel de Rooy --- Created attachment 131280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131280&action=edit Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences Due to the wantarray change, we should fix this call in list context. We should either use an iterator now or append as_list. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:55:35 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131257|0 |1 is obsolete| | --- Comment #880 from Marcel de Rooy --- Created attachment 131281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131281&action=edit Bug 19532: (QA follow-up) Fix fine calculation by inserting biblionumber The fines cron job uses Getoverdues to pass issue info to CalcFine. It took me a while to realize that the overdue hash does not contain a biblionumber. When testing CalcFine, we pass an item hash that does include one. So what happened? $item->{biblionumber} is undefined when it comes from Getoverdues and no recall overdue fine is calculated, only a regular one. Simple fix (without any impact): Add a biblionumber to Getoverdues. Signed-off-by: Marcel de Rooy Tested with fines.pl: recall fine applied now. Ran some Circulation and Overdues unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:55:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:55:48 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131260|0 |1 is obsolete| | --- Comment #881 from Marcel de Rooy --- Created attachment 131282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131282&action=edit Bug 19532: (QA follow-up) Move as_list to iterator based loop Adjusting both new cron jobs. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:57:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 15:57:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #882 from Marcel de Rooy --- Aleisha: Note that I added an extra patch in the beginning too to extract DBIx stuff out of a regular patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:00:53 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130642|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:01:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:01:20 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:08:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:08:25 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #2 from Martin Renvoize --- Created attachment 131283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131283&action=edit Bug 30214: Add ACCTDETAILS notice to self registeration This patch adds the ACCTDETAILS notice trigger to the opac self registration process. Allowing new users, without varification enabled, to receive the ACCTDETAILS notice immediately after their account is created. Test plan 1) Enable AutoEmailOpacUser system preference 2) Ensure the ACCTDETAILS notice is configured 3) Ensure `PatronSelfRegistrationVerifyByEmail` is disabled 4) Register a new user via the opac self registration process using an email address you have access to 5) The new user should have been created and you should be able to see the account details notice in their associated notices 6) Confirm that the email address used above has received the notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:09:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:09:59 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #3 from Martin Renvoize --- Still working here, I'll add NSO status once I've added the next patches (to work with the verification workflow) The current patch also immediately sends the notice after adding it to the message queue.. I'm not sure if this is correct or whether we should wait for the normal process to send mail to run. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:12:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:12:24 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #12 from Lucas Gass --- > I like the idea of making it a category and we should maybe note in the > description it works independently from Independentbranches? I am ok with > the pref name as is. Cait, can you explain what is meant by "category"? I don't understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:19:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:19:36 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #4 from Martin Renvoize --- Created attachment 131284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131284&action=edit Bug 30214: Add ACCTDETAILS notice to verified self registration This patch adds the ACCTDETAILS notice trigger to the opac self registration process. Allowing new users, with varification enabled, to receive the ACCTDETAILS notice immediately after their account is varified. Test plan 1) Enable AutoEmailOpacUser system preference 2) Ensure the ACCTDETAILS notice is configured 3) Ensure `PatronSelfRegistrationVerifyByEmail` is enabled 4) Register a new user via the opac self registration process using an email address you have access to 5) Verify the user by following the link in the verification email you should have received. 6) The new user should have been created and you should be able to see the account details notice in their associated notices 7) Confirm that the email address used above has received the notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:19:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:19:50 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:19:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:19:56 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:20:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:20:22 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com, | |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:21:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:21:50 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #12 from Martin Renvoize --- Self registration done, bug 30214 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:22:23 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17648 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:22:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:22:23 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9097 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:24:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:24:08 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #13 from Martin Renvoize --- Does that cover everything? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:24:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:24:17 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:30:12 +0000 Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC should use 'record' instead of 'biblios' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:30:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:30:15 +0000 Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC should use 'record' instead of 'biblios' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191 --- Comment #1 from Owen Leonard --- Created attachment 131285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131285&action=edit Bug 30191: Authority search result list in the OPAC should use 'record' instead of 'biblios' This patch updates the OPAC authority search results page so that it uses the term "record" instead of "biblio." The patch also changes how the template outputs the count of records so that it is correctly pluralized, e.g. "1 record" vs. "2 records." To test, apply the patch and perform an authority search in the OPAC. In the search results, confirm that the last table header reads "Records." The information in that column should be correct, using the word record or records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:32:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:32:19 +0000 Subject: [Koha-bugs] [Bug 30191] Authority search result list in the OPAC should use 'record' instead of 'biblios' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:35:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:35:51 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:35:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:35:55 +0000 Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130749|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry --- Created attachment 131286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131286&action=edit Bug 24865: Customize the Accountlines Description It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. Test Plan: 1) Create an overdue checkout that will get a fine 2) Run fines.pl 3) Note the description for the fine 4) Delete the fine from the database 5) Apply this patch 6) Run updatedatabase.pl 7) Restart all the things! 8) Run fines.pl 9) Note the description of the fine is unchanged 10) Delete the fine again 11) Browse to Slips & Notices 12) Edit the new notice OVERDUE_FINE_DESC You will have access to the objects checkout, item, and borrower 13) Run fines.pl 14) Note your new description was used Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:40:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:40:35 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #33 from Martin Renvoize --- Note.. I'm almost tempted to just ditch the ACCTDETAILS notice entirely and replace it with a new 'WELCOME' notice instead.. thus making the whole template and translations stuff mute. Especially as the bugs that all hang off this now make the whole feature feel much more like a Welcome Email feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:42:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 16:42:44 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:10:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 17:10:30 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 --- Comment #34 from Andrew Fuerste-Henry --- +1 on the idea of creating a new Welcome Email feature to replace ACCTDETAILS. The current implementation is confusingly limited and inflexible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:35:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 17:35:35 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the display of release notes| |the 'Apply discount' button | |for VOID transactions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:09:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:09:10 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #53 from Fridolin Somers --- Created attachment 131287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131287&action=edit Bug 29857: (follow-up) Fix t/Koha/REST/Plugin/Query.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:09:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:09:15 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #54 from Fridolin Somers --- Created attachment 131288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131288&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Plugins/Plugins.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:09:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:09:20 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #55 from Fridolin Somers --- Created attachment 131289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131289&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/Club/Hold.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:31:10 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #56 from Fridolin Somers --- Created attachment 131290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131290&action=edit Bug 29857: (follow-up) Fix t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:31:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:31:16 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #57 from Fridolin Somers --- Created attachment 131291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131291&action=edit Bug 29857: (follow-up) Fix t/db_dependent/api/v1/transfer_limits.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:32:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:32:01 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #5 from Barbara Johnson --- I completed steps 1-4. I set up two different accounts using two different email addresses but I never received the email confirmation listed in step 5. To see if email was working at all I enabled OpacPasswordChange and OpacResetPassword. I edited an account by adding my email address to it. I then logged into the account on the OPAC and tried to reset my password but I didn't receive an email for that either. Maybe email doesn't work in a sandbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:32:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:32:46 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 --- Comment #58 from Fridolin Somers --- Follow-ups pushed to master : > git log --oneline --no-decorate --grep=29857 be74dd2edf Bug 29857: (follow-up) Fix t/db_dependent/api/v1/transfer_limits.t 94220261f2 Bug 29857: (follow-up) Fix t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t b5560af25e Bug 29857: (follow-up) Fix t/db_dependent/Koha/Club/Hold.t 6ccf04661a Bug 29857: (follow-up) Fix t/db_dependent/Koha/Plugins/Plugins.t e93de8268e Bug 29857: (follow-up) Fix t/Koha/REST/Plugin/Query.t 13a49f860f Bug 29857: (follow-up) Fix t/db_dependent/Koha/Patron/Modifications.t d406051dcb Bug 29857: (follow-up) Fix t/db_dependent/Auth.t 8d2c00fb02 Bug 29857: (follow-up) Fix t/Koha/Email.t e568e8ef5d Bug 29857: (follow-up) Fix t/Koha/Object/Message.t 42c592f3ad Bug 29857: (follow-up) Fix t/db_dependent/Koha/Biblio.t bcd98589c1 Bug 29857: (follow-up) Fix t/Koha/Plugins/Tab.t 651a2228aa Bug 29857: (follow-up) Fix Barcode_transform_hooks.t c287121471 Bug 29857: (QA follow-up) Fix unit test Object.t 6ece7185b0 Bug 29857: (QA follow-up) Add license 3951145cf7 Bug 29857: Fix behavior c10640e8a7 Bug 29857: Unit tests 2b9fae5445 Bug 29857: Rename base class as Koha::Exception 7429f28cfc Bug 29857: Provide a generic full_message method for our exceptions 42096deea4 Bug 29857: Make the exception classes inherit from the base class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:44:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:44:13 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:44:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:44:52 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #15 from Fridolin Somers --- Patch "(follow-up) Adjust Koha::Patrons->search_patrons_to_anonymise tests" pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:48:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:48:33 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #16 from Fridolin Somers --- Ohhh but this changes the actual behavior. Without this patch running anonymise with AnonymousPatron undefined (0 or empry string) is allowed : borrowernumber is set to null This is usefull because AnonymousPatron default value is 0. We agree on new behavior and create a unit test for this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:54:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:54:46 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #27 from Fridolin Somers --- Created attachment 131292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131292&action=edit Bug 25616: (follow-up) Fix t/Search.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:55:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:55:04 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:56:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:56:03 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #28 from Fridolin Somers --- Created attachment 131293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131293&action=edit Bug 25616: [21.11.x] (follow-up) Fix t/Search.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:56:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:56:35 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #29 from Fridolin Somers --- Bug 25616: (follow-up) Fix t/Search.t pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 19:59:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 18:59:55 +0000 Subject: [Koha-bugs] [Bug 29525] Privacy settings for patrons should also affect holds history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #48 from Fridolin Somers --- This is important for GDPR, can it be backported to 21.11.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:09:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:09:00 +0000 Subject: [Koha-bugs] [Bug 28688] Auto Renew Patron Membership if Patron has Been Active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 saylett at spanishfork.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saylett at spanishfork.org --- Comment #3 from saylett at spanishfork.org --- This would be a great feature. We field countless calls/texts/emails from active patrons needing to renew their accounts. We've discussed extending the renewal period, but having it auto-renew based on activity would be much better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:19:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:19:49 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 --- Comment #1 from Lucas Gass --- Created attachment 131294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131294&action=edit Bug 20161: add format, material type, etc to staff details page 1. Make sure DisplayIconsXSLT is on. 2. Look at the results page from the staff client. 3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material' 4. Look at the staff detail page and notice that only 'Material type' will show. 5. Apply patch and restart everything 6. Now look at the detail page and it should match what you see on the results page. 7. Turn off DisplayIconsXSLT 8. Make sure nothing on the results_material_type now displays. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:22:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:22:04 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 --- Comment #2 from Lucas Gass --- This first patch deals with the staff client. A second one to deal with the OPAC will be incoming ASAP. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:22:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:22:55 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:39:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:39:23 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #883 from Aleisha Amohia --- It's looking good Marcel! Thanks for your help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:56:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 19:56:33 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:27:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:27:55 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:28:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:28:00 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 --- Comment #21 from Fridolin Somers --- Created attachment 131295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131295&action=edit Bug 26311: Add patron invalid age to search_for_data_inconsistencies.pl Patron categories may have age limits. Add to script misc/maintenance/search_for_data_inconsistencies.pl the list of patrons which age is invalid regarding there category. Test plan : 1) Create an adult patron category limited to 18-99 years 2) Create a patron in the category 3) Edit in database its date of birth so that he is 17 years old 4) Run misc/maintenance/search_for_data_inconsistencies.pl => You see the patron Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:28:05 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128236|0 |1 is obsolete| | --- Comment #22 from Fridolin Somers --- Created attachment 131296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131296&action=edit Bug 26311: (QA follow-up) Rephrase output message This is a suggestion for rephrasing the message slightly: Before: * Patron borrowernumber=15 in category 'J' has invalid age '56' After: * Patron borrowernumber=37 has an invalid age of 37 for their category 'K' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:28:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:28:09 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128237|0 |1 is obsolete| | --- Comment #23 from Fridolin Somers --- Created attachment 131297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131297&action=edit Bug 26311: (follow-up) loop through the patron with date of birth and in categories having age limits Also added category limits in message, for example (12-18) Check patron : - with no date of birth - with invalid age in category having age required - with invalid age in category having upper age limit - with invalid age in category having age required and upper age limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:28:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:28:51 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:30:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:30:46 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 --- Comment #24 from Fridolin Somers --- (In reply to David Nind from comment #20) > Testing notes and issues identified (using koha-testing-docker): Thanks a lot for testing David. I've found an error in patrons select. Fixed with prefetch of patron category. You may test again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:50:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:50:43 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 131298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131298&action=edit Bug 30007: (follow-up) Adapt tests This patch adapts tests to acknowledge ->cancel and ->fill methods won't yield 'undef' borrowernumber when anonymization takes place, and even further, and exception will be thrown and cancellation/fulfillment will be rejected. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Bonus: this problem was hidding bad tests caused by 29857, fixed on this one as well. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:51:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 20:51:24 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #16) > Ohhh but this changes the actual behavior. > Without this patch running anonymise with AnonymousPatron undefined (0 or > empry string) is allowed : borrowernumber is set to null > This is usefull because AnonymousPatron default value is 0. > > We agree on new behavior and create a unit test for this case. Sorry for the delay. Latest patch adapts the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:05:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:05:08 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:05:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:05:16 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118021|0 |1 is obsolete| | --- Comment #167 from Aleisha Amohia --- Created attachment 131299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131299&action=edit Bug 8367: Add holds_pickup_period circulation rule So that pickup delay can have a different value per patron category, item type or branch. To test: 1) Update database, restart services 2) Set ReservesMaxPickUpDelay syspref (if not already set) 3) Edit your circulation rules and set a value under 'Holds pickup period (day) that is DIFFERENT from ReservesMaxPickUpDelay. Set a few different numbers for different branches as well. 4) Place a hold on a biblio from the staff client. 5) Check in an item from that biblio and confirm the hold as waiting 6) Confirm the expiration date is calculated using the 'Holds pickup period' value instead of the ReservesMaxPickUpDelay syspref 7) Revert the waiting status and delete the hold 8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules. 9) Create a holiday with a date that will overlap with the 'Holds pickup period' 10) Check in an item from that biblio and confirm the hold as waiting 11) Confirm the expiration date is calculated using the 'Holds pickup period' value AND considers the special holiday 12) Confirm tests pass t/db_dependent/Holds/WaitingReserves.t 13) Test Talking Tech: 13a) Enable TalkingTechItivaPhoneNotification 13b) Go to Tools -> Notices & slips. Add content to the HOLD phone (itiva) notice. 13c) In your terminal, run perl /path/to/koha/misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl -o ~/itiva.tmp -w 0 --type=RESERVE Sponsored-by: Catalyst IT Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:05:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:05:25 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124568|0 |1 is obsolete| | --- Comment #168 from Aleisha Amohia --- Created attachment 131300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131300&action=edit Bug 8367: Make database update idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:05:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:05:34 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125087|0 |1 is obsolete| | --- Comment #169 from Aleisha Amohia --- Created attachment 131301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131301&action=edit Bug 8367: Make database update idempotent (across different MariaDB versions) The previous query seemed to work on MariaDB 10.1.48 (used by koha-testing-docker), but it didn't work on MariaDB 10.3.29 (default in Debian 10 as of this writing), but this patched query works on both indempotently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:05:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:05:44 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #170 from Aleisha Amohia --- Created attachment 131302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131302&action=edit Bug 8367: (follow-up) Fix pickup delay text on OPAC and other bits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:48:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:48:37 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:48:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 21:48:41 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131294|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 131303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131303&action=edit Bug 20161: add format, material type, etc to staff/OPAC details page For staff side: 1. Make sure DisplayIconsXSLT is on. 2. Look at the results page from the staff client. 3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material' 4. Look at the staff detail page and notice that only 'Material type' will show. 5. Apply patch and restart everything 6. Now look at the detail page and it should match what you see on the results page. 7. Turn off DisplayIconsXSLT 8. Make sure nothing on the results_material_type now displays. For OPAC: 1. Make sure DisplayOPACiconsXSLT is on. 2. Look at the results page from the OPAC. 3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material' 4. Look at the OPAC detail page and notice that only 'Material type' will show. 5. Apply patch and restart everything 6. Now look at the detail page and it should match what you see on the results page. 7. Turn off DisplayOPACiconsXSLT 8. Make sure nothing on the results_material_type now displays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 00:57:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2022 23:57:00 +0000 Subject: [Koha-bugs] [Bug 30215] New: "Item found" in accountlines untranslatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215 Bug ID: 30215 Summary: "Item found" in accountlines untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When a lost item is returned and refunded to the patron, the accountline description contains "Item found" which is untranslatable. To generate this accountline: 0- Make sure BlockReturnOfLostItems is set to Don't Block 0- Make sure WhenLostChargeReplacementFee is set to Charge 0- In Circulation rules, make sure Default lost item fee refund on return policy is set to one of the Refund options 0- Make sure your item has a replacement price (field v of the item) 1- Check out the item to a patron 2- Change the status of the item to lost The patron should be charged the replacement price 3- Check in the item The patron should have a new credit Lost item fee refund In the description of this new credit, it says "Item found ". I couldn't find "Item found" anywhere in the po files. In fact, when I git grep it, it only shows up in C4/Items. (Also, I'm wondering if the itemnumber is really useful here, I think it will confuse library staff as I myself was confused, but this is not the point of this bug) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 01:22:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 00:22:36 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #16 from Michael Hafen --- Created attachment 131304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131304&action=edit Have the fines cronjob check the issue before updateing the fine Here is another possible solution to this bug. Have the fines cron job check if the issue due date has changed before updating the fine. If the due date changed while the script was processing other issues, then we'll pass on it this time. That way duplicates can be avoided, and issues that become overdue again will get the second fine as they should (on the next run if it was renewed during this run). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 01:22:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 00:22:59 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 Michael Hafen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:52:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 02:52:37 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:52:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 02:52:42 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #1 from Lari Taskula --- Created attachment 131305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131305&action=edit Bug 30200: Add a new system preference ILLRequestsTabs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:52:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 02:52:48 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #2 from Lari Taskula --- Created attachment 131306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131306&action=edit Bug 30200: Add custom tabs to View ILL requests page Prereqs: 1: Make sure you have enabled an ILL backend and enabled system preferecnce ILLModule. For more information see https://koha-community.org/manual/21.11/en/html/ILL_requests.html To test: 1: Note, the following branchcodes, statuses and backends depend on your test environment and which ILL backend you are using. This example is for Libris backend. Set system preference ILLRequestsTabs: - name: tab1 status: - IN_REM - name: tab2 status: - IN_UTEL - IN_LEV - name: tab3 status: - IN_ANK 2. Add at least 4 ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_REM', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_UTEL', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_LEV', 'Libris'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'IN_ANK', 'Libris'); Note: Change values to whatever your test environment has set up. 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "tab1", "tab2" and "tab3" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs 1, 2 and 3 7. Go to cgi-bin/koha/members/ill-requests.pl?borrowernumber=1 8. Repeat steps 4-6 9. Clear system preference ILLRequestsTabs 10. Observe both ill/ill-requests.pl and members/ill-requests.pl now have only one tab "All" under which correct ILL requests are presented 11. Try some other status values in ILLRequestsTabs and observe expected behavior -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:53:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 02:53:00 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 --- Comment #3 from Lari Taskula --- Created attachment 131307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131307&action=edit Bug 30200: Update ill-list-table.js indentation To test: 1. git diff -w --word-diff-regex=[^[:space:]] HEAD~1 2. Observe no differences (above cmd ignores space changes) 3. Therefore patch only includes whitespace changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:53:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 02:53:38 +0000 Subject: [Koha-bugs] [Bug 30200] Add customizable tabs to interlibrary loan requests list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | CC| |magnus at libriotech.no -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:12 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:14 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130225|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:16 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:19 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130227|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:21 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:24 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130229|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 04:17:26 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 06:26:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 05:26:49 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #15 from Mason James --- Created attachment 131308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131308&action=edit test test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:32:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 06:32:11 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #19 from Fridolin Somers --- Patch "Bug 30007: (follow-up) Adapt tests" pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:45:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 06:45:11 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #20 from Fridolin Somers --- (In reply to Fridolin Somers from comment #16) > Ohhh but this changes the actual behavior. > Without this patch running anonymise with AnonymousPatron undefined (0 or > empry string) is allowed : borrowernumber is set to null > This is usefull because AnonymousPatron default value is 0. > But do we all agree with this new behavior. How manage existing databases upgrade having AnonymousPatron not configured but still use batch_anonyise.pl (we have that a lot at Biblibre) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:24:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 08:24:29 +0000 Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items that have holds but have not yet been captured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548 --- Comment #5 from Koha Team University Lyon 3 --- Hi, I don't know what was the case, but I can't reproduce it. You can forget my comment. I don't know if we should keep this BZ it seems that Donna's need is possible to achieve? (If I have understood correctly..) @Donna, what do you think ? Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:05:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 09:05:16 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #8 from Jonathan Druart --- The problem is the timezone, not the calculation. I don't think we need a lib for that. (In reply to Martin Renvoize from comment #4) > Might be an unpopular view.. but don't we already pull in moment.js for > other date manipulations.. so couldn't we use > https://momentjs.com/docs/#/displaying/difference/ to get a rather accurate > result? I didn't manage to make it work, I get "tz is not a function". I've tried with moment-timezone as well, and both with the latest version. Also worth noting: "Moment.js is a legacy project, now in maintenance mode. In most cases, you should choose a different library.", from https://github.com/moment/moment (In reply to Tomás Cohen Arazi from comment #7) > In that case, I'd just allow embedding the age like in: > > GET /patrons > x-koha-emebed: age > > (it would require renaming the ->get_age method) I had that concern some months ago (we will have twice the same business logic), but we agreed on providing a "JS equivalent" (bug 28874). Here it's over-complicating things anyway, we just want to subtract two dates. We can also rely on the client to make extra processing, which is good for server perfs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:22:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 09:22:19 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:22:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 09:22:24 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #9 from Jonathan Druart --- Created attachment 131309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131309&action=edit Bug 30059: Deal with timezones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:23:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 09:23:53 +0000 Subject: [Koha-bugs] [Bug 30059] Add a JS equivalent to Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30059 --- Comment #10 from Jonathan Druart --- This patches fixes the problem. Test plan: open the console and define a timezone: let tz = "UTC" or "America/Buenos_Aires" then call the function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:22:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:22:29 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109952|0 |1 is obsolete| | --- Comment #15 from Julian Maurice --- Created attachment 131310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131310&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:22:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:22:33 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109953|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 131311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131311&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:22:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:22:38 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109954|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 131312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131312&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:22:42 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #18 from Julian Maurice --- Created attachment 131313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131313&action=edit Bug 25375: Add tests for the "available" ES field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:25:19 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Julian Maurice --- Patches rebased, and tests added. Back to Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:33:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:33:45 +0000 Subject: [Koha-bugs] [Bug 30203] Can we trust the clean slate in Circulation.t ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy --- Hmm. I should have known. One of the last subtests calls SendCirculationAlert.. And that sub includes one of the worst Koha hacks: # LOCK TABLES is not transaction-safe and implicitly commits any active transaction before attempting to lock the tables. # If the LOCK/UNLOCK statements are executed from tests, the current transaction will be committed. # To avoid that we need to guess if this code is execute from tests or not (yes it is a bit hacky) my $do_not_lock = ( exists $ENV{_} && $ENV{_} =~ m|prove| ) || $ENV{KOHA_TESTING}; I will send a patch instead of closing this report btw. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:34:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:34:23 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can we trust the clean |Prevent data loss when |slate in Circulation.t ? |running Circulation.t | |without prove -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:34:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:34:32 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:35:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:35:26 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:35:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:35:29 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 --- Comment #2 from Marcel de Rooy --- Created attachment 131314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131314&action=edit Bug 30203: Circulation.t: prevent locking by setting envvar Running this test without prove is disastrous. The LOCK in the called SendCirculationAlert will ruin your data. But no longer when you apply this patch. Test plan: Run prove Circulation.t Inspect your data (e.g. borrowers table). Run perl Circulation.t Inspect your data (e.g. borrowers table) again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:37:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:37:16 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy --- This is a trivial edit but really handy to keep you focus on development instead of reinstalling or restoring db. Very trivial: Self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:39:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:39:33 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131314|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 131315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131315&action=edit Bug 30203: Circulation.t: prevent locking by setting envvar Running this test without prove is disastrous. The LOCK in the called SendCirculationAlert will ruin your data. But no longer when you apply this patch. Test plan: Run prove Circulation.t Inspect your data (e.g. borrowers table). Run perl Circulation.t Inspect your data (e.g. borrowers table) again. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:40:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:40:32 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Fix is clear and test plan works as expected. PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:46:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 10:46:07 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Martin Renvoize --- I really must get better at writing test plans with the sandboxes in mind, my apologies Barbara. External email is indeed disabled on the sandboxes to prevent them being hijacked by people wanting to use them to mass spam email. But, you can still test email functionality. Email sending isn't immediate, so it may take a few minutes to appear. To check the results, you'll need to look at the 'Koha Mail Log' under the 'Logs' select list in the sandbox management page. This will list all mail sent by the server, as it is sent (so it looks a bit funky with all the headers). Hope that helps, Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:12:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 11:12:08 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #20) > (In reply to Fridolin Somers from comment #16) > > Ohhh but this changes the actual behavior. > > Without this patch running anonymise with AnonymousPatron undefined (0 or > > empry string) is allowed : borrowernumber is set to null > > This is usefull because AnonymousPatron default value is 0. > > > But do we all agree with this new behavior. > > How manage existing databases upgrade having AnonymousPatron not configured > but still use batch_anonyise.pl (we have that a lot at Biblibre) ? For the record, check-in dies if AnonymousPatron is not set, since bug 9942. I see two options: - Add an anonymous patron on a DBrev. - Disable OPACPrivacy if AnonymousPatron is incorrectly set. This is already highlighted in about.pl as far as I can tell (see bug 24327). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:41:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 11:41:57 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:06:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:06:26 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #1 from Martin Renvoize --- Created attachment 131316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131316&action=edit Bug 25936: Add option to send password change notices This patch add a new security notice to allow sending notification of password changes to patrons. If enabled, the 'PASSCHANGE' notice will be sent to respective patrons whenever their password is updated. Test plan 1) Run the database updates 2) Enable the new feature by setting 'NotifyPasswordChange' to 'Notify' 3) Change a users password 4) Check that the notice appears in the patrons notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:08:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:08:12 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131316|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 131317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131317&action=edit Bug 25936: Add option to send password change notices This patch add a new security notice to allow sending notification of password changes to patrons. If enabled, the 'PASSCHANGE' notice will be sent to respective patrons whenever their password is updated. Test plan 1) Run the database updates 2) Enable the new feature by setting 'NotifyPasswordChange' to 'Notify' 3) Change a users password 4) Check that the notice appears in the patrons notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:08:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:08:29 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:09:05 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:11:49 +0000 Subject: [Koha-bugs] [Bug 30216] New: Additional identification filed for patron for sip2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216 Bug ID: 30216 Summary: Additional identification filed for patron for sip2 Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: mohsin.riaz1 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I need to add secondary identification field for patron to add RFID UID number in it and also use this as patron identifier as card number using sip2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:13:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:13:01 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131317|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 131318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131318&action=edit Bug 25936: Add option to send password change notices This patch add a new security notice to allow sending notification of password changes to patrons. If enabled, the 'PASSCHANGE' notice will be sent to respective patrons whenever their password is updated. Test plan 1) Run the database updates 2) Enable the new feature by setting 'NotifyPasswordChange' to 'Notify' 3) Change a users password 4) Check that the notice appears in the patrons notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:14:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:14:16 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon.turner at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:15:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:15:46 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:15:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:15:57 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:16:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:16:12 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:29:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:29:21 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:29:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:29:28 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:45:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:45:05 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:45:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:45:09 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131318|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 131319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131319&action=edit Bug 25936: Add option to send password change notices This patch add a new security notice to allow sending notification of password changes to patrons. If enabled, the 'PASSCHANGE' notice will be sent to respective patrons whenever their password is updated. Test plan 1) Run the database updates 2) Enable the new feature by setting 'NotifyPasswordChange' to 'Notify' 3) Change a users password 4) Check that the notice appears in the patrons notices Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:45:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:45:21 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:49:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 12:49:09 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #5 from Marcel de Rooy --- Great addition. Security++ Only thing I could say about the code: if ( !C4::Auth::checkpw_hash( $password, $self_from_storage->password ) ) { I understand this change but it should not really be bound to notify yes or no. Could imagine that set_password should check that always and report it? Currently the interface lets you change your password while not entering a new one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:46:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 13:46:13 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #16 from Mason James --- Created attachment 131320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131320&action=edit control.patch for 19.11.x control.patch for 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:04:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:04:45 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 --- Comment #4 from Owen Leonard --- When I try this, a user with only "place_holds" permission can add, suspend, or delete a hold. The user cannot change the hold date, the expiration date, or the pickup location. Is this to be expected? I would have expected that a user with "place_holds" but NOT "modify_holds_priority" would be able to make any change EXCEPT change priority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:05:52 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #17 from Mason James --- Created attachment 131321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131321&action=edit control.patch for 19.11.x control.patch for 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:06:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:06:16 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 --- Comment #5 from Owen Leonard --- Never mind, I wasn't on the branch I thought I was! Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:20:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:20:37 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:20:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:20:40 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:20:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:20:44 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:20:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:20:46 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:23:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:23:01 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 131322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131322&action=edit Bug 30181: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:23:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:23:07 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 131323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131323&action=edit Bug 30181: Make Koha::BackgroundJob->_derived_class return the right thing This patch makes _derived_class rely on _new_from_dbic to generate a new object with the right class, but based on the same DB row. Not an empty one as it was before. This way we can remove some biolerplate that is required now when writing background job classes. To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJob.t => FAIL: Boo, tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:23:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:23:13 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 131324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131324&action=edit Bug 30181: (follow-up) Remove redundant queries and parameters Now $self is actually an instance of the job class, there's no need to have the job_id parameter passed, or the have the ->process method re-fetch the object from the database. This patch cleans things up. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:23:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:23:18 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 131325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131325&action=edit Bug 30181: (QA follow-up) Update BatchTest This patch updates t::lib::Koha::BackgroundJob::BatchTest to the new style, and also removes a couple stray cases in which job_id was still passed as a parameter. Tests are rewritten a bit, so they actually test more of the behaviors. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/BackgroundJobs.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:24:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:24:27 +0000 Subject: [Koha-bugs] [Bug 30181] Koha::BackgroundJob->_derived_class returns an empty object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30181 --- Comment #10 from Tomás Cohen Arazi --- Thanks for the valuable feedback, Jonathan. I have submitted a revised patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:34:38 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:34:38 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:37:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:37:58 +0000 Subject: [Koha-bugs] [Bug 30217] New: When an item waiting on hold for one patron is checked out to another the hold is reverted but not logged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30217 Bug ID: 30217 Summary: When an item waiting on hold for one patron is checked out to another the hold is reverted but not logged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1 - Enable Holds log 2 - Place a hold for a patron 3 - Check in the item and confirm hold to mark waiting 4 - Check the logs - you see the create and modify actions 5 - Checkout the item to a different patron 6 - The hold is no longer marked waiting 7 - Check the logs - no modification for the reversion of waiting status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:38:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:38:34 +0000 Subject: [Koha-bugs] [Bug 30218] New: Add subfield g to 150 heading_fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30218 Bug ID: 30218 Summary: Add subfield g to 150 heading_fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: domm at plix.at QA Contact: testopia at bugs.koha-community.org When creating authorities via SRU or linking exising authorities (via cgi-bin/koha/authorities/auth_finder.pl) the search results are generated using the hardcoded mappings $bib_heading_fields / $auth_heading_field from C4::Heading::MARC21. For TOPIC_TERM / field 150 these mappings currently include the subfield `abvxyz68`. But: We are using the GND provided by Deutsche Nationalbibliothek. We imported some authorities from there, for example: http://d-nb.info/gnd/4114171-4 "Kind <0-3 Jahre>" (kid 0-3 years) http://d-nb.info/gnd/4196417-2 "Kind <0-4 Jahre>" (kid 0-4 years) When searching for these terms, Koha only displays "Kind", which is not very helpful, as there are a lot of different authorities for different age bands. GND stores "Kind" in 150a, and "0-3 Jahre" in 150g. But in the hardcoded mappings used by Koha, subfield g is not included. This patch adds subfield g to these mappings, thus making it possible to easily select the correct authority. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:39:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:39:14 +0000 Subject: [Koha-bugs] [Bug 30217] When an item waiting on hold has the waiting status reverted the action is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30217 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When an item waiting on |When an item waiting on |hold for one patron is |hold has the waiting status |checked out to another the |reverted the action is not |hold is reverted but not |logged |logged | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:39:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:39:47 +0000 Subject: [Koha-bugs] [Bug 30217] When an item waiting on hold has the waiting status reverted the action is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30217 --- Comment #1 from Nick Clemens --- Additionally: 1 - Place a hld, check in, confirm waiting 2 - From the holds page, revert the waiting status 3 - No log for the reversion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:42:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:42:02 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #43 from Martin Renvoize --- Created attachment 131326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131326&action=edit Bug 29523: Cache the restricted branches list This patch introduces a very localised cache of the restricted branches list in the logged in patron object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:43:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:43:17 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:43:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 14:43:21 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 --- Comment #1 from Owen Leonard --- Created attachment 131327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131327&action=edit Bug 30213: Hide Delete (aka Priority) column when user only has place_hold permission This patch changes the way the priority column displays when viewing a list of holds as a user who doesn't have permission to change hold priority. To test: - Apply the patch and log into the staff interface as a user with at least "place_hold" permission. - Locate a record which can be put on hold and place multiple holds. - View the list of holds. - As a user with both "place_hold" and "modify_holds_priority" permission, you should see a "Priority" column with fields allowing you to change hold priority. You should also see the arrow buttons for changing priority. - As a user with only "place_hold" permission, the "Priority" column should show the priority as a number. You should not see the arrow buttons. - In both cases, confirm that all operations work correctly: Changing hold date, expiration date, pickup library, suspended status; Cancelling holds. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:02:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:02:19 +0000 Subject: [Koha-bugs] [Bug 30213] Hide Delete (aka Priority) column when user only has place_hold permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30213 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Status|Needs Signoff |Signed Off --- Comment #3 from Christopher Brannon --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:02:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:02:39 +0000 Subject: [Koha-bugs] [Bug 30217] When an item waiting on hold has the waiting status reverted the action is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30217 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:03:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:03:57 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:07:06 +0000 Subject: [Koha-bugs] [Bug 30219] New: Batch Patron Modification - Add Patron Notification Preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30219 Bug ID: 30219 Summary: Batch Patron Modification - Add Patron Notification Preferences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: rcoert at arlingtonva.us QA Contact: testopia at bugs.koha-community.org Requesting the addition to update "Patron messaging preferences" when Batch Updating Patron records. Use case - an entire category of patrons is being moved to "Books By Mail" service, which receive no notifications. However, their current patron category receives ALL the notices. The options to adjust the Notifications are either for staff to do it (very time consuming) or a request for the Data Team to correct it (if supported by a vendor). It would save time for everyone if the sysadmins could just update it in Batch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:11:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:11:43 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:11:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:11:52 +0000 Subject: [Koha-bugs] [Bug 30220] New: Purchase suggestion defaults to first library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Bug ID: 30220 Summary: Purchase suggestion defaults to first library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Patrons will not bother to change to their library. Can we make this default to the logged in patron's home library? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:14:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:14:30 +0000 Subject: [Koha-bugs] [Bug 30221] New: Make the tables on opac-user.tt column configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221 Bug ID: 30221 Summary: Make the tables on opac-user.tt column configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There are several tables on opac-user.tt that would benefit from being column configurable. ( check-outs, overdues, charges, holds, article requests ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:23:21 +0000 Subject: [Koha-bugs] [Bug 30222] New: Auto_renew_digest still sends every day when renewals are not allowed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Bug ID: 30222 Summary: Auto_renew_digest still sends every day when renewals are not allowed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 29381 The non-digest auto-renew notice checks to see whether or not the auto-renew error on the issue has changed since the previous day. If the error is not new, the notice doesn't generate. In the auto-renew-digest, we don't do that check. For any error other than auto_too_soon, the patron will be notified every day. Bug 29381 tried to address this, but did not correct the whole issue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 [Bug 29381] Auto-renewal digest messages are sent on every cron run -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:23:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:23:21 +0000 Subject: [Koha-bugs] [Bug 29381] Auto-renewal digest messages are sent on every cron run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:23:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:23:54 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 --- Comment #6 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #5) > Great addition. Security++ > > Only thing I could say about the code: > > if ( !C4::Auth::checkpw_hash( $password, $self_from_storage->password ) ) { > > I understand this change but it should not really be bound to notify yes or > no. Could imagine that set_password should check that always and report it? > Currently the interface lets you change your password while not entering a > new one. I went through the same thought process when I wrote that line. I chose to put it inside the check for two reasons. One, to not require the extra DB hit unless necessary and Two, I was sure what to do with an exception if we did throw one. I decided in the end that it should be handled in the UI if we want to perform such a check, but should that be in opac and staff, or just opac, and what about imports ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:24:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:24:01 +0000 Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com, | |hebah at bywatersolutions.com, | |nick at bywatersolutions.com, | |sbrown at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:27:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:27:04 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:27:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:27:08 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131283|0 |1 is obsolete| | Attachment #131284|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 131337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131337&action=edit Bug 30214: Add ACCTDETAILS notice to self registeration This patch adds the ACCTDETAILS notice trigger to the opac self registration process. Allowing new users, without varification enabled, to receive the ACCTDETAILS notice immediately after their account is created. Test plan 1) Enable AutoEmailOpacUser system preference 2) Ensure the ACCTDETAILS notice is configured 3) Ensure `PatronSelfRegistrationVerifyByEmail` is disabled 4) Register a new user via the opac self registration process using an email address you have access to 5) The new user should have been created and you should be able to see the account details notice in their associated notices 6) Confirm that the email address used above has received the notice. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:27:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:27:12 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #8 from Owen Leonard --- Created attachment 131338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131338&action=edit Bug 30214: Add ACCTDETAILS notice to verified self registration This patch adds the ACCTDETAILS notice trigger to the opac self registration process. Allowing new users, with varification enabled, to receive the ACCTDETAILS notice immediately after their account is varified. Test plan 1) Enable AutoEmailOpacUser system preference 2) Ensure the ACCTDETAILS notice is configured 3) Ensure `PatronSelfRegistrationVerifyByEmail` is enabled 4) Register a new user via the opac self registration process using an email address you have access to 5) Verify the user by following the link in the verification email you should have received. 6) The new user should have been created and you should be able to see the account details notice in their associated notices 7) Confirm that the email address used above has received the notice. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:35:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:35:32 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131238|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 131339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131339&action=edit Bug 30212: Make Select2 available for ILL backends This patch makes select2 available for ILL backend developers to use on their templates. To test: 1. Have a configured backed and an ILL request 2. Open the inspector and load any action on the backend (intranet) => FAIL: no select2 asset is transfered from Koha to the browser 3. Apply this patch 4. Reload => SUCCESS: There's select2 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:35:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:35:48 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Super trivial, works, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:35:53 +0000 Subject: [Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:41:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 16:41:44 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:02:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:02:37 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:02:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:02:41 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #1 from Owen Leonard --- Created attachment 131340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131340&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:10:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:10:05 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:10:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:10:08 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131340|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 131341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131341&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:12:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:12:09 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- I would consider this a separate issue, and will file a separate bug, but if you add branchcode to the sys pref OPACSuggestionMandatoryFields the dropdown should default to an empty value in order to force the user into making a choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:15:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:15:22 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:27:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:27:22 +0000 Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:30:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:30:27 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:30:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:30:30 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131067|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 131342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131342&action=edit Bug 30177: When editing an existing patron set message_prefs_dirty to true 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3 - Confirm that the messaging prefs have been reset to that of the default patron category 4 - Apply patch 5 - Repeat Step 2, this time you should see a warning asking if you want to set messaging prefs to the category default 6 - Press OK and save. Confirm that the messaging prefs are now set to the default for that category 7 - Try it again with an existing account and press Cancel this time. Notice that there should be no change to the patron messaging prefs. 8 - Try making a new patron and switching the category, you should see no warning and the message prefs should be proberly set to the defaults of any category you choose. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:32:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:32:17 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- Marking Failed QA based on Lucas's comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:45:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:45:43 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #4 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > Generate new serial items and confirm that the seasons are correctly > translated when displayed Where will this information appear? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:52:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:52:11 +0000 Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205 --- Comment #3 from Lucas Gass --- (In reply to Owen Leonard from comment #2) > Did you look at including biblio-title.inc? Maybe it's overkill here? I did not, but now I will! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:53:06 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:53:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 17:53:09 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130767|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 131343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131343&action=edit Bug 29922: Group of libraries are now displayed in alphabetical order This patch modifies the OPAC's "Group of libraries" field in Advanced search tab. When the select button under the text "Groups of libraries" is clicked, the library groups are now displayed in alphabetical orders. To test, start by creating multiple libraries (At least 5). Then, create library groups (At least 5) in non-alphabetical order. (Make sure "Use for OPAC search groups" is checked when creating a library group). - Example: CGroup,DGroup,AGroup,EGroup,BGroup (These are the Titles) >From there, follow these steps: 1 - Go in OPAC, then Advanced search. 2 - Under "Groups of librairies" , click the select button. 3 - Notice that the library groups are not in alphabetical order. 4 - Apply the patch. 5 - Notice that the library groups are in alphabetical order. Signed-off-by: Lucas Gass Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:03:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 18:03:45 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:03:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 18:03:48 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129353|0 |1 is obsolete| | Attachment #131063|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 131344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131344&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:03:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 18:03:52 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #9 from Owen Leonard --- Created attachment 131345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131345&action=edit Bug 20362: (follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:07:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 18:07:02 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:47:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 18:47:28 +0000 Subject: [Koha-bugs] [Bug 30223] New: Move book cover image upload JS to a separate file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Bug ID: 30223 Summary: Move book cover image upload JS to a separate file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org With the cover image JavaScript in a separate file it can be reused on other pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:02:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:02:29 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:02:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:02:33 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 --- Comment #1 from Owen Leonard --- Created attachment 131346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131346&action=edit Bug 30223: Move book cover image upload JS to a separate file This patch moves most of the JavaScript from upload-images.tt into a separate file, upload-images.js. Functionality should be unchanged. To test, apply the patch and go to Tools -> Upload local cover image. Test all the things: - Drag-and-drop upload - Click-to-browse upload; - Deleting existing images - Uploading a zip file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:21:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:21:18 +0000 Subject: [Koha-bugs] [Bug 30193] Invalid refs removed in JSON::Validator 5.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30193 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 131347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131347&action=edit Bug 30193: Remove use of allow_invalid_ref This patch removes the code that makes Koha allow an invalid spec It is expected to break the API. As an excercise, try saving the raw output from http://localhost:8080/api/v1 into swagger.json along the swagger.yaml file, and tweak V1.pm to point to the json version. Notice the API works! The idea, is we adapt our API so it conforms to the standard as much as possible, while keeping some modularity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:24:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:24:00 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:26:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:26:13 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:26:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:26:16 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 --- Comment #1 from Kyle M Hall --- Created attachment 131348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131348&action=edit Bug 30199: self checkout login by cardnumber is broken if you input a non-existent cardnumber Test Plan: 1. Set SelfCheckoutByLogin to 'cardnumber'. 2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3. Enter an invalid carnumber like 'thisisabadcardnumber' 4. See the appropriate message "Sorry The userid thisisabadcardnumber was not found in the database. Please try again." 5. Try again with a different cardnumber and notice the same exact error message including the 'thisisabadcardnumber' cardnumber. 6. Apply this patch 7. Restart all the things! 8. Repeat steps 2-4 9. Try again with a different cardnumber, you should now see the correct cardnumber! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:19 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130938|0 |1 is obsolete| | Attachment #130939|0 |1 is obsolete| | Attachment #130940|0 |1 is obsolete| | Attachment #130941|0 |1 is obsolete| | Attachment #130942|0 |1 is obsolete| | Attachment #130943|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 131349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131349&action=edit Bug 28782: Use query param list instead of splitting elements using '/' This removes the need to handle single and multiple cases separately, thus removing bunch if-else cases and simplifying our code. This coding style is also in line with our other .pl scripts. To test: 1) Make sure placing a hold still works from the following pages: /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/catalogue/search.pl?q=a /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron there and through the clubs.pl create a hold to a bib) Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:24 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #46 from Jonathan Druart --- Created attachment 131350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131350&action=edit Bug 28782: (follow-up) Pass real array to query_form() It excepts to receive a real array and not a list, in order to be able to generate the query parameters. Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:29 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #47 from Jonathan Druart --- Created attachment 131351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131351&action=edit Bug 28782: Fix link when placing a hold for a patron from patron list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:34 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #48 from Jonathan Druart --- Created attachment 131352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131352&action=edit Bug 28782: Fix cancel holds in bulk See also bug 29969. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:39 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #49 from Jonathan Druart --- Created attachment 131353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131353&action=edit Bug 28782: (QA follow-up) Bug 29844 follow-up Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:44 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #50 from Jonathan Druart --- Created attachment 131354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131354&action=edit Bug 28782: (QA follow-up) Fix missing filter Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:31:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:31:58 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #51 from Jonathan Druart --- (In reply to Fridolin Somers from comment #44) > There are some problems with filters. > > I create holds for 2 records and cancel them immediately. > Without last patch "Bug 28782: (QA follow-up) Fix missing filter" I see URL : > /cgi-bin/koha/reserve/request.pl?biblionumber=359&biblionumber=369& > action=cancelBulk&ids=2,1 > With last patch I see URL : > /cgi-bin/koha/reserve/request.pl?biblionumber%3D359%26biblionumber%3D369& > action=cancelBulk&ids=2,1 > > Without all patches we have URL : > /cgi-bin/koha/reserve/request.pl?biblionumbers=359/369& > action=cancelBulk&ids=2,1 > Looks it '&' works, but it should be '&'. Good catch, fixed! I amended the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:33:12 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:33:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:33:17 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130874|0 |1 is obsolete| | Attachment #130875|0 |1 is obsolete| | Attachment #130876|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 131355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131355&action=edit Bug 29136: Ajaxify the patron search when placing a hold Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:33:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:33:22 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #13 from Jonathan Druart --- Created attachment 131356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131356&action=edit Bug 29136: Don't redirect if the whole set is > 1 To prevent a redirect when we click on a page with only 1 result Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:33:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:33:26 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 --- Comment #14 from Jonathan Druart --- Created attachment 131357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131357&action=edit Bug 29136: (QA follow-up) missing filters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:34:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:34:55 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:34:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:34:58 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131131|0 |1 is obsolete| | Attachment #131132|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 131358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131358&action=edit Bug 22993: Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:35:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:35:09 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 --- Comment #4 from Kyle M Hall --- Created attachment 131359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131359&action=edit Bug 22993: Handle default messaging preferences during patron creation from API TO test: 1 - Set default messaging preferences for a patron category 2 - Create a patron in that category using the API 3 - Verify messaging preferences are not set 4 - Apply patch, restart all 5 - Create another patron 6 - Verify messaging preferences are correctly set 7 - prove -v t/db_dependent/api/v1/patrons.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:35:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:35:37 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:40:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:40:07 +0000 Subject: [Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:40:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:40:11 +0000 Subject: [Koha-bugs] [Bug 30061] Simplify Koha::Patron->get_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30061 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130362|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 131360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131360&action=edit Bug 30061: Make Koha::Patron->get_age use DateTime math This patch does what the title says. Instead of converting dates to strings and performing math manually, we can just use the DateTime objects we have and calculate the DateTime::Duration there's between them, to get the years count. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Patrons.t => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:42:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:42:32 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:42:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:42:35 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:42:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:42:38 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:43:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:43:01 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 131361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131361&action=edit Bug 22993: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:43:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:43:06 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 131362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131362&action=edit Bug 22993: Handle default messaging preferences during patron creation from API TO test: 1 - Set default messaging preferences for a patron category 2 - Create a patron in that category using the API 3 - Verify messaging preferences are not set 4 - Apply patch, restart all 5 - Create another patron 6 - Verify messaging preferences are correctly set 7 - prove -v t/db_dependent/api/v1/patrons.t Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:45:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 19:45:14 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 --- Comment #7 from Tomás Cohen Arazi --- Well done. Only members/memberentry.pl uses handle_form_action, the rest of the tools that add patrons do what Nick added to the API controller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:13:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:13:06 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #10 from The Minh Luong --- Created attachment 131363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131363&action=edit Bug 15594: Class in now unchanged after the patch I'm not sure if this is the actual issue, but I found that the patch puts the span with the class "publisher_name" inside a new span with typeOf="Organization". In this patch, I removed that new span, to keep it coherent with the previous code. Also, the MARC 260 subfields are displayed correctly ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:13:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:13:42 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |the-minh.luong at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:14:19 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > > Generate new serial items and confirm that the seasons are correctly > > translated when displayed > > Where will this information appear? You should see the season translated everywhere it's displayed (not when it appears in an input however). So on the catalogue/detail.pl tab "Subscriptions", or the subscription detail view (/serials/subscription-detail.pl?subscriptionid=1) You need to: gulp po:update --lang es-ES cd misc/translate Edit po/es-ES-messages.po, translate the season names ./translate install es-ES restart_all (strings are cached) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:15:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:15:29 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #886 from Aleisha Amohia --- Thanks Marcel, I appreciate you helping me get this over the line. If there are bits I can look at, let me know, I have a bit of capacity at the moment. Pass QA on Friday 11 sounds like a great plan to me. Any additional QA team help in between would be awesome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:17:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:17:15 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:17:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:17:19 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131348|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 131364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131364&action=edit Bug 30199: self checkout login by cardnumber is broken if you input a non-existent cardnumber Test Plan: 1. Set SelfCheckoutByLogin to 'cardnumber'. 2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3. Enter an invalid carnumber like 'thisisabadcardnumber' 4. See the appropriate message "Sorry The userid thisisabadcardnumber was not found in the database. Please try again." 5. Try again with a different cardnumber and notice the same exact error message including the 'thisisabadcardnumber' cardnumber. 6. Apply this patch 7. Restart all the things! 8. Repeat steps 2-4 9. Try again with a different cardnumber, you should now see the correct cardnumber! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:21:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:21:43 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:57:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 20:57:11 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |additional_work_needed --- Comment #5 from Fridolin Somers --- Unit test in t/db_dependent/Serials.t fails in Jenkins for D9 D10 U18 U20. 01:00:42.317 koha_1 | # Failed test at t/db_dependent/Serials.t line 469. 01:00:42.317 koha_1 | # got: 'ene.' 01:00:42.317 koha_1 | # expected: 'ene' 01:00:42.317 koha_1 | # Looks like you failed 1 test of 6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:43:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 21:43:30 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:43:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 21:43:33 +0000 Subject: [Koha-bugs] [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:43:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2022 21:43:34 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #4 from Aleisha Amohia --- Created attachment 131365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131365&action=edit Bug 30159: (follow-up) Make warning messages consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:43:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:43:18 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #21 from Fridolin Somers --- Ah, rebase conflict due to Bug 29857 I create a followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:43:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:43:37 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #22 from Fridolin Somers --- Created attachment 131366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131366&action=edit Bug 30072: (follow-up) Fix UT after Bug 29857 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:50:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:50:14 +0000 Subject: [Koha-bugs] [Bug 30224] New: Wrong important field shown in cataloguing validation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Bug ID: 30224 Summary: Wrong important field shown in cataloguing validation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To reproduce: 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. Note: we're aware of the weird HTML display, this is fixed by Bug 30159. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:54:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:54:38 +0000 Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:54:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:54:42 +0000 Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 --- Comment #1 from Aleisha Amohia --- Created attachment 131367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131367&action=edit Bug 30224: Show correct important field in cataloguing validation This patch fxes the cataloguing validation messages to show the correct tag, when the whole field is important (not just a subfield). Note: Look at Bug 30159 to fix the formatting of the validation popup. 1. Go to Administration -> MARC bibliographic frameworks 2. Click Actions next to a framework, view MARC structure 3. Edit multiple tags (at least 2) and check the Important checkbox. 4. Go to cataloguing and create a new record using the framework you just edited 5. Don't fill any of the important fields. Click Save to force the validation for the important tags 6. Notice that the error message shows that an important field isn't filled, but the tag number shown is repeated for each message. The 'Go to field' link goes to the right tag, but the tag number shown is incorrect. 7. Apply patch and refresh page 8. Click Save to force validation again. 9. Confirm the correct tag number is now showing for each error message. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 01:55:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 00:55:54 +0000 Subject: [Koha-bugs] [Bug 30224] Wrong important field shown in cataloguing validation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |adam.styles at esa.edu.au |ity.org | Change sponsored?|--- |Sponsored Text to go in the| |This patch fxes the release notes| |cataloguing validation | |messages to show the | |correct tag, when the whole | |field is important (not | |just a subfield). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:05:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 01:05:57 +0000 Subject: [Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Marion great work, you are Theodoros goddess ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 01:44:12 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30063 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 01:44:12 +0000 Subject: [Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30098 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:50:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 01:50:31 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 --- Comment #6 from Fridolin Somers --- Mmmm tiny patch and it works, I push and send my best wishes to Bug 30063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:54:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 01:54:59 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Dependency with Bug 17239 ? isn't it the opposite relation ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:05:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:05:40 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:46 +0000 Subject: [Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:49 +0000 Subject: [Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:51 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:54 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 --- Comment #52 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:57 +0000 Subject: [Koha-bugs] [Bug 29220] Minor fixes and improved code readability in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29220 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:11:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:11:59 +0000 Subject: [Koha-bugs] [Bug 29220] Minor fixes and improved code readability in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29220 --- Comment #8 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:02 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:04 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:07 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:10 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 --- Comment #19 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:12 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:15 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 --- Comment #16 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:17 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:20 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #23 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:22 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:26 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:29 +0000 Subject: [Koha-bugs] [Bug 30125] Add full-stack tests for API pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30125 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:31 +0000 Subject: [Koha-bugs] [Bug 30125] Add full-stack tests for API pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30125 --- Comment #9 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:34 +0000 Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:36 +0000 Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:39 +0000 Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:41 +0000 Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 --- Comment #16 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:44 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:12:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:12:46 +0000 Subject: [Koha-bugs] [Bug 30203] Prevent data loss when running Circulation.t without prove In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:18:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 02:18:33 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #10) > Dependency with Bug 17239 ? isn't it the opposite relation ? I think it is wrong. Probably a duplicate instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:39:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:39:29 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131321|control.patch for 19.11.x |desc11 description| | --- Comment #18 from Mason James --- Comment on attachment 131321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131321 desc11 comment11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:42:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:42:11 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #19 from Mason James --- Created attachment 131368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131368&action=edit Update debian/control: 21.12.00-16 on deb9/stretch [ba972111] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:44:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:44:12 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:44:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:44:46 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:53:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:53:06 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:53:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:53:08 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:53:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:53:11 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:53:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:53:13 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131368|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 05:53:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 04:53:15 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 --- Comment #20 from Mason James --- Created attachment 131369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131369&action=edit Update debian/control: 21.12.00-16 on deb9/stretch [ba972111] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:10:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:10:07 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130202|1 |0 is obsolete| | Attachment #130203|1 |0 is obsolete| | Attachment #130205|1 |0 is obsolete| | Attachment #130207|1 |0 is obsolete| | Attachment #130217|1 |0 is obsolete| | Attachment #130218|1 |0 is obsolete| | Attachment #130219|1 |0 is obsolete| | Attachment #130225|1 |0 is obsolete| | Attachment #130226|1 |0 is obsolete| | Attachment #130227|1 |0 is obsolete| | Attachment #130228|1 |0 is obsolete| | Attachment #130229|1 |0 is obsolete| | Attachment #130230|1 |0 is obsolete| | Attachment #131308|1 |0 is obsolete| | Attachment #131320|1 |0 is obsolete| | Attachment #131321|1 |0 is obsolete| | Attachment #131368|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:25:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:25:02 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:26:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:26:07 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:40:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:40:38 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130202|1 |0 is obsolete| | Attachment #130202|1 |0 is private| | --- Comment #21 from Mason James --- Comment on attachment 130202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130202 buildbot 19.11.25-0 for stretch: update debian/changelog >From 288f5e384cbf65809e680358a5b4fbffbb2e4f95 Mon Sep 17 00:00:00 2001 >From: Mason James >Date: Wed, 2 Feb 2022 12:16:40 +1300 >Subject: [PATCH] buildbot 19.11.25-0 for stretch: update debian/changelog >Content-Type: text/plain; charset="utf-8" > >https://bugs.koha-community.org/show_bug.cgi?id=30034 >--- > debian/changelog | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/debian/changelog b/debian/changelog >index ebb3f44099..ebc84f6d36 100644 >--- a/debian/changelog >+++ b/debian/changelog >@@ -1,3 +1,9 @@ >+koha (19.11.25-0~git+20220202120644.59e20a86-1) 19.11; urgency=medium >+ >+ * New upstream release (19.11.25-0) >+ >+ -- Mason James Wed, 02 Feb 2022 12:16:38 +1300 >+ > koha (16.05.02) squeeze; urgency=medium > > * New upstream release (16.05.02) >-- >2.20.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:40:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:40:53 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130203|1 |0 is obsolete| | Attachment #130203|1 |0 is private| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:50:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:50:32 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131369|1 |0 is private| | Attachment #131369|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 06:54:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 05:54:12 +0000 Subject: [Koha-bugs] [Bug 30034] Automatic debian/control updates (testing) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30034 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 07:02:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 06:02:22 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 --- Comment #12 from Fridolin Somers --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to Fridolin Somers from comment #10) > > Dependency with Bug 17239 ? isn't it the opposite relation ? > > I think it is wrong. Probably a duplicate instead OK I move to See Also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 07:02:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 06:02:36 +0000 Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17239 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17239 [Bug 17239] Vulnerabilitiy warning for package C4::Biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 07:02:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 06:02:36 +0000 Subject: [Koha-bugs] [Bug 17239] Vulnerabilitiy warning for package C4::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17239 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29771 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29771 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771 [Bug 29771] Get rid of CGI::param in list context warnings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 08:48:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 07:48:55 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 --- Comment #6 from Jonathan Druart --- Created attachment 131370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131370&action=edit Bug 30035: Fix failing test Looks like there was a change in the output for Spanish. Can be 'ene.' in older versions Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 08:49:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 07:49:13 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored-by: Orex Digital release notes| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:52:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 09:52:59 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #887 from Marcel de Rooy --- Still posting two observations from a functional view without any need to address them here btw. Functionally, it is a bit confusing that the recall overdue fine amount is so close in the interface to the number of recalls allowed, due date interval, etc. Because it is actually a fine that will not be placed on the person doing the recall but on the patron that loaned the book (and might be in another patron category). So when you enable recalls for a category and you want to have a non-regular overdue fine, you should fill all recall fines on the other categories as well. Maybe something for documentation ? Another functional remark is that the recalls feature currently does not support policies like we have for holds (e.g. you cannot place recalls on items of another branch etc.). Certainly not meant as a blocker at this moment. But I feel that the need to refine circulation rules at that level will be felt soon by multiple branch libraries. You cannot really introduce recalls for one branch now, since the members of that branch can place recalls on books of the other branches. This may need further thought on follow-up reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:54:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 09:54:55 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #888 from Marcel de Rooy --- Final comment for now. Aleisha has done a really amazing job in keeping this development alive from 2017 onwards. It is a very brave effort on itself to insert this feature into Koha's circulation core; we know that the existing code with all its holds preferences and policies is a minefield. What I saw, looks good and connects with Koha coding practices within the last 5 years. An important step that still needs to be made, is REST API support on follow-up reports. As to functionality, a lot of things have been said and can be said. But this provides us a good base to build and improve further. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:20:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:20:54 +0000 Subject: [Koha-bugs] [Bug 30225] New: Rewrite cities admin view in Vue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 Bug ID: 30225 Summary: Rewrite cities admin view in Vue Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Same as bug 30160 but using Vue 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:20:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:20:55 +0000 Subject: [Koha-bugs] [Bug 30160] Rewrite cities admin view in React In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30160 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30225 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:48:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:48:35 +0000 Subject: [Koha-bugs] [Bug 30160] Rewrite cities admin view in React In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30160 --- Comment #23 from Jonathan Druart --- (In reply to Jonathan Druart from comment #3) > (In reply to Tomás Cohen Arazi from comment #2) > > Are you willing to try Vue as well? > > Nope. Or maybe yes. See bug 30225. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:48:51 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:48:51 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 --- Comment #1 from Jonathan Druart --- Created attachment 131371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131371&action=edit Bug 30225: Rewrite cities admin view in Vue Same as bug 30160 but using Vue 3 (https://vuejs.org/). TODO: * Use Vue Router and remove the switch-view weirdness * Clean package.json it contains too many things Notes: * Use of webpack instead of gulp (didn't manage to make it work, and webpack seems the "new standard"?) * Cannot fully use vue-boostrap-3 as it is using bootstrap 4 and conflict with our version (3.5). The add form for instance should display label and input inline with the code used in this patch, but it's not displayed correctly * Using bootstrap-vue-3 as bootstrap-vue is still for Vue 2 To improve/weirdness: * The fetch before the edit and delete is done too late, in created(). You can notice a "blink". But lifecycle hooks don't permit a await here https://vuejs.org/guide/essentials/lifecycle.html * I guess we should have the whole model stored in Vue to take full advantage of its functionalities * We need to inject the "Edit" and "Delete" buttons, it was a nightmare and it's not done properly. I didn't manage to render a component that is using the font-awesome-icon and bootstrap styles. Hot reload using `yarn watch_js` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:51:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:51:03 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:51:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:51:07 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #6 from Marcel de Rooy --- Created attachment 131372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131372&action=edit Bug 30108: (follow-up) Add required indication, differentiate alert As asked on comment4: [1] Add a required div as a visible hint when applicable. [2] Differentiate alert for hold start and end date. Test plan: See former patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:51:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:51:49 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 --- Comment #7 from Marcel de Rooy --- (In reply to Lucas Gass from comment #4) > Everything works as excepted but I think a few small things can be done to > make the user experience easier: > > 1. On other OPAC pages (self-reg, suggestions ) we add a required div that > makes it clear that the field is required: > >
Required
> > That would be nice so that users can see what is required. > > > 2. The alert message 'Date should be filled.' is generic. We should tell the > user exactly which field needs attention. > > The "Hold starts on date" field is required > The "Hold not needed after" field is required Thx Lucas for your testing and observations. Hope they are fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:58:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 10:58:12 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:01:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 11:01:17 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:57:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 11:57:30 +0000 Subject: [Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com --- Comment #5 from Lucy Vaux-Harvey --- This remains an issue for orders with current holds attached to them. It would be great if the 'Cancel order' options in the basket view made it clear that the item/biblio would not be deleted due to a hold. Also the error message that displays following the Cancel order confirmation screen is not clear. The error message is this one (found on another bug report) - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117968. Could this be re-worded and formatted more clearly to highlight that the items have not been deleted because a hold is attached? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:59:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 11:59:59 +0000 Subject: [Koha-bugs] [Bug 29795] If branch is mandatory on patron self registration form, the pull down should default to empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:04:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:04:21 +0000 Subject: [Koha-bugs] [Bug 20689] Improve usability of Item search fields administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:16:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:16:49 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:16:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:16:53 +0000 Subject: [Koha-bugs] [Bug 29282] Allow items.issue and items.renewals to be shown in the bib details holdings table on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29282 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130568|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 131373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131373&action=edit Bug 29282: Add issues and renewals columns to holdings tbale on details page To test: 1 - Apply patch, restart all 2 - View a record with items in the staff client 3 - Note issues and renewals columns not shown 4 - Click the gear to edit visible columns 5 - Issues and renewals are present and hidden 6 - Click to view columns 7 - Confirm counts show, or 0 if item has not circulated/been renewed 8 - Circulate/renew an item 9 - Verify counts increase 10 - Make columns visible by default in Admin->Table settings 11 - Confirm columns show by default on details page Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:18:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:18:54 +0000 Subject: [Koha-bugs] [Bug 30194] Adapt Koha for JSON::Validator@5.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 131374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131374&action=edit Bug 30194: Adapt V1.pm to the latest JSON::Validator This patch acknowledges a refactoring that took place within JSON::Validator, the OpenAPIv2 schema validator and the Mojolicious::Plugin::OpenAPI plugin. To test: 0. Edit /etc/apt/sources.list.d/koha.list - Duplicate the only present line, replacing 'dev' for 'exp' Run: $ apt update ; apt dist-upgrade 1. Apply this patch 2. Restart all: $ restart_all ; tail -f /var/log/koha/kohadev/*.log => FAIL: It fails 3. Grab a bundled version of the API spec from a working Koha 4. (temporarily) tweak V1.pm to point to this file (swagger.json) 5. Repeat 2 => SUCCESS: Koha works with latests Mojolicious and JSON::Validator Work is being done on bug 30193 to come up with a reorganized spec that conforms better to the standard and thus doesn't require step 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:42:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:42:31 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #96 from Owen Leonard --- I get an error when I try to export a record in the OPAC: Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2dexport_2epl::XSLTParse4Display called at /kohadevbox/koha/opac/opac-export.pl line 147 It works in the staff interface. The "Simple Export" doesn't seem very useful... I wonder if we shouldn't have a more complex example? "

The chronicles of Narnia / C.S. Lewis ; with illustrations by Pauline Baynes.
New York : HarperCollinsPublishers, 2001.

" The changes to opac-detail-sidebar.inc are reverting some updates we don't want to lose. Please double-check to make sure you're only making essential changes there. Finally, there are QA warnings. Please run the QA tool to check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:58:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 12:58:03 +0000 Subject: [Koha-bugs] [Bug 25025] Drag-and-drop cover image upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:07:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:07:19 +0000 Subject: [Koha-bugs] [Bug 28663] One should not be able to apply a discount to a VOID accountline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28663 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:08:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:08:49 +0000 Subject: [Koha-bugs] [Bug 30132] overdue_notices.pl POD is incorrect regarding passing options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30132 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:12:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:12:43 +0000 Subject: [Koha-bugs] [Bug 29287] Display of funds on acquisitions home is not consistent with display on funds page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29287 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:18:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:18:49 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:11 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Severity|enhancement |minor Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:20 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:34 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:41 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:41 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:46 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:19:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:19:50 +0000 Subject: [Koha-bugs] [Bug 30153] FindDuplicate ElasticSearch should not use lowercase 'and' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:21:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:21:10 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:21:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:21:32 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:22:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:22:50 +0000 Subject: [Koha-bugs] [Bug 30164] Header filter not taken into account on the cities view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:02 +0000 Subject: [Koha-bugs] [Bug 29857] We must stringify our exceptions correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:02 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Bug 30007 depends on bug 29857, which changed state. Bug 29857 Summary: We must stringify our exceptions correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:03 +0000 Subject: [Koha-bugs] [Bug 30057] Move Virtualshelves exceptions to their own file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30057 Bug 30057 depends on bug 29857, which changed state. Bug 29857 Summary: We must stringify our exceptions correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29857 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:23 +0000 Subject: [Koha-bugs] [Bug 30007] Make ->anonymize methods throw an exception if AnonymousPatron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:24 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Bug 30023 depends on bug 30007, which changed state. Bug 30007 Summary: Make ->anonymize methods throw an exception if AnonymousPatron is not set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30007 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:43 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:24:43 +0000 Subject: [Koha-bugs] [Bug 30023] Add Koha::Old::Checkout->anonymize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:25:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:25:27 +0000 Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:26:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:26:32 +0000 Subject: [Koha-bugs] [Bug 29687] Get rid of an uninitialized warning in XSLT.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:33:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 13:33:12 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:13:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:13:25 +0000 Subject: [Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:14:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:14:19 +0000 Subject: [Koha-bugs] [Bug 29989] Improve headings in MARC staging template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29989 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:22:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:22:47 +0000 Subject: [Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #30 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:24:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:24:50 +0000 Subject: [Koha-bugs] [Bug 29886] Add Koha::Suggestions->search_limited In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #17 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:25:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:25:50 +0000 Subject: [Koha-bugs] [Bug 30125] Add full-stack tests for API pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30125 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle at bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:29:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:29:48 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #24 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:33:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:33:42 +0000 Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #20 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:41:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:41:46 +0000 Subject: [Koha-bugs] [Bug 29220] Minor fixes and improved code readability in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:42:12 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew at bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry --- Enhancement, not backported to 21.05. Please ask if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:42:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:42:12 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Bug 18493 depends on bug 29596, which changed state. Bug 29596 Summary: Add Yiddish language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:48:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:48:18 +0000 Subject: [Koha-bugs] [Bug 27696] Make a dedicated SCO issue slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27696 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow choice between |Make a dedicated SCO issue |ISSUESLIP and ISSUEQSLIP |slip |when printing a SCO receipt | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:49:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:49:08 +0000 Subject: [Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:50:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:50:06 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 The Minh Luong changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |the-minh.luong at inlibro.com --- Comment #44 from The Minh Luong --- Hi. I have followed the steps of comment 40 and I can't reproduce the problem. Here is what i did: After applying the patch: I attempt to create a new card template. The card template is created. However, I don't see any errors in my plack-intranet-error.log file. I also checked other logs and no error are displayed. I also tried to create a printer profile, as mentioned in the comment. The profile is created and I still can't see any of the errors in the log files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:50:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:50:45 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Andrew Fuerste-Henry from comment #13) > Enhancement, not backported to 21.05. Please ask if needed. Please backport :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:53:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:53:07 +0000 Subject: [Koha-bugs] [Bug 30026] International phone number not supported for sending SMS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 --- Comment #12 from Florian --- Created attachment 131375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131375&action=edit Bug 30026: Quick fix for SmsAlert Hint Just modifying the hint provided in patrons' messaging preferences to allow either + or 00 for international formats. No test plan needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:57:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:57:37 +0000 Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle at bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:59:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 14:59:57 +0000 Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches GetName() with null or empty branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #13 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:00:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:00:00 +0000 Subject: [Koha-bugs] [Bug 28576] Add patron image in patron detail section does not specify image size limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28576 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.12 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #25 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:11:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:11:53 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:11:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:11:56 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130745|0 |1 is obsolete| | --- Comment #8 from Lucas Gass --- Created attachment 131376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131376&action=edit Bug 30108: Database revision, adding new preference Test plan: Run upgrade or new install. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:11:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:11:59 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130746|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 131377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131377&action=edit Bug 30108: Preference description Test plan: Check the preferences form, tab Circulation, tab Hold policy. Look for OPACMandatoryHoldDates. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:12:03 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:12:03 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130747|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 131378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131378&action=edit Bug 30108: Allow making hold dates required Side note: Template still referred to class holddateto while not being used any longer. Replaced this occurrence by futuredate. Test plan: [1] Disable OPACAllowHoldDateInFuture. [2] Set pref OPACMandatoryHoldDates to "end date". [3] Verify that the end date is mandatory on opac-reserve. [4] Set pref OPACMandatoryHoldDates to "start date". [5] Verify that no dates are required. [6] Enable OPACAllowHoldDateInFuture. [7] Verify that start dates are required. [8] Set pref OPACMandatoryHoldDates to "no dates". [9] Verify that no dates are required again. Bonus: Check that more options box is opened when a date still is required. In case of item level being forced, verify that more options is opened regardless of pref setting. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:12:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:12:06 +0000 Subject: [Koha-bugs] [Bug 30108] Allow making hold dates required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131372|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 131379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131379&action=edit Bug 30108: (follow-up) Add required indication, differentiate alert As asked on comment4: [1] Add a required div as a visible hint when applicable. [2] Differentiate alert for hold start and end date. Test plan: See former patch. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:21:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:21:31 +0000 Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.04 released in| | --- Comment #7 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:23:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:23:52 +0000 Subject: [Koha-bugs] [Bug 20570] Add script to complete scanned article requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20570 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:24:35 +0000 Subject: [Koha-bugs] [Bug 28782] Get rid of custom query param list creation for request.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:24:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:24:35 +0000 Subject: [Koha-bugs] [Bug 29136] Patron search on request.pl has performance and display issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29136 Bug 29136 depends on bug 28782, which changed state. Bug 28782 Summary: Get rid of custom query param list creation for request.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:34:20 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:34:20 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.12 released in| | --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:39:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:39:37 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #13 from Lucas Gass --- Created attachment 131380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131380&action=edit Bug 29887: (follow-up) Create a system pref category for Independent branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:55:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 15:55:37 +0000 Subject: [Koha-bugs] [Bug 30226] New: Add system preference to disable auto-renew checkbox at checkout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Bug ID: 30226 Summary: Add system preference to disable auto-renew checkbox at checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In the Checkout Settings area of the checkout screen, there's a checkbox to make an individual checkout auto-renew. For libraries that don't wish to use auto-renewal at all and don't have the cron enabled, it would be good to have a system preference to remove this checkbox. It can be hidden with jQuery or CSS, but fully disabling it would be preferable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:27:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:27:09 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:27:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:27:13 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #45 from Nick Clemens --- Created attachment 131381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131381&action=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:02 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:06 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130194|0 |1 is obsolete| | Attachment #130195|0 |1 is obsolete| | Attachment #131363|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 131382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131382&action=edit Bug 15594: preserve sequence of 260 subfields in detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:11 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #12 from Nick Clemens --- Created attachment 131383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131383&action=edit Bug 15594: preserve sequence of 260 subfields in (staff) detail page When ordered $a$b$a$b$c in the MARC object, 260 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 0) create a notice with $a$b$a subfields. In that (mixed) order. 1) Go to staff detail page and see the fields displayed as "aab" 2) apply the patch 3) validate the aba display. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:15 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #13 from Nick Clemens --- Created attachment 131384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131384&action=edit Bug 15594: Class in now unchanged after the patch I'm not sure if this is the actual issue, but I found that the patch puts the span with the class "publisher_name" inside a new span with typeOf="Organization". In this patch, I removed that new span, to keep it coherent with the previous code. Also, the MARC 260 subfields are displayed correctly ! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:18 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 --- Comment #14 from Nick Clemens --- Created attachment 131385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131385&action=edit Bug 15594: (QA follow-up) Move span to publisher name, fix whitespace, only add spaces once per loop This patch updates the whitespace for readbility Moves the Ogranization span to the subfield b, publisher name only Moves check for last/whitespace to the loop Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:50:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 16:50:46 +0000 Subject: [Koha-bugs] [Bug 15594] Sequence of MARC 260 subfields different on XSLT result list and detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15594 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Nick Clemens --- Small patch, small cleanup, I think this can go ahead PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:05:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 17:05:42 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Kyle M Hall --- This looks really interesting! Jonathan, having used both to implement the same feature, I would love to know your opinion on how easy each one was to learn, and to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 17:08:02 +0000 Subject: [Koha-bugs] [Bug 30227] New: Replace the use of jQueryUI tabs on bibliographic detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 Bug ID: 30227 Summary: Replace the use of jQueryUI tabs on bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the bibliographic detail page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 17:08:02 +0000 Subject: [Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:08:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 17:08:02 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:14:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 17:14:50 +0000 Subject: [Koha-bugs] [Bug 29706] When placing a request on the opac, the user is shown titles they cannot place a hold on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29706 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.12 released in| | --- Comment #14 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:26:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:26:35 +0000 Subject: [Koha-bugs] [Bug 30228] New: Batch item modification fails if only action is deleting subfields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30228 Bug ID: 30228 Summary: Batch item modification fails if only action is deleting subfields Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: hannah.co at northwestu.edu QA Contact: testopia at bugs.koha-community.org When running batch item modification, if the only action is checked box(es) to delete a subfield, the batch item modification fails. The "Job has been enqueued" screen appears. On clicking "View detail of the enqueued job", we receive a 500 error. On checking the item(s), the subfields we've tried to delete are still populated with the previous data. If any values are added/edited, or dropdowns selected for any subfields, the subfields with checked boxes will be correctly deleted. Subfield deletion without any other edits does not work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:28:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:28:32 +0000 Subject: [Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:28:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:28:35 +0000 Subject: [Koha-bugs] [Bug 30227] Replace the use of jQueryUI tabs on bibliographic detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30227 --- Comment #1 from Owen Leonard --- Created attachment 131386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131386&action=edit Bug 30227: Replace the use of jQueryUI tabs on bibliographic detail page This patch replaces jQueryUI tabs on the bibliographic detail page, replacing them with Bootstrap tabs. To test, apply the patch and locate a bibliographic record in the staff client. Check the tabs on the detail page. Try to test as many variations as possible: - With and without holdings - With and without descriptions (5** note fields) - With alternate holdings (AlternateHoldingsField preference) - With HTML5 media (see Preferences -> Enhanced content -> HTML5 media) - With an associated suggestion - With an associated subscription - With acquisition information - With local cover images - With SeparateHoldings enabled - With other editions available (FRBRizeEditions) - With component parts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:31:21 +0000 Subject: [Koha-bugs] [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 [Bug 29998] Replace the use of jQueryUI tabs on item types administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:31:21 +0000 Subject: [Koha-bugs] [Bug 29998] Replace the use of jQueryUI tabs on item types administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:31:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:31:31 +0000 Subject: [Koha-bugs] [Bug 30229] New: Last barcode added duplicates in label batch if page refreshes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30229 Bug ID: 30229 Summary: Last barcode added duplicates in label batch if page refreshes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Note: I believe this is more an issue of how browsers work than a bug, and the duplicate(s) can be deleted with a click - but I'm documenting this here in case anyone else searches for it. When creating a label batch, if you refresh the page, the last barcode added will be duplicated. (Tested in Firefox on 21.05.09 and 20.05.14.) Steps to replicate: -Start a new label batch -Add barcode 111 -Add barcode 222 -In a separate tab, edit the call number for barcode 111 -Refresh your label batch page to see edit - barcode 222 is now repeated at end of batch The updated call number *will* apply to the batch/print correctly without refreshing the label batch page, but libraries may want to see the update before proceeding with the export. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:48:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:48:42 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:48:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:48:45 +0000 Subject: [Koha-bugs] [Bug 30223] Move book cover image upload JS to a separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30223 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131346|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 131387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131387&action=edit Bug 30223: Move book cover image upload JS to a separate file This patch moves most of the JavaScript from upload-images.tt into a separate file, upload-images.js. Functionality should be unchanged. To test, apply the patch and go to Tools -> Upload local cover image. Test all the things: - Drag-and-drop upload - Click-to-browse upload; - Deleting existing images - Uploading a zip file Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:49:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:49:44 +0000 Subject: [Koha-bugs] [Bug 30035] Wrong month name in numbering pattern In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #8 from Fridolin Somers --- Patch " Bug 30035: Fix failing test" pushed to master. I see it is already in 21.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:53:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:53:27 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 19:57:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 18:57:06 +0000 Subject: [Koha-bugs] [Bug 22993] Messaging preferences not set for patrons imported through API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22993 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|arthur.suzuki at biblibre.com |nick at bywatersolutions.com CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:03:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 19:03:18 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 --- Comment #16 from Fridolin Somers --- (In reply to Kyle M Hall from comment #12) > Pushed to 21.11.x for 21.11.03 You forgot to backport the DBRev : > git ll --grep=29596 master c346481429 Bug 29596: DBRev 21.12.00.014 87621c2c89 Bug 29596: Add Yiddish language This is also missing in 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:44:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 19:44:16 +0000 Subject: [Koha-bugs] [Bug 30217] When an item waiting on hold has the waiting status reverted the action is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30217 Amanda Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at hmcpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:10:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 21:10:46 +0000 Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew checkbox at checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:10:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 21:10:50 +0000 Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew checkbox at checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #1 from Lucas Gass --- Created attachment 131388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131388&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:13:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 21:13:18 +0000 Subject: [Koha-bugs] [Bug 30226] Add system preference to disable auto-renew checkbox at checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131388|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 131389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131389&action=edit Bug 30226: Add system preference AllowSetAutomaticRenewal To test: 1. Apply patch, restart the things, and run updatedatabase 2. Look for the system preference 'AllowSetAutomaticRenewal'. 3. To preserve current behavior the system preference should be set to allow by default. 4. Go to the circulation page and see that under 'Checkout settings' there is the option to set a particular item for auto renewal. 5. Set 'AllowSetAutomaticRenewal' to 'don't allow'. 6. Go back to the circulation page and under checkout settings you should no longer see the option to set an item for auto renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:20:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 21:20:04 +0000 Subject: [Koha-bugs] [Bug 29432] Item type deletion should test frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29432 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Fridolin Somers --- OK I close. We have a local fix : https://git.biblibre.com/biblibre/kohac/commit/c1a54004bff33174bde56c2ae3adad6eb417bc79 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:21:47 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 21:21:47 +0000 Subject: [Koha-bugs] [Bug 30230] New: Search for patrons in checkout should not require edit_borrowers permission Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Bug ID: 30230 Summary: Search for patrons in checkout should not require edit_borrowers permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 15812 made searching for patrons for checkout use the regular patron search. This resulted in a significant change in behavior for users who have _circulate_ permissions but not _edit_borrowers_. Previously, a user with these permissions could enter a partial name, be taken to a list of search results, and select the patron they desire. Following bug 15812, a user with these permissions will hit a "You do not have permissions" block when attempting to search for a partial patron name. One can allow the search by adding _edit_borrowers_ permission, but that also grants the ability to create and edit patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 23:31:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 22:31:53 +0000 Subject: [Koha-bugs] [Bug 30231] New: See (rejected) forms of series entry visible in search result (OPAC and intra) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Bug ID: 30231 Summary: See (rejected) forms of series entry visible in search result (OPAC and intra) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: januszop at gmail.com QA Contact: testopia at bugs.koha-community.org When using zebra with IncludeSeeFromInSearches on, with traced series, the rejected forms (4XX) of series entries are visible in result lists, both in OPAC and intra interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 23:34:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 22:34:39 +0000 Subject: [Koha-bugs] [Bug 30231] See (rejected) forms of series entry visible in search result (OPAC and intra) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek --- Created attachment 131390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131390&action=edit Bug 30231: (bug 5927 follow-up) See (rejected) forms of series entry visible in search result (OPAC and intra) When using zebra with IncludeSeeFromInSearches on, with traced series, the rejected forms (4XX) of series entries are visible in result lists, both in OPAC and intra interfaces. Test plan: ========= 1. Have a MARC 21 installation with zebra, and with IncludeSeeFromInSearches on. Have an authority records for series (130, or 100/110/111 with title) with rejected forms (4XX fields). So the auth record should contain at least: 130 _0 $a Series title 430 _0 $a Some other title under which the series in known Use (each) authority record in at least two biblio records (in appropriate fields, i.e. 800/810/811/830 or even deprecated 440, if it makes use of UNIF_TITLE). Don't forget to properly input also 490 (for 8XX). So the biblio record shold contain at least: 245 nn $a Work title. 490 1_ $a Series title 830 _0 $a Series entry $9 Reindex. 2. Perform a simple biblio search (in OPAC and in intra) with the title from auth record. 3. You shold get a list of results. See the Series information--you shold see not only the accepted entry from 1XX in auth but also the rejected forms from 4XX. 4. Apply the patch. 5. Repeat 3. You shold see only the entry form of series now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 23:36:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2022 22:36:28 +0000 Subject: [Koha-bugs] [Bug 30231] See (rejected) forms of series entry visible in search result (OPAC and intra) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30231 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 02:08:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 01:08:46 +0000 Subject: [Koha-bugs] [Bug 30232] New: Acquisition logged in user performance Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Bug ID: 30232 Summary: Acquisition logged in user performance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 02:10:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 01:10:39 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:03:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:03:55 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 --- Comment #1 from Fridolin Somers --- Created attachment 131391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131391&action=edit Bug 30232: Logged in user performance for CanUserManageBasket() Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. This patch optimises call for CanUserManageBasket(). You may benchmark on a vendor with a lot of baskets. Test plan 1) 1.1) Log in to staff interface as user A with all acquisition permissions 1.2) Set system preference 'AcqViewBaskets' to 'created or managed by staff member' 1.3) Create a new basket 1.4) Copy URL, ie /cgi-bin/koha/acqui/basket.pl?basketno=2 1.5) Click on 'Baskets' tab, you see the basket in table 2) 2.1) Log in to staff interface as user B with acquisition permissions but not 'order_manage_all' 2.2) Go to URL => You don't have access to basket 2.3) Click on 'Baskets' tab => you don't see the basket in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:26:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:26:22 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131391|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 131392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131392&action=edit Bug 30232: Logged in user performance for CanUserManageBasket() Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. This patch optimises call for CanUserManageBasket(). Also removes a useless refetch of logged in patron. You may benchmark on a vendor with a lot of baskets. Test plan 1) 1.1) Log in to staff interface as user A with all acquisition permissions 1.2) Set system preference 'AcqViewBaskets' to 'created or managed by staff member' 1.3) Create a new basket 1.4) Copy URL, ie /cgi-bin/koha/acqui/basket.pl?basketno=2 1.5) Click on 'Baskets' tab, you see the basket in table 2) 2.1) Log in to staff interface as user B with acquisition permissions but not 'order_manage_all' 2.2) Go to URL => You don't have access to basket 2.3) Click on 'Baskets' tab => you don't see the basket in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:34:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:34:09 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #17 from Mason James --- (In reply to Fridolin Somers from comment #16) > (In reply to Kyle M Hall from comment #12) > > Pushed to 21.11.x for 21.11.03 > > You forgot to backport the DBRev : > > > git ll --grep=29596 master > c346481429 Bug 29596: DBRev 21.12.00.014 > 87621c2c89 Bug 29596: Add Yiddish language > > This is also missing in 21.05.x hi Kyle, Andrew if you commit a fix to the git repo, and tag - i will release a new package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:34:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:34:10 +0000 Subject: [Koha-bugs] [Bug 18493] Add more languages to advanced search languages dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18493 Bug 18493 depends on bug 29596, which changed state. Bug 29596 Summary: Add Yiddish language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:34:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:34:52 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 --- Comment #3 from Fridolin Somers --- Patch "Logged in user performance for CanUserManageBasket()" Page /cgi-bin/koha/acqui/booksellers.pl tested with 3000 baskets. Time goes from 30s to 20s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:35:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:35:28 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion Priority|P5 - low |P1 - high Severity|enhancement |blocker --- Comment #18 from Mason James --- bumping severity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:50:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:50:40 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 03:50:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 02:50:44 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 --- Comment #4 from Fridolin Somers --- Created attachment 131393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131393&action=edit Bug 30232: Logged in user performance for CanUserUseBudget() Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. This patch optimises call for CanUserUseBudget(); You may benchmark on a user with a lot of budgets acess. Test plan : Play with impacted pages and check budgets list is the same than wihtout patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 04:55:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 03:55:35 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 04:55:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 03:55:39 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #3 from Mason James --- Created attachment 131394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131394&action=edit Bug 19169: Add a test to detect unneeded 'atomicupdate' files to test... 1/ set git repo $ git reset --hard v21.11.03 2/ run test $ prove ./t OK 3/ apply patch 4/ run test again, observe FAIL $ prove ./t/00-check-atomic-updates.pl ./t/00-check-atomic-updates.pl .. 1/? # Failed test 'check for unhandled atomic updates: bug_29596.pl' # at ./t/00-check-atomic-updates.pl line 34. # 'bug_29596.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 3. ./t/00-check-atomic-updates.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 04:56:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 03:56:07 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 05:01:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 04:01:19 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Priority|P5 - low |P1 - high --- Comment #4 from Mason James --- (In reply to Jonathan Druart from comment #2) > Are you asking for something in the release tools, like a git hook? > I use one I can share if you want. hi Jonathan i added a test so we can catch this problem early, before the release :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 05:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 04:03:58 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29596 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 05:03:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 04:03:58 +0000 Subject: [Koha-bugs] [Bug 29596] Add Yiddish language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19169 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:21:56 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:21:56 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131392|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 131395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131395&action=edit Bug 30232: Logged in user performance for CanUserManageBasket() Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. This patch optimises call for CanUserManageBasket(). Also removes a useless refetch of logged in patron. You may benchmark on a vendor with a lot of baskets. Test plan 1) 1.1) Log in to staff interface as user A with all acquisition permissions 1.2) Set system preference 'AcqViewBaskets' to 'created or managed by staff member' 1.3) Create a new basket 1.4) Copy URL, ie /cgi-bin/koha/acqui/basket.pl?basketno=2 1.5) Click on 'Baskets' tab, you see the basket in table 2) 2.1) Log in to staff interface as user B with acquisition permissions but not 'order_manage_all' 2.2) Go to URL => You don't have access to basket 2.3) Click on 'Baskets' tab => you don't see the basket in table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:22:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:22:00 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 --- Comment #6 from Fridolin Somers --- Created attachment 131396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131396&action=edit Bug 30232: Logged in user performance for CanUserUseBudget() and CanUserModifyBudget() Some acquisition methods can take borrowernumber or a Koha::Patron->unblessed. When called with logged in user, sometimes in a loop, performance will be better if fetching Koha::Patron of logged in user only once. This patch optimises call for CanUserUseBudget() and CanUserModifyBudget(); You may benchmark on a user with a lot of budgets acess. Test plan : Play with impacted pages and check budgets list is the same than wihtout patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:22:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:22:30 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:27:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:27:10 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:27:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:27:30 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131395|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 07:45:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 06:45:06 +0000 Subject: [Koha-bugs] [Bug 30232] Acquisition logged in user performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30232 --- Comment #7 from Fridolin Somers --- /cgi-bin/koha/acqui/acqui-home.pl with 300 funds : >From 13 seconds to 10 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:43:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:43:27 +0000 Subject: [Koha-bugs] [Bug 30234] New: Serial covers no longer appear in the administrative interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Bug ID: 30234 Summary: Serial covers no longer appear in the administrative interface Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: egpetridis at yahoo.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 131397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131397&action=edit Administrative view. I'm running koha v21.11.03.000 and I've noticed that serial covers no longer appear in the administrative interface. They do appear in OPAC nevertheless. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:44:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:44:11 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #1 from Manos PETRIDIS --- Created attachment 131398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131398&action=edit OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:45:39 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:45:39 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #2 from Manos PETRIDIS --- Created attachment 131399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131399&action=edit Columns available in administrative interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:46:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:46:34 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #3 from Manos PETRIDIS --- Created attachment 131400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131400&action=edit Search preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:47:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:47:17 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #4 from Manos PETRIDIS --- Created attachment 131401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131401&action=edit Serials preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:48:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:48:35 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #5 from Manos PETRIDIS --- Created attachment 131402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131402&action=edit Cover preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 13:54:34 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 12:54:34 +0000 Subject: [Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #25 from Manos PETRIDIS --- Could this be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 23:46:57 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 22:46:57 +0000 Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855 --- Comment #17 from Katrin Fischer --- I am not sure yet I understand the issue. Can you please add a test plan to your commit message? If the item was renewed and became overdue a second time, my expectation would be that the fine process 'starts over' with a new accountlines entry and starting to calculate 'from 0'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 5 23:58:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 22:58:30 +0000 Subject: [Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 --- Comment #14 from Katrin Fischer --- (In reply to Lucas Gass from comment #13) > Created attachment 131380 [details] [review] > Bug 29887: (follow-up) Create a system pref category for Independent branches Was referring to your comment there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 00:02:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 23:02:16 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #25 from Katrin Fischer --- (In reply to Katrin Fischer from comment #20) > Please remember to update the wiki page as well :) > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks *cough* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 00:08:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Mar 2022 23:08:24 +0000 Subject: [Koha-bugs] [Bug 30216] Additional identification filed for patron for sip2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216 --- Comment #1 from Katrin Fischer --- Where do you store your RFID UID? Is storing it in username or cardnumber no option? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 10:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 09:37:49 +0000 Subject: [Koha-bugs] [Bug 29964] SMTP server list not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #20 from Manos PETRIDIS --- Could it be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 10:38:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 09:38:07 +0000 Subject: [Koha-bugs] [Bug 29964] SMTP server list not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #21 from Manos PETRIDIS --- Could it be related to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 10:46:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 09:46:52 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #6 from Manos PETRIDIS --- Must clarify that older local cover images do appear. Same goes for new images added to new items/issues of older records/serials. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:17:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:17:15 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #19 from Manos PETRIDIS --- Could https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 be related to the fonts used? I can't find any reference to fonts in my library's koha-conf.xml MP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:31:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:31:32 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #20 from Katrin Fischer --- (In reply to Manos PETRIDIS from comment #19) > Could https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 be > related to the fonts used? I can't find any reference to fonts in my > library's koha-conf.xml > > MP It should look something like this with the FONT_DIR replaced: https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/koha-conf.xml#L132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:34:38 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:34:38 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #7 from Katrin Fischer --- You don't give information of where you pull the images from. On item level we can only display local covers, but your screenshot of the system preferences shows that you have turned that feature off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:36:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:36:37 +0000 Subject: [Koha-bugs] [Bug 29964] SMTP server list not populating In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 --- Comment #22 from Katrin Fischer --- (In reply to Manos PETRIDIS from comment #21) > Could it be related to > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28800 ? It is related in terms of missing dependencies/wrong versions etc. The suggested fix will hopefully solve the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:37:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:37:49 +0000 Subject: [Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #26 from Katrin Fischer --- (In reply to Manos PETRIDIS from comment #25) > Could this be related to > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ? It could be a duplicate, but this bug has already been closed and pushed to stable versions, so best way to find out is to update :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 12:48:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 11:48:50 +0000 Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Dotted-integer versions Dotted-integer (also known as dotted-decimal) versions consist of positive integers separated by full stop characters (i.e. "dots", "periods" or "decimal points"). This are equivalent in format to Perl "v-strings", with some additional restrictions on form. They must be given in "normal" form, which has a leading "v" character and at least three integer components. To retain a one-to-one mapping with decimal versions, all components after the first should be restricted to the range 0 to 999. The final component may be separated by an underscore character instead of a period. Mason, maybe you can clarify? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:05:29 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:05:29 +0000 Subject: [Koha-bugs] [Bug 23347] Columns settings for items in OPAC should be according to the framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23347 --- Comment #3 from Katrin Fischer --- (In reply to Marjorie Barry-Vila from comment #2) > Hi Katrin, > > Sorry for the delay! > > It's more a question finally, why the Call number column is displayed when > the field is empty? There are columns that are not displayed as soon as the > field is empty, such as the Notes. > > Even if in the cataloging framework, the callnumber subfield is not checked > for the visibility in opac, the column is displayed anyway. I think only > filled subfields should appear in the table. > > And if that's not possible, then make the Opac box in the cataloging > framework work for the items table. I think the visibility setting for the OPAC in the frameworks currently only works for the MARC view. But you can use the table configuration to still hide the column in the table. So it's possible and also makes sense to configure this in both spots. I think it might make it more confusing actually if the item table was both configured in frameworks and in the column settings. Harder to find out what the issue might be if something doesn't show. Showing or not showing a column that is empty is a little bit of a different problem. We do this for some columns like OPAC note, but I think it was assumed that the call number would usually be filled in or should be, so the column should not be automatically hidden. If you want, we could change the bug description to make it about hiding an empty callnumber column specifically? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:07:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:07:55 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:08:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:08:00 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131199|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 131403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131403&action=edit Bug 17648: ACCTDETAILS notice does not show in notices.pl The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. Test Plan: 1) Apply this patch 2) Create a new patron with an email address 3) Note the patron's ACCTDETAILS notice shows in the patron's messages Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:08:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:08:05 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131200|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 131404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131404&action=edit Bug 17648: (QA follow-up) Further code cleaning We actually have a Koha::Patron method to do all the work of finding the right patron primary email address for notices.. we can use that here instead of doing it long hand. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:08:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:08:09 +0000 Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the notices tab in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131245|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 131405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131405&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:25:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:25:19 +0000 Subject: [Koha-bugs] [Bug 30236] New: Layout of self registration confirmation page is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30236 Bug ID: 30236 Summary: Layout of self registration confirmation page is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Created attachment 131406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131406&action=edit Screenshot of confirmation step of self registration When testing bug 30214 I noticed that in Google Chrome self registration page you get to from the link in the verification message has a somewhat broken layout. The login form should be on the right, etc. (see attached screenshot) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:28:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:28:05 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:28:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:28:11 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131338|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 131407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131407&action=edit Bug 30214: Add ACCTDETAILS notice to verified self registration This patch adds the ACCTDETAILS notice trigger to the opac self registration process. Allowing new users, with varification enabled, to receive the ACCTDETAILS notice immediately after their account is varified. Test plan 1) Enable AutoEmailOpacUser system preference 2) Ensure the ACCTDETAILS notice is configured 3) Ensure `PatronSelfRegistrationVerifyByEmail` is enabled 4) Register a new user via the opac self registration process using an email address you have access to 5) Verify the user by following the link in the verification email you should have received. 6) The new user should have been created and you should be able to see the account details notice in their associated notices 7) Confirm that the email address used above has received the notice. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:28:17 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:28:17 +0000 Subject: [Koha-bugs] [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 --- Comment #10 from Katrin Fischer --- Created attachment 131408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131408&action=edit Bug 30214: (QA follow-up) Clarify code comment Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:29:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:29:14 +0000 Subject: [Koha-bugs] [Bug 30214] Send ACCDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to send |Send ACCDETAILS notice for |ACCDETAILS notice for new |new patrons added via self |patrons added via self |registration |registration | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:29:58 +0000 Subject: [Koha-bugs] [Bug 30214] Send ACCTDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Send ACCDETAILS notice for |Send ACCTDETAILS notice for |new patrons added via self |new patrons added via self |registration |registration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:31:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:31:00 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add option to send |Add option to send |ACCDETAILS notice for new |ACCTDETAILS notice for new |patrons added via patron |patrons added via patron |imports |imports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:35:53 +0000 Subject: [Koha-bugs] [Bug 30237] New: Rename and rephrase AutoEmailOpacUser system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Bug ID: 30237 Summary: Rename and rephrase AutoEmailOpacUser system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 27812, 29005, 30214 With the changes from bugs 27812, bug 29005, and bug 30214 we will have a much cleaner and secure feature than before that will work in a much more predictable way. So I think this would then be a good moment to add documentation to the pref: IS: AutoEmailOpacUser [Send|Don't send] an email to newly created patrons with their account details. COULD BE: AutoEmailNewUser (switch Opac with New) [Send|Don't send] an email to newly created patrons, including verified self registrations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 [Bug 30214] Send ACCTDETAILS notice for new patrons added via self registration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:35:53 +0000 Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 [Bug 30237] Rename and rephrase AutoEmailOpacUser system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:35:53 +0000 Subject: [Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 [Bug 30237] Rename and rephrase AutoEmailOpacUser system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:35:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:35:53 +0000 Subject: [Koha-bugs] [Bug 30214] Send ACCTDETAILS notice for new patrons added via self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 [Bug 30237] Rename and rephrase AutoEmailOpacUser system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:43:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:43:23 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #14 from Katrin Fischer --- (In reply to Martin Renvoize from comment #13) > Does that cover everything? Almost! I think the original idea here was to have a button for manual sending/resending of a notice. So maybe we could add that to the 'More' menu if possible? It could also be useful if patrons don't give an email address at first, but add one later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:48:00 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:48:00 +0000 Subject: [Koha-bugs] [Bug 20161] Show same information for format, material type etc. on the detail page as in the result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20161 --- Comment #4 from Katrin Fischer --- Hi Lucas, if we want to display the same information everywhere, maybe a new include file (like for the languages) would be a good idea? It would save some copy and paste and make it easier to keep things aligned in the future. If we make it a template, it would also be easy to pass on some specifics like different class names. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:52:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:52:02 +0000 Subject: [Koha-bugs] [Bug 30215] "Item found" in accountlines untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- The problem is here: my $credit; if ( $credit_total > 0 ) { my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; $credit = $account->add_credit( { amount => $credit_total, description => 'Item found ' . $self->itemnumber, type => 'LOST_FOUND', interface => C4::Context->interface, library_id => $branchcode, item_id => $self->itemnumber, issue_id => $lost_charge->issue_id } ); Having the description option seems to be a bad idea in the first place when it's not used for adding variables like the title, due date etc. Always meant trouble for translations. I also agree about the itemnumber not being useful. We do have the link to the item displaying in the table, there is no need for it in the description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:56:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:56:04 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 13:56:09 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 12:56:09 +0000 Subject: [Koha-bugs] [Bug 30190] Green buttons turn blue for a second when clicking them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131259|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 131409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131409&action=edit Bug 30190: Green buttons turn blue for a second when clicking them This patch adds additional CSS to better cover various states of buttons in the OPAC. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client - In the OPAC, test various green buttons in varous states: default, hover, and active (the appearance when the button is clicked but before the mouse button is released). - The button should be styled in various shades of green in all cases. - Test a disabled button by performing a catalog search. - On the results page, before any checkboxes are checked, the "Save" button should look correct. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:01:01 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:01:01 +0000 Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds" permission can no longer update hold pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207 --- Comment #6 from Katrin Fischer --- Hi Kyle, quick question: could it make sense to use: flagsrequired => { reserveforothers => '*' }, As I understand it, that means "module level or any sub permission". So that could be more fail save if we added more sub perms. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:02:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:02:35 +0000 Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC records on import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set Default Profile when |Set default profile when |staging MARC notices on |staging MARC records on |import |import --- Comment #2 from Katrin Fischer --- Just a note, I have seen notices used a lot by French devs when they mean 'records', so it might be a false friend in French maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:03:22 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:03:22 +0000 Subject: [Koha-bugs] [Bug 30037] Set default profile when staging MARC records on import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #3 from Katrin Fischer --- Is this ready for testing/review yet? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:17:15 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:17:15 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 --- Comment #9 from Katrin Fischer --- This doesn't work quite right for diacritics and umlauts. Ä or À will always sort to the bottom (after something starting with Z). Google suggests that this can be fixed by use locale - but I have to admit I am not sure where you'd add that and about the consequences. As this might also be an issue for French, it might be worth investigating a bit more. But it looks like this might be kind of a global issue :( I notice that sorting tables also puts the Ä at the bottom. So ready to pass QA on this being an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:23:37 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:23:37 +0000 Subject: [Koha-bugs] [Bug 29922] Group of libraries are now displayed in alphabetical order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29922 --- Comment #10 from Katrin Fischer --- I wonder if this could also be down to a server setting for locale (so might only be an issue in my dev env?) If someone could shed some light it would be nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:29:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:29:54 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:29:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:29:58 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131206|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 131410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131410&action=edit Bug 29713: Make item table when placing an item level hold sortable This patch modifies the holds page in the OPAC so that users selecting a specific item to place a hold on can sort the table of items. This patch also removes some obsolete JavaScript left over from before Flatpickr. To test, apply the patch and go to Administration -> Circulation and fine rules to make sure at least one item type in your system has "OPAC item level holds" set to "allow." - Log in to the OPAC as a user who can place holds. - Search the catalog for items which will accept item-level holds. - Place a hold on one of the results, and click the "Show more options" link on the holds page. - Check the "specific item" radio button. - A table of items should be displayed. Confirm that the table is sortable. - The first entry in the table should be selected. - Perform the same test when placing a hold on multiple titles. Confirm that each table of items is sortable. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:30:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:30:07 +0000 Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 --- Comment #14 from Katrin Fischer --- This works nicely, thx for rescuing the patch, Owen! Only 'nit-pick' I have that we offer sorting on the first column with the checkboxes, but that doesn't appear to work, so we might want to remove the sorting option there altogether. (QA follow-up?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:33:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:33:48 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:41:54 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:41:54 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- Love the activity that discussion about ACCTDETAILS has caused and this is really a good enhancement! Suggestions: * We already have PASSWORD_RESET, maybe we could use PASSWORD_CHANGE here instead of PASSCHANGE to better match them up. Blockers: 1) Sadly, we still have to deal with some installers. Could you please add an SQL version of the new notice to those? Especially for UNIMARC users we cannot switch them over yet as we still have to deal with some framework issues. There is a test in xt to see if you have caught them all! 2) When using updatedatabase for adding the notice, there are some strange indentations Dear [% borrower.firstname %] [% borrower.surname %], Someone has changed your library user account password. If this is unexpected, please contact the library. I think the database update needs to use \n in the SQL. Question: * It looks like this will only work when the 'set_password' method is used, but not when you change the password using 'edit patron', correct? I don't see this as a blocker, but wanted to verify. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:44:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:44:18 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer --- As the follow-up is only a text change, I am resetting to signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:47:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:47:26 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:58:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:58:24 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:58:28 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:58:28 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131034|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 131411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131411&action=edit Bug 30159: Fix Check() to validate both mandatory and important fields This patch adds a check for both mandatory and important fields when validating bibliographic records during cataloguing. To test: 1. Go to Admin -> Biblio frameworks. View the MARC structure of your default framework. 2. Search for tag 082. Edit the subfields for this tag. 3. Check the 'important' checkbox for subfield a and Save. 4. Go to add or edit a new biblio record under Cataloguing. 5. Ensure the 082$a field is empty and hit Save. 6. Notice the confirmation pop-up is an unreadable display of HTML. 7. Click Cancel on the pop-up box. 8. Apply the patch and refresh the editor page. 9. Ensure the 082$a field is empty and hit Save. 10. Notice the confirmation pop-up is more helpful this time. Click Cancel on the pop-up box. 11. Notice the 082$a field is displayed at the top of the page as an important field that is missing information. Use the 'go to field' link and confirm this works as expected. 12. Leave 082$a empty and hit Save. 13. This time click OK on the confirmation pop-up. Confirm you are able to save your record as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:58:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:58:32 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131365|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 131412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131412&action=edit Bug 30159: (follow-up) Make warning messages consistent Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:58:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:58:36 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #8 from Katrin Fischer --- Created attachment 131413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131413&action=edit Bug 30159: (QA follow-up) Fix translatability of alert message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 14:58:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 13:58:44 +0000 Subject: [Koha-bugs] [Bug 30159] Fix display of validation of important fields when biblio cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #9 from Katrin Fischer --- Hi Adam, thx for your patch! Be careful when working with the JavaScript message. We do need the _("") or __("") in JS files to make strings translatable. I fixed this line in my follow-up: + var r=confirm("Important fields(s) are not filled. Are you sure you want to save?"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:00:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:00:21 +0000 Subject: [Koha-bugs] [Bug 9181] Add patron messaging preferences to batch patron modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add patron messaging |Add patron messaging |preference to Batch Patrons |preferences to batch patron |Modification tool |modification tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:00:53 +0000 Subject: [Koha-bugs] [Bug 30219] Batch Patron Modification - Add Patron Notification Preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30219 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Rebecca, there is already an older bug asking for this functionality, I am linking yours as a duplicate. *** This bug has been marked as a duplicate of bug 9181 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:00:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:00:53 +0000 Subject: [Koha-bugs] [Bug 9181] Add patron messaging preferences to batch patron modification tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #5 from Katrin Fischer --- *** Bug 30219 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:03:59 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:03:59 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #4 from Katrin Fischer --- I believe this did default to the patron's home library in the past, which would make this a regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:07:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:07:06 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:07:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:07:11 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131341|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 131414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131414&action=edit Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:07:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:07:49 +0000 Subject: [Koha-bugs] [Bug 30220] Purchase suggestion defaults to first library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30220 --- Comment #6 from Katrin Fischer --- (In reply to Lucas Gass from comment #3) > I would consider this a separate issue, and will file a separate bug, but if > you add branchcode to the sys pref OPACSuggestionMandatoryFields the > dropdown should default to an empty value in order to force the user into > making a choice. Please do! Also tested this with an Anonymous suggestoin and there it still defaults to the first entry, which seems ok given the use case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:12:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:12:19 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 --- Comment #10 from Katrin Fischer --- This looks great, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:13:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:13:14 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:13:18 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:13:18 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131344|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 131415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131415&action=edit Bug 20362: Direct link to authority records missing in staff detail view (1xx , 7xx) I added a magnigying glass icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:13:23 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:13:23 +0000 Subject: [Koha-bugs] [Bug 20362] Direct link to authority records missing in staff detail view (1xx, 7xx) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131345|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 131416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131416&action=edit Bug 20362: (follow-up) Direct link to authority records missing in staff detail view (1xx , 7xx) I change the magnigying glass icon to FA icon in the staff detail view for 1xx and 7xx of the record that links to the authority records. The following test plan is for 100 tag only but the patch can be apply for all 1xx and 7xx tags that can be connect with an authority record. Test Plan: 1) On the Koha staff page, create a new authority. The type of authority will be: e.g Personal Name 2) When creating authority, in tab 1 under -HEADING--PERSONAL NAME enter the personal name term entry element and then save the new authority e.g. Twain, Mark. 3) In circulation, search the catalog for a random book. Click the title of the book and you will be taken to the book details. 4) Edit the record and in tab 1 , scroll down the - MAIN ENTRY-- PERSONAL NAME and repeat this tag (the icon next to the title). 5) Edit the Personal name term entry element by clicking the button on the right of the bar. 6) In the Search main heading ($a only) enter your personal name term e.g. Twain, Mark. 7) Press search, and then in the table that pops up, click 'choose'. 8) Save your edits and the new personal name term will be in the 'By:' of the book details. 9) Notice that there is no magnifying glass icon. 10) Apply this patch 11) Notice that there is now a magnifying glass icon next to the personal name term. 12) Click on the magnifying glass and it will take you directly to the authorities records Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:24:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:24:13 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer --- I am sorry, patch applied, restart_all and did a couple of reloads... but I can't get the warning to trigger. :( Not sure if this is also a separate bug: When the defaults are changed, the digest option although added for the patron category is not checked. The age warning might also upset things a bit, but I tried without that and still no luck. Testing in Firefox on Ubuntu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:26:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:26:05 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Katrin Fischer --- Sometimes... as soon as I had sent my comment, it started working. Including the digest option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:30:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:30:58 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 --- Comment #5 from Katrin Fischer --- Ok, this is the thing: * Updated setting for patron category staff, checking Item due with digest. * Apply patch, reload and restart all the things. * Edit 'Nicole Schneider' * Set patron category to 'staff' * Accept changes to default with OK * Verify: The digest option appears checked, but greyed out. * Save * Edit patron again - the digest option is not set I'll file this as a new bug, as it happens without the patch set too :( Passing QA here meanwhile. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:33:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:33:36 +0000 Subject: [Koha-bugs] [Bug 30238] New: When changing patron category the digest option is not saved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30238 Bug ID: 30238 Summary: When changing patron category the digest option is not saved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com * Update messaging preferences for patron category 'Staff', check Item due with digest. * Edit 'Nicole Schneider' or any other patron in your database, that is not Staff yet and set some different messaging preferences * Edit again and set patron category to 'Staff' * Verify that messaging preferences have been set to default for 'Staff', but: * Verify: The digest option appears checked, but greyed out. * Save * Edit patron again - the digest option was not saved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:34:07 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:34:07 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:34:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:34:11 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131342|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 131417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131417&action=edit Bug 30177: When editing an existing patron set message_prefs_dirty to true 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3 - Confirm that the messaging prefs have been reset to that of the default patron category 4 - Apply patch 5 - Repeat Step 2, this time you should see a warning asking if you want to set messaging prefs to the category default 6 - Press OK and save. Confirm that the messaging prefs are now set to the default for that category 7 - Try it again with an existing account and press Cancel this time. Notice that there should be no change to the patron messaging prefs. 8 - Try making a new patron and switching the category, you should see no warning and the message prefs should be proberly set to the defaults of any category you choose. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:34:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:34:52 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without first warning staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30238 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:34:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:34:52 +0000 Subject: [Koha-bugs] [Bug 30238] When changing patron category the digest option is not saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30238 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30177 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:36:27 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:36:27 +0000 Subject: [Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed Summary|When changing patron |When changing patron |categories of existing |categories of existing |accounts it should not |accounts it should not |reset message prefs without |reset message prefs without |first warning staff |warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:40:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:40:19 +0000 Subject: [Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Katrin Fischer --- As this is the area we just had the security fixes for, we might want to verify if this is related (I suspect it is) to make sure it gets backported to all the right versions. I am updating the severity as for a standalone self check station this could be quite an issue with no staff around to restart things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 15:44:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 14:44:55 +0000 Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority search results table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer --- (In reply to Marjorie Barry-Vila from comment #9) > (In reply to Samu Heiskanen from comment #8) > Hi, > > I just tested in a sandbox (21.12.00.016) > (https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview' > appears twice in the Actions menu, is this normal? > > Regards > > Marjorie Hi Marjorie, please don't hesitate to set "Failed QA" - it sure sounds like we need to check this out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 16:00:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 15:00:19 +0000 Subject: [Koha-bugs] [Bug 25384] Label maker font list is not configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25384 --- Comment #21 from Manos PETRIDIS --- Thenk you very much for the pointer! MP(In reply to Katrin Fischer from comment #20) > (In reply to Manos PETRIDIS from comment #19) > > Could https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 be > > related to the fonts used? I can't find any reference to fonts in my > > library's koha-conf.xml > > > > MP > > It should look something like this with the FONT_DIR replaced: > https://git.koha-community.org/Koha-community/Koha/src/branch/master/etc/ > koha-conf.xml#L132 Thank you very much Katrin for the pointer! MP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:06:46 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 20:06:46 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #8 from Manos PETRIDIS --- (In reply to Katrin Fischer from comment #7) > You don't give information of where you pull the images from. > > On item level we can only display local covers, but your screenshot of the > system preferences shows that you have turned that feature off? Images are from the same server that exhibits this problem. Please note that in 'Cover preferences' attachment both LocalCoverImages and OPACLocalCoverImages are set to Display. i.e. they're enabled. Otherwhise no local cover images would be displayed at all. Please also note that: * Older biblios display all items' images in the administrative interface, even those I added today. Note biblionumber 642 in '202203_642_Admin' * Newer biblios don't display any items' images in the administrative interface. Note biblionumber 1234 in '202203_NatGeo_Admin' * Newer biblios do display all items' images in OPAC. Note biblionumber 1234 for example in '202203_NatGeo_OPAC' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:07:53 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 20:07:53 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #9 from Manos PETRIDIS --- Created attachment 131418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131418&action=edit Newer biblios don't display any items' images in the administrative interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:08:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 20:08:26 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #10 from Manos PETRIDIS --- Created attachment 131419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131419&action=edit Newer biblios do display all items' images in OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:09:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 20:09:05 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #11 from Manos PETRIDIS --- Created attachment 131420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131420&action=edit Older biblios display all items' images in the administrative interface, even those I added today. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:14:08 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 20:14:08 +0000 Subject: [Koha-bugs] [Bug 29803] Local cover images don't show in detail page, but only in results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29803 --- Comment #27 from Manos PETRIDIS --- (In reply to Katrin Fischer from comment #26) > (In reply to Manos PETRIDIS from comment #25) > > Could this be related to > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 ? > > It could be a duplicate, but this bug has already been closed and pushed to > stable versions, so best way to find out is to update :) Unfortunately I'm already at 21.11.03.000 and apt-get reports there isn't anything new to install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:18:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:18:45 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:19:19 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:19:19 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130196|0 |1 is obsolete| | --- Comment #54 from Victor Grousset/tuxayo --- Created attachment 131421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131421&action=edit Bug 29602: Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:19:24 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:19:24 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130197|0 |1 is obsolete| | --- Comment #55 from Victor Grousset/tuxayo --- Created attachment 131422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131422&action=edit Bug 29602: (follow-up) Surround strings with span tag To be nicer with translators. Update the PO files for whichever languages will show how this is useful. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:19:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:19:30 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130198|0 |1 is obsolete| | --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 131423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131423&action=edit Bug 29602: (follow-up) Fix TT tags broken due to missing % -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:19:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:19:35 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 131424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131424&action=edit Bug 29602: (follow-up) fix crash: SET KohaSpan → USE KohaSpan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:19:40 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:19:40 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130200|0 |1 is obsolete| | --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 131425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131425&action=edit Bug 29602: (follow-up) fix duplicate, missing or mismatching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:22:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:22:42 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 00:31:21 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2022 23:31:21 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #59 from Victor Grousset/tuxayo --- Rebased, and diffed the current and previous version to confirm that the conflict resolutions didn't changed anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 01:30:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 00:30:48 +0000 Subject: [Koha-bugs] [Bug 30239] New: Only items that are allowed to be reserved should be considered when checking if an item can be reserved Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30239 Bug ID: 30239 Summary: Only items that are allowed to be reserved should be considered when checking if an item can be reserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The 'on shelf holds' circulation rule defines whether all or some items must be unavailable for a hold to be placed. If 'on shelf holds' is set so all items must be unavailable to place holds, then only items that allow reserves should be considered in that. For example: You have a record with a bunch of different itemtypes attached: Biblio A has three items - a book, a DVD, and a magazine. Books and DVDs have circulation rules where reserves are allowed (reserves allowed > 0). Magazines have a circulation rule where reserves are NOT allowed (reserves allowed == 0); 'On shelf holds' is set to 'all items must be unavailable'. The book and DVD for Biblio A are both checked out and the magazine is not. This means that all items that COULD be reserved are unavailable so a patron should be able to place a hold on them. However, because the magazine is not checked out, Koha things there is an item still available and blocks the patron from placing a hold, even though magazines are not allowed to be reserved. When checking if an item can be reserved based on the 'on shelf holds' rule, we should only consider items that allow reserves in the first place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 01:31:10 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 00:31:10 +0000 Subject: [Koha-bugs] [Bug 30239] Only items that are allowed to be reserved should be considered when checking if an item can be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30239 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 03:14:06 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 02:14:06 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #32 from Alex Buckley --- (In reply to Katrin Fischer from comment #31) Hi Katrin, My apologies for my delay in responding. I've been away for the last 3 weeks, but back now! Thank you for your response I'll make those changes, and let you know if I have any questions. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 03:29:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 02:29:05 +0000 Subject: [Koha-bugs] [Bug 30239] Only items that are allowed to be reserved should be considered when checking if an item can be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30239 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|ASSIGNED |RESOLVED --- Comment #1 from Aleisha Amohia --- Never mind - I can see this works as expected in upstream! Just need to backport a fix for our library :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 04:44:02 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 03:44:02 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #16 from wainuiwitikapark at catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 04:44:58 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 03:44:58 +0000 Subject: [Koha-bugs] [Bug 29862] TestBuilder.t fails with ES enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29862 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 04:55:42 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 03:55:42 +0000 Subject: [Koha-bugs] [Bug 29722] Add some diversity to sample quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29722 --- Comment #17 from Aleisha Amohia --- (In reply to wainuiwitikapark from comment #16) > Does this need to be backported to 19.11.x? Completely up to you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 05:09:31 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 04:09:31 +0000 Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881 --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- Backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 05:53:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 04:53:45 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 05:54:04 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 04:54:04 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #33 from Alex Buckley --- Created attachment 131426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131426&action=edit Bug 23352: Set default collection code when creating subscription The default collection code set in the subscription will be applied if item records are created when receiving the serial. Test plan: 1. Apply 3 patches 2. Run updatedatabase.pl and restart services 3. Create a subscription: - Tick the 'Create an item record when receiving this serial' radio button - Select values in the Location, Collection code and Item type dropdowns - Save the subscription 4. Confirm the Location, and Collection code default values you choose in #3 are displaying in the 'Information' tab of page that's loaded 5. Receive the serial: - Click 'Receive' - Change the status dropdown from 'Expected' to 'Arrived' - Confirm the 'Collection Code', 'Shelving location' and 'Koha item type' dropdowns are pre-filled with the values you defined in #3 6. Run unit test t/db_dependent/Serials.t Sponsored-By: Brimbank Library, Australia Signed-off-by: Samu Heiskanen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 05:54:25 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 04:54:25 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 --- Comment #34 from Alex Buckley --- Created attachment 131427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131427&action=edit Bug 23352: (follow-up) Fixes for QA review Test plan: 1. Confirm that installer/data/mysql/atomicupdate/bug_23352-add_ccode_column_to_subscriptions_table.pl has the exec flag 2. Create a subscription. Notice the 'Collection' dropdown defaults to the 'None' option - same as Location 3. Save the subscription without changing the 'None' collection 4. Receive the serial and confirm the 'Collection' field is empty 5. Create a second subscription. Change the 'Collection' dropdown to 'Fiction', then save the subscription 6. Receive the serial and confirm the 'Collection' dropdown is set to 'Fiction' 7. Confirm that the 'Collection code' terminology in the template is replaced with 'Collection' Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 06:00:16 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 05:00:16 +0000 Subject: [Koha-bugs] [Bug 23352] Define serial's collection code in the subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #35 from Alex Buckley --- (In reply to Katrin Fischer from comment #31) Hi Katrin, I have attached the third patch (rebased against master) and a followup patch which should hopefully fix the three points you noted in comment #31 Good catch re. point 3! I have corrected that. I noticed there are no unit tests for C4::Items->PrepareItemrecordDisplay() so I could not confirm it via a unit test and have added test steps into the fourth patch. Could you please take a look? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 07:36:32 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 06:36:32 +0000 Subject: [Koha-bugs] [Bug 30239] Only items that are allowed to be reserved should be considered when checking if an item can be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30239 --- Comment #2 from Katrin Fischer --- You scared me there for a moment! Can you share which version it#s broken in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:03:35 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 08:03:35 +0000 Subject: [Koha-bugs] [Bug 30216] Additional identification filed for patron for sip2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30216 --- Comment #2 from Mohsin --- Fischer , card number and userid is already occupied with Internal Student ID and OPAC login ID . You can convert any string in barcode and use it but in RFID , there is either UID or you own data on it which is quite different then generating barcode.So if we able to add a new column in Borrower table for RFID UID , it may work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:32:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 08:32:48 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |oleonard at myacpl.org |com | --- Comment #60 from Jonathan Druart --- I am out of this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:47:45 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 08:47:45 +0000 Subject: [Koha-bugs] [Bug 29602] We must be nicer with translators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC|julian.maurice at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:50:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 08:50:30 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #12 from Jonathan Druart --- Using v21.11.03: 0. turned the prefs on 1. created a new bibliographic record 2. attached a cover image to the bib record 3. created a new item 4. attached a cover image to the item => I see the cover images on the staff interface. Do you see an error in the console? Please try to recreate the problem on a sandbox and provide us the different steps. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:30:12 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 09:30:12 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #171 from Emmi Takkinen --- Sorry but I'm unable to repeat step 8, since number of days doesn't change when I change library. It seems number is based on "Standard rules for all libraries", not individual rules as described. After deleting standard rule, number of days is set by ReservesMaxPickUpDelay. Also tests fail for me: not ok 12 - Expiration date should be set to today + 3 based on circulation rules # Failed test 'Expiration date should be set to today + 3 based on circulation rules' # at t/db_dependent/Holds/WaitingReserves.t line 244. # got: '2022-03-07' # expected: '2022-03-10' not ok 13 - Expiration date should be set to today + 4 based on circulation rules and including a holiday # Failed test 'Expiration date should be set to today + 4 based on circulation rules and including a holiday' # at t/db_dependent/Holds/WaitingReserves.t line 266. # got: '2022-03-07' # expected: '2022-03-12' Other than these, this seems to be working as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:51:48 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 09:51:48 +0000 Subject: [Koha-bugs] [Bug 30193] Invalid refs removed in JSON::Validator 5.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30193 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:51:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 09:51:52 +0000 Subject: [Koha-bugs] [Bug 30194] Adapt Koha for JSON::Validator@5.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30194 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 09:58:33 +0000 Subject: [Koha-bugs] [Bug 30234] Serial covers no longer appear in the administrative interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #13 from Manos PETRIDIS --- (In reply to Jonathan Druart from comment #12) > Using v21.11.03: > 0. turned the prefs on > 1. created a new bibliographic record > 2. attached a cover image to the bib record > 3. created a new item > 4. attached a cover image to the item > > => I see the cover images on the staff interface. > > Do you see an error in the console? > Please try to recreate the problem on a sandbox and provide us the different > steps. No errors in the browser console. How might I load my library's backup to a sandbox? The issue does not always appear, therefore any new additions might not bring it to the surface. Menawhile however, I've discovered what the issue is: Local covers are displayed in the administrative interface only for the items set as having home library the one selected by the user upon entry / set my the user using the selector in the upper right corner. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:01:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:01:50 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 --- Comment #5 from Jonathan Druart --- All RM and RMaints must have a pre-push hook with the following code in it. my @atomicupdate_files = `git show HEAD:installer/data/mysql/atomicupdate/|tr -s '\\n' | grep -v '^tree'|grep -v 'README'|grep -v skeleton`; chomp for @atomicupdate_files; for my $atomic ( @atomicupdate_files ) { push @errors, "Atomicupdate file exists - $atomic"; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:02:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:02:52 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Serial covers no longer |Serial local covers do not |appear in the |appear in the |administrative interface |administrative interface, | |unless their home library | |is the same as the one | |selected by the user upon | |entry. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:05:52 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:05:52 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:05:55 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:05:55 +0000 Subject: [Koha-bugs] [Bug 19169] Add a test to detect unneeded 'atomicupdate' files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131394|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 131429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131429&action=edit Bug 19169: Add a test to detect unneeded 'atomicupdate' files to test... 1/ set git repo $ git reset --hard v21.11.03 2/ run test $ prove ./t OK 3/ apply patch 4/ run test again, observe FAIL $ prove ./t/00-check-atomic-updates.pl ./t/00-check-atomic-updates.pl .. 1/? # Failed test 'check for unhandled atomic updates: bug_29596.pl' # at ./t/00-check-atomic-updates.pl line 34. # 'bug_29596.pl' # matches '(?^u:.*pl$)' # Looks like you failed 1 test of 3. ./t/00-check-atomic-updates.pl .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests JD Amended patch: fix copyright year Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:12:14 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:12:14 +0000 Subject: [Koha-bugs] [Bug 25886] libmojolicious-plugin-openapi-perl and libnet-oauth2-authorizationserver-perl unable to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25886 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #20 from Mason James --- (In reply to Mark Rogers from comment #19) > (In reply to Phantom from comment #10) > > did this: > > > > echo 'deb http://debian.koha-community.org/koha stable main bionic' | tee > > /etc/apt/sources.list.d/koha.list > > > > and the install is complete successfully. > > I had the same issue with libmojolicious-plugin-openapi-perl being unable to > update from 1.15-1~kohadev1 to 2.16-1+koha1. > > My /etc/apt/sources.list.d/koha.list was also missing "bionic" at the end, > and adding it fixed the issue. > > I was missing "bionic" after following the instructions at > https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages in my > previous upgrades (from 18.05 to 18.11, 19.05, and 19.11). Those > instructions are trying to cover Ubuntu installations since (and including) > 16.04, but do not include any codename ("xenial" or "bionic") in the > koha.list file. > > Should the instructions on the wiki be updated to say the following? (I'm > requesting an account on the Wiki so I can make the change.) hi Mark, the following page is now marked obsolete, so no need to update it https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages we have combined both debian and ubuntu installation guides, as the install steps are identical https://wiki.koha-community.org/wiki/Koha_on_Debian -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:23:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:23:50 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #14 from Jonathan Druart --- ok, I recreate now, with SeparateHoldings. It seems broken since attaching a cover images to items is possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:31:26 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Version|21.11 |unspecified Depends on| |26145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 [Bug 26145] Add the ability to attach a cover image at item level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:31:26 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:31:26 +0000 Subject: [Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:37:05 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:37:05 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:37:11 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:37:11 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #15 from Jonathan Druart --- Created attachment 131430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131430&action=edit Bug 30234: Fix local cover image display for other holdings Bug 26145 added the ability to add local cover images to items. If SeparateHoldings is set, items from other libraries are displayed in a separate tab, and not considered as visible. We have a JS test to assume that images not shown are not present, this only apply for the images for the bibliographic record, as they can come from different sources. Test plan: Turn on LocalCoverImages and SeparateHoldings Create a record with different items coming from different libraries Attach images to items and to the biblio Notice that with this patch you can see the images from the "Other holdings" tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:37:50 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 10:37:50 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #16 from Jonathan Druart --- Hum I found a bug but it's not exactly what you are describing. Can you try the patch and see if it fixes your problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:23:30 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:23:30 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development adds release notes| |plugin hooks for several | |holds actions. The hook is | |called *after_hold_action* | |and has two parameters | | | |* | |**action**: containing a | |string that represents the | |_action_, possible values: | |_fill_, _cancel_, _suspend_ | |and _resume_. | |* | |**payload**: A hashref | |containing a _hold_ key, | |which points to the | |Koha::Hold object. --- Comment #26 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #25) > (In reply to Katrin Fischer from comment #20) > > Please remember to update the wiki page as well :) > > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks > > *cough* Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:23:36 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:23:36 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:31:13 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:31:13 +0000 Subject: [Koha-bugs] [Bug 30240] New: Re-authentication on sensitive actions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30240 Bug ID: 30240 Summary: Re-authentication on sensitive actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be nice if it was possible to give extra protection to some sensitive actions in the staff client, such as maybe updating borrowers and definitely changing sysprefs. This could be done by asking the user to re-authenticate, before carrying out the action. Extra nice if this could be turned on and off for individual actions. https://opsec.readthedocs.io/en/latest/user/re-authentication-on-sensitive-actions.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:44:44 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:44:44 +0000 Subject: [Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234 --- Comment #17 from Manos PETRIDIS --- (In reply to Jonathan Druart from comment #16) > Hum I found a bug but it's not exactly what you are describing. Can you try > the patch and see if it fixes your problem? My installation is a packages one, but I can verify that by updating file /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/catalogue/detail.tt issue has been resolved. I notice that there are several similar files, for different interface languages, for example /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/el-GR/modules/catalogue/detail.tt These files be automatically updated I suppose once the fix reaches some future release. MP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:44:49 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:44:49 +0000 Subject: [Koha-bugs] [Bug 30072] Add more holds hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #27 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #26) > (In reply to Katrin Fischer from comment #25) > > (In reply to Katrin Fischer from comment #20) > > > Please remember to update the wiki page as well :) > > > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks > > > > *cough* > > Done. Thx :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:58:33 2022 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2022 11:58:33 +0000 Subject: [Koha-bugs] [Bug 30225] Rewrite cities admin view in Vue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30225 --- Comment #3 from Jonathan Druart --- (In reply to Kyle M Hall from comment #2) > This looks really interesting! > > Jonathan, having used both to implement the same feature, I would love to > know your opinion on how easy each one was to learn, and to use. Good question. I should start by saying that I had almost no expression with any of JS frameworks. Only played a bit with react a couple of months ago. I am at a loss when diving into the whole node ecosystem: npm, yarn, gulp, and all the transpilers/compilers available. It took me a while to make it work with Vue... It seems very easy to start a new project from scratch using any of the JS frameworks, you have several CLI tools (Vue CLI, create-react-app) to build the whole structure of the project, run a dev instance on a port, hot reload, etc. But there is way less documentation when you want to integrate them to an existing project, write your own code to transpile, etc. Anyway, I found react and vue quite different. The major problems I had to deal with were: 1. The integration with DataTables   Both React/Vue and DataTables will manage the DOM and we should not make DT mess with React/Vue's components. Actually we should not make React/Vue aware of DT's instance 2. Render React/Vue's components "on the fly", for the "Edit" and "Delete" buttons we had to each action cell   On need to make React/Vue aware of the onclick event to change the state of the app, but those components need to be added after DT has been initialized. Given all the work we provided to make our DT implementation a big player of our REST API usage (and even when we don't use the REST API routes) I didn't feel confident to bypass it, we must deal with is as it, and not rewrite another version of the table (ideally the table should be a REST/Vue component). Another problem was the different versions and the new coding styles/recommendations. For react I learnt, after my first implementation, that everything was obsolete. They do no longer use class/this, but functions and hooks. Same for Vue, there is v3 that is "the new default version as of 7 February 2022" (that's fresh!) and so you find a lot of code that is actually v2. Also, bootstrap's libraries (BootstrapVue and React-Bootstrap), BoostrapVue is supporting Vue2.7 so you need to use another BootstrapVue3 lib for Vue3, which is using Bootstrap 5, way ahead of our Bootstrap version 3.5 (and so buttons are either not styled correctly when using BootstrapVue3's tags, or the whole Koha CSS get broken when you use the BootstrapVue3 css). I haven't answered your question yet, I can give you some subjective feeling: Vue Pro:  * Template/Script/Style (I haven't used style in my implement however) pattern in the component. The templating system is great (see