From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:13:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Feb 2022 23:13:53 +0000
Subject: [Koha-bugs] [Bug 30199] New: self checkout login by cardnumber is
broken if you input a non-existent cardnumber
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199
Bug ID: 30199
Summary: self checkout login by cardnumber is broken if you
input a non-existent cardnumber
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Self checkout
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
To recreate:
1. Set SelfCheckoutByLogin to 'cardnumber'.
2. Go to http://localhost:8080/cgi-bin/koha/sco/sco-main.pl
3. Enter an invalid carnumber like 'thisisabadcardnumber'
4. See the appropriate message "Sorry The userid thisisabadcardnumber was not
found in the database. Please try again."
5. Try again with a different cardnumber and notice the same exact error
message including the 'thisisabadcardnumber' cardnumber.
6. The only thing that solves it for me is to direct my browser to this URL:
http://localhost:8080/cgi-bin/koha/sco/sco-main.pl?op=logout
That properly logs me out and allows me to input a new cardnumber.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:55:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Feb 2022 23:55:37 +0000
Subject: [Koha-bugs] [Bug 30200] New: Add customizable tabs to interlibrary
loan requests list
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30200
Bug ID: 30200
Summary: Add customizable tabs to interlibrary loan requests
list
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: lari.taskula at hypernova.fi
In staff client, all interlibrary loan requests are loaded into a table
regardless of their status.
Ability to sort them by status under multiple tabs would make librarians life a
lot easier.
This Bug adds such feature.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:06:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 01:06:05 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:06:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 01:06:11 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106938|0 |1
is obsolete| |
Attachment #106939|0 |1
is obsolete| |
Attachment #106940|0 |1
is obsolete| |
--- Comment #82 from Owen Leonard ---
Created attachment 131174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131174&action=edit
Bug 6815: Capture member photo via webcam
This patch builds on a patch by Mark Tompsett, adding the option to take
a patron's picture using the computer's webcam. The photo can then be
saved to the patron's account.
To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- Go to Administration -> System preferences and enable the
'patronimages' preference.
- View a patron record. In the sidebar, hover your mouse over the blank
patron image. Click the "Edit" button which appears.
- A modal window should appear with two sections, "Upload patron photo"
and "Take patron photo."
- If your computer has a webcam, your browser should ask permission to
access it. Grant access.
- You should see the view of your webcam shown under the "Take photo"
button.
- Click the "Take photo" button. The captured photo should be shown in
place of the live video from the webcam.
- You should now see three buttons: "Retake photo," "Download photo,"
and "Upload photo."
- Clicking "Retake photo" should hide those buttons and return you
to a live video view.
- Clicking "Download" should make your browser download the image.
- Clicking "Upload" should cause the page to redirect back to the
patron detail page where you should see the new patron image
displayed in the sidebar.
- Trigger the modal again and click the "cancel" button. The
modal should disappear and camera access should stop.
- If your computer has no webcam the modal should appear correctly but
there should be a banner at the bottom indicating that a camera is not
available.
- Try the test again but this time deny your browser access to the
webcam. You may need to reset the camera permissions in your browser's
settings. When the modal appears you should see a message saying
access to the camera is denied.
- The patron image edit modal should be available on all pages which
show the patron image in the sidebar: Check out, Batch check out,
Details, Accounting, Routing lists, Circulation history, Holds
history, Modification log, Notices, Statistics, Files, Purchase
suggestions, Discharges, Housebound, and ILL requests history.
- Test adding an image to a patron record using the "Upload photo"
option. It should still work correctly.
- If the patron has an image attached, the "Upload photo" section should
have a "Delete" button. Test that it works correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:12:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 07:12:42 +0000
Subject: [Koha-bugs] [Bug 30198] Add privacy elements to reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30198
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |emmi.takkinen at koha-suomi.fi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:48:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 08:48:57 +0000
Subject: [Koha-bugs] [Bug 30201] New: Hahaa
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30201
Bug ID: 30201
Summary: Hahaa
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: gggeming1234567890 at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Created attachment 131175
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131175&action=edit
Haha
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:50:59 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 08:50:59 +0000
Subject: [Koha-bugs] [Bug 30201] SPAM
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30201
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Summary|Hahaa |SPAM
Resolution|--- |INVALID
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:40:35 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 09:40:35 +0000
Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with
IndependentBranches on
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
--- Comment #13 from Fridolin Somers ---
Sure, another bug report for long-term fix is good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:03:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 10:03:05 +0000
Subject: [Koha-bugs] [Bug 30202] New: Option to send the cart to the library
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30202
Bug ID: 30202
Summary: Option to send the cart to the library
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: christian.stelzenmueller at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
It would be good if there is an option, where the patrons
are able to send the cart (OPAC) to the library,
additional to the entered email-address.
Maybe with a checkbox saying "Send cart to the library".
This option should of course be configurable with a system preference.
Some libraries are using the cart feature instead of holds to
get items off the shelves for their patrons.
They don't want to have these "holds" in Koha on purpose.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:12:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 12:12:40 +0000
Subject: [Koha-bugs] [Bug 30150] Dutch option in language limits is garbled
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150
--- Comment #7 from Marcel de Rooy ---
(In reply to Eric Phetteplace from comment #2)
> I just used a report `select * FROM language_descriptions` and found the
> Dutch entries further down. If I run your query I get this:
>
> subtag type lang description id
> nl language de Niederländisch 138
> nl language en Dutch 26
> nl language fr Néerlandais 27
> nl language nl nedərlɑns 25
> NL region en Netherlands 299
> NL region nl Nederland 300
>
> Should we change the "nedərlɑns" description in the database to "Nederlands"
> then?
Yes, Nederlands is the correct spelling. Change it. The first description seems
to be a fonetic one. But apart from replacing it, I would say that there is
some encoding issue too.
I already have this entry:
| nl | language | nl | Nederlands | 25 |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:31:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 12:31:47 +0000
Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty
indicators as space making it hard to edit in cataloguing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154
--- Comment #5 from Marcel de Rooy ---
By default, you will find this entry for UNIMARC in your ControlledIndicators
preference:
# UNIMARC: Always copy the indicators from the authority
unimarc, *, ind1:auth1, ind2:auth2
If you don't want this behaviour, a simple remedy is to comment that last line
starting with unimarc.
I would not recommend doing so but it is possible to just ignore standards and
the like ;)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:32:03 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 12:32:03 +0000
Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty
indicators as space making it hard to edit in cataloguing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154
--- Comment #6 from Marcel de Rooy ---
I recommend closing this report. It is no bug.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:48:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 12:48:02 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #845 from Marcel de Rooy ---
(In reply to Aleisha Amohia from comment #844)
> (In reply to Marcel de Rooy from comment #835)
> > Still applied on current master (more or less: minor conflicts)
> > commit 4cc3c0a760df4ddd96cd7bdadc4a766343f0a103
> >
> > Will be spending some time on it now and next week, and hoping that the
> > other volunteers will be able to do so too..
>
> Have fixed the merge conflict and the failing tests and qa tests mentioned
> above.
Thx for doing that quickly. Resuming here now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:13:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:13:08 +0000
Subject: [Koha-bugs] [Bug 30203] New: Can we trust the clean slate in
Circulation.t ?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30203
Bug ID: 30203
Summary: Can we trust the clean slate in Circulation.t ?
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Not sure what happened exactly. But a failing Circulation.t must have removed
all users in my devbox.
# Start with a clean slate
$dbh->do('DELETE FROM issues');
$dbh->do('DELETE FROM borrowers');
And my borrowers:
select borrowernumber,userid,lastseen from borrowers;
+----------------+---------------------------------------------------------------------------+---------------------+
| borrowernumber | userid
| lastseen |
+----------------+---------------------------------------------------------------------------+---------------------+
| 382 | pCITR3m30mWAv4MTsEhckB0QR1JoJFgBac2mdWx
| 2022-03-01 13:01:39 |
| 383 |
sazlgFEfa4UmwVgniArAfluzcETJXkru9ktdHKYzSqTXwYckCAXNje3ZpqfRabaz42p |
2022-03-01 13:01:39 |
| 384 | VkGSPpUO7VFE2it55nZ2pflAmo75HUin4eYVKtThczB7tUF_AZFXuOcg95_Q
| 2022-03-01 13:01:39 |
| 385 |
opoi06B6_LWhoOXQtTjYrN01Vm182og8OK6Uaezc_CfNnA6SYicmnWzb2hEeZF_ |
2022-03-01 13:01:39 |
| 386 | john.renewal
| NULL |
| 387 | katrin.reservation
| NULL |
| 388 | kyle.reservation
| NULL |
| 389 | alice.reservation
| NULL |
| 390 | ca.glisse
| NULL |
| 391 | T5MrUI8DftRsa_nou6Q_VO76Wby4HAfcDsNP9WXk3gom8
| 2022-03-01 13:01:39 |
| 392 |
goV_DQYtptbpxYFdUtEcpJqz9X4fq3Zn4Arf336wEvxvc7rF8prBsQRDLq8_8FZhQypuamFi |
2022-03-01 13:01:39 |
| 393 | fridolyn.somers
| NULL |
| 394 | kyle.hall
| NULL |
| 395 | kyle.hall1
| NULL |
| 396 | chelsea.hall
| NULL |
| 397 | fn.dn
| NULL |
etc etc
The family Hall are prominently visible now :) But Katrin and Fridolin too..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:17:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:17:36 +0000
Subject: [Koha-bugs] [Bug 30123] On set library page,
desk always defaults to last in list instead of desk user is signed
in at
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nicolas.legrand at bulac.fr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:43:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:43:49 +0000
Subject: [Koha-bugs] [Bug 24865] Customize the Accountlines Description
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew at bywatersolutions.com
--- Comment #5 from Andrew Fuerste-Henry ---
A very minor quibble, the current behavior is to give the due date including
the time. The default notice in this patch calls the due date without the time.
It should be changed to maintain current behavior.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:49:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:49:55 +0000
Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty
indicators as space making it hard to edit in cataloguing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154
--- Comment #7 from Noémie Labine ---
The library did clear the appropriate line in AuthorityControlledIndicators and
decided to put a default value of 0 for the second indicator of their 830
field. I believe they will correct the authority records as they see them. In
the end, they do know that it would be prefereable to keep every line in
AuthorityControlledIndicators and correct any empty indicator they would find
in Uniform title authority.
I'm closing this report, thanks for taking the time.
Have a nice day everyone !
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:50:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:50:05 +0000
Subject: [Koha-bugs] [Bug 29907] The 'type' column in the public lists table
is redundant
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29907
Noémie Labine changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:50:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:50:34 +0000
Subject: [Koha-bugs] [Bug 29907] The 'type' column in the public lists table
is redundant
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29907
Noémie Labine changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |---
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:51:30 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:51:30 +0000
Subject: [Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty
indicators as space making it hard to edit in cataloguing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154
Noémie Labine changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:52:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 13:52:23 +0000
Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able
to take multiple types as a parameter
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #11 from Andrew Fuerste-Henry ---
I'm getting this error when trying to run process_message_queue with this
patch:
Global symbol "$letter_code" requires explicit package name (did you forget to
declare "my $letter_code"?) at misc/cronjobs/process_message_queue.pl line 84.
Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference
constructor) at misc/cronjobs/process_message_queue.pl line 90, near "};"
Type of arg 1 to Try::Tiny::try must be block or sub {} (not reference
constructor) at misc/cronjobs/process_message_queue.pl line 90, near "};"
Execution of misc/cronjobs/process_message_queue.pl aborted due to compilation
errors.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:25:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:25:20 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128890|0 |1
is obsolete| |
--- Comment #31 from David Gustafsson ---
Created attachment 131176
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131176&action=edit
Bug 29440: Refactor and clean up bulkmarcimport.pl
To test:
1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert
-update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log"
2) Verify in /tmp/import.log that one biblio has been inserted
3) Import again without the "-n" option, verify that one biblio has been
updated and the rest inserted
4) In the staff interface search the catalog for some string appearing in
the imported biblios to verify records have been indexed
5) View/edit some of the biblios the staff interface to very have been
properly imported
6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file
authorities.xml -insert -update -c=MARC21 -keepids="024a" -match
"heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml"
7) Go to the authorities page and find the imported authority by for example
search for a
400 or 100 field value. Verify that the 001 field of the incoming record has
been moved to 024a.
Also check that the value of 024a appear as a key in /tmp/ids.yml.
8) Edit the authorities.xml file and change the value of field 400a
9) Import authorities again using the same options
10) Verify that the 400a field of the authority in Koha has not been
updated (the import was skippped since revision did not change)
11) Edit authorities.xml, replace the value of field 005 in the file with field
005
of the authority in Koha incremented by one
12) Import again with the same options
13) Verify that the 400a field of the authority in Koha now have been
updated
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:25:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:25:24 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128891|0 |1
is obsolete| |
--- Comment #32 from David Gustafsson ---
Created attachment 131177
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131177&action=edit
Bug 29440: Make authorities import behavior consistent with biblios
The current behavior for when importing authorities, when match
option is enabled, is to insert as a new authority fetching from db
fails. This is both a bit confusing and not consistent with the biblio
case where an error is generated. Also clean up error and log messages
so both messages/errors and when messages/errors are issued are more
consistent for the biblio and authority case.
Signed-off-by: Frank Hansen
The patch works fine for me.
Signing off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:31:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:31:31 +0000
Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329
Holly changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hc at interleaf.ie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:38:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:38:17 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
--- Comment #33 from David Gustafsson ---
Rebased against master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:41:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:41:38 +0000
Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329
--- Comment #7 from Katrin Fischer ---
If there is a feature added for this, I'd love having an option to add
checkboxes instead of having to use a Yes/No pull down :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:43:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:43:18 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:48:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:48:33 +0000
Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131136|0 |1
is obsolete| |
--- Comment #3 from Martin Renvoize ---
Created attachment 131178
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131178&action=edit
Bug 30185: Missing return in db rev 210600003.pl
db rev files are constructed with a return {...}, db rev 210600003.pl is
missing return word.
I don't know if it can impact the db upgrade but we should fix it for
consistency.
To test upgrade from a version 21.05 and check db rev is applied.
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:48:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:48:53 +0000
Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131178|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 131179
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131179&action=edit
Bug 30185: Missing return in db rev 210600003.pl
db rev files are constructed with a return {...}, db rev 210600003.pl is
missing return word.
I don't know if it can impact the db upgrade but we should fix it for
consistency.
To test upgrade from a version 21.05 and check db rev is applied.
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:49:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:49:07 +0000
Subject: [Koha-bugs] [Bug 30185] Missing return in db rev 210600003.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30185
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Trivial PQA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:50:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:50:54 +0000
Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails
validation on first submission
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:52:07 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131176|0 |1
is obsolete| |
--- Comment #34 from David Gustafsson ---
Created attachment 131180
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131180&action=edit
Bug 29440: Refactor and clean up bulkmarcimport.pl
To test:
1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert
-update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log"
2) Verify in /tmp/import.log that one biblio has been inserted
3) Import again without the "-n" option, verify that one biblio has been
updated and the rest inserted
4) In the staff interface search the catalog for some string appearing in
the imported biblios to verify records have been indexed
5) View/edit some of the biblios the staff interface to very have been
properly imported
6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file
authorities.xml -insert -update -c=MARC21 -keepids="024a" -match
"heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml"
7) Go to the authorities page and find the imported authority by for example
search for a
400 or 100 field value. Verify that the 001 field of the incoming record has
been moved to 024a.
Also check that the value of 024a appear as a key in /tmp/ids.yml.
8) Edit the authorities.xml file and change the value of field 400a
9) Import authorities again using the same options
10) Verify that the 400a field of the authority in Koha has not been
updated (the import was skippped since revision did not change)
11) Edit authorities.xml, replace the value of field 005 in the file with field
005
of the authority in Koha incremented by one
12) Import again with the same options
13) Verify that the 400a field of the authority in Koha now have been
updated
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:52:11 +0000
Subject: [Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131177|0 |1
is obsolete| |
--- Comment #35 from David Gustafsson ---
Created attachment 131181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131181&action=edit
Bug 29440: Make authorities import behavior consistent with biblios
The current behavior for when importing authorities, when match
option is enabled, is to insert as a new authority fetching from db
fails. This is both a bit confusing and not consistent with the biblio
case where an error is generated. Also clean up error and log messages
so both messages/errors and when messages/errors are issued are more
consistent for the biblio and authority case.
Signed-off-by: Frank Hansen
The patch works fine for me.
Signing off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:55:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:55:50 +0000
Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with
IndependentBranches on
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131137|0 |1
is obsolete| |
--- Comment #14 from Martin Renvoize ---
Created attachment 131182
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131182&action=edit
Bug 30178: (bugs 27526 and 28445 follow-up) Every librarian can edit every item
with IndependentBranches on
Problem arises after applying bugfix 27526 and 28445: with
IndependentBranches on, a librarian without superlibrarian privileges,
can edit (and potentially delete) every item (i.e. also from a foreign
branch). This is because can_be_edited calculation is buggy (in two spots).
Test plan:
1. Have (at least) two branches defined.
2. Have IndependentBranches set.
3. Have a biblio record with items belonging to different branches.
4. Be a librarian without superlibrarian rights, with editcatalogue
and tool permissions set.
Scenario A (Edit items):
1. Go to Edit -> Edit items view (cataloguing/additems.pl).
2. You will be able to edit every item, also ones not from the branch
you are from (cf. the button 'Actions').
3. Apply the patch.
4. Repeat 1.
5. You should be able to edit only the items from your branch.
Scenario B (Edit items in batch):
1. From Normal view go to Edit -> Edit items in batch.
2. You will be able to batch edit every item, also ones not from the branch
you are from.
3. Apply the patch.
4. Repeat 1.
5. You should be able to edit only the items from your branch (and
see 'Cannot edit' for others.
Scenario C (Delete items in batch):
1. From Normal view go to Edit -> Delete items in batch.
2. You will not see the string 'Cannot delete' and only by chance
will not be able to activate the checkboxes next to foreign items.
3. Apply the patch.
4. Repeat 1.
5. You should be able to delete only the items from your branch (and
see 'Cannot delete' for others.
Scenario D and E:
Analogous steps can be executed from Tools -> Batch item modification
and Tools -> Batch item deletion
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:57:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:57:20 +0000
Subject: [Koha-bugs] [Bug 30178] Every librarian can edit every item with
IndependentBranches on
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #15 from Martin Renvoize ---
Well sleuthed, this was hard to trace.
I've confirmed the fix works and I can't find any regressions. Lets get this
one pushed as a matter of urgency and continue tidying up in a further bug..
I'll leave Katrin and Fridolin to report that new bug.
So.. Passing QA, thanks for the patch Janusz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:59:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:59:01 +0000
Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches
GetName() with null or empty branchcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #130201|0 |1
is obsolete| |
--- Comment #10 from Martin Renvoize ---
Created attachment 131183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131183&action=edit
Bug 29826: Manage call of Template Plugin Branches GetName() with null or empty
branchcode
Bug 26587 added a concatenation that sends a warning if var is undef :
$ prove t/db_dependent/Template/Plugin/Branches.t
Use of uninitialized value $branchcode in concatenation (.) or string at
/kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 35.
This patch adds an early return empty string when GetName is called with
$branchcode null or empty string.
Test plan :
1) Run t/db_dependent/Template/Plugin/Branches.t without patch
2) Run with the patch to see warning disappear
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:59:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 14:59:34 +0000
Subject: [Koha-bugs] [Bug 29826] Manage call of Template Plugin Branches
GetName() with null or empty branchcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29826
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #11 from Martin Renvoize ---
Great fix, includes tests, no regressions and squelched warnings.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:01:23 +0000
Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too
short
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #130809|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 131184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131184&action=edit
Bug 30128: Change language_subtag_registry.description to varchar(255)
In database, language_descriptions.description is VARCHAR(255).
language_subtag_registry.description is VARCH(25), it should have same size.
You can see in https://www.loc.gov/standards/iso639-2/php/code_list.php there
is for example 'South American Indian languages'
Test plan :
1) Run atomic update
2) Check language_subtag_registry.description is now varchar(255)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:01:27 +0000
Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too
short
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131142|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 131185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131185&action=edit
Bug 30128: [DO NOT PUSH] Update DBIC Schema
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:01:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:01:50 +0000
Subject: [Koha-bugs] [Bug 30128] language_subtag_registry.description is too
short
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #6 from Martin Renvoize ---
Trivial fix, no mistakes found, no regerssions.
PQA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:03:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:03:29 +0000
Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131138|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 131186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131186&action=edit
Bug 30147: Fix modules usage in opac-detail.pl
On the ktd sample database when trying to go to the detail page from the result
list:
Undefined subroutine
&CGI::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults
called at /kohadevbox/koha/opac/opac-detail.pl line 260
Turning off OpacBrowseResults makes the error disappear.
In opac-detail.pl, use C4::Search is missing searchResults and getRecords
To test:
- Search for something that gives several result pages in OPAC, example: e
- Switch to one of the last pages using link on top of results, example: 10
- Open any of the records listed in detail view
- Verify that the error is shown
- Apply patch and repeat, error is gone and browsing behaves as expected
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:03:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:03:50 +0000
Subject: [Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Another trivial fix, well spotted.
PQA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:08:02 +0000
Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin
Response
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
Emmanuel Bétemps changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |e.betemps at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:08:14 +0000
Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131129|0 |1
is obsolete| |
--- Comment #7 from Martin Renvoize ---
Created attachment 131187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131187&action=edit
Bug 29771: Remove trivial cases
I squashed the patches because they are too trivial to have a test plan.
Or it is too much work to write the test plan for such trivial cases. I
leave the original commit messages just in case.
Generally, this are all cases in which CGI::param is being called in a
trivially identifiable _list context_. i.e. they are assigned to a
@variable.
I left one case out on purpose: admin/auth_subfields_structure.pl
Paul introduced this:
my @kohafield = ''.$input->param('kohafield');
and then:
my $kohafield = $kohafield[$i];
My intuition says it is forcing scalar context on the first assignment
so the list contains a single element and then inside the loop some
$kohafield assignments should lead to undef, and even warnings. I leave
it for a separate patch because it is not that easy testable and is a
sensible area.
Bug 29771: Remove warning from acqui/finishreceive.pl
This patch removes a warning that shows when receiving.
To test:
1. Do the acq workflow up to the receive step.
2. Once you choose the items and click on Finish
=> FAIL: There's a warning in the logs
3. Revert receipt
4. Apply this patch
5. Receive
=> SUCCESS: No more warnings
6. Sign off :-D
Bug 29771: Remove warning from svc/members/add_to_list
To test:
1. Run:
$ tail -f /var/log/koha/kohadev/*-error.log
2. Generate a patron list
3. Perform a patron search that gives you a few
4. Select some, and choose to add them to the list
=> FAIL: The logs show the infamous warn:
CGI::param called in list context from /kohadevbox/koha/svc/members/add_to_list
5. Apply this patch
6. Restart plack and repeat 4
=> SUCCESS: No warn!
7. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:08:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:08:18 +0000
Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131130|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize ---
Created attachment 131188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131188&action=edit
Bug 29771: Scalar context for split
This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:
split /PATTERN/,EXPR,LIMIT
this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.
To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
browser.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:09:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:09:50 +0000
Subject: [Koha-bugs] [Bug 29771] Get rid of CGI::param in list context
warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29771
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #9 from Martin Renvoize ---
Great call!
This fixes all obvious cases and many non-obvious ones too..
No regressions found, lets get this pushed and deal with any further
occurrences as we spot them.
It would be nice to have a QA script test catch new introductions of such
warnings.. but that can be handled outside of this bug.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:13:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:13:55 +0000
Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching
on original id
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128365|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:15:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:15:44 +0000
Subject: [Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching
on original id
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #7 from David Gustafsson ---
I must have accidentally added two different iterations of the same patch, now
it should work.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:16:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:16:02 +0000
Subject: [Koha-bugs] [Bug 29597] Add tomarcplugin option to bulkmarcimport.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29597
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:17:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:17:53 +0000
Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently
between staff interface and API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #129415|0 |1
is obsolete| |
--- Comment #16 from Martin Renvoize ---
Created attachment 131189
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131189&action=edit
Bug 29877: Regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:17:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:17:57 +0000
Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently
between staff interface and API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #129416|0 |1
is obsolete| |
--- Comment #17 from Martin Renvoize ---
Created attachment 131190
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131190&action=edit
Bug 29877: Make POST /holds handle maxreserves correctly
The current implementation doesn't consider the following values for the
syspref: undef and 0.
The tests mistakenly didn't cover them.
To test:
1. Apply the regression tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail, obvious warnings about comparing undefined values
too.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. You can try on Postman as well
=> SUCCESS: Behavior is correct!
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Andrew Fuerste-Henry
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:19:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:19:08 +0000
Subject: [Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently
between staff interface and API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #18 from Martin Renvoize ---
I think we're all in agreement here that this bug fix restores/corrects the
functionality of the API to make it consistent with existing behaviours
elsewhere and that further actions should take place in their own bug.
As such, and as I can't spot any real regressions resulting from this.. Passing
QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:22:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:22:45 +0000
Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on
any page of results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098
--- Comment #4 from Martin Renvoize ---
Created attachment 131191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131191&action=edit
Bug 30098: Only redirect from patron search if single result is on first page
This patch simply adds a check that we are oin the first page (starting at
result 0)
before redirecting to a isngle patron
To test:
1 - Perform a patron search that returns 41 results, on Koha testing docker,
'a' works
2 - Go to second page of results, works
3 - Go to third page of results, redirected to the patron
4 - Apply patch
5 - Repeat search and paging
6 - On third page you remian in results and are not redirected to patron
Signed-off-by: Emmanuel Bétemps
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:23:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:23:17 +0000
Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on
any page of results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Attachment #130626|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:24:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:24:38 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_14772=5D_Remove_or_clarify_checkbox?=
=?utf-8?q?_=C2=ABflagged=C2=BB_on_subfield_visibility_frameworks?=
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14772
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:25:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:25:52 +0000
Subject: [Koha-bugs] [Bug 30098] Patron search redirects when one result on
any page of results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #5 from Martin Renvoize ---
Hmm, just read Jonathans comment.. I think he's right, that's a slightly
cleaner solution with one less test. I'll PQA as there's not real issue with
this code and leave it to the RM to decide which of the two options is
'nicest'... we can always have the solution from bug 30063 once that's worked
it's way through anyway.
PQA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:28:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:28:39 +0000
Subject: [Koha-bugs] [Bug 23347] Columns settings for items in OPAC should
be according to the framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23347
--- Comment #2 from Marjorie Barry-Vila ---
Hi Katrin,
Sorry for the delay!
It's more a question finally, why the Call number column is displayed when the
field is empty? There are columns that are not displayed as soon as the field
is empty, such as the Notes.
Even if in the cataloging framework, the callnumber subfield is not checked for
the visibility in opac, the column is displayed anyway. I think only filled
subfields should appear in the table.
And if that's not possible, then make the Opac box in the cataloging framework
work for the items table.
Regards,
Marjorie
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:32:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:32:14 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - on
each page is Logo but should be page description/title
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:32:19 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:32:19 +0000
Subject: [Koha-bugs] [Bug 27631] Accessibility: Staff interface - on
each page is Logo but should be page description/title
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631
--- Comment #112 from Owen Leonard ---
Created attachment 131192
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131192&action=edit
Bug 27631: (follow-up) Various corrections
This patch addresses issues found during QA:
- Double headings (patron details page)
- Inconsistent heading position (check out, patron accounting)
- Missing headings when there is no data (Library EANs, Item search
fields, MARC modification templates).
- Typo: Z19.50 => Z39.50
- Reword "Classification sources" heading: "Classification
configuration"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:40:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:40:39 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #846 from Marcel de Rooy ---
Created attachment 131193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131193&action=edit
Bug 19532: (QA follow-up) Fix few Koha::Recalls->search occurrences
Due to the wantarray change, we should fix this call in list context.
We should either use an iterator now or append as_list.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:43:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:43:21 +0000
Subject: [Koha-bugs] [Bug 30003] Register entries doubled up if form fails
validation on first submission
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30003
--- Comment #11 from Katrin Fischer ---
Hi Jake, thx for your patch and don't worry about the bugzilla noise, we all do
it :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:48:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:48:16 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #847 from Marcel de Rooy ---
Saw this warning in QA tools:
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt
FAIL valid_template
Attempt to reload Koha/Template/Plugin/KohaPlugins.pm aborted.
Compilation failed in require at
/usr/lib/x86_64-linux-gnu/perl5/5.28/Template/Plugins.pm line 206.
SAME for koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
The reload aborted on Template plugins I have seen incidentally on a few other
reports, where we did spend quite some time to resolve it to no avail.
Eventually they were ignored.
This report does not do anything with the KohaPlugins template plugin. So I
think we can discard it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:49:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:49:32 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #848 from Marcel de Rooy ---
>From code glancing:
Unfinished business?
+ } elsif ( $code eq 'RecallFound' ) {
+ ;
+ } elsif ( $code eq 'RecallNeedsTransfer' ) {
+ ;
+ } elsif ( $code eq 'TransferredRecall' ) {
+ ;
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 16:53:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 15:53:15 +0000
Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin
Response
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517
jmbroust changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jean-manuel.broust at univ-lyo
| |n2.fr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:01:15 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131166|0 |1
is obsolete| |
--- Comment #26 from Martin Renvoize ---
Created attachment 131194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131194&action=edit
Bug 27812: Remove the ability to transmit a patron's plain text password over
email
We should not give libraries the ability to compromise patron accounts,
it is considered a huge security issue and nobody in network security
would never recommend allowing passwords to be transmitted in clear text
over email.
It should simply not be possible to send a patron's password in plain text
via email. As such, we should remove this ability from Koha.
Test Plan:
1) Apply this patch
2) Create a patron to generate the ACCTDETAILS email
3) Note you can no longer transmit the patron's password in the email
Signed-off-by: Amit Gupta
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:01:20 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131167|0 |1
is obsolete| |
--- Comment #27 from Martin Renvoize ---
Created attachment 131195
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131195&action=edit
Bug 27812: Email should send for all new patron as per the syspref description
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:24 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:01:24 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131168|0 |1
is obsolete| |
--- Comment #28 from Martin Renvoize ---
Created attachment 131196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131196&action=edit
Bug 27812: Add DBRev to warn of the change to the account details notice
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:01:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:01:28 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
--- Comment #29 from Martin Renvoize ---
Created attachment 131197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131197&action=edit
Bug 27812: (QA follow-up) Fix atomicupdate
We removed a bit too much from the skeliton here ;)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:04:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:04:25 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |This bugfix/enhancement
release notes| |improves the default
| |security of Koha by
| |removing the pass of the
| |plain text password to the
| |ACCTDETAILS notice on
| |patron creation.
| |
| |WARNING:
| |You will need to update
| |your notice template if you
| |were relying on
| |`<>` in
| |this notice.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:06:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:06:31 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #30 from Martin Renvoize ---
Right, I think we've all agreed now to keep this bug to scope as a security
related issue.
The code works as expected and we've agreed that updating the notices isn't
reliably possible and so a warning should be used instead.
We now have such a warning posted during the database update and added in the
'Text to go in the release notes' field above.
As such, with the QA scripts passing and no nasty regressions found I think we
can safely mark this PQA..
I will now go and QA the dependant bugs and report a new bug for the 'Your
password has been changed' notice I suggested was a good idea here.
PQA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:09:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:09:02 +0000
Subject: [Koha-bugs] [Bug 30204] New: Add subtitle to serial subscription
search
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
Bug ID: 30204
Summary: Add subtitle to serial subscription search
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
On serials-search.pl when one does a serial search the results will display the
title of the connected biblio but it will not display the biblio.subtitle, it
would be handy if it did show the subtitle along with the title.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:11:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:11:54 +0000
Subject: [Koha-bugs] [Bug 18543] Emails for new patron accounts with the
AutoEmailOpacUser preference require to enter password manually
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Resolution|--- |DUPLICATE
Status|NEW |RESOLVED
--- Comment #4 from Martin Renvoize ---
This will be resolved as part of bug 27812 so I'm marking it as a RESOLVED
DUPLICATE.
Further work will take place in bug 17648 to move this notice into the message
queue and then allow for further trigger area's in follow-up bugs.
*** This bug has been marked as a duplicate of bug 27812 ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:11:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:11:54 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |karen at bywatersolutions.com
--- Comment #31 from Martin Renvoize ---
*** Bug 18543 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:14:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:14:52 +0000
Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:14:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:14:54 +0000
Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
--- Comment #1 from Lucas Gass ---
Created attachment 131198
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131198&action=edit
Bug 30204: Add subtitle to serial search results
To test:
1. Make some new serial subscriptions and connect them to biblios that contain
subtitles.
2. Do a serial search that will return your newly created subscription.
3. Notice the subtitle doesn't appear.
4. Apply patch and restart_all
5. Again try step 2.
6. Notice the subtitle appears alongside the title now.
7. Make sure it still sorts that column correctly.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:16:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:16:17 +0000
Subject: [Koha-bugs] [Bug 30204] Add subtitle to serial subscription search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30204
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
Text to go in the| |Adds the biblio.subtitle to
release notes| |the 'Title' column on
| |serial-search.pl.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:29:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:29:08 +0000
Subject: [Koha-bugs] [Bug 30205] New: Add biblio.subtitle to the
subscription-detail.pl page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
Bug ID: 30205
Summary: Add biblio.subtitle to the subscription-detail.pl page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs at lists.koha-community.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
On the subscription-detail page we show the biblio.title, we should also show
the biblio.subtitle, if it exists.
This can be shown both in the h1 heading and on the 'Biblio:' line.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:30:11 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in
notices.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131165|0 |1
is obsolete| |
--- Comment #9 from Martin Renvoize ---
Created attachment 131199
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131199&action=edit
Bug 17648: ACCTDETAILS notice does not show in notices.pl
The ACCTDETAILS notice apparently bypasses message_queue; notices are sent
directly to the linux mail queue.
Test Plan:
1) Apply this patch
2) Create a new patron with an email address
3) Note the patron's ACCTDETAILS notice shows in the patron's messages
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:30:15 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in
notices.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
--- Comment #10 from Martin Renvoize ---
Created attachment 131200
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131200&action=edit
Bug 17648: (QA follow-up) Further code cleaning
We actually have a Koha::Patron method to do all the work of finding the
right patron primary email address for notices.. we can use that here
instead of doing it long hand.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:30:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:30:41 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in
notices.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #11 from Martin Renvoize ---
Great improvement, all works ass expected.. Signing off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:31:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:31:27 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |17648
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
[Bug 17648] ACCTDETAILS notice does not show in notices.pl
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:31:27 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:31:27 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in
notices.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |9097
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
[Bug 9097] 'Welcome mail' for new library users
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:32:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:32:50 +0000
Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
subscription-detail.pl page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:32:53 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:32:53 +0000
Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
subscription-detail.pl page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
--- Comment #1 from Lucas Gass ---
Created attachment 131201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131201&action=edit
Bug 30205: Add subtitle to subscription detail page
To test:
1. Make some new serial subscriptions and connect them to biblios that contain
subtitles.
2. Do a serial search that will return your newly created subscription.
3. Click on one of those subscription to be taken to the subscription detail
page.
4. Look at the main heading (h1) and the "Biblio:" line. Notice there is no
subtitle in either place
5. Apply patch, restart_all, and reload the subscription detail page.
6. You should now see the subtitle on both the main heading (h1) and on the
'Biblio:' line.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:33:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:33:49 +0000
Subject: [Koha-bugs] [Bug 30205] Add biblio.subtitle to the
subscription-detail.pl page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
|ity.org |
Patch complexity|--- |Trivial patch
Text to go in the| |Add the biblio.subtitle to
release notes| |the serial subscription
| |details page.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:34:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:34:45 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
--- Comment #10 from Martin Renvoize ---
Right.. bug 27812 is now PQA and will now send a notice whenever a new patron
is added via the staff client via memberentry.. and bug 17648 is signed off and
moves the notice into the message queue..
Now it's time to come back to this and look at enabling the notice in some
other places, like patron imports, opac registrations (maybe at the
confirmation stage?) etc.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:38:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:38:44 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
--- Comment #32 from Martin Renvoize ---
Bug 25936 already records my request for password change notifications :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:39:01 +0000
Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
|ity.org |.com
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:39:29 +0000
Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=27812
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:39:29 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:39:29 +0000
Subject: [Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's
plain text password over email
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=25936
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:42:38 +0000
Subject: [Koha-bugs] [Bug 30206] New: Notify users if their personal details
change
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30206
Bug ID: 30206
Summary: Notify users if their personal details change
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: dcook at prosentient.com.au, dpavlin at rot13.org,
george at nekls.org, martin.renvoize at ptfs-europe.com,
testopia at bugs.koha-community.org
We should add the option to notify users when their personal details are
updated.
This should allow for detailing the change that has taken place, allowing the
patron to understand what details the library has on record for them.
This is especially useful in the event that someone has compromised an account
and changed the account.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:42:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:42:38 +0000
Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=30206
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:49:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:49:21 +0000
Subject: [Koha-bugs] [Bug 30207] New: Librarians with only "place_holds"
permission can no longer update hold pickup locations
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
Bug ID: 30207
Summary: Librarians with only "place_holds" permission can no
longer update hold pickup locations
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
Bug 29540 increased the flags required to for modreserve.pl, but in doing so
created a situation where a library can select a different pickup location for
a hold, but upon clicking the "Update hold(s)" button, will be logged out due
to having insufficient permissions for modreserve.pl.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:49:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:49:40 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice does not show in
notices.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
--- Comment #12 from Martin Renvoize ---
Created attachment 131202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131202&action=edit
Bug 17648: (QA follow-up) Restore imediate sending of the notice
The original notice was sent using SendAlerts, which triggers
immediately on submission and doesn't wait for the cron task.
This patch restores that immediacy and also fixes a bug in the imports
on the original patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:52:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:52:13 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29005
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:52:13 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:52:13 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=9097
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:53:02 +0000
Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |29005
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
[Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to
patron imports
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:02 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:53:02 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |9097
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097
[Bug 9097] 'Welcome mail' for new library users
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:53:41 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:53:44 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
--- Comment #1 from Kyle M Hall ---
Created attachment 131203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131203&action=edit
Bug 30207: Librarians with only "place_holds" permission can no longer update
hold pickup locations
Bug 29540 increased the flags required to for modreserve.pl, but in doing so
created a situation where a library can select a different pickup location for
a hold, but upon clicking the "Update hold(s)" button, will be logged out due
to having insufficient permissions for modreserve.pl.
Test Plan:
1) Create a librarian with "place_holds" permissions, but not
"modify_holds_priority".
2) Place a hold for a patron
3) Attempt to change the pickup location from request.pl
4) Note you get logged out with a permissions error
5) Apply this patch
6) Restart all the things!
7) Attempt to change the pickup location from request.pl
8) This time it should succeed!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:53:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:53:52 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 17:57:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 16:57:32 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:35:34 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:35:34 +0000
Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:35:38 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:35:38 +0000
Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221
--- Comment #1 from Lucas Gass ---
Created attachment 131204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131204&action=edit
Bug 24221: Move OPACMySummaryNote to HTML customizations in additional-contents
To test:
1- Before applying the patch add some content to the system preference
OPACMySummaryNote
2- Apply patch
3- restart_all and updatedatabase
4. Go to additional-content.pl ( HTML customizations )
5. You should now see your content from the system preference under
OpacMySummaryNote in HTML customizations
6. Try searching for the system preference, OPACMySummaryNote. It has been
removed and you should not be able to find it.
7. Try changing/removing/adding content from OpacMySummaryNote in HTML
customizations
8. Make sure your edits are reflected when you look at the user summary page
Note: The system preference was named OPACMySummaryNote but in to be more
consitent with how we have named other additional_contents I have renamed this
OpacMySummaryNote.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:36:05 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:36:05 +0000
Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference
to news block
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
CC| |lucas at bywatersolutions.com
Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:52:08 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
ByWater Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131203|0 |1
is obsolete| |
--- Comment #2 from ByWater Sandboxes ---
Created attachment 131205
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131205&action=edit
Bug 30207: Librarians with only "place_holds" permission can no longer update
hold pickup locations
Bug 29540 increased the flags required to for modreserve.pl, but in doing so
created a situation where a library can select a different pickup location for
a hold, but upon clicking the "Update hold(s)" button, will be logged out due
to having insufficient permissions for modreserve.pl.
Test Plan:
1) Create a librarian with "place_holds" permissions, but not
"modify_holds_priority".
2) Place a hold for a patron
3) Attempt to change the pickup location from request.pl
4) Note you get logged out with a permissions error
5) Apply this patch
6) Restart all the things!
7) Attempt to change the pickup location from request.pl
8) This time it should succeed!
Signed-off-by: Christopher Brannon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:52:36 +0000
Subject: [Koha-bugs] [Bug 30207] Librarians with only "place_holds"
permission can no longer update hold pickup locations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30207
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |cbrannon at cdalibrary.org
--- Comment #3 from Christopher Brannon ---
Works as described.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 18:52:37 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 17:52:37 +0000
Subject: [Koha-bugs] [Bug 30206] Notify users if their personal details
change
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30206
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:09:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:09:40 +0000
Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level
hold sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:09:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:09:44 +0000
Subject: [Koha-bugs] [Bug 29713] Make item table when placing an item level
hold sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #130864|0 |1
is obsolete| |
--- Comment #12 from Owen Leonard ---
Created attachment 131206
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131206&action=edit
Bug 29713: Make item table when placing an item level hold sortable
This patch modifies the holds page in the OPAC so that users selecting a
specific item to place a hold on can sort the table of items.
This patch also removes some obsolete JavaScript left over from before
Flatpickr.
To test, apply the patch and go to Administration -> Circulation and
fine rules to make sure at least one item type in your system has
"OPAC item level holds" set to "allow."
- Log in to the OPAC as a user who can place holds.
- Search the catalog for items which will accept item-level holds.
- Place a hold on one of the results, and click the "Show more options"
link on the holds page.
- Check the "specific item" radio button.
- A table of items should be displayed. Confirm that the table is
sortable.
- The first entry in the table should be selected.
- Perform the same test when placing a hold on multiple titles.
Confirm that each table of items is sortable.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:07 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:07 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
The Minh Luong changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #121555|0 |1
is obsolete| |
Attachment #121556|0 |1
is obsolete| |
Attachment #121557|0 |1
is obsolete| |
Attachment #121558|0 |1
is obsolete| |
--- Comment #51 from The Minh Luong ---
Created attachment 131207
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131207&action=edit
Bug 27113: ElasticSearch: Autocomplete in input search
Usually the user knows only part of the title of the book or only the name of
the author, etc. When he start search something Koha (ElasticSearch) predicts
the rest of a word or expression which user is typing. Autocomplete predicts
that thanks to index of ElasticSearch.
TEST PLAN
Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
must have all information in his index.
1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
!! APPLY PATCH !!
2. Mapping is good (Intranet -> Catalog -> Search engine configuration
(Elasticsearch) ).
!Recommended 'Reset Mapping' -> 'Yes'
3. In your koha-conf.xml file you must have good for
and version ES
4. Update Preference:
./installer/data/mysql/updatedatabase.pl
If that passe good you can look the lines:
- DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
- Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
elasticsearch
5. After that we can look two options in the preferences:
- IntranetAutocompleteElasticSearch;
- OPACAutocompleteElasticSearch;
4. For add information in the index we must run script for reindexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d
5. Waiting for the end of indexing
6. Go on Preference and find :
- IntranetAutocompleteElasticSearch;
- OPACAutocompleteElasticSearch;
Value "Show" turn on autocomplete.
7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
also).
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:12 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:12 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
--- Comment #52 from The Minh Luong ---
Created attachment 131208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131208&action=edit
Bug 27113: (follow-up) QA Tests
Bug 27113: (follow-up) QA Tests (2)
Bug 27113: (follow-up) Fixup warnings.
TEST PLAN
Important! In this patch we need to do reindex ElasticSearch. ElasticSearch
must have all information in his index.
1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch
!! APPLY PATCH !!
2. Mapping is good (Intranet -> Catalog -> Search engine configuration
(Elasticsearch) ).
!Recommended 'Reset Mapping' -> 'Yes'
3. In your koha-conf.xml file you must have good for
and version ES
4. Update Preference:
./installer/data/mysql/updatedatabase.pl
If that passe good you can look the lines:
- DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl
- Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with
elasticsearch
5. After that we can look two options in the preferences:
- IntranetAutocompleteElasticSearch;
- OPACAutocompleteElasticSearch;
4. For add information in the index we must run script for reindexing:
./misc/search_tools/rebuild_elasticsearch.pl -v -d
5. Waiting for the end of indexing
6. Go on Preference and find :
- IntranetAutocompleteElasticSearch;
- OPACAutocompleteElasticSearch;
Value "Show" turn on autocomplete.
7. Now we have Autocomplete for Intranet/OPAC search input (advanced search
also).
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:16 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
--- Comment #53 from The Minh Luong ---
Created attachment 131209
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131209&action=edit
Bug 27113: (follow-up) Correction with Session
I have changed CGI::Session->new() from CGI::Session->load() for use session.
This condition - 'CGI::Session->load() or die CGI::Session->errstr();'
I am not sure that was good idea to use 'die' in this condition...What do you
think?
Thanks!
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:21 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
--- Comment #54 from The Minh Luong ---
Created attachment 131210
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131210&action=edit
Bug 27113: (follow-up) Move new CSS to main SCSS files
This patch removes the separate CSS files added for the autocomplete
feature and puts them into the "main" SCSS files. I think a separate
file isn't necessary because the amount of CSS it adds is so small.
I've also tweaked the style of the autocomplete menu shown when you use
the arrow keys to navigate through the autocomplete choices. I think the
previous white-on-light-green didn't have enough contrast.
To test you must rebuild the OPAC and staff client CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
Follow the previous test plan, being careful to observe how it
works when the autocomplete menu has been triggered and you use the
arrow keys to navigate through the results.
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:25 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:25 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
--- Comment #55 from The Minh Luong ---
Created attachment 131211
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131211&action=edit
Bug 27113: Rebase and correct autocomplete appearance
Rebase of previous patches and correct the buggy behavior (See "GIF showing
buggy behavior attachment")
Test plan:
1- Search for an item. Notice that the autocomplete functionnality is not
available. (See "Result" attachment)
2- Make sure that you are using Elasticsearch as your searching engine.
(Preference->SearchEngine->ElasticSearch)
3- Apply the patch.
4- Run ./installer/data/mysql/updatedatabase.pl
5- Looks for the following preferences :
- IntranetAutocompleteElasticSearch
- OPACAutocompleteElasticSearch
6- Set their value to show.
7- Rebuild the OPAC and staff client CSS (This step is important because the
autocomplete CSS is moved to the main SCSS file):
Instructions here:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
8- Search for an item and notice that the autocomplete functionnality is now
available.
9- In the staff interface, go in "Search the catalog".
10- Notice that the buggy behavior is now fixed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:49:55 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:49:55 +0000
Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
The Minh Luong changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
CC| |the-minh.luong at inlibro.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 20:51:11 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 19:51:11 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
run during active circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855
Michael Hafen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
--- Comment #14 from Michael Hafen ---
(In reply to Andreas Jonsson from comment #13)
> Using a table lock seems like a crude solution.
>
> Why not use a transaction?
I agree that the table lock is pretty ugly. Honestly, I haven't tested that it
solves the problem either. Think of it, it probably creates a problem where
the accountlines table is locked during circulation. (I just found out that
foreign key tables also get locked, which compounds this problem.)
But a transaction would not prevent multiple threads from changing the same
row, which is what I was trying to catch there.
I'd be fine with going back to Martin's patches. (But a test would still have
to be written. ;) ) Besides, I'm not even using the table locking patch in
production here.
I've moved on from this, so I'll have to dig in a bit to remember what all is
going on, to figure out how much of a problem the 'renewed is still overdue so
new fine' case is. This keys on the issue_id, but maybe that can be changed to
key on the accountlines_id instead; that would be a better solution to this
problem I think.
I'll dig in a bit and see if I can get this to key on the accountlines_id
instead.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:16:22 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 20:16:22 +0000
Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority
search results table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247
--- Comment #9 from Marjorie Barry-Vila ---
(In reply to Samu Heiskanen from comment #8)
> Created attachment 129236 [details] [review]
> Bug 28247: (folow up) Add a MARC preview action to Authority search results
>
> To test:
> 1) Do an authority search
> 2) On Actions button click to see the available actions and click on "MARC
> preview" action.
> 3) A modal window open and confirm that the correct details are shown.
>
> Signed-off-by: Samu Heiskanen
Hi,
I just tested in a sandbox (21.12.00.016)
(https://staff-bz28247.sandbox.bywatersolutions.com/) and 'Marc preview'
appears twice in the Actions menu, is this normal?
Regards
Marjorie
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:17:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 20:17:39 +0000
Subject: [Koha-bugs] [Bug 28247] Add a MARC preview column to to Authority
search results table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28247
--- Comment #10 from Marjorie Barry-Vila ---
Created attachment 131212
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131212&action=edit
Marc preview
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:23:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 20:23:42 +0000
Subject: [Koha-bugs] [Bug 29005] Add support for AutoEmailUser similar to
AutoEmailOpacUser to patron imports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005
Donna changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bwsdonna at gmail.com
--- Comment #5 from Donna ---
I'd like to see this as an option in the system preference as to which new
patrons get the email - batch created, individually created, both, or neither.
There are libraries that will do batch imports that do not want to send an
email to the new users from the batch import, but do still want to send emails
to users that are created individually.
For instance, a public library will want to send emails to users they register
in person, but when they do a batch upload of students to permit them access to
digital resources, they don't want to send welcome emails to the students.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 21:54:23 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 20:54:23 +0000
Subject: [Koha-bugs] [Bug 24574] Broken MARC records cause "invalid data,
cannot decode object" on ISBDdetail and MARCdetail pages.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24574
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 22:38:54 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 21:38:54 +0000
Subject: [Koha-bugs] [Bug 30208] New: Marking an item lost should revert the
waiting status of any associated hold
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30208
Bug ID: 30208
Summary: Marking an item lost should revert the waiting status
of any associated hold
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
If an item is currently Waiting for pickup for a hold, editing that item to
apply a lost status should revert the waiting status of the hold.
To recreate:
- place an item-level hold
- check your item in and confirm the hold
- confirm on waitingreserves.pl that Koha shows the item is waiting for pickup
- confirm on the request.pl that Koha shows the item is waiting for pickup
- edit your item to Lost
- confirm the item now shows as both lost and waiting
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 23:08:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 22:08:16 +0000
Subject: [Koha-bugs] [Bug 30186] ISBD throws error when record is suppressed,
but patron category is not in OpacHiddenItemsExceptions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30186
Fridolin Somers changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #2 from Fridolin Somers ---
Looks like the preference OpacHiddenItems contains 'lost' instead of
'itemlost'.
Fields must be the column names of items DB table.
See https://wiki.koha-community.org/wiki/OpacHiddenItems
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 23:55:31 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 22:55:31 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #849 from Aleisha Amohia ---
Created attachment 131213
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131213&action=edit
Bug 19532: (follow-up) Removing unnecessary code
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:04:41 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 23:04:41 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
--- Comment #850 from Aleisha Amohia ---
Cool I will ignore that warning about KohaPlugins then.
(In reply to Marcel de Rooy from comment #848)
> From code glancing:
> Unfinished business?
>
> + } elsif ( $code eq 'RecallFound' ) {
> + ;
> + } elsif ( $code eq 'RecallNeedsTransfer' ) {
> + ;
> + } elsif ( $code eq 'TransferredRecall' ) {
> + ;
Not unfinished business, I was just copying the similar code above, but I have
removed in latest follow-up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:13:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 23:13:44 +0000
Subject: [Koha-bugs] [Bug 17648] ACCTDETAILS notice doesn't show in the
notices tab in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|ACCTDETAILS notice does not |ACCTDETAILS notice doesn't
|show in notices.pl |show in the notices tab in
| |staff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:44:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 23:44:01 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:44:08 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 23:44:08 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #126413|0 |1
is obsolete| |
--- Comment #66 from Aleisha Amohia ---
Created attachment 131214
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131214&action=edit
Bug 14367: Add MARC record history
This is a proof-of-concept implementation for adding history
support to MARC records. Every time a change is made a complete
copy of the record is stored along with the date/time and user
identity. The changes are listed under each field in the MARC
record editor and can be reverted with a click.
The changes are stored as a JSON array in a new column named
'history' in the database. The array is re-read from the database
before updating the record to prevent old data lingering in
the session from overwriting newer changes made by other users.
If we decide to implement this feature it might be better to
simply create a new table altogether and link it rather than
the clumsy JSON solution. That would eliminate a lot of bulky
code that transforms MARC-KOHA-JSON and back while ensuring
data integrity.
Also, there are plans to add permissions to the MARC records;
this likely requires more complex interactions that will scale
badly with the current JSON solution.
At present, the history is hardcoded to 10 entries.
This can easily be made into a syspref.
The current implementation should probably be refactored
into a 'BiblioHistory' class before deploying.
Documentation of the functions/methods are also needed.
Icon is ugly and needs to be improved.
Sponsored-By: Halland County Library & Catalyst IT
Test plan:
* Update the database, update the schema files, restart services
* Log into Staff interface, search for a title, choose to edit it's MARC
record.
* Chose a MARC field and modify it, press Save.
* Open the MARC editor again for the same title.
* Next to the edited field a new icon should appear, looking like
a clock face with a encircling arrow; the history icon.
* Clicking the icon should open a table showing all changes done
to the record, including value change, date/time and user name.
* Clicking a record in the history log should revert that field to the
clicked value (a previous value)
* Run prove t/db_dependent/BiblioHistory.t and confirm all tests pass
Signed-off-by: David Nind
Signed-off-by: David Nind
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 00:45:51 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Mar 2022 23:45:51 +0000
Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes
on a timeline or per field.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #126414|0 |1
is obsolete| |
--- Comment #67 from Aleisha Amohia ---
Created attachment 131215
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131215&action=edit
Bug 14367: Updated schema files
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:07:26 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:07:26 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
run during active circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855
Michael Hafen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128187|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:20:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:20:15 +0000
Subject: [Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if
run during active circulation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855
--- Comment #15 from Michael Hafen ---
I think I figured out why the code here was the way it was. It has to do with
the possibility of a book being renewed and then becoming overdue again. The
way the code was there would be a second overdue fine added to the account
lines for this second instance of the issue becoming overdue.
With the patches to dropping the status check the second overdue fine would
never get entered since the previous overdue fine would be found instead. And
the table locking patch doesn't lock the table soon enough to fix the
duplication problem. (Which is besides the fact that locking in a long running
process would totally kill the circulation desk.)
Which brings me back to using accountlines_id to find the overdue fine instead
of issue_id. We need to either make sure the fines cron job doesn't run during
circulation hours, or find and use the accountlines_id when pulling the list of
overdues. Those are the best solutions I can think of, either run the script
when things aren't going to change, or make sure the script can find the right
account line in case things change so we don't have a duplicate.
So, I need to either patch cronjobs/fines.pl and C4/Overdues.pm to use
accountlines_id, or patch the cron files to specify when the fines cron job
runs (move some jobs from cron.daily to cron.d).
I prefer patching fines.pl and C4/Overdues.pm, since I can't be sure how long
the cron jobs would run, and some should finish before others start.
Options and alternate solutions welcome.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:45:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:45:49 +0000
Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:47:28 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:47:28 +0000
Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881
--- Comment #12 from Mason James ---
Created attachment 131216
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131216&action=edit
Bug 29881: Remove SQLite2 dependency (follow up)
small follow up patch :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:51:44 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:51:44 +0000
Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131216|0 |1
is obsolete| |
--- Comment #13 from Mason James ---
Comment on attachment 131216
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131216
Bug 29881: Remove SQLite2 dependency (follow up)
will move this patch to a new bug
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:52:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:52:10 +0000
Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #14 from Mason James ---
resolving again
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 02:59:45 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 01:59:45 +0000
Subject: [Koha-bugs] [Bug 30209] New: Upgrade DBD::SQLite2 package to
DBD::SQLite3
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
Bug ID: 30209
Summary: Upgrade DBD::SQLite2 package to DBD::SQLite3
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Packaging
Assignee: koha-bugs at lists.koha-community.org
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
CC: mtj at kohaaloha.com
the DBD::SQLite2 package has been removed in debian-testing, therefor we should
upgrade to DBD::SQLite3 package
only one script uses DBD::SQLite2 (misc/cronjobs/create_koc_db.pl), see BZ-4269
'create_koc_db.pl' can use both sqlite2 and sqlite3, so we can upgrade this
package without a problem
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:01:52 +0000
Subject: [Koha-bugs] [Bug 30209] Upgrade DBD::SQLite2 package to DBD::SQLite3
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com
|ity.org |
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=29881,
| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=4269
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:01:52 +0000
Subject: [Koha-bugs] [Bug 29881] Remove SQLite2 dependency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29881
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=30209
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:01:52 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:01:52 +0000
Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause
problems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=30209
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:15:39 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:15:39 +0000
Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to
'libdbd-sqlite3-perl'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Upgrade DBD::SQLite2 |Upgrade
|package to DBD::SQLite3 |'libdbd-sqlite2-perl'
| |package to
| |'libdbd-sqlite3-perl'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:19:14 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:19:14 +0000
Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to
'libdbd-sqlite3-perl'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
--- Comment #1 from Mason James ---
Created attachment 131217
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131217&action=edit
Bug 30209: Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'
to test...
- apply patch, build and install new package
- build and install new package
- check that libdbd-sqlite3-perl package is installed
note: libdbd-sqlite3-perl package installs DBD::SQLite module, which uses
sqlite3 :)
https://packages.debian.org/stretch/libdbd-sqlite3-perl
https://metacpan.org/pod/DBD::SQLite
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:20:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:20:40 +0000
Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to
'libdbd-sqlite3-perl'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #131217|0 |1
is obsolete| |
--- Comment #2 from Mason James ---
Created attachment 131218
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131218&action=edit
Bug 30209: Upgrade 'libdbd-sqlite2-perl' package to 'libdbd-sqlite3-perl'
to test...
- apply patch, build and install new package
- build and install new package
- check that libdbd-sqlite3-perl package is installed
note: libdbd-sqlite3-perl package installs DBD::SQLite module, which uses
sqlite3 :)
https://packages.debian.org/stretch/libdbd-sqlite3-perl
https://metacpan.org/pod/DBD::SQLite
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:01 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:21:01 +0000
Subject: [Koha-bugs] [Bug 30209] Upgrade 'libdbd-sqlite2-perl' package to
'libdbd-sqlite3-perl'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30209
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:50 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:21:50 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:21:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:21:57 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125380|0 |1
is obsolete| |
--- Comment #135 from Aleisha Amohia ---
Created attachment 131219
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131219&action=edit
Bug 14242: Use ISBN-field to automatically fill out purchase suggestions
Add new jQuery plugin "autofill" which transforms selected element(s)
into search fields for Google Books API and automatically fills
requested fields with search result.
Use in OPAC purchase suggestions to automatically fill out fields when
entering ISBN-number.
Test plan:
1. Run updatedatabase.pl
2. Enable system precference "OPACSuggestionAutoFill"
3. Log into OPAC and go to purchase suggestions page
4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into
the ISBN field and click the 'search google books' button, or unfocus
the field.
5. Title, Author, Publisher, publication year and Item Type fields should now
be filled
automatically.
6. Press "clear form" to undo - should restore all fields that the API pull
filled to empty
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:04 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:22:04 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125381|0 |1
is obsolete| |
--- Comment #136 from Aleisha Amohia ---
Created attachment 131220
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131220&action=edit
Bug 14242: (follow-up) Format copyright date before plugged into form
This patch formats the copyright date so that only the year shows before
plugging the formatted version into the form.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:10 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:22:10 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #125382|0 |1
is obsolete| |
--- Comment #137 from Aleisha Amohia ---
Created attachment 131221
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131221&action=edit
Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:17 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:22:17 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
--- Comment #138 from Aleisha Amohia ---
Created attachment 131222
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131222&action=edit
Bug 14242: (follow-up) Clear all text input fields
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:22:57 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:22:57 +0000
Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase
suggestions (using an Ajax-request)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
--- Comment #139 from Aleisha Amohia ---
(In reply to Victor Grousset/tuxayo from comment #133)
> I can still reproduce easily comment 128 's *f* test on Firefox and Chromium.
>
> I can reproduce c. using Chromium, going in the network dev tab, network
> conditions (wireless icon), network throttling, adding a custom profile with
> 2 seconds of latency.
>
> That 2 second latency allows me to reproduce d. also.
Hopefully latest follow-up addresses the remaining issues!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:31:32 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:31:32 +0000
Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause
problems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269
--- Comment #3 from Mason James ---
>
> ---- Reported by colin.campbell at ptfs-europe.com 2010-02-25 16:18:38 ----
>
> The module DBD::SQLite2 is a requirement at present. CPAN testers matrix
> shows it failing on most linux perls > 5.8.7 it seems to only be used in
> the script
> log misc/cronjobs/create_koc_db.pl which also can now support sqlite3.
> Should it be removed from Makefile.PL and the script commented to that
> affect for anyone wishing to use it?
>
this bug can be closed, due to work in bz-29881
also, DBD::SQLite2 module has been passing tests since 2018-09-29
http://matrix.cpantesters.org/?dist=+DBD%3A%3ASQLite2
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:32:49 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:32:49 +0000
Subject: [Koha-bugs] [Bug 4269] Module DBD::SQLite2 requirement will cause
problems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4269
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:33 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:57:33 +0000
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:40 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:57:40 +0000
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628
Aleisha Amohia changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #118479|0 |1
is obsolete| |
--- Comment #112 from Aleisha Amohia ---
Created attachment 131223
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131223&action=edit
Bug 8628: Updated schema files
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 03:57:47 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 02:57:47 +0000
Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628
--- Comment #113 from Aleisha Amohia ---
Created attachment 131224
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131224&action=edit
Bug 8628: (follow-up) Fix documentation, subroutine calls, filters
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:35:42 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:35:42 +0000
Subject: [Koha-bugs] [Bug 30210] New: Fix typos in cpanfile
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210
Bug ID: 30210
Summary: Fix typos in cpanfile
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Packaging
Assignee: koha-bugs at lists.koha-community.org
Reporter: mtj at kohaaloha.com
QA Contact: testopia at bugs.koha-community.org
CC: mtj at kohaaloha.com
this patch fixes typos in cpanfile
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:39:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:39:15 +0000
Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:39:18 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:39:18 +0000
Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210
--- Comment #1 from Mason James ---
Created attachment 131225
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131225&action=edit
Bug 30210: Fix typos in cpanfile
to test...
- apply patch
- confirm updated versions display correctly in about.pl page
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:40:15 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:40:15 +0000
Subject: [Koha-bugs] [Bug 30210] Fix typos in cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30210
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:42:20 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:42:20 +0000
Subject: [Koha-bugs] [Bug 25920] Add liblocale-codes-perl package to fix
ubuntu-stable (focal)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to oldstable |RESOLVED
--- Comment #23 from Mason James ---
(In reply to Fridolin Somers from comment #22)
> (In reply to Jonathan Druart from comment #21)
> > (In reply to Jonathan Druart from comment #20)
> > > Mason, we need a separate bug report for this last patch. The original one
> > > has been backported already.
> >
> > This is still pending.
> I've created Bug 30084 for that
thanks Frido! this can be closed now
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:42:21 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:42:21 +0000
Subject: [Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084
Bug 30084 depends on bug 25920, which changed state.
Bug 25920 Summary: Add liblocale-codes-perl package to fix ubuntu-stable (focal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25920
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to oldstable |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 05:43:16 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 04:43:16 +0000
Subject: [Koha-bugs] [Bug 28302] Koha does not work with CGI::Compile 0.24
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to oldoldstable |CLOSED
--- Comment #25 from Mason James ---
(In reply to Victor Grousset/tuxayo from comment #24)
> Pushed in 19.11.18-2
thanks Victor, closing :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 06:10:36 2022
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Mar 2022 05:10:36 +0000
Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and
into cpanfile
In-Reply-To: